Felix Weilbach
0d9a6987eb
Merge pull request #3857 from nextcloud/bump-version-3.3.5
...
Bump version to 3.3.5
2021-09-30 13:13:39 +02:00
Felix Weilbach
229bd8a745
Bump version to 3.3.5
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-30 13:10:53 +02:00
Felix Weilbach
2ded349f9c
Merge pull request #3851 from nextcloud/backport/3827/stable-3.3
...
[stable-3.3] Don't log encryption data in release mode
2021-09-30 12:39:33 +02:00
Felix Weilbach
b27eb606ed
Don't log encryption data in release mode
...
We deliver our builds to users with debug logging enabled to have an
easier time finding problems. However, logging all the encryption data
in this loop is too much and should not be done in release mode.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-30 10:23:19 +00:00
Matthieu Gallien
412be77929
Merge pull request #3850 from nextcloud/backport/3832/stable-3.3
...
[stable-3.3] Fix incorrect db name for nextcloud command line client.
2021-09-30 12:10:58 +02:00
alex-z
8d1aa2f38c
Fix review comments + also check against trailing bakslash.
...
Signed-off-by: alex-z <blackslayer4@gmail.com >
2021-09-30 08:55:43 +00:00
alex-z
8233131897
Fix incorrect db name for nextcloud command line client.
...
Signed-off-by: alex-z <blackslayer4@gmail.com >
2021-09-30 08:55:43 +00:00
Nextcloud bot
e7e1114237
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-30 04:15:49 +00:00
Nextcloud bot
25b7f8f1f9
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-29 03:53:11 +00:00
Nextcloud bot
d23264f254
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-28 03:54:36 +00:00
Nextcloud bot
c5099f9134
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-27 03:55:14 +00:00
Nextcloud bot
5295340649
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-26 03:56:16 +00:00
Nextcloud bot
0be98b1610
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-25 03:54:53 +00:00
Nextcloud bot
12557272f7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-24 03:58:39 +00:00
Nextcloud bot
c666592142
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-23 04:12:56 +00:00
Nextcloud bot
bf865f930d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-22 03:57:03 +00:00
Nextcloud bot
9e932c9af9
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-21 03:57:32 +00:00
allexzander
dcc0fa9f9d
Merge pull request #3817 from nextcloud/bump-3.3.4
...
Bump version to 3.3.4
2021-09-20 15:51:07 +03:00
alex-z
26dfa3983f
Bump version to 3.3.4
...
Signed-off-by: alex-z <blackslayer4@gmail.com >
2021-09-20 14:44:22 +02:00
Nextcloud bot
ed99ffaeec
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-20 03:53:21 +00:00
Nextcloud bot
adf8f4bdb2
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-19 03:53:52 +00:00
Nextcloud bot
524eeac107
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-18 03:58:32 +00:00
Nextcloud bot
45830fbf0d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-17 03:53:24 +00:00
Nextcloud bot
ac0cf09335
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-16 03:56:20 +00:00
Nextcloud bot
5c77aacfe9
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-15 03:55:59 +00:00
Matthieu Gallien
cc2548bcc7
Merge pull request #3791 from nextcloud/backport/3773/stable-3.3
...
[stable-3.3] Accept nc scheme in provider page
2021-09-14 18:49:23 +02:00
Felix Weilbach
63aaa8419d
Accept nc scheme in provider page
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-14 14:33:53 +00:00
Nextcloud bot
6db2028725
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-14 04:00:36 +00:00
Nextcloud bot
8dcc0a3cbe
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-13 03:56:12 +00:00
Nextcloud bot
fee7801f98
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-12 03:57:52 +00:00
Nextcloud bot
735179047d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-11 03:54:42 +00:00
Nextcloud bot
1badf7955a
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-10 04:06:13 +00:00
Nextcloud bot
5dd18690a0
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-09 03:54:52 +00:00
Matthieu Gallien
c4b188caee
Merge pull request #3757 from nextcloud/backport/3746/stable-3.3
...
[stable-3.3] prevent infinte recursion when closing a websocket in case of SSL errors
2021-09-07 12:24:45 +02:00
Matthieu Gallien
5dccbbf343
prevent infinte recursion when closing a websocket in case of SSL errors
...
the slots connected to the web socket can be called even during close
and lead to infinite calls to close -> error slot -> close -> ...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-09-07 12:24:10 +02:00
Matthieu Gallien
5ec5e2f03c
Merge pull request #3756 from nextcloud/backport/3750/stable-3.3
...
[stable-3.3] macOS client is not able to do auto updates
2021-09-07 12:23:19 +02:00
Felix Weilbach
62ec748f57
macOS client is not able to do auto updates
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-07 07:43:15 +00:00
Nextcloud bot
d515337e36
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-07 03:55:29 +00:00
Nextcloud bot
8237f0085b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-06 03:54:21 +00:00
Nextcloud bot
7841de3bee
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-05 03:53:55 +00:00
Nextcloud bot
2c3cef1c27
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-04 03:52:09 +00:00
Felix Weilbach
2d54bc4d17
Merge pull request #3742 from nextcloud/bump-3.3.3
...
Bump version to 3.3.3
2021-09-03 11:40:46 +02:00
Felix Weilbach
664ab345fa
Bump version to 3.3.3
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-03 11:39:01 +02:00
Felix Weilbach
2eee656dec
Merge pull request #3739 from nextcloud/backport/3727/stable-3.3
...
[stable-3.3] Only set dav user after login
2021-09-03 11:33:55 +02:00
Felix Weilbach
28c135c26f
Only set dav user after login.
...
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.
It should be enough to set the dav user only after login because the
dav user will never change.
See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839
Fixes #3677
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-03 09:24:08 +00:00
Nextcloud bot
01fdd229ab
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-03 03:55:24 +00:00
Nextcloud bot
c1fefa3251
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-02 03:52:39 +00:00
Nextcloud bot
dcbb7847d0
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-01 03:52:14 +00:00
Nextcloud bot
0ee03468c6
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-31 03:53:32 +00:00
Nextcloud bot
ef7e29a0d8
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-30 03:52:25 +00:00
Nextcloud bot
c19d489852
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-29 03:51:22 +00:00
Nextcloud bot
3e56ebcfff
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-28 04:23:37 +00:00
Nextcloud bot
189ada15fd
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-27 03:53:56 +00:00
Matthieu Gallien
50453d9d7e
Merge pull request #3718 from nextcloud/release-3.3.2
...
Release 3.3.2
2021-08-26 11:08:51 +02:00
Matthieu Gallien
2740fea577
release 3.3.2 version
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-08-26 11:04:41 +02:00
allexzander
02a95b6f57
Merge pull request #3717 from nextcloud/backport/3698/stable-3.3
...
[stable-3.3] Update nextcloudcmd documentation.
2021-08-26 11:01:53 +03:00
allexzander
3aeeeb56ff
Update nextcloudcmd documentation.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-08-26 07:51:51 +00:00
Nextcloud bot
9e6750f3d2
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-26 03:53:38 +00:00
Nextcloud bot
ff38f1cffc
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-25 03:51:33 +00:00
Matthieu Gallien
58f34bd0c6
Merge pull request #3711 from nextcloud/backport/3709/stable-3.3
...
[stable-3.3] support server versions for one year after it is end of life
2021-08-24 17:01:14 +02:00
Matthieu Gallien
44f89224b3
support server versions for one year after it is end of life
...
according to https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-08-24 14:48:33 +00:00
Nextcloud bot
cf8b2c98c7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-24 03:52:28 +00:00
Matthieu Gallien
35b55d7221
Merge pull request #3706 from nextcloud/backport/3621/stable-3.3
...
[stable-3.3] Bugfix/nextcloud cmd dav fix
2021-08-23 17:20:14 +02:00
allexzander
9492defbe2
Use separate arguments for a remote root and do not use dav or webdav in the server's URL
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-08-23 15:11:44 +00:00
Nextcloud bot
8fbc25a0d7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-23 03:49:39 +00:00
Nextcloud bot
c05136ce50
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-22 03:50:11 +00:00
Nextcloud bot
60542aec87
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-21 03:54:46 +00:00
Nextcloud bot
6155b24c60
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-19 03:50:39 +00:00
Matthieu Gallien
3b75cddefb
Merge pull request #3686 from nextcloud/backport/3680/stable-3.3
...
[stable-3.3] Fix macOS app bundle name in packaging scripts
2021-08-18 11:29:45 +02:00
znerol
75307b70c2
Fix macOS app bundle name in packaging scripts
...
Signed-off-by: znerol <lo+github@znerol.ch >
2021-08-18 07:54:02 +00:00
Nextcloud bot
23591f385e
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-18 03:52:40 +00:00
Nextcloud bot
82d8c363c5
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-17 03:53:23 +00:00
Matthieu Gallien
b05d2d791e
Merge pull request #3676 from nextcloud/bugfix/checksumsParseIssue
...
Bugfix/checksums parse issue
2021-08-16 14:08:41 +02:00
Hannah von Reth
4df0ddcbd5
Add workaround for issue discovered in https://github.com/owncloud/core/pull/38304
2021-08-16 13:05:39 +02:00
Hannah von Reth
26ca566428
Make findBestChecksum case insensitive
...
Especially the casing of ADLER32 did not match the server.
2021-08-16 13:05:34 +02:00
Nextcloud bot
21caff6dd5
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-16 03:51:49 +00:00
Nextcloud bot
5d3cd92631
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-15 03:51:24 +00:00
Nextcloud bot
aa8521c70f
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-14 03:53:15 +00:00
Nextcloud bot
1865bc6881
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-13 03:51:38 +00:00
Matthieu Gallien
cd934ba80c
Merge pull request #3656 from nextcloud/backport/3655/stable-3.3
...
[stable-3.3] Return the login name instead of user id
2021-08-12 15:29:22 +02:00
Felix Weilbach
5202df4407
Return the login name instead of user id
...
App password and login name need to match. If authResult() returns the
user id the user id will be stored in webdav_user
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-12 13:17:57 +00:00
Felix Weilbach
99bcf30f77
Merge pull request #3650 from nextcloud/bump-3.3.1
...
Bump to version 3.3.1
2021-08-12 10:36:42 +02:00
Felix Weilbach
56e8561e64
Bump to version 3.3.1
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-12 10:35:11 +02:00
Nextcloud bot
05fef8e463
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-12 03:53:16 +00:00
Matthieu Gallien
6f5c61e442
Merge pull request #3648 from nextcloud/backport/3646/stable-3.3
...
[stable-3.3] Enforce fetching of user id
2021-08-11 18:51:29 +02:00
Felix Weilbach
1e28185ee9
Enforce fetching of user id
...
With the change of commit 3e61bdc431 and
the relase of v3.3.0 users that had their email address used as login
are not able to login anymore. The dav_user should be empty if users
tried to create a account in the meantime. Therefore we fetch the user
id in the case dav_user (and then Account::_davUser) is empty. We then
store the user id in dav_user.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-11 16:43:11 +00:00
Matthieu Gallien
4d7f72e3a1
Merge pull request #3647 from nextcloud/backport/3632/stable-3.3
...
[stable-3.3] Ensure that the users id is used for accessing webdav
2021-08-11 16:58:39 +02:00
Felix Weilbach
6a414d5fb3
Ensure that the users id is used for accessing webdav
...
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#obtaining-the-login-credentials
states that the email address can be used for login but it's not
allowed to use the email address to access webdav.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-11 14:18:35 +00:00
Nextcloud bot
694c6e7214
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-11 03:53:48 +00:00
Nextcloud bot
e0e4e9778b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-10 04:09:05 +00:00
Nextcloud bot
7baa66b83e
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-09 03:53:21 +00:00
Nextcloud bot
301bb2024e
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-08 03:48:27 +00:00
Nextcloud bot
f7fce0100b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-07 03:57:06 +00:00
Nextcloud bot
af894485b4
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-06 04:01:23 +00:00
Nextcloud bot
2fb609fa98
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-05 03:53:30 +00:00
Nextcloud bot
c4627c3c04
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-04 03:53:10 +00:00
Nextcloud bot
5f0e8b8268
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-03 03:52:44 +00:00
Nextcloud bot
99c6bee64b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-02 03:26:03 +00:00
Nextcloud bot
853bfed89a
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-01 03:27:14 +00:00
Nextcloud bot
86dc3fefc8
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-31 03:32:43 +00:00
Nextcloud bot
ea800b638d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-30 03:24:19 +00:00
Matthieu Gallien
a2e69d8574
Merge pull request #3610 from nextcloud/backport/3609/stable-3.3
...
[stable-3.3] Update supported server versions
2021-07-29 12:03:32 +02:00
Felix Weilbach
0178b322f9
Update supported server versions
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-29 10:03:10 +00:00
Felix Weilbach
acf3bf0959
Merge pull request #3607 from nextcloud/bump-version-3.3.0
...
Bump version 3.3.0
2021-07-29 10:40:19 +02:00
Felix Weilbach
49647c6267
Bump version 3.3.0
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-29 10:36:26 +02:00
Matthieu Gallien
0569b2bab3
Merge pull request #3602 from nextcloud/bugfix/crashInAccountDavPath
...
prevent crash in Accont::davPath without credentials
2021-07-29 10:31:48 +02:00
Matthieu Gallien
badb5c1fba
fix review comment
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-29 08:27:53 +00:00
Matthieu Gallien
391935c90f
prevent crash in Accont::davPath without credentials
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-29 08:27:53 +00:00
Nextcloud bot
9808f83913
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-29 03:23:50 +00:00
Matthieu Gallien
ae33a89844
Merge pull request #3595 from ivaradi/remove-groovy
...
Do not build for Groovy
2021-07-28 17:31:42 +02:00
István Váradi
e0697eefa0
Do not build for Groovy
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-07-28 14:46:55 +00:00
Matthieu Gallien
b50851726d
Merge pull request #3599 from nextcloud/update-docs-news
...
Update improvements and news in the documentation
2021-07-28 16:44:47 +02:00
Felix Weilbach
55067c55a7
Update improvements and news in the documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-28 12:59:36 +00:00
Matthieu Gallien
8d5612219c
Merge pull request #3596 from nextcloud/bugfix/main-dialog-dont-constrain-background-size
...
Don't constrain size of hover background
2021-07-28 12:44:39 +02:00
Felix Weilbach
7bb0c588c1
Don't constrain size of hover background
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-28 10:29:04 +00:00
Matthieu Gallien
d5857730d1
Merge pull request #3592 from nextcloud/bugfix/properWebdavUrlOnAccountSetup
...
in wizard always use the correct way to get dav path
2021-07-28 12:27:58 +02:00
Matthieu Gallien
d2133da3ee
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-28 12:27:02 +02:00
Matthieu Gallien
c40d276770
remove dead code around overriding dav path in URL
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-28 12:12:17 +02:00
Matthieu Gallien
77433f7e1d
in wizard always use the correct way to get dav path
...
fixes listing being incorrect when using dav endpoint
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-28 09:45:49 +00:00
Matthieu Gallien
6ac719d74c
Merge pull request #3339 from nextcloud/ci/addCodeCoverage
...
takes ECMCoverageOption from ECM to enable code coverage analysis
2021-07-28 11:43:49 +02:00
Matthieu Gallien
f9bfd8adec
takes ECMCoverageOption from ECM to enable code coverage analysis
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-28 09:26:40 +00:00
Matthieu Gallien
1e91e1bd96
Merge pull request #3586 from nextcloud/bugfix/fix-crash-folder-isSyncRunning
...
Fix crash in Folder::isSyncRunning()
2021-07-28 11:25:17 +02:00
allexzander
88d18fd5f3
Invoke 'bool Folder::isSyncRunning() const' from tests.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-28 08:58:00 +00:00
allexzander
98ae715905
Fix crash in Folder::isSyncRunning()
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-28 08:58:00 +00:00
allexzander
e3ca1f09de
Merge pull request #3594 from nextcloud/bugfix/revert-checksum-mismatch-skip
...
Revert: Added config parameter that allows to bypass checksum validation failure.
2021-07-28 11:55:21 +03:00
allexzander
8122c63ebc
Revert Added config parameter that allows to bypass checksum validation failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-28 07:57:10 +00:00
Nextcloud bot
76308d5155
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-28 03:26:46 +00:00
John Molakvoæ
f5210c893e
Merge pull request #3492 from nextcloud/feat/rebase-template
2021-07-27 14:41:23 +02:00
John Molakvoæ
7c54065ed7
Delete rebase.yml
2021-07-27 10:47:21 +00:00
John Molakvoæ
dd9836ea5f
Create command-rebase.yml
2021-07-27 10:47:21 +00:00
Nextcloud bot
ac6cf3ef96
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-27 03:25:18 +00:00
Nextcloud bot
a87c3f28a2
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-26 03:26:18 +00:00
Nextcloud bot
afac8c384d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-25 03:27:44 +00:00
Nextcloud bot
b628349dc7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-24 03:30:34 +00:00
Valdnet
a4dc7a938a
Merge pull request #3579 from nextcloud/Valdnet-patch-3
...
l10n: Change to uppercase
2021-07-23 09:56:48 +02:00
Valdnet
9dee4b1a7a
Merge branch 'master' into Valdnet-patch-3
2021-07-23 09:07:18 +02:00
Nextcloud bot
2addea18ff
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-23 03:26:47 +00:00
Felix Weilbach
8bbe71c8a2
Merge pull request #3582 from nextcloud/bugfix/make-main-dialog-window
...
Make main dialog normal window when displayed as regular window
2021-07-22 18:06:48 +02:00
Valdnet
bc9d3c5936
l10n: Change to uppercase
2021-07-22 15:47:52 +00:00
Valdnet
7db51e9029
l10n: Change to uppercase
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-07-22 15:47:52 +00:00
Felix Weilbach
a421ebf01c
Make main dialog normal window when displayed as regular window
...
This will enable users to minimize the dialog.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-22 10:34:13 +02:00
allexzander
2e07e93a42
Merge pull request #3581 from nextcloud/bump-version-3.2.82
...
Bump version to 3.3.0-rc2
2021-07-22 10:19:31 +03:00
allexzander
d9a8a7e0ac
Bump version to 3.3.0-rc2
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-22 10:16:37 +03:00
Nextcloud bot
898fb3c6a8
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-22 03:28:31 +00:00
Matthieu Gallien
a8aa035065
Merge pull request #3542 from nextcloud/bugfix/enforce-https-with-flow2
...
Enforce https in flow2 for https connections
2021-07-21 20:34:42 +02:00
Felix Weilbach
302651620b
Use Q_UNUSED instead of commenting out arg names
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Felix Weilbach
3f6bb4a929
Use QStringLiteral instead of plain strings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Felix Weilbach
ee49a7ed52
Fix review comments
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Felix Weilbach
e4f92ad1a1
Enforce https in flow1 and flow2 for https connections
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Matthieu Gallien
15affdbfda
Merge pull request #3498 from nextcloud/bugfix/qml-warnings
...
Fix QML Warnings and create custom component for the activity list
2021-07-21 19:13:00 +02:00
Camila
6886d6213a
Add custom component ActivityItem.
...
That also addresses QML warnings.
Signed-off-by: Camila <hello@camila.codes >
2021-07-21 17:03:26 +02:00
Camila
79dd4f73fe
Fix QML warning: Unable to assign [undefined] to QFont.
...
Signed-off-by: Camila <hello@camila.codes >
2021-07-21 14:46:04 +00:00
Matthieu Gallien
b536b73c97
Merge pull request #3565 from nextcloud/bugfix/fixSlowMenuInSettings
...
do not block account menu: availability checking can be slow
2021-07-21 16:42:35 +02:00
Matthieu Gallien
a8ef8bdcb8
do not block account menu: availability checking can be slow
...
ignore availability that can be very slow to check with CfApi virtual
files plugin
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 12:58:23 +00:00
Matthieu Gallien
45538857cf
Merge pull request #3345 from nextcloud/ci/testAppveyor
...
Ci/test appveyor
2021-07-21 14:12:52 +02:00
Matthieu Gallien
2bf757a657
only run the pipeline for master branch and pull requests
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
bbcfe56cfd
execute automated tests but do not fail if there are errors
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
360118634d
build the nextcloud client and not something else
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
9295bb42d6
update CraftMaster git repository
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
505121f394
upgrade appveyor support to MSVC 2019
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-21 11:33:07 +00:00
allexzander
309e8bd183
Merge pull request #3566 from nextcloud/bugfix/desktop-client-high-cpu-usage-on-auto-update
...
Show custom QDialog instead of QMessageBox when update is ready.
2021-07-21 14:26:11 +03:00
allexzander
801e4ad363
Create QMessageBox on heap when the update is ready. Do not return true from OCUpdater to allow for a proper app::quit
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-21 14:23:43 +03:00
Matthieu Gallien
58cf46f435
Merge pull request #3569 from nextcloud/bugfix/fixPermissionsLog
...
print the real permissions string instead of its address
2021-07-21 10:39:10 +02:00
Matthieu Gallien
1fca07546c
print the real permissions string instead of its address
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 08:25:42 +00:00
Felix Weilbach
9d2cb53cff
Merge pull request #3574 from nextcloud/bugfix/open-main-dialog-gnome-always
...
Open main dialog gnome always
2021-07-21 09:16:01 +02:00
Felix Weilbach
4e95e32791
Call setClosed() on correct Object
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 12:56:00 +02:00
Felix Weilbach
89fea30a3b
Remove Q_INVOKABLE from signals because it's not needed
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 12:55:37 +02:00
Felix Weilbach
e283c166de
Merge pull request #3488 from nextcloud/bugfix/remove-unused-variable
...
Remove unused pushNotifications variable
2021-07-20 11:05:13 +02:00
Felix Weilbach
12bdd8742b
Remove unnused variable
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 07:43:36 +00:00
Felix Weilbach
38467b2e30
Remove unused pushNotifications variable
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 07:43:36 +00:00
Nextcloud bot
e46ac74ba4
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-20 03:27:06 +00:00
Nextcloud bot
07b390fccc
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-18 03:48:19 +00:00
Nextcloud bot
c1b807dbff
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-17 04:08:12 +00:00
Matthieu Gallien
dc452feadd
Merge pull request #3558 from nextcloud/bugfix/userStatusTooLongAccountMenu
...
Bugfix/user status too long account menu
2021-07-16 17:40:22 +02:00
Matthieu Gallien
064f64f06d
fix width of user status message to not overlap other elements
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-16 15:19:20 +00:00
Matthieu Gallien
260e1d77f5
clean indentation in UserLine.qml
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-16 15:19:20 +00:00
Matthieu Gallien
1eca55a386
Merge pull request #3557 from nextcloud/bugfix/userStatusTooLong
...
fix size of the Label with user status
2021-07-16 17:18:03 +02:00
Matthieu Gallien
c2602135ab
fix size of the Label with user status
...
ensure the label width is not higher than the parent to ensure log
string get elided as expected
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-16 13:04:33 +00:00
Matthieu Gallien
b72d1af50a
Merge pull request #3541 from nextcloud/bugfix/use-dav-instead-of-webdav
...
Use dav instead of webdav
2021-07-16 15:03:17 +02:00
Felix Weilbach
3e61bdc431
Use dav instead of webdav
...
Fixes #3342
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-16 12:42:02 +00:00
Matthieu Gallien
545592c472
Merge pull request #3552 from nextcloud/bugfix/remove-request-to-config-for-uservisibleurl
...
Remove request to config for userVisibleURL.
2021-07-16 14:32:36 +02:00
allexzander
de627a9b7c
Remove request to config for userVisibleURL.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-16 06:45:41 +00:00
Nextcloud bot
5fe4784cbc
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-16 03:51:28 +00:00
Matthieu Gallien
ff4f4255b3
Merge pull request #3548 from nextcloud/bugfix/screenshots
...
Update screenshot in README.md
2021-07-15 19:04:01 +02:00
Felix Weilbach
c00f871b95
Update screenshot in README.md
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-15 15:33:17 +00:00
Felix Weilbach
3a99010cdb
Remove unused screenshots
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-15 15:33:17 +00:00
Nextcloud bot
d9246910b4
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-15 12:15:40 +00:00
Nextcloud bot
387bb29cbd
[tx-robot] updated from transifex
2021-07-15 09:30:49 +00:00
Felix Weilbach
318d82720f
Merge pull request #3554 from nextcloud/bump-version-3.2.81
...
Bump version to 3.3.0-rc1
2021-07-15 10:44:35 +02:00
Felix Weilbach
88fdfe1c72
Bump version to 3.3.0-rc1
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-15 10:28:26 +02:00
Nextcloud bot
1e6fd98b3e
[tx-robot] updated from transifex
2021-07-15 03:54:45 +00:00
Felix Weilbach
41e3b81abf
Merge pull request #3540 from nextcloud/bugfix/position-tray-dialog-correct
...
Position main dialog on at tray icon if not a regular window
2021-07-14 20:24:47 +02:00
Felix Weilbach
036db9d22d
Position main dialog on at tray icon if not a regular window
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-14 18:27:50 +02:00
allexzander
6bc6dcd598
Merge pull request #3547 from nextcloud/bugfix/nextcloud-overlay-identifiers-not-visible
...
Windows. Nextcloud Overlay Identifiers. Set 16 spaces before each identifier's name.
2021-07-14 18:18:47 +03:00
allexzander
871210326f
Windows. Nextcloud Overlay Identifiers. Set 16 spaces before each identifier's name.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-14 16:15:02 +03:00
Nextcloud bot
4342082414
[tx-robot] updated from transifex
2021-07-14 03:53:15 +00:00
Nextcloud bot
0d454e7cf8
[tx-robot] updated from transifex
2021-07-13 03:53:15 +00:00
Felix Weilbach
7e5f080e58
Merge pull request #3468 from nextcloud/feature/main-dialog-regular-window-when-no-tray-icon
...
Show main dialog as normal window if tray icons not available
2021-07-12 16:18:58 +02:00
Felix Weilbach
efaccbd6fd
Show main dialog as normal window if tray icons not available
...
Fixes #3307
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-12 14:10:26 +00:00
Felix Weilbach
bffcf8e482
Merge pull request #3537 from nextcloud/ci/fixMacCompilation
...
only compile xattr virtual files backend for linux platform (not unices)
2021-07-12 15:46:57 +02:00
Matthieu Gallien
2ee26bbd59
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-12 14:31:19 +02:00
Matthieu Gallien
7c68408ee1
only compile xattr virtual files backend for linux platform (not unices)
...
for a reason a mac os platform specific file is missing and before xattr
plugin was compiled only for linux
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-12 14:10:54 +02:00
Felix Weilbach
b7a37a526a
Merge pull request #3536 from nextcloud/bugfix/remove-app-icon-png-files
...
Remove unnecessary png files
2021-07-12 13:51:03 +02:00
Felix Weilbach
589037bd43
Remove unnecessary png files
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-12 12:47:29 +02:00
Nextcloud bot
dce11c3c64
[tx-robot] updated from transifex
2021-07-12 03:51:01 +00:00
Nextcloud bot
107a3e9ebe
[tx-robot] updated from transifex
2021-07-11 03:52:10 +00:00
Nextcloud bot
d15a06cc17
[tx-robot] updated from transifex
2021-07-10 04:05:37 +00:00
Matthieu Gallien
61cd132c53
Merge pull request #3523 from nextcloud/bugfix/recoverSyncDbNonVirtualFile
...
avoid being stuck trying to create placeholder for existing file
2021-07-09 16:36:57 +02:00
Matthieu Gallien
d2f2e3305a
avoid being stuck trying to create placeholder for existing file
...
id sync db think a file is cirtual (empty placeholder) but file system
has a real file (non empty file) once the server has a modified version
we can no longer update it
state of file on disk takes precedence over sync DB to allow recovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-09 12:37:47 +00:00
Nextcloud bot
4a8dba90c2
[tx-robot] updated from transifex
2021-07-09 03:54:31 +00:00
Matthieu Gallien
d6b9ff9436
Merge pull request #3437 from nextcloud/feature/dynamicLoadVfsPlugins
...
bring back dynamic load of VFS plugins
2021-07-08 10:20:39 +02:00
Felix Weilbach
7094d699e9
Allow installation on Windows version < 1709
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-08 08:11:17 +00:00
Matthieu Gallien
8ad6f89fed
bring back dynamic load of VFS plugins
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-08 08:11:17 +00:00
Nextcloud bot
fe925d8f36
[tx-robot] updated from transifex
2021-07-08 03:55:04 +00:00
Nextcloud bot
2bbce75f10
[tx-robot] updated from transifex
2021-07-07 03:53:20 +00:00
Matthieu Gallien
4848f9577b
Merge pull request #3501 from nextcloud/bugfix/fixImplicitHydration
...
avoid error when doing hydration when data socket is closed too early
2021-07-06 16:25:55 +02:00
Matthieu Gallien
c123edb173
address review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-06 14:16:43 +00:00
Matthieu Gallien
4016c2fab0
avoid error when doing hydration when data socket is closed too early
...
when data is received, if we close the socket they cannot be read
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-06 14:16:43 +00:00
Matthieu Gallien
c1f0716d53
Merge pull request #3511 from nextcloud/bugfix/vfsFixes
...
Improve the error message returned by updateMetadata
2021-07-06 16:15:26 +02:00
Hannah von Reth
e7e218d8e6
Improve the error message returned by updateMetadata
...
Also properly handle the case the the file can't be converted to a placeholder
as it is locked
2021-07-06 14:03:53 +00:00
Nextcloud bot
e852c51675
[tx-robot] updated from transifex
2021-07-06 03:54:28 +00:00
Nextcloud bot
fac98e0f3d
[tx-robot] updated from transifex
2021-07-05 03:51:11 +00:00
Nextcloud bot
f396de5518
[tx-robot] updated from transifex
2021-07-04 03:50:57 +00:00
Nextcloud bot
aefec6137c
[tx-robot] updated from transifex
2021-07-03 03:51:48 +00:00
Matthieu Gallien
f42639e6ce
Merge pull request #3486 from nextcloud/bugfix/improveInvalidFileNameMessage
...
improve error message in case of trailing space in directory name
2021-07-02 13:00:05 +02:00
Matthieu Gallien
8f5b88acd5
improve error message in case of trailing space in directory name
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-02 10:50:31 +00:00
Matthieu Gallien
ddff9a5268
Merge pull request #3502 from nextcloud/bugfix/fixCfApiLogs
...
fix all usage of _com_error(cfExecuteresult).ErrorMessage()
2021-07-02 12:46:59 +02:00
Matthieu Gallien
746072e95d
fix all usage of _com_error(cfExecuteresult).ErrorMessage()
...
_com_error(cfExecuteresult).ErrorMessage() calls should be translated to
QString before use with qDebug and related logging facilities
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-02 11:19:04 +02:00
Nextcloud bot
c31020528e
[tx-robot] updated from transifex
2021-07-02 03:53:06 +00:00
Matthieu Gallien
d625f3fc30
Merge pull request #3494 from nextcloud/bugfix/checkServerPublicKey
...
download server public key and check user certificate against it
2021-07-01 19:04:13 +02:00
Matthieu Gallien
2bc72592a0
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-01 14:40:25 +02:00
Matthieu Gallien
698d5f19ba
download server public key and check user certificate against it
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-01 14:07:27 +02:00
allexzander
dca7b8d8d2
Merge pull request #3449 from nextcloud/bugfix/fix-vfs-crash-and-false-conflict-on-local-new
...
Fix VFS crash and false conflict on local new.
2021-07-01 13:33:21 +03:00
allexzander
99f6e82290
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
6ce5279b6c
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
22eba41cb8
Do not process non-directories and non-virtual files. Wipe empty online-only folder based on its pinState.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
c5982143aa
Refactoring.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
48aefc1983
Fix VFS crash and false conflict on local new.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:20 +03:00
Matthieu Gallien
80267adb3a
Merge pull request #3497 from nextcloud/bugfix/run-legacy-uninstall-in-a-secure-way
...
Run legacy uninstall exe in a secure way
2021-06-30 16:18:19 +02:00
allexzander
860514f01b
Run legacy uninstall exe in a secure way.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-30 11:58:13 +00:00
Matthieu Gallien
d9a634223a
Merge pull request #3472 from nextcloud/feature/cacheQmlImages
...
directly send the icon url for activities to the qml component
2021-06-30 13:49:30 +02:00
Matthieu Gallien
c27fc1be4a
use fallback icons for activities without icons
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-30 11:28:13 +00:00
Matthieu Gallien
269d225511
directly send the icon url for activities to teh qml component
...
should allow usage of default cache from Image qml standard component
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-30 11:28:12 +00:00
Matthieu Gallien
2a0b6f38b5
Merge pull request #3333 from nextcloud/bugfix/check-if-first-is-empty
...
Check if first is not empty
2021-06-30 09:29:01 +02:00
Felix Weilbach
c9715db720
Check if first is not empty
...
If it's not checked that first is empty, crashes may happen.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-30 06:57:41 +00:00
Nextcloud bot
e5b4fc2769
[tx-robot] updated from transifex
2021-06-30 03:53:48 +00:00
Nextcloud bot
acd98403bb
[tx-robot] updated from transifex
2021-06-29 03:52:40 +00:00
Nextcloud bot
e861fbdb2b
[tx-robot] updated from transifex
2021-06-28 03:56:09 +00:00
Nextcloud bot
7095559639
[tx-robot] updated from transifex
2021-06-27 03:53:57 +00:00
Nextcloud bot
208f0bfec1
[tx-robot] updated from transifex
2021-06-26 03:52:55 +00:00
Matthieu Gallien
cce894618e
Merge pull request #3489 from nextcloud/bugfix/design-call
...
Design call improvements
2021-06-25 23:32:03 +02:00
Felix Weilbach
015a5ae235
Don't display account name in italic
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 20:13:06 +00:00
Felix Weilbach
ae7269e156
Use Material icons for general and network settings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 20:13:06 +00:00
Felix Weilbach
fd7666100a
Merge pull request #3490 from nextcloud/bugfix/update-documentation
...
Update documentation and replace old screenshots
2021-06-25 22:11:16 +02:00
Felix Weilbach
166638b87f
Update navigating section in documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 17:40:54 +00:00
Felix Weilbach
2c556857e0
Update visual tour in documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 17:40:53 +00:00
Felix Weilbach
0a19a2996e
Update system requirements in documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 17:40:53 +00:00
Felix Weilbach
90244380aa
Merge pull request #3460 from nextcloud/feature/unit-test-move-custom-root
...
Add unit test for move custom remote root
2021-06-25 12:32:48 +02:00
Felix Weilbach
2ee3ca02a4
Add unit test for move custom remote root
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 10:14:29 +00:00
Nextcloud bot
c286b62e60
[tx-robot] updated from transifex
2021-06-25 03:54:15 +00:00
Felix Weilbach
0c8ed85156
Merge pull request #3471 from nextcloud/feature/build-without-webengine
...
Build optional without QWebEngine
2021-06-24 20:54:16 +02:00
Felix Weilbach
40065dc6dc
Disable QtWebEngine automatic if not found
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
Felix Weilbach
991f79c123
Open provider page in browser when compiling without webengine
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
Felix Weilbach
8376b99ec5
Allow to compile without QWebEngine
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
Felix Weilbach
216a57c74e
Remove dead code
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
István Váradi
ad3b48c2c5
Merge pull request #3475 from ivaradi/use-full-gpg-keyid
...
Use the full GPG key ID for signing Debian packages
2021-06-24 16:20:16 +02:00
István Váradi
f69c595103
Use the full GPG key ID for signing Debian packages
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-06-24 12:01:29 +00:00
Nextcloud bot
db1357088d
[tx-robot] updated from transifex
2021-06-24 03:54:09 +00:00
Nextcloud bot
e19ce76e86
[tx-robot] updated from transifex
2021-06-23 03:54:55 +00:00
Nextcloud bot
df6abd5c97
[tx-robot] updated from transifex
2021-06-22 03:56:27 +00:00
István Váradi
363df3b718
Merge pull request #3464 from ivaradi/add-impish
...
Add building for Ubuntu Impish
2021-06-21 17:35:00 +02:00
István Váradi
c27782279e
Add building for Ubuntu Impish
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-06-21 17:23:34 +02:00
Felix Weilbach
616725f016
Merge pull request #3369 from nextcloud/bugfix/dont-crash-e2ee-vfs-dialog-on-folder-delete
...
Prevent crash in dialog that warns user about vfs and e2ee
2021-06-21 12:24:31 +02:00
Felix Weilbach
cb5e8398c4
Fix review comment
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-21 12:04:11 +02:00
Felix Weilbach
ab9784374f
Fix review comments
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-21 12:04:11 +02:00
Felix Weilbach
52342e5710
Prevent crash in dialog that warns user about vfs and e2ee
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-21 12:04:03 +02:00
Nextcloud bot
f720e6484d
[tx-robot] updated from transifex
2021-06-21 03:57:59 +00:00
Nextcloud bot
e13731691f
[tx-robot] updated from transifex
2021-06-20 03:58:10 +00:00
Nextcloud bot
404920c4ce
[tx-robot] updated from transifex
2021-06-19 04:21:10 +00:00
Nextcloud bot
636e7159c7
[tx-robot] updated from transifex
2021-06-18 04:02:20 +00:00
Felix Weilbach
959e450d60
Merge pull request #3337 from nextcloud/Valdnet-patch-4
...
l10n: Spelling unification
2021-06-17 15:11:18 +02:00
Valdnet
3937595eef
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-06-17 12:18:00 +00:00
Valdnet
33bdfe687f
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-06-17 12:18:00 +00:00
Felix Weilbach
dfab4bb447
Merge pull request #3445 from nextcloud/bugfix/remove-unused-function
...
Remove unused function declaration
2021-06-17 14:16:21 +02:00
Felix Weilbach
27f8152b05
Remove unused function declaration
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-17 11:22:57 +00:00
Felix Weilbach
6e41875fe1
Merge pull request #3420 from nextcloud/bugfix/cfapi-improve-cancellation
...
Cfapi: Make sure no data is transfered after cancellation
2021-06-17 11:46:13 +02:00
Felix Weilbach
c799dbdd61
Cfapi: Make sure no data is transfered after cancellation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-17 09:10:06 +00:00
Felix Weilbach
e6e4bfb9c6
Merge pull request #3397 from nextcloud/feature/enable-clazy-drone
...
Enable clazy in drone
2021-06-17 09:58:29 +02:00
Felix Weilbach
3e3c124af1
Enable clazy in drone
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-17 09:47:00 +02:00
Nextcloud bot
3e77ae0c1e
[tx-robot] updated from transifex
2021-06-17 03:59:19 +00:00
Matthieu Gallien
08fa88e182
Merge pull request #3370 from nextcloud/fix/filesFixesForWindowsAndLogs
...
Fix/files fixes for windows and logs
2021-06-16 15:36:47 +02:00
Hannah von Reth
22c634935b
Run expansive assert only in dev builds
2021-06-16 10:54:07 +00:00
Hannah von Reth
03182ea714
Use longWinPath in more places
2021-06-16 10:54:07 +00:00
Hannah von Reth
d014293f6d
Ensure pathtoUNC is called with an absolute path
2021-06-16 10:54:06 +00:00
Camila
9ea8dd95f8
Merge pull request #3388 from nextcloud/bugfix/qml-warnings
...
Bugfix/qml warnings
2021-06-16 10:40:37 +02:00
Camila
7ddc4ca170
Remove extra RowLayout.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
449fda16e1
Fix QML Warning: ReferenceError: PopupMenu is not defined.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
f3c17c747a
Fix compiling warning: multiple definitions of stateOnlineImageSource in theme.h.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
19e581657d
Fix QML warning: Cannot specify left, right... anchors for items inside Row.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
5585f61cc0
Fix QML warning: Detected anchors on an item that is managed by a layout.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
c8edb11228
Fix QML warning: Accessible must be attached to an Item.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Nextcloud bot
73d244cd9c
[tx-robot] updated from transifex
2021-06-16 03:57:33 +00:00
Felix Weilbach
ed6a5c66b3
Merge pull request #3404 from nextcloud/bugfix/macos-set-bundle-name-correct
...
Start macOS app bundle name with uppercase letter
2021-06-15 14:33:35 +02:00
Felix Weilbach
7850551cad
Start macOS app bundle name with uppercase letter
...
It's a convention on macOS that app bundle names start with an uppercase
letter. Also this aligns the app name with Windows and Linux.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-15 12:19:55 +00:00
allexzander
ce54a98f7d
Merge pull request #3425 from nextcloud/bugfix/vfs-wipe-moved-folder-when-conflict
...
VFS wipe moved folder when conflict
2021-06-15 14:50:17 +03:00
allexzander
a3d12a616b
Add error message to GUI.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-15 14:33:45 +03:00
allexzander
6312f6ddde
Wipe empty folder when moving a VFS placeholder. Keep a folder if there are hydrated items inside.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-15 13:19:35 +03:00
Felix Weilbach
3542d171f1
Merge pull request #3432 from nextcloud/bugfix/set-pin-state-correct-after-rename
...
Set pin state correct after rename
2021-06-14 15:49:30 +02:00
Felix Weilbach
a89a84ff14
Mark placeholder in sync after updating the placeholder
...
Fixes #3403 #3082 #3391
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-14 13:40:26 +00:00
Felix Weilbach
befca65b91
Merge pull request #3395 from nextcloud/bugfix/use-svg-icon-for-app-sidebar-macos
...
Generate png icons with inkscape
2021-06-14 12:30:05 +02:00
Felix Weilbach
d4b0273792
Generate application png icons from svg icons
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-14 10:14:28 +00:00
Felix Weilbach
e7c65a71b8
Remove conditional logic for OEM.cmake
...
This file is not used in Brander and in the desktop client and just
confused people.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-14 10:14:28 +00:00
Nextcloud bot
ec521e1d4c
[tx-robot] updated from transifex
2021-06-13 03:56:20 +00:00
Nextcloud bot
290ca44c36
[tx-robot] updated from transifex
2021-06-12 03:57:20 +00:00
Nextcloud bot
ddd0c712ef
[tx-robot] updated from transifex
2021-06-11 04:02:39 +00:00
allexzander
7e3b366a89
Merge pull request #3401 from nextcloud/bugfix/checksum-mismatch-download-error
...
Added config parameter that allows to bypass checksum validation failure
2021-06-10 13:52:40 +03:00
allexzander
dc72686ab3
Allow download with mismatched checksum if a config option is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-10 13:39:11 +03:00
Nextcloud bot
407817fdb4
[tx-robot] updated from transifex
2021-06-10 04:13:11 +00:00
Nextcloud bot
470a89dfae
[tx-robot] updated from transifex
2021-06-09 04:02:04 +00:00
allexzander
c59e3c440c
Merge pull request #3390 from nextcloud/bugfix/syncexclude-dehydration-freeze
...
VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always.
2021-06-08 12:44:15 +03:00
allexzander
d6ddf595f8
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
allexzander
5dd310c21c
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
allexzander
b150de9106
Fix review comments. Also consider exclude.lst.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
allexzander
bb55232e8e
VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
Matthieu Gallien
1951eec009
Merge pull request #3394 from nextcloud/ci/fixNeedsInfoHelperAction
...
really fix the actions to remove needsinfo when someone comment
2021-06-08 11:00:09 +02:00
Matthieu Gallien
c51815f8ad
use upper case name for the github token access
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-08 08:50:51 +00:00
Matthieu Gallien
149b1317e7
really fix the actions to remove needsinfo when someone comment
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-08 08:50:51 +00:00
Nextcloud bot
de632d7397
[tx-robot] updated from transifex
2021-06-08 04:03:16 +00:00
Felix Weilbach
e62453dc66
Merge pull request #3410 from nextcloud/bugfix/check-against-cmake-cxx-compiler-id
...
Check compiler against CMAKE_CXX_COMPILER_ID
2021-06-07 15:44:16 +02:00
Felix Weilbach
74b2c5761d
Check compiler against CMAKE_CXX_COMPILER_ID
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-07 15:18:03 +02:00
Nextcloud bot
60469f45ff
[tx-robot] updated from transifex
2021-06-07 03:59:09 +00:00
Nextcloud bot
d4c2991b9d
[tx-robot] updated from transifex
2021-06-06 04:00:46 +00:00
Nextcloud bot
38afea3353
[tx-robot] updated from transifex
2021-06-05 04:03:45 +00:00
Nextcloud bot
d06998a46b
[tx-robot] updated from transifex
2021-06-04 04:08:20 +00:00
Matthieu Gallien
62656b093a
Merge pull request #3368 from nextcloud/strugee-patch-1
...
Improve error message
2021-06-03 14:22:47 +02:00
AJ Jordan
a51d0a14db
Improve error message
...
This one is more user-friendly and grammatically correct.
Signed-off-by: AJ Jordan <alex@strugee.net >
2021-06-03 11:25:47 +00:00
Felix Weilbach
83498c30e2
Merge pull request #3380 from uusijani/patch-1
...
Document --background
2021-06-02 21:37:08 +02:00
Jani Uusitalo
f4b1ba45b8
Document --background
...
Fix [#3374 ](https://github.com/nextcloud/desktop/issues/3374 ).
Signed-off-by: Jani Uusitalo <jani@mummila.net >
2021-06-02 21:22:59 +03:00
allexzander
e4553252e0
Merge pull request #3393 from nextcloud/feature/unit-tests-for-isPathWindowsDrivePartitionRoot
...
Added unit tests for Utility::isPathWindowsDrivePartitionRoot.
2021-06-02 10:58:37 +03:00
allexzander
fe9f934277
Added unit tests for Utility::isPathWindowsDrivePartitionRoot.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-02 10:30:27 +03:00
Nextcloud bot
0944468ed9
[tx-robot] updated from transifex
2021-06-02 04:02:19 +00:00
allexzander
da586b719c
Merge pull request #3352 from nextcloud/bugfix/openssl-crash-when-no-e2ee-mnemonic
...
Bugfix. Crash when printing OpenSSL decryption errors with no e2ee mnemonic,
2021-06-01 17:48:03 +03:00
Matthieu Gallien
6b20092017
Merge pull request #3386 from nextcloud/ci/fixNeedsInfoHelperAction
...
fix needs info label remover action by providing github token
2021-06-01 16:17:16 +02:00
allexzander
bf39f053c4
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-01 13:51:02 +00:00
allexzander
a80c58f367
Bugfix. Crash when printing OpenSSL decryption errors with no e2ee mnemonic.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-01 13:51:02 +00:00
Matthieu Gallien
8b98dfcabb
fix needs info label remover action by providing github token
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-01 09:35:19 +02:00
Nextcloud bot
65a92e746a
[tx-robot] updated from transifex
2021-06-01 04:02:08 +00:00
Nextcloud bot
8abd4ce948
[tx-robot] updated from transifex
2021-05-30 04:00:14 +00:00
Nextcloud bot
5ef031d219
[tx-robot] updated from transifex
2021-05-29 04:16:47 +00:00
Nextcloud bot
7286e71c3a
[tx-robot] updated from transifex
2021-05-28 04:03:59 +00:00
Matthieu Gallien
b07f855976
Merge pull request #3341 from nextcloud/ci/needsInfoHelper
...
automate removal of needs info labels when the issue is commented
2021-05-27 10:16:13 +02:00
Matthieu Gallien
dbeba16919
ensure we do not remove needs info label when stale bot comment
...
we could have an issue with bug and needs info label
when it is detected as staled by the bot, a comment is added
we should ensure that the automated comment is not taken as answer to
the needs info
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-05-27 08:06:53 +00:00
Matthieu Gallien
a9aef22acb
remove use of checkout action as per review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-05-27 08:06:53 +00:00
Matthieu Gallien
b327522670
automate removal of needs info labels when the issue is commented
...
should help handling needs info label in a more efficient way
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-27 08:06:53 +00:00
Matthieu Gallien
e0b1ff95e4
Merge pull request #3364 from nextcloud/ci/needsInfoStaleBotConflicts
...
use a specific stale label for needs info handling to solve conflict
2021-05-27 10:04:20 +02:00
Matthieu Gallien
92146b0c8d
use a specific stale label for needs info handling to solve conflict
...
each stale bot needs to have its own stale label such that it does not
remove the label added by the other bot
that can happen due to needs info bot removing stale label on issues
that have both bug and needs info labels
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-05-27 07:46:59 +00:00
Matthieu Gallien
a807263ce3
Merge pull request #3346 from nextcloud/bugfix/e2ee-warning-vfs-dialog
...
Set button on QMessageBox before changing the text
2021-05-27 09:45:13 +02:00
Felix Weilbach
03610cb706
Set button on QMessageBox before changing the text
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-27 07:39:50 +00:00
Matthieu Gallien
ba5f517417
Merge pull request #3338 from nextcloud/bug/checkPublicPrivateKey
...
check e2ee public key against private one
2021-05-27 09:38:12 +02:00
Matthieu Gallien
7fb09a8163
check e2ee public key against private one
...
should ensure we have matching private/public keys
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-27 07:26:48 +00:00
Nextcloud bot
2c1644e676
[tx-robot] updated from transifex
2021-05-27 04:01:51 +00:00
Felix Weilbach
d3e07e8f57
Merge pull request #3344 from nextcloud/bugfix/remove-obsolete-add-app-icon-macro
...
Remove obsolete AddAppIconMacro
2021-05-26 11:10:31 +02:00
Felix Weilbach
cf616abc46
Remove obsolete AddAppIconMacro
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-26 08:54:12 +00:00
Matthieu Gallien
f171eec278
Merge pull request #3330 from nextcloud/ci/updateQtVersionsInCi
...
update most docker images to use Qt 5.12.10 in Drone
2021-05-26 10:49:18 +02:00
Matthieu Gallien
9144ece89d
update most docker images to use Qt 5.12.10 in Drone
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-26 08:18:35 +00:00
Nextcloud bot
01f432cf67
[tx-robot] updated from transifex
2021-05-26 04:05:48 +00:00
Camila
5d2cfd8429
Merge pull request #3182 from nextcloud/bugfix/user-status
...
Bugfix/user status
2021-05-25 09:45:05 +02:00
Camila
f758157973
Fix aligment emoji + message on Windows.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
8d2264e027
Display the user status emoji separated from the message.
...
It allows to align the emoji with the message.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
1cb7f63575
Remove signal refreshCurrentUserGui.
...
Use only QML property bindings to refresh the UI.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
46f7cd3884
User property isConnected instead of a invokable.
...
Remove unnecessary connection to refreshCurrentUserGui signal.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
1adde8d547
serverUserStatus => serverHasUserStatus.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
2caa9ccfc6
Add Q_UNREACHABLE() after switch statements in UserStatus.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
73da14040b
Rename ServerUserStatusRole to ServerHasUserStatusRole.
...
- serverHasUserStatus Q_PROPERTY is CONSTANT.
- Fix code style.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
828881d82a
Do not display the folder status if there are no folders being synced.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
4326eb53ba
Fix margins and sizes to align both avatar + user status displays.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
dc01b76066
Fix code style.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
93227ab08b
Check if new value is different from the current one.
...
In AccountState::setDesktopNotificationsAllowed.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
f7e9e31bc9
Rename isDesktopNotificationsAllowed property to desktopNotificationsAllowed.
...
- User !== instead of !=.
- Fix code style.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
820e97cd9b
Do not display the user status if there is no pre defined message.
...
Display the server url instead.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
c793cbe593
Always display the server url in the drop down account menu.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
419595ce5e
Use DesktopNotificationsAllowedRole to check if user is online.
...
Rename ServerUserStatus to ServerUserStatusRole.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
bd65eee278
Remove unused methods in UserModel.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
671b099c98
Check if the user is connected and if the server supports user status.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
e3b96ddc85
Move stringToEnum and enumToString to an anonymous namespace.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
1f61d258bb
Fix user status message alignment.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Nextcloud bot
c684191a2d
[tx-robot] updated from transifex
2021-05-25 04:05:36 +00:00
Nextcloud bot
755d672476
[tx-robot] updated from transifex
2021-05-24 03:58:58 +00:00
Nextcloud bot
e59413edc3
[tx-robot] updated from transifex
2021-05-23 04:00:59 +00:00
Nextcloud bot
97103da677
[tx-robot] updated from transifex
2021-05-22 04:04:35 +00:00
Nextcloud bot
30b7803661
[tx-robot] updated from transifex
2021-05-21 04:07:09 +00:00
rakekniven
de07319ec6
Merge pull request #3279 from nextcloud/Valdnet-patch-3
...
l10n: Replace apostrophe with double quotation
2021-05-20 08:04:54 +02:00
rakekniven
793c211232
Merge branch 'master' into Valdnet-patch-3
2021-05-20 07:47:17 +02:00
Nextcloud bot
b4a655124b
[tx-robot] updated from transifex
2021-05-20 04:18:16 +00:00
Felix Weilbach
3ec2ac3a5f
Merge pull request #3257 from nextcloud/feature/store-last-sync-run
...
Track time of last sync
2021-05-19 10:01:43 +02:00
Felix Weilbach
78f1943d76
Add a key value store to the sync journal
...
This key value store should help to keep track of important events,
that can not be store in the logs, because the logs are deleted too fast.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-19 09:04:43 +02:00
Nextcloud bot
4f915e9b53
[tx-robot] updated from transifex
2021-05-19 04:19:03 +00:00
Matthieu Gallien
79e6459bd1
Merge pull request #3183 from nextcloud/bugfix/warn-if-e2ee-with-vfs
...
Warn user if using e2ee and vfs together
2021-05-18 14:08:53 +02:00
Felix Weilbach
32b7e62359
Warn user if using e2ee and vfs together
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-18 11:50:18 +00:00
Matthieu Gallien
701e106aa3
Merge pull request #3286 from Dimon4eg/use_folders_in_cmake
...
use folders in CMake
2021-05-18 12:17:37 +02:00
Dmytro Korchynskyi
8b6b3023ea
use folders in CMake
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com >
2021-05-18 09:59:17 +03:00
Nextcloud bot
9a43755daa
[tx-robot] updated from transifex
2021-05-18 04:01:01 +00:00
allexzander
cdadb00cc8
Merge pull request #3311 from nextcloud/bugfix/rename-issue-for-custom-sync-root
...
Add remote folder prefix for renaming in a non-root local folder.
2021-05-17 15:25:57 +03:00
allexzander
76be5dce73
Add remote folder prefix for renaming in a non-root local folder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-17 12:19:58 +00:00
Felix Weilbach
47ec726cae
Merge pull request #3171 from nextcloud/feature/enable-addr-sanitizer
...
Enable address sanitizer
2021-05-17 13:58:01 +02:00
Felix Weilbach
e2d0481c64
Add CMake option to enable address sanitizers
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-17 11:43:55 +00:00
Matthieu Gallien
31179131f2
Merge pull request #3308 from nextcloud/ci/upgradeSqlite
...
upgrade SQLite3 to 3.35.5
2021-05-17 11:58:16 +02:00
Matthieu Gallien
89be02f8e7
upgrade SQLite3 to 3.35.5
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-17 09:48:15 +00:00
Nextcloud bot
c0bf12ec26
[tx-robot] updated from transifex
2021-05-17 03:59:33 +00:00
Nextcloud bot
a2b4cfe355
[tx-robot] updated from transifex
2021-05-16 04:02:19 +00:00
Nextcloud bot
5210ad8bdc
[tx-robot] updated from transifex
2021-05-14 03:53:16 +00:00
Nextcloud bot
dc8502e47d
[tx-robot] updated from transifex
2021-05-13 03:50:15 +00:00
Valdnet
a3b2dc669c
One more apostrophe change
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-05-12 12:45:33 +02:00
Valdnet
dadddd7ea2
l10n: Replace apostrophe with double quotation
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-05-12 12:34:22 +02:00
Felix Weilbach
96c80487a4
Merge pull request #3299 from nextcloud/bugfix/remove-unnecessary-cfapi-logging
...
Remove unnecessary cfapi logging statements
2021-05-12 11:54:58 +02:00
Felix Weilbach
c3a2587a91
Remove unnecessary cfapi logging statements
...
For big files that can add a lot lines to the log files.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-12 08:49:13 +00:00
Nextcloud bot
c528a41389
[tx-robot] updated from transifex
2021-05-12 03:54:55 +00:00
Matthieu Gallien
e4de8c5a46
Merge pull request #3304 from nextcloud/CI/needsInfoStaleBot
...
add a stale bot to help manage needs info issues
2021-05-11 18:42:54 +02:00
Matthieu Gallien
3d247ad9e3
add a stale bot to help manage needs info issues
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-11 16:32:59 +00:00
allexzander
00eca1260e
Merge pull request #3290 from nextcloud/bugfix/block-vfs-on-windows-partition-root
...
Temporary! Windows. VFS. Block Virtual Files for partition root sync folders.
2021-05-11 19:04:37 +03:00
allexzander
bbf11d7e7a
Temporary! Windows. VFS. Block Virtual Files for partition root sync folders.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-11 18:53:35 +03:00
Nextcloud bot
4f7cbee64d
[tx-robot] updated from transifex
2021-05-11 03:54:30 +00:00
Matthieu Gallien
a107d7e5dd
Merge pull request #3297 from nextcloud/updateCopyrightNotice
...
also update ownCloud years interval in copyright notice
2021-05-10 13:38:35 +02:00
Matthieu Gallien
54d91cdd7b
also update ownCloud years interval in copyright notice
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-10 10:29:22 +00:00
Matthieu Gallien
131ab55673
Merge pull request #3272 from nextcloud/ci/staleBotMoreOften
...
Ci/stale bot more often
2021-05-10 09:53:19 +02:00
Matthieu Gallien
8d12dfe63d
add a message when bot close a staled issue
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-10 07:22:29 +00:00
Matthieu Gallien
60ccc3cb6f
run every 8 hours the stale bot to provide faster reaction to changes
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-10 07:22:29 +00:00
Nextcloud bot
21e607da57
[tx-robot] updated from transifex
2021-05-10 04:06:15 +00:00
Nextcloud bot
34a25a4e02
[tx-robot] updated from transifex
2021-05-09 03:54:21 +00:00
Nextcloud bot
e0dd06b978
[tx-robot] updated from transifex
2021-05-08 03:56:52 +00:00
Felix Weilbach
85df5d35cb
Merge pull request #3285 from nextcloud/feature/git-ignore-convert-exe
...
Git ignore convert.exe and .dir-locals.el
2021-05-07 12:28:04 +02:00
Felix Weilbach
690bc199c6
Git ignore convert.exe and .dir-locals.el
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-07 12:17:42 +02:00
Nextcloud bot
3ee831884f
[tx-robot] updated from transifex
2021-05-07 04:00:14 +00:00
Matthieu Gallien
05543d8b87
Merge pull request #3267 from nextcloud/feature/autoUpdatePlatforms
...
send OS name and version to auto updater to allow selective upgrades
2021-05-06 12:13:48 +02:00
Matthieu Gallien
86dda5675f
send OS name and version to auto updater to allow selective upgrades
...
in order to be able to suuport legacy OS, also sends the OS name and
version
will be used to detect Windows 8.1 and similar legacy versions
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 09:32:09 +00:00
Matthieu Gallien
8f7646d93f
Merge pull request #3260 from nextcloud/fix/cherryPickFixes
...
Fix/cherry pick fixes
2021-05-06 09:55:04 +02:00
Hannah von Reth
17a1a630a4
Use the http logger with the unittests
...
This allow better debugging of the tests
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
bff386e5c1
Fix int uint warning
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
98655ef28b
Fix warning by using qsizetype instead of size_t
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
ea3d78aecf
Fix warning by using QByteArrayLiteral
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
e04c6abcd5
Fix placeholder detection for cfapi
...
Fixes : #8326
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
adb56178b9
GetLastError() needs to be called when the error happens
...
qDebug might clear it already
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
allexzander
539b45a346
Merge pull request #3246 from nextcloud/bugfix/vfs-allow-dyhadration-of-readonly-files
...
VFS. Allow dehydartion of readonly files. Preserve 'readonly' flag when creating a placeholder.
2021-05-06 09:26:17 +03:00
allexzander
d754bb7102
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-06 06:17:36 +00:00
allexzander
ef89256d39
VFS. Allow dehydartion of readonly files. Preserve 'readonly' flag when creating a placeholder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-06 06:17:36 +00:00
Nextcloud bot
49e68d7234
[tx-robot] updated from transifex
2021-05-06 04:00:08 +00:00
allexzander
f66add825d
Merge pull request #3239 from nextcloud/bugfix/vfs-local-name-clash-error
...
VFS. Display local file name clash error when syncing in VFS mode.
2021-05-05 20:43:40 +03:00
allexzander
19522210ac
VFS. Display local file name clash error when syncing in VFS mode.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-05 17:34:59 +00:00
Matthieu Gallien
361bd6fdb4
Merge pull request #3265 from nextcloud/rakekniven-patch-1
...
Changed copyright year to 2021
2021-05-05 14:56:43 +02:00
rakekniven
6d23e93d31
Changed copyright year to 2021
...
Fix for #3258
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com >
2021-05-05 13:37:31 +02:00
Felix Weilbach
6d22da9a4b
Merge pull request #3263 from nextcloud/bugfix/dont-crash-if-screen-under-pointer-not-found
...
Fallback to primary screen if screen under pointer not found
2021-05-05 12:10:10 +02:00
Felix Weilbach
aadee15008
Fallback to primary screen if screen under pointer not found
...
Fixes #3252
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-05 11:56:46 +02:00
Matthieu Gallien
8716877e61
Merge pull request #3261 from nextcloud/ci/staleBot
...
increase number of operations per run to go through old issues
2021-05-05 11:45:21 +02:00
Matthieu Gallien
1e267f1781
increase number of operations per run to go through old issues
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-05 11:20:08 +02:00
Nextcloud bot
3062595022
[tx-robot] updated from transifex
2021-05-05 04:08:32 +00:00
Felix Weilbach
0bf725be3a
Merge pull request #3255 from nextcloud/bug/fixMissingTranslation
...
add missing call to tr to get a translated string
2021-05-04 12:44:15 +02:00
Matthieu Gallien
23ba193102
add missing call to tr to get a translated string
...
Fix #3250
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-04 12:16:10 +02:00
Felix Weilbach
c37a4a6452
Merge pull request #3193 from nextcloud/bugfix/pn-reconnect-forever-if-possible
...
Push notifications: reconnect forever if possible
2021-05-04 10:17:37 +02:00
Felix Weilbach
7112d2aa78
Push Notifications: Reconnect forever if capabilities allow it
...
Fixes #3115
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-04 10:05:19 +02:00
Felix Weilbach
aea867c445
Refactor push notification tests
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-04 07:27:06 +00:00
Felix Weilbach
d21df33a50
Add missing copyright headers for push notifications
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-04 07:27:06 +00:00
Nextcloud bot
9372b6827c
[tx-robot] updated from transifex
2021-05-04 03:57:20 +00:00
Nextcloud bot
b27c9ae9bc
[tx-robot] updated from transifex
2021-05-03 03:55:12 +00:00
Nextcloud bot
9b0c57cdea
[tx-robot] updated from transifex
2021-05-02 03:54:12 +00:00
Nextcloud bot
cee697e781
[tx-robot] updated from transifex
2021-05-01 03:58:05 +00:00
rakekniven
0d5e4a1ba2
Merge pull request #3241 from nextcloud/rakekniven-patch-2
...
No need to translate ellipsis
2021-04-30 14:50:28 +02:00
rakekniven
33ef3a1d1e
Merge branch 'master' into rakekniven-patch-2
2021-04-30 14:38:23 +02:00
rakekniven
ecd88832b8
Merge pull request #3242 from nextcloud/Valdnet-patch-3
...
l10n: Translation of ellipse
2021-04-30 14:37:56 +02:00
Valdnet
dc6518a4ee
l10n: Translation of ellipse
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-30 13:57:02 +02:00
rakekniven
0e12b0323e
No need to translate ellipsis
...
Here another PR for the same code line as #3238
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com >
2021-04-30 13:27:18 +02:00
Felix Weilbach
a97c083c98
Merge pull request #3238 from nextcloud/Valdnet-patch-3
...
l10n: Change to an ellipsis
2021-04-30 11:07:06 +02:00
Valdnet
f431649bad
l10n: Change to an ellipsis
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-30 08:19:25 +00:00
Matthieu Gallien
741c2f0bd3
Merge pull request #3233 from nextcloud/doc/updateDocumentationVersion
...
update version of documentation to the latest release (v3.2.1)
2021-04-30 10:07:14 +02:00
Matthieu Gallien
55f91e2cb7
update version of documentation to the latest release (v3.2.1)
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-30 07:28:58 +00:00
Nextcloud bot
e973dd8c39
[tx-robot] updated from transifex
2021-04-30 03:59:29 +00:00
allexzander
14843b7a62
Merge pull request #3186 from nextcloud/feature/share-obey-enforced-password-for-share-by-mail
...
Obey enforced password for share by email.
2021-04-29 11:21:24 +03:00
allexzander
e72013fed1
Fix Felix's comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:21 +00:00
allexzander
19e2d70c53
Final corrections and refactoring.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:21 +00:00
allexzander
deb9ba89f0
Only show password option for email shares.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:21 +00:00
allexzander
526fa399dc
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
allexzander
c908183044
Use separate progress indicator for password and replace a button with it while running.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
allexzander
0072d39ca0
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
allexzander
2d88fc6c99
Obey enforced password for share by email.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
Nextcloud bot
a4bad72c57
[tx-robot] updated from transifex
2021-04-29 03:59:40 +00:00
Felix Weilbach
2234aa4387
Merge pull request #3218 from nextcloud/Valdnet-patch-3
...
l10n: Delete space and capital letter
2021-04-28 13:48:13 +02:00
Valdnet
8aedc74838
l10n: Delete space and change capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-28 11:41:06 +00:00
Felix Weilbach
d7b6ff2841
Merge pull request #3220 from nextcloud/feature/feature-req-template
...
Add separate GitHub templates for features and issues
2021-04-28 13:36:23 +02:00
Felix Weilbach
7cbea48a53
Add separate GitHub templates for features and issues
...
Additionally, this commit adds functionality to label automatically
feature and bug reports.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-28 10:34:29 +00:00
Nextcloud bot
314ab62804
[tx-robot] updated from transifex
2021-04-28 03:57:45 +00:00
Camila
864313d588
Merge pull request #3185 from HouraisanNEET/patch-1
...
Update installing.rst
2021-04-27 19:33:08 +02:00
HouraisanNEET
20a2c42963
Update installing.rst
...
Signed-off-by: HouraisanNEET <HouraisanNEET@users.noreply.github.com >
2021-04-27 17:20:54 +00:00
allexzander
98b1203856
Merge pull request #3178 from nextcloud/bugfix/improve-public-link-sharing-dialog
...
Improve public link sharing dialog
2021-04-27 14:15:27 +03:00
allexzander
e7e5542d3e
Improve public link sharing UI. Fix UX issues.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-27 13:51:52 +03:00
Nextcloud bot
2406b356c7
[tx-robot] updated from transifex
2021-04-27 03:59:28 +00:00
Matthieu Gallien
6cf1f7f9f2
Merge pull request #3214 from nextcloud/doc/updateNews
...
update the news part of documentation with improvements from 3.2 release
2021-04-26 21:07:12 +02:00
Matthieu Gallien
c2b36981fa
update the versions and date used in the doc generation
...
should no longer be necessary when this will come from cmake until that,
let's update it
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 16:37:13 +02:00
Matthieu Gallien
0aca5d616c
update the news part of documentation with improvements from 3.2 release
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 16:37:13 +02:00
Felix Weilbach
5ea16ffb3b
Merge pull request #3132 from yopito/fix/clang-variadic-macro-warning-only-for-clang
...
clang's variadic macro warnings: only for clang
2021-04-26 16:02:21 +02:00
yopito
14d61c5071
clang's variadic macro warnings: only for clang
...
following settings of cmake/modules/Warnings.cmake
Signed-off-by: yopito <pierre.bourgin@free.fr >
2021-04-26 13:22:41 +00:00
Felix Weilbach
384aeb513b
Merge pull request #3192 from nextcloud/bugfix/call-finish-if-remove-all-files
...
Call finish() if going to remove all files
2021-04-26 15:21:29 +02:00
Felix Weilbach
9a88e38121
Call finish() if going to remove all files
...
While investigating #3172 , I discoverd that the sync will hang forever
if the user has deleted all files on the server. Calling the callback
resolves the problem.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-26 12:50:14 +00:00
Matthieu Gallien
e9b3144e1a
Merge pull request #3170 from nextcloud/bug/fixVfsStatusDelay
...
status wrong for directories when using vfs and nextcloud desktop 3.2.0
2021-04-26 14:12:23 +02:00
Matthieu Gallien
419bd93dea
when files get hydrated indirectly through pinning, sets correct state
...
files that get downloaded not through an hydration request need to be
converted to placeholder
sets the expected state when converting them to placeholder files
#3082
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 13:54:32 +02:00
Matthieu Gallien
929ae965ce
prevent progress bar to appear after a download is finished with CfApi
...
when using Cloud Filter API with enabled VFS on Windows, a progress bar
stays visible for some time after hydration is completed. Not updating a
last time the progress bar prevents that.
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 13:54:32 +02:00
Matthieu Gallien
9453bcab59
Merge pull request #3209 from nextcloud/doc/serverCompatibility
...
add info in the installation page about the supported server versions
2021-04-26 13:19:25 +02:00
Matthieu Gallien
734d403a82
add info in the installation page about the supported server versions
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 13:18:34 +02:00
Matthieu Gallien
74b5ca3e8e
Merge pull request #3187 from nextcloud/bugfix/fixCfRegisterSyncRoot
...
fix errors when calling CfRegisterSyncRoot by setting more fields
2021-04-26 13:13:01 +02:00
Matthieu Gallien
97d785f1bb
fix errors when calling CfRegisterSyncRoot by setting more fields
...
sets a reasonable size of the StructSize members in the struct passed to
CfRegisterSyncRoot function
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 08:02:40 +00:00
Matthieu Gallien
5404c8cd2a
Merge pull request #3154 from q-wertz/update-client-integration-linux
...
Update Linux file manager integration
2021-04-26 09:27:53 +02:00
Clemens Sonnleitner
5e0385381f
Updated the description on file manager integration on Linux
...
Signed-off-by: Clemens Sonnleitner <clemens.sonnleitner@web.de >
2021-04-26 07:03:50 +00:00
Nextcloud bot
313d6d5bcf
[tx-robot] updated from transifex
2021-04-26 03:56:53 +00:00
Nextcloud bot
fb06b4743e
[tx-robot] updated from transifex
2021-04-25 03:58:29 +00:00
Nextcloud bot
82bf3ee0f6
[tx-robot] updated from transifex
2021-04-24 03:58:34 +00:00
Felix Weilbach
802be220ae
Merge pull request #3048 from nextcloud/linux-display-name
...
Use More Concise Display Name on Linux
2021-04-23 14:56:22 +02:00
Elsie Hupp
ce20aa36a2
Use concise display name
...
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com >
2021-04-23 12:20:35 +00:00
Nextcloud bot
fadc12996a
[tx-robot] updated from transifex
2021-04-23 03:58:40 +00:00
Felix Weilbach
bdebce7114
Merge pull request #3184 from nextcloud/featuer/add-pr-template
...
Add pull request template
2021-04-22 15:52:24 +02:00
Felix Weilbach
a9d05b3eca
Add pull request template
...
I'm tierd of telling people to signoff their work:)
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-22 15:02:44 +02:00
Felix Weilbach
52bb707d54
Merge pull request #3179 from nextcloud/Valdnet-patch-2
...
l10n: Change to an ellipsis
2021-04-22 09:46:34 +02:00
Valdnet
796b4e4e72
l10n: Change to an ellipsis
...
Reported on Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-22 07:40:15 +00:00
Nextcloud bot
811d54fd24
[tx-robot] updated from transifex
2021-04-22 03:56:47 +00:00
Nextcloud bot
2240452804
[tx-robot] updated from transifex
2021-04-21 11:25:21 +00:00
Matthieu Gallien
b3daa9b8ab
Merge pull request #3174 from nextcloud/bug/avoidAssertEmptyDateHeader
...
avoid an assert by delaying access to response timestamp when in error
2021-04-21 09:22:31 +02:00
Matthieu Gallien
782a2fdf06
avoid an assert by delaying access to response timestamp when in error
...
when canceling the sync of a big directory, I can get some network
request that are aborted before a Date reply header has been read
in this case we would always access
AbstractNetworkJob::responseTimestamp() and fire the assert even if we
know that the network reply has an error
delay the access to after the possible errors have been dealt with
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-20 17:42:17 +02:00
Felix Weilbach
596992c2ea
Merge pull request #3127 from nextcloud/feature/add-note-to-group-share
...
Add note to user and group share
2021-04-20 13:47:50 +02:00
Felix Weilbach
275e46f0db
Show progess indicator
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
c3fac23903
Don't delete note and expiration date on toggle
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
8711d5bf49
Don't use unnecessary layout element
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
2851528595
Show user/group note on share if already set
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
22a3b19e08
Add expire date to user and group share
...
Fixes #3100
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
946a51e4c1
Add note to user and group share
...
Fixes #3104
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Nextcloud bot
87f3073b87
[tx-robot] updated from transifex
2021-04-20 03:56:46 +00:00
Matthieu Gallien
20357ca7fa
Revert "Add CMake option to enable address sanitizers"
...
This reverts commit 3000e26640 .
This was not intended for a direct push
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-19 17:54:09 +02:00
Felix Weilbach
3000e26640
Add CMake option to enable address sanitizers
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-19 15:38:59 +02:00
allexzander
da0b03b01c
Merge pull request #3167 from nextcloud/bugfix/fix-documentation-markup-warnings
...
Documentation. Fix incorrect syntax warnings and incorrect indentation before the 'image' element.
2021-04-19 11:24:10 +03:00
allexzander
21d39dea87
Documentation. Fix incorrect syntax warnings and incorrect indentation before image elements.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-19 10:32:53 +03:00
allexzander
801a3ff9d4
Merge pull request #3136 from nextcloud/E2EE-and-VFS
...
E2EE and VFS
2021-04-19 09:32:30 +03:00
Jos Poortvliet
cd598a00f7
Documentation: E2EE and VFS
...
Describe the relation between E2EE and VFS.
Signed-off-by: Jos Poortvliet <jospoortvliet@gmail.com >
2021-04-19 09:24:11 +03:00
Nextcloud bot
41bf68bc9c
[tx-robot] updated from transifex
2021-04-19 03:59:18 +00:00
Nextcloud bot
58992b0010
[tx-robot] updated from transifex
2021-04-18 03:53:09 +00:00
Nextcloud bot
f584971423
[tx-robot] updated from transifex
2021-04-17 03:55:03 +00:00
allexzander
66b625abdc
Merge pull request #3146 from nextcloud/bugfix/fix-incorrect-image-elements
...
Documentation. Fix incorrect format usage for images and subheaders.
2021-04-16 17:16:47 +03:00
allexzander
4fad07179d
Documentation. Fix incorrect subheader format.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-16 14:04:28 +00:00
allexzander
988e928d74
Documentation. Fix incorrect image elements.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-16 14:04:28 +00:00
allexzander
7d9d75e90a
Merge pull request #3150 from nextcloud/bugfix/vfs-documentation-show-experimental
...
Documentation: Correct option to enable virtual files on Linux/macOS
2021-04-16 17:02:54 +03:00
Felix Weilbach
315fdb0be8
Documentation: Correct option to enable virtual files on Linux/macOS
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-16 15:27:48 +02:00
allexzander
218e69e510
Merge pull request #3125 from nextcloud/bugfix/windows-navigation-panel-display-vfs-sync-folder
...
Display VFS sync folder within the navigation panel on Windows.
2021-04-16 10:43:24 +03:00
allexzander
d65c91ea36
Display VFS sync folder within the navigation panel on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-16 07:18:44 +00:00
Nextcloud bot
1374966567
[tx-robot] updated from transifex
2021-04-16 03:59:43 +00:00
Felix Weilbach
f77723e3a7
Merge pull request #3111 from nicolasfella/sharedmimeinfo
...
Copy FindSharedMimeInfo from ECM
2021-04-15 16:46:55 +02:00
Nicolas Fella
2548455f45
Copy FindSharedMimeInfo from ECM
...
Instead of relying on ECM being installed.
We copy other stuff from ECM so be consistent.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-15 14:32:46 +00:00
Felix Weilbach
8e3ddcc79c
Merge pull request #3133 from nicolasfella/cmaketest
...
Remove redundant CMake code
2021-04-15 16:31:34 +02:00
Nicolas Fella
2ad03d96ac
Remove redundant CMake code
...
The same is done somewhere below
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-15 14:13:36 +00:00
allexzander
63a02a988f
Merge pull request #3138 from nextcloud/feature/windows-msi-force-minimum-supported-os
...
Windows MSI. Do not allow installing Nextcloud client on < Windows 10 or < 1709
2021-04-15 14:35:00 +03:00
allexzander
c88e76a4a9
Minimum supported Windows 10, build 1709.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-15 13:47:37 +03:00
Felix Weilbach
a74d9ec516
Merge pull request #3124 from nextcloud/bugfix/cmake-require-sqlite-only-on-unix
...
CMake: Require sqlite3 only on Unix
2021-04-15 09:04:14 +02:00
Felix Weilbach
da1e5c448a
CMake: Use own SQLite3 on macOS and Windows
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-15 08:51:06 +02:00
Nextcloud bot
89677fe22f
[tx-robot] updated from transifex
2021-04-15 03:57:09 +00:00
rakekniven
0fa95bdfb1
Merge pull request #3121 from castillo92/patch-1
...
Update sharedialog.cpp
2021-04-14 20:39:03 +02:00
rakekniven
03e7d8da28
Merge branch 'master' into patch-1
2021-04-14 17:11:27 +02:00
Nicolas Fella
b1fc7d4b52
Merge pull request #3112 from nicolasfella/threads
...
Use imported target for Threads
2021-04-14 13:17:22 +02:00
Nicolas Fella
70033cda1f
Use imported target for Threads
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-14 11:07:04 +00:00
Felix Weilbach
71658b0974
Merge pull request #3119 from nextcloud/feature/cmake-add-feature-summary
...
Add feature summary to CMake
2021-04-14 10:23:59 +02:00
Felix Weilbach
f3eed2ad1e
Add feature summary to CMake
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-14 09:51:31 +02:00
castillo92
98a4bb8cce
Update sharedialog.cpp
...
The original sentence uses the word "share" three times and is too redundant when translated into other languages
2021-04-14 09:24:35 +02:00
allexzander
a5330aeb24
Merge pull request #3046 from nextcloud/bugfix/msi-do-not-reboot-silent-installation
...
Do not schedule reboot when installing MSI in silent mode unless 'SCHEDULE_REBOOT is set.
2021-04-14 10:17:19 +03:00
allexzander
7d2ab1f3fe
Do not schedule reboot when installing MSI in silent mode unless 'SCHEDULE_REBOOT' is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-14 06:59:21 +00:00
allexzander
32dd91e650
Merge pull request #3066 from nextcloud/bugfix/temporary-solution-for-file-restoration-via-datafingerprint
...
Temporary solution for file restoration issue due to failing the data…
2021-04-14 09:49:57 +03:00
allexzander
bc919bcc8c
Temporary solution for file restoration issue due to failing the dataFingerprint on client.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-14 06:42:48 +00:00
Nextcloud bot
0e6e240f09
[tx-robot] updated from transifex
2021-04-14 03:59:35 +00:00
Felix Weilbach
43cae72d4d
Merge pull request #3022 from nextcloud/feature/display-invalid-filenames-as-warning
...
Display invalid filenames as warning
2021-04-13 17:35:43 +02:00
Felix Weilbach
696979cb0e
Display invalid filenames as warning
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 14:58:51 +00:00
Felix Weilbach
b736355985
Add notification cache
...
The notification cache helps to not display duplicate desktop
notifications to the user.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 14:58:50 +00:00
Felix Weilbach
9c4a9958f7
Merge pull request #3031 from nextcloud/feature/push-notifications-ping-server
...
Push notifications: Ping server
2021-04-13 14:27:55 +02:00
Felix Weilbach
b256c6e694
Ping websocket server
...
This helps the client to recognize if the websocket server is still alive.
Fixes #2983
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 12:19:40 +00:00
Felix Weilbach
d7499b0746
Refactor push notification test utils
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 12:19:40 +00:00
Nicolas Fella
c49be218ec
Merge pull request #3092 from nextcloud/cloudproviders2
...
Only include libcloudproviders dir when cloudproviders is found
2021-04-13 13:38:03 +02:00
Nicolas Fella
b8879dbf07
Only include libcloudproviders dir when cloudproviders is found
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-13 11:29:29 +00:00
Nicolas Fella
478ca784b1
Merge pull request #3093 from nicolasfella/dolphin2
...
[shellintegration] Simplify cmake code
2021-04-13 13:28:04 +02:00
Nicolas Fella
df3ebb11f6
[shellintegration] Simplify cmake code
...
We don't need ECM to check for KIO
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-13 11:22:19 +00:00
Valdnet
e2ad407259
Merge pull request #3087 from nextcloud/Valdnet-patch-2
...
l10n: Unify spelling
2021-04-13 12:42:25 +02:00
Valdnet
e628a51735
l10n: Unify spelling
...
Spelling unification in Nextcloud applications.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 12:24:57 +02:00
allexzander
909248f058
Merge pull request #3089 from nextcloud/feature/add-vfs-and-status-feature-doc
...
Added documentation for VFS and Status Feature.
2021-04-13 12:38:17 +03:00
allexzander
b4d01afd86
Added documentation for VFS and Status Feature.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-13 10:18:27 +03:00
Felix Weilbach
f882dee8dc
Merge pull request #3059 from nextcloud/inotify
...
Improve Inotify cmake code
2021-04-13 08:46:54 +02:00
Nicolas Fella
3bc66bea66
Improve Inotify cmake code
...
Use the FindInotify from ECM. It handles the case of Linux vs BSD
correctly automatically.
Also only find Inotify on Linux and BSD
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-13 06:36:14 +00:00
Nextcloud bot
f119e4cf64
[tx-robot] updated from transifex
2021-04-13 03:56:05 +00:00
Matthieu Gallien
8102d51b99
Merge pull request #3065 from nicolasfella/dolphincmake
...
[dolphin] Clean up CMake code
2021-04-12 16:22:18 +02:00
Nicolas Fella
e207cfdbfc
[dolphin] Clean up CMake code
...
Remove some stuff that is not needed.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-12 13:27:46 +00:00
Matthieu Gallien
a1f78c4330
Merge pull request #3003 from nextcloud/fix-and-comment-default-build-type
...
Remove non-functional default CMAKE_BUILD_TYPE
2021-04-12 14:16:44 +02:00
Elsie Hupp
1183b3f7b9
Remove non-functional default CMAKE_BUILD_TYPE
...
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com >
2021-04-12 11:26:08 +00:00
Felix Weilbach
efdd46fb6d
Merge pull request #3058 from nicolasfella/cloudproviders
...
Use FindPkgConfig to find libcloudproviders and related libs
2021-04-12 13:15:38 +02:00
Nicolas Fella
b34a901838
Use FindPkgConfig to find libcloudproviders and related libs
...
Instead of using custom find modules.
This allows using imported targets which make the code much nicer.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-12 10:00:08 +00:00
Nextcloud bot
e74746c4e7
[tx-robot] updated from transifex
2021-04-12 03:55:08 +00:00
Nextcloud bot
96c51faa9c
[tx-robot] updated from transifex
2021-04-11 03:53:37 +00:00
Nextcloud bot
c956a462e2
[tx-robot] updated from transifex
2021-04-10 04:06:36 +00:00
Felix Weilbach
4efe00feca
Merge pull request #3075 from nextcloud/bugfix/embed-version-info-win
...
Embed version and icon into windows executable
2021-04-09 14:29:46 +02:00
Felix Weilbach
c49dc440bb
Embed version and icon into windows executable
...
These changes are necessary because of changing the compilation
process for the gui from a single executable to static lib +
executable in commit 0521dce174 .
Otherwise the version and icon information will be lost.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-09 13:53:12 +02:00
Nextcloud bot
5e15f4f2c6
[tx-robot] updated from transifex
2021-04-09 03:55:46 +00:00
allexzander
b6371bf39b
Merge pull request #3073 from nextcloud/bump_version_to_3.2.5
...
Bump version to 3.2.50
2021-04-08 11:26:20 +03:00
allexzander
740e1d2f0d
Bump version to 3.2.50.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-08 11:09:49 +03:00
allexzander
5e6c31b262
Merge pull request #3072 from nextcloud/bump-version-3.2.0
...
Bump version to 3.2.0.
2021-04-08 10:47:24 +03:00
allexzander
8550bfa8f1
Bump version to 3.2.0.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-08 10:38:10 +03:00
allexzander
f6afb62a53
Merge pull request #3069 from nextcloud/feature/user-status
...
User status bug fixing...
2021-04-08 10:18:13 +03:00
Camila
1ca0ea49dd
Remove unnecessary local variable.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
29f4a3857b
Reposition qml elements for the folder status icon.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
050bd49373
Rename enumToUserString => enumToString.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
8986975a17
Use enum class instead of enum.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
50de12b3c3
Undo unnecessary removal of lines.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
163015492a
Fix #3067 : missing apps icon.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
c8ac99c8cf
Align status text with server url.
...
Cleans the space in the beginning of the string when there is no emoji
set.
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
e51dad79a2
Refactor UserStatus.
...
- Make preDefinedStatus a local var.
- Add function to get the status user string.
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
d2b762aa66
Move curly brackets to the correct line.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
98cfc362f7
Remove const and reference of base types.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:58 +00:00
Nextcloud bot
835a61c5ee
[tx-robot] updated from transifex
2021-04-08 03:55:06 +00:00
allexzander
5eb6834167
Merge pull request #3057 from nextcloud/bugfix/vfs-windows-lnk-files-freeze-issue
...
Fix VFX Windows .lnk files freeze/crash issue
2021-04-07 12:28:05 +03:00
allexzander
4b58c2b7b7
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
82953d0601
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
de85b79bb8
Address review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
cb8b6ccd9b
Ignore *.lnk files on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
13f4bb541d
Treat .lnk files as normal files without hydrating them or creating a placeholder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
3906ae0922
Another way to fix this.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
7235c708dc
Added .lnk file placeholder creation fix.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
d5b6d93978
Fix VFS freeze when syncing '.lnk' files on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
Matthieu Gallien
4a7145f1f3
Merge pull request #3068 from nextcloud/bug/fixAssertEditIgnoredFiles
...
use QFileInfo to check if path is absolute to avoid assert on windows
2021-04-07 10:06:29 +02:00
Matthieu Gallien
d6752c96b1
use QFileInfo to check if path is absolute to avoid assert on windows
...
on windos absolute path does not have to start with / . Remove failing assert
when editing ignored files list.
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-07 07:40:07 +00:00
Nextcloud bot
77681ff5b5
[tx-robot] updated from transifex
2021-04-07 03:55:50 +00:00
allexzander
4c8378030d
Merge pull request #3061 from nextcloud/bugfix/vfs-syncroot-reg-params-non-temp
...
Create std::wstrings out of const wchar_t* so a copy is created every time
2021-04-06 15:46:06 +03:00
allexzander
0a33e99053
Create std::wstrings out of const wchar_t* so a copy is created every time.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-06 10:03:22 +03:00
allexzander
454226b3ea
Merge pull request #3060 from nextcloud/bugfix/reduce-socketapi-logging
...
Reduce Socket API logging.
2021-04-06 09:49:21 +03:00
allexzander
e15045977e
Reduce Socket API logging.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-06 09:34:20 +03:00
Nextcloud bot
a599cd2c3f
[tx-robot] updated from transifex
2021-04-06 03:54:22 +00:00
Nextcloud bot
487f29cf80
[tx-robot] updated from transifex
2021-04-04 03:53:11 +00:00
Nextcloud bot
2268facd9d
[tx-robot] updated from transifex
2021-04-03 04:11:49 +00:00
Nextcloud bot
57aeeca172
[tx-robot] updated from transifex
2021-04-02 03:55:01 +00:00
Nextcloud bot
962bbf3043
[tx-robot] updated from transifex
2021-04-01 03:55:02 +00:00
Felix Weilbach
6e147a7a8c
Merge pull request #3052 from nextcloud/bugfix/remove-html-tags-from-notifications
...
Remove html tags from strings that may appear in notifications
2021-03-31 17:36:15 +02:00
Felix Weilbach
b2377ff64f
Remove html tags from strings that may appear in notifications
...
The content of notifications on MacOS are not allowed to contain HTML
tags in it. Linux (Free Desktop) notifications may contain HTML tags
in their content. However, it is optional that the notification daemon
interprets the tags. The GNOME notification daemon does not interpret
HTML tags and even does not strip them off. KDE's daemon interprets
the tags. For now I think it's the best solution to remove the HTML
tags. In the future we should fire a action if the user clicks on the
notification and react on it and open the link then. This should work
on all platforms. But as this change involves working with the native
MacOS api and I don't have hardware for that at the moment for that I
will postpone it.
Fixes #2200
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-31 16:23:42 +02:00
Camila
be6e0f26df
Merge pull request #3049 from nextcloud/bump-version-rc3
...
Bump version to 3.1.83.
2021-03-31 12:27:22 +02:00
Camila
8741f4386c
Bump version to 3.1.83.
...
Signed-off-by: Camila <hello@camila.codes >
2021-03-31 12:14:18 +02:00
Nextcloud bot
ac6b62e19d
[tx-robot] updated from transifex
2021-03-31 03:55:58 +00:00
Nextcloud bot
044b5a33e9
[tx-robot] updated from transifex
2021-03-30 03:51:17 +00:00
Felix Weilbach
dde9eb645e
Merge pull request #3040 from nextcloud/bugfix/macos-dont-deploy-bearer
...
Don't deploy bearer plugin on MacOS
2021-03-29 16:01:41 +02:00
Felix Weilbach
354f4c02ee
Don't deploy bearer plugin on MacOS
...
Fixes #2944 , #2237
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-29 13:46:07 +00:00
Camila
58dd076b2b
Merge pull request #3015 from nextcloud/bugfix/update-wizard-doc
...
Update documentation for the account wizard.
2021-03-29 14:51:59 +02:00
Felix Weilbach
7faa80c1e1
Update documentation for the account wizard
...
This update is necessary because of the following commit:
b5cf820b42
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-29 12:10:37 +00:00
Nextcloud bot
f7dd4bbf69
[tx-robot] updated from transifex
2021-03-29 03:52:25 +00:00
Nextcloud bot
a7ac7991b8
[tx-robot] updated from transifex
2021-03-28 03:51:07 +00:00
Nextcloud bot
8eb5ed07bf
[tx-robot] updated from transifex
2021-03-27 03:52:53 +00:00
allexzander
4ce2e79e90
Merge pull request #3043 from nextcloud/bugfix/vfs-syncroot-register-error
...
Fix VFS CfAPI Syncroot Register Error.
2021-03-27 02:44:13 +02:00
allexzander
28771b25e3
Fix VFS CfAPI Syncroot Register Error.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-27 02:41:24 +02:00
allexzander
ab128cc4aa
Revert "Merge pull request #3042 from nextcloud/temp-fix-vfs-failure-wow6432"
...
This reverts commit cafa475398 , reversing
changes made to 003e56f4e6 .
2021-03-26 22:25:31 +02:00
allexzander
cafa475398
Merge pull request #3042 from nextcloud/temp-fix-vfs-failure-wow6432
...
Temp fix for vfs failure.
2021-03-26 21:46:10 +02:00
allexzander
9d15334813
Temp fix for vfs failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-26 21:41:44 +02:00
Nextcloud bot
003e56f4e6
[tx-robot] updated from transifex
2021-03-26 03:54:34 +00:00
Nextcloud bot
99309ab33b
[tx-robot] updated from transifex
2021-03-25 03:54:25 +00:00
Camila
d91e24d77d
Merge pull request #3034 from nextcloud/bump-version
...
Bump version to 3.1.82.
2021-03-24 19:48:28 +01:00
Camila
1edc2cfd31
Bump version to 3.1.82.
...
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 19:47:01 +01:00
Camila
e8669ad4b6
Merge pull request #2505 from nextcloud/status-feature
...
Status feature.
2021-03-24 17:28:27 +01:00
Camila
9219926a74
Add checks in case userStatus is not available/fails on the server side.
...
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:42:26 +01:00
Camila
d9a0778e52
Add UserStatus enum with the pre defined status.
...
- User QHash to map status strings and Status enum.
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:41:31 +01:00
Camila
974e2fb718
Do not display notifications when user status is do not disturb.
...
- This information is retrieved from the notifications endpoint.
- Add icons for the different pre defined status.
- Make functions available to QML to decide which status icon to display.
- Display the user status icon on the avatar and
move the online/offline connection status to the folder icon.
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:40:05 +01:00
Camila
f4d8699db8
Add UserStatus class to retrieve the user status.
...
- AccountState controls UserStatus.
- Display user status in the system tray menu next to user's avatar.
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:39:13 +01:00
Felix Weilbach
c29c011095
Merge pull request #3029 from nextcloud/Valdnet-patch-2
...
l10n: Change sync message
2021-03-24 15:03:22 +01:00
Valdnet
519dee9104
l10n: Change sync message #3027
2021-03-24 13:13:40 +00:00
allexzander
e3a26477a2
Merge pull request #2981 from nextcloud/vfs_win_progress_bar_refresh
...
Refresh Windows download dialog progress when hydrating a placeholder
2021-03-24 15:01:27 +02:00
allexzander
193e50311b
Refresh Windows download dialog progress when hydrating a placeholder
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-24 14:09:06 +02:00
Felix Weilbach
6a53491645
Merge pull request #3028 from nextcloud/bugfix/check-db-read-successful-on-hydration-canceled
...
Check reading from journal was successful before remove placeholder
2021-03-24 12:25:13 +01:00
Felix Weilbach
d78774f29e
Check reading from journal was successful before remove placeholder
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-24 10:51:50 +00:00
Nextcloud bot
4e420fcb5c
[tx-robot] updated from transifex
2021-03-24 03:52:27 +00:00
Felix Weilbach
22a9d18d3b
Merge pull request #3025 from nextcloud/bugfix/hidpi-scaling
...
Enable high dpi scaling on all platforms
2021-03-23 09:49:25 +01:00
Felix Weilbach
c296a93cee
Enable high dpi scaling on all platforms
...
Fixes #2295 , #1079 , #914
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-23 08:36:11 +00:00
Nextcloud bot
66ee5087f6
[tx-robot] updated from transifex
2021-03-23 03:51:35 +00:00
Felix Weilbach
4d921c8025
Merge pull request #3020 from nextcloud/feature/increase-file-removal-logging
...
Increase logging around file removal events
2021-03-22 09:01:42 +01:00
Felix Weilbach
b1983d7d19
Increase logging around file removal events
...
To better see what is going on when and if files are removed by the
client.
See also: #260 , #1433 , #2913
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-22 07:48:39 +00:00
Nextcloud bot
54c1ab8828
[tx-robot] updated from transifex
2021-03-22 03:51:08 +00:00
Nextcloud bot
3652251587
[tx-robot] updated from transifex
2021-03-21 03:47:05 +00:00
Nextcloud bot
9c4c7217a0
[tx-robot] updated from transifex
2021-03-20 03:49:45 +00:00
Nextcloud bot
b3d5b4983e
[tx-robot] updated from transifex
2021-03-19 03:49:45 +00:00
Felix Weilbach
278a6fd005
Merge pull request #3010 from nextcloud/feature/cfapi-handle-cancelation
...
CFAPI: Handle cancelation of hydration requests
2021-03-18 13:27:27 +01:00
Felix Weilbach
9bf5b5c7ba
CFAPI: Handle cancelation of hydration requests
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-18 10:43:48 +00:00
allexzander
6abb0b2184
Merge pull request #3016 from nextcloud/fix_for_win_createfile_long_path
...
Fix for Windows CreateFile long path
2021-03-18 12:34:22 +02:00
allexzander
5f0344abb2
Fix warnings in CfApiWrapper.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-18 12:07:07 +02:00
allexzander
3fde838bee
Fix for Windows long path issue.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-18 12:07:07 +02:00
Nextcloud bot
af654fb4ed
[tx-robot] updated from transifex
2021-03-18 03:52:32 +00:00
Felix Weilbach
2ab23e3b3c
Merge pull request #2990 from nextcloud/bugfix/fix-create-folder-dialog-crash
...
Fix crash when trying to open the folder creation dialog
2021-03-17 09:41:06 +01:00
Felix Weilbach
f4853da2ab
Fix crash when trying to open the folder creation dialog
...
The bug does seem to just appear in special compiler
constellations. We're unsure why this fix works. To better see if this
fix works or if crashes still occur, we added some logging.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-17 08:43:32 +01:00
Nextcloud bot
262f20a8f4
[tx-robot] updated from transifex
2021-03-17 03:49:13 +00:00
Felix Weilbach
96ded93597
Merge pull request #3009 from nextcloud/bugfix/check-not-for-productname
...
Don't check against product name if checking server version
2021-03-16 16:00:32 +01:00
Felix Weilbach
c0f09ae12c
Don't check against product name if checking server version
...
We should not rely on the product name because it is something the
user can change in the theming options on the server.
Fixes #3001
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-16 14:30:56 +00:00
Felix Weilbach
162dff9525
Merge pull request #2989 from nextcloud/bugfix/fix-appearance-login-dialog
...
Display the content of the login dialog correct
2021-03-16 14:59:33 +01:00
Felix Weilbach
ff7932bb54
Display the content of the login dialog correct
...
This adjustment is necessary because of the changes of the new account
wizard that were introduced with:
e0b7ef15b2
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-16 13:34:34 +00:00
Nextcloud bot
6d6da18f9a
[tx-robot] updated from transifex
2021-03-16 03:50:03 +00:00
allexzander
a92d300b7f
Merge pull request #2995 from nextcloud/repair_basic_auth_support
...
Repair basic auth support
2021-03-15 11:52:21 +02:00
Kevin Ottens
a6bcd3af46
Force basic auth on get authentication required error
...
If the get job got an authentication required error on the account url
(not davUrl! at that stage we always get auth error there), then it is
safe to assume basic auth is used on the server. It is then kind of
pointless to use any other auth mode they will necessarily fail. Only
basic auth will do the job so force it.
Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com >
2021-03-15 09:38:15 +00:00
Kevin Ottens
0d3459e85e
Introduce an empty auth type
...
This is necessary to be able to distinguish between "I decided on basic
by default" and "I didn't write any auth type". To make sure all the
jobs end up writing something we then implement the "I decided on basic
by default" in the slots connected to the job and we assert it in
checkAllDone()
Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com >
2021-03-15 09:38:15 +00:00
Kevin Ottens
7ad0208800
Finish cleaning up shibboleth
...
There were a couple of shibboleth related enums left, since that auth
method isn't supported anymore remove the code tied to those enums. It
was dead code anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com >
2021-03-15 09:38:15 +00:00
Nextcloud bot
a61d2d2dd0
[tx-robot] updated from transifex
2021-03-15 03:55:26 +00:00
Nextcloud bot
88a7285e5f
[tx-robot] updated from transifex
2021-03-14 03:48:03 +00:00
Nextcloud bot
6c194be02d
[tx-robot] updated from transifex
2021-03-13 03:47:03 +00:00
Felix Weilbach
aa9821f05f
Merge pull request #2999 from nextcloud/bugfix/fix-settings-dialog-on-dark-theme
...
Don't customize settings dialog palette
2021-03-12 15:22:15 +01:00
Felix Weilbach
cdc2e4c56e
Don't customize settings dialog palette
...
Customizing of the palette will prevent the settings dialog from
display a dark theme correct.
Fixes #2993
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-12 11:47:16 +01:00
allexzander
d028466d1c
Merge pull request #2998 from nextcloud/fix_incorrect_logexpire_config_type
...
Fix incorrect type when reading the 'logExpire' property from config.
2021-03-12 10:40:12 +02:00
allexzander
c89d351d97
Fix incorrect type when reading the 'logExpire' property from config.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-12 10:23:31 +02:00
Nextcloud bot
90a06aa57b
[tx-robot] updated from transifex
2021-03-12 03:48:03 +00:00
Felix Weilbach
72858da27b
Merge pull request #2967 from nextcloud/bugfix/fix-missing-error-handling-download-encrypted
...
Add missing error handling for downloads of client side encryption
2021-03-11 14:40:40 +01:00
Felix Weilbach
88426de4dd
Add missing error handling for downloads of client side encryption
...
The missing error handlers can cause the sync to hang forever
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-11 10:59:08 +00:00
Felix Weilbach
6fac2d1e40
Merge pull request #2976 from nextcloud/refactor/split-out-valuable-activities
...
Split content of User::isValueableActivity()
2021-03-11 11:57:55 +01:00
Felix Weilbach
e3ac63e9ff
Rename isActivityIgnored() to isUnsolvableconflict()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-11 09:42:38 +00:00
Felix Weilbach
05d31e2e53
Split content of User::isValueableActivity()
...
Refactoring of User::isValueableactivity() because of changes
introduced with merge commit f17c52d .
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-11 09:42:38 +00:00
Nextcloud bot
0ce965e8da
[tx-robot] updated from transifex
2021-03-11 03:51:50 +00:00
Camila
ed8f081b4a
Merge pull request #2986 from nextcloud/bump-version-3.1.81
...
Bump version to 3.1.81
2021-03-10 15:31:22 +01:00
Felix Weilbach
18b282d213
Bump version to 3.1.81
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 15:06:47 +01:00
Felix Weilbach
b5cf820b42
Merge pull request #2895 from nextcloud/wizard_ui_improvements
...
Improve wizard ui
2021-03-10 12:54:43 +01:00
Felix Weilbach
e0b7ef15b2
Restyle wizard pages
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
f55e5b1885
Restyle wizard
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
9185956069
Split out wizard welcome page
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
05d2a87840
Add new wizard icons and remove obsolete ones
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
344b28d2f8
Merge pull request #2979 from ivaradi/no-externc-glib2
...
Do not include glib.h with extern C (2)
2021-03-10 09:54:48 +01:00
István Váradi
2e7cc96228
Do not include glib.h with extern C (2)
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-03-10 07:48:23 +01:00
Nextcloud bot
d258faa117
[tx-robot] updated from transifex
2021-03-10 04:00:48 +00:00
István Váradi
17e27ce4ed
Merge pull request #2972 from ivaradi/no-externc-glib
...
Do no include glib.h with extern C
2021-03-09 13:30:20 +01:00
István Váradi
db321d25ef
Do no include glib.h with extern C
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-03-09 10:29:14 +01:00
Nextcloud bot
4760e892ad
[tx-robot] updated from transifex
2021-03-09 03:52:13 +00:00
Nextcloud bot
ad34531f02
[tx-robot] updated from transifex
2021-03-08 03:51:36 +00:00
Nextcloud bot
2e80adcf26
[tx-robot] updated from transifex
2021-03-07 03:47:27 +00:00
Nextcloud bot
de06b10af9
[tx-robot] updated from transifex
2021-03-06 03:52:05 +00:00
Felix Weilbach
f17c52dccd
Merge pull request #2948 from nextcloud/bugfix/conflict-dialog-issue
...
Fix crash when opening conflict dialog
2021-03-05 14:31:59 +01:00
Felix Weilbach
63dbb90bbd
Iteration
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-05 11:32:44 +00:00
Felix Weilbach
ef5abac567
Fix crashes with conflict dialog
...
When the client runs and a conflict gets detected, the sync engine runs
two times.
On the first run, the sync engine detects the conflict, marks the
file as a conflict and propagates that to the GUI. This leads to an
error notification with the original filename in the main dialog.
The sync engine runs then a second time. On this second run, the file
that originally caused the conflict is not anymore a conflict
file. Instead, the sync engine detects the conflicted copy and
propagates that file as a conflict to the GUI.
When opening the conflict dialog with the original file name (not the
conflicted copy) a crash happens. Usually, the two sync runs are really
fast, so the user does not notice the first notification. However, a
problem can occur if a conflict gets created while the client is not
running. Since then, the client does not do two sync runs. It does only
run once.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-05 11:32:44 +00:00
Nextcloud bot
101d3e5d7d
[tx-robot] updated from transifex
2021-03-05 03:51:13 +00:00
Felix Weilbach
3796876c8e
Merge pull request #2958 from nextcloud/bugfix/vfs-win-download-large-files
...
VFS Windows: Fix download of large files
2021-03-04 22:51:42 +01:00
Felix Weilbach
523f1bcadd
VFS Windows: Fix download of large files
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-04 09:05:17 +01:00
Nextcloud bot
226ec38f5c
[tx-robot] updated from transifex
2021-03-04 03:53:22 +00:00
Nextcloud bot
23d76b0920
[tx-robot] updated from transifex
2021-03-03 03:51:17 +00:00
Felix Weilbach
97cd61140e
Merge pull request #2931 from elsiehupp/build-instructions
...
Improve OSX build Instructions
2021-03-01 19:15:34 +01:00
Elsie Hupp
b33ea05271
Update OSX build instructions
...
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com >
2021-03-01 15:26:32 +00:00
Nextcloud bot
2d6faebb10
[tx-robot] updated from transifex
2021-03-01 03:48:16 +00:00
Nextcloud bot
7179fd88e8
[tx-robot] updated from transifex
2021-02-28 03:46:22 +00:00
Kevin Ottens
f32a8b3236
Merge pull request #2951 from nextcloud/enhancement/better_logging_of_cfpapi_error
...
Log error message from CFAPI
2021-02-27 18:56:35 +01:00
Felix Weilbach
4d05979be5
Log error message from CFAPI
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-27 17:44:26 +00:00
Nextcloud bot
8e32bea212
[tx-robot] updated from transifex
2021-02-27 03:51:14 +00:00
Nextcloud bot
6e3b3fccfc
[tx-robot] updated from transifex
2021-02-26 03:48:56 +00:00
Nextcloud bot
b5ca1f2f4b
[tx-robot] updated from transifex
2021-02-25 03:50:19 +00:00
Tobias Kaminsky
f8c031ee93
Merge pull request #2949 from nextcloud/staleAction
...
Move from stale bot to stale action
2021-02-24 16:50:49 +01:00
tobiasKaminsky
3de6ce9ee9
Move from stale bot to stale action
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me >
2021-02-24 08:02:56 +01:00
Nextcloud bot
26b3ad1e1c
[tx-robot] updated from transifex
2021-02-24 03:56:01 +00:00
Nextcloud bot
26a08fa51b
[tx-robot] updated from transifex
2021-02-19 03:53:20 +00:00
allexzander
ebdec26e27
Merge pull request #2935 from nextcloud/do-not-auto-start-debug-build
...
Do not add debug build to startup programs.
2021-02-18 15:45:34 +02:00
allexzander
88a21c0665
Do not add debug build to startup programs.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-18 13:19:06 +00:00
Tobias Kaminsky
6c9cfa319b
Merge pull request #2937 from nextcloud/staleSecondTry
...
Stale: issue must have bug and must not have approved label
2021-02-18 12:54:17 +01:00
tobiasKaminsky
8dded9310c
Stale: issue must have bug and must not have approved label
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me >
2021-02-18 10:42:18 +01:00
Nextcloud bot
dafd37711a
[tx-robot] updated from transifex
2021-02-18 03:52:54 +00:00
Nextcloud bot
41c547e705
[tx-robot] updated from transifex
2021-02-17 03:46:45 +00:00
allexzander
e6ec648e3b
Merge pull request #2925 from nextcloud/fix-incorrect-logger-output-for-non-latin-strings
...
Fix incorrect logger output for non-Latin strings.
2021-02-16 16:13:16 +02:00
allexzander
4d66d209bc
Fix incorrect logger output for non-latin strings.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-16 09:30:08 +02:00
Nextcloud bot
642320c007
[tx-robot] updated from transifex
2021-02-16 03:48:18 +00:00
Nextcloud bot
10cd83fbb4
[tx-robot] updated from transifex
2021-02-15 03:43:56 +00:00
Nextcloud bot
be8521cdab
[tx-robot] updated from transifex
2021-02-14 03:41:47 +00:00
Kevin Ottens
0996b13386
Merge pull request #2928 from nextcloud/add_missing_override_specifier
...
Add missing override specifier
2021-02-13 11:32:46 +01:00
Felix Weilbach
29e1a82f56
Add missing override specifer to WebFlowCredentials
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-13 10:22:01 +00:00
Nextcloud bot
6a3260ec26
[tx-robot] updated from transifex
2021-02-13 03:44:20 +00:00
Camila
24ab49da18
Merge pull request #2914 from marcohald/master
...
Configuration Options for Windows Registry
2021-02-12 19:06:04 +01:00
marcohald
6032f2baef
Merge branch 'master' into master
2021-02-12 15:19:34 +01:00
Marco Hald
43ed8423e5
Configuration Options for Windows Registry
...
Added the configuration options
confirmExternalStorage
crashReporter
newBigFolderSizeLimit
useNewBigFolderSizeLimit
to the Windows registry
Signed-off-by: Marco Hald <marcohald@users.noreply.github.com >
2021-02-12 12:23:51 +01:00
Kevin Ottens
81831fd69a
Merge pull request #2919 from nextcloud/validate_ssl_providers_certificate
...
Validate the providers ssl certificate
2021-02-12 10:50:41 +01:00
Felix Weilbach
74d07e28cf
Validate the providers ssl certificate
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-12 08:25:59 +00:00
Nextcloud bot
6ff3d67f61
[tx-robot] updated from transifex
2021-02-12 03:44:56 +00:00
Nextcloud bot
c6cd25c5ce
[tx-robot] updated from transifex
2021-02-11 03:44:29 +00:00
Nextcloud bot
71547dc619
[tx-robot] updated from transifex
2021-02-10 03:51:25 +00:00
allexzander
7f92d8dccb
Merge pull request #2906 from nextcloud/fix-url-scheme-security-issue
...
Validate sensitive URLs to onle allow http(s) schemes.
2021-02-09 16:42:17 +02:00
allexzander
013f3cea70
Validate sensitive URLs to onle allow http(s) schemes.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-09 15:00:35 +02:00
allexzander
e97b7d8a25
Default parameter nullptr widget for openBrowser.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-09 08:40:51 +00:00
Nextcloud bot
18a82da494
[tx-robot] updated from transifex
2021-02-09 03:44:37 +00:00
Nextcloud bot
6be88c6d37
[tx-robot] updated from transifex
2021-02-08 03:44:42 +00:00
Nextcloud bot
ca0591c4e0
[tx-robot] updated from transifex
2021-02-07 03:45:41 +00:00
Nextcloud bot
2bce09801e
[tx-robot] updated from transifex
2021-02-06 03:48:23 +00:00
allexzander
496f174232
Merge pull request #2904 from ivaradi/ui-namespace
...
Move FolderCreationDialog into the OCC namespace
2021-02-05 19:19:56 +02:00
István Váradi
92f1074fcc
Put FolderCreationDialog into the OCC namespace.
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-02-05 16:27:25 +01:00
Nextcloud bot
f455f9969f
[tx-robot] updated from transifex
2021-02-05 03:48:33 +00:00
Kevin Ottens
1c1301e482
Merge pull request #2892 from nextcloud/repair_e2ee_on_non_remote_root_sync_folder
...
Repair E2EE on sync folders which don't point to the root of the server on the remote end
2021-02-04 13:24:18 +01:00
Kevin Ottens
856f0567a7
Make sure we pass a full remote path to LSCOL jobs
...
Indeed the path we have is supposedly not fully qualified in case of a
sync folder which doesn't point to / on the remote end. But LSCOL works
with absolute paths on the server so make sure this is what we give it
out.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-02-04 11:16:48 +00:00
Kevin Ottens
dd83efb543
The e2eMangledName was relative to the remote folder, repair it
...
This got broken during the huge discovery refactoring. I wrongly passed
the mangled name as is out of discovery, but coming from listing jobs it
was fully qualified while the jobs at propagation time and the db expect
those paths to be relative to the remote folder.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-02-04 11:16:48 +00:00
allexzander
2c8fa40fb6
Merge pull request #2897 from nextcloud/allow-creation-of-new-folders-from-the-settings-dialog
...
Allow creation of new folders from the Settings Dialog.
2021-02-04 10:28:05 +02:00
allexzander
81a090b362
Allow creation of new folders from the Settings Dialog.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-04 10:05:18 +02:00
Nextcloud bot
93b26bc666
[tx-robot] updated from transifex
2021-02-04 03:43:39 +00:00
allexzander
a94c109646
Merge pull request #2901 from nextcloud/win-tests-compilation-hot-fix
...
Win tests compilation fix.
2021-02-03 20:12:56 +02:00
allexzander
3d266b9246
Win tests compilation fix. For Windows, the build was failing because of not being able to locate #include <sqlite3.h> in tests.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-03 13:52:10 +02:00
Nextcloud bot
6d634c79ee
[tx-robot] updated from transifex
2021-02-03 03:58:51 +00:00
Felix Weilbach
6803256cb3
Merge pull request #2900 from nextcloud/make_sure_theme_resources_are_loaded
...
Load the theme resource explictly
2021-02-02 19:34:50 +01:00
Kevin Ottens
55fd0562de
Load the theme resource explictly
...
Otherwise they won't be loaded automatically at startup leading to lots
of missing icons. Since they're now in a static library they need that
explicit loading.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-02-02 18:33:45 +01:00
Camila
0521dce174
Merge pull request #2834 from nextcloud/compile_nextcloud_as_lib
...
Compile nextcoud gui as separate library
2021-02-02 14:44:40 +01:00
Felix Weilbach
d8493a9b3b
Add automoc property to updater
...
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-02-02 13:35:04 +00:00
Felix Weilbach
02dd363feb
Add test utils library
...
The test utils library collects all dependencies that are needed for
tests and gets automatically linked with every test.
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-02-02 13:35:04 +00:00
Felix Weilbach
73a41d8e34
Compile nextcoud gui as separate library
...
Compiling nextcoud gui as a separate library. This is needed to more
easily write tests. The whole nextcloud application can now be linked
against the tests.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-02 13:35:04 +00:00
Kevin Ottens
c19f048774
Merge pull request #2894 from nextcloud/fix-docs
...
Documentation: break line in config example.
2021-02-02 11:40:11 +01:00
Camila
3087a09c45
Documentation: break line in config example.
...
Also make sure the following note is not displayed as one block with the
config example.
Minor change: fix typo.
Signed-off-by: Camila <hello@camila.codes >
2021-02-02 10:51:34 +01:00
Nextcloud bot
b66d48a5d7
[tx-robot] updated from transifex
2021-02-02 03:40:51 +00:00
Nextcloud bot
cf2adc0446
[tx-robot] updated from transifex
2021-02-01 03:46:58 +00:00
Nextcloud bot
2fc7947c7b
[tx-robot] updated from transifex
2021-01-31 03:43:48 +00:00
Nextcloud bot
a1d264aaac
[tx-robot] updated from transifex
2021-01-30 03:51:02 +00:00
Nextcloud bot
79be34ce32
[tx-robot] updated from transifex
2021-01-29 03:49:40 +00:00
Nextcloud bot
5ee4c7a0ff
[tx-robot] updated from transifex
2021-01-28 03:59:43 +00:00
Kevin Ottens
d176b96b43
Merge pull request #2874 from nextcloud/more_active_stalebot
...
Reduce exempt labels list to give a chance to stale bot to do something
2021-01-27 19:33:18 +01:00
Kevin Ottens
cc681d094a
Reduce exempt labels list to give a chance to stale bot to do something
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-27 18:15:26 +00:00
Kevin Ottens
ab6ba2212a
Merge pull request #2877 from nextcloud/revert_2875
...
Revert "Specify PUBLIC for the link targets to make them visible to w…
2021-01-27 19:14:16 +01:00
Kevin Ottens
1456d6e433
Revert "Specify PUBLIC for the link targets to make them visible to windeployqt"
...
This reverts commit 002abdc38b .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-27 19:06:23 +01:00
allexzander
ac5a277e39
Merge pull request #2872 from nextcloud/use-push-notifications-for-activities-in-tray
...
Use push notifications for Tray activities/notifications fetch trigger.
2021-01-27 20:02:04 +02:00
allexzander
8c4d5333c1
Use push notifications for Tray activities/notifications fetch trigger.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-27 19:53:28 +02:00
Kevin Ottens
f2ffa74a7b
Merge pull request #2875 from nextcloud/make_qtwebsockets_visible_to_windeployqt
...
Specify PUBLIC for the link targets to make them visible to windeployqt
2021-01-27 18:07:51 +01:00
Kevin Ottens
002abdc38b
Specify PUBLIC for the link targets to make them visible to windeployqt
...
I went full steam on making it all public which is not really required,
it's only really QtWebSockets we're after. Could always be fine tuned
later on if this works as expected.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-27 18:00:26 +01:00
Kevin Ottens
c7d9e11d89
Merge pull request #2867 from nextcloud/fix_file_resolve_dialog
...
Start file conflict resolve dialog asynchronous
2021-01-27 09:10:32 +01:00
Felix Weilbach
51d8cf8102
Start file conflict resolve dialog asynchronous
...
Fixes #2804
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-01-27 08:01:25 +00:00
Kevin Ottens
71f0b45412
Merge pull request #2732 from nextcloud/Valdnet-patch-2
...
Replace dots with ellipses and add spaces.
2021-01-27 08:59:48 +01:00
Valdnet
d8a88fd047
Replace dots with ellipses and add spaces.
2021-01-27 07:36:52 +00:00
Nextcloud bot
4567c2b0a2
[tx-robot] updated from transifex
2021-01-27 03:47:28 +00:00
Kevin Ottens
90a7f583b2
Merge pull request #2868 from nextcloud/vfs_cfapi_dont_mistake_unpinned_directory_for_files_to_dehydrate
...
Don't treat new folders in unpinned folders as files to dehydrate
2021-01-26 18:27:24 +01:00
Kevin Ottens
ebfe51b7e7
Don't treat new folders in unpinned folders as files to dehydrate
...
This would only happen if the parent of the newly created folder would
be explicitly set to online only, hence why it went under the radar
previously.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 17:09:24 +00:00
Kevin Ottens
d119fc4749
Merge pull request #2733 from nextcloud/Valdnet-patch-3
...
Move space in "owncloudadvancedsetuppage.cpp"
2021-01-26 18:07:30 +01:00
Valdnet
817d460b84
Move space in "owncloudadvancedsetuppage.cpp"
2021-01-26 16:40:46 +00:00
Kevin Ottens
56b7ec70f4
Merge pull request #2840 from nextcloud/avoid_keeping_account_alive_from_subobject
...
Avoid keeping Account alive via a shared ptr in ClientSideEncryption
2021-01-26 14:00:27 +01:00
Kevin Ottens
d20fc1a6ce
Remove unused method
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 11:20:13 +00:00
Kevin Ottens
4168c0d082
Avoid keeping Account alive via a shared ptr in ClientSideEncryption
...
This account object was really only used during the initialization phase
or for forgetting the sensitive data. So let's receive it as parameter
there and pass it on from job to job as needed.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 11:20:13 +00:00
Kevin Ottens
737158e9b4
Merge pull request #2865 from nextcloud/vfs_cfapi_dont_get_stuck
...
VFS CfAPI implementation shouldn't get stuck
2021-01-26 12:19:07 +01:00
Kevin Ottens
21035d48a6
Don't crash when the same request is filled twice
...
The OS might request the same file again if we take too much time to
fulfill a request. So in case it's queueing the same one again instead
of bailing out just fail the second one and let the first one finish
properly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 10:58:14 +00:00
Kevin Ottens
d3c7218ee8
Be a bit more resilient with errors
...
In case we'd been to slow to fullfill or we're still processing a
cancelled request better not just crash. We still log the issue though.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 10:58:14 +00:00
Nextcloud bot
6a4da69a62
[tx-robot] updated from transifex
2021-01-26 03:45:50 +00:00
Kevin Ottens
76d0fb254b
Merge pull request #2734 from nextcloud/Valdnet-patch-4
...
Move space in "folderwizard.cpp"
2021-01-25 18:51:15 +01:00
Valdnet
f365ec1e4c
Move space in "folderwizard.cpp"
2021-01-25 17:42:38 +00:00
Kevin Ottens
24ee350ef3
Merge pull request #2735 from nextcloud/Valdnet-patch-5
...
Change the quotation marks
2021-01-25 18:41:31 +01:00
Valdnet
8539dc7dc6
Change the quotation marks
2021-01-25 17:33:46 +00:00
Kevin Ottens
8c66b9f89e
Merge pull request #2814 from nextcloud/files_push_notifications
...
Add push notifications for file changes
2021-01-25 18:17:39 +01:00
Felix Weilbach
78f00acaa2
Add push notifications for file changes
...
Resolves #2802
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-01-25 17:01:09 +00:00
Kevin Ottens
fd604ddc9e
Merge pull request #2864 from nextcloud/fixes_for_wizard_advanced_setup
...
Fixes for wizard advanced setup
2021-01-25 17:45:02 +01:00
Kevin Ottens
4992bfa8ef
Ensure the right radio is selected when selective sync is picked
...
This got broken previously when trying to reconcile during a
cherry-pick. This also repairs the case when the theme tells us the
default is to not select anything (not that we're using this right now
but in case we'd like to brand this).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-25 16:53:21 +01:00
Kevin Ottens
2b2dac10ef
It's not really recommended anymore at least not on Windows
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-25 16:24:44 +01:00
allexzander
bc753d5fba
Merge pull request #2853 from nextcloud/e2ee-fix-rename-root-folder-issue
...
E2ee fix rename root folder issue & Fix upload stuck issue due to incorrect Lock/Unlock sequence
2021-01-25 10:44:25 +02:00
allexzander
eb80f54dcf
E2EE Fix incorrect name of a nested encrypted item in the Settings dialog when the root folder is non-encrypted and it is renamed.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-25 10:35:54 +02:00
allexzander
483a874cb6
Fix folder upload issue due to wrong Lock/Unlock order
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-25 10:35:30 +02:00
allexzander
79fe231acc
Fix E2EE root folder rename issue.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-25 10:35:30 +02:00
Kevin Ottens
18f5b841e3
Merge pull request #2859 from nicolasfella/qt5153
...
Fix build against Qt 5.15.3
2021-01-25 09:35:08 +01:00
Nicolas Fella
ab064c92b6
Fix build against Qt 5.15.3
...
Use QLatin1Char to prevent build error due to stricter QT_NO_CAST_FROM_ASCII
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-01-25 08:19:49 +00:00
Kevin Ottens
398101ae3d
Merge pull request #2860 from nextcloud/rakekniven-patch-2
...
Removed blank before colon
2021-01-25 09:18:46 +01:00
rakekniven
c3403b83ef
Removed blank before colon
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2021-01-25 08:08:13 +00:00
Nextcloud bot
04df193539
[tx-robot] updated from transifex
2021-01-25 03:44:11 +00:00
Nextcloud bot
a916e5a64d
[tx-robot] updated from transifex
2021-01-24 03:42:11 +00:00
Nextcloud bot
b8a56e0b4b
[tx-robot] updated from transifex
2021-01-22 03:47:57 +00:00
Kevin Ottens
b43701822f
Merge pull request #2845 from nextcloud/default_to_colored_systray_on_linux
...
Default to colored systray on linux
2021-01-21 08:01:58 +01:00
Kevin Ottens
48f0c54a90
Fix the branding detection for monochrome icons on Mac
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-21 06:39:11 +00:00
Kevin Ottens
96b2b2a509
Revert "Make monochrome icons the default on Linux and Mac OS."
...
This reverts commit 016410dbaa .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-21 06:39:11 +00:00
Nextcloud bot
fdaf04e4e5
[tx-robot] updated from transifex
2021-01-21 03:46:57 +00:00
Kevin Ottens
7f51355dc8
Merge pull request #2844 from nextcloud/handle_svg_branded_clients
...
Handle SVG branded clients
2021-01-20 16:08:01 +01:00
Kevin Ottens
471bb25e62
Use APPLICATION_ICON_SET for themed icons
...
We now favor APPLICATION_ICON_SET to isBranded() regarding the decision
to use PNG or SVG for icons.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 15:11:57 +01:00
Kevin Ottens
88986749a4
Use the SVG wizard logo when APPLICATION_ICON_SET says so
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 15:09:58 +01:00
Kevin Ottens
4b4437787f
Add the APPLICATION_ICON_SET option
...
Also mention the svg possibly used in the wizard
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 10:41:16 +01:00
Kevin Ottens
0b135ae644
Reference the wizard_logo.svg file from the resources
...
Somehow this was missing
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 10:10:22 +01:00
Nextcloud bot
93e8aea19e
[tx-robot] updated from transifex
2021-01-20 03:47:11 +00:00
Nextcloud bot
b1780f9b03
[tx-robot] updated from transifex
2021-01-19 03:45:22 +00:00
Nextcloud bot
6bded34856
[tx-robot] updated from transifex
2021-01-18 03:44:21 +00:00
Nextcloud bot
d87538da8b
[tx-robot] updated from transifex
2021-01-17 03:43:43 +00:00
Nextcloud bot
d30ae39890
[tx-robot] updated from transifex
2021-01-16 03:42:11 +00:00
Nextcloud bot
e353d79881
[tx-robot] updated from transifex
2021-01-15 03:49:34 +00:00
Camila
0d33ed048f
Merge pull request #2827 from nextcloud/apply_version_suffix_to_msi_filename
...
Integrate the version suffix to the MSI filename
2021-01-14 21:14:46 +01:00
Kevin Ottens
576a25161b
Integrate the version suffix to the MSI filename
...
This should be enough to reinstate the "-daily" marker in the filename
for daily builds.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 19:24:42 +00:00
Kevin Ottens
bc78ee0ca8
Merge pull request #2826 from nextcloud/reference_coding_style_wiki_page
...
Reference coding style wiki page from CONTRIBIUTING.md
2021-01-14 19:01:36 +01:00
Felix Weilbach
60a3c27d84
Merge branch 'master' into reference_coding_style_wiki_page
2021-01-14 09:49:55 -08:00
Felix Weilbach
b8277355ec
Reference coding style wiki page from CONTRIBIUTING.md
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-01-14 18:47:52 +01:00
Kevin Ottens
314f714082
Merge pull request #2824 from nextcloud/e2ee-can-not-move-folder
...
Fix e2ee folder move issue
2021-01-14 15:12:17 +01:00
allexzander
96472320e4
Fix e2ee folder move issue
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-14 15:54:30 +02:00
Kevin Ottens
c34c0f078b
Merge pull request #2793 from nextcloud/xattr_backend_for_vfs
...
XAttr backend for VFS
2021-01-14 14:30:39 +01:00
Kevin Ottens
1aeb77c967
Add the XAttr backend prototype with its test suite
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:03 +01:00
Kevin Ottens
7c8b7db725
Don't detect file changes during hydration for virtual files
...
Indeed, that file size will almost always change between the 1 byte
placeholder and the hydrated file. Only when using the CfAPI on Windows
this won't be the case since because it will expose the original size
even for placeholders.
Also worth noting: the suffix backend didn't hit that case since the
filename changes (with suffix for placeholders, without for hydrated
files).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:03 +01:00
Kevin Ottens
6e51dcf9c6
Provide the path to the current folder to statTypeVirtualFile on unix
...
Otherwise backends can't get to the actual file which will be needed for
the XAttr backend.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:03 +01:00
Kevin Ottens
a89b483773
Add the plumbing for a new extended attributes backend
...
Ideally this will end up being the backend we use for both Linux and
macOS but that will require work with desktop environments on the Linux
side and to reverse engineering at least on xattr value on macOS.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:02 +01:00
Kevin Ottens
4a1c650a56
Merge pull request #2821 from nextcloud/e2ee-fix-parallel-uploads-issue
...
E2EE fix upload parallelism issue.
2021-01-14 11:41:52 +01:00
allexzander
bf5b214e0e
E2EE fix upload parallelism issue.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-14 06:59:05 +00:00
Nextcloud bot
6656b23922
[tx-robot] updated from transifex
2021-01-14 03:47:20 +00:00
Camila
13930c084c
Merge pull request #2823 from nextcloud/repair_chunked_uploads
...
Repair chunked uploads
2021-01-13 18:28:28 +01:00
Kevin Ottens
5325e058d8
Repair chunked uploads
...
There's been a confusion between the chunk number and the chunk
offset leading to corruptions... Let's pass the proper offset to
the UploadDevice again.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-13 18:00:19 +01:00
Nextcloud bot
f7be923b73
[tx-robot] updated from transifex
2021-01-13 03:52:05 +00:00
Camila
731e8a2679
Merge pull request #2815 from nextcloud/update-docs
...
Update Github issue template and documentation with the new 3.1 option to "Create Debug Archive".
2021-01-12 19:34:25 +01:00
Camila
bba376e944
Update documentation with the new 3.1 option to "Create Debug Archive".
...
Signed-off-by: Camila <hello@camila.codes >
2021-01-12 18:38:43 +01:00
Camila
250fcf380b
Fix documentation path in instruction of doc/README.
...
Signed-off-by: Camila <hello@camila.codes >
2021-01-12 18:38:43 +01:00
Camila
c6fe097535
Update Github issue template with the new 3.1 option to "Create Debug Archive".
...
Also:
- cleaned up some of the text: nobody read that and it was mostly
from a time when this team was only one person.
- remove references to e2ee known issues. Not relevant anymore.
Signed-off-by: Camila <hello@camila.codes >
2021-01-12 18:38:30 +01:00
Nextcloud bot
4ae7224151
[tx-robot] updated from transifex
2021-01-12 03:48:28 +00:00
allexzander
7dc19b90bd
Merge pull request #2799 from nextcloud/e2ee-root-folder-remove-issue
...
E2ee root folder remove issue
2021-01-11 21:20:03 +02:00
allexzander
4ed7feab2b
Implement nested items removal when removing root encrypted folder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-11 21:12:58 +02:00
Nextcloud bot
ff661d47d4
[tx-robot] updated from transifex
2021-01-10 04:02:55 +00:00
Nextcloud bot
6cc9a721a6
[tx-robot] updated from transifex
2021-01-09 03:59:04 +00:00
Nextcloud bot
12053c98eb
[tx-robot] updated from transifex
2021-01-08 04:02:38 +00:00
Kevin Ottens
8d5d45ea5c
Merge pull request #2801 from nextcloud/fix_cfapi_win32_build
...
Fix CfAPI Win32 build
2021-01-07 15:33:45 +01:00
Kevin Ottens
2d8eb19ee5
Second attempt at fixing CfAPI wrapper build in Win32 mode
...
MSVC having so useless error messages it didn't quite point to the root
cause of the issue... it turns out that through the maze of macros
defined in the windows API, there's one which impacted the function
pointer definition of CfCloseHandle which would then not convert to
FileHandle::Deleter as expected. So I end up wrapping it in a lambda to
help... luckily this kind of lambdas decay into a simple function
pointer so there's likely no overhead it's just to coerce the compiler
into doing the right thing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-07 13:49:10 +01:00
Kevin Ottens
79a54d68ed
Revert "Fix CfAPI wrapper build in Win32 mode"
...
This reverts commit 3b3864296a .
2021-01-07 13:40:01 +01:00
Nextcloud bot
344a3c82fd
[tx-robot] updated from transifex
2021-01-07 03:58:16 +00:00
allexzander
33fb861ac8
Merge pull request #2800 from nextcloud/fix_cfapi_win32_build
...
Fix CfAPI wrapper build in Win32 mode
2021-01-06 19:08:29 +02:00
Kevin Ottens
3b3864296a
Fix CfAPI wrapper build in Win32 mode
...
For some reason MSVC manages to deduce the right constructor in Win64
mode but not in Win32 mode. So let's be more explicit about what we
return.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-06 17:07:50 +01:00
Nextcloud bot
a0facaf36d
[tx-robot] updated from transifex
2021-01-06 03:57:55 +00:00
Kevin Ottens
0bb6dcebd8
Merge pull request #2794 from FlexW/master
...
Remove NO_SHIBBOLETH flag and dead code
2021-01-05 14:17:25 +01:00
Felix Weilbach
db0f1e245d
Remove NO_SHIBBOLETH flag and dead code
...
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-01-05 12:58:58 +01:00
Nextcloud bot
0b5f42f832
[tx-robot] updated from transifex
2021-01-05 03:53:25 +00:00
Nextcloud bot
e210dd894d
[tx-robot] updated from transifex
2021-01-04 03:54:59 +00:00
Nextcloud bot
d66983fe99
[tx-robot] updated from transifex
2021-01-03 03:55:25 +00:00
Nextcloud bot
629caeff7b
[tx-robot] updated from transifex
2021-01-02 03:52:58 +00:00
Nextcloud bot
10a5538a83
[tx-robot] updated from transifex
2021-01-01 03:53:03 +00:00
Nextcloud bot
845dab2559
[tx-robot] updated from transifex
2020-12-31 04:02:00 +00:00
Kevin Ottens
fbd9f5126c
Merge pull request #2781 from nextcloud/cherry_pick_2020_w53
...
Cherry pick 2020 w53
2020-12-30 19:00:19 +01:00
Hannah von Reth
09cc988026
Fix a possible crash with the remove all files dialog
2020-12-30 16:20:43 +01:00
Kevin Ottens
da3ff631ef
Use Q_REQUIRED_RESULT directly like in other places
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 16:20:42 +01:00
Hannah von Reth
72b6118c3e
Mark vfs functions as OC_REQUIRED_RESULT
2020-12-30 16:17:48 +01:00
Hannah von Reth
aadda32633
Handle errors in convertToPlaceholder
2020-12-30 16:17:47 +01:00
Hannah von Reth
552427ffc3
Update windows launch on start binary location
...
Fixes : #7672
2020-12-30 16:17:47 +01:00
Dominik Schmidt
69915ab594
Fix testVersionOfInstalledBinary for brandings
2020-12-30 16:17:47 +01:00
Dominik Schmidt
67f9890320
Use owncloudcmd in testVersionOfInstalledBinary
...
... as it works without X in CI.
2020-12-30 16:17:47 +01:00
Dominik Schmidt
635d2b2da2
Fix style
2020-12-30 16:17:47 +01:00
Hannah von Reth
713a429675
Add todo for Qt 5.15
2020-12-30 16:17:47 +01:00
Hannah von Reth
1144473f5d
Cleanup pathtoUNC and its test
2020-12-30 16:17:46 +01:00
Hannah von Reth
51d73e27ea
Clarify comment
2020-12-30 16:17:46 +01:00
Hannah von Reth
3f873ed2ee
Simplify file comparison
2020-12-30 16:17:46 +01:00
Hannah von Reth
157d526129
Include auth type in http log
2020-12-30 16:17:46 +01:00
Hannah von Reth
f6f7789afa
Log the final http request
2020-12-30 16:17:41 +01:00
Kevin Ottens
c501eed365
Merge pull request #2778 from nextcloud/windows_cfapi_backend_for_vfs
...
Windows cfapi backend for vfs
2020-12-30 16:16:57 +01:00
Kevin Ottens
46a5bd6b25
Ensure we properly cancel hydration on server errors
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:59 +01:00
Kevin Ottens
e37a5f36b0
Don't look at virtual files data for the mimetype matches
...
Otherwise this would attempt to download the file everytime we check the
direct editor for a given file which wouldn't be adequate. Would also
lead to a deadlock in our case since that would happen in the main
thread and implicit hydration is driven from there as well.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
90fbb7d322
Implement callback between wrapper and vfs object for hydration requests
...
This comes with a test simulating an open request coming from another
process (although in our case it's really just a thread). The actual
hydration works as expected by cfapi, handling of encrypted files is for
now missing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
5d013accea
Improve test readability with a bunch of macros
...
Since we often checked the same file states to see if they were virtual,
non virtual or gone, let's factor this out. This way intent in tests is
clearer.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
691ab9a40a
Port the tests to the CfApiWrapper
...
This reduces code duplication and opportunities of mistakes between the
test and the implementation.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
7668c521c1
Split the CfAPI lower level code in a wrapper
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
423780bf79
Add initial version of the CfApi backend
...
For now this implements only the logic necessary to get a test suite
equivalent to the TestSyncVirtualFiles one to pass. It doesn't (yet)
honor request to fetch files from the system.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
216b251b40
One byte placeholders assumption only holds for the suffix backend
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:57 +01:00
Kevin Ottens
4d4b87c9c3
Don't consider CfApi backend as experimental
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:53 +01:00
Nextcloud bot
a23791c039
[tx-robot] updated from transifex
2020-12-30 03:48:58 +00:00
Nextcloud bot
473abb4c7a
[tx-robot] updated from transifex
2020-12-29 03:48:59 +00:00
Kevin Ottens
23efdd2ead
Merge pull request #2748 from nextcloud/rakekniven-patch-1
...
Removed translation for "etag" and changed spelling
2020-12-28 10:01:18 +01:00
rakekniven
267d987895
Changed spelling of "etag".
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-12-28 08:51:56 +00:00
rakekniven
e1979fdb33
Removed translation for "etag" and changed spelling
...
Shouldn't be translated.
Just checked https://en.wikipedia.org/wiki/HTTP_ETag and all available localized pages.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-12-28 08:51:56 +00:00
Nextcloud bot
19765e2be7
[tx-robot] updated from transifex
2020-12-27 03:52:01 +00:00
Nextcloud bot
12a7fb32a9
[tx-robot] updated from transifex
2020-12-26 03:45:58 +00:00
Nextcloud bot
e726d71425
[tx-robot] updated from transifex
2020-12-25 03:45:25 +00:00
Nextcloud bot
2b4bc9d517
[tx-robot] updated from transifex
2020-12-24 03:46:47 +00:00
Nextcloud bot
274b27d2e0
[tx-robot] updated from transifex
2020-12-23 03:47:06 +00:00
István Váradi
b1458ff56b
Merge pull request #2759 from ivaradi/ubuntu-hirsute
...
Add support for Hirsute
2020-12-22 10:55:48 +01:00
István Váradi
dadc053809
Add support for Hirsute
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-12-22 10:19:08 +01:00
Nextcloud bot
269d42d7d9
[tx-robot] updated from transifex
2020-12-22 03:48:05 +00:00
Kevin Ottens
1c46101dff
Merge pull request #2739 from hrittich/master
...
Fixed the autostart for AppImages. See #2504 .
2020-12-21 12:07:44 +01:00
Hannah Rittich
5fc778bfaa
Fixed the autostart for AppImages. See #2504 .
...
Signed-off-by: Hannah Rittich <hrittich@users.noreply.github.com >
2020-12-21 11:56:09 +01:00
Kevin Ottens
f7ec914380
Merge pull request #2749 from nextcloud/rakekniven-patch-2
...
Changed triple dot to ellipsis
2020-12-21 09:12:42 +01:00
rakekniven
29d968ab15
Changed triple dot to ellipsis
...
Reported at Transifex.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-12-21 08:00:29 +00:00
Nextcloud bot
e5d5be9dfe
[tx-robot] updated from transifex
2020-12-21 03:46:22 +00:00
Nextcloud bot
4ef8a0e69f
[tx-robot] updated from transifex
2020-12-20 03:48:31 +00:00
Nextcloud bot
060fa3e125
[tx-robot] updated from transifex
2020-12-19 03:46:53 +00:00
Nextcloud bot
0ae71a34b5
[tx-robot] updated from transifex
2020-12-18 03:48:04 +00:00
Kevin Ottens
92a968860d
Merge pull request #2726 from nextcloud/settings-ui
...
UI improvements: Settings dialog
2020-12-17 11:00:48 +01:00
Camila
0e0ea9d81a
Update the settings dialog window title.
...
Signed-off-by: Camila <hello@camila.codes >
2020-12-17 07:04:07 +00:00
Camila
625752f85d
General settings: move buttons to the bottom left of their group boxes.
...
Signed-off-by: Camila <hello@camila.codes >
2020-12-17 07:04:07 +00:00
Nextcloud bot
8fd2443ead
[tx-robot] updated from transifex
2020-12-17 03:46:16 +00:00
Kevin Ottens
0d084ee343
Merge pull request #2725 from nextcloud/default-mono-icons
...
Make monochrome icons the default on Linux and Mac OS.
2020-12-16 19:03:56 +01:00
Camila
016410dbaa
Make monochrome icons the default on Linux and Mac OS.
...
Unless it is branded with other icons.
Signed-off-by: Camila <hello@camila.codes >
2020-12-16 14:42:24 +01:00
Nextcloud bot
e3081476cd
[tx-robot] updated from transifex
2020-12-16 03:48:12 +00:00
Kevin Ottens
1d5c203044
Merge pull request #2700 from nextcloud/major_engine_update
...
Major engine update
2020-12-15 12:32:17 +01:00
Kevin Ottens
a938e7d05f
Adjust the appimage script to the buildsystem changes
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Kevin Ottens
af57a702ef
Workaround bug in older GCC used for the AppImage toolchain
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Kevin Ottens
0756497c3e
Get the excluded files test to pass again on Windows
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Kevin Ottens
c57eff6fd8
Please the clang-tidy overlord
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Hannah von Reth
c03a5da670
Don't warn if everything is fine
2020-12-15 11:01:53 +01:00
Hannah von Reth
4e373ca7ff
Remove now unneeded cmake test and define
2020-12-15 11:01:52 +01:00
Hannah von Reth
ebd8047cb6
Replace custome date parser QDateTime::fromString(value, Qt::RFC2822Date)
2020-12-15 11:01:52 +01:00
Hannah von Reth
40e07ef3e3
Fix unit tests by setting Date header
2020-12-15 11:01:52 +01:00
Hannah von Reth
9d9eadba8e
Use time the request was send,..
...
not when it was processed by the client, to determine the quality of the connection.
2020-12-15 11:01:08 +01:00
Hannah von Reth
6818b8e303
Speedup test build by compile the fake server just once
2020-12-15 10:59:27 +01:00
Hannah von Reth
1b4ccea083
Owncloud - virtual files smaller <1KB - problems with syncing
...
The issue was caused by gziped responses not providing a
content lenght header.
Fixes : #8248
2020-12-15 10:59:27 +01:00
Hannah von Reth
96eaef6dba
Pause sync when remove all dialog is displayed
...
Fixes : #8263
2020-12-15 10:59:27 +01:00
Hannah von Reth
c253b51249
Use enum instead of int
2020-12-15 10:59:27 +01:00
Hannah von Reth
befc373ea6
Fix test on systems where C:\ is not writeable
2020-12-15 10:59:27 +01:00
Hannah von Reth
dc42ebb793
Don't recurse the whole tree looking for a git dir, use PROJECT_SOURCE_DIR
2020-12-15 10:59:26 +01:00
Hannah von Reth
0eb8b01f0a
Fix usePlaceholders migration
2020-12-15 10:59:26 +01:00
Hannah von Reth
58bc9e837c
Remove junk files
2020-12-15 10:59:26 +01:00
Hannah von Reth
a083a37126
Fix vfs experimental text
2020-12-15 10:59:26 +01:00
Hannah von Reth
b2934a68bc
Fix folder permission check on NTFS
...
Fixes : #8187
2020-12-15 10:59:26 +01:00
Hannah von Reth
8dbdaed5c3
Fix condition
2020-12-15 10:59:26 +01:00
Hannah von Reth
e4a0222954
Append .exe to crashreporter path so it is better located
2020-12-15 10:59:25 +01:00
Hannah von Reth
440b31986a
Ensure the callback is triggered
2020-12-15 10:59:25 +01:00
Hannah von Reth
f6faba48e2
Don`t block main thread when displaying all files removed dialog
...
Fixes : #8170
2020-12-15 10:59:25 +01:00
Hannah von Reth
b4cb3ecb5a
Don't use exec() on dialogs
2020-12-15 10:59:25 +01:00
Hannah von Reth
4878042e61
Update libcrashreporter-qt
2020-12-15 10:59:25 +01:00
Hannah von Reth
7c65d38ba4
Draw active progressbar
...
Pass a widget to the progressbar in the folder delegate to draw the correct active state
2020-12-15 10:59:25 +01:00
Kevin Ottens
201dbd54db
Remove the plugin loader mechanism for VFS backends
...
We will have all the code in public anyway so it can just be compiled
in. Thus no need to go through the plugin loading dance. Replaced the
loading with factory functions. Kept mostly the same structure
otherwise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
7e5f81ea81
Allow to control availability of folders in the settings dialog
...
It felt odd to be able to control the encryption status in the settings
dialog but not the availability. Also availability was controllable on
the root, so let's make it widely available.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
70c2dc70a1
Resurrect the display of subfolders for VFS sync folders
...
This got removed from the settings since in that case selective sync
isn't supported. Unfortunately that's also necessary to display them to
allow encrypting folders via the context menu.
So we display the subfolders again but in the case of VFS we disable the
ability to (un)check them. They just have an icon, a name and a context
menu.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
9f0e0b0f6a
Update the FolderStatusModel when a folder encryption ends
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
596bfab6e1
Set the account state after E2EE is setup in the GUI
...
Otherwise we would not display the E2EE message if the account was
connected before the creation of the settings dialog. This was likely
caused by the delayed creation of the settings dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
f45e84f2ee
Remove empty action in the settings toolbar
...
This was causing an unwanted line in the middle of the bar.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
d63097475c
Fix typo and style
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
1acb2679dd
Get rid of now unused GetFolderEncryptStatusJob
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
36b8e7c2a4
Remove the encryption flag check from encrypted propagation code
...
If we use those encrypted propagation code paths, we already know from
the discovery phase (and thus the journal db) that the folders are
encrypted so no need to check again.
This will remove another expensive round trip with the server.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
b2533e6451
Remove encrypt status job fetching from ClientSideEncryption
...
This is now unused.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
d22046d679
No need to fetch encryption data separately before discovery
...
This step isn't necessary anymore, no one looks at ClientSideEncryption
for that information anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
580b36fe20
Remove unused methods on ClientSideEncryption
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
ce5edfdf4d
Stop using e2e()->isFolderEncrypted() in the folder wizard
...
We used the same approach than for the FolderStatusModel by getting the
is-encrypted property straight from the LSCOL job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
4fde05b8b6
FolderStatusModel now uses the LSCOL job result for encryption status
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
8e5a8d9fb9
FolderStatusModel LSCOL job now gets the is-encrypted property
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
7a4a359704
Stop using e2e()->isFolderEncrypted() in the jobs
...
Thanks to the new discovery algorithm, we got all the freshest E2EE
information straight from the database so reuse it instead of going
through an in memory copy.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
37a51872e1
Set the encrypted flag in the database when EncryptFolderJob succeeds
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
b667bdda14
Change EncryptFolderJob path convention
...
It had a different path convention than all the other jobs, most likely
for legacy reasons because of the tight coupling it had to the settings
dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
ee8e0fa332
Have the folder token inside the EncryptFolderJob
...
No need to look for a token on the outside we can just work properly by
keeping all the state encapsulated in the job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
af00ef1cca
Don't use getFileRecordByE2eMangledName in jobs anymore
...
Thanks to the new discovery algorithm we got both mangled and original
file names in the item so no need to go through the database for
nothing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
66f24241d8
Repair E2EE deletions
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
567f678fd5
Make sure the encrypted flag gets all the way to the journal db
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
961794669e
Repair E2EE uploads
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
1d07af07a5
Start hooking up E2EE to the new discovery algorithm
...
Now we pull the encrypted metadata during the discovery which is a
better approach than before. This shall remove the need for some of the
deep propfinds we have been using so far. It already simplifies the code
a bit for the download scenario.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
2cf76bbcbf
Repair the Windows Build
...
We now enforce the use of QStringLiteral and friends in some places,
but that feel through the cracks for some of the Windows specific code.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Hannah von Reth
dd3e70b667
VirtualFiles: Ensure the target location supports vfs
...
Fixes : #8131
2020-12-15 10:59:20 +01:00
Hannah von Reth
8796f25994
Log error code as hex
2020-12-15 10:59:20 +01:00
Hannah von Reth
44175aca94
Fix: Log chunked messages
2020-12-15 10:59:20 +01:00
Hannah von Reth
60011e8003
Remove vfs warning in the delegate, indicate them in the description instead
...
Fixes : #8139
2020-12-15 10:59:20 +01:00
Hannah von Reth
93152761a1
Use verbose function names instead of direct member access
2020-12-15 10:59:20 +01:00
Hannah von Reth
356192fb1d
Don't show 404 errors when manually creating folder sync pair.
...
Fixes : #7724
2020-12-15 10:59:20 +01:00
Hannah von Reth
1619cd5dcc
Use winvfs by default when adding folder sync connection
...
Fixes : #8083
2020-12-15 10:59:19 +01:00
Hannah von Reth
8460526df9
Clear cookies on logout
2020-12-15 10:59:19 +01:00
Hannah von Reth
0c57bb8869
Remove the use of goto from test/csync/std_tests/check_std_c_jhash.c
2020-12-15 10:59:19 +01:00
Hannah von Reth
f220151527
Remove the use of goto from src/csync/csync_exclude.cpp
2020-12-15 10:59:19 +01:00
Hannah von Reth
4f596dae8c
Log http status
...
Fixes : #8073
2020-12-15 10:59:19 +01:00
Hannah von Reth
020c6d6424
Fix placeholders are reverted to OnlineOnly
...
Fixes : #7779
2020-12-15 10:59:19 +01:00
Hannah von Reth
d58cdaeb2a
Crashreporter: Apply the same hdpi settings as to the main gui
...
Fixes : #8042
2020-12-15 10:59:18 +01:00
Hannah von Reth
0eabc75039
Improve log message
2020-12-15 10:59:18 +01:00
Hannah von Reth
f1f6257b5d
Windows VFS: Enable Windows VFS by default
2020-12-15 10:59:18 +01:00
Hannah von Reth
1aa1ea7bea
Return empty string instead of 1 as adler32 checksum for empty files
2020-12-15 10:59:18 +01:00
Hannah von Reth
23f7c51f70
Print checksum on mismatch
2020-12-15 10:59:18 +01:00
Hannah von Reth
fd6146d09e
Clazy: Fix some warnings
2020-12-15 10:59:18 +01:00
Hannah von Reth
3caf8276a2
Remove pointless warning
...
We also don't have a version entry in the db if thne db is new.
As I don't expect regular updates from 1.5 this message can just be removed.
Fixes : #8004
2020-12-15 10:59:17 +01:00
Hannah von Reth
2d66025d72
csync: apply strict QString handling
2020-12-15 10:59:17 +01:00
Hannah von Reth
bd62615aab
Clazy: Fix some warnigns
2020-12-15 10:59:17 +01:00
Hannah von Reth
d109d49b49
Ui: Hide selective sync settings if vfs is active
...
Fixes : #7976
2020-12-15 10:59:17 +01:00
Hannah von Reth
54cc2be00f
Fix assertion introduced by e1ca612c5d3087e02f6b7f8e454224e0b88e82ad
...
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787
e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
2020-12-15 10:59:17 +01:00
Hannah von Reth
93281c8560
Use const access where possible
2020-12-15 10:59:17 +01:00
Hannah von Reth
563b347567
csync: apply strict QString handling
2020-12-15 10:59:16 +01:00
Hannah von Reth
82dbf8b5e1
VFS: remove now unused parameter
2020-12-15 10:59:16 +01:00
Hannah von Reth
c1a91e91e7
Use the servers checksum type by default
2020-12-15 10:59:16 +01:00
Hannah von Reth
8c3749cbe2
Log state before specific assertion
2020-12-15 10:59:16 +01:00
Hannah von Reth
2887a93c40
Win: Use full Windows paths in file watcher and improve logging
2020-12-15 10:59:16 +01:00
Hannah von Reth
7fa7bc54c4
Win: Move hresultToQString from vfs plugin to Utility::formatWinError
2020-12-15 10:59:16 +01:00
Hannah von Reth
4589772393
Remove more legacy C code
2020-12-15 10:59:15 +01:00
Hannah von Reth
3dcbc9fa66
Tests: Port check_vio_ext to Windows
2020-12-15 10:59:15 +01:00
Hannah von Reth
47dc7e6c49
Remove custome string functions
2020-12-15 10:59:15 +01:00
Hannah von Reth
29c6f44124
Logging: Print enum before cast in SqlQuer::bindValue
2020-12-15 10:59:15 +01:00
Hannah von Reth
b9638bc778
Fix warning
...
warning C4573: the usage of 'QObject::disconnect' requires the compiler to capture 'this' but the current default capture mode does not allow it
2020-12-15 10:59:15 +01:00
Hannah von Reth
e38b43123c
Log: Only print 'Saved account settings' in debug mode
...
Don't log that there was no error...
2020-12-15 10:59:15 +01:00
Hannah von Reth
c9ee0a0343
Log: Improve log message [ info gui.folder ]: Folder sync result: 4...
...
by including the name of the folder and print the name of the result
2020-12-15 10:59:15 +01:00
Hannah von Reth
fb34f8ea85
Gui: Don't try to display the wizard during shutdown
...
Fixes : #7936
2020-12-15 10:59:14 +01:00
Hannah von Reth
4f8928d35e
Remove dead code
2020-12-15 10:59:14 +01:00
Hannah von Reth
c5b59bf3b1
Make ownCloud accassible on the Application object
2020-12-15 10:59:14 +01:00
Hannah von Reth
4645e69147
Remove ifdef(Q_OS_X11) code, there never was such a define.
...
As noone complained since I don't think anyone will miss the code
2020-12-15 10:59:14 +01:00
Hannah von Reth
e4b7ed8fd6
A pedantic .desktop parser want's a list to end with ;
2020-12-15 10:59:14 +01:00
Hannah von Reth
f932dfc648
VFS: Tell the vfs plugin whether we have multiple accounts
...
This allows us to decide on the presentation of the account
2020-12-15 10:59:14 +01:00
Hannah von Reth
a0d81df21e
UnitTests: Set a CookiesJar in FakeQNAM
2020-12-15 10:59:13 +01:00
Hannah von Reth
7e91166d7a
CMake: Remove krazy2 support, we now use clazy
2020-12-15 10:59:13 +01:00
Hannah von Reth
7fdb842ed2
VFS: Prevent duplicated navigation panel icon
...
Issue: #7748
2020-12-15 10:59:13 +01:00
Hannah von Reth
6c2c544713
Log HTTP requests and responses
...
Issue: #7873
2020-12-15 10:59:13 +01:00
Hannah von Reth
c92f70d4ff
Beautify flags
2020-12-15 10:59:13 +01:00
Hannah von Reth
2b95f919ad
Fix 3aeca58b316363dc12ad4b392750fc57e7a2965a
2020-12-15 10:59:13 +01:00
Hannah von Reth
6d2526a67d
Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value
2020-12-15 10:59:12 +01:00
Hannah von Reth
b492b69dfd
Fix 150a5b4d06600d140ddf05383fb74cda6ae6e941
2020-12-15 10:59:12 +01:00
Hannah von Reth
6fde08d9f7
Fix crash on settings migration
...
Fixes : #7878
2020-12-15 10:59:12 +01:00
Hannah von Reth
fa87b899fb
Fix usage of QMessageBox
...
Fixes : #7874
2020-12-15 10:59:12 +01:00
Hannah von Reth
11b9e3fa61
Fix order of pluginkit commands and modernise
2020-12-15 10:59:12 +01:00
Hannah von Reth
aaca3e7ce5
Use separate loggin category for upload v1 and ng
2020-12-15 10:59:12 +01:00
Hannah von Reth
eed4ffb823
Wizard: Raise own window
...
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
2020-12-15 10:59:11 +01:00
Hannah von Reth
baff0a6986
VFS Dialog: Don't enable on close button clicked
...
Issue: #7710
2020-12-15 10:59:11 +01:00
Hannah von Reth
1a1035d516
Remove unused struct
2020-12-15 10:59:11 +01:00
Hannah von Reth
b15c308170
Remvoe now unneeded SyncRunFileLog::directionToStr
2020-12-15 10:59:11 +01:00
Hannah von Reth
4681421b62
Remvoe now unneeded SyncRunFileLog::instructionToStr
2020-12-15 10:59:11 +01:00
Hannah von Reth
a1d8010eae
Cleanup moc_csync.cpp include
2020-12-15 10:59:11 +01:00
Hannah von Reth
4d615c31da
Rename csync_instructions_e -> SyncInsturctions
2020-12-15 10:59:10 +01:00
Hannah von Reth
8cbdb4451b
Remove now unneede csync_instruction_str
2020-12-15 10:59:10 +01:00
Hannah von Reth
caa04f6adb
Make bit flags better readable
2020-12-15 10:59:10 +01:00
Hannah von Reth
c803292829
Use Q_ENUM_NS for PinState
2020-12-15 10:59:10 +01:00
Hannah von Reth
86789a1280
Test: Disable parallelism to ensure serial execution
2020-12-15 10:59:10 +01:00
Hannah von Reth
38c4d5a406
Cookies: Do set cookies in DetermineAuthTypeJob too
...
As we don't support cookie based authentication anymore we can provide cookies here.
This fixes issues with loadbalancers access policy managers.
2020-12-15 10:59:10 +01:00
Hannah von Reth
f073997aee
Cookies: Don't override cookies with outdated values
...
This code was actually not breaking most cookie handling by accident.
As the raw cookies where not split properly we added cookies with values like
"key: val; key2 = val2; key3 = val3"
When the code was corrected we overwrote the newer values in the jar with
the old ones from a request.
2020-12-15 10:59:09 +01:00
Olivier Goffart
317d3735d7
SocketAPI: fix status after a failure to move
...
Issue #7759
2020-12-15 10:59:09 +01:00
Hannah von Reth
734e49765d
Test: Fix testMovedWithError for vfs mode
2020-12-15 10:59:09 +01:00
Hannah von Reth
85aefa4232
Sync: Fix handling of virtual files in error state
...
Issue: #7799
2020-12-15 10:59:09 +01:00
Hannah von Reth
7644be576f
Test: Add test for vfs failed move crash
2020-12-15 10:59:09 +01:00
Hannah von Reth
bcceb5c33d
[Gui] Implement raiseDialog on Windows
...
Issue: #7774
2020-12-15 10:59:09 +01:00
Hannah von Reth
12ae1e97c6
[SocketApi] Ensure listener still exists
2020-12-15 10:59:08 +01:00
Hannah von Reth
868b05f25b
Improve logging of issues during plugin loading
...
If the plugin could not be loaded the client calls qFatal
Make the loading warnings critical so they get printed before we crash
2020-12-15 10:59:08 +01:00
Hannah von Reth
d63d4cdf62
Don't insert items into the folder model if selectiveSync is not supported
...
This fixes an assertion in FolderStatusModel::SubFolderInfo::resetSubs
rowCount reported 0 but we actually had items in the model
2020-12-15 10:59:08 +01:00
Hannah von Reth
9176afe263
Make sure all cases are handled
2020-12-15 10:59:08 +01:00
Hannah von Reth
9b0788bdf8
[Gui] Fix vfs dialog not showing on Windows
2020-12-15 10:59:08 +01:00
Hannah von Reth
a9728b527a
Remove unused defines
2020-12-15 10:59:08 +01:00
Hannah von Reth
1dd01477c5
Use Q_ENUM_NS to pretty print csync enums
2020-12-15 10:59:07 +01:00
Hannah von Reth
5927beb08d
Fix potential null pointer access
...
https://sentry.io/organizations/owncloud/issues/1529161263/events/02509984b5ca42ffb3960d9c9e161414/?project=79001&statsPeriod=14d
2020-12-15 10:59:07 +01:00
Olivier Goffart
b7193e6a0e
Folder Wizard: warn when adding a folder which is the parent of a sync'ed folder
...
issue #7741
2020-12-15 10:59:07 +01:00
Hannah von Reth
13c9d6431d
Fix expansion of tree view on newly added accounts
...
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a
I removed a few lines of code there which are already part of fetchMore()
Fixes : #7336
2020-12-15 10:59:07 +01:00
Hannah von Reth
fdc3b7c8da
[Wizard] Make vfs dialog blocking
...
Calling the callback after the receiver was deleted caused a crash
Fixes : #7709
Fixes : #7711
2020-12-15 10:59:07 +01:00
Olivier Goffart
a6a0e361c1
fixup test
2020-12-15 10:59:07 +01:00
Olivier Goffart
9f2c67dca9
Tests: add a couple of move tests
...
This was an attempt to reproduce #7722 , but this actually does not
reproduce it
2020-12-15 10:59:07 +01:00
Hannah von Reth
106a35d242
[SSL] Print warning only if something changed
2020-12-15 10:59:06 +01:00
Hannah von Reth
ba87fc9e78
[SSL] Properly restore user accepted certificats
2020-12-15 10:59:06 +01:00
Hannah von Reth
c8dd333e31
[Sanity] Remove old ifdef
2020-12-15 10:59:06 +01:00
Hannah von Reth
9564e5e92e
Fix saving of cookies
...
Fixes : #7700
2020-12-15 10:59:06 +01:00
Hannah von Reth
3a3ccb0834
Don't hardcode PLUGINDIR
2020-12-15 10:59:06 +01:00
Olivier Goffart
7fd4a280f0
Make PluginFactory virtual to silent -Wnon-virtual-dtor warning
...
This is not necessary, but it also shouldn't hurt.
2020-12-15 10:59:06 +01:00
Olivier Goffart
1c10fceacc
SyncEngine: no need to use QAtomicInt
...
This was done because the propagator jobs where running in a thread a long
time ago, but this is no longer the case.
(Also QAtomicInt::load is marked as deprecated now)
2020-12-15 10:59:05 +01:00
Olivier Goffart
f81f96915f
ProxyAuthHandler Use QPointer instead of QWeakPointer
...
QWeakPointer::data is deprecated.
In this case we should use QPointer
2020-12-15 10:59:05 +01:00
Hannah von Reth
e08645f259
Remove old test scripts
...
Fixes: 7679
2020-12-15 10:59:05 +01:00
Hannah von Reth
466e8abc91
[Core] Include more information about the OS in the user agent
2020-12-15 10:59:05 +01:00
Hannah von Reth
edb51abdfd
Don't ignore file sync notification after an unlock
...
For a usual file sync event we check for actual changes in the local file,
after an unlock the local file might be unchanged so we need to sync it anyhow.
Fixes : owncloud/enterprise#3609
2020-12-15 10:59:05 +01:00
Hannah von Reth
3317e354f2
Prepend PLUGINDIR else its pointless
2020-12-15 10:59:05 +01:00
Hannah von Reth
b6e8d47644
Use Q_ENUM on AuthType to get the name printed in the log
2020-12-15 10:59:04 +01:00
Hannah von Reth
a3a872eefe
Add Actions to the Desktop file
2020-12-15 10:59:04 +01:00
Hannah von Reth
dabf7aaebc
Application: Allow to quit running instances by commandline
2020-12-15 10:59:04 +01:00
Hannah von Reth
fa82a4aff3
Cleanup
2020-12-15 10:59:04 +01:00
Hannah von Reth
6c19b02888
Disable http2 support for now
...
Issue: #7610
2020-12-15 10:59:04 +01:00
Olivier Goffart
0e7c56e81c
Don't show the "All files deleted" popup when unselecting everything with selective sync
...
Issue #7337
2020-12-15 10:59:04 +01:00
Olivier Goffart
4424eb7f07
AccountSettings: limit the clickable region of the 'add folder' button
...
Issue #7326
2020-12-15 10:59:03 +01:00
Olivier Goffart
b97c0ed8a2
Network Settings: Show a warning that proxy settings do not apply to localhost
...
Only show this if at least one account is detected to have an url that looks
like localhost, because this could otherwise be confusing
Issue #7169
2020-12-15 10:59:03 +01:00
Olivier Goffart
392d3c257c
Discovery: Allow more HTTP error code to be treated as ignored dir
...
The original code from csync was stopping at any error.
But we have been whitelisting soeme http error code one by one
to ignore the directory instead of aborting the sync.
However, as there are more requests to continue the sync in case
of error, just ignore most HTTP errors
Issue #7586
2020-12-15 10:59:03 +01:00
Hannah von Reth
43c7e32ee1
[libsync] Export verifyFileUnchanged
...
This fixes Windows builds that are broken since #7562 was merged
2020-12-15 10:59:03 +01:00
Olivier Goffart
66f7b27121
VFS: Do not overwrite existing files by placeholder
...
For issue #7557 and #7556
Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
2020-12-15 10:59:03 +01:00
Hannah von Reth
9807285abd
[Gui] Set proper hdpi attributes
2020-12-15 10:59:03 +01:00
Olivier Goffart
fc0aeb53b1
Discovery: fix TestSyncVirtualFiles::testExtraFilesLocalDehydrated on windows
...
On windows we do a test to know if we should change the case of the files,
but that conflict with the test that checks if the file was still there
when the filename is actually the same. Which can happen with virtual files
as they have two representation (the one with and without suffix).
2020-12-15 10:59:02 +01:00
Olivier Goffart
ca18bbc2ca
Test: Fix testsyncvirtualfiles test
...
Like previous commit, the failure was caused by two conflicting commits
2020-12-15 10:59:02 +01:00
Olivier Goffart
ecd3de61f5
Fix build of tests.
...
Resulted from a conflict between two patches
2020-12-15 10:59:02 +01:00
Christian Kamm
4c4cbf0d97
Vfs: Lots of tests and corrections for suffix edge cases
...
Avoid or deal with problems that happen when suffixed files exist on the
server or suffix and non-suffixed files exist locally.
See #7350 , #7261 .
2020-12-15 10:59:02 +01:00
Olivier Goffart
88f86a56b1
Discovery: Attempt to fix issue with windows VFS and new files
...
(or moved files)
As seen in the log of #7558 , a conflict may be issued by mistake.
See investigation in https://github.com/owncloud/client/issues/7558#issuecomment-547385362
This hopefully fix #7558
2020-12-15 10:59:02 +01:00
Olivier Goffart
513b0c723c
Account Settings: change the color of info message from green to blue
...
To avoid confusion with the color of "success"
Issue #7403
2020-12-15 10:59:02 +01:00
Olivier Goffart
4d7ed8f62c
Wizard: fix compilation warnings about unused variables
2020-12-15 10:59:01 +01:00
Olivier Goffart
115a53134c
SyncEngine: Save a bit of memory by not keeping a set of all filename
...
This is only used for conflict files, so only save conflict files.
(The _seenFile was used for other things in 2.5, but not anymore)
2020-12-15 10:59:01 +01:00
Olivier Goffart
83d743b66b
When moving is allowed but deleting is not, do not restore moved items
...
Issue #7293
2020-12-15 10:59:01 +01:00
Olivier Goffart
ee611e6004
Restoration items should appear in the sync protocol
...
When an item is downloaded because it is restored, it shall be shown in the
sync protocol.
(It is also going to be shown in the not synchronized for a short while, but
that's fine)
2020-12-15 10:59:01 +01:00
Olivier Goffart
cb38bb2b5e
Fix Upload of large (> 2GiB) files
...
Issue #7506
This is a regression introduced by the delta sync feature (as the chunk offset
changed from being the chunk number to be the byte offset, it needs to be a
qint64 now)
2020-12-15 10:59:01 +01:00
Christian Kamm
ee3279c904
Tests: Fail if the initial sync fails
2020-12-15 10:59:01 +01:00
Christian Kamm
9d422284af
Discovery: Distinguish readdir and closedir errors
2020-12-15 10:59:01 +01:00
Olivier Goffart
390af4d41b
Tests: introduce ItemCompletedSpy to avoid a bit of code duplication
2020-12-15 10:59:00 +01:00
Olivier Goffart
adbd3d869b
Fix warning about serverJob not being used
...
And fix a FIXME in the same time
2020-12-15 10:59:00 +01:00
Christian Kamm
89216daee6
Propagate dir: Never write the etag on remote mkdir #7481
...
It must always only be written once all children are successfully
propagated.
2020-12-15 10:59:00 +01:00
Hannah von Reth
dc55617144
Ensure the url is complete before we validate it
...
Fixes : #6722
2020-12-15 10:59:00 +01:00
Christian Kamm
c9476a11f4
Checksums: Explicitly close file before reporting result
...
To ensure it's no longer open when the finished signal fires.
2020-12-15 10:59:00 +01:00
Christian Kamm
e91e1ca78f
Test: Disable local discovery parallelism in permission test
...
Adding parallelism broke the test because it depended on the order of
discovery.
2020-12-15 10:59:00 +01:00
Christian Kamm
e596b55977
Discovery: Change local job signal signatures
...
To make it more explicit that data a copy of the data is transfered
between threads. (though Qt will make a copy of the arguments anyway)
2020-12-15 10:58:59 +01:00
Christian Kamm
71f71b38f1
Discovery: local job shouldn't be parented
...
Since it'll be deleted by the thread pool.
2020-12-15 10:58:59 +01:00
Christian Kamm
53a217d4e4
Don't store pointer to local job
...
There were crashes in the QPointer assignment. Possibly the thread pool
is done with the job and deletes it before the assignment is done.
2020-12-15 10:58:59 +01:00
Markus Goetz
26b5e36351
Discovery: List local directories from thread #7456 #7439
2020-12-15 10:58:59 +01:00
Markus Goetz
09a0dbbf82
Reconcile: Sort already during discovery #7445
2020-12-15 10:58:59 +01:00
Christian Kamm
a5c6612883
ConnectionValidator: increase timeout to 57s #7456
...
When the gui thread blocks for several seconds it's possible for the
ConnectionValidator to timeout and decide that the account is
unreachable. It will then terminate all sync runs.
Increasing the timeout makes this less likely to happen. The tradeoff is
that real disconnects will not be detected as quickly.
This does not address the root cause but makes the symptom less likely
to appear.
2020-12-15 10:58:59 +01:00
Markus Goetz
41dc68f99c
Propagator: Delay job execution a bit #7439
2020-12-15 10:58:58 +01:00
Christian Kamm
e37e954720
Discovery: Remove level of indent around moves
...
No code changes.
2020-12-15 10:58:58 +01:00
Christian Kamm
28797baa39
Discovery: If a move is forbidden, restore the source
...
Previously the source was deleted (or attempted to be deleted), even if
the new location was not acceptable for upload. This could make data
unavilable on the server.
For #7410
2020-12-15 10:58:58 +01:00
Christian Kamm
c9d1037622
Propagation: Fix delete-before-rename bug #7441
...
By introducing a PropagateRootDirectory job that explicitly
separates the directory deletion jobs from all the other jobs.
Note that this means that if there are errors in subJobs the
dirDeletionJobs won't get executed.
2020-12-15 10:58:58 +01:00
Markus Goetz
475117dd60
Propagator: Make sure we schedule only one job #7439
...
To not starve the event loop.
(There is still ~= 3 jobs running at the same time)
2020-12-15 10:58:58 +01:00
Christian Kamm
3446412d92
PropagateDownload: Don't try to open readonly temporaries
...
This situation could arrise when receiving a read-only share and the
temporary rename failed for some reason.
See #7419
2020-12-15 10:58:58 +01:00
Hannah von Reth
f78c4f851b
Change Windows virtual files description to tech preview
2020-12-15 10:58:57 +01:00
Christian Kamm
0ac8a3e6be
Don't fatal on "Storage temporarily unavailable"
...
This is an unreliable workaround. The real fix will need to be deferred
to another release.
For #5088
2020-12-15 10:58:57 +01:00
Hannah von Reth
afc9cd2f46
OwncloudWizard: Mark vfs as tech preview instead of experimental
2020-12-15 10:58:57 +01:00
Hannah von Reth
e5a36c3bc6
CMake VFS: Enable us to provided vfs plugins from an external directory
2020-12-15 10:58:57 +01:00
Dominik Schmidt
7e4d24de2b
SocketApi: Avoid unneccessary conversions
2020-12-15 10:58:57 +01:00
Dominik Schmidt
06ac1c33e8
SocketApi: cleanup debug output
2020-12-15 10:58:57 +01:00
Dominik Schmidt
25cd52dd9f
Add ASYNC_ASSERT_ICON_IS_EQUAL command to SocketApi
2020-12-15 10:58:57 +01:00
Dominik Schmidt
d1f9b1a4f8
Make findWidget more powerful
2020-12-15 10:58:56 +01:00
Dominik Schmidt
67656fb136
Add Q_PROPERTYs for gui testing
2020-12-15 10:58:56 +01:00
Dominik Schmidt
596154a01a
Switch GUI Testing SocketApi to Utf8
2020-12-15 10:58:56 +01:00
Dominik Schmidt
ad033e40fd
Fix build with recent Clang (on Linux)
2020-12-15 10:58:56 +01:00
Dominik Schmidt
3288a36da6
Add GUI testing SocketApi extension
2020-12-15 10:58:56 +01:00
Hannah von Reth
e97784bb9d
Don't use mutable lambdas as they hide where we modify work on a copy
2020-12-15 10:58:55 +01:00
Hannah von Reth
0f92713ce5
AccountSettings: Use switch, case to ensure we handle all cases
2020-12-15 10:58:55 +01:00
Christian Kamm
bade7aedc6
Checksums: Add back QIODevice api
...
Because the winvfs plugin needs it. But be more careful about the
device's lifetime this time.
2020-12-15 10:58:55 +01:00
Christian Kamm
18e1098e38
Remove maxLogLines config option
...
It's no longer used.
For owncloud/docs#1365
2020-12-15 10:58:55 +01:00
Christian Kamm
ea829f96ca
Download: Don't trigger too many concurrent hash computations
...
Previously the job would only become "active" when the downloads
started. That meant that arbitrarily many hash computations could be
queued at the same time.
Since the the file was opened during future creation this could lead to
a "too many open files" problem if there were lots of new-new conflicts.
To change this:
- Make PropagateDownload become active when computing a hash
asynchronously.
- Make the computation future open the file only once it gets run. This
will make it less likely for this problem to occur even if thousands
of these futures are queued.
For #7372
2020-12-15 10:58:55 +01:00
Christian Kamm
8a5a185752
Fix 'unused parameter name' warnings
2020-12-15 10:58:55 +01:00
Christian Kamm
c9dbe46542
Checksums: Fix crash due to threading issue
...
The checksum computation thread was potentially using a QFile that was
deleted in the gui thread.
For #7368
2020-12-15 10:58:54 +01:00
Christian Kamm
a587cd3a13
AccountSettings: Fetch subitems after wiping them
...
That helps avoid empty lists after account creation #7336
2020-12-15 10:58:54 +01:00
Christian Kamm
5761f4cd8a
SyncEngine: Don't duplicate fatal errors
...
Previously fatal error texts were duplicated: Once they entered the
SyncResult via the SyncFileItem and once via syncError().
syncError is intended for folder-wide sync issues that are not pinned
to particular files. Thus that duplicated path is removed.
For #5088
2020-12-15 10:58:54 +01:00
Christian Kamm
61972c35a8
Discovery: Parse etag to be consistent with RequestEtagJob
...
This avoids unnecessary sync runs.
For #7345
2020-12-15 10:58:54 +01:00
Christian Kamm
38c466efbf
Vfs: Require local discovery after disabling vfs
...
Without it local files aren't guaranteed to be downloaded #6936 .
2020-12-15 10:58:54 +01:00
Christian Kamm
55ee3f440b
Vfs: Remove old db record when dehydrating via rename
...
For #7338
2020-12-15 10:58:54 +01:00
Christian Kamm
e6990bd04e
Vfs: Make move detection work with virtual files #7001
...
Previously a checksum computation could be done on a suffix-placeholder
file, making discovery believe that no move took place.
2020-12-15 10:58:54 +01:00
Christian Kamm
00dcf3ef59
Vfs: Ensure pins change with (de-)hydration
...
Previously an implicit hydration of a file in an online-only folder
would not change the pin state and cause a dehydration on the next
sync.
2020-12-15 10:58:53 +01:00
Christian Kamm
0df3b83bd2
Vfs: Add hook to allow update-metadata for unchanged files
...
Allows winvfs to convert files to placeholders when vfs is enabled. This
is required to mark files as in-sync #7329 .
2020-12-15 10:58:53 +01:00
Christian Kamm
b34df4413b
Vfs: Improve strings for availability states
2020-12-15 10:58:53 +01:00
Christian Kamm
5bc2180478
Vfs: Preserve pin state on hydration
...
For #7322 and #7323
2020-12-15 10:58:53 +01:00
Christian Kamm
fc52c5d0cd
Vfs: Retain existing data when enabling vfs #7302
...
Previously all local data was deleted because the root folder was marked
as OnlineOnly.
2020-12-15 10:58:53 +01:00
Dominik Schmidt
92f6d866e1
Add missing OWNCLOUDSYNC_EXPORT
2020-12-15 10:58:52 +01:00
Christian Kamm
eb58352286
Vfs: Make test pass with different suffix #7279
2020-12-15 10:58:52 +01:00
Christian Kamm
5acb157a7e
VfsSuffix: Wipe stale pin states #7273
...
Previously the pin states of deleted files stayed in the 'flags'
database and could be inadvertently reused when a new file with the same
name appeared. Now they are deleted.
To make this work right, the meaning of the 'path' column in the 'flags'
table was changed: Previously it never had the .owncloud file suffix.
Now it's the same as in metadata.path.
This takes the safe parts from #7274 for inclusion in 2.6. The more
elaborate database schema changes (why use 'path' the join the two
tables in the first place?) shall go into master.
2020-12-15 10:58:52 +01:00
Christian Kamm
0e9f030b0f
RequestEtagJob: Consistently parse etags #7271
...
Previously RequestEtagJob did return the etag verbatim (including extra
quotes) while the db had the parsed form. That caused the etag
comparison during discovery move detection to always fail. The test
didn't catch it because the etags there didn't have quotes.
Now:
- RequestEtagJob will parse the etag, leading to a consistent format
- Tests have etags with quotes, detecting the problem
2020-12-15 10:58:52 +01:00
Christian Kamm
69fa1e4775
UploadDevice: Fix windows issues #7264
...
- Close the UploadDevice to close the QFile after the PUT job is done.
This allows winvfs to get an oplock on the file later.
- Don't rely on QFile::fileName() to be valid after
openAndSeekFileSharedRead() was called. The way it is openend on
Windows makes it have an empty filename.
2020-12-15 10:58:52 +01:00
Christian Kamm
fb47419e84
Vfs: Move pin state if files move #7250
...
Previously renames of items didn't carry the pin state with them.
2020-12-15 10:58:52 +01:00
Christian Kamm
34dc5e4e88
Vfs: Don't let new local files start out unpinned #7250
...
If one adds a new file to an online-only folder the previous behavior
was to upload the file in one sync and dehydrate it in the next. Now
these new files get set to Unspecified pin state, making them retain
their data.
2020-12-15 10:58:52 +01:00
Markus Goetz
62d876b09a
OAuth2: Better error logging
...
This does not fix a bug, just was found while spotting a bug that was no bug.
For https://github.com/owncloud/enterprise/issues/2951
2020-12-15 10:58:51 +01:00
Christian Kamm
452ed56571
Upload: Read file chunks gradually #7226
...
Instead of all at once, to reduce peak memory use.
Changing UploadDevice in this way requires keeping the file open for the
duration of the upload. It also means changes to open(), seek(), close()
to ensure that uses of the device work right when a request needs to
be resent.
2020-12-15 10:58:51 +01:00
Christian Kamm
a7852e3aba
Http2: Resend requests on ContentReSend error #7174
...
Since Qt does not yet transparently resend HTTP2 requests in some cases
we do it manually.
The test showed a problem where the initial non-200 reply would close
the target temporary file and the follow-up request couldn't store any
data. Removing that close() call is safe because there also is a
_saveBodyToFile flag that guards writes to the target file.
2020-12-15 10:58:51 +01:00
Olivier Goffart
c335f69a65
Discovery: Do not abort the sync in case of error 404 (or 500)
...
Issue: #7199
2020-12-15 10:58:51 +01:00
Olivier Goffart
9f08636a4a
SyncEngine: Fix renaming a single file cause the "delete all file" popup
...
Possibly a regression, since the new discovery discovers rist the renamed
files as removed
Issue #7204
2020-12-15 10:58:51 +01:00
Olivier Goffart
2c975b1e70
SocketAPI: Fix string claiming a folder is a file
...
Issue #7206
2020-12-15 10:58:51 +01:00
Markus Goetz
46c336503a
Log Window: Create and open folder properly #7166
2020-12-15 10:58:50 +01:00
Christian Kamm
ee1078b768
owncloudcmd: log sync errors
...
Previously it was hard to debug some errors since the messages would not
show up in the output.
2020-12-15 10:58:50 +01:00
Christian Kamm
b974f579ae
Chunked upload: Fix percent encoding in If header #7176
2020-12-15 10:58:50 +01:00
Christian Kamm
9f3578b276
Tests: Fix DB locking issue in permissions test
2020-12-15 10:58:50 +01:00
Christian Kamm
a0457d5e1d
Tests: fix vfs availability test case
2020-12-15 10:58:50 +01:00
Christian Kamm
edad7ce7d7
Vfs: Mark sqlite temporaries excluded on db-open #7141
...
The previous patch ensured that the sqlite temporaries weren't deleted
and recreated for every sync run, but there was still time between
client startup and the first sync run where they would have the
"needs-sync" icon.
2020-12-15 10:58:50 +01:00
Christian Kamm
7774b8049e
Vfs: Distinguish availability error kinds #7143
...
Previously "no-availability" meant db-error and querying the
availability of a nonexistant path returned AllHydrated.
Now, the availability has a DbError and a NoSuchItem error case.
2020-12-15 10:58:49 +01:00
Christian Kamm
1e5ae77994
Fix logic for duration that an etag reply indicates connectivity
...
This got inverted accidentally when std::chrono was introduced.
For #7160
2020-12-15 10:58:49 +01:00
Christian Kamm
7f3f13fd97
Vfs: "free space" only shows when it has an effect #7143
...
To do this, introduce AllDehydrated availability and rename
SomeDehydrated to Mixed - it now guarantees there are also hydrated
items.
2020-12-15 10:58:49 +01:00
Christian Kamm
40d9fc4f4b
Vfs: Adjust and centralise action text #7143
...
Saying "Currently available locally" sounds more like an indicator than
"Availably locally" does. Centralizing translations avoids consistency
issues between shell context menus and sync folder context menu.
2020-12-15 10:58:49 +01:00
Christian Kamm
021f994584
FolderWizard: Don't crash when typing invalid drive #7041
...
When the user typed "x:" where the drive x didn't exist, the validation
function would loop forever. Now it shows a "path doesn't exist" error.
2020-12-15 10:58:49 +01:00
Christian Kamm
21cb93e3ce
SyncEngine: Don't close db when done #7141
...
The db-close operation is likely a leftover from when the SyncEngine
owned its own db connection and serves no purpose anymore.
Closing the db causes the removal of the temporary wal and shm files.
These files are recreated when the db is opened again, which happens
almost immediately.
This is a problem for winvfs because the delete-recreate step wipes the
exclusion state on these files just after the sync is done. That meant
that the db temporaries permanently had a "needs sync" icon marker shown
in the explorer.
Avoiding reopening the db also reduces the number of log messages per
sync.
2020-12-15 10:58:48 +01:00
Christian Kamm
a4f357ee4b
Sqlite: Use FULL synchronous mode with non-WAL journal
...
According to the documentation DELETE+NORMAL isn't safe from corruption
on older file systems.
2020-12-15 10:58:48 +01:00
Christian Kamm
076e24f465
Log: Start logging immediately when "permanent logs" enabled #7146
...
Previously one would need to wait for the next sync run to create the
first log file.
2020-12-15 10:58:48 +01:00
Christian Kamm
772a210cc9
Mention selective sync when switching on vfs
2020-12-15 10:58:48 +01:00
Christian Kamm
cfbcdc01db
Discovery: Improvements to doc comments
2020-12-15 10:58:48 +01:00
Christian Kamm
fbe2dbf4ab
Discovery: Query data-fingerprint on root item
...
Previously the property wasn't queried, meaning the fingerprint logic
couldn't get triggered.
2020-12-15 10:58:48 +01:00
Christian Kamm
c50f041c5b
Discovery: 403 and 503 on root cause error
...
Previously these result codes during remote discovery of the sync root
would not cause an error and the discovery would get stuck.
Also extends RemoteDiscovery tests to check for errors on the root item.
2020-12-15 10:58:48 +01:00
Christian Kamm
7b96321df2
PropagateIgnore: Default to NormalError for INSTRUCTION_ERROR
...
Previously if one set the instruction to ERROR while forgetting to set
an error status, it'd propagate as FileIgnored. Now the default is
NormalError for INSTRUCTION_ERROR and FileIgnored for
INSTRUCTION_IGNORE.
2020-12-15 10:58:47 +01:00
Christian Kamm
da40e84aec
About: Add remark about vfs plugin that's in use #7137
2020-12-15 10:58:47 +01:00
Christian Kamm
2bffde2600
Fix windows build
2020-12-15 10:58:47 +01:00
Christian Kamm
22234e0e73
LogWindow: Remove output, add "go to log folder" button #6475
2020-12-15 10:58:47 +01:00
Christian Kamm
dcf34316fd
Vfs: Add 'availability', a simplified, user-facing pin state #7111
...
The idea is that the user's question is "is this folder's data available
offline?" and not "does this folder have AlwaysLocal pin state?".
The the answers to the two questions can differ: an always-local
folder can have subitems that are not always-local and are dehydrated.
The new availability enum intends to describe the answer to the user's
actual question and can be derived from pin states. If pin states aren't
stored in the database the way of calculating availability will depend
on the vfs plugin.
2020-12-15 10:58:47 +01:00
Christian Kamm
590db28541
Vfs: Clear up relationship between _type and pin state
...
The pin state is a per-item attribute that has an effect on _type:
AlwaysLocal dehydrated files will be marked for hydration and OnlineOnly
hydrated files will be marked for dehydration.
Where exactly this effect materializes depends on how the pin states are
stored. If they're stored in the db (suffix) the dbEntry._type is
changed during the discovery.
If the pin state is stored in the filesystem, the localEntry._type must
be adjusted by the plugin's stat callback.
This patch makes pin states behave more consistently between plugins.
Previously with suffix-vfs pin states only had an effect on new remote
files. Now the effect of pinning or unpinning files or directories is as
documented and similar to other plugins.
2020-12-15 10:58:46 +01:00
Christian Kamm
2738f110f2
Sqlite: Update to 3.27.2
2020-12-15 10:58:46 +01:00
Christian Kamm
cd10e3d28c
PropagateDirectory: Set initial dir mtime to server mtime #7119
...
It's still not synced in any way later.
2020-12-15 10:58:46 +01:00
Christian Kamm
69887c531e
PropagateDirectory: Remove dead code
...
1. The _firstJob is usually deleted by the time the PropagateDirectory
finishes. (deleteLater() is called early)
2. The PropagateDirectory::_item and PropagateRemoteMkdir::_item point
to the same SyncFileItem anyway. This code is a leftover from when
each job had its own instance.
2020-12-15 10:58:46 +01:00
Christian Kamm
fd9b01981b
Detect missing server data during discovery #7112
...
This has two positive effects:
- We can put the error on the particular file that has missing data
- We can sync all other files
2020-12-15 10:58:46 +01:00
Christian Kamm
4bab93b246
Vfs: Better handling and more tests for suffix file renames
...
Previously removing the vfs suffix of a file always triggered a
conflict. Now it may just cause a file download.
This was done because users expected symmetry in the rename actions and
renaming foo -> foo.owncloud already triggers the "make the file
virtual" action. Now foo.owncloud -> foo triggers the "download the
contents" action.
2020-12-15 10:58:46 +01:00
Christian Kamm
5e5b0b3f76
Vfs suffix: Require suffix when creating placeholder files
2020-12-15 10:58:45 +01:00
Christian Kamm
3f55f9302e
Vfs: Hydrating a virtual is SYNC not NEW #7101
...
Previously it'd be NEW(ItemTypeFile), but now it has changed to be
SYNC(ItemTypeVirtualFileDownload) which allows better classification.
2020-12-15 10:58:45 +01:00
Christian Kamm
e0c8acc195
Notifications: Don't say "downloaded" for new files #7101
...
These files may very well just be new virtual files that were explicitly
*not* downloaded.
2020-12-15 10:58:45 +01:00
Christian Kamm
0c0049c908
Local discovery tracking: On success, also wipe _renameTarget
...
It's possible that the rename target was in the local discovery list.
2020-12-15 10:58:45 +01:00
Christian Kamm
04e0e22513
Protocol, Notifications: Show destination() instead of _file
...
destination() now consistently points to the file after the successful
sync operation. _file might be the place the item was moved from.
2020-12-15 10:58:45 +01:00
Christian Kamm
47f10fbf96
Fix and test _file and _renameTarget
...
There was a bunch of inconsistency around whether _file was set to
_renameTarget or not. This is now never done, passing on more
information.
2020-12-15 10:58:44 +01:00
Olivier Goffart
afbb580528
Test: fix compilation with GCC 4.9
...
It does not appear to support variadic lambda
2020-12-15 10:58:44 +01:00
Christian Kamm
0cf19123a7
VFS: Unbreak behavior for rename+hydrate #7001
...
Users can rename a file *and* add/remove the vfs suffix at the same time
leading to very complex sync actions. This patch doesn't add support for
them, but adds tests and makes sure these cases do not cause unintened
behavior.
The rename will be propagated, but the users's hydrate/dehydrate request
will be ignored.
2020-12-15 10:58:44 +01:00
Olivier Goffart
4346567a03
Async Poll: keep the size in the database
...
This was not required with 2.5 because a size of 0 was ignorted when comparing
size by the csync updater, to be compatible with very old version of the database.
But the we discovery will still think the file is changed if the database contains
a size of 0
2020-12-15 10:58:44 +01:00
Olivier Goffart
46bf3ed31a
Upload: asynchronious operations
...
Implements https://github.com/owncloud/core/pull/31851
2020-12-15 10:58:44 +01:00
Markus Goetz
32c60c2f5d
macOS: Fix vfs suffix plugin paths #7090
2020-12-15 10:58:44 +01:00
Christian Kamm
d496aa5933
Linux: Add autostart delay to avoid tray issues #6518
...
It seems that sometimes the tray implementation isn't ready on system
startup. Retrying later seems to not help. Delaying the start of the
client is the workaround that people have reported as effective.
2020-12-15 10:58:43 +01:00
Markus Goetz
5da48a5239
SocketApi: Fix owncloud/enterprise#2938
2020-12-15 10:58:43 +01:00
Christian Kamm
2f7cdb81cf
Tray: Try to establish tray after 10s if failed initially #6518
...
When owncloud is started during desktop startup the tray may not yet
be running when the client starts. This will make the client attempt
to create a tray icon again after 10 seconds if there's no tray
during initial startup.
2020-12-15 10:58:43 +01:00
Christian Kamm
4bd062f5be
OwnSql: Distinguish no-data from error #6677
...
This could fix a problem where the client incorrectly decides to delete
local data.
Previously any sqlite3_step() return value that wasn't SQLITE_ROW would
be interpreted as "there's no more data here". Thus an sqlite error at a
bad time could cause the remote discovery to fail to read an unchanged
subtree from the database. These files would then be deleted locally.
With this change sqlite errors from sqlite3_step are detected and
logged. For the particular case of SyncJournalDb::getFilesBelowPath()
the error will now be propagated and the sync run will fail instead of
performing spurious deletes.
Note that many other database functions still don't distinguish
not-found from error cases. Most of them won't have as severe effects on
affected sync runs though.
2020-12-15 10:58:43 +01:00
Christian Kamm
ee6a48b3dc
Client certs: Store pkcs12 in config, password in keychain
...
It still reads and writes the old format too, but all newly stored
client certs will be in the new form.
For #6776 because Windows limits credential data to 512 bytes in older
versions.
2020-12-15 10:58:43 +01:00
Christian Kamm
cc840534c0
Add PLUGINDIR cmake setting and define #7027
...
By default, plugins are only searched next to the binary or next to the
other Qt plugins. This optional build variable allows another path to be
configured.
The idea is that on linux the oC packaging probably wants the binary in
something like /opt/owncloud/bin and the plugins in
/opt/owncloud/lib/plugins.
Similarly, distribution packagers probably don't want the plugins next
to the binary or next to the other Qt plugins. This flag allows them to
configure another path that the executable will look in.
2020-12-15 10:58:43 +01:00
Olivier Goffart
87bd26bf6c
AccountManager: load the cookies
...
For issue #7054
2020-12-15 10:58:43 +01:00
Christian Kamm
575935ded0
Windows: Forbid chars 0-31 in filenames #6987
2020-12-15 10:58:42 +01:00
Christian Kamm
a72bf89779
Selective sync: Don't collapse tree when entering mode #7055
...
doExpand() is called when the selective sync editing mode is enabled in
the folder settings view. Previously it'd set the expansion to be
exactly the root items. Now, it just expands any root items that are
currently collapsed, leaving all other item expansion unchanged.
2020-12-15 10:58:42 +01:00
Christian Kamm
2e11f14a6b
SocketApi: Fix crash with readyRead() after disconnected() #7044
...
With the recent bugfix to avoid sending messages on dead connections
0bfe7ac250c54f5415c0a794c7b271428e83c3cf
the client now crashed if readyRead() was received after disconnected()
for the socket as the listener for that connection was already removed.
This code fixes it by still invoking the handler from readyRead() but
passing a SocketListener that won't attempt to send messages.
2020-12-15 10:58:42 +01:00
Christian Kamm
6199e140a5
Wizard: Avoid cert dialog multiple connection
...
This could lead to odd behavior when slotCertificateAccepted
was called multiple times.
2020-12-15 10:58:42 +01:00
Christian Kamm
83268c255a
Folder wizard: Fix infinite loop for bad paths #7041
2020-12-15 10:58:42 +01:00
Christian Kamm
93afc2a04b
Discovery win: Fix detection of case-only renames
...
Previously they were detected as DELETE+NEW because if "a" is renamed to
"A" then QFile::exists("a") will still return true on Windows.
2020-12-15 10:58:42 +01:00
Christian Kamm
238ac53666
Ensure local discovery on selective sync changes
...
As far as I'm aware local discovery can be skipped on folders that are
selective-sync blacklisted, so a local discovery is required when an
entry is removed from the blacklist.
Also rename
avoidReadFromDbOnNextSync() -> schedulePathForRemoteDiscovery()
since the old name might also imply it's not read from db in the local
discovery - which is not the case. Use Folder::
schedulePathForLocalDiscovery() for that.
2020-12-15 10:58:41 +01:00
Christian Kamm
4c04351360
Fix warnings about signedness
...
Sizes are always qint64, not unsigned.
TransferIds are always uint.
2020-12-15 10:58:41 +01:00
Christian Kamm
60cb5d3b34
Tests: Fix permission propagation check
...
It was using the wrong path to the conflict file.
2020-12-15 10:58:41 +01:00
Christian Kamm
5089f55629
Test: Add check for permission propagation
...
Also covering propagation to the downloaded file when a conflict-rename
is done at the same time, which used to not work.
2020-12-15 10:58:41 +01:00
Christian Kamm
aed1f28980
Tests: Add db checks to rename/move tests
...
For moves it's relevant that the old db entry is removed and the new one
is created at the right location.
2020-12-15 10:58:41 +01:00
Christian Kamm
910ccaf600
Vfs: Improve sync protocol entries for actions
...
Creating a new virtual file and replacing a file with a virtual one now
have their own text in the protocol, not just "Downloaded".
To do this, the SyncFileItem type is kept as
ItemTypeVirtualFileDehydration for these actions. Added new code to
ensure the type isn't written to the database.
While looking at this, I've also added documentation on SyncFileItem's
_file, _renameTarget, _originalFile and destination() because some of
the semantics weren't clear.
2020-12-15 10:58:41 +01:00
Christian Kamm
f24687ec93
Vfs: Make dehydration a SYNC and not a NEW action
...
That change will be useful for the notifications. Previously the
dehydrated files were reported as "newly downloaded", now they're
reported as "updated".
2020-12-15 10:58:40 +01:00
Christian Kamm
797734870f
PropagateDownload: Create conflict even if local file changed
...
Fixes a bug introduced while moving the attribute propagation before the
conflict-renaming.
2020-12-15 10:58:40 +01:00
Christian Kamm
8a8e93827f
Vfs suffix: Fix dehydration creating the wrong db entry
2020-12-15 10:58:40 +01:00
Christian Kamm
b06f67baf0
Vfs: Ensure VfsOff works without start() being called
...
In tests an un-started Vfs instance is sometimes passed to SyncEngine
via SyncOptions.
2020-12-15 10:58:40 +01:00
Christian Kamm
6a977edeee
Vfs: Remove VfsDefaults
...
That just complicated things. It's ok if Vfs is not a fully abstract
interface class.
The pinstate-in-db methods are instead provided directly on Vfs and
VfsSuffix and VfsOff use them to implement pin states.
The start() method is simply non-virtual and calls into startImpl() for
the plugin-specific startup code.
2020-12-15 10:58:40 +01:00
Christian Kamm
e9cbe13598
Vfs: Add option to hide socketapi pin actions
...
Because some plugins provide alternative ui.
2020-12-15 10:58:40 +01:00
Christian Kamm
e6ee5d0f8a
PropagateDownload: Conflict-rename later
...
The block of code that propagated attributes etc from the previously
existing file was placed *after* the block that renamed the previously
existing file to a conflict name. That meant the propagation didn't work
in the conflict case.
2020-12-15 10:58:39 +01:00
Christian Kamm
6c5fa1dadd
Vfs: dehydration is separate action
...
Allows for better attribute preservation.
Also add verifyFileUnchanged() call before dehydration to avoid data
loss when discovery takes a while.
2020-12-15 10:58:39 +01:00
Christian Kamm
d8873c18a1
File watcher: Pin state attribute changes are valid notifications
...
Previously they would be discarded since the file's mtime or size hadn't
changed.
2020-12-15 10:58:39 +01:00
Christian Kamm
83a818678f
PinStates cleanup
...
- SyncJournalDB functions now behind internalPinStates() to avoid
accidental usage, when nearly everyone should go through Vfs.
- Rename Vfs::getPinState() to Vfs::pinState()
2020-12-15 10:58:39 +01:00
Christian Kamm
0eb4065197
Folder: Add remoteFolderTrailingSlash()
...
There were cases where the "/" exception wasn't handled correctly
and there'd be extra slashes in generated paths.
2020-12-15 10:58:39 +01:00
Christian Kamm
41f1ddb5fc
Vfs: Call unregisterFolder() when folder is removed
2020-12-15 10:58:39 +01:00
Christian Kamm
597cc60f52
Vfs: Enable propagating attributes on download
2020-12-15 10:58:38 +01:00
Christian Kamm
01f7bc7b49
SyncFileStatusTracker: Distinguish Warning and Excluded
...
Any folder with a (potentially deeply) contained error will have
StatusWarning. StatusExcluded marks exclusions. The difference is useful
to know for VFS.
2020-12-15 10:58:38 +01:00
Christian Kamm
7f400e3226
Pin state updates
...
- unspecified and inherited are different
- move enum to header in common/
- access through Vfs instead of directly in Journal
2020-12-15 10:58:38 +01:00
Christian Kamm
2722c61515
Vfs: Shell integration is enabled optionally
...
Needs to be disabled for tests in some cases.
2020-12-15 10:58:38 +01:00
Christian Kamm
f89450648f
Vfs: Clarify SyncEngine::wipeVirtualFiles()
...
Possibly the behavior should actually change and the function should
de-placeholder all items, not just dehydrated ones.
2020-12-15 10:58:38 +01:00
Christian Kamm
5820ac8b41
Discovery: Files can have dehydrate/download actions
...
This will be used in conjunction with vfs plugins that detect whether a
file has a pending hydration/dehydration through independent means and
communicate that to the discovery through local file type.
2020-12-15 10:58:38 +01:00
Christian Kamm
af1666788e
Discovery: Add signal for silentlyExcluded files
...
This allows SyncFileStatusTracker to also know about these. After all
its information is used to provide icons for them too.
2020-12-15 10:58:37 +01:00
Christian Kamm
e2eea24a03
Vfs: Send SyncFileStatusTracker data to vfs plugins
2020-12-15 10:58:37 +01:00
Christian Kamm
31394f14b5
Vfs: Make files that end up in db placeholders
...
Since 'placeholder' just means that it's an item of the special type
that the vfs plugin can deal with - no matter whether hydrated or
dehydrated - all done items should become placeholders. Even
directories.
Now every file that passes through updateMetadata() will be converted to
a placeholder if necessary.
2020-12-15 10:58:37 +01:00
Christian Kamm
ca0323e1e7
Propagator: Helper for updating db
...
Similar steps were done in many propagation jobs.
This also updates the db entry to always have the item.destination() as
file path.
2020-12-15 10:58:37 +01:00
Christian Kamm
fe27804afb
Move SyncFileStatus to libcommon
...
It'll be needed in vfs plugins so they can connect to the data coming
out of SyncFileStatusTracker.
2020-12-15 10:58:37 +01:00
Christian Kamm
1cc41427fc
Build fix for mingw64 7.3 (Qt 5.12.0)
2020-12-15 10:58:37 +01:00
Christian Kamm
4d58208676
File watcher: Reduce touch ignore duration
...
On Linux and Windows the file watcher can't distinguish between changes
that were caused by the process itself, like during a sync operation,
and external changes. To work around that the client keeps a list of
files it has touched and blocks notifications on these files for a bit.
The duration of this block was originally and arbitrarily set at 15
seconds. During manual tests I regularly thought there was a bug when
syncs didn't trigger, when the only problem was that my changes happened
too close to a previous sync operation.
This change reduces the duration to three seconds. I imagine that this
is still enough.
Also use std::chrono while at it.
2020-12-15 10:58:36 +01:00
Dominik Schmidt
539cef345e
Switch to standard opt-out BUILD_TESTING instead of opt-in UNIT_TESTING
...
Compare https://cmake.org/cmake/help/v3.0/module/CTest.html
Craft automatically handles BUILD_TESTING, so we don't need to handle it
in our own blueprint.
2020-12-15 10:58:36 +01:00
Christian Kamm
13890c04a7
HttpCreds: Warn in log if keychain-write jobs fail #6776
...
Also, calling deleteLater() on jobs is unnecessary (they autodelete
after finished()) and deleting the attached QSettings is also
unnecessary because the settings object is parented to the job.
2020-12-15 10:58:36 +01:00
Christian Kamm
1a250bc3c7
Download: Ignore content-length for compressed HTTP2/SPDY replies #6885
...
It contains the compressed size.
See https://bugreports.qt.io/browse/QTBUG-73364
2020-12-15 10:58:36 +01:00
Christian Kamm
848b869cdf
SocketAPI: Remove listener immediately on lost connection
...
To avoid situations where messages are attempted to be sent to dead
connections.
2020-12-15 10:58:36 +01:00
Christian Kamm
0eebd77d2c
SocketAPI OSX: Forbid further sends on connectionDidDie
...
Also release the remote end immediately.
2020-12-15 10:58:36 +01:00
Olivier Goffart
6f4bf585f0
Move: Fix move detection in directory move on the other side
2020-12-15 10:58:35 +01:00
Olivier Goffart
88d02a887f
Move: add comments and tests
2020-12-15 10:58:35 +01:00
Olivier Goffart
1fb4c22adf
Move: add more test and fix move within moves
2020-12-15 10:58:35 +01:00
Olivier Goffart
ade4c11de3
Rename: fix renamed folder moved into renamed folder issue
...
Issue #6694
2020-12-15 10:58:35 +01:00
Christian Kamm
f3be99e5b2
vfs: Update pinning context menu to be less confusing
...
Seeing "Currently available online only" for a currently hydrated file
was odd. It makes sense since current hydration status and pin state are
independent.
The new text will say something like "Currently available, but marked
online only" to better indicate that the file might be dehydrated later
since it wasn't pinned.
2020-12-15 10:58:35 +01:00
Christian Kamm
b7079289c2
Vfs: Switch on/off only when sync isn't running #6936
...
Avoids some situations that might cause data loss.
2020-12-15 10:58:34 +01:00
Christian Kamm
5728256763
Folder: Add selective sync / ui related flags
...
supportsSelectiveSync(): clearer than !supportsVirtualFiles() and allows
extra logic
isVfsOnOffSwitchPending(): Somewhat awkward way of dealing with the
phase between a user requesting vfs state to be switched and it
actually happening
2020-12-15 10:58:34 +01:00
Christian Kamm
b91839b760
SyncEngine: Rename phase finishing slots
...
slotDiscoveryJobFinished -> slotDiscoveryFinished
slotFinished -> slotPropagationFinished
This should be clearer. Particular the
slotFinished -> finalize -> emit finished()
chain was confusing before.
2020-12-15 10:58:34 +01:00
Christian Kamm
9f8505c736
Discovery: Fix aborting during discovery #6972
2020-12-15 10:58:34 +01:00
Christian Kamm
836d298141
vfs suffix: Ignore server files or synced files with the suffix #6953
2020-12-15 10:58:34 +01:00
Christian Kamm
e774c6c739
Discovery: Ensure selective sync lists are sorted #6958
2020-12-15 10:58:34 +01:00
Christian Kamm
22255e4976
vfs: Add vfs migration options to folder context menu
...
This allows enabling and disabling vfs.
To distinguish this operation from setting the root pin state, the
availability setting is adjusted as well to be similar to the
menu that shows in the shell extensions.
2020-12-15 10:58:33 +01:00
Christian Kamm
20ef0a0290
vfs: Allow retrieving of pin state paths and flags
2020-12-15 10:58:33 +01:00
Christian Kamm
7ef6e60660
Result: Add copy/move ctor/op=
...
It has a destructor and these operations make sense. Particularly the
move is important for code like:
Result<x, y> foo() { Result<x, y> v; return v; }
because the move-ctor will not autogenerate if x or y are not trivially
destructible.
2020-12-15 10:58:33 +01:00
Christian Kamm
3b923e2afe
vfs: Change per-folder message on vfs support
...
I'm unsure this note is all that useful. Remove entirely?
2020-12-15 10:58:33 +01:00
Christian Kamm
4df101ed84
vfs: Allow (de-)hydrating the full sync folder
2020-12-15 10:58:33 +01:00
Christian Kamm
47e21bfc60
vfs: Don't assume suffix mode for old folders
...
That would break with old folders that use selective sync.
2020-12-15 10:58:33 +01:00
Christian Kamm
cbb32edee2
vfs: Disable selective sync if vfs support is available
2020-12-15 10:58:32 +01:00
Christian Kamm
aa23058d76
Wizard: Ensure client cert doesn't get lost #6911
2020-12-15 10:58:32 +01:00
Christian Kamm
c470825c8f
Wizard: Drop unused function
2020-12-15 10:58:32 +01:00
Markus Goetz
4fcad0d8b0
Sync: Display theme in debug log
2020-12-15 10:58:32 +01:00
Christian Kamm
b4e73690b7
sqlite: Set exclusive locking_mode to avoid WAL issues #6881
...
Can be overridden with OWNCLOUD_SQLITE_LOCKING_MODE
2020-12-15 10:58:32 +01:00
Dominik Schmidt
17465a6f94
Fix lookup of system wide settings
2020-12-15 10:58:32 +01:00
Olivier Goffart
f258af1198
sqlite: Update bundled version to 3.26.0
...
For OS X and Windows.
2020-12-15 10:58:31 +01:00
Olivier Goffart
c31d3f277f
HttpCredentials: Do not re-enter the event loop
...
https://sentry.io/owncloud/desktop-win-and-mac/issues/777907931/
mention a crash in OCC::HttpCredentialsGui::showDialog
One possible explaination is that this is caused by re-entring the event loop.
So don't do that.
2020-12-15 10:58:31 +01:00
Olivier Goffart
51d2e41d8b
Chunking Move: Fix too many starting slashes in the destination header
...
Commit 6ca724f fixed it for the move case. But the upload MOVE did the same
Issue #6904
2020-12-15 10:58:31 +01:00
Olivier Goffart
0e56dfe3a4
Gui: do not show the settings when opening a virtual file
...
Issue #6764
2020-12-15 10:58:31 +01:00
Christian Kamm
c4dfa82661
SocketAPI: Overhaul ui for 'available locally' vs 'online only'
...
For #6815
2020-12-15 10:58:30 +01:00
Christian Kamm
aa382eda29
Db: Add wiping of pin state for subtrees
2020-12-15 10:58:30 +01:00
Christian Kamm
d956f518a8
vfs: Remove newFilesAreVirtual - use root PinState instead
...
This unifies how to deal with pin states.
Also enable reading a folders direct pin state vs its effective pin
state.
2020-12-15 10:58:30 +01:00
Olivier Goffart
62ec4c9330
Discovery: Handle the blacklistFiles from the server capabilities
...
Issue #434
Ideally one could add the blacklist to the exlucde reggexp, but this
is simpler
2020-12-15 10:58:30 +01:00
Christian Kamm
8fecff5153
Progress: Virtual file creation needs no transfer progress #6933
...
Treat virtual file creation as a size-less action, similar to
propagating renames or deletions.
2020-12-15 10:58:30 +01:00
Christian Kamm
cdf61b9e82
vfs: Show "new files are virtual" option only with vfs
...
If there's no vfs possibility, showing it makes little sense.
2020-12-15 10:58:30 +01:00
Christian Kamm
8f895fc83c
vfs: SocketAPI actions adjust pin state of directories #6815
...
Downloading a folder also sets its pin state; releasing a folder sets
its pin state.
2020-12-15 10:58:29 +01:00
Christian Kamm
486c25cb47
vfs: Use PinState in sync algorithm #6815
...
New files are virtual if the file's pin state is OnlineOnly.
2020-12-15 10:58:29 +01:00
Christian Kamm
68126ac208
vfs: Introduce PinState db storage #6815
...
The idea is to allow folders (and later maybe files?) to be
- pinned to be available locally
- pinned to be online only
- inherit their pin from the parent
Where this pinning only controls the default for new files.
Subfolders may have a different pin state, and contained files
may be hydrated or dehydrated based on user actions.
This value is stored in a new 'flags' table. The idea is to store
data there that doesn't necessarily exist for each metadata entry.
The selective sync state could be migrated to this table.
2020-12-15 10:58:29 +01:00
Olivier Goffart
dfedb09fd8
Move test for issue #1329 from t1.pl to new test system
2020-12-15 10:58:29 +01:00
Olivier Goffart
a29320b18d
Discovery: Set right direction when restoring deleted discovery because it has modified files
...
(Catched by a faillure of t1.pl)
2020-12-15 10:58:29 +01:00
Olivier Goffart
6da96cd026
Port the exclude test to the QTest Framework
...
This is just a port to QtTest, I did not change the layout of the test.
I did search and replace to replace the assert with QCOMPARE/QVERIFY
I still call setup and setup_init like before (only explicitly, now)
Also ported the preformence tests to QBENCHMAK because windows don't have
gettimeofday.
Relates #6358
2020-12-15 10:58:29 +01:00
Olivier Goffart
fad1238b33
Test: Move the test for Utility::normalizeEtag to testutility.cpp
...
I just moved the text and did the minimum to port it to QtTest
Did not change hte layout of it.
Relates #6358
2020-12-15 10:58:28 +01:00
Olivier Goffart
6e048a2d3f
Remove check_csync_util
...
It's testing nothing.
Only that one can convert a csync instruction to a string.
But this is only used in debug anyway
Relates to #6358
2020-12-15 10:58:28 +01:00
Christian Kamm
69144566ce
Database: Change path for new dbs to .sync_* #5904
...
This is to avoid issues on OSX, where the ._ prefix has special meaning.
Originally (before 2.3.2) ._ was necessary to guarantee exclusion. But
since then the .sync_ prefix is excluded as well.
This does not affect existing database files.
2020-12-15 10:58:28 +01:00
Christian Kamm
30294e0c9a
Vfs: Have a static list of potential plugins for now
...
Fixes in-source builds and other cases where more non-plugin directories
are created in src/libsync/vfs.
2020-12-15 10:58:28 +01:00
Christian Kamm
75b9976526
Vfs: Ensure older versions gracefully ignore winvfs folders
...
Previously there'd likely be a mess if a 2.6 winvfs folder was attempted
to be used with a 2.5 client. Now the older clients will ignore these
folders.
2020-12-15 10:58:28 +01:00
Christian Kamm
bdfda460e6
Vfs plugins: Available plugins must load
...
A plugin that can't be loaded due to dependency issues should not be
considered as available.
2020-12-15 10:58:28 +01:00
Olivier Goffart
fd410a5a84
SyncEngine: Ensure that the paths passed to the discovery ends with slashes
...
This was making the tx.pl test fail
2020-12-15 10:58:28 +01:00
Olivier Goffart
edd806960d
Propagator: Don't abort sync on error 503
...
Only do it when it is actually a maintenance mode
Issues #5088 , #5859 , https://github.com/owncloud/enterprise/issues/2637
2020-12-15 10:58:27 +01:00
Olivier Goffart
feb770eca7
Allow to open log window via command line to already running client
...
Issue: #4098
2020-12-15 10:58:27 +01:00
Dominik Schmidt
687eb9665d
Fix installation of vfs suffix plugin
2020-12-15 10:58:27 +01:00
Olivier Goffart
a7a54b6d11
VFS: Plugin needs to be installed, otherwise it can't be loaded
2020-12-15 10:58:27 +01:00
Olivier Goffart
47b2913357
Fix compilation warning
...
src/libsync/propagatorjobs.cpp:63:10: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
[this, &deleted](const QString &path, bool isDir) {
^~~~~
2020-12-15 10:58:27 +01:00
Christian Kamm
d87c2b803d
vfs: Make Vfs ctor explicit
2020-12-15 10:58:27 +01:00
Christian Kamm
305d439c41
vfs: Separate vfs availability from new-files-virtual
...
This helps support 2.5 settings where there are virtual files in the
tree but new files aren't created virtual.
It's also a prelude for #6815
There's currently no way of
- upgrading vfs plugins (a silent suffix->winvfs upgrade is attempted
once only, when moving to master)
- disabling vfs capabilities outright
2020-12-15 10:58:27 +01:00
Christian Kamm
1e5e884805
vfs: Don't always load plugins, check metadata
2020-12-15 10:58:26 +01:00
Christian Kamm
cc912f4d02
vfs: ensure backwards-compatible settings value is always set
2020-12-15 10:58:26 +01:00
Christian Kamm
b30f79edf6
vfs: Ensure SyncOptions::_vfs is never null
...
- Create a VfsOff derived class
- Make it a shared pointer shared with Folder::_vfs
2020-12-15 10:58:26 +01:00
Christian Kamm
842577e014
vfs: Switch order of deletion and journal removal in dehydration
...
To be more crash-resilient.
2020-12-15 10:58:26 +01:00
Christian Kamm
4e40b635da
vfs: Update outdated comment
2020-12-15 10:58:26 +01:00
Christian Kamm
d7ad7854c1
vfs: Ensure local discovery is done on dehydration request
2020-12-15 10:58:26 +01:00
Christian Kamm
f2b78b5efb
Folder settings: Keep "usePlaceholders" to be backwards compatible
2020-12-15 10:58:25 +01:00
Christian Kamm
fa2450cf11
vfs: Be more careful about Vfs instance ownership
2020-12-15 10:58:25 +01:00
Christian Kamm
9196aa8e0a
vfs: Remove VfsSuffixPrivate
2020-12-15 10:58:25 +01:00
Christian Kamm
5b26b739f0
vfs: Document ignored return value.
2020-12-15 10:58:25 +01:00
Christian Kamm
77e5b956d1
Plugin: Drop PluginLoader
2020-12-15 10:58:25 +01:00
Christian Kamm
9bc28e3006
Plugin: style fixes
2020-12-15 10:58:25 +01:00
Christian Kamm
a5264f7740
Checksums: Make file ownership more explicit
2020-12-15 10:58:24 +01:00
Christian Kamm
9ced8dd836
vfs: Improve modeFromString() signature
2020-12-15 10:58:24 +01:00
Christian Kamm
f502a526fa
Generalize Result<> class, add Optional<>
...
To make it nicer to use outside of HTTP results.
2020-12-15 10:58:24 +01:00
Christian Kamm
e7e6b839c0
vfs: Add API docs
2020-12-15 10:58:24 +01:00
Dominik Schmidt
bd22caa5ec
Remove unused include directories
2020-12-15 10:58:24 +01:00
Christian Kamm
85dd10eb9b
vfs: Fix dealing with missing vfs instance
...
Maybe there should just be a VfsOff instance to make this less error
prone.
2020-12-15 10:58:24 +01:00
Dominik Schmidt
bfe136da7a
Fix export of vfs functions
2020-12-15 10:58:23 +01:00
Dominik Schmidt
1104883fba
Cleanup CMake (output)
2020-12-15 10:58:23 +01:00
Christian Kamm
f074c1a07b
vfs: Add check for presence of win plugin
2020-12-15 10:58:23 +01:00
Christian Kamm
4bef96afe7
vfs: Make switching vfs on/off work again
2020-12-15 10:58:23 +01:00
Christian Kamm
fa6f3cd847
vfs: Fix plugin decision in wizards, sanitize loading
2020-12-15 10:58:23 +01:00
Christian Kamm
d5a3604d39
vfs: Reenable local metadata updating of vfs files
2020-12-15 10:58:23 +01:00
Christian Kamm
96f4fd46e5
vfs: Make some behaviors suffix-vfs specific
2020-12-15 10:58:23 +01:00
Christian Kamm
90827c8162
vfs: Allow remote renames to propagate as such
2020-12-15 10:58:22 +01:00
Christian Kamm
e0ae6012b1
vfs: Allow folders without vfs
2020-12-15 10:58:22 +01:00
Christian Kamm
e39d751b59
Fix big-folder detection when vfs is disabled
2020-12-15 10:58:22 +01:00
Christian Kamm
bee1b0edd4
vfs: Implement dehydration tagging
2020-12-15 10:58:22 +01:00
Christian Kamm
ae9a7e088f
vfs: Fix suffix detection and handling
2020-12-15 10:58:22 +01:00
Christian Kamm
1ed005aafe
winvfs: Better error reporting
...
- fix download and validation error reporting
- add tests
2020-12-15 10:58:22 +01:00
Christian Kamm
0f2ef42ba2
Fixes after rebase to master
...
- use vfs suffix in ProcessDirectoryJob
- fix include vfs.h
- fix local vio passing vfs
- fix checksum computation
- vfs mode use
- mingw lambda compile issue
2020-12-15 10:58:21 +01:00
Christian Kamm
2b20985875
winvfs: initial work
...
Done by ckamm and dschmidt
2020-12-15 10:58:21 +01:00
Christian Kamm
c3b1a872aa
FolderMan: Remove assumption of unique running sync
2020-12-15 10:58:21 +01:00
Christian Kamm
22e08cf6ad
Checksums: Work on QIODevice*s
...
Needed for cfapi where we want to feed data through a custom device
which retrieves data from the windows api.
2020-12-15 10:58:21 +01:00
Olivier Goffart
a6614c18f1
IgnoreListEditor: increase a bit the size
...
Should Help for issue #6641
2020-12-15 10:58:21 +01:00
Olivier Goffart
7c1871ae65
Account: Fix crash when deleting an account
...
We should not have request parented to the account, otherwise we might get
a loop on the deletion order.
Issue #6893
2020-12-15 10:58:21 +01:00
Christian Kamm
6b0bb66b17
LockWatcher: Add chrono header
2020-12-15 10:58:20 +01:00
Christian Kamm
582803b6bd
cjhash: Fix build fix
...
See 17a4055e8d658f24b1fc47c44fd2daf66c7d5dbf
2020-12-15 10:58:20 +01:00
Olivier Goffart
175b064364
cjhash: use Q_FALLTHROUGH
...
This fixes the warning
warning: unknown option after ‘#pragma GCC diagnostic’ kind [-Wpragmas]
Issue #6872
2020-12-15 10:58:20 +01:00
Kevin Ottens
cce3d6f6fc
Excludes: switch all the path handling to QString
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:58:20 +01:00
Olivier Goffart
1c443ad021
CMakeLists.txt: increment sqlite version
...
3.9 is required for custom index to work
2020-12-15 10:58:20 +01:00
Olivier Goffart
5e05b61d2f
csync_vio_locale: use QString for the path in opendir
...
So we don't have to convert to utf8 and back again
2020-12-15 10:58:20 +01:00
Olivier Goffart
f0c24cb6f9
Remove csync_misc: The code no longer use fnmatch
2020-12-15 10:58:20 +01:00
Olivier Goffart
3c3619f99a
Exclude: do everything with QString wiuthout converting to char*
2020-12-15 10:58:19 +01:00
Olivier Goffart
164051b0c9
ProcessDirectoryJob::process: optimize so there is only one map
2020-12-15 10:58:19 +01:00
Olivier Goffart
1783db5811
PropagateUpload: Avoid many allocations by using QByteArrayLiteral
2020-12-15 10:58:19 +01:00
Olivier Goffart
d6a0290058
Optimisation: Add a cache SyncJournalDb::mapChecksumType
...
No need to do two sql query for something that's always the same and
there are very few checksum types
2020-12-15 10:58:19 +01:00
Olivier Goffart
69de2d5180
Sync: optimize by removing setFileRecordMetadata
...
Inh most case we already have a record from before, so avoid doing a useless
lookup in the database.
In owncloudpropagator.cpp, directories do not have a checksum so no need
to call a function that preserves it
2020-12-15 10:58:19 +01:00
Olivier Goffart
416a0b3482
Test System: Optimisations so the benchmark is significant
2020-12-15 10:58:19 +01:00
Olivier Goffart
7e1840bb2f
OwnSql: Speedup by avoiding allocating an error string on success
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
7e55ce6640
owncloudcmd: fix compiliation with TOKEN_AUTH_ONLY
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
b3792ac1f0
libsync: Fix build error with TOKEN_AUTH_ONLY
...
When enabling TOKEN_AUTH_ONLY, the code path using QPainter is disabled.
So we also don't need the includes.
This header is not available for Remarkable.
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
ff9bd84c45
Disable stack protector features when cross compiling
...
When cross-compiling this for remarkable using the poky toolchain
this results in linker errors with stack protector: libssp_nonshared.a
not found
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
6aead6425e
Add CMake option to disable GUI build
2020-12-15 10:58:18 +01:00
Kevin Ottens
9131a68ec4
Get DatabaseErrorTest to pass
...
The E2EE code path would get the engine to go wrong in case of db error.
It's just better to have a failing upload or failing mkdir later in those
cases.
Emitting signals from a ctor is a bad idea anyway
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:58:18 +01:00
Olivier Goffart
bb9ce8db21
Test that the sync behave well if there are errors while reading the database
2020-12-15 10:58:17 +01:00
Olivier Goffart
b79e57d1c1
Discovery: fix double emission of finished in case of error
2020-12-15 10:58:17 +01:00
Olivier Goffart
7061f31887
Discovery: Fix downloading files when database is used for local discovery
...
This also fix the currently failling LockedFilesTest
2020-12-15 10:58:17 +01:00
Olivier Goffart
0eaa950e9e
Remove csync.cpp: It's only dead code
2020-12-15 10:58:17 +01:00
Christian Kamm
0d49056a13
Add Ctrl-L as log window shortcut
...
F12 is taken on OSX and there's no other way of showing it.
2020-12-15 10:58:17 +01:00
Christian Kamm
9d55590d10
Test: Add test for locked file tracking and propagation
2020-12-15 10:58:17 +01:00
Christian Kamm
da178c1352
Folder: Treat file unlock similar to external change #6822
...
For consistent handling of incoming notifications.
2020-12-15 10:58:17 +01:00
Christian Kamm
815e0fee8f
Propagator: Add assert against duplicate done() calls
2020-12-15 10:58:16 +01:00
Olivier Goffart
2c9b66fe69
RemoteDiscoveryTest: Fix after the merge from 2.5
...
The new discovery's message is slightly different
2020-12-15 10:58:16 +01:00
Christian Kamm
18b9712105
Test: Check for folder in error message #6826
2020-12-15 10:58:16 +01:00
Markus Goetz
59d12c302e
gitignore: XCode userdata
2020-12-15 10:58:16 +01:00
Olivier Goffart
eb23776f16
Discovery: Fix renaming on windows
...
buf.type is ItemFileSkip because csync_vio_local_stat does not set this field
2020-12-15 10:58:16 +01:00
Olivier Goffart
beee123c80
New Discovery: Fix trailing slash causing failure on windows
2020-12-15 10:58:16 +01:00
Olivier Goffart
60b17cd128
Folder: update the folder version
...
Since the new index would crash old version of the client, we need to
upgrade folder version so they do not load in the client 2.5.0
2020-12-15 10:58:15 +01:00
Christian Kamm
7de453d439
Settings: Make FoldersWithPlaceholders group sticky
...
If virtual files are disabled on a folder it might still have db entries
or local virtual files that would confuse older client versions.
2020-12-15 10:58:15 +01:00
Olivier Goffart
ab85c60205
owncloudcmd: Read the server version from the capabilities
...
Issue: #6846
2020-12-15 10:58:15 +01:00
Olivier Goffart
3e4486c078
owncloudcmd: fetch the dav user
...
This is required to get the new endpoint working when the server
uses ldap or that the dav user is not the same as the login.
Issue #6830
2020-12-15 10:58:15 +01:00
Olivier Goffart
ec8c02dad0
Sharing: add the shareWithAdditionalInfo string in autocompletion results
...
Issue #6749
2020-12-15 10:58:15 +01:00
Olivier Goffart
380d7b8028
Migration from 2.4: fallback to move file by file if directory move failled ( #6807 )
...
Migration from 2.4: fallback to move file by file if directory move failed
This can happen if the directory already exist because, say, it was
created by the ownCloud outlook plugin which save its file in the same directory
2020-12-15 10:58:15 +01:00
Olivier Goffart
e20e1d110f
Move: Fix too many starting slashes in the destination header
...
QDir::cleanPath does not remove starting slashes on windows.
So use account::davUrl which is already cleaned
Issue: #6824
2020-12-15 10:58:15 +01:00
Olivier Goffart
dcfbde2a67
Wizard: Reset the QSslConfiguration before checking the server
...
Because a previous call with another demain might have set some
config for another server.
Issue #6832
2020-12-15 10:58:14 +01:00
Olivier Goffart
b820e46805
Fix compiler warning
2020-12-15 10:58:14 +01:00
Olivier Goffart
35967fc2d6
OAuth2: Refresh the token without aborting the sync
...
OAuth2 access token typically only has a token valid for 1 hour.
Before this patch, when the token was timing out during the sync, the
sync was aborted, and the ConnectionValidator was then requesting a new
token, so the sync can be started over.
If the discovery takes longer than the oauth2 validity, this means that
the sync can never proceed, as it would be always restarted from scratch.
With this patch, we try to transparently renew the OAuth2 token and restart
the jobs that failed because the access token was invalid.
Note that some changes were required in the GETFile job because it handled
the error itself and so it was erroring the jobs before its too late.
Issue #6814
2020-12-15 10:58:14 +01:00
Olivier Goffart
53a14c2041
HttpCredentials: initialize all member inline
2020-12-15 10:58:14 +01:00
Dominik Schmidt
5d9370594d
Disable autostartCheckBox if autostart is configured system wide
2020-12-15 10:58:14 +01:00
Christian Kamm
00edcf98a1
Discovery: Virtual file handling adjustments
...
- adjust virtual file path handing
- helpers for vfs suffix adding/removal
- helpers for isDirectory/isVirtual on SyncJournalRecords
- be clear about what PathTuple _local/_server mean
2020-12-15 10:58:14 +01:00
Olivier Goffart
58eaf9940a
Database: Add an index on the parent path
...
So we can quickly query the items in a parent directory
This uses a custom slite3 function, which means that when downgrading the client,
or using another tool to add entries in the database, any insertion in the metadata
table will produce an error: "unknown function: parent_hash()"
(This will crash the client 2.5)
2020-12-15 10:58:13 +01:00
Olivier Goffart
e45e57982d
Add missing export
2020-12-15 10:58:13 +01:00
Christian Kamm
b431f4ef0c
Discovery: Fix log output for instructions
2020-12-15 10:58:13 +01:00
Christian Kamm
ce420d77a8
Discovery: Don't rebuild invalidFilname regex each call
2020-12-15 10:58:13 +01:00
Christian Kamm
113124cde5
Discovery: Introduce smaller functions
2020-12-15 10:58:13 +01:00
Christian Kamm
4f6f706f40
Excludes: drop csyncTraversalMatchFun()
...
The new discovery can call the traversal match function directly.
2020-12-15 10:58:13 +01:00
Christian Kamm
1d4e4fafcc
Discovery: Add back virtual file instruction checks
2020-12-15 10:58:12 +01:00
Olivier Goffart
a4e139969c
Fix windows build
2020-12-15 10:58:12 +01:00
Olivier Goffart
8490664860
Account Settings: fix progress being written in white when there are errors
2020-12-15 10:58:12 +01:00
Christian Kamm
dd34cbc751
Virtual files: Wipe selective sync settings when enabled
2020-12-15 10:58:12 +01:00
Christian Kamm
60de1c9720
virtual files: show option only when branding allows it
2020-12-15 10:58:12 +01:00
Christian Kamm
251e01a440
Virtual files: Use theme to check for option availability
2020-12-15 10:58:12 +01:00
Olivier Goffart
94e63ef7b9
Account Settings: Add a context menu entry to enable or disable virtual files
...
Issue #6725
2020-12-15 10:58:12 +01:00
Olivier Goffart
18f6e346b8
Upload: Do not error out if the server do not send the X-OC-MTime: accepted header
...
If the server does not set the mtime, it is not a big problem for the
synchronisation.
The test was used before so we could do a PROPPATCH for server that did not
support this header. But now that all server supports that we don't need to
to the check. (We do not do the PROPPATCH since we got rid of the neon
dependency)
Apparently, it may happen that some backend don't support setting mtime
and this can lead to this error.
https://github.com/owncloud/client/issues/6797
2020-12-15 10:58:11 +01:00
Dominik Schmidt
a985ea8624
Do not select ownCloud in Finder after installation to fix #6781
2020-12-15 10:58:11 +01:00
Olivier Goffart
15eab07866
OAuth2: Store 'Account::davUser' in the config, and use that user for connecting
...
We need to use the user id to check if we are connected to the right account.
These might be different from the HTTP Basic Auth login. (LDAP setups)
When the account was configured as an oauth2 account form the wisard, the
http_user was already set correctly to the user id. But when the server is
upgrading from basic auth to oauth2, we need to pick the right login.
Note that Account::davUser() already defaults to the HTTP user when none
is set, so this means the upgrade will be fine if this is not set in the
config.
Issues:
https://github.com/owncloud/oauth2/issues/109
https://github.com/owncloud/enterprise/issues/2781
2020-12-15 10:58:11 +01:00
Olivier Goffart
75f66ddaa1
Local discovery: always recurse within touched directory
...
If the file system watcher tells us a directory was modified, we should
recurse into it because it means it is probably a new directory
Issue #6804
2020-12-15 10:58:11 +01:00
Christian Kamm
e10e953c66
PropagateUpload: Avoid crash due to cascading aborts
...
https://sentry.io/owncloud/desktop-win-and-mac/issues/698694072/activity/
2020-12-15 10:58:11 +01:00
Olivier Goffart
640cf0c71e
Fix leaks in tests
...
As discovered by AddressSanitizer
2020-12-15 10:58:11 +01:00
Christian Kamm
d1aedcfd3c
Discovery: restructure processFileAnalyzeLocalInfo
2020-12-15 10:58:10 +01:00
Christian Kamm
a2839bd40a
Discovery: easy conditions first in processFileAnalyzeRemoteInfo
...
Removing two levels of indent that way
2020-12-15 10:58:10 +01:00
Christian Kamm
76341904e9
Discovery: Add comments
2020-12-15 10:58:10 +01:00
Olivier Goffart
5a1c93d0ac
Discovery: make sure finished is not called twice, even in case of errors
2020-12-15 10:58:10 +01:00
Olivier Goffart
b86e1efc9a
Remove the backup deteciton code which was used for server < 9.1
2020-12-15 10:58:10 +01:00
Olivier Goffart
f666511a4b
Discovery: Remove stale DB entries
...
And test the Remove/Remove case.
This means we need to always query the database for all the entries.
This showed another small bug in the test in which sync item for virtual
files at the root could have a slash in front of them.
2020-12-15 10:58:10 +01:00
Christian Kamm
5683278fab
Discovery: Comments and visibility adjustments
2020-12-15 10:58:09 +01:00
Olivier Goffart
aa18e10ff5
Discovery: cleanups and comments
2020-12-15 10:58:09 +01:00
Olivier Goffart
b10b3e5eeb
Discovery: move checkMovePermissions to its own function
2020-12-15 10:58:09 +01:00
Olivier Goffart
edd866b32b
Discovery: Adjust the instruction in case of resolved conflict
...
When resolving a conflict because the file was just updated on the server,
we write all the metadata on the database immediatly, so INSTRUCITON_NONE
is enough and UPDATE_METADATA is not needed
2020-12-15 10:58:09 +01:00
Olivier Goffart
7cddaf82ab
ProcessDirectoryJob: always set _childModified to true, regardless the direction
...
This was like that to handle the case of CSYNC_INSTRUCTION_TYPE_CHANGE, but just add
a condition in this location.
2020-12-15 10:58:09 +01:00
Olivier Goffart
46510c2f39
Discovery phase: refactor some code in DiscoveryPhase::findAndCancelDeletedJob
...
Less code duplication
2020-12-15 10:58:09 +01:00
Olivier Goffart
1c2a3279bb
New Discovery Algorithm: more cleanups
...
- rename progress() to be more explicit
- Make some more member of the discovery phase private
2020-12-15 10:58:09 +01:00
Olivier Goffart
2f8c77c54f
Fixup commit 835c9163374f42003aa2f7795ade3f4ff62c8877
...
The previous code considered the also HTTP 207 code without the
application/xml header to have this message.
httpCode 0 does not make much sense anyway.
This change the behavior to consider any 2xx without the xml header
to show this error message
2020-12-15 10:58:08 +01:00
Olivier Goffart
c009dae1ce
New discovery algorithm: fixups
...
Adapt reviews from ckamm in https://github.com/owncloud/client/pull/6738#pullrequestreview-164623532
- SyncJournalFileRecord: initialize everything inline
- Add more comments
- And some ENFORCE
2020-12-15 10:58:08 +01:00
Olivier Goffart
059f722b3b
Move Result to its own header
2020-12-15 10:58:08 +01:00
Olivier Goffart
afed46afcc
New discovery algorithm: Parallel PROPFIND
2020-12-15 10:58:08 +01:00
Olivier Goffart
c8eff3da2d
New Discovery algorithm: Remove the sync cleanup phase
...
Since we do not recurse within some directories, many files are not seen.
The stale entry will cleanup by themself as the sync engine try to remove
the files that are already removed.
Should we need to actually do this cleanup, it should be dotected in the
discovery.
2020-12-15 10:58:08 +01:00
Olivier Goffart
35c0cf4e59
New discovery algorithm: Set the originalFile for ignored files
...
This is used to show the name in the UI
2020-12-15 10:58:08 +01:00
Olivier Goffart
52dcfcb166
New Propagation algorithm: Fetch, and emit, the root etag
...
Remove the feature to concatenate etags as servers that don't
have a root etag are no longer suported
2020-12-15 10:58:07 +01:00
Olivier Goffart
d25d87e92c
New Discovery Algorithm: Ge tthe size of new folders
...
Also add a test that this works properly
2020-12-15 10:58:07 +01:00
Olivier Goffart
ef542ac83d
New Discovery algorithm: Split the process function even further
...
Move the finialization in its own function.
This allow to save a bit of code duplication.
Also change the order of the parameter in the constructor for consistency
2020-12-15 10:58:07 +01:00
Olivier Goffart
fc69dda246
New Discovery Algo: Refactor by splitting the processFile in two
2020-12-15 10:58:07 +01:00
Olivier Goffart
b7d827d6d0
New Discovery Algorithm: Handle rename of virtual files
2020-12-15 10:58:07 +01:00
Christian Kamm
e58a25d7c5
Virtual files: Renames propagate #6718
2020-12-15 10:58:07 +01:00
Olivier Goffart
3289675b8d
Folder Wizard: Disable the 'choose what to sync' treeview if virtual files are selected
...
Don't allow to configure virtual files with a selective sync blacklist
2020-12-15 10:58:07 +01:00
Olivier Goffart
d8fa8e270f
AccountSetting: Fix Small Memoy leak
2020-12-15 10:58:06 +01:00
Olivier Goffart
f0ddf179a5
Fix tx.pl
...
The conflict filename changed
2020-12-15 10:58:06 +01:00
Olivier Goffart
0ba9dc7dd1
AccountSettings: Force sync should wipe the blacklist
...
Issue #6757
2020-12-15 10:58:06 +01:00
Olivier Goffart
68ace415d4
Virtual files: don't check for new big folders
...
https://github.com/owncloud/client/issues/6724#issuecomment-417368475
2020-12-15 10:58:06 +01:00
Olivier Goffart
75a57778d9
Virtual files: Don't show selective sync
...
Issue #6724
2020-12-15 10:58:06 +01:00
Olivier Goffart
46aa8fd1f8
Socket API: add an option to replace existing files with virtual files
...
Issue #6726
2020-12-15 10:58:06 +01:00
Olivier Goffart
afc953b649
Update the minimum supported version
...
We want to warn if the server version is not supported and did not get
appropriate QA for this client version.
https://github.com/owncloud/enterprise/issues/2687
2020-12-15 10:58:05 +01:00
Markus Goetz
811ac50c05
CMakeLists.txt: Log the Qt version in compile
2020-12-15 10:58:05 +01:00
Christian Kamm
6b571b609c
Conflicts: Rename BasePath to InitialBasePath #6709
2020-12-15 10:58:05 +01:00
Olivier Goffart
d81ccbb0c1
Checksum: Add support for SHA256 and SHA3
...
In case, some day, the server also supports it
2020-12-15 10:58:05 +01:00
Olivier Goffart
bf6e4174c8
Move the checksum related routine from FileSystem to checksum, where they belong
2020-12-15 10:58:05 +01:00
Olivier Goffart
198b65e9fc
Fix a compilation error on windows
2020-12-15 10:58:05 +01:00
Olivier Goffart
21fe54fb13
New Discovery Algo: readability improvements
...
As proposed by ckamm on #6738
2020-12-15 10:58:04 +01:00
Olivier Goffart
3a06a7978f
New discovery algo: data finger print
2020-12-15 10:58:04 +01:00
Olivier Goffart
5683f1c33d
New Disco Algo: Handle spurious virtual files
...
Port commit 0b9049e6ff
for issue #6718
2020-12-15 10:58:04 +01:00
Olivier Goffart
9c99544e0b
Fix test link with older Qt
2020-12-15 10:58:04 +01:00
Olivier Goffart
c3f745fa76
Conflict handling: add the OC-ConflictBasePath header
...
Issue #6702
2020-12-15 10:58:04 +01:00
Olivier Goffart
358aadfb98
Account Settings: Add a text for folder using vierual files
...
Issue #6723
2020-12-15 10:58:04 +01:00
Olivier Goffart
73d933115a
Virtual Files: Set the mtime of the virtual file to that of the server
...
Note: When the server mtime is modified, the mtime of the file is not updated
Issue #6727
2020-12-15 10:58:04 +01:00
Olivier Goffart
a17a2a9c06
Virtual Files Mime Type: use "vnd." prefix instead of "x-"
...
As reported in https://github.com/owncloud/client/issues/6717#issuecomment-413703567
2020-12-15 10:58:03 +01:00
Christian Kamm
c10f103fb8
Virtual files: Renaming to virtual doesn't delete data #6718
...
Unfortunately to do this, the local update phase must write to the
database, creating a new side-effect and order dependency (local update
must run before remote update).
2020-12-15 10:58:03 +01:00
Olivier Goffart
a670431a48
SyncEngine: Fix renames making hierarchy inversion
...
Issue #6694
2020-12-15 10:58:03 +01:00
Christian Kamm
be0fa72fcb
RemotePermissions: Fix empty vs null
...
Fixes two bugs that appeared since the introduction of the struct:
- when reading permissions from the journal, null ("") was read as
empty-not-null
- when reading permissinos from the server, empty ("") was read as null
Addresses #4608
2020-12-15 10:58:03 +01:00
Olivier Goffart
4837bc8d60
FolderStatusModel: Do not abort applying selective sync if one folder has an error
...
Issue #6675
2020-12-15 10:58:03 +01:00
Olivier Goffart
732069aaa7
SyncEngine: Fix the "direction" of the "all file delted" message when the server is reset
...
Using the direction of the "first" item is not enough as it might be a directory
which is a UPDATE_META_DATA, or there can have been a few changes locally as well.
As reported on https://github.com/owncloud/client/issues/6317#issuecomment-412163113
2020-12-15 10:58:02 +01:00
Christian Kamm
f6ca649308
Do not require server replies to contain an mtime
...
The check was added for #6317 in commit
13eb64584f .
We did see missing mtimes in replies in tests with live servers though.
Possibly those were old incomplete responses cached in the stat cache?
2020-12-15 10:58:02 +01:00
Olivier Goffart
9401273daf
New discovery algorithm: Call FolderDiscovered
2020-12-15 10:58:02 +01:00
Olivier Goffart
a36ed56f01
New Discovery algorithm: Refactor a bit the way the signal are emited
2020-12-15 10:58:02 +01:00
Olivier Goffart
8f3ce6e520
Fix TestDownload: _ignore_hidden_files was not properly initialized
2020-12-15 10:58:02 +01:00
Olivier Goffart
b6487181c6
New Discovery Phase: fix a few FIXME
...
Some FIXME were already fixed.
2020-12-15 10:58:02 +01:00
Olivier Goffart
9863500ec1
New discovery algorithm: handle symlinks
2020-12-15 10:58:01 +01:00
Olivier Goffart
a9ec521bf1
New discovery algo: Handle Database error
2020-12-15 10:58:01 +01:00
Olivier Goffart
d6fc3b6e0a
Skip failing test
...
These tests are failling because now we consider that any files that ends
with .owncloud is a virtual file, regardless what the DB say.
2020-12-15 10:58:01 +01:00
Olivier Goffart
1bcbcd407c
New discovery phase: read the direct download URL and Cookie
2020-12-15 10:58:01 +01:00
Olivier Goffart
ca32eb1cf7
More cleanup of csync remains
2020-12-15 10:58:01 +01:00
Olivier Goffart
ac24cdbde6
New Discovery Algo: Permsission check
2020-12-15 10:58:01 +01:00
Olivier Goffart
0a6d2d0f46
Remove csync_update and csync_reconcile
...
I guess some other csync utilities can also be remove dnow but
that will be for later
2020-12-15 10:58:00 +01:00
Olivier Goffart
5994c65ecb
Remove the check_csync_update test
...
since csync_update is going away
2020-12-15 10:58:00 +01:00
Olivier Goffart
57068b0fd9
New Discovery Algorithm: handle server errors
2020-12-15 10:58:00 +01:00
Olivier Goffart
4031fb6d5b
Backport 64014dd374
2020-12-15 10:58:00 +01:00
Olivier Goffart
6794306dde
Added test that checks what happens when there is an error in the remote discovery
...
(Many of the expected error string are left empty because the current
error message is not insterresting
2020-12-15 10:58:00 +01:00
Olivier Goffart
75a1f2d089
Convert p7.pl to a C++ test
...
This is just a translation of test/scripts/txpl/t7.pl to C++ using the test
framework.
2020-12-15 10:58:00 +01:00
Olivier Goffart
f4a5167812
New Discovery Algo: Support the DatabaseAndFilesystem mode for local discovery
2020-12-15 10:57:59 +01:00
Olivier Goffart
370923791d
New Disco algortihm: Fix TestChunkingNG::connectionDroppedBeforeEtagRecieved
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:57:59 +01:00
Olivier Goffart
710934bdbd
New disco algo: Fix TestSyncFileStatusTracker
2020-12-15 10:57:59 +01:00
Olivier Goffart
f926248937
New discovery algorithm: More work on virtual files
2020-12-15 10:57:59 +01:00
Olivier Goffart
35e40b58ca
New Disco algorithm: Type change (file to dir)
2020-12-15 10:57:59 +01:00
Olivier Goffart
1e8c37d3d6
New discovery algorithm: Virtual files
...
The commented tests lines were implementation details
2020-12-15 10:57:59 +01:00
Olivier Goffart
22d989e272
New discovery algorithm: Fix directory deletion
...
TestAllFilesDeleted passes
2020-12-15 10:57:59 +01:00
Olivier Goffart
d54e00488a
New Discovery algorithm
...
Some error handling. In particular for the case where there is a conflict
between files and directories.
SyncEngineTest and SyncMoveTest passes
2020-12-15 10:57:58 +01:00
Olivier Goffart
a384a2d1cb
New Discovery algorithm: Handle of move within a moved directory
2020-12-15 10:57:58 +01:00
Olivier Goffart
bdd1e72dda
New discovery algoritmh: more on Renames
2020-12-15 10:57:58 +01:00
Olivier Goffart
f43d07dc05
New Discovery algorithm: Check that the original file is still on the server while renaming
2020-12-15 10:57:58 +01:00
Olivier Goffart
7e36cc3fcb
New disco algorithm: Fix some moving
...
Fix TestSyncMove::testSelectiveSyncMovedFolder
2020-12-15 10:57:58 +01:00
Olivier Goffart
5a57a36729
New discovery algorithm: Local rename
2020-12-15 10:57:58 +01:00
Olivier Goffart
f9a9be59e6
New discovery algo: Remote move
...
TestSyncMove::testRemoteChangeInMovedFolder
2020-12-15 10:57:57 +01:00
Olivier Goffart
92ddc60900
Handle Encoding Problems
...
TestSyncEngine now passes
2020-12-15 10:57:57 +01:00
Olivier Goffart
501da58b10
Ignore Hidden Files
2020-12-15 10:57:57 +01:00
Olivier Goffart
8bf69cf0cd
Port the invalid napme regexp
...
TestSyncEngine::testInvalidFilenameRegex
2020-12-15 10:57:57 +01:00
Olivier Goffart
9efd21d70b
More progress
...
TestSyncEngine::testFakeConflict / TestSyncEngine::testSyncFileItemProperties
2020-12-15 10:57:57 +01:00
Olivier Goffart
e934f6b27b
New discovery algo
...
Make TestSyncEngine::testSelectiveSyncBug pass
2020-12-15 10:57:57 +01:00
Olivier Goffart
4066c1a004
New discovery: TestSyncEngine::testEmlLocalChecksum
2020-12-15 10:57:57 +01:00
Olivier Goffart
9bf417d930
New discovery algorithm
...
Some progress:
TestSyncEngine::testDirUpload
2020-12-15 10:57:56 +01:00
Olivier Goffart
ec681ab2a5
New discovery algorithm: Initial work.
...
SyncEngineTest testFileDownload is passing
2020-12-15 10:57:56 +01:00
Kevin Ottens
ba0d465e47
Revert "Merge pull request #1454 from nextcloud/syncjournal-del-prio"
...
This reverts commit d9fd9cfef2 , reversing
changes made to 2dcf594fc6 .
2020-12-15 10:57:56 +01:00
Dominik Schmidt
07f331717f
Rename ocsync library to ${APPLICATION_EXECUTABLE}_csync
2020-12-15 10:57:56 +01:00
Dominik Schmidt
aad928a6be
Install libocsync to lib/ without subfolder.
...
Installing to lib/${APPLICATION_EXECUTABLE} has caused a bunch of
irritations in the past and subtle annoying to fix bugs. To avoid name
clashes with branded clients ${APPLICATION_EXECUTABLE} becomes now
part of the filename instead of the subfolder.
The concrete motivation to change this now is that on Windows there
is no RPATH and it's not possible to run owncloud directly from the
Craft Root folder, which is nice when you're developing on Windows.
It would have been possible to change this just for Windows but as
written earlier this has caused lots of issues and thus I think it's
a good idea to just stay consistent accross platforms when touching it.
2020-12-15 10:57:56 +01:00
Olivier Goffart
919debccfc
nautilus shell integration: Fix when there are several branded client installed
...
It appears that several extension can be loaded at the same time, but their
classname for the extension need to be different, otherwise only the last
loaded one would be active.
Issue #6524
2020-12-15 10:57:55 +01:00
Olivier Goffart
0155a4fa73
Wizard + OAuth: Make opening a new browser after clicking back works again
...
Issue #6574
When there is an error in the advanced page, OwncloudAdvancedSetupPage::updateStatus
(and others) call completeChanged(), which is connected to
QWizardPrivate::_q_updateButtonStates which will re-enable the back button from the
last page.
When the user click "back" and re-open the browser, the account's credentials
already have a oauth token set. So the call to the API to get a new token fails
because we use the previous token instead of using the client's secret_id.
Fix this with the HttpCredentials::DontAddCredentialsAttribute.
Now, this is still not working because the session cookies are confusing the
server. So we'll clear the cookies when re-opening the browser
2020-12-15 10:57:55 +01:00
Olivier Goffart
d8e761ab61
FindSql3.cmake: Add the input variable in the search path
...
Issue #6278
2020-12-15 10:57:55 +01:00
Olivier Goffart
0d21936e95
FolderStatusModel: Fix crash when there is an error while expanding folders
...
In FolderStatusModel::slotLscolFinishedWithError, the call to parentInfo->resetSubs
deleted the 'job' and the reply 'r' which we accessed later to get the error code.
Fix this problem twice by
1) Get the error code before caling resetSubs
2) in FolderStatusModel::SubFolderInfo::resetSubs, call deleteLater instead of delete
Regression introduced in commit d69936e0
Issue #6562
2020-12-15 10:57:55 +01:00
Olivier Goffart
cf3846c565
csync: refactor csync_s::error_string to avoid valgrind error
...
The problem here is that we were sometimes allocating the error_string with
qstrdup, which need to be released with delete[] and not free().
Simplify the code by using QString instead.
```
==7230== Mismatched free() / delete / delete []
==7230== at 0x4C2E10B: free (vg_replace_malloc.c:530)
==7230== by 0x57C2321: csync_s::reinitialize() (csync.cpp:247)
==7230== by 0x548130F: OCC::SyncEngine::finalize(bool) (syncengine.cpp:1212)
==7230== by 0x5481223: OCC::SyncEngine::handleSyncError(csync_s*, char const*) (syncengine.cpp:746)
==7230== by 0x5483E78: OCC::SyncEngine::slotDiscoveryJobFinished(int) (syncengine.cpp:965)
==7230== by 0x5495E34: QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<int>, void, void (OCC::SyncEngine::*)(int)>::call(void (OCC::SyncEngine::*)(int), OCC::SyncEngine*, void**) (qobjectdefs_impl.h:134)
==7230== by 0x5495D92: void QtPrivate::FunctionPointer<void (OCC::SyncEngine::*)(int)>::call<QtPrivate::List<int>, void>(void (OCC::SyncEngine::*)(int), OCC::SyncEngine*, void**) (qobjectdefs_impl.h:167)
==7230== by 0x5495CB5: QtPrivate::QSlotObject<void (OCC::SyncEngine::*)(int), QtPrivate::List<int>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (qobjectdefs_impl.h:396)
==7230== by 0xA9BF2E1: QObject::event(QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== by 0x64BE983: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0x64C625A: QApplication::notify(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0xA994BC8: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== Address 0x225b2640 is 0 bytes inside a block of size 50 alloc'd
==7230== at 0x4C2DC6F: operator new[](unsigned long) (vg_replace_malloc.c:423)
==7230== by 0xA7E8FC8: qstrdup(char const*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== by 0x53F5750: OCC::DiscoveryJob::remote_vio_opendir_hook(char const*, void*) (discoveryphase.cpp:666)
==7230== by 0x57E1278: csync_vio_opendir(csync_s*, char const*) (csync_vio.cpp:39)
==7230== by 0x57D718F: csync_ftw(csync_s*, char const*, int (*)(csync_s*, std::unique_ptr<csync_file_stat_s, std::default_delete<csync_file_stat_s> >), unsigned int) (csync_update.cpp:674)
==7230== by 0x57C1B05: csync_update(csync_s*) (csync.cpp:109)
==7230== by 0x53F5BCC: OCC::DiscoveryJob::start() (discoveryphase.cpp:718)
==7230== by 0x54B8F74: OCC::DiscoveryJob::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_discoveryphase.cpp:494)
==7230== by 0xA9BF2E1: QObject::event(QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== by 0x64BE983: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0x64C625A: QApplication::notify(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0xA994BC8: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230==
```
2020-12-15 10:57:55 +01:00
Olivier Goffart
857afd32df
PropagateDownload: Don't discard the body of error message
...
We want to keep the body so we can get the message from it
(Issue #6459 )
TestDownload::testErrorMessage did not fail because the FakeErrorReply
did not emit readyRead and did not implement bytesAvailable.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:57:55 +01:00
Olivier Goffart
5bd902de9c
.desktop file: the MimeType entry must ends with a semi colon
...
Also remove some comments
2020-12-15 10:57:55 +01:00
Olivier Goffart
4ee244190b
Virtual Files: Allow to download a folder recursively from the socket API
...
Issue: #6466
2020-12-15 10:57:54 +01:00
Christian Kamm
6dba2e8b06
Virtual files: Wipe virtual after download completes, not before
...
Otherwise a interrupted or unsuccessful download would mean that the
download-intend was forgotten. The next sync would reestablish the
virtual file instead.
2020-12-15 10:57:54 +01:00
Olivier Goffart
530614bf78
Rename SocketApi::FileData::accountRelativePath to serverRelativePath
...
As discussed in issue #6552
2020-12-15 10:57:54 +01:00
Olivier Goffart
ced5dfb8ee
Share dialog: use the original name and not the virtual file name
...
When sharing a virtual file, we should actually use the original file name
not the virtual file name
Issue: #6461
2020-12-15 10:57:54 +01:00
Christian Kamm
a6c19572a2
Virtual files: Only remove virtual file once on download
...
With thanks to @ogoffart for spotting the problem.
2020-12-15 10:57:54 +01:00
Christian Kamm
97f7b5abeb
Settings migration: Preserve future settings where possible
...
See discussion in #6506
2020-12-15 10:57:54 +01:00
Christian Kamm
87ba4e6b9c
Config: Add version flags to accounts and folders
...
Also, if there is too-new configuration, backup the file, show a
warning message asking the user whether it's ok to discard the
configuration from the future.
See #6504
2020-12-15 10:57:53 +01:00
Christian Kamm
aa6f5f59c4
Rename Placeholders to Virtual Files in code #6531
2020-12-15 10:57:53 +01:00
Olivier Goffart
a877a9d472
SyncRunFileLog: Add the requestid
...
https://github.com/owncloud/client/pull/6427#issuecomment-383879509
2020-12-15 10:57:53 +01:00
Olivier Goffart
09cacc4cd4
Blacklist: remember the X-Request-ID
...
Issue #6420
Store the X-Request-ID in the SyncFileItem and also in the blacklist.
Note that for consistency reason, the X-Request-ID is also in the
SyncFileItem if the request succeeds.
Currently there is no UI to access it, but it can be queried with sql
commands
2020-12-15 10:57:53 +01:00
Christian Kamm
7da4bb4c20
Wizard: Add a "(recommended)" to the main option #6470
2020-12-15 10:57:53 +01:00
Christian Kamm
ddeeecd061
Rename "placeholder" feature
2020-12-15 10:57:53 +01:00
Christian Kamm
4e3f2f755a
Placeholder: Stop adding ignore pattern
...
Because we can't make older clients preserve the version directive that
was attached to it.
See #6504 and #6498
2020-12-15 10:57:52 +01:00
Christian Kamm
8b6ac63ddb
Placeholder: Don't contain "stub"
2020-12-15 10:57:52 +01:00
Christian Kamm
27b65cbc69
Placeholders: Save to key that's invisible to <2.5 clients #6504
2020-12-15 10:57:52 +01:00
Olivier Goffart
3272f3b72b
FolderWizard: fix crash when experimental feature are disabled
...
The _placeholderCheckBox only exists if the experimental features are enabled
Found via the crash reporter
https://sentry.io/owncloud/desktop-win-and-mac/issues/556407777/
2020-12-15 10:57:52 +01:00
Matthew Setter
eb0e7fa032
Correct incorrect reference to OSX Menu bar
...
This fixes https://github.com/owncloud/documentation/issues/4109 .
2020-12-15 10:57:52 +01:00
Markus Goetz
215afba89e
Share Dialog: Disable workaround for macOS too #6185
2020-12-15 10:57:52 +01:00
Christian Kamm
6347aeeed2
CMake: Add a default placeholder_suffix
...
To make themes work that don't define it explicitly.
2020-12-15 10:57:51 +01:00
Markus Goetz
8dcfd50a7d
Placeholders: Support for macOS #6290
2020-12-15 10:57:51 +01:00
Olivier Goffart
600b1a72c1
Fix test: QTemporaryDir::filePath was added in Qt 5.9
2020-12-15 10:57:51 +01:00
Christian Kamm
765c12dae1
LocalDiscoveryTracker: Separate from Folder and move to libsync
...
To allow relevant code to be closer together and for testing in
unittests without having to get a gui Folder.
See #6120
2020-12-15 10:57:51 +01:00
Olivier Goffart
7969067f80
Logger: Guard zlib usage by ZLIB_FOUND
...
Similar to the use for the checksum.
I know that zlib is required in principle, but i don't have it
in one of my test building environment, and it is easier to just
disable it.
2020-12-15 10:57:51 +01:00
Kevin Ottens
b1dc14977f
Get TestDownload to pass
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:57:51 +01:00
Olivier Goffart
4eb8997519
Download: Remove useless code and add a test
...
From issue #7015 , the code is wrong because the path is the file system path and
not the path on the DB.
But since this is a conflict, this means the reconcile will still want to download
the file from the server next sync, so we need not to worry about this case
2020-12-15 10:57:50 +01:00
Olivier Goffart
718843ffce
Download: Use the <s:message> from the reply in the error message if any
...
Issue: #6459
2020-12-15 10:57:50 +01:00
Olivier Goffart
50223d889b
Add a test for resuming downloads
2020-12-15 10:57:50 +01:00
Christian Kamm
9c6a76d280
Doc: Add showExperimentalOptions to conffile.rst
2020-12-15 10:57:50 +01:00
Christian Kamm
27c8bce0b9
Wizards: Show placeholder option only if showExperimentalOptions is set
...
This config file option will also control other features in the future.
2020-12-15 10:57:50 +01:00
Christian Kamm
aee8b9f3c5
Wizards: Add placeholder option and warning to account wizard
...
Also add the warning dialog to the option in the folder wizard.
2020-12-15 10:57:50 +01:00
Christian Kamm
7dc65b060d
NSIS: Register placeholder extension
...
Also change the placeholder suffix config option to not include the dot,
the dotless form is needed in the nsis script.
2020-12-15 10:57:50 +01:00
Christian Kamm
6a37a7a42c
Placeholders: Fix migration issues
...
Some edgecases weren't covered and didn't have tests yet.
2020-12-15 10:57:49 +01:00
Christian Kamm
40f2303166
SyncOptions: Add default placeholder suffix
...
Otherwise each test has to set this up anew.
2020-12-15 10:57:49 +01:00
Christian Kamm
12d6f680f2
Placeholders: Ignore placeholder files in older clients
...
To do this, we add the placeholder extension to the user exclude file
automatically. However, newer clients shouldn't use that exclude
pattern: so we also add version directives that allow making exclude
patterns dependent on the client version.
2020-12-15 10:57:49 +01:00
Christian Kamm
d6078f958b
Placeholders: Download from shell integration
2020-12-15 10:57:49 +01:00
Olivier Goffart
91f53521ae
Placeholder: The extension is now a branding option
2020-12-15 10:57:49 +01:00
Olivier Goffart
a2bdd5b9a5
Placeholders: Fixup clicking on placeholder after previous change
...
Now that the name in the db is the name of the placeholder file,
we need to adjust the call to downloadPlaceholder
2020-12-15 10:57:49 +01:00
Christian Kamm
b1de184bc8
Placeholders: Safe migration to older client versions
...
Now the db entries for placeholders will have the full placeholder
paths. That way older clients will, on remote discovery, delete the
placeholders and download the real files.
2020-12-15 10:57:48 +01:00
Christian Kamm
0cd83a2c09
Placeholders: Deal with conflicts when a placeholder exists
...
So "foo.owncloud" exists but the user adds a new "foo".
2020-12-15 10:57:48 +01:00
Olivier Goffart
d233e5f8d7
Placeholders: install mimetype on linux
2020-12-15 10:57:48 +01:00
Olivier Goffart
7eeb99ba24
Placeholders: Add an checkbox in the FolderWizard to enable the placeholder feature
2020-12-15 10:57:48 +01:00
Olivier Goffart
1049fb74d9
Placeholders: Move the placeholder option from the account to the folder
2020-12-15 10:57:48 +01:00
Olivier Goffart
6ce7c7a56b
PlaceHolders: Trigger a download of the placeholder and open it
2020-12-15 10:57:48 +01:00
Christian Kamm
f5cf03b6a6
On-demand downloading: Placeholder-file based prototype
...
- Controled by an option.
- New remote files start out as ItemTypePlaceholder, are created with a
.owncloud extension.
- When their db entry is set to ItemTypePlaceholderDownload the next
sync run will download them.
- Files that aren't in the placeholder state sync as usual.
- See test cases in testsyncplaceholders.
Missing:
- User ui for triggering placeholder file download
- Maybe: Going back from file to placeholder?
2020-12-15 10:57:43 +01:00
Camila
c50b1cc37c
Merge pull request #2714 from nextcloud/ensure_sync_after_conflict_resolution
...
Ensure a sync happens after a conflict resolution
2020-12-15 10:48:43 +01:00
Kevin Ottens
8c4bd2bb52
Ensure a sync happens after a conflict resolution
...
You'd expect that after a conflict resolution the file watcher would
pick up the change and trigger a sync. For some reason it doesn't seem
to happen on at least some Ubuntu systems. In such cases the user would
then still have a stale conflict entry in the activity list and wouldn't
be able to do anything with it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 09:40:57 +00:00
Camila
75a97bdaf3
Merge pull request #2713 from nextcloud/usermodel_properly_check_out_of_bound_index
...
UserModel: check indices are inside the user list
2020-12-15 10:37:58 +01:00
Kevin Ottens
d640076454
UserModel: check indices are inside the user list
...
The model was just checking for the user list being empty or not which
is overly optimistic. Indeed there might be cases where the id is
actually outside the boundaries so properly check for this.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 08:43:32 +00:00
Nextcloud bot
94c4e3044c
[tx-robot] updated from transifex
2020-12-15 03:48:34 +00:00
Kevin Ottens
2415d9525b
Merge pull request #2708 from nextcloud/fix_new_account_wizard_open
...
Have the new account wizard open again
2020-12-14 16:28:31 +01:00
Kevin Ottens
5ed397a430
Have the new account wizard open again
...
UserModel can't be connected to AccountSettings if the settings dialog
doesn't exist. This is the case now since we delay the creation of that
dialog and free it after use.
Instead it should be properly channeled through the Systray object all
the way up to OwncloudGui which knows how to handle this properly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-14 15:58:52 +01:00
Camila
be1fb77488
Merge pull request #2692 from nextcloud/fix-issue-1029
...
Handle the warning message when unchecking folders for syncing.
2020-12-14 12:54:05 +01:00
Camila
b4dc682690
Handle the warning message when unchecking folders for syncing.
...
Split widgets and slot to handle the refreshing of the view:
- refreshSelectiveSyncStatus is connected to signal dirtyChanged
and will handle big folder warning.
- slotSelectiveSyncChanged which is connected to dataChanged signal
and will handle the selective sync warning. It fixes #1029 because
it looks for the checkbox state before showing the warning.
Signed-off-by: Camila <hello@camila.codes >
2020-12-14 12:36:51 +01:00
Nextcloud bot
0b985f2743
[tx-robot] updated from transifex
2020-12-14 03:48:55 +00:00
Nextcloud bot
8c47d62fa2
[tx-robot] updated from transifex
2020-12-13 03:44:59 +00:00
Nextcloud bot
2de52c351a
[tx-robot] updated from transifex
2020-12-12 03:47:17 +00:00
Nextcloud bot
dc229480b3
[tx-robot] updated from transifex
2020-12-11 03:46:02 +00:00
Kevin Ottens
7f0e64ef67
Merge pull request #2698 from nextcloud/themed-icons-v2
...
Use the icon color property to color the icons in the tray window header.
2020-12-10 19:06:40 +01:00
Camila
cfbd22b5e7
Use the icon color property to color the icons in the tray window header.
...
The icon color is set with APPLICATION_WIZARD_HEADER_TITLE_COLOR in the
theme.
Signed-off-by: Camila <hello@camila.codes >
2020-12-10 17:43:45 +01:00
Kevin Ottens
5b534761bf
Merge pull request #2697 from nextcloud/v3.1.5
...
Bump master version to 3.1.50
2020-12-10 14:18:35 +01:00
allexzander
7b575fc643
Bump master version to 3.1.5
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-10 14:54:25 +02:00
allexzander
6c651f1cb6
Bump master version to 3.1.5
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-10 14:44:58 +02:00
Kevin Ottens
7f4ffd0f72
Merge pull request #2696 from nextcloud/v.3.1.0
...
Bump master version to 3.1.0
2020-12-10 12:16:47 +01:00
allexzander
e6b06d0a6b
Bump master version to 3.1.0
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-10 12:47:51 +02:00
Nextcloud bot
e160788204
[tx-robot] updated from transifex
2020-12-10 03:53:56 +00:00
Nextcloud bot
f5d4ac518f
[tx-robot] updated from transifex
2020-12-09 03:44:40 +00:00
allexzander
31d3ce7663
Merge pull request #2685 from nextcloud/fix-slow-sharee-search-in-dialog
...
Fixed slow sharee search in the share dialog
2020-12-08 15:56:29 +02:00
allexzander
9266ecc2e8
Fixed slow sharee search in the share dialog
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-08 13:48:43 +00:00
allexzander
14105d4ec6
Merge pull request #2686 from nextcloud/add-email-sharing
...
Added sharing via email.
2020-12-08 15:24:08 +02:00
allexzander
6e8658dc2c
Added sharing via email.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-08 11:08:45 +02:00
Nextcloud bot
1d7b7c26d3
[tx-robot] updated from transifex
2020-12-08 03:48:38 +00:00
Kevin Ottens
b2dfa29325
Merge pull request #2690 from nextcloud/update-documentation
...
Update documentation on how to generate debug logs.
2020-12-07 16:22:37 +01:00
Camila
09c2279bb5
Update documentation on how to generate debug logs.
...
Minor change: bypasses => bypass.
Signed-off-by: Camila <hello@camila.codes >
2020-12-07 14:52:51 +01:00
Nextcloud bot
4886525e08
[tx-robot] updated from transifex
2020-12-07 03:48:13 +00:00
Nextcloud bot
f2fd083898
[tx-robot] updated from transifex
2020-12-06 03:43:57 +00:00
Nextcloud bot
8a2eb71c4f
[tx-robot] updated from transifex
2020-12-04 03:45:51 +00:00
Kevin Ottens
8e29935195
Merge pull request #2682 from nextcloud/debug-skip
...
Add debug log to check which folders are being skipped during syncing.
2020-12-03 12:37:38 +01:00
Camila
5517ff2c02
Add debug log to check which folders are being skipped during syncing.
...
Signed-off-by: Camila <hello@camila.codes >
2020-12-03 12:24:25 +01:00
Nextcloud bot
bd959018a1
[tx-robot] updated from transifex
2020-12-03 03:45:56 +00:00
Camila
a527e85fe6
Merge pull request #2666 from nextcloud/notification_actions_bring_back_from_version_2
...
Notification action buttons and context menu
2020-12-02 15:42:32 +01:00
allexzander
f04281cb69
Implemented notification action buttons and context menu for confirm/dismiss and other actions.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-02 08:08:37 +00:00
Kevin Ottens
7721832ee0
Merge pull request #2677 from briankendall/fix-tray-window-spaces-bug
...
Fix macOS bug where tray window causes spaces to switch
2020-12-02 08:23:19 +01:00
Brian Kendall
f9991e180c
Fix macOS bug where tray window causes spaces to switch
...
Signed-off-by: Brian Kendall <brian@briankendall.net >
2020-12-02 06:54:16 +00:00
Nextcloud bot
bc38c0ba3f
[tx-robot] updated from transifex
2020-12-02 03:46:16 +00:00
Nextcloud bot
9ff8d97647
[tx-robot] updated from transifex
2020-12-01 03:45:58 +00:00
István Váradi
62bf777cda
Merge pull request #2652 from ivaradi/debian-version-discrepancy
...
Handle the case when the release version differs from that in VERSION.cmake
2020-11-30 16:46:20 +01:00
István Váradi
3d9d5f2fe7
Handle the case when the release version differs from that in VERSION.cmake
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-11-30 15:33:34 +01:00
allexzander
57e1f2ac07
Merge pull request #2675 from nextcloud/fix-appimage-build
...
fix AppImage build
2020-11-30 14:20:30 +02:00
allexzander
0fdb423fe0
fix AppImage build by using v0.10.0 for qtkeychain
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-30 13:41:12 +02:00
Nextcloud bot
7bfd8ea23c
[tx-robot] updated from transifex
2020-11-30 03:43:17 +00:00
Nextcloud bot
57a4cd926d
[tx-robot] updated from transifex
2020-11-29 03:42:10 +00:00
Nextcloud bot
de4edb6099
[tx-robot] updated from transifex
2020-11-28 03:39:34 +00:00
Nextcloud bot
70dbbbeaa4
[tx-robot] updated from transifex
2020-11-27 03:40:43 +00:00
Camila
9614d051a5
Merge pull request #2667 from nextcloud/version-bump
...
Master is now 3.0.82.
2020-11-26 13:08:20 +01:00
Camila
8d1fe8ed3c
Master is now 3.0.82.
...
Signed-off-by: Camila <hello@camila.codes >
2020-11-26 12:52:55 +01:00
Camila
4d133ba9a5
Merge pull request #2540 from nextcloud/fix-issue-1458
...
Add last / to exclude list file path.
2020-11-26 12:51:53 +01:00
Camila
bdd3465e7b
Check if there are patterns associated with a sync exclude file.
...
The previous check didn't take into the account that .sync-exclude.lst
might be empty which would crash at Q_ASSERT(_allExcludes.contains(basePath))
in the prepare function. It also takes into account that
_allExcludes[basePath] was creating new items in the list.
Signed-off-by: Camila <hello@camila.codes >
2020-11-26 12:12:04 +01:00
Camila
998e93ac13
Add last / to exclude list file path.
...
This Q_ASSERT(this->endsWith('/')) in BasePathByteArray was the reason
for bug report #1458 .
Signed-off-by: Camila <hello@camila.codes >
2020-11-26 12:11:57 +01:00
Nextcloud bot
820ab12561
[tx-robot] updated from transifex
2020-11-26 03:45:21 +00:00
Kevin Ottens
c38189e981
Merge pull request #2665 from nextcloud/sparkle_build_fixes
...
Sparkle build fixes
2020-11-25 18:00:34 +01:00
Dominik Schmidt
a50c665051
Simplify Sparkle handling in CMake
2020-11-25 09:43:59 +01:00
Chih-Hsuan Yen
6962cbf582
Fix build without Sparkle.framework
...
(PR #6567 )
2020-11-25 09:40:20 +01:00
Christian Kamm
60d3696ccd
Settings: Add warning when switching update channel
2020-11-25 09:39:16 +01:00
Nextcloud bot
c4987aa641
[tx-robot] updated from transifex
2020-11-25 03:42:43 +00:00
Camila
104d3c0661
Merge pull request #2647 from nextcloud/cherry_pick_updater_fixes_and_improvements
...
Cherry pick updater fixes and improvements
2020-11-24 20:58:26 +01:00
Kevin Ottens
4906353f2e
Please the clang-tidy overlord
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-24 18:22:33 +00:00
Hannah von Reth
038644f378
Don't scare users with critical parser log messages
2020-11-24 18:22:33 +00:00
Hannah von Reth
d30cd0f0fd
Include architecture in updater query
...
Fixes : #8074
2020-11-24 18:22:33 +00:00
Hannah von Reth
c76095859a
Cleanup stirngs
2020-11-24 18:22:33 +00:00
Olivier Goffart
a7f010c370
Updater: Fix crash when there is an XML error
...
The problem was accessing the lines with an off by one error, while printing
the log.
Other problem included the fact that QDebug added spaces, quotes, and other
things which made the error lot look right in the console.
Issue #7545
2020-11-24 18:22:33 +00:00
Olivier Goffart
1bf895cadc
Updater: Fix Version numer not shown in the user visible string
...
There was one argument too many in the string.
Bug was introduced in commit 21ac396b
Issue: #7288
2020-11-24 18:22:33 +00:00
Christian Kamm
c58f00abc7
Updater: Improved logging output #7388
2020-11-24 18:22:33 +00:00
Hannah von Reth
1df3f5b6df
NSISUpdater: Improve logging for version comparison
2020-11-24 18:22:33 +00:00
Hannah von Reth
1aca005267
Updater: Log parsing issues in autoupdatLog parsing issues in autoupdatee
2020-11-24 18:22:33 +00:00
Markus Goetz
9a375211d7
Autoupdater: Log the URL #3475
2020-11-24 18:22:33 +00:00
Christian Kamm
d2991210c5
Updater: Preserve target version string
...
For #7217
2020-11-24 18:22:33 +00:00
Christian Kamm
aa7409f401
Updater: Make "Update manually" not also "skip this version"
...
See #7217
2020-11-24 18:22:33 +00:00
Christian Kamm
0b3512f49c
WinUpdater: More useful options on update failure #7217
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-24 18:22:33 +00:00
Olivier Goffart
9596eb7f20
Updater: show the human readable version in the settings
...
The xml looks like this:
<version>2.5.0.328</version>
<versionstring>ownCloud Client 2.5.0 alpha1 (build 238)</versionstring>
And we should show the version string
Issue #6602
2020-11-24 18:22:33 +00:00
Olivier Goffart
f2c3ef741b
Updater: remove unused function
2020-11-24 18:22:33 +00:00
Dominik Schmidt
ae38b88d1c
Remove unused installers before copying new ones into the appdata dir
2020-11-24 18:22:33 +00:00
Olivier Goffart
e93972824d
MSI: Fix crash in the auto updater
...
'auto' here is a QStringBuilder referencing a temporary
Ammend commit 150d4f5935
(MSI: Always with logfile #6609 )
Found in the crash reporter:
https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/
2020-11-24 18:22:33 +00:00
Markus Goetz
5e518419de
MSI: Always with logfile #6609
2020-11-24 18:22:33 +00:00
Dominik Schmidt
d069fda9ab
Extract filename of updateFile without leading slash
2020-11-24 18:22:33 +00:00
Dominik Schmidt
dfac8c0e59
Escape msi and owncloud.exe path (who knows...)
2020-11-24 18:22:33 +00:00
Dominik Schmidt
ed0dc68db2
Run msi properly and restart client after update
2020-11-24 18:22:33 +00:00
Dominik Schmidt
08b5981fb6
Implement basic .msi support in updater
2020-11-24 18:22:33 +00:00
Markus Goetz
412e43b696
Updater: Comments
2020-11-24 18:22:33 +00:00
Christian Kamm
4b39731c27
Updater: Make sparkle updater respect release channel
2020-11-24 18:22:33 +00:00
Markus Goetz
311e3a3bd8
Auto Updater: Show UI element also on macOS
...
(cherry picked from commit dfdc2e1e87f99d387a042f4983c999fbb7fcf3d9)
2020-11-24 18:22:33 +00:00
Christian Kamm
a8ad946758
Settings: Add update channel combobox #6259
2020-11-24 18:22:33 +00:00
Markus Goetz
65035d1990
Sparkle: Delegate calls work now with 1.18.1 (maybe even before)
...
We can extend on this to give UI feedback.
2020-11-24 18:22:33 +00:00
Camila
c24b81c081
Merge pull request #2660 from nextcloud/folder-watcher
...
FolderWatcher: fixes and improvements
2020-11-24 19:19:08 +01:00
Christian Kamm
08014b6dc3
FolderWatcher: Disable test on OSX #7305
2020-11-24 16:56:49 +00:00
Olivier Goffart
5a432a193f
FolderWatcher: Usage of QTime for elapsed time is deprecated
2020-11-24 16:56:49 +00:00
Christian Kamm
28e4fc54a1
FolderWatcher: Wait for ready before testing #7305
2020-11-24 16:56:49 +00:00
Christian Kamm
e97fc430bf
FolderWatcher: Become unreliable if test notification fails #7241
...
Necessary for some filesystems on windows that don't have full file
watching capabilities.
2020-11-24 16:56:49 +00:00
Christian Kamm
74382ddcc0
FolderWatcher linux: Make automatically recursive #7068
...
Previously it depended on addFolder() / removeFolder() calls to adjust
watchers when new folders were added or removed. There also needed to be
complex move handling.
Now, any folder creation/move-in notifications automatically trigger
watcher additions and folder deletion/move-out triggers removal.
2020-11-24 16:56:49 +00:00
Christian Kamm
21b931dc6b
FolderWatcher: Always notify about conflict files #7073
...
This makes sure that the conflict list can be updated if a user resolves
a conflict by deleting the local conflict file. Previously one had to
wait for the next sync run.
2020-11-24 16:56:49 +00:00
Christian Kamm
351bada552
Folderwatcher: On linux, fix paths after dir renames #6808
...
If a folder was renamed A -> B, the folder watcher for the inode
would be unaware and still report changes for A/foo. Now directory
renames in the watched folders are tracked and paths are updated
accordingly.
2020-11-24 16:56:49 +00:00
allexzander
fe29290564
Merge pull request #2663 from nextcloud/fix-windows-compilation
...
Fix Windows compilation broken after QML debugging fix.
2020-11-24 18:34:04 +02:00
allexzander
29ca1404cc
Fix Windows compilation broken after QML debugging fix.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-24 16:50:16 +02:00
allexzander
d4c14f8f4f
Merge pull request #2662 from nextcloud/fix-qml-debugging
...
Fix QML debugging by removing incorrect dependency
2020-11-24 16:24:17 +02:00
allexzander
92733e9069
Fix QML debugging by removing incorrect dependency
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-24 15:19:17 +02:00
Nextcloud bot
2aa3d17e5c
[tx-robot] updated from transifex
2020-11-24 03:41:57 +00:00
Kevin Ottens
7cf3f14f78
Merge pull request #2658 from nextcloud/enable_qml_debugger_on_debug_builds
...
Enable the QML debugger on debug builds
2020-11-23 18:59:52 +01:00
Kevin Ottens
922b322337
Enable the QML debugger on debug builds
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-23 17:39:50 +00:00
allexzander
f530758f78
Merge pull request #2655 from nextcloud/use-dinamyc-path-for-account-state-icons
...
Use dynamic path for account online/offline state icon. Refresh GUI on connection state change.
2020-11-23 18:01:13 +02:00
allexzander
665a8c4217
Use dynamic path for account online/offline state icon. Refresh GUI on connection state change.
...
Signed-off-by: Alex Zolotov <alex.zolotov.nextcloud.com>
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-23 17:49:25 +02:00
Nextcloud bot
10cb0a71eb
[tx-robot] updated from transifex
2020-11-23 03:38:35 +00:00
Nextcloud bot
e6ea3878a9
[tx-robot] updated from transifex
2020-11-21 03:44:21 +00:00
Nextcloud bot
8faa103ebf
[tx-robot] updated from transifex
2020-11-20 03:43:18 +00:00
Nextcloud bot
d0004230b9
[tx-robot] updated from transifex
2020-11-19 03:43:51 +00:00
Kevin Ottens
44f2bc24ff
Merge pull request #2648 from nextcloud/debian_packages_should_not_block_ci
...
Issue a warning for Debian pipeline failures but don't fail the CI
2020-11-18 16:32:29 +01:00
Kevin Ottens
6f25840ec9
Issue a warning for Debian pipeline failures but don't fail the CI
...
Since this fails every time we bump the version number and takes time to
catch up while failing every following PRs, let's prevent this pipeline
from failing the CI.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-18 16:05:19 +01:00
Nextcloud bot
1950efcfff
[tx-robot] updated from transifex
2020-11-18 03:41:49 +00:00
Nextcloud bot
d026aa9301
[tx-robot] updated from transifex
2020-11-16 03:43:48 +00:00
Nextcloud bot
0d7865e6f8
[tx-robot] updated from transifex
2020-11-15 03:41:36 +00:00
Nextcloud bot
fa1f20ca8e
[tx-robot] updated from transifex
2020-11-14 03:44:00 +00:00
Nextcloud bot
771bac2279
[tx-robot] updated from transifex
2020-11-13 03:43:12 +00:00
Kevin Ottens
ebcdb41fb9
Merge pull request #2630 from nextcloud/bump_to_version_3.0.81
...
Master is now 3.0.81
2020-11-12 16:31:01 +01:00
Kevin Ottens
d2e0959b47
Master is now 3.0.81
...
This feels a bit like moving back in that case, but that's due to the
change of convention in the release process. We used to bump early but
now we're moving to a point when we bump at the last minute.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-12 15:53:16 +01:00
Nextcloud bot
2316cb6ce4
[tx-robot] updated from transifex
2020-11-12 03:44:40 +00:00
Nextcloud bot
f66b091e12
[tx-robot] updated from transifex
2020-11-11 03:47:29 +00:00
Camila
00a47fefaf
Merge pull request #2616 from nextcloud/move_journaldb_files_back_to_sync_folders
...
Move journaldb files back to sync folders
2020-11-10 19:19:14 +01:00
Kevin Ottens
4f7876f520
Migrate journal dbs files back to the sync folder
...
In case of past collisions during the 3.0 times... well one will resync
from scratch unfortunately. But if that happened there are likely other
problems which occurred.
Also this might fix some of the bugs with people loosing settings from
the database. Indeed the -wal and -shm concatenations were wrong. Using
append was in fact changing the folderDefinition member which (I guess)
would potentially lead to funny ".db-wal-shm-wal-shm" names.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Kevin Ottens
0b731eb516
Revert "moved default db sync file to Qt standard path AppDataLocation"
...
This reverts commit fc6b895f52 .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Kevin Ottens
1b553b93b9
Partial Revert "Adapted for cmd version and added migration step for config file"
...
This partially reverts commit 67ed54671b .
The migration code was left untouched.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Kevin Ottens
cebd39aa85
Revert "Adjust to makeDbName returning an absolute path"
...
This reverts commit 2492e241ac .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Camila
2e97a7fb74
Merge pull request #2531 from nextcloud/bring_back_systray_menu_pause_sync_action
...
Bring back the "Pause sync" action in the systray context menu
2020-11-10 18:43:52 +01:00
Kevin Ottens
6c463442ef
Bring back the pause/resume action in the systray menu
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:29:51 +00:00
Kevin Ottens
1288ee0437
Move pause/unpause helpers to Systray
...
We had signals just to call those backs in ownCloudGui, they were
otherwise unused. So let's move them inside of Systray since it's
specific to it anyway.
Also fix the dangerous call to sender(). We can call this function
without going through a signal/slot connection and also it's never
connected to an AccountState.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:29:51 +00:00
Camila
3ffc699058
Merge pull request #2620 from nextcloud/fix_crash_when_displaying_share_dialog
...
Make sure the settings dialog exist before hiding it
2020-11-10 18:09:54 +01:00
Kevin Ottens
95487d8bfc
Make sure the settings dialog exist before hiding it
...
Because of PR #2580 the settings dialog doesn't always exist. We need to
check for it first before placing calls to it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 16:57:56 +00:00
Camila
863db075eb
Merge pull request #2621 from nextcloud/wiswedel/documentation/chunkedUpload
...
[documentation] upload chunks config
2020-11-10 17:56:28 +01:00
Sascha Wiswedel
e69b26e363
[documentation] upload chunks config
...
documenting e86499d990
2020-11-10 14:56:32 +01:00
Nextcloud bot
4382193519
[tx-robot] updated from transifex
2020-11-10 03:45:50 +00:00
Nextcloud bot
7a093592a0
[tx-robot] updated from transifex
2020-11-09 03:42:28 +00:00
Nextcloud bot
942d8ba86a
[tx-robot] updated from transifex
2020-11-08 03:42:17 +00:00
Nextcloud bot
9f9bcecd31
[tx-robot] updated from transifex
2020-11-07 03:42:02 +00:00
Kevin Ottens
46aba0832d
Merge pull request #2615 from nextcloud/fetch_apps_on_connectivity_changes_only
...
Fetch apps when we get connected only
2020-11-05 13:55:36 +01:00
Kevin Ottens
86d240f7b4
Fetch apps when we get connected only
...
This was right now on the check connectivity beat which is too much when
you got many users. Be more conservative there and only update the list
of apps when the account gets connected.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-05 13:37:25 +01:00
Nextcloud bot
6445a61d80
[tx-robot] updated from transifex
2020-11-05 03:40:34 +00:00
Nextcloud bot
3749fe15b6
[tx-robot] updated from transifex
2020-11-04 03:41:27 +00:00
Nextcloud bot
50e038cfaa
[tx-robot] updated from transifex
2020-11-03 03:41:44 +00:00
Camila
44a55674ac
Merge pull request #2603 from nextcloud/remove_findqt5keychain_cmake_module
...
Get rid of FindQt5Keychain.cmake
2020-11-02 14:36:46 +01:00
Kevin Ottens
0e617d020f
Adjust AppImage build of QtKeychain to be found by cmake
...
Now that things are done in a more standard way, let's adjust the
AppImage build so that QtKeychain is picked up properly now that our
FindQt5Keychain.cmake file is gone.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-02 13:28:02 +01:00
Kevin Ottens
3427dadaeb
Get rid of FindQt5Keychain.cmake
...
QtKeychain provides Qt5KeychainConfig.cmake and friends nowadays, so no
need to have a less reliable and outdated find module on our end.
Also this shows that we were including keychain.h in the wrong way and
were not using the link target, so both got fixed as well.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-02 13:19:48 +01:00
Nextcloud bot
dfd6cce978
[tx-robot] updated from transifex
2020-11-02 03:41:37 +00:00
Nextcloud bot
5a8c2bab89
[tx-robot] updated from transifex
2020-11-01 03:40:38 +00:00
Nextcloud bot
a14930c293
[tx-robot] updated from transifex
2020-10-31 03:41:57 +00:00
Nextcloud bot
a3914482d7
[tx-robot] updated from transifex
2020-10-30 03:42:51 +00:00
Kevin Ottens
56d067d7a9
Merge pull request #2589 from sryze/windows7-fixes
...
Misc fixes for Windows 7
2020-10-28 07:39:14 +01:00
Sergey Zolotarev
18c1bc0bd6
Misc fixes for Windows 7
...
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com >
2020-10-28 06:24:53 +00:00
Nextcloud bot
ef86d4b738
[tx-robot] updated from transifex
2020-10-28 03:42:53 +00:00
Nextcloud bot
a74861dbb5
[tx-robot] updated from transifex
2020-10-27 03:42:33 +00:00
Kevin Ottens
9593cea18c
Merge pull request #2591 from nextcloud/fix_conflict_dialog_wording
...
Remove last left over of the "remote" wording
2020-10-26 16:09:49 +01:00
Kevin Ottens
3e6b257ccd
Remove last left over of the "remote" wording
...
I switched from "remote" to "server" but apparently left one behind by
mistake...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-26 14:45:46 +00:00
Valdnet
d17c9af044
Merge pull request #2586 from nextcloud/Valdnet-patch-2
...
l10n: Change the triple dot to ellipsis
2020-10-26 15:09:15 +01:00
Valdnet
204cced445
l10n: Change the ellipsis
2020-10-26 13:22:55 +00:00
Valdnet
f116c39b0a
l10n: Add a space in generalsettings.ui
2020-10-26 13:22:55 +00:00
Kevin Ottens
6b794ddd5a
Merge pull request #2582 from nextcloud/macos_add_more_information_on_skipped_file_watcher_event
...
Also output the event flags in the debug logs
2020-10-26 14:15:15 +01:00
Kevin Ottens
8fad88055e
Also output the event flags in the debug logs
...
When we skip a watcher event on mac, we log the file path but not the
event flags which came with it. Let's add it, it should help figure out
what's going on with #2578 .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-26 12:37:00 +00:00
Valdnet
1627522695
Merge pull request #2587 from nextcloud/rakekniven-patch-1
...
Triple dot to ellipsis
2020-10-26 13:32:42 +01:00
rakekniven
62fa8028a6
Triple dot to ellipsis
...
Reported at Transifex.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-10-26 12:22:23 +00:00
Nextcloud bot
92801816e0
[tx-robot] updated from transifex
2020-10-26 03:37:49 +00:00
Nextcloud bot
599cf0143f
[tx-robot] updated from transifex
2020-10-25 03:39:15 +00:00
Nextcloud bot
38205cab68
[tx-robot] updated from transifex
2020-10-24 03:39:31 +00:00
Nextcloud bot
fa8f37e987
[tx-robot] updated from transifex
2020-10-23 03:38:53 +00:00
Camila
2bcc99792d
Merge pull request #2581 from nextcloud/ensure_systray_window_doesnt_prevent_windows_session_close
...
Ensure we quickly show/hide the systray window on startup
2020-10-22 19:48:43 +02:00
Kevin Ottens
24964e2b9b
Ensure we quickly show/hide the systray window on startup
...
This is quick enough that no flickering should appear in practice.
We end up doing this because for some reason on Windows (I dug up deep
into the Windows QPA without nailing it down) not showing that systray
window at least once prevents the app object to return from exec() when
the session ends.
It's as if that window would be in some limbo state (neither opened nor
closed) which would prevent quitting. Clearly what we're doing here is a
workaround...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 17:31:05 +00:00
Kevin Ottens
802d27ed0f
Merge pull request #2527 from nextcloud/improve_conflict_handling_gui
...
Improve conflict handling gui
2020-10-22 18:27:45 +02:00
Kevin Ottens
b835092ae9
Use the ConflictDialog directly from the activity list
...
No need to go to the file manager first to then have the user go through
the context menu, just popup the dialog directly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:47 +02:00
Kevin Ottens
4116c90c9c
Move the activity action behavior on the C++ side
...
We better do this before this business logic grows in the QML side and
gets out of control. We'll need finer grained information due to the
conflict handling anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
910f0c9339
Repair SettingsDialog::showIssuesList
...
This was completely disabled code and the connect was gone... So let's
introduce the connect back and have it trigger the main window while
selecting the right user. This way the new activity list is displayed
and since the conflicts are shown at the top this is hopefully obvious
again.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
c42f4abd25
Add a function to know the user id matching a given account
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
e3b97b0a04
In the case of conflicts, have the socket api propose the config dialog
...
This should be safe in the case of conflicts in folders on which the
user can write. For other cases we still use the older actions.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
49c478cd2a
Add a conflict dialog to help the user solve them
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
67e81fcd0f
Add KeepBothVersions as a possible solution to ConflictSolver
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
4fdb203cdb
Move some of the SocketApi conflict handling in a ConflictSolver class
...
The socket api move and delete commands are not strictly about conflicts
since they also deal with files which couldn't be uploaded for some
other reason. Still the new ConflictSolver could be used in those cases.
This opens the door at reusing that logic in other places.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
26d62a9712
Repair the canAddToDir logic
...
This could only work at the root of the sync folder where the record for
the parent folder would be invalid. Otherwise the negation would be
wrong... assuming you can add a file only if the permission is not
there.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:44 +02:00
Christian Kamm
00e901f5a7
SocketAPI: Introduce conflict resolution actions #6252
...
For conflicts generally as well as new files in read-only directories
the context menu will now present delete and move options.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:10 +02:00
Christian Kamm
f62be57ef2
FileSystem: make removeRecursively() reusable
...
We want to use it for deleting directory conflicts.
2020-10-22 16:39:17 +02:00
Christian Kamm
e70371f408
FileSystem: Fix bad indentation
2020-10-22 16:39:17 +02:00
Kevin Ottens
b982a17998
Merge pull request #2580 from nextcloud/delay-settingsdialog-init
...
Delay initialization of SettingsDialog
2020-10-22 15:08:01 +02:00
Michael Schuster
7699004a11
Fix crash in SettingsDialog with delayed initialization
...
setWindowFlags triggered changeEvent, thus causing a crash in customizeStyle.
This fix should be kept even if we decide against delayed init in the future.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-22 11:29:38 +00:00
Michael Schuster
0fb10163a3
Delay initialization of SettingsDialog
...
ownCloudGui::slotShowSettings already got what it takes to create it only when we try to show it for the first time.
This however has some implications:
Pros:
- Only created when needed, while testing saved ca. 20 MB of RAM and got freed again after closing the dialog.
- Since we defaulted to the new Tray UI from 3.0, this is an added bonus for users don't opening the settings.
Cons:
- Resources like the avatar image have to be refetched everytime the dialog is recreated.
This may be desired as well, because it ensures displaying no outdated info (e.g. on connection issues).
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-22 11:29:38 +00:00
Nextcloud bot
40aa53bf76
[tx-robot] updated from transifex
2020-10-22 03:39:17 +00:00
Kevin Ottens
bb43127633
Merge pull request #2575 from nextcloud/expose_branding_values_to_qtquick
...
Expose branding values to qtquick
2020-10-21 14:13:40 +02:00
Kevin Ottens
c6c2d4cf4c
Use the Theme colors for the header part of the window
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:46:51 +02:00
Kevin Ottens
a2e3f9d63a
Expose Theme on the QML side
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:46:38 +02:00
Kevin Ottens
7536e4c00b
Expose the branding related members of Theme as properties
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:46:04 +02:00
Kevin Ottens
de63e5e221
Don't hardcode the color of text in the header
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:40:42 +02:00
Kevin Ottens
0e9efe728a
Get rid of ncBlueHover
...
Use a similar trick of a semi-transparent rectangle on top when the
mouse area is hovered. This way it will always work whatever is the
background color.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 11:24:06 +02:00
Kevin Ottens
60da0cee25
Merge pull request #2572 from nextcloud/avoid_depth_infinity_propfind_for_e2ee
...
Avoid depth infinity propfind for e2ee
2020-10-21 10:16:14 +02:00
Kevin Ottens
10cb4170c7
Don't use depth infinity anymore to get the folders e2ee status
...
This way we avoid the expensive SQL query on the server at the price of
more round-trips since we're doing the recursive traversal by hand now.
Also it turns out this depth was used for all the other propfind calls
during sync when we want fresher information regarding a folder. This
was very inefficient in all cases and won't happen anymore.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:59 +02:00
Kevin Ottens
b5fdbefb0e
Make sure jobs don't outlive ClientSideEncryption
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
399b97442e
Factor out the logic to start a new e2ee status job
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
cbc40b5a15
Mention the folder we listed in the debug logs
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
8e3ca71763
Change the way we store the job result
...
If there's more than one job we need to unite the maps not simply overwrite
them.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
9aeb7046d2
Start managing a list of GetFolderEncryptStatusJob
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
cfb66ddadd
Add a way to know which folder was listed for encrypted status
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Nextcloud bot
65b90f4bb1
[tx-robot] updated from transifex
2020-10-21 03:39:44 +00:00
Kevin Ottens
534f0567bf
Merge pull request #2568 from nextcloud/fix-macos-crash-403-folder-view
...
Fix crash when clicking on folder with status 403 in the main dialog.
2020-10-20 16:38:13 +02:00
Camila San
03b1c0b84a
Fix crash when clicking on folder with status 403 in the main dialog.
...
LsColJob was still being used after delete was called.
Signed-off-by: Camila San <hello@camila.codes >
2020-10-20 16:19:27 +02:00
Nextcloud bot
671ca522ea
[tx-robot] updated from transifex
2020-10-20 03:38:46 +00:00
Kevin Ottens
0927b9bc90
Merge pull request #2551 from nextcloud/fix_share_dialog_animation_for_enforced_password_policy
...
Fix share dialog animation for enforced password policy
2020-10-19 17:09:55 +02:00
Kevin Ottens
b7ea6530c5
Stop the animation if we got an error message
...
Otherwise it would spin forever while we know we're not doing any work
anymore since we got a message from the server.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-19 14:33:19 +00:00
Kevin Ottens
ecc170decc
Inform _emptyShareLinkWidget of linkShareRequiresPassword signals
...
All the other ShareLinkWidgets process that signal (which allows to
display error messages for instance) but not that one for some reason.
That being said it might need to deal with an enforced password
situation.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-19 14:33:19 +00:00
Kevin Ottens
e502e71926
Emit last to avoid use after delete crash
...
It turns out the shareDeleted() signal is connected to a function
cleaning up the ShareLinkWidget holding the last shared pointer to the
Share object. Since we use member variables for calling updateFolder()
this would lead to using deleted objects.
Just swap the call and the signal to have everything back in order.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-19 14:33:19 +00:00
Nextcloud bot
3329df4caf
[tx-robot] updated from transifex
2020-10-17 03:38:33 +00:00
Nextcloud bot
801c77401c
[tx-robot] updated from transifex
2020-10-16 03:39:07 +00:00
Nextcloud bot
f6824de126
[tx-robot] updated from transifex
2020-10-15 03:37:51 +00:00
Michael Schuster
61dc4b9137
Update comments
...
Everyone uses their private mail, so ensure people can get in touch.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-15 02:18:52 +02:00
Nextcloud bot
e656d67f39
[tx-robot] updated from transifex
2020-10-14 03:41:57 +00:00
Kevin Ottens
38f4843582
Merge pull request #2534 from nextcloud/connection_wizard_improvements
...
Connection wizard improvements
2020-10-13 15:23:56 +02:00
Kevin Ottens
ca57221b74
Ensure we use the app name in the GUI
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:43 +02:00
Kevin Ottens
7efaa2ed68
Fix the secure lock label aspect
...
Make sure we got a fixed size for that label. Also ensure that the
pixmap we display there is properly scaled to fit while maintaining the
aspect ratio.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:32 +02:00
Kevin Ottens
ec945b8ac7
Hide the slideshow when going to the login page
...
This is indeed very distracting otherwise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:32 +02:00
Kevin Ottens
9ec4b5ef8e
Add a label explaining the server address field
...
This is as discussed in #1160
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:31 +02:00
Kevin Ottens
5e472e629f
Improve wording on the wizard buttons
...
This is as discussed on #1158
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:31 +02:00
Nextcloud bot
d0a9d21de8
[tx-robot] updated from transifex
2020-10-13 03:40:16 +00:00
Kevin Ottens
e980682b4d
Merge pull request #2543 from renyhp/patch-2
...
Update bookmarks location
2020-10-12 17:31:11 +02:00
renyhp
e5b307c81f
Update bookmarks location
...
Signed-off-by: renyhp <renyhp@disroot.org >
2020-10-12 15:02:00 +00:00
Kevin Ottens
3c986ead91
Merge pull request #2542 from nicolasfella/puzzel
...
Avoid string translation puzzle
2020-10-12 17:00:49 +02:00
Nicolas Fella
206c98688e
Avoid string translation puzzle
...
Combining translated strings like this makes them hard to translate since the order of words is different between languages.
Use proper placeholder strings instead.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-10-12 13:34:50 +00:00
Kevin Ottens
e787054d1c
Merge pull request #2541 from nicolasfella/work/nullptrflags
...
Don't use nullptr for QFlags
2020-10-12 15:33:38 +02:00
Nicolas Fella
6f17bbe6d5
Don't use nullptr for QFlags
...
This fixes some deprecation warnings
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-10-12 11:52:53 +00:00
Kevin Ottens
142894b2f7
Merge pull request #2221 from nicolasfella/declarative
...
Make QML code more declarative by using properties
2020-10-12 13:51:47 +02:00
Nicolas Fella
f5860928d9
Make QML code more declarative by using properties
...
By using properties and property bindings the QML code gets more declarative rather than imperative, which is considered better.
This patch:
- Introduces a currentUserId property in UserModel that replaces the equivalent Q_INVOKABLE call
- Introduces an avatar property in User that contains the avatar's image provider url without any fallback
- Introduces new image provider urls for fallback images
- Moves the fallback image selection to QML since we want different fallbacks according to where it is used
- Wires up the necessary signals to propagate a changing avatar
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-10-12 11:00:20 +00:00
Nextcloud bot
1d939121fc
[tx-robot] updated from transifex
2020-10-12 03:37:35 +00:00
Nextcloud bot
bfe9b0ba91
[tx-robot] updated from transifex
2020-10-10 03:42:03 +00:00
Nextcloud bot
3148705df6
[tx-robot] updated from transifex
2020-10-09 03:37:01 +00:00
Camila
643e43dcfb
Merge pull request #2530 from nextcloud/repair_windows_build
...
Repair the Windows build
2020-10-08 17:21:04 +02:00
Kevin Ottens
a53a87a3eb
Export the WordList functions
...
Now that they are used from gui/ they need to be properly exported so
that linking doesn't fail when visibility is activated (only on our
Windows build it seems).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 15:58:29 +02:00
Kevin Ottens
fc9ceb5af9
Merge pull request #2521 from nextcloud/use_friendly_user_agent_during_authentication
...
Use friendly user agent during authentication
2020-10-08 12:42:17 +02:00
Kevin Ottens
ab67741d87
Use setHeader instead of setRawHeader for the user agent
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Kevin Ottens
3d8af05037
Use friendly user agent during webflow2 auth
...
This way the server displays a less scary string while granting access
from the browser. Also this same string will be used in the "Devices and
sessions" section of the server settings.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Kevin Ottens
836de0358d
Add a function for a more friendly user agent string
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Kevin Ottens
50dd715f4d
Don't force user agent if one is already set on the request
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Nextcloud bot
d0ce8bc1ae
[tx-robot] updated from transifex
2020-10-08 03:37:16 +00:00
Michael Schuster
211dbadd1a
Merge pull request #2514 from nextcloud/make_it_easier_for_user_to_provide_debug_information
...
Make it easier for user to provide debug information
2020-10-07 17:12:02 +02:00
Kevin Ottens
3fca307fbb
Also add build infos in the archive
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
8ce137cc53
Also add the command line arguments in the archive
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
8fb673457b
Add a button to create a debug archive
...
This will harvest everything we might need for debugging purposes:
* config file
* sync journal dbs
* log files
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
15d294e7fb
Add dependency on QtGuiPrivate
...
I'm not a huge fan of using private APIs but QZip is really the API with
the least hassles for our debug archive need. No external dependency and
we know it is generally available and stable despite the lack of
stability promise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
607347289e
Expose more of the logger state
...
It is better to rely on the Logger state to know exactly where we're
logging. Indeed due to the the various ways to impact its state the
config alone might not now where we're logging.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
167800320f
Make sure --logfile has precedence on config
...
Since we changed the default in the config file and since log dir had
precedence on log file, the --logfile command line option wasn't doing
anything anymore.
We make sure it has an effect again overriding --logdir or the logDir
config entry.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
b0a38816fc
Change the defaults for logging
...
Turn on the logging by default for everyone. Let's use a log dir within
the config directory of the application and have debug logs expiring
after a day.
This obviously means we'll generate quite some logs but with the
automated compression it shouldn't be too horrible. Obviously that
scales with the amount of files and syncs occurring. In our tests with a
large setup we're around 100 MB for a day worth of logs, this shouldn't
be too much of an issue on today's average desktop/laptop.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Michael Schuster
f90ae66d94
Merge pull request #2520 from nextcloud/handle_askForOptionalPassword_capability
...
Handle ask for optional password capability
2020-10-07 15:30:17 +02:00
Kevin Ottens
e78312f094
If askForOptionalPassword is enabled preset a random password
...
This is the same approach used on the server side. Turns out I quite
like it, this avoids popping up a dialog to the user and since she won't
know the password she'll have to set a new one anyway or disable it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 09:43:47 +00:00
Kevin Ottens
099d25a56c
Since we must ask for a password this can't be a default public link
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 09:43:47 +00:00
Kevin Ottens
e356acbcee
Add sharePublicLinkAskOptionalPassword to Capabilities
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 09:43:47 +00:00
Nextcloud bot
d6f53d66f4
[tx-robot] updated from transifex
2020-10-07 03:36:23 +00:00
Nextcloud bot
a2a58eefde
[tx-robot] updated from transifex
2020-10-06 03:36:51 +00:00
Michael Schuster
36002701ed
Merge pull request #2512 from nextcloud/fix_updater_with_github_downloads
...
Handle redirects when downloading updates
2020-10-05 16:56:23 +02:00
Kevin Ottens
f39542688a
Handle redirects when downloading updates
...
This is necessary for downloads coming from Github for instance. They
are systematically redirected and we'd just fail the download.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-05 15:48:39 +02:00
Kevin Ottens
01152d3f37
Merge pull request #2500 from nextcloud/docs-msi
...
Windows MSI: Update Docs & add SKIPAUTOUPDATE property
2020-10-05 09:43:00 +02:00
Michael Schuster
b552c77128
Docs: Be slightly more modern and use 64-bit examples
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
ce279d0bbd
Windows MSI: Add SKIPAUTOUPDATE property for the skipUpdateCheck setting
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
c5ff288b37
Docs: Use our app name in the MSI docs
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
2476dcb425
Windows MSI: Stay compatible with the upstream "StartMenuShortcuts" feature
...
Even though we only create a program shortcut in the Start Menu, try to make administrators lives easier by not diverging feature and option naming.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
bf6980d31a
Docs: Adopt latest MSI doc enhancements from upstream master
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Dominik Schmidt
8e48d53b04
Docs: Adopt upstream commit fe04300 for MSI installation
...
See: fe043006c8
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
0e5d9a5a6b
Docs: Update macOS version info
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Nextcloud bot
d1c0481338
[tx-robot] updated from transifex
2020-10-05 03:38:36 +00:00
Nextcloud bot
06177b1a7c
[tx-robot] updated from transifex
2020-10-04 03:38:54 +00:00
Nextcloud bot
ebe7cbf0ed
[tx-robot] updated from transifex
2020-10-03 03:40:51 +00:00
Michael Schuster
a0b351b145
Merge pull request #2497 from nextcloud/fix/mac-folderwatcher-memory-leak
...
macOS: Fix memory leak in FolderWatcherPrivate::startWatching
2020-10-02 19:30:26 +02:00
Michael Schuster
bb30633d31
Fix source file access modes
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-02 16:56:29 +00:00
Michael Schuster
5979ae30e1
macOS: Fix memory leak in FolderWatcherPrivate::startWatching
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-02 16:56:29 +00:00
Nextcloud bot
4b985ab3b3
[tx-robot] updated from transifex
2020-10-02 03:32:41 +00:00
Michael Schuster
5467909389
Merge pull request #2478 from Aldaris1985/patch-1
...
Update propagateupload.cpp
2020-10-02 00:07:45 +02:00
Aldaris1985
ef6773bd60
Update propagateupload.cpp
...
Typo corrected.
2020-10-01 21:26:17 +00:00
Kevin Ottens
c1feecc727
Merge pull request #2493 from nextcloud/kesselb-patch-1
...
Delete FUNDING.yml
2020-10-01 13:03:09 +02:00
kesselb
fbeba931d2
Delete FUNDING.yml
2020-10-01 11:21:12 +02:00
Nextcloud bot
ce2dec0194
[tx-robot] updated from transifex
2020-10-01 03:40:09 +00:00
Kevin Ottens
48524fc1f4
Merge pull request #2487 from nextcloud/add-talk-icon
...
Add a clickable icon for Talk notifications.
2020-09-30 14:02:27 +02:00
Camila
954544830d
Add a clickable icon for Talk notifications.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-30 08:46:01 +00:00
Nextcloud bot
2cb919a684
[tx-robot] updated from transifex
2020-09-30 03:39:38 +00:00
Kevin Ottens
6569ecbd27
Merge pull request #2272 from snake66/issues/2219/deprecate-foreach
...
Issues/2219/deprecate foreach
2020-09-29 19:58:52 +02:00
Harald Eilertsen
7721da25e5
Replace find_if with none_of where appropriate.
...
We're not interested in any found element in these cases, just to check
that none of the elements matches.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:32:39 +02:00
Harald Eilertsen
061ef027ff
Don't hold ref to value returned from function.
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:32:24 +02:00
Harald Eilertsen
074a94ceb9
gui/accountmanager: Make isAccountIdAvailable a bit clearer.
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:24 +02:00
Harald Eilertsen
62bf4c5fda
gui/folderman: Replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:24 +02:00
Harald Eilertsen
677997b2b3
gui/folder: Replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
5bd2529ca6
gui/application: replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
e343b4b947
gui/accountstate: Replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
225fdabf6a
gui/accountstate: Replace foreach ( #2219 )
...
Most instances have been converted to range based for, but std::find_if
has been used where it made sense.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
1898782781
gui/accountmanager: Replace foreach/Q_FOREACH ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
5f4cec870b
cmd: Replace foreach with range base for ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Camila
1b1975e01d
Merge pull request #2486 from nextcloud/fix-notification
...
Connect signal guiLog to slot to display systray message.
2020-09-29 19:26:06 +02:00
Camila
dc12cdf196
Correct the object name returned by the api.
...
The id was always 0 so no new systray messages were displayed.
Signed-off-by: Camila <hello@camila.codes >
2020-09-29 18:53:28 +02:00
Camila
d2eb24a9a8
Connect signal guiLog to slot to display systray message.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-29 18:53:28 +02:00
Kevin Ottens
b9873cac63
Merge pull request #2485 from nextcloud/Valdnet-patch-1
...
l10n: Remove space from string text
2020-09-29 14:43:39 +02:00
Valdnet
d50ad548d2
l10n: Remove space from string text
2020-09-29 14:39:34 +02:00
Nextcloud bot
68ba07a45a
[tx-robot] updated from transifex
2020-09-29 03:41:15 +00:00
Kevin Ottens
10b23200ab
Merge pull request #2317 from nextcloud/tray-accessibility
...
Tray accessibility
2020-09-28 16:48:26 +02:00
Dominique Fuchs
b96b7e20c7
emitting signals from Qts Accessibility interaction invocations instead of duplicating actions
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
1053c58b0f
KISS. Removed description for now, instead clarified some Accessible.name
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
8abe4219a5
Added missing qsTr() calls - again
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
a69898371f
Added missing qsTr() calls
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
a4151d71bc
Fix typo
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
3287ec2387
Typo fixes, minor additions
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
c6047e4d63
Re-add wrongly delete action
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
43bf703806
Initial accessibility declarations for tray window qml src
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Camila
a7a079a335
Merge pull request #2477 from nextcloud/free_icon_job
...
Free IconJob after use
2020-09-28 13:02:41 +02:00
Dan Griffin
5763e1e9d8
Free IconJob after use
...
Signed-off-by: Dan Griffin <github.mk@xiragon.com >
2020-09-28 12:30:53 +02:00
Nextcloud bot
836638815f
[tx-robot] updated from transifex
2020-09-28 03:37:52 +00:00
Nextcloud bot
eefa46a8e7
[tx-robot] updated from transifex
2020-09-27 03:37:06 +00:00
Nextcloud bot
d58af951f3
[tx-robot] updated from transifex
2020-09-26 03:38:03 +00:00
Nextcloud bot
78a3e45456
[tx-robot] updated from transifex
2020-09-25 03:41:46 +00:00
Kevin Ottens
7b1ba31c13
Merge pull request #2470 from nextcloud/fix_qt_5_12_tooltip_wrap
...
Force tooltip wrap mode because it's not enabled in Qt 5.12...
2020-09-24 14:49:44 +02:00
Kevin Ottens
78b03739a7
Force tooltip wrap mode because it's not enabled in Qt 5.12...
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-24 14:47:56 +02:00
Nextcloud bot
16b709edbc
[tx-robot] updated from transifex
2020-09-24 03:38:39 +00:00
Kevin Ottens
a2899eba74
Merge pull request #2409 from jplsek/native-text-render
...
Use native text rendering for qml windows
2020-09-23 13:15:00 +02:00
Jeremy Plsek
5fa2a13f8d
Use native text rendering for qml windows
...
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com >
2020-09-23 08:00:46 +00:00
Kevin Ottens
dde4dd78fb
Merge pull request #2441 from nextcloud/enh/server-url
...
Allow server URL to be pre-defined without enforcing it
2020-09-23 09:59:31 +02:00
Michael Schuster
ce71ffe9f9
Allow server URL to be pre-defined without enforcing it to be used unmodified
...
APPLICATION_SERVER_URL can be either empty or be specified. This commit adds the new CMake option APPLICATION_SERVER_URL_ENFORCE to decide whether to enforce the
URL's unmodified use (like before, default: ON) or to allow modification by the user (new).
By default APPLICATION_SERVER_URL_ENFORCE is set to ON, to no break with the previous implementation's expectations.
If APPLICATION_SERVER_URL is empty, APPLICATION_SERVER_URL_ENFORCE will be ignored by the Account Wizard.
The previous behaviour confused me a bit with branded builds. When the URL was (usually) specified but not forced, it was simply discarded, forcing the user to
manually supply it.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-23 07:21:35 +00:00
Nextcloud bot
122493eeeb
[tx-robot] updated from transifex
2020-09-23 03:37:35 +00:00
Nextcloud bot
3ca6f4b0f2
[tx-robot] updated from transifex
2020-09-22 03:37:33 +00:00
Michael Schuster
b72bfb5c65
Merge pull request #2369 from nextcloud/enh/windows-msi
...
Windows: MSI support & Win32 migration tools
2020-09-21 17:35:37 +02:00
Michael Schuster
e024aa3f16
Windows: Win32 migration tools code review
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
a9014f9852
Windows MSI: Add MSI scripts and UI resources
...
Uses CMake to generate and install all required files in the "msi/" directory.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
f321cd8ae6
Windows: Add Win32 stand-alone migration tool NCNavRemove
...
Removes all Explorer Navigation Pane entries for a given ApplicationName, specified in NavRemove.ini in the working directory.
Also compiles a DLL with the same behaviour that exports:
- RemoveNavigationPaneEntries
Both tool variants are Mutex-protected.
Statically linked, optimized for binary size, no Qt dependencies.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
68776fe319
Windows MSI: Add helper DLL and shared migration tools code
...
The helper DLL will be utilized by Windows Installer with Custom Actions defined in the NCMsiHelper.wxs WiX fragment.
Exports:
- ExecNsisUninstaller
- RemoveNavigationPaneEntries
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
fc365df5de
Windows MSI: Let CMake install Shell Extensions WiX fragment to "msi/"
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
fad9b2c969
Windows MSI: Add Upgrade Code and migration tool build options to NEXTCLOUD.cmake
...
The Upgrade Code is a GUID (specified without brackets) for the MSI package to allow Windows Installer identify existing installations.
New build options (default: OFF):
- BUILD_WIN_MSI: Build all MSI scripts and a required helper DLL (to uninstall NSIS legacy installations and remove Explorer Navigation Pane entries)
- BUILD_WIN_TOOLS: Build additional migration tools (currently NCNavRemove, a stand-alone tool for Explorer entries removal)
The helper DLL and migration tools are set to be statically linked and optimized for binary size.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Kevin Ottens
58b88de936
Merge pull request #2431 from jplsek/remove-this-includes
...
Remove "This includes" due to tooltip order
2020-09-21 15:40:37 +02:00
Jeremy Plsek
3a53afd704
Remove "This includes" due to tooltip order
...
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com >
2020-09-21 09:46:25 +00:00
Nextcloud bot
c127052f2d
[tx-robot] updated from transifex
2020-09-21 03:32:07 +00:00
Nextcloud bot
ed972a0e3f
[tx-robot] updated from transifex
2020-09-20 03:31:45 +00:00
Nextcloud bot
5d7e1b6a69
[tx-robot] updated from transifex
2020-09-19 03:34:11 +00:00
Michael Schuster
0f2784107c
Merge pull request #2437 from nextcloud/remove_no_description_available_messages_in_activity_list
...
If there's no description just say nothing
2020-09-18 20:41:34 +02:00
Kevin Ottens
3171cb2720
If there's no description just say nothing
...
Otherwise we get lots of "No description available" lines in the
activity list which is basically noise. Also trains the user to ignore
the secondary line.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-18 17:46:38 +00:00
Michael Schuster
f451e1d2d5
Merge pull request #2445 from nextcloud/fix-mac-catalina-login
...
Entitlement to sign the QtWebEngineProcess with an exception.
2020-09-18 06:44:11 +02:00
Camila San
9c5a51bb07
Entitlement to sign the QtWebEngineProcess with an exception.
...
Fix for #1793 : The problem seems to be related enabling hardened runtime.
This exception allows the webview to load.
Signed-off-by: Camila San <hello@camila.codes >
2020-09-18 04:35:06 +00:00
Nextcloud bot
091c805f9e
[tx-robot] updated from transifex
2020-09-18 03:30:59 +00:00
Dominique Fuchs
54364e7374
Merge pull request #2439 from nextcloud/fix-subfolder-missing-contentsync
...
Fix missing subdirectory discovery on move operations in macOS
2020-09-17 16:04:12 +02:00
Dominique Fuchs
f8f3190cb4
Fix missing subdirectory discovery on move operations in macOS.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Add qAsConst to avoid detaching
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Changed callchain to find and return possibly coalesced paths
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Removed another qAsConst remnant, more func const-correctness.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-17 15:44:32 +02:00
Nextcloud bot
ed3eb1ac9c
[tx-robot] updated from transifex
2020-09-17 04:13:19 +00:00
Kevin Ottens
61a74e67c9
Merge pull request #2435 from nextcloud/fix-journal-upgrade-multiple-syncconnections
...
Fix incomplete journal upgrade from 2.x to 3.x
2020-09-16 13:21:42 +02:00
Dominique Fuchs
d09b0284dd
Do not break out of outer loop when upgrading folders, continue instead
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Remove awkward debug line a.k.a. whoops
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-16 10:57:43 +02:00
Kevin Ottens
5eba2e9163
Merge pull request #2432 from nextcloud/fix/nsis-language-encoding
...
Windows: Fix NSIS language encoding (use UTF-8)
2020-09-16 09:13:26 +02:00
Michael Schuster
0e1e3a29ce
Windows: Remove unused and outdated NSIS Transifex settings
...
The last translation update from Transifex was done in 2017, so the scripts and settings were never used for Nextcloud.
This commit removes the unused scripts and "Auto-generated" comments in the translation files.
Some files have been modified over time either way and MSI will replace NSIS soon.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-16 05:41:27 +00:00
Michael Schuster
7f5b7f637c
Windows: Fix NSIS language encoding (use UTF-8 instead of Win code pages)
...
The old conversion to specific code pages caused display errors (see issue #2393 for Russian).
Based on bin/l10n.sh, the files in this commit were converted to UTF-8 using iconv with the following parameters:
iconv -f CP1252 -t UTF-8 -o German.nsh German.nsh
iconv -f CP1252 -t UTF-8 -o Galician.nsh Galician.nsh
iconv -f CP1253 -t UTF-8 -o Greek.nsh Greek.nsh
iconv -f CP1250 -t UTF-8 -o Slovenian.nsh Slovenian.nsh
iconv -f CP1257 -t UTF-8 -o Estonian.nsh Estonian.nsh
iconv -f CP1252 -t UTF-8 -o Italian.nsh Italian.nsh
iconv -f CP1252 -t UTF-8 -o PortugueseBR.nsh PortugueseBR.nsh
iconv -f CP1252 -t UTF-8 -o Spanish.nsh Spanish.nsh
iconv -f CP1252 -t UTF-8 -o Dutch.nsh Dutch.nsh
iconv -f CP1252 -t UTF-8 -o Finnish.nsh Finnish.nsh
iconv -f CP932 -t UTF-8 -o Japanese.nsh Japanese.nsh
iconv -f CP1250 -t UTF-8 -o Slovak.nsh Slovak.nsh
iconv -f CP1254 -t UTF-8 -o Turkish.nsh Turkish.nsh
iconv -f CP1252 -t UTF-8 -o Norwegian.nsh Norwegian.nsh
iconv -f CP852 -t UTF-8 -o Czech.nsh Czech.nsh
The installer script nextcloud.nsi in the client-building repo needs the following line (to be added on top):
Unicode true
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-16 05:41:27 +00:00
Nextcloud bot
dbe8422c5d
[tx-robot] updated from transifex
2020-09-16 03:27:56 +00:00
Kevin Ottens
9d05bc0a8b
Merge pull request #2424 from nextcloud/enable_ci_for_stable_branches
...
Try to enable the CI on stable branches as well
2020-09-15 15:24:58 +02:00
Kevin Ottens
f3c2632f8c
Try to enable the CI on stable branches as well
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 12:46:36 +00:00
Kevin Ottens
16dda17334
Merge pull request #2423 from nextcloud/disable_bugprone_forward_declaration_namespace_clang_tidy_check
...
Disable bugprone-forward-declaration-namespace check
2020-09-15 14:45:29 +02:00
Kevin Ottens
63c3580755
Disable bugprone-forward-declaration-namespace check
...
Turns out this clang-tidy check can give false positives coming from
headers outside the project while it shouldn't.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 12:04:32 +00:00
Kevin Ottens
8aaa533a3e
Merge pull request #2412 from jplsek/tooltip-update
...
Include list info in tooltip
2020-09-15 13:50:39 +02:00
Jeremy Plsek
797df2b5d5
Include list info in tooltip
...
Also extend the tooltip timeout
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com >
2020-09-15 10:04:06 +00:00
Kevin Ottens
14993d4de6
Merge pull request #2417 from nextcloud/fix_menu_popup_in_main_dialog
...
Fix menu popup in main dialog
2020-09-15 11:03:07 +02:00
Kevin Ottens
6ee37b5975
Make sure menu are closed when button is clicked again
...
This way we also made sure all the Menu are currently on the same close
policy.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 08:46:10 +00:00
Kevin Ottens
f7efe6a902
Delay binding on the menu width
...
Indee the MenuItem might not be linked to its Menu at creation time
which will make the binding fail and give a warning. Delay for the menu
availability.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 08:46:10 +00:00
Kevin Ottens
eb0cedebfa
Remove pre-QQC2.3 workaround
...
Now that we depend on Qt 5.12 anyway, the count property is available
just fine on the Menu item.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 08:46:09 +00:00
Kevin Ottens
4f5d707e44
Merge pull request #2418 from nextcloud/use_primary_screen_as_fallback_when_qcursor_pos_search_failed
...
Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
2020-09-15 10:44:54 +02:00
Kevin Ottens
7ccb016397
Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
...
Under Wayland QCursor::pos() is unlikely to give us anything meaningful,
so fallback to the primary screen information.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 07:17:03 +00:00
Nextcloud bot
54b09a1fbb
[tx-robot] updated from transifex
2020-09-15 03:22:14 +00:00
Nextcloud bot
9d3a905cc5
[tx-robot] updated from transifex
2020-09-12 03:19:44 +00:00
Nextcloud bot
88a573a643
[tx-robot] updated from transifex
2020-09-11 03:20:37 +00:00
Kevin Ottens
01986df8ca
Don't use a confusing "royal you" in the sync messages
...
Users get rightfully confused with the "You changed ..." messages in the
activity list for syncs. Indeed, some of those changes might be coming
from the server in which case we don't really know who did the change.
So now we use the old "Synced ..." messages for changes pulled from the
server and we have a more precise "You changed ..." (renamed, deleted,
created) when the changes were initiated locally (since there we know
the user reading the message did it).
Also changed how the messages are constructed so that they can be
properly translated.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-10 15:40:05 +02:00
Nextcloud bot
9ab256b4b4
[tx-robot] updated from transifex
2020-09-10 03:25:52 +00:00
Camila
95f634ce28
Click on activity list in systray open file in the file manager.
...
Clean up code, add more const and auto.
Signed-off-by: Camila <hello@camila.codes >
2020-09-09 20:06:46 +02:00
Camila
c1086c9886
Fix tooltip for activity info.
...
Also improves readability of the items in the list.
Signed-off-by: Camila <hello@camila.codes >
2020-09-09 20:06:46 +02:00
Valdnet
a432501d80
l10n: Add a period
2020-09-09 10:07:10 +02:00
Nextcloud bot
301a926f4d
[tx-robot] updated from transifex
2020-09-09 03:19:56 +00:00
Valdnet
9822079cae
l10n: Extract the button name
2020-09-08 16:44:51 +02:00
Valdnet
528fa92e86
l10n: Delete unnecessary sentence
2020-09-08 16:44:51 +02:00
Valdnet
1444500f77
l10n: A few more fixes
2020-09-08 16:44:51 +02:00
Valdnet
e2737b5067
l10n: Word correction
2020-09-08 16:44:51 +02:00
Valdnet
f931bc832c
l10n: Corrected translation
2020-09-08 16:44:51 +02:00
Kevin Ottens
fdb35e5f9f
Leave the implicit uint to int cast
...
I wrongly (and stupidly) assumed the int in QBitArray was treated as a
hash as well but it is an index so it must be positive. Also to make
things even worse I misread on which expression clang-tidy was
complaining regarding the implementation specific narrowing
conversion... This is happening after the modulo operator and not
before. We're in a safe range of values at that point, so it's fine to
let the narrowing happen.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-08 16:44:31 +02:00
Kevin Ottens
de3ba2721b
Merge pull request #2387 from nextcloud/update-troubleshooting
...
Update troubleshooting
2020-09-08 15:46:55 +02:00
Camila
0f03e3091d
Add README with instructions on how to build the documentation.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-08 13:44:26 +00:00
Camila
fecc62b7e1
Update troubleshooting instructions with the newly added config file options.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-08 13:44:26 +00:00
Nextcloud bot
5adb720630
[tx-robot] updated from transifex
2020-09-08 03:19:49 +00:00
Nextcloud bot
a61dd7cf46
[tx-robot] updated from transifex
2020-09-06 03:28:59 +00:00
Nextcloud bot
2db125dca0
[tx-robot] updated from transifex
2020-09-05 03:29:13 +00:00
Nextcloud bot
6c69ac6602
[tx-robot] updated from transifex
2020-09-04 03:29:47 +00:00
Kevin Ottens
a4cb7e3040
Merge pull request #2357 from thaytan/metadata-index-e2eMangledName
...
syncjournaldb: index e2eMangledName column in metadata
2020-09-03 16:20:48 +02:00
Jan Schmidt
3077a1378b
syncjournaldb: index e2eMangledName column in metadata
...
Add an index on the e2eMangledName column in the metadata table
to speed up file sync by orders of magnitude on directories with
a large number of files.
Signed-off-by: Jan Schmidt <jan@centricular.com >
2020-09-03 22:56:14 +10:00
Nextcloud bot
fd29a0ae57
[tx-robot] updated from transifex
2020-09-03 03:29:13 +00:00
Kevin Ottens
18b16a3ede
Merge pull request #2351 from nextcloud/fix_clang_tidy_errors_in_csync_tests
...
Fix clang tidy errors in csync tests
2020-09-02 08:25:24 +02:00
Kevin Ottens
ee92e5af9a
Switch to newer CI image to build csync tests
...
This new image brings the cmocka dependency and thus will make the CI
build the csync tests which depend on it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
2916144fe3
Fix bugprone-narrowing-conversion errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
c7c37f9bef
Fix modernize-use-nullptr errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
9a0713fab7
Fix modernize-use-auto errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
f323f8b4bc
Fix modernize-deprecated-headers errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:45 +00:00
Nextcloud bot
9ec4e772eb
[tx-robot] updated from transifex
2020-09-02 03:31:47 +00:00
Kevin Ottens
b6591be973
Merge pull request #2283 from nextcloud/enable_bugprone_clang_tidy_checks
...
Enable bugprone clang tidy checks
2020-09-01 08:47:41 +02:00
Kevin Ottens
310693be2c
Enable all the other bugprone clang-tidy checks
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
aa63889e5b
Enable bugprone-terminating-continue clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
0909f00a8b
Enable bugprone-too-small-loop-variable clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
80cc196f6f
Enable bugprone-narrowing-conversions clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
5cec1373ad
Enable bugprone-macro-parentheses clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
608bf025e6
Enable bugprone-forward-declaration-namespace clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
c8ea848596
Enable the bugprone-branch-clone clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
4cb9bec23a
Enable the bugprone-argument-comment clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Nextcloud bot
4e61181b45
[tx-robot] updated from transifex
2020-09-01 03:26:29 +00:00
Kevin Ottens
4ee80bfe2e
Merge pull request #2345 from nextcloud/use_httpd_unix-directory_mimetype_for_e2ee_folders
...
Use httpd/unix-directory mimetype for E2EE folders
2020-08-31 13:11:51 +02:00
Kevin Ottens
eb76682b1e
Use httpd/unix-directory mimetype for E2EE folders
...
We don't do much with that mimetype on our end, but other clients
somehow don't expect inode/directory to let's lie. ;-)
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-31 10:08:48 +00:00
Kevin Ottens
1a0945a973
Enable all the misc clang-tidy check except one
...
This flagged mostly unused parameters. Didn't enable the
misc-non-private-member-variables-in-classes check as we got a lot of
those. Hopefully we'll get to fix them at some point but that feels too
early and too much work for now.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-31 09:14:09 +02:00
Nextcloud bot
7236af78af
[tx-robot] updated from transifex
2020-08-31 03:25:49 +00:00
Nextcloud bot
b01299349b
[tx-robot] updated from transifex
2020-08-30 03:24:23 +00:00
Nextcloud bot
78fa448c7e
[tx-robot] updated from transifex
2020-08-29 03:26:40 +00:00
Michael Schuster
75aa94be79
Merge pull request #2336 from nextcloud/jospoortvliet-patch-1
...
Some changes to the template...
2020-08-29 00:14:16 +02:00
Jos Poortvliet
01a722821a
Some changes to the template...
2020-08-28 21:54:10 +02:00
Nextcloud bot
e45be65996
[tx-robot] updated from transifex
2020-08-28 03:26:44 +00:00
Nextcloud bot
1f536a7e1b
[tx-robot] updated from transifex
2020-08-27 03:29:43 +00:00
Michael Schuster
5945f18d5a
Remove remaining QLinkedList includes in addition to #2300
...
Now the only remaining reference is in:
src/3rdparty/libcrashreporter-qt/3rdparty/drkonqi-parser/backtraceparser.cpp:269: || line.functionName().startsWith(QLatin1String("QLinkedList")
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-27 03:12:09 +02:00
Michael Schuster
bd519ffe7a
Adapt code style in addition to #2300
...
- Use "!empty()" instead of "size() > 0" in std::list
- Add comments for namespace brackets
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-27 01:31:06 +02:00
Michael Schuster
e973c43a7a
Merge pull request #2300 from chenecharry/master
...
Support client builds on VS2019 (QLinkedList is deprecated)
2020-08-27 01:27:09 +02:00
Michael Schuster
24a2b21c2c
Merge branch 'master' into master
2020-08-27 01:12:30 +02:00
Nextcloud bot
07bde18c3a
[tx-robot] updated from transifex
2020-08-26 03:29:53 +00:00
V.C
b20ea25201
Code review changes implemented
...
Code review changes implemented for bandwidthmanager.cpp
1. Use auto instead of size_t
2. Check for empty instead of size comparisions
Signed-off-by: V.C <c******@rediffmail.com >
2020-08-26 02:45:20 +00:00
V.C
af1bb7e98c
Support client builds on VS2019
...
Scenario: Build fails on Qt 5.15.0 + VS2019 16.7.2
Root cause: QLinkedList seems to be depreciated. Advise to use std::list instead.
Fix: Used std::list insead of QLinkedList.
Signed-off-by: V.C <c******@rediffmail.com >
2020-08-26 02:45:20 +00:00
Michael Schuster
c1cb3e6c49
Merge pull request #2309 from nextcloud/update-docs-page-title
...
Update copyright date and version displayed in the page title.
2020-08-25 21:07:18 +02:00
Camila
cbea02390e
Update copyright date and version displayed in the page title.
...
- This is the title displayed at https://docs.nextcloud.com/desktop/x.y
Signed-off-by: Camila <hello@camila.codes >
2020-08-25 18:50:14 +00:00
Michael Schuster
c4b87cd465
Merge pull request #2313 from nextcloud/update-issue-template
...
Add --logdebug parameter to instructions in issue_template for Github.
2020-08-25 20:48:59 +02:00
Camila
c746e65a8e
Update issue_template with information about logs, e2ee versions and code of conduct.
...
Signed-off-by: Camila <hello@camila.codes >
2020-08-25 15:11:34 +00:00
Camila
6c36041829
Add --logdebug parameter to instructions in issue_template for Github.
...
Signed-off-by: Camila <hello@camila.codes >
2020-08-25 15:11:34 +00:00
Nextcloud bot
c687fb0291
[tx-robot] updated from transifex
2020-08-25 03:32:20 +00:00
Nextcloud bot
d4183aebb3
[tx-robot] updated from transifex
2020-08-24 03:31:03 +00:00
Nextcloud bot
7af6e18491
[tx-robot] updated from transifex
2020-08-22 03:28:48 +00:00
Michael Schuster
5b8ec5cede
Merge pull request #2302 from ivaradi/no-eoan
...
Do not build for Eoan
2020-08-22 00:55:31 +02:00
István Váradi
cd303e313d
Do not build for Eoan
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-08-21 18:54:56 +02:00
Nextcloud bot
32880507b2
[tx-robot] updated from transifex
2020-08-21 03:30:20 +00:00
Michael Schuster
b60239c29e
Merge pull request #2288 from nextcloud/enh/windows-shellext
...
Windows shell extensions: Use custom GUIDs and prepare for MSI
2020-08-20 21:11:34 +02:00
Michael Schuster
4df8db4ff6
Fix spacing
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
db05f65e0d
Windows shell extensions: Add WiX (MSI) fragment
...
Use CMake to generate a WXI fragment to handle the DLL registration and file deployment for the shellext components.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
11632da7ea
Windows shell extensions: Change NCUtil Pipe name from ownCloud to APPLICATION_EXECUTABLE
...
Avoid interference with foreign pipes as this is always a bad idea ;p
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
0ba5df597f
Windows shell extensions: Rename all files and classes from OC* to NC*, update version info
...
This also ensures a clear separation in the system registry.
SelfReg is not recommended by Microsoft and will be handled by the MSI package to allow proper Repair and Uninstall.
However, we keep it for backward compatibility with the NSIS installer.
For details see:
https://stackoverflow.com/questions/364187/how-do-you-register-a-win32-com-dll-file-in-wix-3#364210
https://docs.microsoft.com/en-us/windows/win32/msi/selfreg-table#remarks
Another fix by this commit:
The "Version" registry value in the NCOverlays self reg should be a key and not a value.
Details: https://wixtoolset.org/documentation/manual/v3/xsd/wix/class.html
Example:
[HKCR\CLSID\{01234567-89AB-CDEF-0123-456789ABCDEF}\Version]
@="1.0.0.0"
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
8ce13b7bdb
Windows shell extensions: Use custom GUIDs via CMake and prepare MSI reg
...
Previously side by side installation with ownCloud or other NC custom builds would break the shell integration because the same GUIDs and registry keys were used.
Now we specify our custom GUIDs in NEXTCLOUD.cmake and use CMake to generate a header file and WiX (MSI) include file with these constants.
Note: Using generators like "guidgen" or "uuidgen" ensures that GUIDs are unique, as manual changes are not guaranteed to be.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
4675869fb3
Remove dead code
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
bfd7707ff4
2.7 has less automatic includes on Windows
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
34e9e2f288
Cleanup Windows shell extensions
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
6c9a31f6ee
Remove outdated visual studio projects, we now use cmake
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Dominik Schmidt
13d4b91935
Avoid warning because /MT overrides /MD flag
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Dominik Schmidt
e4b53b12e1
Make OCUtil helper lib static and link it statically against crt
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Olivier Goffart
906556640d
Windows Shell Integration: Don't limit the size of the buffer
...
Otherwise we can't have operation that has many many filename
As reported in #6780
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Christian Kamm
77cc262337
Windows shellext: Update copyrights and company name
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Olivier Goffart
6274462036
windows shell extension: add OCUtil/resource.h
...
It's a copy from OCContextMenu/resources.h
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Christian Kamm
c6fc46aa09
Windows shellext: Add rc for OCUtil #6554
...
To set the dll's metadata.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Kevin Ottens
d446431804
Merge pull request #2292 from nextcloud/prevent_sharing_for_e2ee_folders
...
Disable context menu actions for E2EE files and folders
2020-08-20 18:36:37 +02:00
Kevin Ottens
ed5e9de9f6
Present sharing of E2EE files from the main dialog too
...
The visibility of the share button for the activity list is tied to the
path role in the ActivityListModel, so make sure we don't return a path
for E2EE files and folders.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-20 14:53:14 +02:00
Kevin Ottens
07388e0f22
Disable context menu actions for E2EE files and folders
...
Those files and folders are not shareable and the "Edit" or "Open in
browser" actions will lead to showing an error in the web GUI. No need
to lead users there so just disable them.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-20 14:13:56 +02:00
Nextcloud bot
b67c61bf4a
[tx-robot] updated from transifex
2020-08-20 03:32:34 +00:00
Nextcloud bot
d6cc9fe829
[tx-robot] updated from transifex
2020-08-19 03:32:55 +00:00
Kevin Ottens
3540f1e460
Show the "Display mnemonic" button only when we know e2e is supported
...
Turns out that showing the button straight from the page ctor is a bit
too early. At that point the account might not be connected yet and thus
we wouldn't have proper information. Currently we were displaying that
button all the time, now we wait for the account to be connected to
decide to show it or not.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-18 17:41:38 +02:00
Camila
71fbc65eb0
Minor fix in text of warning and debug message.
...
Signed-off-by: Camila <hello@camila.codes >
2020-08-18 14:00:21 +02:00
Kevin Ottens
f6e36523d2
Make sure we don't assert when calling fileStatus
...
It happens that sometimes we leak a directory path ending with a slash,
but that violates fileStatus' precondition so let's catch it early and
skip such path.
Of course the right fix would be a larger swipe in the sync engine and
around it to not use naked strings anymore but rely on the typesystem.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-18 13:52:28 +02:00
Nextcloud bot
2456f943af
[tx-robot] updated from transifex
2020-08-18 03:34:45 +00:00
Nextcloud bot
c8b6bc6029
[tx-robot] updated from transifex
2020-08-17 03:28:12 +00:00
Nextcloud bot
60ce985828
[tx-robot] updated from transifex
2020-08-16 03:28:22 +00:00
István Váradi
770e3e7b85
Merge pull request #2271 from ivaradi/cstdint-fix
...
Include cstdint only when compiling C++ code
2020-08-15 14:35:01 +02:00
István Váradi
387df7ae71
Merge branch 'master' into cstdint-fix
2020-08-15 12:56:13 +02:00
Nextcloud bot
2e69680812
[tx-robot] updated from transifex
2020-08-15 03:29:02 +00:00
István Váradi
89d4b6e12a
Include cstdint only when compiling C++ code
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-08-14 06:15:42 +02:00
Nextcloud bot
74c1710ed4
[tx-robot] updated from transifex
2020-08-14 03:44:39 +00:00
Kevin Ottens
4117ac2913
Merge pull request #2268 from nextcloud/cherry_pick_testchunkingng_related_improvements
...
Cherry pick TestChunkingNG related improvements
2020-08-13 17:26:33 +02:00
Kevin Ottens
ef6d2600ca
Size cleanups in TestChunkingNG
...
Some of the comments didn't match the size or were missing. This also
means reducing one of the 150 MB payloads left behind reducing the
execution time by a few more seconds. This is now around 30s execution
time which is more acceptable.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 16:46:14 +02:00
Olivier Goffart
a7847a4e82
Upload: Store the size in the UploadInfo, and compare it when resolving potential conflict
...
This is about the conflicts that happens when the file has been uploaded
correctly to the server, but the etag was not recieved because the connection
was closed before we got the reply.
We used to compare only the mtime when comparing the uploaded file and the
existing file. However, to be perfectly correct, we also should check the
size.
This was found because TestChunkingNG::connectionDroppedBeforeEtagRecieved is
flaky. Example of faillure found in https://drone.owncloud.com/owncloud/client/481/5
while testing PR #6626
(very trimmed log:)
06-29 07:58:02:015 [ info sync.csync.csync ]: ## Starting local discovery ##
06-29 07:58:02:016 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: <-> 1644a8c8750, inode: 1935629 <-> 1935629, size: 301 <-> 300, perms: 0 <-> ff, type: 0 <-> 0, checksum: <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:016 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:972 [ warning sync.networkjob ]: QNetworkReply::NetworkError(OperationCanceledError) "Connection timed out" QVariant(Invalid)
.. next sync...
06-29 07:58:02:980 [ info sync.engine ]: #### Discovery start ####################################################
06-29 07:58:02:981 [ info sync.csync.csync ]: ## Starting local discovery ##
06-29 07:58:02:983 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: <-> 1644a8c8750, inode: 1935629 <-> 1935629, size: 302 <-> 300, perms: 0 <-> ff, type: 0 <-> 0, checksum: <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:983 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:985 [ info sync.csync.csync ]: ## Starting remote discovery ##
06-29 07:58:02:985 [ info sync.networkjob ]: OCC::LsColJob created for "http://localhost/owncloud " + "" "OCC::DiscoverySingleDirectoryJob"
06-29 07:58:02:987 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: 1644a8c8b26 <-> 1644a8c8750, inode: 0 <-> 1935629, size: 301 <-> 300, perms: ff <-> ff, type: 0 <-> 0, checksum: SHA1:5adcdac9608ae0811247f07f4cf1ab0a2ef99154 <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:987 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:989 [ info sync.csync.csync ]: Update detection for remote replica took 0.004 seconds walking 13 files
06-29 07:58:02:990 [ info sync.engine ]: #### Discovery end #################################################### 9 ms
06-29 07:58:02:990 [ info sync.database ]: Updating file record for path: "A/a0" inode: 1935629 modtime: 1530259082 type: 0 etag: "1644a8c8b26" fileId: "16383ea4" remotePerm: "WDNVCKR" fileSize: 301 checksum: "SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1"
06-29 07:58:02:990 [ info sync.csync.reconciler ]: INSTRUCTION_UPDATE_METADATA client file: A/a0
06-29 07:58:02:990 [ info sync.csync.csync ]: Reconciliation for local replica took 0 seconds visiting 13 files.
06-29 07:58:02:990 [ info sync.csync.reconciler ]: INSTRUCTION_UPDATE_METADATA server dir: A
06-29 07:58:02:990 [ info sync.csync.csync ]: Reconciliation for remote replica took 0 seconds visiting 13 files.
06-29 07:58:02:990 [ info sync.engine ]: #### Reconcile end #################################################### 9 ms
06-29 07:58:02:990 [ info sync.database ]: Updating local metadata for: "A/a0" 1530259082 302 1935629
FAIL! : TestChunkingNG::connectionDroppedBeforeEtagRecieved(small file) '!fakeFolder.syncOnce()' returned FALSE. ()
2020-08-13 16:46:08 +02:00
Olivier Goffart
c2324327ef
TestChunkingNG: Make it faster
...
Use smaller files so the test run faster.
Particulary usefull for TestChunkingNG::connectionDroppedBeforeEtagRecieved
Which had become so much slower after 2638332dc6
increased the timeout for bigger files
2020-08-13 16:46:03 +02:00
Christian Kamm
c74c0d8e6e
Upload: Add more chunk resuming unit tests #6405
2020-08-13 16:45:55 +02:00
Kevin Ottens
2684ba149e
Merge pull request #2269 from nextcloud/enable_modernize_loop_convert
...
Enable the modernize-loop-convert check on clang-tidy
2020-08-13 16:37:41 +02:00
Kevin Ottens
866ffc2a6b
Enable the modernize-loop-convert check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 12:55:14 +00:00
Kevin Ottens
a5b4922a0e
Remove unused method
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 12:55:14 +00:00
Kevin Ottens
0e2af4b502
Enable the modernize-deprecated-headers check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 14:53:52 +02:00
Kevin Ottens
2f8c29082a
Enable the modernize-use-equals-default check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 14:19:42 +02:00
Nextcloud bot
2d4d66b998
[tx-robot] updated from transifex
2020-08-13 03:30:50 +00:00
Kevin Ottens
cdf6e7d72b
Enable the modernize-user-nullptr check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 19:45:25 +02:00
Kevin Ottens
3ff899cff9
Merge pull request #2264 from nextcloud/enable_modernize_use_using
...
Enable the modernize-use-using check on clang-tidy
2020-08-12 19:29:17 +02:00
Kevin Ottens
6ae1d0ddf6
Get rid of useless using constructs
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 18:18:57 +02:00
Kevin Ottens
97af14a4f0
Make QTokenizer use simpler by having optional second parameter
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 18:18:57 +02:00
Kevin Ottens
d58ec4bf70
Enable the modernize-use-using check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 18:18:57 +02:00
Kevin Ottens
7bb54e34d7
Merge pull request #2262 from nextcloud/enable_trivial_clang_tidy_modernize_checks
...
Enable "trivial" modernize clang-tidy checks
2020-08-12 17:16:38 +02:00
Kevin Ottens
07b7753216
Enable "trivial" modernize clang-tidy checks
...
This is a bunch of modernize checks which we don't hit at all. This is
an easy win and also make sure those old constructs won't creep up
behind our back.
Note that some of them won't trigger until we bump our C++ baseline
standard to C++17. But I'd say that's OK, that'll force our hand to do
those C++17 related cleanups when the time comes.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 13:13:08 +00:00
Kevin Ottens
1767c0295f
Merge pull request #2037 from nextcloud/enable_modernize_raw_string_literal
...
Enable modernize raw string literal
2020-08-12 15:02:55 +02:00
Kevin Ottens
3e79e1861b
We don't really need two \ here
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 09:48:33 +02:00
Kevin Ottens
c50a968a1e
Add more raw string literals missed previously
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 09:48:29 +02:00
Kevin Ottens
ed1c2eaab4
Merge pull request #2247 from nextcloud/improve_drone_config
...
Improve drone config
2020-08-12 09:45:26 +02:00
Kevin Ottens
14bfa5025f
Make sure wget looks for the certificates at the right place
...
Might happen because we got too many copies of OpenSSL around
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
571e15c6eb
Switch to Ninja for the clang build
...
Clang is generally slower to compile than GCC so use a faster Make for
that build variant. This also allows us to verify our CMake files don't
do anything Make specific.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
5116f4d255
Parallelize the clang-tidy runs
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
db5c186202
Split cmake and compile into separate pipeline steps
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
725f1e742d
Switch to actual commands inside of the steps
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
6da67ef653
Split the CI pipelines into proper steps
...
Will make it easier to navigate the logs
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
65407483e5
Now make sure we're not picking up generated headers
...
This could happen (and started to happen more with clang-tidy 10) that
clang-tidy picked up errors in headers from the build directory. Now
that we moved the build directory out of source, we can simply filter
headers based on the pwd.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
1e8340cd48
Move the build in a volume to be reused between steps
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
9016ffe4b7
Remove unneeded environment variables
...
Those are set by the base CI image anyway, no need to do the work again.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
be6a9dab01
Switch to the newer base CI image
...
We can now spare building QtKeychain over and over shortening a bit the
build. We also update to latest gcc and clang.
Note that I didn't switch the AppImage pipeline to the newer image to
keep the binary compatibility promise required by linuxdeployqt.
Probably would make sense to do a specific image for AppImage with some
other of the cleanups I did there (in particular to avoid building
qtkeychain every time).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
d264f7078b
Parallelize the CI build
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Nextcloud bot
c3cd06ddad
[tx-robot] updated from transifex
2020-08-12 03:30:27 +00:00
Kevin Ottens
c5343e10f5
Merge pull request #2258 from nextcloud/have_a_way_to_display_e2ee_mnemonic
...
Keep the E2EE info message around to allow displaying mnemonic
2020-08-11 15:11:40 +02:00
Kevin Ottens
37e20698ca
Keep the E2EE info message around to allow displaying mnemonic
...
We lost the ability to display the E2EE mnemonic during the GUI
redesign and the info message wasn't displayed again on restart. So now
we display it every time, it still can be dismissed and the button text
is different in such a case to make the intent clearer.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-11 14:55:51 +02:00
Nextcloud bot
a1dbfd71cb
[tx-robot] updated from transifex
2020-08-11 03:30:03 +00:00
Kevin Ottens
d08c160b69
Merge pull request #2255 from nextcloud/restore_e2ee_old_key_storage_format_compatibility
...
Restore E2EE old key storage format compatibility
2020-08-10 16:07:06 +02:00
Kevin Ottens
ef3c516598
Add support for BASE64 encoded '|' when decrypting
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
595eb78c8a
Move the private key salt handling in its own function
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
d5339265fb
Ignore the salt part of the key during decryption
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
54a19945fd
Restore the symmetry between *StringSymmetric functions
...
If we receive data without base64 encoding for encryption, it makes
sense to get it without base64 encoding out of decryption.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
26b88131cc
Add unit tests for the encryption helpers
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Nextcloud bot
aac1f2ae56
[tx-robot] updated from transifex
2020-08-09 03:29:44 +00:00
Nextcloud bot
7e2c3b2516
[tx-robot] updated from transifex
2020-08-08 03:31:51 +00:00
Kevin Ottens
a813602124
Master is now what will become 3.1
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-07 14:36:44 +02:00
Nextcloud bot
53f346fa9b
[tx-robot] updated from transifex
2020-08-07 03:32:17 +00:00
Kevin Ottens
ff60f75b2a
Merge pull request #2248 from nextcloud/bump_version_to_3.0
...
There won't be a 2.7, this is called 3.0 instead
2020-08-06 14:25:00 +02:00
Kevin Ottens
39de633828
There won't be a 2.7, this is called 3.0 instead
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-06 13:40:00 +02:00
Nextcloud bot
2ebc4041ac
[tx-robot] updated from transifex
2020-08-06 03:31:10 +00:00
Nextcloud bot
8a89edc1f9
[tx-robot] updated from transifex
2020-08-05 08:58:21 +00:00
Nextcloud bot
cfbc343c69
[tx-robot] updated from transifex
2020-08-05 08:53:47 +00:00
Nextcloud bot
1906e5aac9
[tx-robot] updated from transifex
2020-08-05 03:31:20 +00:00
Kevin Ottens
662df54371
Merge pull request #2245 from nextcloud/fix-issue-2243
...
Fix #2243
2020-08-04 18:54:55 +02:00
Camila
8f300ffe66
Remove extra check for talk app on server in AccountState.
...
- Remove repeated hard coded "spreed" string.
Signed-off-by: Camila <hello@camila.codes >
2020-08-04 16:28:19 +00:00
Camila
6d6cc3852b
Fix #2243 : use server url instead of hard coded string.
...
Signed-off-by: Camila <hello@camila.codes >
2020-08-04 16:28:19 +00:00
Kevin Ottens
0516db5e10
Make sure we always have a CLSID when Explorer integration is used
...
We update properly the CLSID of folders to integrate them with the
Explorer pane when they are added or removed from the GUI. That said,
there might be cases of users adding folders to sync straight from the
GUI. In such a case the CLSID might be missing on config load so now we
assign one on the fly when that happens.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-04 07:33:53 +02:00
Nextcloud bot
cc4b12ce8b
[tx-robot] updated from transifex
2020-08-04 03:30:42 +00:00
Michael Schuster
e02be629bb
Windows: Enable CFG and SafeSEH linker security flags
...
See:
https://docs.microsoft.com/en-us/windows/win32/secbp/control-flow-guard
https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-03 10:11:33 +02:00
Michael Schuster
bc5888e8e4
Always show Settings in the context menu (amends #2164 )
...
The context menu should allow access to the Settings even when no accounts are configured.
Users may specify proxy / startup / update and other settings at any time.
This slipped through in #2164 .
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-03 10:10:05 +02:00
Nextcloud bot
480c3e6f86
[tx-robot] updated from transifex
2020-08-03 03:31:51 +00:00
Nextcloud bot
d457d87c86
[tx-robot] updated from transifex
2020-08-02 03:30:48 +00:00
Nextcloud bot
da814c9e44
[tx-robot] updated from transifex
2020-08-01 03:30:21 +00:00
Nextcloud bot
b1a92e8db9
[tx-robot] updated from transifex
2020-07-31 03:31:56 +00:00
Nextcloud bot
739edaa801
[tx-robot] updated from transifex
2020-07-30 03:31:15 +00:00
Nextcloud bot
5913cdd8d6
[tx-robot] updated from transifex
2020-07-29 03:32:53 +00:00
Kevin Ottens
b6826bf6ea
Merge pull request #2227 from nextcloud/support_png_for_branded_clients_systray
...
Support png for branded clients systray
2020-07-28 12:06:03 +02:00
Kevin Ottens
66ede652f8
Use PNGs for branded clients
...
For branded clients try to load a png of the right size, for unbranded
clients use the SVGs. If something fails at load time skip it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-28 09:20:34 +00:00
Kevin Ottens
72eba2b93d
Move the svg rendering part in a lambda
...
This simplifies the loop body a bit, opening the door to what's next.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-28 09:20:34 +00:00
Kevin Ottens
73c3aa7898
Extract the svg renderer from the loop
...
No need to recreate it each time for nothing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-28 09:20:34 +00:00
Kevin Ottens
16a37c6aa0
Branded clients have more size variety for their icons
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-28 09:20:34 +00:00
Kevin Ottens
983c02b6db
Switch to for range loop
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-28 09:20:34 +00:00
Kevin Ottens
14ecf535f9
Let Theme tell us if we're branded or not
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-28 09:20:34 +00:00
Camila
e89177b25b
Add OpacityMask to fix mouse hover on round corner.
...
- Fix for #2173 .
- Removed the workaround for the left round corner which was also
fixed with the OpacityMask.
Signed-off-by: Camila <hello@camila.codes >
2020-07-28 11:19:22 +02:00
Nextcloud bot
e5572faeba
[tx-robot] updated from transifex
2020-07-28 03:30:52 +00:00
Nextcloud bot
d2ea938ac0
[tx-robot] updated from transifex
2020-07-26 03:28:55 +00:00
Nextcloud bot
0c533ca387
[tx-robot] updated from transifex
2020-07-25 03:29:52 +00:00
Nextcloud bot
f3b22b33e3
[tx-robot] updated from transifex
2020-07-24 03:31:38 +00:00
Stephan Beyer
cd008ffe59
Let context menu open wizard if there are no accounts
...
The context menu offers to open the main dialog and the settings
even if no accounts are configured. In this case, the main dialog
is useless and the settings are probably confusing. Hence, this
commit replaces these actions in the context menu by an action
to open the wizard (which also opens on left click, so this is
the most natural thing to do).
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-23 21:08:53 +02:00
Nextcloud bot
3fd32e55f9
[tx-robot] updated from transifex
2020-07-23 03:32:46 +00:00
Michael Schuster
fba50c7c42
Merge pull request #2224 from nextcloud/qt-5.12.9-update
...
Update CI for Qt 5.12.9
2020-07-22 15:21:48 +02:00
Michael Schuster
6cc1aa723e
Update CI for Qt 5.12.9
...
Also remove the jq package installation from the AppImage build script because
the package is included in the new Docker image (see nextcloud/docker-ci#231 ).
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-22 14:19:57 +02:00
Nextcloud bot
ccff6e00dc
[tx-robot] updated from transifex
2020-07-22 03:31:25 +00:00
Kevin Ottens
f8fb26424d
Merge pull request #2209 from nextcloud/fix-pause-sync-states
...
Fix pause sync states
2020-07-21 13:12:39 +02:00
Dominique Fuchs
a07db657d5
sigh, too
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-21 12:44:45 +02:00
Dominique Fuchs
cd3a72822e
Get a const auto for the FolderMap to iterate over
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-21 10:10:07 +00:00
Dominique Fuchs
dbdf40ea45
Replaced Qt foreach by C++11 ranged for loop
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-21 10:10:07 +00:00
Dominique Fuchs
82c70f0c95
Properly set syncPause state on Systray creation when account init is done
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-21 10:10:07 +00:00
Dominique Fuchs
5ac3099b37
Fixed copy/paste bug, resulting in a wrong signal ::pauseSync used instead of ::resumeSync
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-21 10:10:07 +00:00
Michael Schuster
815cd7f3fc
Fix Windows installer graphics files for 2.7
...
For some reason the exported bitmaps in #2211 were not properly saved in the right
format for display by the NSIS installer system.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-21 10:54:02 +02:00
Nextcloud bot
30f7ef319c
[tx-robot] updated from transifex
2020-07-21 03:31:14 +00:00
Michael Schuster
b801a74281
Drone Upload: Fix if condition for master, in addition to #2213
...
Don't try to comment on master (old condition was from a previous version of the script).
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-21 01:20:19 +02:00
Michael Schuster
8fb272a95f
Merge pull request #2213 from nextcloud/enh/ci-upload
...
Drone: Upload AppImage to GitHub using nextcloud-desktop-bot
2020-07-20 18:28:44 +02:00
Michael Schuster
c3f5a9b9cc
Drone: Upload AppImage to GitHub using nextcloud-desktop-bot
...
Uploading AppImage's to transfer.sh often fail and cause the CI to wait for
the 15 minutes timeout.
This new approach uses a bot user to create releases in a dedicated ci-builds
repository. Each PR (or master) will get a dedicated release with the AppImage
supplied as a release asset. Older assets will be deleted prior uploading the
recent build.
The bot will then (in case of a PR) create a comment in the PR, containing the
download link.
Home of the CI releases: https://github.com/nextcloud-desktop-bot/ci-builds/releases
Inspired by: https://github.com/nextcloud/android/blob/master/scripts/uploadArtifact.sh
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-20 17:11:33 +02:00
Dominique Fuchs
6ab55eddae
Add -no-strip cmd line arg to macdeployqt if when building with Debug profile
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-20 15:04:33 +02:00
Nextcloud bot
f285a29463
[tx-robot] updated from transifex
2020-07-20 03:30:19 +00:00
Michael Schuster
51ce085ab5
Merge pull request #2215 from jneplokh/pr/ownCloud-reference-fix
...
Change ownCloud reference to Nextcloud
2020-07-20 02:12:57 +02:00
Jacob Neplokh
c4e8211687
Change ownCloud reference to Nextcloud
...
Signed-off-by: Jacob Neplokh <me@jacobneplokh.com >
2020-07-19 11:36:34 -07:00
Nextcloud bot
274e3491f3
[tx-robot] updated from transifex
2020-07-19 03:31:58 +00:00
Michael Schuster
d55fd09b27
Merge pull request #2211 from nextcloud/logo-2.7
...
Logo update for 2.7
2020-07-18 14:41:40 +02:00
Michael Schuster
b997f3e10a
Update Windows installer graphics with 2.7 logo
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-18 12:29:47 +00:00
Michael Schuster
4cd77d96ae
Update logo for 2.7
...
Based on: c876a02584/nextcloud-icon.svg
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-18 12:29:47 +00:00
Nextcloud bot
15b0da8904
[tx-robot] updated from transifex
2020-07-18 03:30:12 +00:00
Nextcloud bot
cd91309fd8
[tx-robot] updated from transifex
2020-07-17 03:31:27 +00:00
Nextcloud bot
27d08f02f4
[tx-robot] updated from transifex
2020-07-16 03:41:39 +00:00
Kevin Ottens
f46276d70d
Update our E2E API requirement
...
Now that we adjusted our protocol to follow the slightly updated server
API, let's make sure we don't try to talk to a server with an older API.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-15 18:39:29 +02:00
Kevin Ottens
15f9eeeb08
Merge pull request #2201 from nextcloud/disable_parallelism_for_e2e_remote_mkdir_jobs
...
Disable parallelism for e2e remote mkdir jobs
2020-07-15 17:24:11 +02:00
Kevin Ottens
c369d33015
Disable parallelism if we think the parent is e2e
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-15 13:05:54 +02:00
Kevin Ottens
cfd3771818
Allow to override the parallelism
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-15 13:05:11 +02:00
Kevin Ottens
5cfbf34501
Move PropagateRemoteMkdir ctor to the cpp file
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-15 13:03:55 +02:00
Kevin Ottens
6b8d2270c6
Make sure the tray icon point is in screen coordinates
...
Previously we were using QCursor::pos() in the Linux case, which is a
fair heuristic except it will always be relative to the primary screen
and not the current screen. This explains why we had to adjust with the
virtual geometry.
In the Windows and Mac case we got the position out of QSystemTrayIcon
and that one was already relative to the current screen.
So now we use QCursor::pos(currentScreen()) which ensures we give the
coordinates relatively to the current screen also in the Linux case.
Since all platforms are now having that point in the same coordinate
system we don't need to mess around with the virtual geometry to
compensate.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-15 12:22:54 +02:00
Nextcloud bot
2c50ecd4d3
[tx-robot] updated from transifex
2020-07-15 03:57:54 +00:00
Nextcloud bot
5c442af1ca
[tx-robot] updated from transifex
2020-07-14 03:29:35 +00:00
Kevin Ottens
62e2f64165
Merge pull request #2188 from nextcloud/upgrade-syncjournaldb-to27
...
Move existing syncjournal db files from client ver <2.7
2020-07-13 18:04:28 +02:00
Dominique Fuchs
6bc70ddd5b
Fix typo, use compound assignment op
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-13 17:47:19 +02:00
Dominique Fuchs
bc20edc582
Only attempt to move if file exist
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-13 17:47:18 +02:00
Dominique Fuchs
4656748130
Move existing syncjournal db files from client ver <2.7
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-13 17:47:11 +02:00
Nextcloud bot
ac837d19ee
[tx-robot] updated from transifex
2020-07-12 03:29:20 +00:00
István Váradi
69a37e10ce
Fetch tags for Debian build
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-07-11 17:39:17 +02:00
Nextcloud bot
fe7d22e4ce
[tx-robot] updated from transifex
2020-07-11 03:29:57 +00:00
Nextcloud bot
6c79231d1a
[tx-robot] updated from transifex
2020-07-10 03:33:30 +00:00
Nextcloud bot
2b97549266
[tx-robot] updated from transifex
2020-07-09 23:51:47 +00:00
Michael Schuster
a0284d07f6
Merge pull request #2183 from nextcloud/fix-delete-base-folders-instr
...
Prevent empty FileMap in local csync to be processed if folder not empty
2020-07-09 23:36:13 +02:00
Dominique Fuchs
19d46f0541
Merge branch 'fix-delete-base-folders-instr' of https://github.com/Nextcloud/desktop into fix-delete-base-folders-instr
2020-07-09 21:47:34 +02:00
Dominique Fuchs
f8920f969f
Remove debug variable
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-09 21:47:19 +02:00
Dominique Fuchs
8deb38ac24
Merge branch 'master' into fix-delete-base-folders-instr
2020-07-09 21:38:11 +02:00
Dominique Fuchs
d47e570ff3
Prevent empty FileMap in local csync to be processed if folder not empty
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-09 21:23:24 +02:00
Kevin Ottens
3ccac1b1be
Properly register folder as encrypted during sync
...
Turns out that when we added a new e2e folder during sync, we were
passing the wrong path to the e2e object. We have several path
convention in the sync code, just happened to be the wrong one.
I still long for the day when we'll use the type system to deal with
paths. All those strings are error-prone.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 17:16:21 +02:00
Kevin Ottens
26686ecd45
Recover from missing metadata on uploads
...
Other clients seem to allow creating empty encrypted folders with no
metadata associated to them, so let's get ready to handle it. In case of
a 404 to get the metadata, we create an empty metadata payload and pass
it further down.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
4ef42e53d3
Change the separator in the private key
...
It used to be a base64 encoded '|', now it is still a '|' but not
encoded, let's adjust accordingly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
3c20b2414e
Prevent parallelism when deleting encrypted files
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
1be869fdc7
Unlock the folder only after we actually deleted the file
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
8e0ab5ce47
Allow to specify the e2e-token on DeleteJob
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
0575d0e793
Stop unlocking from within PropagateRemoteDeleteEncrypted
...
We need to finish deleting the file before we can actually unlock. Also
the token will be necessary for the delete to succeed.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
7e251edd6e
Compare the unencrypted filename with the originalName
...
Otherwise obviously we'd never find the files in the metadata.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
2831b22be4
Use the encrypted path for collection listing
...
If we use the local path we'll get a 404.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
511a6e66dc
Pass e2e-token to PropagateUpload subjobs
...
The headers() method is used to pass extra headers to the PUT jobs for
instance, definitely needed for uploads now.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
9a4c63404d
Pass the e2e-token for encrypted MKCOL
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
01f5501ad8
Allow to pass extraHeaders to a path based MkColJob
...
We could specify the extra headers with a URL but not a simple path.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Kevin Ottens
e14ae806b6
E2EE RFC has been updated to use e2e-token instead of token
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-09 16:22:54 +02:00
Michael Schuster
a94def0e54
Merge pull request #2177 from nextcloud/fix-issue-2175
...
Share link display the correct permissions for files and folders.
2020-07-09 06:16:18 +02:00
Camila
f018f7df3b
Fix text in the permissions menu for share link.
...
Changed word capitalization and replace && for andi to match the server.
Signed-off-by: Camila <hello@camila.codes >
2020-07-09 03:21:04 +00:00
Camila
30a533d49c
Share link display the correct permissions for files and folders.
...
- Fix #2175 :
- Shows the correct default permissions
- Shows the permissions the user set
Signed-off-by: Camila <hello@camila.codes >
2020-07-09 03:21:04 +00:00
Michael Schuster
4fec77e9c0
Merge pull request #2168 from nextcloud/display-default-permissions-share
...
Display the correct default permissions when creating a share.
2020-07-09 05:19:56 +02:00
Camila
d7a1367292
Display the correct default permissions when creating a share.
...
- The default displayed was not in sync with the server because
the client was setting permissions when creating a share while it
should get the default permissions from the server to display it to the
user first.
Signed-off-by: Camila <hello@camila.codes >
2020-07-08 18:15:36 +02:00
Stephan Beyer
308bed0da7
Use braced initializer list for returns in Systray::taskbarGeometry()
...
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
a87b6157ee
Make csync_file_stat_s::isE2eEncrypted a bitfield
...
This is in line with other bools of that struct and gets rid
of clang-tidy's modernize-use-default-member-init warning.
(The trivial alternative to get rid of that warning would be
to use default member init for that bool variable, but I think
it is better to have it as a bitfield.)
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
1e6747cd1d
Remove redundant initialization of ElidedLabel::_elideMode
...
The value gets already initialized by default member initialization,
so there is no need to set it again in the constructor.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
293be2c2e6
Remove redundant initialization of HttpCredentials::_keychainMigration
...
The value gets already initialized by default member initialization,
so there is no need to set it again.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
a9de465927
Remove redundant initialization of SyncFileStatus::_shared attribute
...
The value gets already initialized by default member initialization,
so there is no need to set it again in the copy constructor.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
ed570d6274
Use default member init for PKeyCtx::_ctx and PKey::_pkey
...
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
00f93fdb77
Use more auto in folderstatusdelegate.cpp
...
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
82f38aa37d
Filter clang-tidy output on Drone for errors
...
The run-clang-tidy is very verbose and prints a lot of unneccessary
information. This commit greps for errors in the output.
Moreover, we add the -quiet switch.
As a desired "side" effect, this commit repairs the issue of
run-clang-tidy-6.0 that it does not return a usable exit code.
Hence clang-tidy errors will lead to CI failures now.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Stephan Beyer
8e6d9401c7
Simplify clang-tidy invocation for Drone
...
Symlinking and running bash is not necessary.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-08 14:08:41 +02:00
Kevin Ottens
2492e241ac
Adjust to makeDbName returning an absolute path
...
PR #1451 changed the behavior of makeDbName which now returns an
absolute path. This obviously then failed in nextcloudcmd which
prepended to it the path to the local folder to sync. We just stop doing
this to have the journal db end up at the right place in that case as
well.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-08 13:09:13 +02:00
Nextcloud bot
31bc07417b
[tx-robot] updated from transifex
2020-07-08 03:40:45 +00:00
Kevin Ottens
c2632eb604
Handle properly null avatar
...
If we try to produce the avatar before we managed to connect we'd end up
trying to paint in a null image. Just return early, which will allow the
caller to do something else instead.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-07 18:07:33 +02:00
Kevin Ottens
32b51a52ef
Merge pull request #2167 from nextcloud/fix_url_decoding_for_folder_encryption_status
...
Fix url decoding for folder encryption status
2020-07-07 18:06:19 +02:00
Kevin Ottens
217869e95c
Decode the href from the XML payload
...
The XML we get as reply has href entities properly percent encoded.
Since we didn't go through QUrl next we didn't get a properly decoded
version. Make sure we decode it before storage.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-07 15:51:24 +00:00
Kevin Ottens
f90d6951c2
No need to compute base at each loop run
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-07 15:51:24 +00:00
Stephan Beyer
e32bd75519
Set maximum height of account and app menu
...
The menus may become too large if they have too many items
(the account menu has this in case of many accounts, the apps
menu in case of many apps). This commit limits the maximum
height such that the menus do not hide the header.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-07-07 17:35:09 +02:00
Nextcloud bot
501380a004
[tx-robot] updated from transifex
2020-07-07 03:34:53 +00:00
Stephan Beyer
e010d58401
Merge pull request #2159 from nextcloud/fix_appsmenu_binding_loop
...
Reach out to the contentItem inside of the ListView to find the width
2020-07-06 23:48:51 +02:00
Kevin Ottens
b98cf0a029
Reach out to the contentItem inside of the ListView to find the width
...
Turns out that the ListView embedded in the Menu (reachable via
contentItem) would create a binding loop if we're using its
childrenRect. But really we're interested in the total width for the
instantiated delegate *inside* the ListView. That's why we go one level
deeper and get the childrenRect of the inner contentItem instead.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 20:39:42 +00:00
Michael Schuster
2475fb73b7
Merge pull request #2127 from nextcloud/fix/proxy-password-storage
...
ConfigFile security: Migrate Proxy password to keychain
2020-07-06 22:36:21 +02:00
Michael Schuster
f4d83d02f6
Cleanup auto pointers and qobject casts, refactor KeychainChunk
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:40 +02:00
Michael Schuster
ff631e919f
ProxyAuthHandler: Add template member function execAwait to avoid code duplication
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:40 +02:00
Michael Schuster
8503226c44
Keychain: Use auto deletion in WebFlowCredentials and ConfigFile
...
- Also make use of the new KeychainChunk::DeleteJob
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:40 +02:00
Michael Schuster
42eb3388f8
Refactor KeychainChunk to use QEventLoop and add DeleteJob class
...
- Use QEventLoop for synchronous exec()
- Rename startAwait() to exec()
- Add code for auto deletion
- Add new DeleteJob class
- Cleanup, tweaks
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:40 +02:00
Michael Schuster
ea95c4bf49
Refactor ProxyAuthHandler to use QEventLoop
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:39 +02:00
Michael Schuster
81c644e702
ConfigFile security: Migrate Proxy password to keychain
...
When specified in the config file, the Proxy password will be migrated
to the keychain, for backward compatibility and to allow admins to
overwrite an existing password by rolling out updated config files.
Once migrated to the keychain, the password will be removed from the
config file.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:39 +02:00
Michael Schuster
18cbbc5052
KeychainChunk: Add synchronous method startAwait()
...
Awaits completion with no need to connect some slot to the finished() signal first,
inspired by the ProxyAuthHandler class.
Also add:
- Job dtor to safely erase passwords
- textData() method
- New ctor overloads to work with arbitrary keys (without Account ptrs)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:39 +02:00
Michael Schuster
2a3ef044be
Move KeychainChunk class from gui to libsync
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:39 +02:00
Michael Schuster
203a2ce003
Move QKeychain::NoBackendAvailable error handling to KeychainChunk class
...
Originally this was in the WebFlowCredentials class. Since we've abstracted everything
from there already, let's also move this in case some other code may use
KeychainChunk::ReadJob prior to WebFlowCredentials.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-07-06 21:51:36 +02:00
Kevin Ottens
d3d713ff9c
Fix the hover for the other menu items
...
Ultimately we would avoid the code duplication by creating our own
proper QQC2 style instead of directly tuning everything. That's a battle
for another time (more elements would need to be adjusted for that, I
don't want to dilute this branch too much).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 20:14:57 +02:00
Dominique Fuchs
180f191014
Fix hover cutoff in apps menu
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-07-06 20:14:57 +02:00
asemmar
628a426d22
forgot some indent
...
Signed-off-by: asemmar <anis.semmar@itron.com >
2020-07-06 09:46:14 +02:00
asemmar
d5587e386c
fixed bad spelling of word 'retreive' except in sqlite dependancy
...
Signed-off-by: asemmar <anis.semmar@itron.com >
2020-07-06 09:46:14 +02:00
Kevin Ottens
5db717d48c
Merge pull request #2150 from nextcloud/fix_e2e_moves_handling
...
Fix e2e moves handling
2020-07-06 08:40:49 +02:00
Kevin Ottens
d217fc272e
Make sure moves involving e2e are delete + upload
...
If the file has a mangled name or will end up in a parent directory
known to be encrypted, we stick to the CSYNC_INTRUCTION_NEW instead of
going for CSYNC_INSTRUCTION_RENAME. This way we'll have a delete and an
upload instead of a move command.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 05:27:14 +00:00
Kevin Ottens
0b1cf69134
Update the metadata table with encryption info before discovery
...
When the ClientSideEncryption object is fed, also serialize the
encryption info of the folders inside the metadata table.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 05:27:14 +00:00
Kevin Ottens
7bb48a76c4
Add isE2eEncrypted column in the metadata table
...
This will allow to exploit the information of a directory being
encrypted or not during the discovery phase.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 05:27:14 +00:00
Kevin Ottens
287a130044
Also deliver the encrypted status via the ClientEncryption signal
...
This will turn useful for other consumers of that data. The alternative
would be to expose a method breaking all form of encapsulation.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 05:27:14 +00:00
Kevin Ottens
3520360159
Move the e2e information fetch even earlier
...
We used to do it when the propagation starts, let's do it even before
the discovery starts. This way we'll have a chance to exploit the
information during the discovery phase.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 05:27:14 +00:00
Kevin Ottens
f98c7990ba
Split the discovery phase out of startSync()
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-06 05:27:14 +00:00
Nextcloud bot
abb5c8b70e
[tx-robot] updated from transifex
2020-07-06 03:24:15 +00:00
Nextcloud bot
90ac7b75bf
[tx-robot] updated from transifex
2020-07-05 03:25:01 +00:00
Nextcloud bot
8fc1ae81b5
[tx-robot] updated from transifex
2020-07-04 03:27:19 +00:00
Nextcloud bot
4e3fffc4bc
[tx-robot] updated from transifex
2020-07-03 03:29:57 +00:00
Camila
bd9aae8ca2
Don't display quota information when the user has no quota.
...
- The code handling the api response was not up to date with the latest
api changes.
- Unlimited quota display: use qint64 to avoid data loss
- Change total with quota: total holds the quota total and not the storage total.
Signed-off-by: Camila <hello@camila.codes >
2020-07-02 20:06:12 +02:00
Camila
fdc160460b
Fix #2085 new tray menu.
...
Update systray behavior and context menu:
- left click brings up the new QtQuick based dialogs on all latforms
- right click brings up the new QtQuick based dialog on Mac OS only
- right click brings up a context menu on all other platforms than Mac OS
- "Quit Nextcloud" => "Exit Nextcloud"
- Add "Open main dialog" option.
Signed-off-by: Camila <hello@camila.codes >
2020-07-02 19:21:10 +02:00
Nextcloud bot
6081ef636d
[tx-robot] updated from transifex
2020-07-02 03:35:35 +00:00
Kevin Ottens
be4ba031ec
Merge pull request #2144 from nextcloud/fix_e2ee_upload_lock_starvation
...
Fix e2ee upload lock starvation
2020-07-01 19:22:45 +02:00
Kevin Ottens
5a07a36d06
Avoid job parallelism when uploading to an encrypted folder
...
With the current design of the file upload this necessarily pushed to a
lock starvation on the folder. Indeed you could end up with N jobs
asking for the lock at the same time. So just avoid parallelizing for
now even though it will be slow.
We could try to optimize but that'd require some serious changes to the
sync logic on the jobs... let's stabilize first and optimize later.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 17:11:57 +00:00
Kevin Ottens
27b982ceaf
Override parallelism() for uploads
...
This way we'll be able to control parallelism for upload jobs.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 17:11:57 +00:00
Kevin Ottens
5e20e2b46f
Move PropagateUpload ctor impl to the cpp file
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 17:11:57 +00:00
Kevin Ottens
56a6fe4731
Merge pull request #2139 from nextcloud/fix_e2ee_folder_sync_connection
...
Fix e2ee folder sync connection
2020-07-01 19:10:44 +02:00
Kevin Ottens
542d303313
Reduce interaction with e2ee folders when in the wizard
...
During the wizard we currently don't have much information about the
encrypted folders. In particular we can only display their mangled names
which is far from ideal for the user to make an informed choice.
That's why in the wizard we now forbid creation of subfolders in e2ee
folders and we also don't display subfolders of e2ee folders.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
cb9ba9702b
Properly display encryption status for non root folder connection
...
Since the e2e oracle works only in term of absolute remote paths and
that our model x._path was relative, we need to properly convert.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
d2e8cd4469
Deal properly with encrypted item updates accross connections
...
In such cases we get a download for which _file is already the demangled
name and _encryptedFileName has the mangled information. This is
different to what we encountered so far where initially _file was
mangled and _encryptedFileName was empty. Let's deal with that case
properly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
9a2d04720a
Also use mangled paths when looking for entries below a path
...
Otherwise on second sync we wouldn't find anything under a mangled path
and just end up thinking said files were removed.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
0f21b625ab
Also check on mangled names when cleaning up the journal
...
Otherwise, after a first sync all the mangled entries would be removed
from the journal. On second sync it would be fine because we'd then have
seen the unmangled names because of the local files. Unfortunately
that'd mean reuploading them for nothing or trying to mkdir again on the
server for nothing... with a chance of using differently mangled names
(although I didn't spot it, I can't exclude it never happened).
This also led to weirdly getting stuck during sync when there was more
than one sync point.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
3204c15911
Better separate between absolute and relative paths on uploads
...
Yes... I still wish this would be all driven by the type system, would be
much less error-prone.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
8d5c79c219
Better separate between absolute and relative paths on downloads
...
I wish this would be all driven by the type system instead of
error-prone string concatenation everywhere. That will be for a (much)
later refactoring hopefully.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
8a181adb3a
Always use an absolute remote path for GetFolderEncryptStatusJob
...
It turns out this job expected an absolute remote path even in the case
of a subfolder sync point.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:58:29 +00:00
Kevin Ottens
d2447ae90a
Merge pull request #2145 from nextcloud/repair_and_improve_logging
...
Repair and improve logging
2020-07-01 18:57:16 +02:00
Kevin Ottens
fdceb1f2d2
Allow to control logFlush from the config file
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:10:56 +02:00
Kevin Ottens
f557dd7792
Allow to control logDir from the config file
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:10:53 +02:00
Kevin Ottens
be2d9d4838
Allow to control logExpire from the config file
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 16:10:50 +02:00
Kevin Ottens
808fb17809
Allow to control log debug from the config file
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 15:56:23 +02:00
Kevin Ottens
7996eaae82
Have a filter rule capturing all of nextcloud debug
...
This was half broken before that commit and the previous one since some
of the categories would not be captured.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 15:39:52 +02:00
Kevin Ottens
53c31f5fed
Make sure all our logging categories start with nextcloud.
...
Otherwise it was a bit confusing and annoying for filter rules:
e.g. "nextcloud.sync.*" vs "sync.*".
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 15:39:52 +02:00
Kevin Ottens
90f757b96b
Repair the log message pattern
...
At last it will become useful again...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 15:39:52 +02:00
Hannah von Reth
5a05c2d6cd
[Logger] Ensure log file is flushed before crash
2020-07-01 15:13:20 +02:00
Hannah von Reth
cd96b4a265
[Logger] Ensure errors are also printed to an attached console
2020-07-01 15:13:20 +02:00
Olivier Goffart
44fc881ced
Logger: Remove the thread pointer from the log.
...
We don't do discovery in a thread or use many threads anymore so this is
just noise.
Also use of QString::sprintf is deprecated, and C cast.
2020-07-01 15:13:20 +02:00
Hannah von Reth
669e42edd1
[Logger] Correctly handle message priority
...
This fixes the flodded sys log.
Fixes : #7453
2020-07-01 15:13:20 +02:00
Hannah von Reth
a57bf0c899
Print critical and fatal messages to stderr
...
That way we might get a reason why the client crashes (dev setup)
2020-07-01 15:13:20 +02:00
Christian Kamm
039d885b76
LogDir: Compress last logfile on restart
...
For #7353
2020-07-01 15:13:20 +02:00
Kevin Ottens
09c9a1c5bc
Properly guard io.h since it is Windows only
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-07-01 15:13:20 +02:00
Dominik Schmidt
b171bd991d
Make -logfile - work on Windows
2020-07-01 14:54:52 +02:00
Dominik Schmidt
fd493a0598
Make qFatal() trigger the crash reporter on Windows
2020-07-01 14:54:32 +02:00
Valdnet
01e6f73da5
Change the space character to a dot
...
Change the space character to a dot in the text string
2020-07-01 14:11:14 +02:00
Valdnet
d526f9e073
Delete a space character
...
Delete a space character before the line breaks
2020-07-01 14:10:49 +02:00
Nextcloud bot
e28708beee
[tx-robot] updated from transifex
2020-07-01 03:25:34 +00:00
Kevin Ottens
aaba0f2bb5
Merge pull request #2128 from nextcloud/fix_subfolder_encryption_scheme
...
Fix subfolder encryption scheme
2020-06-30 17:19:02 +02:00
Kevin Ottens
d7a9a4cd09
Fix parenting issues of PropagateUploadEncrypted
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
3182c613ac
Take care of mangled paths on download as well
...
This means adjusting PropagateDownloadEncrypted so that it knows where
the file will end (otherwise it would create temporary files in non
existant paths for instance).
In turn we have to adjust PropagateDownloadFile accordingly so that it
resolves the local folder the file will end up in.
And last we adjust PropagateLocalMkdir to resolve paths as well and
demangle as needed.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
6dc12166ad
Update the item even if we don't call decryptFile()
...
This way it makes it usable in a directory context.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
2abc3ce2f5
Stop leaking PropagateDownloadEncrypted objects
...
We give them a parent to make sure they will be destroyed when the jobs
which created them are destroyed themselves.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
01d44dd3a1
Display folder names demangled in the settings
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
710c470c13
Assume that folder paths can be mangled
...
PropagateUploadEncrypted made the assumption of the folder names never
being mangled. This is not true since the previous commits so make sure
we properly deal with that using the journal db.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
3e13919c35
Use QHash instead of QMap
...
This is not only a question of performances in our case (complexity
being better on look ups). It also provides a few more services.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
3db267a03b
Ensure GetFolderEncryptStatusJob gets all the folders
...
We ensure the PROPFIND Depth is infinity by explicitly specifying the
header (turns out our implementation just doesn't assume infinity
otherwise). This way we have a clear picture about *all* the folders of
the user, otherwise ClientSideEncryption couldn't be a trustable oracle
on the encryption state for any folder not on the root and all the
encryption code assumes it has a full picture of encryption.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
f93fdafa80
Finally encrypt subdirectories during sync
...
We catch when a directory is inside a known encrypted folder and in such
a case we now do the following:
1) we encrypt the folder meta data (its name) properly and create it
under that mangled name on the server side
2) we mark the new folder itself as encrypted
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
319e441653
Make PropagateUploadEncrypted reusable in a directory context
...
It was assuming we'd encrypt only files but directory names also need to
be encrypted. We just skip the writing to temp file part in that case.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
fc9a8c4496
Mark user strings for translation
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
74978a23fb
Move the encrypt folder logic in a reusable job class
...
This way this whole logic isn't stuck into the settings dialog anymore.
Also cleaned up the unused "decrypt folder" logic.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
b3fb730d5a
Use the propagator to trigger the e2e info fetch
...
This is a much better place than the GUI, this way we ensure the
propagator is always operating of up to date information. Previously if
the propagator kicked in without user interaction from startup (not
showing the settings dialog) it would have no E2E information available
whatsoever... unsurprisingly it would thus take wrong information at
every turn.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
5f611d6e39
Get ClientSideEncryption to notify when folder info fetch is done
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
76fbbfefa5
Fix typo
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
5afcf71e68
Fix typo
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
839c056b8d
Don't show the encrypt action in subfolders of encrypted folders
...
Since we want to move to a place where the encryption of subfolders is
always enforced it makes no sense to leave it in control of the user.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
3bbc54ee6c
Fix typo
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Kevin Ottens
03ecaab259
Capture the pointer to info by value
...
Using a reference capture is a disaster waiting to happen here, if for
some reason we'd move from exec() to popup() for the menu below we'd be
getting garbage in the lambda call.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-30 11:29:08 +02:00
Nextcloud bot
7794de9b59
[tx-robot] updated from transifex
2020-06-30 03:24:51 +00:00
Nextcloud bot
372f67839e
[tx-robot] updated from transifex
2020-06-29 03:25:17 +00:00
Kevin Ottens
6ec5f9ea10
Merge pull request #2126 from nextcloud/sbeyer-simplify-systray-positioning
...
Slightly simplify code for Systray positioning
2020-06-26 14:29:29 +02:00
Stephan Beyer
20b58219e4
Hide Systray's auxiliary positioning methods from public and Qml
...
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-26 12:03:26 +00:00
Stephan Beyer
080505ef46
Simplify tray window positioning
...
The Qml position setting code is moved to C++, which allowed to get rid
of the currentScreenIndex() method (which seemed to be just a detour to
pass the screen from C++ to Qml).
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-26 12:03:26 +00:00
Nextcloud bot
afa5267932
[tx-robot] updated from transifex
2020-06-26 03:25:36 +00:00
Michael Schuster
d71249bb6e
Fix crash in UserModel::currentUser() and add more sanity checks
...
Commit 07bede8 (PR #1892 ) introduced a new helper method currentUser()
that didn't check for _users.count() thus causing to throw an
"index out of range" exception when no accounts are configured.
This commit uses the opportunity to add more sanity checks to UserModel.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-25 20:52:30 +02:00
Nextcloud bot
109f9ae60a
[tx-robot] updated from transifex
2020-06-25 03:26:55 +00:00
Kevin Ottens
cbea0e7134
Merge pull request #2119 from nextcloud/sbeyer-fix-segv-on-exit
...
Fix SEGV (due to circular ownership) at exit
2020-06-24 18:05:37 +02:00
Stephan Beyer
f90e0e519f
Make Systray's _trayEngine a QPointer
...
This is just safer.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-24 17:25:20 +02:00
Stephan Beyer
08cb289b8c
Fix SEGV (by circular ownership) at exit
...
Commit a12205f322 (PR #1891 ) introduced
a circular ownership: qmlRegisterSingletonType<Systray>(...) makes the
QQmlEngine own the resulting singleton Systray instance, however, the
QQmlEngine _trayEngine itself is owned by the Systray instance. This
circular ownership results in a crash when the destructor of Systray
calls the destructor of _trayEngine which attempts to call the destructor
of Systray.
This commit solves this problem by making ownCloudGui, which is the
parent of Systray, the parent of the _trayEngine.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-24 13:50:17 +02:00
Stephan Beyer
6adb798728
Let Systray constructor call its base class constructor
...
Although I see no behavioral difference, this is probably
a good idea.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-24 13:42:26 +02:00
Nextcloud bot
af5acd5142
[tx-robot] updated from transifex
2020-06-24 03:25:43 +00:00
Nextcloud bot
5959a98e29
[tx-robot] updated from transifex
2020-06-23 03:30:12 +00:00
Michael Schuster
902963fa10
Fix issue #2108 : Default system proxy not working with Account Wizard
...
Discovered on Windows in conjunction with PAC scripts:
- Already configured accounts worked
- Fresh client account setup did not work
Reason:
- Proxy was reset over and over again in Account::setCredentials
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-22 11:59:13 +02:00
Kevin Ottens
d5113b5342
Merge pull request #2110 from nextcloud/sbeyer-menu-border-colors
...
Darken menu border color
2020-06-22 11:58:10 +02:00
Stephan Beyer
3f4ed0883a
Make sure the menu separator uses Style.menuBorder color
...
In case the default color value will ever change, this
commit makes sure that the colors of the menu border and
the menu separator coincide.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-22 06:54:57 +00:00
Stephan Beyer
f671a4b23f
Darken menu border color
...
The lightgray menu border color #ededed introduced in
commit f147e5a66f (by PR #2095 )
is way too light for my display (and probably others).
Thus the menus have no clear border which looks odd and broken.
This commit simply darkens the menu border to #bdbdbd, which
coincides with the (current default) color of the menu separator.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-22 06:54:57 +00:00
Nextcloud bot
6f5bf018f6
[tx-robot] updated from transifex
2020-06-22 03:24:14 +00:00
Nextcloud bot
0b5484bfea
[tx-robot] updated from transifex
2020-06-20 03:26:41 +00:00
Michael Schuster
cee8a4ccf6
Merge pull request #2106 from nextcloud/fix/proxy-build-libsync
...
Fix libsync exports for proxy changes in #1886
2020-06-18 21:24:25 +02:00
Michael Schuster
92c8d6836b
Fix libsync exports for proxy changes in #1886
...
Build failed on Windows, missing libsync export for printQNetworkProxy after
moving ClientProxy class from gui to libsync.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-18 21:05:11 +02:00
Michael Schuster
1afb70e114
Merge pull request #1886 from nextcloud/enh/proxy
...
Move the proxyfiles to libsync where they make more sense
2020-06-18 20:38:27 +02:00
Michael Schuster
0253e98041
Improve proxy logging: Log type string instead of abstract ID
...
The format in the client log was: 3://host:port
Now it is shown like: HttpProxy://host:port
The old ID display was confusing and misleading users (and people debugging it ;p)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-18 20:13:57 +02:00
Roeland Jago Douma
50dcab5f88
Move the proxyfiles to libsync where they make more sense
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-18 18:38:06 +02:00
Nextcloud bot
9b9504c860
[tx-robot] updated from transifex
2020-06-18 03:26:43 +00:00
Michael Schuster
56f79eb8b4
Merge pull request #2093 from nicrame/patch-1
...
Add photothumb.db to sync-exclude.lst
2020-06-18 01:36:00 +02:00
Michael Schuster
93404c6c1b
Merge branch 'master' into patch-1
2020-06-18 00:44:52 +02:00
Kevin Ottens
bc9f7415b6
Merge pull request #2099 from nextcloud/ease_access_to_main_dialog
...
Ease access to main dialog
2020-06-17 19:25:37 +02:00
Kevin Ottens
2ce1669ceb
Bring forward the main systray dialog on second execution
...
Previously we were showing up the settings dialog but it doesn't quite
make sense anymore now that we got two dialogs.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-17 16:01:49 +00:00
Kevin Ottens
a6873f556b
Also show the window on right click
...
Note this won't work on all platforms. KDE Plasma and GNOME Shell (with
systray extension) assume that right click is necessarily for a context
menu exposed via D-Bus, there's not nice way to make the right click
popup the main dialog on those platforms.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-17 16:01:49 +00:00
Michael Schuster
bb78789300
Merge branch 'master' into patch-1
2020-06-17 17:35:07 +02:00
Nextcloud bot
afac668d9c
[tx-robot] updated from transifex
2020-06-17 03:24:38 +00:00
Kevin Ottens
73a689bc39
Don't call method on potentially null object
...
We were calling accountState() on a "folder" member which could be
nullptr. In fact this would happen any time one right click on a file
outside of a sync dir under Windows, this thus led to a crash.
Since the capabilities variable was unused anyway, we just removed it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-16 19:15:53 +02:00
Kevin Ottens
4f7a6cfb1d
Make activity items with a link clickable
...
We then get more items clickable, in particular the bottom one proposing
to open the activity application. Now we can click it and it opens the
activity application straight away.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-16 18:52:20 +02:00
Kevin Ottens
f147e5a66f
Don't use a bright blue color for menus
...
As advised, use a light gray instead, this electric blue was a bit too
much.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-16 18:52:20 +02:00
Kevin Ottens
2096e8295d
Don't use a weirdly truncated icon size for header buttons
...
This led to blurry icons. Now use a fixed size of 32 which also makes
them a bit more pleasing... at least to me. ;-)
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-16 18:52:20 +02:00
Kevin Ottens
bc863584db
Don't duplicate file name in the info line
...
For the "Activity" type activities, displayPath contains the file name
which is also in the subject. This was redundant, so now we don't
display an info line at all for that type of activities.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-16 18:52:20 +02:00
Kevin Ottens
f8e2e3403a
Close all menus on window show
...
We previously missed the app menu which wasn't closed.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-16 18:52:20 +02:00
Nicolas Fella
07bede8a56
Use properties to get user details
...
Convert imperative QML code to declarative code using property bindings
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-06-16 15:01:37 +02:00
Nicolas Fella
a12205f322
Port from context properties to singletons
...
Context properties are deprecated and will be removed in Qt 6.
QML singletons are the better option here, especially given that
UserModel and UserAppsModel already are singletons.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-06-16 14:34:59 +02:00
Nextcloud bot
1157ceafb1
[tx-robot] updated from transifex
2020-06-16 03:26:18 +00:00
Nicolas Fella
be2e5266aa
Create HeaderButton QML component
...
Deduplicate the Button code by moving it into a separate file.
Also use the same background code for the apps button since as far as I can tell it didn't behave any different
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-06-15 20:52:41 +02:00
Kevin Ottens
cf6ac3d14e
Merge pull request #1939 from nextcloud/fix-tray-multiscreen
...
Major multi monitor improvements and rewrite of tray window positioning
2020-06-15 14:49:35 +02:00
Kevin Ottens
d3d99b2d9d
Add some debug output for the window placement
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Michael Schuster
44a9200c5d
Fix crash caused by setting Tray window screen pointer on the QML side
...
Seems like Qt sometimes doesn't like the QML window's screen property to be set
to a C++ (QVariant) pointer value, so we use the index: Qt.application.screens[]
See Qt docs: https://doc.qt.io/qt-5/qml-qtquick-window-window.html#screen-prop
This fix returns the matching window's index from the QGuiApplication::screens()
list to the QML side, instead of the window pointer.
Steps to reproduce the crash with the previous code:
- Open the Tray menu and close it a few times,
or scroll randomly up and down in its activity list.
Tested with Qt 5.12.5
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-15 12:32:25 +00:00
Michael Schuster
5055f526c2
Remove Submodule qtmacgoodies again
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-15 12:32:25 +00:00
Kevin Ottens
f15a9cfc82
Try make taskbar position heuristic more readable
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Kevin Ottens
5848a1575b
Make the reference point independent of the window
...
This leads to simplifying the computation code quite a bit as well.
Indeed we're separating concern between what is window size dependent or
not and that shows.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Kevin Ottens
40824dc427
Get rid of screenIndex
...
This was leading to the same logic being duplicated several times. It's
fine to return the QScreen* on the QML side directly but wrapped into a
QVariant.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Kevin Ottens
6c6dfb15a7
Move all the position computation on the C++ side
...
The API is just more convenient there, the rect and point types on the
QML side are just pale shadow of their C++ counterparts.
Also improved a bit the constness of the Systray class.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Kevin Ottens
83b36b4ab0
Rename tbOrientation into taskbarOrientation
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Kevin Ottens
aa90237e94
Introduce a screenRect as coordinate space
...
The top left corner of that screenRect is (0,0) or based on
(virtualX,virtualY) depending on the platform. This leads to easier
reduction in code duplication.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Kevin Ottens
65e8f33ccf
Use TaskBarPosition enum on the QML side
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-15 12:32:25 +00:00
Dominique Fuchs
a6f918f3c2
More simplifications, also transfer of more tray positioning logic to C++ backend.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-06-15 12:32:25 +00:00
Dominique Fuchs
f44df7f61a
Major multi monitor improvements and rewrite of tray window positioning
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-06-15 12:32:25 +00:00
Nextcloud bot
121e23e322
[tx-robot] updated from transifex
2020-06-15 03:25:35 +00:00
Marcin Wilk
299749681d
Add photothumb.db to sync-exclude.lst
...
Add photothumb.db file that is thumbnails generated by Photoscape application (generated in every folder with graphic files).
2020-06-14 20:24:10 +02:00
Nextcloud bot
39e8c80116
[tx-robot] updated from transifex
2020-06-14 03:23:26 +00:00
Nextcloud bot
e92d79956f
[tx-robot] updated from transifex
2020-06-12 03:26:31 +00:00
Nextcloud bot
037b4a6ba6
[tx-robot] updated from transifex
2020-06-11 03:25:10 +00:00
Michael Schuster
473f3fd05c
Merge pull request #2077 from nextcloud/nullptr-everywhere-comparison
...
Simplify nullptr comparisons where appropriate
2020-06-11 01:03:44 +02:00
Michael Schuster
456c1eadbe
Simplify nullptr comparisons where appropriate
...
Make the codebase consistent, we already have a lot of implicit pointer comparisons.
Exception: Stay explicit on return's, example:
return _db != nullptr;
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-11 00:27:30 +02:00
Nextcloud bot
3f685fd933
[tx-robot] updated from transifex
2020-06-10 03:28:04 +00:00
Michael Schuster
2b680cadd3
Fix nullptr regression in RegistryUtil::ReadRegistry
...
Merging PR #2057 caused the Windows build to fail:
shell_integration\windows\OCUtil\RegistryUtil.cpp(43): error C2664: 'LSTATUS RegOpenKeyExW(HKEY,LPCWSTR,DWORD,REGSAM,PHKEY)': cannot convert argument 3 from 'nullptr' to 'DWORD'
The previous implementation prior the PR supplied NULL as the argument 3 to RegOpenKeyEx,
so it was silently accepted and translated to zero, satisfying the DWORD's type requirement.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-09 18:34:43 +02:00
Rick van der Zwet
24177ec7e4
Change default autostart to hide gui
...
Signed-off-by: Rick van der Zwet <info@rickvanderzwet.nl >
2020-06-09 18:34:30 +02:00
Kevin Ottens
6420725fb9
Merge pull request #2058 from nextcloud/sbeyer-fix-nosync-crash
...
Fix/improve use case without local folder
2020-06-09 18:33:54 +02:00
Stephan Beyer
0f620acc1f
Replace prefixing of paths with file:// by QUrl::fromLocalFile()
...
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-09 16:45:46 +02:00
Stephan Beyer
749070a29c
Hide openLocalFolderButton if no local folder is configured
...
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-09 16:45:46 +02:00
Stephan Beyer
131c1f1bac
Fix crash on opening unconfigured local folder
...
When you try to open the local sync folder (by clicking on the
folder symbol) for an account that has no folder configured,
the client crashes.
This commit changes User::openLocalFolder() to do nothing in
case no local folder is configured.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-09 16:45:38 +02:00
Stephan Beyer
2946c335ba
Change width of app menu
...
The app menu had a width based on the header button size which was
way too narrow to display its content.
This commit changes the width based on the contents (menu items) of
the menu, however, limiting the maximum width to half the window width.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-09 14:53:51 +02:00
Nextcloud bot
e138c7dcc5
[tx-robot] updated from transifex
2020-06-09 03:25:28 +00:00
Stephan Beyer
ea16804751
Replace NULL by nullptr in all C++ files
...
We keep NULL in the pure C files in src/csync/std and test/csync.
We also replace Doxygen documentation referring to "NULL" to
"\c nullptr" (formatted as code).
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-08 20:07:50 +02:00
Nicolas Fella
bce93b052b
Use APPLICATION_ICON_NAME for autostart icon
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-06-08 20:06:00 +02:00
Roeland Jago Douma
fba69de096
Don't show a message box if the entered url returned an error
...
BEtter to now just display clickable links etc.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-06-08 19:40:16 +02:00
Michael Schuster
3b4c409aab
Merge pull request #2063 from nextcloud/fix/mac-bundleinfo-dark-mode-optin
...
macOS: Opt In to Dark Mode for building against older macOS SDKs < 10.14
2020-06-07 16:38:03 +02:00
Michael Schuster
565fa18db2
macOS: Opt In to Dark Mode for building against older macOS SDKs < 10.14
...
Required for our build server that uses an older SDK to support previous macOS versions.
See: https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_macos_app
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-07 16:21:02 +02:00
Michael Schuster
be48889812
Merge pull request #1749 from nextcloud/fix/mac-2.7-qml-tray-build
...
macOS: Use macdeployqt instead of the old admin/osx/macdeployqt.py
2020-06-07 16:17:30 +02:00
Michael Schuster
e6389959ce
macOS: Build nextcloudcmd after gui and run macdeployqt with the -executable option
...
- src/CMakeLists.txt: Switch build order to build cmd before gui
- src/gui/CMakeLists.txt: Use the -executable option for a combined run of macdeployqt
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-07 14:39:42 +02:00
Dominique Fuchs
a45c2e04e5
Copy nextcloudcmd post-build instead of macdeployqt when building macOS bundle
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-06-07 14:39:42 +02:00
Michael Schuster
acb56be528
macOS: Use macdeployqt instead of the old admin/osx/macdeployqt.py
...
In order to build the new 2.7 releases (new QML dependencies) without manually
modifying the old Python script each time, rely on Qt's standard tool instead.
This should streamline the build systems for upcoming dependency changes.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-07 14:39:42 +02:00
Michael Schuster
3ce88bb62c
Merge pull request #2061 from nextcloud/enh/version-display-cmd
...
Improve command line version info and help display (gui & cmd)
2020-06-07 14:38:48 +02:00
Michael Schuster
221e5c5fc4
Improve command line version info and help display to streamline gui and cmd
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-07 14:20:33 +02:00
Nextcloud bot
992b05c53e
[tx-robot] updated from transifex
2020-06-07 03:25:11 +00:00
Michael Schuster
b28fe79902
Merge pull request #2060 from nextcloud/fix/qt-5.15.0-build-error
...
Fix Qt 5.15.0 build error (missing include)
2020-06-07 03:23:15 +02:00
Michael Schuster
0fe7a65738
Fix Qt 5.15.0 build error (missing include)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-06-07 02:43:45 +02:00
Nextcloud bot
45bddb6f9c
[tx-robot] updated from transifex
2020-06-06 03:27:24 +00:00
Stephan Beyer
674759d94e
Rename rebase.yaml to rebase.yml for consistency
...
YAML files here use the .yml extension, not the .yaml extension.
Hence the GitHub workflow file is renamed.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-06-05 07:46:04 +02:00
Nextcloud bot
30ba341b8c
[tx-robot] updated from transifex
2020-06-05 03:24:18 +00:00
Kevin Ottens
00d20b03ac
Add some more make_unique calls
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-04 08:44:05 +02:00
Nextcloud bot
7525ce887f
[tx-robot] updated from transifex
2020-06-04 03:24:30 +00:00
Kevin Ottens
0503be65ae
Cleanup the missing braced init list returns
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-03 16:14:18 +02:00
shile
891c192ebc
Add install instructions for nextcloudcmd
...
Signed-off-by: shile <13051960278@163.com >
2020-06-03 16:10:55 +02:00
Kevin Ottens
e3e262e42e
Use default member init when applicable
...
This also fixes a couple of warnings at places (out of order init for
instance) and a potential bug in the webflow credentials / qtkeychain
integration.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-03 16:10:39 +02:00
Kevin Ottens
965909f7fa
Add missing auto opportunities
...
Somehow forgot to run it on the updater code
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-03 16:02:43 +02:00
Kevin Ottens
12279089f5
Merge pull request #2047 from nextcloud/clang-cppcoreguidelines-init-var
...
Do not declare local variables without an initial value.
2020-06-03 10:35:24 +02:00
Camila San
3bae570f29
Do not declare local variables without an initial value.
...
Signed-off-by: Camila San <hello@camila.codes >
2020-06-03 07:50:40 +00:00
Nextcloud bot
e90eb9d717
[tx-robot] updated from transifex
2020-06-03 03:24:59 +00:00
Kevin Ottens
e99d3f18be
Merge pull request #1257 from ivan-cukic/ivan/icon-for-unencrypted-subdir
...
Show a broken lock icon for unencrypted subdirectory
2020-06-02 18:37:25 +02:00
Kevin Ottens
02a28325a8
Show broken encryption icon only in non-empty folders
...
This should address Tobias' concerns regarding the icon being
misleading. Now we basically do the following inside an encrypted folder
parent:
* encrypted folders get the encrypted icon;
* non-encrypted empty folders get the regular folder icon;
* non-encrypted non-empty folders get the broken encryption icon.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-06-02 15:50:18 +00:00
Ivan Čukić
c800d9149e
Show a broken lock icon for unencrypted subdirectory
...
The E2E application allows creating unencrypted subdirectories
in an encrypted parent. This is a big privacy problem.
This patch shows a red broken lock icon for these subdirectories
in the NC client UI.
Signed-off-by: Ivan Čukić <ivan.cukic@kde.org >
2020-06-02 15:50:18 +00:00
Michael Schuster
f286603ffe
Merge pull request #1235 from ivan-cukic/ivan/fixing-leaks
...
Fixing memory leaks in the encryption module
2020-06-02 17:47:08 +02:00
Ivan Čukić
4fb370275d
Introduced RAII classes for other OpenSSL resources
2020-06-02 14:09:06 +00:00
Ivan Čukić
c31b1a750d
Fixing memory leaks in the encryption module
...
Due to usage of early-returns, combined with malloc/free,
several buffers that get allocated are leaked when an error
occurs.
Several functions had potential leaks:
- `encryptStringSymmetric` leaked `ctext`
- `EncryptionHelper::fileDecryption` leaked `out`
- `EncryptionHelper::fileEncryption` leaked `out`
Most of the functions had leaks of the cypher context.
This patch uses `QByteArray` as the handler for the dynamically
allocated buffers for openssl to operate on. This also removes
the need for conversions from malloc'd buffers to `QByteArray`
variables previously present in the code.
It also introduces a `CypherCtx` thin wrapper class to provide
a leak-free handling of `EVP_CIPHER_CTX`.
2020-06-02 14:09:06 +00:00
Nextcloud bot
5a1404ef59
[tx-robot] updated from transifex
2020-06-02 03:24:55 +00:00
Nextcloud bot
2720897cde
[tx-robot] updated from transifex
2020-06-01 03:24:28 +00:00
Michael Schuster
e348f6458d
Merge pull request #2051 from nextcloud/remove-submodule-binary
...
Remove Submodule binary (old upstream binaries)
2020-05-31 16:06:22 +02:00
Michael Schuster
a57903259b
Remove Submodule binary (old upstream binaries)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-05-31 15:47:36 +02:00
Nextcloud bot
fe1d287c62
[tx-robot] updated from transifex
2020-05-31 03:24:59 +00:00
Nextcloud bot
b5ffad192c
[tx-robot] updated from transifex
2020-05-30 03:24:55 +00:00
Michael Schuster
a80d0b0f0f
Merge pull request #1940 from nextcloud/traywindow-listview-actions
...
Implemented share functionality in tray window and changed buttons
2020-05-29 21:14:21 +02:00
Michael Schuster
6ec69a700d
ShareDialog: Pointer cosmetics
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-05-29 20:57:52 +02:00
Michael Schuster
ae0ea12501
Merge branch 'master' into traywindow-listview-actions
2020-05-29 19:08:21 +02:00
Michael Schuster
ba4d109315
ShareDialog: Add further checks for the _manager member ptr
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-05-29 18:29:47 +02:00
Michael Schuster
efdef8535f
ShareDialog: Fix crash, properly init member pointers
...
_manager ptr only got initialized in the constructor when sharingPossible was set to true
Changes:
- Move member ptr inits from constructor to the header file's class definition
- Init _manager: set to nullptr too
- Add check for _manager to avoid crash in showSharingUi()
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-05-29 18:12:36 +02:00
Nextcloud bot
4620734194
[tx-robot] updated from transifex
2020-05-29 03:26:32 +00:00
Kevin Ottens
53c3eb8fe5
Try to fix the rebase action
...
I think I got the if clause wrong regarding limiting the command only to
member users. Let's move this out of the way for now.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-28 19:27:12 +02:00
Kevin Ottens
08cc4e1967
Remove the last redundant void arg I left behind
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-28 18:57:20 +02:00
Kevin Ottens
8d823baede
Add a GitHub Action to easily rebase PRs
...
This will make it easier to have a semi-linear commit history
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-28 18:12:27 +02:00
Nextcloud bot
300fb90c0b
[tx-robot] updated from transifex
2020-05-28 03:30:34 +00:00
Michael Schuster
a2fd79bcf7
Merge pull request #2035 from nextcloud/add_clang_tidy_pipeline_to_drone
...
Add clang tidy pipeline to drone
2020-05-27 19:14:08 +02:00
Kevin Ottens
2b4ea340e2
Run clang-tidy from the 5.12-clang pipeline
...
This should pass, with the minimal .clang-tidy which was provided. Other
PRs should be done to enable further checks.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-27 18:44:25 +02:00
Kevin Ottens
7f7dd6bc76
Upgrade to the latest client image
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-27 16:43:24 +02:00
Michael Schuster
c0a9f60d0d
Merge pull request #2032 from nextcloud/insulate_testutility_from_user_settings
...
testLaunchOnStartup shouldn't fail on dev setup
2020-05-27 16:10:57 +02:00
Michael Schuster
ad8075a30b
Merge pull request #2023 from nextcloud/use_return_braced_init_list
...
Use the return braced init list pattern
2020-05-27 16:08:19 +02:00
Kevin Ottens
b39a14bf2b
testLaunchOnStartup shouldn't fail on dev setup
...
This test was failing locally for me. Indeed, through QStandardPaths it
was finding the user settings of my production client and not having the
initial state it expected. Using QStandardPaths test mode then it starts
from a clean slate every time.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-27 15:11:25 +02:00
Kevin Ottens
6e62c8b430
Use the return braced init list pattern
...
This way we avoid repeating the return type while it is already known.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-27 14:36:07 +02:00
Michael Schuster
ccc409dbd0
Merge pull request #2024 from nextcloud/use_raw_string_literals
...
Use raw string literals when appropriate
2020-05-27 05:54:54 +02:00
Nextcloud bot
606aa131e7
[tx-robot] updated from transifex
2020-05-27 03:26:35 +00:00
Michael Schuster
044a4bf6b5
Merge pull request #2021 from nextcloud/use_default_for_trivial_ctor_and_dtor
...
Use = default for trivial ctors and dtors
2020-05-27 05:17:24 +02:00
Michael Schuster
b2b0e8f4e4
Merge pull request #2020 from nextcloud/use_make_unique
...
Use make_unique when appropriate
2020-05-27 05:10:41 +02:00
Michael Schuster
4b2684cf4a
Merge pull request #2019 from nextcloud/remove_redundant_void_argument
...
Remove redundant void argument list
2020-05-27 05:07:52 +02:00
Michael Schuster
21c6dd50a2
Merge pull request #2018 from nextcloud/use_using
...
Use using instead of typedef
2020-05-27 05:04:55 +02:00
Michael Schuster
7a102feca8
Merge pull request #2017 from nextcloud/remove_redundant_initializer
...
Remove redundant initializer
2020-05-27 05:01:34 +02:00
Kevin Ottens
f5350db078
Use raw string literals when appropriate
...
This is especially nice for Windows paths.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-26 20:13:51 +02:00
Kevin Ottens
a73a1f3927
Use = default for trivial ctors and dtors
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-25 21:33:24 +02:00
Kevin Ottens
9e20a0fecf
Use make_unique when appropriate
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-25 21:08:43 +02:00
Kevin Ottens
65e6c445e5
Remove redundant void argument list
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-25 20:32:55 +02:00
Kevin Ottens
0bc4dcd8a5
Use using instead of typedef
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-25 20:29:44 +02:00
Kevin Ottens
86b1821251
Remove redundant initializer
...
This is the same value than the initializer value in the header, no need
to repeat it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-25 20:12:09 +02:00
Kevin Ottens
b579b49a5c
Get rid of redundant parentheses
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-25 20:03:01 +02:00
Nextcloud bot
4825c472f6
[tx-robot] updated from transifex
2020-05-25 03:23:39 +00:00
Nextcloud bot
6a207d19e7
[tx-robot] updated from transifex
2020-05-24 03:24:41 +00:00
Michael Schuster
d4563e9196
Merge pull request #2006 from nextcloud/sbeyer-improve-wizard-url-field
...
Improve URL input field in Wizard
2020-05-23 20:06:21 +02:00
Stephan Beyer
375fcb8e14
Replace "https://..." hint by " https://host:port "
...
The new hint is a little more verbose and provides more information
than the old one.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-23 18:32:18 +02:00
Stephan Beyer
f46ce2ce98
Show URL placeholder hint in wizard
...
In owncloudsetupnocredspage.ui, the URL input field leUrl has a
placeholder text saying "https://..." which is a very useful hint
for the user. However, in the OwncloudSetupPage constructor, the
placeholer text is overwritten by the return string of the theme's
wizardUrlHint() method. The NextcloudTheme class does not override
this virtual method, so an empty string is used.
To make available the "https://..." hint, it is moved from the
UI file to NextcloudTheme::wizardUrlHint(). Note that, if a
theme is used which does not allow a custom server URL, the
placeholder text is now empty. This makes sense because the
input field is disabled in that case.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-23 18:32:15 +02:00
Stephan Beyer
deff3230f5
Change vertical size policy of URL input field in wizard
...
The input field for the nextcloud server URL is vertically too
big (because of the icon next to it in the same horizontal layout).
This commit solves this issue by changing its vertical size policy
from Ignored to Fixed.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-23 18:32:10 +02:00
Nextcloud bot
7b2ef2f41e
[tx-robot] updated from transifex
2020-05-23 03:27:12 +00:00
István Váradi
77c2048ff6
Merge pull request #2003 from ivaradi/debian-qt512
...
Do not build master for distributions without Qt 5.12 or later
2020-05-22 18:46:30 +02:00
Nextcloud bot
d53121c6ad
[tx-robot] updated from transifex
2020-05-22 03:28:53 +00:00
István Váradi
81682b4cbe
Do not build master for distributions without Qt 5.12
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-05-21 21:01:57 +02:00
Kevin Ottens
89316ced9e
Merge pull request #1987 from sbeyer/fix-leaks
...
Fix a few leaks
2020-05-21 17:12:04 +02:00
Kevin Ottens
c3ad79ba91
Merge pull request #2001 from nextcloud/sbeyer-member-tidy
...
Use default member initialization
2020-05-21 17:10:48 +02:00
Nextcloud bot
9d10671cea
[tx-robot] updated from transifex
2020-05-21 03:28:21 +00:00
Stephan Beyer
faeb233a74
Use default member initializers in OCC::FolderStatusModel sub-structs
...
This allows to remove their explicit default constructor definitions.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 01:45:13 +02:00
Stephan Beyer
04a24c14a8
Use default member initializers in OCC::SyncJournalErrorBlacklistRecord
...
This allows to remove its explicit default constructor definition.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 01:41:33 +02:00
Stephan Beyer
3015ea5715
Use default member initializers in OCC::SyncJournalDb sub-structs
...
This allows to remove their explicit default constructor definitions.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 01:32:16 +02:00
Stephan Beyer
f275640343
Fix leak in OCC::AccountManager stub for FolderManTest
...
We simply use a static QObject using Q_GLOBAL_STATIC()
instead of allocating a leaking QObject on the heap.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 01:22:15 +02:00
Stephan Beyer
8bc1525df5
Fix leak in Systray
...
The member _trayEngine, allocated in the constructor, was leaking.
This commit sets the Systray instance as the Qt object tree parent of
the _trayEngine to fix the leak.
While at it, a few unused header includes have been removed.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 01:22:15 +02:00
Stephan Beyer
eaf4aa0e5b
Fix leak in CloudProviderManager
...
The member _map, allocated in the constructor, was leaking.
The ad-hoc way to fix the leak would have been to add a destructor
that deletes _map. However, there is no good reason why _map has
to be a pointer to a QMap (instead of a QMap).
Hence this commit changes the type of the _map member from a QMap
pointer to a QMap.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 01:22:15 +02:00
Stephan Beyer
71a474129b
Fix leak in CloudProviderWrapper
...
The member _recentlyChanged, allocated in the constructor, was leaking.
The ad-hoc way to fix the leak would have been to add a destructor
that deletes _recentlyChanged. However, there is no good reason why
_recentlyChanged has to be a pointer to a QList (instead of a QList).
Hence this commit changes the type of the _recentlyChanged member
from a QList pointer to a QList.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 01:22:15 +02:00
Stephan Beyer
15bdfa9fbf
Use default member initializers in OCC::FolderDefinition
...
Using default member initializers (available since C++11) in
OCC::FolderDefinition allows to remove its explicit default
constructor, which is favorable.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 00:56:26 +02:00
Stephan Beyer
ff192e48d0
Remove unused member in OCC::FolderDefinition
...
OCC::FolderDefinition has a member called isClientSideEncrypted
that was introduced by commit 9318c487b9 but has not been used
in any way since.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-21 00:56:06 +02:00
Kevin Ottens
5543e4d834
Don't use int literals for bools
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-20 13:52:58 +02:00
Dominique Fuchs
e9a82dff77
Merge remote-tracking branch 'origin/master' into traywindow-listview-actions
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-05-20 10:48:46 +02:00
Nextcloud bot
7c5dbdd004
[tx-robot] updated from transifex
2020-05-20 03:25:52 +00:00
Michael Schuster
ef7d268a63
Merge pull request #1990 from nextcloud/use_auto_to_avoid_duplicated_type_names
...
Use auto to avoiding repeating type names
2020-05-20 04:14:14 +02:00
Michael Schuster
7804b8e006
Fix spacing
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-05-20 03:57:33 +02:00
Kevin Ottens
712869db9a
Use auto to avoiding repeating type names
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-20 03:54:41 +02:00
Michael Schuster
3d2de4fc40
Merge pull request #1989 from nextcloud/remove_redundant_virtual
...
Remove useless virtual, better use override only
2020-05-20 03:27:45 +02:00
Michael Schuster
1f2bfc0f42
Merge pull request #1988 from nextcloud/nullptr_everywhere
...
Use nullptr when appropriate
2020-05-20 02:55:15 +02:00
Michael Schuster
6559ba46bb
Merge pull request #1992 from NeroBurner/patch-1
...
Update github links to desktop repository
2020-05-20 02:53:00 +02:00
Michael Schuster
7fd431b50f
Use the default parameter: QUrl::path(QUrl::PrettyDecoded = 0x000000)
...
Change it to path() to be consistent with the other usages in the project :)
See: https://doc.qt.io/qt-5/qurl.html#path
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-05-20 02:30:45 +02:00
Kevin Ottens
dea6ebaa35
Use nullptr when appropriate
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-20 02:21:26 +02:00
Michael Schuster
0c040c9686
Merge pull request #1986 from nextcloud/properly_handle_denormalized_href_path
...
Properly handle denormalized href
2020-05-20 01:31:34 +02:00
Dominique Fuchs
9bfcdbae3a
More code cleanupand style-preference adjustments.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-05-20 00:09:41 +02:00
Dominique Fuchs
aa13aa533a
Removed publiclink param and corresponding if branch.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-05-19 23:29:59 +02:00
Dominique Fuchs
fa9dddf567
Code cleanup and this-> removals.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-05-19 23:25:21 +02:00
Reinhold Gschweicher
6ba59c9a9b
Update github links to desktop repository
...
Update the issue and open PR links with the new repository URL.
The old URL is forwarded, but feels not completely right.
Signed-off-by: Reinhold Gschweicher <pyro4hell@gmail.com >
2020-05-19 21:33:37 +02:00
Michael Schuster
1f402e3482
Merge pull request #1994 from nextcloud/cleanup_stale_files
...
Remove now unused Qt patch files
2020-05-19 20:45:05 +02:00
Kevin Ottens
35d1b8b820
Merge pull request #1991 from sbeyer/improve-sanitizer-support
...
Improve sanitizer support
2020-05-19 20:21:40 +02:00
Kevin Ottens
cd5db46036
Remove now unused files
...
Those files all refer to Qt version older than 5.12, also they seemed
unused for a while now.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-19 19:43:35 +02:00
Michael Schuster
2744146101
Merge pull request #1979 from nextcloud/bump_qt_dependency_to_5_12
...
Stop supporting Qt older than 5.12
2020-05-19 18:57:28 +02:00
Stephan Beyer
7f598b181e
Add -fno-sanitize=vptr for SANITIZE_UNDEFINED=ON
...
The UndefinedBehaviorSanitizer includes the "vptr" check. This
check, however, needs typeinfo for OCC::AccountManager because
otherwise its stub for FileManTest leads to undefined references
when linking. Adding the -frtti flag to enable run-time typeinfo
did not solve the problem. I do not know another solution, so this
commit disables the vptr check.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-19 10:57:58 +02:00
Stephan Beyer
00574ef8b4
Make sanitizer options more fine-grained
...
The SANITIZE_ADDRESS option of our CMake configuration activates the
AddressSanitizer (and UBSan in a non-working way) for the whole project
(although, by the way, its documentation pretends that it is only enabled
for tests).
This commit introduces new options SANITIZE_LEAK, SANITIZE_MEMORY,
SANITIZE_UNDEFINED, SANITIZE_THREAD. Each of these options (including
SANITIZE_ADDRESS) enables only the corresponding sanitizer.
Moreover, we mark all sanitizer options as advanced options, because these
options are only interesting for developers.
Note that some sanitizers are conflicting, that is, not all options can
be enabled simultaneously. Also, not all sanitizers are available for
all compilers and versions. We, however, do not check for this, instead
we let the compiler throw its errors in such cases.
The explicit usage of the Google Linker is removed, because it is not
necessary and can lead to problems with clang.
The commit can be considered a rewrite of cmake/modules/SanitizerFlags.cmake.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net >
2020-05-19 10:57:02 +02:00
Nextcloud bot
b7517e9082
[tx-robot] updated from transifex
2020-05-19 03:24:08 +00:00
Kevin Ottens
9328a4bba3
Remove useless virtual, better use override only
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-18 20:45:20 +02:00
Kevin Ottens
4d1ff01654
Properly handle denormalized href
...
In case of denormalized paths in the dav href (presence of . or .. in
the path) simple string startsWith comparison wasn't enough to know if
said href ended up in the right namespace. That's why we're now using
QUrl (pretending local file since we don't have a full URL in the href)
to normalize the path before comparison.
This could happen with broken proxies for instance where we would
wrongly validate the dav information resulting in potentially surprising
syncing and name collisions.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-18 19:33:34 +02:00
Nextcloud bot
8f1b10ea70
[tx-robot] updated from transifex
2020-05-18 03:22:51 +00:00
Nextcloud bot
9a5d3ede18
[tx-robot] updated from transifex
2020-05-17 03:23:33 +00:00
Nextcloud bot
bfeb408a8c
[tx-robot] updated from transifex
2020-05-16 03:24:46 +00:00
Nextcloud bot
34c9eea413
[tx-robot] updated from transifex
2020-05-15 03:24:34 +00:00
Kevin Ottens
3867e73fd5
Stop supporting Qt older than 5.12
...
This both removes older Qt from the CI and also adjust all the
find_package calls in CMakeLists.txt
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-14 21:15:45 +02:00
Nextcloud bot
57ad12f3d2
[tx-robot] updated from transifex
2020-05-14 03:25:33 +00:00
Nextcloud bot
7cb7678dd4
[tx-robot] updated from transifex
2020-05-13 03:24:15 +00:00
Michael Schuster
4788f5032c
Merge pull request #1974 from nextcloud/dont_silently_kill_debug
...
Don't silently kill debug messages
2020-05-12 19:29:54 +02:00
Michael Schuster
a786c3a972
Merge pull request #1972 from nextcloud/fix_fileutil_leak
...
Fix leak in FileUtil::IsChildFile
2020-05-12 17:33:24 +02:00
Kevin Ottens
9000a880cb
Don't silently kill debug messages
...
The message handler globally installed by the logger silently drop
messages if the logger is not logging. On top of it, it doesn't log
debug messages by default.
Anything not logged is currently silently discarded. This can come as a
surprise to a developer trying to contribute for the first time and
adding some debug message for some reason.
We're thus trying to strike a middle ground which is that debug messages
get a regular output if the logger isn't interested in them.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-12 17:33:13 +02:00
Kevin Ottens
bfdb1e730a
Fix leak in FileUtil::IsChildFile
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-12 14:32:34 +02:00
Nextcloud bot
d2b4d1de4b
[tx-robot] updated from transifex
2020-05-12 03:23:08 +00:00
Nextcloud bot
8bd1ce2a3d
[tx-robot] updated from transifex
2020-05-11 03:24:25 +00:00
Nextcloud bot
56b067bbb9
[tx-robot] updated from transifex
2020-05-10 03:25:39 +00:00
Michael Schuster
afae7606cf
Merge pull request #1965 from ivaradi/drop-xenial
...
Do not build for Xenial anymore
2020-05-08 20:11:09 +02:00
István Váradi
697d303259
Do not build for Xenial anymore.
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-05-08 19:47:43 +02:00
Kevin Ottens
66d69bf197
Merge pull request #1961 from nextcloud/tray_window_is_dialog
...
Indicate this is a dialog and not a regular window
2020-05-07 13:05:40 +02:00
Kevin Ottens
3b6ab2fa5a
Indicate this is a dialog and not a regular window
...
This is necessary with some window managers which would otherwise
consider they can reposition and resize the tray window as they wish
(yes, even though the user can't do it directly).
This is for instance the case if you use the tiling mode scripts of
KWin. It automatically ignores dialogs but might force windows to be
fullscreen (which would badly break the layout in our case).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-07 09:39:08 +02:00
Kevin Ottens
f47b68b96c
Merge pull request #1962 from nextcloud/fix_svg_icon_loading
...
Force the default QQC2 style
2020-05-07 07:26:39 +02:00
Nextcloud bot
f0758c96aa
[tx-robot] updated from transifex
2020-05-07 03:24:41 +00:00
Kevin Ottens
de7021e85e
Force the default QQC2 style
...
This works around a bug in KDE's qqc2-desktop-style which breaks buttons
with icons not based on a name. By forcing a style name the KDE Plasma
platformtheme plugin won't try to force qqc2-desktops-style anymore.
Can be removed once the bug in qqc2-desktop-style is gone.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-05-07 02:07:02 +02:00
Michael Schuster
590d0f25b5
Merge pull request #1963 from nextcloud/drone-remove-qt-5.7-and-5.8
...
Drone: Remove CI builds for Qt 5.7 and 5.8
2020-05-07 01:45:46 +02:00
Michael Schuster
244c8fa995
Drone: Remove CI builds for Qt 5.7 and 5.8
...
Housekeeping and the new 2.7 Tray builds need at least Qt 5.9
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-05-07 01:17:36 +02:00
Michael Schuster
cd8762f2c1
Merge pull request #1957 from nextcloud/backport/1954/master
...
[master] Fix typos.
2020-05-04 20:41:42 +02:00
Michael Schuster
5f75231cf6
Merge pull request #1949 from veddox/master
...
Resolve symlinks when checking for registered paths.
2020-05-04 20:17:48 +02:00
Sandro Knauß
6cdae6c19e
Fix typos.
...
Debian has a list of known typos in their checking tools.
Signed-off-by: Sandro Knauß <hefee@debian.org >
2020-05-04 18:11:36 +00:00
Michael Schuster
0082ff90df
Merge pull request #1955 from ivaradi/debian-cleanup
...
Remove unnecessary Debian build files
2020-05-04 19:57:19 +02:00
Michael Schuster
684f061ab1
Merge pull request #1956 from nextcloud/update-changelog
...
Update ChangeLog with 2.6 series.
2020-05-04 19:42:28 +02:00
Camila San
c14761445b
Update ChangeLog with 2.6 series.
2020-05-04 17:45:13 +02:00
István Váradi
4f3ea3ae66
Remove unnecessary Debian build files
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-05-04 16:40:26 +02:00
Nextcloud bot
d7841fd9b1
[tx-robot] updated from transifex
2020-05-04 03:22:43 +00:00
Nextcloud bot
8133897d1a
[tx-robot] updated from transifex
2020-05-03 03:22:41 +00:00
Daniel Vedder
0d71d03d7b
Fixed symlink resolution for menu items.
...
Signed-off-by: Daniel Vedder <d.vedder@web.de >
2020-05-02 17:03:21 +02:00
Daniel Vedder
0743a0b502
Resolve symlinks when checking for registered paths.
...
Fixes issue #1948 : https://github.com/nextcloud/desktop/issues/1948
The client already resolves symlinks when adding new paths to the
sync-list, but the Nautilus plugin did not do this yet, causing it
to not recognise synced folders if they were accessed via a symlink.
Signed-off-by: Daniel Vedder <d.vedder@web.de >
2020-05-02 14:48:51 +02:00
Nextcloud bot
7193d2ffba
[tx-robot] updated from transifex
2020-05-02 03:23:10 +00:00
István Váradi
4729e5272a
Merge pull request #1896 from ivaradi/debian-new
...
Reorganize Debian build
2020-05-01 11:15:07 +02:00
Nextcloud bot
1c53126340
[tx-robot] updated from transifex
2020-05-01 03:27:29 +00:00
Nextcloud bot
e6eb13915f
[tx-robot] updated from transifex
2020-04-30 03:26:57 +00:00
Nextcloud bot
6ddce0a90a
[tx-robot] updated from transifex
2020-04-29 03:23:26 +00:00
Nextcloud bot
7c8de2bb40
[tx-robot] updated from transifex
2020-04-28 03:24:02 +00:00
István Váradi
230b2f3781
Add Groovy build
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-04-27 19:20:40 +02:00
István Váradi
46c1d7f298
Allow specifying the base commit and version in the configuration file
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-04-27 19:20:30 +02:00
István Váradi
7b2de328a2
Change Debian build to the new more Debian-y way
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-04-27 19:19:04 +02:00
István Váradi
47824c104e
Merge pull request #1895 from ivaradi/debian-version
...
Debian versioning updates
2020-04-27 17:00:37 +02:00
Dominique Fuchs
671961e641
Added share icon from nc server repo, changed corresp. btn icon
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-04-27 08:06:58 +02:00
Nextcloud bot
22f839bbe9
[tx-robot] updated from transifex
2020-04-27 03:22:26 +00:00
István Váradi
ae48a41510
Merge pull request #1943 from ivaradi/groovy
...
Add Groovy-specific files
2020-04-26 16:42:04 +02:00
István Váradi
8345d47cc5
Add Groovy-specific files
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-04-26 10:08:58 +02:00
István Váradi
e41e7de404
Merge pull request #1942 from ivaradi/disco-groovy
...
Remove Ubuntu Disco, add Groovy
2020-04-26 09:24:53 +02:00
István Váradi
b389eed6b0
Remove Ubuntu Disco, add Groovy
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-04-26 08:40:37 +02:00
Nextcloud bot
b0f788415f
[tx-robot] updated from transifex
2020-04-26 03:23:13 +00:00
Dominique Fuchs
3626715394
Merge pull request #1884 from nicolasfella/menuaction
...
[dolphin] Use menuAction() instead of manual creation
2020-04-25 14:57:32 +02:00
Dominique Fuchs
c77bf6c634
Merge pull request #1919 from taaem/fix-dbus-activation
...
CloudProviders: Use absolute path in dbus file
2020-04-25 13:43:42 +02:00
Dominique Fuchs
1c21bfdd7c
Merge pull request #1922 from taaem/fix-recent-files
...
Fix cloudprovider crashing - don't clear the _recentMenu pointer
2020-04-25 13:37:29 +02:00
Dominique Fuchs
061ca2d713
Merge branch 'master' into menuaction
2020-04-25 13:18:10 +02:00
Dominique Fuchs
ddee26084d
Merge pull request #1937 from ivaradi/xenial-compat
...
Qt 5.5 compatibility #ifdef
2020-04-25 12:23:25 +02:00
Dominique Fuchs
6df75328fd
Merge pull request #1893 from nicolasfella/override
...
override specifier missing
2020-04-25 12:18:56 +02:00
Dominique Fuchs
79eface432
Merge pull request #1887 from nicolasfella/colon
...
[dolphin] Fix overlays when filename has a colon
2020-04-25 12:17:29 +02:00
Dominique Fuchs
210253ce35
Merge pull request #1889 from nicolasfella/applicationengine
...
Use QQmlApplicationEngine instead of QQmlEngine
2020-04-25 12:15:33 +02:00
Dominique Fuchs
4bd5e9d79b
Implemented share functionality in tray window and changed actions / button logic.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-04-25 10:17:53 +02:00
Nextcloud bot
c126f1a540
[tx-robot] updated from transifex
2020-04-24 03:39:24 +00:00
István Váradi
3d44a71755
Qt 5.5 compatibility #ifdef
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-04-23 20:22:30 +02:00
Nextcloud bot
0514fdd933
[tx-robot] updated from transifex
2020-04-23 03:29:16 +00:00
Nextcloud bot
e961eac5c1
[tx-robot] updated from transifex
2020-04-22 03:25:56 +00:00
Nextcloud bot
90dd893ddd
[tx-robot] updated from transifex
2020-04-21 03:24:07 +00:00
Nextcloud bot
ebfe796ad8
[tx-robot] updated from transifex
2020-04-18 03:23:49 +00:00
Michael Schuster
60684da95d
Merge pull request #1933 from nicolasfella/fixdolphin
...
Fix build of Dolphin integration
2020-04-17 20:03:47 +02:00
Nicolas Fella
d077c7884e
Fix build of Dolphin integration
...
config.h needs to be included in the header already since we use APPLICATION_ICON_NAME there. This got introduced in 6fc877577c
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-04-17 12:48:10 +02:00
Nextcloud bot
870f336a4c
[tx-robot] updated from transifex
2020-04-17 03:24:03 +00:00
Nextcloud bot
685379beac
[tx-robot] updated from transifex
2020-04-16 03:27:37 +00:00
Michael Schuster
6fc877577c
[dolphin] Use CMake env vars for App Name and Icon strings
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-04-16 03:47:24 +02:00
Michael Schuster
6e220b10e4
Merge pull request #1883 from nicolasfella/contexticon
...
[dolphin] Add icon to context menu
2020-04-16 02:52:34 +02:00
Michael Schuster
45342d7952
Merge pull request #1882 from nicolasfella/detach
...
Fix container detaching
2020-04-15 21:28:51 +02:00
Michael Schuster
d0b698ed37
Merge pull request #1881 from nicolasfella/envempty
...
Use qEnvironmentVariableIsEmpty
2020-04-15 17:52:09 +02:00
Michael Schuster
ef42635c23
Merge pull request #1880 from nicolasfella/timeout
...
Remove timeout parameter from showMessage
2020-04-15 17:28:02 +02:00
Michael Schuster
92afba538f
Merge pull request #1879 from nicolasfella/desktopentry
...
Add desktop-entry hint to notifications
2020-04-15 17:15:48 +02:00
Nextcloud bot
159218d5ae
[tx-robot] updated from transifex
2020-04-15 03:28:13 +00:00
Nicolas Fella
29fa924853
Use LINUX_APPLICATION_ID
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-04-14 21:38:33 +02:00
Nextcloud bot
54d862436e
[tx-robot] updated from transifex
2020-04-14 03:27:25 +00:00
Nextcloud bot
2c6628158f
[tx-robot] updated from transifex
2020-04-13 03:42:45 +00:00
Nextcloud bot
8d76b88edb
[tx-robot] updated from transifex
2020-04-11 03:30:49 +00:00
Tim Klocke
8b4abddb71
CloudProviders: Use absolute path in dbus file
2020-04-10 23:09:05 +02:00
Tim Klocke
18615d0297
CloudProviders: Don't clear the _recentMenu pointer
...
The _recentMenu pointer ref should not be freed, when building the
menu.
This fixes #1920 and #1818
2020-04-10 23:08:07 +02:00
Nextcloud bot
f1ffc16d86
[tx-robot] updated from transifex
2020-04-10 03:31:12 +00:00
Nextcloud bot
151224f12e
[tx-robot] updated from transifex
2020-04-09 03:31:03 +00:00
Nextcloud bot
49e1338087
[tx-robot] updated from transifex
2020-04-08 03:31:13 +00:00
Nextcloud bot
80c8bc760f
[tx-robot] updated from transifex
2020-04-06 03:27:52 +00:00
Nextcloud bot
98a2740ca0
[tx-robot] updated from transifex
2020-04-05 03:27:09 +00:00
Nextcloud bot
1fad22596f
[tx-robot] updated from transifex
2020-04-04 03:27:46 +00:00
Nextcloud bot
3359b019c3
[tx-robot] updated from transifex
2020-04-03 03:20:10 +00:00
Nextcloud bot
e2c8ff9295
[tx-robot] updated from transifex
2020-04-02 03:19:13 +00:00
Nextcloud bot
7a68565268
[tx-robot] updated from transifex
2020-04-01 03:20:04 +00:00
Nextcloud bot
6b74e8b969
[tx-robot] updated from transifex
2020-03-31 03:31:20 +00:00
Nextcloud bot
aa3ad18221
[tx-robot] updated from transifex
2020-03-30 03:30:26 +00:00
Nextcloud bot
9189d7f1ab
[tx-robot] updated from transifex
2020-03-29 03:36:20 +00:00
Nextcloud bot
20cf9c8b57
[tx-robot] updated from transifex
2020-03-28 03:31:03 +00:00
Nextcloud bot
8aea96a640
[tx-robot] updated from transifex
2020-03-27 03:29:32 +00:00
Nextcloud bot
732d59ad14
[tx-robot] updated from transifex
2020-03-26 03:26:14 +00:00
István Váradi
5d2e99d15c
Generate alpha, beta and stable versions
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-03-24 19:06:16 +01:00
István Váradi
19a58ed9c8
Generate more unique and ordered version numbers for Debian builds
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-03-24 19:06:07 +01:00
Nextcloud bot
56222de768
[tx-robot] updated from transifex
2020-03-24 03:29:21 +00:00
Nextcloud bot
56679299dd
[tx-robot] updated from transifex
2020-03-23 03:27:02 +00:00
Nicolas Fella
b4d1a63c14
Use override
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-22 21:58:15 +01:00
Nicolas Fella
d54add6233
Use QQmlApplicationEngine
...
This simplifies the code a bit.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-22 16:14:56 +01:00
Nextcloud bot
2aa3dfa9c0
[tx-robot] updated from transifex
2020-03-22 03:27:18 +00:00
Nicolas Fella
20b7e938c5
[dolphin] Fix overlays when filename has a colon
...
When the filename contains a ':' it gets split too much and tokens[2] does not contain the full filename any more. Read the name from the original line instead.
Fixes #686
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-21 15:38:27 +01:00
Nextcloud bot
db8b304608
[tx-robot] updated from transifex
2020-03-21 03:28:46 +00:00
Nicolas Fella
a482e3c834
[dolphin] Don't manually create menuAction
...
Use menuAction() from QMenu
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-21 02:09:48 +01:00
Nicolas Fella
e1f4d17446
[dolphin] Add icon to context menu
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-21 02:04:42 +01:00
Nicolas Fella
1afda2b875
Fix container detaching
...
Found by clazy
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-21 01:24:37 +01:00
Nicolas Fella
c1189421c0
Use qEnvironmentVariableIsEmpty
...
clazy suggests that it is more efficient since it doesn't allocate.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-21 01:06:15 +01:00
Nicolas Fella
b84a1eeb8d
Remove timeout parameter from showMessage
...
It it never set by calling code so the default value of 10000 is used. It is only used in the call to QSystemTrayIcon, which uses 10000 as default value too.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-21 00:40:40 +01:00
Nicolas Fella
2f54e911b7
Add desktop-entry hint to notifications
...
This allows the notification server to map a notification to the program's desktop file, which allows the server to do extra things. For example KDE Plasma adds the Nextcloud icon to the notification and allows to configure notifications from Nextcloud.
This is a standard hint from https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html#hints
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-03-21 00:25:33 +01:00
Nextcloud bot
3ca586c464
[tx-robot] updated from transifex
2020-03-18 03:30:27 +00:00
Nextcloud bot
6cc9a55833
[tx-robot] updated from transifex
2020-03-17 03:32:02 +00:00
Nextcloud bot
9da7f4eaa4
[tx-robot] updated from transifex
2020-03-16 03:33:08 +00:00
Nextcloud bot
43da96b3dc
[tx-robot] updated from transifex
2020-03-15 03:31:47 +00:00
Nextcloud bot
af44c430cf
[tx-robot] updated from transifex
2020-03-14 03:26:40 +00:00
Nextcloud bot
bc40e358b0
[tx-robot] updated from transifex
2020-03-13 03:26:47 +00:00
István Váradi
8ee6b0dab2
Provide specific install file for Debian oldstable
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-03-12 07:53:00 +01:00
Nextcloud bot
75259b24f3
[tx-robot] updated from transifex
2020-03-12 03:27:31 +00:00
Nextcloud bot
7a2f8b75c2
[tx-robot] updated from transifex
2020-03-11 03:28:31 +00:00
Michael Schuster
d2d9d29b55
Merge pull request #1848 from nextcloud/fix-webview-missing-qobjects
...
WebView: Add missing Q_OBJECT macros
2020-03-11 01:46:31 +01:00
Michael Schuster
102369bfbe
WebView: Add missing Q_OBJECT macros
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-11 01:18:11 +01:00
Michael Schuster
37f9e62993
Merge pull request #1853 from nextcloud/fix/test-updater
...
Updater: Fix Tests build (failed with BUILD_UPDATER=NO)
2020-03-10 23:41:06 +01:00
Michael Schuster
5f42813d98
Updater: Fix Tests build (failed with BUILD_UPDATER=NO)
...
Also don't build the test for the updater, fix missing updater library.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-10 22:10:45 +01:00
Michael Schuster
78776f81e4
Merge pull request #1847 from nextcloud/enh/updater
...
Updater: Enhance UI, make build optional
2020-03-10 15:53:47 +01:00
Michael Schuster
f629e83203
Merge pull request #1843 from nextcloud/enh/version-info
...
Enhance Version info display (minimal info, hide details)
2020-03-10 15:52:50 +01:00
Nextcloud bot
74562f2597
[tx-robot] updated from transifex
2020-03-10 03:28:10 +00:00
Nextcloud bot
0bf6e5e53c
[tx-robot] updated from transifex
2020-03-09 03:22:27 +00:00
Michael Schuster
e833e86da6
Updater: Add CMake option BUILD_UPDATER to make the updater optional
...
- Default: BUILD_UPDATER = NO
To ease builds for distro packages and contributors (regardless of the specified update URL)
- Enable updater build for Drone CI and AppImage builds
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-09 02:34:55 +01:00
Michael Schuster
c812d896aa
Fix OCUpdater: Also change status on network error or invalid XML
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-09 02:34:55 +01:00
Michael Schuster
c043a4e55c
Updater UI: Implement auto-update option and update button
...
- Add checkbox and button to UI
- Add new parameter autoUpdateCheck to ConfigFile
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-09 02:34:55 +01:00
Michael Schuster
555b41f300
Fix Legal notice dialog: Correct title and header font
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-09 00:41:59 +01:00
Nextcloud bot
4ae16d92ac
[tx-robot] updated from transifex
2020-03-08 03:27:56 +00:00
Michael Schuster
d8c407ac97
Settings dialog: Move detailed version info from About section to Legal notice dialog
...
- Enlarge dialog widget to show full content
- Implement Dark-/Light-Mode switching (hyperlinks)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-07 06:45:41 +01:00
Michael Schuster
2adde0fcca
Settings dialog About section: Show minimal version info
...
- Application name, version number, OS
Example: Nextcloud Desktop Client
Version 2.6.4 (macOS)
- Keep previous version info in new method Theme::aboutDetails()
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-07 06:38:09 +01:00
Michael Schuster
a471868d88
Version parameter: Show Qt platform plugin, OS and CPU arch
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-07 06:31:14 +01:00
Michael Schuster
6685722cb3
Add missing --version parameter to help screen
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-07 06:20:00 +01:00
Nextcloud bot
6a0ee0cee5
[tx-robot] updated from transifex
2020-03-07 03:26:06 +00:00
Nextcloud bot
aa5556b7d0
[tx-robot] updated from transifex
2020-03-06 03:28:47 +00:00
Michael Schuster
275fe95895
Merge pull request #1834 from cclauss/python3-issues
...
Use print() function in both Python 2 and Python 3
2020-03-06 02:55:17 +01:00
Michael Schuster
0e60bf7c82
Merge pull request #1838 from nextcloud/enh/share_circles
...
Allow sharing to circles: https://github.com/nextcloud/circles
2020-03-06 02:17:36 +01:00
István Váradi
87c920cbf2
Merge pull request #1836 from ivaradi/focal
...
Added Focal-specific files
2020-03-05 17:03:00 +01:00
István Váradi
9a23210e59
Added Focal-specific files
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-03-05 14:37:41 +01:00
cclauss
b34ed01109
Use print() function in both Python 2 and Python 3
...
Signed-off-by: cclauss <cclauss@me.com >
2020-03-05 11:35:30 +01:00
Roeland Jago Douma
3776a04206
Allow sharing to circles
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-03-05 10:44:06 +01:00
Nextcloud bot
76e4a2646a
[tx-robot] updated from transifex
2020-03-05 03:28:48 +00:00
Michael Schuster
398c5a2a37
Merge pull request #1832 from ivaradi/focal
...
Added build for Focal
2020-03-05 02:45:25 +01:00
István Váradi
744d527300
Added build for Focal
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-03-04 20:47:03 +01:00
Nextcloud bot
5ef08a51b2
[tx-robot] updated from transifex
2020-03-03 19:25:22 +00:00
Michael Schuster
601804b78c
Merge pull request #1829 from nextcloud/fix-explorer-pinning
...
Fix Explorer pinning: Add fallbacks for Shell commands (fixes #1599 )
2020-03-03 20:12:32 +01:00
Christian Kamm
a704cca090
Windows: Fix context menu handling only own verbs #7004
...
Previously it'd handle all verbs as if they were our own.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-03 18:56:09 +01:00
Michael Schuster
ff642085b4
Fix Explorer pinning: Add fallbacks for Shell commands ( fixes #1599 )
...
See: #1599
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-03 18:45:58 +01:00
Michael Schuster
377526d6f9
Merge pull request #1827 from nextcloud/fix-webflow-username-case
...
WebFlowCredentials: Make username comparison case-insensitive (fix #1741 )
2020-03-03 06:25:35 +01:00
Michael Schuster
ab1099f13e
WebFlowCredentials: Make username comparison case-insensitive ( fix #1741 )
...
Fixes issue #1741
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-03 06:01:27 +01:00
Nextcloud bot
3edcd2a578
[tx-robot] updated from transifex
2020-03-03 03:28:18 +00:00
Michael Schuster
c6b59c5e58
Merge pull request #1826 from nextcloud/fix/qml-tray-msvc-warnings-1
...
Fix MSVC warnings: Missing return value, cast type
2020-03-03 02:38:26 +01:00
Michael Schuster
aab735a595
Fix MSVC warnings: Missing return value, cast type
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-03 02:08:37 +01:00
Bruno Perel
7378ae6a7f
Fix git merge hiccup
2020-03-02 08:05:37 +01:00
Nextcloud bot
68ee513bd0
[tx-robot] updated from transifex
2020-03-02 03:26:20 +00:00
Michael Schuster
7fa44d438d
Merge pull request #1823 from nextcloud/fix-http2-disable
...
Disable HTTP/2 for now due to Qt bug, allow enabling it via env var
2020-03-02 03:26:43 +01:00
Michael Schuster
f90f31756a
Fix build with older Qt: Disable http2 for now due to Qt bug, add env var (upstream)
...
Disable http2 for now due to Qt bug but allow enabling it via env var, see: https://github.com/owncloud/client/pull/7620
and: https://github.com/nextcloud/desktop/pull/1806
Issue: https://github.com/nextcloud/desktop/issues/1503
Co-authored-by: XNG <Milokita@users.noreply.github.com >
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com >
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-02 01:47:00 +01:00
XNG
e2066b317b
Disable http2 for now due to Qt bug
...
So that user may continue to use http2 on their webpage
Signed-off-by: XNG <Milokita@users.noreply.github.com >
(cherry picked from commit dad95d4e4617211360bf2b4391e29c341e939844)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-02 01:27:04 +01:00
Michael Schuster
eb7ed33d98
Merge pull request #1744 from nextcloud/qt-traygeometry-workaround
...
Fix wrong window position on some linux DEs - worked around invalid g…
2020-03-01 07:07:47 +01:00
Michael Schuster
deb90a6ba1
Merge pull request #1739 from nextcloud/qml-singleton-style
...
Outsourcing qml styling into own, centralized module
2020-03-01 07:06:20 +01:00
Michael Schuster
b846e25ddb
further resource cleanup: remove theme/settings@2x.png
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-01 06:51:00 +01:00
Michael Schuster
712fef0cac
Merge branch 'master' into qml-singleton-style and fix merge conflict
...
Migrate changes in client.qrc to resources.qrc
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-01 06:47:46 +01:00
Michael Schuster
318c749558
Merge pull request #1736 from nextcloud/resource-cleanup
...
Resource cleanup and application-wide svg usage
2020-03-01 06:11:17 +01:00
Michael Schuster
662fbb7b2a
Merge pull request #1820 from nextcloud/fix-explorer-integration-2
...
Fix Explorer integration re-save and hide option on non-Windows
2020-03-01 05:43:49 +01:00
Michael Schuster
5b2877a63e
Merge branch 'master' into resource-cleanup
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-01 05:34:12 +01:00
Michael Schuster
29e02d0579
owncloudsetuppage.cpp: adapt to string change from master: url -> URL
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-01 05:32:59 +01:00
Michael Schuster
a92a764c2a
owncloudsetuppage.cpp: also rename client/theme/lock-http(s) PNGs to SVG
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-01 05:12:59 +01:00
Nextcloud bot
2c88b46e26
[tx-robot] updated from transifex
2020-03-01 03:28:17 +00:00
Michael Schuster
40767f7ae0
Fix Explorer integration: Hide option on non-Windows
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-01 04:03:29 +01:00
Michael Schuster
f1dd312b2e
Fix Explorer integration re-save (fixes issue #1807 )
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-03-01 03:39:24 +01:00
Michael Schuster
bf838bd336
Merge pull request #1809 from sroracle/cmake-qml-quick
...
Fix cmake inclusion of Qml and Quick
2020-02-29 21:18:11 +01:00
Nextcloud bot
ce322fd39c
[tx-robot] updated from transifex
2020-02-29 03:27:40 +00:00
Nextcloud bot
c8e9aac4cf
[tx-robot] updated from transifex
2020-02-28 03:27:33 +00:00
Nextcloud bot
ac491aeb8b
[tx-robot] updated from transifex
2020-02-27 03:28:55 +00:00
Nextcloud bot
3b00bc3cde
[tx-robot] updated from transifex
2020-02-26 03:28:57 +00:00
Nextcloud bot
b3a9954fa8
[tx-robot] updated from transifex
2020-02-25 03:34:13 +00:00
Michael Schuster
67e2999f63
Merge pull request #1810 from nextcloud/rakekniven-patch-1
...
l10n: Changes to improve source strings
2020-02-24 21:07:12 +01:00
rakekniven
b936cc1f6e
l10n: Change spelling of "webdav"
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-24 11:14:34 +01:00
rakekniven
62bc9d025e
l10n: Removed colon from translation
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-24 11:13:34 +01:00
rakekniven
961c05363a
l10n: Removed blank before colon
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-24 11:10:05 +01:00
rakekniven
3f7cd5c0f3
l10n: Change case of one word
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-24 11:08:56 +01:00
Max Rees
3d3021e3b0
Fix cmake inclusion of Qml and Quick
...
Signed-off-by: Max Rees <maxcrees@me.com >
2020-02-23 23:44:54 -06:00
Nextcloud bot
b7b3601cc1
[tx-robot] updated from transifex
2020-02-24 03:30:44 +00:00
Nextcloud bot
366016ce3c
[tx-robot] updated from transifex
2020-02-23 03:30:53 +00:00
Nextcloud bot
eb419d54fa
[tx-robot] updated from transifex
2020-02-22 03:30:06 +00:00
Michael Schuster
5ab20d4ab1
Merge pull request #1802 from nextcloud/feature/update-segment
...
Updater: Add query-parameter 'updatesegment' to the update check
2020-02-21 23:39:10 +01:00
Michael Schuster
9c8a0204e5
Updater: Add query-parameter 'updatesegment' to the update check
...
Used to throttle down desktop release rollout in order to keep the update servers alive at peak times.
See: https://github.com/nextcloud/client_updater_server/pull/36
Targeted issues: #1795 , #1800
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-02-21 21:28:42 +01:00
Nextcloud bot
34e3d236f8
[tx-robot] updated from transifex
2020-02-21 12:45:31 +00:00
Nextcloud bot
67bc8fc529
[tx-robot] updated from transifex
2020-02-21 12:15:55 +00:00
Nextcloud bot
ac1e4d2bb1
[tx-robot] updated from transifex
2020-02-20 03:29:30 +00:00
Nextcloud bot
04d68018d6
[tx-robot] updated from transifex
2020-02-19 03:26:26 +00:00
Nextcloud bot
7bb3646781
[tx-robot] updated from transifex
2020-02-18 03:26:16 +00:00
Michael Schuster
5554488dd8
Merge pull request #1768 from nextcloud/umlaut-sync-fix
...
Fix wrong encoding when specifying extra header with if-match path
2020-02-17 01:49:48 +01:00
Nextcloud bot
39a48a17ef
[tx-robot] updated from transifex
2020-02-16 03:26:04 +00:00
Nextcloud bot
7dd903c9b6
[tx-robot] updated from transifex
2020-02-15 03:27:07 +00:00
Michael Schuster
cf209f4c10
Merge pull request #1782 from nextcloud/enh/quota-userinfo
...
Add UserInfo class and fetch quota via API instead of PropfindJob
2020-02-14 12:58:16 +01:00
Nextcloud bot
33896de943
[tx-robot] updated from transifex
2020-02-14 03:26:18 +00:00
Michael Schuster
3e255df533
Fix Tests linkage (missed UserInfo.cpp in CMakeLists.txt)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-02-14 03:12:37 +01:00
Michael Schuster
640655ea10
Code cleanup
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-02-14 03:00:20 +01:00
Michael Schuster
abfebcf291
Add UserInfo class and fetch quota via API instead of PropfindJob
...
The PropfindJob quota includes the size of shares and thus leads to confusion
in regard of the real space available, as shown in the UI.
This commit aims to streamline the behaviour with the Android and iOS apps,
which also utilize the API.
Details:
- Refactor the QuotaInfo class into UserInfo
- Use JsonApiJob (ocs/v1.php/cloud/user) instead of PropfindJob
- Let ConnectionValidator use the new UserInfo class to fetch
the user and the avatar image (to avoid code duplication)
- Allow updating the avatar image upon AccountSettings visibility,
using UserInfo's quota fetching
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-02-14 02:10:01 +01:00
Nextcloud bot
bbb310a853
[tx-robot] updated from transifex
2020-02-13 03:30:53 +00:00
Nextcloud bot
fd6eba287e
[tx-robot] updated from transifex
2020-02-12 03:25:47 +00:00
Nextcloud bot
8f2e853ec0
[tx-robot] updated from transifex
2020-02-11 03:29:04 +00:00
Nextcloud bot
8c287fcb6b
[tx-robot] updated from transifex
2020-02-10 03:29:23 +00:00
Nextcloud bot
f55f5f2e63
[tx-robot] updated from transifex
2020-02-09 03:28:11 +00:00
Nextcloud bot
ed9dd8b18a
[tx-robot] updated from transifex
2020-02-08 03:25:44 +00:00
Nextcloud bot
0bcf67c49c
[tx-robot] updated from transifex
2020-02-07 03:41:48 +00:00
Dominique Fuchs
6d23ce82d7
Merge pull request #1770 from nextcloud/rakekniven-patch-1
...
l10n: Changed grammar and triple dots to ellipsis
2020-02-06 08:17:38 +01:00
Dominique Fuchs
4b8b84f2dd
Merge pull request #1759 from nextcloud/fix/do_not_save_all_the_time
...
Do not save notes on text change
2020-02-06 07:49:28 +01:00
Dominique Fuchs
32ce9c76bc
Merge pull request #1765 from nextcloud/tintou/cloudproviders-background
...
Start the client in background if activated by D-Bus
2020-02-06 07:48:27 +01:00
Dominique Fuchs
8e67de3d3d
Merge pull request #1760 from Andre-Schuiki/patch-1
...
Update autoupdate.rst
2020-02-06 07:34:59 +01:00
Dominique Fuchs
e7b5cc8974
Merge pull request #1763 from nextcloud/tintou/cloudprovider-valid-dbus-path
...
Make sure that the libcloudprovider integration is using a valid D-Bus path
2020-02-06 07:17:35 +01:00
Nextcloud bot
8765908f65
[tx-robot] updated from transifex
2020-02-06 03:27:56 +00:00
rakekniven
da66b3956e
l10n: Changed grammar
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-05 06:55:51 +01:00
rakekniven
1988511c55
l10n: Triple dot to ellipsis
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-05 06:54:32 +01:00
rakekniven
abcadec94a
l10n: Triple dot to ellipsis
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-05 06:53:17 +01:00
rakekniven
8f82fc2e51
Triple dot to ellipsis
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-05 06:52:17 +01:00
rakekniven
f9d27e4e3b
l10n: Triple dot to ellipsis
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-02-05 06:50:27 +01:00
Nextcloud bot
b47a2f1b76
[tx-robot] updated from transifex
2020-02-05 03:28:00 +00:00
Nextcloud bot
de5cfbd384
[tx-robot] updated from transifex
2020-02-04 03:25:30 +00:00
rakekniven
32c2c062c0
l10n: Changed spelling of "user name" to "username"
...
Using "username" like on > 200 strings over the whole Nextcloud project.
Signed-off-by: rakekniven mark.ziegler@rakekniven.de
2020-02-03 10:42:37 +01:00
Nextcloud bot
9e59386560
[tx-robot] updated from transifex
2020-02-03 03:22:22 +00:00
Dominique Fuchs
c69aba9b44
Fix wrong encoding when specifying extra header with if-match path
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-02-02 13:35:16 +01:00
Nextcloud bot
f44c7f00bb
[tx-robot] updated from transifex
2020-02-02 03:23:37 +00:00
Corentin Noël
842f71891e
Start the client in background if activated by D-Bus
...
The nextcloud client can be started by any other application consuming libcloudproviers.
Make sure that the client won't pop-up if we open the file manager.
Signed-off-by: Corentin Noël <corentin.noel@collabora.com >
2020-02-01 16:04:02 +01:00
Nextcloud bot
5f34604b20
[tx-robot] updated from transifex
2020-02-01 03:24:07 +00:00
István Váradi
6485f63a60
Merge pull request #1764 from ivaradi/fix-xenial-cloudproviders
...
Do not install files related to cloud providers under Xenial
2020-01-31 10:06:56 +01:00
István Váradi
56a7a68de3
Do not install files related to cloud providers under Xenial
...
Signed-off-by: István Váradi <Istvan.Varadi@ericsson.com >
2020-01-31 08:41:11 +01:00
Nextcloud bot
2987851914
[tx-robot] updated from transifex
2020-01-31 03:22:31 +00:00
Corentin Noël
31d55c5c4e
Merge pull request #1729 from nextcloud/tintou/cloud-providers-debian-install
...
Install libcloudproviders files by default on debian
2020-01-30 21:09:55 +01:00
Corentin Noël
a7d6555de2
Make sure that the libcloudprovider integration is using a valid D-Bus path
...
Set a simple unique identifier per folder to ensure that it is always unique.
Fixes https://github.com/nextcloud/desktop/issues/1704
Signed-off-by: Corentin Noël <corentin@elementary.io >
2020-01-30 21:05:13 +01:00
rakekniven
dfdb872e7b
Changed product name to Nextcloud
...
Reported at Transifex.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-01-30 19:16:01 +01:00
Andre-Schuiki
4e83f3d525
Update autoupdate.rst
...
Hi, you have the wrong registry path in the documentation? (tested client version: 2.6.0 x64 build: 20190927)
The Nextcloud Client checks the path "HKEY_LOCAL_MACHINE\Software\Policies\Nextcloud GmbH\Nextcloud" not "HKEY_LOCAL_MACHINE\Software\Policies\Nextcloud\Nextcloud" under HKLM.
2020-01-30 10:12:56 +01:00
Nextcloud bot
37377bf470
[tx-robot] updated from transifex
2020-01-30 03:26:35 +00:00
Nextcloud bot
24ef0b3aa9
[tx-robot] updated from transifex
2020-01-29 03:26:58 +00:00
Roeland Jago Douma
bd9b0cf23f
Am empty note is not a valid note
...
Do not show the note edit field for empty new shares.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-01-28 12:46:15 +01:00
Roeland Jago Douma
d449912a0a
Do not save notes on text change
...
Only save notes on submit. Else you will get spammed with a ton of
requests (and possibly mails)
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-01-28 12:09:17 +01:00
Nextcloud bot
83733684f0
[tx-robot] updated from transifex
2020-01-28 03:28:37 +00:00
Nextcloud bot
f3c90436e7
[tx-robot] updated from transifex
2020-01-27 03:26:37 +00:00
Nextcloud bot
490af281af
[tx-robot] updated from transifex
2020-01-26 03:24:49 +00:00
Nextcloud bot
ecffff5a76
[tx-robot] updated from transifex
2020-01-25 03:24:23 +00:00
Nextcloud bot
6a8f3a1397
[tx-robot] updated from transifex
2020-01-24 03:24:11 +00:00
Nextcloud bot
afc6a41169
[tx-robot] updated from transifex
2020-01-22 03:27:43 +00:00
Michael Schuster
20f1a01219
Merge pull request #1745 from nextcloud/bugfix/noid/use-system-proxy-default
...
Use system proxy by default if no config file is present
2020-01-21 17:29:20 +01:00
Dominique Fuchs
0697c81ae6
Rewrite of screen selection logic, plus synamic screen selection Window.qml
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-21 13:54:04 +01:00
Dominique Fuchs
77be6729a2
Fix also screen selection for different Qt versions and for buggy linux DEs
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-21 12:16:24 +01:00
Julius Härtl
baf082df7c
Use system proxy by default if no config file is present
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2020-01-21 11:59:07 +01:00
Dominique Fuchs
f3062f6c96
Fix wrong window position on some linux DEs - worked around invalid geometry() returned by QT
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-21 09:55:26 +01:00
Nextcloud bot
5ad6f727f8
[tx-robot] updated from transifex
2020-01-21 03:26:23 +00:00
Nextcloud bot
04a08bfb23
[tx-robot] updated from transifex
2020-01-20 03:24:27 +00:00
Dominique Fuchs
bb757c6a27
Merge branch 'master' into resource-cleanup
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-19 20:44:59 +01:00
Dominique Fuchs
6593317afa
Merge branch 'master' into qml-singleton-style
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-19 20:43:36 +01:00
Dominique Fuchs
9deb51c846
Module styling also for UserLine.qml
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-19 20:40:49 +01:00
Dominique Fuchs
3a39e636ae
Introduced Style module
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-19 20:13:12 +01:00
Michael Schuster
03cddabfd0
Tray menu: Only show time ago (view too noisy)
...
Don't show date and time for now, rather as a tool tip later.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-19 19:12:34 +01:00
Michael Schuster
8c2d77c68f
Merge pull request #1699 from Milokita/test-file-fix
...
apply http2 qt resend patch from owncloud
2020-01-19 18:11:36 +01:00
Dominique Fuchs
d3cd422b46
Fix crash on start without any accounts
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
(cherry picked from commit 9935606c87ec4818f04c7d7c63d2f4b61187eead)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-19 14:14:23 +01:00
István Váradi
482ab9ad14
Merge pull request #1738 from ivaradi/qt5.5-compat
...
Qt 5.5 compatibility ifdef
2020-01-19 13:42:31 +01:00
István Váradi
835cd2ac80
Qt 5.5 compatibility ifdef
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-01-19 13:16:17 +01:00
Michael Schuster
36e2813169
Merge pull request #1737 from nextcloud/appimage-qmlfix
...
Testing fix for qmldir import with linuxdeployqt AppImage
2020-01-19 12:43:32 +01:00
Dominique Fuchs
35f8103b40
Testing fix for qmldir import with linuxdeployqt AppImage by correcting source path
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-19 09:10:59 +01:00
Nextcloud bot
f4febe04bc
[tx-robot] updated from transifex
2020-01-19 03:25:56 +00:00
Dominique Fuchs
f99fc722ac
add missing resource include for add.svg
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-18 21:03:32 +01:00
Dominique Fuchs
a9ba51885e
Re-add unintentionaly deleted files
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-18 17:52:42 +01:00
Dominique Fuchs
01e9343d8b
Cleanup/Removal/Adaption/Update to resource files and crresponding code, esp. regarding svg usage
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-18 17:47:17 +01:00
Michael Schuster
c2f5f156f0
Bump version year to 2020
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-18 17:11:44 +01:00
Michael Schuster
7136d92011
Linux AppImage build script: Add QML dir for new 2.7 Tray menu
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-18 16:31:48 +01:00
Michael Schuster
a35aa58943
Linux AppImage build script: Use QtKeyChain master
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-18 16:31:22 +01:00
Michael Schuster
e7f7ad7eb3
Merge pull request #1735 from nextcloud/feature/context-menu-direct-edit
...
Add direct editing to the file manager extension
2020-01-18 15:45:49 +01:00
Michael Schuster
c0863ede02
Share context menu: Use directEditing capability in SocketApi
...
- Allow direct editing "Edit" when an editor is available for the mime type
- Show "Open in browser" if editing is unavailable (as previously)
(now on top of the menu list)
- Rename the menu title to the app name, "Nextcloud" instead of "Share via ..."
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-18 15:12:16 +01:00
Michael Schuster
45b39cdbc1
Add support for the directEditing capability
...
- Fetch in ConnectionValidator::slotCapabilitiesRecieved
- Add editors to a list made of the new DirectEditor class
TODO:
- Add support for re-fetch and continously check for changes (ETag)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-18 15:07:51 +01:00
Michael Schuster
9447a10716
JsonApiJob: Add method usePOST to allow anonymous POST requests
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-18 15:03:21 +01:00
Michael Schuster
2039872ee5
Merge pull request #1565 from nextcloud/qml-tray-menu
...
New tray window
2020-01-18 13:18:45 +01:00
Michael Schuster
016a90d7b0
More code maintenance
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-18 12:56:26 +01:00
Dominique Fuchs
9b5bb1365c
Code maintenance - correct some syntax, fix some warnings.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-18 10:30:34 +01:00
Nextcloud bot
b0dfdca76f
[tx-robot] updated from transifex
2020-01-18 03:28:30 +00:00
Michael Schuster
de74057cc8
Add grey hint Activity entry if limit is reached
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-17 20:26:48 +01:00
Michael Schuster
e2188b109a
Limit fetching Activities to 100 or max. 30 days old
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-17 20:25:41 +01:00
Michael Schuster
3ae55c2555
AccountState: Add helper to find navigation App
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-17 20:21:42 +01:00
Michael Schuster
b47adb7aeb
Notifications bug fix: Don't init ETag response header with *
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-17 20:20:37 +01:00
Michael Schuster
889cb636d3
Add Activity date and time
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-17 20:16:20 +01:00
Dominique Fuchs
c9719f44dc
Fix hover property wrongly placed in button, not MouseArea
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-17 16:30:27 +01:00
Dominique Fuchs
599dae0486
Inclusion of possible 'notification' type descriptions in activity
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-17 14:50:05 +01:00
Dominique Fuchs
1c5cdc4d36
Adapted currentId logic for activity fetching to new API (should fix endless fetch bug)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-17 14:29:54 +01:00
Dominique Fuchs
0156edf320
Removed visibility workaround
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-17 11:21:43 +01:00
Dominique Fuchs
f425dfdfea
Set sourceSize to prevent blurry rerendering of svg source in activityIcon
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-17 10:38:21 +01:00
Dominique Fuchs
7ea2f3fa59
Refresh visibility of ListView based on presence of items on showWindow
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-17 09:09:42 +01:00
Dominique Fuchs
1c22070a74
Refresh immediately on showWindow, regardless of the timer
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-17 09:04:24 +01:00
Nextcloud bot
21f3cb8f7d
[tx-robot] updated from transifex
2020-01-17 03:26:44 +00:00
Michael Schuster
9abc1eb921
Add initial support for Apps menu icon display (show remote SVGs)
...
Caching and showing them from local data-URLs leaded to blurry rendering in Qt.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-16 18:43:48 +01:00
Dominique Fuchs
94325359d7
Fixed bug regarding additional but empty delegate at end of activitylist
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 18:01:18 +01:00
Dominique Fuchs
585094a719
Minor property hierarchy fix
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 17:40:47 +01:00
Dominique Fuchs
4b79c597dc
Disabled animations until population glitches are fixed
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 17:11:08 +01:00
Dominique Fuchs
1bc8ec59aa
Streamlining local sync notification/activity icons with server ones. Added fileAction logic for local sync activities
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 17:09:34 +01:00
Dominique Fuchs
b9a350e201
Minor layout adjustments
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 15:19:17 +01:00
Dominique Fuchs
cd80c749d6
Retreive and svg data from icon property url for activity entries
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 14:01:54 +01:00
Dominique Fuchs
06fdde8f1e
Upgrade of NC server API usage + corresponding activity queries and properties including icon ref
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 12:43:04 +01:00
Dominique Fuchs
9f259bda27
Add check if applist rowCount() already empty to prevent assert exception
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 11:30:51 +01:00
Dominique Fuchs
d7a9940973
Fix failing of several tests by including ocsjob source (after its inclusion in accountstate in a previous commit)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 10:53:43 +01:00
Dominique Fuchs
db92d5bfff
append the correct folderwatcher (platform specific)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 10:39:56 +01:00
Dominique Fuchs
246f7e9395
1px border #0082c9 around tray window
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-16 08:01:09 +01:00
Nextcloud bot
b5549bf00c
[tx-robot] updated from transifex
2020-01-16 03:28:16 +00:00
Michael Schuster
7fe138330e
Double the width of the Apps menu (x starts at the Talk button)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-16 00:57:49 +01:00
Michael Schuster
3488fd7c7f
Fix font sizes for "Log out" and "Remove account" and the Apps menu
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-16 00:45:31 +01:00
Roeland Jago Douma
a3aab00ca9
Windows 7 is out of support
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-01-16 00:07:10 +01:00
Brandon
d10bc1bb14
Correct wrong variable
...
Signed-off-by: Brandon <brandon.yeow@websparks.sg >
2020-01-15 23:07:14 +01:00
Brandon
18a88fcecf
Correct wrong variable
...
Signed-off-by: Brandon <me@branbit.com >
Signed-off-by: Brandon <brandon.yeow@websparks.sg >
2020-01-15 23:07:14 +01:00
ritsute
c92f520423
Handle broken shared file error gracefully
...
Signed-off-by: Brandon <me@branbit.com >
Signed-off-by: Brandon <brandon.yeow@websparks.sg >
2020-01-15 23:07:14 +01:00
Dominique Fuchs
00d73a9389
Add visual separation between accountStateIndicator and avatar
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-15 20:11:50 +01:00
Dominique Fuchs
ddf67ff948
Preserve a 2px distance from tray border (streamlining with acount menu)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-15 19:28:40 +01:00
Dominique Fuchs
9b32ebdae4
Allow text to expand further if one or both buttons aren't visible
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-15 19:15:25 +01:00
Dominique Fuchs
0ec2291bd7
Layout adjustments & also show remote path in activitylist
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-15 18:44:33 +01:00
Michael Schuster
026bf02c85
App menu: Filter out Talk because we have a dedicated button for it
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-15 18:14:20 +01:00
Michael Schuster
42ebc7e995
Remove debug output
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-15 18:09:33 +01:00
Corentin Noël
1e2a9a322b
Install libcloudproviders files by default on debian
...
Signed-off-by: Corentin Noël <corentin@elementary.io >
2020-01-15 17:32:40 +01:00
Michael Schuster
b4b6366ba8
Add App list menu to Tray UI
...
- Modify Window.qml and Systray to show the App menu upon clicking the App button
on the top-right. Fall back to opening the general URL in case no apps are found.
- Introduce a new UserAppsModel in UserModel.cpp to access the fetched server Apps
from AccountState (propagated down from the User class).
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-15 16:42:06 +01:00
Michael Schuster
7b740f5e9a
Remove setTalkCapability() from AccountState and filter for Talk upon App list building
...
Since the per Account App list is now being built in AccountState's slotNavigationAppsFetched
it's easy to filter for the availability of the Talk app on the server by its ID property
upon App list building, thus eliminating the need for an extra fetch job.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-15 16:30:05 +01:00
Michael Schuster
cb328d6cea
Fetch server Apps in AccountState (moved from ownCloudGui)
...
- Add a new class AccountApp to keep them in an AccountAppList
and also save properties like ID and Icon URL.
- Clear the app list upon re-fetch to avoid endlessly growing lists
like in the previous implementation in ownCloudGui.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-15 16:23:46 +01:00
Dominique Fuchs
b57b8cfb66
Resized add account icon, adapted layout for new size
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-15 08:01:54 +01:00
Nextcloud bot
cb1c68a36e
[tx-robot] updated from transifex
2020-01-15 03:24:58 +00:00
Dominique Fuchs
29138cc533
Font and icon size improvements, svg transfer to new folder
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-14 19:48:21 +01:00
Dominique Fuchs
c09dd9287c
Fix missing trayScreen init in non-OSX clause
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-14 08:55:39 +01:00
Dominique Fuchs
65b47d4613
Make qml UI strings translatable
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-14 07:59:28 +01:00
Nextcloud bot
aab2d01a7c
[tx-robot] updated from transifex
2020-01-14 03:25:33 +00:00
Dominique Fuchs
f748a4bb50
Made tray window positioning HighDPI aware
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 22:11:57 +01:00
Dominique Fuchs
e4b19d0cb5
Activity refresh in background
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 14:35:58 +01:00
Dominique Fuchs
eeefbe57af
Added progressInfo / cleanup to acitivtymodel
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 13:10:32 +01:00
Dominique Fuchs
84066634e7
Integrated local error messages in activitymodel
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 12:54:38 +01:00
Dominique Fuchs
9e82ba60b4
Integrated local sync activities in activitymodel
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 12:20:41 +01:00
Dominique Fuchs
96a74d9ef0
Minor improvements
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 11:46:49 +01:00
Dominique Fuchs
1ebcd3a0fb
Icon selection, svg path transfers, scrollbar
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 09:59:34 +01:00
JanDragon
7565c547ae
Welcome to 2020
2020-01-13 09:28:51 +01:00
Michael Schuster
8f9101773c
Fix Explorer integration on Windows and the crash on other systems
...
- Ensure that the folder integration stays persistent in Explorer,
the uninstaller removes the folder upon updating the client.
Recreate all entries upon start. This has the benefit of removing
old remains of non-working, outdated entries.
- Don't crash on the other systems when the user clicks the option
button "Show sync folders in Explorer's Navigation Pane".
Even though the option currently doesn't work on the other platforms,
crashing is never good...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-01-13 09:25:01 +01:00
Dominique Fuchs
17fcfd4e41
Show ListView delegate only when model is populated (prevent dummy delegate)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 09:12:44 +01:00
Dominique Fuchs
9e6df7a4dc
Add populate transition
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 08:43:51 +01:00
Dominique Fuchs
9319210c4c
Fix local folder not opening on windows, add extra slash
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-13 08:33:10 +01:00
Nextcloud bot
43fa27887d
[tx-robot] updated from transifex
2020-01-13 03:24:43 +00:00
Dominique Fuchs
58f1c3234d
Temperarily disabling animations due to lags - FIXME
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 21:37:08 +01:00
Dominique Fuchs
715924cac6
Show activitylist on initial tray opening when logged in
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 21:19:18 +01:00
Dominique Fuchs
163ca3b58a
Removed old account toolbox
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 19:53:02 +01:00
Dominique Fuchs
1c2916052d
Bunch of fixes and optimizations for activityList
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 17:52:51 +01:00
Dominique Fuchs
b76da25ef1
Model/View improvements, also fixes crash on account removal
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 16:16:24 +01:00
Dominique Fuchs
7f35178c70
More fixes to login/logout logic
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 11:06:48 +01:00
Dominique Fuchs
212e1f80f5
emit signal for current user GUI refresh on login/logout
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 10:46:14 +01:00
Dominique Fuchs
a2c9e369c3
call resetRejectedCertificates on fresh login
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 10:42:40 +01:00
Dominique Fuchs
78f12de997
Merge branch 'master' into qml-tray-menu
2020-01-12 09:12:16 +01:00
Dominique Fuchs
8ec7cfa700
Connection status indicators as avatar overlay
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 09:10:06 +01:00
Dominique Fuchs
bc8f64bb98
Generalized connection check, now working for every user in account menu
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-12 08:50:13 +01:00
Nextcloud bot
c7cc716e57
[tx-robot] updated from transifex
2020-01-12 03:25:48 +00:00
Dominique Fuchs
578a3b4ef4
Streamlined 'Add account' button with account entries
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 20:28:00 +01:00
Dominique Fuchs
cc671dfad3
Fix local folder URL
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 19:56:56 +01:00
Dominique Fuchs
86b915d42e
Systray now a singleton with instance(), show tray on finished wizard
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 17:34:56 +01:00
Dominique Fuchs
738127525f
Fix comment
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 17:14:44 +01:00
Dominique Fuchs
6485ef480b
Added confirmation dialog for account removal
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 17:06:42 +01:00
Dominique Fuchs
9af7d4ad06
Fix crash on startup when no users configured
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 16:41:20 +01:00
Dominique Fuchs
32741162d9
Detect newly added user and rebuild account menu automatically
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 15:47:36 +01:00
Dominique Fuchs
3da982f073
Implemented account removal
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 15:32:59 +01:00
Dominique Fuchs
a021f62e96
Tray creation timing, account menu reinstantiating on visible change
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 15:05:37 +01:00
Dominique Fuchs
80e21560eb
More UserLine, avatar fixes
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-11 14:57:22 +01:00
Nextcloud bot
e38b98c81a
[tx-robot] updated from transifex
2020-01-11 03:25:40 +00:00
Dominique Fuchs
9c0221a0fa
UserLine drafting, bugfixes, restuctures
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-10 16:28:53 +01:00
Nextcloud bot
afbed7dbd7
[tx-robot] updated from transifex
2020-01-10 03:27:02 +00:00
Roeland Jago Douma
05083e32c9
Ask for password on password protected link shares
...
Fixes #1485
This was missed when creating the new share dialog.
Now it pops up with a nice share password dialog to enter for your link
share.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-01-09 18:20:32 +01:00
Nextcloud bot
c6bd8c1221
[tx-robot] updated from transifex
2020-01-09 04:16:12 +00:00
Nextcloud bot
63c7844a27
[tx-robot] updated from transifex
2020-01-08 04:16:49 +00:00
Nextcloud bot
762032ebbc
[tx-robot] updated from transifex
2020-01-07 04:17:27 +00:00
JanDragon
4a64e8da83
Updated year in legalnotice.cpp
2020-01-06 09:08:22 +01:00
Nextcloud bot
5c6af99f11
[tx-robot] updated from transifex
2020-01-06 04:16:30 +00:00
Dominique Fuchs
6ac1a4a353
Preps for UserLine submenu
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-05 21:31:09 +01:00
Dominique Fuchs
330ff96ee2
Code cleanup regarding context menu. Pause/resume logic implemented. Halfway through remodeling account menu.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-05 21:06:42 +01:00
Dominique Fuchs
a90995cf15
Focus and popup improvements for macOS
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-05 16:25:32 +01:00
Nextcloud bot
84693b95ec
[tx-robot] updated from transifex
2020-01-05 04:28:46 +00:00
Dominique Fuchs
aa9921c6f5
Quit/settings button in tray menu, disable context menu, font size fixes
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-04 17:22:56 +01:00
Dominique Fuchs
d653618b0a
Fix blurry caret svg due to https://bugreports.qt.io/browse/QTBUG-44863
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-04 12:18:06 +01:00
Dominique Fuchs
dc9744448c
Fix wrong macro clause
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-04 12:15:01 +01:00
Dominique Fuchs
ed9c06583a
Fix macOS popup y position, neglecting unneccesary calculations
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-04 12:08:30 +01:00
Dominique Fuchs
ff92adf3e0
Tray account menu wording/positioning
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-04 10:09:01 +01:00
Nextcloud bot
bf95c03847
[tx-robot] updated from transifex
2020-01-04 04:17:33 +00:00
Dominique Fuchs
e0641df727
First real activity connection
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-03 16:15:15 +01:00
Dominique Fuchs
f01c47e0ec
Fix server adress retreival in tray window buttons
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-03 14:00:07 +01:00
Dominique Fuchs
faf46fcf60
More typo fix
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-03 13:42:07 +01:00
Dominique Fuchs
687a99279d
Has function for ActivityModel, typos
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-03 13:39:10 +01:00
Dominique Fuchs
25e09815be
Fixed client.qrc
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-03 13:17:01 +01:00
Dominique Fuchs
02cb43180c
Fix git not recognizing case sensitive changes
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-03 13:12:04 +01:00
Dominique Fuchs
b32310b8a6
Gigantic ton of changes and deletions: ActivityListModel, tray GUI, Account logic.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-03 13:09:29 +01:00
Dominique Fuchs
556a1a5ef2
Added ActivityModel in new tray backend, implemented as delegate in UI
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-02 10:39:53 +01:00
Dominique Fuchs
36467c1e3a
Added folder search for User instance, added open folder button connection
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-02 09:55:37 +01:00
Dominique Fuchs
d4b334636e
Fall back to primary screen on QT version < 5.10 instead of icon position detection
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-02 08:56:07 +01:00
Dominique Fuchs
7653c5fa60
Fix merge conflict
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-01-02 08:43:34 +01:00
Nextcloud bot
bd61cd3142
[tx-robot] updated from transifex
2020-01-02 04:14:47 +00:00
Nextcloud bot
1a0f7221d9
[tx-robot] updated from transifex
2020-01-01 04:14:20 +00:00
Nextcloud bot
7303c726f9
[tx-robot] updated from transifex
2019-12-31 04:15:07 +00:00
Dominique Fuchs
44bfc79caa
Implemented platform agnostic tray window positioning logic
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-30 14:14:28 +01:00
Dominique Fuchs
6f8ffc0357
Backend code separation & structure cleanup
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-30 11:52:07 +01:00
Dominique Fuchs
bb45a5f67e
Added popup show/hide logic
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-30 11:39:21 +01:00
Nextcloud bot
baa0a5b8af
[tx-robot] updated from transifex
2019-12-30 04:12:51 +00:00
Nextcloud bot
9081556e1d
[tx-robot] updated from transifex
2019-12-29 04:14:53 +00:00
Nextcloud bot
1b14f55c3c
[tx-robot] updated from transifex
2019-12-28 04:13:31 +00:00
Nextcloud bot
89a5e34414
[tx-robot] updated from transifex
2019-12-27 04:13:27 +00:00
Nextcloud bot
e2bc7d1307
[tx-robot] updated from transifex
2019-12-26 04:11:34 +00:00
XNG
768cf7e1ae
apply http2 qt resend patch from owncloud
...
Signed-off-by: XNG <Milokita@users.noreply.github.com >
2019-12-25 14:36:25 +08:00
XNG
d87a88e39f
apply http2 qt resend patch from owncloud
...
Signed-off-by: XNG <Milokita@users.noreply.github.com >
2019-12-25 14:13:03 +08:00
XNG
314c00a8b7
apply http2 qt resend patch from owncloud
...
Signed-off-by: XNG <Milokita@users.noreply.github.com >
2019-12-25 13:59:15 +08:00
Nextcloud bot
16ed62d548
[tx-robot] updated from transifex
2019-12-25 04:13:59 +00:00
Michael Schuster
2b2810511d
KeychainChunk: Fix error handling in ReadJob::slotReadJobDone
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 12:17:43 +01:00
Michael Schuster
e07859fb3c
Fix date in ActivityWidget and remove unnecessary string conversion
...
The local date and time value was converted into a string, just to be converted
into another string, to be converted to a value once again, returning zero as
the result. This caused the widget to always display "now".
Looks like this was a simply copy and paste mistake from this line in
ActivityListModel::slotActivitiesReceived:
a._dateTime = QDateTime::fromString(json.value("date").toString(), Qt::ISODate);
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 08:53:14 +01:00
Michael Schuster
9b034a2eb0
Heavy refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys and large certs
...
With QtKeychain on Windows, storing larger keys or certs in one keychain entry causes the
following error due to limits in the Windows APIs:
Error: "Credential size exceeds maximum size of 2560"
This fix implements the new wrapper class KeychainChunk with wrapper jobs ReadJob and WriteJob
to encapsulate the QKeychain handling of ReadPasswordJob and WritePasswordJob with binaryData
but split every supplied keychain entry's data into 2048 byte chunks, on Windows only.
The wrapper is used for all keychain operations in WebFlowCredentials, except for the server password.
All finished keychain jobs now get deleted properly, to avoid memory leaks.
For reference also see previous fixes:
- https://github.com/nextcloud/desktop/pull/1389
- https://github.com/nextcloud/desktop/pull/1394
This should finally fix the re-opened issue:
- https://github.com/nextcloud/desktop/issues/863
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:47:35 +01:00
Michael Schuster
bd9652b24c
Flow2AuthWidget: Minor fixes and improvements
...
- Improve status messages
- Add a counter to make sure that "Link copied to clipboard." is visible for
three seconds and to not enable the buttons too early
- Add more space between buttons and status
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
8b5f09305c
Flow2: Refactor UI into Flow2AuthWidget only and improve Flow2Auth
...
- Flow2AuthCredsPage:
- Remove .ui file and embed Flow2AuthWidget into layout
- Flow2AuthWidget:
- Make use generic for Flow2AuthCredsPage and WebFlowCredentialsDialog
- Fix _errorLabel to render HTML tags instead of dumping them as plain text
- Flow2Auth:
- Explicitly start auth with startAuth(account) instead of using constructor
- Take control of copying the auth link to clipboard
- Request a new auth link on copying, to avoid expiry invalidation
- Use signals statusChanged() and result() to be more verbose (status, errors)
- Change timer invocation and add safety bool's to avoid weird behaviour when
the user triggers multiple link-copy calls (fetchNewToken)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
6d033f2964
Add new HeaderBanner class for WebFlowCredentialsDialog
...
New widget on top of the layout, based on Qt's own modern wizard header banner.
This should improve the user's perception of the dialog.
Encapsulate the existing layout into a container layout to allow the banner taking
the full width of the dialog.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
0bcac1882a
Make WebFlowCredentialsDialog cancellation- and deletion-safe
...
- Add new signal to let WebFlowCredentials know and emit asked() to also
tell AccountState that the user won't authenticate, and triggering
log-out state in the settings window.
- Use deleteLater() to safely delete WebFlowCredentialsDialog, so
that Qt can free it at the right time and without crashes.
Do the same with it's _webView and _flow2AuthWidget on closeEvent().
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
b6b04aeff8
WebFlowCredentialsDialog: Bring re-auth dialog to top (raise) on error
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
a69aed80e6
Flow2: Make ProgressIndicator's background-aware (Dark-/Light-Mode switching)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
e81f972270
Flow2: Add poll status text, ProgressIndicator and countdown timer
...
Also enable / disable buttons during polling.
This aims to make the authentication status more transparent and should avoid the
impression that the client is perhaps doing nothing.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
542590db7c
Small fixes and code cleanup
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
e04aae94bc
Flow2: Poll for re-auth result upon WebFlowCredentialsDialog window activation
...
Since the default remote poll interval has been re-raised recently to 30 seconds,
the delay between clicking "Grant access" in the browser and fetch and showing success
in the dialog may seem erroneous to the users and tempt them to click "Re-open browser"
again, causing the whole login process to restart.
This commit implements an event handler to pass the dialog's window activation
event down to the Login Flow v2 widget, in order to allow it to poll earlier.
See previous commits for dependent implementation details.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
aa18667905
WebFlowCredentialsDialog: Bring re-auth dialog to top (raise) upon showing SettingsDialog
...
Purpose: The floating re-auth windows of the WebFlowCredentialsDialog often get hidden behind
the SettingsDialog, and the users have to minimize a lot of other windows to find them again.
See previous commit for dependent implementation details.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
addb27a085
Add helper slots and signals to catch SettingsDialog's window activation events
...
Signal the SettingsDialog's window activation event down to ownCloudGui and Application,
so that other classes can hook in to get notified when the SettingsDialog is being shown
again.
This approach has been chosen because we otherwise would have to deal with new instance
pointers of the current SettingsWindow - but Application is already there ;-)
Purpose: The floating re-auth windows of the WebFlowCredentialsDialog often get hidden
behind the SettingsDialog, and the users have to minimize a lot of other windows to find
them again. This commit implements the preparation for the upcoming fix commit.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
be10d5200f
Flow2: Use ownCloudGui::raiseDialog to bring account setup wizard to top (raise) on auth result
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
e8348612b4
Flow2: Poll for auth result upon account setup wizard window activation
...
Since the default remote poll interval has been re-raised recently to 30 seconds,
the delay between clicking "Grant access" in the browser and fetch and showing success
in the wizard may seem erroneous to the users and tempt them to click "Re-open browser"
again, causing the whole login process to restart.
This commit implements an event handler to pass the wizard's window activation
event down to the Login Flow v2 page, in order to allow it to poll earlier.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
3a160a4dce
Flow2: Bring account setup wizard to top (raise) on auth result
...
Show and raise the wizard on success / error in the Login Flow v2 auth.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:46:57 +01:00
Michael Schuster
ccd20f0172
Fix issue #1237 : White text on almost-white background
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:44:18 +01:00
Michael Schuster
c03bc8540c
Fix folder opening in ActivityListModel
...
After fixing the crash in the previous commit, double-clicking on Activity list rows still didn't work.
This fix partly reverts commit 8546d53b05 in ActivityItemDelegate::PathRole
of ActivityListModel::data, but adds a new check for relPath's existence in line 74.
I'm assuming the previous change there has been done to shorten the code and avoid opening the user's home
folder upon clicking entries which file value is "App Password". The new path-check takes care of that too now.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:42:01 +01:00
Michael Schuster
003acb7254
Fix crash in ActivityListModel ( fixes #1693 )
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:42:01 +01:00
Michael Schuster
b961b683d6
Show date and time in activity log (fixes issue #1683 )
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-24 07:40:42 +01:00
Nextcloud bot
f82ef95866
[tx-robot] updated from transifex
2019-12-24 04:15:27 +00:00
Nextcloud bot
ed9000bb07
[tx-robot] updated from transifex
2019-12-23 04:17:38 +00:00
Nextcloud bot
6afe2b124d
[tx-robot] updated from transifex
2019-12-22 04:20:47 +00:00
Nextcloud bot
629d23d832
[tx-robot] updated from transifex
2019-12-21 03:50:38 +00:00
Nextcloud bot
d837feca71
[tx-robot] updated from transifex
2019-12-20 03:50:25 +00:00
Michael Schuster
a7dade979c
Fix build (missing refactoring)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
3a2caf61e5
Mac and high-dpi displays: Add workaround in ActivityItemDelegate to show full uncropped activity's actionText and timeText
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
b5ed16088a
Make all ProgressIndicator's background-aware (Dark-/Light-Mode switching)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
e4a20b9e72
Make OwncloudWizard and its pages background-aware (Dark-/Light-Mode switching)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
37e5fe786f
Remove unnecessary string translation and copy in ActivityItemDelegate
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
643995528b
Remove unnecessary breaks in ActivityListModel
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
ecd17f2ea2
Make ActivityItemDelegate background- and selection-aware (Dark-/Light-Mode switching)
...
Also implement cached member icons in ActivityListModel and return their enums to
ActivityItemDelegate instead of always recreating them for each call to paint().
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
bf0bf2c1b6
Refactor ActivitySettings: Rename member variable ui to _ui
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
acedf362b6
Make AccountSettings and ActivitySettings background-aware (Dark-/Light-Mode switching)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
3b580eeca7
Change error link colour in AccountSettings::showConnectionLabel
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
6adfff1f13
Add new Theme helper method to custom-colourize links
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Michael Schuster
7d542d7989
Change Dark Mode link colour
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-19 22:07:30 +01:00
Nextcloud bot
b6a8195cb0
[tx-robot] updated from transifex
2019-12-19 03:51:44 +00:00
Michael Schuster
cc21d175f1
Fix Activity List: Add check to avoid first empty entry
...
Add checks to ActivityListModel::combineActivityLists in order to avoid adding
empty Activity entries to the _finalList.
The previous implementation always added an empty entry to the top of the list because
_notificationIgnoredFiles was appended without checking (_listOfIgnoredFiles.size() > 0).
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-18 03:29:54 +01:00
Nextcloud bot
ade4b198cf
[tx-robot] updated from transifex
2019-12-17 03:51:18 +00:00
Nextcloud bot
32b65f576f
[tx-robot] updated from transifex
2019-12-15 03:50:26 +00:00
Nextcloud bot
f2bbb90d52
[tx-robot] updated from transifex
2019-12-14 03:50:17 +00:00
Nextcloud bot
ffbf06755f
[tx-robot] updated from transifex
2019-12-13 03:50:26 +00:00
Nextcloud bot
58716bb406
[tx-robot] updated from transifex
2019-12-12 03:50:18 +00:00
Nextcloud bot
782d68afa8
[tx-robot] updated from transifex
2019-12-11 03:10:56 +00:00
Nextcloud bot
1c1f291778
[tx-robot] updated from transifex
2019-12-10 03:14:17 +00:00
Michael Schuster
b754eacd74
macOS: Rename 'Explorer' appropriately on non-Windows
...
- Rename it to 'Finder' on macOS.
- This way we also avoid having the whole string re-translated on Transifex.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-09 21:37:21 +01:00
Michael Schuster
7ce8a6a201
Make the ShareDialog background-aware (Dark-/Light-Mode switching)
...
Use customizeStyle() to change link colours, icons and pixmaps in the ShareDialog and notify
it's widgets via slots.
TODO - known issue (macOS):
- The background and font colours in the ShareUserLine widget still stay the same.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-09 21:37:21 +01:00
Michael Schuster
789a2a7ae3
Make SettingsDialog background-aware (Dark-/Light-Mode switching)
...
Use customizeStyle() to change link colours in the SettingsDialog and notify it's widgets via slots.
Also modify the background colour of the errors messages in AccountSettings::showConnectionLabel
to always use an appropiate colour for it's custom-defined background.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-09 21:37:21 +01:00
Michael Schuster
be4fc6b887
Implement and move some colour-aware helper methods into the Theme class
...
This introduces a new method to change the colours in the links in QLabel's.
Utilizes a custom crafted RegEx function to replace already-coloured links.
Moved code is based on stuff from the SettingsDialog class.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-09 21:37:21 +01:00
Michael Schuster
2dae31486a
Pick from upstream: Fix too low contrast when tab is selected
...
The low contrast is also a problem with the Dark Mode on macOS.
For reference please see:
- Commit: 413ef5e96d
- Issue: https://github.com/owncloud/client/issues/7512
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-09 21:37:21 +01:00
Michael Schuster
71f66c6229
Fix SSL-button's info background color for Dark Mode
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-09 21:37:21 +01:00
Michael Schuster
b4f926ded7
Remove submodule qtmacgoodies and the MacSettingsDialog class
...
Reverts back to the SettingsDialog class because of bugs and glitches with
more recent Qt versions (Qt 5.12) and with the macOS Dark Mode.
See upstream: https://github.com/owncloud/client/pull/7492
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-09 21:37:21 +01:00
Dominique Fuchs
438a445353
Merge remote-tracking branch 'origin/master' into qml-tray-menu
2019-12-09 06:52:52 +01:00
Dominique Fuchs
6a04fe8ab6
Remove init.qml from CMakeLists and resource file
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-09 06:43:20 +01:00
Nextcloud bot
ca7bdf245e
[tx-robot] updated from transifex
2019-12-09 03:11:08 +00:00
Dominique Fuchs
c45d2212a5
Removal of init.qml plus minor fixes
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-08 20:18:03 +01:00
Dominique Fuchs
66bfccc738
Replaced .engine() by pointer access b/c of backward compatibility
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-08 13:18:46 +01:00
Dominique Fuchs
ae7eddf7c9
Fixed inconsistent module import versions (based on Qt 5.9)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-08 11:32:22 +01:00
Nextcloud bot
36a59f09ac
[tx-robot] updated from transifex
2019-12-08 03:12:35 +00:00
Michael Schuster
5869b93acb
Fix deleteKeychainEntries: Stay consistent with job->setInsecureFallback(false)
...
We never fall back to the insecure variant in the whole codebase, so don't do it here.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-08 02:47:22 +01:00
Michael Schuster
b15eb27aa9
Fix Windows key-chunk deletion (too paranoid)
...
Clear the key chunk buffer, but don't set _clientSslKeyChunkCount to zero because we need it later for deleteKeychainEntries
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-08 02:47:22 +01:00
Michael Schuster
336b64a569
Fix member variable name from last refactoring (Windows code)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-08 02:47:22 +01:00
Michael Schuster
6a49e787bb
Fix Remote Wipe keychain storage
...
In certain cases don't write the app password in Account::writeAppPasswordOnce:
- id() is empty: This always happend once the Account Wizard showed the folder selection
- appPassword is empty: Caused by Logout -> Relaunch, preventing remote wipe on relaunch
Implement some logging to ease debugging in the future.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-08 02:47:22 +01:00
Michael Schuster
0c5f4a1525
Remote Wipe: Implement hack to allow deleting all keychain entries (SSL certs & keys)
...
Client SSL certificates and keys cannot be deleted at this time because there is
no UI for selecting them on re-login.
We introduce this dirty hack here, to allow deleting them upon Remote Wipe.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-08 02:47:22 +01:00
Michael Schuster
6ef9f3cc26
Refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys
...
WebFlowCredentials:
- Remove _clientSslCaKeyWriteQueue and simply use _clientSslKeyChunkBufferPEM
- Store key's sub-chunks in slots with "." (dot) suffix
- Implement deletion of the key chunks in WebFlowCredentials::deleteKeychainEntries
- Remove spaces in log messages
- Improve code readability
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-08 02:47:22 +01:00
Michael Schuster
72be80cbd9
Windows: Workaround for storing >= 4k (4096 bit) client-cert SSL keys
...
With QtKeychain on Windows, storing larger keys in one keychain entry causes the
following error due to limits in the Windows APIs:
Error: "Credential size exceeds maximum size of 2560"
To avoid overhead on the other platforms and balance code duplication, this
approach puts some read- and write-parts into Windows-only defines.
For reference also see previous fixes:
- https://github.com/nextcloud/desktop/pull/1389
- https://github.com/nextcloud/desktop/pull/1394
This (again) fixes the re-opened issue:
- https://github.com/nextcloud/desktop/issues/863
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-08 02:47:22 +01:00
Nextcloud bot
99a27d19b9
[tx-robot] updated from transifex
2019-12-07 03:13:09 +00:00
Michael Schuster
877fd7abb9
Fall back to old login flow on GS as this is not yet ready ( #2 : re-auth)
...
This commit ensures that the check also occurs on re-authorization in case
the user gets logged out.
See: https://github.com/nextcloud/desktop/pull/1644
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-12-06 21:03:01 +01:00
Roeland Jago Douma
363e62f8fa
Fall back to old login flow on GS as this is not yet ready
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-12-06 21:03:01 +01:00
David Kahles
9a3aa55b29
Compare QDateTime objects more efficient
...
There is no need to call toMSecsSinceEpoch() as QDateTime implements an
comparison operator itself. This is more efficient, because the
QDateTime comparison operator doesn't call localtime() in all cases. Thus, we
don't read /etc/localtime for every comparison. This improves
performance in some cases.
Signed-off-by: David Kahles <david.kahles96@gmail.com >
2019-12-06 16:17:53 +01:00
Dominique Fuchs
ab9897b397
Added frontend invokation to open local folder
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-06 14:50:34 +01:00
Nextcloud bot
30829d0669
[tx-robot] updated from transifex
2019-12-06 03:13:10 +00:00
Dominique Fuchs
c18611d4af
Finished account switch back- and frontend in tray menuwindow
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-05 11:38:29 +01:00
Dominique Fuchs
5eff8608fe
Account swtich logic and UI updates
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-05 08:21:19 +01:00
Nextcloud bot
c25a56b2be
[tx-robot] updated from transifex
2019-12-05 03:11:15 +00:00
Dominique Fuchs
3a4ca5e190
Working on account switching
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-04 16:19:42 +01:00
Dominique Fuchs
d1d1f9bb58
Connected AccountWizard with new account action in tray menu, minor fixes
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-04 14:19:23 +01:00
Dominique Fuchs
0c81d25e96
Clean up test variable
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-04 13:18:18 +01:00
Dominique Fuchs
90ace3fedc
Minor preps for c++ ActivityListModel impl. in QML
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-04 13:10:28 +01:00
Dominique Fuchs
3a0ccf3697
connected UserModel login/logout signals, minor fixes
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-04 13:00:26 +01:00
Nextcloud bot
ea1e42cb83
[tx-robot] updated from transifex
2019-12-04 10:22:14 +00:00
Dominique Fuchs
4e0997dbdf
Minor fixes and enhancements
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-04 08:06:56 +01:00
Nextcloud bot
50b4fdc03d
[tx-robot] updated from transifex
2019-12-04 03:10:59 +00:00
Dominique Fuchs
57084fbd3e
WIP: working UserModel.cpp and account menu
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-03 22:15:25 +01:00
Dominique Fuchs
4478399282
More stuff regarding tray/UserModel.cpp
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-03 18:50:34 +01:00
Dominique Fuchs
53abf5a316
WIP: Building User/MenuModel backend for tray menu
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-03 17:25:11 +01:00
Joas Schilling
9ce2491d67
Use … instead of 3 dots
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-12-03 09:06:06 +01:00
Joas Schilling
ec637217f2
Fix some translations
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-12-03 09:06:06 +01:00
Joas Schilling
91a5395e1a
Improve the translation of "Share via …"
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-12-03 09:06:06 +01:00
Dominique Fuchs
dac1c9b413
Avatar, full user name and server address now reflected in QML gui, provided by C++ backend
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-12-03 07:26:59 +01:00
Dominique Fuchs
c21e4f5982
Clean up test variable
2019-12-02 22:48:39 +01:00
Dominique Fuchs
478281d853
Restructures and refactorings: New systray class, handling of current user selection, integration of user information in tray window header
2019-12-02 22:45:14 +01:00
Dominique Fuchs
08d4c56886
WIP: Extending systray class, transitioning towas independent ActivityModel inclusion
2019-12-02 14:10:18 +01:00
Nextcloud bot
4987add452
[tx-robot] updated from transifex
2019-12-02 03:10:52 +00:00
Nextcloud bot
6a9f155856
[tx-robot] updated from transifex
2019-11-30 03:10:58 +00:00
Michael Schuster
407864c40e
Fix copyright year in MacOSXBundleInfo.plist.in for 2019
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-29 17:24:25 +01:00
Dominique Fuchs
03c0d8ba5a
Minor preps for c++ ActivityListModel impl. in QML
2019-11-29 17:06:35 +01:00
Michael Schuster
76c7ab499f
Use ReadPasswordJob::finished for ReadPasswordJob
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-29 13:53:52 +01:00
Michael Schuster
dcc84d3508
Fix remote wipe keychain storage (issue #1592 )
...
The app password for the remote wipe was constantly being written in
WebFlowCredentials::slotFinished to the keychain, leading to unnecessary
write and log overhead on the system.
This fix introduces a check to only store the app password once in
a lifetime of the Account class. Also the method used to store the
password will be renamed from setAppPassword to writeAppPasswordOnce
to be more expressive.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-29 13:53:52 +01:00
Nextcloud bot
8ae18d9935
[tx-robot] updated from transifex
2019-11-29 03:10:32 +00:00
Nextcloud bot
013e08f80a
[tx-robot] updated from transifex
2019-11-28 03:12:08 +00:00
Nextcloud bot
33dd60107d
[tx-robot] updated from transifex
2019-11-27 03:07:47 +00:00
István Váradi
2fc76c2b24
Build for Debian stable and oldstable
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-11-26 16:20:11 +01:00
Christoph Wurst
923abd8d0b
Fix legal notice year
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-11-26 12:46:02 +01:00
Nextcloud bot
dc6c638f34
[tx-robot] updated from transifex
2019-11-26 03:07:54 +00:00
Nextcloud bot
2081a265b1
[tx-robot] updated from transifex
2019-11-23 03:09:19 +00:00
Nextcloud bot
a72c3ba8f0
[tx-robot] updated from transifex
2019-11-22 03:09:11 +00:00
Nextcloud bot
363a865263
[tx-robot] updated from transifex
2019-11-21 03:08:55 +00:00
Nextcloud bot
b40e753696
[tx-robot] updated from transifex
2019-11-20 03:09:39 +00:00
Nextcloud bot
58e99184bb
[tx-robot] updated from transifex
2019-11-19 03:08:32 +00:00
Nextcloud bot
79ba95ce04
[tx-robot] updated from transifex
2019-11-18 03:06:58 +00:00
Michael Schuster
93319a6a61
Merge pull request #1623 from nextcloud/mac-prepare-notarization
...
macOS build: Avoid the Get-Task-Allow Entitlement (Notarization)
2019-11-17 21:54:47 +01:00
Michael Schuster
7fb0a82e69
macOS build: Avoid the Get-Task-Allow Entitlement (Notarization)
...
Setting CODE_SIGN_INJECT_BASE_ENTITLEMENTS to NO is required for macOS
Notarization.
See: https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues
And upstream: 97f4af32ae
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-17 21:33:04 +01:00
Michael Schuster
e9e6b85bd9
Merge pull request #1621 from nextcloud/mac-sign-timestamp
...
Add timestamp to Mac installer code signing
2019-11-17 18:12:29 +01:00
Michael Schuster
3b5966bba0
Add timestamp to Mac installer code signing
...
Use the --timestamp option for 'productsign' to add a secure timestamp.
See: https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-17 17:50:52 +01:00
Nextcloud bot
7fc592cb22
[tx-robot] updated from transifex
2019-11-17 03:09:30 +00:00
Michael Schuster
c7299dec78
Merge pull request #1619 from nextcloud/bumpQt-5.12.5
...
Bump Qt 5.12.5 image
2019-11-17 03:19:25 +01:00
Michael Schuster
fce0a50e37
Fix: add /usr/local/lib to LD_LIBRARY_PATH for OpenSSL 1.1.1
...
Drone pipeline qt-5.12 failed because the unit tests didn't find OpenSSL.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-17 02:56:53 +01:00
Michael Schuster
c047232c3b
Fix: escape env vars
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-17 01:59:04 +01:00
Michael Schuster
a846f0276d
Bump Qt 5.12.5 image
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-17 01:30:53 +01:00
Michael Schuster
e2cb3aa078
Merge pull request #1617 from nextcloud/appimageQt-5.12.5
...
Upgrade for Qt 5.12.5 in docker-ci
2019-11-16 22:09:36 +01:00
Michael Schuster
801098f546
Fix dir in upload script
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-16 21:53:25 +01:00
Michael Schuster
4fc8936553
Make AppImage upload optional and add timeout
...
Moves the upload into a separate Drone command and adds a timeout for curl
to fail after 15 minutes.
Returns zero to keep Drone from failing.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-16 21:36:59 +01:00
Michael Schuster
dd0135ce2e
Move .desktop file path to new env var to avoid duplicates
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-16 21:34:13 +01:00
Michael Schuster
d830a1c5f7
Upgrade for Qt 5.12.5 in docker-ci
...
- Use the new image: nextcloudci/client-5.12:client-5.12-5
- Use it's new QT_BASE_DIR: /opt/qt5.12.5
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-16 21:31:07 +01:00
Nextcloud bot
403df7cebc
[tx-robot] updated from transifex
2019-11-16 03:06:41 +00:00
Nextcloud bot
45bc034261
[tx-robot] updated from transifex
2019-11-15 03:07:58 +00:00
Nextcloud bot
bbbead5769
[tx-robot] updated from transifex
2019-11-14 03:07:51 +00:00
Michael Schuster
fca7b32405
Merge pull request #1604 from nextcloud/rakekniven-patch-1
...
l10n: Remove string from Transifex resource
2019-11-14 03:22:29 +01:00
Michael Schuster
d558af31c9
Merge pull request #1605 from nextcloud/revert-1586-qt5.5-compat
...
Revert and Fix "Remove HTTP/2 support from Xenial"
2019-11-14 03:19:09 +01:00
Michael Schuster
5131463644
Fix: Apply http2 patch from owncloud #1573 - only with Qt >= 5.8
...
Drone builds failed with Qt 5.7 and we introduce a new ifdef here
to avoid patching specifically for Ubuntu Xenial only.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-14 02:39:06 +01:00
Michael Schuster
9e8498ad4e
Revert "Remove HTTP/2 support from Xenial"
2019-11-14 02:22:01 +01:00
Michael Schuster
3777ae4624
Merge pull request #1586 from ivaradi/qt5.5-compat
...
Remove HTTP/2 support from Xenial
2019-11-14 01:45:19 +01:00
rakekniven
e896c41ef9
l10n: Remove string from Transifex resource
...
Fix for #1578
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2019-11-13 18:03:22 +01:00
Nextcloud bot
9d8b8be8d2
[tx-robot] updated from transifex
2019-11-13 03:07:30 +00:00
Nextcloud bot
1c15b97b11
[tx-robot] updated from transifex
2019-11-12 03:09:20 +00:00
Nextcloud bot
8017ee45f5
[tx-robot] updated from transifex
2019-11-10 03:11:47 +00:00
Nextcloud bot
8c1e3cabe0
[tx-robot] updated from transifex
2019-11-09 03:03:34 +00:00
Michael Schuster
0c6279f86a
Merge branch 'master' into qt5.5-compat
2019-11-07 15:49:43 +01:00
Nextcloud bot
1cffa3b731
[tx-robot] updated from transifex
2019-11-07 03:06:07 +00:00
Nextcloud bot
549acb0785
[tx-robot] updated from transifex
2019-11-06 03:08:01 +00:00
István Váradi
a143b42c2a
Remove HTTP/2 support from Xenial
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-11-05 19:34:32 +01:00
Nextcloud bot
e85ad9de6a
[tx-robot] updated from transifex
2019-11-05 03:05:20 +00:00
Camila Ayres
0ab5bbb08e
Merge pull request #1522 from adrb/issue_1351
...
* fix for issue no. 1351
2019-11-04 22:48:20 +01:00
Camila Ayres
4efa282f80
Merge branch 'master' into issue_1351
2019-11-04 22:48:07 +01:00
Camila Ayres
d53cfbd9fb
Merge pull request #1573 from Milokita/master
...
Fix #1182 - upload of files with umlaut.
2019-11-04 20:21:17 +01:00
Camila Ayres
94986877d8
Merge branch 'master' into master
2019-11-04 20:20:32 +01:00
Camila Ayres
f3bc2f5e87
Merge pull request #1579 from nextcloud/fix-remote-wipe-proxy
...
Fix remote wipe when a proxy is configured.
2019-11-04 20:16:53 +01:00
Camila Ayres
a5365a6cce
Merge branch 'master' into master
2019-11-04 20:14:11 +01:00
Michael Schuster
b9ad82ceeb
Merge branch 'master' into fix-remote-wipe-proxy
2019-11-04 19:58:56 +01:00
Camila Ayres
fe959fe0d5
Merge pull request #1580 from nextcloud/fix-updater-message
...
Fix updater message: Download link instead of "use the system's updat…
2019-11-04 19:55:39 +01:00
Michael Schuster
6421397083
Fix updater message: Download link instead of "use the system's update tool"
...
Provide a download link to the new version instead of the confusing message that
users should use their "system's update tool to install it".
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-11-04 19:19:59 +01:00
Camila San
52ae354ca2
Fix remote wipe when a proxy is configured.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-11-04 17:52:02 +00:00
Dominique Fuchs
c6ff66be79
Smoother deletions: Added animation for removeDisplaced including sequential opacity change and displacement animation
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-11-04 12:48:07 +01:00
Nextcloud bot
73af9b1cac
[tx-robot] updated from transifex
2019-11-04 03:08:04 +00:00
Nextcloud bot
cdaee7b933
[tx-robot] updated from transifex
2019-11-03 03:09:40 +00:00
Nextcloud bot
6adbd9bd50
[tx-robot] updated from transifex
2019-11-02 03:04:09 +00:00
Nextcloud bot
6acf3871e4
[tx-robot] updated from transifex
2019-11-01 02:56:47 +00:00
XNG
ead2131ba2
Merge branch 'master' of https://github.com/Milokita/desktop
2019-11-01 09:35:19 +08:00
XNG
cf1532acf1
Apply http2 patch from owncloud
...
Signed-off-by: XNG <Milokita@users.noreply.github.com >
2019-11-01 09:35:10 +08:00
XNG
17ca7ab5db
Apply http2 patch from owncloud
...
Signed-off-by: XNG <Milokita@users.noreply.github.com >
2019-11-01 09:22:52 +08:00
XNG
c42332a5ee
Merge pull request #1 from nextcloud/master
...
Just some catch up
2019-11-01 08:48:06 +08:00
Nextcloud bot
c736f48ac9
[tx-robot] updated from transifex
2019-10-31 02:57:51 +00:00
Dominique Fuchs
06b251063e
Initial ListView design/modeling for activity list
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-30 20:47:21 +01:00
Dominique Fuchs
cb7b2a3dc6
Merge branch 'master' into qml-tray-menu
2019-10-30 17:19:18 +01:00
Nextcloud bot
5ac203ebd8
[tx-robot] updated from transifex
2019-10-30 02:56:18 +00:00
Dominique Fuchs
6135eb26ad
Finished (static) header design and hover effects
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-29 23:25:00 +01:00
Dominique Fuchs
d18e2ba339
Merge pull request #1429 from nextcloud/recipientnote
...
Finishing PR #1154
2019-10-29 14:49:36 +01:00
Dominique Fuchs
7ed03f1f29
resolving conflict with current master
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-29 14:07:26 +01:00
Dominique Fuchs
5301477747
Merge branch 'master' into recipientnote
2019-10-29 12:58:14 +01:00
Dominique Fuchs
73667a5367
Updated vecto icons and names, disabled init position (breaks on multiple monitors on windows), integrated new icons in qml
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-29 08:13:05 +01:00
Nextcloud bot
09c282d9ea
[tx-robot] updated from transifex
2019-10-29 03:05:48 +00:00
Dominique Fuchs
f9f1b49298
Added new vector graphics for tray window header icons
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-28 10:36:09 +01:00
Nextcloud bot
f5ff69f8b3
[tx-robot] updated from transifex
2019-10-28 03:05:30 +00:00
Camila San
1e43c29484
Add new qml tray icon.
...
This is a work in progress.
Signed-off-by: Camila San <hello@camila.codes >
2019-10-27 20:02:30 +01:00
Michael Schuster
a15cad0088
Merge pull request #1451 from nextcloud/move-rtfiles
...
Move journal files away from sync folder to standardized location
2019-10-27 18:03:49 +01:00
Michael Schuster
8e8858178b
Merge branch 'master' into move-rtfiles
2019-10-27 17:49:22 +01:00
Michael Schuster
528352ba82
Merge pull request #1449 from nextcloud/lnx-domainname-desktopfiles
...
Linux/Wayland: Updated .desktop file naming scheme
2019-10-27 17:48:28 +01:00
Michael Schuster
e54f127a06
Merge branch 'master' into lnx-domainname-desktopfiles
2019-10-27 17:30:48 +01:00
Michael Schuster
d9fd9cfef2
Merge pull request #1454 from nextcloud/syncjournal-del-prio
...
Prioritize DELETE instruction in SyncFileVector (merged trees)
2019-10-27 17:29:03 +01:00
Michael Schuster
9618500975
fix tab spacing
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-27 17:25:50 +01:00
Michael Schuster
25076f2ddc
tab formatting (just a little more ;p)
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-27 17:03:23 +01:00
Dominique Fuchs
66912071a8
Merge branch 'syncjournal-del-prio' of https://github.com/nextcloud/desktop into syncjournal-del-prio
2019-10-27 16:56:07 +01:00
Dominique Fuchs
e9438549f4
tab formatting
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-27 16:55:37 +01:00
Dominique Fuchs
eff75a2059
Merge branch 'master' into move-rtfiles
2019-10-27 15:43:41 +01:00
Dominique Fuchs
d001d9d1a3
Merge branch 'master' into syncjournal-del-prio
2019-10-27 15:38:43 +01:00
Dominique Fuchs
5c3f71c097
Merge branch 'master' into qml-tray-menu
2019-10-27 15:38:16 +01:00
Dominique Fuchs
7f764f8108
Added basic UI [WIP] for new tray window
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-27 15:19:20 +01:00
Nextcloud bot
2dcf594fc6
[tx-robot] updated from transifex
2019-10-27 03:04:17 +00:00
Nextcloud bot
076469f385
[tx-robot] updated from transifex
2019-10-26 03:05:59 +00:00
Nextcloud bot
e178eeb7f5
[tx-robot] updated from transifex
2019-10-25 03:06:12 +00:00
Nextcloud bot
a8cf6e0443
[tx-robot] updated from transifex
2019-10-24 03:05:27 +00:00
Michael Schuster
725458b63c
Merge pull request #1554 from sryze/fix-duplicate-apps
...
Fix duplicate items in Apps menu (a bug introduced in #1477 )
2019-10-23 23:44:54 +02:00
Sergey Zolotarev
9a11bef263
Fix duplicate items in Apps menu (a bug introduced in #1477 )
...
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com >
2019-10-24 02:55:56 +06:00
Michael Schuster
b184cba953
Merge pull request #1553 from nextcloud/jospoortvliet-patch-1
...
Update ChangeLog
2019-10-23 22:45:55 +02:00
Jos Poortvliet
8b393ce792
Update ChangeLog
...
Link to https://github.com/nextcloud/desktop/releases as there's no plan to keep the changelog file up to date.
2019-10-23 21:30:40 +02:00
Nextcloud bot
f801ffe4f7
[tx-robot] updated from transifex
2019-10-23 03:05:14 +00:00
Camila Ayres
b293a5b818
Merge pull request #1529 from nextcloud/samu-workopen-patch-2-1
...
Replace command line Step 5 Install Homebrew
2019-10-22 15:08:11 +02:00
Camila Ayres
beffd726bd
Merge branch 'master' into samu-workopen-patch-2-1
2019-10-22 15:08:01 +02:00
Camila Ayres
41f6c9e52d
Merge pull request #1530 from nextcloud/samu-workopen-patch-1
...
Update Installing Mac Step 11
2019-10-22 15:01:58 +02:00
Camila Ayres
ce71673824
Merge branch 'master' into samu-workopen-patch-1
2019-10-22 14:59:45 +02:00
Camila Ayres
e05f187fcf
Merge pull request #1544 from asapelkin/address_sanitizer
...
Enabled address sanitizing for tests
2019-10-22 14:59:33 +02:00
Camila Ayres
04b5754653
Merge branch 'master' into address_sanitizer
2019-10-22 14:43:37 +02:00
Camila Ayres
44bc3692fd
Merge pull request #1527 from nextcloud/qt-5.12.5-update-submodules
...
Update submodules for Qt 5.12.5 (qtmacgoodies)
2019-10-22 14:41:51 +02:00
Camila Ayres
3a310f93e0
Merge branch 'master' into qt-5.12.5-update-submodules
2019-10-22 14:31:27 +02:00
Nextcloud bot
706769026d
[tx-robot] updated from transifex
2019-10-22 03:06:06 +00:00
asapelkin
704e34fa99
enabled address sanitizing for tests
...
Signed-off-by: asapelkin <asapelkin0x01@ya.ru >
2019-10-22 01:13:59 +03:00
Roeland Jago Douma
a6fae36cb2
Merge pull request #1536 from nextcloud/ci/bump5.12image/libsecret
...
Bump Qt5.12 image
2019-10-21 20:27:53 +02:00
Roeland Jago Douma
4c791abafc
Bump Qt5.12 image
...
Main improvement is that this image contains the libsecret.
So when building qtkeychain that should be used.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-10-21 14:50:25 +02:00
István Váradi
11e14f1726
Merge pull request #1531 from ivaradi/debian-dbus
...
Add libdbus-1-dev to the build dependencies
2019-10-21 14:03:03 +02:00
István Váradi
0273689ca9
Merge branch 'master' into debian-dbus
2019-10-21 11:39:51 +02:00
Nextcloud bot
05a56c2e8e
[tx-robot] updated from transifex
2019-10-21 03:06:00 +00:00
Michael Schuster
325dd8732e
Merge pull request #1487 from nextcloud/testSyncFileStatusTracker-winPath
...
Fix tests for Windows platform
2019-10-20 21:48:36 +02:00
Michael Schuster
4d5dd0f49c
Merge branch 'master' into testSyncFileStatusTracker-winPath
2019-10-20 21:33:19 +02:00
Michael Schuster
39d85fd008
Merge pull request #1532 from nextcloud/fix-msvc-clang-variadic-macro-warning-fix
...
MSVC Fix for PR #1526 : Fix clang's variadic macro warnings
2019-10-20 13:31:01 +02:00
Michael Schuster
a12164ad53
MSVC Fix for PR #1526 : Fix clang's variadic macro warnings
...
The recently merged #1526 caused the MSVC Builds on Windows to fail.
This patch sets the new CMake flag only if the compiler it not MSVC.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-20 12:52:52 +02:00
István Váradi
805b85a4d7
Add libdbus-1-dev to the build dependencies
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-10-20 10:23:49 +02:00
Nextcloud bot
cacb300ffd
[tx-robot] updated from transifex
2019-10-20 03:08:24 +00:00
samu-workopen
15e36c535f
Update Step 11
...
Step 11 is completely outdated, please replace it with:
Enable git submodules:
$ cd desktop
$ git submodule init
$ git submodule update
Generate the build files:
$ cd build
$ cmake .. -DCMAKE_INSTALL_PREFIX=~/nextcloud-desktop-client -DCMAKE_BUILD_TYPE=Debug -DNO_SHIBBOLETH=1
2019-10-19 16:11:49 +02:00
Camila Ayres
b5e51c7e34
Merge pull request #1528 from nextcloud/samu-workopen-patch-1
...
Update building instructions.
2019-10-19 15:14:17 +02:00
samu-workopen
e4482ef675
Replace command line Step 5 Install Homebrew
...
replace brew install "qt5 --with-qtwebkit" with "install qt5" otherwise it will not work
2019-10-19 15:06:07 +02:00
samu-workopen
09b3be25fc
Update building instructions
...
Added links and a description how to clone the repo
2019-10-19 14:21:04 +02:00
Michael Schuster
7235db2793
Merge branch 'master' into qt-5.12.5-update-submodules
2019-10-19 05:43:23 +02:00
Nextcloud bot
35005e46b4
[tx-robot] updated from transifex
2019-10-19 03:04:56 +00:00
Michael Schuster
abd50022d1
Update submodules for Qt 5.12.5 (qtmacgoodies)
...
Fetch the new submodule commits to get these fixes:
- Merge upstream: Retrieve the associated NSView more reliably: https://github.com/camilasan/qtmacgoodies/pull/1
- Bugfix for Qt 5.12.5 - Redraw the ToolBar: https://github.com/camilasan/qtmacgoodies/pull/2
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-19 05:04:41 +02:00
Michael Schuster
e9c12c32d2
Merge pull request #1526 from JohannesLorenz/clang-variadic-macro-warning-fix
...
Fix clang's variadic macro warnings
2019-10-19 04:41:54 +02:00
Michael Schuster
8950417d37
Merge branch 'master' into clang-variadic-macro-warning-fix
2019-10-19 04:37:42 +02:00
Michael Schuster
8c6e2f84c1
Merge pull request #1471 from tintou/master
...
Build with libcloudproviders on debian and in the AppImage
NOTE:
The admin/linux/Dockerfile is outdated and the following repo is currently used for our daily builds:
https://github.com/nextcloud/docker-ci/tree/master/client
This fix will be added there soon too.
2019-10-19 04:36:08 +02:00
Michael Schuster
d0aec7696a
Merge branch 'master' into master
2019-10-19 03:50:43 +02:00
Michael Schuster
a9da2a2277
Merge pull request #1456 from andwun/fix/too-low-default-poll-interval
...
Revert DEFAULT_REMOTE_POLL_INTERVAL back from 5 seconds to 30 seconds
2019-10-19 03:48:39 +02:00
Michael Schuster
4f1e4e149f
Merge branch 'master' into fix/too-low-default-poll-interval
2019-10-19 03:40:21 +02:00
Adrian Brzezinski
bd25144390
Merge branch 'issue_1351' of https://github.com/adrb/desktop into issue_1351
...
Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl >
2019-10-18 08:30:46 +02:00
Adrian Brzezinski
3d1fc20d01
Merge branch 'issue_1351' of https://github.com/adrb/desktop into issue_1351
...
Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl >
2019-10-18 08:24:50 +02:00
adrb
921b144d06
Merge branch 'master' into issue_1351
2019-10-18 08:19:32 +02:00
Adrian Brzezinski
12d306fa85
Merge branch 'issue_1351' of https://github.com/adrb/desktop into issue_1351
2019-10-18 08:18:19 +02:00
Adrian Brzezinski
3b750895b4
* fix for issue no. 1351
...
Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl >
2019-10-18 08:16:59 +02:00
Johannes Lorenz
8c334a1f43
Fix clang's variadic macro warnings
...
Using variadic macros like `qCWarning()` without any parameter for "..."
is a GNU extension, which causes a lot of `clang` warnings:
```
desktop/src/common/ownsql.cpp:74:24: warning: must specify at least one
argument for '...' parameter of variadic macro
[-Wgnu-zero-variadic-macro-arguments]
qCWarning(lcSql) << "Error:" << _error << "for" << filename;
^
/usr/include/qt/QtCore/qloggingcategory.h:140:11: note: macro 'qCWarning'
defined here
^
```
This patch tells `clang` to be silent.
Signed-off-by: Johannes Lorenz <j.git@lorenz-ho.me >
2019-10-18 05:25:05 +02:00
Nextcloud bot
6db3b2fb78
[tx-robot] updated from transifex
2019-10-18 03:04:52 +00:00
Michael Schuster
5775ec1ff1
Merge pull request #1504 from nextcloud/feature/remote-wipe
...
Remote wipe for RC1.
2019-10-17 22:23:37 +02:00
Michael Schuster
32bb31a417
Merge branch 'master' into feature/remote-wipe
2019-10-17 22:05:20 +02:00
Michael Schuster
87844f5ff4
Merge pull request #1523 from nextcloud/improvement/merge-ignored-files-notification
...
Merge the list of ignored files/symlinks into one Activity notification.
2019-10-17 22:04:18 +02:00
Camila San
19491ff85f
Once client gets 401/403 from the server, check if remote wipe was requested.
...
- When the the users logs because of 401 or 403 errors, it checks if the
server requested the remote wipe. If yes, locally deletes account and folders
connected to the account and notify the server. If no, proceeds to ask the
user to login again.
- The app password is restored in the keychain.
- WIP: The change also includes a test class for RemoteWipe.
Signed-off-by: Camila San <hello@camila.codes >
2019-10-17 20:11:31 +02:00
Camila San
8546d53b05
Merge the list of ignored files/symlinks into one Activity notification.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-10-17 18:45:33 +02:00
Adrian Brzezinski
dfb20586ce
* fix for issue no. 1351
2019-10-17 14:45:38 +02:00
Camila Ayres
5783c406a2
Merge branch 'master' into master
2019-10-17 13:44:07 +02:00
Camila Ayres
6c56811636
Merge branch 'master' into testSyncFileStatusTracker-winPath
2019-10-17 13:37:01 +02:00
Camila Ayres
08c7be5350
Merge pull request #1520 from nextcloud/fix-mac-crash-qtmacgoodies-pr-1
...
Pick from upstream: Update qtmacgoodies for an OSX crash fix #6930
2019-10-17 13:35:58 +02:00
Michael Schuster
ade9c6ce72
Merge branch 'master' into fix-mac-crash-qtmacgoodies-pr-1
2019-10-17 05:50:38 +02:00
Nextcloud bot
fdefb19bdb
[tx-robot] updated from transifex
2019-10-17 03:05:50 +00:00
Michael Schuster
ade50d0b92
Pick from upstream: Update qtmacgoodies for an OSX crash fix #6930
...
With Qt 5.12.5 this OC crash also applies to the Nextcloud Desktop Client on macOS.
For reference please see:
- https://github.com/owncloud/client/issues/6930
- 0dc7bc3328
For the required changes in the qtmacgoodies submodule see:
https://github.com/camilasan/qtmacgoodies/pull/1
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-17 04:29:33 +02:00
Michael Schuster
09bae4d6e1
Merge pull request #1478 from sryze/quit-wizard-fix
...
Don't run connection wizard when quitting the application
2019-10-16 14:01:42 +02:00
Michael Schuster
0c30d9cfe8
Merge branch 'master' into quit-wizard-fix
2019-10-16 05:19:21 +02:00
Nextcloud bot
94dae8d535
[tx-robot] updated from transifex
2019-10-16 03:04:57 +00:00
Michael Schuster
e8fc3ecf28
Merge branch 'master' into quit-wizard-fix
2019-10-16 04:43:41 +02:00
Michael Schuster
b3a03e9c58
Merge pull request #1516 from nextcloud/backport/1515/master
...
[master] Add new "styles" plugin to macOS deployment script for Qt 5.12.5
2019-10-16 01:44:49 +02:00
Michael Schuster
097b923871
Add new "styles" plugin to macOS deployment script for Qt 5.12.5
...
Qt 5.12 needs this library to use the correct style for Light / Dark Mode:
styles/libqmacstyle.dylib
The interface looks like from the 1990's without this library ;-)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-15 23:32:04 +00:00
Nextcloud bot
f422a63200
[tx-robot] updated from transifex
2019-10-15 03:04:26 +00:00
Nextcloud bot
eec460a32d
[tx-robot] updated from transifex
2019-10-13 03:05:59 +00:00
Nextcloud bot
5ccea62ba6
[tx-robot] updated from transifex
2019-10-12 03:05:06 +00:00
Nextcloud bot
529beb328a
[tx-robot] updated from transifex
2019-10-11 03:02:18 +00:00
Michael Schuster
796cc8cd28
Merge pull request #1495 from nextcloud/fix-flow2-content-length
...
Add a 'Content-Length: 0' header to initial POST requests
2019-10-10 08:08:26 +02:00
Michael Schuster
c8b4145214
Add a 'Content-Length: 0' header to initial POST requests
...
The webserver lighttpd rejected POST requests without a Content-length
header with "411 Length Required".
See: https://github.com/nextcloud/desktop/issues/1473
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-10 05:17:22 +02:00
Michael Schuster
04a9f0313a
Merge pull request #1481 from asapelkin/for_loop_optimization
...
Avoiding copying in range-based loops
2019-10-10 01:30:40 +02:00
Michael Schuster
6166961804
Merge pull request #1441 from nextcloud/trexcl
...
Fixed missing 'translatable' exclusions, added missing window titles
2019-10-10 01:29:57 +02:00
Michael Schuster
4ddc606361
Merge branch 'master' into for_loop_optimization
2019-10-10 01:12:57 +02:00
Michael Schuster
836c748cd9
Merge branch 'master' into trexcl
2019-10-10 01:12:48 +02:00
Michael Schuster
3bee0bcf04
Merge pull request #1032 from k1l1/master
...
Changed max GUI bandwidth limits
2019-10-10 01:09:01 +02:00
Michael Schuster
0d349d54b4
Fix outdated link to server admin docs
...
Sets the target version from "15" to "latest" and removes
"index.html" because this could get obsolete in the future too.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-10-10 01:03:46 +02:00
Michael Schuster
29123f4d9d
Merge branch 'master' into master
2019-10-10 00:45:04 +02:00
Michael Schuster
a16c1a8957
Merge branch 'master' into for_loop_optimization
2019-10-10 00:41:46 +02:00
Dominique Fuchs
c1cd308940
Merge branch 'master' into quit-wizard-fix
2019-10-09 09:18:26 +02:00
Sergey Zolotarev
4bba498229
Replace isQuitting flag with disconnect()
...
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com >
2019-10-09 11:07:00 +06:00
Nextcloud bot
40b2fc8848
[tx-robot] updated from transifex
2019-10-09 03:04:39 +00:00
Dominique Fuchs
6bc13fcab1
Merge branch 'master' into for_loop_optimization
2019-10-08 10:36:25 +02:00
Dominique Fuchs
c3cb7dfadd
Merge branch 'testSyncFileStatusTracker-winPath' of https://github.com/nextcloud/desktop into testSyncFileStatusTracker-winPath
2019-10-08 08:44:23 +02:00
Dominique Fuchs
7750d2198d
Don't need a second if for non-Windows, using Qt macro for platform check
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-08 08:44:08 +02:00
Dominique Fuchs
3ced2a6ea3
Merge branch 'master' into testSyncFileStatusTracker-winPath
2019-10-08 08:37:29 +02:00
Dominique Fuchs
f993e7c555
Fixed typo preventing successful path rename on Win and modified ASSERT for Window path styles
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-10-08 08:31:31 +02:00
Nextcloud bot
35df5691f2
[tx-robot] updated from transifex
2019-10-08 03:03:10 +00:00
asapelkin
6b71e4ec6f
Merge branch 'master' into for_loop_optimization
2019-10-07 15:31:01 +03:00
Camila Ayres
9c199cc753
Merge pull request #1477 from sryze/tray-menu-fix
...
Prevent jumping of tray menu
2019-10-07 12:53:28 +02:00
asapelkin
57f9b8159f
Merge branch 'master' into for_loop_optimization
2019-10-07 12:35:18 +03:00
Camila Ayres
a94e116926
Merge branch 'master' into tray-menu-fix
2019-10-07 09:56:40 +02:00
Dominique Fuchs
75444e44b9
Merge branch 'master' into master
2019-10-07 09:45:22 +02:00
Nextcloud bot
dbfa5dc786
[tx-robot] updated from transifex
2019-10-07 03:02:44 +00:00
asapelkin
17f39bd09d
little loops optimization
...
Signed-off-by: asapelkin <asapelkin0x01@ya.ru >
2019-10-07 01:29:55 +03:00
Nextcloud bot
7c8e650c5a
[tx-robot] updated from transifex
2019-10-06 03:05:29 +00:00
Sergey Zolotarev
eaddc55267
Don't run connection wizard when quitting the application
...
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com >
2019-10-05 22:38:47 +06:00
Sergey Zolotarev
f6b6765424
Prevent jumping of tray menu
...
Instead of adding the "Apps" menu after the apps are fetched, add it
from the start (together with other actions) but in a disabled state,
and enable it after the apps data is ready.
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com >
2019-10-05 22:10:35 +06:00
Dominique Fuchs
f3ab9d5fef
Merge branch 'master' into master
2019-10-05 10:35:59 +02:00
Nextcloud bot
998354b5ab
[tx-robot] updated from transifex
2019-10-05 03:04:09 +00:00
Michael Schuster
852d39e271
Merge pull request #1465 from nextcloud/show-server-vers
...
Add server info to menu
2019-10-05 01:50:38 +02:00
Michael Schuster
7deb74cc22
Merge branch 'master' into show-server-vers
2019-10-05 00:44:08 +02:00
Michael Schuster
ba6d1ab886
Merge pull request #1474 from nextcloud/rakekniven-patch-1
...
Fixed grammar
2019-10-05 00:43:05 +02:00
Michael Schuster
c72aa457b3
Merge branch 'master' into rakekniven-patch-1
2019-10-05 00:04:39 +02:00
István Váradi
6ed6a5e8ea
Merge pull request #1467 from ivaradi/fix-eoan-build
...
Remove kdelibs5-dev from the build dependencies for Eoan
2019-10-04 21:29:51 +02:00
István Váradi
fd7ba861a1
Merge branch 'master' into fix-eoan-build
2019-10-04 20:15:38 +02:00
rakekniven
b25aa99de7
Fixed grammar
...
Reported at Transifex.
See https://www.transifex.com/nextcloud/nextcloud/translate/#nl/client/182396083
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2019-10-04 08:10:55 +02:00
Nextcloud bot
dddb233f16
[tx-robot] updated from transifex
2019-10-04 03:05:53 +00:00
Corentin Noël
04dd02c295
Build with libcloudproviders on debian and in the AppImage
...
Signed-off-by: Corentin Noël <corentin.noel@collabora.com >
2019-10-03 10:33:46 +02:00
Nextcloud bot
3f495a30e0
[tx-robot] updated from transifex
2019-10-03 03:03:10 +00:00
István Váradi
37f74291b5
Remove kdelibs5-dev from the build dependencies for Eoan
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-10-02 20:04:23 +02:00
Nextcloud bot
361c5a5a54
[tx-robot] updated from transifex
2019-10-02 03:05:56 +00:00
Daniel Kesselberg
4114fe68c9
Add server info to menu
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2019-10-01 16:16:20 +02:00
Camila Ayres
4dddf88569
Merge pull request #1459 from tribut/fix-ldap-display-name
...
Use user-provided username in `displayName()` - Fix #836
2019-10-01 15:06:15 +02:00
Camila Ayres
7f19d5669b
Merge branch 'master' into fix-ldap-display-name
2019-10-01 12:34:39 +02:00
Roeland Jago Douma
c6705ecd9c
Merge pull request #1462 from tribut/fix-typo-elided
...
Fix typo
2019-10-01 12:02:36 +02:00
Felix Eckhofer
28da954aad
Fix typo
...
Signed-off-by: Felix Eckhofer <felix@eckhofer.com >
2019-10-01 08:25:24 +02:00
Nextcloud bot
a8fbbc65c1
[tx-robot] updated from transifex
2019-10-01 03:15:23 +00:00
Michael Schuster
47ffcfd561
Merge pull request #1461 from nextcloud/issue/1458
...
Checks if exclude file is empty before creating the regular expressions.
2019-09-30 21:52:04 +02:00
Camila San
481d8d3a0b
Checks if exclude file is empty before creating the regular expressions.
...
The default file created by the application it is not empty.
Signed-off-by: Camila San <hello@camila.codes >
2019-09-30 20:38:56 +02:00
Felix Eckhofer
ace142bb23
Use user-provided username in displayName()
...
This replaces `davUser()`, which is replaced by a numeric ID when using
LDAP, by the username that was actually used for logging in.
Fixes #836
Signed-off-by: Felix Eckhofer <felix@eckhofer.com >
2019-09-30 17:56:14 +02:00
Dominique Fuchs
ea14baff6c
Merge branch 'lnx-domainname-desktopfiles' of https://github.com/nextcloud/desktop into lnx-domainname-desktopfiles
2019-09-30 11:00:10 +02:00
Dominique Fuchs
0c4c5c5f8b
Fixed typo / double suffix
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-30 10:59:59 +02:00
Dominique Fuchs
0a407a39b0
Merge branch 'master' into lnx-domainname-desktopfiles
2019-09-30 09:46:15 +02:00
Dominique Fuchs
3ad1c0e7a8
Created wrapper variable LINUX_APPLICATION_ID to clean up code
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-30 09:45:41 +02:00
Nextcloud bot
a140720901
[tx-robot] updated from transifex
2019-09-30 03:12:41 +00:00
Nextcloud bot
141d31c546
[tx-robot] updated from transifex
2019-09-29 03:15:41 +00:00
Andreas Wunderlich
f293dbfeeb
Revert default remote poll interval back from 5 seconds to 30 seconds
...
Signed-off-by: Andreas Wunderlich <code@andwun.me >
2019-09-29 00:58:35 +02:00
Dominique Fuchs
3f533edba6
Merge branch 'master' into syncjournal-del-prio
2019-09-28 09:29:04 +02:00
Dominique Fuchs
10a5e75cd8
Harmonizing sorting algorithm (again)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-28 09:17:12 +02:00
Nextcloud bot
58349fae02
[tx-robot] updated from transifex
2019-09-28 03:04:02 +00:00
Dominique Fuchs
3269402f48
Merge branch 'syncjournal-del-prio' of https://github.com/nextcloud/desktop into syncjournal-del-prio
2019-09-27 12:21:06 +02:00
Dominique Fuchs
26f7848821
Fix logic for DELETE prio, now (hopefully) in harmony with destination sorting
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-27 12:21:02 +02:00
Dominique Fuchs
08efb40599
Merge branch 'master' into syncjournal-del-prio
2019-09-27 09:59:32 +02:00
Dominique Fuchs
f81e5be119
Implemented second sorting step for SyncFileVector (merged trees) to prioritize DELETEs
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-27 09:34:49 +02:00
Nextcloud bot
cf4fcebc53
[tx-robot] updated from transifex
2019-09-27 03:04:15 +00:00
Michael Schuster
00db94a73c
Revert "Fix White Window issue on Windows after Qt 5.12.4 upgrade"
...
This reverts commit 8f616969ab .
Turns out that with the upgrade to the new released Qt 5.12.5 the issue
has been solved by the Qt developers, so this fix becomes obsolete.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-27 04:58:12 +02:00
Dominique Fuchs
a8ecf486d1
Updated AppImage instructions w/ new desktop file name
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-26 21:01:01 +02:00
Dominique Fuchs
83918619cf
Corrected new .desktop file location in forgotten function
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-26 20:56:14 +02:00
Dominique Fuchs
f52c330c22
cleanup and migration for location change
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-26 19:09:40 +02:00
Dominique Fuchs
67ed54671b
Adapted for cmd version and added migration step for config file
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-26 17:47:01 +02:00
Dominique Fuchs
fc6b895f52
moved default db sync file to Qt standard path AppDataLocation
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-26 17:09:24 +02:00
Camila Ayres
6f9256f290
Merge branch 'master' into lnx-domainname-desktopfiles
2019-09-26 13:26:22 +02:00
Camila Ayres
f6b03f0186
Merge pull request #1443 from nextcloud/enhancement/change-share-menu-wording
...
Improve wording of the context menu in the file manager extension.
2019-09-26 13:20:42 +02:00
Dominique Fuchs
555c513acb
Merge branch 'master' into lnx-domainname-desktopfiles
2019-09-26 12:51:20 +02:00
Dominique Fuchs
96da4674f9
Updated .desktop file naming scheme
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-26 12:36:05 +02:00
Dominique Fuchs
e5f0ee3b92
Fixed wrongly formatted define statement
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-26 12:35:32 +02:00
Camila Ayres
570041e3b4
Merge branch 'master' into enhancement/change-share-menu-wording
2019-09-26 11:12:43 +02:00
Camila Ayres
c0e7120b12
Merge pull request #1445 from nextcloud/fix-white-window
...
Fix White Window issue on Windows after Qt 5.12.4 upgrade
2019-09-26 11:04:14 +02:00
Michael Schuster
82a73e443c
Merge branch 'master' into fix-white-window
2019-09-26 05:21:42 +02:00
Nextcloud bot
5d3a8e3725
[tx-robot] updated from transifex
2019-09-26 03:03:05 +00:00
Michael Schuster
8f616969ab
Fix White Window issue on Windows after Qt 5.12.4 upgrade
...
Qt 5.12.4 seems to introduce a new bug on Windows, causing the settings window
to not be redrawn when re-opening it, for example by clicking at the tray icon.
As a workaround this fix starts a 100 ms timer to be fired once upon
QDialog::showEvent is called.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-26 04:59:17 +02:00
Michael Schuster
cb60e8aa90
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-26 01:41:06 +02:00
Camila San
b9f0e444e8
Improve wording of the context menu in the file manager extension.
...
'Share...' -> 'Share options'
'private link' -> 'internal link'
Removes 'to clipboard' from 'copy link' options.
Signed-off-by: Camila San <hello@camila.codes >
2019-09-25 19:54:22 +02:00
Dominique Fuchs
cd89efc24b
Fixed some missing 'translatable' exclusions, added missing window titles in flow dialogs
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-25 14:02:59 +02:00
Nextcloud bot
8ebacae846
[tx-robot] updated from transifex
2019-09-25 03:04:06 +00:00
Camila Ayres
7a033395f2
Merge pull request #1438 from nextcloud/enhancement/change-share-menu-wording
...
Changes wording in the share context menu.
2019-09-24 16:52:27 +02:00
Camila San
dd90ed9643
Changes wording in the share context menu.
...
Instead of only Nextcloud it says "Share via Nextcloud".
Signed-off-by: Camila San <hello@camila.codes >
2019-09-24 16:25:03 +02:00
Camila Ayres
d392843c12
Merge pull request #1434 from nextcloud/ui-msg-delete-all-files
...
UI improvement: Message box: Delete / Keep all files
2019-09-24 12:24:36 +02:00
Camila Ayres
e944aa6f2d
Merge branch 'master' into ui-msg-delete-all-files
2019-09-24 12:06:09 +02:00
Nextcloud bot
08c76f5997
[tx-robot] updated from transifex
2019-09-24 03:07:21 +00:00
Nextcloud bot
4c2895c92f
[tx-robot] updated from transifex
2019-09-21 03:02:36 +00:00
Dominique Fuchs
d8dca83dd5
Merge branch 'master' into recipientnote
2019-09-20 19:01:34 +02:00
Dominique Fuchs
0ff91574d2
show only 'shared with you by...' if it's not the current user itself
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-20 18:50:32 +02:00
Michael Schuster
30cff4e4f8
UI improvement: Message box: Delete / Keep all files
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-20 16:47:11 +02:00
Nextcloud bot
1138118d8e
[tx-robot] updated from transifex
2019-09-20 03:04:15 +00:00
Dominique Fuchs
be2c1fdb89
Merge pull request #1427 from mawasak/master
...
Fix for #1382 "linux client crashes for no discernable reason"
2019-09-19 19:51:12 +02:00
Dominique Fuchs
030e85c06c
Merge branch 'master' into master
2019-09-19 17:05:04 +02:00
Camila Ayres
b493f03d42
Finish adding tags to the the exemptLabels list for the stale bot.
2019-09-19 14:47:40 +02:00
Camila Ayres
4bfd2a5d77
Update exempt labels config for stale bot.
2019-09-19 13:36:44 +02:00
Camila Ayres
4945dd126a
Add configuration file for funding.
...
Bounty source link.
2019-09-19 13:05:14 +02:00
Camila Ayres
8caa997181
Add configuration file for stale bot.
2019-09-19 12:59:21 +02:00
Dominique Fuchs
2b88ea390c
Merge branch 'master' into recipientnote
2019-09-19 10:05:06 +02:00
Dominique Fuchs
31f3b322c8
Color corrections and sharer=self case implementation
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-19 10:04:52 +02:00
Nextcloud bot
55ebd5154c
[tx-robot] updated from transifex
2019-09-19 03:06:20 +00:00
Mariusz Wasak
dcc33f3417
Fix for #1382 "linux client crashes for no discernable reason"
...
There in no "return" in
PropagateUploadFileCommon::slotStartUpload in if (prevModtime != _item-
>_modtime) {... }
There is possibility that
PropagateItemJob::done(status, errorString)
maybe called two times from PropagateUploadFileCommon::slotStartUpload
1. in if (prevModtime != _item->_modtime) {... }
2. in if (fileIsStillChanging(*_item)) {..}
if changes in files are frequent the second call is possible.
This two calls has effect in PropagatorCompositeJob::slotSubJobFinished
and job is removed two times in _runningJobs.remove(i);
(the second time with argumetnt -1 (because first call removed job).
This return was removed in commit
efc039863b - by accident I think.
Good simulation is to synchronize firefox profile with frequent page
refresh.
Signed-off-by: Mariusz Wasak <mawasak@gmail.com >
2019-09-18 18:18:12 +02:00
Michael Schuster
eab8c1eb7e
Merge branch 'master' into recipientnote
2019-09-18 14:02:47 +02:00
Dominique Fuchs
5a9fc02f07
Correcting autoraise for widget w/ background fill
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-18 13:40:14 +02:00
Dominique Fuchs
9d6780d6c1
Finishing PR #1154 adding note when sharing
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-18 13:37:49 +02:00
Nextcloud bot
811c3c995a
[tx-robot] updated from transifex
2019-09-18 03:04:37 +00:00
Michael Schuster
44ed5744f1
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-17 17:46:17 +02:00
Nextcloud bot
179bbffd76
[tx-robot] updated from transifex
2019-09-17 02:55:13 +00:00
Michael Schuster
207de071f4
Add warning for failed chown in libsync/propagatedownload.cpp
...
In addition to PR 1409 generate warnings if chown fails.
See: https://github.com/nextcloud/desktop/pull/1409
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-16 20:26:18 +02:00
Michael Schuster
0845f25f70
Merge pull request #1240 from ivan-cukic/ivan/remote-size-retrieved-race-condition
...
Race condition in the remote size loading logic
2019-09-16 20:08:29 +02:00
Michael Schuster
916d414543
Merge branch 'master' into ivan/remote-size-retrieved-race-condition
2019-09-16 19:17:00 +02:00
Michael Schuster
b93fbddf05
Merge pull request #1409 from DominiqueFuchs/msvc-warn-audit
...
Review of msvc/gcc warnings -> code cleanup, prevention of implicit casts, variadic macros
2019-09-16 19:08:10 +02:00
Michael Schuster
b40e3e7b4e
Merge branch 'master' into msvc-warn-audit
2019-09-16 16:55:42 +02:00
Kilian Pfeiffer
c46ca5c256
Merge branch 'master' into master
2019-09-16 13:41:15 +02:00
Nextcloud bot
44d954ade9
[tx-robot] updated from transifex
2019-09-16 02:55:42 +00:00
Dominique Fuchs
cdc939ae97
Merge pull request #1214 from Thaodan/fix_urlscheme_warning
...
fix qt warning about registering a URL sheme first.
2019-09-15 19:31:20 +02:00
Dominique Fuchs
a2a753a34b
Merge branch 'master' into fix_urlscheme_warning
2019-09-15 19:12:22 +02:00
Camila Ayres
d0e25c230a
Merge pull request #1149 from nextcloud/bugfixing-slideshow
...
slideshow buttons
2019-09-15 18:52:05 +02:00
Camila Ayres
82a67a44c4
Merge branch 'master' into bugfixing-slideshow
2019-09-15 18:18:46 +02:00
Camila Ayres
233a423e8c
Merge pull request #1420 from nextcloud/e2e-csr-transmit
...
Fixing E2E CSR transmission failure for new connections
2019-09-15 17:22:49 +02:00
Dominique Fuchs
5e099adb2f
Merge branch 'master' into e2e-csr-transmit
2019-09-15 12:03:16 +02:00
Dominique Fuchs
a35b346e62
Fixed e2e key transmission issue after generation (forgotten content type on sendrequest())
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-15 11:53:57 +02:00
Dominique Fuchs
7d4406254a
Merge branch 'master' into fix_urlscheme_warning
2019-09-15 09:56:16 +02:00
Nextcloud bot
70091726c9
[tx-robot] updated from transifex
2019-09-15 02:57:10 +00:00
Nextcloud bot
564088680a
[tx-robot] updated from transifex
2019-09-14 02:55:51 +00:00
Dominique Fuchs
1eb61b7949
Fixed unused var
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-13 20:49:59 +02:00
Dominique Fuchs
f6bac6cfdd
Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow
2019-09-13 20:38:16 +02:00
Dominique Fuchs
e8c8fe4223
Added slight svg transparency as requested in ref issue, fixed bg detection logic
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-13 20:38:03 +02:00
Dominique Fuchs
3659bca0ec
Merge branch 'master' into bugfixing-slideshow
2019-09-13 17:30:25 +02:00
Dominique Fuchs
ace3da841c
(Maybe) finished implementation of themed wizard buttons and accessibility refinements and thus implementation of helper fct. to retrieve themed QIcons.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-13 17:26:39 +02:00
Kilian Pfeiffer
457b0c3ab1
Merge branch 'master' into master
2019-09-13 08:57:06 +02:00
Dominique Fuchs
544229d1e8
[WIP] themed button implementation
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-13 08:24:02 +02:00
Dominique Fuchs
af05db895c
[WIP] Resource file and include changes as well as new control icons for wizard slide buttons
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-13 08:08:39 +02:00
Nextcloud bot
2958cf2180
[tx-robot] updated from transifex
2019-09-13 02:57:35 +00:00
Michael Schuster
32c114bd17
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-13 02:19:22 +02:00
Dominique Fuchs
1d96b102c0
Layout optimizations and tab access for self-hosting link
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-12 22:00:43 +02:00
Michael Schuster
d6fce49162
Merge pull request #1414 from nextcloud/fix-double-slashes
...
Fix double slashes
2019-09-12 21:25:43 +02:00
Dominique Fuchs
ff5bf8634f
fix naming for slide navigation, adapted everywhere to be consistent
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-12 20:59:03 +02:00
Dominique Fuchs
f49cd1850c
Restructured layout, as the initial change were too broken (after additions through the last months)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-12 20:53:40 +02:00
Dominique Fuchs
d420242fcb
Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow
2019-09-12 17:56:30 +02:00
Dominique Fuchs
c873da75e4
Fixed wrong resource paths
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-12 17:52:31 +02:00
Dominique Fuchs
9b60573d7e
Merge branch 'master' into bugfixing-slideshow
2019-09-12 17:09:26 +02:00
Dominique Fuchs
907f36bfcb
Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow
2019-09-12 16:43:54 +02:00
Dominique Fuchs
04fedf83b4
Added newly created next/prev svg's and fixed reduntant layout parts in wizard
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-12 16:43:24 +02:00
Michael Schuster
f3d774e2e5
Merge branch 'master' into fix-double-slashes
2019-09-12 05:09:21 +02:00
Nextcloud bot
8f40161fa2
[tx-robot] updated from transifex
2019-09-12 02:55:19 +00:00
Dominique Fuchs
febc035063
Merge branch 'master' into ivan/remote-size-retrieved-race-condition
2019-09-11 22:56:34 +02:00
Dominique Fuchs
4902751d02
Merge branch 'master' into bugfixing-slideshow
2019-09-11 22:17:57 +02:00
Dominique Fuchs
45bd869a15
Merge branch 'master' into master
2019-09-11 22:06:22 +02:00
Michael Schuster
905c1532fe
fix comment typo
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-11 17:31:16 +02:00
Michael Schuster
c3d8657619
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-11 17:27:49 +02:00
Nextcloud bot
51ff031de5
[tx-robot] updated from transifex
2019-09-11 03:05:21 +00:00
Dominique Fuchs
6b9395a3c5
Merge pull request #916 from nextcloud/icons
...
Remove outdated (and unused) icons
2019-09-10 16:15:43 +02:00
Dominique Fuchs
b1db012094
Merge branch 'master' into icons
2019-09-10 14:36:40 +02:00
Dominique Fuchs
556e8d39aa
Merge pull request #719 from tuxmaster5000/owncloud
...
Rename owncloud tests to nextcloud
2019-09-10 14:31:30 +02:00
Dominique Fuchs
cd5ff96904
Merge branch 'master' into owncloud
2019-09-10 13:11:02 +02:00
Dominique Fuchs
24a20ec758
Merge pull request #1039 from javierllorente/master
...
Add sync date next to "Synchronized with local folder"
2019-09-10 11:38:59 +02:00
Dominique Fuchs
4edab98b58
Merge branch 'master' into owncloud
2019-09-10 11:03:39 +02:00
Dominique Fuchs
dd130ede8f
Merge branch 'master' into master
2019-09-10 10:17:37 +02:00
Dominique Fuchs
81bcb46ef2
Merge pull request #1231 from Zottel92/issue1216/IgnoreEmacsRecoveryFiles
...
issue1216: added sync-exclude entry for emacs recovery files
2019-09-10 09:46:24 +02:00
Dominique Fuchs
37f532c1f0
Merge branch 'master' into issue1216/IgnoreEmacsRecoveryFiles
2019-09-10 09:02:55 +02:00
Nextcloud bot
04f2bd4baa
[tx-robot] updated from transifex
2019-09-10 03:06:52 +00:00
Dominique Fuchs
07df659a3f
Merge branch 'master' into issue1216/IgnoreEmacsRecoveryFiles
2019-09-09 21:46:39 +02:00
Dominique Fuchs
e89ff9ae61
Merge branch 'master' into msvc-warn-audit
2019-09-09 20:16:52 +02:00
Dominique Fuchs
c662ff1902
fixed wrongly assigned pointer, didn't recognize class
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 20:06:32 +02:00
Dominique Fuchs
a3825080db
Use -Wno-gnu-zero-variadic-macro-arguments only for Clang
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:35:30 +02:00
Dominique Fuchs
a237493def
Q_UNUSED for atm unused parameters
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:38 +02:00
Dominique Fuchs
3a0cd45782
Declared Q_UNUSED for as-of-now unused parameters.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:37 +02:00
Dominique Fuchs
f08cc08eb2
Prevented warning regarding operator precedence - enhanced clarity by adding parentheses
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:36 +02:00
Dominique Fuchs
e3685b951c
removed reduntant /* within a comment
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:35 +02:00
Dominique Fuchs
6b04e2f77b
Remove unnecessary argument
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:34 +02:00
Dominique Fuchs
2e8b7771b0
Prevent use of uninitialized folder pointer.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:32 +02:00
Dominique Fuchs
26e98d35e6
Added forgotten case when parsing log through gui. LockedFiles were not communicated.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:31 +02:00
Dominique Fuchs
ab3d0141ec
initialize _modtime to prevent undefined usage
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 19:23:30 +02:00
Dominique Fuchs
39df36c247
Use return type to prevent warning and determine chown success. Added TODO
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 18:06:29 +02:00
Dominique Fuchs
7473cdf184
Removed disabling of msvc warning to prevent generating a unknown option for other compilers in turn. Now detect specifically GCC in ifdef
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-09 13:46:46 +02:00
Nextcloud bot
4f7d7e3601
[tx-robot] updated from transifex
2019-09-09 03:06:29 +00:00
Dominique Fuchs
49a6dc311e
Merge branch 'master' into msvc-warn-audit
2019-09-08 20:00:48 +02:00
Dominique Fuchs
c585e81530
Moved macro definition due to timing issues while compiling when relying on header inheritance
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 19:46:08 +02:00
Dominique Fuchs
c779098772
Conditional (based on Qt version) use of 'horizontalAdvance' to provide better UI experience. See https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 19:37:56 +02:00
Dominique Fuchs
cc07ed1ee8
commit 222b2d did the trick. now streamlined use of https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION_CHECK
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 19:22:40 +02:00
Dominique Fuchs
222b2d8645
Further testing of cond. include of Qt library > 5.9. Utilized different macro.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 19:17:00 +02:00
Dominique Fuchs
f41eeaf6ec
Fixed another logic error -> logical to bitwise OR for QTLEGACY
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 18:51:54 +02:00
Dominique Fuchs
48097801e8
Fixed logic error in QTLEGACY macro and added forgottin #if clause for header file
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 18:42:40 +02:00
Dominique Fuchs
dca83aad45
Added macro definition and compile-time condition to support Qt < 5.9
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 17:33:34 +02:00
Dominique Fuchs
be7a524557
Indeed, DWORD is a special snowflake - only when on _WIN32
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 16:22:08 +02:00
Dominique Fuchs
0827ff0995
Fixed wrongly formatted args for win32 linker flags resulting in 'unrecognized option' for all of them. Remark: /WL is for VS only, useless (and not necessary for msvc cmd)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 16:09:58 +02:00
Dominique Fuchs
503b9de2a0
Fixed missing braces
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 15:49:53 +02:00
Dominique Fuchs
a2d47cdec4
Qt: Fixed numerous deprecated calls by adapting newer ones
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 15:40:49 +02:00
Dominique Fuchs
ba74c24d8f
Added cmake preprocessor definitions when using msvc regarding the 'safe' versions of CRT functions
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 14:47:35 +02:00
Dominique Fuchs
d60a216982
Use existing fct for RegKeyQuery instead of redundant subroutine
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 13:44:00 +02:00
Dominique Fuchs
d6af025a46
Numoerous safe conversions implemented. Added additional Utility::convertSizeToDWORD for windows builds.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 11:33:20 +02:00
Dominique Fuchs
82fa10c227
Corrected namespace when calling convertSizetoUint
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 10:21:59 +02:00
Nextcloud bot
13b2b5253e
[tx-robot] updated from transifex
2019-09-08 03:10:00 +00:00
Dominique Fuchs
46e0a05078
Renamed conversion function to make intention more clear. Also defaulted to 'controlled truncation' to not stupidly crash. TBD/TODO: Better handling for such things.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 02:20:24 +02:00
Dominique Fuchs
8329de4cee
Selectively and temporary disabled warning about unknown preprocessor declarative for msvc when using specific GCC instruction.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 02:07:52 +02:00
Dominique Fuchs
b4dee67bf5
Implemented Utility::convert function to convert size_t -> uint safely and on the fly. Often necessary for Qt and WIN32 functions. Using this will not generate compiler warnings of possible truncation. First call implemented in ownsql.cpp
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 02:04:50 +02:00
Dominique Fuchs
5ae3435fe6
Fixed broken overloading mechanism of variadic templates. See code comment for further information.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-08 01:09:22 +02:00
Dominique Fuchs
9a256fcbfe
usage of UINT as iterator here because comparing with UINT retval from DragQueryFile
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-07 21:42:10 +02:00
Dominique Fuchs
112d2bfe11
Removed redundant (and wrong in terms of it's value) definitions for WINVER/_WIN32_WINNT
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-07 21:28:12 +02:00
Dominique Fuchs
69a11a7ec1
Removed redundant (and wrong in terms of it's value) definitions for WINVER/_WIN32_WINNT
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-07 21:26:40 +02:00
Dominique Fuchs
3960ffea3f
Removed redundant (and wrong in terms of it's value) definitions for WINVER/_WIN32_WINNT
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-07 20:58:20 +02:00
Dominique Fuchs
78543deee4
Updated WINVER/_WIN32_WINNT from 0x0600 to 0x0601 (e.g. Server 2008/Vista to 7) as 7 is reasonable and noted everywhere as requirement
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-07 20:55:49 +02:00
Dominique Fuchs
4dd49327e4
Merge remote-tracking branch 'upstream/master'
2019-09-07 19:41:35 +02:00
Nextcloud bot
2121e7116e
[tx-robot] updated from transifex
2019-09-07 03:06:08 +00:00
Michael Schuster
67107a4f5d
Fix double slashes in WebDAV URLs (account setup wizard)
...
Sanitize URL paths to elaminate double-slashes in the URL path string,
used for the first connection by the account setup wizard.
Example: https://cloud.example.com/remote.php/webdav//
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-07 04:18:07 +02:00
Michael Schuster
0557d53f5f
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-07 03:30:47 +02:00
Michael Schuster
819a006a17
Replace old NSI Windows setup wizard graphics
...
New UI resources based on current https://github.com/nextcloud/promo
New:
- Icon based on https://github.com/nextcloud/desktop/pull/1401
- Wizard image & header image (dotted background replaces old cloud background)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-07 02:00:49 +02:00
Dominique Fuchs
65ee5915af
Merge remote-tracking branch 'upstream/master'
2019-09-06 21:00:37 +02:00
Dominique Fuchs
8ad3b18932
Merge branch 'master' of https://github.com/DominiqueFuchs/desktop
2019-09-06 20:43:51 +02:00
Camila San
c835c39491
Bump master version to 2.7.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-09-06 18:20:52 +02:00
Michael Schuster
4cb45d5d6a
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-06 17:57:52 +02:00
Camila Ayres
acb9fc7c8e
Merge pull request #1408 from nextcloud/flow2-ui-qt5-compat
...
Qt5.5 compatiblity patch for login flow V2 + UI improvement
2019-09-06 17:56:09 +02:00
Camila Ayres
081f9741e4
Merge branch 'master' into flow2-ui-qt5-compat
2019-09-06 17:32:40 +02:00
Camila Ayres
a70b7d5852
Merge pull request #1405 from DominiqueFuchs/w10-start-logo
...
Full-Scaled new logo in Windows 10 start menu tile
2019-09-06 17:22:10 +02:00
Michael Schuster
8b2c47cdcb
Remove old Qt 5.5 patch for Xenial
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-06 17:05:18 +02:00
Camila Ayres
a3beb9ba41
Merge branch 'master' into w10-start-logo
2019-09-06 17:02:06 +02:00
Camila Ayres
c4dfe576d0
Merge pull request #1399 from DominiqueFuchs/master
...
Integrated registry check on windows when hasDarkSystray is called.
2019-09-06 17:01:53 +02:00
Camila Ayres
0841fe8dd3
Merge branch 'master' into master
2019-09-06 16:50:27 +02:00
Michael Schuster
b28ae98d58
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-06 16:45:17 +02:00
Camila Ayres
c3b270ba26
Merge pull request #1401 from DominiqueFuchs/logo-update
...
Logo update
2019-09-06 16:37:59 +02:00
Camila Ayres
9ab5241459
Merge branch 'master' into w10-start-logo
2019-09-06 16:03:54 +02:00
Camila Ayres
ec603b061d
Merge branch 'master' into logo-update
2019-09-06 15:42:02 +02:00
Michael Schuster
b792a627e2
Qt5.5 compatiblity patch for login flow V2 + UI improvment
...
Removes the right-click function for the "Re-open browser" buttons because
they are not intuitive for the user.
Adds a dedicated "Copy link" button.
Implements Qt 5.5 fixes based on: https://github.com/nextcloud/desktop/pull/1392
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-09-06 14:40:54 +02:00
Michael Schuster
0e8c6a176b
Merge branch 'master' of https://github.com/nextcloud/desktop
2019-09-06 14:39:10 +02:00
Camila Ayres
0353724472
Merge pull request #1374 from Ram-Z/per-directory-ignore
...
Read .sync_exclude.lst in each subdirectory
2019-09-06 14:20:34 +02:00
Martin Sucha
bbb295fea4
Use newer digest algorithms in TLS error dialog
...
MD5 has been broken for a long time now and SHA1 has been
deprecated as well. SHA1 is not used when issuing new
publicly trusted certificates since 1 January 2016[1] and
there are more and more effective attacks[2][3] against it,
so display SHA1 fingerprint only for old certificates
to encourage use of safer digests by users.
So, we display SHA-256 and SHA-512 fingerprints instead in
the common case.
[1] https://cabforum.org/wp-content/uploads/CA-Browser-Forum-BR-1.6.5.pdf
[2] https://shattered.io/static/shattered.pdf
[3] https://eprint.iacr.org/2019/459.pdf
Signed-off-by: Martin Sucha <git@mm.ms47.eu >
2019-09-06 14:07:07 +02:00
Camila Ayres
d36ddb752a
Merge branch 'master' into per-directory-ignore
2019-09-06 13:35:28 +02:00
Dominique Fuchs
680f70aa1a
Merge branch 'master' into w10-start-logo
2019-09-06 09:30:12 +02:00
Dominique Fuchs
4ea64bf9ee
Final commit to resolve #22 (at least in desktop repo, final bits have to be set in client-building).
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-06 09:24:06 +02:00
Dominique Fuchs
c1dd0079d9
Modified CMakeLists (src/gui/) to install VisualElements logo files in appropiate install output folder
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-06 08:35:46 +02:00
Dominique Fuchs
f33d0a322d
Renamed files for consistent sheme & use in CMakeLists (/src/gui)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-06 08:23:48 +02:00
Dominique Fuchs
429c9afd60
Added files for start menu icon (70 & 150px) on Windows 10
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-06 07:44:49 +02:00
Nextcloud bot
a6653af440
[tx-robot] updated from transifex
2019-09-06 03:03:36 +00:00
Dominique Fuchs
abb2711d26
Merge branch 'master' into logo-update
2019-09-05 21:38:17 +02:00
Dominique Fuchs
0a5ba5a3c7
Merge pull request #1402 from DominiqueFuchs/gitignore
...
Updated .gitignore to integrate unwanted files when working with VSC …
2019-09-05 20:44:43 +02:00
Dominique Fuchs
0a643c06e7
Merge branch 'master' into gitignore
2019-09-05 20:31:23 +02:00
Dominique Fuchs
6f5dcfa78b
Complementary renaming in theme.qrc
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-05 19:59:49 +02:00
Dominique Fuchs
e2f7947966
Check for possible case failure when building on drone
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-05 19:52:03 +02:00
Dominique Fuchs
4b9e8274b5
Merge branch 'logo-update' of https://github.com/DominiqueFuchs/desktop into logo-update
2019-09-05 20:59:34 +02:00
Dominique Fuchs
7aefa5afaf
Updated CmakeLists for gui part to correct old variable (OUTFILE_BASE[NAME]) that changed by recent update of AddAppIcon modules. Fixes wrong naming of resource pack in build output.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-05 20:58:05 +02:00
John Molakvoæ
1606cf2e09
Use newer digest algorithms in TLS error dialog ( #1404 )
...
Use newer digest algorithms in TLS error dialog
2019-09-05 07:12:36 +02:00
Dominique Fuchs
464cdabecf
Merge branch 'master' into gitignore
2019-09-05 07:00:13 +02:00
Dominique Fuchs
defa0b2781
Merge branch 'master' into logo-update
2019-09-05 06:59:34 +02:00
John Molakvoæ
acd2425250
Merge branch 'master' into ssl-error-digests
2019-09-05 06:44:19 +02:00
Nextcloud bot
aa37a67729
[tx-robot] updated from transifex
2019-09-05 03:09:38 +00:00
Michael Schuster
1b2e64788d
Merge branch 'master' into ssl-error-digests
2019-09-05 01:07:20 +02:00
Roeland Jago Douma
b8ef78205a
Merge pull request #1256 from meskobalazs/master
...
Marking unused strings as unstranslatable
2019-09-04 23:06:08 +02:00
Martin Sucha
3e6422a889
Use newer digest algorithms in TLS error dialog
...
MD5 has been broken for a long time now and SHA1 has been
deprecated as well. SHA1 is not used when issuing new
publicly trusted certificates since 1 January 2016[1] and
there are more and more effective attacks[2][3] against it,
so display SHA1 fingerprint only for old certificates
to encourage use of safer digests by users.
So, we display SHA-256 and SHA-512 fingerprints instead in
the common case.
[1] https://cabforum.org/wp-content/uploads/CA-Browser-Forum-BR-1.6.5.pdf
[2] https://shattered.io/static/shattered.pdf
[3] https://eprint.iacr.org/2019/459.pdf
Signed-off-by: Martin Sucha <git@mm.ms47.eu >
2019-09-04 22:06:12 +02:00
Michael Schuster
0bcc923a8a
Merge branch 'master' into gitignore
2019-09-04 21:12:48 +02:00
Roeland Jago Douma
0cb1f4d14b
Merge pull request #1394 from nextcloud/webflow-client-ssl-ca-chain
...
Windows: Workaround for CredWriteW used by QtKeychain
2019-09-04 20:04:45 +02:00
Dominique Fuchs
7ac6df24a3
Updated ECMAddAppIcon to newest ver from https://github.com/KDE/extra-cmake-modules/blob/master/modules/ECMAddAppIcon.cmake with modifications for nc workflow (incl. png2imagemagick)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-04 16:51:16 +02:00
Michael Schuster
5ef9600007
Merge branch 'master' into webflow-client-ssl-ca-chain
2019-09-04 12:56:22 +02:00
Nextcloud bot
fcc84b6dc4
[tx-robot] updated from transifex
2019-09-04 03:07:24 +00:00
Dominique Fuchs
88dcbad790
Updated theme.qrc to include new icon logo files
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 19:38:01 +02:00
Dominique Fuchs
7e4323c7de
Revert-corrected naming of icon files due to limitations by ECMAddAppIcon
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 18:27:37 +02:00
Dominique Fuchs
af831a7653
updated resources for new logo icon files
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 18:17:46 +02:00
Dominique Fuchs
8bd85fa71d
Corrected sized icon versions to up2date windows guidelines (see also ECMAddAppIcon.cmake)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 18:05:06 +02:00
Dominique Fuchs
9d225452bd
Updated svg version of nc icon
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 18:00:51 +02:00
Dominique Fuchs
b79a82cc3f
Updated AddAppIconMacro (esp. for new macOS retina guidelines) and corrected filenames to not change pattern in cmake scripts
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 17:54:22 +02:00
Dominique Fuchs
0380271499
Updated cmake module to current version (esp. worthy for newer windows versions reg. the sizes) in https://github.com/KDE/extra-cmake-modules/blob/master/modules/ECMAddAppIcon.cmake
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 17:25:05 +02:00
Dominique Fuchs
2e243e5a38
deleted old icon files (not sidebar logo files atm)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 17:19:20 +02:00
Dominique Fuchs
e56b1a082b
Updated .gitignore to integrate unwanted files when working with VSC or VS2019
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 10:59:21 +02:00
Dominique Fuchs
c389985c2e
Merge remote-tracking branch 'upstream/master'
2019-09-03 10:53:43 +02:00
Dominique Fuchs
ef9c092662
Added png export series of new logo based on svg material in promo branch.
...
Decided for new naming sheme too keep old variants in repo untill all changes (also in helper repos like client-building) are done.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-03 09:42:52 +02:00
Nextcloud bot
86f559add4
[tx-robot] updated from transifex
2019-09-03 03:04:22 +00:00
Dominique Fuchs
5bcff7dab6
Merge branch 'master' into master
2019-09-02 06:56:30 +02:00
Nextcloud bot
812e688572
[tx-robot] updated from transifex
2019-09-02 03:03:47 +00:00
Dominique Fuchs
8f3bf3313e
Integrated registry check on windows when hasDarkSystray is called.
...
Return value determines which theme is applied for monochrome variant.
Fixes #1276 but only when monochrome option is toggled or nc starts, not automatically when changing windows theme.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2019-09-01 22:13:14 +02:00
Nextcloud bot
87bf0d9a7e
[tx-robot] updated from transifex
2019-09-01 03:09:08 +00:00
Nextcloud bot
bb9140d075
[tx-robot] updated from transifex
2019-08-31 03:03:58 +00:00
Michael Schuster
267224b258
Merge branch 'master' into webflow-client-ssl-ca-chain
2019-08-30 05:38:07 +02:00
Michael Schuster
61884d1ada
fix indents, add comment
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-30 05:35:36 +02:00
Nextcloud bot
29ff9f403e
[tx-robot] updated from transifex
2019-08-30 03:06:24 +00:00
Michael Schuster
b52292db92
Windows: Workaround for CredWriteW used by QtKeychain
...
Saving all client CA's within one credential may result in:
Error: "Credential size exceeds maximum size of 2560"
Client CA certificates are now being stored in separate slots
within the keychain and are being processed by a queue mechanism.
IMPORTANT TODO:
forgetSensitiveData(): Invoked by "Log out" & "Remove account"
- Remove client CA certs and KEY!
(uncomment "//deleteKeychainEntries();" )
Disabled as long as selecting another cert is not supported by the UI.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-30 04:56:01 +02:00
Nextcloud bot
57d0a17744
[tx-robot] updated from transifex
2019-08-29 03:03:24 +00:00
Roeland Jago Douma
85a2860e86
Merge pull request #1389 from nextcloud/webflow-client-ssl
...
Adds SSL client cert storage to webflow + Login Flow v2
2019-08-28 07:40:39 +02:00
Nextcloud bot
7fc95c4c52
[tx-robot] updated from transifex
2019-08-28 03:10:20 +00:00
Michael Schuster
2c4336ab2a
Merge branch 'master' into webflow-client-ssl
2019-08-28 00:30:36 +02:00
Roeland Jago Douma
d584bedcb6
Also store the CACertificates of the client side certificate
...
Else authentication will still fail in setups that have a chain of
certificates supplied.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-08-27 09:55:41 +02:00
Nextcloud bot
5c34f9e247
[tx-robot] updated from transifex
2019-08-27 03:04:46 +00:00
Michael Schuster
dbde585049
Adds SSL client cert storage to webflow + Login Flow v2
...
The previous commit 50cd6af394 - Build a webflowcredentials
changed:
src/gui/wizard/flow2authcredspage.cpp in line 135 to use WebFlowCredentials
instead of HttpCredentials.
But the WebFlowCredentials class didn't include code to store and load SSL client
certificates and keys from the keychain.
This commit migrates the useful stuff from the old HttpCredentials class
into WebFlowCredentials.
Successfully tested on Windows. Please test on other systems and verify it's safe! :)
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-27 03:32:21 +02:00
Michael Schuster
18404a128b
Merge pull request #1384 from nextcloud/login-flow-v2
...
Login flow v2
2019-08-26 21:48:40 +02:00
Roeland Jago Douma
302ca0e04e
Fix some compiler warnings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-08-26 20:41:14 +02:00
Roeland Jago Douma
50cd6af394
Build a webflowcredentials
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-08-26 20:04:23 +02:00
Michael Schuster
fd8345ccbe
Login Flow V2: adds re-auth upon logout, improvements
...
- Implements re-auth upon logout -> login
- Improves UI and security
TODO:
- SSL: Client certificate login is possible at the first time only but missing after relaunch
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-26 20:03:15 +02:00
Michael Schuster
7add98e9a3
UI: don't let Flow2 and OAuth hide the wizard
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-26 20:03:15 +02:00
Michael Schuster
aa93a04fd6
fix comment typo in httpcredentials.cpp
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-26 20:03:15 +02:00
Michael Schuster
628bab92c4
fix comment typo in webflowcredentials.cpp
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-26 20:03:15 +02:00
Michael Schuster
12f2ea6728
Login Flow V2: remove static test url
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-26 20:03:15 +02:00
Michael Schuster
8fa55b97b4
Login Flow V2: 1st implementation, cleanup
...
This is the first draft of the Login Flow V2 authorization method.
See: https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#login-flow-v2
- Adds the Login Fĺow V2 auth method
- Adds ability to reinitiate a new request via UI
TODO:
- Implement re-auth upon logout -> login
- Improve UI
- SSL: Client certificate login is possible at the first time only but missing after relaunch
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-26 20:03:15 +02:00
Michael Schuster
2742411abd
Login Flow V2: 1st test-implementation
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2019-08-26 20:03:15 +02:00
Nextcloud bot
9941d49579
[tx-robot] updated from transifex
2019-08-26 03:00:53 +00:00
Nextcloud bot
93f6bb2740
[tx-robot] updated from transifex
2019-08-25 03:03:22 +00:00
Nextcloud bot
95c6dd32e9
[tx-robot] updated from transifex
2019-08-24 03:03:25 +00:00
Nextcloud bot
c5f8b00a6b
[tx-robot] updated from transifex
2019-08-21 03:04:55 +00:00
Nextcloud bot
7135d441e6
[tx-robot] updated from transifex
2019-08-20 03:04:04 +00:00
Roeland Jago Douma
e0a1d78441
Merge pull request #1225 from edent/patch-1
...
Typo
2019-08-19 15:39:10 +02:00
Nextcloud bot
eb31925a00
[tx-robot] updated from transifex
2019-08-18 03:08:13 +00:00
Nextcloud bot
6f4de8f503
[tx-robot] updated from transifex
2019-08-17 03:06:09 +00:00
Nextcloud bot
db83302546
[tx-robot] updated from transifex
2019-08-16 03:01:55 +00:00
Nextcloud bot
c74db8677b
[tx-robot] updated from transifex
2019-08-15 03:02:27 +00:00
Samir Benmendil
5e3c2d2a96
Fix fullPath matching
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
7a9b13a563
Manual exclude are anchored to _localPath by default
...
This makes a lot of sense, since there should be no file to be synced
outside of _localPath.
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
e27645cb00
Extract loadExcludeFile and use it when discovering new exclude files
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
34fcb13e78
Never ignore .sync-exclude, even if excludeHidden
...
That is unless any of the parent folders is hidden.
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
758483bc6e
Silence CMake warning
...
CMake Warning (dev) at NEXTCLOUD.cmake:31 (set):
implicitly converting 'string' to 'STRING' type
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
9f4873e864
Fix some typos
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
94448a8b33
Add menu action to main sync folder too
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
acf0b0f7c4
Add menu action to each subfolder
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
d4816442ef
Extract IgnoreListTableWidget to be reused
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
e44a2302de
Remove all rows in the table widget
...
`clearContents()` will leave the number of rows as is. This was causing
a segfault when trying to loop over the items of the widget.
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
4a2b91a043
IgnoreListEditor can work on any path
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Samir Benmendil
14279104ae
Read .sync_exclude.lst in each subdirectory
...
Signed-off-by: Samir Benmendil <me@rmz.io >
2019-08-15 03:00:26 +01:00
Nextcloud bot
7843660bbf
[tx-robot] updated from transifex
2019-08-14 03:05:59 +00:00
Camila Ayres
037b2338de
Merge pull request #1376 from nextcloud/updates-changelog
...
Update ChangeLog.
2019-08-12 15:20:23 +02:00
Camila San
cfa6f13620
Updates ChangeLog.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-08-12 15:13:05 +02:00
Nextcloud bot
00d222891c
[tx-robot] updated from transifex
2019-08-12 03:03:59 +00:00
Nextcloud bot
1ed8c898e9
[tx-robot] updated from transifex
2019-08-11 03:06:12 +00:00
Nextcloud bot
c2f401a77a
[tx-robot] updated from transifex
2019-08-10 03:05:46 +00:00
Camila Ayres
169dea1627
Merge pull request #1372 from ivaradi/remove-libgnome-keyring
...
Remove dependency on libgnome-keyring0 on Eoan
2019-08-09 11:42:24 +02:00
István Váradi
1883c04a12
Remove dependency on libgnome-keyring0 on Eoan
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-08-09 06:47:59 +02:00
Nextcloud bot
ec70ee96f3
[tx-robot] updated from transifex
2019-08-09 03:04:25 +00:00
Nextcloud bot
0337507446
[tx-robot] updated from transifex
2019-08-08 03:04:58 +00:00
Nextcloud bot
890c7d731d
[tx-robot] updated from transifex
2019-08-07 03:03:54 +00:00
Nextcloud bot
3a6f9e51f5
[tx-robot] updated from transifex
2019-08-06 03:03:52 +00:00
Nextcloud bot
eb41f01857
[tx-robot] updated from transifex
2019-08-05 03:01:25 +00:00
Nextcloud bot
681c03b097
[tx-robot] updated from transifex
2019-08-04 03:06:07 +00:00
Nextcloud bot
233333a616
[tx-robot] updated from transifex
2019-08-03 03:04:01 +00:00
Camila Ayres
f9947334f6
Merge pull request #1366 from nextcloud/fix/client_side_cert
...
Add proper CA to client side certificate connection
2019-08-02 18:38:27 +02:00
Camila Ayres
9b6b14b374
Merge branch 'master' into fix/client_side_cert
2019-08-02 14:40:20 +02:00
Roeland Jago Douma
4c8da1a3e7
Add proper CA
...
If the cert has a chain of certs we should send them all properly
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-08-02 14:19:37 +02:00
Nextcloud bot
9e7868b3de
[tx-robot] updated from transifex
2019-08-02 03:05:09 +00:00
Nextcloud bot
8fad2acc36
[tx-robot] updated from transifex
2019-08-01 03:08:11 +00:00
Nextcloud bot
4befda1eab
[tx-robot] updated from transifex
2019-07-31 03:08:42 +00:00
István Váradi
29218158c0
Merge pull request #1360 from ivaradi/ubuntu-eoan
...
Remove Ubuntu Cosmic and add Eoan package
2019-07-30 07:07:53 +02:00
István Váradi
40753860cf
Merge branch 'master' into ubuntu-eoan
2019-07-30 06:50:19 +02:00
István Váradi
5142cf026f
Merge pull request #1359 from ivaradi/qt55-update
...
Update Qt 5.5 compatibility patch for Xenial
2019-07-30 06:49:59 +02:00
István Váradi
d64b477280
Merge branch 'master' into ubuntu-eoan
2019-07-30 06:36:44 +02:00
István Váradi
d0cf21d355
Merge branch 'master' into qt55-update
2019-07-30 06:36:24 +02:00
Nextcloud bot
4257f70d2e
[tx-robot] updated from transifex
2019-07-30 03:05:57 +00:00
István Váradi
d000328700
Merge branch 'master' into ubuntu-eoan
2019-07-29 19:05:13 +02:00
István Váradi
b5e45711fc
Merge branch 'master' into qt55-update
2019-07-29 19:04:43 +02:00
Nextcloud bot
9f94f412ef
[tx-robot] updated from transifex
2019-07-29 03:03:27 +00:00
Nextcloud bot
c13d4ca40e
[tx-robot] updated from transifex
2019-07-28 03:05:54 +00:00
István Váradi
04d825f4b6
Remove Ubuntu Cosmic and add Eoan package
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-07-27 11:21:39 +02:00
Nextcloud bot
b448e215ad
[tx-robot] updated from transifex
2019-07-27 03:03:03 +00:00
István Váradi
2d2c1ef29e
Update Qt 5.5 compatibility patch for Xenial
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-07-26 21:08:23 +02:00
Nextcloud bot
d654a65ac7
[tx-robot] updated from transifex
2019-07-26 03:03:02 +00:00
István Váradi
f462bfc7c5
Merge pull request #1222 from ivaradi/new-drone-debian
...
Reinstate Debian build in the new Drone config
2019-07-25 18:58:29 +02:00
István Váradi
d6ab7920d9
Fix the Debian changelog generator
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-07-25 16:48:24 +02:00
István Váradi
ec359d0e6b
Reinstate Debian build in the new Drone config
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2019-07-25 16:48:17 +02:00
Nextcloud bot
be3713a535
[tx-robot] updated from transifex
2019-07-25 03:03:32 +00:00
Camila Ayres
a21258487f
Merge pull request #1354 from nextcloud/minorchange/link-to-help-text
...
Minor text change in the link to help in the tab 'General'.
2019-07-24 19:07:10 +02:00
Camila San
3ea472d9f2
Minor text change in the link to help in the tab 'General'.
...
Also uses helpUrl() retrieve the correct APPLICATION_HELP_URL
instead of APPLICATION_DOMAIN.
Signed-off-by: Camila San <hello@camila.codes >
2019-07-24 16:39:21 +02:00
Nextcloud bot
a0587f3cde
[tx-robot] updated from transifex
2019-07-24 03:05:55 +00:00
Nextcloud bot
96c35a9410
[tx-robot] updated from transifex
2019-07-23 03:09:01 +00:00
Camila Ayres
41900140df
Merge pull request #1342 from gt-h6k/fixes-1187
...
Fixes issue #1187
2019-07-22 22:04:14 +02:00
Camila Ayres
a47dd69a71
Merge branch 'master' into fixes-1187
2019-07-22 20:45:50 +02:00
Camila Ayres
0539e34c69
Merge pull request #1275 from ivyclare/pr/607
...
Fixes #607
2019-07-22 20:45:28 +02:00
Camila Ayres
5d30f4b1eb
Merge branch 'master' into pr/607
2019-07-22 19:38:56 +02:00
Camila Ayres
4559965abf
Merge pull request #1278 from ivyclare/pr/878
...
Fixes issue #878
2019-07-22 19:38:36 +02:00
Camila Ayres
4801bd5818
Merge branch 'master' into pr/607
2019-07-22 16:46:45 +02:00
Camila Ayres
9411a34a2b
Merge branch 'master' into pr/878
2019-07-22 16:09:52 +02:00
Camila Ayres
94bff61c45
Merge branch 'master' into fixes-1187
2019-07-22 16:09:40 +02:00
Camila Ayres
cf3dd53e12
Merge pull request #1347 from caugner/965-file-folder-ignored-as-info
...
Displays FileIgnored activities with an info icon
2019-07-22 16:09:27 +02:00
Camila Ayres
0ae72cd68a
Merge branch 'master' into pr/878
2019-07-22 15:45:56 +02:00
Camila Ayres
88624f055d
Merge branch 'master' into 965-file-folder-ignored-as-info
2019-07-22 15:44:10 +02:00
Nextcloud bot
50be2e067c
[tx-robot] updated from transifex
2019-07-22 03:06:58 +00:00
Claas Augner
116c5b361f
Displays FileIgnored activities with an info icon
...
See: https://github.com/nextcloud/desktop/issues/965
Signed-off-by: Claas Augner <git@caugner.de >
2019-07-21 22:02:15 +02:00
Nextcloud bot
ae28be4a10
[tx-robot] updated from transifex
2019-07-21 03:07:35 +00:00
Nextcloud bot
fa2f52b551
[tx-robot] updated from transifex
2019-07-20 03:03:51 +00:00
Nextcloud bot
658f6817ce
[tx-robot] updated from transifex
2019-07-19 03:16:29 +00:00
Nextcloud bot
28c401236b
[tx-robot] updated from transifex
2019-07-17 03:03:58 +00:00
Hiroki Goto
57ca82e620
Merge branch 'master' into fixes-1187
2019-07-15 20:08:47 +09:00
Nextcloud bot
7d700a3c84
[tx-robot] updated from transifex
2019-07-15 03:00:34 +00:00
Nextcloud bot
2c2cc5c23e
[tx-robot] updated from transifex
2019-07-14 03:03:06 +00:00
gt-h6k
1763504b4e
Fixes issue #1187
...
Signed-off-by: Hiroki Goto <git@gt-h6k.net >
2019-07-13 16:39:30 +09:00
Nextcloud bot
94db2f82a2
[tx-robot] updated from transifex
2019-07-13 03:06:30 +00:00
Nextcloud bot
d967ebac9a
[tx-robot] updated from transifex
2019-07-12 02:59:46 +00:00
Nextcloud bot
6b5b3c96cf
[tx-robot] updated from transifex
2019-07-11 02:58:04 +00:00
Nextcloud bot
a8bf75d496
[tx-robot] updated from transifex
2019-07-10 02:57:49 +00:00
Nextcloud bot
bb34de2bd8
[tx-robot] updated from transifex
2019-07-09 02:54:41 +00:00
Nextcloud bot
b146654474
[tx-robot] updated from transifex
2019-07-07 02:55:41 +00:00
Nextcloud bot
c897564d28
[tx-robot] updated from transifex
2019-07-05 02:57:08 +00:00
Nextcloud bot
ae9bc786ad
[tx-robot] updated from transifex
2019-07-04 02:55:55 +00:00
Nextcloud bot
b2d85cc4bf
[tx-robot] updated from transifex
2019-07-03 02:55:33 +00:00
Nextcloud bot
ac505aac0e
[tx-robot] updated from transifex
2019-07-02 02:54:54 +00:00
Nextcloud bot
4eac71a032
[tx-robot] updated from transifex
2019-06-30 02:55:43 +00:00
Nextcloud bot
fa29fc4028
[tx-robot] updated from transifex
2019-06-28 02:56:13 +00:00
Nextcloud bot
f352af7ffb
[tx-robot] updated from transifex
2019-06-27 02:57:19 +00:00
Nextcloud bot
d7098343a2
[tx-robot] updated from transifex
2019-06-26 02:56:31 +00:00
Nextcloud bot
908f4d34e3
[tx-robot] updated from transifex
2019-06-25 02:57:16 +00:00
Nextcloud bot
78c7aed3b9
[tx-robot] updated from transifex
2019-06-24 02:56:03 +00:00
Nextcloud bot
a8986124b8
[tx-robot] updated from transifex
2019-06-23 02:56:59 +00:00
Nextcloud bot
57ec1cdda4
[tx-robot] updated from transifex
2019-06-22 02:55:39 +00:00
Camila Ayres
9dc47438c9
Merge pull request #1309 from nextcloud/feature/show-shared-file-owner
...
Displays the uid_owner of a shared file.
2019-06-21 19:53:46 +02:00
Camila San
d6a0a5272a
Displays the uid_owner of a shared file.
...
Also displays the sharees that reshared it via share link.
Signed-off-by: Camila San <hello@camila.codes >
2019-06-21 18:36:45 +02:00
Nextcloud bot
47ac10fb8e
[tx-robot] updated from transifex
2019-06-21 02:54:12 +00:00
Nextcloud bot
459a17bd7e
[tx-robot] updated from transifex
2019-06-20 02:55:55 +00:00
Nextcloud bot
de65b6fb7e
[tx-robot] updated from transifex
2019-06-18 02:55:35 +00:00
Nextcloud bot
6ddfc80672
[tx-robot] updated from transifex
2019-06-17 02:54:41 +00:00
Nextcloud bot
048cf3b23e
[tx-robot] updated from transifex
2019-06-16 02:56:30 +00:00
Nextcloud bot
3c958dea20
[tx-robot] updated from transifex
2019-06-13 02:48:18 +00:00
Kilian Pfeiffer
ac24874585
Merge branch 'master' into master
2019-06-12 12:41:09 +02:00
Camila Ayres
0b420c5fe6
Merge pull request #1301 from nextcloud/error-423-change-warning-color
...
Add error category for http file lock error status 423.
2019-06-12 11:33:25 +02:00
Camila San
bb7d330516
Add error category for http file lock error status 423.
...
It filters the error out of the list of blocking errors. It now shows up
in the Activities and Notificattions list as a warning.
Signed-off-by: Camila San <hello@camila.codes >
2019-06-11 23:32:10 +02:00
Nextcloud bot
795c29d5bd
[tx-robot] updated from transifex
2019-06-11 02:46:16 +00:00
Nextcloud bot
ad04116c00
[tx-robot] updated from transifex
2019-06-10 02:47:53 +00:00
Nextcloud bot
42b9dec1d0
[tx-robot] updated from transifex
2019-06-09 02:47:26 +00:00
Nextcloud bot
51e398d4f4
[tx-robot] updated from transifex
2019-06-08 02:46:59 +00:00
Ivoline Ngong
5c2e8c9574
Merge branch 'master' into pr/607
2019-06-07 19:36:44 +03:00
Nextcloud bot
feee0bf62b
[tx-robot] updated from transifex
2019-06-06 02:47:28 +00:00
Nextcloud bot
f6dee2b10f
[tx-robot] updated from transifex
2019-06-05 02:47:31 +00:00
Nextcloud bot
57fc438b91
[tx-robot] updated from transifex
2019-06-04 02:47:14 +00:00
Camila Ayres
aa5b62c931
Add comment to Github issue_template.md.
...
Minor change: removes some item e.g. PHP version that are not relevant to the client.
2019-06-03 17:42:29 +02:00
Ivan Čukić
f089fa34fc
Merge pull request #1241 from ivan-cukic/ivan/encryption-initial-setup
...
Added a nice UI for the E2E-enabled account first connect
2019-06-03 09:44:19 +02:00
Ivan Čukić
200032c9cb
Merge branch 'master' into ivan/encryption-initial-setup
2019-06-03 09:11:56 +02:00
Nextcloud bot
6a294bb4a0
[tx-robot] updated from transifex
2019-06-03 02:46:03 +00:00
Nextcloud bot
4aa2e2e8c3
[tx-robot] updated from transifex
2019-06-01 02:46:48 +00:00
Nextcloud bot
4cd7095a40
[tx-robot] updated from transifex
2019-05-30 02:46:02 +00:00
Ivoline Ngong
d3c5a71689
Merge branch 'master' into pr/878
2019-05-29 21:06:19 +03:00
ivyclare
f4340b98ce
Unshare action transferred to 3 dot menu
...
Signed-off-by: ivyclare <ivolinengong@gmail.com >
2019-05-29 20:54:53 +03:00
Camila Ayres
867e546fa9
Merge branch 'master' into master
2019-05-29 17:40:53 +02:00
Nextcloud bot
eb28fe9990
[tx-robot] updated from transifex
2019-05-29 02:56:09 +00:00
Nextcloud bot
fa5c1eff25
[tx-robot] updated from transifex
2019-05-28 03:00:44 +00:00
ivyclare
bcdc88ecf0
Change »Details…« to »View more activity…«
...
Signed-off-by: ivyclare <ivolinengong@gmail.com >
2019-05-28 01:14:31 +03:00
Camila Ayres
1dca017537
Merge pull request #1247 from nextcloud/backport/reshare
...
Adds parameter to retrieve shares with its reshares.
2019-05-27 20:16:34 +02:00
Camila San
9ff1a30dc4
Display error when current user is not allowed to reshare file/folder.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-05-27 19:46:38 +02:00
Camila San
4f0ff154d3
Display sharees on the first show of the share dialog.
...
It was displaying them only when the current user would edit the share.
Signed-off-by: Camila San <hello@camila.codes >
2019-05-27 19:46:38 +02:00
Camila San
981a4ee240
Adds parameter to retrieve shares with its reshares.
...
If the initiator or the recipient is not the current user,
show the list of sharees without any options to edit it.
Minor change: updates api to v2.
Signed-off-by: Camila San <hello@camila.codes >
2019-05-27 19:46:38 +02:00
Nextcloud bot
378dd744fb
[tx-robot] updated from transifex
2019-05-27 02:54:16 +00:00
Nextcloud bot
d38e829330
[tx-robot] updated from transifex
2019-05-25 02:55:41 +00:00
Nextcloud bot
ad65b6fdf3
[tx-robot] updated from transifex
2019-05-24 02:56:34 +00:00
Roeland Jago Douma
ea6f3be374
Merge pull request #1273 from csware/issue-1266
...
WebView: Properly handle usernames with spaces and plus signs in it
2019-05-23 19:59:49 +02:00
Sven Strickroth
85d217ec95
WebView: Properly handle usernames with spaces and plus signs in it
...
The path returned from the server encodes a space in the username with `+` and if the username contains a `+` sign it is encoded as `%2B` (cf. https://www.php.net/manual/function.urlencode.php ).
Fix: Don't (double) decode the URL path and then replace `+` with space (introduced in issue #279 resp. commit 9ec61a84ce ). Instead first replace `+` with space, then decode percent encoding.
Tested with a username containing a space, a username containing a `+`sign and a username containing just A-Za-z0-9- (with Nextcloud 16).
(fixes issue #1266 )
Signed-off-by: Sven Strickroth <email@cs-ware.de >
2019-05-23 17:09:33 +02:00
Nextcloud bot
e8213242a9
[tx-robot] updated from transifex
2019-05-23 02:55:27 +00:00
Sebastian Grund
a9bea53c89
issue1216: added sync-exclude entry for emacs recovery files
...
Signed-off-by: Sebastian Grund <grund92@gmx.de >
2019-05-22 08:52:37 +02:00
Nextcloud bot
0c603944b8
[tx-robot] updated from transifex
2019-05-22 02:56:14 +00:00
Nextcloud bot
559187df6c
[tx-robot] updated from transifex
2019-05-20 02:53:13 +00:00
Nextcloud bot
eb00500b0b
[tx-robot] updated from transifex
2019-05-19 02:55:18 +00:00
Ivan Čukić
876f69dc7d
Merge branch 'master' into ivan/encryption-initial-setup
2019-05-18 23:07:34 +02:00
Ivan Čukić
33605d7f65
Removed ellipsis from the button text
2019-05-18 22:58:41 +02:00
Nextcloud bot
492fc846df
[tx-robot] updated from transifex
2019-05-18 02:53:47 +00:00
Nextcloud bot
febf206704
[tx-robot] updated from transifex
2019-05-17 02:59:46 +00:00
Nextcloud bot
e1eeaadaff
[tx-robot] updated from transifex
2019-05-16 02:53:07 +00:00
Ivan Čukić
4f17366262
Changed the message to 'Enable encryption...'
2019-05-14 21:54:43 +02:00
Ivan Čukić
a8ac89c20c
Merge branch 'master' into ivan/encryption-initial-setup
2019-05-14 21:53:57 +02:00
Balázs Meskó
a13bba7f42
Marking unused strings as unstranslatable
...
Signed-off-by: Balázs Meskó <mesko.balazs@fsf.hu >
2019-05-14 20:07:08 +02:00
Nextcloud bot
e0f421ac7a
[tx-robot] updated from transifex
2019-05-14 02:51:16 +00:00
Roeland Jago Douma
b6c0f9db5d
Merge pull request #1253 from muesli/webview-typo
...
Fixed typo in "certificate"
2019-05-13 07:58:52 +02:00
Roeland Jago Douma
50755d0295
Merge pull request #1251 from yarons/patch-1
...
Fixed typo
2019-05-13 07:58:29 +02:00
Christian Muehlhaeuser
9dc0027304
Fixed typo in "certificate"
...
Signed-off-by: Christian Muehlhaeuser <muesli@gmail.com >
2019-05-13 05:22:58 +02:00
Nextcloud bot
37ee52a930
[tx-robot] updated from transifex
2019-05-13 00:47:37 +00:00
Yaron Shahrabani
692d885b55
Fixed typo
...
Chipher -> Cipher
2019-05-12 19:11:33 +03:00
Ivan Čukić
6c0d796b4b
E2E UI setup poligh
...
- Text changed to "Enable..." instead of "Setup"
- The close icon follows NC style
- "end-to-end" instead of "end to end"
Signed-off-by: Ivan Čukić <ivan.cukic@kde.org >
2019-05-11 19:20:19 +02:00
Ivan Čukić
db7e5e01b3
Merge branch 'master' into ivan/encryption-initial-setup
2019-05-11 19:19:00 +02:00
Nextcloud bot
ae0b1ce3d6
[tx-robot] updated from transifex
2019-05-11 00:48:37 +00:00
Camila Ayres
419b8a3ff9
Merge pull request #1245 from joshua-sterner/master
...
This should fix issue #1000 .
2019-05-10 17:04:40 +02:00
Camila Ayres
bdfc5dcd14
Merge branch 'master' into master
2019-05-10 14:42:44 +02:00
Camila Ayres
c0704cd500
Merge pull request #1234 from curiousDTU/small-fix
...
updated default remote poll to 5 seconds #1115
2019-05-10 11:08:32 +02:00
Joshua Sterner
1b36dbc435
Merge branch 'master' into master
2019-05-09 23:15:54 -07:00
shobha
188374f60c
updated default remote poll to 5 seconds #1115
...
Signed-off-by: shobha <tyagishobha@gmail.com >
2019-05-10 09:15:09 +05:30
Nextcloud bot
fd9d7563c2
[tx-robot] updated from transifex
2019-05-10 00:49:02 +00:00
Joshua Sterner
bd9fcd88d8
testMove3LevelDirWithFile now uses mv function to move the directory
...
Signed-off-by: Joshua Sterner <joshua.s.sterner@gmail.com >
2019-05-09 04:12:33 -07:00
Joshua Sterner
b6ff17c50b
Fixed Issue #1000 - Subfolders of moved folders not synced
...
Signed-off-by: Joshua Sterner <joshua.s.sterner@gmail.com >
2019-05-09 04:12:33 -07:00
Nextcloud bot
2d3bac4e53
[tx-robot] updated from transifex
2019-05-09 00:48:24 +00:00
Ivan Čukić
7af786fde9
Added a nice UI for the E2E-enabled account first connect
...
Instead of immediately popping up the mnemonic dialogue,
only show a notification bar on the account setup page.
For the cases where the user does not want to use E2E,
this is significantly less intrusive than the old approach.
2019-05-09 00:37:24 +02:00
Ivan Čukić
0f7c10a2d6
Race condition in the remote size loading logic
...
The quota retrieval process might not be finished by the time
the used space on the server (`_rSize`) is compared against
the locally available disk space which might end up in
a "There isn't enough free space in the local folder!" message
even if there is enough free space.
This patch updates the status after the quota has been retrieved.
It also initializes `_rSize` to `-1` so that errors like this
are easier to catch in the future.
2019-05-08 23:09:55 +02:00
Camila Ayres
1f1a7a27f0
Merge pull request #1239 from nextcloud/fix/device-memory-leak
...
Fix memory leak with device pointer
2019-05-08 20:14:49 +02:00
Christoph Wurst
c2e3cbca31
Fix memory leak with device pointer
...
Downstream of https://github.com/owncloud/client/pull/6856
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-05-08 19:41:48 +02:00
Nextcloud bot
92a5e64487
[tx-robot] updated from transifex
2019-05-08 00:52:12 +00:00
Nextcloud bot
9153f710df
[tx-robot] updated from transifex
2019-05-07 00:48:06 +00:00
Nextcloud bot
8151eb4837
[tx-robot] updated from transifex
2019-05-05 00:49:10 +00:00
Corentin Noël
18f51e47d7
Merge branch 'master' into master
2019-05-03 17:04:42 +02:00
Corentin Noël
aba4b722af
Merge branch 'master' into fix_urlscheme_warning
2019-05-03 17:03:23 +02:00
Corentin Noël
654049d4fd
Merge branch 'master' into icons
2019-05-03 17:02:59 +02:00
Nextcloud bot
a5b65a73a8
[tx-robot] updated from transifex
2019-05-03 00:47:47 +00:00
Nextcloud bot
26b9bf0281
[tx-robot] updated from transifex
2019-05-02 00:48:16 +00:00
Nextcloud bot
19c968de76
[tx-robot] updated from transifex
2019-05-01 00:48:06 +00:00
Terence Eden
e64fa74899
Typo
...
There's no such thing as a "key*h*chain".
2019-04-28 10:03:38 +01:00
Nextcloud bot
9b3fa62b2d
[tx-robot] updated from transifex
2019-04-28 00:50:09 +00:00
Nextcloud bot
68983c54bb
[tx-robot] updated from transifex
2019-04-27 00:47:44 +00:00
Nextcloud bot
d9af9b895f
[tx-robot] updated from transifex
2019-04-26 00:47:12 +00:00
Nextcloud bot
50f332eac7
[tx-robot] updated from transifex
2019-04-25 00:47:56 +00:00
Nextcloud bot
ad095efe3a
[tx-robot] updated from transifex
2019-04-23 00:48:20 +00:00
Björn Bidar
cea0d519a4
fix qt warning about registering a URL sheme first.
...
Qt recommends to register a URL scheme before installing it.
I don't know the impact of the not registering before instaling but I
think the change is pretty harmles.
See:
https://doc.qt.io/qt-5/qwebengineurlscheme.html#registerScheme
Signed-off-by: Björn Bidar <theodorstormgrade@gmail.com >
2019-04-22 07:38:38 +02:00
Nextcloud bot
3c947819c1
[tx-robot] updated from transifex
2019-04-22 00:48:48 +00:00
Camila Ayres
f52f9f0abe
Merge pull request #1212 from nextcloud/cmake-simplify
...
Simplify cmake command to make copy-pastable.
2019-04-21 19:41:52 +02:00
Camila San
75ccffa5a2
Simplify compile instructions.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-04-21 17:13:20 +02:00
Jan-Christoph Borchardt
f0035b95bb
Simplify cmake command to make copy-pastable
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net >
2019-04-21 14:31:10 +02:00
Nextcloud bot
955f54cdef
[tx-robot] updated from transifex
2019-04-21 00:50:00 +00:00
Nextcloud bot
c5b8cda323
[tx-robot] updated from transifex
2019-04-20 00:48:15 +00:00
Nextcloud bot
ae0dbcde5b
[tx-robot] updated from transifex
2019-04-19 00:49:24 +00:00
Nextcloud bot
f32d83e993
[tx-robot] updated from transifex
2019-04-18 00:49:41 +00:00
Nextcloud bot
d7b881feb6
[tx-robot] updated from transifex
2019-04-17 00:50:11 +00:00
Nextcloud bot
6bd98518e4
[tx-robot] updated from transifex
2019-04-15 00:49:36 +00:00
Nextcloud bot
54d80bbc9b
[tx-robot] updated from transifex
2019-04-14 00:51:05 +00:00
Nextcloud bot
5f9ec1762a
[tx-robot] updated from transifex
2019-04-13 00:51:53 +00:00
Camila San
1c8dfd701b
Increase version to 2.5.3.
2019-04-12 17:17:23 +02:00
Camila Ayres
f520d7364d
Merge pull request #1118 from tuchfarber/tuchfarber/fix_empty_file_error_wording
...
Fix empty file wording in error log (small)
2019-04-12 17:08:27 +02:00
Camila Ayres
4d61a7c263
Merge branch 'master' into tuchfarber/fix_empty_file_error_wording
2019-04-12 16:51:36 +02:00
Camila Ayres
ac6ef500cc
Merge pull request #1201 from nextcloud/bugfix/popup-empty-folder
...
Uses configuraion to determine if it should show empty folder popup.
2019-04-12 16:38:51 +02:00
Camila San
b5b2ef3120
Updates test to fit new configuration default value.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-04-12 16:22:07 +02:00
Camila San
7f3c3f6eb6
Uses configuraion to determine if it should show empty folder popup.
...
Configuration default value is set to false because users are getting
the popup message too often.
Signed-off-by: Camila San <hello@camila.codes >
2019-04-12 16:22:07 +02:00
Camila Ayres
936bdd04a8
Merge pull request #1185 from tintou/master
...
libcloudproviders: Add missing check for Qt5DBus
2019-04-12 16:09:31 +02:00
Camila Ayres
33baf40061
Merge branch 'master' into master
2019-04-12 15:50:55 +02:00
Roeland Jago Douma
6a63d8f2b9
Merge pull request #1191 from nextcloud/bugfix/1172/share-link
...
Share link fixing
2019-04-12 14:31:11 +02:00
Corentin Noël
b11a4217c7
Merge branch 'master' into master
2019-04-12 14:25:56 +02:00
Camila San
35114cf45c
Disable options in share dialog if account state changes.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-04-12 14:17:58 +02:00
Camila San
e07c472057
Refactores sharing link to support multiple share links.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-04-12 14:17:58 +02:00
Camila San
0fed1cc54d
Fixes deleting of one single link share.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-04-12 14:17:57 +02:00
Roeland Jago Douma
ac257cd65f
Merge pull request #1186 from tintou/tintou/i18n
...
Fix several memory leaks in cloudproviders and add translation support
2019-04-12 14:09:30 +02:00
Roeland Jago Douma
088b0817d8
Merge branch 'master' into tintou/i18n
2019-04-12 13:48:19 +02:00
Roeland Jago Douma
b0c75723e2
Merge pull request #1200 from nextcloud/new_drone
...
New drone config
2019-04-12 13:47:28 +02:00
Roeland Jago Douma
b368a93e2e
New drone config
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-04-12 11:14:05 +02:00
Roeland Jago Douma
c75cb390dd
Merge branch 'master' into tintou/i18n
2019-04-12 10:35:02 +02:00
Nextcloud bot
d39f826e0e
[tx-robot] updated from transifex
2019-04-12 00:49:48 +00:00
Camila Ayres
1ea8b18893
Merge branch 'master' into tintou/i18n
2019-04-11 13:54:18 +02:00
Nextcloud bot
8491ef428e
[tx-robot] updated from transifex
2019-04-10 00:48:53 +00:00
Julius Härtl
42ce5c0c0d
Merge branch 'master' into master
2019-04-09 10:01:35 +02:00
Nextcloud bot
acca019afe
[tx-robot] updated from transifex
2019-04-09 00:48:35 +00:00
Nextcloud bot
4591f9c09f
[tx-robot] updated from transifex
2019-04-08 00:49:58 +00:00
Corentin Noël
088a5a9771
Fix several memory leaks in cloudproviders and add translation support
2019-04-04 22:06:22 +02:00
Corentin Noël
19079c65c1
libcloudproviders: Add missing check for Qt5DBus
2019-04-04 17:50:30 +02:00
Nextcloud bot
3804410949
[tx-robot] updated from transifex
2019-04-04 00:49:12 +00:00
Nextcloud bot
b8e874a3a7
[tx-robot] updated from transifex
2019-04-02 00:51:06 +00:00
Nextcloud bot
3a03568ec8
[tx-robot] updated from transifex
2019-04-01 00:51:27 +00:00
Nextcloud bot
40da5630e1
[tx-robot] updated from transifex
2019-03-31 01:50:45 +00:00
Nextcloud bot
b36626d50a
[tx-robot] updated from transifex
2019-03-30 01:50:00 +00:00
Roeland Jago Douma
26f897d22c
Merge pull request #1157 from stragu/patch-1
...
Fix a minor typo
2019-03-29 13:33:55 +01:00
Nextcloud bot
1b4cb6483b
[tx-robot] updated from transifex
2019-03-29 01:50:20 +00:00
Nextcloud bot
9312c18c57
[tx-robot] updated from transifex
2019-03-27 11:31:33 +00:00
Nextcloud bot
96434aabe9
[tx-robot] updated from transifex
2019-03-27 01:42:51 +00:00
Nextcloud bot
95ec0777ca
[tx-robot] updated from transifex
2019-03-26 01:41:08 +00:00
Nextcloud bot
283423f1bd
[tx-robot] updated from transifex
2019-03-25 01:43:41 +00:00
Stéphane Guillou
3a893d6179
Fix a minor typo
2019-03-24 20:12:44 +10:00
Nextcloud bot
6a83b31c5a
[tx-robot] updated from transifex
2019-03-24 01:44:42 +00:00
Nextcloud bot
9a3667c1de
[tx-robot] updated from transifex
2019-03-23 01:43:05 +00:00
Nextcloud bot
90fa47bbe6
[tx-robot] updated from transifex
2019-03-22 01:44:35 +00:00
Camila Ayres
44c265e2a7
Merge pull request #1153 from nextcloud/enh/512/ci
...
Add Qt-5.12 to CI
2019-03-21 17:56:27 +01:00
Roeland Jago Douma
bb9017d3a6
Move over AppImage builder to 5.12
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-03-21 15:57:40 +01:00
Roeland Jago Douma
9d87f707a6
Add Qt-5.12 to CI
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-03-21 15:57:40 +01:00
Nextcloud bot
89cda9a1b4
[tx-robot] updated from transifex
2019-03-21 01:52:00 +00:00
Nextcloud bot
653e56268d
[tx-robot] updated from transifex
2019-03-20 01:49:54 +00:00
Nextcloud bot
56c905819e
[tx-robot] updated from transifex
2019-03-19 01:52:24 +00:00
Izabela Bakollari
ff7b0aace9
Modified slideshow buttons and edited "Host your own server" link
2019-03-18 16:31:35 +01:00
Izabela Bakollari
9b476a5caa
Add files via upload
2019-03-18 15:58:12 +01:00
Nextcloud bot
0d5120e7cc
[tx-robot] updated from transifex
2019-03-18 01:50:05 +00:00
Nextcloud bot
1c76dd5859
[tx-robot] updated from transifex
2019-03-17 01:50:55 +00:00
Nextcloud bot
37f709fe34
[tx-robot] updated from transifex
2019-03-16 01:50:19 +00:00
Nextcloud bot
a362f32402
[tx-robot] updated from transifex
2019-03-15 01:52:48 +00:00
Nextcloud bot
7ecab308f2
[tx-robot] updated from transifex
2019-03-14 01:45:23 +00:00
Nextcloud bot
d7314adcf1
[tx-robot] updated from transifex
2019-03-13 01:45:16 +00:00
Nextcloud bot
f64035339b
[tx-robot] updated from transifex
2019-03-12 01:44:20 +00:00
Nextcloud bot
0e70b8ab9f
[tx-robot] updated from transifex
2019-03-10 01:44:57 +00:00
Kilian Pfeiffer
2c58bee151
Merge branch 'master' into master
2019-03-09 17:57:11 +01:00
Nextcloud bot
e805184726
[tx-robot] updated from transifex
2019-03-09 01:42:32 +00:00
Nextcloud bot
b0d1e34df3
[tx-robot] updated from transifex
2019-03-08 01:44:20 +00:00
Matt Tuchfarber
0862d6cfb0
Fix empty file wording in error log
...
Changing empty file error text so that it reads correctly.
2019-03-07 00:18:12 -05:00
Nextcloud bot
9032b1c491
[tx-robot] updated from transifex
2019-03-07 01:44:38 +00:00
Nextcloud bot
e9111d745c
[tx-robot] updated from transifex
2019-03-05 01:52:03 +00:00
Roeland Jago Douma
0e3a8856e5
Merge pull request #1092 from nextcloud/enh/debug_not_warnings
...
Be less verbose with logging
2019-03-04 10:19:16 +01:00
Nextcloud bot
3084b85229
[tx-robot] updated from transifex
2019-03-04 01:42:12 +00:00
Nextcloud bot
f7f0a3249f
[tx-robot] updated from transifex
2019-03-03 01:43:17 +00:00
Nextcloud bot
4419a51a5d
[tx-robot] updated from transifex
2019-03-02 01:43:14 +00:00
Camila Ayres
1d37e96999
Merge pull request #1119 from nextcloud/typo
...
Fix typo in translation string
2019-03-01 12:18:34 +01:00
Morris Jobke
158c6e8136
Fix typo in translation string
2019-03-01 11:40:20 +01:00
Nextcloud bot
423e4ef92e
[tx-robot] updated from transifex
2019-03-01 01:49:47 +00:00
Nextcloud bot
4645adda0a
[tx-robot] updated from transifex
2019-02-28 01:50:48 +00:00
Nextcloud bot
0252ad9a08
[tx-robot] updated from transifex
2019-02-25 01:48:24 +00:00
Nextcloud bot
089625c9fd
[tx-robot] updated from transifex
2019-02-24 01:51:53 +00:00
Nextcloud bot
e63fd9b894
[tx-robot] updated from transifex
2019-02-23 01:49:05 +00:00
Nextcloud bot
9be32355f9
[tx-robot] updated from transifex
2019-02-22 01:49:45 +00:00
Nextcloud bot
984c02546e
[tx-robot] updated from transifex
2019-02-21 01:48:49 +00:00
Nextcloud bot
c60b4afafb
[tx-robot] updated from transifex
2019-02-20 01:48:28 +00:00
Nextcloud bot
55ff37a454
[tx-robot] updated from transifex
2019-02-16 01:48:02 +00:00
Roeland Jago Douma
bb2f179342
Be less verbose with logging
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-02-15 20:23:24 +01:00
Roeland Jago Douma
28afe8c323
Merge pull request #1087 from SimJoSt/patch-1
...
correct app passwords link
2019-02-14 11:51:24 +01:00
Joda Stößer
9393626ec2
correct app passwords link
...
Since some versions ago, the path/url for the app password settings is `/settings/user/security#security` instead of `/settings/personal#apppasswords`
2019-02-14 05:26:21 +01:00
Nextcloud bot
c0d0d39d8d
[tx-robot] updated from transifex
2019-02-13 01:48:58 +00:00
Kilian Pfeiffer
c4ffd844f3
Merge branch 'master' into master
2019-02-12 12:46:19 +01:00
Nextcloud bot
d06db158a0
[tx-robot] updated from transifex
2019-02-12 01:48:01 +00:00
Nextcloud bot
1698c39223
[tx-robot] updated from transifex
2019-02-11 01:49:14 +00:00
Nextcloud bot
42ad97de8c
[tx-robot] updated from transifex
2019-02-10 01:51:00 +00:00
Nextcloud bot
29230412ed
[tx-robot] updated from transifex
2019-02-09 01:49:42 +00:00
Nextcloud bot
e4bcc1a9ee
[tx-robot] updated from transifex
2019-02-08 01:49:54 +00:00
Nextcloud bot
ca624def40
[tx-robot] updated from transifex
2019-02-07 01:52:13 +00:00
Nextcloud bot
bb912ecc0a
[tx-robot] updated from transifex
2019-02-06 01:42:24 +00:00
Camila San
e2309362e1
Updates version to 2.5.2.
...
Signed-off-by: Camila San <hello@camila.codes >
2019-02-05 12:02:55 +01:00
Camila Ayres
a20ac05357
Merge pull request #1071 from nextcloud/enh/invalid_certificate_messagebox
...
Add invalid certiticate messagebox
2019-02-05 10:50:20 +01:00
Roeland Jago Douma
c9d4360fb6
Add invalid certiticate messagebox
...
This is a quick hack to make self signed certificates work.
I'm not to fond of it the real solution should be to request the url
with QNAM and then see if it fails.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-02-05 10:18:35 +01:00
Nextcloud bot
63fe2a7098
[tx-robot] updated from transifex
2019-02-05 01:42:29 +00:00
Camila Ayres
9931977266
Merge pull request #1062 from nextcloud/enh/notifications/do_not_show_dismissed
...
Do not display dismissed notifications
2019-02-04 20:43:42 +01:00
Camila Ayres
d4a77be3f8
Merge branch 'master' into enh/notifications/do_not_show_dismissed
2019-02-04 20:27:44 +01:00
Camila Ayres
79dd8397d7
Merge pull request #1069 from nextcloud/rakekniven-patch-1
...
Fixed l18n issue. Added space for separating string
2019-02-04 17:50:45 +01:00
rakekniven
d564279254
Fixed l18n issue. Added space for separating string
...
Related to #1068
Reported at forums with screenshots. See
https://help.nextcloud.com/t/client-2-5-1-linux-typo/46796
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de >
2019-02-04 17:13:53 +01:00
Nextcloud bot
97c54249d5
[tx-robot] updated from transifex
2019-02-04 01:41:57 +00:00
Nextcloud bot
652304e82e
[tx-robot] updated from transifex
2019-02-02 01:42:34 +00:00
Roeland Jago Douma
86251ff2e3
Do not display dismissed notifications
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-02-01 14:39:59 +01:00
Nextcloud bot
ae7ad8fb4f
[tx-robot] updated from transifex
2019-02-01 01:42:38 +00:00
Roeland Jago Douma
822c386709
Merge pull request #1057 from nextcloud/fix/proxy-login-flow
...
Fix login flow with system proxy
2019-01-31 16:11:08 +01:00
Roeland Jago Douma
50ebc49d69
Work around proxy issue with webview by always setting a proxy
...
Just use the prefered http tcp socket proxy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-31 14:14:31 +01:00
Roeland Jago Douma
eb3245b241
Fix login flow with system proxy
...
I must admit why this works is puzzling me. However if I just use a system
proxy without this it doesn't work. I suspect a Qt bug but will have to
dig deeper to find out if that is the case.
For now this little hack will have to do.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-31 13:45:40 +01:00
Julius Härtl
af443461e3
Merge pull request #1060 from nextcloud/enh/easier_theming
...
Start with easier theming
2019-01-31 12:04:25 +01:00
Roeland Jago Douma
e2293eddce
Allow to specifiy server url via CMAKE
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-31 11:28:46 +01:00
Roeland Jago Douma
b34708da29
Move help URL also to CMAKE
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-31 11:28:46 +01:00
Roeland Jago Douma
0c21852bc3
No need to overwrite customMedia in the theme
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-31 11:28:46 +01:00
Roeland Jago Douma
944f9e9668
Move wizard options to CMAKE as well
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-31 11:28:38 +01:00
Roeland Jago Douma
5c2996deb7
Use the provided updater URL
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-31 09:52:16 +01:00
Nextcloud bot
33d272e941
[tx-robot] updated from transifex
2019-01-31 01:43:23 +00:00
Roeland Jago Douma
bf81a473af
Merge pull request #1054 from nextcloud/enh/no_double_slash
...
Do not add double slash to login flow url
2019-01-30 16:39:52 +01:00
Roeland Jago Douma
a46548fc04
Merge pull request #1050 from IzabelaBakollari/master
...
Removed whitespace from string
2019-01-30 09:58:15 +01:00
Nextcloud bot
21b7257150
[tx-robot] updated from transifex
2019-01-30 01:44:34 +00:00
Roeland Jago Douma
7c1401da1c
Do not add double slash to login flow url
...
If the entered url ends with a slash we should not add another one.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-29 22:50:30 +01:00
Izabela Bakollari
c53e9cb417
Changes to be committed:
...
modified: CONTRIBUTING.md
Edited the link to report issue template.
2019-01-29 16:59:44 +01:00
Izabela Bakollari
e3731e40aa
Changes to be committed:
...
modified: src/gui/activitywidget.cpp
Removed whitespace from string
Issue #928
2019-01-29 13:10:11 +01:00
Nextcloud bot
218ffd0cd8
[tx-robot] updated from transifex
2019-01-29 01:42:50 +00:00
Nextcloud bot
9195452878
[tx-robot] updated from transifex
2019-01-28 01:43:34 +00:00
Nextcloud bot
67c25ca4b9
[tx-robot] updated from transifex
2019-01-27 01:46:09 +00:00
Nextcloud bot
75ddd315e3
[tx-robot] updated from transifex
2019-01-24 01:49:14 +00:00
Nextcloud bot
179ab90fce
[tx-robot] updated from transifex
2019-01-23 01:48:46 +00:00
Javier Llorente
cbc19e86fb
Add sync date next to "Synchronized with local folder"
2019-01-22 23:16:57 +01:00
Nextcloud bot
198b95676a
[tx-robot] updated from transifex
2019-01-22 01:49:05 +00:00
Nextcloud bot
63e5e4e92d
[tx-robot] updated from transifex
2019-01-21 01:48:04 +00:00
Nextcloud bot
107bf5db6d
[tx-robot] updated from transifex
2019-01-20 01:48:41 +00:00
Nextcloud bot
38449bf179
[tx-robot] updated from transifex
2019-01-19 01:49:57 +00:00
kilian.pfeiffer
10073c1f10
changed max GUI bandwith limits
2019-01-18 15:11:52 +01:00
Nextcloud bot
8710d70a0a
[tx-robot] updated from transifex
2019-01-18 01:52:08 +00:00
Nextcloud bot
b0e8837b94
[tx-robot] updated from transifex
2019-01-17 01:49:26 +00:00
Nextcloud bot
aadd2ff7ac
[tx-robot] updated from transifex
2019-01-16 01:50:23 +00:00
Jan-Christoph Borchardt
8a35bfdc13
Remove outdated icons
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net >
2019-01-15 19:59:34 +01:00
Nextcloud bot
7dfe21fe35
[tx-robot] updated from transifex
2019-01-15 01:52:13 +00:00
Roeland Jago Douma
310266f9fa
Merge pull request #1006 from javierllorente/master
...
Wizard: show an error message if there is no enough free space in the local folder
2019-01-14 09:52:51 +01:00
Nextcloud bot
33e3b7098f
[tx-robot] updated from transifex
2019-01-14 01:49:44 +00:00
Javier Llorente
e5b5573711
Show an error message if there is no enough free space in the local
...
folder
2019-01-13 23:35:06 +01:00
Nextcloud bot
5e4abbc0c1
[tx-robot] updated from transifex
2019-01-13 01:49:32 +00:00
Nextcloud bot
9e6e6dd5db
[tx-robot] updated from transifex
2019-01-12 01:48:02 +00:00
Nextcloud bot
79e196a22f
[tx-robot] updated from transifex
2019-01-11 01:49:11 +00:00
Nextcloud bot
d73c4273ad
[tx-robot] updated from transifex
2019-01-10 01:47:53 +00:00
Nextcloud bot
86a1bc36cb
[tx-robot] updated from transifex
2019-01-09 01:50:35 +00:00
Nextcloud bot
aa600b4a24
[tx-robot] updated from transifex
2019-01-08 01:47:12 +00:00
Roeland Jago Douma
27298a2056
Merge pull request #959 from yan12125/correct-webview-deallocation
...
Make sure _profile and _page are deleted in the correct order
2019-01-07 15:01:23 +01:00
Roeland Jago Douma
5ebee92991
Merge pull request #1001 from nextcloud/fix/279/handle_username_space
...
Handle spaces in username properly in login flow
2019-01-07 14:21:52 +01:00
Roeland Jago Douma
9ec61a84ce
Handle spaces in username properly in login flow
...
Fixes #279
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-01-07 10:41:01 +01:00
Roeland Jago Douma
cacf3e9924
Merge pull request #923 from ivaradi/disco-support
...
Support Ubuntu Disco Dingo
2019-01-07 09:53:04 +01:00
Roeland Jago Douma
dc993d3ebe
Merge pull request #981 from yan12125/fix-kde-cmake-warnings
...
Fix KDEInstallDirs deprecation warnings
2019-01-07 09:49:07 +01:00
István Váradi
51829bfb47
Merge branch 'master' into disco-support
2019-01-07 09:40:39 +01:00
Roeland Jago Douma
6dfe160cef
Merge pull request #993 from HuemerGroup/stylesheet-fix
...
Removed Stylesheet
2019-01-07 09:33:53 +01:00
Nextcloud bot
a2f1ee05ba
[tx-robot] updated from transifex
2019-01-07 01:47:36 +00:00
István Váradi
76b9d5c0c3
Merge branch 'master' into disco-support
2019-01-06 16:53:46 +01:00
Nextcloud bot
51d349f527
[tx-robot] updated from transifex
2019-01-06 02:01:14 +00:00
Roeland Jago Douma
188125dd88
Merge branch 'master' into disco-support
2019-01-05 22:08:24 +01:00
Nextcloud bot
d8aed94ab1
[tx-robot] updated from transifex
2019-01-05 01:47:29 +00:00
Nextcloud bot
86d7d41e40
[tx-robot] updated from transifex
2019-01-04 02:31:36 +00:00
Oskar Kruschitz
74454d0452
Removed Stylesheet
...
Stylesheet String was not correctly defined (missing ";" after "%2") and caused an error in logging output.
After checking the fixed Style I removed it since it does not really look good.
2019-01-03 15:54:50 +01:00
Nextcloud bot
0dcf6c6024
[tx-robot] updated from transifex
2019-01-03 01:46:40 +00:00
Nextcloud bot
0a14f6eeb1
[tx-robot] updated from transifex
2019-01-02 01:46:49 +00:00
Nextcloud bot
b59b633a3d
[tx-robot] updated from transifex
2019-01-01 01:46:32 +00:00
Nextcloud bot
d6b34323c5
[tx-robot] updated from transifex
2018-12-31 01:48:26 +00:00
Nextcloud bot
716517db98
[tx-robot] updated from transifex
2018-12-30 01:50:18 +00:00
Nextcloud bot
76c515b09c
[tx-robot] updated from transifex
2018-12-29 01:46:03 +00:00
Nextcloud bot
ac367b21bc
[tx-robot] updated from transifex
2018-12-28 15:52:56 +00:00
Chih-Hsuan Yen
1361c3053a
Fix KDEInstallDirs deprecation warnings
...
Get rid of a bunch of such warnings from configuring the Dolphin plugin:
CMake Deprecation Warning at /usr/share/ECM/kde-modules/KDEInstallDirs.cmake:345 (message):
BIN_INSTALL_DIR is deprecated, use KDE_INSTALL_BINDIR instead.
Call Stack (most recent call first):
/usr/share/ECM/kde-modules/KDEInstallDirs.cmake:433 (_define_relative)
shell_integration/dolphin/CMakeLists.txt:23 (include)
Modified from https://github.com/owncloud/client/pull/6922
Original author: Dominik Schmidt <dev@dominik-schmidt.de >
2018-12-28 21:55:45 +08:00
Nextcloud bot
b46ee79081
[tx-robot] updated from transifex
2018-12-27 01:49:06 +00:00
Nextcloud bot
9cea77b0fb
[tx-robot] updated from transifex
2018-12-26 01:50:50 +00:00
Nextcloud bot
c04addc5c4
[tx-robot] updated from transifex
2018-12-24 01:55:12 +00:00
Nextcloud bot
c2f4326908
[tx-robot] updated from transifex
2018-12-23 01:50:47 +00:00
Nextcloud bot
f6d3229b38
[tx-robot] updated from transifex
2018-12-21 01:47:16 +00:00
Nextcloud bot
3451970751
[tx-robot] updated from transifex
2018-12-20 01:48:23 +00:00
Chih-Hsuan Yen
09b0055dc3
Make sure _profile and _page are deleted in the correct order
...
Inspired by https://github.com/electron/electron/pull/15028
Closes https://github.com/nextcloud/desktop/issues/941
Closes https://github.com/nextcloud/desktop/issues/950
2018-12-19 21:44:54 +08:00
Nextcloud bot
24907acc2a
[tx-robot] updated from transifex
2018-12-17 01:48:23 +00:00
Nextcloud bot
01bbfaacf3
[tx-robot] updated from transifex
2018-12-16 01:48:42 +00:00
Nextcloud bot
6d5da44947
[tx-robot] updated from transifex
2018-12-15 01:46:20 +00:00
Roeland Jago Douma
071709ab5e
Merge pull request #946 from hiiamok/qt5.12-wizard-webview
...
Added missing Include
2018-12-13 19:34:42 +01:00
Oskar Kruschitz
1295884420
Added missing Include
...
Fixing an error during Build with Qt5.12:
error: member access into incomplete type 'const QWebEngineCertificateError'
2018-12-13 16:13:01 +01:00
Nextcloud bot
6d661e0b3d
[tx-robot] updated from transifex
2018-12-13 01:48:20 +00:00
Nextcloud bot
e0430288ce
[tx-robot] updated from transifex
2018-12-12 01:54:46 +00:00
Nextcloud bot
a7b16e3c28
[tx-robot] updated from transifex
2018-12-11 01:47:42 +00:00
Nextcloud bot
abe22d8fe6
[tx-robot] updated from transifex
2018-12-10 05:20:00 +00:00
Nextcloud bot
1ad7116045
[tx-robot] updated from transifex
2018-12-09 01:48:57 +00:00
Nextcloud bot
72777be571
[tx-robot] updated from transifex
2018-12-07 01:47:38 +00:00
Camila Ayres
840904d527
Merge pull request #778 from jpnurmi/background
...
Add a command line option to launch the client in the background
2018-12-06 09:53:19 +01:00
Camila Ayres
f91678ef24
Merge branch 'master' into background
2018-12-06 09:35:15 +01:00
Nextcloud bot
6cf390f753
[tx-robot] updated from transifex
2018-12-06 01:54:12 +00:00
István Váradi
20b9404539
Support Ubuntu Disco Dingo
2018-12-05 19:46:45 +01:00
Nextcloud bot
0ff23eabca
[tx-robot] updated from transifex
2018-12-05 01:48:53 +00:00
Camila San
b37cbea5cc
Updates desktop client version to 2.5.1.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-12-04 12:18:06 +01:00
Nextcloud bot
fc18fd9a06
[tx-robot] updated from transifex
2018-12-04 01:57:46 +00:00
Nextcloud bot
07116707e5
[tx-robot] updated from transifex
2018-12-03 01:45:39 +00:00
Nextcloud bot
0f935b06e9
[tx-robot] updated from transifex
2018-12-02 01:47:55 +00:00
Nextcloud bot
a0d6f5fb60
[tx-robot] updated from transifex
2018-12-01 01:45:33 +00:00
Nextcloud bot
4ddfc04534
[tx-robot] updated from transifex
2018-11-30 01:46:30 +00:00
Nextcloud bot
9fb5b4a92d
[tx-robot] updated from transifex
2018-11-29 01:48:27 +00:00
Camila Ayres
b97d8ba6db
Merge pull request #898 from nextcloud/nautilus-integration-name
...
Fix appname for Nautilus integration script.
2018-11-28 12:21:27 +01:00
Jan-Christoph Borchardt
7d8bba6786
Fix appname for Nautilus integration script
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net >
2018-11-28 11:54:08 +01:00
Nextcloud bot
f0c6825746
[tx-robot] updated from transifex
2018-11-28 01:48:00 +00:00
Roeland Jago Douma
1490b186f9
Merge pull request #860 from nextcloud/fix/566/do_not_read_system_exclude
...
Do not read system exclude list if user exclude is present
2018-11-27 11:54:40 +01:00
Roeland Jago Douma
8b64db6344
Merge branch 'master' into fix/566/do_not_read_system_exclude
2018-11-27 11:19:20 +01:00
Roeland Jago Douma
ab85dfcd67
Merge pull request #880 from nextcloud/fix/873
...
Write the actual folder to the log
2018-11-27 11:16:10 +01:00
Nextcloud bot
13fdb32d4f
[tx-robot] updated from transifex
2018-11-27 01:51:22 +00:00
Camila Ayres
72901a4ed8
Merge branch 'master' into background
2018-11-26 21:07:14 +01:00
Nextcloud bot
558d3ad492
[tx-robot] updated from transifex
2018-11-26 01:52:12 +00:00
Nextcloud bot
0a04419180
[tx-robot] updated from transifex
2018-11-25 05:19:20 +00:00
Nextcloud bot
fdbc523f85
[tx-robot] updated from transifex
2018-11-24 01:44:00 +00:00
Roeland Jago Douma
287d78ffd3
Write the actual folder to the log
...
Fixes #873
Not all folder names are proper latin1.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-23 10:33:25 +01:00
Nextcloud bot
8418507483
[tx-robot] updated from transifex
2018-11-23 02:52:33 +00:00
Roeland Jago Douma
d1b9d100b4
Merge pull request #874 from nextcloud/fix_activity_busy_loop
...
Fix the activity loop
2018-11-22 23:09:57 +01:00
Roeland Jago Douma
b93c762205
Fix the activity loop
...
We should stop fetching the moment the activity stream is empty when
fetched. It doesn't matter if the current list is empty.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-22 10:40:00 +01:00
Nextcloud bot
528e1bef37
[tx-robot] updated from transifex
2018-11-22 01:47:38 +00:00
Nextcloud bot
73aed1d630
[tx-robot] updated from transifex
2018-11-21 01:47:22 +00:00
Nextcloud bot
7b446eef93
[tx-robot] updated from transifex
2018-11-20 01:48:03 +00:00
Roeland Jago Douma
1afaa22ddb
Merge pull request #859 from nextcloud/fix/788/no_activity_flood
...
Do not fetch activities if they are not enabled
2018-11-19 23:15:08 +01:00
Roeland Jago Douma
bdd5d423ed
Merge branch 'master' into fix/788/no_activity_flood
2018-11-19 21:29:58 +01:00
Roeland Jago Douma
44b5e07a80
Merge pull request #847 from jpnurmi/share-dialog-take-2
...
Share dialog alignment
2018-11-19 20:18:30 +01:00
Roeland Jago Douma
d8c0fb856c
Merge branch 'master' into share-dialog-take-2
2018-11-19 19:33:05 +01:00
Roeland Jago Douma
6cc496633f
Do not read system exclude list if user exclude is present
...
For #566
Since we only showed the user exclude list (and some extra items) the
system exclude list was still used.
This copies over the system exclude list (if it isn't there).
If it fails we use the system one still.
However if you now remove items from your own list it will really be
gone.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-19 15:35:32 +01:00
Roeland Jago Douma
1d0bf08a1c
Do not fetch activities if they are not enabled
...
Fixes #788
Fixes #834
If the activity app is not enabled we should not try to fetch the
activities at all.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-19 14:13:51 +01:00
Nextcloud bot
a3d1bd3a42
[tx-robot] updated from transifex
2018-11-19 01:46:32 +00:00
Roeland Jago Douma
1c0fbba98e
Merge pull request #854 from nextcloud/enoch85-patch-1
...
Change link to docs for NC 15
2018-11-18 16:34:14 +01:00
Daniel Hansson
2d6c5f393f
Change link to docs for NC 15
...
This changes the link for the "Host your own" link in the wizard.
2018-11-18 11:02:34 +01:00
Nextcloud bot
eaf339b11d
[tx-robot] updated from transifex
2018-11-18 01:48:31 +00:00
Roeland Jago Douma
3a50b57b5a
Merge pull request #848 from nextcloud/rakekniven-patch-1
...
Fixed typo
2018-11-17 13:08:06 +01:00
rakekniven
6c0cd4bd3a
Fixed typo
...
Reported at Transifex.
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de >
2018-11-17 11:36:16 +01:00
J-P Nurmi
d6170271e9
ShareDialog: increase the width
...
To match the old width it had before the alignment work.
2018-11-17 09:24:45 +01:00
J-P Nurmi
6f145e3a80
ShareUserGroupWidget: allow frame when scrollable
2018-11-17 09:22:52 +01:00
J-P Nurmi
3c193143f2
Cleanup sharedialog.ui
2018-11-17 09:22:52 +01:00
J-P Nurmi
b25e15347b
ShareUserGroupWidget: fix scroll area size management
2018-11-17 09:22:52 +01:00
J-P Nurmi
a8cce41f35
sharedialog.ui: fix scroll area size
2018-11-17 09:22:52 +01:00
J-P Nurmi
f0f691fffc
Cleanup shareuserline.ui
2018-11-17 09:22:52 +01:00
J-P Nurmi
847706432b
ShareLinkWidget: redo the layout
...
NOTE: The progress indicator is temporarily moved one line up to avoid
inserting it on its own line, which would cause the content pushed down
and the dialog size jump back and forth.
2018-11-17 09:22:52 +01:00
J-P Nurmi
bd93489b14
Cleanup shareusergroupwidget.ui
...
Remove hard-coded fixed sizes, size constraints, and other unnecessary
property assignments. This works with any dialog width, meaning that
the width can be defined in one place higher up in the widget hierachy.
2018-11-17 09:22:52 +01:00
J-P Nurmi
96d0059ca4
ShareDialog: use auto-raising tool buttons as confirm buttons
2018-11-17 09:22:52 +01:00
J-P Nurmi
df802472cb
ShareLinkWidget: sync the confirm button size
2018-11-17 09:22:52 +01:00
J-P Nurmi
94750a5ea1
ShareUserGroupWidget: sync the share confirm button size with others
...
This keeps also the total width of the share dialog constant.
2018-11-17 09:22:52 +01:00
J-P Nurmi
fae1c0dbdd
ShareUserLine: fix eliding
...
The widget doesn't have its final size at construction time, so the
width for eliding is not yet known. Let ElidedLabel do the job.
2018-11-17 09:22:52 +01:00
J-P Nurmi
b546e7c224
ElidedLabel: add default constructor
...
Makes it possible to promote QLabel to an ElidedLabel in Qt Designer.
2018-11-17 09:22:52 +01:00
J-P Nurmi
cd58850f5b
ShareUserGroupWidget: remove nested content margins
2018-11-17 09:22:52 +01:00
J-P Nurmi
7d3242077b
ShareDialog: align the left margin
...
All other margins are 10px.
2018-11-17 09:22:52 +01:00
Nextcloud bot
3f2ff2e6ba
[tx-robot] updated from transifex
2018-11-17 02:02:47 +00:00
Roeland Jago Douma
433a059223
Merge pull request #843 from Aentfs/master
...
Change man page names and contents for nextcloud
2018-11-16 22:35:22 +01:00
Stefan Suhren
d6feb984c3
Change man page names and contents for nextcloud
2018-11-16 16:57:15 +01:00
Nextcloud bot
41f2864ac9
[tx-robot] updated from transifex
2018-11-16 01:47:40 +00:00
Nextcloud bot
b1a2683e62
[tx-robot] updated from transifex
2018-11-15 01:50:21 +00:00
Roeland Jago Douma
4febf7c70b
Merge pull request #823 from Awesome-Technologies/providers
...
Fix cmake build using WITH_PROVIDERS=OFF
2018-11-14 14:43:42 +01:00
Roeland Jago Douma
b8f0721fcb
Merge pull request #824 from ivaradi/debian-repo-update
...
Debian/Ubuntu target repository update
2018-11-14 14:30:51 +01:00
Roeland Jago Douma
8f95f68f06
Merge branch 'master' into providers
2018-11-14 13:18:37 +01:00
Nextcloud bot
c9b7078fb7
[tx-robot] updated from transifex
2018-11-14 01:47:56 +00:00
István Váradi
f0b96445d2
Fixed the PPA names as well
2018-11-13 20:49:26 +01:00
István Váradi
bcb4b44c69
Also use the correct OBS repository
2018-11-13 16:47:06 +01:00
István Váradi
82f9ec78dc
Use the version kind to differentiate between target repos
2018-11-13 16:44:20 +01:00
István Váradi
5a26e7dabe
Use the tags to determine if a version is a release or a beta one
2018-11-13 16:42:42 +01:00
Manuel Stahl
6718f5ad58
Fix cmake build using WITH_PROVIDERS=OFF
...
Fixes #821 .
2018-11-13 14:54:30 +01:00
Roeland Jago Douma
88c738dd21
Merge pull request #818 from nextcloud/enhancement/809/config-error
...
More verbose error and proper app name on configuration read error
2018-11-13 11:30:18 +01:00
Julius Härtl
2d79ea5262
More verbose error and proper app name on configuration read error
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-11-13 11:01:20 +01:00
Roeland Jago Douma
cc7abc02f4
Merge pull request #813 from jpnurmi/action-colors
...
SettingsDialog: tweak color aware icons
2018-11-13 08:16:41 +01:00
Roeland Jago Douma
e2c813bfca
Merge branch 'master' into action-colors
2018-11-13 07:41:53 +01:00
Roeland Jago Douma
5695aba5d7
Merge pull request #811 from jpnurmi/modernize
...
libsync: let Clang-Tidy modernize nullptr & override usage
2018-11-13 07:41:10 +01:00
Nextcloud bot
0f9e32d49c
[tx-robot] updated from transifex
2018-11-13 01:52:41 +00:00
Roeland Jago Douma
0d9d942ab7
Merge branch 'master' into modernize
2018-11-12 20:21:13 +01:00
Roeland Jago Douma
9de32d2cb7
Merge pull request #812 from jpnurmi/settings-dialog-accounts
...
SettingsDialog: fix a little glitch in the account tool button size
2018-11-12 20:10:30 +01:00
J-P Nurmi
53c89e2196
SettingsDialog: tweak color aware icons
...
If selected text is light, provide a light icon too when selected.
2018-11-12 20:04:02 +01:00
J-P Nurmi
b0959a6292
SettingsDialog: fix a little glitch in the account tool button size
...
SettingsDialog::accountAdded() uses the height of the toolbar to
calculate the desired default size for toolbuttons. Make sure to have
the "General" and "Network" tool buttons in place before calling
accountAdded() to avoid cramped first button.
2018-11-12 18:53:47 +01:00
J-P Nurmi
1af9bf8abc
libsync: run clang-tidy modernize-use-nullptr
2018-11-12 18:46:39 +01:00
J-P Nurmi
0d1c15a768
libsync: run clang-tidy modernize-use-override
2018-11-12 18:43:58 +01:00
J-P Nurmi
48acaec66f
libsync: search'n'replace "Q_DECL_OVERRIDE" with "override"
2018-11-12 18:39:50 +01:00
Roeland Jago Douma
9f6bb617e9
Merge pull request #807 from nextcloud/modernize
...
GUI: let Clang-Tidy modernize nullptr & override usage
2018-11-12 15:26:18 +01:00
Roeland Jago Douma
c5a4694c74
Merge branch 'master' into modernize
2018-11-12 14:56:35 +01:00
Roeland Jago Douma
0f2294cef4
Merge pull request #806 from nextcloud/server-notification-handler
...
Fixup the port in server notification URLs
2018-11-12 14:48:30 +01:00
Roeland Jago Douma
778489d445
Merge pull request #808 from jpnurmi/slideshow
...
Improve the slide show
2018-11-12 14:47:56 +01:00
J-P Nurmi
ba53a01339
SlideShow: don't allow clicks while animating
...
Changing slides while animating was looking a bit awkward.
2018-11-11 12:30:33 +01:00
J-P Nurmi
8217c44ee5
SlideShow: slow down the slide interval
...
The original non-animated slide show was running at 2500ms interval.
The new animated slide show was using the same interval, but used
1000ms to animate the slides. This left significantly less time for
the user to read the slides.
2018-11-11 12:27:21 +01:00
J-P Nurmi
fff64e8aa5
GUI: search'n'replace remaining "Q_DECL_OVERRIDE" with "override"
2018-11-11 11:12:37 +01:00
J-P Nurmi
8e38e2ac86
GUI: run clang-tidy modernize-use-override
2018-11-11 11:08:03 +01:00
J-P Nurmi
fb5ff96ed6
GUI: run clang-tidy modernize-use-nullptr
2018-11-11 10:56:22 +01:00
Nextcloud bot
371001c9ff
[tx-robot] updated from transifex
2018-11-11 01:51:25 +00:00
J-P Nurmi
91602574a9
Fixup the port in server notification URLs
...
... in addition to fixing up the scheme and host.
For example, the survey app sends "/settings/admin/survey_client" as
a link. Clicking the "More information" button wouldn't lead to the
correct place if NC was running on a custom port.
2018-11-10 22:24:17 +01:00
Nextcloud bot
8367dbc67f
[tx-robot] updated from transifex
2018-11-10 01:49:34 +00:00
rakekniven
ee96d998e5
Merge pull request #803 from nextcloud/rakekniven-patch-1
...
l10n. Added space for correct grammar.
2018-11-09 17:06:25 +01:00
rakekniven
a73da99d78
Merge branch 'master' into rakekniven-patch-1
2018-11-09 16:37:43 +01:00
rakekniven
f25ef73772
l10n. Added space for correct grammar.
...
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de >
2018-11-09 16:37:29 +01:00
Roeland Jago Douma
cf0838643f
Merge pull request #800 from nextcloud/fix/open_activities_on_conflict
...
Actually open the activity view on a click for more info
2018-11-09 16:36:24 +01:00
Roeland Jago Douma
559fd910d8
Merge pull request #801 from nextcloud/fix/generated_avatar_not_black
...
Use a format that supports alpha channels for avatars
2018-11-09 15:15:46 +01:00
Roeland Jago Douma
3a0c7f64c0
Use a format that supports alpha channels for avatars
...
If we use the source format it can result in fully black images. As the
basic generated avatar doesn't have an alpha channel.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-09 13:01:28 +01:00
Roeland Jago Douma
7925c6c081
Actually open the activity view on a click for more info
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-09 12:12:25 +01:00
Roeland Jago Douma
9c0e5c2b19
Merge pull request #797 from alexcustos/issue_alternative_log_in
...
Added default scheme when server returns just a host
2018-11-09 08:52:39 +01:00
Nextcloud bot
c387592e47
[tx-robot] updated from transifex
2018-11-09 01:48:22 +00:00
Camila Ayres
b1d68f311d
Merge pull request #798 from alexcustos/issues_openssl_1_1
...
Removed explicit initialization; Fixed RAND_bytes not found
2018-11-08 10:26:47 +01:00
Aleksandr Borisenko
f5586baee7
Added default scheme when server returns just a host
2018-11-08 11:35:27 +03:00
Aleksandr Borisenko
bb2d31a2bd
Removed explicit initialization; Fixed RAND_bytes not found
2018-11-08 11:24:39 +03:00
Nextcloud bot
82cbee3f9d
[tx-robot] updated from transifex
2018-11-08 01:48:27 +00:00
Roeland Jago Douma
347f4c8675
Merge pull request #796 from nextcloud/settings-dialog-height
...
SettingsDialog: disable unnecessary wrapping for the about label
2018-11-07 21:09:27 +01:00
J-P Nurmi
3a6d0ee29c
SettingsDialog: disable unnecessary wrapping for the about label
...
For some reason, QLabel with rich text and word wrapping enabled
calculates quite a bit too large size hint. Luckily, it's rich text
that is already divided to paragraphs so that wrapping makes actually
very little visual difference. For example, on my screen, when the
settings dialog is resized horizontally to the minimum, the only word
that actually wrapped was "2017". After this patch, it naturally won't
wrap anymore, but the General Settings page also doesn't leave a large
gap at the bottom. As a result, the minimum height of the dialog went
down from 581 to 525. The exact values depend on the style and fonts.
Fixes #91 .
2018-11-07 20:01:28 +01:00
J-P Nurmi
ee8bcb2a5b
Add a command line option to launch the client in the background
...
Allow passing a --background argument to force the app in the background
even if systray is not available.
Fixes #737
2018-11-07 18:42:36 +01:00
Roeland Jago Douma
1b6e0c5292
Merge pull request #794 from jpnurmi/activity-text-colors
...
Fix ActivityWidget palette
2018-11-07 10:13:00 +01:00
Roeland Jago Douma
32cf2f2622
Merge branch 'master' into activity-text-colors
2018-11-07 09:29:15 +01:00
Nextcloud bot
6bd6bd3ed9
[tx-robot] updated from transifex
2018-11-07 01:48:19 +00:00
Roeland Jago Douma
13e1b6a34a
Merge pull request #790 from nextcloud/fix/789/osx_installer_background
...
Update isntaller background for OSX
2018-11-06 11:11:16 +01:00
Roeland Jago Douma
6ada87ed15
Update isntaller background for OSX
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-06 10:39:10 +01:00
Nextcloud bot
da367f17ab
[tx-robot] updated from transifex
2018-11-06 01:50:02 +00:00
J-P Nurmi
d01a99e9e5
ActivityWidget: remove a hard-coded white background
...
Let the system palette provide the appropriate color.
Fixes #742 .
2018-11-05 22:13:34 +01:00
J-P Nurmi
b8d97b590f
Fix palette usage in ActivityItemDelegate::paint()
...
Fixes #742 .
2018-11-05 20:18:54 +01:00
Roeland Jago Douma
5a1fed8e23
Merge pull request #785 from nextcloud/we_are_nextcloud
...
Use Nextcloud
2018-11-05 13:57:17 +01:00
Roeland Jago Douma
fe60a2a570
Use Nextcloud
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-05 13:27:30 +01:00
Roeland Jago Douma
aee0363876
Merge pull request #783 from nextcloud/doc/cmake-build
...
Fix cmake build of documentation
2018-11-05 11:26:36 +01:00
Julius Härtl
abac2c327e
Fix cmake build of documentation
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-11-05 10:56:21 +01:00
Nextcloud bot
6dae188ed9
[tx-robot] updated from transifex
2018-11-05 01:49:43 +00:00
Roeland Jago Douma
2b760cd63b
Merge pull request #781 from ivaradi/qt5.5-compat
...
Qt 5.5 compatibility patch for Xenial
2018-11-04 21:08:44 +01:00
Roeland Jago Douma
54b490c8d1
Merge branch 'master' into qt5.5-compat
2018-11-04 20:41:33 +01:00
Roeland Jago Douma
1e6b0b8924
Merge pull request #780 from jpnurmi/margins
...
Margins
2018-11-04 20:20:42 +01:00
Roeland Jago Douma
ef15534c64
Merge branch 'master' into margins
2018-11-04 19:40:40 +01:00
István Váradi
ea806a1287
Patch for Xenial to be able to compile with Qt 5.5
2018-11-04 17:28:13 +01:00
Roeland Jago Douma
b904d79d8f
Merge pull request #776 from nextcloud/feature/migrate_http_to_webflow
...
Migrate http auth to webflow
2018-11-04 14:03:13 +01:00
Roeland Jago Douma
0c535872cb
Merge branch 'master' into feature/migrate_http_to_webflow
2018-11-04 13:47:04 +01:00
Nextcloud bot
15553df34e
[tx-robot] updated from transifex
2018-11-04 01:54:37 +00:00
J-P Nurmi
028979d752
ActivityWidget: remove double margins
...
To align margins with the account settings tab, so the content doesn't
jump when switching tabs.
2018-11-03 23:03:54 +01:00
J-P Nurmi
1e1d116052
SettingsDialog: remove an unused button box
...
This makes the bottom margin aligned with horizontal margins, and
eliminates a warning on startup:
[unknown QObject::connect: Cannot connect (null)::clicked() to OCC::SettingsDialog::accept()
2018-11-03 22:49:48 +01:00
Roeland Jago Douma
045bba0161
Migrate http auth to webflow
...
This moves all the basic http auth over to the webflow mechanism.
This thus also makes sure that if the password changes a webflow page
pops up. And thus will directly move them over to apptokens then.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-03 12:37:53 +01:00
Nextcloud bot
b44408a91b
[tx-robot] updated from transifex
2018-11-03 01:49:48 +00:00
Roeland Jago Douma
af8a2819be
Merge pull request #768 from nextcloud/fix/766/copy_over_old_windows_config
...
Copy over config file to new location on windows
2018-11-02 21:01:22 +01:00
Roeland Jago Douma
17d05a2ad4
Merge pull request #750 from jpnurmi/slideshow
...
Setup wizard: implement an animated and interactive slide show
2018-11-02 12:21:07 +01:00
Roeland Jago Douma
0f767ed995
Increase durations a bit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-02 11:10:57 +01:00
Roeland Jago Douma
e6f1d7632a
Merge branch 'master' into slideshow
2018-11-02 10:43:01 +01:00
Roeland Jago Douma
40c36a9ed3
Merge pull request #756 from jpnurmi/add-button
...
Make the "Add Folder Sync Connection" button act like a button
2018-11-02 10:39:00 +01:00
Roeland Jago Douma
67714d33db
Merge pull request #744 from jpnurmi/remove-qtsvg-include
...
Build fix: remove an unused QtSvg/QSvgRenderer include
2018-11-02 10:31:01 +01:00
Roeland Jago Douma
e01cb108e1
Merge pull request #754 from kevin147147/patch-1
...
theming for general settings ui
2018-11-02 10:08:18 +01:00
Roeland Jago Douma
3e634dad70
Merge pull request #764 from Awesome-Technologies/user_group_widget
...
Fix warning in ShareUserGroupWidget
2018-11-02 10:05:14 +01:00
Nextcloud bot
c2d947ee02
[tx-robot] updated from transifex
2018-11-02 01:51:45 +00:00
Roeland Jago Douma
28fe702e8e
Merge pull request #769 from nextcloud/l10n/update
...
Update to translate strings
2018-11-01 16:13:10 +01:00
Roeland Jago Douma
baf4d5f9fc
Update to translate strings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-01 15:22:41 +01:00
Roeland Jago Douma
188a1a6e24
Copy over config file to new location on windows
...
Fixes #766
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-11-01 15:02:31 +01:00
Roeland Jago Douma
899fca12ba
Merge pull request #721 from storca/patch-1
...
Inform user that configuration is not writable
2018-11-01 11:44:37 +01:00
Roeland Jago Douma
0f1395fdf0
Merge pull request #758 from nextcloud/self-signed-login-flow
...
Allow to use the login flow with a self signed certificate
2018-11-01 11:43:54 +01:00
Manuel Stahl
c9f720b68d
Fix warning in ShareUserGroupWidget
...
Change-Id: I63091c67cd56dce241f04ed6badc090bb25cad5f
2018-11-01 10:26:19 +01:00
Roeland Jago Douma
b30a8528bd
Merge pull request #645 from nextcloud/upstream/wizard
...
Wizard enhancement
2018-11-01 09:30:19 +01:00
Roeland Jago Douma
bb4c180c89
Merge branch 'master' into upstream/wizard
2018-11-01 08:32:12 +01:00
Roeland Jago Douma
a23dd9dfb3
Merge pull request #646 from nextcloud/upstream/pr/6656
...
FolderMan::checkPathValidityForNewFolder: make sure to work when fold…
2018-11-01 08:31:36 +01:00
Roeland Jago Douma
3b5d8f0277
Merge branch 'master' into upstream/pr/6656
2018-11-01 08:07:55 +01:00
Nextcloud bot
feb9a69703
[tx-robot] updated from transifex
2018-11-01 01:50:27 +00:00
Roeland Jago Douma
fd2293b067
Merge pull request #655 from nextcloud/upstream/pr/6671
...
Do not require server replies to contain an mtime
2018-10-31 22:19:26 +01:00
Roeland Jago Douma
5cfdc71ca5
Merge branch 'master' into upstream/pr/6671
2018-10-31 21:13:10 +01:00
Roeland Jago Douma
d3ee6ed9c5
Merge pull request #651 from nextcloud/upstream/pr/6616
...
Update: Report on readdir() errors #6610
2018-10-31 21:12:54 +01:00
J-P Nurmi
08879c0f14
Make the "Add Folder Sync Connection" button act like a button
2018-10-31 20:05:14 +01:00
Roeland Jago Douma
b7d0e5672a
Merge branch 'master' into upstream/pr/6616
2018-10-31 13:51:34 +01:00
Nextcloud bot
a39d4777fd
[tx-robot] updated from transifex
2018-10-31 01:49:53 +00:00
Roeland Jago Douma
cb4450864e
Merge pull request #656 from nextcloud/upstream/pr/6672
...
Settings: Attempt to fix rename issue on old macOS
2018-10-30 23:04:34 +01:00
Roeland Jago Douma
ef3aeb65cc
Merge pull request #658 from nextcloud/upstream/pr/6698
...
OAuth: Fix infinite loop when the refresh token is expired
2018-10-30 23:04:09 +01:00
Roeland Jago Douma
aca75ee982
Merge pull request #403 from nextcloud/upstream/pr/6372
...
Partial local discovery: Fix scheduling logic
2018-10-30 23:03:16 +01:00
Roeland Jago Douma
326c872ba7
Merge pull request #663 from nextcloud/upstream/pr/6707
...
Windows: Release handle/fd when file open fails #6699
2018-10-30 22:40:44 +01:00
Roeland Jago Douma
dd39887f2b
Merge pull request #641 from nextcloud/upstream/pr/6621
...
TestOAuth: Don't have global static QObject
2018-10-30 22:38:51 +01:00
Roeland Jago Douma
8df9746005
Merge branch 'master' into upstream/pr/6372
2018-10-30 22:37:30 +01:00
Roeland Jago Douma
668c53a0af
Allow to use the login flow with a self signed certificate
...
The QWebEngine uses a different certificate store/system. So we can't
just pass wour accepted certificates in there.
As a work around we now trust the url we set by definition. As this has
to already be approved before we access this.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-10-30 22:23:10 +01:00
kevin147147
30032f9c0c
i18n for general settings ui
2018-10-30 17:32:52 +01:00
Nextcloud bot
f2bc5c0482
[tx-robot] updated from transifex
2018-10-30 01:52:44 +00:00
J-P Nurmi
1d3d261e38
Setup wizard: implement an animated and interactive slide show
2018-10-29 19:10:27 +01:00
Nextcloud bot
c40793257d
[tx-robot] updated from transifex
2018-10-29 01:51:50 +00:00
Roeland Jago Douma
85b9f94a36
Merge pull request #748 from caugner/qtkeychain-0.9.1
...
qtkeychain: 0.8.0 -> 0.9.1
2018-10-28 19:45:17 +01:00
Roeland Jago Douma
8688fabee3
Merge branch 'master' into qtkeychain-0.9.1
2018-10-28 19:20:16 +01:00
Nextcloud bot
e88b81c6c9
[tx-robot] updated from transifex
2018-10-27 00:51:13 +00:00
Claas Augner
2344db8937
qtkeychain: 0.8.0 -> 0.9.1
2018-10-26 18:49:03 +02:00
Nextcloud bot
58302e9fc0
[tx-robot] updated from transifex
2018-10-26 00:50:27 +00:00
J-P Nurmi
f48aabf344
Build fix: remove an unused QtSvg/QSvgRenderer include
...
Slipped in in 156605c .
2018-10-25 21:32:43 +02:00
Roeland Jago Douma
8acc5573ff
Merge pull request #667 from nextcloud/upstream/pr/6592
...
SettingsDialog: Show the page for the newly created account
2018-10-25 08:23:51 +02:00
Roeland Jago Douma
6224f6a1fa
Merge branch 'master' into upstream/pr/6592
2018-10-25 07:44:04 +02:00
Nextcloud bot
44bc637237
[tx-robot] updated from transifex
2018-10-25 00:49:57 +00:00
Julius Härtl
99d4f81892
Merge branch 'master' into upstream/pr/6592
2018-10-24 22:38:11 +02:00
Julius Härtl
98bedf1031
Merge pull request #659 from nextcloud/upstream/issues/6696-6610
...
Windows: Don't ignore files with FILE_ATTRIBUTE_TEMPORARY
2018-10-24 22:25:16 +02:00
storca
ef8e029cbf
Merge branch 'master' into patch-1
2018-10-24 18:10:35 +02:00
Roeland Jago Douma
eb31e9205c
Merge branch 'master' into upstream/issues/6696-6610
2018-10-24 16:50:39 +02:00
Roeland Jago Douma
c8204f1725
Merge pull request #640 from nextcloud/upstream/pr/6617
...
OAuth: Remove the timeout
2018-10-24 16:49:59 +02:00
Roeland Jago Douma
174f99728f
Merge branch 'master' into upstream/pr/6617
2018-10-24 16:27:31 +02:00
Roeland Jago Douma
dcdf6d966d
Merge pull request #717 from tuxmaster5000/gitignore
...
Add cmake temporary stuff
2018-10-24 13:22:56 +02:00
Roeland Jago Douma
3e79ebed60
Merge pull request #661 from nextcloud/upstream/pr/6712
...
nautilus: Fix GET_MENU_ITEMS with utf8 filenames #6643
2018-10-24 13:22:22 +02:00
Roeland Jago Douma
5237a2c3e2
Merge branch 'master' into upstream/pr/6712
2018-10-24 08:59:29 +02:00
Roeland Jago Douma
6e0d636989
Merge pull request #595 from nextcloud/upstream/pr/6485
...
Show a tray message when a folder watcher becomes unreliable #6119
2018-10-24 08:59:15 +02:00
Roeland Jago Douma
d246c1e8b9
Merge branch 'master' into upstream/pr/6485
2018-10-24 08:27:11 +02:00
Roeland Jago Douma
96541d8ab8
Merge pull request #657 from nextcloud/upstream/pr/6688
...
Support higher resolution theme icons
2018-10-24 08:23:41 +02:00
Roeland Jago Douma
091c4fd9b0
Merge branch 'master' into upstream/pr/6688
2018-10-24 07:29:10 +02:00
Nextcloud bot
8098566140
[tx-robot] updated from transifex
2018-10-24 00:50:56 +00:00
Roeland Jago Douma
21dc97b809
Merge pull request #644 from nextcloud/upstream/pr/6632
...
Reconcile: When detecting a local move, keep the local mtime
2018-10-23 23:13:58 +02:00
Julius Härtl
23883b2b60
Merge branch 'master' into patch-1
2018-10-23 23:11:21 +02:00
Julius Härtl
0f9b8daa57
Merge branch 'master' into upstream/pr/6712
2018-10-23 23:09:26 +02:00
Dominik Schmidt
cddb9aa8ba
Support higher resolution theme icons
2018-10-23 23:07:17 +02:00
Roeland Jago Douma
24606c0105
Merge branch 'master' into upstream/pr/6632
2018-10-23 22:51:12 +02:00
Roeland Jago Douma
3384f7e28b
Merge pull request #660 from nextcloud/upstream/pr/6674
...
Data-Fingerprint: Fix backup detection when fingerprint is empty
2018-10-23 22:50:54 +02:00
Roeland Jago Douma
6b7328bb87
Merge branch 'master' into upstream/pr/6632
2018-10-23 22:48:34 +02:00
Roeland Jago Douma
f3529e3dd7
Merge branch 'master' into upstream/pr/6674
2018-10-23 21:43:13 +02:00
Roeland Jago Douma
305952e32e
Merge pull request #634 from nextcloud/upstream/issue/6581
...
Ensure GETFileJob notices finishing #6581
2018-10-23 21:26:21 +02:00
Roeland Jago Douma
c37186cc56
Merge branch 'master' into upstream/issue/6581
2018-10-23 21:08:51 +02:00
Roeland Jago Douma
4e866123c5
Merge pull request #635 from nextcloud/upstream/issue/6522
...
OAuth2: Try to refresh the token even if the credentials weren't ready.
2018-10-23 21:07:04 +02:00
Roeland Jago Douma
35c0c9c0b1
Merge branch 'master' into upstream/issue/6522
2018-10-23 20:13:28 +02:00
Roeland Jago Douma
d3bc9fbdf3
Merge pull request #639 from nextcloud/upstream/pr/6605
...
UpdateInfo: Remove unused code
2018-10-23 13:05:27 +02:00
Roeland Jago Douma
0cf2970134
Merge branch 'master' into upstream/pr/6605
2018-10-23 12:32:16 +02:00
Roeland Jago Douma
206f081505
Merge pull request #727 from nextcloud/fix-issue-268
...
Uses QByteArray to store private key.
2018-10-23 12:31:39 +02:00
Roeland Jago Douma
1c8307f264
Merge branch 'master' into fix-issue-268
2018-10-23 12:04:14 +02:00
Roeland Jago Douma
2d65091f27
Merge pull request #637 from nextcloud/upstream/issue/6545
...
Tray workarounds #6545
2018-10-23 11:48:08 +02:00
Roeland Jago Douma
a492ab8294
Merge branch 'master' into upstream/issue/6545
2018-10-23 10:59:56 +02:00
Nextcloud bot
3da6f45ba9
[tx-robot] updated from transifex
2018-10-23 00:43:03 +00:00
Julius Härtl
856d40fd99
Merge branch 'master' into upstream/issue/6581
2018-10-22 20:41:17 +02:00
Nextcloud bot
846075704e
[tx-robot] updated from transifex
2018-10-22 00:45:03 +00:00
Roeland Jago Douma
156308c72e
Merge branch 'master' into upstream/issue/6581
2018-10-21 14:19:07 +02:00
Camila Ayres
c99a35a8a5
Merge pull request #732 from st4ll1/master
...
Fix cmake command for linux in README too
2018-10-21 11:50:28 +02:00
Andreas Stallinger
f937fdd624
Fix cmake command for linux in README too
2018-10-21 10:40:44 +02:00
Nextcloud bot
1f8c3074a6
[tx-robot] updated from transifex
2018-10-21 00:44:18 +00:00
Nextcloud bot
11673005db
[tx-robot] updated from transifex
2018-10-20 00:43:12 +00:00
Roeland Jago Douma
df24a25829
Merge pull request #396 from nextcloud/upstream/pr/6360
...
SyncJournal: Clear etag filter before sync
2018-10-19 20:26:30 +02:00
Roeland Jago Douma
2dc7ff7332
Merge branch 'master' into upstream/pr/6360
2018-10-19 16:13:09 +02:00
Roeland Jago Douma
7ace48d5de
Merge pull request #643 from nextcloud/upstream/pr/6615
...
Log: Adjust update/reconcile log verbosity
2018-10-19 16:04:26 +02:00
Roeland Jago Douma
56ccff4ee8
Merge pull request #654 from nextcloud/upstream/sqlite-version-3-24
...
sqlite: Update bundled version to 3.24.0
2018-10-19 16:03:04 +02:00
Roeland Jago Douma
9d9f96a685
Merge branch 'master' into upstream/pr/6615
2018-10-19 15:43:50 +02:00
Nextcloud bot
052c37acda
[tx-robot] updated from transifex
2018-10-19 00:42:46 +00:00
Nextcloud bot
fd2e88e13b
[tx-robot] updated from transifex
2018-10-17 00:42:35 +00:00
storca
4bd3829f78
Merge branch 'master' into patch-1
2018-10-16 21:17:58 +02:00
tuxmaster5000
ddf1ac04e5
Merge branch 'master' into owncloud
2018-10-16 09:35:33 +02:00
tuxmaster5000
28b399ec2b
Merge branch 'master' into gitignore
2018-10-16 08:55:18 +02:00
Roeland Jago Douma
4bb936f876
Merge pull request #709 from nextcloud/fix-issue-665
...
Fixes #665 Adds slot for confirmShare button.
2018-10-15 13:58:16 +02:00
Roeland Jago Douma
6805d91033
Merge branch 'master' into fix-issue-665
2018-10-15 13:47:18 +02:00
Nextcloud bot
8da2b9dbf8
[tx-robot] updated from transifex
2018-10-15 00:43:12 +00:00
Camila San
45ff3385c7
Uses QByteArray to store private key.
...
Removes QSslkey. See #268
Signed-off-by: Camila San <hello@camila.codes >
2018-10-15 00:21:08 +02:00
Camila Ayres
53cc6a1611
Merge branch 'master' into gitignore
2018-10-14 16:17:13 +02:00
Camila Ayres
4e3b408c50
Merge branch 'master' into patch-1
2018-10-14 16:14:43 +02:00
Camila Ayres
aa388b86c0
Merge branch 'master' into owncloud
2018-10-14 16:13:01 +02:00
Nextcloud bot
bfc8154e68
[tx-robot] updated from transifex
2018-10-14 00:43:12 +00:00
storca
620908523e
Update accountmanager.cpp
...
Fixed syntax error
Possible fix for issue #720
2018-10-13 18:45:01 +02:00
storca
8a996ba9a9
Update accountmanager.cpp
...
Fixed issue #720 by adding the isWrittable method
2018-10-13 18:36:40 +02:00
Nextcloud bot
74d8f32f37
[tx-robot] updated from transifex
2018-10-13 00:42:33 +00:00
tuxmaster5000
f9c6449c05
Fix include file
2018-10-12 15:56:26 +02:00
tuxmaster5000
3c00c09ea8
Rename owncloud tests to nextcloud
2018-10-12 14:52:18 +02:00
tuxmaster5000
a5e329a1c5
Add cmake temporary stuff
2018-10-12 11:48:32 +02:00
Nextcloud bot
3fe44f0d25
[tx-robot] updated from transifex
2018-10-11 00:43:07 +00:00
Nextcloud bot
e207c91228
[tx-robot] updated from transifex
2018-10-10 00:50:58 +00:00
Nextcloud bot
cdf922f51d
[tx-robot] updated from transifex
2018-10-09 00:49:05 +00:00
Camila Ayres
45ffc0ae09
Merge pull request #710 from kevin147147/patch-1
...
Rename INSTALL to INSTALL.md for Preview :)
2018-10-08 22:00:22 +02:00
kevin147147
e214234001
Rename README to README.md
...
Preview :)
2018-10-08 21:01:08 +02:00
kevin147147
54e58b51ab
Rename INSTALL to INSTALL.md
...
Preview :)
2018-10-08 20:57:34 +02:00
Camila San
debe37308f
Fixes #665 Adds slot for confirmShare button.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-10-08 20:56:01 +02:00
Nextcloud bot
7c096d08aa
[tx-robot] updated from transifex
2018-10-07 00:50:40 +00:00
Nextcloud bot
ac631d008c
[tx-robot] updated from transifex
2018-10-06 00:48:41 +00:00
Nextcloud bot
f1cad3443b
[tx-robot] updated from transifex
2018-10-05 00:51:40 +00:00
Nextcloud bot
cacde7a3aa
[tx-robot] updated from transifex
2018-10-02 00:49:28 +00:00
Camila Ayres
b533c3582e
Updates issue_template.md.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-10-01 17:57:35 +02:00
Nextcloud bot
69f18f6b7d
[tx-robot] updated from transifex
2018-10-01 00:49:10 +00:00
Nextcloud bot
de80f7d6ca
[tx-robot] updated from transifex
2018-09-30 00:50:09 +00:00
Nextcloud bot
38ec3b8972
[tx-robot] updated from transifex
2018-09-29 00:47:33 +00:00
Nextcloud bot
52d40235b6
[tx-robot] updated from transifex
2018-09-28 00:43:34 +00:00
Nextcloud bot
0ee662bb0e
[tx-robot] updated from transifex
2018-09-27 00:52:10 +00:00
Nextcloud bot
5733e90b09
[tx-robot] updated from transifex
2018-09-26 00:52:09 +00:00
Nextcloud bot
95d2c64c1b
[tx-robot] updated from transifex
2018-09-25 00:51:54 +00:00
Nextcloud bot
b71c753a94
[tx-robot] updated from transifex
2018-09-24 00:49:25 +00:00
Nextcloud bot
bd88ddfa07
[tx-robot] updated from transifex
2018-09-23 01:19:35 +00:00
Nextcloud bot
373c6cd631
[tx-robot] updated from transifex
2018-09-22 00:52:01 +00:00
Nextcloud bot
a464ad2c71
[tx-robot] updated from transifex
2018-09-21 00:59:02 +00:00
Nextcloud bot
f3dd97f29c
[tx-robot] updated from transifex
2018-09-20 00:50:44 +00:00
Nextcloud bot
6587955668
[tx-robot] updated from transifex
2018-09-19 00:49:32 +00:00
Nextcloud bot
9013036685
[tx-robot] updated from transifex
2018-09-17 00:52:18 +00:00
Nextcloud bot
ebd632f582
[tx-robot] updated from transifex
2018-09-16 00:51:19 +00:00
Nextcloud bot
ce22007b16
[tx-robot] updated from transifex
2018-09-15 00:50:19 +00:00
Nextcloud bot
6a1043cef0
[tx-robot] updated from transifex
2018-09-14 00:51:47 +00:00
Nextcloud bot
82f3b4c91f
[tx-robot] updated from transifex
2018-09-13 00:50:42 +00:00
Nextcloud bot
d0b6a611f2
[tx-robot] updated from transifex
2018-09-12 00:49:42 +00:00
Camila Ayres
714a4090a7
Merge pull request #668 from nextcloud/update-qtmacgoodies
...
Updates submodule qtmacgoodies.
2018-09-11 16:41:45 +02:00
Camila San
63d7e54ef3
Updates submodule qtmacgoodies.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-09-11 16:11:47 +02:00
Markus Goetz
a2f4917daf
SettingsDialogMac: Show the page for the newly created account
2018-09-11 13:45:01 +02:00
Olivier Goffart
a09f1d14ba
SettingsDialog: Show the page for the newly created account
2018-09-11 13:44:22 +02:00
Nextcloud bot
96c37b1fac
[tx-robot] updated from transifex
2018-09-11 00:50:01 +00:00
Christian Kamm
4bd2545dad
Windows: Release handle/fd when file open fails #6699
2018-09-10 21:17:20 +02:00
Christian Kamm
f4dfdf5889
nautilus: Fix GET_MENU_ITEMS with utf8 filenames #6643
2018-09-10 21:06:57 +02:00
Olivier Goffart
08e4ba3363
Data-Fingerprint: Fix backup detection when fingerprint is empty
...
Add a test to test the data fingerprint feature make me realize it was broken.
The code was relying in the distinction between empty and null QByteArray,
but this was a bad idea as this difference is lost when going through QString.
2018-09-10 20:44:03 +02:00
Olivier Goffart
3b2c6d2202
OAuth: Fix infinite loop when the refresh token is expired
...
The server reply with a code 400 when the token is invalid,
the client was understanding this error as a network error, and was retying
again with the same token.
Instead, we must rely on what the json is saying, even if the reply is
not a 200 code.
Issue https://github.com/owncloud/enterprise/issues/2777
2018-09-10 20:22:40 +02:00
Markus Goetz
4f83bba829
Windows: Don't ignore files with FILE_ATTRIBUTE_TEMPORARY
...
Too many applications incorrectly use this attribute.
For #6696 #6610
2018-09-10 20:20:40 +02:00
Markus Goetz
109947ba3f
Settings: Attempt to fix rename issue on old macOS
...
Found by @hurradieweltgehtunter
2018-09-10 17:34:48 +02:00
Christian Kamm
5b228d1afd
Do not require server replies to contain an mtime
...
The check was added for #6317 in commit
13eb64584f .
We did see missing mtimes in replies in tests with live servers though.
Possibly those were old incomplete responses cached in the stat cache?
2018-09-10 17:33:53 +02:00
Camila San
90d3917481
Creates .github folder.
...
- Adds issue_template.md to folder .github - previously bug_report.md.
- This will enable the issue template when users creates issues.
Signed-off-by: Camila San <hello@camila.codes >
2018-09-10 17:17:39 +02:00
Camila San
d9cc362258
Adds bug_report.md file.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-09-10 17:09:22 +02:00
Camila Ayres
0a5f890bf9
Adds bug_report template.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-09-10 16:58:27 +02:00
Markus Goetz
b873311bc5
sqlite: Update bundled version to 3.24.0
...
For OS X and Windows.
2018-09-10 16:44:16 +02:00
Camila Ayres
eaa4e77626
Merge pull request #652 from ivaradi/nautilus-plugin-python-fix
...
Use encode()/decode() with Python 3 only.
2018-09-10 15:29:10 +02:00
István Váradi
7a7799407d
Merge branch 'master' into nautilus-plugin-python-fix
2018-09-10 15:17:14 +02:00
István Váradi
a4e23e7655
Merge pull request #598 from ivaradi/icon-name-fix
...
Create symlinks for the small-letter application icon file names
2018-09-10 15:16:45 +02:00
István Váradi
56ea525499
Use encode()/decode() with Python 3 only
2018-09-10 15:05:46 +02:00
István Váradi
e84bdd59c7
Use the correct icon name variable in mirall.desktop.in
2018-09-10 14:54:24 +02:00
István Váradi
b5f484aaf5
Revert "Create symlinks for the small-letter application icon file names"
...
This reverts commit 328f82297a .
2018-09-10 14:50:14 +02:00
Christian Kamm
3ec4fc6145
Update: Report on readdir() errors #6610
2018-09-10 14:33:36 +02:00
István Váradi
264b77c634
Merge branch 'master' into icon-name-fix
2018-09-10 14:08:35 +02:00
Nextcloud bot
23d64dd3ac
[tx-robot] updated from transifex
2018-09-10 00:50:19 +00:00
Olivier Goffart
b3e4ec9454
FolderMan::checkPathValidityForNewFolder: make sure to work when folder points to deleted folders
...
Note that we also needed to adjust the server url to contains the user name
in the folder wizard. (As checkPathValidityForNewFolder expect the user name)
Issue #6654
2018-09-09 22:02:44 +02:00
Olivier Goffart
39c6196487
Wizard: show a message when the URL is invalid
...
Rather than let Qt show "Host not found"
Issue #6646
2018-09-09 21:47:03 +02:00
Olivier Goffart
986cf448a9
Wizard OAuth2 Page: add a context menu to copy the link
...
Relates to https://github.com/owncloud/enterprise/issues/2600
2018-09-09 21:46:42 +02:00
Olivier Goffart
67f793a49e
Log: Remove inaccurate comment about --logdebug
...
The exact string is actually "sync.*.debug=true\ngui.*.debug=true".
And this is not strictly equivalent to setting the env var, as it
calls QLoggingCategory::setFilterRules.
Over all, that's an implementation details that users do not care about.
2018-09-09 21:44:55 +02:00
Olivier Goffart
d202942a2c
Reconcile: When detecting a local move, keep the local mtime
...
https://github.com/owncloud/client/issues/6629#issuecomment-402450691
2018-09-09 21:38:10 +02:00
Dmitry Mayorov
d338c130af
added logdebug
2018-09-09 21:36:47 +02:00
Christian Kamm
283c4b13a1
Log: Adjust update/reconcile log verbosity
...
Not having these enabled by default is causing significant extra back
and forth with reporters since they must manually use --logdebug for the
log to be useful.
2018-09-09 21:34:41 +02:00
Olivier Goffart
7019f03e46
TestOAuth: Don't have global static QObject
...
Fix a strange warning seen on the log from the CI on Windows in
https://github.com/owncloud/client/pull/6621
The test shows, at the beginning
QObject::connect: No such signal DesktopServiceHook::destroyed(QObject*)
And crashes at the and.
My guess is that when QDesktopServices::setUrlHandler is called, the
QMetaObject is not yet initialized
But this is probably not the reason of the crash
2018-09-09 18:16:59 +02:00
Olivier Goffart
40007537ea
OAuth: Remove the timeout
...
There is no real reason to have a timeout. The connection can stay open
as long as we are not authenticated. The User can still re-open a browser
from the UI at any time.
Issue #6612
2018-09-09 17:57:38 +02:00
Markus Goetz
6122a47241
UpdateInfo: Remove unused code
2018-09-09 17:39:56 +02:00
Christian Kamm
ce3339a00f
fixup: remove outdated Qt5.5 workaround code
2018-09-09 17:27:30 +02:00
Christian Kamm
14df7a3273
fixup: use initializer for contextMenuVisibleManual
2018-09-09 17:23:49 +02:00
Christian Kamm
9330d2b178
fixup: make logging "info"
2018-09-09 17:15:58 +02:00
Christian Kamm
87dd198b52
Tray workarounds #6545
...
* Disentangle the previous 'qdbusWorkarounds' into three different
things
* Make not trusting tray.isVisible() a new workaround
* Introduce env vars for all workaround flags
* Use the workaround flags for OSX
* Determine workaround flags for KDE when the plasma integration plugin
is missing
2018-09-09 13:17:31 +02:00
Olivier Goffart
a68c95522d
OAuth2: Try to refresh the token even if the credentials weren't ready.
...
This can happen when the client is started and the internet connection
was not enabled. Then we would fetch the credentials, but we would
no do the refresh token step (because network is down).
So next time we try to connect, we would also not refresh the token
because the credentials are not marked as 'ready'
Reported in
https://github.com/owncloud/client/issues/6522#issuecomment-396845167
2018-09-09 12:00:59 +02:00
Christian Kamm
cba0627a9c
Ensure GETFileJob notices finishing #6581
...
It could happen that readyRead was emitted for incoming data while the
download was not yet finished. Then the network job could finish with
no more data arriving - so readyRead wasn't emitted again.
To fix this, the finished signal also gets connected to the readyRead
slot.
2018-09-09 11:50:00 +02:00
Nextcloud bot
cb69944b5c
[tx-robot] updated from transifex
2018-09-09 00:52:22 +00:00
Nextcloud bot
f80517d719
[tx-robot] updated from transifex
2018-09-08 00:50:03 +00:00
Camila Ayres
13cfd80093
Adds correct qt5keychain lib file name for cmake instructions in README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-09-06 10:57:33 +02:00
Camila Ayres
17ac41377e
Fix README cmake instructions for the 3 platforms.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-09-06 10:39:31 +02:00
Nextcloud bot
0b8459ca14
[tx-robot] updated from transifex
2018-09-06 00:52:07 +00:00
Roeland Jago Douma
537fac70bf
Merge pull request #594 from hiiamok/windows-large-app-icon
...
Larger Windows App Icon
2018-09-05 22:54:42 +02:00
Oskar Kruschitz
cf150caa2b
Merge branch 'master' into windows-large-app-icon
2018-09-05 13:24:08 +02:00
Camila Ayres
23d276021e
Updates README cmake instruction for Windows.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-09-05 13:23:58 +02:00
Roeland Jago Douma
599f6f0228
Merge pull request #624 from nextcloud/fix/279/abstract_webflow_qnam
...
Add a WebFlowCredentialsAccessManager
2018-09-05 13:01:06 +02:00
Camila Ayres
bddc573c54
Merge branch 'master' into fix/279/abstract_webflow_qnam
2018-09-05 12:42:56 +02:00
Camila Ayres
1a73d3323a
Merge pull request #625 from hiiamok/mac-app-icon
...
Mac Application Icon
2018-09-05 12:41:09 +02:00
Oskar Kruschitz
2bfb99f174
Mac Application Icon
...
Replaced ownCloud.icns with APPLICATION_ICON_NAME variable
2018-09-05 11:57:26 +02:00
Oskar Kruschitz
f4a704164f
Merge branch 'master' into windows-large-app-icon
2018-09-05 11:37:24 +02:00
Nextcloud bot
e730f95a71
[tx-robot] updated from transifex
2018-09-05 00:48:38 +00:00
Roeland Jago Douma
9f1f99f4db
Add a WebFlowCredentialsAccessManager
...
Fixes #279
Some setups don't make Qt emit the right signals and the client would
end up in state where it could not do the initial authentications.
This is a similar hack that apparently already was is place for basic
http auth.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-09-04 20:59:25 +02:00
Oskar Kruschitz
d236c3c011
Merge branch 'master' into windows-large-app-icon
2018-09-04 08:35:11 +02:00
Nextcloud bot
73ccccb8a7
[tx-robot] updated from transifex
2018-09-04 00:47:25 +00:00
Oskar Kruschitz
7ab2a9bfcb
Merge branch 'master' into windows-large-app-icon
2018-09-03 12:51:26 +02:00
Camila Ayres
b19abe9c86
Merge pull request #614 from Titan-C/host_link
...
In setup wizard put link to nextcloud installation.
2018-09-02 13:18:00 +02:00
Camila Ayres
44026763b8
Merge branch 'master' into host_link
2018-09-02 12:55:44 +02:00
Camila Ayres
617cd6dfdb
Merge pull request #615 from Titan-C/webview_scale
...
Web view scales vertically.
2018-09-02 12:54:41 +02:00
Camila Ayres
3a489b73f9
Merge branch 'master' into webview_scale
2018-09-02 12:23:44 +02:00
Camila Ayres
07013783ea
Merge pull request #405 from nextcloud/sync-hidden-files
...
Sync hidden files by default.
2018-09-02 12:23:29 +02:00
Camila Ayres
7c77864396
Merge branch 'master' into sync-hidden-files
2018-09-02 12:01:07 +02:00
Nextcloud bot
3b8dde601d
[tx-robot] updated from transifex
2018-09-02 00:50:43 +00:00
Tobia De Koninck
d9f79215a7
Fix the hiddensync state in the UI + also sync hidden in cmd
2018-09-01 16:30:27 +02:00
Jan-Christoph Borchardt
309b0b6382
Sync hidden files by default
2018-09-01 16:30:27 +02:00
Nextcloud bot
9d021d004d
[tx-robot] updated from transifex
2018-09-01 00:48:21 +00:00
Óscar Nájera
452f64221e
Web view scales vertically
...
Fix #591
2018-08-31 19:49:13 +02:00
Óscar Nájera
72419a1149
Remove hostButton from setup page
2018-08-31 18:35:52 +02:00
Óscar Nájera
ab5c4749c1
In setup wizard put link to nextcloud installation
...
Fix #604
Remove the not actionable button but a direct link to the nextcloud
installation page. In this case the button is changed for a label with an
html link to the website.
2018-08-31 18:32:00 +02:00
Nextcloud bot
5cdf8a2997
[tx-robot] updated from transifex
2018-08-31 00:48:47 +00:00
Camila Ayres
bfd8897f22
Merge branch 'master' into windows-large-app-icon
2018-08-30 17:05:04 +02:00
Camila Ayres
8c19be7213
Merge pull request #599 from Titan-C/unpause_resume
...
Rename Unpause To Resume.
2018-08-30 17:03:58 +02:00
Camila Ayres
4a47d1c8ef
Merge branch 'master' into unpause_resume
2018-08-30 16:47:28 +02:00
Camila Ayres
e3d7c9f1ea
Merge branch 'master' into icon-name-fix
2018-08-30 16:45:52 +02:00
Camila Ayres
fbd8438072
Merge pull request #603 from Titan-C/login_button
...
Hide login button on setup screen.
2018-08-30 16:43:41 +02:00
Camila Ayres
efc2f0eded
Merge branch 'master' into login_button
2018-08-30 14:33:00 +02:00
Camila Ayres
3e839b2e44
Merge branch 'master' into unpause_resume
2018-08-30 13:31:34 +02:00
Camila Ayres
678e2c873e
Merge pull request #601 from Titan-C/activity_hover_notooltip
...
Drop the ToolTipRole from the activity list.
2018-08-30 13:26:47 +02:00
Óscar Nájera
121c0d8433
Hide login button on setup screen
...
Fix #576
2018-08-30 13:24:23 +02:00
Camila Ayres
881c7f804f
Merge branch 'master' into activity_hover_notooltip
2018-08-30 12:33:40 +02:00
István Váradi
2e55702258
Merge branch 'master' into icon-name-fix
2018-08-30 07:54:49 +02:00
Oskar Kruschitz
964470fc11
Merge branch 'master' into windows-large-app-icon
2018-08-30 07:42:34 +02:00
Nextcloud bot
c4d01b6aea
[tx-robot] updated from transifex
2018-08-30 00:46:36 +00:00
Óscar Nájera
0f80ecbb39
Drop the ToolTipRole from the activity list
...
Fix #515
2018-08-30 00:37:59 +02:00
Oskar Kruschitz
bf35821bc0
Merge branch 'master' into windows-large-app-icon
2018-08-29 20:39:17 +02:00
Óscar Nájera
d896edeee8
Rename Unpause to Resume
...
Fix #192
2018-08-29 17:03:07 +02:00
István Váradi
328f82297a
Create symlinks for the small-letter application icon file names
2018-08-29 16:36:56 +02:00
Camila Ayres
cafdcf77cb
Merge pull request #597 from Titan-C/readmes
...
Improves README documentation.
2018-08-29 16:08:01 +02:00
Óscar Nájera
ed705ba98c
Improving documentation
...
Fix #584
Fix #585
2018-08-29 15:47:44 +02:00
Christian Kamm
2844c925eb
Show a tray message when a folder watcher becomes unreliable #6119
2018-08-28 17:04:25 +02:00
Oskar Kruschitz
ea8676ad2c
Larger Windows App Icon
...
Newer Windows versions are also displaying a 256x256 icon. If this icon size is not present, the 48x48 icon is used, but not resized. This means there is a possibly large empty area around the icon.
2018-08-28 10:06:28 +02:00
Nextcloud bot
028da61824
[tx-robot] updated from transifex
2018-08-28 00:47:44 +00:00
Nextcloud bot
16337bf656
[tx-robot] updated from transifex
2018-08-27 00:48:31 +00:00
Camila Ayres
d8bf20310b
Adds link on how to create a pull request to the README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-25 17:49:34 +02:00
Nextcloud bot
cdd84dce6e
[tx-robot] updated from transifex
2018-08-25 00:47:18 +00:00
Camila Ayres
647df7bcee
Merge pull request #580 from nextcloud/issues/activities
...
Fixes #538 : correctly checks for local sync actitivities.
2018-08-24 14:54:42 +02:00
Camila San
64e21d5083
Fixes #538 : correctly checks for local sync actitivities.
...
- Local sync activities are now listed with the sync icon and included
in the correct list: once a file is synced, activityWidget checks for
its status to know if it is an error or if the file was successfully synced.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-24 09:24:32 +02:00
Nextcloud bot
ea0bdddb2a
[tx-robot] updated from transifex
2018-08-24 00:48:54 +00:00
Nextcloud bot
e9b4453814
[tx-robot] updated from transifex
2018-08-23 00:52:06 +00:00
Nextcloud bot
1991d71136
[tx-robot] updated from transifex
2018-08-22 00:48:25 +00:00
Camila Ayres
6a7a08bd01
Merge pull request #567 from nextcloud/issues/share-dialog
...
Fixes issues in the share dialog
2018-08-21 23:23:04 +02:00
Camila San
d5a0ec7d8b
Fixes #534 : interactions with expiration date and password.
...
- Fixes call for slot when date is set - it was the password
slot for that.
- Adds QProgressIndicator and function to toggle animation.
- Fixes: when date was set, the date was not being correctly set and
displayed.
- Fixes: hides and 'deletes' passsword and expire. date widgets when
the user unchecks it in the toolbox menu.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-21 22:48:51 +02:00
Camila San
eecbdb00de
Fixes #534 : can edit permission were always disabled.
...
- Properly checks files and folder share permissions when displaying
can edit checkbox - which can also be partially checked - and listing
permissios in the tollbutton menu.
- Fixes click on can edit checkbox - which can also change state of
permissions in the toolbutton menu.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-21 22:48:51 +02:00
Camila San
085de2825a
Enhancement #534 : hide tool button when there is no share link.
...
- Only display button when there is a share link.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-21 22:48:51 +02:00
Camila San
cf3ee4b3a4
Fixes share link delete action when clicking on tool button menu.
...
- Shared point was not handled properly.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-21 22:48:50 +02:00
Camila San
8f7bc8cff9
Changes 'Allow editing' for file sharing to a checkbox instead of a radiobutton.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-21 22:48:42 +02:00
Camila Ayres
ff9177edc3
Merge pull request #571 from nextcloud/issues/mac-build
...
Fixes mac build.
2018-08-21 22:47:41 +02:00
Camila San
c8d5d9a622
Removes dynamic cast when building navigation apps.
...
- It checks for the menu title to know where to add the apps menu instead of trying to cast
the menu pointer saved in the sender() property.
- The previous solution was not working reliably - see #523
- Adds TODO.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-21 14:57:12 +02:00
Camila San
fa4328a596
Changes repo for 3rdparty/qtmacgoodies.
...
- The fork has the functions needed to add separators in the toolbar.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-21 13:02:54 +02:00
Nextcloud bot
985c2ed1ca
[tx-robot] updated from transifex
2018-08-21 00:47:36 +00:00
Nextcloud bot
034d5b60aa
[tx-robot] updated from transifex
2018-08-20 00:48:31 +00:00
Nextcloud bot
a2f7355d4a
[tx-robot] updated from transifex
2018-08-19 00:47:24 +00:00
Nextcloud bot
17d4aeeb78
[tx-robot] updated from transifex
2018-08-18 00:47:40 +00:00
Nextcloud bot
a214ecf788
[tx-robot] updated from transifex
2018-08-17 00:47:10 +00:00
Camila Ayres
0d9de74726
Merge pull request #562 from ivaradi/qaction2
...
Further QAction constructor fixes
2018-08-15 17:32:43 +02:00
István Váradi
8b996772a4
Further QAction constructor fixes
2018-08-15 17:02:28 +02:00
Camila Ayres
fa5143a66d
Merge pull request #556 from ivaradi/qaction
...
Provide parent to QAction
2018-08-14 21:10:56 +02:00
István Váradi
8cbc757a56
Merge branch 'master' into qaction
2018-08-14 17:13:44 +02:00
Camila Ayres
e9ae10ba6c
Merge pull request #559 from nextcloud/issues/517
...
Fixes #517 : changes QPalette for more readability in the activities list.
2018-08-14 17:12:48 +02:00
István Váradi
5bcc4ece77
Merge branch 'master' into qaction
2018-08-14 17:11:00 +02:00
Camila San
135bcaea3e
Fixes #517 : changes QPalette for more readability in the activities list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-14 17:00:43 +02:00
Camila Ayres
29c11618b3
Merge pull request #558 from nextcloud/issues/518
...
Fixes #518 : adds more margin for the text in the activity
2018-08-14 16:59:54 +02:00
István Váradi
a15a470ea2
Merge branch 'master' into qaction
2018-08-14 16:53:14 +02:00
Camila San
1d4fc91d79
Fixes #518 : adds more margin for the text in the activity (only for Windows).
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-14 16:32:48 +02:00
Camila Ayres
ef9c302b5e
Merge pull request #550 from nextcloud/issues/533
...
Fixes #533 : Removes the copy activities/notifications button
2018-08-14 16:31:14 +02:00
Camila San
c1c5e5da5f
Fixes #533 : Removes the copy activities/notifications button
...
- Also removes the signal/slot associated with it.
- Minor changes: removes white background and changes frame style to the
same used in the accountsettings for consistency.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-14 13:53:14 +02:00
István Váradi
14615855d0
Provide parent to QAction
2018-08-14 11:54:08 +02:00
Roeland Jago Douma
f0ef2c27a3
Merge pull request #553 from ivaradi/libssl
...
LibSSL versions
2018-08-13 21:47:53 +02:00
Camila Ayres
b50db09b01
Merge pull request #554 from nextcloud/feature/noid/enable_providers_by_default
...
Enable providers by default
2018-08-13 20:24:27 +02:00
Roeland Jago Douma
86991b9996
Enable providers by default
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-08-13 19:59:34 +02:00
István Váradi
c27943b46d
Merge branch 'master' into libssl
2018-08-13 19:15:57 +02:00
Camila Ayres
ef71e6b0f7
Merge pull request #551 from nextcloud/issues/494
...
Issue #494 : removes close button from the settings.
2018-08-13 18:25:20 +02:00
Camila Ayres
8e8a619ee1
Merge branch 'master' into issues/494
2018-08-13 17:42:53 +02:00
Camila Ayres
27076c0f28
Merge pull request #552 from nextcloud/removes-notificationwidget
...
Removes unused NotificationWidget class.
2018-08-13 17:42:38 +02:00
István Váradi
fc6e6149e5
Require libssl 1.1 on distributions other than Xenial
2018-08-13 16:24:44 +02:00
István Váradi
13e2bb099b
Require libssl 1.0 on Xenial
2018-08-13 16:24:18 +02:00
Camila San
8fd0ca4587
Removes unused NotificationWidget class.
...
Since the new activities/notifications list UI this class is not used
anymore.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-13 15:17:40 +02:00
Camila San
2aa942e4b8
Issue #494 : removes close button from the settings.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-13 14:24:10 +02:00
Camila Ayres
92aaa09643
Merge pull request #541 from nextcloud/bugfix/noid/wizard-external-links
...
Make links open in an external browser
2018-08-13 12:03:31 +02:00
Roeland Jago Douma
0e2cd30ea1
Merge branch 'master' into bugfix/noid/wizard-external-links
2018-08-13 11:43:42 +02:00
Roeland Jago Douma
bc44c62471
Merge pull request #524 from ivaradi/ubuntu-compat
...
Some Ubuntu compilation fixes
2018-08-13 11:43:26 +02:00
Roeland Jago Douma
2434523f33
Merge pull request #532 from ShinjiLE/master
...
rearange CMake find_package OpenSSL
2018-08-13 11:42:35 +02:00
Camila Ayres
534a92b709
Merge branch 'master' into bugfix/noid/wizard-external-links
2018-08-13 11:40:45 +02:00
Roeland Jago Douma
233e10ecb1
Merge branch 'master' into master
2018-08-13 11:21:05 +02:00
Roeland Jago Douma
cefc6b531c
Merge pull request #549 from nextcloud/ci/noid/bump_imagesx
...
Bump ci images
2018-08-13 11:20:50 +02:00
Roeland Jago Douma
5c7c92157f
Bump images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-08-13 10:56:18 +02:00
Camila Ayres
176a2e6f84
Merge branch 'master' into ubuntu-compat
2018-08-13 09:03:26 +02:00
Camila Ayres
647d16c792
Merge branch 'master' into bugfix/noid/wizard-external-links
2018-08-13 09:02:21 +02:00
Camila Ayres
3ad33a368a
Merge branch 'master' into master
2018-08-13 08:58:26 +02:00
Nextcloud bot
951096f569
[tx-robot] updated from transifex
2018-08-13 00:49:31 +00:00
Nextcloud bot
489c0529c4
[tx-robot] updated from transifex
2018-08-12 00:48:32 +00:00
Julius Härtl
3576fbb2a5
Remove unused subclass of QWebEngineView
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-08-11 17:47:40 +02:00
Julius Härtl
8dedb9084e
Make links open in an external browser
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-08-11 17:38:08 +02:00
Nextcloud bot
f6ef11a5c9
[tx-robot] updated from transifex
2018-08-11 00:47:25 +00:00
Nextcloud bot
1d868eb809
[tx-robot] updated from transifex
2018-08-09 00:48:49 +00:00
Julius Härtl
c3aafa722a
Merge pull request #536 from nextcloud/3rdpart/remove_uneeded
...
Remove nlohmann/json.hpp
2018-08-08 21:34:48 +02:00
Roeland Jago Douma
b85bad0566
Remove nlohmann/json.hpp
...
Not used so no need to have it lying around
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-08-08 20:03:04 +02:00
Nextcloud bot
a4507db31a
[tx-robot] updated from transifex
2018-08-08 00:50:18 +00:00
Nextcloud bot
e551b89ba7
[tx-robot] updated from transifex
2018-08-07 00:46:53 +00:00
Ronny
7cbca28eb7
Merge branch 'master' into master
2018-08-05 11:35:53 +02:00
Nextcloud bot
a1967d551d
[tx-robot] updated from transifex
2018-08-05 00:49:39 +00:00
Ronny Kunze
2b825a1748
rearange CMake find_package OpenSSL
...
the command seems to be malformed . The keyword VERSION is not valid .
And the version should follow direct after the packagename.
2018-08-04 16:53:06 +02:00
Nextcloud bot
5110f9618a
[tx-robot] updated from transifex
2018-08-04 00:47:26 +00:00
István Váradi
d30f8b9094
Merge branch 'master' into ubuntu-compat
2018-08-03 17:16:20 +02:00
Camila Ayres
e0f49971f9
Merge pull request #525 from nextcloud/feature/132/about_dialog
...
Add legal notice button to about dialog
2018-08-02 22:32:56 +02:00
Roeland Jago Douma
c4d7f97e00
Add legal notice button to about dialog
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-08-02 22:17:11 +02:00
Roeland Jago Douma
30fc87daea
Merge pull request #344 from nextcloud/fix-share-dialog
...
Fix share dialog
2018-08-02 22:13:30 +02:00
Roeland Jago Douma
aa4ff0c083
Fix include order
...
Because why not :S
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-08-02 21:19:57 +02:00
István Váradi
758c2ad9ac
Merge branch 'master' into ubuntu-compat
2018-08-02 21:08:54 +02:00
Camila San
9d087b920b
Inserts ShareDialogStartPage in the correct position in the share dialog.
...
- With the new UI this had to be adapted.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 20:23:26 +02:00
Camila San
2cd32261a2
Checks if share link exists before settings password.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 20:22:37 +02:00
Camila San
8e0398426d
Replaces 'more' (3 dots) png icon for svg in buttons of the share
...
dialog.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 20:21:11 +02:00
Camila San
44865e0107
Adjustes sizes and margins in the share dialog and its widgets.
...
- Adds TODO's in commented out code.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:57:17 +02:00
Camila San
c2c2fe3ce3
Changes Share User/Group widget UI to match the server share UI.
...
- Display list of permissions in the tool button menu.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:57:17 +02:00
Camila San
25ff932a0b
Fixes edit permission on share link for files and folders.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:57:17 +02:00
Camila San
5b7970fed7
Updates client.qrc with new icon 'copy' for share link menu options.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:57:17 +02:00
Camila San
b14aa11c29
Changes share link layout so it looks like the UI on the server.
...
- Adds icons to Share link and to save password on share dialog.
- Changes wording of the menu options for sharing link.
- Adds functionality to the new menu (mostly permissions).
- More widget size and size policy adjustments.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:57:16 +02:00
Camila San
a19904657a
Switches order of widgets in share dialog: share link comes first.
...
- First text input to search for users,then share link and then the list
of users.
- Adjusts size and scroll bar for sharees list.
- Adds option 'can share' to 3 dots menu in share user/group widget.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:52:28 +02:00
Camila San
7aff1e27c0
Fixes share users/groups widget.
...
- Existing sharees where not being displayed.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:52:28 +02:00
Camila San
55b0b46bb6
Changes size, size policy, content and margins of the share dialog and its widgets.
...
- Adds select with permissions to share dialog on the user/group search.
- Changes order of widgets, removes excess of text and do not display empty widgets.
- Share user/group widget: replaces combo box for tool button with permissions.
- Using Fixed as size policy it gives a much smoother user experience
when windows size dinamically changes.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:52:27 +02:00
Camila San
4ecfab4bf3
Improves share dialog.
...
- Removes the tabs: adds items to a vertical layout.
- Fix spacing and alignment.
- Removes extra text.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-02 19:48:42 +02:00
Nextcloud bot
34acc095c7
[tx-robot] updated from transifex
2018-08-02 00:48:46 +00:00
István Váradi
c919b7e069
Merge branch 'master' into ubuntu-compat
2018-08-01 16:28:48 +02:00
Camila Ayres
00e2d4ef93
Merge pull request #523 from nextcloud/fix-navigation-apps
...
Fixes crash on mac OS and linux.
2018-08-01 15:45:06 +02:00
Camila Ayres
2fd6f3583b
Merge branch 'master' into fix-navigation-apps
2018-08-01 15:20:33 +02:00
Nextcloud bot
49be437bfa
[tx-robot] updated from transifex
2018-08-01 00:46:14 +00:00
Camila San
0ac532f5c9
Fixes crash on mac OS and linux.
...
- The crash was happening when the user could not connect and it would
crash on trying to retrieve and display the navigation apps.
- Checks AccountStatePtr earlier in the function
slotNavigationAppsFetched.
- Cast of pointer stored in QVariant to QMenu was not done correctly -
qvariant_cast works best for user type defined or QMetaType known to
QVariant.
Signed-off-by: Camila San <hello@camila.codes >
2018-08-01 00:28:25 +02:00
István Váradi
be3640dc51
Depend on libqt5svg5-dev
2018-07-31 16:24:16 +02:00
István Váradi
343402740f
Make the Bionic control file the default one
2018-07-31 16:22:02 +02:00
István Váradi
1364755141
Use libkf5kio-dev directly on Bionic and Cosmic
2018-07-31 16:21:03 +02:00
Roeland Jago Douma
5be1bcd8b0
Merge pull request #439 from nextcloud/feature/noid/register
...
Providers integration
2018-07-31 14:21:51 +02:00
Julius Härtl
bc96ec8ae1
Fix styling
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-07-31 13:35:37 +02:00
Julius Härtl
3159a36f25
Make build optional
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-07-31 13:35:36 +02:00
Julius Härtl
156605c2fa
Use proper URL
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-07-31 13:35:36 +02:00
Julius Härtl
18f1452b04
Add slideshow images
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-07-31 13:35:36 +02:00
Julius Härtl
295750555d
Allow to use provider registration with flow auth
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-07-31 13:35:35 +02:00
Nextcloud bot
60bc5c378c
[tx-robot] updated from transifex
2018-07-31 00:48:58 +00:00
Roeland Jago Douma
fa5026bba7
Merge pull request #491 from nextcloud/fix-activities-v2
...
Fix activities v2
2018-07-30 22:39:08 +02:00
Camila San
32bb1ca449
Aligns copy button to the left in the activity widget.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:11:04 +02:00
Camila San
a149660ae9
Enables again alternate row color in the activity list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:11:04 +02:00
Camila San
524a3d4c6a
Returns default icon when no status matches any of the check for SyncFileItem::Status.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:11:04 +02:00
Camila San
90a2d5a3e7
Aligns text correcty when not all text has content in the activity list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:11:04 +02:00
Camila San
156b4cf284
Aligns time vertically on the bottom of the notification action text when there is no message.
...
- Minor fix: gives less space for long text that needed ellipses which
was not showing and set right margin because otherwise text was not
painted correctly and completly.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:11:04 +02:00
Camila San
ee612bda3a
Fixes crash when folder it is not set in the activity list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:11:03 +02:00
Camila San
a1cab471e8
Comments out slotProgressInfo.
...
- Added TODO.
- It seems to be working only in some cases.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:02 +02:00
Camila San
f294cf1b93
Changes icons for errors and warnings in the activity list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:02 +02:00
Camila San
31892f5337
Changes background color to white for the Activity list widget.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:02 +02:00
Camila San
e9dbee0df5
Removes alternate color on the rows of Activity Widget.
...
- Also fixes the click on each activity: the user had to click twice -
one to select the row and then one click to open file manager or
browser.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:02 +02:00
Camila San
9cbf5aa783
Changes icons for actions in Activity List.
...
- For folder (open file manager) and close (dismiss
notification).
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:02 +02:00
Camila San
36a73432bc
Implements ActivityWidget::slotProgressInfo.
...
- Attempts to implement slot as it was in the old IssuesWidget.
- It should clean up the activity list when needed - e.g. when file
conflict was solved.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
b2834e047d
Refactores ActivityListModel::removeFromActivityList.
...
- Fixes crash when dismissing notification - notification was being
removed from the wrong list.
- Minor changes: removes AccountStatePtr where it was needed anymore now
that ActivityListModel has an _accountState, it doesn't need to be
checked for each activity/notification.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
f63434b856
Stores folder in ActivityData.
...
- The information is needed on ActivityWidget::slotProgressInfo.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
7bc9275a8c
Separates types of errors: SyncErrorType and SyncFileItemType.
...
- This follows what the enums already being used SynResult::Status and
SyncFileItem::Status.
- Do not display buttons for FileErrorTypes - since they are errors on
local syncing, there is nothing to do in the server.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
7b1569df81
Removes static const from activity widget.
...
- It didn't need to be static.
- It crashed on Windows (Visual Studio 15 2017 Win64).
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
f85825dee4
Adds header and forward declaration of 'QMouseEvent' to ActivityItemDelegate.
...
To fix compiling for Qt5.7 (drone error).
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
3673603e5a
Fixes buttons clickable area in the activities list.
...
- Their size was not correctly calculated so it was hard to filter the
clicks on the list. User had to click multiple times before clicking on
the right acceptable area.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
9f9be7814c
Adjust space between action/buttons in the toolbar.
...
- Minor: cleans up code used for debug.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
938c99ec42
Fixes and improves 'copy to clipboard' output.
...
- With the merging of activities and notifications the copy to clipboard
function got broken. Had to put it back as it was before.
- The output text from the clipboard was almost unreadeable. Ajusted the
space between texts and used separator '-' instead of ','.
- Minor: cleans up comments.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
4a6b7854f5
Adds 'Join' string for call notifications.
...
- Stores object_type from the api response to check if notification is a
call so the primary button text and action is 'Join'.
- Puts strings into consts.
- Minor change: Improves comments on ActivityListModel.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
00effb0e2f
Adds 'accept' button for remote share notifications.
...
- Stores object_type form the api response to check if notification is
remote_share, so the primary button text is 'accept' instead of 'more
information'.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
f0ca5dbded
Fix settings dialog for mac.
...
- Fixes adding/removing accounts with separator in the toolbar -
accounts were not added in the right order and removing was not
including the separator.
- Fixes button sizes in the activities list - the buttons were too small
for the text.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
11484d5588
Removes Protocol and Issues widget files and references.
...
- Minor changes:
- Improves comments and qCWarning messages
- Removes commented out code.
- adds TODO's.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
ab3c6da5d7
Gives full path to file to open in file manager.
...
- The path to the file wa being stored in the wrong activity property.
It was in the action link when it should be in the file.
- Minor: comments out the display of issues and protocol widget.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
f402b1d9e4
Changes icons for opening in file manager and to dismiss notification.
...
- The icons used before were not really clear on what their function
was.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:01 +02:00
Camila San
ec51428e4d
Fixes the url for the button 'more information'.
...
- The url for the browser was not full path to the file.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
64d635a046
Fixes the color of the font.
...
- It was too light when the row was selected.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
9de3985021
Small fixes.
...
- Align progress indicator to the center.
- Moves unused code.
- Removes unused labels.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
a9cd3b3a6d
Merges errors and protocols into notifications/activities.
...
- Errors will always be on top, then Notifications comes next and then Activities for last.
- Adds 2 new types of Activity: NotificationType and ErrorType.
- ActivityListModel and ActivityWidget stores AccountState to connect user and widget.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
d0c72dd642
Makes space smaller bewteen user/activities and network/settings menu.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
9ad2a980ce
Moves the separator to between accounts.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
7e8b5f34d7
Fixes the text length for activities.
...
- Activities from the server don't have buttons to interact with so
their content can use the full lenght of the row.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
918ccb1ed3
Removes row when notification is dismissed.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
e3c7a5a2ff
Changes Activity list view icons, buttons and drawing.
...
- Displays the notification icon when available.
- Adds dismiss button with an icon.
- Handles buttons actions in the list view.
- Changes what is painted first (activityitemdelegate) for each row in
the activity list.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
00a73b5ded
Adds class to retrieve icons.
...
- This is an attempt to cache the icons.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
49377976db
Removes notification row from the view when clicking on Dismiss.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
ef4a30fcb9
Displays a menu once the user clicks on the button in the notifications.
...
- In activityitemdelegate the mouse events are filtered (ActivityItemDelegate::editorEvent) to check if the user clicked
on a button in the list of activities/notifications. Then a signal is emitted to ActivityWidget that does the rest:
show submenu when there are more options, open browser, open file manager, send request to server.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
9ad01f0819
Fixes order of the notifications: latest on top.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
7fa5e41e8d
Only displays buttons if it is a notification and adjust space left.
...
- Do not display buttons for activities.
- Adds correctly text and button in the space left depending on the widget size.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:06:00 +02:00
Camila San
4e4a0da3b7
Returns the activity type to the list view.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
2350b41dc3
List model returns the list of actions for each activity.
...
- The list of possible actions (server requests( was not being used in
the activityitemdelegate. This is needed to be able to draw the primary
action buttons and other options for each notification in the view.)
- Minor changes:
- Uses different icons for activities and notifications in the list view.
- Align elements in the list view of notifications/activities properly.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
d1f4f8a558
Correctly removes actions - account, separator and settings widget from toolbar when account is removed.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
a6331c7a75
Fixes widget stack visibility when switching actions.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
22a6303c9d
Adds space bewteen different accounts and activity.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
1b1468a9c6
Each user has its own list of activities.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
b13f77c0fb
Adds one activity widget for each user.
...
- ActivityListModel and ActivityWidget stores an AccountState to connect user and widget.
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
8e0c036fc3
Aligns Network and General to the right.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
75c2613b1b
Displays activity and notification messages in the list view.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:59 +02:00
Camila San
908870ccde
Adds notifications to the Activities list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-30 22:05:57 +02:00
Roeland Jago Douma
30a4f1edd7
Merge pull request #510 from ivaradi/beta-ppa
...
Use the beta PPA for builds (re #402 )
2018-07-30 20:34:05 +02:00
Roeland Jago Douma
9722fbc151
Merge pull request #507 from doits/allow_macos_gpu_switching
...
allow to switch to the integrated gpu on MacOS
2018-07-30 20:33:41 +02:00
Roeland Jago Douma
7fccae7875
Merge pull request #509 from ivaradi/artful-cosmic
...
Stop building for Artful, enable Cosmic
2018-07-30 20:32:56 +02:00
Nextcloud bot
d49aadaf76
[tx-robot] updated from transifex
2018-07-30 00:50:31 +00:00
Nextcloud bot
adb6606e6f
[tx-robot] updated from transifex
2018-07-29 00:48:28 +00:00
Nextcloud bot
e0a1b00d3e
[tx-robot] updated from transifex
2018-07-28 00:47:08 +00:00
István Váradi
c2ceb173b1
Merge branch 'master' into beta-ppa
2018-07-27 21:00:01 +02:00
István Váradi
5f74baabeb
Merge branch 'master' into artful-cosmic
2018-07-27 20:59:44 +02:00
Nextcloud bot
c38fa06754
[tx-robot] updated from transifex
2018-07-27 00:48:48 +00:00
István Váradi
d63bcb4d4b
Use the beta PPA for builds (re #402 )
2018-07-26 20:19:18 +02:00
István Váradi
dd9e12fe43
Start building for cosmic
2018-07-26 20:08:48 +02:00
István Váradi
8e92f87694
Stop building for artful
2018-07-26 20:07:36 +02:00
Markus Doits
2335688b68
allow to switch to the integrated gpu on MacOS
...
without that key, the client automatically runs on the dedicated gpu (if
present). now it allows the system to use the integrated one.
closes #501
2018-07-25 09:35:53 +02:00
Nextcloud bot
69b6f5a019
[tx-robot] updated from transifex
2018-07-25 00:46:45 +00:00
Roeland Jago Douma
1af353cb2f
Merge pull request #503 from ivaradi/libgnome-keyring0
...
Add a dependency on libgnome-keyring0 on Bionic
2018-07-24 13:26:05 +02:00
István Váradi
d228aa8644
Merge branch 'master' into libgnome-keyring0
2018-07-23 14:50:37 +02:00
Nextcloud bot
7f829a88bf
[tx-robot] updated from transifex
2018-07-23 00:46:53 +00:00
István Váradi
df9cc8396a
Add a dependency on libgnome-keyring0 on Bionic
2018-07-22 20:33:45 +02:00
Nextcloud bot
df4fb880c2
[tx-robot] updated from transifex
2018-07-22 00:52:57 +00:00
Nextcloud bot
e45a37df73
[tx-robot] updated from transifex
2018-07-20 00:46:28 +00:00
Nextcloud bot
b0ec091e04
[tx-robot] updated from transifex
2018-07-19 00:45:48 +00:00
Nextcloud bot
0c44b32843
[tx-robot] updated from transifex
2018-07-18 00:45:39 +00:00
Camila Ayres
720960f0be
Merge pull request #497 from nextcloud/readme-updates
...
Updates the README with build instructions.
2018-07-16 12:35:23 +02:00
Camila Ayres
2511105cce
Adds link to wiki page 'System requirements' to README.
2018-07-16 11:31:34 +02:00
Camila Ayres
7e63fd535e
Updates the README with build instructions.
...
- Adds a shorter version of how to build the client but the extended version will be kept on the Wiki.
- Makes the instructions available if you clone the repo and work offline.
2018-07-16 11:09:05 +02:00
Nextcloud bot
0898ada696
[tx-robot] updated from transifex
2018-07-16 00:45:09 +00:00
Nextcloud bot
dce17b4bd3
[tx-robot] updated from transifex
2018-07-15 00:45:32 +00:00
Nextcloud bot
edf28d9191
[tx-robot] updated from transifex
2018-07-13 00:48:03 +00:00
Camila Ayres
d70e2d5c02
Merge pull request #490 from nextcloud/nickvergessen-patch-1
...
Link IRC to webchat so people without a client can do something.
2018-07-11 09:37:53 +02:00
Joas Schilling
dd154c7505
Link IRC to webchat so people without a client can do something
...
Also note that github doesn't render irc:// links, so it just showed the name
2018-07-11 09:04:03 +02:00
Nextcloud bot
716f88e222
[tx-robot] updated from transifex
2018-07-11 00:47:26 +00:00
Nextcloud bot
62708dea13
[tx-robot] updated from transifex
2018-07-10 09:12:30 +00:00
Nextcloud bot
4f164d1e23
[tx-robot] updated from transifex
2018-07-07 00:40:31 +00:00
Nextcloud bot
e6d46cba17
[tx-robot] updated from transifex
2018-07-06 00:41:45 +00:00
Roeland Jago Douma
e69d56a0cd
Merge pull request #395 from nextcloud/upstream/pr/6388
...
OwnSql: Some refactoring
2018-07-04 13:34:44 +02:00
Camila Ayres
f1c4b76669
Merge branch 'master' into upstream/pr/6388
2018-07-04 10:12:42 +02:00
Nextcloud bot
41ca5388e9
[tx-robot] updated from transifex
2018-07-04 00:41:40 +00:00
Roeland Jago Douma
24efdd3b45
Fix E2E query
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-03 11:40:58 +02:00
Roeland Jago Douma
6c11c1aa73
Fix query
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-03 10:33:26 +02:00
Olivier Goffart
d114212333
OwnSql: Fixup after feedback for #6388
2018-07-03 10:33:26 +02:00
Olivier Goffart
779969f865
OwnSql: Put the SQL queries next to their use.
...
This avoid haivng to modify 4 places when we want to add a query
2018-07-03 10:33:26 +02:00
Olivier Goffart
518fb90757
OwnSql: Some refactoring
...
Use QByteArray for the query so we don't have to convert twice.
Automatically finish the query when the DB close, so we don't
have to call reset
2018-07-03 10:33:26 +02:00
Roeland Jago Douma
b309a1c8c4
Merge pull request #401 from nextcloud/upstream/pr/6456
...
Issues: Show link to conflicts doc if there are some #6396
2018-07-03 10:32:09 +02:00
Christian Kamm
4fa6fff1a9
Doc: Explaining conflict files and resolving them #6396
2018-07-03 10:18:20 +02:00
Christian Kamm
d549c77af6
Issues: Show link to conflicts doc if there are some #6396
...
The link url is themed.
2018-07-03 10:18:18 +02:00
Roeland Jago Douma
b527013ad8
Merge pull request #402 from ivaradi/master
...
Use the VERSION.cmake file to determine Ubuntu/Debian main package version
2018-07-03 10:17:42 +02:00
István Váradi
e6cc593516
Revert "Do not require exact version for WebEngine dependencies"
...
This reverts commit dcceec25c89e935b59c921ae22c66199f8642531.
2018-07-03 09:11:31 +02:00
István Váradi
dec5473eec
The version is also read from the VERSION.cmake file
2018-07-03 09:11:31 +02:00
István Váradi
ced4cad329
Do not require exact version for WebEngine dependencies
2018-07-03 09:11:31 +02:00
Camila Ayres
b18c62dc41
Merge pull request #472 from nextcloud/feature/noid/loginflow_accept_language
...
Set Accept-language header for webview requests
2018-07-03 08:52:11 +02:00
Roeland Jago Douma
0d70b05b65
Set Accept-language header for webview requests
...
This way the server will properly translate it for you if it has
translations.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-03 07:45:02 +02:00
Nextcloud bot
44205359a5
[tx-robot] updated from transifex
2018-07-03 00:44:23 +00:00
Camila Ayres
2361076b75
Merge pull request #471 from nextcloud/fix/458/do_not_show_webview_by_default
...
Do not force to show the webview on construct
2018-07-02 22:22:40 +02:00
Camila Ayres
9627aad04c
Merge branch 'master' into fix/458/do_not_show_webview_by_default
2018-07-02 22:01:03 +02:00
Roeland Jago Douma
cbf417664d
Merge pull request #404 from nextcloud/upstream/pr/6491
...
Proxy settings: Fix bad behavior with empty host
2018-07-02 21:25:53 +02:00
Christian Kamm
70b5d54082
Proxy settings: Fix bad behavior with empty host
...
Fixes f6a075ef54 for #5885
When no host is given it shouldn't just *appear* that there is no
proxy, there actually shouldn't be a proxy set then.
2018-07-02 21:15:30 +02:00
Roeland Jago Douma
34d964fc80
Do not force to show the webview on construct
...
Should fix #458
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-02 20:09:30 +02:00
Roeland Jago Douma
93c6576bcb
Merge pull request #470 from nextcloud/update-readme
...
Adds item about Code of Conduct in the README.
2018-07-02 19:48:07 +02:00
Camila San
4adade9818
More polishing the emojis markdown in the README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 18:50:40 +02:00
Camila San
cb6506e3f1
More polishing the emojis markdown in the README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 18:25:10 +02:00
Camila San
165b164e95
Fixes CoC links in the README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 18:21:35 +02:00
Camila San
c437ffc95f
Adds 'Code of Conduct' item to the README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 18:17:32 +02:00
Roeland Jago Douma
9bb58550ff
Merge pull request #469 from nextcloud/update-readme
...
Updates the README
2018-07-02 18:11:32 +02:00
Camila San
3bf8002708
README: changes emoji markup positions.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 18:06:59 +02:00
Camila San
74dedf636c
README: trying some emoji markup.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 17:47:12 +02:00
Camila San
19f1513af0
Fixes link, put items in a list in the README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 17:29:05 +02:00
Camila San
ee668eb6cd
Changes the order of the content in the README.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 17:24:57 +02:00
Camila San
65cb94c316
Updates the README with info about the daily builds and how to compile the client.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-07-02 17:06:48 +02:00
Camila Ayres
178edb97bc
Merge pull request #466 from nextcloud/fix_compile_warnings
...
Fix compile warnings
2018-07-02 13:50:04 +02:00
Roeland Jago Douma
08abc71acb
gui Q_UNUSED
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-02 13:02:15 +02:00
Roeland Jago Douma
ce545b1e47
propage*encrypted Q_UNUSED
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-02 12:45:44 +02:00
Roeland Jago Douma
e871359453
Remove unneeded ;
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-02 11:03:58 +02:00
Roeland Jago Douma
b952fa64ee
Restore logger installation
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-07-02 11:01:52 +02:00
Nextcloud bot
027565e571
[tx-robot] updated from transifex
2018-07-02 00:42:35 +00:00
Nextcloud bot
09e2a4af60
[tx-robot] updated from transifex
2018-07-01 00:44:43 +00:00
Julius Härtl
bc7ef87d18
Merge pull request #460 from nextcloud/no_trademark_text
...
Remove default trademark text
2018-06-29 22:56:28 +02:00
Roeland Jago Douma
d2b75cabb2
Remove default trademark text
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-29 21:36:18 +02:00
Nextcloud bot
85cee68f1d
[tx-robot] updated from transifex
2018-06-29 00:46:29 +00:00
Roeland Jago Douma
70d7676794
Merge pull request #440 from nextcloud/fix/runtestsci
...
Run unit tests on drone
2018-06-28 21:55:15 +02:00
Roeland Jago Douma
97ea6c54bc
Run tests on drone
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-28 14:50:35 +02:00
Camila Ayres
ff23e99a9a
Merge pull request #389 from nextcloud/upstream/pr/6426
...
Theme: unify ownCloudTheme and Theme classes
2018-06-28 14:39:17 +02:00
Roeland Jago Douma
38b89a3fa0
Update testutility
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-28 13:37:02 +02:00
Roeland Jago Douma
6ab7e814a5
Fix tests to actually compile
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-28 13:37:02 +02:00
Roeland Jago Douma
595cbfaa16
Update urls
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-28 12:46:47 +02:00
Camila San
4c7b7dfcaa
Restores previous text in the about section.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-06-28 12:33:40 +02:00
Olivier Goffart
c5ace2338c
Theme: unify ownCloudTheme and Theme classes
...
The goal is to avoid confusion described in issue #6422 by removing
duplicates between the Theme and owncloudTheme.
- Use the about from ownCloudTheme everywhere
- Create default applicationIcons() and condifFileName() that should work
everywhere
- trayFolderIcon was removed as it is not used
- the helpUrl from the default Theme now points to the owncloud client
documentation. Before there was no help entry by default for branded
client if the function was not overriden.
- Do not merge functions that would otherwise break compatibility with
theme that did not override them. For example colors or customMedia.
2018-06-28 12:33:39 +02:00
Roeland Jago Douma
0c21e4945d
Merge pull request #455 from nextcloud/fix/appimage/openssl
...
Fix/appimage/openssl
2018-06-27 23:26:44 +02:00
Roeland Jago Douma
cd0b638a80
Add openssl 1.0 to appimage as Qt needs it
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-27 23:14:10 +02:00
Roeland Jago Douma
8d70eab8fe
Checkout depth of 1 for drone for faster cloning
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-27 23:13:56 +02:00
Roeland Jago Douma
5ce9aedb7a
Merge pull request #452 from nextcloud/organize-windows-translation
...
Windows: moves translation files to /i18n.
2018-06-27 13:14:19 +02:00
Camila Ayres
acc65cdc4a
Merge branch 'master' into organize-windows-translation
2018-06-27 12:29:56 +02:00
Nextcloud bot
c36dafa317
[tx-robot] updated from transifex
2018-06-27 00:46:34 +00:00
Camila San
e69a9c61d0
Windows: moves translation files to /i18n.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-06-26 23:56:34 +02:00
Roeland Jago Douma
aa04f20ad6
Merge pull request #449 from nextcloud/ci/appimage
...
Build AppImage with Qt-5.11
2018-06-26 21:18:30 +02:00
Roeland Jago Douma
7ce9c22d2c
Build AppImage with Qt-5.11
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-26 17:49:00 +02:00
Roeland Jago Douma
106756624a
Merge pull request #448 from nextcloud/ci/clang
...
Add clang build to CI
2018-06-26 17:44:23 +02:00
Camila Ayres
e3815608ab
Merge branch 'master' into ci/clang
2018-06-26 17:26:54 +02:00
Camila Ayres
959318adf0
Merge pull request #450 from nextcloud/deps/openssl
...
We require openssl 1.1
2018-06-26 17:26:16 +02:00
Roeland Jago Douma
c1bebd1253
We require openssl 1.1
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-26 16:37:44 +02:00
Roeland Jago Douma
64255f8f09
Add clang build to CI
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-26 15:41:23 +02:00
Julius Härtl
84b7ed04e6
Merge pull request #446 from nextcloud/ci/qt510-qt511
...
Add Qt-5.10 and Qt-5.11 drone builds
2018-06-26 15:08:51 +02:00
Roeland Jago Douma
0a9185b88c
Add Qt-5.10 and Qt-5.11 drone builds
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-26 13:08:34 +02:00
Nextcloud bot
5d96a0e6b6
[tx-robot] updated from transifex
2018-06-25 00:46:38 +00:00
Nextcloud bot
e290b1c353
[tx-robot] updated from transifex
2018-06-24 00:46:16 +00:00
Roeland Jago Douma
1235652cde
Merge pull request #442 from nextcloud/fix/noid/appimage_webview
...
Fix webview appimage
2018-06-23 21:36:47 +02:00
Roeland Jago Douma
2c5e559df6
Bundle NSS because else 💥
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-23 21:29:16 +02:00
Roeland Jago Douma
e79591e52c
Bump drone images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-23 21:29:16 +02:00
Roeland Jago Douma
9eb950bdcf
Merge pull request #438 from nextcloud/bugfix/413/hide-decrypt-option
...
Hide decrypt option since it does only work for empty folders
2018-06-23 21:20:46 +02:00
Julius Härtl
92480ec8fb
Hide decrypt option since it does only work for empty folders
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-22 12:13:04 +02:00
Roeland Jago Douma
aff749da12
Merge pull request #437 from nextcloud/feature/150/e2e-indicator
...
Add indicator to e2e folders
2018-06-22 11:32:22 +02:00
Julius Härtl
e42f5648bd
Add indicator to e2e folders
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-22 11:21:30 +02:00
Camila Ayres
73969e2515
Merge pull request #436 from nextcloud/feature/noid/e2e-mnemonic-dialog
...
Use custom mnemonic dialog.
2018-06-22 11:09:54 +02:00
Julius Härtl
655a43db10
Use custom mnemonic dialog
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-22 10:42:01 +02:00
Roeland Jago Douma
cf93b74028
Merge pull request #432 from nextcloud/feature/157/show_mnemonic
...
Add a button to E2E accounts to show the mnemonic
2018-06-22 10:15:07 +02:00
Roeland Jago Douma
48a6ef37b2
Add a button to E2E accounts to show the mnemonic
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-21 19:52:27 +02:00
Roeland Jago Douma
a742cbcdce
Merge pull request #409 from nextcloud/upstream/pr/6556
...
Fix make doc-man in shadow build
2018-06-21 19:50:48 +02:00
Roeland Jago Douma
652dd8c812
Merge pull request #410 from nextcloud/upstream/windows-shell-integration
...
Windows Shell extention: Fix clicking on the menu entries
2018-06-21 19:42:04 +02:00
Olivier Goffart
0d0bff4bf5
Windows Shell extention: Fix clicking on the menu entries
...
Issue #6553
2018-06-21 19:21:07 +02:00
Camila Ayres
4d60dd6516
Merge pull request #431 from nextcloud/fix/webkit-osx
...
More fixes for the OSX daily builds.
2018-06-21 15:37:56 +02:00
Roeland Jago Douma
30b211381f
More fixes for the OSX daily builds
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-21 15:22:53 +02:00
Nextcloud bot
9bfdb057cd
[tx-robot] updated from transifex
2018-06-21 00:50:29 +00:00
Jan-Christoph Borchardt
ae6483862e
Merge pull request #416 from nextcloud/bugfix/16/sync-state-icons
...
Add new sync state icons
2018-06-20 17:36:38 +02:00
Julius Härtl
b4306884c8
Update theme file
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-20 16:27:17 +02:00
Julius Härtl
539823e64a
Add new icons
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-20 16:06:20 +02:00
Julius Härtl
0e1302cca5
Remove icons from qrc file
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-20 16:06:20 +02:00
Julius Härtl
4ba40a6ce1
Move information icon to warning icon
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-20 16:06:19 +02:00
Julius Härtl
38b4febde6
Remove unused icons
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-20 16:06:19 +02:00
Roeland Jago Douma
81d8a1ec6b
Merge pull request #419 from nextcloud/fix/osx/no_thead_local
...
Thread local storage don't work properly on OSX
2018-06-20 15:15:15 +02:00
Roeland Jago Douma
9fe77ed7bf
Merge pull request #430 from nextcloud/update_mac_deploy-at
...
Fix macdeployqt
2018-06-20 15:14:43 +02:00
Roeland Jago Douma
cbf3725814
Fix macdeployqt
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-20 13:05:41 +02:00
Nextcloud bot
bb480061e5
[tx-robot] updated from transifex
2018-06-20 00:48:25 +00:00
Nextcloud bot
a0ad05fb90
[tx-robot] updated from transifex
2018-06-19 00:48:37 +00:00
Nextcloud bot
10f08159bd
[tx-robot] updated from transifex
2018-06-17 00:52:06 +00:00
Nextcloud bot
57657ae119
[tx-robot] updated from transifex
2018-06-16 00:52:48 +00:00
Camila Ayres
4aeec032fe
Merge branch 'master' into fix/osx/no_thead_local
2018-06-15 10:29:24 +02:00
Nextcloud bot
990af6be2f
[tx-robot] updated from transifex
2018-06-15 00:49:45 +00:00
Roeland Jago Douma
f7bf8c7577
Thread local storage don't work properly on OSX
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-14 21:26:07 +02:00
Roeland Jago Douma
f71c74e5aa
Merge pull request #418 from nextcloud/fix/nextcloud_sparkle_key
...
Add our own dsa_pub.pem
2018-06-14 21:06:17 +02:00
Roeland Jago Douma
8b96ef53b9
Add our own dsa_pub.pem
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-14 20:59:27 +02:00
Roeland Jago Douma
2ce79717b2
Merge pull request #412 from nextcloud/upstream/nsis
...
NSIS: SVG imageformats plugin DLL
2018-06-13 19:52:40 +02:00
Markus Goetz
c04ae70cf5
NSIS: SVG imageformats plugin DLL #6515
2018-06-13 14:57:31 +02:00
Markus Goetz
ae36f36d56
NSIS: SVG DLL #6515
2018-06-13 14:57:30 +02:00
Nextcloud bot
4ad2955a75
[tx-robot] updated from transifex
2018-06-12 00:55:30 +00:00
Roeland Jago Douma
26bf407d62
Merge pull request #400 from nextcloud/upstream/pr/6481
...
SocketAPI: Allow opening share dialog if contents still syncing #4608
2018-06-11 19:43:01 +02:00
Christian Kamm
ca8f569371
SocketAPI: Remove SHARE_STATUS
...
It was never used by a shell integration.
2018-06-11 19:35:17 +02:00
Christian Kamm
2bec587d4d
SocketAPI: Allow opening share dialog if contents still syncing #4608
...
With the previous changes the "Share..." action was shown but it didn't
work yet.
2018-06-11 19:35:16 +02:00
Roeland Jago Douma
f31d4ba341
Merge pull request #392 from nextcloud/upstream/pr/6413
...
Rename local discovery option for clarity
2018-06-11 15:25:03 +02:00
Christian Kamm
16ba0cf47e
Blacklist: Add unittest #6411
2018-06-11 14:50:01 +02:00
Christian Kamm
d304fcbda7
Rename local discovery option for clarity
...
It's using full relative filepaths, not just dir paths.
2018-06-11 14:50:01 +02:00
Roeland Jago Douma
2cc94636cf
Merge pull request #391 from nextcloud/upstream/pr/6417
...
Conflicts: Change tags to be more user friendly #6365
2018-06-11 14:48:47 +02:00
Christian Kamm
77fcff5bdf
Conflicts: Change tags to be more user friendly #6365
...
From "_conflict-user-yyyymmdd-hhmmss"
to " (conflicted copy user yyyy-mm-dd hhmmss)"
2018-06-11 14:40:40 +02:00
Nextcloud bot
a9d633c7ef
[tx-robot] updated from transifex
2018-06-11 00:48:08 +00:00
Olivier Goffart
1b6cc36a61
Fix make doc-man in shadow build
...
Issue #6555
2018-06-10 16:07:22 +02:00
Nextcloud bot
e82fdee90c
[tx-robot] updated from transifex
2018-06-10 00:49:25 +00:00
Nextcloud bot
0e00f9d0d3
[tx-robot] updated from transifex
2018-06-09 00:48:57 +00:00
Roeland Jago Douma
dc41f8a16e
Fix windows build
...
* Reorder openssl header import
* not => !
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-08 16:53:56 +02:00
Roeland Jago Douma
7e98a1e802
Merge pull request #390 from nextcloud/upstream/pr/6377
...
Notify if an explicitly excluded folder is created #6222
2018-06-08 14:58:45 +02:00
Christian Kamm
e65caee9cf
Notify if an explicitly excluded folder is created #6222
2018-06-08 14:49:26 +02:00
Nextcloud bot
1ba96d779b
[tx-robot] updated from transifex
2018-06-08 00:49:17 +00:00
Roeland Jago Douma
d0a93ddfc4
Merge pull request #387 from nextcloud/upstream/accountwizard
...
AccountWizard: Reserve space for error label #6546
2018-06-07 15:39:55 +02:00
Christian Kamm
a1d6af60f0
AccountWizard: Reserve space for error label #6546
2018-06-07 15:32:52 +02:00
Roeland Jago Douma
a6179876c7
Merge pull request #385 from nextcloud/upstream/pr/6525
...
Credentials: Retry fetching from the keychain in case the keychain is…
2018-06-07 15:32:16 +02:00
Olivier Goffart
7c9ec4a55a
Credentials: Retry fetching from the keychain in case the keychain is still starting
...
When owncloud is restored, at boot time, it might be started before the
crendential manager. So if we detect an error, wait 10 seconds and hopefully
it'd be loaded by then.
Issues: #4274 , #6522
2018-06-07 15:18:40 +02:00
Roeland Jago Douma
81b0cdc9d2
Merge pull request #386 from nextcloud/upstream/owncloudsynclog
...
owncloudsynclog: 1 MB -> 10 MB #6420
2018-06-07 15:01:34 +02:00
Julius Härtl
689ab5b8b3
Merge branch 'master' into upstream/owncloudsynclog
2018-06-07 14:38:49 +02:00
Roeland Jago Douma
2a60141ef2
Merge pull request #383 from nextcloud/upstream/pr/6526
...
macOS: Don't use WAL for sqlite3 in /Volumes
2018-06-07 10:36:57 +02:00
Markus Goetz
3cd21e258e
macOS: Don't use WAL for sqlite3 in /Volumes
...
For #6049
2018-06-07 10:22:07 +02:00
Roeland Jago Douma
a01c78a4ce
Merge pull request #382 from nextcloud/upstream/pr/6530
...
SyncJournal: Check file existence even for open dbs #6049
2018-06-07 10:21:07 +02:00
Christian Kamm
8147963b24
SyncJournal: Explain added file-exists check
2018-06-07 09:50:09 +02:00
Christian Kamm
cc04ce9fe4
SyncJournal: Check file existence even for open dbs #6049
...
With WAL mode sqlite seems to occasionally crash when the
underlying filesystem goes away.
2018-06-07 09:50:09 +02:00
Roeland Jago Douma
a348ff3134
Merge pull request #381 from nextcloud/upstream/pr/6532
...
Upload: Adjust timeout for final job based on size #6527
2018-06-07 09:49:25 +02:00
Christian Kamm
5f793c151c
Upload: Adjust timeout for final job based on size #6527
...
Some servers have virus scanners and the like that can delay the
response of the final chunked upload assembly significantly, often
breaking the current 5min (!) timeout. See owncloud/enterprise#2480
for details.
2018-06-07 09:38:16 +02:00
Roeland Jago Douma
b2a8eea875
Merge pull request #380 from nextcloud/upstream/pr/6533
...
Propagation: Connection closed is a normal error #6516
2018-06-07 09:35:32 +02:00
Christian Kamm
4fa762b5ce
Propagation: Connection closed is a normal error #6516
...
Because it sometimes appears in conjunction with server bugs and we
don't want to halt all syncing for other files in these cases.
2018-06-07 09:12:46 +02:00
Roeland Jago Douma
f540c37ad3
Merge pull request #375 from nextcloud/upstream/pr/6523
...
PropagateUpload: Remove unused PropagateUploadFileCommon::abort
2018-06-07 09:11:45 +02:00
Olivier Goffart
14ff3534a8
Fix compilation warning
...
propagateuploadng.cpp:500:10: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
2018-06-07 08:53:12 +02:00
Christian Kamm
3556482bce
TestChunkingNG: Remove unneeded test code
2018-06-07 08:53:12 +02:00
Christian Kamm
d9640dd79e
PropagateUpload: Fix miscount in abort() #6516
...
Previously it tried to abort even jobs that had already finished, which
was not going to work as they wouldn't emit finished() again.
Also, in some cases the abortCount would never go to zero and that case
wasn't well documented.
2018-06-07 08:53:12 +02:00
Christian Kamm
96126a53d3
PropagateUpload: Remove unused PropagateUploadFileCommon::abort
2018-06-07 08:53:10 +02:00
Nextcloud bot
e043840fd0
[tx-robot] updated from transifex
2018-06-07 00:47:40 +00:00
Christian Kamm
797b40237e
Partial local discovery: Fix scheduling logic
...
A recent patch that touched the condition for deciding whether a
periodic full local discovery is necessary accidentally inverted the
condition.
2018-06-06 22:49:50 +02:00
Roeland Jago Douma
448b0ebf63
Merge pull request #374 from nextcloud/upstream/pr/6519
...
ShareLink: Preserve password when unrelated ui changes #6512
2018-06-06 21:01:51 +02:00
Christian Kamm
898a530ba5
ShareLink: Preserve password when unrelated ui changes #6512
2018-06-06 20:56:34 +02:00
Roeland Jago Douma
04930768ee
Merge pull request #370 from nextcloud/upstream/pr/6238
...
update supported linux platforms
2018-06-06 20:56:03 +02:00
Olivier Goffart
e2e6b06d6c
Update installing.rst
2018-06-06 20:50:19 +02:00
Jürgen Weigert
caf21210a6
update supported linux platforms
2018-06-06 20:50:17 +02:00
Roeland Jago Douma
8189c50f51
Merge pull request #368 from nextcloud/upstream/sqlite-version
...
sqlite: Update bundled version to 3.23.1
2018-06-06 20:46:53 +02:00
Olivier Goffart
31ba483845
sqlite: Update bundled version to 3.23.1
...
For OS X and Windows.
2018-06-06 20:40:23 +02:00
Roeland Jago Douma
fb6e503f7b
Merge pull request #367 from nextcloud/upstream/clang
...
Fix a bunch of warning with clang
2018-06-06 20:39:44 +02:00
Olivier Goffart
fbc1747168
Fix a bunch of warning with clang
...
The option -Wno-discarded-qualifiers only exists with GCC, clang warns that
it has no effects.
Also it warns when some virtual fuction are marked with override but not
all of them.
2018-06-06 20:31:14 +02:00
Roeland Jago Douma
075091d7e0
Merge pull request #365 from nextcloud/upstream/pr/6464
...
Logging: Avoid the word "Error"
2018-06-06 20:30:30 +02:00
Markus Goetz
367d0c39e8
Logging: Avoid the word "Error"
...
The old code printed "QNetworkReply::NoError"
2018-06-06 20:24:32 +02:00
Roeland Jago Douma
ba901503fc
Merge pull request #364 from nextcloud/upstream/pr/6458
...
Network settings: If no proxy host given, show "no proxy" #5885
2018-06-06 20:23:49 +02:00
Christian Kamm
e1ab5f3811
Network settings: If no proxy host given, show "no proxy" #5885
...
What happens internally is that a proxy without a hostname gets treated
as no proxy.
2018-06-06 20:11:09 +02:00
Roeland Jago Douma
33b6d0473a
Merge pull request #399 from nextcloud/upstream/pr/6333
...
Use std::chrono::milliseconds to represent milliseconds
2018-06-06 20:09:48 +02:00
Olivier Goffart
073a5184cb
Use std::chrono::milliseconds to represent milliseconds
2018-06-06 17:26:53 +02:00
Julius Härtl
ea58a1038b
Merge pull request #363 from nextcloud/upstream/pr/6468
...
More Button: Use SVG and fix size so it renders good in highdpi
2018-06-06 14:44:24 +02:00
Olivier Goffart
c4af4a5a85
More Button: Use SVG and fix size so it renders good in highdpi
...
When the more button was changed from using a text to an icon,
the size computation was not adjusted proerly to that of a button
with an icon.
And using svg allows it to be rendered correctly with high-dpi
It looks much much nicer now
2018-06-06 13:55:34 +02:00
Roeland Jago Douma
ad43d88fde
Merge pull request #360 from nextcloud/upstream/pr/6428
...
Uploads: Don't delete unexisting chunks
2018-06-06 13:34:55 +02:00
Olivier Goffart
012c638d4e
Uploads: Don't delete unexisting chunks
...
Since commit 4dc49ff3 , we store an entry in the upload info table even
for non chunked uploads. However, if this fails we don't want to remove
non-existant stale chunks if the upload fails.
Without this commit, we would send a DELETE command to clean non-existant
chunks in the dav/uploads/ namespace.
2018-06-06 09:52:02 +02:00
Roeland Jago Douma
27e1efb8a3
Merge pull request #358 from nextcloud/upstream/pr/6434
...
SocketApi/Sharing: Add "copy public link" to menu #6356
2018-06-06 09:34:19 +02:00
Christian Kamm
de9fb7dc9a
Silence warning by removing unnecessary this capture
2018-06-06 09:15:25 +02:00
Christian Kamm
550b845037
SocketApi/Sharing: Add "copy public link" to menu #6356
...
* The new menu option will fetch shares and create a new link share if
no "context menu share" currently exists.
* Various cleanup of common operations in socketapi happened as well,
in particular there's now FileData::get() that calculates all the
relevant paths that are useful for most socketapi actions.
2018-06-06 09:15:23 +02:00
Roeland Jago Douma
d7ce92b017
Merge pull request #357 from nextcloud/upstream/notifications
...
Notifications: Lower hiding timeout
2018-06-05 21:45:37 +02:00
Markus Goetz
eb097cbffb
Notifications: Lower hiding timeout
...
With the 4.5sec timeout, it was very easy to accidently hit the wrong notification
when the previous one dissapeared so late.
2018-06-05 21:24:56 +02:00
Roeland Jago Douma
4e4ec48bbc
Merge pull request #356 from nextcloud/upstream/qunused
...
Q_UNUSED: Sprinkle around
2018-06-05 21:20:09 +02:00
Markus Goetz
de1032ebd7
Q_UNUSED: Sprinkle around
2018-06-05 20:45:51 +02:00
Roeland Jago Douma
27826ddee0
Merge pull request #355 from nextcloud/upstream/pr/6450
...
macOS: Implement new dynamic Finder menu items #6328
2018-06-05 20:45:11 +02:00
Markus Goetz
d3cbe63801
macOS: Implement new dynamic Finder menu items #6328
2018-06-05 20:40:40 +02:00
Roeland Jago Douma
5b0a1d4c79
Merge pull request #354 from nextcloud/upstream/pr/6444
...
macOS: Unload the Finder extension on exit #5382 #3819
2018-06-05 20:39:43 +02:00
Markus Goetz
648911f3ab
macOS: Unload the Finder extension on exit #5382 #3819
2018-06-05 20:22:02 +02:00
Roeland Jago Douma
eda221227f
Merge pull request #353 from nextcloud/upstream/pr/6448
...
Simple permanent logging
2018-06-05 20:21:25 +02:00
Christian Kamm
4a81ae75cf
Logging: Add persistent auto-logdir option #6442
2018-06-05 20:07:53 +02:00
Christian Kamm
428cfc5e1c
LogDir: Compress log when switching files #6442
2018-06-05 20:07:53 +02:00
Christian Kamm
9319b6594e
LogDir: Go to new file on Problem/Abort too #6442
2018-06-05 20:07:53 +02:00
Roeland Jago Douma
a7b7344659
Merge pull request #352 from nextcloud/upstream/pr/6438
...
Folders: Use "Problem" icon for unresolved conflicts #6277
2018-06-05 20:07:00 +02:00
Christian Kamm
63c2474b70
Folders: Use "Problem" icon for unresolved conflicts #6277
2018-06-05 19:59:19 +02:00
Roeland Jago Douma
f9f1f8bda6
Merge pull request #351 from nextcloud/upstream/pr/6437
...
Share link: Update permission wording #6192
2018-06-05 19:58:40 +02:00
Christian Kamm
ed5e413751
Share link: Update permission wording #6192
2018-06-05 19:46:04 +02:00
Roeland Jago Douma
7c4c3b0493
Merge pull request #349 from nextcloud/upstream/macOS
...
macOS: build/installer changes
2018-06-05 13:39:36 +02:00
Roeland Jago Douma
4ddbb35d77
Fix debian patch
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-05 13:29:51 +02:00
Markus Goetz
16bf765818
macOS: Don't hardcode path in Installer source
2018-06-05 13:29:51 +02:00
Markus Goetz
5667408c58
macOS: Offer only standard installation in installer
2018-06-05 13:29:51 +02:00
Markus Goetz
a0e17ce221
create_mac.sh: Also name properly in source dir
2018-06-05 13:29:51 +02:00
Markus Goetz
3defc30e12
macosx.pkgproj; This is a .cmake preprocessed file
2018-06-05 13:29:51 +02:00
Christian Kamm
09f83f4fa9
SyncJournal: Clear etag filter before sync
...
Before, we only cleared the _avoidReadFromDbOnNextSyncFilter *after* a
sync which meant that we had to sync twice after selective sync setup.
Now, we clear the filter *before* a sync as well which allows the actual
next sync to write the correct etags to the db again - instead of only
the sync after that one.
Also expand on comments and rename _avoidReadFromDbOnNextSyncFilter to
_etagStorageFilter.
2018-06-05 12:00:20 +02:00
Roeland Jago Douma
3ce41c71c1
Merge pull request #350 from nextcloud/upstream/pr/6436
...
SyncJournalDb::setSelectiveSyncList: Always use a transaction
2018-06-05 11:30:24 +02:00
Olivier Goffart
613fd30021
SyncJournalDb::setSelectiveSyncList: Always use a transaction
...
Issue #6431
2018-06-05 11:15:51 +02:00
Roeland Jago Douma
0afcb23734
Merge pull request #331 from nextcloud/upstream/pr/6412
...
Blacklisting must prevent parent etag updates #6411
2018-06-05 10:18:53 +02:00
Christian Kamm
c57e4dcf03
Blacklisting must prevent parent etag updates #6411
2018-06-05 10:12:11 +02:00
Roeland Jago Douma
5309694b34
Merge pull request #394 from nextcloud/fix/master/info
...
Fix output add E2E again
2018-06-05 09:39:06 +02:00
Roeland Jago Douma
a0c458d937
Fix output add E2E again
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-05 09:02:41 +02:00
Roeland Jago Douma
a035b9b10b
Merge pull request #393 from ivaradi/master
...
Re-encoded Ubuntu/Debian upload keys
2018-06-05 09:02:23 +02:00
István Váradi
92de0770bc
Re-encoded Ubuntu/Debian upload keys
2018-06-05 08:34:41 +02:00
Roeland Jago Douma
2eb87e769c
Merge pull request #330 from nextcloud/upstream/pr/6408
...
FolderStatusModel: fix potential assert
2018-06-05 08:19:01 +02:00
Olivier Goffart
f4f228de3e
FolderStatusModel: fix potential assert
...
OCC::FolderStatusModel::slotUpdateDirectories: ASSERT: "parentInfo->_fetching" in file /home/olivier/kdegit/owncloud/mirall/src/gui/folderstatusmodel.cpp, line 599
This can happen if the structure of a folder is change while the user
expands the root folder. In this case, resetSubs() is called which
resets _fetching to false.
Instead, we need to keep a pointer to the job so we can abort it by
deleting it.
2018-06-05 08:12:58 +02:00
Roeland Jago Douma
6872cbda7e
Merge pull request #329 from nextcloud/upstream/pr/6416
...
csync_update: add the checksum in the discovery log
2018-06-05 08:12:00 +02:00
Olivier Goffart
3e508329b5
csync_update: add the checksum in the discovery log
...
Issue #6414
2018-06-05 07:52:29 +02:00
Roeland Jago Douma
69aa077212
Merge pull request #338 from ivaradi/master
...
Patch the OSX CMakeLists.txt for Xenial
2018-06-05 07:51:46 +02:00
István Váradi
d0e4c67459
Merge branch 'master' of github.com:nextcloud/client
2018-06-05 06:58:12 +02:00
Nextcloud bot
f8d0cbd468
[tx-robot] updated from transifex
2018-06-05 00:47:52 +00:00
Roeland Jago Douma
dfed78a665
Merge pull request #328 from nextcloud/upstream/issue/5932
...
macdeployqt: Adjust minimum version based on our Qt #5932
2018-06-04 20:23:38 +02:00
Markus Goetz
0d182280c4
macdeployqt: Adjust minimum version based on our Qt #5932
2018-06-04 20:02:43 +02:00
Roeland Jago Douma
8477c5a565
Merge pull request #327 from nextcloud/upstream/pr/6271
...
postinstall macOS: check if Finder is running
2018-06-04 20:00:58 +02:00
Roeland Jago Douma
32ae670c4e
Merge pull request #325 from nextcloud/upstream/ssl-button-speed
...
SslButton: Improve speed (especially on macOS) #6031
2018-06-04 17:14:38 +02:00
Roeland Jago Douma
4bd6f2b26d
Merge pull request #323 from nextcloud/upstream/upload-finished-flag
...
Upload: Simplify 'finished' flag
2018-06-04 17:14:17 +02:00
Roeland Jago Douma
c1171d700e
Merge pull request #322 from nextcloud/upstream/pr/6404
...
Excludes: Expand doc, Desktop.ini only in root folder
2018-06-04 17:13:23 +02:00
Roeland Jago Douma
3a1dc44ec8
Merge pull request #320 from nextcloud/upstream/issue/6403
...
propagateuploadv1: don't finalize after a done()
2018-06-04 17:12:52 +02:00
Roeland Jago Douma
3c3f3541d4
Merge pull request #291 from nextcloud/fixEncryptionDecryptionNonEmptyFolder
...
Forbid to encrypt or decrypt a non-empty folder.
2018-06-04 16:03:25 +02:00
Roeland Jago Douma
c49597d9d8
Merge pull request #319 from nextcloud/upstream/issue/4424
...
Folder: normalize the local path.
2018-06-04 16:02:49 +02:00
Roeland Jago Douma
321e8c0264
Merge pull request #317 from nextcloud/upstream/issue/3146
...
SslButton: Add HTTP/2 info #3146
2018-06-04 16:01:44 +02:00
Roeland Jago Douma
092063d348
Merge pull request #316 from nextcloud/upstream/pr/6384
...
CSync Errors cleanup
2018-06-04 15:59:45 +02:00
Olivier Goffart
393f6c2310
SyncEngine: remove the "CSync" wording from the error messages
...
They are confusing for the user.
Example in issue #6274
2018-06-04 15:41:38 +02:00
Olivier Goffart
5f30177bfc
CSync: Remove unused error codes
...
None of the removed ERRNO code were ever set.
So none of the removed error hapenned anymore
2018-06-04 15:41:38 +02:00
Olivier Goffart
15e93c8a31
CSync: reconcile never returns an error
2018-06-04 15:41:38 +02:00
Olivier Goffart
be29fc2f69
csync: remove CSYNC_PARAM_ERROR
...
It does not make sense to report such error to the user.
Its goal was to show invalid use of the csync API, but this is now done
with asserts.
2018-06-04 15:41:38 +02:00
Olivier Goffart
0443f8dd4d
csync: Simplify csync_walk_local_tree/csync_walk_remote_tree
...
Small refactoring
2018-06-04 15:41:38 +02:00
Tomaz Canabrava
9b74a596c6
Forbid to encrypt or decrypt a non-empty folder.
...
The specs forbid the encryption or decryption of a
non empty folder. so...
1 - check for the sync status, if it's not synced return
as there's no way that I can say that there's items on the
server right now without waiting for the sync to finish
2 - verify if the folder is empty locally
as the user could have send some files to the folder.
2018-06-04 15:33:01 +02:00
Julius Härtl
5df1af79c5
Merge pull request #377 from nextcloud/bugfix/noid/cloudprovidesr_314
...
Fix cloudproviders after merging #314
2018-06-04 15:32:36 +02:00
Morris Jobke
d35ea29ad2
Merge pull request #388 from nextcloud/documentation/macos-osx
...
[documentation] Mac OS X is now macOS
2018-06-04 14:10:55 +02:00
Marius Blüm
78bfae45ae
Mac OS X is now macOS
...
Signed-off-by: Marius Blüm <marius@lineone.io >
2018-06-04 11:44:03 +02:00
Markus Goetz
ab34f36836
owncloudsynclog: 1 MB -> 10 MB #6420
2018-06-03 23:09:23 +02:00
Roeland Jago Douma
f96206705a
Merge pull request #315 from nextcloud/upstream/pr/6379
...
Discovery: Error if properties are missing #6317
2018-06-03 19:58:21 +02:00
Nextcloud bot
70d4c64d99
[tx-robot] updated from transifex
2018-06-03 00:48:45 +00:00
Roeland Jago Douma
4b1c6bb833
Fix cloudproviders after merging #314
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-02 20:46:10 +02:00
Roeland Jago Douma
1262cbf4ef
Merge pull request #314 from nextcloud/upstream/pr/6373
...
Make sure ignored and conflict files show up in the issues tab even with partial local discovery
2018-06-02 20:20:19 +02:00
Nextcloud bot
b2433c8961
[tx-robot] updated from transifex
2018-06-02 00:46:48 +00:00
Julius Härtl
c9634d65aa
Merge pull request #313 from nextcloud/upstream/pr/6380
...
ConnectionValidator: change the minimum server version
2018-06-01 15:43:19 +02:00
Julius Härtl
fc4f8fb2d5
Merge pull request #372 from nextcloud/upstream/pr/6488
...
ShareDialog: macOS grey odditiy #5774
2018-06-01 15:42:26 +02:00
Julius Härtl
4be565c56f
Merge pull request #369 from nextcloud/upstream/issue/6406
...
Nautilus shell integration: Print python version on startup #6406
2018-06-01 15:40:23 +02:00
Julius Härtl
e4981931ac
Merge pull request #373 from nextcloud/upstream/pr/6490
...
Nautilus: Fix Python3 and remove many debug
2018-06-01 15:39:56 +02:00
Olivier Goffart
5f969580ac
Nautilus: Fix Python3 and remove many debug
...
Use b'\n' in the call to rfind, as the _remainder is bytes, not a string.
Remove most of the debug message which happens during normal operation.
They are mostly spamming the nautilus console, and can also cause bug
as they may throw exception in case of wrong encoding.
Relates to issue: #6406
2018-06-01 13:35:19 +02:00
Markus Goetz
b8b9b93a6e
ShareDialog: macOS grey odditiy #5774
2018-06-01 13:31:22 +02:00
Olivier Goffart
4d7617d64b
Propagator: remove a bunch of code related to the 'Shared' directory
...
This no longer exists since the owncloud server 7.0 which we no longer
allow to connect to
2018-06-01 13:17:20 +02:00
Olivier Goffart
8484b493e4
ConnectionValidator: change the minimum server version
...
Forbit connection with server older than 7.0. These server did not have
permission.
Also warn for anything older than 9.1. 9.0 is end of life according to
https://github.com/owncloud/core/wiki/Maintenance-and-Release-Schedule
2018-06-01 13:17:11 +02:00
Christian Kamm
70f0792d4a
Nautilus shell integration: Print python version on startup #6406
2018-06-01 13:02:13 +02:00
Roeland Jago Douma
335298f4e2
Merge pull request #312 from nextcloud/upstream/pr/6374
...
Move ClientProxy and and ConnectionValidator out of libsync
2018-06-01 11:08:20 +02:00
Olivier Goffart
1b587a1241
ConnectionValidator::Status use Q_ENUM
...
So no need to have a manual conversion to QString
This is only used in debug message anyway.
2018-05-31 21:56:55 +02:00
Olivier Goffart
311307e8cb
Move ClientProxy and ConnecitonValidator to gui
...
They are using the ConfigFile and are used to control
when to sync rather than for the sync itself
2018-05-31 21:56:55 +02:00
Olivier Goffart
7e05e1e411
owncloudcmd: Do not overwrite the http timeout for json jobs
...
The AbstractNetworkJob already has a sensible timeout that depends
on an environment variable.
No need to overwrite that with some arbitrary value. (The connection
validator does that because it could cause problems if two connection
validator were to run at the same time. Not a problem here)
2018-05-31 21:56:55 +02:00
Olivier Goffart
204cb470b4
owncloudcmd: Do not read the proxy settings from the gui's config file
...
The proxy settings for the owncloudcmd client can be set via the
--httpproxy command line argument. owncloudcmd should not depends
on the gui's config
2018-05-31 21:56:55 +02:00
Olivier Goffart
9fe8713bdc
Folder: remove unused member
2018-05-31 21:56:44 +02:00
Nextcloud bot
08024f69c8
[tx-robot] updated from transifex
2018-05-31 00:48:48 +00:00
Roeland Jago Douma
c6ef8eec0a
Merge pull request #305 from nextcloud/upstream/pr/6363
...
SyncEngine: Use separate state for two unicode conversions
2018-05-30 08:04:05 +02:00
Roeland Jago Douma
86741de622
Merge pull request #299 from nextcloud/upstream/pr/6349
...
Don't delete contents behind directory junctions #6322
2018-05-30 08:03:04 +02:00
Roeland Jago Douma
c6c42c3c70
Merge pull request #311 from nextcloud/upstream/pr/6371
...
Utility::fsCasePreserving: remove UNIT_TESTING ifdef
2018-05-29 20:33:34 +02:00
Roeland Jago Douma
d410b8e057
Merge pull request #310 from nextcloud/upstream/version-cmake
...
VERSION.cmake: This is 2.4.2 now
2018-05-29 20:32:27 +02:00
Markus Goetz
68601240f8
VERSION.cmake: This is 2.4.2 now
2018-05-29 20:19:42 +02:00
Roeland Jago Douma
6ebcc638e0
Merge pull request #300 from nextcloud/upstream/pr/6351
...
SettingsDialogMac: Also start timer for notifications
2018-05-29 20:19:03 +02:00
Markus Goetz
13b2e51dfe
Notifications: Immediately request when getting account online
2018-05-29 20:09:08 +02:00
Markus Goetz
00d8343e76
SettingsDialogMac: Also start timer for notifications
2018-05-29 20:09:06 +02:00
Nextcloud bot
4089456bc6
[tx-robot] updated from transifex
2018-05-28 00:49:03 +00:00
Roeland Jago Douma
1b756ac80f
Merge pull request #318 from nextcloud/upstream/pr/6402
...
Dolphin plugin: fall back if $XDG_RUNTIME_DIR is empty
2018-05-26 21:33:45 +02:00
Roeland Jago Douma
bb1b86b087
Merge pull request #307 from nextcloud/upstream/pr/6366
...
test/testsyncengine: testNoLocalEncoding is for Linux
2018-05-26 21:30:21 +02:00
Nextcloud bot
e9be7fc18a
[tx-robot] updated from transifex
2018-05-26 00:54:16 +00:00
Nextcloud bot
37cac61f49
[tx-robot] updated from transifex
2018-05-25 00:55:04 +00:00
Nextcloud bot
c2e0a4a73c
[tx-robot] updated from transifex
2018-05-23 16:56:31 +00:00
István Váradi
76c4b05270
Patch the OSX CMakeLists.txt for Xenial
2018-05-22 07:04:09 +02:00
Camila Ayres
122daf4199
Merge pull request #335 from nextcloud/rakekniven-patch-1
...
Fixed tiny grammar issue (adds dot to the end of a sentence)
2018-05-21 17:43:35 +02:00
rakekniven
8d90c8c17b
Fixed tiny grammar issue
2018-05-20 11:17:46 +02:00
Julius Härtl
6a5654d6d2
Merge pull request #294 from nextcloud/upstream/pr/6330
...
SocketAPI: "Open in browser" and disable Share entries when sharing i…
2018-05-19 16:09:50 +02:00
Julius Härtl
9196ab1c98
Merge pull request #246 from k1l1/master
...
scary wording on big changes #216 (translations missing)
2018-05-19 15:44:04 +02:00
Kilian Pfeiffer
bb65eb8cdd
changed wording
...
https://github.com/nextcloud/client/issues/216
2018-05-19 13:17:25 +02:00
Julius Härtl
b7a67863a7
Merge pull request #306 from nextcloud/upstream/pr/6347
...
Set launch-on-startup when the first account is set up
2018-05-18 16:08:52 +02:00
Roeland Jago Douma
b7d5aff901
Merge pull request #303 from nextcloud/upstream/issue/6322
...
SyncJournal: Don't use LIKE with paths
2018-05-18 13:56:25 +02:00
Roeland Jago Douma
1dc3c156d4
Merge pull request #304 from nextcloud/upstream/pr/6364
...
Conflicts: Add user name to conflict file name #6325
2018-05-18 13:56:14 +02:00
Julius Härtl
0283e1bfaa
Merge pull request #295 from nextcloud/upstream/pr/6329
...
Tray: Change icon for unresolved conflicts #6277
2018-05-18 08:53:49 +02:00
Julius Härtl
5f0b56e13a
Merge pull request #326 from nextcloud/upstream/pr/6415
...
Nautilus integration: Not a ColumnProvider
2018-05-17 22:56:57 +02:00
Joss Brown
df8708dd46
postinstall macOS: check if Finder is running
...
Some users have disabled Finder, and the postinstall will always reenable Finder, unless it checks Finder status first.
2018-05-17 21:14:57 +02:00
Roeland Jago Douma
cf4e156fa0
Merge pull request #321 from nextcloud/upstream/qtversion-pkg-name
...
macOS: Put Qt version in .pkg name
2018-05-17 21:13:42 +02:00
Roeland Jago Douma
3b4fcfcc65
Merge pull request #302 from nextcloud/upstream/pr/6352
...
Sharing: Use maximum allowed permissions for new share #6346
2018-05-17 21:11:33 +02:00
Christian Kamm
629b14266b
Nautilus integration: Not a ColumnProvider
...
The nautilus plugin doesn't actually define get_columns(), so pretending
to be a ColumnProvider lead to a critical warning on startup.
2018-05-17 20:52:40 +02:00
Roeland Jago Douma
33555292ae
Merge pull request #301 from nextcloud/upstream/pr/6353
...
HTTP2: Only from Qt 5.9.4 #6285
2018-05-17 15:39:09 +02:00
Roeland Jago Douma
36572b79c3
Merge pull request #298 from nextcloud/upstream/no-shibboleth
...
NO_SHIBBOLETH: Fix warning
2018-05-17 15:38:04 +02:00
Roeland Jago Douma
2e0d724e3e
Merge pull request #297 from nextcloud/upstream/pr/6336
...
- add description for moveToTrash variable
2018-05-17 15:37:40 +02:00
Roeland Jago Douma
cbeb9af7fd
Merge pull request #296 from nextcloud/upstream/issue/6337
...
FolderStatusModel: Refresh folders on Problem sync #6337
2018-05-17 15:37:20 +02:00
Camila Ayres
19ae3e4326
Merge pull request #293 from nextcloud/upstream/pr/6265
...
Move remote-deleted files to trash
2018-05-17 12:20:53 +02:00
Markus Goetz
9ef42b4835
SslButton: Improve speed (especially on macOS) #6031
...
From 1+n*450msec to 1*450msec
2018-05-16 21:03:06 +02:00
Christian Kamm
a2675b559b
Upload: Simplify 'finished' flag
...
* Sometimes there was 'finished' and '_finished'
* Make each done() call automatically set _finished to true
2018-05-16 20:57:26 +02:00
Christian Kamm
5f7fd7c551
Excludes: Expand doc, Desktop.ini only in root folder
...
The Desktop.ini exclude was added for 2.4 because we add such a file to
the synced folder on Windows. It doesn't need to cover subdirectories.
2018-05-16 20:29:12 +02:00
Olivier Goffart
ad276a4bce
Folder: normalize the local path.
...
We otherwise normalize all path in the C form, so we must have
the Folder's path normalized the same. Or all comparizon will fail
(such as knowing if a file from the SocketAPI or the FilesystemWatcher
are part of the folder)
Issue #4424
2018-05-16 20:26:09 +02:00
Olivier Goffart
3506c52be9
propagateuploadv1: don't finalize after a done()
...
Should fix an assert when "Server does not support X-OC-MTime"
(Which only happens with owncloud 5)
Issue #6403
2018-05-16 20:23:47 +02:00
Markus Goetz
434f093f98
SslButton: Add HTTP/2 info #3146
2018-05-16 20:10:51 +02:00
Markus Goetz
b22daf8691
macOS: Put Qt version in .pkg name
2018-05-16 20:08:25 +02:00
whitequark
6dd5876b8a
Dolphin plugin: fall back if $XDG_RUNTIME_DIR is empty
...
As per XDG Base Directories specification:
> If $XDG_RUNTIME_DIR is not set applications should fall back
> to a replacement directory [...]
In practice, the ownCloud client has the fallback, but the plugin
helper does not, and if $XDG_RUNTIME_DIR is not set, the plugin
mysteriously does not work.
2018-05-16 20:05:46 +02:00
Christian Kamm
1868b2f3ec
IssuesWidget: addItem performance improvement
...
Ensure adding a new item isn't usually O(n) by keeping track of which
items have associated issues.
2018-05-16 16:49:41 +02:00
Christian Kamm
a0d7095b2c
IssuesWidget: Don't allow two issues for the same file/folder
...
This is intended to safeguard against invalidation bugs that cause the
same error to be added again for every sync run.
2018-05-16 16:49:03 +02:00
Christian Kamm
a0d5e31423
INSTRUCTION_IGNORE now carries a direction
...
This allows IssuesWidget to selectively wipe only the 'Up' ignores
during selective local discovery.
2018-05-16 16:48:31 +02:00
Christian Kamm
11b6b48c75
ProtocolItem: Adjust the way data is stored again
...
The struct makes it easy to pack data and should consume less memory
overall.
2018-05-16 16:48:06 +02:00
Christian Kamm
800f1ace0c
SyncResult: Make sure the number of conflicts is correct #6226
...
If the SyncResult incorrectly believes that there are no conflicts, the
tray icon won't be correct and there will be no warning about unresolved
conflicts on the account.
Nevertheless, it's pretty awkward that the IssuesWidget is better
informed about pending conflicts than the Folder itself. This kind of
backwards data flow is very confusing.
Unfortunately the only alternative I see is to either keep track of
this information in two places (also in Folder), or create a common
data-holding class that can serve as a model instance for the issues
view as well as provide data directly to the Folder - which would
have been a much larger change.
2018-05-16 16:47:27 +02:00
Christian Kamm
75194d1821
SyncEngine: Make "local discovery?" question available
...
Also fix the minor bug that was mentioned and add tests.
2018-05-16 16:46:40 +02:00
Christian Kamm
2defaf099d
Issues tab: Invalidate issues selectively #6226
...
Everything is invalidated later: after discovery, not before. In
addition entries that should only be invalidated when new local
discovery is done have that behavior now.
2018-05-16 16:45:39 +02:00
Christian Kamm
01f83ff398
ProgressInfo: Add information for local vs remote discovery
2018-05-16 16:45:13 +02:00
Christian Kamm
8077748c9d
slotFolderDiscovered: Fix 'local' always being false
...
It was unused, so no harm done.
2018-05-16 16:44:36 +02:00
Christian Kamm
687b6f5655
Discovery: Error if properties are missing #6317
2018-05-16 16:42:20 +02:00
Olivier Goffart
b0f539fc1f
cmake: Remove references of now unused WITH_TESTING
...
Issue #6318
2018-05-16 13:00:17 +02:00
Olivier Goffart
d4aebd30de
Utility::fsCasePreserving: remove UNIT_TESTING ifdef
...
Since the release package will be build with unit test, we don't
want to query the env variable at every call to fsCasePreserving.
So only test the env variable at startup.
And the testutility can still change the value.
(The env variable is still used from t8.pl and maybe smashbox)
Issue #6318
2018-05-16 12:57:20 +02:00
Markus Goetz
f6b67a866a
test/testsyncengine: testNoLocalEncoding is for Linux
2018-05-15 23:06:39 +02:00
Christian Kamm
583399ad53
Set launch-on-startup when the first account is set up
...
The previous code would disable it when the second account was
configured.
See #6347
2018-05-15 22:59:16 +02:00
Christian Kamm
ea142b8018
Conflicts with user name: Fix tests
2018-05-15 22:54:48 +02:00
Christian Kamm
f244cc4d4a
SyncEngine: Use separate state for two unicode conversions
...
It's unlikely that there were interaction effects but still seems safer
to use different conversion state for the path and rename_path.
2018-05-15 22:44:10 +02:00
Christian Kamm
17d174e6fa
Conflicts: Add user name to conflict file name #6325
...
For the case of uploading conflict files only.
2018-05-15 22:38:35 +02:00
Christian Kamm
ce0e2d0b88
SyncJournal: Don't use LIKE with paths
...
Paths can contain the wildcards % and _ and that would lead to odd
behavior.
This patch also clarifies the behavior of avoidReadFromDbOnNextSync()
which previously dependend on whether "foo/bar" or "foo/bar/" was
passed as input.
Possibly affects #6322
2018-05-15 19:44:00 +02:00
Christian Kamm
7154a001d6
Sharing: Use maximum allowed permissions for new share #6346
...
The client already computed the valid permissions, there was just a typo
that meant we didn't end up using them.
2018-05-15 19:26:40 +02:00
Markus Goetz
e82869d10e
HTTP2: Only from Qt 5.9.4 #6285
2018-05-15 19:23:11 +02:00
Olivier Goffart
88347a985f
Adjust the Move To Trash patch
...
(PR #6265 )
- Remove the UI completely
- Move the #ifdef inside the FileSystem::moveToTrash function, so it is easier to
implement on other platforms
- Q_OS_UNIX includes mac, so we need to disable it. (not using Q_OS_LINUX because of
other BSD that uses XDG spec as well
- Translate the error messages
- Add a couple of doc comments
2018-05-15 19:10:41 +02:00
Christian Kamm
2d1d651fcd
Don't delete contents behind directory junctions #6322
...
QFileInfo::isSymLink() does detect reparse points that are symlinks but
returns false for junctions. The new function FileSystem::isJunction()
can detect those and is used to not recursively delete files inside
directories that are junctions.
See also https://bugreports.qt.io/browse/QTBUG-45344 and the
discussion in the PR https://codereview.qt-project.org/#/c/113019/ .
2018-05-15 18:42:44 +02:00
Markus Goetz
d33692cdc7
NO_SHIBBOLETH: Fix warning
2018-05-15 18:31:12 +02:00
Oleg Solovyov
66eeb96c54
- doc: linux-only setting
2018-05-15 18:25:27 +02:00
Oleg Solovyov
09ade2b892
- add description for moveToTrash variable
2018-05-15 18:22:36 +02:00
Christian Kamm
1fa88c9820
FolderStatusModel: Refresh folders on Problem sync #6337
...
We don't want to refresh too frequently. But Problem is very close to
Success and very common.
2018-05-15 18:08:17 +02:00
Christian Kamm
ad750f569c
Tray: Change icon for unresolved conflicts #6277
2018-05-15 17:58:10 +02:00
Olivier Goffart
2fcd7b20b8
SocketAPI: "Open in browser" and disable Share entries when sharing is disabled.
...
This adds "Open in browser" entry in the menu (Issue #5903 )
Also mark the entries as disabled when the file is not yet on the server.
If re-sharing is not allowed for that file, a disabled explaination
entry is added to the menu.
If sharing is disabled globaly in the branding or in the server,
the share entry will not be present.
(Issues #4205 and #4608 )
Meta issue #6292
2018-05-15 17:39:30 +02:00
Oleg Solovyov
f9fe24feb9
Move remote-deleted files to trash
...
Squashed from https://github.com/owncloud/client/pull/6265
Linux only, Hidden option, disabled by default
2018-05-15 17:23:38 +02:00
Julius Härtl
5e2270bd57
Merge pull request #247 from nextcloud/adds-etag-navigation-apps
...
Checks for 304 response in the navigation apps request
2018-05-08 06:55:41 +02:00
Camila San
d629f2259d
Changes from qCWarning to qCDebug.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-05-07 18:19:29 +02:00
Camila San
bbff83fe7c
Only updates the list of apps when there is a change in the server (not 304 status).
...
Signed-off-by: Camila San <hello@camila.codes >
2018-05-07 18:03:51 +02:00
Camila San
402dc6c33b
Checks for http status code before building navigation apps menu.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-05-07 18:03:51 +02:00
Camila San
23a759ef4a
Adds 304 http status code as valid.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-05-07 18:03:51 +02:00
Camila San
77ebccee72
Adds methods to set/get navigation apps etag response header.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-05-07 18:03:51 +02:00
Camila San
d7286872f6
Adds function to add raw header to the request.
...
Function added to be able to add If-None-Match to save the ETag.
Signed-off-by: Camila San <hello@camila.codes >
2018-05-07 18:03:42 +02:00
Camila Ayres
3b0b0fea33
Merge pull request #282 from ivaradi/master
...
Fix Debian build (another attempt)
2018-05-06 19:23:31 +02:00
István Váradi
ceb83c3709
Merge branch 'master' of github.com:nextcloud/client
2018-05-06 18:28:34 +02:00
István Váradi
a602df065e
Fixed the name of the Qt WebEngine package
2018-05-06 17:12:17 +02:00
István Váradi
181f3bbd26
Added build dependency on qt5webengine-dev ( #281 )
2018-05-06 16:17:16 +02:00
István Váradi
7e210cfcb3
Merge branch 'master' of github.com:nextcloud/client
2018-05-06 10:24:21 +02:00
István Váradi
fee2872a98
Added build dependency on qt5webengine-dev
2018-05-06 09:53:49 +02:00
Roeland Jago Douma
880f256a62
Merge pull request #278 from ivaradi/master
...
Fix Debian build
2018-05-03 22:20:44 +02:00
István Váradi
7827fe4151
Fix Debian build
2018-05-03 19:02:49 +02:00
Roeland Jago Douma
e40bddb2c2
Merge pull request #276 from nextcloud/no_debian
...
Build no debian while it fails
2018-05-03 14:38:38 +02:00
Roeland Jago Douma
ed3a723ad2
Build no debian while it fails
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-03 14:28:11 +02:00
Roeland Jago Douma
889c930b36
Merge pull request #75 from nextcloud/new_flow
...
Add weblogin flow for NC > 12
2018-05-03 14:07:44 +02:00
Roeland Jago Douma
56e17c25b2
Change loading bar to NC blue
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-03 13:55:27 +02:00
Roeland Jago Douma
ef2d113930
Mark credentials as valid if there is no error
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
35e8d0437d
Address comments
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
6809f12e68
Allow the user to sign in again
...
If the user is signed out (for whatever reason). Show a popup
with the loginflow again.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
ac1664b525
Actually use webflow credentails
...
* Detect invalid auth (if the users token is removed for example)
* Properly store and fetch from keychain
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
6b43d80c01
Start with persisting credentials
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
356f9b4831
Actually connect properly to server
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
715c738ebf
Add urlschema handler so w can catch the nc:// urls
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
c763a6e7fb
Show webview with page
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Roeland Jago Douma
c4a88fe57e
Add QWebView as a dependency
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-02 22:50:48 +02:00
Camila Ayres
9338dadaab
Merge pull request #265 from k1l1/log_files_path
...
Put log files somewhere else #221 (name conflict)
2018-05-02 15:30:34 +02:00
Kilian Pfeiffer
56c1d79c49
fixes windows crash / renaming changed
2018-04-30 16:09:04 +02:00
Camila Ayres
64cbc88474
Merge pull request #251 from nextcloud/clientSideEncryptionV4
...
Client side encryption v4.
2018-04-26 19:56:55 +02:00
Kilian Pfeiffer
cd926e5b84
resolving name conflict in logfiles
2018-04-24 15:47:23 +02:00
Morris Jobke
a41546834e
Merge pull request #262 from nextcloud/update-transifex-config
...
Update transifex config and move it to a proper place
2018-04-23 19:59:41 +02:00
Morris Jobke
3a763f4d9c
Update transifex config and move it to a proper place
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-04-23 15:45:34 +02:00
Roeland Jago Douma
81ae682e87
Revert "Make different program so it doesn't mess with existing config"
...
This reverts commit c04d1f1f69 .
2018-04-22 21:04:37 +02:00
Roeland Jago Douma
75609c1b2c
Merge pull request #254 from ad1rie1/FIX32BitApplication
...
Fix #6394
2018-04-22 20:57:36 +02:00
Camila Ayres
25b40cc852
Merge pull request #255 from ad1rie1/FixDeprecatedTR
...
Fix Use of Deprecated trUtf8.
2018-04-20 11:11:05 +02:00
Adrien
8e52f1237b
Fix Use of Deprecated trUtf8
2018-04-19 12:02:26 +02:00
Julius Härtl
00336bd71d
Merge pull request #253 from k1l1/log_files_path
...
Put log files somewhere else #221
2018-04-19 11:43:29 +02:00
Adrien
5f0a021c04
Fix #6394
2018-04-19 11:35:03 +02:00
Kilian Pfeiffer
40b1f051a4
log files are visible now
2018-04-17 17:59:03 +02:00
Kilian Pfeiffer
faf64958ec
changed paths of logfiles
2018-04-17 15:54:05 +02:00
Tomaz Canabrava
7432d6a814
Merge branch 'master' into clientSideEncryptionV4
2018-04-10 16:18:58 +02:00
Daniel Nicoletti
16aa54ed64
Do not create new db entries when the remote tree does not have proper values
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
3e05bd1da0
Do not detach encrypted files vector
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
3eb3535d0f
Fix downloading NEW encrypted files
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
defe2d7631
Fix matching encrypted data for downloading
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
b12066f1aa
Properly remove encryption data from JSON of deleted file
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
a9208f6581
Remove unused encrypted property
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
6e63a538b7
Make sure bool _currentLockingInProgress is first defined to false
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
a7a8de8787
Fix matching encrypted file for download
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
d93f7269b8
Properly mark encrypted files for removal
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
d3b6aacf3f
Fix merging remote and local trees when e2e files are involved
...
When populating the tree from the filesystem we need to fill
the e2eMangledName from DB and we when trying to find another
match on the oposite tree we need to take in account that names
don't match and search with the mangled name information
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
c0ef36b8fa
Use QUuid to generate random names
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
60fc5d6dd4
Fix upload of existing encrypted files by matching only filename
2018-04-09 13:23:52 +02:00
Daniel Nicoletti
d5ab642e46
Fix sync status running when encryption data is missing
...
When a file on the server of an encrypted folder do
not have a matching entry on the JSON metadata, we
need to report an error and be done with the job
so that Sync status is not "running".
This eventually should cause the file to be removed
from the server as it can not be recovered anymore.
2018-04-09 13:23:52 +02:00
Tomaz Canabrava
b4b3e422de
Handle gracefully failures in file decryption
2018-03-27 09:18:54 +02:00
Tomaz Canabrava
ed6f56257e
Dont use new with QFiles.
2018-03-26 22:18:07 +02:00
Tomaz Canabrava
461aeca200
Do not crash when failing to decrypt the metadata
2018-03-26 22:02:46 +02:00
Tomaz Canabrava
6c88367ac6
Do not crash if there was an error encrypting the file.
2018-03-26 21:44:46 +02:00
Tomaz Canabrava
5fe9717598
Potentially fix crash acessing a deleted pointer.
2018-03-26 21:37:13 +02:00
Tomaz Canabrava
ec28465e01
Correctly handle systems without client side encryption
2018-03-26 20:51:14 +02:00
Tomaz Canabrava
11684682e6
Return empty metadata in case of error, Display error to the user.
2018-03-25 22:31:49 +02:00
Tomaz Canabrava
96115be0c6
Unlock folder in case of error
2018-03-25 21:54:08 +02:00
Roeland Jago Douma
4c40789dca
Merge pull request #140 from nextcloud/appimage_drone_bump
...
Bump AppImage Drone
2018-03-23 15:36:33 +01:00
Roeland Jago Douma
a2815dac12
Merge pull request #224 from nextcloud/fix-documentation-cmake
...
Remove configure_file for non-existing documentation config file
2018-03-23 15:36:13 +01:00
Julius Härtl
16f53da9ae
Remove configure_file for non-existing documentation config file
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-03-22 19:30:05 +01:00
Camila Ayres
08b33c6f4b
Merge pull request #197 from nextcloud/fix-notifications
...
Improves notifications:
- Display the actual response text from the notification API in the popups.
- Do not display sync activities messages like how many files were downloaded, only errors.
- Make the notifications section above the activity feed also clickable. e.g open the call, the file that was shared, open the calendar event etc
- Changes "Show desktop notifications" setting to "Show server notifications"
- Show notifications on startup and then show only NEW notifications: uses If-None-Match check to only retrieve notifications once there are new notifications.
2018-03-13 13:30:44 +01:00
Camila Ayres
eb3b3f02a0
Merge pull request #195 from nextcloud/apps-external-sites-menu
...
Adds apps and external sites to menu.
2018-03-09 11:48:14 +01:00
Camila San
11d178ce1d
Adds absolute=true param to navigation/apps request.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-03-03 23:11:11 +01:00
Camila San
2e4472a4db
Enables server notifications by default.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-03-03 22:44:24 +01:00
Camila San
3c778980df
Makes sure JsonApiJob::finished won't throw a JSON error when status code is 304.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-03-03 22:24:16 +01:00
Camila San
621596f45a
Saves notifications ETag response header to use to request only new notifications.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-03-01 22:19:04 +01:00
Camila Ayres
cb5bc61a44
Merge pull request #163 from nextcloud/edit-system-exclude-list
...
Edit system exclude list.
2018-03-01 19:32:18 +01:00
Camila San
d42401e36a
Changes notifications api endpoint to v2.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-03-01 15:20:36 +01:00
Camila San
6bf9f65fd3
Only notify users of new notifications and only shows them all on startup.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-27 23:05:18 +01:00
Camila San
56709f3cff
Removes string 'Created' from notifications time.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-26 12:56:02 +01:00
Camila San
112c5e10b6
Removes Server Activities option from General settings.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-26 12:02:34 +01:00
Camila San
09a92a518a
Align text and changes spacing in notification widget.
2018-02-26 00:03:29 +01:00
Camila San
0f9d8e15a0
Only uses 'More information' text in button for notification link.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-26 00:02:09 +01:00
Camila San
44f299eba2
Removes debug messages.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-26 00:00:42 +01:00
Camila San
d71438f181
Adds host and scheme to activity link so it can be opened in the
...
browser.
- Removes debug messages.
- Removes Activity data _appName - not used anymore.
Signed-off-by: Camila San <hello@camila.codes >
2018-02-25 23:58:28 +01:00
Camila San
71f4760215
Do not display user account when there is only one user in popup message.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-25 23:57:44 +01:00
Camila San
4a6a8ca6c6
Removes _appName from Activity data.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-25 23:56:54 +01:00
Camila San
e33d2bf7f7
Removes (s) from time strings.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-25 23:55:04 +01:00
Camila San
4c79059146
Changes notification icon bell size.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-25 23:54:04 +01:00
Daniel Hansson
eec728eab8
Merge pull request #196 from ivaradi/master
...
Recommends relation to libgnome-keyring0
2018-02-24 21:46:09 +01:00
Daniel Hansson
d21ea9ed10
Merge pull request #174 from ivaradi/correct-dolphin-plugin-path
...
Dolphin plugin path correction
2018-02-24 21:45:47 +01:00
István Váradi
99add9f00d
Recommend libgnome-keyring0 on Debian too
2018-02-24 10:33:19 +01:00
István Váradi
0b3129f366
Added a Recommends relation to libgnome-keyring0
2018-02-24 10:19:01 +01:00
Camila San
1a0edc1cd0
Sync activities notifications are never shown unless there is an error. Server activities and notifications are off by default.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-23 12:08:37 +01:00
Camila San
99d8d050c2
Compares account menu with the account associated with the action to make sure apps is added to the right position.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-22 20:10:22 +01:00
Camila San
4ffff7454e
Refactores code and displays nav. apps before Pause/Unpause folders sync.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-21 18:49:12 +01:00
Camila San
9acb30ecb2
Refactores code to fetch and display sub menu with list from navigation/apps endpoint.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-20 19:41:08 +01:00
Camila San
61062f9809
Adds ocsnavigationapps files to CMakeslists.txt.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-20 19:33:25 +01:00
Camila San
fb080f08ec
Uses OcsNavigationAppsJob instead of OcsAppsJob and OcsExternalSitesJob in OwncloudGui.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 20:53:12 +01:00
Camila San
c9bc20c63d
Creates navigation/apps API call class OcsNavigationAppsJob.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 20:51:56 +01:00
Camila San
f107b3348c
Removes external sites/apps configuration from general settings.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 20:49:55 +01:00
Camila San
00cfbe39be
Removes external sites/apps configuration from config file.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 20:49:13 +01:00
Camila San
9f559c8e00
Retrieves list of apps and displays it if 'show apps' checkbox is checked in the settings.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:33 +01:00
Camila San
bf77dbac73
Adds checkbox 'showApps' to the general settings form.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:33 +01:00
Camila San
e29953bc11
Adds show apps option to the config file.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:33 +01:00
Camila San
8ada9d0471
List apps for each user in the tray main menu.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:33 +01:00
Camila San
08769b2803
Adds OcsAppsJob to retrieve apps enabled for the user.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:33 +01:00
Camila San
89d743396a
Fixes class name in comments and in ifndef.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:33 +01:00
Camila San
649f3ff904
Changes response parsing for the new request.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:32 +01:00
Camila San
9f0c154e68
Fixes request url - uses the one for all users.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:32 +01:00
Camila San
f48a94ba71
Saves 'show external sites list' option to the config file.
...
Uses option to toggle display of external sites list in the main menu.
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:32 +01:00
Camila San
ec428786ac
Adds checkbox to toggle display of external sites list in the menu.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:32 +01:00
Camila San
69f3468ec0
Lists external sites for each user in the main menu.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:32 +01:00
Camila San
8408851cee
Adds OCS External Sites Job to retrieve it from the server.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-19 19:59:19 +01:00
Tomaz Canabrava
7da0764b8d
Don't class what's not a class
2018-02-18 01:23:59 +01:00
Tomaz Canabrava
176a42a062
Return the error reported by openssl
2018-02-18 01:13:23 +01:00
Tomaz Canabrava
5faeca1b82
Move BIO2ByteArray to annonymous namespace
...
This has no use outside of the clientsidenecryption.cpp
2018-02-18 01:04:44 +01:00
Camila San
32e29fb849
Doesn't open the file manager when there isn't a file associated with the Activity.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-16 19:17:22 +01:00
Camila San
20cf4ed642
Improves Notification Widget UI.
...
- Changes spacing.
- Removes QFrame.
- Changes icon size.
Signed-off-by: Camila San <hello@camila.codes >
2018-02-16 18:04:44 +01:00
Camila San
ab7185a6c7
Changes notification text in the checkboxes and adds tooltips with explanation about it.
...
- Changes the configuration name in ConfigFile and GeneralSettings
accordingly with the new text.
- Makes sure the user sees error and conflict messages even if the
setting is disabled.
Signed-off-by: Camila San <hello@camila.codes >
2018-02-15 20:21:35 +01:00
Camila San
bfc7aa16c6
Adds option to toggle display of Sync and Activity notifications.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-14 20:38:15 +01:00
Camila San
b24751b099
Adds button to open notification in the browser - to update something, join a call, etc.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-14 19:22:08 +01:00
Camila San
a7dd3a7da1
Displays the actual notification subject in the system tray messages.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-12 22:16:46 +01:00
Daniel Nicoletti
99117078f3
Remove table for e2e and add an e2eMangledName column ( #169 )
...
If the code was not complex enough syncing two tables
already started to give UNIQUE constrains errors on
simple sync operations, this also adds initial support
remote delete of an encrypted file
2018-02-12 12:50:51 +01:00
Roeland Jago Douma
1eb7ba72f0
Use standardized filename
...
See https://github.com/nextcloud/end_to_end_encryption_rfc/issues/13
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-02-09 11:40:06 +01:00
István Váradi
2cc670453a
A separate Dolphin client install file is not required for Bionic
2018-02-08 17:19:13 +01:00
István Váradi
22153cf912
KDE_INSTALL_USE_QT_SYS_PATHS turned on so that the plugin is installed to the correct directory on Xenial too
2018-02-08 17:18:18 +01:00
Roeland Jago Douma
0743c63c81
Merge pull request #114 from ivaradi/debian-build
...
Moved Debian build to Drone
2018-02-06 08:18:00 +01:00
István Váradi
7216d05766
The Debian build script needs the history to generate logs and the tags to be able to determine the version
2018-02-02 19:11:10 +01:00
István Váradi
b11661f4c0
Reinstated the check for being on the master branch to enable uploading the packages
2018-02-02 18:57:51 +01:00
Daniel Nicoletti
080c5ea678
Better explanation for encryption passphrase
...
FIXES : #149
2018-02-02 17:27:58 +01:00
Camila San
2545017819
Refactores code.
...
- Renames function from populateTableReadOnlyValues to setupTableReadOnlyItems.
- Use a const to define the number of read only rows.
- Removes enable/disable remove all button checks from where it was not
needed.
Signed-off-by: Camila San <hello@camila.codes >
2018-02-02 16:01:53 +01:00
Camila San
73b7540468
Enable/disable remove all button depending on the number of rows.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-02 15:50:17 +01:00
Camila San
c29d3b7e0b
Adds button to remove all items from ignore list table.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-02 14:40:30 +01:00
Camila San
4855e3242c
Restores correctly default system values for ignore files list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-02 14:15:45 +01:00
Camila San
bf76b596af
Allows deletion of pre configured patterns in the ignore list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-01 22:36:40 +01:00
Camila San
6dd349a8a6
Adds button to restore default patterns in the ignore list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-02-01 22:35:38 +01:00
István Váradi
4c74f29b5f
Removed yakkety and zesty, added bionic
2018-02-01 20:07:40 +01:00
István Váradi
549abc8c90
Build Xenial with Qt 5.5
2018-02-01 20:06:18 +01:00
István Váradi
ed9509f31f
Merge branch 'master' into debian-build
2018-02-01 18:44:55 +01:00
Morris Jobke
b9a7e5622d
Merge pull request #141 from nextcloud/documentation
...
Documentation update
2018-02-01 16:14:44 +01:00
Morris Jobke
5db7f60179
Fix CMake failure
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-02-01 16:08:33 +01:00
Morris Jobke
9c43edcad6
Run documentation tests in seperate job
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-02-01 15:58:51 +01:00
Morris Jobke
545a406997
Latest refinements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-02-01 15:57:37 +01:00
Marius Blüm
d75b32156f
Brand Screenshots
...
Signed-off-by: Marius Blüm <marius@lineone.io >
2018-02-01 14:23:38 +01:00
Camila San
f7697b0584
Enables removing patterns from ignored files list.
...
Signed-off-by: Camila San <hello@camila.codes >
2018-01-31 22:59:51 +01:00
István Váradi
d0896f0c82
Removed some debug printouts and dead code and added Bionic in place of Zesty
2018-01-31 20:04:33 +01:00
István Váradi
4d396c645e
Why does Drone sometimes not use the new changes?
2018-01-31 19:58:24 +01:00
István Váradi
ebaae773f6
Trying a different strategy to sign the package files
2018-01-31 19:53:50 +01:00
István Váradi
88c03a5858
Stepped the version of the build image
2018-01-30 19:22:46 +01:00
István Váradi
11a540114e
Hiding the keys from the output
2018-01-30 19:22:26 +01:00
Roeland Jago Douma
89b2df62c5
Merge pull request #144 from nextcloud/win_images
...
Use Nextcloud images for windows installer
2018-01-30 14:23:32 +01:00
Julius Härtl
da2a1c25d5
Add drone build for documentation
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-01-30 14:23:10 +01:00
Roeland Jago Douma
df123bb3bc
Use NC windows installer images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-30 11:55:16 +01:00
Roeland Jago Douma
c04d1f1f69
Make different program so it doesn't mess with existing config
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-30 11:53:52 +01:00
Roeland Jago Douma
f8d805d78b
Use NC windows installer images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-30 11:25:46 +01:00
Roeland Jago Douma
d85c2bf025
Fix building on windows
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-30 11:10:03 +01:00
Roeland Jago Douma
296f46356e
If the metadata is empty we should store (and not update).
...
Android only creates the metadata file when the first encrypted file is
added. We assumed it would be there.
This hacky code makes us store the metadata if there wasn't any yet.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-29 22:04:50 +01:00
Tomaz Canabrava
dcc9ac7d2e
[Buildfix] Fix build from last merge
2018-01-29 14:17:52 +01:00
Tomaz Canabrava
d24a1e542e
Merge branch 'master' into clientSideEncryptionV3
2018-01-29 14:06:12 +01:00
Morris Jobke
a7e1003c41
Add shared_assets
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-01-29 01:19:51 +01:00
Morris Jobke
fe102f359c
Build current documentation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-01-29 01:19:47 +01:00
Tomaz Canabrava
f4a50e88f5
[CSE] Ignore renames for downloaded files.
...
- TODO: Fix the incorrect "filename has been removed" popup.
The file is not removed, just the popup shows.
2018-01-28 23:59:53 +01:00
Tomaz Canabrava
682bb2ad43
[CSE] Save the encrypted name relation on downloads
2018-01-28 23:50:12 +01:00
Tomaz Canabrava
d38e5e1529
[CSE] Bypass rename if it's e2e
...
The client tracks the files in server and locally, but the
names of the files differ in the server, but we do *not*
wanna rename the files to the server one, we wanna
keep it as is if it's an encrypted file.
2018-01-28 23:48:51 +01:00
Tomaz Canabrava
7b123650da
[CSE] Search for name, not mangled name.
2018-01-28 23:48:25 +01:00
Tomaz Canabrava
0c94142c97
[CSE] More debug output
2018-01-28 23:47:58 +01:00
Tomaz Canabrava
e8849a2cf9
[CSE] Save the relation of the file / encrypted file names on the db
2018-01-28 22:26:07 +01:00
Roeland Jago Douma
11946d9ef8
Bump
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-28 20:21:12 +01:00
Roeland Jago Douma
4ee1f1fe1a
Foo
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-28 20:19:37 +01:00
Roeland Jago Douma
3c084bb6eb
Bump drone image
...
* Bump to 16.04 since 14.04 doesn't auto build here due to openssl fu
* No more gcc7 since gcc5 is new enough
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-28 20:10:04 +01:00
Roeland Jago Douma
45eefb27cf
Bump AppImage Drone
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-28 20:04:42 +01:00
Tomaz Canabrava
e9a7a56359
[CSE] Store the encrypted file name on the SyncFilePtr
2018-01-28 18:37:01 +01:00
Tomaz Canabrava
a003d216a5
[CSE] Implementation of the setE2eRelation
...
This call creates a new entry on the database for e2e.
2018-01-28 18:05:28 +01:00
Tomaz Canabrava
32eaaa0601
[CSE] GetMangledName implementation
2018-01-28 17:50:10 +01:00
Tomaz Canabrava
be817748f8
[CSE] Reset the new Queries on close
2018-01-28 17:46:20 +01:00
Tomaz Canabrava
b909bb6977
[CSE] Change the Database to handle Encrypted Files
...
Create a table to hold the information between the
real file name and the fake file name
2018-01-28 16:41:07 +01:00
István Váradi
72f629a7dc
Added secrets to .drone.yml
2018-01-27 08:50:28 +01:00
István Váradi
9ad6f1485e
Printing environment
2018-01-26 12:54:35 +01:00
István Váradi
459b6ab1e7
Trigger another build in the hope that it will see the previous commit
2018-01-26 12:41:27 +01:00
István Váradi
85140d3784
Reverting to upper-case key variable names
2018-01-26 12:28:14 +01:00
Roeland Jago Douma
040507fce6
Merge pull request #135 from nextcloud/oc_up
...
Merge upstream changes
2018-01-25 20:31:35 +01:00
István Váradi
7a1f32894b
Try if the variables are lower-case
2018-01-25 17:21:02 +01:00
István Váradi
1acd7db5f8
Dummy commit to trigger a new build
2018-01-25 17:16:59 +01:00
Roeland Jago Douma
e2e99da446
Bump appimage drone image
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-25 14:31:14 +01:00
Julius Härtl
bcb9553925
Use Qt5DBus_FOUND instead of the old WITH_DBUS
...
WITH_DBUS was removed in 257d8142b1
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-01-25 14:18:03 +01:00
Roeland Jago Douma
aa7e47f525
Fix new icon naming
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-25 12:19:51 +01:00
Roeland Jago Douma
48bce4c6b0
Merge remote-tracking branch 'oc/master' into oc_up
2018-01-25 11:17:04 +01:00
Roeland Jago Douma
84b26e0d4d
Merge pull request #133 from nextcloud/fix-notification-dismiss-button
...
Uses QString::number to get a string equivalent of the notification_id number
2018-01-24 19:29:21 +01:00
Julius Härtl
3d162745af
Merge pull request #131 from nextcloud/nextcloud_subdir
...
If status.php fails check <server>/nextcloud/status.php
2018-01-24 17:59:48 +01:00
Camila San
7a69e19e4d
Uses QString::number to get a string equivalent of the notification_id number.
...
This fixes the bug reported #117 .
Signed-off-by: Camila San <hello@camila.codes >
2018-01-24 17:29:45 +01:00
Olivier Goffart
02988229b1
FolderStatusModel: don't use deprecated QModelIndex::child
...
Was deprecated in Qt 5.8.
(IMHO this show that child can be usefull and I am not sure the
deprecation was justified)
2018-01-24 10:23:03 +01:00
Roeland Jago Douma
4892b0ec43
Properly fill EncryptedFile
...
* Add a mimetype (mobile clients need this)
* Add the tag unencoded as we encode it when we send the metadata
already
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-23 21:31:00 +01:00
Roeland Jago Douma
21d55c3321
No sharing in metadata yet and PEM as PKCS#8
...
* Don't store the metadata yet this crashes android
- Yes android should be fixed but for now this is quicker ;)
* QSslKey exports PEM as PKCS#1
- This is not handled properly on android so use PKCS#8 helper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-23 21:02:52 +01:00
István Váradi
5e7f72b8df
Attempt to pass the key in the environment
2018-01-23 19:51:13 +01:00
István Váradi
ed9300f924
Commit to trigger build
2018-01-23 19:42:34 +01:00
Olivier Goffart
72b9beb79c
Merge remote-tracking branch 'origin/2.4'
...
Conflicts:
shell_integration/nautilus/syncstate.py
2018-01-23 14:08:15 +01:00
Olivier Goffart
883080b557
Windows shell extension: port to the new protocol
2018-01-23 14:02:56 +01:00
Christian Kamm
ebfac84c69
Shell integration: Make nautilus work with multiselections
...
Previously no menu would ever be shown if more than one file is
selected. Now the GET_MENU_ITEMS command is sent with all selected files
as an argument - similar to what is done for the dolphin integration.
2018-01-23 14:02:56 +01:00
Christian Kamm
3c2622d2de
Shell integration: Update nautilus for GET_MENU_ITEMS
2018-01-23 14:02:56 +01:00
Olivier Goffart
982c591ec9
SocketApi: add a way to disable menu entries
2018-01-23 14:02:56 +01:00
Olivier Goffart
1782ae3c08
SocketAPI: Make it easier to add or remove item in the action menu
...
By making it dynamic.
So far only the dolphin shell extension have been ported
2018-01-23 14:02:56 +01:00
Roeland Jago Douma
7ce009ef49
If status.php fails check <server>/nextcloud/status.php
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-23 13:43:44 +01:00
Christian Kamm
72363155d8
Nautilus integration: Work with python2 and python3
2018-01-23 12:30:58 +01:00
Olivier Goffart
f254ee3211
Nautilus shell integration: Port to Python 3
2018-01-23 12:30:58 +01:00
Christian Kamm
59f2e0634e
Protocol: Correct sorting by size #6326
...
Previously we were sorting by size string, where
"6 MB" < "3 KB".
2018-01-23 12:02:16 +01:00
Christian Kamm
32bb1e6763
ProtocolItem: Use accessors over magic numbers
2018-01-23 12:02:16 +01:00
Christian Kamm
497b327d43
ShareLinkWidget: Remove outdated signal connection
...
Also convert the others to the new syntax to avoid similar errors in the
future.
2018-01-23 12:01:22 +01:00
Christian Kamm
d831369f86
Protocol: Remove entries for auto resolved conflicts #6316
2018-01-23 12:01:22 +01:00
Roeland Jago Douma
a2b8724adf
Hacky way to drop duplicates (we should really use the fileid!)
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-23 11:58:05 +01:00
Roeland Jago Douma
bb85e2ab2c
Reuse existing EncryptedFile
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-23 11:36:15 +01:00
Jenkins for ownCloud
c1a1e55207
[tx-robot] updated from transifex
2018-01-23 02:18:36 +01:00
Olivier Goffart
c3dbb20ce3
Logger: --logdebug only show owncloud's debug message
...
Recent Qt version show way too many debug messages, spamming the console.
So filter only messages that comes from the client.
2018-01-22 21:13:15 +01:00
Roeland Jago Douma
33beb7aade
Don't generate values after we use them
...
* Pregerenate IV
* Pregenerate key
* Pregenerate filename
TODO:
- Reuse existing file entries and update (we might need logic in the
metadatahandling to do this properly).
2018-01-22 15:24:54 +01:00
Tomaz Canabrava
cae6bbc853
[CSE] Start the download process
2018-01-22 14:08:32 +01:00
Christian Kamm
e2b89c5afe
TextXmlParse: Add truncated-xml testcase #6317
2018-01-22 14:05:08 +01:00
Jenkins for ownCloud
ba4712c922
[tx-robot] updated from transifex
2018-01-22 02:18:54 +01:00
Tomaz Canabrava
cf2fa2ea35
[CSE] Get the tag of the encrypted file to feed the metadata
...
Also, change the logging cattegory
2018-01-21 21:59:19 +01:00
Tomaz Canabrava
5d6817e165
[CSE] Save the tag while encrypting.
2018-01-21 21:49:24 +01:00
Tomaz Canabrava
261cedce3f
[CSE] Do not quit if encryption fails
...
It's much more reasonable to return failure and handle it.
2018-01-21 21:40:53 +01:00
Tomaz Canabrava
2d872f2a8d
[CSE] Add missing files
2018-01-21 21:26:05 +01:00
Tomaz Canabrava
009562da1e
[CSE] Remove lambas with lambdas
...
It's hard to reason with lambdas with lambdas, so transform
them into actuall signal / slot calls.
2018-01-21 21:25:06 +01:00
Tomaz Canabrava
d5a76ea70d
[CSE] Remove the DecryptionJob
...
Transform it into an Static function - it was blocking anyway
and this way it's easier to transform it into a thread in the
future.
2018-01-21 21:24:02 +01:00
Tomaz Canabrava
4a2d0ab9e9
[CSE] Move code to display minemonic out of the libsync
...
The libsync should not contain Qt Widget related code.
2018-01-21 19:50:40 +01:00
Jenkins for ownCloud
a19eb59461
[tx-robot] updated from transifex
2018-01-21 02:18:35 +01:00
Jenkins for ownCloud
484ec95596
[tx-robot] updated from transifex
2018-01-20 02:18:50 +01:00
Olivier Goffart
5a97ddde5a
Merge remote-tracking branch 'origin/2.4'
...
Conflicts:
src/gui/updater/updater.cpp
2018-01-19 13:41:29 +01:00
Olivier Goffart
b8539eb329
Get rid of the StopWatch in the PropagateUpload job
...
For issue #6318
The StopWatch is using memory, and we are not really using it.
2018-01-19 13:37:48 +01:00
Christian Kamm
b9c7aa8df3
Sync: Deal with file/folder conflicts #6312
...
Previously conflicts with a different type on both ends lead to sync
errors. Now they are handled in the expected way: the local item gets
renamed and the remote item gets propagated downwards.
This also adds a unittest for the TYPE_CHANGE case. That one looks like
parts of it might be unified with CONFLICT cases.
2018-01-19 09:47:49 +01:00
Jenkins for ownCloud
6f5b3eb4d7
[tx-robot] updated from transifex
2018-01-19 02:18:35 +01:00
Roeland Jago Douma
6d613fb4d5
Quick and dirty way of showing the mnemonic for now
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-18 22:10:55 +01:00
Dominik Schmidt
127e675838
Merge pull request #6310 from owncloud/appveyor
...
Enable appveyor builds
2018-01-18 18:08:09 +01:00
Christian Kamm
c1b5412c16
Exclude regex: Use named captures
...
My benchmarks show no performance difference.
2018-01-18 10:24:24 +01:00
Dominik Schmidt
217c6bbcaf
Add AppVeyor badge
2018-01-18 09:46:06 +01:00
Jenkins for ownCloud
a32b3e565b
[tx-robot] updated from transifex
2018-01-18 02:18:38 +01:00
István Váradi
3ea3699cdd
The source packages are temporarily uploaded even when not on the master branch
2018-01-17 19:24:02 +01:00
Olivier Goffart
926609bd74
Partially revert "shell_integration/dolphin: Silence some warnings"
...
This partially reverts commit 1c721e9422 .
This caused the overlay plugin to be installed at the wrong place
because the kcoreaddons_add_plugin macto still use deprecated
${PLUGIN_INSTALL_DIR}.
I guess we'll have to live with the warnings.
2018-01-17 17:34:27 +01:00
Dominik Schmidt
486ccaff56
Enable tests in appveyor builds
2018-01-17 16:25:03 +01:00
Dominik Schmidt
e0cc93c047
Enable appveyor builds
2018-01-17 16:21:09 +01:00
Christian Kamm
4337e8532e
Exclude matching: Speedup the full-path traversal case
...
Previously we'd use the full regex when the bname triggered a full-path
matching to take place. Now we have a simplified full-traversal regex
for this case that can be significantly faster to apply.
Triggered by #5017 but doesn't actually solve it.
2018-01-17 15:05:50 +01:00
Christian Kamm
a8a6f82270
Link shares: Change default share name #6298
...
There's a 64 character limit and we don't want to accidentally exceed
it.
Eventually there might be server API for default share name generation.
See owncloud/core#29913
2018-01-17 15:03:11 +01:00
Dominik Schmidt
4895b848c8
Merge pull request #6308 from dschmidt/fix-linux-icons
...
Fix Linux icons
2018-01-17 12:53:32 +01:00
Dominik Schmidt
fe3c68b9dd
Fix Linux icons
2018-01-17 12:18:31 +01:00
Jenkins for ownCloud
24d6fda360
[tx-robot] updated from transifex
2018-01-17 02:18:35 +01:00
István Váradi
f4fcf46a1c
Utilizing some Drone environment variables
2018-01-16 19:36:36 +01:00
Roeland Jago Douma
4e7c033ae5
Merge pull request #121 from nextcloud/removes-logout-login-all-accounts
...
Removes 'Log in to all accounts' and 'Log out to all accounts' from the primary client menu.
2018-01-16 09:20:47 +01:00
Jenkins for ownCloud
d4106b9a88
[tx-robot] updated from transifex
2018-01-16 02:18:35 +01:00
Olivier Goffart
2a14ba5582
Folder: remove declaration of non-existing method
2018-01-15 15:43:13 +01:00
Olivier Goffart
2a842a5745
Application: remove declaration of non-existing functions
2018-01-15 15:07:09 +01:00
Olivier Goffart
cfe9909560
admin/linux/Dockerfile: Add comments
2018-01-15 13:56:35 +01:00
Olivier Goffart
8331f04b5b
Merge pull request #6244 from owncloud/cleanuo
...
Modernize makefiles and remove dead code
2018-01-15 13:49:57 +01:00
Camila Ayres
cd36f73f6b
Removes 'Log in to all accounts' and 'Log out to all accounts' from main menu.
...
This is not an often used option and it should be fine if this can only be done
from within the settings dialog.
Signed-off-by: Camila San <hello@camila.codes >
2018-01-15 11:48:27 +01:00
Olivier Goffart
d0713d018c
client_de.ts: Fix spacing in a translation
...
Issue #6303
2018-01-15 11:29:08 +01:00
Roeland Jago Douma
5722d29e42
Double encode the metadatakeys
...
This is required by a misunderstanding of the RFC.
You need to resetup your test user.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-15 11:26:06 +01:00
Jürgen Weigert
a33fc2a0db
Update updater.cpp
...
deprecate suffix nightly, promote suffix daily
2018-01-15 11:25:10 +01:00
Jenkins for ownCloud
ca200e788e
[tx-robot] updated from transifex
2018-01-15 02:18:34 +01:00
Dominik Schmidt
7839c4d4e1
Revert "Disable stack protection for mingw win32 builds in 2.4"
...
This reverts commit 298f1ab570 .
We're shipping libssp-0.dll now with mingw builds. We would
have enough time to test this for 2.5.0 now anyway, but we
also will most likely switch to MSVC for that release.
2018-01-14 14:39:29 +01:00
Jenkins for ownCloud
c454d626b6
[tx-robot] updated from transifex
2018-01-14 02:18:36 +01:00
Dominik Schmidt
969d90d15b
Fix UIC detection in windows cross env
2018-01-14 00:57:40 +01:00
Dominik Schmidt
d8a279c671
Fix windows cross build of the updater and bump libcrashreporter-qt revision
2018-01-14 00:45:02 +01:00
Dominik Schmidt
6d56f30d9b
Fix incorrect target_include_directories usage for crash reporter
2018-01-13 23:49:58 +01:00
Dominik Schmidt
86ea5876cd
Use standard png2ico in our cross env too
2018-01-13 23:28:52 +01:00
Dominik Schmidt
bb8468c627
Add Linux CI Dockerfile
2018-01-13 23:28:18 +01:00
Dominik Schmidt
fc62e9e9d9
Fix .def and .rc files not being compiled into windows shell extensions
2018-01-13 21:01:09 +01:00
Dominik Schmidt
15967b1219
Install all dlls to BINDIR so craft does not ignore them
2018-01-13 13:58:17 +01:00
Dominik Schmidt
0656c77da8
Set CMAKE_CXX_STANDARD to 14
2018-01-13 13:58:17 +01:00
Dominik Schmidt
81c20352e1
Use new ECMAddAppIcon macro for application icons.
...
cmake/modules/ECMAddAppIcon.cmake is heavily patched to support sidebar icons, OUTFILE_BASE parameter and to not include 64 and 64@2x icons on macOS which are not supported. All changes are made in a way that we can upstream this.
2018-01-13 13:58:17 +01:00
Dominik Schmidt
4e52ee9ebd
Build Explorer extension if building with MSVC
2018-01-13 13:58:17 +01:00
Dominik Schmidt
6ee87a77cc
Fix macOS updater build without deprecated Qt apis
2018-01-13 13:58:17 +01:00
Dominik Schmidt
539d6fd92e
Link client against QtMacExtras as it bundles qtmacgoodies
2018-01-13 13:58:17 +01:00
Dominik Schmidt
da98e2aa28
Fix building sqlite on macOS and Windows
2018-01-13 13:58:17 +01:00
Dominik Schmidt
1f9763eda9
Package libssp-0.dll in NSIS installer.
...
It's needed since 586fd346ea activated stack-protector-strong
2018-01-13 13:58:17 +01:00
Dominik Schmidt
cbf470f17b
Fix csync installation on windows
2018-01-13 13:58:17 +01:00
Dominik Schmidt
1f12d6344b
Fix sqlite compilation (on OSX)
2018-01-13 13:58:17 +01:00
Olivier Goffart
437d45981e
Remove unused c_strlist
2018-01-13 13:58:17 +01:00
Olivier Goffart
3ae327ea8e
Modernize out CMakeLists.txt
...
Mainly uses target_include_directories instead of include_directories
so libraries public include directory get automatically added when adding
the target in target_link_library
2018-01-13 13:58:17 +01:00
Olivier Goffart
1c721e9422
shell_integration/dolphin: Silence some warnings
2018-01-13 13:58:17 +01:00
Olivier Goffart
5d0aa5f039
Remove unused c_path
2018-01-13 13:58:17 +01:00
Olivier Goffart
41798cef18
Csync: remove some unused build system stuff
2018-01-13 13:58:17 +01:00
Olivier Goffart
1c11778693
Remove the unusued csync_file_locked_or_open test in csync_reconcile
...
It is unused. Also remove the corresponding error code
2018-01-13 13:58:17 +01:00
Olivier Goffart
3ddd4b6f16
Get rid of csync_log
...
We use Qt's debugging code everywhere
2018-01-13 13:58:17 +01:00
Olivier Goffart
d948ed11a1
Csync: use QElapsedTimer and qCInfo instead of CSYNC_LOG and its own csync time function
...
This allow to remove all the csync time manipulation routne which are now unused
2018-01-13 13:58:17 +01:00
Olivier Goffart
257d8142b1
Build system: Get rid of QtVersionAbstraction.cmake
...
Use modern cmake with target_link_libraries and Qt5:: that
automatically add the include path and compile flags
2018-01-13 13:58:17 +01:00
Olivier Goffart
48c55b7d29
csync/std: don't build in a separate library
...
There is no need to create a static library for the csync/std file, just
put everything together in csync
2018-01-13 13:58:17 +01:00
Olivier Goffart
776bbbf7b1
Don't include sqlite3.h from headers
...
So that sqlite is not part of the public interface of csync
(and that the sqlite include path don't need to be passed when compiling
libsync or gui)
2018-01-13 13:58:17 +01:00
Dominik Schmidt
f326bf371d
Merge pull request #6299 from dschmidt/linux-docker-ci
...
Use docker for Linux CI
2018-01-13 13:46:04 +01:00
Jenkins for ownCloud
4cf7ca4162
[tx-robot] updated from transifex
2018-01-13 02:18:33 +01:00
István Váradi
9eb395efd1
The Debian Docker image reference is fixed
2018-01-12 19:55:56 +01:00
Roeland Jago Douma
99aebf292c
Yet another drone image
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-12 19:36:09 +01:00
Dominik Schmidt
01f3b82ea5
Move pulling docker images to their own stages
2018-01-12 17:19:22 +01:00
Roeland Jago Douma
d1c84fd859
Bump drone docer used for appimage
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-01-12 15:21:30 +01:00
Jenkins for ownCloud
c22e3aaa4b
[tx-robot] updated from transifex
2018-01-12 02:19:52 +01:00
Dominik Schmidt
dbf15fb8dc
Make setLaunchOnStartup debug output more meaningful
2018-01-11 16:11:23 +01:00
Dominik Schmidt
a253129fd6
Fix running tests until #6210 is fixed
2018-01-11 16:11:06 +01:00
Dominik Schmidt
a8ba3ee9e1
Use docker for Linux CI
2018-01-11 16:10:31 +01:00
István Váradi
66c745e133
Moved Debian build to Drone
2018-01-11 11:34:41 +01:00
Olivier Goffart
9613f6437d
Merge remote-tracking branch 'origin/2.4'
...
Conflicts:
src/libsync/networkjobs.cpp
2018-01-11 10:46:50 +01:00
Jürgen Weigert
9dc765142c
Update updater.cpp
...
depricate suffix nightly, promote suffix daily
2018-01-10 16:19:08 +01:00
Christian Kamm
7d70f1becb
Ignore files that can't be encoded for the filesystem
...
There's an upstream bug where QTextCodec::canEncode returns true even
though it should be false. This works around that issue and adds a test.
The original work was done in 72809ef5b1
See #6287 , #5676 , #5719
See https://bugreports.qt.io/browse/QTBUG-6925
2018-01-10 13:36:00 +01:00
Jenkins for ownCloud
a476c5420a
[tx-robot] updated from transifex
2018-01-10 02:18:51 +01:00
Christian Kamm
cdd8d10940
Fix resizing crash when currentPage() is null
...
Sentry:
https://sentry.io/owncloud/desktop-win-and-mac/issues/425331770/
2018-01-09 13:54:11 +01:00
Christian Kamm
883deb1c5d
Fix potential crash in Composite job destruction
...
Sentry:
https://sentry.io/owncloud/desktop-win-and-mac/issues/427476987/
2018-01-09 13:53:57 +01:00
Christian Kamm
e389fcaecb
Avatars: Use old location for servers <10 #6279
2018-01-09 11:34:56 +01:00
Christian Kamm
585d2b20bd
Exclude regex: Restore old matching on Windows #6245
...
Unfortunately matching behaved differently on Windows. This patch
restores the previous matching behavior but still uses the new regular
expression based matching.
Further work will hopefully unify the behavior between platforms without
breaking backwards compatibility.
2018-01-09 11:09:05 +01:00
Jenkins for ownCloud
9078d9cfab
[tx-robot] updated from transifex
2018-01-09 02:18:35 +01:00
Daniel Nicoletti
a7ee1a95a6
Download and decrypt file if parent folder is marked as encrypted
2018-01-08 21:08:31 +01:00
Daniel Nicoletti
3abbbab6a0
Faster way to detecting CSE capability
2018-01-08 21:08:31 +01:00
Christian Kamm
51b662fdfe
Minor logging additions
...
- Clearly mark local and remote discovery start, to make this searchable
even without --logdebug.
- Promote two messages from debug to info: The 'N entries read from db'
message is useful and the 'read from db but ignored' message is rare
and surprising - if there's a bug there we want to see what happened in
the logs.
2018-01-08 09:36:30 +01:00
Jenkins for ownCloud
b6d74ad753
[tx-robot] updated from transifex
2018-01-08 02:18:35 +01:00
Jenkins for ownCloud
5656323434
[tx-robot] updated from transifex
2018-01-06 02:18:39 +01:00
Christian Kamm
81baebf113
owncloudcmd: Set proxy earlier #6281
...
In particular before the capability call.
Also warn if no proxy is set because the command line doesn't follow the
strict format requirements.
(cherry picked from commit d0e7f61db6 )
2018-01-05 10:26:55 +01:00
Christian Kamm
f7c884d4d1
owncloudcmd: Remove some dead code
...
(cherry picked from commit 0f8790d993 )
2018-01-05 10:26:53 +01:00
Christian Kamm
d0e7f61db6
owncloudcmd: Set proxy earlier #6281
...
In particular before the capability call.
Also warn if no proxy is set because the command line doesn't follow the
strict format requirements.
2018-01-05 10:23:29 +01:00
Christian Kamm
0f8790d993
owncloudcmd: Remove some dead code
2018-01-05 10:12:25 +01:00
Christian Kamm
86377aa37a
Folder: Remove unused 'dirty proxy' setting
2018-01-05 09:44:20 +01:00
Christian Kamm
3988f3ad77
GCC: Fix implicit-fallthrough warnings
2018-01-05 09:43:53 +01:00
Christian Kamm
7aa9af08c3
Issues: Speed up insertion and add hard upper limit #6272
...
Since sorting was enabled permanenty the list would be resorted with
each inserted issue. When inserting thousands of ignored files that
would make the whole ui freeze up.
Instead, sorting is disabled for inserts now and is reenabled after some
time has passed. That way users usually see the sorted view without the
lockups. Also, there's now a maximum of 50k issue entries.
2018-01-05 08:44:27 +01:00
Jenkins for ownCloud
15803d1837
[tx-robot] updated from transifex
2018-01-05 02:18:35 +01:00
Christian Kamm
ab9d6285c6
Proxy: Hostname validation and reconnection on setting change
...
Where 'validation' currently just means "check whether it's empty".
Code adapted from wiggiBe's original PR #6140
2018-01-04 14:30:24 +01:00
Jenkins for ownCloud
c0c10fd5f1
[tx-robot] updated from transifex
2018-01-04 02:18:34 +01:00
Jenkins for ownCloud
e2d4a38639
[tx-robot] updated from transifex
2018-01-03 02:18:34 +01:00
Jenkins for ownCloud
f89676d4bb
[tx-robot] updated from transifex
2018-01-02 02:18:36 +01:00
Jenkins for ownCloud
b9c167fc13
[tx-robot] updated from transifex
2018-01-01 02:18:34 +01:00
Jenkins for ownCloud
3bac06d6e5
[tx-robot] updated from transifex
2017-12-31 02:18:36 +01:00
Jenkins for ownCloud
504e11b5bb
[tx-robot] updated from transifex
2017-12-30 02:18:36 +01:00
Daniel Nicoletti
e2c895e61f
Fix encrypted file location on the server
2017-12-29 17:28:35 +01:00
Daniel Nicoletti
ca92c46970
Add category logging to PropagateUploadEncrypted
2017-12-29 17:28:35 +01:00
Daniel Nicoletti
50916bcda5
Mark ClientSideEncryption::isFolderEncrypted() as const
2017-12-29 17:28:35 +01:00
Daniel Nicoletti
c6491d50bb
Replace deprecated Qt API usage
2017-12-29 17:28:35 +01:00
Daniel Nicoletti
fdc96d3a4f
Fix deprecated use of QUrl::setQueryItems()
2017-12-29 17:28:35 +01:00
Daniel Nicoletti
e06e04ee93
Fix parsing list of encrypted folders
2017-12-29 17:28:35 +01:00
Tomaz Canabrava
7d68fa17e7
Merge pull request #107 from dantti/clientSideEncryptionV3
...
Prepend "nextcloud" for all logging categories
2017-12-29 11:52:40 +01:00
Jenkins for ownCloud
b80ba97154
[tx-robot] updated from transifex
2017-12-29 02:18:34 +01:00
Daniel Nicoletti
a63d34f870
Prepend "nextcloud" for all logging categories
...
Thus making easier to exclude logging from kio, qt
and only enable "nextcloud.*"
2017-12-28 17:33:10 -02:00
Tomaz Canabrava
c772857054
Merge pull request #106 from dantti/clientSideEncryptionV3
...
Fix URL in dialog that requests password
2017-12-28 13:08:33 +01:00
Daniel Nicoletti
c963259bfb
Fix URL in dialog that requests password
...
An URL that had base like "http://localhost/nextcloud/ "
would get the last slash '/' removed and then appended
with "index.php..." resulting in
http://localhost/nextcloudindex.php
2017-12-28 10:00:17 -02:00
Jenkins for ownCloud
e3e38f3eac
[tx-robot] updated from transifex
2017-12-28 02:18:36 +01:00
Jürgen Weigert
6e445033c7
OBS publishing details added
...
OBS has two pubishing swithces: one per package and one per project,
we always only switch per project! we have too many dependency packages to keep that in sync manually!
2017-12-27 12:37:02 +01:00
Jenkins for ownCloud
93c9f4316b
[tx-robot] updated from transifex
2017-12-27 02:18:35 +01:00
Jenkins for ownCloud
47a7000121
[tx-robot] updated from transifex
2017-12-26 02:18:36 +01:00
Jenkins for ownCloud
6c9026e330
[tx-robot] updated from transifex
2017-12-25 02:18:36 +01:00
Tomaz Canabrava
efc039863b
[CSE] Tons of debugs.
2017-12-24 17:08:04 +01:00
Tomaz Canabrava
da9f1c412d
[CSE] Remove debug
2017-12-24 16:36:57 +01:00
Tomaz Canabrava
06c34ed617
[CSE] Assorted fixes
...
- Unlock the folder even on error
- Use the correct name of the file for upload
2017-12-24 16:30:39 +01:00
Jenkins for ownCloud
d59c609a73
[tx-robot] updated from transifex
2017-12-24 02:18:35 +01:00
Jenkins for ownCloud
6ee48c8f15
[tx-robot] updated from transifex
2017-12-23 02:18:34 +01:00
Tomaz Canabrava
60ef722b60
[CSE] Update the metadata when a file is being uploaded.
2017-12-22 23:05:39 +01:00
Tomaz Canabrava
e70bf44aaf
[CSE] Fix the generation of the data for the update Metadata
2017-12-22 22:39:45 +01:00
Tomaz Canabrava
124a7253a4
[CSE] Create job to Update Metadata
2017-12-22 22:02:16 +01:00
Jenkins for ownCloud
6af823b36a
[tx-robot] updated from transifex
2017-12-22 02:18:56 +01:00
Olivier Goffart
a642d99d4b
Merge remote-tracking branch 'origin/2.4'
...
Conflicts:
VERSION.cmake
src/CMakeLists.txt
2017-12-21 12:51:01 +01:00
Roeland Jago Douma
65dfc47ac7
Set public key once certificate is retrieved
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-21 10:20:03 +01:00
Roeland Jago Douma
0dc7831336
Key is already base64 decoded
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-21 09:49:31 +01:00
Jenkins for ownCloud
8c7ea61623
[tx-robot] updated from transifex
2017-12-21 02:18:35 +01:00
Tomaz Canabrava
b72113a53d
[CSE] Prepare the beginning of the upload.
...
I still need to send the metadata.
2017-12-21 00:35:23 +01:00
Tomaz Canabrava
df5fd3fbe6
[CSE] More debug output, fix input file path
2017-12-21 00:00:27 +01:00
Tomaz Canabrava
7be5f0a736
[CSE] Update the finished signal
2017-12-20 23:36:49 +01:00
Tomaz Canabrava
d87648c99a
[CSE] Use the metadata as pointer.
2017-12-20 23:30:51 +01:00
Tomaz Canabrava
25d58ccd58
Revert "Store metadata keys as keys"
...
This commit broke decryption.
This reverts commit b9f094cd94 .
2017-12-20 23:16:42 +01:00
Tomaz Canabrava
dd0528037d
[CSE] Generate a random name for the temporary file
2017-12-20 23:09:28 +01:00
Tomaz Canabrava
7e83f0591b
[CSE] Create the Encrypted File on Disk
2017-12-20 22:32:38 +01:00
Tomaz Canabrava
3760b86e07
[CSE] Mobe fileEncryption to a static function
...
and I'll move all of those to a namespace latter.
2017-12-20 22:28:01 +01:00
Tomaz Canabrava
20198c5c7b
Merge branch 'clientSideEncryptionV3' of github.com:nextcloud/client into clientSideEncryptionV3
2017-12-20 22:11:46 +01:00
Roeland Jago Douma
3c301a8282
Add missing FolderMetadata functions
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 22:08:57 +01:00
Roeland Jago Douma
74bc9213c5
Generate encrypted metadata on the fly
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 22:04:26 +01:00
Tomaz Canabrava
679bb1f18e
[CSE] Expose EncryptionHelper
2017-12-20 21:33:25 +01:00
Tomaz Canabrava
14b18b146d
Merge branch 'clientSideEncryptionV3' of github.com:nextcloud/client into clientSideEncryptionV3
2017-12-20 21:29:54 +01:00
Roeland Jago Douma
5e23ca9658
FolderMetaData: store metadataKeys in a QMap
...
* This allows us to pick the right key for files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 21:25:27 +01:00
Roeland Jago Douma
b9f094cd94
Store metadata keys as keys
...
Don't store them base64 encoded. But store them directly useable
2017-12-20 21:17:41 +01:00
Roeland Jago Douma
c35b57cfba
Parse the files in the metadata
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 20:49:16 +01:00
Tomaz Canabrava
1e899f4172
[CSE] Do not create QPointer from raw pointers
2017-12-20 20:00:59 +01:00
Tomaz Canabrava
0347cf4e9e
[CSE] Store the sharing keys in memory
2017-12-20 19:40:58 +01:00
Roeland Jago Douma
fc73ad7476
Salt should not be hardcoded
...
We append the salt (just like the IV) to the ciphertext of the private
key. This means we also have to split it off properly.
This breaks compartibility with currently stored keys on your server.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 16:07:33 +01:00
Markus Goetz
067508c082
VERSION.cmake: This branch is now 2.4.1
2017-12-20 16:03:35 +01:00
Roeland Jago Douma
b924ad7282
Lower mnemonic when generating password
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 15:41:38 +01:00
Roeland Jago Douma
4551bbe0e0
Forget key + cert + mnemonic on account removal
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 15:35:23 +01:00
Roeland Jago Douma
a48a3e0acc
Cleanup old functions
...
Those functions had no use anymore since we store the key and cert in
the keychain. Removed them so we don't use them by accident.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 13:41:13 +01:00
Roeland Jago Douma
ee281963fe
Base64 magic:
...
* metadata keys: bin -> b64 -> enc -> b64
* sharing metadat: string -> b64 -> enc -> b64
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-20 10:22:35 +01:00
Jenkins for ownCloud
79065ba5c6
[tx-robot] updated from transifex
2017-12-20 02:18:53 +01:00
Tomaz Canabrava
ab89231ca2
[CSE] Remove unused debug
2017-12-20 00:25:56 +01:00
Tomaz Canabrava
d26ade1870
[CSE] Fix the result of the decryption
...
However the text still looks like encrypted.
2017-12-20 00:25:39 +01:00
Tomaz Canabrava
a1e6901ecc
[CSE] Decrypt correctly the metadata
...
There's a bug that's returning an empty bytearray, need to look
into that.
2017-12-20 00:20:27 +01:00
Tomaz Canabrava
494ae31de9
[CSE] Fix correct json object
2017-12-19 23:09:39 +01:00
Tomaz Canabrava
a02246dc65
[CSE] Fix Metadata bugs p1
...
The RFC was misleading, I took the chance to fix a few
inconsistencies regarding the QJsonDocument.
2017-12-19 22:47:05 +01:00
Tomaz Canabrava
5609a1dbe8
[CSE] Remove old debug code so I can focus.
2017-12-19 17:02:23 +01:00
Jenkins for ownCloud
3fbd156c83
[tx-robot] updated from transifex
2017-12-19 02:18:35 +01:00
Jenkins for ownCloud
8fb191afcf
[tx-robot] updated from transifex
2017-12-18 02:18:34 +01:00
Tomaz Canabrava
aa36cc4a5c
[CSE] Reduce probability of conflicts when rebasing
...
Creates a new file/class to handle upload,
propagateuploadencrypted.h/cpp. This should have all the logic to deal
with the encryption and upload.
2017-12-17 22:38:43 +01:00
Tomaz Canabrava
b9cdc8e922
[CSE] Fix the url to delete the metadata
2017-12-17 21:19:32 +01:00
Tomaz Canabrava
23f832caf4
[CSE] Code Cleanup
2017-12-17 19:19:44 +01:00
Tomaz Canabrava
7ef2489f1d
[CSE] Fix infoForFileId
...
We need to traverse the path recursivelly.
2017-12-17 19:14:34 +01:00
Jenkins for ownCloud
ab37856a91
[tx-robot] updated from transifex
2017-12-17 02:18:35 +01:00
Hefee
844e03d000
Also disable fstack-protector for alpha plattform.
...
This fixes #6211 .
(cherry picked from commit 69e81e8f65 )
2017-12-16 14:08:08 +01:00
Hefee
69e81e8f65
Also disable fstack-protector for alpha plattform.
...
This fixes #6211 .
2017-12-16 14:03:59 +01:00
Jenkins for ownCloud
46e796303e
[tx-robot] updated from transifex
2017-12-16 02:18:35 +01:00
Tomaz Canabrava
ce41e3e42f
[CSE] Work the Set Decrypted Bit
2017-12-15 23:32:41 +01:00
Olivier Goffart
1940c2f9bf
Exclude: Use Qt to load the exclude file
...
fopen does not work well with relative path tand forward slashes on windows
This fix the windows textexcludedfiles test.
And also make the code simpler.
Note that the 'trimmed' might be a behavior change, but i think it is ok
2017-12-15 19:16:20 +01:00
Christian Kamm
83e94c3ec7
Fix compile after rebase
2017-12-15 18:05:44 +01:00
Christian Kamm
a7c0cfc8eb
Upload conflict files #4557
...
If the server has the 'uploadConflictFiles' capability conflict
files will be uploaded instead of ignored.
Uploaded conflict files have the following headers set during upload
OC-Conflict: 1
OC-ConflictBaseFileId: 172489174instanceid
OC-ConflictBaseMtime: 1235789213
OC-ConflictBaseEtag: myetag
when the data is available. Downloads accept the same headers in return
when downloading a conflict file.
In the absence of server support clients will identify conflict files
through the file name pattern and attempt to deduce the base fileid.
Base etag and mtime can't be deduced though.
The upload job for a new conflict file will be triggered directly from
the job that created the conflict file now. No second sync run is
necessary anymore.
This commit does not yet introduce a 'username' like identifier that
automatically gets added to conflict file filenames (to name the files
foo_conflict-Fred-1345.txt instead of just foo_conflict-1345.txt).
2017-12-15 18:03:53 +01:00
Christian Kamm
7ae8ba35de
Remove unused csync test file
...
Now found at
test/csync/csync_tests/check_csync_update.cpp
2017-12-15 18:02:04 +01:00
Christian Kamm
8eebc53728
Unify item type enum
...
Previously, there was csync_ftw_type_e and SyncFileItem::Type. Having
two enums lead to a bug where Type::Unknown == Type::File that went
unnoticed for a good while.
This patch keeps only a single enum.
2017-12-15 18:02:04 +01:00
Tomaz Canabrava
2e516dfc67
Merge branch 'clientSideEncryptionV3' of github.com:nextcloud/client into clientSideEncryptionV3
2017-12-15 15:05:51 +01:00
Tomaz Canabrava
250c8ff1bf
[CSE] Add job to delete metadata
...
This is needed for the correct functioning of the Set Folder
as Decrypted
2017-12-15 15:02:43 +01:00
Olivier Goffart
ee366df58f
Fix the TestFolderMan on Windows
2017-12-15 14:51:00 +01:00
Olivier Goffart
482ee875a1
Fix TestSyncEngine on windows
2017-12-15 14:39:01 +01:00
Tomaz Canabrava
5607e27f20
[CSE] Actually save the http response result
2017-12-15 14:25:57 +01:00
Olivier Goffart
b10edfecfc
Workaround MSVC bug with enum in bitfield
...
MSVC stores the enum as signed in the bitfield (contrary to the C++ spec)
Which means that once we store a value such as SyncFileItem::DetailError
in a bitfield, we get a negative value back, then of course, further
comparison fails.
2017-12-15 14:18:45 +01:00
Tomaz Canabrava
43332d3ac7
[CSE] Properly update UI status to encrypted / decrypted
2017-12-15 14:00:42 +01:00
Roeland Jago Douma
8c178bd035
Merge pull request #95 from nextcloud/fix-libcloudproviders-conditions
...
Fix build on windows
2017-12-15 12:58:13 +01:00
Julius Härtl
49a16ffb4b
Fix build on windows
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2017-12-15 10:59:14 +01:00
Klaas Freitag
3b96097cf6
Config: Look for exclude file in a relative path.
...
If the application binary is not installed in /usr/bin the client
with this patch considers to check the relative location
../../etc/owncloud-client/ to find the system exclude.
This is an important bit for AppImage based packages of the client,
as this runs from a temporar mountpoint and the system file can not
be found under /etc.
2017-12-15 09:54:40 +01:00
Christian Kamm
298f1ab570
Disable stack protection for mingw win32 builds in 2.4
...
Mingw builds could have it enabled! But we need to ship libssp and test
this more. For the upcoming 2.4 release it should be disabled.
2017-12-15 09:16:59 +01:00
Jenkins for ownCloud
79dd8e9074
[tx-robot] updated from transifex
2017-12-15 02:18:52 +01:00
Roeland Jago Douma
99b4381591
Don't try to decrypt twice
...
The DecryptMetaDataKeys already base64 decoded
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-14 23:11:40 +01:00
Roeland Jago Douma
69a201a62d
Percentencode the json we send so special chars don't cause trouble
...
The + sign was lost in transfer.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-14 23:11:07 +01:00
Roeland Jago Douma
56028759d5
Merge branch 'master' into clientSideEncryptionV3
2017-12-14 20:47:05 +01:00
Markus Goetz
8d5afff0a4
Update ChangeLog for 2.4.0
2017-12-14 20:07:14 +01:00
Roeland Jago Douma
be3afd1291
Add FileEncryptJob and FileDecryptJob
...
This handles encryption and decryption of files.
Just create the job and start off.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-14 16:54:56 +01:00
Roeland Jago Douma
ac524d8e85
Merge pull request #92 from nextcloud/drone_up
...
Bump drone images
2017-12-14 14:54:46 +01:00
Tomaz Canabrava
82c07236c1
[CSE] Add new method "infoForFolderId"
...
we need to query the model for the subfolderinfo, but we don't
have the model index, we have the folder id. this returns it.
2017-12-14 14:39:07 +01:00
Roeland Jago Douma
76b8d2536b
Bump drone images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-14 12:57:16 +01:00
Olivier Goffart
4dc49ff3b0
SyncEngine: Recover when the PUT reply (or chunkin's MOVE) is lost
...
This can happen if the upload of a file is finished, but we just got
disconnected right before recieving the reply containing the etag.
So nothing was save din the DB, and we are not sure if the server
recieved the file properly or not. Further local update of the file
will cause a conflict.
In order to fix this, store the checksum of the uploading file in
the uploadinfo table of the local db (even if there is no chunking
involved). And when we have a conflict, check that it is not because
of this situation by checking the entry in the uploadinfo table.
Issue #5106
2017-12-14 11:56:12 +01:00
Olivier Goffart
4369853ddb
TestSystem: Add QIODevice in the serverOverride function, and add a DelayedReply
...
Preparing to add test that needs the QIODevice.
Also make the DelayedReply so we can generalize the existing delay on FakeChunkMoveReply
to any reply.
2017-12-14 11:56:12 +01:00
Roeland Jago Douma
de4492a2fd
Merge pull request #55 from nextcloud/libcloudproviders-integration
...
Integrate libcloudproviders support
2017-12-14 11:50:43 +01:00
Christian Kamm
d870729709
Require Qt >= 5.6 #6241
2017-12-14 11:31:30 +01:00
Julius Härtl
1cedb1919f
Integrate libcloudproviders support
...
This commit integrates support for libcloudproviders
desktop integration API. If build with the library it
will check on startup if the DBus interface is available
and then use it instead of the legacy status icon.
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2017-12-14 11:19:25 +01:00
Roeland Jago Douma
09fa5966da
Merge pull request #90 from nextcloud/oc_up
...
Merge upstream
2017-12-14 11:18:54 +01:00
Roeland Jago Douma
fe4bb52a6d
Merge remote-tracking branch 'oc/master' into oc_up
2017-12-14 10:27:11 +01:00
Christian Kamm
f40cceaf04
Share link: Adjust design of folder sharing permissions #6192
2017-12-14 08:34:44 +01:00
Jenkins for ownCloud
b357003a95
[tx-robot] updated from transifex
2017-12-14 02:18:37 +01:00
Daniel Hansson
042816bd0d
Merge pull request #88 from ivaradi/debian-build
...
Ubuntu/Debian build
2017-12-13 21:40:02 +01:00
Tomaz Canabrava
c592871f94
[CSE] Do not handle b64 inside of the decrypt function
...
the decrypt function should deal with the raw data always.
2017-12-13 16:37:52 +01:00
rockihack
5cc3b526e8
stack-protector is not supported on hppa.
...
(cherry picked from commit 8a963a67f2 )
2017-12-13 11:28:22 +01:00
rockihack
1b2a8ba6b0
Enable stack-protector-strong on Windows and macOS.
...
(cherry picked from commit 586fd346ea )
2017-12-13 11:28:22 +01:00
rockihack
8a963a67f2
stack-protector is not supported on hppa.
2017-12-13 11:27:48 +01:00
rockihack
586fd346ea
Enable stack-protector-strong on Windows and macOS.
2017-12-13 11:27:48 +01:00
Christian Kamm
e5ed8fc90a
Merge remote-tracking branch 'origin/2.4'
2017-12-13 11:03:24 +01:00
Markus Goetz
75676f8830
Notifications: Propagate "Dismiss" as DELETE to server #5922
...
(cherry picked from commit e86416fff7 )
2017-12-13 11:00:40 +01:00
Jenkins for ownCloud
530853c988
[tx-robot] updated from transifex
2017-12-13 02:18:36 +01:00
Tomaz Canabrava
9916583ffa
[CSE] More verbose output
2017-12-12 21:50:30 +01:00
Roeland Jago Douma
25734afd39
First base64 decode
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-12-12 21:42:37 +01:00
Tomaz Canabrava
ea3558faf6
[CSE] Fix strings
2017-12-12 21:29:06 +01:00
Tomaz Canabrava
159c0e138f
[CSE] Add a DecryptAsync method
...
Also, cleanup a bit of the old calls. One particular difference
is that I used to set padding to 1 and it should actually be
PKCS1_OAEP_PADDING
2017-12-12 21:23:02 +01:00
Tomaz Canabrava
aca298ca64
[CSE] Be explicit that async encryption uses publicKey
2017-12-12 20:14:31 +01:00
Tomaz Canabrava
2127b2629d
[CSE] Move encryption related network jobs to its own file
...
Move encryption related network jobs to it's own file,
the original file was starting to be just way too big.
2017-12-12 19:36:47 +01:00
István Váradi
c26d986dbf
New repository directory name
2017-12-12 17:27:01 +01:00
István Váradi
e55518f820
Fixed IV variable reference
2017-12-12 17:22:29 +01:00
István Váradi
44854beefb
Further script and file path renaming
2017-12-12 17:17:23 +01:00
István Váradi
7e41a811dd
Fix of script path
2017-12-12 17:14:49 +01:00
István Váradi
d2e159c385
Automatic building of Ubuntu/Debian packages
2017-12-12 17:11:46 +01:00
Tomaz Canabrava
f6f078d1ee
[CSE] Rename Variable
2017-12-12 16:15:05 +01:00
Tomaz Canabrava
ce37235cc4
[CSE] Retrieve the Private Key from the KeyChain
...
This fixes one thing and exposes a bug.
the MetadataKeys are not being correctly unencrypted.
2017-12-12 16:09:49 +01:00
Tomaz Canabrava
0a58ea76e5
[CSE] Start the work with an existing metadata
2017-12-12 15:35:53 +01:00
Olivier Goffart
02283fc686
Merge pull request #6224 from owncloud/deprecated
...
Remove use of deprecated Qt API
2017-12-12 11:48:04 +01:00
Tomaz Canabrava
e6f835d138
[CSE] Unlock the folder after a lock
...
This makes sure the folder will be unlocked for next tests
2017-12-12 11:26:54 +01:00
Tomaz Canabrava
33b1fcfe66
Merge branch 'master' into clientSideEncryptionV3
2017-12-12 10:46:43 +01:00
Christian Kamm
dcf0baa9de
Journal: 64bit inodes, fix storing uint64s generally
...
In addition to using the right function when retrieving inodes this
*also* fixes a more general bug ownsql had with storing uint64 values
that didn't fit into an int64.
2017-12-12 10:30:54 +01:00
Martin
cd2057fc04
Update Overlay Icon naming
2017-12-12 10:18:00 +01:00
Jenkins for ownCloud
3e294d5339
[tx-robot] updated from transifex
2017-12-12 02:18:35 +01:00
Olivier Goffart
bae00358b9
Merge pull request #6219 from owncloud/config
...
Move config and remove most dependencies form the sync engine.
2017-12-11 17:10:18 +01:00
Jenkins for ownCloud
36573a5c6f
[tx-robot] updated from transifex
2017-12-11 02:18:33 +01:00
Jenkins for ownCloud
9a835af7ce
[tx-robot] updated from transifex
2017-12-10 02:18:34 +01:00
Jenkins for ownCloud
ca48ff793c
[tx-robot] updated from transifex
2017-12-09 02:18:34 +01:00
Olivier Goffart
58e8a25869
Enable deprecated warnings
2017-12-08 16:16:06 +01:00
Olivier Goffart
d517d92f6c
FolderWizard: don't use deprecated API
2017-12-08 16:16:06 +01:00
Olivier Goffart
71dcf7fc37
SSLButton: Removes some call to deprecated functions
2017-12-08 16:16:02 +01:00
Olivier Goffart
0a59faf03d
OcsJob: Use QUrlQuery
...
Qurl::setEncodedQueryItems is deprecated.
2017-12-08 16:15:48 +01:00
Olivier Goffart
7bd48b1327
cmd: remove usage of deprecated qInstallMsgHandler
2017-12-08 16:15:48 +01:00
Olivier Goffart
8c652e061d
Remove uses of deprecated QString::fromAscii
2017-12-08 16:15:48 +01:00
Olivier Goffart
a4816d6a8c
Updater: use QUrlQuery
...
QUrl::addQueryItem is deprecated
2017-12-08 16:15:47 +01:00
Olivier Goffart
1a503d54f6
Remove usage of deprecated qSort
2017-12-08 16:15:47 +01:00
Olivier Goffart
263668b1cb
Remove use of deprecated translate call
2017-12-08 16:15:38 +01:00
Olivier Goffart
3df65460f5
Remove usage of QString::null
...
Replaces by "QString()"
2017-12-08 16:15:22 +01:00
Olivier Goffart
74672d493d
Utility: use QUrlQuery
...
For QUrl::setQuery is deprecated in Qt5
2017-12-08 16:15:17 +01:00
Tomaz Canabrava
0a83d3e743
[CSE] Fix reading the public key for the metadata
...
This broke when we started to use QSslKey and the Qt Keychain
framework.
2017-12-08 11:24:22 +01:00
Tomaz Canabrava
a08a32ceca
[CSE] Fetch the metadata for the upload.
2017-12-08 10:32:05 +01:00
Tomaz Canabrava
6745777ca3
[CSE] Save folder id and token for the lock
...
So we can unlock it later. - perhaps we should store this
on the disk or something, to make it harder to lose.
2017-12-08 10:19:56 +01:00
Olivier Goffart
f1b7d506ae
csync_exclude: fix compilation of non-test builds
2017-12-08 09:43:26 +01:00
Jenkins for ownCloud
fc8c88be41
[tx-robot] updated from transifex
2017-12-08 02:18:35 +01:00
Tomaz Canabrava
70d562668c
[CSE] Add handling for side-by-side uploads.
2017-12-07 21:51:42 +01:00
Tomaz Canabrava
ccd8cff4db
[CSE] Try to lock repeteadly the folder if needed.
...
The upload is made in an event loop with more than one
upload at the same time, this confuses the hell out of the
folder locking mechanism.
We need to lock the folder and ask the other trials to try
again in a few seconds in the future to give time for the
uploader to actually upload the current file that's locking
the folder.
2017-12-07 21:31:20 +01:00
Tomaz Canabrava
9f678652f8
[CSE] Lock the folder to upload a file.
2017-12-07 20:52:54 +01:00
Tomaz Canabrava
76916b6c48
[CSE] Request the Folder ID.
2017-12-07 19:39:30 +01:00
Tomaz Canabrava
4878e824e5
[CSE] Fix reading encrypted status of folders.
2017-12-07 19:04:12 +01:00
Tomaz Canabrava
893ca66af8
[CSE] Fix indentation
...
Parts of the code are indented by spaces, other parts by tabs.
This needs to run in the whole codebase.
2017-12-07 18:12:25 +01:00
Tomaz Canabrava
19120fde9f
[CSE] Don't query for files on GetFolderEncryptStatusJob
...
The request for folders whas also replying for files.
2017-12-07 18:10:14 +01:00
Tomaz Canabrava
7fe4dd2163
[CSE] Renane GetFolderEncryptStatus to GetFolderEncryptStatusJob
...
it's a network job after all
2017-12-07 18:06:55 +01:00
Olivier Goffart
4581d708ff
Account: remove dependency with ConfigFile
...
Part of #6213
2017-12-07 17:39:16 +01:00
Olivier Goffart
e0a14cac5b
ConfigFile: use QStandardPaths::AppConfigLocation for the config file
...
Also use appName instead of appNameGui in order to compute the path
Issue: #2245
The reason is to respect the XDG spec on Unix (#1601 ) and might help
on windows roaming profiles (#684 )
2017-12-07 17:39:16 +01:00
Olivier Goffart
ac844a2a45
AbstractNetworkJob: move the httpTimeout from the propagator to the network job
...
Remove one dependency from the config file for the sync engine.
Part of issue #6213
2017-12-07 17:39:16 +01:00
Olivier Goffart
7230fa6b4f
SyncOptions: move to its own file
...
It does not really belong in the discoveryphase.h as it is used also for
propagator option.
Also use C++11 style member initializer
2017-12-07 17:35:38 +01:00
Olivier Goffart
e25af4f0dc
csync_exclude: Fix compile
...
csync_exclude.cpp:428:17: error: assigning to 'char *' from incompatible type 'const char *'
bname = path;
^~~~
The C library's strrchr always return 'char*'
Only the C++'s std::strrchr has two overloads
2017-12-07 17:34:14 +01:00
Tomaz Canabrava
863e86138f
[CSE] Pass the folder to the GetEncryptionStatus
...
Sometimes we are only interested in folders.
2017-12-07 17:32:35 +01:00
Christian Kamm
287670c9d6
Excludes: Remove fnmatch codepath
...
Now all exclude patterns can be translated to regular expressions.
2017-12-07 14:38:21 +01:00
Christian Kamm
994f3bb644
Excludes: fnmatch doesn't treat '{' as special
...
Neither the documentation at
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_13
nor the fnmatch source code in <glibc>/posix/fnmatch_loop.c points
toward { causing special matching behavior.
2017-12-07 14:38:21 +01:00
Christian Kamm
e5c780ee19
Excludes: Translate full-path patterns to regex
...
Improves full matches by more than an order of magnitude
and also improves speed of traversal matches by roughly 20%,
judging by the check_csync_exclude performance test.
2017-12-07 14:38:21 +01:00
Christian Kamm
1c3d5ab158
Excludes: Introduce dir-only regex matches
2017-12-07 14:38:21 +01:00
Christian Kamm
5d668eca40
Excludes: Optimize Desktop.ini check
2017-12-07 14:38:21 +01:00
Christian Kamm
7ab127ad53
Excludes: Refactor for pending improvements
...
Make ExcludedFiles something that is instantiated outside of
the CSYNC context and then given to it as a hook.
ExcludedFiles still lives in csync_exclude and the internal
workings haven't been touched.
2017-12-07 14:38:21 +01:00
Olivier Goffart
dd91f4a86e
Merge remote-tracking branch 'origin/2.4'
...
Conflicts:
src/csync/csync.cpp
2017-12-07 09:37:50 +01:00
Olivier Goffart
3485109125
Jenkinsfile: Fix compilation
...
Add a CMAKE_PREFIX_PATH so it finds the right QtKeychain
2017-12-07 09:35:04 +01:00
Jenkins for ownCloud
a1136e7695
[tx-robot] updated from transifex
2017-12-07 02:18:34 +01:00
Hefee
32f38dc5f8
fix typo error: occured-> occurred
2017-12-06 20:02:53 +01:00
Christian Kamm
ceac18c554
Reconcile: Rename maps are consistent with update phase #6212
...
For duplicate file ids the update phase and reconcile phase determined
the rename mappings independently. If they disagreed (due to different
order of processing), complicated misbehavior would result.
This patch fixes it by letting reconcile try to use the mapping that the
update phase has computed first.
2017-12-06 16:42:11 +01:00
Christian Kamm
99f32dcb99
Clear csync rename mappings after reconcile
...
They were being preserved *across sync runs*.
2017-12-06 16:42:11 +01:00
Christian Kamm
79fe71db58
Hide selective sync buttons while disconnected #5809
...
The choices or big folder warnings will pop up again on reconnection.
2017-12-06 16:41:28 +01:00
Jenkins for ownCloud
ac937030f0
[tx-robot] updated from transifex
2017-12-06 02:18:35 +01:00
Olivier Goffart
ed5385faa3
Merge remote-tracking branch 'origin/2.4'
...
Conflicts:
src/libsync/connectionvalidator.cpp
src/libsync/networkjobs.cpp
2017-12-05 15:58:13 +01:00
Markus Goetz
fe234499dd
Update release_template.md
2017-12-05 09:22:23 +01:00
Jenkins for ownCloud
67d77dd6ce
[tx-robot] updated from transifex
2017-12-05 02:18:35 +01:00
Tomaz Canabrava
66aecb9626
[CSE] Handle normal uploads in CSE enabled instances
2017-12-04 22:45:10 +01:00
Tomaz Canabrava
6f35cbff6b
[CSE] Fetch the Folder information for encryption status
2017-12-04 22:27:13 +01:00
Tomaz Canabrava
387737d908
[CSE] Start to create the upload logic.
2017-12-04 21:33:43 +01:00
Markus Goetz
755ef0119a
ChangeLog: More 2.4.0 changes up to now
2017-12-04 13:18:29 +01:00
Hefee
1a1ab92ed9
make doc-man working again.
2017-12-04 12:37:30 +01:00
Michael Stingl
b29e9b931d
move man rst files to separate dir
2017-12-04 12:37:30 +01:00
Markus Goetz
0479322c1d
fstack-protector: Improve previous commit
2017-12-04 12:37:03 +01:00
Klaas Freitag
0be7b6fe1f
Only enable -fstack-protector-strong compiler flag for gcc > 4.9
...
On older/other compilers this flag is not understood.
2017-12-04 12:37:03 +01:00
Olivier Goffart
ee98daf9ea
Shibboleth: Upgrade to OAuth2 When the server supports it
...
If the server support both Shibboleth and OAuth2, upgrades to OAuth2
Issue #6198
2017-12-04 08:09:34 +01:00
Jenkins for ownCloud
f2beaba3e9
[tx-robot] updated from transifex
2017-12-04 02:18:34 +01:00
Tomaz Canabrava
8c4928d9f6
Merge branch 'uploadImprovements' into clientSideEncryptionV3
2017-12-03 18:15:33 +01:00
Jenkins for ownCloud
823c7469e1
[tx-robot] updated from transifex
2017-12-03 02:18:34 +01:00
Jenkins for ownCloud
10efe1faee
[tx-robot] updated from transifex
2017-12-02 02:18:34 +01:00
Olivier Goffart
e0954b0999
test/syncenginetestutils.h: Don't use toTimeZone only to get the UTC
2017-12-01 13:18:09 +01:00
Jenkins for ownCloud
5ff3e448f5
[tx-robot] updated from transifex
2017-12-01 02:18:34 +01:00
Jenkins for ownCloud
58bcbba841
[tx-robot] updated from transifex
2017-11-30 02:18:34 +01:00
Roeland Jago Douma
18b456ea2c
Merge pull request #77 from nextcloud/bump_drone
...
Bump drone images to contain WebEngine
2017-11-29 12:51:59 +01:00
Roeland Jago Douma
529442e0f8
Bump drone images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-29 12:34:34 +01:00
Olivier Goffart
30e3932af8
FolderWizard: Fix minimum size
...
There are several bugs in QWizard that needs to be worked around for the minimum
size of the widget to take effect.
Issue #4280
2017-11-29 08:03:06 +01:00
Jenkins for ownCloud
e86937e2e2
[tx-robot] updated from transifex
2017-11-29 02:18:34 +01:00
Tomaz Canabrava
35eb071874
[uploadImprovements] use the new struct on PropagateUploadNg
...
use the new struct on PropagateUploadNg to make the algorithm
more future proof.
2017-11-28 22:58:52 +01:00
Tomaz Canabrava
a64bd6059b
[uploadImprovements] fix struct hole
2017-11-28 22:22:37 +01:00
Tomaz Canabrava
a623b14209
[uploadImprovements] use the new struct info in PropagateUploadV1
...
Add a new member for the UploadFileInfo in PropagateUploadCommon
to hold the full file path - as it can change if we use a temporary
file to upload.
Adapt propagateuploadv1 to use the new calls.
2017-11-28 22:17:29 +01:00
Tomaz Canabrava
f609336bfc
Split file to upload from the file on disk
...
They can be conceptually equal - I can upload the file
on disk, and that's what I do right now. But if we want
to accept filters in the future, filters that change
the file on disk like shrinking an image, the current
information used is wrong and we need a way to separate those.
This patch introduces a new struct that holds the *actual*
file that will be uploaded, be it a temporary one or
the original file.
2017-11-28 21:28:06 +01:00
Tomaz Canabrava
2cacf2547e
Merge branch 'master' into clientSideEncryptionV3
2017-11-28 20:12:57 +01:00
Markus Goetz
6276d9290d
utility_mac: Check for NULL from LSSharedFileListItemResolve #6123
...
Possibly also #6074
2017-11-28 13:35:15 +01:00
Roeland Jago Douma
0f60deb043
Store and retrieve keys in keychain
...
* Store privatekey, certificate and mnemonic in keychain
* Retrieve private + public key from server
- ask for mnemonic to decrypt private key
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-28 12:36:35 +01:00
Markus Goetz
cde6589af8
owncloudcmd: Don't need Qt Sql module
2017-11-28 10:18:01 +01:00
Jenkins for ownCloud
482d538559
[tx-robot] updated from transifex
2017-11-28 02:18:53 +01:00
Tomaz Canabrava
c4d3d0987d
[CSE] Find the start of the upload
2017-11-27 22:20:24 +01:00
Tomaz Canabrava
47b5cd0fbb
[CSE] Shows correctly Encrypt / Decrypt in the menu
2017-11-27 21:19:54 +01:00
Tomaz Canabrava
dd903d447f
[CSE] Store the encryption status without the webdav url
...
The Folder information on the desktop client doesn't
knows about the webdav layout aparently.
2017-11-27 21:09:13 +01:00
Tomaz Canabrava
d2d2df4c75
[CSE] Try to find the webdav url of a folder.
2017-11-27 21:06:38 +01:00
Roeland Jago Douma
8c411b32f7
Merge pull request #67 from edent/patch-3
...
Update ownCloud references to NextCloud
2017-11-27 20:40:01 +01:00
Roeland Jago Douma
ccd050455a
Merge pull request #62 from bceverly/master
...
Added build support for FreeBSD
2017-11-27 20:39:19 +01:00
Roeland Jago Douma
ffb9f69cf6
Start with moving data to the keychain
...
* Check for cert + privateKey in keychain
* Work with QSslKey and QSslCertificate
* Abstract reading the BIO's a bit more
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-27 16:21:53 +01:00
Roeland Jago Douma
74c4d27ea0
Indent
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-27 16:12:56 +01:00
Tomaz Canabrava
e3050f7456
[CSE] Pass by reference, return by value.
...
Also, Do not create variables in the heap to change it's value
via reference, prefer an aggregation value. use a Typedef to
fully specify what you want in return.
2017-11-27 15:21:29 +01:00
Jenkins for ownCloud
6cc5ce7a66
[tx-robot] updated from transifex
2017-11-27 02:18:35 +01:00
Jenkins for ownCloud
7a80fe4939
[tx-robot] updated from transifex
2017-11-26 02:18:36 +01:00
Roeland Jago Douma
9cbe795045
Move more encryption functions to encryption helper
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-25 21:43:15 +01:00
Olivier Goffart
b8444053b8
AccountSettings: Fix the size of the "Add Sync Folder Connection" button
...
The problem here is that the QPainter is created on the viewport with is a
QWidget, but QAbstractItemView can have a different font, and the
QStyleOptionViewItem::font is this font. QStyleOptionViewItem::font
was used to compute the sizeHint, and the default font from the QPainter
was used to draw the text, so they could be not in sync.
Fix it by always using the font for QPushButton
Reported in
https://github.com/owncloud/client/issues/6156#issuecomment-346576328
2017-11-25 16:07:06 +01:00
Roeland Jago Douma
0ee0243595
Merge pull request #65 from edent/patch-2
...
Typo in documentation
2017-11-25 15:55:41 +01:00
Roeland Jago Douma
b6e986bb1b
Merge pull request #64 from edent/patch-1
...
Typo
2017-11-25 15:55:14 +01:00
Roeland Jago Douma
e0fbdfe175
Remove obsolete encryption functions
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-25 15:50:47 +01:00
Olivier Goffart
753d7addb4
libsync: Fix compilation with TOKEN_AUTH_ONLY
...
This means we cannot use QtGui in libsync.
So this mostly disable the avatar from the account and the avatarjob
Note that there is one logic change: in ConnectionValidator::slotUserFetched
we do the avatar job even if the user is empty. Otherwise we would end up in
a invalid state. This restore the 2.3.x behavior that was broken in
commit e05d6bfcdc
2017-11-25 12:57:16 +01:00
Terence Eden
632570a13b
Update ownCloud references to NextCloud
...
Fixes #66
2017-11-25 10:26:23 +00:00
Terence Eden
e6be710cdb
Typo in documentation
...
Fixes #63
2017-11-25 10:03:36 +00:00
Terence Eden
0b00ab8a15
Typo
...
Fixes #63
2017-11-25 10:03:00 +00:00
Jenkins for ownCloud
c0ae96e7a8
[tx-robot] updated from transifex
2017-11-25 02:18:35 +01:00
Roeland Jago Douma
12adff76e2
Properly decrypt private key and send it to the server
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-24 22:10:28 +01:00
Roeland Jago Douma
6d145a676b
Added EncryptionHelper
...
This is to move generic encryption methods out of the main code and into
small helper functions. So we don't scatter the encryption code all over
the place.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-24 21:05:21 +01:00
bceverly
5279e2fb37
Added support for FreeBSD
2017-11-24 08:54:29 -05:00
bceverly
51e355e403
Added support for FreeBSD
2017-11-24 08:54:24 -05:00
Jenkins for ownCloud
e99d64011e
[tx-robot] updated from transifex
2017-11-24 02:18:38 +01:00
Tomaz Canabrava
45d9323653
[CSE] Update encryption status when folder is updated
2017-11-23 16:55:12 +01:00
Tomaz Canabrava
57e0d7abcb
[CSE] Fix pointer to e2e
...
Qt expects things to be pointers even if they are stack
variables.
2017-11-23 16:54:45 +01:00
Olivier Goffart
72809ef5b1
csync_update: ignore remote files that cannot be encoded
...
This is mainly for linux, whose local is not UTF-8.
For example, in latin1, it is not possible to encode emoji or chinese character.
If there are such character in the filename, Qt would just save the file using
the replacement character ('?'). Then, on the next sync, client would rename
the files using this replacement character.
Avoid this by ignoring the files which cannot be downloaded because the
filename cannot be represented with the user's locale
Relates to issue #5676 and #5719
2017-11-23 12:51:28 +01:00
Jenkins for ownCloud
7a790c88e8
[tx-robot] updated from transifex
2017-11-23 02:18:33 +01:00
Jenkins for ownCloud
01377f6ea9
[tx-robot] updated from transifex
2017-11-22 02:18:34 +01:00
Christian Kamm
8c94601ef2
User shares: Further avatar tweaks
2017-11-21 16:33:03 +01:00
Christian Kamm
f27ceb7fab
User shares: Use background color, remove permission frame #6176
2017-11-21 16:33:03 +01:00
Christian Kamm
60bde048c6
User shares: Fix missing label when there are only link shares
...
The "not shared with users or groups" label only appeared if there were
no shares at all.
2017-11-21 16:33:03 +01:00
Christian Kamm
3b961204e1
Avatars in user share dialog: Minor tweaks
2017-11-21 16:33:03 +01:00
Christian Kamm
e9907bc8ae
AvatarJob improvements
...
* Drop AvatarJob2
* Allow AvatarJob to retrieve different sizes and users
* Make creating a circular avatar into a function
(maybe all avatars should be made into that shape in the first place)
2017-11-21 16:33:03 +01:00
Roeland Jago Douma
6b9b5252de
User shares: Show avatars
...
[Sharing] Show placeholders for avatars
Just like on the web show placeholders for avatars in the sharing dialog
[Sharing] Show avatars!
[Sharing] Show same avatar placeholder for group/federated shares as on
web
2017-11-21 16:33:03 +01:00
Roeland Jago Douma
84a093e450
Merge pull request #53 from nextcloud/build_appimage
...
Automatically start building AppImages on PR's
2017-11-21 14:27:53 +01:00
Roeland Jago Douma
be8b99bf3a
Build AppImage on all pushes
...
This allows quickly testing of the appimages for feedback
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-21 14:20:09 +01:00
Christian Kamm
d949ec6877
Protocol: Introduce context menu with "open in browser" #6121
...
To do this conveniently a bunch of functionality that's common to
IssueWidget and ProtocolWidget is moved to ProtocolItem.
Also the convenience function to asynchronously retrieve the private
link url is moved from the socket api to the network jobs.
2017-11-21 12:42:10 +01:00
Olivier Goffart
96dede4e84
TestChunkingNG: Test that resuming does not send past data.
2017-11-21 11:19:14 +01:00
Roeland Jago Douma
e7b7b8923f
Merge pull request #52 from nextcloud/single_drone
...
No double building on PR's
2017-11-21 10:18:01 +01:00
Tomaz Canabrava
a118419f0c
[CSE] buildfix, use the correct type.
2017-11-21 09:55:44 +01:00
Roeland Jago Douma
407d71b305
Merge pull request #50 from nextcloud/correct_app_password_link
...
Have correct app password link
2017-11-21 09:48:01 +01:00
Roeland Jago Douma
d63e18aa9d
Merge pull request #51 from nextcloud/no_jenkins
...
We don't use Jenkins
2017-11-21 09:38:37 +01:00
Roeland Jago Douma
26ba89c2a8
No double building on PR's
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-21 09:27:52 +01:00
Roeland Jago Douma
7c5150421c
We don't use Jenkins
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-21 09:20:17 +01:00
Roeland Jago Douma
462353d0ee
Have correct app password link
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-21 09:17:42 +01:00
Jenkins for ownCloud
72783aa068
[tx-robot] updated from transifex
2017-11-21 02:18:35 +01:00
Tomaz Canabrava
d31aa7836a
[CSE] Add job to find what folders are encrypted.
...
This still needs to be correctly setuped in the call chain.
The job returns a QVariantMap with the folder-webdav-url
and the encrypted status.
2017-11-20 21:38:17 +01:00
Jürgen Weigert
0abe7a77fb
Update release_template.md
2017-11-20 18:12:18 +01:00
Jürgen Weigert
ad408c5717
post release checks added
...
this fixes https://github.com/owncloud/client/issues/5836
2017-11-20 18:12:18 +01:00
Tomaz Canabrava
34e6534813
Merge branch 'clientSideEncryptionV3' of github.com:nextcloud/client into clientSideEncryptionV3
2017-11-20 18:01:48 +01:00
Tomaz Canabrava
6d464d9dc6
Merge branch 'master-nextcloud' into clientSideEncryptionV3
2017-11-20 18:00:58 +01:00
Roeland Jago Douma
2236d05d25
Merge pull request #49 from nextcloud/nc_theme
...
Nextcloud theme
2017-11-20 16:47:31 +01:00
Roeland Jago Douma
f0537b20d1
Update with NC icons
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-20 16:14:40 +01:00
Roeland Jago Douma
9878559002
Move to NC theme
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-20 15:46:18 +01:00
Markus Goetz
658a8c0609
mirall.desktop.in: Clean bogus comments #5767
2017-11-20 15:29:39 +01:00
Olivier Goffart
e7a91a1169
AccountSettings: Use the proper position to show the menu over sub-folder
...
The menu can be open with the keyboard shortcut.
(Fixup for the fix of #5596 )
Also use popup instead of exec to show the menu: it's safer as it does
not re-enter the event loop.
2017-11-20 15:22:45 +01:00
Roeland Jago Douma
6b3006b325
OwnCloudCPack.cmake to NextcloudCPack.cmake
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-20 14:12:52 +01:00
Roeland Jago Douma
5dc73ffd8b
OWNCLOUD.cmake => NEXTCLOUD.cmake
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-20 14:12:52 +01:00
Roeland Jago Douma
b835bdc55b
Merge pull request #48 from nextcloud/oc_master
...
Bump to oc master
2017-11-20 13:43:34 +01:00
Roeland Jago Douma
725be9ff54
Merge branch 'master' of https://github.com/owncloud/client into oc_master
2017-11-20 13:29:59 +01:00
Christian Kamm
14a51458ab
Link share: Move 'delete' button to the bottom #6163
2017-11-20 12:42:41 +01:00
Christian Kamm
aafe7c4732
Merge remote-tracking branch 'origin/2.4'
2017-11-20 11:54:56 +01:00
Christian Kamm
86c2e9e825
Tray: Fix 'Open folder' action creation
...
It looks like the action was created but not added to the menu. Did this
work with previous Qt versions?
2017-11-20 11:48:55 +01:00
Olivier Goffart
480932a58a
Checksum: Ignore unkown OC-Checksum header when downloading...
...
And if there are several checksums, pick the "best" one.
The case of several checksum was reported in
https://github.com/nextcloud/client_theming/issues/213
2017-11-20 10:51:15 +01:00
Jenkins for ownCloud
529bcab009
[tx-robot] updated from transifex
2017-11-20 02:18:34 +01:00
Jenkins for ownCloud
9a4871abeb
[tx-robot] updated from transifex
2017-11-19 02:18:36 +01:00
Jenkins for ownCloud
40665c05ac
[tx-robot] updated from transifex
2017-11-18 02:18:36 +01:00
Michael Stingl
d832312acc
Add 2.3.3 System Requirements to client repo ( #5996 )
...
I would like to maintain the System Requirements in the client repo.
2017-11-17 15:05:42 +01:00
Jenkins for ownCloud
63cf0e347b
[tx-robot] updated from transifex
2017-11-17 02:18:37 +01:00
Olivier Goffart
2192386d86
test/testsyncengine: test for PR #6168
2017-11-16 13:31:54 +01:00
Christian Kamm
e694ffcd03
PropagateDownload: Adjustments to skipping downloads #6153
...
Previously we required matching mtimes but that's actually
unnecessary when the question is about whether to skip the
download. We will still update the file's metadata.
Also, adjust behavior when the checksum is weak (Adler32):
in these cases we still depend on equal mtimes.
2017-11-16 13:31:54 +01:00
Christian Kamm
eff401d418
Share links: Confirm deletion explicitly #6163
...
Also add the "Delete" action to the "..." menu.
2017-11-16 11:16:47 +01:00
Roeland Jago Douma
9394fe6e84
Use openssl functions to get random words
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-16 10:45:57 +01:00
Jenkins for ownCloud
7049ccd7ab
[tx-robot] updated from transifex
2017-11-16 02:18:53 +01:00
Markus Goetz
8fb2167fca
sqlite: Update bundled version to 3.21
...
For OS X and Windows.
2017-11-15 21:53:53 +01:00
Markus Goetz
d0b8528022
Changelog: 2.4 changes up to now
2017-11-15 21:47:34 +01:00
Samuel Alfageme
13d80beb83
Changelog Updated with latest changes
...
Web equivalent PR: https://github.com/owncloud/owncloud.org/pull/1318
2017-11-15 13:37:25 +01:00
Christian Kamm
06ce8dd8bd
Wizard: Add explanation text when server error is shown #6157
...
Just showing a box with the message can be surprising.
2017-11-15 11:01:44 +01:00
Olivier Goffart
9a1ea67a35
Theme: Update the wizard size on high dpi screen
...
Issue #6156
2017-11-15 10:46:08 +01:00
Christian Kamm
e616f904b6
Share link: Add tooltip to delete button #6163
2017-11-15 10:16:33 +01:00
Christian Kamm
bff24ffd2f
PropagateDownload: Fix GET with redirects #6159
...
The GET jobs were redirected, but the custom incremental handling
in readyRead didn't propagate to the follow-up job.
2017-11-15 10:11:15 +01:00
Jenkins for ownCloud
2cdc969cc5
[tx-robot] updated from transifex
2017-11-15 02:18:34 +01:00
Matthew Setter
b13fd786b6
Fix broken download link
2017-11-14 12:25:48 +01:00
Matthew Setter
89d55d0af8
Fix broken images in the FAQ
2017-11-14 12:25:48 +01:00
Matthew Setter
d46335aba1
Minor formatting fixes
...
Fix broken header and table
2017-11-14 12:25:48 +01:00
Matthew Setter
e417a4b159
Fix title casing to match style guide
2017-11-14 12:25:48 +01:00
Christian Kamm
b0f986c740
Private links: Account for overwritehost #6146
...
Retrieve ocs/v1.php/config to determine the desired host and build the
private link urls with that instead.
2017-11-14 12:14:11 +01:00
Christian Kamm
18091f99d4
Private links: Retrieve numeric file id property #6146
...
Some servers have non-compliant instance ids (that start with a number)
and thereby make deducing the numeric file id from the full id
unreliable.
To circumvent this problem we retrieve the fileid property from the
server with a PROPFIND.
2017-11-14 12:14:11 +01:00
Christian Kamm
3ae2071129
DetermineAuth: Remove concept of Unknown #6148
...
This restores 2.3 behavior. Some servers reply 404 to GETs and PROPFINDs
to the remote.php/webdav/ url and used to work. Being more picky would
break them.
2017-11-14 12:10:35 +01:00
Christian Kamm
820ebf4b6e
Sql: db close() failing isn't fatal
...
The assert was made fatal when looking at asserts for #5429 #5518
without having a particular problem in mind. Recent reports weakly
suggest that this might lead to occasional crashes for users when
sqlite_close fails in ways that look ignorable.
2017-11-14 12:10:19 +01:00
Jenkins for ownCloud
161f6baba6
[tx-robot] updated from transifex
2017-11-14 02:18:32 +01:00
Tomaz Canabrava
14aeb6921b
[CSE] Fix invalid memory access
2017-11-13 18:15:08 +01:00
Tomaz Canabrava
8adfc28de7
[CSE] Store lock-token and retrieve later
2017-11-13 17:54:19 +01:00
Tomaz Canabrava
a0f0e5617a
[CSE] Move the e2e object to the Account
...
This is important as a lot of the code would start
to rely in direct access to the client side encryption
and there are different keys for different accounts.
2017-11-13 17:22:09 +01:00
Tomaz Canabrava
6351c01ee7
[CSE] Remember the token for folders
2017-11-13 17:04:02 +01:00
Tomaz Canabrava
e32fd58578
[CSE] handle success and failure of metadata upload.
2017-11-13 17:03:40 +01:00
Tomaz Canabrava
22a2ab8999
[CSE] Start to send the metadata to the server
2017-11-13 16:46:30 +01:00
Jenkins for ownCloud
89d7dbf2cf
[tx-robot] updated from transifex
2017-11-13 02:18:32 +01:00
Tomaz Canabrava
4755b8c8a3
[CSE] More warnings
2017-11-12 13:03:52 +01:00
Tomaz Canabrava
19d64e6308
[CSE] Remove warnings
2017-11-12 12:55:12 +01:00
Jenkins for ownCloud
b1972e56fa
[tx-robot] updated from transifex
2017-11-12 02:18:33 +01:00
Tomaz Canabrava
05d826a954
Merge branch 'master' into clientSideEncryptionV3
2017-11-11 16:28:20 +01:00
Tomaz Canabrava
685ceacace
[CSE] Memleaks
2017-11-11 16:25:38 +01:00
Jenkins for ownCloud
7d10f9829e
[tx-robot] updated from transifex
2017-11-11 02:18:34 +01:00
Jenkins for ownCloud
d2723bc0ac
[tx-robot] updated from transifex
2017-11-10 02:18:50 +01:00
Jenkins for ownCloud
a0d43f8ba6
[tx-robot] updated from transifex
2017-11-09 02:18:50 +01:00
Christian Kamm
37c5612aee
Discovery: Treat files starting with '.' as hidden #6145
...
This bug was introduced when strcmp(a, b) != 0 was accidentally
converted to a == b.
2017-11-08 12:53:46 +01:00
Jenkins for ownCloud
f2e73c0887
[tx-robot] updated from transifex
2017-11-08 02:25:47 +01:00
Jenkins for ownCloud
aca36cc1ac
[tx-robot] updated from transifex
2017-11-07 02:21:25 +01:00
Tomaz Canabrava
ee4a848d9a
[CSE] Correctly Unlock the Folder
...
Wireshark is love, and life.
2017-11-06 20:58:30 +01:00
Tomaz Canabrava
7290cf2813
[CSE] Adjust the CN accordingly to the server
2017-11-06 20:57:50 +01:00
Christian Kamm
9af6e29f42
DetermineAuthType: Adjustments for tight firewalls #6135
...
With some firewalls we can't GET /remote.php/webdav/. Here we keep the
GET request to detect shibboleth through the redirect pattern but then
use PROPFIND to figure out the http auth method.
Currently we prefer OAuth to Shibboleth to Basic auth.
This also restores the fallback behavior of assuming basic auth
when no auth type can be determined.
2017-11-06 13:09:10 +01:00
Jenkins for ownCloud
d6db77cce8
[tx-robot] updated from transifex
2017-11-06 02:25:40 +01:00
Jenkins for ownCloud
71d2e3de74
[tx-robot] updated from transifex
2017-11-05 02:26:45 +01:00
Jenkins for ownCloud
a7e07239e3
[tx-robot] updated from transifex
2017-11-04 02:19:35 +01:00
Roeland Jago Douma
131fd4e483
Fix encryptJSON and descryptJSON
...
Now working with tag
Basically we called EVP_*Update to much which resulted in weird output.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-03 18:00:05 +01:00
Tomaz Canabrava
be9cd358d4
[CSE] Bypass Qt DELETE Bug
...
It appears that Qt implementation of the DELETE http request
does not send bodyData, and we need that for Nextcloud.
Currently I changed the http request on the server side
to accept a POST instead of a DELETE, so I can actually
develop.
Also, I already poked the Qt developers that did this code.
2017-11-03 17:00:28 +01:00
Tomaz Canabrava
6ad6852045
[CSE] Cleanup - remove commented metadata.
2017-11-03 16:59:39 +01:00
Tomaz Canabrava
832cbef8e7
[CMAKE] Bump minimum version to 3.2
...
Removes a lot of warnings.
2017-11-03 15:43:57 +01:00
Tomaz Canabrava
5514f14e88
[CSE] Get and send the lock - token
2017-11-03 15:12:12 +01:00
Tomaz Canabrava
ea9e2135a1
[CSE] Remove uneeded comments.
2017-11-03 14:28:13 +01:00
Tomaz Canabrava
b53003792f
[CSE] Removed lambdas for Metadata / Lock / Unlock
2017-11-03 12:34:30 +01:00
Tomaz Canabrava
6facd29663
[CSE] Start to break the lambdas
...
Lambda within a lambda is a terrible idea,
Use default signal / slot connections with a
method instead.
2017-11-03 12:00:25 +01:00
Tomaz Canabrava
3b157caf09
[CSE] Handle encrypt / lock / unlock
2017-11-03 11:21:01 +01:00
Tomaz Canabrava
d7e05c9b05
[CSE] Comment out broken code.
...
But why it's broken?
2017-11-03 11:20:44 +01:00
Christian Kamm
3608114ec1
Journal: Fix low-disk space errors
...
Fixes a regression from 4dbe9d4113 ,
low disk space can lead to IOERR not just CANTOPEN.
2017-11-03 10:44:47 +01:00
Christian Kamm
c9d5a9cea2
HttpCreds: Don't create empty client cert keychain entries #5752
...
This doesn't do anything about deleting the client cert keychain
entries when the whole account is removed though.
2017-11-03 10:28:56 +01:00
Jenkins for ownCloud
354cdfdbc1
[tx-robot] updated from transifex
2017-11-03 02:19:05 +01:00
Jürgen Weigert
d903afc4bf
Adding post-release checks to template ( #6109 )
...
copied 3 items from https://github.com/owncloud/client/issues/5889
2017-11-02 16:57:02 +01:00
Christian Kamm
4dbe9d4113
Journal: Don't crash if the db file is readonly #6050
...
Surprisingly sqlite3_open_v2() returns ok on readonly files with
SQLITE_OPEN_READWRITE. Probably due to the journal mode?
2017-11-02 16:36:51 +01:00
Roeland Jago Douma
8e3e3a4575
Be java compatible and store the tag at the end of the cipher text
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-02 12:39:42 +01:00
Christian Kamm
c743cc171a
Client certs: Improve error message #6128
...
"Could not load certificate" can very well just be a bad password.
2017-11-02 11:30:44 +01:00
Jenkins for ownCloud
7963a8322d
[tx-robot] updated from transifex
2017-11-02 02:18:48 +01:00
Tomaz Canabrava
8d537fdd3c
[CSE] Get Metadata from the server
2017-11-01 18:32:33 +01:00
Tomaz Canabrava
4a66cf11d2
[CSE] Send Metadata to the server
2017-11-01 18:21:30 +01:00
Tomaz Canabrava
2698759525
[CSE] Implement the Folder Unlock api job
2017-11-01 17:54:17 +01:00
Tomaz Canabrava
1b1add5ead
[CSE] Add api to lock file
2017-11-01 17:36:54 +01:00
Christian Kamm
6ac44f05cd
Credentials: Namespace windows cred keys #6125
...
The application name is prepended to the key. QtKeychain doesn't
do that automatically on the platform.
2017-11-01 17:03:30 +01:00
Tomaz Canabrava
e5fdcd2f38
[CSE] Add TODO:
2017-11-01 16:48:19 +01:00
Tomaz Canabrava
ef2529ca44
[CSE] Set padding to 0 for the Rsa encryption
...
Also, commented out the finalization of the decrypt operation
because that was messing with the encryption. There's something
wrong here but I need to get this working and I can fix stuff
later.
2017-11-01 16:13:17 +01:00
Christian Kamm
64a84fda38
Wizard: Don't report confusing error message #6116
...
For historical reasons CheckServerJob doesn't just check url/ but also
url/owncloud/. However, that means if url/status.php is a 404 and
url/owncloud/status.php is a 404, the user will see the latter url
appear in the error message. That's potentially confusing.
Instead, just show the account url which will be closer to what the
user typed into the account wizard, while being adjusted for protocol
and possible redirects.
2017-11-01 15:57:58 +01:00
Tomaz Canabrava
1a891423e5
[CSE] Call the decryption function to test.
2017-11-01 15:48:40 +01:00
Tomaz Canabrava
41ebcd0b7e
[CSE] Decryption of the metadata blob
2017-11-01 15:29:14 +01:00
Tomaz Canabrava
77ec3b086d
[CSE] Remember to finalize encryption
2017-11-01 15:24:19 +01:00
Tomaz Canabrava
88d87bf0ca
[CSE] Convert encrypted bitearray to Base64
...
also, start the decrypt.
2017-11-01 14:46:32 +01:00
Jenkins for ownCloud
8eec79680c
[tx-robot] updated from transifex
2017-11-01 02:19:02 +01:00
Tomaz Canabrava
eb43fa1459
[CSE] Internal metadata encryption working
2017-10-31 17:52:01 +01:00
Tomaz Canabrava
8793fdbc69
[CSE] Remember to actually use the correct variable
2017-10-31 16:06:01 +01:00
Tomaz Canabrava
4bb7ebb6aa
[CSE] Convert the base64 data to raw, for the decyrption
2017-10-31 13:17:22 +01:00
Tomaz Canabrava
3628f3739d
[CSE] Start the decryption of the metadata
2017-10-31 13:06:20 +01:00
Tomaz Canabrava
b28b4705de
[CSE] Correctly store the encrypted metadata
...
Missing the conversion to base64.
2017-10-31 12:07:47 +01:00
Tomaz Canabrava
560ce958de
[CSE] Remove warning.
2017-10-31 11:24:10 +01:00
Tomaz Canabrava
69d73162aa
[CSE] functions for encrypt / decrypt folder
...
The code was scattered around the slot for the context
menu request and had already too many indentation levels.
2017-10-31 11:09:34 +01:00
Tomaz Canabrava
69dc099b17
[CSE] Dedicated function for the subfolder menu
2017-10-31 11:03:24 +01:00
Tomaz Canabrava
c7d9abbea3
[CSE] Rework pubkeyPath to be able to fetch pubKey
2017-10-30 20:02:55 +01:00
Tomaz Canabrava
a986532442
[CSE] Generate a random password for the metadata.
2017-10-30 19:08:03 +01:00
Tomaz Canabrava
cf56d58241
[CSE] Start the encryption of the metadataKey
2017-10-30 19:05:55 +01:00
Tomaz Canabrava
edb04c137c
[CSE] Call the FolderMetadata
2017-10-30 19:05:32 +01:00
Tomaz Canabrava
c695c50c33
[CSE] Implement the empty metadata
...
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org >
2017-10-30 15:40:05 +01:00
Tomaz Canabrava
5420741edb
Merge branch 'master' into clientSideEncryptionV3
2017-10-30 11:21:36 +01:00
Jenkins for ownCloud
0968d74dad
[tx-robot] updated from transifex
2017-10-30 02:27:13 +01:00
Jenkins for ownCloud
876a1c5140
[tx-robot] updated from transifex
2017-10-29 02:18:42 +01:00
Jenkins for ownCloud
1455636169
[tx-robot] updated from transifex
2017-10-29 02:21:41 +02:00
Jenkins for ownCloud
7ea9a5ca4e
[tx-robot] updated from transifex
2017-10-28 02:18:51 +02:00
Christian Kamm
05c1bfb6cf
Merge remote-tracking branch 'origin/2.4'
2017-10-27 10:29:31 +02:00
Jenkins for ownCloud
2d2ec2a576
[tx-robot] updated from transifex
2017-10-27 02:20:55 +02:00
Jürgen Weigert
17126de5c7
APPLICATION_NAME may contain whitespace
...
Need some quotes to survive in makensis.
2017-10-26 18:44:38 +02:00
Jenkins for ownCloud
e4612ca5d4
[tx-robot] updated from transifex
2017-10-26 02:19:20 +02:00
Jenkins for ownCloud
15af5878b6
[tx-robot] updated from transifex
2017-10-25 02:21:52 +02:00
Jocelyn Turcotte
d9f6468310
Windows: Remove navigation pane entries when uninstalling
...
Issue #5295
2017-10-24 16:10:53 +02:00
Jocelyn Turcotte
10c6951438
Windows: Add a setting to enable/disable the explorer navigation pane integration
...
Issue #5295
2017-10-24 16:10:53 +02:00
Jocelyn Turcotte
56e38e6f80
Windows: Add sync folders to Explorer's navigation pane
...
This is only the navigation pane, the SyncRootManager entries aren't handled yet.
This follows the instructions from:
https://msdn.microsoft.com/en-us/library/windows/desktop/dn889934%28v=vs.85%29.aspx
Issue #5295
2017-10-24 16:10:53 +02:00
Roeland Jago Douma
238f0b3610
Add note
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-10-24 15:53:17 +02:00
Roeland Jago Douma
817baf292d
Use EVP_aes_128_gcm
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-10-24 15:51:53 +02:00
Roeland Jago Douma
ca6fa7b341
Update decryp function
...
* Do not use AAD
* Do not try to decrypt the last 16 bytes as Android adds the tag there
by default
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-10-24 15:51:53 +02:00
Roeland Jago Douma
bacbf337d2
Update encryption function
...
* Do not use padding
* Do not use the ADD data
* Append the tag to the ciphertext to be compatible with Android
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-10-24 15:51:53 +02:00
Olivier Goffart
c36043a175
ShareDialog: trigger a sync for folder affected by a change of sharing
...
This allow the sync engine to query the new metadata and update the
overlay icons.
Note: we also need to invalidate the etags because the server does not
change the etag of parent directories that see their share-types changed.
Issue #6098
2017-10-24 15:50:14 +02:00
Olivier Goffart
ee63b36ed3
SyncFileStatusTracker: Detect changed in the shared flag
...
... even if the file is not changed.
We get an UPDATE_METADATA in that case, so make sure we let the
SyncFileStatusTracker know about it.
That means we need to filter out UPDATE_METADATA in the other listeners
of this signal.
Issue #6098
2017-10-24 15:50:14 +02:00
Olivier Goffart
35d28294cd
SyncEngine: remove SyncEngine::syncItemDiscovered
...
It is unused.
2017-10-24 15:50:14 +02:00
Olivier Goffart
c6bd3ab31a
Sharing: remove the ShareManager::_jobContinuation
...
It is growing indefinitively in case of error, causing a leak.
Use a labda instead to pass the capture
2017-10-24 15:50:14 +02:00
Christian Kamm
9c7ee6ef85
Reconcile: Rename handling fixes: duplicate file ids
...
When users share the same tree several times (say A/ and A/B/ are both
shared) the remote tree can have several entries that have the same
file id. This needs to be respected in rename detection.
Also adds several tests and fixes for issues noticed during testing.
See #6096
2017-10-24 10:54:23 +02:00
Christian Kamm
e85a339d94
Local discovery: Use db instead of filesystem
...
We mostly trust the file watchers meaning that we don't re-scan the
local tree if we have done that recently and no file watcher events
have arrived. If the file watchers invalidate a subtree, we rescan
only that subtree.
Since we're not entirely sure the file watchers are reliable, we still
do full local discoveries regularly (1h by default). There is a config
file setting as well as an environment variable to control the interval.
2017-10-24 10:00:20 +02:00
Christian Kamm
66f0ce6616
FolderWatcher: reliability and data-loss signal
...
Add state and signal to catch the following two known problems:
* Linux: inotify user watch pool is exhausted. Folder watcher becomes
unreliable.
* Windows: buffer is too small, some notifications are lost but watching
stays reliable.
2017-10-24 10:00:20 +02:00
Christian Kamm
fb2d31c9ce
Folder: Move FolderWatcher to Folder
...
This makes it unnecessary for FolderMan to manage the list and removes
the need for some forwarders.
This is done in preparation for follow-up commits that want to add
diagnostics to FolderWatcher that shall be available from within Folder.
2017-10-24 10:00:20 +02:00
Christian Kamm
8865405a32
Version: master branch is future 2.5 now
2017-10-24 09:56:16 +02:00
Christian Kamm
f3ea375083
Wizard: Resolve url/ redirects only if url/status.php not found
...
Unfortunately checking the base-url for redirects in all cases lead
to incorrect behavior in some SAML/OAuth2 edge cases.
This new iteration checks the base url for redirects only if the
standard CheckServerJob can't reach the server. That way the 2.3
behavior is only changed in cases that would have lead to errors.
See #5954
2017-10-24 09:42:08 +02:00
Jenkins for ownCloud
15b02547e8
[tx-robot] updated from transifex
2017-10-24 02:18:49 +02:00
Tomaz Canabrava
476fe66043
[CSE] Add beginnign of the code to deal with the metadata
2017-10-23 21:06:26 +02:00
Tomaz Canabrava
bb53c2586f
[CSE] Add Nlohmann's json library
...
Because nobody deservers to deal with Qt's JSON API
2017-10-23 21:06:26 +02:00
Tomaz Canabrava
23f5bb7ed9
[CSE] Move network jobs out of networkjobs.h
...
Since those networkjobs are all about client side
encryption, mvoe them to clientsideencryption.h
This will help with fewer conflicts with the origin.
2017-10-23 21:06:26 +02:00
Jenkins for ownCloud
13b1f8b33e
[tx-robot] updated from transifex
2017-10-23 02:19:01 +02:00
Jenkins for ownCloud
ccd32c04a9
[tx-robot] updated from transifex
2017-10-22 02:21:00 +02:00
Jenkins for ownCloud
df19b20d07
[tx-robot] updated from transifex
2017-10-21 02:20:25 +02:00
Olivier Goffart
f41c9fbb7f
owncloudsetupwizard: Fix "add new account" if the wizard is already visible
...
Clicking on the "Add new Account" from the systray menu should raise
the wizard, even if it is already running.
Relates to issue #6105
2017-10-20 12:41:48 +02:00
Olivier Goffart
a0e50670de
Shibolleth: raise the browser when clicking on the tray
...
Issue #6105
Dynamically find the browser trough topLevelWidgets instead of
forwarding the call to the relevant page as it would require to break
many abstration layers (OwncloudSetupWizard -> OwncloudWizard ->
AbstractCredentialsWizardPage -> OwncloudShibbolethCredsPage)
And considering that we want to phase shibboleth down, I tought is
was not worth adding an interface for this.
The OAuth page don't have this problem because it shows a label and
allow the user to re-open the browser.
2017-10-20 10:51:35 +02:00
Jenkins for ownCloud
984631d807
[tx-robot] updated from transifex
2017-10-20 02:21:27 +02:00
Olivier Goffart
a9761a8976
Use qEnvironmentVariable* instead of qgetenv when appropriate
...
Now that we use Qt5, we should do that. It is slightly more efficient
and declares the intent.
(Modified using clazy)
2017-10-19 13:57:49 +02:00
Jenkins for ownCloud
84d8624e03
[tx-robot] updated from transifex
2017-10-19 02:21:00 +02:00
Tomaz Canabrava
1a47052aa3
[CSE] Remove unused function
...
This is already being called from somwhere else.
2017-10-18 21:51:39 +02:00
Tomaz Canabrava
e0988f482c
[CSE] Build fix
...
- change the name of one Qt Message Handler
- changed parameter from int to QString
2017-10-18 21:51:39 +02:00
Tomaz Canabrava
d83e8819ce
[CSE] SetEncryptionFlagApiJob
...
This new job sets the Encryption Flag in a folder.
2017-10-18 21:51:39 +02:00
Tomaz Canabrava
623eb29845
[CSE] Helper functions for the URL's
2017-10-18 21:51:39 +02:00
Tomaz Canabrava
1436d5bac1
[CSE] Better debug output
2017-10-18 21:51:39 +02:00
Tomaz Canabrava
0b50afe915
[CSE] Correctly Set's the client as connected
...
If we manage to encrypt and upload the private key
to the server, the client is in it's connected state.
2017-10-18 21:51:39 +02:00
Tomaz Canabrava
cfb6e3be8c
[CSE] Send the Private Key to the server
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
78136a10b0
[CSE] Debug statements to help find the encrypt error
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
08dfe86f37
[CSE] Adjust the calls to ent-to-end encryption
...
We changed the name.
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
0f1480728e
[cse] Use fake data to verify the encryption
...
beware, this is broken.
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
ba3d2a61d5
[cse] Call the encrypt and decrypt functions on fake data
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
e0d368cbb3
[cse] Update the encrypt and decrypt algorithm to GCM
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
4f7265c04f
[aes] Create the Decrypt function.
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
6b53b4f257
[cse] Add the crypt method, based on OpenSSL Wiki
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
77c0309e02
[cse] use PKCS5_PBKDF2_HMAC_SHA1 on the random-word passphrase
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
5395fc56b1
[cse] Start the encryption algorithm for the Private Key
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
fd00e180f5
[aes] fix out of bounds access.
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
60729f1fc4
[cse] Enable OpenSSL for encryption
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
418401a33c
[cse] new method, getUnifiedString
...
Enter a string list, return a string.
2017-10-18 21:51:38 +02:00
Tomaz Canabrava
2111aeaac1
[cse] Add wordlist & related methods.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
69c709714d
[cse] Save signed key on disk
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
090336c928
[cse] Correctly send the CSR
...
finally.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org >
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
307dfd195c
[cse] Call the CSR job.
...
There's something wrong on the CSR job that I need to discover.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
304231811d
[cse] Start the job to sign the public key.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
ecb05020a9
[cse] Do not save the certificate on disk
...
Store it on memory, and discard it as soon as no longer
needed.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
d2992d92ba
[cse] Generate the CSE
...
I still need to send it to the server. It's been a long
learning with the OpenSSL library.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
c358980448
[cse] Link Against OpenSSL
...
For some reason, this was working untill I added a call
to X509_REQ_get_subject_name, then the linking suddenly
stopped working (even tougth I'm using a ton of other
OpenSSL calls)
Force to link against 1.0
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
42a3098595
[cse] s/scr/csr
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
58e2e6b30b
[cse] Generate the public / private keys and store locally
...
Now I need to understand what the hell I need to do
to send this to the server.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
8c342cb1dd
[cse] Generate the KeyPair
...
Not stored anywhere yet, but it's correctly running.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
17693a75e5
[cse] Request public key from server
...
This is the first step needed to properly communicate.
Next, get private key.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
f4bbec1019
[bugfix] Return the error code, don't discard it.
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
29b64640fa
[cse] Start to fetch the basics to fetch the key from the server
2017-10-18 21:51:37 +02:00
Tomaz Canabrava
3f4d915a17
[cse] Add files to handle client side encryption
...
This will be the responsible for encryption,
decryption and talking with the server.
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
7e2085375f
[cse] Invalid read of 1
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
1c85f94b00
[cse] Use server capabilities to query for cse
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
920047fa70
[CSE] Remove uneeded includes
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
f7e74f520b
[CSE] Call encrypt and unencrypt from the GUI
...
If the server allows client side encryption, show
the user the menu with the encrypt and unencrupt options
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
5b51346e83
[CSE] New Network Job: DeleteApiJob
...
This network job does a DELETE http request on a URL. It's the
second class that does basically the same, but this one returns
the http return code, and it's set to do a api call.
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
e2091bb0a3
[CSE] Add FileIdRole for the FolderStatusModel
...
This way we can actually request the id from outside of the model.
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
9870f39dcb
[CSE] Fetch file-id for subfolders
...
File id is a must if we want to call any API.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org >
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
9318c487b9
[CSE] Display menu for encrytp / decryot folders
...
If the server supports client syde encryption, display
a menu on right click that should display encrypt and decrypt.
ideally it would show the encrypt if the folder is decrypted, and
decrypt if the folder is encrypted but currently there's no way
for the client to know that.
2017-10-18 21:51:36 +02:00
Tomaz Canabrava
1c32f6bb2e
[CSE] Check the server for client side encryption
...
Call the apps api and check if the response has
the client_side_encryption key.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org >
2017-10-18 21:51:36 +02:00
Roeland Jago Douma
f9b1c724d6
Merge pull request #19 from nextcloud/no_5.6_drone
...
Our 5.6 container is to old. Lets focus on the others for now
2017-10-18 21:29:47 +02:00
Roeland Jago Douma
4946848d08
Out 5.6 container is to old. Lets focus on the others for now
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-10-18 21:14:19 +02:00
Roeland Jago Douma
f56e1d167d
Merge pull request #18 from nextcloud/up_mas
...
Update to oC master
2017-10-18 21:13:24 +02:00
Roeland Jago Douma
bc7e65b395
Merge branch 'master' of https://github.com/owncloud/client
2017-10-18 21:03:15 +02:00
Markus Goetz
9866010b4c
SettingsDialogMac: Fix account display name #6078
2017-10-18 10:41:01 +02:00
Markus Goetz
a3c1052cae
owncloudcmd: Fix timestamps, Fix --logdebug
...
We did not set a log handler so there were no timestamps.
The --debug didn't have an effect, let's use --logdebug like in GUI version.
(Command line always outputs some log)
Found in owncloud/documentation#3436
2017-10-18 09:16:05 +02:00
Jenkins for ownCloud
726cbc160c
[tx-robot] updated from transifex
2017-10-18 02:19:58 +02:00
Christian Kamm
bf39343920
Sync: Add capability for invalid filename regexes #6092
2017-10-17 17:15:49 +02:00
Markus Goetz
af24b4132d
Packaging: Require ZLIB
...
For owncloud/enterprise#2295
2017-10-17 16:53:11 +02:00
Markus Goetz
d339b68715
Checksums: Use addData function
...
Our implementation had bad error handling.
This one now uses a new Qt5 addData function.
owncloud/enterprise#2252
2017-10-17 13:26:54 +02:00
Dominik Schmidt
7f51803d04
Only use $(MAKE) in doc target if make is used as generator
...
The old behavior broke builds with other CMake generators like Ninja as it obviously has no concept of $(MAKE)
2017-10-17 12:50:34 +02:00
Jenkins for ownCloud
eadc791795
[tx-robot] updated from transifex
2017-10-17 12:43:06 +02:00
Jenkins for ownCloud
408cf11b2b
[tx-robot] updated from transifex
2017-10-17 12:40:55 +02:00
Markus Goetz
e3ba8d3209
Merge branch 'master' into 2.4
2017-10-17 12:37:20 +02:00
Christian Kamm
17b1c83ae5
Activity: Allow sorting of issues and protocol #6086
...
The issues tab uses custom ordering where overall and summary sync
issues are displayed first. This ordering is preserved by creating
special sorting logic for the "time" column.
It needed special handling anyway, since sorting by time-string would
have yielded incorrect results.
2017-10-17 09:47:57 +02:00
Christian Kamm
b2a8ffc577
Abort: Fix crash with early aborts
...
_chunkCount could be 0, leading to a floating point exception
I also added initializers for several uninitialized integers in the
upload jobs.
2017-10-17 09:44:52 +02:00
Christian Kamm
e2711224ed
Propagator: Avoid duplicate async abort
2017-10-17 09:44:52 +02:00
Christian Kamm
2ac7e0200a
Test case for #5949
2017-10-17 09:44:52 +02:00
Christian Kamm
e6b971b316
TestUtils: Invalidate etags on PUT or chunk-MOVE
2017-10-17 09:44:52 +02:00
Christian Kamm
111bb485ec
UploadNG: Avoid div-by-zero for super fast uploads
2017-10-17 09:44:52 +02:00
Piotr Mrowczynski
e10775d34f
Fix paused sync file move issue #5949
...
Dont abort final chunk immedietally
Use sync and async aborts
2017-10-17 09:44:52 +02:00
Jenkins for ownCloud
30957479a3
[tx-robot] updated from transifex
2017-10-17 02:18:34 +02:00
Jenkins for ownCloud
b4ab53dd32
[tx-robot] updated from transifex
2017-10-16 02:18:33 +02:00
Jenkins for ownCloud
a314eeb892
[tx-robot] updated from transifex
2017-10-15 02:18:35 +02:00
Jenkins for ownCloud
644ddf318c
[tx-robot] updated from transifex
2017-10-14 02:18:36 +02:00
Christian Kamm
f598ac89ac
HttpCreds: Fix retry after wrong password #5989
...
This is an ugly solution.
2017-10-13 14:24:37 +02:00
Christian Kamm
3f7b3ca962
Checksums: Improve logging and add global disable #5017
2017-10-13 13:08:20 +02:00
Jenkins for ownCloud
104c6edcde
[tx-robot] updated from transifex
2017-10-13 02:18:37 +02:00
Jenkins for ownCloud
94b673dc8e
[tx-robot] updated from transifex
2017-10-12 02:18:38 +02:00
Christian Kamm
096cd348f0
Doc: Update FAQ entry on deeply nested directories #1067
2017-10-11 16:01:46 +02:00
Christian Kamm
01c2ffe2ae
PropagateDownload: Read Content-md5 header #6088
2017-10-11 09:06:23 +02:00
Jenkins for ownCloud
0a4370236d
[tx-robot] updated from transifex
2017-10-11 02:18:35 +02:00
Jenkins for ownCloud
fe8d2b397e
[tx-robot] updated from transifex
2017-10-10 02:18:44 +02:00
Christian Kamm
92e90f9c55
Context menu: More detailed status messages
...
Previously it could only display synchronization progress or "up to
date". Now it also communicates the same overall state that the icon
shows.
See owncloud/enterprise#2134
2017-10-09 14:14:31 +02:00
Roeland Jago Douma
9eabd2a32a
Merge pull request #6 from nextcloud/mergeWithOrigin
...
Update master from current owncloud master
2017-10-09 08:50:13 +02:00
Jenkins for ownCloud
3eb2642b11
[tx-robot] updated from transifex
2017-10-09 02:18:35 +02:00
Jenkins for ownCloud
99192a6dec
[tx-robot] updated from transifex
2017-10-08 02:18:36 +02:00
Jenkins for ownCloud
cffc1fd1c4
[tx-robot] updated from transifex
2017-10-07 02:18:37 +02:00
Olivier Goffart
b8f7c6daae
CMakeLists.txt: Put -pie as a linker flag were it belongs
...
Fixes warning introduced by PR #6040
2017-10-06 14:35:56 +02:00
Markus Goetz
cd07865da6
Settings Dialog: Fix display name compilation for macOS #6078
2017-10-06 13:34:40 +02:00
Thomas Müller
315e38e814
Use display-name from the ocs call in the settings dialog
2017-10-06 10:59:20 +02:00
Jenkins for ownCloud
95b90271b6
[tx-robot] updated from transifex
2017-10-06 02:18:35 +02:00
Christian Kamm
19c6757a0f
Rename detection: File size must be equal
...
Comparison of file sizes for potential conflicts was added in
0eb9401c62 , but did not extend to checking
the file size in case of potential local moves.
This commit adds this check and adds tests for various move+change
scenarios.
2017-10-05 22:01:42 +02:00
Christian Kamm
3636a59830
t9.pl: Make more reliable
...
Sometimes the 'touch' didn't change the mtime since too little time had
passed!
2017-10-05 22:01:42 +02:00
Markus Goetz
548302c367
ChangeLog: Re-format and re-order
2017-10-05 22:01:42 +02:00
Markus Goetz
a64a33c589
ChangeLog: More 2.4.0 changes
2017-10-05 22:01:42 +02:00
Christian Kamm
01bbbb7d08
Excludes: Fix bug with escapes in the regex, add tests
2017-10-05 22:01:42 +02:00
Christian Kamm
f609ea3bef
Excludes: optimize csync_is_windows_reserved_word
2017-10-05 22:01:42 +02:00
Markus Goetz
91223b1a3d
Excludes: During directory traversal, use QRegularExpression
...
On Mac, this halves the time spent in csync_excluded_traversal
when using check_csync_excluded_performance. A similar performance
increase is seen on linux.
2017-10-05 22:01:42 +02:00
Jenkins for ownCloud
ca0f9825ce
[tx-robot] updated from transifex
2017-10-05 22:01:42 +02:00
Markus Goetz
f202593ce4
sqlite: Update bundled version to 3.20.1
...
For OS X and Windows.
2017-10-05 22:01:42 +02:00
Jürgen Weigert
d8ed9e5bde
use IS_DIRECTORY ${CMAKE_SOURCE_DIR}/admin
...
We need to test presence of admin folder using ${CMAKE_SOURCE_DIR}, or it is always false. Bad for ox, (good for everything else)
2017-10-05 22:01:39 +02:00
Jenkins for ownCloud
c436b36b89
[tx-robot] updated from transifex
2017-10-05 22:01:39 +02:00
Jenkins for ownCloud
980bab422a
[tx-robot] updated from transifex
2017-10-05 22:01:39 +02:00
Jenkins for ownCloud
6fbd3cf61a
[tx-robot] updated from transifex
2017-10-05 22:01:39 +02:00
Jenkins for ownCloud
e6e1f765bd
[tx-robot] updated from transifex
2017-10-05 22:01:39 +02:00
Jenkins for ownCloud
b2fe501706
[tx-robot] updated from transifex
2017-10-05 22:01:38 +02:00
rockihack
2bfd85e3c7
Linux Hardening
...
see: https://wiki.debian.org/Hardening#User_Space
2017-10-05 22:01:38 +02:00
Jenkins for ownCloud
e1eb374ac3
[tx-robot] updated from transifex
2017-10-05 22:01:38 +02:00
Jürgen Weigert
ea2c3828cb
Update clean_tarball.sh
...
warning against removing sqlite. it is used with Linux with cmake switch on CentOS6
USE_OUR_OWN_SQLITE3=TRUE
2017-10-05 22:01:38 +02:00
Jürgen Weigert
c1e2bdc3d2
Update CMakeLists.txt
...
Make admin folder optional. It is needed for osx, but it is deleted from Linux builds for the sake of easier license review as discussed in https://github.com/owncloud/client/issues/6005
2017-10-05 22:01:38 +02:00
Jürgen Weigert
09c3043c85
support old sqlite before 3.7.7
...
quickfix: define the symbol for backwards compat
or FIXME: better solution #ifdef SQLITE_IOERR_SHMMAP where needed...
2017-10-05 22:01:38 +02:00
Olivier Goffart
0a8c394ee9
fixup! [tx-robot] updated from transifex
2017-10-05 22:01:38 +02:00
Olivier Goffart
cd44d8ed77
Test OAuth2
...
Include a test for PR #6057
2017-10-05 22:01:38 +02:00
Olivier Goffart
cfc38753b4
SyncEngine: _hasNoneFiles should be set when there are INSTRUCTION_UPDATE_METADATA
2017-10-05 22:01:38 +02:00
Olivier Goffart
c424dec7d4
OAuth: fix compilation with old gcc
...
We need to used QPointer::data in the signal slot connection
Relates to pr #6065
2017-10-05 22:01:38 +02:00
Jenkins for ownCloud
78078b714e
[tx-robot] updated from transifex
2017-10-05 22:01:38 +02:00
Markus Goetz
36117336e7
Updater: Rudimentary support for beta channel
...
So we can get people update from our alpha to the beta and rc
2017-10-05 22:01:38 +02:00
Olivier Goffart
d59c146488
Fix encoding of version string
2017-10-05 22:01:38 +02:00
Olivier Goffart
6583ebdcd9
csync_rename: optimize lookup
...
Avoid many memory allocations in reconcile
2017-10-05 22:01:38 +02:00
Olivier Goffart
917e2e43c6
csync_reconcile: Optimize reconcile by avoiding alocations
...
Fix performence regression from commit d66c2b5fae
For every new file we would look up every parent directories. Allocating
a new QByteArreay for every parent riectory just to know if it is in the other
tree is wasting lots of CPU.
Use a ByteArrayRef trick, similar to QStringRef
2017-10-05 22:01:37 +02:00
Dominik Schmidt
bdd3dc743b
Set CMAKE_INSTALL_RPATH as RPATH for installed executables
2017-10-05 22:01:37 +02:00
Christian Kamm
9143ddd0ad
Packaging: Add options for fine-grained builds #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-10-05 22:01:37 +02:00
Christian Kamm
f46440eb67
Packaging: Adjust APPNAME handling #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-10-05 22:01:37 +02:00
Christian Kamm
96a6d64500
Packaging: Make check for theme.qrc more specific #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-10-05 22:01:37 +02:00
Christian Kamm
08bc21937b
Packaging: Change directory for docs #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-10-05 22:01:37 +02:00
Christian Kamm
f64519bfbd
Move the --version output text to Theme #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-10-05 22:01:37 +02:00
Jenkins for ownCloud
494df32ee4
[tx-robot] updated from transifex
2017-10-05 22:01:37 +02:00
Olivier Goffart
bbbd2319ed
Use QDateTime::currentDateTimeUtc instead of the non utc version
...
QDateTime::currentDateTime is terribly slow.
2017-10-05 22:01:37 +02:00
Olivier Goffart
79c775bcd8
OAuth: Fix crash when closing the browser while identifying
...
To reproduce, log in and click "authorize" on the browser, then close
the browser before the client has replied, (but after redirected to localhost,
i.e. when the client is asking the server for the token)
The problem is that socket can be destroyed so we don't need to answer on a
destroyed socket.
2017-10-05 22:01:37 +02:00
Olivier Goffart
a3b1597d17
OwnSQL: don't parse the error message when we are done
2017-10-05 22:01:37 +02:00
Jocelyn Turcotte
ecb4e96794
SyncJournalDb: Reimplement the db_is_empty logic from csync
...
This reduces the initial sync local discovery time from
2.0 to 0.6 seconds in LargeSyncBench on my machine.
2017-10-05 22:01:37 +02:00
Jocelyn Turcotte
185cb2e39a
Use SyncJournalDb in csync
...
This gets rid of the csync_statedb sqlite layer and use
the same code and same connection as the rest of the SyncEngine.
Missing functions are added to SyncJournalDb and change a few minor
things (like changing SyncJournalFileRecord::_modtime to be an int64
instead of a QDateTime, like it was in csync).
2017-10-05 22:01:37 +02:00
Jocelyn Turcotte
c6610f6fbf
SyncJournalDB: Allow callers of getFileRecord if the query failed
...
The current implementation would return the same value whether the query failed
or if no row would be found. This is something that is currently checked by csync
and needs to be provided if we want to use SyncJournalDB there.
Adjusted all call sites to also check the return value even though they
could still just rely on rec.isValid(), but makes it more explicit as to what
happens for database errors in those cases, if we ever want to gracefully handle
them.
2017-10-05 22:01:37 +02:00
Jocelyn Turcotte
d76ecf015c
SyncJournalDB: Bind phash as a qlonglong instead of a QString
...
This is what csync does and we don't need to pass it as a string
to let sqlite convert it back to a uint64 later.
2017-10-05 22:01:36 +02:00
Jenkins for ownCloud
312f3a9bf3
[tx-robot] updated from transifex
2017-10-05 22:01:36 +02:00
Olivier Goffart
fd9662b803
bandwidthmanager: Fix unregistering devices on delete
...
from the destroyed signal, qobject_cast won't work because the object
is already destroyed. One must use reinterpret_cast then
2017-10-05 22:01:36 +02:00
Olivier Goffart
37810c0a19
PropagateUpload: Fix another non-normalized connect that appears while profiling
2017-10-05 22:01:36 +02:00
Olivier Goffart
38a76ac5bf
benchlargesync: Do several syncs
...
Make sure there is already a small sync before so the database is queried.
Make also a sync after to run an update with many files in the database.
2017-10-05 22:01:36 +02:00
Olivier Goffart
d100f9ac67
c_utf8_from_locale: optimize the UTF8 case on Linux
...
Avoid converting to a QString as an intermediate step
2017-10-05 22:01:36 +02:00
Olivier Goffart
5fc864adb6
csync: use a unordered_map for the FileMap
...
Saves more than 10% of csync_update on LargeSyncBench
2017-10-05 22:01:36 +02:00
Jenkins for ownCloud
2738d5d9ab
[tx-robot] updated from transifex
2017-10-05 22:01:36 +02:00
Olivier Goffart
0936cfee5d
chsck_vio: fix readdir test by removing it.
...
The code that was creating the files in the directory was removed in
commit 6906b8d30c . The directory is empty
so the result is expected to be null. It was passing before because the
code was returning an entry for . and .., but since commit
35f80bd439 this is no longer the case
2017-10-05 22:01:36 +02:00
Olivier Goffart
38962ca694
csync_update: fix assert
...
Amend 1dc44c0f62
2017-10-05 22:01:36 +02:00
Jenkins for ownCloud
7e677516ae
[tx-robot] updated from transifex
2017-10-05 22:01:36 +02:00
Markus Goetz
cabf7a79d5
macOS: Fix compile
2017-10-05 22:01:36 +02:00
Olivier Goffart
2b12990f19
Httpcreds: Fix double slash in the Request App Password url
...
Issue #6044
2017-10-05 22:01:36 +02:00
Olivier Goffart
3184d4bb32
OAuth2: Fix double slash in URL
...
We need to use concatPath to avoid possible double '/' in the URLs if the
account url() ends with '/'.
This has become even more of a problem since commit
d1b8370a4a which was resolving the url after
a redirect where most server actually add a '/' if the url is a folder
2017-10-05 22:01:36 +02:00
Jenkins for ownCloud
0cbbea9796
[tx-robot] updated from transifex
2017-10-05 22:01:35 +02:00
Olivier Goffart
b19677ea97
csync_vio_local: merge readdir and stat in the same call
...
For the remote this was already done long time ago
For windows, this was already partially done
The goal is to avoid needless conversion of the path to local encoding.
2017-10-05 22:01:35 +02:00
Olivier Goffart
dc0a0841fa
csync_update/reconcile: replace CSYNC_LOG with qDebug/qInfo
...
CSYNC_LOG has quite an overhead as it uses vsprintf and it might
be run even if the category is disabled
2017-10-05 22:01:35 +02:00
Christian Kamm
351e65309c
SyncEngine: Adjust free space messaging
...
Before, the way the info message was phrased implied a failure. And
since the large numbers can be hard to compare that can be confusing.
2017-10-05 22:01:35 +02:00
Olivier Goffart
e36c8678d9
csync: remove unused type
2017-10-05 22:01:35 +02:00
Olivier Goffart
f793de4629
RemotePermissions: Store in a class rather than in a QByteArray to save memory
...
Create a specific type that parses the permissions so we can store
it in a short rather than in a QByteArray
Note: in RemotePermissions::toString, we make sure the string is not
empty by adding a space, this was already existing before commit
e8f7adc7ca where it was removed by mistake.
2017-10-05 22:01:35 +02:00
Jenkins for ownCloud
cd4908ac6a
[tx-robot] updated from transifex
2017-10-05 22:01:35 +02:00
Olivier Goffart
0ad05aee0d
Port to new signal-slot syntax what cannot be done automatically
...
Some slot were protected or private but needed to be public.
Some needed a static_cast (can't use qOverload because it is in Qt 5.7)
This is not only a partial change.
2017-10-05 22:01:35 +02:00
Olivier Goffart
190f821d93
DiscoveryPhase: use the new syntax in disconnect
...
Since we used the new syntax in connect, we need to use it in disconnect
2017-10-05 22:01:35 +02:00
Olivier Goffart
7aca2352be
Use the Qt5 connection syntax (automated with clazy)
...
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.
This commit only contains calls that were automatically converted with clazy.
2017-10-05 22:01:35 +02:00
Olivier Goffart
3143b32aa5
test/stub: add some call required by the next patches
...
As we use the new connection syntax in folderman.cpp, some more symbol
need to be mocked
2017-10-05 22:01:35 +02:00
Olivier Goffart
e8a76859c1
Include <QAuthenticator> from code that connect to signal that uses it
...
The new connection syntax will need that
2017-10-05 22:01:35 +02:00
Olivier Goffart
c219ceea52
Gui: Use lambda instead of QSignalMapper
...
It's simpler, and QSignalMapper is deprecated in Qt 5.10
2017-10-05 22:01:34 +02:00
Olivier Goffart
608f5034ef
Remove settingsdialog.cpp.Rbt431
2017-10-05 22:01:34 +02:00
Jenkins for ownCloud
78458662a5
[tx-robot] updated from transifex
2017-10-05 22:01:34 +02:00
Markus Goetz
800dd485ef
ChangeLog: More 2.4.0 changes
2017-10-05 22:01:34 +02:00
Jenkins for ownCloud
f4ca43293b
[tx-robot] updated from transifex
2017-10-05 22:01:34 +02:00
Christian Kamm
6161b5519b
Fix compile with bad strrchr signature
2017-10-05 22:01:34 +02:00
Christian Kamm
2cac928810
Conflicts: Upload them files if env variable says so
...
Set OWNCLOUD_UPLOAD_CONFLICT_FILES=1 to trigger this behavior.
Note that this is experimental and unsupported. The real feature is
likely to end up in 2.5.
Uploading conflict files is simply done by removing the pattern from
csync_exclude. The rest here deals with making the conflict notification
ui approximately work.
There are still some concerns about where an uploaded conflict file
appears in the sync protocol and issues list (it should be in both, but
is only in one of them currently!).
See #4557 .
2017-10-05 22:01:34 +02:00
Christian Kamm
05927b68a8
Private links: Retrieve link through propfind property #6020
...
* The sharing ui does a propfind anyway: use that to query the new
property as well!
* For the socket api, asynchronously query the server for the right url
when an action that needs it is triggered.
The old, manually generated URL will be used as fallback in case the
server doesn't support the new property or the property can't be
retrieved for some reason.
Depends on owncloud/core#29021
2017-10-05 22:01:34 +02:00
Jenkins for ownCloud
b3f90111e2
[tx-robot] updated from transifex
2017-10-05 22:01:34 +02:00
Jocelyn Turcotte
254f6291df
Fix the build (make install)
2017-10-05 22:01:34 +02:00
Olivier Goffart
faa7fd1b32
Gui: Allow to add multiple sync folder connection of the same folder
...
... or child folders
There is also no real reason to forbid the user from syncing the same
folder to multiple location on its hardrive.
A real use case is when the user uncheck a big directory using "choose
what to sync", but would still like to sync a folder within this disabled
tree. The user can now do this with the "add folder" feature
Since 2.3, we even support syncing the same local folder to multiple
remote folder, so why not allow syncing the same remote folder several
times?
Relates to issue #3645
2017-10-05 22:01:34 +02:00
Jocelyn Turcotte
76d95f8b87
SyncJournalDB: Only reset_and_clear_bindings once
...
We only need to do it once between each query execution and
that can be right before the first bind.
2017-10-05 22:01:34 +02:00
Jocelyn Turcotte
4e90bd7a5a
csync_update: Remove the check for csync_get_statedb_exists
...
This always returns true since _csync_statedb_is_empty also always
returns true. This function was initially intended to be a shortcut
in case the database doesn't contain any row, but has been broken since
27fb5d9128 and now won't return false
unless the statement fails.
The _last_db_return_error in _csync_detect_update would take care
of that code path in a more direct and clearer way anyway.
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
81e32e1a08
Move SyncJournalDB to src/common
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
98ef3050d8
Reverse the dependency between SyncJournalFileRecord and SyncFileItem
...
This will allow us to also use the SyncJournalDB in csync.
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
4c2e078eac
Move non-csync-dependent parts of FileSystem to src/common
...
This keep the csync-dependent parts in src/libsync, slitting the namespace
over two files.
This will allow moving SyncJournalDB to src/common as well.
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
dc3c3195b5
Update sync-algorithm.md
...
The rbtree was replaced by a std::map.
2017-10-05 22:01:33 +02:00
Christian Kamm
cda72effe2
Checksums: Clearer behavior and added testing
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
0f21ed6a5b
Remove SyncFileItem::_isDirectory
...
It's always equivalent to _type == SyncFileItem::Directory.
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
85a93efe51
Remove SyncFileItem::log
...
This remove the remaining "other" fields of the sync log to save a
bit of memory.
other_etag and other_fileId don't give much information to the users
and other_instruction will always be INST_NONE anyway.
other_modtime and other_size are kept since they are sometimes used.
They were renamed to have a bit more meaningful name.
SyncEngine::checkPermissions will now fetch its information from the
csync trees since they are now preserved until right after this point.
Fixes #3213
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
82dd1775eb
Remove SyncEngine::_remotePerms
...
Now that csync is using a more convenient data structure for
its file trees, wait a little bit longer before destroying them and
fetch the remote permissions from the remote tree there instead.
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
3bc1f63b0a
Remove the usage of phash in csync
...
Only store the path since they represent the same thing, and do the
phash conversion during DB lookup like done in libsync.
We could get rid of everything since we also have an index on the path
column, but since it's the primary key this makes the migration non-trivial.
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
2276df1eec
Replace the custom rbtree by a std::map
2017-10-05 22:01:33 +02:00
Jocelyn Turcotte
ec52807e29
csync: Keep the csync_file_stat_t instances created during discovery
...
Now that they use the same structure, avoid _csync_detect_update
having to recreate another instance and transfer everything manually.
Any instance created during discovery should now be used all the way
up to SyncEngine::treewalkFile.
This also makes sure that the path and types are properly set in that
object instead of having to pass everything as separate parameters.
This gets rid of csync_ftw_flags_e which was now converted from,
and to csync_ftw_type_e, already in the csync_file_stat_t.
Issue #1817
2017-10-05 22:01:33 +02:00
Jenkins for ownCloud
7f88a3e1cd
[tx-robot] updated from transifex
2017-10-05 22:01:33 +02:00
Jenkins for ownCloud
74049e3e92
[tx-robot] updated from transifex
2017-10-05 22:01:33 +02:00
Jenkins for ownCloud
d01c7dc7db
[tx-robot] updated from transifex
2017-10-05 22:01:33 +02:00
Christian Kamm
b92de38c31
AbstractNetworkJob: Allow relative redirect
...
Previously all redirects were considered absolute.
2017-10-05 22:01:32 +02:00
Christian Kamm
78b082a23c
Reduce timeout for some admin jobs
...
The oauth token jobs and the wizard redirect check job shouldn't have
5min timeouts.
2017-10-05 22:01:32 +02:00
Christian Kamm
1aa1e7f833
Wizard: Handle url-shortener redirects #5954
...
Grab any permanent redirects from the base url the user entered
before attempting to connect to a modified url (with status.php
added).
2017-10-05 22:01:32 +02:00
Christian Kamm
4d2261420d
HttpCreds: Remove migration code from 1.7
2017-10-05 22:01:32 +02:00
Christian Kamm
23153a4866
Credentials: Use per-account keychain entries #5830
...
This requires a lot of migration code: the old entries need to be read,
saved to the new locations and then deleted.
2017-10-05 22:01:32 +02:00
Christian Kamm
7f75a533d1
Journal: Second attempt at journal mode fallback #5723
...
Some filesystems, vms or other limitations make using the WAL journal
mode impossible. We are notified of this problem through an sqlite
IOERR for SHMMAP. In that case We want to attempt to fall back to the
DELETE journal mode.
2017-10-05 22:01:32 +02:00
Christian Kamm
e47b8ffaca
OAuth: Don't use implicit POST bodies
...
The query args of POST requests become the request body. If there's a
redirect, the redirected url will therefore not contain the query
arguments. Use an explicit request body to make the redirection work.
2017-10-05 22:01:32 +02:00
Christian Kamm
a79b0a3791
OAuth: Pass client auth in header instead of url
...
To play more nicely with redirects.
2017-10-05 22:01:32 +02:00
Christian Kamm
ce51ea34b9
OAuth: Use redirectable jobs for oauth token management
2017-10-05 22:01:32 +02:00
Christian Kamm
0e8ce9c3db
PropagateUpload: Model of remote quota, avoid some uploads #5537
...
When we see a 507 error, assume that quota is < uploaded size.
2017-10-05 22:01:32 +02:00
Christian Kamm
76faf4937b
SyncOptions/Propagator: Parallelism as an option
...
Very useful for changing it on a per-test basis.
2017-10-05 22:01:32 +02:00
Christian Kamm
df05042e7f
Make DetailError different from BlacklistedError
...
It's quite different in regard to blacklist handling and overall
sync failure changes.
2017-10-05 22:01:32 +02:00
Helmut K. C. Tessarek
e8f17f5b0b
remove qt4 code
2017-10-05 22:01:32 +02:00
Jenkins for ownCloud
7d1285d313
[tx-robot] updated from transifex
2017-10-05 22:01:31 +02:00
Christian Kamm
72131ff4ce
Excludes: Allow escaping # #6012
...
Otherwise adding patterns that start with # are impossible to add, since
they get treated as comments. Also add this escaping for patterns added
in the ui.
2017-10-05 22:01:06 +02:00
Jenkins for ownCloud
c03d53e1dd
[tx-robot] updated from transifex
2017-10-05 22:01:05 +02:00
Jenkins for ownCloud
bc5a6527f9
[tx-robot] updated from transifex
2017-10-05 22:01:05 +02:00
Markus Goetz
7ca1107ea0
ChunkingNgTest: CI debuggability #6015
2017-10-05 22:01:05 +02:00
Christian Kamm
4acb70e79d
Journal: Fall back to DELETE on IO error #5723
...
Also add logging of extended error codes for this IO error, maybe we can
become more specific about which situations should trigger a journal
mode switch.
2017-10-05 22:01:05 +02:00
Christian Kamm
755b18db61
Folder: Check etag again after active sync #4116
...
Maybe more things were happening on the server?
2017-10-05 22:01:05 +02:00
Jenkins for ownCloud
bf8151a8ad
[tx-robot] updated from transifex
2017-10-05 22:01:05 +02:00
Christian Kamm
b810ce7768
Update server url in case of permanent redirection #5972
...
This is the first time the account url may update outside of
account setup.
Summary of redirection handling:
1. During account setup (wizard)
- status.php gets permanently redirected -> adjust url
- authed PROPFIND gets *any* redirection -> adjust url
2. During connectivity ping (ConnectionValidator)
- status.php gets permanently redirected -> adjust url (new!)
All other redirections should be followed transparently and
don't update the account url in the settings.
2017-10-05 22:01:05 +02:00
Christian Kamm
1c0d80c20d
Use DetermineAuthTypeJob in HttpCredentials
...
* Move it to networkjobs
* Minor adjustments to its logic
* Fixes redirect handling for oauth/basic http auth check #6003
2017-10-05 22:01:05 +02:00
Markus Goetz
ed9977a2b3
Add clean_tarball.sh #6005
2017-10-05 22:01:05 +02:00
Jenkins for ownCloud
546c7c420a
[tx-robot] updated from transifex
2017-10-05 22:01:05 +02:00
Jocelyn Turcotte
bdf3f1e271
Windows: Make sure that the folder and Desktop.ini have the right attributes ( #6018 )
...
When created from scratch, the owncloud icon won't be picked-up by
explorer unless the right attributes are set on both the sync root and the
Desktop.ini file.
Issue #2446
2017-10-05 22:01:04 +02:00
rockihack
4e90179065
Enable DEP & ASLR on Windows
2017-10-05 22:01:04 +02:00
Markus Goetz
43f85a787b
Remove qtkeychain submodule #6004
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
a8c33885bb
Fix the macOS Sparkle build
2017-10-05 22:01:04 +02:00
Christian Kamm
3591849279
Http credentials: Fix behavior for bad password #5989
...
When the GET request from askFromUser is scheduled on the QNAM inside
the slot that handles the QNetworkReply::finished signal, it seems to
not get processed at all.
This workaround moves the sending of the new GET to the event loop,
sidestepping the problem.
2017-10-05 22:01:04 +02:00
Christian Kamm
8a094d2b0e
Fix compile errors
...
cmocka seems to #define fail to something inappropriate.
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
deb123b80d
csync_statedb: (really) Make sure children of non-synced items aren't read from the DB
...
No tests are covering this and I reversed the original logic.
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
7a97dc1783
csync_statedb: Make sure children of non-synced items aren't read from the DB
...
Fix a regression during C++ conversion from 704ca366b3
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
41f215fd8d
Fix build after C++ conversion of csync
...
Use the same macro as in SyncFileItem for bitfields on enums.
Fixes #5993
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
e0fa5723eb
Use a C++ contructor and destructor for CSYNC
...
Merge csync_create and csync_init into the constructor and
replace csync_destroy with the destructor.
Also use a QByteArray for csync_s::root_perms and flatten
csync_rename_s as a rename sub-struct of csync_s since it
can now handle C++ types.
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
4947dc22ab
Remove csync_s::replica
...
The only difference with csync_s::current is that it's
assigned the value of csync_s::local::type and
csync_s::remote::type, which never change. So might as
well only use the "current" field with constants.
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
157e933ae5
Replace TREE_WALK_FILE with csync_file_stat_t
...
Just expose csync_file_stat_t since we don't need an abstraction layer
anymore. Also pass the nodes of both trees directly to the visitor
function.
Issue #1817
2017-10-05 22:01:04 +02:00
Jocelyn Turcotte
7fad474863
Replace csync_vio_file_stat_t with csync_file_stat_t
...
Also move csync_normalize_etag to common/utility since we
don't need the char* function anymore.
Remove the single space file_stat->remotePerm codepath since
this won't be used in csync anymore since
8de3bda0b1 .
Issue #1817
2017-10-05 22:01:04 +02:00
Matthew Setter
26dde9b543
Fix link to download the ownCloud client
...
This was requested in https://github.com/owncloud/documentation/issues/3354 .
2017-10-05 22:01:04 +02:00
Matthew Setter
b43e948167
Fix broken images in FAQ
...
This relates to https://github.com/owncloud/documentation/issues/3354 .
2017-10-05 22:01:03 +02:00
Jürgen Weigert
9da3822305
Update ChangeLog
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
61d949730b
Make csync_file_stat_t public and partly convert to C++
...
This is the first commit trying to unify csync_file_stat_s,
csync_vio_file_stat_s and csync_tree_walk_file_s. Use QByteArray
and unique_ptr already since I'm not used to track memory allocations
and this will make the transition easier.
Issue #1817
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
bfc7ea562d
Move Utility to a new common static library
...
Now that csync builds as C++, this will avoid having to implement
functionalities needed by csync mandatorily in csync itself.
This library is built as part of libocsync and symbols exported
through it.
This requires a relicense of Utility as LGPL. All classes moved into
this library from src/libsync will need to be relicensed as well.
2017-10-05 22:01:03 +02:00
Christian Kamm
6d8c98f6b4
Add minor unittest for numeric id extraction #5933
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
4aca1b9697
StatusTracker: Fix different case paths not matching ( #5981 )
...
Use a custom std::map comparator functor to do all comparisons
on contained QStrings using Qt::CaseInsensitive on macOS and Windows.
Issue #5257
2017-10-05 22:01:03 +02:00
Jürgen Weigert
f96990b489
fix branded nemo and caja shell integration ( #5966 )
...
* Update createcajaplugin.sh
* first apply branding, then create copies. Better.
Fixes https://github.com/owncloud/ownbrander/issues/753
* fix https://github.com/owncloud/ownbrander/issues/752 too.
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
7280359c66
Fix cmocka deprecation warnings
...
Just use cmocka_run_group_tests like we already use in
some of those tests.
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
b30c3202f0
Enable csync logs in unit tests
...
Go through the Logger to enable the csync-QDebug bridge.
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
ac4be17192
Compile almost all of csync as C++
...
This will allow us to unify data structures between csync and libsync.
Utility functions like csync_time and c_std are still compiled as C
since we won't need to be coupled with Qt in the short term.
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
39e9938cad
Use .cpp for existing csync .cc files
...
Make this consistent with the rest of the client code.
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
f897a91354
Move csync to src/csync
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
5948f26884
Move csync/tests to test/csync
2017-10-05 22:01:03 +02:00
Jocelyn Turcotte
95579b3de1
Move csync/tests/ownCloud to test/scripts/txpl
2017-10-05 22:00:57 +02:00
Christian Kamm
90befac901
Rename detection: File size must be equal
...
Comparison of file sizes for potential conflicts was added in
0eb9401c62 , but did not extend to checking
the file size in case of potential local moves.
This commit adds this check and adds tests for various move+change
scenarios.
2017-10-05 14:17:07 +02:00
Christian Kamm
22f71ce17e
t9.pl: Make more reliable
...
Sometimes the 'touch' didn't change the mtime since too little time had
passed!
2017-10-05 14:13:10 +02:00
Markus Goetz
0931f25747
ChangeLog: Re-format and re-order
2017-10-05 13:07:42 +02:00
Markus Goetz
971f2391cf
ChangeLog: More 2.4.0 changes
2017-10-05 12:52:50 +02:00
Christian Kamm
43a26eb50a
Excludes: Fix bug with escapes in the regex, add tests
2017-10-05 10:40:53 +02:00
Christian Kamm
99d406072f
Excludes: optimize csync_is_windows_reserved_word
2017-10-05 10:19:48 +02:00
Markus Goetz
3a1a56c7ad
Excludes: During directory traversal, use QRegularExpression
...
On Mac, this halves the time spent in csync_excluded_traversal
when using check_csync_excluded_performance. A similar performance
increase is seen on linux.
2017-10-05 10:19:48 +02:00
Jenkins for ownCloud
57cbba81e7
[tx-robot] updated from transifex
2017-10-05 02:18:35 +02:00
Markus Goetz
e48d55d126
sqlite: Update bundled version to 3.20.1
...
For OS X and Windows.
2017-10-04 17:12:12 +02:00
Jürgen Weigert
1c03fa8642
use IS_DIRECTORY ${CMAKE_SOURCE_DIR}/admin
...
We need to test presence of admin folder using ${CMAKE_SOURCE_DIR}, or it is always false. Bad for ox, (good for everything else)
2017-10-04 07:49:27 +02:00
Jenkins for ownCloud
670ff36024
[tx-robot] updated from transifex
2017-10-04 02:18:35 +02:00
Jenkins for ownCloud
6b3f6d9860
[tx-robot] updated from transifex
2017-10-03 02:18:33 +02:00
Jenkins for ownCloud
ac5876e94e
[tx-robot] updated from transifex
2017-10-02 02:18:33 +02:00
Jenkins for ownCloud
b13f44023d
[tx-robot] updated from transifex
2017-10-01 02:18:33 +02:00
Jenkins for ownCloud
2f15d8aef5
[tx-robot] updated from transifex
2017-09-30 02:18:32 +02:00
rockihack
ecaa37efbe
Linux Hardening
...
see: https://wiki.debian.org/Hardening#User_Space
2017-09-29 14:34:30 +02:00
Jenkins for ownCloud
33e421473c
[tx-robot] updated from transifex
2017-09-29 02:18:33 +02:00
Jürgen Weigert
eb1a96c164
Update clean_tarball.sh
...
warning against removing sqlite. it is used with Linux with cmake switch on CentOS6
USE_OUR_OWN_SQLITE3=TRUE
2017-09-28 21:09:43 +02:00
Jürgen Weigert
2afcac763d
Update CMakeLists.txt
...
Make admin folder optional. It is needed for osx, but it is deleted from Linux builds for the sake of easier license review as discussed in https://github.com/owncloud/client/issues/6005
2017-09-28 19:32:55 +02:00
Jürgen Weigert
28fe903aee
support old sqlite before 3.7.7
...
quickfix: define the symbol for backwards compat
or FIXME: better solution #ifdef SQLITE_IOERR_SHMMAP where needed...
2017-09-28 19:01:55 +02:00
Olivier Goffart
253d197ccb
fixup! [tx-robot] updated from transifex
2017-09-28 18:38:33 +02:00
Olivier Goffart
0ceb806f1a
Test OAuth2
...
Include a test for PR #6057
2017-09-28 18:38:33 +02:00
Olivier Goffart
800b9cf167
SyncEngine: _hasNoneFiles should be set when there are INSTRUCTION_UPDATE_METADATA
2017-09-28 11:15:36 +02:00
Olivier Goffart
1da398e6c6
OAuth: fix compilation with old gcc
...
We need to used QPointer::data in the signal slot connection
Relates to pr #6065
2017-09-28 10:55:28 +02:00
Jenkins for ownCloud
074cb132bb
[tx-robot] updated from transifex
2017-09-28 02:18:36 +02:00
Markus Goetz
2df74fd9d7
Updater: Rudimentary support for beta channel
...
So we can get people update from our alpha to the beta and rc
2017-09-27 16:23:34 +02:00
Roeland Jago Douma
cba78eb11f
Merge pull request #2 from nextcloud/update-readme
...
Update README
2017-09-27 14:03:23 +02:00
Roeland Jago Douma
cc7cb6b650
Remove templates for now
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-09-27 14:02:49 +02:00
Christoph Wurst
8eb466c9c5
Update README
...
Adjust branding and remove some sections
2017-09-27 14:00:02 +02:00
Olivier Goffart
d68b07dfc7
Fix encoding of version string
2017-09-27 12:06:49 +02:00
Olivier Goffart
a52dff713b
csync_rename: optimize lookup
...
Avoid many memory allocations in reconcile
2017-09-27 11:41:55 +02:00
Olivier Goffart
041c5e6d44
csync_reconcile: Optimize reconcile by avoiding alocations
...
Fix performence regression from commit d66c2b5fae
For every new file we would look up every parent directories. Allocating
a new QByteArreay for every parent riectory just to know if it is in the other
tree is wasting lots of CPU.
Use a ByteArrayRef trick, similar to QStringRef
2017-09-27 11:41:55 +02:00
Dominik Schmidt
a2ce739192
Set CMAKE_INSTALL_RPATH as RPATH for installed executables
2017-09-27 09:13:44 +02:00
Christian Kamm
ca4ad58a06
Packaging: Add options for fine-grained builds #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-09-27 09:13:44 +02:00
Christian Kamm
89df8fb692
Packaging: Adjust APPNAME handling #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-09-27 09:13:44 +02:00
Christian Kamm
9a021d2279
Packaging: Make check for theme.qrc more specific #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-09-27 09:13:44 +02:00
Christian Kamm
82e87805c3
Packaging: Change directory for docs #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-09-27 09:13:44 +02:00
Christian Kamm
844bfc5f25
Move the --version output text to Theme #5957
...
Extracted and adjusted from packaging.diff by @jnweiger and @dschmidt
2017-09-27 09:13:44 +02:00
Jenkins for ownCloud
706c68f69c
[tx-robot] updated from transifex
2017-09-27 02:18:33 +02:00
Olivier Goffart
13e0cc6b50
Use QDateTime::currentDateTimeUtc instead of the non utc version
...
QDateTime::currentDateTime is terribly slow.
2017-09-26 16:14:17 +02:00
Olivier Goffart
7af81f7665
OAuth: Fix crash when closing the browser while identifying
...
To reproduce, log in and click "authorize" on the browser, then close
the browser before the client has replied, (but after redirected to localhost,
i.e. when the client is asking the server for the token)
The problem is that socket can be destroyed so we don't need to answer on a
destroyed socket.
2017-09-26 14:56:57 +02:00
Olivier Goffart
278129b286
OwnSQL: don't parse the error message when we are done
2017-09-26 11:03:23 +02:00
Jocelyn Turcotte
54c522c861
SyncJournalDb: Reimplement the db_is_empty logic from csync
...
This reduces the initial sync local discovery time from
2.0 to 0.6 seconds in LargeSyncBench on my machine.
2017-09-26 11:03:23 +02:00
Jocelyn Turcotte
a034ee894c
Use SyncJournalDb in csync
...
This gets rid of the csync_statedb sqlite layer and use
the same code and same connection as the rest of the SyncEngine.
Missing functions are added to SyncJournalDb and change a few minor
things (like changing SyncJournalFileRecord::_modtime to be an int64
instead of a QDateTime, like it was in csync).
2017-09-26 11:03:23 +02:00
Jocelyn Turcotte
6f46764daa
SyncJournalDB: Allow callers of getFileRecord if the query failed
...
The current implementation would return the same value whether the query failed
or if no row would be found. This is something that is currently checked by csync
and needs to be provided if we want to use SyncJournalDB there.
Adjusted all call sites to also check the return value even though they
could still just rely on rec.isValid(), but makes it more explicit as to what
happens for database errors in those cases, if we ever want to gracefully handle
them.
2017-09-26 11:03:23 +02:00
Jocelyn Turcotte
e1d482ea7c
SyncJournalDB: Bind phash as a qlonglong instead of a QString
...
This is what csync does and we don't need to pass it as a string
to let sqlite convert it back to a uint64 later.
2017-09-26 11:03:23 +02:00
Jenkins for ownCloud
c34ec00d3a
[tx-robot] updated from transifex
2017-09-26 02:18:33 +02:00
Olivier Goffart
090abdee87
bandwidthmanager: Fix unregistering devices on delete
...
from the destroyed signal, qobject_cast won't work because the object
is already destroyed. One must use reinterpret_cast then
2017-09-25 12:56:20 +02:00
Olivier Goffart
ce04a76b17
PropagateUpload: Fix another non-normalized connect that appears while profiling
2017-09-25 12:49:55 +02:00
Olivier Goffart
2953eed729
benchlargesync: Do several syncs
...
Make sure there is already a small sync before so the database is queried.
Make also a sync after to run an update with many files in the database.
2017-09-25 12:49:55 +02:00
Olivier Goffart
bf2b089c5c
c_utf8_from_locale: optimize the UTF8 case on Linux
...
Avoid converting to a QString as an intermediate step
2017-09-25 10:35:28 +02:00
Olivier Goffart
3107e63040
csync: use a unordered_map for the FileMap
...
Saves more than 10% of csync_update on LargeSyncBench
2017-09-25 10:35:28 +02:00
Jenkins for ownCloud
2ec8194d01
[tx-robot] updated from transifex
2017-09-25 02:18:29 +02:00
Olivier Goffart
d113498c7b
chsck_vio: fix readdir test by removing it.
...
The code that was creating the files in the directory was removed in
commit 6906b8d30c . The directory is empty
so the result is expected to be null. It was passing before because the
code was returning an entry for . and .., but since commit
35f80bd439 this is no longer the case
2017-09-25 00:17:47 +02:00
Olivier Goffart
d8206ccbc7
csync_update: fix assert
...
Amend 1dc44c0f62
2017-09-25 00:17:47 +02:00
Jenkins for ownCloud
fbd8de1c24
[tx-robot] updated from transifex
2017-09-24 02:18:33 +02:00
Markus Goetz
81d9f94a29
macOS: Fix compile
2017-09-23 13:42:39 +02:00
Olivier Goffart
382cc444f0
Httpcreds: Fix double slash in the Request App Password url
...
Issue #6044
2017-09-23 10:10:40 +02:00
Olivier Goffart
0cec6f08ca
OAuth2: Fix double slash in URL
...
We need to use concatPath to avoid possible double '/' in the URLs if the
account url() ends with '/'.
This has become even more of a problem since commit
d1b8370a4a which was resolving the url after
a redirect where most server actually add a '/' if the url is a folder
2017-09-23 10:10:40 +02:00
Jenkins for ownCloud
2112e16cca
[tx-robot] updated from transifex
2017-09-23 02:18:30 +02:00
Olivier Goffart
35f80bd439
csync_vio_local: merge readdir and stat in the same call
...
For the remote this was already done long time ago
For windows, this was already partially done
The goal is to avoid needless conversion of the path to local encoding.
2017-09-22 16:18:18 +02:00
Olivier Goffart
1dc44c0f62
csync_update/reconcile: replace CSYNC_LOG with qDebug/qInfo
...
CSYNC_LOG has quite an overhead as it uses vsprintf and it might
be run even if the category is disabled
2017-09-22 11:12:19 +02:00
Christian Kamm
eae3f7ce0a
SyncEngine: Adjust free space messaging
...
Before, the way the info message was phrased implied a failure. And
since the large numbers can be hard to compare that can be confusing.
2017-09-22 11:07:27 +02:00
Olivier Goffart
aa322d41aa
csync: remove unused type
2017-09-22 09:58:55 +02:00
Olivier Goffart
95d23b1914
RemotePermissions: Store in a class rather than in a QByteArray to save memory
...
Create a specific type that parses the permissions so we can store
it in a short rather than in a QByteArray
Note: in RemotePermissions::toString, we make sure the string is not
empty by adding a space, this was already existing before commit
e8f7adc7ca where it was removed by mistake.
2017-09-22 09:29:08 +02:00
Jenkins for ownCloud
0464cdb43f
[tx-robot] updated from transifex
2017-09-22 02:18:30 +02:00
Olivier Goffart
35e4fe061d
Port to new signal-slot syntax what cannot be done automatically
...
Some slot were protected or private but needed to be public.
Some needed a static_cast (can't use qOverload because it is in Qt 5.7)
This is not only a partial change.
2017-09-21 14:05:39 +02:00
Olivier Goffart
02924ad83e
DiscoveryPhase: use the new syntax in disconnect
...
Since we used the new syntax in connect, we need to use it in disconnect
2017-09-21 14:05:39 +02:00
Olivier Goffart
ff4213b59f
Use the Qt5 connection syntax (automated with clazy)
...
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.
This commit only contains calls that were automatically converted with clazy.
2017-09-21 14:05:39 +02:00
Olivier Goffart
c4e51247d8
test/stub: add some call required by the next patches
...
As we use the new connection syntax in folderman.cpp, some more symbol
need to be mocked
2017-09-21 14:05:39 +02:00
Olivier Goffart
1218a38f2c
Include <QAuthenticator> from code that connect to signal that uses it
...
The new connection syntax will need that
2017-09-21 14:05:39 +02:00
Olivier Goffart
797f8087bc
Gui: Use lambda instead of QSignalMapper
...
It's simpler, and QSignalMapper is deprecated in Qt 5.10
2017-09-21 14:05:39 +02:00
Olivier Goffart
bf77ac6ba5
Remove settingsdialog.cpp.Rbt431
2017-09-21 09:25:45 +02:00
Jenkins for ownCloud
eafb006649
[tx-robot] updated from transifex
2017-09-21 02:18:30 +02:00
Markus Goetz
a9bf7a90ed
ChangeLog: More 2.4.0 changes
2017-09-20 14:44:33 +02:00
Jenkins for ownCloud
ee7593bbe3
[tx-robot] updated from transifex
2017-09-20 02:18:35 +02:00
Christian Kamm
30843cd368
Fix compile with bad strrchr signature
2017-09-19 12:44:59 +02:00
Christian Kamm
53195b064a
Conflicts: Upload them files if env variable says so
...
Set OWNCLOUD_UPLOAD_CONFLICT_FILES=1 to trigger this behavior.
Note that this is experimental and unsupported. The real feature is
likely to end up in 2.5.
Uploading conflict files is simply done by removing the pattern from
csync_exclude. The rest here deals with making the conflict notification
ui approximately work.
There are still some concerns about where an uploaded conflict file
appears in the sync protocol and issues list (it should be in both, but
is only in one of them currently!).
See #4557 .
2017-09-19 11:45:38 +02:00
Christian Kamm
dca2664707
Private links: Retrieve link through propfind property #6020
...
* The sharing ui does a propfind anyway: use that to query the new
property as well!
* For the socket api, asynchronously query the server for the right url
when an action that needs it is triggered.
The old, manually generated URL will be used as fallback in case the
server doesn't support the new property or the property can't be
retrieved for some reason.
Depends on owncloud/core#29021
2017-09-19 10:51:03 +02:00
Jenkins for ownCloud
e1dfc38a90
[tx-robot] updated from transifex
2017-09-19 02:18:38 +02:00
Jocelyn Turcotte
2e90e9c35b
Fix the build (make install)
2017-09-18 15:32:05 +02:00
Olivier Goffart
8f5110900c
Gui: Allow to add multiple sync folder connection of the same folder
...
... or child folders
There is also no real reason to forbid the user from syncing the same
folder to multiple location on its hardrive.
A real use case is when the user uncheck a big directory using "choose
what to sync", but would still like to sync a folder within this disabled
tree. The user can now do this with the "add folder" feature
Since 2.3, we even support syncing the same local folder to multiple
remote folder, so why not allow syncing the same remote folder several
times?
Relates to issue #3645
2017-09-18 15:17:06 +02:00
Jocelyn Turcotte
5e332983e2
SyncJournalDB: Only reset_and_clear_bindings once
...
We only need to do it once between each query execution and
that can be right before the first bind.
2017-09-18 14:00:52 +02:00
Jocelyn Turcotte
6e240a3e9c
csync_update: Remove the check for csync_get_statedb_exists
...
This always returns true since _csync_statedb_is_empty also always
returns true. This function was initially intended to be a shortcut
in case the database doesn't contain any row, but has been broken since
27fb5d9128 and now won't return false
unless the statement fails.
The _last_db_return_error in _csync_detect_update would take care
of that code path in a more direct and clearer way anyway.
2017-09-18 14:00:52 +02:00
Jocelyn Turcotte
a1f1775d15
Move SyncJournalDB to src/common
2017-09-18 14:00:52 +02:00
Jocelyn Turcotte
5fbed0d1cd
Reverse the dependency between SyncJournalFileRecord and SyncFileItem
...
This will allow us to also use the SyncJournalDB in csync.
2017-09-18 14:00:52 +02:00
Jocelyn Turcotte
bd25225045
Move non-csync-dependent parts of FileSystem to src/common
...
This keep the csync-dependent parts in src/libsync, slitting the namespace
over two files.
This will allow moving SyncJournalDB to src/common as well.
2017-09-18 14:00:52 +02:00
Jocelyn Turcotte
013eba0e79
Update sync-algorithm.md
...
The rbtree was replaced by a std::map.
2017-09-18 14:00:52 +02:00
Christian Kamm
78212e03d6
Checksums: Clearer behavior and added testing
2017-09-18 12:52:09 +02:00
Jocelyn Turcotte
a8ea7b0858
Remove SyncFileItem::_isDirectory
...
It's always equivalent to _type == SyncFileItem::Directory.
2017-09-18 11:46:09 +02:00
Jocelyn Turcotte
0e97770c47
Remove SyncFileItem::log
...
This remove the remaining "other" fields of the sync log to save a
bit of memory.
other_etag and other_fileId don't give much information to the users
and other_instruction will always be INST_NONE anyway.
other_modtime and other_size are kept since they are sometimes used.
They were renamed to have a bit more meaningful name.
SyncEngine::checkPermissions will now fetch its information from the
csync trees since they are now preserved until right after this point.
Fixes #3213
2017-09-18 11:46:09 +02:00
Jocelyn Turcotte
3d7bd7583b
Remove SyncEngine::_remotePerms
...
Now that csync is using a more convenient data structure for
its file trees, wait a little bit longer before destroying them and
fetch the remote permissions from the remote tree there instead.
2017-09-18 11:46:09 +02:00
Jocelyn Turcotte
bfacac8683
Remove the usage of phash in csync
...
Only store the path since they represent the same thing, and do the
phash conversion during DB lookup like done in libsync.
We could get rid of everything since we also have an index on the path
column, but since it's the primary key this makes the migration non-trivial.
2017-09-18 11:46:09 +02:00
Jocelyn Turcotte
d66c2b5fae
Replace the custom rbtree by a std::map
2017-09-18 11:46:09 +02:00
Jocelyn Turcotte
72e44ce3d7
csync: Keep the csync_file_stat_t instances created during discovery
...
Now that they use the same structure, avoid _csync_detect_update
having to recreate another instance and transfer everything manually.
Any instance created during discovery should now be used all the way
up to SyncEngine::treewalkFile.
This also makes sure that the path and types are properly set in that
object instead of having to pass everything as separate parameters.
This gets rid of csync_ftw_flags_e which was now converted from,
and to csync_ftw_type_e, already in the csync_file_stat_t.
Issue #1817
2017-09-18 11:46:09 +02:00
Jenkins for ownCloud
0806e0466c
[tx-robot] updated from transifex
2017-09-18 02:18:30 +02:00
Jenkins for ownCloud
c05ca51238
[tx-robot] updated from transifex
2017-09-17 02:18:29 +02:00
Jenkins for ownCloud
1a4a5bfc57
[tx-robot] updated from transifex
2017-09-16 02:18:35 +02:00
Christian Kamm
be5d5aea6d
AbstractNetworkJob: Allow relative redirect
...
Previously all redirects were considered absolute.
2017-09-15 15:25:10 +02:00
Christian Kamm
8635b8ac84
Reduce timeout for some admin jobs
...
The oauth token jobs and the wizard redirect check job shouldn't have
5min timeouts.
2017-09-15 15:25:10 +02:00
Christian Kamm
d1b8370a4a
Wizard: Handle url-shortener redirects #5954
...
Grab any permanent redirects from the base url the user entered
before attempting to connect to a modified url (with status.php
added).
2017-09-15 15:25:10 +02:00
Christian Kamm
1f57fd0407
HttpCreds: Remove migration code from 1.7
2017-09-15 09:29:05 +02:00
Christian Kamm
671599c8b2
Credentials: Use per-account keychain entries #5830
...
This requires a lot of migration code: the old entries need to be read,
saved to the new locations and then deleted.
2017-09-15 09:29:05 +02:00
Christian Kamm
0b4fd52d63
Journal: Second attempt at journal mode fallback #5723
...
Some filesystems, vms or other limitations make using the WAL journal
mode impossible. We are notified of this problem through an sqlite
IOERR for SHMMAP. In that case We want to attempt to fall back to the
DELETE journal mode.
2017-09-15 09:28:35 +02:00
Christian Kamm
e05f5fc50d
OAuth: Don't use implicit POST bodies
...
The query args of POST requests become the request body. If there's a
redirect, the redirected url will therefore not contain the query
arguments. Use an explicit request body to make the redirection work.
2017-09-15 09:28:03 +02:00
Christian Kamm
da6250fc1f
OAuth: Pass client auth in header instead of url
...
To play more nicely with redirects.
2017-09-15 09:28:03 +02:00
Christian Kamm
7d075cdcb7
OAuth: Use redirectable jobs for oauth token management
2017-09-15 09:28:03 +02:00
Christian Kamm
3a55ff2119
PropagateUpload: Model of remote quota, avoid some uploads #5537
...
When we see a 507 error, assume that quota is < uploaded size.
2017-09-15 09:27:07 +02:00
Christian Kamm
b5b055e1ae
SyncOptions/Propagator: Parallelism as an option
...
Very useful for changing it on a per-test basis.
2017-09-15 09:27:07 +02:00
Christian Kamm
0c99673581
Make DetailError different from BlacklistedError
...
It's quite different in regard to blacklist handling and overall
sync failure changes.
2017-09-15 09:27:07 +02:00
Helmut K. C. Tessarek
709aa27031
remove qt4 code
2017-09-15 07:11:05 +02:00
Jenkins for ownCloud
5b01d63491
[tx-robot] updated from transifex
2017-09-15 02:18:32 +02:00
Jürgen Weigert
46b3d41b20
Update release_template.md
2017-09-15 00:37:12 +02:00
Christian Kamm
0b7ad2c804
Excludes: Allow escaping # #6012
...
Otherwise adding patterns that start with # are impossible to add, since
they get treated as comments. Also add this escaping for patterns added
in the ui.
2017-09-14 14:53:05 +02:00
Jenkins for ownCloud
8392d6c136
[tx-robot] updated from transifex
2017-09-14 02:18:30 +02:00
Jenkins for ownCloud
4ced7e9c80
[tx-robot] updated from transifex
2017-09-13 02:18:31 +02:00
Markus Goetz
3d120983da
ChunkingNgTest: CI debuggability #6015
2017-09-12 17:26:54 +02:00
Christian Kamm
70aafd74a8
Journal: Fall back to DELETE on IO error #5723
...
Also add logging of extended error codes for this IO error, maybe we can
become more specific about which situations should trigger a journal
mode switch.
2017-09-12 14:12:24 +02:00
Christian Kamm
66415831ea
Folder: Check etag again after active sync #4116
...
Maybe more things were happening on the server?
2017-09-12 13:58:59 +02:00
Jenkins for ownCloud
2b7919fb3a
[tx-robot] updated from transifex
2017-09-12 02:18:30 +02:00
Christian Kamm
09173fb727
Update server url in case of permanent redirection #5972
...
This is the first time the account url may update outside of
account setup.
Summary of redirection handling:
1. During account setup (wizard)
- status.php gets permanently redirected -> adjust url
- authed PROPFIND gets *any* redirection -> adjust url
2. During connectivity ping (ConnectionValidator)
- status.php gets permanently redirected -> adjust url (new!)
All other redirections should be followed transparently and
don't update the account url in the settings.
2017-09-11 19:27:36 +02:00
Christian Kamm
de5de6284c
Use DetermineAuthTypeJob in HttpCredentials
...
* Move it to networkjobs
* Minor adjustments to its logic
* Fixes redirect handling for oauth/basic http auth check #6003
2017-09-11 19:15:43 +02:00
Markus Goetz
de8ab35cb3
Add clean_tarball.sh #6005
2017-09-11 18:56:22 +02:00
Jenkins for ownCloud
237b597e19
[tx-robot] updated from transifex
2017-09-11 16:03:15 +02:00
Jocelyn Turcotte
2d7a4bdb06
Windows: Make sure that the folder and Desktop.ini have the right attributes ( #6018 )
...
When created from scratch, the owncloud icon won't be picked-up by
explorer unless the right attributes are set on both the sync root and the
Desktop.ini file.
Issue #2446
2017-09-11 15:32:42 +02:00
rockihack
6f270a3648
Enable DEP & ASLR on Windows
2017-09-11 11:18:18 +02:00
Markus Goetz
8be2aaa751
Remove qtkeychain submodule #6004
2017-09-08 15:23:16 +02:00
Jocelyn Turcotte
5ede5ab4ce
Fix the macOS Sparkle build
2017-09-08 13:58:14 +02:00
Christian Kamm
506f7c0764
Http credentials: Fix behavior for bad password #5989
...
When the GET request from askFromUser is scheduled on the QNAM inside
the slot that handles the QNetworkReply::finished signal, it seems to
not get processed at all.
This workaround moves the sending of the new GET to the event loop,
sidestepping the problem.
2017-09-07 11:23:24 +02:00
Christian Kamm
4b686a4394
Fix compile errors
...
cmocka seems to #define fail to something inappropriate.
2017-09-07 11:02:05 +02:00
Jocelyn Turcotte
a18a601291
csync_statedb: (really) Make sure children of non-synced items aren't read from the DB
...
No tests are covering this and I reversed the original logic.
2017-09-07 10:26:19 +02:00
Jocelyn Turcotte
92fc50d4b0
csync_statedb: Make sure children of non-synced items aren't read from the DB
...
Fix a regression during C++ conversion from 704ca366b3
2017-09-07 10:17:58 +02:00
Jocelyn Turcotte
57c812bc00
Merge pull request #5979 from owncloud/csync-merge-filestat-types
...
csync: Merge csync_vio_file_stat_t, csync_file_stat_t and TREE_WALK_FILE data structures
2017-09-06 13:09:16 +02:00
Jocelyn Turcotte
715b8c4683
Fix build after C++ conversion of csync
...
Use the same macro as in SyncFileItem for bitfields on enums.
Fixes #5993
2017-09-06 13:08:23 +02:00
Jocelyn Turcotte
b1bb7ec1a8
Use a C++ contructor and destructor for CSYNC
...
Merge csync_create and csync_init into the constructor and
replace csync_destroy with the destructor.
Also use a QByteArray for csync_s::root_perms and flatten
csync_rename_s as a rename sub-struct of csync_s since it
can now handle C++ types.
2017-09-06 13:08:23 +02:00
Jocelyn Turcotte
f6136dd036
Remove csync_s::replica
...
The only difference with csync_s::current is that it's
assigned the value of csync_s::local::type and
csync_s::remote::type, which never change. So might as
well only use the "current" field with constants.
2017-09-06 13:08:23 +02:00
Jocelyn Turcotte
cb49635231
Replace TREE_WALK_FILE with csync_file_stat_t
...
Just expose csync_file_stat_t since we don't need an abstraction layer
anymore. Also pass the nodes of both trees directly to the visitor
function.
Issue #1817
2017-09-06 13:08:23 +02:00
Jocelyn Turcotte
e8f7adc7ca
Replace csync_vio_file_stat_t with csync_file_stat_t
...
Also move csync_normalize_etag to common/utility since we
don't need the char* function anymore.
Remove the single space file_stat->remotePerm codepath since
this won't be used in csync anymore since
8de3bda0b1 .
Issue #1817
2017-09-06 13:08:23 +02:00
Matthew Setter
ab8061a57f
Fix link to download the ownCloud client
...
This was requested in https://github.com/owncloud/documentation/issues/3354 .
2017-09-06 09:09:14 +02:00
Matthew Setter
f414355680
Fix broken images in FAQ
...
This relates to https://github.com/owncloud/documentation/issues/3354 .
2017-09-06 09:08:53 +02:00
Jürgen Weigert
6dd043659c
Update ChangeLog
2017-09-05 18:20:03 +02:00
Jocelyn Turcotte
704ca366b3
Make csync_file_stat_t public and partly convert to C++
...
This is the first commit trying to unify csync_file_stat_s,
csync_vio_file_stat_s and csync_tree_walk_file_s. Use QByteArray
and unique_ptr already since I'm not used to track memory allocations
and this will make the transition easier.
Issue #1817
2017-09-05 17:25:19 +02:00
Jocelyn Turcotte
cf15cbf0b3
Move Utility to a new common static library
...
Now that csync builds as C++, this will avoid having to implement
functionalities needed by csync mandatorily in csync itself.
This library is built as part of libocsync and symbols exported
through it.
This requires a relicense of Utility as LGPL. All classes moved into
this library from src/libsync will need to be relicensed as well.
2017-09-05 17:25:19 +02:00
Christian Kamm
de7c301654
Add minor unittest for numeric id extraction #5933
2017-09-05 13:40:26 +02:00
Jocelyn Turcotte
48d2fc1599
StatusTracker: Fix different case paths not matching ( #5981 )
...
Use a custom std::map comparator functor to do all comparisons
on contained QStrings using Qt::CaseInsensitive on macOS and Windows.
Issue #5257
2017-08-31 13:32:00 +02:00
Jürgen Weigert
839361594d
fix branded nemo and caja shell integration ( #5966 )
...
* Update createcajaplugin.sh
* first apply branding, then create copies. Better.
Fixes https://github.com/owncloud/ownbrander/issues/753
* fix https://github.com/owncloud/ownbrander/issues/752 too.
2017-08-31 13:16:34 +02:00
Jocelyn Turcotte
40abe3f370
Merge pull request #5978 from owncloud/csync-cpp
...
Move csync to src/ and compile most of it at C++
2017-08-25 15:36:32 +02:00
Roeland Jago Douma
cacba220f9
Merge pull request #48 from nextcloud-gmbh/master-oc
...
Bump to oc master
2017-08-25 15:06:26 +02:00
Roeland Jago Douma
cdc5c1db43
Merge remote-tracking branch 'oc/master' into master-oc
2017-08-23 15:40:35 +02:00
Jocelyn Turcotte
7a5a706397
Fix cmocka deprecation warnings
...
Just use cmocka_run_group_tests like we already use in
some of those tests.
2017-08-22 15:22:57 +02:00
Jocelyn Turcotte
59ea79d9e6
Enable csync logs in unit tests
...
Go through the Logger to enable the csync-QDebug bridge.
2017-08-22 15:22:56 +02:00
Jocelyn Turcotte
4e5898efd7
Compile almost all of csync as C++
...
This will allow us to unify data structures between csync and libsync.
Utility functions like csync_time and c_std are still compiled as C
since we won't need to be coupled with Qt in the short term.
2017-08-22 15:22:56 +02:00
Jocelyn Turcotte
a512586140
Use .cpp for existing csync .cc files
...
Make this consistent with the rest of the client code.
2017-08-22 11:18:22 +02:00
Jocelyn Turcotte
28a0971cdf
Move csync to src/csync
2017-08-22 11:18:22 +02:00
Jocelyn Turcotte
5c9827a33c
Move csync/tests to test/csync
2017-08-22 11:18:22 +02:00
Jocelyn Turcotte
f0362b2332
Move csync/tests/ownCloud to test/scripts/txpl
2017-08-22 11:18:22 +02:00
Martin
5bf48bc68f
Merge pull request #5974 from owncloud/Documentation_Activity_Update
...
Documentation improvement for #5969
2017-08-20 21:09:42 +02:00
Martin
6e47d9a2e5
Documentation improvement for #5969
2017-08-20 18:17:58 +02:00
Jocelyn Turcotte
a480a318fd
Hardcode Desktop.ini in the exclude list
...
This prevents it from being removed from the exclude list, which
would be an issue since the client itself creates this file in a way
that wouldn't match on machines with different installation paths.
2017-08-15 13:37:33 +02:00
Jocelyn Turcotte
251f1d0047
Windows: Use the application icon for the sidebar
...
By setting the icon in Desktop.ini of the root folder, this adds the icon
both when browsing the folder directly and to the sidebar shortcut.
To avoid overwriting any user setting that could exist in Desktop.ini,
only do this if the file doesn't exist. Editing .ini files on Windows
isn't trivial and isn't worth it given that this file won't exist most
of the time.
Fixes #2446
2017-08-15 13:37:33 +02:00
Markus Goetz
1c3127e43b
CMake: Print the Qt version and path #5957 #5932
2017-08-14 14:24:27 +02:00
Roeland Jago Douma
63d99f3e30
Merge pull request #47 from nextcloud-gmbh/drone_qt5.9
...
Add Qt5.9 to drone
2017-08-05 21:15:30 +02:00
Roeland Jago Douma
067c174e61
Add Qt5.9 to drone
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-08-05 21:08:45 +02:00
Roeland Jago Douma
993e1eb89c
Merge pull request #46 from nextcloud-gmbh/drone_57_58
...
Add qt5.7 and qt5.8 CI tests
2017-08-05 14:37:26 +02:00
Roeland Jago Douma
6cb4131024
Add qt5.7 and qt5.8 CI tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-08-05 14:29:13 +02:00
Markus Goetz
20a979173f
Sync Folder: Add file manager favorite also in folder wizard #455
...
Not only in the account wizard.
2017-08-04 17:38:01 +02:00
Markus Goetz
4aad318446
Upload: Log the checksum / file hash
2017-08-04 15:42:11 +02:00
Markus Goetz
13a5653c4e
ChangeLog: More 2.4.0 stuff
2017-08-04 15:23:44 +02:00
Roeland Jago Douma
ceccc661f1
Merge pull request #43 from nextcloud-gmbh/drone
...
Get drone up and running
2017-08-04 10:55:06 +02:00
Roeland Jago Douma
53087ac803
Add drone test for Qt-5.6
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-08-03 22:29:46 +02:00
Matthew Setter
119ecb4259
Merge pull request #5762 from owncloud/update-docs-to-2.3.2
...
Update client docs version string to 2.3.2
2017-08-03 13:56:39 +02:00
Matthew Setter
8bd047174a
Update client docs version string to 2.4.0
...
Need to update this to match the latest version.
2017-08-01 17:28:50 +02:00
Matthew Setter
416393a794
Merge pull request #5929 from owncloud/doc-cleanup
...
Clean up the client docs removing old, outdated, content
2017-08-01 11:52:05 +02:00
Jocelyn Turcotte
9e36cabcbf
macos: Add a sidebar icon
...
In the process, use an iconset to generate the icns using iconutil.
Also add some missing icon resolutions according to the guidelines.
Issue #296
2017-07-31 18:43:47 +02:00
Matthew Setter
3731eba9b6
Clean up the client docs removing old, outdated, content
...
This makes changes as suggested by @michaelstingl in
https://github.com/owncloud/documentation/issues/3240 .
2017-07-31 14:04:02 +02:00
Olivier Goffart
f707a43b3c
FolderWizard: fix crash in FolderWizardRemotePath::slotHandleLsColNetworkError
...
The Job is a LsColJob, not a MkColJob!
Reproduce by entering a name with invalid character that cause an error 400
in the folder wizard's remote path line edit.
(Relates issue #5924 )
2017-07-28 11:57:08 +02:00
Jocelyn Turcotte
7a96e8a292
General settings: Put all advanced checkboxes in a layout
...
The mac style has the concept of Layout Item Rectangle that bleeds
widgets margins into parent margins. This unfortunately doesn't work
when the parent layout doesn't have any margin, like we do when we
have the hierarchy:
Vertical(normal margin)
/ Horizontal(no margin, uses parent layout spacing)
/Widget
I guess Qt should propagate remaining uneaten margins to grand-parent
layouts and so on to have this work properly, but nobody seems to
have touched that code since Qt 4.4.
So just try to make the problem less worse by making sure that
all checkboxes we want to align are either in the same layout, or
in a loyout of their own.
Issue #5492
2017-07-27 17:37:27 +02:00
Jocelyn Turcotte
90cce0ab56
Fix the selective sync notification folder list being cropped
...
The maximumHeight would stay at the last animated value.
Issue #5492
2017-07-27 17:37:27 +02:00
Olivier Goffart
41ed603abf
AccountState: reset _waitingForNewCredentials when signin in
...
Just to force the logic to re-ask the credenticals, in case we were
already asking them when singin off.
Issue: https://github.com/owncloud/client/issues/5893#issuecomment-316949686
2017-07-26 14:58:28 +02:00
Markus Goetz
cdce7f2044
encoding_tests: No more iconv
2017-07-26 11:46:18 +02:00
Olivier Goffart
6ae88514d8
OAuth: clear refresh token when the server claim not to support oauth
...
Allow upgrade path when the server removes support for oauth
Relates: https://github.com/owncloud/client/issues/5848#issuecomment-317353049
We also need to force the account to commit the config to the disk,
otherwise we may not register we are no longer using owncloud and we
risk sending the password as the token to the token refresh API call
2017-07-25 12:34:13 +02:00
Olivier Goffart
c043840cb1
OAuth: Fix refresh of token after expiration
...
Before commit d3b00532b1 ,
fetchFromKeychain was called everytime we detect that the creds are
invalid (in AccountState::slotInvalidCredentials)
But since that commit, AccountState was calling askFromUser directly,
breaking the refresh of the token.
So I made sure AccountState::slotInvalidCredentials still calls
refreshAccessToken.
Another change that was made was too be sure to clear the cookies
in HttpCredentials::invalidateToken even when we are only clearing the
access_token. That's because the session with a cookie may stay valid
longer than the access_token
2017-07-25 12:34:13 +02:00
Olivier Goffart
a831164d65
Revert "Revert "Discovery: consider also the "shared by me" as shared""
...
This reverts commit efa7821dd2 .
This reverts the revert, but also add a check that the server version
is bigger than 10.0
Issue #4788
2017-07-25 12:11:33 +02:00
Jocelyn Turcotte
a41dc00160
Don't keep the list of touched files for the whole sync
...
We only want to know if they were touched within the last 15 seconds,
so change the data structure to use a QMultiMap, and sort them by
QElapsedTimer. This allows us to iterate over old entries ordered by
time and to stop once we find a recent entry.
This makes the look-up slower but in most cases the folder watcher
will report any change within milliseconds, and we start from the
most recent. What this really makes slower are actual user file
changes while a fast sync is underways which will need to iterate
over the whole map to find out the file isn't there.
This reduces the growth of the memory usage when downloading a large
amount of files.
2017-07-24 17:54:29 +02:00
Jocelyn Turcotte
5a1bf7d8fe
windows: Fix a memory leak in FileSystem::longWinPath
...
Also use c_path_to_UNC directly instead of doing an extra
UTF-8->wchar conversion.
2017-07-24 17:54:29 +02:00
Olivier Goffart
075c423c62
buildint.rst: Put back reference to openssl on windows
...
OpenSSL might no longer be needed to build the client, but we still need
it to run it.
That reverts part of commit 6e57b0219e for
this file.
Fix #5858
Reported in https://central.owncloud.org/t/locally-built-client-error-creating-ssl-context/8264
2017-07-21 08:57:57 +02:00
Olivier Goffart
d9813dbc90
Propagator: fix a qMax which should have been a qMin
2017-07-18 08:58:07 +02:00
Olivier Goffart
50874eecfa
OAuth: Add the user in the authorize call
...
Issues: #5897 , https://github.com/owncloud/oauth2/issues/48
2017-07-17 10:13:12 +02:00
Olivier Goffart
3cea550d08
PropagateUpload: Remove the Qt workaround against data corruption
...
This was only for Qt <= 5.4, which we don't really support anymore.
And even then, the data corruption is happens very seldomly anyway.
2017-07-17 10:12:48 +02:00
Olivier Goffart
5e9d6f1cbd
Merge pull request #5905 from kaustubh-welankar/issue_5692_pull
...
Fix for issue number #5692 :
Abort owncloudcmd if the capabilities call fails.
2017-07-17 08:38:57 +02:00
Olivier Goffart
b1363d1a79
AccessManager: Disable HTTP/2 without TLS
...
Qt would otherwise still try to do HTTP/2 connection even over "http://".
And that does not work with server that does not support it
2017-07-17 08:20:17 +02:00
Olivier Goffart
520923b5a7
HTTP/2 Support
...
We need Qt 5.9 for HTTP2 because, even if Qt 5.8 already has support
for it, there is some critical bug in the HTTP2 implementation which
make it unusable [ https://codereview.qt-project.org/186050 and
https://codereview.qt-project.org/186066 ]
When using HTTP2, we can use many more parallel network request, this
is especially good for small file handling
Lower the priority of the GET and PUT propagation jobs, so the quota
or selective sync ui PROPFIND will not be blocked by them
2017-07-17 08:20:17 +02:00
Olivier Goffart
2ba46e05ee
Merge pull request #5326 from owncloud/cleanup_tests
...
Use OWNCLOUD_BIN_DIR directly in C++ code.
2017-07-15 14:48:25 +02:00
Kaustubh Welankar
90ed57f478
Change error message. Removed Qt5 if check
2017-07-15 16:50:40 +05:30
Markus Goetz
ab580103c7
csync_vio: Better log for stat errors
2017-07-14 15:37:56 +02:00
Kaustubh Welankar
1c6a83d0dd
Fix for issue number 5692
2017-07-14 16:50:49 +05:30
Olivier Goffart
06f3a70f9a
OAuth: Better message when loggin in with the wrong username
...
Since the user is already in the browser, put the error message in the
browser with a message to log out and then log in as the right user.
Issue #5895
2017-07-14 11:17:24 +02:00
Markus Goetz
1fb68e8711
X-Request-ID: Send per request not per account #5853
2017-07-14 09:14:01 +02:00
Christian Kamm
bd107e133f
Ensure qsrand is called
2017-07-13 18:06:40 +02:00
Christian Kamm
1c2d5f16c8
Account: Send a X-Request-ID header #5853
2017-07-13 18:06:40 +02:00
Olivier Goffart
5738110cb6
OAuth2: Have a link to the browser in the owncloud UI
...
When the browser is open, ad a link in the ui to re-open
the browser.
Issue #5893
2017-07-13 16:09:42 +02:00
Kashyap Prajapati
6be122edc4
Broken URL fixed in Dockerfile
...
Url to mingw repo fixed.
2017-07-13 14:49:00 +02:00
Christian Kamm
7979342edf
AccountSettings: Draw a box to indicate pending conflicts
2017-07-13 11:48:10 +02:00
Christian Kamm
2cdf5517cb
Conflicts: Detect and show in issues tab
...
Incidentally fixes a potential issue where conflicts were silently-
ignored and thus deleted if the parent folder was deleted.
2017-07-13 11:48:10 +02:00
Markus Goetz
7adcb76f68
check_vio_ext: Align with new UTF8 behaviour on macOS
2017-07-13 10:01:17 +02:00
Olivier Goffart
acf65b4c23
csync: Use Qt for encodeing/decoding filesystem strings
...
Issues:
- #5661 On mac, iconv did not support all of unicode and some
files with emoji in the filename could not be uploaded
- #5719 , #5676 On linux, we will now support non utf-8 locale
2017-07-13 10:01:17 +02:00
Olivier Goffart
d099c2a8db
csync: Move the locale<->utf8 conversion to a different file
...
It's a C++ file so we will be able to use Qt from it
2017-07-13 10:01:17 +02:00
Olivier Goffart
20f1257e88
csync: Remove iconv depedency
...
We use iconv to normalize the string on mac. But the iconv version
on mac does not support full unicode.
So we will use Qt to normalize the string
2017-07-13 10:01:17 +02:00
Christian Kamm
fe0de111fd
IssuesWidget: Fix insertion of sync errors before item errors
2017-07-12 10:10:00 +02:00
Christian Kamm
e7a0c1b6d0
SyncEngineTest: _size now correct for uploads #5855
2017-07-12 10:09:04 +02:00
Christian Kamm
da54b3d7e5
Merge remote-tracking branch 'origin/2.3'
2017-07-12 10:06:04 +02:00
Christian Kamm
971abaea80
IssuesWidget: Add button to retry 507 errors #5537
...
Since these errors are blacklisted, it can take up to 24h to retry items
that had a 507 error for a while. This way users can intervene and cause
an upload attempt immediately.
2017-07-12 09:04:27 +02:00
Christian Kamm
a76670f3b8
IssuesWidget: Hide folder column when possible
2017-07-12 09:04:27 +02:00
Christian Kamm
e13b618a65
Add ElidedLabel
...
A label that adjusts its text based on Qt::TextElideMode.
2017-07-12 09:04:27 +02:00
Christian Kamm
cd1b89475c
PropagateUpload: Better messaging for 507 #5537
...
It now produces a summary error message indicating the problem.
Adjust blacklist database table to contain 'errorCategory'. This is
useful for two things:
- Reestablishing summary messages based on blacklisted errors. For
example if we don't retry a 507ed file, we still want to show the
message about space on the server
- Selectively wiping the blacklist: When we have ui for something like
"I deleted some files, please retry all files now!", we want to
delete all blacklist entries of a specific category only.
2017-07-12 09:04:27 +02:00
Christian Kamm
5d90b48790
PropagateUpload: Put upload error handling in one function
2017-07-12 09:04:27 +02:00
Christian Kamm
c3cb186952
ProgressInfo: Carry a sync status
...
* A bunch of code was determining sync status by ad-hoc comparing some
progress info fields. It can now just check the status, making it
easier to comprehend.
* There's a clear indication for "a new sync is starting", which helps
wiping the issues tab at the right time.
2017-07-12 09:04:27 +02:00
Christian Kamm
5ca743dd25
SyncEngine: Introduce overall errors that are not tied to a file #5746
...
For now we use them for:
* csync errors: This allows them to appear in the sync issues tab
* insufficient local disk space, as a summary of individual file errors
Insufficient remote space will use them too, as might other issues that
are bigger than a single sync item.
2017-07-12 09:04:27 +02:00
Jenkins for ownCloud
c9db5d234f
[tx-robot] updated from transifex
2017-07-12 02:18:29 +02:00
Samuel Alfageme
4fd773d4ae
More refs. to corresponding issue/PR on 2.3.3 changelog
2017-07-11 17:29:49 +02:00
Markus Goetz
5d67271acd
ChangeLog: 2.3.3
2017-07-11 17:18:56 +02:00
Olivier Goffart
d34dbbdb0b
OAuth: Redirects to the server in case of sucessfull login
...
Requires https://github.com/owncloud/oauth2/pull/45
This commit moves the reply after we got the token reply from
the server, that allows to reply with an error to the browser
if the login does not work.
2017-07-11 09:56:04 +02:00
Jenkins for ownCloud
f52cefaa94
[tx-robot] updated from transifex
2017-07-11 02:18:29 +02:00
Christian Kamm
1c9b51c330
IssuesTab: Hide filters if they wouldn't be useful
...
As suggested by @dragotin
2017-07-10 11:13:48 +02:00
Christian Kamm
122854af77
FolderMan: Add missing folderListChanged emits
...
She signal of a folder list change was not emitted when folders were
deleted from the list.
2017-07-10 11:13:48 +02:00
Jenkins for ownCloud
2c127ae2d5
[tx-robot] updated from transifex
2017-07-10 02:18:29 +02:00
Jenkins for ownCloud
7db4455592
[tx-robot] updated from transifex
2017-07-09 02:18:29 +02:00
Christian Kamm
a5ace5e71d
Account/Credentials: Have identical lifetimes
...
The QNAM may continue to outlive both.
Rename Credentials::getQNAM() to createQNAM() while we're at it - it's
used to make a new QNAM that will subsequently be owned by the Account
object.
See d01065b9a1 for rationale.
Relates to
d40c56eda5
147cf798a6
2017-07-08 13:07:13 +02:00
Jenkins for ownCloud
0d926f7632
[tx-robot] updated from transifex
2017-07-08 02:18:29 +02:00
Jocelyn Turcotte
af4f1083b7
shell/windows Build 46: Private links context menu
2017-07-07 18:10:48 +02:00
Jürgen Weigert
186f16e688
Update building.rst
2017-07-07 16:01:20 +02:00
Christian Kamm
99b1f69271
Link share: Remove direct download if unavailable #5837
...
It would have been much nicer to keep the menu assigned to the
QToolButton, but if one switches away from InstantPopup (to adjust the
entries before they're displayed), the button always gets a menu
indicator that can't be removed.
2017-07-07 11:23:32 +02:00
Christian Kamm
e54be1c4ee
Link shares: Add "show file listing" option #5837
2017-07-07 11:23:32 +02:00
Christian Kamm
411621bf03
shell integrations: Change share menu title to "Share..."
...
Since the appname is in the context submenu title already.
Also drop APPNAME string.
2017-07-07 10:50:07 +02:00
Christian Kamm
ca2ffd4fb3
SocketAPI: Change strings to a consistent _MENU_TITLE postfix
2017-07-07 10:49:51 +02:00
Jocelyn Turcotte
3b20684dc7
shell/macos: Remove legacy (< 10.10) overlay icons
...
Having to update the plugins to add a submenu in the context menu,
it's more cost-effective to remove support for legacy macOS versions
than implementing and testing this setup.
2017-07-07 10:49:51 +02:00
Jocelyn Turcotte
b6db9789ee
shell/macos: Use a submenu to include private link actions
2017-07-07 10:49:51 +02:00
Jocelyn Turcotte
7a4daf799a
shell/windows: Use a submenu to include private link actions
...
Refactor things a bit to be able to reuse some code and
clean things up.
2017-07-07 10:49:51 +02:00
Jocelyn Turcotte
389499d639
SocketApi: Add GET_STRINGS:BEGIN and END
...
The Windows shell extension relied on the response of
SHARE_MENU_TITLE to advance its state machine, but in order
to use the new GET_STRINGS instead, we need to know when the
last string was received. Also add BEGIN for consistency.
2017-07-07 10:49:51 +02:00
Jocelyn Turcotte
7b58a82840
SocketApi: Adjust the format of the mailto: URL
...
Minor tweaks that weren't actually an issue, but just in case.
2017-07-07 10:49:51 +02:00
Jocelyn Turcotte
9d818066a7
SocketApi: Improve logging
2017-07-07 10:49:51 +02:00
Christian Kamm
0238a29c7c
Introduce private link sharing #5023
...
* SocketAPI has COPL_LOCAL_LINK / EMAIL_LOCAL_LINK commands
* The nautilus and dolphing shell integrations show a submenu from which
one can share as well as access the private link.
* The SocketAPI provides a new GET_STRINGS command to access localized
strings.
* The private link can also be accessed from the user/group sharing
dialog.
* The numeric file id is extracted from the full id to create the
private link url.
2017-07-07 10:49:51 +02:00
Jenkins for ownCloud
383ba63c5a
[tx-robot] updated from transifex
2017-07-07 02:18:31 +02:00
Jenkins for ownCloud
4e5e290ec2
[tx-robot] updated from transifex
2017-07-07 01:15:16 +02:00
Christian Kamm
d01065b9a1
Fix crash on account deletion
...
Calling forgetSensitiveData() on account deletion leads to a timer for
clearQNAMCache() being queued. Then the Account object is deleted. The
Credentials object stays alive for now because it has a deleteLater
deleter.
If the timer calls into a slot on the Credentials object, the _account
pointer will be invalid at this time.
As a workaround, move the target slot to Account - that way it will not
be called as the account object is already destroyed.
However since Account and Credentials are mutually dependent, it would
be much preferable if their lifetimes were linked, avoiding this
category of bugs.
The current behavior was introduced in
d40c56eda5 and I currently don't
understand why - maybe there's another way of dealing with the problem
that existed then.
2017-07-06 14:34:02 +02:00
Hefee
607287a9d6
Use OWNCLOUD_BIN_DIR directly in C++ code.
...
No need to do a STR replacement and the macro changing the path.
It actually broke test execution for Debian.
See https://bugs.debian.org/844937
2017-07-06 08:41:02 +02:00
Jenkins for ownCloud
01b3cde79b
[tx-robot] updated from transifex
2017-07-06 02:18:28 +02:00
Jenkins for ownCloud
5b0fea195d
[tx-robot] updated from transifex
2017-07-05 02:18:35 +02:00
ckamm
ce8341ca1f
Add a more functional error view #5516 ( #5861 )
...
* Add a more functional error view #5516
* Allow filtering of ignores and warnings to see only important bits.
* Navigate from the folder view to the error view by clicking on the
error list with the red background.
* Move the error list into its own ui file to allow easier extension.
* Fix issue around tab id handling in ActivitySettings.
* Rename "Action" column to "Issue".
* Change mouse cursor to hand over button and new error list area
Several OSX fixes provided by guruz.
2017-07-04 14:08:41 +02:00
Christian Kamm
9493e8f42e
AccountState: Add a 1-5min reconnection delay #5872
...
This only applies when the server was explicitly in maintenance mode or
when it was 503-unavailable.
2017-07-04 13:12:41 +02:00
Christian Kamm
b1aaf055b1
Blacklist: Don't let errors become warnings #5516
...
Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.
2017-07-04 13:07:51 +02:00
Olivier Goffart
34e75f80bc
main.cpp: Fix a compiler warning
...
src/gui/main.cpp:112:9: warning: bool literal returned from 'main' [-Wmain]
Used 1 to keep previous behaviour. I supposed the code was meant
to return success (0), but it does not really matter anyway.
2017-07-04 11:43:07 +02:00
Markus Goetz
f4d1a07b72
SyncEngine: Keep local size in SyncItem #5855
2017-07-04 11:42:44 +02:00
Christian Kamm
0db095e02a
SyncEngineTest: Fix test reliability
...
There was a rounding issue in the mtimes which sometimes resulted in an
off-by-one error. Caused by storing a full QDateTime in the FileInfo but
the mtime saved to the disk being truncated to seconds.
2017-07-04 09:57:22 +02:00
Jenkins for ownCloud
99f5580c37
[tx-robot] updated from transifex
2017-07-04 02:18:29 +02:00
Olivier Goffart
30095a0c3f
Fix check_csync_update
...
Commit 8160963110 changed the
SQL requests from csync to read from the checksumtype table.
So we need to add this table in the fake DB as well
2017-07-03 17:26:29 +02:00
Olivier Goffart
946c6967e9
Fix check_csync_exclude test
...
Commit 4697f0274f remove .htaccess from
the sync-exclude.lst, so use another known excluded pattern
2017-07-03 17:26:29 +02:00
Piotr Mrowczynski
d1e00099dc
Classify chunked items correctly. Issue #5850
2017-07-03 14:41:53 +02:00
Markus Goetz
f49985697b
TestSyncJournalDB: Fix concurrent usage on CI
2017-07-03 14:08:39 +02:00
Christian Kamm
d018d460e3
csync tests: remove stray 'print'
2017-07-03 13:16:55 +02:00
Christian Kamm
851a3128e4
SyncEngine: Add unittest for SyncFileItem properties #5855
...
Checks instruction, direction, size, modtime for three common cases.
2017-07-03 12:54:24 +02:00
Christian Kamm
bdb8a4a0cb
csync tests: Fix for new owncloudcmd return codes
...
These were introduced in 4af45394f9
2017-07-03 11:48:38 +02:00
Jenkins for ownCloud
2a410217e2
[tx-robot] updated from transifex
2017-07-03 02:18:29 +02:00
Jenkins for ownCloud
2c0e820d9a
[tx-robot] updated from transifex
2017-07-02 02:18:29 +02:00
Jenkins for ownCloud
2326ea77e6
[tx-robot] updated from transifex
2017-07-01 02:18:28 +02:00
Jenkins for ownCloud
e6984f4058
[tx-robot] updated from transifex
2017-06-30 02:18:46 +02:00
Samuel Alfageme
aeea27b57b
Update central.owncloud.org link
...
Desktop client category was renamed, old link was 404 - see: https://central.owncloud.org/t/new-central-categories-you-decide
2017-06-29 17:54:42 +02:00
Samuel Alfageme
0f70bd7913
Update central.owncloud.org link
...
Desktop client category was renamed, old link was 404 - see: https://central.owncloud.org/t/new-central-categories-you-decide
2017-06-29 17:52:00 +02:00
Roeland Jago Douma
d810c13304
Merge pull request #27 from nextcloud-gmbh/wording-fix
...
Change wording from synchronizing to synchronized
2017-06-29 16:06:07 +02:00
Jan-Christoph Borchardt
3d2f5b6af1
Change wording from synchronizing to synchronized
2017-06-29 15:36:57 +02:00
Jenkins for ownCloud
e8f95743cc
[tx-robot] updated from transifex
2017-06-29 02:22:16 +02:00
Roeland Jago Douma
e240904a32
Merge pull request #33 from nextcloud-gmbh/update_doc
...
Point to NC doc repo
2017-06-28 16:44:31 +02:00
Roeland Jago Douma
58e0c6c630
Point to NC doc repo
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-06-28 16:40:42 +02:00
Roeland Jago Douma
501394ec6f
Merge pull request #32 from nextcloud-gmbh/oc_master
...
Oc master
2017-06-28 13:24:24 +02:00
Jenkins for ownCloud
fd0b8f3583
[tx-robot] updated from transifex
2017-06-28 02:22:09 +02:00
Jenkins for ownCloud
2a52b087fd
[tx-robot] updated from transifex
2017-06-27 02:22:10 +02:00
Jenkins for ownCloud
c70cdd61ca
[tx-robot] updated from transifex
2017-06-26 02:22:09 +02:00
Jenkins for ownCloud
5979db1270
[tx-robot] updated from transifex
2017-06-25 02:22:09 +02:00
Jenkins for ownCloud
0edc29dc72
[tx-robot] updated from transifex
2017-06-24 02:22:16 +02:00
Jenkins for ownCloud
5e4aaab91b
[tx-robot] updated from transifex
2017-06-23 02:22:09 +02:00
Markus Goetz
59bbbd5e66
Jenkinsfile: Some comments
2017-06-22 15:42:56 +02:00
Markus Goetz
1e98ba27c6
CSyncSqliteTest: Fix test
2017-06-22 15:11:49 +02:00
Markus Goetz
2244b35a6d
test_journal.db: Add checksumtype table
2017-06-22 15:11:49 +02:00
Christian Kamm
15ee7b39ac
Merge remote-tracking branch 'origin/2.3'
2017-06-22 14:06:31 +02:00
Jenkins for ownCloud
6a298d180d
[tx-robot] updated from transifex
2017-06-22 02:22:09 +02:00
Markus Goetz
cb7d74a063
Jenkinsfile: Compile in debug because of all the asserts
2017-06-21 15:11:55 +02:00
Markus Goetz
bc946053a3
Jenkinsfile: Compile in debug because of all the asserts
2017-06-21 15:02:26 +02:00
Markus Goetz
bfe095b065
Jenkinsfile: Run verbose tests
2017-06-21 12:18:21 +02:00
Markus Goetz
30bcd45a14
Jenkinsfile: Run full testing
2017-06-21 12:13:01 +02:00
Markus Goetz
cd5ad7db64
Jenkinsfile: Run full testing
2017-06-21 12:12:08 +02:00
Markus Goetz
1332e7d66a
Jenkinsfile: 2.3.3 will ship with Qt 5.
...
This should fix the current CI run too
2017-06-21 11:59:24 +02:00
Markus Goetz
f44d3914ef
owncloudcmd: Explain --debug parameter
2017-06-21 10:01:32 +02:00
Jenkins for ownCloud
949e8e5f51
[tx-robot] updated from transifex
2017-06-21 02:22:08 +02:00
Christian Kamm
1e78a14f1a
Ignore ui: Add the sync journal patterns #5844
...
The ignore patterns for the journal files are hardcoded. Add them to
the UI to make them discoverable.
2017-06-20 13:35:34 +02:00
Christian Kamm
4291ea47f7
Journal: Don't use a ._ path if it won't work #5633
...
When synchronizing a folder on a samba share, creating files that begin
with ._ is often forbidden. This prevented the client from creating
its ._sync_abcdef.db file.
Now, it'll check whether the preferred filename is creatable, and if
it isn't it'll use .sync_abcdef.db instead.
The disadvantage is that this alternative path won't be ignored by
older clients - that was the reason for the ._ prefix.
2017-06-20 13:35:34 +02:00
Jenkins for ownCloud
b50706a7aa
[tx-robot] updated from transifex
2017-06-20 02:22:12 +02:00
Jocelyn Turcotte
b20f87eef3
shell/Windows: Update binaries to build 45
2017-06-19 12:11:11 +02:00
Frederik Juul Christiani
bc2e1a53cb
shell_integration/windows: Create _newQueries as a non-signaled auto-reset event.
...
Since ResetEvent() is never called, the call to WaitForMultipleObjects()
can always return immediately once the event has been signaled.
2017-06-19 12:11:11 +02:00
Frederik Juul Christiani
e7d4d12e16
Initialize stop variable.
...
Avoid stopping the worker thread immediately if the stop variable happens to be true.
2017-06-19 12:11:11 +02:00
Jenkins for ownCloud
f348a7d4f4
[tx-robot] updated from transifex
2017-06-19 02:22:08 +02:00
Jenkins for ownCloud
9c82c36c71
[tx-robot] updated from transifex
2017-06-18 02:22:08 +02:00
Jenkins for ownCloud
480388133e
[tx-robot] updated from transifex
2017-06-17 02:22:17 +02:00
Jocelyn Turcotte
5d24a2dc0f
Remove debug messages by default from sync.engine
...
Other categories were already set properly.
2017-06-15 20:10:30 +02:00
Christian Kamm
8160963110
Compare the hash of files with identical mtime/size #5589
...
* For conflicts where mtime and size are identical:
a) If there's no remote checksum, skip (unchanged)
b) If there's a remote checksum that's a useful hash, create a
PropagateDownload job and compute the local hash. If the hashes
are identical, don't download the file and just update metadata.
* Avoid exposing the existence of checksumTypeId beyond the database
layer. This makes handling checksums easier in general because they
can usually be treated as a single blob.
This change was prompted by the difficulty of producing file_stat_t
entries uniformly from PROPFINDs and the database.
2017-06-15 13:54:16 +02:00
Christian Kamm
d50d8b86cf
SyncEngineTest: Add network override
...
This is useful for monitoring what kind of network requests are
sent to the fake server. Such as "did this sync cause an upload?"
and "was there a propfind for this path?". It can also inject
custom replies.
2017-06-15 13:53:57 +02:00
Christian Kamm
b28e06608c
SyncEngineTest: Send 'checksums' in FakePropfind
2017-06-15 13:53:57 +02:00
Christian Kamm
cd411e5fb1
SyncEngineTest: Fix date locale related bug
...
The client is very picky about date strings it accepts. If dates are
formatted with a non-C locale (such as localized weekday names), it
fails to parse it and tests fail in subtle ways.
2017-06-15 13:53:57 +02:00
Jocelyn Turcotte
9daef50ce6
shell/Windows: Update binaries to build 45
2017-06-14 14:17:50 +02:00
Frederik Juul Christiani
fae178f70b
shell_integration/windows: Create _newQueries as a non-signaled auto-reset event.
...
Since ResetEvent() is never called, the call to WaitForMultipleObjects()
can always return immediately once the event has been signaled.
2017-06-14 12:14:22 +02:00
Frederik Juul Christiani
744208f701
Initialize stop variable.
...
Avoid stopping the worker thread immediately if the stop variable happens to be true.
2017-06-14 12:14:21 +02:00
Olivier Goffart
85d8ae6b93
AccountSettings: Triggering log in re-ask about previously rejected certificates #5819
...
Issue #5819
2017-06-14 11:48:24 +02:00
Jenkins for ownCloud
ff79cc9107
[tx-robot] updated from transifex
2017-06-14 02:22:19 +02:00
Olivier Goffart
5100a2daf1
OAuth: cleanup debug messages
...
- Add category to the all messages (they did not have it was merged right after
the patch to add category everywhere, but this code did not have it.)
- Make sure there is no warnings in the normal flow. (The wizard does a request
without authentication to determine the auth type)
2017-06-13 12:08:24 +02:00
Olivier Goffart
6e57b0219e
Don't link dirrectly against openssl
...
All our crypto code is handled by qt nodaways.
No need to carry this dependency.
Especially since it causes warnings on system where there are
twp openssl version installed:
/usr/bin/ld: warning: libcrypto.so.1.0.0, needed by /usr/lib/libQt5Network.so.5.9.0, may conflict with libcrypto.so.1.1
2017-06-13 11:27:23 +02:00
Markus Goetz
3a002a1ddf
Update ChangeLog
2017-06-12 18:46:57 +02:00
Christian Kamm
4b0d956b3d
OAuth: Fix a typo in the success message
2017-06-12 12:58:20 +02:00
Olivier Goffart
85408961ba
Wizard: Don't let the second to last page go back with OAuth2
...
We don't want to re-open the browser in that case.
2017-06-12 12:58:20 +02:00
Olivier Goffart
04b6794318
OAuth: Error handling in the wizard
...
Issues: #5813 and #5811
2017-06-12 12:58:20 +02:00
Jenkins for ownCloud
e86b6b2246
[tx-robot] updated from transifex
2017-06-09 02:22:10 +02:00
Olivier Goffart
3314a472c3
SyncEngine: SelectiveSync: Remove local files of undelected folder despite other modified files
...
Issue #5783
When the directry that should be removed by selective sync contains changes,
we ignore the whole sub tree instead of only ignoreing new files.
We cannot ignore the whole directory, we need to ignore only the directory
that do not have files to remove
2017-06-08 14:53:54 +02:00
Christian Kamm
aeeb408c74
Merge branch '2.3'
2017-06-08 13:02:34 +02:00
Olivier Goffart
18c39197e5
ownsql: fix build on jenkins
...
sqlite3_system_errno was only added in sqlite 3.12
(cherry picked from commit e2e56f45af )
2017-06-08 12:53:45 +02:00
Christian Kamm
7eb8219419
Add extra logging for SQLITE_CANTOPEN errors #5633
...
(cherry picked from commit 05c1dcef9b )
2017-06-08 12:52:58 +02:00
Jenkins for ownCloud
2f915af690
[tx-robot] updated from transifex
2017-06-08 02:22:10 +02:00
Jenkins for ownCloud
272898a792
[tx-robot] updated from transifex
2017-06-07 02:22:13 +02:00
Olivier Goffart
63c40b45e4
OAuth: Fix the secret to the one from commit 05fd985f9f in the oauth2 repository
...
05fd985f9f
2017-06-06 14:49:34 +02:00
Olivier Goffart
c17a678385
FolderStatusModel: fix assert in Qt when the list of subfolder is empty
...
Fix an assert that happens in beginInsertRows when opening a folder
and that folder is empty.
This can only be reproduced with a debug build of Qt.
2017-06-06 14:49:03 +02:00
Olivier Goffart
e2e56f45af
ownsql: fix build on jenkins
...
sqlite3_system_errno was only added in sqlite 3.12
2017-06-06 14:47:11 +02:00
Christian Kamm
05c1dcef9b
Add extra logging for SQLITE_CANTOPEN errors #5633
2017-06-06 12:59:57 +02:00
Christian Kamm
cc5fe558ba
Fix maintenance mode detection #5755
...
The server sends "maintenance": "true" which isn't a json boolean...
2017-06-06 10:45:41 +02:00
Jenkins for ownCloud
68ee08440e
[tx-robot] updated from transifex
2017-06-05 02:22:03 +02:00
Jenkins for ownCloud
b02b99003a
[tx-robot] updated from transifex
2017-06-03 02:22:02 +02:00
Jenkins for ownCloud
e3306abbcb
[tx-robot] updated from transifex
2017-06-02 02:22:13 +02:00
Olivier Goffart
3d93527a8e
Authentication with OAuth2
...
When the OAuth2 app (https://github.com/owncloud/oauth2 ) is enabled,
We will open a browser and perform the OAuth2 authentication
Issue: #4798 and https://github.com/owncloud/platform/issues/17
2017-06-01 10:39:33 +02:00
Markus Goetz
8a19f2ac65
ChangeLog: More things that were done until now
2017-06-01 10:37:01 +02:00
Julius Härtl
b7fa50be4c
Set proper application name, icon name for freedesktop notifications
...
Use application name defined in OEM build configuration
2017-06-01 10:01:05 +02:00
Jenkins for ownCloud
61d05fa4d7
[tx-robot] updated from transifex
2017-05-31 02:22:17 +02:00
Markus Goetz
42751f87d9
Application: debug implies logdebug
2017-05-29 22:05:26 +02:00
Dominik Schmidt
0fc3df45ce
Remove obsolete FindQtKeychain for Qt4
2017-05-29 21:44:25 +02:00
Dominik Schmidt
78dede2ac4
Fix build on Debian 7 (CMake pre 2.8.12)
2017-05-29 21:44:25 +02:00
Christian Kamm
577a2715bd
Download: Retrigger folder discovery on 404
...
See owncloud/enterprise#1966
If the server and the client's database go out of sync, there could be
persistent 404 errors. This change ensures that the problem corrects
itself eventually by triggering a remote discovery of the file's
parent folders.
It does not address the root cause that might have lead to the
divergence.
2017-05-29 21:41:10 +02:00
Olivier Goffart
f88431adbf
Don't call QElapsedTimer::restart on uninitialized timer
...
That's an undefined behavior.
Since we don't use the return value anyway, we should just use start()
2017-05-29 10:51:05 +02:00
Jenkins for ownCloud
56de50de28
[tx-robot] updated from transifex
2017-05-25 02:22:08 +02:00
Jenkins for ownCloud
a48785ee5e
[tx-robot] updated from transifex
2017-05-24 02:22:16 +02:00
Jenkins for ownCloud
3be73ad1ca
[tx-robot] updated from transifex
2017-05-23 02:22:15 +02:00
Christian Kamm
03aa7e3044
Sharing: Disable 'set password' button when password is empty #5788
2017-05-22 14:41:06 +02:00
Christian Kamm
91f6cae168
Share dialog: Use default icon if available #5781
2017-05-22 14:15:53 +02:00
Christian Kamm
ddd584077c
Share link: Fix disabled API/sharing #5778
...
* Don't hide the displayed error directly after showing it
* Don't try to fetch shares when sharing isn't possible
2017-05-22 10:59:57 +02:00
Christian Kamm
8201f0b6ea
Share Dialog: Remove unused hline
2017-05-22 10:59:57 +02:00
Christian Kamm
f2b5fcd706
Share link: Fix parsing integer ids #5777
...
Older ownCloud servers like 8.2.0 used to use integer ids.
This broke when switching to QJson because toString() on JSON
values is strict and returns "" for integers.
2017-05-22 10:54:30 +02:00
Christian Kamm
950439e5b8
Sharing dialog: Ensure error labels are expanding #5774
2017-05-22 10:52:52 +02:00
Christian Kamm
f24cdf5a05
Share dialog: Hide the icon when unused
...
Previously this used up some space when there was no icon, leading
to an oddly indented header.
2017-05-22 10:52:52 +02:00
Christian Kamm
d3b00532b1
Credentials: Simplify credential flow #5728
...
And as a side effect: don't ask for user password when we can't
connect to the server in the first place.
2017-05-22 10:52:18 +02:00
Christian Kamm
b7ed0fce2a
Account: forget credentials on delete #5752
2017-05-22 10:49:11 +02:00
Christian Kamm
c1d2a9ab92
Sharing: Show warning that link shares are public #5785 #5747
...
Backport of 3872e060ba33913e43714776a1afce787e772351
2017-05-22 10:28:16 +02:00
Christian Kamm
87a7642381
Settings: Ensure the 'about' label isn't cut off #5760
2017-05-22 10:11:09 +02:00
Christian Kamm
57d965aeba
Merge branch '2.3'
2017-05-22 10:00:28 +02:00
Christian Kamm
9b4e00c3fc
mirall.desktop.in: Remove superfluous lines #5767
2017-05-22 09:59:13 +02:00
Jenkins for ownCloud
97a4302b58
[tx-robot] updated from transifex
2017-05-22 02:22:15 +02:00
Jenkins for ownCloud
bac5121221
[tx-robot] updated from transifex
2017-05-21 02:22:14 +02:00
Jenkins for ownCloud
3462b1d1a3
[tx-robot] updated from transifex
2017-05-20 02:22:15 +02:00
Jenkins for ownCloud
54cc1cdcf7
[tx-robot] updated from transifex
2017-05-20 01:18:15 +02:00
Jenkins for ownCloud
0fd678e9a6
[tx-robot] updated from transifex
2017-05-19 02:22:22 +02:00
Jenkins for ownCloud
580762b4e6
[tx-robot] updated from transifex
2017-05-18 02:22:27 +02:00
Christian Kamm
5eaae83a01
Merge remote-tracking branch 'origin/2.3'
2017-05-17 13:10:19 +02:00
Jocelyn Turcotte
c50136d675
Add the account name and folder when starting the sync
...
This should help clearly delimiting them in the log for multi-account setups.
This information is already available elsewhere in the log in any case.
Issue #5672
2017-05-17 12:39:59 +02:00
Christian Kamm
494ea5c78c
Reformatting: Add .git-blame-ignore-revs
...
For git hyper-blame support
2017-05-17 12:31:49 +02:00
Christian Kamm
c8d0f788e0
Apply clang-format
2017-05-17 12:26:27 +02:00
Christian Kamm
ae263d60bd
Reformatting: Reformat some lines that would become really long
2017-05-17 12:26:27 +02:00
Christian Kamm
df3fe25702
Reformatting: Adjust trailing comments
...
These would otherwise be line-wrapped by clang-format,
and then consecutive reformattings remove the aligned
comment indentation
Example:
int a; // too long comment
->
int a; // too long
// comment
->
int a; // too long
// comment
2017-05-17 12:26:27 +02:00
Christian Kamm
566e6c813e
Add .clang-format style
...
From http://code.qt.io/cgit/qt/qtrepotools.git/tree/config/_clang-format
2017-05-17 12:26:27 +02:00
Jenkins for ownCloud
c09a828f7b
[tx-robot] updated from transifex
2017-05-17 02:22:16 +02:00
Christian Kamm
c5a0ce5a43
Selective sync: Skip excluded folders when reading db
...
When a new folder becomes selective-sync excluded, we already mark it
and all its parent folders with _invalid_ etags to force rediscovery.
That's not enough however. Later calls to csync_statedb_get_below_path
could still pull data about the excluded files into the remote tree.
That lead to incorrect behavior, such as uploads happening for folders
that had been explicitly excluded from sync.
To fix the problem, statedb_get_below_path is adjusted to not read the
data about excluded folders from the database.
Currently we can't wipe this data from the database outright because we
need it to determine whether the files in the excluded folder can be
wiped away or not.
See owncloud/enterprise#1965
2017-05-16 13:58:45 +02:00
Jenkins for ownCloud
6d74601cf3
[tx-robot] updated from transifex
2017-05-16 02:22:31 +02:00
Christian Kamm
ee4892e345
Wizard: Skip result page with acceptance instead of closing #5764
2017-05-12 10:21:07 +02:00
Jenkins for ownCloud
557931f207
[tx-robot] updated from transifex
2017-05-12 02:18:31 +02:00
Jocelyn Turcotte
7fd2f292e7
Promote a few more logs to info/warning
2017-05-11 17:22:59 +02:00
Markus Goetz
b68d982619
macOS: Fix usage of qCDebug in .mm file
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
cf058bc537
Add the possiblility to enable debug logging categories
...
Add a checkbox in the log window as well as a --logdebug command-line
option that should have the same effect.
Issue #5647
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
cc9680c1e8
Also pass csync logs through QMessageLogger
...
This allows using logging rules and custom message patterns with csync.
This also pass the a relative verbosity to the message logger.
Issue #5647
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
b7553d5bdf
Upgrade some qCDebug to qCInfo or qCWarning
...
Use qCInfo for anything that has general value for support and
development. Use qCWarning for any recoverable error and qCCritical
for anything that could result in data loss or would identify a serious
issue with the code.
Issue #5647
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
4ad190a558
Use Qt logging categories for logging
...
This gives more insight about the logs and allow setting fine-tuned
logging rules. The categories are set to only output Info by default
so this allows us to provide more concise logging while keeping the
ability to extract more information for a specific category when
developping or debugging customer issues.
Issue #5647
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
3a193655b3
Improve the logging message pattern
...
Add the log level and category name in the output. Only output the
thread ID and function name for qCDebug statements as they are not
necessary for general use and make the log harder to read.
Also make sure that the message pattern is set when NO_MSG_HANDLER is
used. Using an environment variable should have priority over it anyway.
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
e10a08f64d
Remove the unused folderwatcher_qt implementation
2017-05-11 17:22:59 +02:00
Matthew Setter
84e9400742
Add explanation of how to replace local sync folder to FAQ
...
This fixes owncloud/documentation/issues/2923.
(cherry picked from commit 6580af65c1 )
2017-05-11 12:07:33 +02:00
Markus Goetz
cc94c772cd
ChangeLog: 2.4 until now
2017-05-11 12:03:52 +02:00
Christian Kamm
4b6edaa01a
Detect maintenance mode #4485
...
When we first detect a 503 (probably from a PROPFIND) and enter the
ServiceUnavailable state, we new trigger a status.php query that will
switch the state to MaintenanceMode if necessary.
2017-05-11 11:39:49 +02:00
Jenkins for ownCloud
45f831da4c
[tx-robot] updated from transifex
2017-05-11 02:18:31 +02:00
Markus Goetz
8da7919a43
Sharing: Fix UI glitch when sharing is disabled
2017-05-10 15:41:58 +02:00
Markus Goetz
f52d66a954
Sharing: Optionally show warning that links are public
...
For https://github.com/owncloud/enterprise/issues/1914
2017-05-10 15:41:58 +02:00
Jenkins for ownCloud
55dfbb9446
[tx-robot] updated from transifex
2017-05-10 02:18:36 +02:00
Jocelyn Turcotte
4d3212b31f
Merge branch 2.3 into master
2017-05-09 18:23:01 +02:00
Markus Goetz
973dc9e1e2
Update release_template.md
2017-05-09 13:12:22 +02:00
Markus Goetz
8e1422fb37
VERSION.cmake: This is 2.3.3 now
2017-05-09 12:23:52 +02:00
Christian Kamm
881641f0b7
Remove stray debug output
2017-05-09 10:37:40 +02:00
Jenkins for ownCloud
6a378a6362
[tx-robot] updated from transifex
2017-05-09 02:18:36 +02:00
Jocelyn Turcotte
879dadba78
Use QTemporaryDir in TestOwnSql
...
This will improve the cleanup and possibly help for #5366 .
2017-05-08 23:18:06 +02:00
Jocelyn Turcotte
5266720c62
Jenkinsfile: Also use 4 parallel jobs for linux builds
2017-05-08 23:18:06 +02:00
Jocelyn Turcotte
dca2b67338
Favor QtKeychain installed together with Qt
...
By default we will look in /usr/lib, which would prevent us from
using a different path for Qt as QtKeychain depends on Qt itself.
2017-05-08 23:18:06 +02:00
Markus Goetz
d1b1da3414
Update release_template.md
2017-05-08 20:34:57 +02:00
Markus Goetz
48a359b69e
Update release_template.md
2017-05-08 17:01:37 +02:00
Markus Goetz
2a8f9a7c04
Update release_template.md
2017-05-08 16:17:07 +02:00
Markus Goetz
ea691aa2a0
ChangeLog: 2.3.2
2017-05-08 15:50:09 +02:00
Christian Kamm
3da1e9a4b9
Remove 3rdparty qjson #5710
2017-05-08 11:50:33 +02:00
Christian Kamm
f1b42cedda
Port PollJob responses to Qt5's QJson #5710
2017-05-08 11:50:33 +02:00
Christian Kamm
2598579d84
Switch JsonApiJob to Qt5's QJson #5710
2017-05-08 11:50:33 +02:00
Christian Kamm
c5b6ec209a
Sharing: Switch from QtJson to Qt5's QJson #5710
2017-05-08 11:50:33 +02:00
Olivier Goffart
13705999f7
Discovery: Increase the MAX_DEPTH and show deep folder as ignored
...
Before this patch, to deep folder would just be ignored, without any feedback.
This patch makes it so deep folder are properly shown as ignored in the UI.
Also increase the MAX_DEPTH
Issue: #1067
2017-05-08 11:29:51 +02:00
Markus Goetz
fbe812b9bc
Selective Sync: Open sub folder context menu #5596
2017-05-08 11:24:02 +02:00
Olivier Goffart
4697f0274f
Exclude list: remove .htaccess
...
As per issue #5701 , if the server does not support it, let the server
show return an error, but we should not blacklist it localy
2017-05-08 11:17:22 +02:00
Jenkins for ownCloud
9597c2b808
[tx-robot] updated from transifex
2017-05-08 02:18:29 +02:00
Jenkins for ownCloud
3817202b9c
[tx-robot] updated from transifex
2017-05-07 02:18:30 +02:00
Jenkins for ownCloud
ed960e5a71
[tx-robot] updated from transifex
2017-05-06 02:18:30 +02:00
Jenkins for ownCloud
8b08ca2d00
[tx-robot] updated from transifex
2017-05-05 02:18:28 +02:00
Christian Kamm
aff8008baf
Downloads: Remove empty temporary if disk space full #5746
2017-05-04 15:12:14 +02:00
Christian Kamm
c922015521
SSL error handling: Remove unnecessary confusing code
...
I'm confident this is unnecessary. The original bug in #3283 was
to call ignoreSslErrors() without an argument in the 'accept'
case, which meant ignoring *all* subsequent SSL errors.
With that fixed, explicitly aborting the reply and resetting QNAM
is not needed since not ignoring the error will lead to the SSL
handshake failing.
See also:
75b38d1a2f (workaround introduced)
89376e14d6 (real fix)
76ce5adbf0 (cherry-pick of workaround)
2017-05-04 09:19:01 +02:00
Jenkins for ownCloud
b20adf2281
[tx-robot] updated from transifex
2017-05-04 02:18:38 +02:00
Markus Goetz
4ed9edb104
Wizard: Don't show not-so-useful result page #5726
...
Better immediately show the settings dialog where people can see what's going on.
They can go to sync folder or webinterface from there.
2017-05-03 19:21:46 +02:00
Olivier Goffart
bb244d527c
Better words for the error message when one cannot create the database.
...
Issue #5291
2017-05-03 17:53:46 +02:00
Matthew Setter
7f1d13dfbf
Merge pull request #5741 from owncloud/add-checksum-details
...
Document the checksums addition in 10.0
2017-05-03 13:32:21 +02:00
Matthew Setter
3185b0940b
Increase the clarity of the checksum statements
...
This comes after discussion and feedback with @phil-davis.
2017-05-03 13:17:09 +02:00
Christian Kamm
d709a47b93
Share dialog: Add option to copy/email direct links #5627
2017-05-03 10:26:27 +02:00
Jenkins for ownCloud
b02f724e7e
[tx-robot] updated from transifex
2017-05-03 02:18:29 +02:00
Matthew Setter
013a0e25d5
Document the checksums addition in 10.0
...
This commit documents the new checksums addition in 10.0, specifically
in the desktop client. This fixes owncloud/documentation/issues/2964.
2017-05-02 12:48:08 +02:00
Jenkins for ownCloud
6d2f77851e
[tx-robot] updated from transifex
2017-05-02 02:18:27 +02:00
Jenkins for ownCloud
131055aefc
[tx-robot] updated from transifex
2017-05-01 02:18:29 +02:00
Jenkins for ownCloud
0682f8793c
[tx-robot] updated from transifex
2017-04-30 02:18:28 +02:00
Jenkins for ownCloud
fdf4a53283
[tx-robot] updated from transifex
2017-04-29 02:18:29 +02:00
Jenkins for ownCloud
ccc1db02a0
[tx-robot] updated from transifex
2017-04-28 02:18:30 +02:00
Luca Lorenzetto
3db8d3dfb6
When creating explorer favorite use more specific windows functions ( #5690 )
...
Fixes https://github.com/owncloud/client/issues/2719
2017-04-27 10:34:07 +02:00
Jenkins for ownCloud
4e15e2055c
[tx-robot] updated from transifex
2017-04-27 02:18:30 +02:00
Tommy Sparber
72a3e08907
Move check for mono icons into separate function
2017-04-26 17:39:01 +02:00
Christian Kamm
f8c0e796df
SqlDatabase: Ask freeSpace for directory, fix for Windows
...
See owncloud/enterprise#1955
2017-04-26 12:38:04 +02:00
Jenkins for ownCloud
fd40113e48
[tx-robot] updated from transifex
2017-04-26 02:18:39 +02:00
Jenkins for ownCloud
ca8b961e60
[tx-robot] updated from transifex
2017-04-25 02:18:37 +02:00
Markus Goetz
b6e3709e74
ChangeLog for 2.3.2
2017-04-24 12:08:36 +02:00
Michael Stingl
4202387c52
templates > .github and create release_template ( #5590 )
2017-04-24 11:54:53 +02:00
Christian Kamm
cd4e647816
Merge remote-tracking branch 'origin/2.3'
2017-04-24 10:32:53 +02:00
Jenkins for ownCloud
fd97a09e64
[tx-robot] updated from transifex
2017-04-24 02:18:29 +02:00
Jenkins for ownCloud
42d2594071
[tx-robot] updated from transifex
2017-04-23 02:18:28 +02:00
Jenkins for ownCloud
ff70cf9b5f
[tx-robot] updated from transifex
2017-04-22 02:18:28 +02:00
Kiril Vladimiroff
3a31694147
Remove all conditional checks for Qt 4.x ( #5505 )
2017-04-21 18:13:32 +02:00
Christian Kamm
05236f0a7a
Sharing multiple public links: Depend on new capability
...
See owncloud/core#27709 : files_sharing/public/multiple
2017-04-21 14:08:00 +02:00
ckamm
a475526805
Merge pull request #5695 from ckamm/sharedialog-multiplelinkshares
...
Multiple link shares and UI adjustments for share dialog
2017-04-21 10:17:55 +02:00
Christian Kamm
3c1a2cde33
ShareDialog: Review fixes
...
* Allow creating nameless shares
* Display token as name for nameless shares
(both to be consistent with server)
* Allow changing a share's name by editing it in the table
* Minor adjustments
2017-04-21 10:16:08 +02:00
Christian Kamm
a1f7168d2a
ShareDialog: Add support for multiple public link shares #5655
...
Starting from oC 10.0.0 having several public link shares with
different attributes for a path will be supported. This adds
functionality to create, edit and delete these public link shares.
The behavior is currently gated by server version, but should be
adapted to use a capability as soon as one is introduced, see
owncloud/core#27622 .
The UI reduces to a single-share version when talking to older servers.
Testing scenarios:
* Link sharing is disabled (by capability, not by theme)
* Required passwords
* Required expiry
* Forbidden 'allow upload' for folders
* New and old servers
2017-04-21 10:10:12 +02:00
Christian Kamm
1e1c2f8de2
Rename ShareWidget to ShareUserLine
...
There will probably be a ShareLinkLine too, due to #5655
2017-04-21 10:09:01 +02:00
Christian Kamm
76e67db04b
ShareDialog: Use a tab widget #5655
2017-04-21 10:09:01 +02:00
Jenkins for ownCloud
9d06e99b58
[tx-robot] updated from transifex
2017-04-21 02:18:30 +02:00
Kaustubh Welankar
70c3514996
Removed Magic Numbers in propagator #5685 ( #5705 )
2017-04-20 11:14:53 +02:00
Olivier Goffart
9aeb587d6c
Require Qt5
2017-04-20 09:39:41 +02:00
Dominik Schmidt
51041d0f15
Disable Qt4 CI
2017-04-20 09:39:41 +02:00
ckamm
543e8a224c
Fix a crash in ProxyAuthHandler ( #5711 )
...
See
https://sentry.io/owncloud/desktop-win-and-mac/issues/243433178/activity/
https://sentry.io/owncloud/desktop-win-and-mac/issues/234182688/activity/
The problem was that an account's QNetworkAccessManager can be deleted
when reentering the event loop.
2017-04-20 09:21:33 +02:00
ckamm
ea378fe837
FolderStatusModel: Fix crash for empty relativePath ( #5713 )
...
The problem was that split("", SkipEmptyParts) is the empty list.
See
https://sentry.io/owncloud/desktop-win-and-mac/issues/251167186/
2017-04-20 09:16:55 +02:00
Markus Goetz
de9ee295be
Some Dialogs: Bring to top on tray click #5515 #5566 ( #5664 )
...
On my OS X, it might get hidden under other apps while I opened it and then want to quickly
verify something in another app.
2017-04-20 08:55:44 +02:00
Jenkins for ownCloud
3a8d6a6f16
[tx-robot] updated from transifex
2017-04-20 02:18:30 +02:00
Markus Goetz
5ac58d3b83
Server: Parse version from capabilities too #5691 ( #5698 )
...
Newer servers will have the option of hiding version, versionstring, edition
and productname. They will always send the full information in the capabilities.
2017-04-19 11:02:03 +02:00
dheule
ada2be94f2
added owncloudcmd bandwidth limit parameter ( #5707 )
2017-04-19 10:32:36 +02:00
Jenkins for ownCloud
866991df4c
[tx-robot] updated from transifex
2017-04-19 02:18:38 +02:00
Jenkins for ownCloud
7613938181
[tx-robot] updated from transifex
2017-04-18 02:18:27 +02:00
Jenkins for ownCloud
4eb4069c15
[tx-robot] updated from transifex
2017-04-17 02:18:28 +02:00
Jenkins for ownCloud
f097e472f4
[tx-robot] updated from transifex
2017-04-16 02:18:27 +02:00
Jenkins for ownCloud
c46b97ec37
[tx-robot] updated from transifex
2017-04-15 02:18:27 +02:00
Jenkins for ownCloud
1994cd7ba2
[tx-robot] updated from transifex
2017-04-14 02:18:37 +02:00
Olivier Goffart
8cb3a77022
Merge remote-tracking branch 'origin/avatar_pics'
...
Also fix compilation because of 22370fdbdadd06f0cacd249a8d7a32f0d3c1374e
Pull request #5482
2017-04-13 11:54:28 +02:00
Olivier Goffart
1ed4eb46f2
Merge remote-tracking branch 'origin/2.3'
...
Conflicts:
VERSION.cmake
2017-04-13 10:19:35 +02:00
Christian Kamm
7c31da5a95
AccountSettings: Sync with clean discovery on Ctrl-F6 #5666
2017-04-13 10:11:21 +02:00
Christian Kamm
1f245b3791
AccountSettings: Easier access to selected folder alias
2017-04-13 10:11:21 +02:00
Olivier Goffart
4af45394f9
owncloudcmd: return code depend on sync result
...
Issue #3936
2017-04-13 10:10:47 +02:00
Jenkins for ownCloud
c1c5a488d0
[tx-robot] updated from transifex
2017-04-13 02:18:32 +02:00
Markus Goetz
554d1b88fc
Avatar: macOS support
2017-04-12 17:55:28 +02:00
Jenkins for ownCloud
5e18d5cf4e
[tx-robot] updated from transifex
2017-04-12 02:18:30 +02:00
Christian Kamm
8a639d39fc
ShareDialog: Reenable user input textedit on error #5694
2017-04-11 15:50:32 +02:00
Jenkins for ownCloud
e43425cf16
[tx-robot] updated from transifex
2017-04-11 02:18:28 +02:00
Markus Goetz
26af3ce525
Wizard: Improve folder creation (2)
2017-04-10 16:15:28 +02:00
Jenkins for ownCloud
5f316f8b96
[tx-robot] updated from transifex
2017-04-10 02:18:28 +02:00
Jenkins for ownCloud
35060f4954
[tx-robot] updated from transifex
2017-04-09 02:18:27 +02:00
Jenkins for ownCloud
0b2f1dda48
[tx-robot] updated from transifex
2017-04-08 02:18:38 +02:00
Jenkins for ownCloud
1a555449ec
[tx-robot] updated from transifex
2017-04-08 01:15:19 +02:00
Jenkins for ownCloud
5ba61e5399
[tx-robot] updated from transifex
2017-04-07 02:18:29 +02:00
Jenkins for ownCloud
0809703d2b
[tx-robot] updated from transifex
2017-04-06 02:18:28 +02:00
Jenkins for ownCloud
55b423fbb5
[tx-robot] updated from transifex
2017-04-06 01:15:15 +02:00
Markus Goetz
e08ec11fd4
Wizard: Improve folder creation
2017-04-05 16:55:52 +02:00
Jenkins for ownCloud
0c2f65a939
[tx-robot] updated from transifex
2017-04-05 02:18:28 +02:00
Christian Kamm
29e34bd2c0
Doc: Update to new sync journal db name #5662
2017-04-04 10:49:26 +02:00
Christian Kamm
6abc2bf72d
Transfers: Show a decimal for single digit MB rates #4428
2017-04-04 09:54:06 +02:00
Christian Kamm
a10fe84a83
ShareDialog: Hide the detailed permissions if there is only one #5655
2017-04-04 09:40:48 +02:00
Christian Kamm
7d9c4d052c
ShareDialog: Margin and spacing refinements #5627
2017-04-04 09:40:48 +02:00
Christian Kamm
f8d69dfe8e
ShareDialog: Fix thumbnail size #5654
2017-04-04 09:40:48 +02:00
Christian Kamm
2841714817
owncloudcmd docs: Mention required sync-exclude.lst #5679
2017-04-04 09:38:23 +02:00
Christian Kamm
35af03b2e5
Improve http error messages; cleanup
...
By default QNetworkReply::errorString() often produces messages like
"Error downloading <url> - server replied: <reason>"
but the "downloading" part invariably confuses people since the
error might very well have been produced by a PUT request.
This commit produces clearer error messages for HTTP errors.
Additionally:
* Remove some unnecessary null checks from slots connected to
network job signals and document that these signals never send
null replies.
* There was a bug where AbstractNetworkJob::_timedout wasn't
set when derived classes overrode slotTimeout. We now ensure
it's always set by disallowing overrides of slotTimeout.
Instead it now calls onTimedOut, which allows custom handling.
* Several subclasses declared errorString, isTimedOut. Move
these to AbstractNetworkJob.
* Unify handling of OC-ErrorString (via the new, general
Job::errorString)
* Add documentation in various places.
2017-04-04 09:27:37 +02:00
Jenkins for ownCloud
ce735d8d68
[tx-robot] updated from transifex
2017-04-04 02:18:31 +02:00
Samuel Alfageme
ae018eab42
Fixing a duplicate in the build instructions
...
- The duplicate and some typos were introduced in 42aed56a5a
- Also fixes some minor format issues. There's a lot of notes in this docs, we should refactor some.
2017-04-03 21:19:39 +02:00
Jenkins for ownCloud
484c8397e3
[tx-robot] updated from transifex
2017-04-03 02:18:28 +02:00
Jenkins for ownCloud
b8de36c585
[tx-robot] updated from transifex
2017-04-02 02:18:27 +02:00
Jenkins for ownCloud
59ba292edd
[tx-robot] updated from transifex
2017-04-01 02:18:36 +02:00
Jenkins for ownCloud
bc9c4fe17b
[tx-robot] updated from transifex
2017-03-31 02:18:27 +02:00
Jenkins for ownCloud
7253f64d26
[tx-robot] updated from transifex
2017-03-30 02:18:30 +02:00
Markus Goetz
28e9c56a4b
Chunking NG: Also send OC-Total-Length on MOVE
...
For https://github.com/owncloud/core/issues/26988
2017-03-29 19:51:02 +02:00
Roeland Jago Douma
68f0f1b404
complete url when using themed wizardUrlPostfix
...
Before we would only open the part of the url that the users entered.
Now if the wizardUrlPostfix is used this is should be appended to that
when opening the browser on the result page.
2017-03-29 18:09:15 +02:00
Samuel Alfageme
96f152d57c
Removed the coverity badge
...
Following the discussion on da45d99b8f
Also updated the link to the current building instructions.
2017-03-29 17:26:10 +02:00
Jenkins for ownCloud
f1a35527ee
[tx-robot] updated from transifex
2017-03-29 02:18:28 +02:00
Olivier Goffart
039ff0ca8e
PropagateDownload: fix possible crash
...
Backtrace looks like this:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x0
File "propagatedownload.cpp", line 234, in OCC::GETFileJob::slotReadyRead
File "moc_propagatedownl_CA5CFSHZDTX34X.cpp", line 86, in OCC::GETFileJob::qt_static_metacall
File "qobject.cpp", line 495, in QMetaCallEvent::placeMetaCall
File "qobject.cpp", line 1256, in QObject::event
File "qapplication.cpp", line 3804, in QApplicationPrivate::notify_helper
GETFileJob::slotReadyRead can be called with a QueuedConnection when the
bendwith manager is involved. In that case, if the QNAM was reset
in between, the reply might have been destroyed.
(This is only speculation based on the backtrace)
2017-03-28 18:04:19 +02:00
Olivier Goffart
85afa4788b
AccountState: Attempt to fix a crash
...
Backtrace from the crash reporter:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x21
File "qcoreapplication.cpp", line 1281, in QCoreApplication::postEvent
File "qobject.cpp", line 2125, in QObject::deleteLater
File "connectionvalidator.cpp", line 240, in OCC::ConnectionValidator::reportResult
File "connectionvalidator.cpp", line 206, in OCC::ConnectionValidator::slotAuthFailed
File "moc_connectionvalidator.cpp", line 127, in OCC::ConnectionValidator::qt_static_metacall
File "qobject.cpp", line 3716, in QMetaObject::activate
File "moc_networkjobs.cpp", line 653, in OCC::PropfindJob::finishedWithError
File "networkjobs.cpp", line 570, in OCC::PropfindJob::finished
I believe the problem is caused because 'this' was deleted in ConnectionValidator::reportResult
as the signal connectionResult gets emited. The AccountState::slotConnectionValidatorResult
slot does indeed call slotInvalidCredentials which might call {Shibboleth,Http}Credentials::fetchFromKeychain
which might emit fetched directly, which will call AccountState::slotCredentialsFetched
which deletes the _connectionValidator
So use deleteLater when deleting the _connectionValidator, hoping this helps
2017-03-28 18:04:19 +02:00
Christian Kamm
53c5f03c32
Merge branch 'dynamic_chunking'
2017-03-28 11:35:01 +02:00
Christian Kamm
e86499d990
dynamic chunking: cleanup, fixes, improvements
...
* make target duration a client option instead of a capability
* simplify algorithm for determining chunk size significantly
* preserve chunk size for the whole propagation, not just per upload
* move options to SyncOptions to avoid depending on ConfigFile
in the propagator
* move chunk-size adjustment to after a chunk finishes, not when
a new chunk starts
2017-03-28 11:32:10 +02:00
Jenkins for ownCloud
3ca071c612
[tx-robot] updated from transifex
2017-03-28 02:18:27 +02:00
Piotr M
88e0f97798
dynamic chunking prototype
2017-03-27 13:43:39 +02:00
Jenkins for ownCloud
d78b84a12f
[tx-robot] updated from transifex
2017-03-27 02:18:28 +02:00
Olivier Goffart
5c2b185374
VERSION: 2.3.1 was release, this branch is now for 2.3.2
2017-03-25 09:06:59 +01:00
Jenkins for ownCloud
8339ff3c1c
[tx-robot] updated from transifex
2017-03-25 02:18:28 +01:00
Jenkins for ownCloud
73e58fa090
[tx-robot] updated from transifex
2017-03-25 01:15:15 +01:00
Jürgen Weigert
e2cda2dc65
Update CMakeLists.txt
...
remove doc-man target in doc/CMakeLists.txt https://github.com/owncloud/client/issues/2153
2017-03-24 18:31:29 +01:00
ajasja
090d02a65f
Documented the usage of environment variables.
...
In particular the `OWNCLOUD_CHUNK_SIZE` as requested per #2449 .
I looked through the code and it seems the env vars override the conf file, but I'm not 100 % sure.
The `OWNCLOUD_CRITICAL_FREE_SPACE_BYTES` and `OWNCLOUD_FREE_SPACE_BYTES` are now mentioned in two places.
2017-03-24 12:26:46 +01:00
Christian Kamm
a0e88477c1
ShareDialog: Make "can edit" partially checked sometimes #5642
...
Previously the check box was checked if *any* of its sub-permissions
were granted. This can hide the fact that only a limited subset of them
are actually granted.
The new behavior is to display as "partially checked" if only some
of the sub-permissions are available. Clicking the check box itself
still toggles between granting all or none of them.
2017-03-24 09:52:01 +01:00
Jenkins for ownCloud
4e70a14c29
[tx-robot] updated from transifex
2017-03-24 02:18:28 +01:00
Markus Goetz
da45d99b8f
Update README.md
...
Fix Jenkins badges
2017-03-23 18:18:36 +01:00
Jenkins for ownCloud
14131cf020
[tx-robot] updated from transifex
2017-03-23 02:18:37 +01:00
Jenkins for ownCloud
dd5b36779d
[tx-robot] updated from transifex
2017-03-22 02:18:28 +01:00
Christian Kamm
f67989afea
Wizards: Never propose an existing folder for syncing #5597
2017-03-21 17:07:35 +01:00
Christian Kamm
14fef4a0d3
Wizard: Remove unused oldLocalFolder property
2017-03-21 17:07:35 +01:00
Olivier Goffart
d3439d5526
owncloudsetuppage.ui: Remove that file, it is unused
2017-03-21 16:38:13 +01:00
Jenkins for ownCloud
34bb950889
[tx-robot] updated from transifex
2017-03-21 02:18:29 +01:00
Samuel Alfageme
489efa24f7
Fixing a typo on an issue reference
...
(cherry picked from commit ed03cdf45a )
2017-03-20 17:29:36 +01:00
Matthew Setter
9840ae9e96
Fix incorrect documentation for the ownCloud command-line client
...
This fixes #5609 .
2017-03-20 17:29:16 +01:00
Samuel Alfageme
d375e9b86c
Including some info on the proxy config. in the docs.
...
This was a request of @michaelstingl to document how to configure the proxy manually via the .cfg file for config provisioning purposes.
- Restructured the bullet points into 3 different tables; I believe it's a cleaner approach; maybe this is also applicable to other sections.
- Would be logical to include also settings on proxy auth?
2017-03-20 11:55:02 +01:00
Olivier Goffart
722918abd6
Folder::showSyncResultPopup: Fix undefined behavior when there is no errors
...
When there is no errors _syncResult.firstItemError() is NULL, and accessing
it's _file member is an undefined behavior. (Thankfully, createGuiLog did not
use the string when the count was 0, but we are not supposed to create
null references.
Found with the UB sanitizer:
src/gui/folder.cpp:348:49: runtime error: member access within null pointer of type 'OCC::SyncFileItem'
src/gui/folder.cpp:348:19: runtime error: reference binding to null pointer of type 'const QString'
2017-03-20 11:53:13 +01:00
Jenkins for ownCloud
48fe8d1cb8
[tx-robot] updated from transifex
2017-03-20 02:18:28 +01:00
Jenkins for ownCloud
1000cdda09
[tx-robot] updated from transifex
2017-03-19 02:18:28 +01:00
Jenkins for ownCloud
d71b59b817
[tx-robot] updated from transifex
2017-03-18 02:18:35 +01:00
Jenkins for ownCloud
95b92c12ac
[tx-robot] updated from transifex
2017-03-17 02:18:36 +01:00
Olivier Goffart
4597201560
Merge remote-tracking branch 'origin/2.3'
...
Conflicts:
src/libsync/owncloudpropagator.h
2017-03-16 14:35:08 +01:00
Olivier Goffart
a60370255e
ActivityListModel: attempt to fix a crash.
...
The backtrace seems to indicate that the account is invalid.
I don't know how this can happen, maybe the account's display
name was changed while the app is running?
Backtrace:
Crash: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS at 0x18
Module "owncloud", in OCC::AccountState::account
Module "owncloud", in OCC::ActivityListModel::data
Module "owncloud", in OCC::ActivityItemDelegate::paint
Module "QtWidgets", in QListView::paintEvent
Module "QtWidgets", in QWidget::event
Module "QtWidgets", in QFrame::event
Module "QtWidgets", in QAbstractScrollArea::viewportEvent
Module "QtWidgets", in QAbstractItemView::viewportEvent
Module "QtWidgets", in QAbstractScrollAreaFilter::eventFilter
Module "QtCore", in QCoreApplicationPrivate::sendThroughObjectEventFilters
2017-03-16 14:31:15 +01:00
Olivier Goffart
21909cae04
Propagator: change order of destruction
...
The destructor of the PropagateItemJob will access the propagator's
_activeJobList. So the _rootJob needs to be destroyed before it.
Order of destruction is the reverse of the order of the members in
the class. So put it at the end so it can be destroyed first.
(This made TestSyncEngine::testDirDownloadWithError crash sometimes
in the master branch)
2017-03-16 14:24:25 +01:00
Markus Goetz
176ea20fef
ChangeLog for 2.3.1
2017-03-16 14:19:23 +01:00
Olivier Goffart
574435687d
Merge remote-tracking branch 'origin/2.3'
...
Conflicts:
src/libsync/owncloudpropagator.cpp
2017-03-16 13:51:53 +01:00
Christian Kamm
1a279ca158
About: Show the runtime versions of Qt and OpenSSL #5592
...
I didn't want to touch this visible translated string in a
patch release so I just switched the data.
For Qt versions before 5, we continue to show the build-time version
of OpenSSL but it's clearly marked as such.
2017-03-16 12:40:42 +01:00
Olivier Goffart
0ed929f24b
SyncEngine: fix test regression in TestChunkingNG::testCreateConflictWhileSyncing
...
In 8ef11a38c9 , we started blacklisting
SoftError for 0 seconds. But if the two sync happen with less than
1s interval, we would still prevent them to happen.
So make sure we expire if 0 seconds have expired
2017-03-16 10:17:08 +01:00
Jenkins for ownCloud
41eeed981f
[tx-robot] updated from transifex
2017-03-16 02:18:29 +01:00
Olivier Goffart
8e68e0321c
Attempt to fix a crash in FolderStatusModel::slotUpdateDirectories
...
The backtrace looks like:
File "atomic_base.h", line 396, in QString::~QString
File "qlist.h", line 442, in OCC::FolderStatusModel::slotUpdateDirectories
This is the only QList operation, and it may crash if the list is empty.
It can be empty if the propfind returned empty results.
I'm not sure how this can be possible to have an empty list there since
the server is always supposed to return at least one entry, for the directory
itself. But it can happen if a directory was transformed in a file, or
if there is a bug on the server.
2017-03-15 17:23:39 +01:00
Christian Kamm
881b32521b
HttpCreds: Update app passwords url #5605
...
See also owncloud/core#27360
2017-03-15 16:30:08 +01:00
Christian Kamm
b98876e265
Account server version: Helper to create versions
...
Hex literals don't work well with version 10: 0x100000 doesn't do
the right thing.
2017-03-15 16:30:08 +01:00
Olivier Goffart
dbb5bcb784
Ignore list editor: adjust the size
...
The previous patch on this file made it a bit too big, so make it a bit smaller
For issue #5600
2017-03-15 16:00:48 +01:00
Samuel Alfageme
fce194ce08
Using different window flags on the connection method dialog ( #5614 )
...
This is a possible fix for #3850 , applying custom window flags (http://doc.qt.io/qt-5.8/qt.html#WindowType-enum ) on the connection method dialog. These avoid resizing the dialog and displaying a maximize button on OS X and context help button on Windows.
2017-03-15 15:46:51 +01:00
Jenkins for ownCloud
d95b43f347
[tx-robot] updated from transifex
2017-03-15 02:18:36 +01:00
Christian Kamm
9ca9773e9d
Add more versions to --version #5592
...
* Add git revision, if available
* Add SSL runtime version
* Add compile-time Qt version
2017-03-14 16:13:52 +01:00
Christian Kamm
13b2568358
Windows/NTFS: Do not attempt to upload inaccessible files #5544
...
It is possible to create files with filenames that differ
only by case in NTFS, but most operations such as stat and
open only target one of these by default.
When that happens, we want to avoid uploading incorrect data
and give up on the file.
Typically this situation should never occurr during normal use
of Windows. It can happen, however, when a NTFS partition is
mounted in another OS.
2017-03-14 16:03:08 +01:00
Jenkins for ownCloud
7a2d12bb47
[tx-robot] updated from transifex
2017-03-14 02:18:30 +01:00
Olivier Goffart
2152bc5fca
Ignore list editor: adjust the size of the columns in the table
...
So the title of the column is fully visible.
Adjust the default size and the size policy of the label so it behave
correctly as the window get resized
Issue #5600
2017-03-13 17:05:24 +01:00
Jenkins for ownCloud
11aecf1af2
[tx-robot] updated from transifex
2017-03-13 02:18:30 +01:00
Jenkins for ownCloud
903d6c80fe
[tx-robot] updated from transifex
2017-03-12 02:18:30 +01:00
Jenkins for ownCloud
585221c58c
[tx-robot] updated from transifex
2017-03-11 02:18:38 +01:00
Christian Kamm
8ef11a38c9
Blacklist: Escalate repeated SoftError to NormalError #5500
2017-03-10 15:51:55 +01:00
Matthew Setter
5204524691
Merge pull request #5585 from owncloud/add-replace-sync-directory-to-faq
...
Add explanation of how to replace local sync folder to FAQ
2017-03-10 09:11:38 +01:00
Matthew Setter
9af7e8cff0
Revise the point about starting a clean sync
...
On review, after feedback from @phil-davis, he's right that users need
to be fully briefed as to the implications of choosing a clean sync —
especially when they have a large amount of data in their account.
2017-03-10 08:35:55 +01:00
Jenkins for ownCloud
f94a15b0fa
[tx-robot] updated from transifex
2017-03-10 02:18:30 +01:00
Klaas Freitag
5e33898a08
Avatar: Use QImage instead of QPixmap to avoid dep on QApplication.
...
That fixes the test suite.
2017-03-09 22:34:36 +01:00
Olivier Goffart
9c83c57f1c
Propagator: Attempt to fix a crash in OwncloudPropagator::scheduleNextJob
...
The crash reporter shows many crashes in OwncloudPropagator::scheduleNextJob.
We don't really know what could be the cause, but it's probably because
the _activeJobList contains dangling pointer.
So this patch makes sure to remove all the jobs from this list as they get
destroyed.
2017-03-09 15:48:52 +01:00
Olivier Goffart
1a98b49f1b
Fix TestSyncEngine::testDirDownloadWithError
...
On master, the scheduling is different and the tasks abort in another
order
2017-03-09 10:35:58 +01:00
Olivier Goffart
0e8f0481d4
Merge remote-tracking branch 'origin/2.3'
...
Conflicts:
src/libsync/owncloudpropagator.cpp
2017-03-09 09:54:14 +01:00
Jenkins for ownCloud
1d0ef83078
[tx-robot] updated from transifex
2017-03-09 02:18:30 +01:00
Jenkins for ownCloud
4ab217ba04
[tx-robot] updated from transifex
2017-03-08 02:18:33 +01:00
Matthew Setter
6580af65c1
Add explanation of how to replace local sync folder to FAQ
...
This fixes owncloud/documentation/issues/2923.
2017-03-07 15:41:24 +01:00
Christian Kamm
cdf16dd905
Remove unreachable code #5582
2017-03-07 13:23:47 +01:00
Christian Kamm
4a1a5fa076
AbstractNetworkJob: Improve redirect handling #5555
...
* For requests:
- reuse the original QNetworkRequest, so headers and attributes
are the same as in the original request
- determine the original http method from the reply and the request
attributes
- keep the original request body around such that it can be sent
again in case the request is redirected
* Simplify the interface that is used for creating new requests in
AbstractNetworkJob.
2017-03-07 13:18:01 +01:00
Jenkins for ownCloud
298684aaa0
[tx-robot] updated from transifex
2017-03-07 02:18:31 +01:00
Jenkins for ownCloud
005c027274
[tx-robot] updated from transifex
2017-03-07 01:15:15 +01:00
Olivier Goffart
f4495c5c80
ActivityListModel: fix possible crash in slotActivitiesReceived
...
Backtrace from the crash reporter:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x401
File "moc_activitylistmo_M5OEXJ7XGJYTWT.cpp", line 92, in OCC::ActivityListModel::qt_static_metacall
File "qobject.cpp", line 3730, in QMetaObject::activate
File "moc_networkjobs_7AMNCW4BBANVRK.cpp", line 1342, in OCC::JsonApiJob::jsonReceived
File "networkjobs.cpp", line 714, in OCC::JsonApiJob::finished
File "abstractnetworkjob.cpp", line 207, in OCC::AbstractNetworkJob::slotFinished
File "moc_abstractnetwor_PFI2TXGQHRE33H.cpp", line 98, in OCC::AbstractNetworkJob::qt_static_metacall
File "qobject.cpp", line 3730, in QMetaObject::activate
File "moc_qnetworkreply.cpp", line 367, in QNetworkReply::finished
File "qnetworkreplyhttpimpl.cpp", line 2100, in QNetworkReplyHttpImplPrivate::finished
File "qnetworkreplyhttpimpl.cpp", line 279, in QNetworkReplyHttpImpl::abort
My theory is that the AccountState stored in a property of the job was destroyed.
before the job timed out.
Therefore, the qobject_cast within the qvariant_cast would call the metaObject()
virtual function on a dangling pointer.
Fix it by storing a QPointer instead which will track the deletion.
2017-03-06 17:25:22 +01:00
Olivier Goffart
f862c626a1
Propagator: Fix finished signal of directory being emited twice and causing crash
...
When there is a FatalError, we ended up emiting the finished signal for
the directory job several times, which would lead to crashes
Issue #5578
2017-03-06 16:14:04 +01:00
Markus Goetz
6487bb071b
NSIS: Don't display link on finish page
2017-03-06 15:40:10 +01:00
Jenkins for ownCloud
e7296d03d3
[tx-robot] updated from transifex
2017-03-05 02:18:29 +01:00
Jenkins for ownCloud
139bb8f094
[tx-robot] updated from transifex
2017-03-04 02:18:29 +01:00
Olivier Goffart
d30ed7fb8a
VERSION: master branch is 2.4
2017-03-03 11:00:33 +01:00
Olivier Goffart
13df7fcee0
Merge branch '2.3'
...
Conflicts:
src/libsync/owncloudpropagator.cpp
2017-03-03 10:57:23 +01:00
Olivier Goffart
84ecbc4c89
2.3.0 was released: Update version
2017-03-03 10:48:47 +01:00
Olivier Goffart
4a010ce7cd
SslButton: Remove additional ')'
...
Regression since 7bfe061382
Issue: #5573
2017-03-03 10:43:47 +01:00
Jenkins for ownCloud
40698c8fd0
[tx-robot] updated from transifex
2017-03-03 02:18:27 +01:00
Jenkins for ownCloud
3adaf44f7b
[tx-robot] updated from transifex
2017-03-02 02:18:30 +01:00
Matthew Setter
6e4ecd11a1
Update client version from 2.2 to 2.3 ( #5568 )
...
As the latest version of 2.3, the version information needs to be
updated as well.
2017-03-01 13:26:49 +01:00
Jenkins for ownCloud
3983fecaf1
[tx-robot] updated from transifex
2017-03-01 02:18:28 +01:00
Jenkins for ownCloud
7effcff245
[tx-robot] updated from transifex
2017-02-28 02:18:28 +01:00
Jocelyn Turcotte
384f18da38
Potential fix for crash in PropagateDirectory::abort ( #5564 )
2017-02-27 17:09:29 +01:00
Jenkins for ownCloud
75e06c25c7
[tx-robot] updated from transifex
2017-02-27 02:18:29 +01:00
Jenkins for ownCloud
d0341eb509
[tx-robot] updated from transifex
2017-02-26 02:18:29 +01:00
Jenkins for ownCloud
74bf16ccb1
[tx-robot] updated from transifex
2017-02-25 02:18:28 +01:00
Jenkins for ownCloud
96e1f74ef3
[tx-robot] updated from transifex
2017-02-24 02:18:31 +01:00
Jocelyn Turcotte
793a994ce6
Don't abort propagation job abortions synchronously from finished
...
This leads to crashes since we changed the connection to the parent
jobs not to be queued anymore.
We don't really need to bubble up the finished state through
parents in that case, and it would also mean that we'd recurse
all the way through leaves as we go up to each parent. So just call
abort directly on the OwncloudPropagator and make sure the abortion
call is posted to the event loop.
2017-02-23 17:54:33 +01:00
Jocelyn Turcotte
19bf5e2ff1
Reduce the connection data used by PropagateDirectory objects
...
Avoid using connections to report up the job tree for signals
that we can directly communicate to the OwncloudPropagator.
This slightly reduces the memory usage and avoid passing those calls
through the whole parent chain.
2017-02-23 17:54:33 +01:00
Jocelyn Turcotte
16ad3d5c88
Create PropagateItemJobs only before starting them
2017-02-23 17:54:33 +01:00
Jocelyn Turcotte
ff2d98596f
Split running jobs into a separate vector
2017-02-23 17:54:33 +01:00
Jocelyn Turcotte
072698d606
Split the subjob logic out of PropagateDirectory
2017-02-23 17:54:33 +01:00
Jocelyn Turcotte
0b098045f1
Replace WaitForFinishedInParentDirectory with WaitForFinished for directory moves
...
In preparation for the PropagateDirectory refactoring, simplify things
by removing WaitForFinishedInParentDirectory, which is currently
implemented as a one-level check.
This value is important for directory items, but is however never
used since a directory CSYNC_INSTRUCTION_RENAME item will always be in
PropagateDirectory::_firstJob, which will have to pass through its own
PropagateDirectory job's parallelism() before reaching the parent's
_subJobs optimization.
Since PropagateDirectory::parallelism can only return WaitForFinished
or FullParallelism, that value is lost. So this commit doesn't
change the behavior for directories, and allow file renames to be
scheduled in parallel across directories (which isn't a problem).
2017-02-23 17:54:33 +01:00
Jocelyn Turcotte
ddb6b3b262
Fix TestSyncEngine::abortAfterFailedMkdir (again)
...
It could be possible that _firstJob is marked as finished if
aborted before its parent PropagateDirectory was marked as finished,
allowing a posted scheduleNextJob call to schedule the child job
in-between.
2017-02-23 17:54:33 +01:00
Olivier Goffart
7bfe061382
Verify that all strings are properly escaped ( #5558 )
...
- I checked every occurence of a '%2' and make correct use of the
QString::arg overload that takes several argument instead of chaining
them, because the first argument can contains a '%1'
- I tried to look for every label that they either use plain text or richtext
and escape the user provided strings in there.
2017-02-23 14:54:17 +01:00
Jenkins for ownCloud
1333252902
[tx-robot] updated from transifex
2017-02-23 02:18:29 +01:00
Christian Kamm
21a09df7d1
Wizard: Handle PROPFIND redirects #5553
...
By default, followRedirects is true for all requests, to transparently
handle redirections. In the wizard, we have special redirect-handling
code though and that was being skipped.
Setting the flag to false allows the wizard to be aware of redirects
and to handle them in the correct way. Tested with the server described
in
https://github.com/owncloud/administration/tree/master/redirectServer
There's a second bug here, where followRedirects always converts
redirected requests to the GET verb. That means redirected PROPFINDs
will never have worked. This change un-breaks them for the wizard only.
There should be no case that previously worked that stops working now.
2017-02-22 13:24:13 +01:00
Jenkins for ownCloud
23313c47f8
[tx-robot] updated from transifex
2017-02-22 02:18:36 +01:00
Matthew Setter
7f2470f1f6
Merge pull request #5549 from owncloud/fix-documentation-build-process
...
Fix documentation build process
2017-02-21 13:52:45 +01:00
Matthew Setter
488b964c52
Merge branch 'master' into fix-documentation-build-process
2017-02-21 12:07:57 +01:00
Matthew Setter
b4d3f696bf
Re-add the Makefile for controlling the build process
...
I'm not sure, why the file was removed, it was there in 2013, but it was
removed. This commit adds it back so that the build process can be
automated in a UNIX environment.
2017-02-21 11:58:15 +01:00
Markus Goetz
4a880ec113
Update ChangeLog
2017-02-21 11:53:54 +01:00
Matthew Setter
9cc4d363b2
Fix the Sphinx-doc build configuration
...
I'm not sure what the configuration/setup has been like to date. But as
it stood, it didn't build successfully. Given that, I've created a copy
of doc/conf.py, included in this commit, from the default doc/conf.py.in
and set the appropriate variables as necessary.
NOTE: The build didn't work when the version, release, and latex_logo
values weren't set, either directly or with interpolatable values.
2017-02-21 11:49:23 +01:00
Matthew Setter
b646caffd0
Merge pull request #5547 from owncloud/update-docs-build-configuration
...
Create a build configuration file
2017-02-21 09:37:01 +01:00
Matthew Setter
b9bc3e36b8
Merge pull request #5545 from owncloud/grammar-updates
...
Fix grammar and spelling errors in the documentation
2017-02-21 09:28:55 +01:00
Jenkins for ownCloud
39b16389f9
[tx-robot] updated from transifex
2017-02-21 02:18:36 +01:00
Markus Goetz
65d8f51a10
Message Boxes: Force to be more on top #5503 ( #5536 )
2017-02-20 13:58:35 +01:00
Matthew Setter
24aaf7a034
Create a build configuration file
...
This is no different from the default file, conf.py.in, except for the
specification of the logo file.
2017-02-20 11:04:01 +01:00
Matthew Setter
80f2e40e67
Fixed grammar and spelling errors in the documentation
2017-02-20 10:52:22 +01:00
Jenkins for ownCloud
15d1c7374c
[tx-robot] updated from transifex
2017-02-20 02:18:28 +01:00
Jenkins for ownCloud
a11cee4e26
[tx-robot] updated from transifex
2017-02-19 02:18:28 +01:00
Jenkins for ownCloud
a9dc2ebff6
[tx-robot] updated from transifex
2017-02-18 02:18:30 +01:00
Olivier Goffart
112a7dba73
Propagator: Fix t8.pl
...
The test sets OWNCLOUD_MAX_PARALLEL to 1 to disable parallelism.
But since the max amount of parallelism is twice as much, that does not
work.
So change the way we compute the hardMaximumActiveJob: Use the value of
OWNCLOUD_MAX_PARALLEL to maximize this amount and base the maximum amount
of transfer jobs on it instead of the other way.
A result of this change is that, in case of bandwidth limit, we keep the
default of 6 non-transfer jobs in parallel. I believe that's fine since
the short jobs do not really use bandwidth, so we can still keep the same
amount of small jobs.
2017-02-17 16:56:57 +01:00
Christian Kamm
ee11b5d9be
Revert "Don't blacklist 507 Insufficent Storage #5346 ( #5424 )"
...
This reverts commit e1f5a49c21 .
Retrying uploads with insufficent storage errors frequently leads to
high server traffic. See #5537 for links and a sketch of a correct
solution.
2017-02-17 16:21:54 +01:00
Jocelyn Turcotte
824be789bf
Revert "Fix TestSyncEngine::abortAfterFailedMkdir"
...
This reverts commit 1cec2ca13d
but keeps the reset() -> take() part that is probably the cause
of crashes we've seen in the crash reporter.
2017-02-17 14:06:30 +01:00
Jenkins for ownCloud
db20aa01da
[tx-robot] updated from transifex
2017-02-17 02:18:36 +01:00
Olivier Goffart
a3f4907e0b
AccessManager: don't set an invalid network configuration on linux ( #5538 )
...
If we call
setConfiguration(QNetworkConfiguration());
This sets an invalid configuration on the QNAM.
But later, when we really go online because interfaces are discovered,
QNetworkAccessManagerPrivate::_q_onlineStateChanged is called (with isOnline=true).
And this will set the state to disconnected because customNetworkConfiguration is
true, and the networkConfiguration state is disabled.
The workaround we to fix another bug on Windows in which the default network
configuration was not behaving properly.
The issue on linux is hard to reproduce and only happen in some condition,
but it was reproduced on smashbox when they run two owncloudcmd at the same time.
Issues: #4720 , #3600
2017-02-16 16:14:55 +01:00
Christian Kamm
4d7dd0c909
Recent Changes: Fix duplicates #5256
...
The transmissionProgress emission when the whole sync finishes
shouldn't look exactly like the one for the last file.
2017-02-16 15:10:46 +01:00
Jenkins for ownCloud
88da5f6592
[tx-robot] updated from transifex
2017-02-16 02:18:36 +01:00
Olivier Goffart
e8c10501a5
Folder: Keep files option after aboutToRemoveAllFiles should not clear selective sync list ( #5531 )
...
We were removing the wholme journal db when the user wanted to keep all files,
But that would also remove the selective sync lists.
We should only remove the metadata table.
Issue #5484
2017-02-15 13:27:41 +01:00
Roeland Jago Douma
99aaf22ae5
Update windows docker file to use 2.3 OBS repo
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-02-15 09:49:29 +01:00
Jenkins for ownCloud
3943016f3b
[tx-robot] updated from transifex
2017-02-15 02:18:29 +01:00
Olivier Goffart
172689d35c
Merge remote-tracking branch 'origin/2.3'
2017-02-14 15:08:10 +01:00
Jocelyn Turcotte
60a4a742a3
Disable tests uncompatible with Qt4 for that build
2017-02-14 14:32:41 +01:00
Jocelyn Turcotte
b26db062d2
Fix the UNIT_TESTING build on Windows
...
- Put all tests in the bin directory so that DLLs can be loaded
- Add missing exports
- Skip tests that use code depending on zlib
- The "GMT" timezone is named differently, use the int constructor instead
5 tests are still failing, it's not really worth fixing at the moment
since no developper is currently using Windows as its main platform.
2017-02-14 14:32:41 +01:00
Jocelyn Turcotte
611f633ba8
Fix FolderManTest on macOS
...
On macOS /var is a symlink to /private/var and we have to make sure that we
use the canonical path before and after it enters the code to make sure we
compare paths correctly.
2017-02-14 14:32:41 +01:00
Jocelyn Turcotte
3265948458
Fix ExcludedFilesTest on macOS
...
Use the same logic to find sync-exclude as check_csync_exclude.c
2017-02-14 14:32:41 +01:00
Jocelyn Turcotte
0e3e9d5991
Fix FileSystemTest on macOS
2017-02-14 14:32:41 +01:00
Jocelyn Turcotte
0be6cd3bf7
Fix FolderWatcherTest on macOS and Windows
...
- We need to use a QGuiApplication on macOS or else we don't get notifications
- Switch to use QSignalSpy rather than lists and sleeps
- Use system() for all modifications since we pass kFSEventStreamCreateFlagIgnoreSelf
- Keep using the local process on Windows since it catches its own events
2017-02-14 14:32:41 +01:00
Jocelyn Turcotte
867b78052d
Fix UtilityTest on macOS
2017-02-14 14:32:41 +01:00
Olivier Goffart
058f7df635
Folder: remove unused variable
2017-02-14 10:10:07 +01:00
Jenkins for ownCloud
c1552d7984
[tx-robot] updated from transifex
2017-02-14 02:18:27 +01:00
Markus Goetz
575b981542
Modify Jenkinsfile for 2.3
2017-02-13 14:47:51 +01:00
Jenkins for ownCloud
0d0af95956
[tx-robot] updated from transifex
2017-02-13 02:18:28 +01:00
Jenkins for ownCloud
6c5d873647
[tx-robot] updated from transifex
2017-02-12 02:18:28 +01:00
Jenkins for ownCloud
71187e1744
[tx-robot] updated from transifex
2017-02-11 02:18:34 +01:00
Christian Kamm
006ce854a6
Doc: For conflicts, the local file is renamed #5521
2017-02-10 12:50:35 +01:00
Jenkins for ownCloud
697178bab6
[tx-robot] updated from transifex
2017-02-10 02:18:29 +01:00
Jenkins for ownCloud
d8a86da377
[tx-robot] updated from transifex
2017-02-09 02:18:33 +01:00
Jocelyn Turcotte
d1dace9e7f
Remove unneeded Q_DECLARE_METATYPE
2017-02-08 17:57:20 +01:00
Jocelyn Turcotte
1cec2ca13d
Fix TestSyncEngine::abortAfterFailedMkdir
...
It could be possible that _firstJob is marked as finished if
aborted before its parent PropagateDirectory was marked as finished,
allowing a posted scheduleNextJob call to schedule the child job
in-between.
2017-02-08 17:32:04 +01:00
Jocelyn Turcotte
1d9e08d109
Skip TestSyncEngine::abortAfterFailedMkdir
2017-02-08 17:25:32 +01:00
ckamm
7879c470b3
Merge pull request #5518 from ckamm/asserts
...
Improve usage of asserts
2017-02-08 15:25:02 +01:00
Christian Kamm
3c7545a45f
CMake: Don't force-enable asserts #5429
...
Should be safer now that we've gone through asserts and assured that
one ones that should be fatal continue to exist in release builds
independently of QT_NO_DEBUG.
2017-02-08 15:15:19 +01:00
Christian Kamm
4c1fdf1dee
Double check usage of asserts #5429
...
A few are supposed to be fatal.
2017-02-08 15:15:19 +01:00
Christian Kamm
18e25122db
Performance: reserve() _remotePerm #5496
2017-02-08 15:06:09 +01:00
Olivier Goffart
439e688906
Folder: Change the wording for the massive deletion message
...
Issue #5503
2017-02-08 14:30:14 +01:00
ckamm
4198d9f420
Settings: Don't migrate settings on access error #5499 ( #5523 )
...
Previously, we'd try migrating from legacy settings if reading
the settings failed with an error. Now, we try again after a
couple of seconds and eventually give up.
2017-02-08 14:28:50 +01:00
Olivier Goffart
06579a5c70
AccountManager: Fix small leak in the account migration code
...
The QSettings object was not deleted in every possible code paths
2017-02-08 12:31:07 +01:00
Markus Goetz
df773ea8bb
CentOS: More build fixes
2017-02-08 11:39:28 +01:00
Markus Goetz
e7be4faac8
CentOS: Another attempt
2017-02-08 11:15:23 +01:00
Jenkins for ownCloud
a184c6bec1
[tx-robot] updated from transifex
2017-02-08 02:18:27 +01:00
Markus Goetz
1102ac20ac
Improve previous fix
...
After comment on 78a798eef3
2017-02-07 19:40:32 +01:00
Markus Goetz
6a4ae63f14
CentOS: Another fix for old compiler version (2)
2017-02-07 19:22:04 +01:00
Markus Goetz
6c6961e4d9
ChangeLog for 2.3 additions
2017-02-07 19:04:00 +01:00
Markus Goetz
78a798eef3
Old Qt: Another build fix
2017-02-07 18:54:40 +01:00
Markus Goetz
19dd656989
CentOS: Another fix for old compiler version
2017-02-07 18:32:34 +01:00
Markus Goetz
d9fac50e9b
CentOS: Fix build for old compiler version
2017-02-07 18:05:29 +01:00
Markus Goetz
9614a94035
Revert "Disable RTTI"
...
This reverts commit 85d3de1589 .
This breaks our old Qt on CentOS.
We can re-introduce this with #5470
2017-02-07 17:35:04 +01:00
Jenkins for ownCloud
5002964546
[tx-robot] updated from transifex
2017-02-07 02:18:27 +01:00
Jenkins for ownCloud
4cca1ba55f
[tx-robot] updated from transifex
2017-02-06 02:18:27 +01:00
Jenkins for ownCloud
3e99c32582
[tx-robot] updated from transifex
2017-02-05 02:18:27 +01:00
Jenkins for ownCloud
74ce597f8d
[tx-robot] updated from transifex
2017-02-04 02:18:27 +01:00
Jenkins for ownCloud
a27b2d94b3
[tx-robot] updated from transifex
2017-02-03 02:18:27 +01:00
Jenkins for ownCloud
890e771ec1
[tx-robot] updated from transifex
2017-02-02 02:18:27 +01:00
Jenkins for ownCloud
5df10cb8f8
[tx-robot] updated from transifex
2017-02-01 02:18:28 +01:00
Jenkins for ownCloud
9acc974268
[tx-robot] updated from transifex
2017-01-31 02:18:26 +01:00
Jenkins for ownCloud
42e64026ae
[tx-robot] updated from transifex
2017-01-30 02:18:28 +01:00
Jenkins for ownCloud
78e7d13f9f
[tx-robot] updated from transifex
2017-01-29 02:18:27 +01:00
Jenkins for ownCloud
2d55332a45
[tx-robot] updated from transifex
2017-01-28 02:18:34 +01:00
Jenkins for ownCloud
72cd9abd4a
[tx-robot] updated from transifex
2017-01-28 01:15:15 +01:00
Olivier Goffart
0d16cf41fe
Merge remote-tracking branch 'origin/master' into 2.3
...
We can do that because the only changes that were in master but not in 2.3 were the
translations change and documentation change, and the support for the 'M' permission
which we want in 2.3.
2017-01-27 17:45:05 +01:00
Olivier Goffart
65e4afedc4
Account Wizard: don't whitelist everything on the first sync if we still want to confirm big folder
...
Issue: https://github.com/owncloud/client/pull/5340#issuecomment-274564441
2017-01-27 15:59:59 +01:00
Olivier Goffart
b76a9654cc
General Settings: Make sure to reload the settings when an account is added
...
The Size limit, or confirmation checkboxes might have changed.
We need to guard against saving if the control changes while we are loading
Issue: https://github.com/owncloud/client/pull/5340#issuecomment-274878023
2017-01-27 15:59:59 +01:00
Olivier Goffart
38cf459b3e
Confirm External Storage: adjust the notification message
...
We need to forward the information that the folder is an external storage
for the notification message.
Issue: https://github.com/owncloud/client/pull/5340#issuecomment-274878023
2017-01-27 15:59:59 +01:00
Olivier Goffart
ed7416098e
Wizard: Increase the size
...
The advanced page has become quite complex and does not fit on the screen
anymore if the fonts are too big
2017-01-27 15:59:59 +01:00
Olivier Goffart
517623e457
FolderStatusModel: Different icon for external storages
...
Issue: https://github.com/owncloud/client/pull/5340#issuecomment-274564441
2017-01-27 15:59:59 +01:00
Olivier Goffart
f89bc09fd1
Discovery: Filter 'M' out of permissions for non root storage
...
The sync engine rely on the 'M' in premission to ask for confirmation
(As requested in issue #5340 )
But we only want to ask the premission for the 'root' of the mounting point and not
for every subfolders within it.
So we change the discovery phase in a way that it does not keep the 'M' for
children within the external storage.
2017-01-27 15:59:59 +01:00
Olivier Goffart
f854c5263b
Wizard: Add options to ask confirmation for external storage
...
Added two checkboxes in the Account Wizard in the advanced page to change the first options.
Also added a checkbox in the general settings to ask for confirmation for external storages.
Theme options allow to hide the checkboxes in the wizard.
As described in issue #5340
2017-01-27 15:59:59 +01:00
Olivier Goffart
70da607e06
Discovery: Add branding option to disable default sync of 'M' directories
...
Issue #5331 and https://github.com/owncloud/enterprise/issues/1594
2017-01-27 15:59:59 +01:00
Jenkins for ownCloud
4f28b2daad
[tx-robot] updated from transifex
2017-01-27 02:18:28 +01:00
Jocelyn Turcotte
8884fe7236
Remove PropagateDirectory::_runningNow
...
This variable isn't used anymore except in a stray Q_ASSERT.
2017-01-26 17:13:54 +01:00
Jocelyn Turcotte
bb3efc5988
Clear SyncEngine::_remotePerms after the sync
...
Also make reuse the SyncFileItem::_remotePerm QByteArray allocation
instead of redoing the copy from the csync char*.
2017-01-26 17:13:54 +01:00
Jocelyn Turcotte
f6665ccc81
Pack boolean members in PropagateUploadFileCommon #5457
2017-01-26 17:13:54 +01:00
Jocelyn Turcotte
f1e9be4fa8
Don't use the StopWatch for each job in production builds #5456
...
This accounted for more than 10% of the peak memory usage while only
providing value through the debugging log.
2017-01-26 17:13:54 +01:00
Jocelyn Turcotte
9db23d4df1
Remove SyncFileItem::_requestDuration #5456
...
This will save a QElapsedTimer in each job that was used only for
.owncloudsync.log (for which the request duration doesn't bring much
value).
2017-01-26 17:13:54 +01:00
Jocelyn Turcotte
9d16ad844c
Don't reallocate a QByteArray for each contentChecksumType call #5481
2017-01-26 17:13:54 +01:00
Jocelyn Turcotte
b0700ebbab
Remove duplicate SyncFileItem entries for the log
...
The accuracy of that log isn't as important as the few bytes those
fields take as hostage for the whole sync.
2017-01-26 17:13:54 +01:00
Markus Goetz
2bda55be81
Don't create legacy 'folders/' subdirectory
2017-01-26 12:29:58 +01:00
Markus Goetz
e859d220be
Cookies: Use different DB for different accounts ( #5490 )
...
This is a follow up to #5469
2017-01-26 10:54:03 +01:00
Piotr Mrówczyński
c3ae5123cb
Delete finished propagation jobs in PropagateDirectory #5269 ( #5400 )
2017-01-26 10:03:22 +01:00
Jenkins for ownCloud
a1a5111a8a
[tx-robot] updated from transifex
2017-01-26 02:18:40 +01:00
Jocelyn Turcotte
ee211d7609
Release SyncFileItem objects with their job
...
We now delete subjobs as their propagation is complete. This allows us
to also release the item by making sure that nothing else is holding a
reference to it.
Remove the stored SyncFileItemVector from SyncEngine and SyncResult
and instead gather the needed info progressively as each itemCompleted
signal is emitted.
This frees some holes on the heap as propagation goes, allowing many
memory allocations without the need of requesting more virtual memory
from the OS, preventing the memory usage from increasingly growing.
2017-01-25 23:26:23 +01:00
Jocelyn Turcotte
1fc5a76622
Pass the SyncFileItem as SyncFileItemPtr in itemCompleted
...
This will allow us to keep a reference on the items in connected slots.
2017-01-25 23:26:23 +01:00
Jocelyn Turcotte
a764d7eb86
Don't pass the PropagatorJob in itemCompleted
...
This was to catch duplicate emissions for PropagateDirectory but we
don't emit this signal anymore from there.
This fixes a warning about PropagatorJob not being a registered metatype.
This reverts commit fe42c1a818 .
2017-01-25 23:26:23 +01:00
Jocelyn Turcotte
605a18ff73
Tests: Add a large sync benchmark
...
This simulates a ~50k files sync that can be used to measure memory
usage without having to wait for a server.
2017-01-25 23:26:23 +01:00
Jocelyn Turcotte
92e86641d1
Bring back the error message if the sync-exclude.lst file is missing
...
We unconditionnally add the file on startup, but don't check for errors.
During sync we check for errors, but only try loading the file if it
exists.
2017-01-25 23:26:23 +01:00
Markus Goetz
c8cfb3160e
Merge remote-tracking branch 'origin/selective-sync-big-folder' into 2.3
2017-01-25 19:45:20 +01:00
Olivier Goffart
268fc97a71
Merge pull request #5480 from owncloud/chunking-ng-cleanup
...
Chunking ng cleanup
2017-01-25 19:19:48 +01:00
Jenkins for ownCloud
de2458d892
[tx-robot] updated from transifex
2017-01-25 02:18:34 +01:00
Matthew Setter
d75b838897
Add extra note about deleting .csync_journal.db
...
This is added as per the recommendation from @guruz in #5252 .
2017-01-24 16:18:21 +01:00
Carla Schroder
4df7cab72a
add note about deleting .csync_journal.db for "CSync unknown error"
2017-01-24 16:18:21 +01:00
Christian Kamm
59c1fdbe05
Shib: Use different keychain entry per account #5469
...
Previously shib multiaccount didn't work at all because the
session cookie was stored in the same keychain entry.
2017-01-24 13:14:11 +01:00
Christian Kamm
26234dbf6c
Folders: Adjust ui when account is disconnected #5477
...
Previously if you paused/unpaused a folder for a disconnected account
they would prepare to sync and thus display the 'Waiting...' text. With
this change, folders that can't possibly sync don't show text like
this.
When account connectivity changes, all unpaused folders will be
scheduled anyway.
2017-01-24 10:26:03 +01:00
Jenkins for ownCloud
05a254b527
[tx-robot] updated from transifex
2017-01-24 02:18:28 +01:00
Klaas Freitag
e95b73dfac
Avatar: Set a circle mask around the avatar image.
...
The server displays the avatar cut into a circle, and so we do.
2017-01-23 21:36:18 +01:00
Klaas Freitag
c00e3e8c0a
ConnectionValidator: Set a 20 second timeout for Avatar request.
2017-01-23 21:35:12 +01:00
Klaas Freitag
2a12610a46
Update ASCII-Art describing the connection check flow.
...
Added Avatar fetching
2017-01-23 21:34:34 +01:00
Jenkins for ownCloud
d282a8380e
[tx-robot] updated from transifex
2017-01-23 11:11:23 +01:00
Klaas Freitag
d466a05915
SettingsDialog: Display the user avatar as action icon if available.
...
The avatar image is fetched from the server async, thus connect a signal
from the account if the avatar changes.
Server feature https://github.com/owncloud/core/pull/26872 is needed.
2017-01-22 13:58:36 +01:00
Klaas Freitag
e05d6bfcdc
Make the Account store the avatar pixmap.
...
The avatar pixmap is fetched from the server by the Connectionvalidator,
once it has validated the user name, it queries the avatar pixmap.
If the server does not have the avatar route, an empty pixmap is stored.
2017-01-22 13:55:08 +01:00
Klaas Freitag
b49dd02e3d
New network job AvatarJob: GETs the account avatar from server.
2017-01-22 13:52:19 +01:00
Jenkins for ownCloud
83dfbb933b
[tx-robot] updated from transifex
2017-01-22 02:18:27 +01:00
Jenkins for ownCloud
100603fdc0
[tx-robot] updated from transifex
2017-01-21 02:18:28 +01:00
Olivier Goffart
d6fdda8efa
ChunkingNG: add '0' padding on the filename ( #5476 )
...
The server sorts the chunk by name alphabetically. So if we want to keep
the chunk in order, we need to add a few '0' in front of the chunk name
2017-01-20 16:03:50 +01:00
Markus Goetz
faedaa5e09
Update issue_template.md
2017-01-20 16:00:50 +01:00
Olivier Goffart
8a70d22af7
ChunkingNG: Add some tests
...
- Test that we recover correctly if the chunks were removed on the server.
- Test changing the file localy while uploading.
2017-01-20 14:48:53 +01:00
Olivier Goffart
a63d970e5e
ChunkingNG: remove stale chunks when cleaning the uploadInfo table
...
Stale chunks might be there because a file was removed or would just not
be uploaded, for any reason.
We just start the DeleteJob but we don't care if it success or not.
Relates to https://github.com/owncloud/core/issues/26981
One of the test is testing the case where the file is modified on the server
during the upload. So this test the precondition failed error.
The FakeGetReply logic was modified because resizing a 150MB big QByteArray
by increment of 16k just did not scale when downloading a big file.
2017-01-20 14:48:53 +01:00
Olivier Goffart
f6c77fad17
ChunkingNG: delete stale chunks if the file was changed locally
...
Relates to https://github.com/owncloud/core/issues/26981
We do not track the success or error of the DeleteJob because it does not
matter. If it fails, it might be because the chunks were already removed.
If not, the chunks will be stale, but the server must anyway do a few
cleanup from time to time because we do not always remove the chunks
2017-01-20 14:48:53 +01:00
Jenkins for ownCloud
661c7f0558
[tx-robot] updated from transifex
2017-01-20 02:18:34 +01:00
Jenkins for ownCloud
a7efe144fc
[tx-robot] updated from transifex
2017-01-19 02:18:40 +01:00
Jocelyn Turcotte
b68a28de8d
StatusTracker: Emit OK for the last child before parents ( #5467 )
...
The current logic tried to avoid a DB lookup just to fetch whether
the file is shared or not since that info is already in the
SyncFileItem. The implementation would however need to decrease the
sync count for itself (and parents) before emitting the new status,
thus emitting the OK status for parents before that last child that
ended the propagation for that folder.
Change the implementation to achieve what we want: give the
possibility to decSyncCount to use a pre-fetched sharing state while
still doing the emission for all involved files. This ensures that
the leaf file also gets its status emitted before its parents.
Issue #4797
2017-01-18 15:40:52 +01:00
Samuel Alfageme
72a7b7ca42
Reference to build Qt5 with qtwebkit support in the docs #5129 ( #5471 )
...
This addresses the issue only on OS X. It should be stated though, that qtwebkit is not part of the qt5core lib and therefore a requirement for the projectto build in the rest of the OSS
2017-01-18 14:46:47 +01:00
Jocelyn Turcotte
166ef85a51
shell/Windows: Update binaries to build 44
2017-01-18 13:34:02 +01:00
Matthew Setter
1f60c61f87
Update the MacOS automatic update instructions
...
As requested in #5431 , the automatic update instructions for MacOS X
have been simplified; removing the older, incorrect instructions.
2017-01-18 12:55:23 +01:00
Matthew Setter
30ef794fa1
Fix several typos in the client documentation
2017-01-18 12:53:33 +01:00
Jocelyn Turcotte
47fbfbc006
shell/Windows: Avoid memory allocations and copies when querying icons
...
IsMemberOf is called for every file (in the ownCloud directory or not) and
with every instance of OCOverlay (we have 5) when displaying a list of
files in Explorer.
Refactor the code to avoid copying the list of watched directories, as
well as creating a wstring from a PWWSTR for files outside watched
directories.
Also change some calls of begin_with to use isDescendantOf since it
properly handles parent paths not ending with a backslash, which could
lead to SocketAPI queries for sibling folders with a name that starts with
a watched folder name.
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
e131c142ff
shell/Windows: Fix the view not being updated on StateError
...
Since StateError == 0, if this was the status used when the path
isn't in the map already, the view would not be updated since the
new state would be the same as the default-constructed state in the
map. Fix by explicitly inserting in that case, this also avoid aving
to do two lookups in the map when a path already has an entry.
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
1b99ff2e91
shell/Windows: Remove the UPDATE_VIEW message handling
...
The client now tries to only push STATUS messages to connections
unless they previously requested it with a RETRIEVE_FILE_STATUS,
but this means that we now have to make sure that a new connection
will rerequest every icon that the user will see on files from that
point on.
To that end, we now send a SHChangeNotify for every file in the cache
when we lose the connection (or on UNREGISTER_PATH) to make sure that
what's on the screen matches what's in the cache. We also remove the
_oldCache logic that made this more difficult to enforce.
The client has been able to reliably push status updates on macOS
for a few versions now, and we don't need it on Windows either. The
_oldCache mechanism was to avoid sending to many update requests
when receiving an UPDATE_VIEW.
Also fixes #4766
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
3e85d47a57
shell/Windows: Convert tabs to space
...
It was a mix of both and the rest of the code uses spaces.
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
e709d75d56
shell/Windows: Remove unused files
...
The real OCContextMenu.cpp is in the OCContextMenu folder.
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
cb5cfb8cf6
shell/macOS: Make sure the root folder's cache is cleared on disconnect
...
The SocketAPI now only sends status pushes for paths requested by the
shell. We have to make sure that Finder doesn't just show the entry
from its cache after a reconnect.
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
ebd2a15711
shell/macOS: Remove backslashes from the extension display name
...
Tell cmake not to escape shell strings adding backslashes before
spaces by passing the VERBATIM optiton. Also add the quotes to
whole command line arguments to prevent quotes from appearing on the
XCode side, because of the VERBATIM option.
This only affects themed clients since the default theme doesn't
have space in its APPLICATION_NAME.
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
d3a0608bd5
SocketAPI: Only push status for files requested by the shell #5361
...
We currently push the SYNC status for all files that will be propagated,
and then the OK status when those files are propagated.
On top of this, we send those statuses to all clients connected, even
if the socket is kept open by an application that only needed to show
a file open dialog. On macOS we're also using an NSConnection which
means that we have to wait for the RPC call to return from the
extension, which makes bulk status changes possibly heavy.
Reduce the time spent needlessly sending status pushes by limiting
them to files requested through that socket since it connected.
To limit the data to store, only remember the parent directory of
files requested, and store those in a bloom filter.
Note that this adds a requirement to shell extensions: they should
make sure that the status cache only contains entries that have been
requested through the socket API. In other words, the status cache
must be empty when each socket client connects to the socket API.
Otherwise the cached icon type will be shown to the user, and the
SocketAPI won't push new status for that file if it didn't receive
a RETRIEVE_FILE_STATUS.
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
c25b599bbb
SocketApi::slotReadSocket: Small optimizations
...
- Use the looked-up method index also for the invocation
- Do the method name concatenation already on QByteArray since we'll
convert anyway
- Use staticMetaObject instead of metaObject()
2017-01-18 12:15:52 +01:00
Jocelyn Turcotte
a5ff9e58e3
SocketAPI: Remove unecessary null-checks
...
Those methods are private and there is only one call-site, we can
be sure that this parameter won't be null already.
2017-01-18 12:15:52 +01:00
Olivier Goffart
9b96899d75
Sync Engine: Specify what chars are not syncable in the error message #1733 ( #5449 )
2017-01-18 11:45:46 +01:00
Olivier Goffart
b046cca010
Fix more compilation errors with Qt 4
...
Ammand last commit which was a fixup to the change from pull request #5468
for issue #5453
2017-01-18 10:19:51 +01:00
Olivier Goffart
edf0a99a8a
Fix compilation with Qt 4
...
Fixup to the change from pull request #5468 for issue #5453
2017-01-18 09:57:36 +01:00
Jenkins for ownCloud
a4640b202f
[tx-robot] updated from transifex
2017-01-18 02:18:27 +01:00
Markus Goetz
5ef2e88f00
NSIS: Adjust to 5.6.2 image
2017-01-17 17:35:32 +01:00
Christian Kamm
352f168313
Folder: Remove unused variable
2017-01-17 14:53:09 +01:00
Markus Goetz
85d3de1589
Disable RTTI
...
Shrinks owncloud binary by 24 KB and libowncloudsync by 14 KB.
I don't know if it has influence on memory usage or runtime speed though.
Was worth a try.
2017-01-17 14:52:10 +01:00
Markus Goetz
588a88fb63
Updater: Don't create instance for invalid URL
...
Also don't use dynamic_cast
For enterprise/#689
2017-01-17 14:52:10 +01:00
Christian Kamm
cd9e88ad22
PropagatorJob: Remove unneccessary pointer #5453
2017-01-17 14:47:38 +01:00
Christian Kamm
29b39acfbe
PropagatorJob: Access propagator through function #5453
2017-01-17 14:47:38 +01:00
Matthew Setter
7427be0062
Merge pull request #5466 from settermjd/add-directory-limit-to-faq
...
Add Sync Client's Directory Depth Limit To FAQ
2017-01-17 14:33:35 +01:00
Matthew Setter
e7546903cc
Add an FAQ entry about the sync client's sub-directory scan limit
...
As requested in #1067 , this commit adds an entry to the FAQ to highlight
the fact that the sync client will never scan greater than 50
sub-directories.
2017-01-17 11:14:52 +01:00
Matthew Setter
78e3a7e897
Revise the FAQ entry style
...
This approach uses less content, and makes the content more prominent.
2017-01-17 10:36:42 +01:00
Jenkins for ownCloud
1a21b8698e
[tx-robot] updated from transifex
2017-01-17 02:18:34 +01:00
Carlos Damken
280906eab9
Ignoring "System Volume Information"
...
Avoid to upload the "System Volume Information"
2017-01-16 19:11:56 +01:00
Markus Goetz
9d7425b201
DB: Also migrate -shm and -wal to new name #3764 #5045 ( #5459 )
2017-01-16 15:42:11 +01:00
Markus Goetz
7eb43d7f7e
PropagateUploadFileNG: Delete unused map contents to free memory
2017-01-13 19:00:04 +01:00
ckamm
d76e0ec6d8
Reset stuck chunked uploads eventually #5344 ( #5443 )
...
Previously this wasn't happening for errors that were not
NormalErrors because they don't end up in the blacklist.
This revises the resetting logic to be independent of the
error blacklist and make use of UploadInfo::errorCount
instead.
412 errors should reset chunked uploads because they might be
indicative of a checksum error.
Additionally, server bugs might require that additional
errors cause an upload reset. To allow that, a new capability
is added that can be used to advise the client about this.
2017-01-13 14:44:45 +01:00
Olivier Goffart
0249a68420
SelectiveSync: adjust the position of the "Loading" label
...
It should be parented to the treeview to be sure that is shows inside of it.
2017-01-13 10:55:45 +01:00
Christian Kamm
aa6f041c36
wizardSelectiveSyncDefaultNothing applies to folder wizard #4581
...
Previous the Theme option only applied to the account setup wizard.
2017-01-13 10:52:39 +01:00
Christian Kamm
dce3f8c4f6
Selective sync: Adjust widget common to folder/account wizards
2017-01-13 10:52:10 +01:00
Jenkins for ownCloud
4a83f976e1
[tx-robot] updated from transifex
2017-01-13 02:18:27 +01:00
Jenkins for ownCloud
23572aaf77
[tx-robot] updated from transifex
2017-01-12 02:18:33 +01:00
Christian Kamm
48655ff1ec
Doc: Add forceSyncInterval and timeout config file flags
2017-01-11 11:34:36 +01:00
Christian Kamm
ffbf34cb97
Log the auth type being used for accounts
...
There have been hard to track down bugs related to the wrong auth
type being used.
2017-01-11 09:30:59 +01:00
Jenkins for ownCloud
fad690be11
[tx-robot] updated from transifex
2017-01-11 02:18:38 +01:00
Jenkins for ownCloud
355a644020
[tx-robot] updated from transifex
2017-01-10 02:18:34 +01:00
Jenkins for ownCloud
5e6e4e7464
[tx-robot] updated from transifex
2017-01-08 02:18:35 +01:00
Markus Goetz
76fde49282
sqlite: Update bundled version to 3.16.1
...
For OS X and Windows.
2017-01-05 17:27:46 +01:00
Markus Goetz
4ef7d0410d
First iteration ChangeLog for 2.3.0
2017-01-05 16:56:37 +01:00
octotree
a1b4984d14
Symlink Support for Dolphin Plugins ( #5428 )
...
Add Symlink Support to Dolphin Overlay Plugin
2017-01-05 13:24:22 +01:00
Christian Kamm
adbe5ecf55
ownsql: qFatal on prepare errors #5357
2017-01-04 15:15:06 +01:00
Jenkins for ownCloud
ba32571039
[tx-robot] updated from transifex
2017-01-04 02:19:32 +01:00
Christian Kamm
084146756b
Account: Fix displayName() #5413
...
This displayName() seemed to be based on Account::user() which used
to call _credentials->user(). But then we repurposed user() to be
davUser() and this usage wasn't updated to point back to the username
used for the credentials.
2017-01-03 13:54:59 +01:00
ckamm
e1f5a49c21
Don't blacklist 507 Insufficent Storage #5346 ( #5424 )
2017-01-03 13:48:32 +01:00
ckamm
143320341e
Build: Enable Q_ASSERT in release mode ( #5425 )
2017-01-03 13:42:25 +01:00
Christian Kamm
e286bb1b64
Wizard: Don't accidentally pre-fill url field #5412
...
slotUrlEditFinished() is called when the wizard is triggered in
some situations.
2017-01-03 11:53:40 +01:00
Olivier Goffart
d433f0e08e
HTTPCreds: remove all cookies when logging out ( #5383 )
...
Some custom server use persistent cookies with the auth token. So we should
clear all the cookies when disconnecting.
Account::clearCookieJar is only called from the HTTPCredentials. This funciton
is not used for shibboleth.
There is probably no reasons to keep the HTTP cookie anyway.
Issue #5370
2017-01-03 11:39:10 +01:00
Christian Kamm
107149d601
Doc: Improve example #5422
2017-01-03 11:31:51 +01:00
Christian Kamm
fa9b36f829
Wizard: Let the user know if url is invalid #5398
2017-01-03 11:28:56 +01:00
Christian Kamm
6775292d63
Fix compile of tests
2017-01-03 10:52:39 +01:00
Christian Kamm
6835429a28
Sql: Allow prepare fail for PRAGMA quick_check #5357
...
This actually happens in low-disk situations.
2017-01-03 10:43:29 +01:00
Christian Kamm
22135f9f57
Fixup broken authType on load #5408
2017-01-03 10:38:20 +01:00
Jenkins for ownCloud
0fd06a225c
[tx-robot] updated from transifex
2017-01-03 02:19:30 +01:00
Christian Kamm
473dcb0947
Only create a FolderWatcher if the path exists
...
Also retry creating it before each sync.
See #5317
2017-01-02 08:52:26 +01:00
Christian Kamm
e306f4611c
Reschedule a folder regularly with some delay for some errors
...
Like "folder doesn't exist" - such that we will detect when the folder
becomes available and start syncing.
See #5317
2017-01-02 08:52:26 +01:00
Markus Goetz
c6f4f44619
Fix up SSL client certificates #5213 #69 ( #5289 )
...
The re-enables the UI, uses Qt API for importing and
stores the certificate/key in the system keychain.
People who had set up client certs need to re-setup the account. This is ok
since it was an undocumented feature anyway.
2017-01-02 08:34:02 +01:00
Jenkins for ownCloud
0865c63745
[tx-robot] updated from transifex
2017-01-02 02:19:26 +01:00
Jenkins for ownCloud
b81c3a6a67
[tx-robot] updated from transifex
2017-01-01 02:19:32 +01:00
Jenkins for ownCloud
cc56e5639d
[tx-robot] updated from transifex
2016-12-30 02:18:34 +01:00
Jenkins for ownCloud
3ce5b358ae
[tx-robot] updated from transifex
2016-12-25 02:18:27 +01:00
Jenkins for ownCloud
e968284618
[tx-robot] updated from transifex
2016-12-24 02:18:26 +01:00
Jenkins for ownCloud
c7723179d8
[tx-robot] updated from transifex
2016-12-23 02:18:34 +01:00
Jenkins for ownCloud
1872f3f94a
[tx-robot] updated from transifex
2016-12-22 02:18:30 +01:00
Christian Kamm
3b7887ca35
Wizard: Detach saved account from wizard
...
Fixes #5408 #5407 .
The problem was that cleanup of the credentials page set the
credentials of the account back to dummy, thereby overriding
things like shib usernames.
This should be broken since a932eac832 .
2016-12-21 15:31:12 +01:00
Piotr Mrówczyński
d781e63fab
Add capability to disable parallel chunked upload #5364 - technical review ( #5403 )
2016-12-21 15:08:45 +01:00
Kyle Fazzari
d1237cdda3
Correctly handle possible missing GIT_SHA1. ( #5401 )
...
Currently, if get_git_head_revision() doesn't define GIT_SHA1 (which it
doesn't in some cases) it's possible to end up with the following error:
CMake Error at CMakeLists.txt:69 (if):
if given arguments:
"STREQUAL" "GITDIR-NOTFOUND"
Unknown arguments specified
Fix this by making sure both left and right hand arguments to STREQUAL
are always strings, even if GIT_SHA1 is undefined.
Signed-off-by: Kyle Fazzari <kyle@canonical.com >
2016-12-21 14:14:26 +01:00
Christian Kamm
030e3a5d4a
Increase initial bandwidth estimates #4428 #5390
...
To 2 MB/s and 10 files/s.
2016-12-21 08:53:47 +01:00
Jenkins for ownCloud
4fa4a6a5ed
[tx-robot] updated from transifex
2016-12-21 02:18:28 +01:00
Phil Davis
23fb07240b
Fix Mac PATH command
...
Reported in the doc repo owncloud/documentation#1618
This version as suggested by @jturcotte
2016-12-20 20:01:38 +01:00
Christian Kamm
3912dba33a
Move qDeclareMetatype from Folder to SyncEngine
2016-12-20 11:43:39 +01:00
Christian Kamm
d8c479ab1e
Don't wipe db if check fails while disk space is low #5357
...
An experimental fix for the issue, merged because it's low risk and
makes testing easier.
2016-12-20 09:33:59 +01:00
Jenkins for ownCloud
bec67455c1
[tx-robot] updated from transifex
2016-12-20 02:18:27 +01:00
Jenkins for ownCloud
ba6a37a601
[tx-robot] updated from transifex
2016-12-19 02:18:28 +01:00
Jenkins for ownCloud
03f5091e73
[tx-robot] updated from transifex
2016-12-18 02:18:28 +01:00
Jenkins for ownCloud
6b6ff08821
[tx-robot] updated from transifex
2016-12-17 02:18:27 +01:00
Jenkins for ownCloud
35a0ee4893
[tx-robot] updated from transifex
2016-12-16 02:18:29 +01:00
Jenkins for ownCloud
3519391119
[tx-robot] updated from transifex
2016-12-15 02:18:37 +01:00
Olivier Goffart
775a1c9ad8
FolderStatusModel: Fix insert/remove items when there are labels
...
Otherwise it might happen that the model is inconsistant and this can
lead to crash in the worst case.
(For example, if there was a "fetching" label, and we hide it because it
was a 404. In this case, we would not call begin/endRemoveRows, so the
view could still call the model with an index of row 0, that used to be
for the label, but now correspond to the first element of _subs. And
because _subs is empty, this could lead to crashes)
2016-12-14 14:13:47 +01:00
Olivier Goffart
ac95844ebd
Propagator: make sure every network job has a parent
...
This could make sure that the network job gets deleted if the parent job gets
deleted, and would avoid crashes like:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0xffffffff8b008a04
File "qiodevice.cpp", line 1617, in QIODevice::errorString
File "propagatedownload.cpp", line 264, in OCC::GETFileJob::slotReadyRead
File "moc_propagatedownload.cpp", line 85, in OCC::GETFileJob::qt_static_metacall
File "qobject.cpp", line 3716, in QMetaObject::activate
File "moc_qiodevice.cpp", line 154, in QIODevice::readyRead
File "qnetworkreplyhttpimpl.cpp", line 1045, in QNetworkReplyHttpImplPrivate::replyDownloadData
(#5329 )
2016-12-14 14:13:47 +01:00
Olivier Goffart
c5b90d9507
Account::slotHandleSslErrors: add guards in case the reply gets deleted in the dialog event loop
...
Since slotHandleSslErrors will show a dialog with an eventloop, it could be
That the reply gets deleted. Guard against that.
(#5329 )
2016-12-14 14:13:47 +01:00
Christian Kamm
d631f2e070
Sync now: Disable on disconnect, rename while running #2158
2016-12-13 15:28:52 +01:00
Jonathan Kawohl
5bae2ed5ef
fixed merge conflicts
2016-12-13 09:12:50 +01:00
Jenkins for ownCloud
5af2a657ca
[tx-robot] updated from transifex
2016-12-13 02:18:28 +01:00
Jenkins for ownCloud
71231026a0
[tx-robot] updated from transifex
2016-12-12 02:18:28 +01:00
Jenkins for ownCloud
dfca67b63a
[tx-robot] updated from transifex
2016-12-11 02:18:27 +01:00
Jenkins for ownCloud
7dc6a3b89f
[tx-robot] updated from transifex
2016-12-10 02:18:32 +01:00
Jocelyn Turcotte
f985111b62
Fix the log window not showing csync logs
...
The csync log level was only set up on startup, and for log files.
Fix the issue by making Logger::isNoop rely on being explicitly activated
for the log window instead of relying on the presence of a connected
signal, and move the csync log level logic in Logger.
2016-12-09 10:03:46 +01:00
Jocelyn Turcotte
e8d734b1c2
Fix the sync direction being wrong on MSVC
...
The compiler seems to use signed enums and we need to reserve an extra
bit for the sign to avoid the 2 value to overflow and being interpreted
as -2 when read, and thus not being correctly compared to the full enum
value.
2016-12-09 10:03:46 +01:00
Jenkins for ownCloud
a38864fcb4
[tx-robot] updated from transifex
2016-12-09 02:18:28 +01:00
Jenkins for ownCloud
47bab51474
[tx-robot] updated from transifex
2016-12-08 02:18:27 +01:00
Jocelyn Turcotte
d0d5b2b4ee
Don't try to deploy the mng image format plugin on macOS
...
Qt now only build it if the system library is available since libmng
isn't active enough to make its security reliable enough. We don't
use that image format ourselves anyway.
2016-12-07 15:26:23 +01:00
Jocelyn Turcotte
36967122db
Rebase Qt patches on 5.6 #3449
...
Also get rid of the list of different version. We always only support one Qt version
for macOS and Windows, and the list of patches will be based on that supported
version.
2016-12-07 15:26:23 +01:00
Jenkins for ownCloud
3fd67b9fb6
[tx-robot] updated from transifex
2016-12-07 02:18:34 +01:00
ckamm
5bef1aa402
Merge pull request #5045 from owncloud/dbjournal_per_account
...
Allow a folder to be synced to several accounts. This changes the path of the sync journal file!
2016-12-06 10:55:58 +01:00
Jenkins for ownCloud
de9ea19e7e
[tx-robot] updated from transifex
2016-12-06 02:18:34 +01:00
Olivier Goffart
4ac2b764a4
libsync: Clear the upload info after several retries ( #5345 )
...
Issue #5344
2016-12-05 17:21:36 +01:00
Jenkins for ownCloud
0614cda337
[tx-robot] updated from transifex
2016-12-05 02:18:32 +01:00
Jenkins for ownCloud
9e895b9b3e
[tx-robot] updated from transifex
2016-12-04 02:18:28 +01:00
Jenkins for ownCloud
f501211c63
[tx-robot] updated from transifex
2016-12-03 02:18:25 +01:00
Jenkins for ownCloud
77ac1b46dd
[tx-robot] updated from transifex
2016-12-02 02:18:35 +01:00
Jenkins for ownCloud
745c21623c
[tx-robot] updated from transifex
2016-12-01 02:18:28 +01:00
Jenkins for ownCloud
b91c116518
[tx-robot] updated from transifex
2016-11-30 02:18:34 +01:00
Felix Tiede
d090a3330a
Generate .desktop file with OEM name directly.
...
Instead of renaming the .desktop file at install time it is now
generated with its OEM name during configure time.
2016-11-29 18:36:26 +01:00
Felix Tiede
d04e7841e2
Fix file installation source path.
...
By default the file is copied from the source and not the build
directory which will fail with the configure-time built file.
2016-11-29 18:36:26 +01:00
Felix Tiede
d7a4726544
Extend OEM configurability to dolphin desktop file.
...
OEM configurability creates binaries with OEM names which the .desktop
file doesn't take into account and thus dolphin integration does not
work if OEM changes the binary's name(s).
These changes are now integrated into the .desktop file at compile time.
2016-11-29 18:36:26 +01:00
Olivier Goffart
19d2677db1
libsync: use the new webdav url if the server reports it
...
The rules to select the webdav url are now:
- If the server reports that the new chunking algorithm is working,
always use remote.php/dav/files/<username>
This capability can be overriden with an environment variable
- Otherwise, use the dav path provided by the theme, which defaults to
remote.php/webdav
This means that with the newer server, the branding can no longer override
the webdav URL. If there is still an usecase for the branding to do so, we
need to find another way to override it. But it is now more complicated to
configure as might need include the username and need different endpoint
depending on the operations (chunks or not)
Issue #4007
2016-11-29 16:16:20 +01:00
Christian Kamm
a139d1a279
FolderWizard: pass AccountPtr by const&
...
For review of #5045
2016-11-29 10:39:20 +01:00
Christian Kamm
13e624c38f
Fix compilation with Qt < 5.1
...
For review of #5045
2016-11-29 10:39:08 +01:00
Christian Kamm
acb155503b
Ensure the 'Sync paused' state is used after pausing #5290
2016-11-29 09:56:45 +01:00
Jenkins for ownCloud
4cb80b08a2
[tx-robot] updated from transifex
2016-11-29 02:18:28 +01:00
Jenkins for ownCloud
cd85b7c6d7
[tx-robot] updated from transifex
2016-11-28 02:18:33 +01:00
Olivier Goffart
109056e676
owncloudcmd: Don't put the password in the URL
...
As the URL might be print on the logs.
Also don't change the scheme from http to owncloud.
This was required before when we were using neon through csync, but now that
we use QNAM for everything we don't need it. The credentials from the account
are used.
2016-11-26 12:57:44 +01:00
Jenkins for ownCloud
51a1bea5de
[tx-robot] updated from transifex
2016-11-26 02:18:36 +01:00
Christian Kamm
68f99bcc27
AccountSettings: Add a "Force sync now" context menu option
2016-11-25 14:23:56 +01:00
Christian Kamm
276985f6c3
Fix perl tests for sync journal db name
2016-11-25 13:21:34 +01:00
Jenkins for ownCloud
7523db354d
[tx-robot] updated from transifex
2016-11-25 02:18:27 +01:00
Jenkins for ownCloud
4919c9e7b1
[tx-robot] updated from transifex
2016-11-24 02:18:38 +01:00
Christian Kamm
045498c71a
Account: Rename user() to davUser()
...
Avoids potential confusion with credentials->user()
2016-11-23 17:08:17 +01:00
Christian Kamm
49f8143f00
Bugfixes for sync journal name generation and usage
...
* Use 'user' value for journal name generation
* Save journal name in settings
* Make owncloudcmd choose the right db
2016-11-23 16:48:15 +01:00
Christian Kamm
bea7241910
Don't wipe each journal on each start
2016-11-23 16:48:15 +01:00
Christian Kamm
61b4da944c
Split folders configuration locations for backwards compatibility
2016-11-23 16:48:15 +01:00
Christian Kamm
6fe1868693
Always migrate .csync_journal to ._sync_xxx
2016-11-23 16:48:15 +01:00
Christian Kamm
9641c7a1e7
Rename sync journal to ._sync_xxx.db.
...
The added underscore means that older clients will also ignore the
file.
2016-11-23 16:48:15 +01:00
Christian Kamm
3e59a9b316
Merge branch 'master' into dbjournal_per_account
2016-11-23 16:47:56 +01:00
Markus Goetz
679ac0d26a
Wizard: Show if server asks for client certificate #2799 #69 ( #5261 )
...
This also nicely displays the 'Untrusted domain' message of oC.
The link to add a trusted domain (via web browser) is clickable.
2016-11-23 11:43:15 +01:00
Markus Goetz
2e3a3bcf84
Folder: Make folder only accessible by user #5282 ( #5315 )
...
Because on OS X the parent folder might not protect
against access.
2016-11-23 11:05:41 +01:00
Jonathan Kawohl
ad437a49f9
Merge branch 'Kawohl-master'
...
fix conflict
2016-11-23 11:01:52 +01:00
Jonathan Kawohl
6b2282bf0d
Merge branch 'master' of https://github.com/owncloud/client into Kawohl-master
...
fix conflict
2016-11-23 10:59:18 +01:00
Jonathan Kawohl
42aed56a5a
Merge branch 'master' of https://gthub.com/Kawohl/client into Kawohl-master
...
fix conflict
2016-11-23 10:56:29 +01:00
Jonathan Kawohl
ca9ec46253
fixed note
2016-11-23 09:17:33 +01:00
Jonathan Kawohl
a92eec160a
fixed review https://github.com/owncloud/client/pull/5259#pullrequestreview-9743725
2016-11-23 09:10:58 +01:00
Jenkins for ownCloud
cc91c42dfa
[tx-robot] updated from transifex
2016-11-23 02:18:37 +01:00
Olivier Goffart
d22d0e7e30
Propagator: don't use dynamic_cast for QObject
...
qobject_cast is better. (no need to use RTTI when we have QMetaObject
2016-11-22 17:37:41 +01:00
Samuel
4998303c42
Fixing a typo on a message
...
This refers to the message shown when copying the list of unsynced items on the activity tab
2016-11-22 12:14:03 +01:00
Christian Kamm
ceef2f2d46
FolderMan: Never schedule paused folders #5290
...
Previously the last folder in the queue was scheduled, regardless
of whether it was paused or not.
2016-11-22 10:53:15 +01:00
Jenkins for ownCloud
8b18600d7e
[tx-robot] updated from transifex
2016-11-22 02:18:29 +01:00
Jonathan Kawohl
6cc63462b3
adjusted minimum version.
2016-11-21 13:53:59 +01:00
Olivier Goffart
a1dc4069c9
libsync: Don't store the remote URI in the csync or in the SyncEngine
...
We are going to change the webdav path depending on the capabilities.
But the SyncEngine and csync might have been created before the capabilities
are retrieved.
The main raison why we gave the path to the sync engine was to pass it to csync.
But the thing is that csync don't need anymore this url as everything is done by the
discovery classes in libsync that use the network jobs that use the account for the urls.
So csync do not need the remote URI.
shortenFilename in folderstatusmodel.cpp was useless because the string is the
_file of a SyncFileItem which is the relative file name, that name never
starts with owncloud://.
All the csync test creates the folder because csync use to check if the folder
exists. But we don't need to do that anymore
2016-11-21 08:09:11 +01:00
Jenkins for ownCloud
86846af59d
[tx-robot] updated from transifex
2016-11-21 02:18:27 +01:00
Jenkins for ownCloud
5bfa02602d
[tx-robot] updated from transifex
2016-11-20 02:18:28 +01:00
Jenkins for ownCloud
9be23984eb
[tx-robot] updated from transifex
2016-11-19 02:18:35 +01:00
Christian Kamm
eb8de8e3c0
Enable clicking on 'not synced' items #5306
2016-11-18 16:19:36 +01:00
ckamm
ec7333a4bf
Merge pull request #5272 from owncloud/licensefix-pending
...
License: Adjust license of GPLv2 source files to GPLv2+
2016-11-18 15:14:47 +01:00
Christian Kamm
e485c5c008
Always send a progress message at the end of a sync #5290
...
Some listeners detect whether a sync is finished by checking
for isUpdatingEstimates and completedFiles >= totalFiles. But
if a sync didn't transfer any files we never sent signal
with these values. Now we do.
2016-11-18 12:33:44 +01:00
Christian Kamm
6451eb3ade
Tray: Add a 'New account...' action if no account is configured #5307
...
Useful when left-clicking the tray icon isn't working for some reason.
2016-11-18 12:17:05 +01:00
Jenkins for ownCloud
01528427b5
[tx-robot] updated from transifex
2016-11-18 02:18:35 +01:00
Jenkins for ownCloud
cec4d7b9ff
[tx-robot] updated from transifex
2016-11-17 02:18:43 +01:00
Olivier Goffart
efa7821dd2
Revert "Discovery: consider also the "shared by me" as shared"
...
This reverts pull request 5313 (commit
2d6e473a40 and
2f3db04e87 )
The problem is that this loads the server too much.
2016-11-16 17:45:40 +01:00
Markus Goetz
89f55cf9df
Folder: Add comments after discussion about pre-selected selective sync
2016-11-16 14:08:05 +01:00
Markus Goetz
52552a4204
Merge pull request #5102 from owncloud/chunking-ng
...
Chunking ng
2016-11-15 15:56:52 +01:00
Olivier Goffart
2f3db04e87
Rename SyncFileStatus::sharedWithMe to shared
...
Last commit for issue #4788 made the meaning to be simply shared
(with the user or from the user)
2016-11-15 14:32:20 +01:00
Olivier Goffart
2d6e473a40
Discovery: consider also the "shared by me" as shared
...
The "S" in the permission is only for the "Shared with me" files.
It is only used to show the shared status in the overlay icons.
But we also wish to show the shared status for files that are shared
"by" the users. We can find that out using the 'share-types' webdav
property. If set, then we are sharing the object.
We fake a 'S' in the permission as for our purpose, they mean the same.
Issue #4788
2016-11-15 14:32:20 +01:00
Olivier Goffart
92027e8692
SyncEngineTestUtils: Do don't allocate a buffer for the whole file
...
As the file can be some hunreds of megabytes, allocating such big arrays may
cause problems.
Also make the timeout a bit bigger so the test can rununder valgrind.
2016-11-15 11:39:40 +01:00
Olivier Goffart
2723cd225e
FolderStatusDelegate: Fix compiler warning.
...
QStyleOptionProgressBarV2 is deprecated in Qt5.
2016-11-15 10:16:41 +01:00
Jenkins for ownCloud
acd151102c
[tx-robot] updated from transifex
2016-11-15 02:18:36 +01:00
Olivier Goffart
77e790d2ee
Merge pull request #5304 from owncloud/Kawohl-linktocentral
...
documnetation.
2016-11-14 12:43:10 +01:00
Olivier Goffart
899c675f0a
Merge pull request #5267 from payload/fix_4608
...
nautilus integration: "share" extension for syncing folders
2016-11-14 12:35:18 +01:00
Olivier Goffart
fb76487e76
Merge pull request #5266 from rmekarni/patch-1
...
Fix find_library FindCMocka.cmake
2016-11-14 12:20:24 +01:00
Tobias Haeussler
0c0a3ca0a5
Add manifest file on Windows to make the application UAC aware.
2016-11-14 12:16:58 +01:00
Olivier Goffart
5377d1e283
Chunking-NG: code cleanup after review
2016-11-14 10:42:07 +01:00
Jenkins for ownCloud
676ad530e7
[tx-robot] updated from transifex
2016-11-14 02:18:26 +01:00
Jenkins for ownCloud
fbcb01ed27
[tx-robot] updated from transifex
2016-11-13 02:18:26 +01:00
Jenkins for ownCloud
c2b006e857
[tx-robot] updated from transifex
2016-11-12 02:18:26 +01:00
Jenkins for ownCloud
0e7ccea588
[tx-robot] updated from transifex
2016-11-11 02:18:27 +01:00
Jenkins for ownCloud
c16deb3e44
[tx-robot] updated from transifex
2016-11-10 02:18:27 +01:00
Jenkins for ownCloud
019544fcfd
[tx-robot] updated from transifex
2016-11-10 01:15:14 +01:00
Jonathan Kawohl
5f0167b19e
removed openssl_version variable,
2016-11-09 10:25:32 +01:00
Jonathan Kawohl
29d3c33eb2
added missing quotes
2016-11-09 08:59:14 +01:00
Jonathan Kawohl
469eca1f5f
added link to central
2016-11-09 08:59:14 +01:00
Jonathan Kawohl
0864d67a9a
fixing wrong files Revert "fix for https://github.com/owncloud/client/issues/1251 "
...
This reverts commit 4f1feab845 .
2016-11-09 08:59:14 +01:00
Jonathan Kawohl
e9503664f5
fix for https://github.com/owncloud/client/issues/1251
2016-11-09 08:59:14 +01:00
Jonathan Kawohl
58cee61624
added info on qtkeychain
...
added installation info on qtkeychain
2016-11-09 08:59:14 +01:00
Jonathan Kawohl
d23d07f99b
Correcting for PR comments
2016-11-09 08:59:14 +01:00
Jonathan Kawohl
d70db810dd
updated link for documentation and added more info to osx build
2016-11-09 08:59:14 +01:00
Jenkins for ownCloud
842129f99d
[tx-robot] updated from transifex
2016-11-09 02:18:28 +01:00
ckamm
36d61ef3a9
Doc: Add sync algorithm overview and comments ( #5277 )
...
* Doc: Add sync algorithm overview and comments
2016-11-08 16:10:55 +01:00
Christian Kamm
f1f27221a7
Conflicts: Use the local mtime for the conflict file name #5273
...
Otherwise local conflict files may be overridden in a restore
situation. See ticket for details.
2016-11-08 14:47:51 +01:00
Christian Kamm
eb012d26ee
FolderStatusModel: Minor cleanups.
2016-11-08 14:01:07 +01:00
Christian Kamm
9ee8187083
Sort folder list alphabetically #5299
2016-11-08 14:01:07 +01:00
Christian Kamm
b0c45cfc89
Test: Don't fail when DST change is near #5284
2016-11-08 11:13:19 +01:00
Christian Kamm
90cea69692
Network: Add "Accept" header for some firewalls #5298
2016-11-08 11:01:49 +01:00
Jenkins for ownCloud
155bdfbffe
[tx-robot] updated from transifex
2016-11-08 02:18:26 +01:00
Christian Kamm
0e2782d369
Terminate sync when pausing from context menu #5290
2016-11-07 12:50:06 +01:00
Jenkins for ownCloud
6b3d0e69aa
[tx-robot] updated from transifex
2016-11-07 02:18:26 +01:00
Jenkins for ownCloud
f30aee6d4e
[tx-robot] updated from transifex
2016-11-06 02:18:34 +01:00
Jenkins for ownCloud
82f86eb019
[tx-robot] updated from transifex
2016-11-05 02:18:29 +01:00
Olivier Goffart
9573c5e64d
Merge remote-tracking branch '2.2' into master
...
For the reanslation. Now transifex should be updated to update master.
This should normally be the last merge from 2.2
Conflicts:
mirall.desktop.in
translations/client_sl.ts
translations/client_th.ts
2016-11-04 16:51:58 +01:00
Olivier Goffart
15f2b911d9
ChunkingNG: remove stale files when resuming
2016-11-04 16:43:01 +01:00
Jenkins for ownCloud
f5aff70398
[tx-robot] updated from transifex
2016-11-04 16:41:40 +01:00
Olivier Goffart
e3a4c3989a
SyncEngine: disable heuristics for backup restoration for server >= 9.1
...
The ownCloud 9.1 server has a data-fingerprint property that the admin must
change in case of backup restoration. When this change, the client understands
that a backup was restored, and will generate conflict files and re-upload
new files.
The heuristics based system checks that there is at least two files wose mtime
is put back in the past and no files that goes forward. In that case we ask the
user before creating the conflicts.
This commit disable the heuristics for newer server that have the data-fingerpint.
And change the heuristics to two hours because we want to avoid false positive due
to some clock error, and that 2 hours of lost due to backup restoration is probably
not so bad.
We only ask the user in the heuristics based aproach so in practice this mean that
the "backup-detected" dialog will no longer appear with newer server.
Relates issues #5260 , #5109
2016-11-04 16:30:58 +01:00
Jenkins for ownCloud
3e954bc17f
[tx-robot] updated from transifex
2016-11-04 02:18:27 +01:00
Jenkins for ownCloud
2527569bb8
[tx-robot] updated from transifex
2016-11-03 02:18:27 +01:00
Jenkins for ownCloud
1e197531cb
[tx-robot] updated from transifex
2016-11-02 02:18:28 +01:00
Jenkins for ownCloud
8b876576eb
[tx-robot] updated from transifex
2016-11-01 02:18:29 +01:00
Piotr Mrówczyński
a2287c9657
Merge pull request #5274 from owncloud/reduce_loops_dirjob
...
Cache the value of last unfinished job in the PropagateDerectory scheduleNextJob
2016-10-31 22:07:50 +01:00
Piotr M
34c59ba9ed
reduce number of loops
2016-10-31 19:45:24 +01:00
Olivier Goffart
c8014a0afd
ChunkingNG: Add Test
2016-10-31 15:16:53 +01:00
Olivier Goffart
456d82715e
Fix compile after merge
2016-10-31 11:29:33 +01:00
Olivier Goffart
8ca3eb7883
Merge remote-tracking branch 'origin/master' into chunking-ng
2016-10-31 11:09:12 +01:00
Jenkins for ownCloud
c110745330
[tx-robot] updated from transifex
2016-10-31 02:18:27 +01:00
Jenkins for ownCloud
19521863a0
[tx-robot] updated from transifex
2016-10-30 02:18:24 +01:00
Jenkins for ownCloud
c256896165
[tx-robot] updated from transifex
2016-10-30 02:18:26 +02:00
Jenkins for ownCloud
ef922f60fa
[tx-robot] updated from transifex
2016-10-29 02:18:28 +02:00
Jenkins for ownCloud
733ea90e6b
[tx-robot] updated from transifex
2016-10-28 02:18:28 +02:00
Jenkins for ownCloud
a4e1fa9dcf
[tx-robot] updated from transifex
2016-10-27 02:18:30 +02:00
Jenkins for ownCloud
1a1684ca2a
[tx-robot] updated from transifex
2016-10-26 02:18:34 +02:00
Gilbert Röhrbein
9c8572e335
nautilus integration: refactored _connectToSocketServer, removed superfluous check
2016-10-25 21:45:47 +02:00
Gilbert Röhrbein
e675a34fbb
nautilus integration: use os.path.join, os.sep and tempfile.gettempdir instead of string concats
2016-10-25 20:15:17 +02:00
Christian Kamm
5f47c01346
Account: Rearrange for readability
2016-10-25 13:20:23 +02:00
Christian Kamm
10644d3568
Move concatUrl and settingsWithGroup to Utility
...
There was little reason to keep them cluttering Account.
2016-10-25 12:05:28 +02:00
Christian Kamm
9ee3144358
Account: Remove wasMigrated/setMigrated
...
It was unused since early in the multi-account work:
a932eac832
2016-10-25 11:43:06 +02:00
Christian Kamm
cf48ea2e00
Remove unused functions
...
Account::changed and AbstractCredentials::changed have not been needed
in a long while.
2016-10-25 11:33:38 +02:00
Christian Kamm
db24f60ae3
License: Adjust license of GPLv2 source files to GPLv2+
...
See #5180
2016-10-25 11:06:54 +02:00
Christian Kamm
6026148692
FolderMan: Clean up API
...
Many public slots didn't need to be public or slots.
2016-10-25 09:44:34 +02:00
Christian Kamm
a2222228c9
FolderMan: Document and clean up folder scheduling
2016-10-25 09:44:34 +02:00
Jenkins for ownCloud
9e2d3f5bc7
[tx-robot] updated from transifex
2016-10-25 02:18:32 +02:00
Marcus Hoffmann
fe984b61d7
Add script to create a caja plugin. ( #5262 )
...
Caja is a fork of nautilus maintained by the Mate project.
This adds a script to create a caja plugin from the nautilus plugin.
It replaces all occurences of nautilus with caja (case sensitive).
This is done in the same way the nemo plugin is generated from the nautilus one.
2016-10-24 15:36:23 +02:00
Jonathan Kawohl
ffac3f6213
fixing wrong files Revert "fix for https://github.com/owncloud/client/issues/1251 "
...
This reverts commit 4f1feab845 .
2016-10-24 15:16:06 +02:00
Jonathan Kawohl
4f1feab845
fix for https://github.com/owncloud/client/issues/1251
2016-10-24 15:09:25 +02:00
Jonathan Kawohl
f738cfd7fe
added info on qtkeychain
...
added installation info on qtkeychain
2016-10-24 09:00:07 +02:00
Jenkins for ownCloud
e6be670e49
[tx-robot] updated from transifex
2016-10-24 02:18:28 +02:00
Jenkins for ownCloud
46ce2f4722
[tx-robot] updated from transifex
2016-10-23 02:18:28 +02:00
Gilbert Röhrbein
166a0f60ca
nautilus integration: "share" extension for syncing folders
...
Issue #4608
* folder state is either OK or SYNC usually
* this extension does not know about if a folder is shareable
* a OK folder is shareable
* a SYNC folder could be uploaded or not uploaded
* this commit looks into file entries below this folder
* if one exists with state OK or SYNC
this folder must have been uploaded
* better would be if the server (gui) tells us
if the folder is uploaded
2016-10-22 23:26:44 +02:00
Romain Mekarni
a9019ccbad
Fix find_library FindCMocka.cmake
2016-10-22 14:52:27 +02:00
Jenkins for ownCloud
0a4806af44
[tx-robot] updated from transifex
2016-10-22 02:18:28 +02:00
Olivier Goffart
e33b89c222
Chunking-NG: Enable if the server supports it
2016-10-21 16:42:27 +02:00
Olivier Goffart
6b899be895
Merge remote-tracking branch 'origin/2.2' into master
2016-10-21 10:27:33 +02:00
Jenkins for ownCloud
641785298f
[tx-robot] updated from transifex
2016-10-21 02:18:31 +02:00
Jonathan Kawohl
092c935422
Correcting for PR comments
2016-10-20 13:05:56 +02:00
Olivier Goffart
273590fdfc
ChunkingNG: Use the 'If' header
...
As discussed in https://github.com/owncloud/core/pull/26368
2016-10-20 11:16:06 +02:00
Olivier Goffart
0960058842
Merge remote-tracking branch 'origin/master' into chunking-ng
2016-10-20 09:25:03 +02:00
Jenkins for ownCloud
1f78ea0fd1
[tx-robot] updated from transifex
2016-10-20 02:18:28 +02:00
Jonathan Kawohl
72d8175032
updated link for documentation and added more info to osx build
2016-10-19 11:12:11 +02:00
Jenkins for ownCloud
2fd9767892
[tx-robot] updated from transifex
2016-10-19 02:18:33 +02:00
Christian Kamm
69a1e46d0c
Progress: Reset lastCompletedItem #5256
...
Otherwise progress listeners think it's still the last-completed
item when the next sync starts. This lead to spurious entries in
the "Recent Changes" list.
2016-10-18 12:29:52 +02:00
Christian Kamm
e020a5327e
Force a remote discovery when upgrading to this version #5242
...
A remote discovery will fix up any lingering problems caused by #5190 .
2016-10-18 11:21:01 +02:00
Christian Kamm
1b04489887
Remove stale commented code
...
These functions don't even exist anymore.
2016-10-18 11:21:01 +02:00
Olivier Goffart
36a19703db
SyncEngine: Permission error in subfolder of a folder that cannnot be added is a SoftError
...
Issue #5059
2016-10-17 12:22:04 +02:00
Jenkins for ownCloud
f3a345a23b
[tx-robot] updated from transifex
2016-10-17 02:18:29 +02:00
Jenkins for ownCloud
826459eae7
[tx-robot] updated from transifex
2016-10-17 01:15:13 +02:00
Jenkins for ownCloud
c2c36b85cb
[tx-robot] updated from transifex
2016-10-16 02:18:28 +02:00
Jenkins for ownCloud
7b2f8ae6f7
[tx-robot] updated from transifex
2016-10-15 02:18:29 +02:00
Markus Goetz
d600fdc89b
OS X: Use monochrome tray icon by default ( #5229 )
2016-10-14 14:26:31 +02:00
Markus Goetz
8c5ea8dc90
Propagator: Also upload more in parallel ( #5230 )
...
Fix for https://github.com/owncloud/client/issues/4986#issuecomment-227071801
This is before we have bundling at some point.
2016-10-14 14:23:55 +02:00
Jenkins for ownCloud
0eddcd6384
[tx-robot] updated from transifex
2016-10-14 02:18:29 +02:00
Klaas Freitag
9f2ae5dd17
Add a note that the source repositories need to be enabled. ( #5239 )
...
* Add a note that the source repositories need to be enabled.
* Fix typo, is => are.
2016-10-13 16:22:54 +02:00
Olivier Goffart
766d9ae1ac
QProgressIndicator: update copy from upstream
...
Update from commit 05ce8a23cdc12e825532dc6de06c267fb8d48b4f from
https://github.com/dragotin/QProgressIndicator
Which itself is forked from commit e5ba0fd09bfd43b067ee3646d70b294c7efcb558 from
upstream, with additional license header.
It was relicensed to MIT according to
14bb9d10e2
Relates to issues #5180 and #5184
2016-10-13 12:05:59 +02:00
Jenkins for ownCloud
21128ed762
[tx-robot] updated from transifex
2016-10-13 02:18:28 +02:00
Markus Goetz
5000d40619
Fixup previous commit
...
Thanks @ogoffart for spotting.
2016-10-12 19:10:56 +02:00
Klaas Freitag
16e28567a6
Folderman: Some comments for the checkPathValidityForNewFolder method.
2016-10-12 18:16:53 +02:00
Klaas Freitag
3bef42db6b
folderman: checkPathValidityForNewFolder - correct file path comparison
...
It now checks based on the correct case sensitivity and also using the new
method for filename comparison.
2016-10-12 14:50:10 +02:00
Klaas Freitag
27d23edacc
Utility: Add a function to check if two filenames are equal plus test.
...
It calls canonical path always and works with the correct case preserving
depending on the platform.
2016-10-12 14:48:00 +02:00
Jenkins for ownCloud
0d321050a6
[tx-robot] updated from transifex
2016-10-12 02:18:34 +02:00
Markus Goetz
fc7aaf792b
Auto Start: Only set on first account setup, not all later ones
2016-10-11 20:28:14 +02:00
Markus Goetz
f6355e15a3
sqlite: Update bundled version to 3.14.2
...
For OS X and Windows.
2016-10-11 20:06:43 +02:00
Olivier Goffart
d80d5a8ee4
SyncEngine: Fix renaming a folder should keep the selective sync state
...
Issue #5224
Two problems:
- In the discovery phase, we need to check the selective sync entries of
the source path in case of renames.
- When the rename is done, we need to actually update the black list in the
database.
2016-10-11 14:38:25 +02:00
Olivier Goffart
e0a36ab313
TestFolderMan: don't pollute user's settings
2016-10-11 14:27:14 +02:00
Olivier Goffart
9d3e78ed54
AccountManager: do not load invalid account
...
Some tests (such as FolderManTest) can polute the config file with invalid
accounts.
(That's because most of the code, (even in libsync) always instentiate a ConfigFile)
2016-10-11 14:27:14 +02:00
Olivier Goffart
b6079bfe4f
Remove usused variable
2016-10-11 12:12:28 +02:00
Olivier Goffart
f75106fd8e
SyncJournalDB: check the return value of the prepare statements in checkConnect
...
Relates to #5199
2016-10-11 11:35:26 +02:00
Olivier Goffart
57fe7b800f
Theme: Fix compiler warning
...
Relates #5227
2016-10-11 10:31:47 +02:00
Jenkins for ownCloud
089ecf8222
[tx-robot] updated from transifex
2016-10-11 02:18:32 +02:00
Klaas Freitag
e1a48e3c33
Move the journal file name generation to the syncjournaldb class.
...
As requested by Olivier.
2016-10-10 16:59:17 +02:00
Olivier Goffart
c2fa9b5bbf
AccoutWizard: Change the set policy of a radio button
...
In an attempt to make sure the button next to it don't get too small.
Issue #5209
2016-10-10 13:27:28 +02:00
Olivier Goffart
86522cbbf0
OwnSQL: avoid crashing in SqlQuery::reset_and_clear_bindings
...
The crash reporter shows a lot of crashes in sqlite3_clear_bindings
which seems to indicate that _stmt is null. We should guard against
a null value in order to avoid crashing.
This should only happen if the prepare call fails. We don't usually
check the return value of the prepare call, but if _stmt is null, the
exec call should return false, not true. We check the result of the
exec call, so this should then abort the sync with an error, rather
than crashing.
2016-10-10 13:27:12 +02:00
Jenkins for ownCloud
d54f8adac5
[tx-robot] updated from transifex
2016-10-10 02:18:29 +02:00
Jenkins for ownCloud
d35ecafa0b
[tx-robot] updated from transifex
2016-10-09 02:18:27 +02:00
Jenkins for ownCloud
2ca807280a
[tx-robot] updated from transifex
2016-10-08 02:18:33 +02:00
Klaas Freitag
5d13f9290f
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 16:24:09 +02:00
Klaas Freitag
c84140d293
checkPathValidityForNewFolder: Catch sync folders underneath sym links.
...
plus some whitespace changes.
2016-10-07 16:23:13 +02:00
Christian Kamm
91b6b88883
Tray: Fix crash on startup for non-OSX oses
2016-10-07 13:32:42 +02:00
Christian Kamm
f36d4562a1
Doc: Remove mention of "F5 to reset database" #5130
2016-10-07 13:22:43 +02:00
Tommy Sparber
67ecca492b
Improve macOS SysTray/StatusBar monochrome icon ( #5227 )
...
- Use a white icon if the context menu is visible.
- Enable `QIcon::setIsMask` if compiled on Qt >= 5.6 to allow automatic
macOS color handling.
- No changes if the colored icons are used.
2016-10-06 17:18:51 +02:00
Markus Goetz
84c925dc58
503: Also parse other server error message ( #5228 )
...
From https://github.com/owncloud/core/pull/26145
2016-10-06 14:45:04 +02:00
Jenkins for ownCloud
e1a01c75d9
[tx-robot] updated from transifex
2016-10-06 02:18:30 +02:00
Jenkins for ownCloud
6a4adbc87e
[tx-robot] updated from transifex
2016-10-05 02:18:30 +02:00
Jenkins for ownCloud
89974ab1d4
[tx-robot] updated from transifex
2016-10-04 02:18:30 +02:00
Jenkins for ownCloud
8d0c313486
[tx-robot] updated from transifex
2016-10-03 02:18:39 +02:00
Jenkins for ownCloud
aab0cdf12a
[tx-robot] updated from transifex
2016-10-02 02:18:29 +02:00
Jenkins for ownCloud
a89520043e
[tx-robot] updated from transifex
2016-10-01 02:18:30 +02:00
Jenkins for ownCloud
6382a142cd
[tx-robot] updated from transifex
2016-10-01 01:15:17 +02:00
Klaas Freitag
838c072ccc
Folder Setup: Allow to set up more sync connects to the same folder.
...
One local folder can now be configured as sync target for multiple
accounts as long as their url and user differ.
Also this patch accepts that the sync folder is behind a symlink.
Also this patch fixes a bug that before the user input was taken
canonically which was not working for the symlink handling.
2016-09-30 14:08:00 +02:00
Jenkins for ownCloud
02c403e360
[tx-robot] updated from transifex
2016-09-30 02:18:34 +02:00
Klaas Freitag
ed6a708460
SyncJournalDb: Migrate the old csync journal to the new name.
...
Migration strategy to the new filename.
2016-09-29 16:41:11 +02:00
Klaas Freitag
0c9dcdafc2
csync: Only free the statedb filename on destroy.
...
The filename must not be wiped in csync_commit as that is
happening after every sync. It is only set once in the
constructor of the SyncEngine in csync_init().
2016-09-29 16:36:14 +02:00
Christian Kamm
5f2b1999f6
Package: Fix nautilus plugin name collision when branded
...
As suggested by @olifre in #5183
2016-09-28 13:10:48 +02:00
Christian Kamm
bd2bcad3ba
ShareDialog: Remove context help button
...
Ticket #5203
2016-09-28 13:00:52 +02:00
Christian Kamm
598a7cec5d
Merge remote-tracking branch 'origin/2.2'
2016-09-28 12:07:45 +02:00
Jenkins for ownCloud
46d934bd95
[tx-robot] updated from transifex
2016-09-28 02:18:31 +02:00
Markus Goetz
e8c8943a30
VERSION.cmake: We're at 2.2.5
2016-09-27 18:21:55 +02:00
Markus Goetz
95c479aa07
Wizard: Do the system proxy lookup in a thread ( #5160 )
...
This is analogous to the code in ConnectionValidator.
2016-09-26 15:45:30 +02:00
ckamm
035442b6da
Improve the "new big folder" UI #5202 ( #5204 )
...
Instead of using the regular selective-sync UI (where it's unclear what
the "Cancel" button would even mean in this context), provide a
different set of buttons that allow the user to quickly synchronize
all pending big folders, none of them, or perform manual changes
as usual.
2016-09-23 13:47:57 +02:00
ckamm
98efb07535
Tray: Workaround collection ( #5179 )
...
Tray: Workaround collection
* QDBus workaround for Qt 5.5.0 only, there were reports of the tray
working fine with 5.5.1. #5164
* OWNCLOUD_FORCE_QDBUS_TRAY_WORKAROUND to force the workaround on an off
* OWNCLOUD_TRAY_UPDATE_WHILE_VISIBLE to enable or disable updating of
the menu while it's visible - disable by default due to problems on OSX and Xubuntu.
* Track the visibility of the tray menu with aboutToShow/aboutToHide
only on OSX - the aboutToHide signal doesn't trigger reliably on linux
* Refactor such that setupContextMenu is different from updateContextMenu
* Don't use on-demand updating of the tray menu when the qdbus workaround
is active, instead to occasional (30s) updates of the tray menu.
2016-09-23 10:44:54 +02:00
Olivier Goffart
bc04f79959
Missing Inc -> GmbH ( #5181 )
2016-09-22 15:32:12 +02:00
Christian Kamm
e10c97573f
Warning if mailto url fails #5142
2016-09-22 14:16:58 +02:00
Christian Kamm
383479fbfd
Fix Windows build with WITH_UNIT_TESTING
2016-09-22 13:55:48 +02:00
Olivier Goffart
fca5f1b210
owncloudcmd: fix --silent
...
We ignored csync log, but we also need to silent Qt debug output.
We need to ignore it at the very begining because there might be
qDebug also in account creation.
Issue #5196
2016-09-22 10:32:27 +02:00
Christian Kamm
0cea3d85f5
Add log messages for LockWatcher use #5190
2016-09-22 09:57:42 +02:00
Olivier Goffart
85b8ab178e
SyncEngine: Fix renaming of folder when file are changed ( #5195 )
...
Two bugs:
- The change filed are not considered as move, they are re-downloaded
but the old file was not removed from the database. The change in
owncloudpropagator.cpp takes care of removing the old entries.
- Next sync would then remove the file in the server in the old folder
This was not a problem until we start reusing the sync engine, and
that the _renamedFolders map is not cleared. We were before deleting
a non-existing file. But now we delete the actual file.
Also improve the tests to be able to do move on the server.
This include support for file id.
Issue #5192
2016-09-22 09:02:47 +02:00
Jenkins for ownCloud
ea9d17b41d
[tx-robot] updated from transifex
2016-09-22 01:15:16 +02:00
Piotr Mrówczyński
b7eb37dc03
Merge pull request #5170 from owncloud/add_capabilities_owncloudcmd
...
add server capabilities to owncloudcmd
2016-09-21 22:28:41 +02:00
Olivier Goffart
98bfa8d5de
Propagator: properly send the success flag ( #5189 )
...
In case of the root directory, it may happen that the _item
is empty and the _item->_status is NoStatus. But we still need to report
the proper success or error of the whole propagation. We should really
use _hasError for that. However, _hasError is also defined to NoStatus
if there was no error, so in that case we need to set Success.
This fixes the problem in which the data-fingerprint is not saved on the
database because the SyncEngine think that the sync failed. (Issue #5185 )
2016-09-21 16:35:42 +02:00
Olivier Goffart
ff701bd473
ConnectionValidator: properly handle error in status.php ( #5188 )
...
We wwer enot connecting to the right signal from the check server
job, and therefore we were not catching the condition in which the
json was invalid. We would then never terminate the ConnectionValidator job.
Note that instanceNotFound is also emited if there is a network error.
The log looked like this:
10:25:51.247 OCC::CheckServerJob::finished: status.php from server is not valid JSON!
10:25:51.248 OCC::CheckServerJob::finished: status.php returns: QMap() QNetworkReply::NetworkError(NoError) Reply: QNetworkReplyHttpImpl(0x2b6a790)
10:25:51.248 OCC::CheckServerJob::finished: No proper answer on QUrl("http://localhost/~owncloud/status.php ")
10:26:23.235 OCC::AccountState::checkConnectivity: ConnectionValidator already running, ignoring "owncloud@localhost"
10:26:55.235 OCC::AccountState::checkConnectivity: ConnectionValidator already running, ignoring "owncloud@localhost"
[...]
2016-09-20 11:55:43 +02:00
Jocelyn Turcotte
31aaf956f5
Merge pull request #5182 from jturcotte/msvcBuild
...
Fix the MSVC build
2016-09-20 10:39:14 +02:00
Jocelyn Turcotte
a221ac1e4d
Fix unit testing build warning on Linux
...
The compiler complained about the PathComponent reference on the lambdas comes from the anonymous namespace.
2016-09-16 17:55:28 +02:00
Jocelyn Turcotte
2b274e9460
Fix the MSVC build
...
- Replace functions that are provided by MinGW with a Win32-based
implementation
- Explicitly export needed symbols from ocsync.dll
- Rename share.h to sharemanager.h since the name clashes with one
of the Windows headers and get included from there
- Remove the timestamp from the fallback csync stderr logging, it's
not used since we always provide a log callback
2016-09-16 17:43:39 +02:00
Olivier Goffart
da26e59770
Chunking-NG: add some headers when uploading chunks
...
These are not understood by owncloud yet, but were requested for CernBox
OC-Total-Length in the MKCOL: The full lenght of the file
OC-Chunk-Offset in the PUT: The offset within the file in which this chunk belongs
OC-Checksum in the MOVE: The transission checksum
2016-09-16 16:36:46 +02:00
Olivier Goffart
3c24d5a148
Chunking-NG: The MOVE will return the code 204 if the file was already there
2016-09-16 16:20:40 +02:00
Olivier Goffart
c222793525
Chunking-NG: use OC-If-Destination-Match instread of If-Match
...
For the MOVE command, because If-Match in Webdav relates to the source, not
the destination
2016-09-16 16:15:09 +02:00
Olivier Goffart
28018e8590
Chunking-NG: Fix destination URL
2016-09-16 16:14:53 +02:00
Olivier Goffart
4c79ce2ae6
ConnectionValidator: fetch the account name.
...
This is needed for the new webdav path used by the new chunking.
The user might not be the same as the one used to connect
2016-09-16 15:49:43 +02:00
Markus Goetz
aa5d3055be
Folder/Watcher: Fix up #5174 #5153 ( #5186 )
...
It was surprising to have a broken symlink return empty for
canonical path.
2016-09-15 14:56:37 +02:00
Markus Goetz
b7809ded23
OS X: Try to fix tray menu not updating correctly #5158 ( #5177 )
...
I even had this issue long before 2.3 that submenus suddenly disappeared.
Now we refrain from updating while visible.
2016-09-13 14:34:22 +02:00
ckamm
dfb121236c
Excludes: Consider files in hidden folders excluded #5163 ( #5173 )
...
Previously, we only checked the hiddenness of the target file and
ignored the hiddenness of the containing folders. This lead to
undesired behavior when people synced their home folders and there
was a folder watcher notification for a non-hidden file in one of
the hidden folders.
I'm not fully sure why, but sometimes notifications for .foo/bar were
already ignored, but notifications for .foo/bar/car were not. This may
be because of how we set up the FolderWatchers on Linux.
The new behavior is to check all path components for hiddenness, up
until the base path (but excluding the base path, so using a hidden
folder as a sync folder will work).
2016-09-13 14:14:27 +02:00
ckamm
f286493c90
Merge pull request #5174 from owncloud/fix5116_2
...
Better fix for #5116
2016-09-13 10:16:05 +02:00
Olivier Goffart
c2cb729fee
Folder: Cannonicalize the path
...
This is important because we compare the paths from the file system watcher if it
starts with this path.
Same in the SocketAPI where we need to use cannonical paths in the REGISTER_PATH command,
as the plugin themself will do this comparison.
Issue #5116
2016-09-12 16:56:59 +02:00
Olivier Goffart
904cd46f75
Revert "FolderWatcher: Act on relative paths #5116 ( #5153 )"
...
This is not sufficient as it is not working for the Socket API.
Next commit will fix it in another layer.
Also, not ignoring paths that are not inside the folder is wrong
as it might still happen if the name has a different casing
This reverts commit d5a481f132 .
2016-09-12 16:05:55 +02:00
Piotr M
7fd00b2cd5
add server capabilities to owncloudcmd
2016-09-12 14:43:40 +02:00
Klaas Freitag
2d110540ee
Dolphin Plugin: Use the Application name for the socket path ( #5172 )
...
do not hardcode.
This should fix #5165
2016-09-12 14:12:33 +02:00
Markus Goetz
d5a481f132
FolderWatcher: Act on relative paths #5116 ( #5153 )
2016-09-12 14:03:11 +02:00
Olivier Goffart
1d09f6b60f
Allow to disable Shiboleth to build without QtWebkit ( #5166 )
2016-09-11 16:14:08 +02:00
Olivier Goffart
98268d102f
ExcludeFiles: Fix when the folder casing is not the same in the settings and in the FS
...
If the folder has different case in the settings and in the FS, we should
not ignore all the files. This is important for the files system watcher.
2016-09-11 12:12:10 +02:00
Olivier Goffart
9e895a6ecc
FolderStatusModel: Fix beginInsertRow/endInsertRow
...
We need to do the change between the begin and the end call so the selection
don't get broken
2016-09-11 12:12:10 +02:00
Olivier Goffart
7c75a39bc1
Chunking-NG: Some fixup after feedback from the pull request #5102
2016-09-10 12:30:14 +02:00
Markus Goetz
524220d090
Selective Sync: Fix request loop and show error in view ( #5154 )
...
I got into a situation where the model would endlessly request the directory
contents from the server because we did not notice yet that the server
is actually in maintenance mode while we were expanding the tree view when
changing the tab to the account or when just expanding it by clicking.
2016-09-06 11:11:03 +02:00
Christian Kamm
af9c4d0e2f
Recall: Copy instead of move recalled file #5150
...
That was an unintentional change in
2662203fb7
Also expand the test case to cover this.
2016-09-06 10:42:59 +02:00
Klaas Freitag
c97d8aa8fd
Show the rename target in the client log file. ( #5149 )
2016-09-05 13:26:49 +02:00
Klaas Freitag
f0dc3b2deb
FolderWatcher: Also ignore the new sync journal file name format.
2016-09-02 16:19:10 +02:00
Klaas Freitag
84ede3f01f
Make sync journal name generating a method of SyncJournal.
...
Before it was in Folder, however, the command line client does not
have the Folder class. To not duplicate code, the function to generate
the sync journal name went to SyncEngine class.
2016-09-02 16:19:10 +02:00
Klaas Freitag
2daf895e43
Documentation: Mention the new format for the journal file.
2016-09-02 16:19:10 +02:00
Klaas Freitag
3b651b2da9
folderman: Clean some comments
2016-09-02 16:19:04 +02:00
Klaas Freitag
6fd930908c
csync_tests: Adopted to new cmocka API.
2016-09-02 15:49:54 +02:00
Klaas Freitag
62125a442d
csync_exclude: Also exclude the new syncjournal filename.
2016-09-02 15:49:21 +02:00
Klaas Freitag
2d54fb2ff9
csync_update: Do not check to exclude .csync_journal.db
...
It is indeed already handled by csync_exclude.
2016-09-02 15:48:45 +02:00
Klaas Freitag
e46fad52bb
Make the sync journal file name a method of the Folder class.
...
The sync journal name has a dependency on the remote url now.
2016-09-02 12:29:21 +02:00
Olivier Goffart
c41f6ed76b
Chunking-NG: use new dav URL for the move
2016-08-31 12:12:34 +02:00
Olivier Goffart
818b5854ce
Chunking-NG: Qt4 compile
2016-08-31 10:28:44 +02:00
Olivier Goffart
79abb8b4e3
ChunkingNg: enable depending on an environment variable
2016-08-31 10:28:15 +02:00
Olivier Goffart
fad387b6b8
Chunking-Ng: Resume
2016-08-31 10:28:15 +02:00
Olivier Goffart
a1558100b8
WIP: new chunking algorithm
...
Current limitations of this WiP
- No resuming implemented yet
- No parallel chunks
- Hackish way to get the webdav paths
2016-08-31 10:28:15 +02:00
Olivier Goffart
4f3f642da6
Upload: refactor the upload in two classes so the new chuning can be implemented
2016-08-31 10:28:15 +02:00
Olivier Goffart
86eab48981
Qt4 Compile
2016-08-31 10:27:20 +02:00
Olivier Goffart
d2bde5489f
Propagator, remove the QNAM in the name as the alternative has been removed a long time ago
2016-08-31 10:25:06 +02:00
Christian Kamm
39e93768ea
Account wizard: Enable back button consistently #5107
...
Tested with http auth and shib auth.
2016-08-26 13:12:25 +02:00
Christian Kamm
c1eb9244d1
Shibboleth: Fix detection in account wizard #5138
...
Following redirections generally
(bb5c2cbfa5 ) meant that the special
shib-redirection detection code was no longer being used.
2016-08-26 12:58:06 +02:00
Markus Goetz
6ecda6e7f4
Merge branch '2.2'
2016-08-24 11:39:12 +02:00
Jocelyn Turcotte
b28123bed9
Fix the Qt4 unit testing build
2016-08-18 10:34:07 +02:00
Jocelyn Turcotte
2ff7b63551
Merge pull request #5122 from jturcotte/syncfilestatustrackerTests
2016-08-17 16:04:02 +02:00
Christian Kamm
b541fea793
ShareLink: Ensure the password line edit is enabled #5117
2016-08-17 15:48:25 +02:00
Jocelyn Turcotte
efb6b8c2c9
[overlays] Fix folders appearing as OK even though children are still syncing #4797
...
This would happen if the directory would first need to be created
through an mkdir propagation job. This job's itemCompleted signal
would trigger the directory to show as SYNC even though its children
are still propagating.
Fix the issue by tracking the sync count for each file, affecting
its parents. This allows us to get rid of the O(n) vector lookup
for each status query, and properly track the hierachical sync
status of a directory.
This also removes the itemCompleted signal emission from the
PropagateDirectory job. Since we only needed for overlay icons, and
since this job doesn't do any direct propagation, we can remove it
to ensure that we won't call itemCompleted twice for the item attached
to Propagate*Mkdir jobs (since the PropagateDirectory is backed by
the same SyncFileItem, instruction and status).
2016-08-17 15:40:02 +02:00
Jocelyn Turcotte
e974771796
csync: Use an explicit instruction for should_update_metadata
...
The current way of tracking the need to update the metadata without
propagation using a separate flag makes it difficult to track
priorities between the local and remote tree. The logic is also
difficult to logically cover since the possibilities matrix isn't
100% covered, leaving the flag only used in a few situations
(mostly involving folders, but not only).
The reason we need to change this is to be able to track the sync
state of files for overlay icons. The instruction alone can't be
used since CSYNC_INSTRUCTION_SYNC is used for folders even though
they won't be propagated. Removing this logic is however not possible
without using something else than CSYNC_INSTRUCTION_NONE since too
many codepath interpret (rightfully) this as meaning "nothing to do".
This patch adds a new CSYNC_INSTRUCTION_UPDATE_METADATA instruction
to let the update and reconcile steps tell the SyncEngine to update
the metadata of a file without any propagation. Other flags are left
to be interpretted by the implementation as implicitly needing
metadata update or not, as this was already the case for most file
propagation jobs. For example, CSYNC_INSTRUCTION_NEW for directories
now also implicitly update the metadata.
Since it's not impossible for folders to emit CSYNC_INSTRUCTION_SYNC
or CSYNC_INSTRUCTION_CONFLICT, the corresponding code paths in the
sync engine have been removed.
Since the reconcile step can now know if the local tree needs metadata
update while the remote side might want propagation, the
localMetadataUpdate logic in SyncEngine::treewalkFile now simply use
a CSYNC_INSTRUCTION_UPDATE_METADATA for the local side, which is now
implemented as a different database query.
2016-08-17 15:39:31 +02:00
Jocelyn Turcotte
82ef1bcfe0
Make sure that we invalidate parents on blacklisted items
...
Add a missing call that we currently only do in slotItemCompleted.
This would normally only affect the first sync and would have
gotten properly update at the end of the sync anyway.
2016-08-17 15:39:30 +02:00
Jocelyn Turcotte
b7ff4a76e8
Add TestSyncEngine and TestSyncFileStatusTracker auto tests
...
To be able to test the SyncEngine efficiently, a set of server
mocking classes have been implemented on top of QNetworkAccessManager.
The local disk side hasn't been mocked since this would require adding
a large abstraction layer in csync. The SyncEngine is instead pointed
to a different temporary dir in each test and we test by interacting
with files in this directory instead.
The FakeFolder object wraps the SyncEngine with those abstractions
and allow controlling the local files, and the fake remote state
through the FileModifier interface, using a FileInfo tree structure
for the remote-side implementation as well as feeding and comparing
the states on both side in tests.
Tests run fast and require no setup to be run, but each server feature
that we want to test on the client side needs to be implemented in
this fake objects library. For example, the OC-FileId header isn't
set as of this commit, and we can't test the file move logic properly
without implementing it first.
The TestSyncFileStatusTracker tests already contain a few QEXPECT_FAIL
for what I esteem being issues that need to be fixed in order to catch
up on our test coverage without making this patch too huge.
2016-08-17 15:39:30 +02:00
Jenkins for ownCloud
7f59dec0bb
[tx-robot] updated from transifex
2016-08-17 01:15:16 +02:00
Jocelyn Turcotte
2507ba9818
tx.pl: Fix each put_to_dir taking 10 seconds
...
The open function expects a URL, passing only the directory name would
lead HTTP::DAV to try looking it as an hostname on the network and
only return after it timed out.
2016-08-15 15:35:53 +02:00
ckamm
88cd5421bf
Tray menu: Update only on demand #4990 #4985 ( #5072 )
...
The tray menu is now only updated when it becomes visible or while
it is visible.
2016-08-15 13:42:56 +02:00
ckamm
7b26e6b8f9
Progress: Don't display unlikely estimates #5046 ( #5066 )
2016-08-15 13:36:53 +02:00
Jenkins for ownCloud
1a454ec6b2
[tx-robot] updated from transifex
2016-08-15 01:15:15 +02:00
Jenkins for ownCloud
ce4daaaae2
[tx-robot] updated from transifex
2016-08-13 01:15:24 +02:00
Jenkins for ownCloud
775ad25be3
[tx-robot] updated from transifex
2016-08-12 01:16:28 +02:00
Jenkins for ownCloud
7e43fe599c
[tx-robot] updated from transifex
2016-08-12 01:15:20 +02:00
Jenkins for ownCloud
3e64840e33
[tx-robot] updated from transifex
2016-08-11 01:16:34 +02:00
Jenkins for ownCloud
e6db2ee960
[tx-robot] updated from transifex
2016-08-11 01:15:18 +02:00
Markus Goetz
be34bfb276
issue_template.md: Clarifying comment
2016-08-10 14:44:19 +02:00
Jenkins for ownCloud
6fbeb60d86
[tx-robot] updated from transifex
2016-08-10 01:16:38 +02:00
Daniel Molkentin
bb5c2cbfa5
Always follow redirects in network jobs ( #4905 )
...
This is a move away from the original policy where jobs
would only follow redirects in special cases.
Two restrictions are in place:
1. We do not allow protocol downgrades (https -> http)
2. We stop redirects after we find them looping (e.g. old = new url, or
indirectly when looping 10 times).
This is closer to RFC conforming behavior, although currently
we will treat 301 replies like they were 302. This is for a separate
commit.
Error handling (and display) also needs improvement.
Addresses #2791
2016-08-09 16:01:29 +02:00
Jenkins for ownCloud
60904496d2
[tx-robot] updated from transifex
2016-08-09 15:12:31 +02:00
Thomas Müller
94c9a2cca1
Jenkinsfile: Add win32 build ( #5091 )
2016-08-09 15:06:17 +02:00
Olivier Goffart
73a6939b70
ownsql: handle QByteArray without converting to QString ( #5097 )
...
QByteArray is used for checksum
2016-08-02 11:39:08 +02:00
Olivier Goffart
88e5a9411a
SyncEngine: Reads the data-fingerprint property ( #5056 )
...
When it changes, assume a backup was recovered, and keep conflict files.
Issues: #2325 and https://github.com/owncloud/enterprise/issues/966
2016-08-02 10:30:49 +02:00
Jenkins for ownCloud
d58c392d93
[tx-robot] updated from transifex
2016-08-01 01:16:19 +02:00
Klaas Freitag
5ac434a740
Logs: Add the name of the platform we're running on to the log. ( #5082 )
2016-07-28 16:30:40 +02:00
Daniel Molkentin
a83c5598e8
Update owner to be ownCloud GmbH
...
Fixes #5079
2016-07-26 16:48:08 +02:00
Christian Kamm
eadecc5802
Excludes: Fix a Windows specific bug #5039
...
It meant that almost nothing was being excluded.
Broken since 87b4693a9d
2016-07-19 15:38:57 +02:00
Christian Kamm
39bde6f3e4
Revert "Add 'open in browser' to account menu #4824 "
...
This reverts commit 3c575a2f37 .
One can already open the account in the browser by clicking the
link in the settings dialog!
2016-07-19 11:19:40 +02:00
Klaas Freitag
f3cfd2b70b
csync: Free statedb file member before realloc
2016-07-17 21:13:17 +02:00
Klaas Freitag
78caa1a712
Fix tests for syncjournaldb
2016-07-17 21:10:07 +02:00
Olivier Goffart
3465024898
CleanupPollsJob: Fix possible leak
...
Missing deleteLater when the CleanupPollsJob aborts.
This is only a problem if the SyncEngine is kept alive a long time. Which is
usually not the case in the configuration where poll jobs are used.
2016-07-14 09:23:22 +02:00
Olivier Goffart
7c671756e6
Merge remote-tracking branch 'origin/2.2'
...
Conflicts:
src/libsync/syncfilestatustracker.cpp
2016-07-12 17:38:15 +02:00
Markus Goetz
0c6788f03d
conffile.rst #5052
2016-07-12 14:29:05 +02:00
Thomas Müller
6bd4de19a8
Add Jenkinsfile ( #5041 )
2016-07-12 13:24:35 +02:00
Olivier Goffart
927a8b5071
Qt4: don't require a X server in the tests
...
Previous commit was not enough
2016-07-12 11:07:12 +02:00
Olivier Goffart
a4310f0f5c
Qt4: don't require a X server in the tests
2016-07-11 14:04:58 +02:00
Olivier Goffart
cb64ba22b3
Fix Qt4 build
2016-07-11 12:27:59 +02:00
Klaas Freitag
0884ad6517
owncloudcmd: Adopt to new syncJournalDb MD5 based name schema.
2016-07-10 13:05:09 +02:00
Klaas Freitag
37fc4e4332
SyncJournalDb: Cleanup of Constructor interface.
...
The parameter path is not longer needed.
2016-07-10 13:04:29 +02:00
Klaas Freitag
9cc90159f1
FolderMan: ensureJournalGone needs to know the exact journal name, WIP
2016-07-10 12:57:35 +02:00
Klaas Freitag
4ceee86c66
SyncEngine: Calculate a uniq journal name using the remote account.
...
That should allow to sync the same local folder to multiple remote destinations.
see #3764
2016-07-10 12:56:43 +02:00
Klaas Freitag
b9ea7c3414
csync: Do not compute the journal name in csync_update any more.
...
Rely on the name that was passed to csync_init()
2016-07-10 12:54:33 +02:00
Klaas Freitag
3033e693be
Folder: For wipe reuse the journal name from SyncEngine.
...
Do not compute on its own any more.
2016-07-10 12:52:47 +02:00
Klaas Freitag
a1bc01d3b1
SyncJournalDb: Add a method to set the name of the db file.
2016-07-10 12:51:42 +02:00
Jenkins for ownCloud
b21e3e0fdc
[tx-robot] updated from transifex
2016-07-10 01:15:58 -04:00
Jenkins for ownCloud
4979181e85
[tx-robot] updated from transifex
2016-07-07 01:15:57 -04:00
Christian Kamm
699d1ba13b
owncloudcmd: Make source_dir absolute #5035
...
Fixes a problem with relative paths on Windows.
2016-07-05 15:40:32 +02:00
Christian Kamm
3c575a2f37
Add 'open in browser' to account menu #4824
2016-07-05 14:48:51 +02:00
Christian Kamm
bd7ec19644
Set discovery thread priority to low #5017
2016-07-05 13:53:57 +02:00
Olivier Goffart
3f3a679f81
Fix the URL from previous commit
...
The pull request was merged too early and did not contain the URL change
(Issue #4877 )
2016-06-28 14:17:16 +02:00
Olivier Goffart
cde9017340
GUI: Show link to the page that allow to add a new token ( #4963 )
...
If owncloud >= 9.1 is detected:
and add a link to the ownCloud page that allow to add device token.
Issue #4877
2016-06-28 12:25:04 +02:00
Christian Kamm
6e9df8673f
Merge remote-tracking branch 'origin/2.2'
2016-06-22 15:41:37 +02:00
ckamm
681243277e
Share dialog: Add 'Mail link' button #3261 ( #4961 )
2016-06-20 13:06:57 +02:00
Jocelyn Turcotte
cb50fae0a7
SocketAPI: Move the normalization closer to the data entrance ( #4972 )
...
Follow-up for #4884
2016-06-15 21:03:21 +02:00
Jenkins for ownCloud
73cc3a4fd4
[tx-robot] updated from transifex
2016-06-10 01:15:55 -04:00
Christian Kamm
d655074f85
Log: Include start of propagation and lap duration
2016-06-09 14:28:15 +02:00
Christian Kamm
85a173e174
Log: Write the sync log during propagation #3108
...
...instead of when done with the sync. This way we get information
even if the client crashes.
2016-06-09 14:10:47 +02:00
Christian Kamm
87b4693a9d
Add error message for trailing spaces on Windows #4878
2016-06-09 12:41:02 +02:00
ckamm
28c12a3ca0
Move touched-files tracking to SyncEngine #4927 ( #4946 )
2016-06-09 12:07:18 +02:00
Christian Kamm
66f041f74c
Fix Qt4 build
2016-06-07 10:05:57 +02:00
Christian Kamm
6d02d76cfd
Fix compile warnings in tests
2016-06-07 09:43:04 +02:00
Christian Kamm
48efbcb8ca
Merge remote-tracking branch 'origin/2.2'
2016-06-07 09:39:44 +02:00
Jenkins for ownCloud
86680a53e0
[tx-robot] updated from transifex
2016-06-03 01:15:59 -04:00
Jenkins for ownCloud
e031f7d090
[tx-robot] updated from transifex
2016-06-01 01:18:50 -04:00
Stephen Colebrook
d4b72132d6
Search results are filtered by server. Don't filter a second time. Also allows searching on attributes other than displayname in ldap configurations. Search results match web and mobile apps. ( #4902 )
2016-05-31 09:45:38 +02:00
Daniel Molkentin
763016bd8f
Merge pull request #4916 from mwleeds/patch-1
...
Fix typo in folder.cpp
2016-05-27 18:13:05 +02:00
Matthew Leeds
7f0cc5b699
Fix typo in folder.cpp
2016-05-27 11:13:18 -04:00
Jenkins for ownCloud
d3a93cbaeb
[tx-robot] updated from transifex
2016-05-27 01:15:50 -04:00
Daniel Molkentin
85d3c7a263
Merge remote-tracking branch 'origin/2.2'
2016-05-26 10:19:50 +02:00
Olivier Goffart
159535fe90
Merge branch '2.2'
2016-05-25 16:30:17 +02:00
Markus Goetz
088a294fac
Update issue_template.md
...
Use 2.2 link
2016-05-25 11:33:10 +02:00
Jenkins for ownCloud
813bc15a78
[tx-robot] updated from transifex
2016-05-22 01:15:47 -04:00
ckamm
567fe87e98
Use natural sorting for filenames if available #4859 ( #4864 )
2016-05-19 15:36:46 +02:00
Christian Kamm
a1ba23eea9
Activity: When a new notification arrives, switch to that tab #4805
2016-05-19 14:13:07 +02:00
Olivier Goffart
194db066b6
Merge remote-tracking branch 'origin/2.2'
2016-05-17 10:04:31 +02:00
Jocelyn Turcotte
129c17651a
Revert "Overlay icon fixes ( #4765 )"
...
The pull request should have been done against the 2.2 branch, and
the branch would better be merged instead of squashed to keep the
history easier to lookup.
This reverts commit 0469236d80 .
2016-05-03 12:59:17 +02:00
Jocelyn Turcotte
0469236d80
Overlay icon fixes ( #4765 )
...
* Fix the sync status push for parent directories #4682
As before, we rely on metadata-update SyncFileItem entries for parent
directories to notify us that a directory contains files to propagate,
and to know when all children were propagated through its itemCompleted
signal.
Those metadata SyncFileItems however have a None direction and we need
to add a explicit directory check to show them as Sync.
This fix also handles new files as well as existing ones, so no need
to keep a separate logic for new files.
* Fix the root item sync status #4682
Make sure that we push the new status when the status of the SyncEngine
changed. SyncEngine::started comes a bit late, only when the propagation
starts, although it's better in this case since child folders will
only switch to Sync in aboutToPropagate.
Also fix an issue with SyncEngine::findSyncItem when using an empty
fileName; this would match and return the wrong item, even though
not currently happening with the code since fileStatus won't call
it with an empty fileName anymore.
* Simplify the root status logic
Go through fileStatus like other cases to make sure that all use
cases go through the same code path. This also makes sure to use
lookupProblem which will use lower_bound which is more efficient
for larger sets of sync problems.
This also fixes the issue with lookupProblem that prevented it to
properly match an empty pathToMatch, caused by the fact that the
problem map contains relative paths not starting with a slash.
* Avoid a SyncFileStatusTracker private overload with the same name
Having an overload as a private function in the same class makes the
code harder to follow. Rename the private fileStatus to syncFileItemStatus.
* [osx] Fix missing overlay icons on client startup
Since the statuses are cached and that we can't invalidate the cache,
sending NOP would need to be overwritten by the default OK status
once the client successfully connected. But instead of remembering
which files we NOPed, rather wait until we are ready to sync before
sending the REGISTER_PATH message to the socket API client. It will
also prevent the client from sending unnecessary RETRIEVE_FILE_STATUS
requests.
Also remove AccountState::canSync, since it does the same as
isConnected and syncing is not an account responsibility.
2016-05-02 16:33:17 +02:00
Olivier Goffart
93e0d52dd3
Merge pull request #4769 from orion1024/curl-check-in-perl-tests
...
Adding CURL check in t6.pl
2016-04-30 14:25:21 +02:00
orion1024
9f3e576348
Adding CURL check in t6.pl
...
Aborts immediately if CURL not found, to avoid misleading errors later.
2016-04-30 11:44:16 +02:00
Olivier Goffart
5479aaeb5b
Merge remote-tracking branch 'origin/2.2'
2016-04-28 16:38:46 +02:00
Christian Kamm
8dc178a9f3
Share link: Consistent order of options owncloud/core#24122
2016-04-26 07:45:41 +02:00
Klaas Freitag
35d4b96339
Set base version to 2.3.0. For 2.2, please use the branch 2.2
2016-04-25 14:15:17 +02:00