Felix Weilbach
2d54bc4d17
Merge pull request #3742 from nextcloud/bump-3.3.3
...
Bump version to 3.3.3
2021-09-03 11:40:46 +02:00
Felix Weilbach
664ab345fa
Bump version to 3.3.3
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-03 11:39:01 +02:00
Felix Weilbach
2eee656dec
Merge pull request #3739 from nextcloud/backport/3727/stable-3.3
...
[stable-3.3] Only set dav user after login
2021-09-03 11:33:55 +02:00
Felix Weilbach
28c135c26f
Only set dav user after login.
...
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.
It should be enough to set the dav user only after login because the
dav user will never change.
See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839
Fixes #3677
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-09-03 09:24:08 +00:00
Nextcloud bot
01fdd229ab
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-03 03:55:24 +00:00
Nextcloud bot
c1fefa3251
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-02 03:52:39 +00:00
Nextcloud bot
dcbb7847d0
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-09-01 03:52:14 +00:00
Nextcloud bot
0ee03468c6
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-31 03:53:32 +00:00
Nextcloud bot
ef7e29a0d8
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-30 03:52:25 +00:00
Nextcloud bot
c19d489852
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-29 03:51:22 +00:00
Nextcloud bot
3e56ebcfff
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-28 04:23:37 +00:00
Nextcloud bot
189ada15fd
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-27 03:53:56 +00:00
Matthieu Gallien
50453d9d7e
Merge pull request #3718 from nextcloud/release-3.3.2
...
Release 3.3.2
2021-08-26 11:08:51 +02:00
Matthieu Gallien
2740fea577
release 3.3.2 version
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-08-26 11:04:41 +02:00
allexzander
02a95b6f57
Merge pull request #3717 from nextcloud/backport/3698/stable-3.3
...
[stable-3.3] Update nextcloudcmd documentation.
2021-08-26 11:01:53 +03:00
allexzander
3aeeeb56ff
Update nextcloudcmd documentation.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-08-26 07:51:51 +00:00
Nextcloud bot
9e6750f3d2
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-26 03:53:38 +00:00
Nextcloud bot
ff38f1cffc
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-25 03:51:33 +00:00
Matthieu Gallien
58f34bd0c6
Merge pull request #3711 from nextcloud/backport/3709/stable-3.3
...
[stable-3.3] support server versions for one year after it is end of life
2021-08-24 17:01:14 +02:00
Matthieu Gallien
44f89224b3
support server versions for one year after it is end of life
...
according to https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-08-24 14:48:33 +00:00
Nextcloud bot
cf8b2c98c7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-24 03:52:28 +00:00
Matthieu Gallien
35b55d7221
Merge pull request #3706 from nextcloud/backport/3621/stable-3.3
...
[stable-3.3] Bugfix/nextcloud cmd dav fix
2021-08-23 17:20:14 +02:00
allexzander
9492defbe2
Use separate arguments for a remote root and do not use dav or webdav in the server's URL
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-08-23 15:11:44 +00:00
Nextcloud bot
8fbc25a0d7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-23 03:49:39 +00:00
Nextcloud bot
c05136ce50
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-22 03:50:11 +00:00
Nextcloud bot
60542aec87
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-21 03:54:46 +00:00
Nextcloud bot
6155b24c60
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-19 03:50:39 +00:00
Matthieu Gallien
3b75cddefb
Merge pull request #3686 from nextcloud/backport/3680/stable-3.3
...
[stable-3.3] Fix macOS app bundle name in packaging scripts
2021-08-18 11:29:45 +02:00
znerol
75307b70c2
Fix macOS app bundle name in packaging scripts
...
Signed-off-by: znerol <lo+github@znerol.ch >
2021-08-18 07:54:02 +00:00
Nextcloud bot
23591f385e
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-18 03:52:40 +00:00
Nextcloud bot
82d8c363c5
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-17 03:53:23 +00:00
Matthieu Gallien
b05d2d791e
Merge pull request #3676 from nextcloud/bugfix/checksumsParseIssue
...
Bugfix/checksums parse issue
2021-08-16 14:08:41 +02:00
Hannah von Reth
4df0ddcbd5
Add workaround for issue discovered in https://github.com/owncloud/core/pull/38304
2021-08-16 13:05:39 +02:00
Hannah von Reth
26ca566428
Make findBestChecksum case insensitive
...
Especially the casing of ADLER32 did not match the server.
2021-08-16 13:05:34 +02:00
Nextcloud bot
21caff6dd5
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-16 03:51:49 +00:00
Nextcloud bot
5d3cd92631
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-15 03:51:24 +00:00
Nextcloud bot
aa8521c70f
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-14 03:53:15 +00:00
Nextcloud bot
1865bc6881
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-13 03:51:38 +00:00
Matthieu Gallien
cd934ba80c
Merge pull request #3656 from nextcloud/backport/3655/stable-3.3
...
[stable-3.3] Return the login name instead of user id
2021-08-12 15:29:22 +02:00
Felix Weilbach
5202df4407
Return the login name instead of user id
...
App password and login name need to match. If authResult() returns the
user id the user id will be stored in webdav_user
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-12 13:17:57 +00:00
Felix Weilbach
99bcf30f77
Merge pull request #3650 from nextcloud/bump-3.3.1
...
Bump to version 3.3.1
2021-08-12 10:36:42 +02:00
Felix Weilbach
56e8561e64
Bump to version 3.3.1
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-12 10:35:11 +02:00
Nextcloud bot
05fef8e463
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-12 03:53:16 +00:00
Matthieu Gallien
6f5c61e442
Merge pull request #3648 from nextcloud/backport/3646/stable-3.3
...
[stable-3.3] Enforce fetching of user id
2021-08-11 18:51:29 +02:00
Felix Weilbach
1e28185ee9
Enforce fetching of user id
...
With the change of commit 3e61bdc431 and
the relase of v3.3.0 users that had their email address used as login
are not able to login anymore. The dav_user should be empty if users
tried to create a account in the meantime. Therefore we fetch the user
id in the case dav_user (and then Account::_davUser) is empty. We then
store the user id in dav_user.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-11 16:43:11 +00:00
Matthieu Gallien
4d7f72e3a1
Merge pull request #3647 from nextcloud/backport/3632/stable-3.3
...
[stable-3.3] Ensure that the users id is used for accessing webdav
2021-08-11 16:58:39 +02:00
Felix Weilbach
6a414d5fb3
Ensure that the users id is used for accessing webdav
...
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#obtaining-the-login-credentials
states that the email address can be used for login but it's not
allowed to use the email address to access webdav.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-08-11 14:18:35 +00:00
Nextcloud bot
694c6e7214
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-11 03:53:48 +00:00
Nextcloud bot
e0e4e9778b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-10 04:09:05 +00:00
Nextcloud bot
7baa66b83e
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-09 03:53:21 +00:00
Nextcloud bot
301bb2024e
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-08 03:48:27 +00:00
Nextcloud bot
f7fce0100b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-07 03:57:06 +00:00
Nextcloud bot
af894485b4
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-06 04:01:23 +00:00
Nextcloud bot
2fb609fa98
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-05 03:53:30 +00:00
Nextcloud bot
c4627c3c04
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-04 03:53:10 +00:00
Nextcloud bot
5f0e8b8268
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-03 03:52:44 +00:00
Nextcloud bot
99c6bee64b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-02 03:26:03 +00:00
Nextcloud bot
853bfed89a
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-08-01 03:27:14 +00:00
Nextcloud bot
86dc3fefc8
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-31 03:32:43 +00:00
Nextcloud bot
ea800b638d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-30 03:24:19 +00:00
Matthieu Gallien
a2e69d8574
Merge pull request #3610 from nextcloud/backport/3609/stable-3.3
...
[stable-3.3] Update supported server versions
2021-07-29 12:03:32 +02:00
Felix Weilbach
0178b322f9
Update supported server versions
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-29 10:03:10 +00:00
Felix Weilbach
acf3bf0959
Merge pull request #3607 from nextcloud/bump-version-3.3.0
...
Bump version 3.3.0
2021-07-29 10:40:19 +02:00
Felix Weilbach
49647c6267
Bump version 3.3.0
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-29 10:36:26 +02:00
Matthieu Gallien
0569b2bab3
Merge pull request #3602 from nextcloud/bugfix/crashInAccountDavPath
...
prevent crash in Accont::davPath without credentials
2021-07-29 10:31:48 +02:00
Matthieu Gallien
badb5c1fba
fix review comment
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-29 08:27:53 +00:00
Matthieu Gallien
391935c90f
prevent crash in Accont::davPath without credentials
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-29 08:27:53 +00:00
Nextcloud bot
9808f83913
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-29 03:23:50 +00:00
Matthieu Gallien
ae33a89844
Merge pull request #3595 from ivaradi/remove-groovy
...
Do not build for Groovy
2021-07-28 17:31:42 +02:00
István Váradi
e0697eefa0
Do not build for Groovy
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-07-28 14:46:55 +00:00
Matthieu Gallien
b50851726d
Merge pull request #3599 from nextcloud/update-docs-news
...
Update improvements and news in the documentation
2021-07-28 16:44:47 +02:00
Felix Weilbach
55067c55a7
Update improvements and news in the documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-28 12:59:36 +00:00
Matthieu Gallien
8d5612219c
Merge pull request #3596 from nextcloud/bugfix/main-dialog-dont-constrain-background-size
...
Don't constrain size of hover background
2021-07-28 12:44:39 +02:00
Felix Weilbach
7bb0c588c1
Don't constrain size of hover background
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-28 10:29:04 +00:00
Matthieu Gallien
d5857730d1
Merge pull request #3592 from nextcloud/bugfix/properWebdavUrlOnAccountSetup
...
in wizard always use the correct way to get dav path
2021-07-28 12:27:58 +02:00
Matthieu Gallien
d2133da3ee
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-28 12:27:02 +02:00
Matthieu Gallien
c40d276770
remove dead code around overriding dav path in URL
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-28 12:12:17 +02:00
Matthieu Gallien
77433f7e1d
in wizard always use the correct way to get dav path
...
fixes listing being incorrect when using dav endpoint
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-28 09:45:49 +00:00
Matthieu Gallien
6ac719d74c
Merge pull request #3339 from nextcloud/ci/addCodeCoverage
...
takes ECMCoverageOption from ECM to enable code coverage analysis
2021-07-28 11:43:49 +02:00
Matthieu Gallien
f9bfd8adec
takes ECMCoverageOption from ECM to enable code coverage analysis
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-28 09:26:40 +00:00
Matthieu Gallien
1e91e1bd96
Merge pull request #3586 from nextcloud/bugfix/fix-crash-folder-isSyncRunning
...
Fix crash in Folder::isSyncRunning()
2021-07-28 11:25:17 +02:00
allexzander
88d18fd5f3
Invoke 'bool Folder::isSyncRunning() const' from tests.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-28 08:58:00 +00:00
allexzander
98ae715905
Fix crash in Folder::isSyncRunning()
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-28 08:58:00 +00:00
allexzander
e3ca1f09de
Merge pull request #3594 from nextcloud/bugfix/revert-checksum-mismatch-skip
...
Revert: Added config parameter that allows to bypass checksum validation failure.
2021-07-28 11:55:21 +03:00
allexzander
8122c63ebc
Revert Added config parameter that allows to bypass checksum validation failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-28 07:57:10 +00:00
Nextcloud bot
76308d5155
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-28 03:26:46 +00:00
John Molakvoæ
f5210c893e
Merge pull request #3492 from nextcloud/feat/rebase-template
2021-07-27 14:41:23 +02:00
John Molakvoæ
7c54065ed7
Delete rebase.yml
2021-07-27 10:47:21 +00:00
John Molakvoæ
dd9836ea5f
Create command-rebase.yml
2021-07-27 10:47:21 +00:00
Nextcloud bot
ac6cf3ef96
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-27 03:25:18 +00:00
Nextcloud bot
a87c3f28a2
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-26 03:26:18 +00:00
Nextcloud bot
afac8c384d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-25 03:27:44 +00:00
Nextcloud bot
b628349dc7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-24 03:30:34 +00:00
Valdnet
a4dc7a938a
Merge pull request #3579 from nextcloud/Valdnet-patch-3
...
l10n: Change to uppercase
2021-07-23 09:56:48 +02:00
Valdnet
9dee4b1a7a
Merge branch 'master' into Valdnet-patch-3
2021-07-23 09:07:18 +02:00
Nextcloud bot
2addea18ff
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-23 03:26:47 +00:00
Felix Weilbach
8bbe71c8a2
Merge pull request #3582 from nextcloud/bugfix/make-main-dialog-window
...
Make main dialog normal window when displayed as regular window
2021-07-22 18:06:48 +02:00
Valdnet
bc9d3c5936
l10n: Change to uppercase
2021-07-22 15:47:52 +00:00
Valdnet
7db51e9029
l10n: Change to uppercase
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-07-22 15:47:52 +00:00
Felix Weilbach
a421ebf01c
Make main dialog normal window when displayed as regular window
...
This will enable users to minimize the dialog.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-22 10:34:13 +02:00
allexzander
2e07e93a42
Merge pull request #3581 from nextcloud/bump-version-3.2.82
...
Bump version to 3.3.0-rc2
2021-07-22 10:19:31 +03:00
allexzander
d9a8a7e0ac
Bump version to 3.3.0-rc2
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-22 10:16:37 +03:00
Nextcloud bot
898fb3c6a8
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-22 03:28:31 +00:00
Matthieu Gallien
a8aa035065
Merge pull request #3542 from nextcloud/bugfix/enforce-https-with-flow2
...
Enforce https in flow2 for https connections
2021-07-21 20:34:42 +02:00
Felix Weilbach
302651620b
Use Q_UNUSED instead of commenting out arg names
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Felix Weilbach
3f6bb4a929
Use QStringLiteral instead of plain strings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Felix Weilbach
ee49a7ed52
Fix review comments
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Felix Weilbach
e4f92ad1a1
Enforce https in flow1 and flow2 for https connections
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-21 17:15:11 +00:00
Matthieu Gallien
15affdbfda
Merge pull request #3498 from nextcloud/bugfix/qml-warnings
...
Fix QML Warnings and create custom component for the activity list
2021-07-21 19:13:00 +02:00
Camila
6886d6213a
Add custom component ActivityItem.
...
That also addresses QML warnings.
Signed-off-by: Camila <hello@camila.codes >
2021-07-21 17:03:26 +02:00
Camila
79dd4f73fe
Fix QML warning: Unable to assign [undefined] to QFont.
...
Signed-off-by: Camila <hello@camila.codes >
2021-07-21 14:46:04 +00:00
Matthieu Gallien
b536b73c97
Merge pull request #3565 from nextcloud/bugfix/fixSlowMenuInSettings
...
do not block account menu: availability checking can be slow
2021-07-21 16:42:35 +02:00
Matthieu Gallien
a8ef8bdcb8
do not block account menu: availability checking can be slow
...
ignore availability that can be very slow to check with CfApi virtual
files plugin
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 12:58:23 +00:00
Matthieu Gallien
45538857cf
Merge pull request #3345 from nextcloud/ci/testAppveyor
...
Ci/test appveyor
2021-07-21 14:12:52 +02:00
Matthieu Gallien
2bf757a657
only run the pipeline for master branch and pull requests
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
bbcfe56cfd
execute automated tests but do not fail if there are errors
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
360118634d
build the nextcloud client and not something else
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
9295bb42d6
update CraftMaster git repository
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-21 11:33:07 +00:00
Matthieu Gallien
505121f394
upgrade appveyor support to MSVC 2019
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-07-21 11:33:07 +00:00
allexzander
309e8bd183
Merge pull request #3566 from nextcloud/bugfix/desktop-client-high-cpu-usage-on-auto-update
...
Show custom QDialog instead of QMessageBox when update is ready.
2021-07-21 14:26:11 +03:00
allexzander
801e4ad363
Create QMessageBox on heap when the update is ready. Do not return true from OCUpdater to allow for a proper app::quit
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-21 14:23:43 +03:00
Matthieu Gallien
58cf46f435
Merge pull request #3569 from nextcloud/bugfix/fixPermissionsLog
...
print the real permissions string instead of its address
2021-07-21 10:39:10 +02:00
Matthieu Gallien
1fca07546c
print the real permissions string instead of its address
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-21 08:25:42 +00:00
Felix Weilbach
9d2cb53cff
Merge pull request #3574 from nextcloud/bugfix/open-main-dialog-gnome-always
...
Open main dialog gnome always
2021-07-21 09:16:01 +02:00
Felix Weilbach
4e95e32791
Call setClosed() on correct Object
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 12:56:00 +02:00
Felix Weilbach
89fea30a3b
Remove Q_INVOKABLE from signals because it's not needed
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 12:55:37 +02:00
Felix Weilbach
e283c166de
Merge pull request #3488 from nextcloud/bugfix/remove-unused-variable
...
Remove unused pushNotifications variable
2021-07-20 11:05:13 +02:00
Felix Weilbach
12bdd8742b
Remove unnused variable
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 07:43:36 +00:00
Felix Weilbach
38467b2e30
Remove unused pushNotifications variable
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-20 07:43:36 +00:00
Nextcloud bot
e46ac74ba4
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-20 03:27:06 +00:00
Nextcloud bot
07b390fccc
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-18 03:48:19 +00:00
Nextcloud bot
c1b807dbff
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-17 04:08:12 +00:00
Matthieu Gallien
dc452feadd
Merge pull request #3558 from nextcloud/bugfix/userStatusTooLongAccountMenu
...
Bugfix/user status too long account menu
2021-07-16 17:40:22 +02:00
Matthieu Gallien
064f64f06d
fix width of user status message to not overlap other elements
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-16 15:19:20 +00:00
Matthieu Gallien
260e1d77f5
clean indentation in UserLine.qml
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-16 15:19:20 +00:00
Matthieu Gallien
1eca55a386
Merge pull request #3557 from nextcloud/bugfix/userStatusTooLong
...
fix size of the Label with user status
2021-07-16 17:18:03 +02:00
Matthieu Gallien
c2602135ab
fix size of the Label with user status
...
ensure the label width is not higher than the parent to ensure log
string get elided as expected
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-16 13:04:33 +00:00
Matthieu Gallien
b72d1af50a
Merge pull request #3541 from nextcloud/bugfix/use-dav-instead-of-webdav
...
Use dav instead of webdav
2021-07-16 15:03:17 +02:00
Felix Weilbach
3e61bdc431
Use dav instead of webdav
...
Fixes #3342
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-16 12:42:02 +00:00
Matthieu Gallien
545592c472
Merge pull request #3552 from nextcloud/bugfix/remove-request-to-config-for-uservisibleurl
...
Remove request to config for userVisibleURL.
2021-07-16 14:32:36 +02:00
allexzander
de627a9b7c
Remove request to config for userVisibleURL.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-16 06:45:41 +00:00
Nextcloud bot
5fe4784cbc
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-16 03:51:28 +00:00
Matthieu Gallien
ff4f4255b3
Merge pull request #3548 from nextcloud/bugfix/screenshots
...
Update screenshot in README.md
2021-07-15 19:04:01 +02:00
Felix Weilbach
c00f871b95
Update screenshot in README.md
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-15 15:33:17 +00:00
Felix Weilbach
3a99010cdb
Remove unused screenshots
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-15 15:33:17 +00:00
Nextcloud bot
d9246910b4
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com >
2021-07-15 12:15:40 +00:00
Nextcloud bot
387bb29cbd
[tx-robot] updated from transifex
2021-07-15 09:30:49 +00:00
Felix Weilbach
318d82720f
Merge pull request #3554 from nextcloud/bump-version-3.2.81
...
Bump version to 3.3.0-rc1
2021-07-15 10:44:35 +02:00
Felix Weilbach
88fdfe1c72
Bump version to 3.3.0-rc1
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-15 10:28:26 +02:00
Nextcloud bot
1e6fd98b3e
[tx-robot] updated from transifex
2021-07-15 03:54:45 +00:00
Felix Weilbach
41e3b81abf
Merge pull request #3540 from nextcloud/bugfix/position-tray-dialog-correct
...
Position main dialog on at tray icon if not a regular window
2021-07-14 20:24:47 +02:00
Felix Weilbach
036db9d22d
Position main dialog on at tray icon if not a regular window
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-14 18:27:50 +02:00
allexzander
6bc6dcd598
Merge pull request #3547 from nextcloud/bugfix/nextcloud-overlay-identifiers-not-visible
...
Windows. Nextcloud Overlay Identifiers. Set 16 spaces before each identifier's name.
2021-07-14 18:18:47 +03:00
allexzander
871210326f
Windows. Nextcloud Overlay Identifiers. Set 16 spaces before each identifier's name.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-14 16:15:02 +03:00
Nextcloud bot
4342082414
[tx-robot] updated from transifex
2021-07-14 03:53:15 +00:00
Nextcloud bot
0d454e7cf8
[tx-robot] updated from transifex
2021-07-13 03:53:15 +00:00
Felix Weilbach
7e5f080e58
Merge pull request #3468 from nextcloud/feature/main-dialog-regular-window-when-no-tray-icon
...
Show main dialog as normal window if tray icons not available
2021-07-12 16:18:58 +02:00
Felix Weilbach
efaccbd6fd
Show main dialog as normal window if tray icons not available
...
Fixes #3307
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-12 14:10:26 +00:00
Felix Weilbach
bffcf8e482
Merge pull request #3537 from nextcloud/ci/fixMacCompilation
...
only compile xattr virtual files backend for linux platform (not unices)
2021-07-12 15:46:57 +02:00
Matthieu Gallien
2ee26bbd59
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-12 14:31:19 +02:00
Matthieu Gallien
7c68408ee1
only compile xattr virtual files backend for linux platform (not unices)
...
for a reason a mac os platform specific file is missing and before xattr
plugin was compiled only for linux
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-12 14:10:54 +02:00
Felix Weilbach
b7a37a526a
Merge pull request #3536 from nextcloud/bugfix/remove-app-icon-png-files
...
Remove unnecessary png files
2021-07-12 13:51:03 +02:00
Felix Weilbach
589037bd43
Remove unnecessary png files
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-12 12:47:29 +02:00
Nextcloud bot
dce11c3c64
[tx-robot] updated from transifex
2021-07-12 03:51:01 +00:00
Nextcloud bot
107a3e9ebe
[tx-robot] updated from transifex
2021-07-11 03:52:10 +00:00
Nextcloud bot
d15a06cc17
[tx-robot] updated from transifex
2021-07-10 04:05:37 +00:00
Matthieu Gallien
61cd132c53
Merge pull request #3523 from nextcloud/bugfix/recoverSyncDbNonVirtualFile
...
avoid being stuck trying to create placeholder for existing file
2021-07-09 16:36:57 +02:00
Matthieu Gallien
d2f2e3305a
avoid being stuck trying to create placeholder for existing file
...
id sync db think a file is cirtual (empty placeholder) but file system
has a real file (non empty file) once the server has a modified version
we can no longer update it
state of file on disk takes precedence over sync DB to allow recovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-09 12:37:47 +00:00
Nextcloud bot
4a8dba90c2
[tx-robot] updated from transifex
2021-07-09 03:54:31 +00:00
Matthieu Gallien
d6b9ff9436
Merge pull request #3437 from nextcloud/feature/dynamicLoadVfsPlugins
...
bring back dynamic load of VFS plugins
2021-07-08 10:20:39 +02:00
Felix Weilbach
7094d699e9
Allow installation on Windows version < 1709
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-07-08 08:11:17 +00:00
Matthieu Gallien
8ad6f89fed
bring back dynamic load of VFS plugins
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-08 08:11:17 +00:00
Nextcloud bot
fe925d8f36
[tx-robot] updated from transifex
2021-07-08 03:55:04 +00:00
Nextcloud bot
2bbce75f10
[tx-robot] updated from transifex
2021-07-07 03:53:20 +00:00
Matthieu Gallien
4848f9577b
Merge pull request #3501 from nextcloud/bugfix/fixImplicitHydration
...
avoid error when doing hydration when data socket is closed too early
2021-07-06 16:25:55 +02:00
Matthieu Gallien
c123edb173
address review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-06 14:16:43 +00:00
Matthieu Gallien
4016c2fab0
avoid error when doing hydration when data socket is closed too early
...
when data is received, if we close the socket they cannot be read
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-06 14:16:43 +00:00
Matthieu Gallien
c1f0716d53
Merge pull request #3511 from nextcloud/bugfix/vfsFixes
...
Improve the error message returned by updateMetadata
2021-07-06 16:15:26 +02:00
Hannah von Reth
e7e218d8e6
Improve the error message returned by updateMetadata
...
Also properly handle the case the the file can't be converted to a placeholder
as it is locked
2021-07-06 14:03:53 +00:00
Nextcloud bot
e852c51675
[tx-robot] updated from transifex
2021-07-06 03:54:28 +00:00
Nextcloud bot
fac98e0f3d
[tx-robot] updated from transifex
2021-07-05 03:51:11 +00:00
Nextcloud bot
f396de5518
[tx-robot] updated from transifex
2021-07-04 03:50:57 +00:00
Nextcloud bot
aefec6137c
[tx-robot] updated from transifex
2021-07-03 03:51:48 +00:00
Matthieu Gallien
f42639e6ce
Merge pull request #3486 from nextcloud/bugfix/improveInvalidFileNameMessage
...
improve error message in case of trailing space in directory name
2021-07-02 13:00:05 +02:00
Matthieu Gallien
8f5b88acd5
improve error message in case of trailing space in directory name
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-02 10:50:31 +00:00
Matthieu Gallien
ddff9a5268
Merge pull request #3502 from nextcloud/bugfix/fixCfApiLogs
...
fix all usage of _com_error(cfExecuteresult).ErrorMessage()
2021-07-02 12:46:59 +02:00
Matthieu Gallien
746072e95d
fix all usage of _com_error(cfExecuteresult).ErrorMessage()
...
_com_error(cfExecuteresult).ErrorMessage() calls should be translated to
QString before use with qDebug and related logging facilities
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-02 11:19:04 +02:00
Nextcloud bot
c31020528e
[tx-robot] updated from transifex
2021-07-02 03:53:06 +00:00
Matthieu Gallien
d625f3fc30
Merge pull request #3494 from nextcloud/bugfix/checkServerPublicKey
...
download server public key and check user certificate against it
2021-07-01 19:04:13 +02:00
Matthieu Gallien
2bc72592a0
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-01 14:40:25 +02:00
Matthieu Gallien
698d5f19ba
download server public key and check user certificate against it
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-07-01 14:07:27 +02:00
allexzander
dca7b8d8d2
Merge pull request #3449 from nextcloud/bugfix/fix-vfs-crash-and-false-conflict-on-local-new
...
Fix VFS crash and false conflict on local new.
2021-07-01 13:33:21 +03:00
allexzander
99f6e82290
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
6ce5279b6c
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
22eba41cb8
Do not process non-directories and non-virtual files. Wipe empty online-only folder based on its pinState.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
c5982143aa
Refactoring.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:21 +03:00
allexzander
48aefc1983
Fix VFS crash and false conflict on local new.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-07-01 11:59:20 +03:00
Matthieu Gallien
80267adb3a
Merge pull request #3497 from nextcloud/bugfix/run-legacy-uninstall-in-a-secure-way
...
Run legacy uninstall exe in a secure way
2021-06-30 16:18:19 +02:00
allexzander
860514f01b
Run legacy uninstall exe in a secure way.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-30 11:58:13 +00:00
Matthieu Gallien
d9a634223a
Merge pull request #3472 from nextcloud/feature/cacheQmlImages
...
directly send the icon url for activities to the qml component
2021-06-30 13:49:30 +02:00
Matthieu Gallien
c27fc1be4a
use fallback icons for activities without icons
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-30 11:28:13 +00:00
Matthieu Gallien
269d225511
directly send the icon url for activities to teh qml component
...
should allow usage of default cache from Image qml standard component
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-30 11:28:12 +00:00
Matthieu Gallien
2a0b6f38b5
Merge pull request #3333 from nextcloud/bugfix/check-if-first-is-empty
...
Check if first is not empty
2021-06-30 09:29:01 +02:00
Felix Weilbach
c9715db720
Check if first is not empty
...
If it's not checked that first is empty, crashes may happen.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-30 06:57:41 +00:00
Nextcloud bot
e5b4fc2769
[tx-robot] updated from transifex
2021-06-30 03:53:48 +00:00
Nextcloud bot
acd98403bb
[tx-robot] updated from transifex
2021-06-29 03:52:40 +00:00
Nextcloud bot
e861fbdb2b
[tx-robot] updated from transifex
2021-06-28 03:56:09 +00:00
Nextcloud bot
7095559639
[tx-robot] updated from transifex
2021-06-27 03:53:57 +00:00
Nextcloud bot
208f0bfec1
[tx-robot] updated from transifex
2021-06-26 03:52:55 +00:00
Matthieu Gallien
cce894618e
Merge pull request #3489 from nextcloud/bugfix/design-call
...
Design call improvements
2021-06-25 23:32:03 +02:00
Felix Weilbach
015a5ae235
Don't display account name in italic
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 20:13:06 +00:00
Felix Weilbach
ae7269e156
Use Material icons for general and network settings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 20:13:06 +00:00
Felix Weilbach
fd7666100a
Merge pull request #3490 from nextcloud/bugfix/update-documentation
...
Update documentation and replace old screenshots
2021-06-25 22:11:16 +02:00
Felix Weilbach
166638b87f
Update navigating section in documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 17:40:54 +00:00
Felix Weilbach
2c556857e0
Update visual tour in documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 17:40:53 +00:00
Felix Weilbach
0a19a2996e
Update system requirements in documentation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 17:40:53 +00:00
Felix Weilbach
90244380aa
Merge pull request #3460 from nextcloud/feature/unit-test-move-custom-root
...
Add unit test for move custom remote root
2021-06-25 12:32:48 +02:00
Felix Weilbach
2ee3ca02a4
Add unit test for move custom remote root
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-25 10:14:29 +00:00
Nextcloud bot
c286b62e60
[tx-robot] updated from transifex
2021-06-25 03:54:15 +00:00
Felix Weilbach
0c8ed85156
Merge pull request #3471 from nextcloud/feature/build-without-webengine
...
Build optional without QWebEngine
2021-06-24 20:54:16 +02:00
Felix Weilbach
40065dc6dc
Disable QtWebEngine automatic if not found
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
Felix Weilbach
991f79c123
Open provider page in browser when compiling without webengine
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
Felix Weilbach
8376b99ec5
Allow to compile without QWebEngine
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
Felix Weilbach
216a57c74e
Remove dead code
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-24 15:43:51 +00:00
István Váradi
ad3b48c2c5
Merge pull request #3475 from ivaradi/use-full-gpg-keyid
...
Use the full GPG key ID for signing Debian packages
2021-06-24 16:20:16 +02:00
István Váradi
f69c595103
Use the full GPG key ID for signing Debian packages
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-06-24 12:01:29 +00:00
Nextcloud bot
db1357088d
[tx-robot] updated from transifex
2021-06-24 03:54:09 +00:00
Nextcloud bot
e19ce76e86
[tx-robot] updated from transifex
2021-06-23 03:54:55 +00:00
Nextcloud bot
df6abd5c97
[tx-robot] updated from transifex
2021-06-22 03:56:27 +00:00
István Váradi
363df3b718
Merge pull request #3464 from ivaradi/add-impish
...
Add building for Ubuntu Impish
2021-06-21 17:35:00 +02:00
István Váradi
c27782279e
Add building for Ubuntu Impish
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-06-21 17:23:34 +02:00
Felix Weilbach
616725f016
Merge pull request #3369 from nextcloud/bugfix/dont-crash-e2ee-vfs-dialog-on-folder-delete
...
Prevent crash in dialog that warns user about vfs and e2ee
2021-06-21 12:24:31 +02:00
Felix Weilbach
cb5e8398c4
Fix review comment
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-21 12:04:11 +02:00
Felix Weilbach
ab9784374f
Fix review comments
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-21 12:04:11 +02:00
Felix Weilbach
52342e5710
Prevent crash in dialog that warns user about vfs and e2ee
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-21 12:04:03 +02:00
Nextcloud bot
f720e6484d
[tx-robot] updated from transifex
2021-06-21 03:57:59 +00:00
Nextcloud bot
e13731691f
[tx-robot] updated from transifex
2021-06-20 03:58:10 +00:00
Nextcloud bot
404920c4ce
[tx-robot] updated from transifex
2021-06-19 04:21:10 +00:00
Nextcloud bot
636e7159c7
[tx-robot] updated from transifex
2021-06-18 04:02:20 +00:00
Felix Weilbach
959e450d60
Merge pull request #3337 from nextcloud/Valdnet-patch-4
...
l10n: Spelling unification
2021-06-17 15:11:18 +02:00
Valdnet
3937595eef
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-06-17 12:18:00 +00:00
Valdnet
33bdfe687f
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-06-17 12:18:00 +00:00
Felix Weilbach
dfab4bb447
Merge pull request #3445 from nextcloud/bugfix/remove-unused-function
...
Remove unused function declaration
2021-06-17 14:16:21 +02:00
Felix Weilbach
27f8152b05
Remove unused function declaration
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-17 11:22:57 +00:00
Felix Weilbach
6e41875fe1
Merge pull request #3420 from nextcloud/bugfix/cfapi-improve-cancellation
...
Cfapi: Make sure no data is transfered after cancellation
2021-06-17 11:46:13 +02:00
Felix Weilbach
c799dbdd61
Cfapi: Make sure no data is transfered after cancellation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-17 09:10:06 +00:00
Felix Weilbach
e6e4bfb9c6
Merge pull request #3397 from nextcloud/feature/enable-clazy-drone
...
Enable clazy in drone
2021-06-17 09:58:29 +02:00
Felix Weilbach
3e3c124af1
Enable clazy in drone
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-17 09:47:00 +02:00
Nextcloud bot
3e77ae0c1e
[tx-robot] updated from transifex
2021-06-17 03:59:19 +00:00
Matthieu Gallien
08fa88e182
Merge pull request #3370 from nextcloud/fix/filesFixesForWindowsAndLogs
...
Fix/files fixes for windows and logs
2021-06-16 15:36:47 +02:00
Hannah von Reth
22c634935b
Run expansive assert only in dev builds
2021-06-16 10:54:07 +00:00
Hannah von Reth
03182ea714
Use longWinPath in more places
2021-06-16 10:54:07 +00:00
Hannah von Reth
d014293f6d
Ensure pathtoUNC is called with an absolute path
2021-06-16 10:54:06 +00:00
Camila
9ea8dd95f8
Merge pull request #3388 from nextcloud/bugfix/qml-warnings
...
Bugfix/qml warnings
2021-06-16 10:40:37 +02:00
Camila
7ddc4ca170
Remove extra RowLayout.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
449fda16e1
Fix QML Warning: ReferenceError: PopupMenu is not defined.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
f3c17c747a
Fix compiling warning: multiple definitions of stateOnlineImageSource in theme.h.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
19e581657d
Fix QML warning: Cannot specify left, right... anchors for items inside Row.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
5585f61cc0
Fix QML warning: Detected anchors on an item that is managed by a layout.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Camila
c8edb11228
Fix QML warning: Accessible must be attached to an Item.
...
Signed-off-by: Camila <hello@camila.codes >
2021-06-16 07:55:33 +00:00
Nextcloud bot
73d244cd9c
[tx-robot] updated from transifex
2021-06-16 03:57:33 +00:00
Felix Weilbach
ed6a5c66b3
Merge pull request #3404 from nextcloud/bugfix/macos-set-bundle-name-correct
...
Start macOS app bundle name with uppercase letter
2021-06-15 14:33:35 +02:00
Felix Weilbach
7850551cad
Start macOS app bundle name with uppercase letter
...
It's a convention on macOS that app bundle names start with an uppercase
letter. Also this aligns the app name with Windows and Linux.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-15 12:19:55 +00:00
allexzander
ce54a98f7d
Merge pull request #3425 from nextcloud/bugfix/vfs-wipe-moved-folder-when-conflict
...
VFS wipe moved folder when conflict
2021-06-15 14:50:17 +03:00
allexzander
a3d12a616b
Add error message to GUI.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-15 14:33:45 +03:00
allexzander
6312f6ddde
Wipe empty folder when moving a VFS placeholder. Keep a folder if there are hydrated items inside.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-15 13:19:35 +03:00
Felix Weilbach
3542d171f1
Merge pull request #3432 from nextcloud/bugfix/set-pin-state-correct-after-rename
...
Set pin state correct after rename
2021-06-14 15:49:30 +02:00
Felix Weilbach
a89a84ff14
Mark placeholder in sync after updating the placeholder
...
Fixes #3403 #3082 #3391
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-14 13:40:26 +00:00
Felix Weilbach
befca65b91
Merge pull request #3395 from nextcloud/bugfix/use-svg-icon-for-app-sidebar-macos
...
Generate png icons with inkscape
2021-06-14 12:30:05 +02:00
Felix Weilbach
d4b0273792
Generate application png icons from svg icons
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-14 10:14:28 +00:00
Felix Weilbach
e7c65a71b8
Remove conditional logic for OEM.cmake
...
This file is not used in Brander and in the desktop client and just
confused people.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-14 10:14:28 +00:00
Nextcloud bot
ec521e1d4c
[tx-robot] updated from transifex
2021-06-13 03:56:20 +00:00
Nextcloud bot
290ca44c36
[tx-robot] updated from transifex
2021-06-12 03:57:20 +00:00
Nextcloud bot
ddd0c712ef
[tx-robot] updated from transifex
2021-06-11 04:02:39 +00:00
allexzander
7e3b366a89
Merge pull request #3401 from nextcloud/bugfix/checksum-mismatch-download-error
...
Added config parameter that allows to bypass checksum validation failure
2021-06-10 13:52:40 +03:00
allexzander
dc72686ab3
Allow download with mismatched checksum if a config option is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-10 13:39:11 +03:00
Nextcloud bot
407817fdb4
[tx-robot] updated from transifex
2021-06-10 04:13:11 +00:00
Nextcloud bot
470a89dfae
[tx-robot] updated from transifex
2021-06-09 04:02:04 +00:00
allexzander
c59e3c440c
Merge pull request #3390 from nextcloud/bugfix/syncexclude-dehydration-freeze
...
VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always.
2021-06-08 12:44:15 +03:00
allexzander
d6ddf595f8
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
allexzander
5dd310c21c
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
allexzander
b150de9106
Fix review comments. Also consider exclude.lst.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
allexzander
bb55232e8e
VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-08 09:25:43 +00:00
Matthieu Gallien
1951eec009
Merge pull request #3394 from nextcloud/ci/fixNeedsInfoHelperAction
...
really fix the actions to remove needsinfo when someone comment
2021-06-08 11:00:09 +02:00
Matthieu Gallien
c51815f8ad
use upper case name for the github token access
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-08 08:50:51 +00:00
Matthieu Gallien
149b1317e7
really fix the actions to remove needsinfo when someone comment
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-08 08:50:51 +00:00
Nextcloud bot
de632d7397
[tx-robot] updated from transifex
2021-06-08 04:03:16 +00:00
Felix Weilbach
e62453dc66
Merge pull request #3410 from nextcloud/bugfix/check-against-cmake-cxx-compiler-id
...
Check compiler against CMAKE_CXX_COMPILER_ID
2021-06-07 15:44:16 +02:00
Felix Weilbach
74b2c5761d
Check compiler against CMAKE_CXX_COMPILER_ID
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-06-07 15:18:03 +02:00
Nextcloud bot
60469f45ff
[tx-robot] updated from transifex
2021-06-07 03:59:09 +00:00
Nextcloud bot
d4c2991b9d
[tx-robot] updated from transifex
2021-06-06 04:00:46 +00:00
Nextcloud bot
38afea3353
[tx-robot] updated from transifex
2021-06-05 04:03:45 +00:00
Nextcloud bot
d06998a46b
[tx-robot] updated from transifex
2021-06-04 04:08:20 +00:00
Matthieu Gallien
62656b093a
Merge pull request #3368 from nextcloud/strugee-patch-1
...
Improve error message
2021-06-03 14:22:47 +02:00
AJ Jordan
a51d0a14db
Improve error message
...
This one is more user-friendly and grammatically correct.
Signed-off-by: AJ Jordan <alex@strugee.net >
2021-06-03 11:25:47 +00:00
Felix Weilbach
83498c30e2
Merge pull request #3380 from uusijani/patch-1
...
Document --background
2021-06-02 21:37:08 +02:00
Jani Uusitalo
f4b1ba45b8
Document --background
...
Fix [#3374 ](https://github.com/nextcloud/desktop/issues/3374 ).
Signed-off-by: Jani Uusitalo <jani@mummila.net >
2021-06-02 21:22:59 +03:00
allexzander
e4553252e0
Merge pull request #3393 from nextcloud/feature/unit-tests-for-isPathWindowsDrivePartitionRoot
...
Added unit tests for Utility::isPathWindowsDrivePartitionRoot.
2021-06-02 10:58:37 +03:00
allexzander
fe9f934277
Added unit tests for Utility::isPathWindowsDrivePartitionRoot.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-02 10:30:27 +03:00
Nextcloud bot
0944468ed9
[tx-robot] updated from transifex
2021-06-02 04:02:19 +00:00
allexzander
da586b719c
Merge pull request #3352 from nextcloud/bugfix/openssl-crash-when-no-e2ee-mnemonic
...
Bugfix. Crash when printing OpenSSL decryption errors with no e2ee mnemonic,
2021-06-01 17:48:03 +03:00
Matthieu Gallien
6b20092017
Merge pull request #3386 from nextcloud/ci/fixNeedsInfoHelperAction
...
fix needs info label remover action by providing github token
2021-06-01 16:17:16 +02:00
allexzander
bf39f053c4
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-01 13:51:02 +00:00
allexzander
a80c58f367
Bugfix. Crash when printing OpenSSL decryption errors with no e2ee mnemonic.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-06-01 13:51:02 +00:00
Matthieu Gallien
8b98dfcabb
fix needs info label remover action by providing github token
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-06-01 09:35:19 +02:00
Nextcloud bot
65a92e746a
[tx-robot] updated from transifex
2021-06-01 04:02:08 +00:00
Nextcloud bot
8abd4ce948
[tx-robot] updated from transifex
2021-05-30 04:00:14 +00:00
Nextcloud bot
5ef031d219
[tx-robot] updated from transifex
2021-05-29 04:16:47 +00:00
Nextcloud bot
7286e71c3a
[tx-robot] updated from transifex
2021-05-28 04:03:59 +00:00
Matthieu Gallien
b07f855976
Merge pull request #3341 from nextcloud/ci/needsInfoHelper
...
automate removal of needs info labels when the issue is commented
2021-05-27 10:16:13 +02:00
Matthieu Gallien
dbeba16919
ensure we do not remove needs info label when stale bot comment
...
we could have an issue with bug and needs info label
when it is detected as staled by the bot, a comment is added
we should ensure that the automated comment is not taken as answer to
the needs info
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-05-27 08:06:53 +00:00
Matthieu Gallien
a9aef22acb
remove use of checkout action as per review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-05-27 08:06:53 +00:00
Matthieu Gallien
b327522670
automate removal of needs info labels when the issue is commented
...
should help handling needs info label in a more efficient way
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-27 08:06:53 +00:00
Matthieu Gallien
e0b1ff95e4
Merge pull request #3364 from nextcloud/ci/needsInfoStaleBotConflicts
...
use a specific stale label for needs info handling to solve conflict
2021-05-27 10:04:20 +02:00
Matthieu Gallien
92146b0c8d
use a specific stale label for needs info handling to solve conflict
...
each stale bot needs to have its own stale label such that it does not
remove the label added by the other bot
that can happen due to needs info bot removing stale label on issues
that have both bug and needs info labels
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com >
2021-05-27 07:46:59 +00:00
Matthieu Gallien
a807263ce3
Merge pull request #3346 from nextcloud/bugfix/e2ee-warning-vfs-dialog
...
Set button on QMessageBox before changing the text
2021-05-27 09:45:13 +02:00
Felix Weilbach
03610cb706
Set button on QMessageBox before changing the text
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-27 07:39:50 +00:00
Matthieu Gallien
ba5f517417
Merge pull request #3338 from nextcloud/bug/checkPublicPrivateKey
...
check e2ee public key against private one
2021-05-27 09:38:12 +02:00
Matthieu Gallien
7fb09a8163
check e2ee public key against private one
...
should ensure we have matching private/public keys
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-27 07:26:48 +00:00
Nextcloud bot
2c1644e676
[tx-robot] updated from transifex
2021-05-27 04:01:51 +00:00
Felix Weilbach
d3e07e8f57
Merge pull request #3344 from nextcloud/bugfix/remove-obsolete-add-app-icon-macro
...
Remove obsolete AddAppIconMacro
2021-05-26 11:10:31 +02:00
Felix Weilbach
cf616abc46
Remove obsolete AddAppIconMacro
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-26 08:54:12 +00:00
Matthieu Gallien
f171eec278
Merge pull request #3330 from nextcloud/ci/updateQtVersionsInCi
...
update most docker images to use Qt 5.12.10 in Drone
2021-05-26 10:49:18 +02:00
Matthieu Gallien
9144ece89d
update most docker images to use Qt 5.12.10 in Drone
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-26 08:18:35 +00:00
Nextcloud bot
01f432cf67
[tx-robot] updated from transifex
2021-05-26 04:05:48 +00:00
Camila
5d2cfd8429
Merge pull request #3182 from nextcloud/bugfix/user-status
...
Bugfix/user status
2021-05-25 09:45:05 +02:00
Camila
f758157973
Fix aligment emoji + message on Windows.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
8d2264e027
Display the user status emoji separated from the message.
...
It allows to align the emoji with the message.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
1cb7f63575
Remove signal refreshCurrentUserGui.
...
Use only QML property bindings to refresh the UI.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
46f7cd3884
User property isConnected instead of a invokable.
...
Remove unnecessary connection to refreshCurrentUserGui signal.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
1adde8d547
serverUserStatus => serverHasUserStatus.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
2caa9ccfc6
Add Q_UNREACHABLE() after switch statements in UserStatus.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
73da14040b
Rename ServerUserStatusRole to ServerHasUserStatusRole.
...
- serverHasUserStatus Q_PROPERTY is CONSTANT.
- Fix code style.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
828881d82a
Do not display the folder status if there are no folders being synced.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:53 +00:00
Camila
4326eb53ba
Fix margins and sizes to align both avatar + user status displays.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
dc01b76066
Fix code style.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
93227ab08b
Check if new value is different from the current one.
...
In AccountState::setDesktopNotificationsAllowed.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
f7e9e31bc9
Rename isDesktopNotificationsAllowed property to desktopNotificationsAllowed.
...
- User !== instead of !=.
- Fix code style.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
820e97cd9b
Do not display the user status if there is no pre defined message.
...
Display the server url instead.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
c793cbe593
Always display the server url in the drop down account menu.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
419595ce5e
Use DesktopNotificationsAllowedRole to check if user is online.
...
Rename ServerUserStatus to ServerUserStatusRole.
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
bd65eee278
Remove unused methods in UserModel.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
671b099c98
Check if the user is connected and if the server supports user status.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
e3b96ddc85
Move stringToEnum and enumToString to an anonymous namespace.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Camila
1f61d258bb
Fix user status message alignment.
...
Signed-off-by: Camila <hello@camila.codes >
2021-05-25 06:55:52 +00:00
Nextcloud bot
c684191a2d
[tx-robot] updated from transifex
2021-05-25 04:05:36 +00:00
Nextcloud bot
755d672476
[tx-robot] updated from transifex
2021-05-24 03:58:58 +00:00
Nextcloud bot
e59413edc3
[tx-robot] updated from transifex
2021-05-23 04:00:59 +00:00
Nextcloud bot
97103da677
[tx-robot] updated from transifex
2021-05-22 04:04:35 +00:00
Nextcloud bot
30b7803661
[tx-robot] updated from transifex
2021-05-21 04:07:09 +00:00
rakekniven
de07319ec6
Merge pull request #3279 from nextcloud/Valdnet-patch-3
...
l10n: Replace apostrophe with double quotation
2021-05-20 08:04:54 +02:00
rakekniven
793c211232
Merge branch 'master' into Valdnet-patch-3
2021-05-20 07:47:17 +02:00
Nextcloud bot
b4a655124b
[tx-robot] updated from transifex
2021-05-20 04:18:16 +00:00
Felix Weilbach
3ec2ac3a5f
Merge pull request #3257 from nextcloud/feature/store-last-sync-run
...
Track time of last sync
2021-05-19 10:01:43 +02:00
Felix Weilbach
78f1943d76
Add a key value store to the sync journal
...
This key value store should help to keep track of important events,
that can not be store in the logs, because the logs are deleted too fast.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-19 09:04:43 +02:00
Nextcloud bot
4f915e9b53
[tx-robot] updated from transifex
2021-05-19 04:19:03 +00:00
Matthieu Gallien
79e6459bd1
Merge pull request #3183 from nextcloud/bugfix/warn-if-e2ee-with-vfs
...
Warn user if using e2ee and vfs together
2021-05-18 14:08:53 +02:00
Felix Weilbach
32b7e62359
Warn user if using e2ee and vfs together
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-18 11:50:18 +00:00
Matthieu Gallien
701e106aa3
Merge pull request #3286 from Dimon4eg/use_folders_in_cmake
...
use folders in CMake
2021-05-18 12:17:37 +02:00
Dmytro Korchynskyi
8b6b3023ea
use folders in CMake
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com >
2021-05-18 09:59:17 +03:00
Nextcloud bot
9a43755daa
[tx-robot] updated from transifex
2021-05-18 04:01:01 +00:00
allexzander
cdadb00cc8
Merge pull request #3311 from nextcloud/bugfix/rename-issue-for-custom-sync-root
...
Add remote folder prefix for renaming in a non-root local folder.
2021-05-17 15:25:57 +03:00
allexzander
76be5dce73
Add remote folder prefix for renaming in a non-root local folder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-17 12:19:58 +00:00
Felix Weilbach
47ec726cae
Merge pull request #3171 from nextcloud/feature/enable-addr-sanitizer
...
Enable address sanitizer
2021-05-17 13:58:01 +02:00
Felix Weilbach
e2d0481c64
Add CMake option to enable address sanitizers
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-17 11:43:55 +00:00
Matthieu Gallien
31179131f2
Merge pull request #3308 from nextcloud/ci/upgradeSqlite
...
upgrade SQLite3 to 3.35.5
2021-05-17 11:58:16 +02:00
Matthieu Gallien
89be02f8e7
upgrade SQLite3 to 3.35.5
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-17 09:48:15 +00:00
Nextcloud bot
c0bf12ec26
[tx-robot] updated from transifex
2021-05-17 03:59:33 +00:00
Nextcloud bot
a2b4cfe355
[tx-robot] updated from transifex
2021-05-16 04:02:19 +00:00
Nextcloud bot
5210ad8bdc
[tx-robot] updated from transifex
2021-05-14 03:53:16 +00:00
Nextcloud bot
dc8502e47d
[tx-robot] updated from transifex
2021-05-13 03:50:15 +00:00
Valdnet
a3b2dc669c
One more apostrophe change
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-05-12 12:45:33 +02:00
Valdnet
dadddd7ea2
l10n: Replace apostrophe with double quotation
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-05-12 12:34:22 +02:00
Felix Weilbach
96c80487a4
Merge pull request #3299 from nextcloud/bugfix/remove-unnecessary-cfapi-logging
...
Remove unnecessary cfapi logging statements
2021-05-12 11:54:58 +02:00
Felix Weilbach
c3a2587a91
Remove unnecessary cfapi logging statements
...
For big files that can add a lot lines to the log files.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-12 08:49:13 +00:00
Nextcloud bot
c528a41389
[tx-robot] updated from transifex
2021-05-12 03:54:55 +00:00
Matthieu Gallien
e4de8c5a46
Merge pull request #3304 from nextcloud/CI/needsInfoStaleBot
...
add a stale bot to help manage needs info issues
2021-05-11 18:42:54 +02:00
Matthieu Gallien
3d247ad9e3
add a stale bot to help manage needs info issues
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-11 16:32:59 +00:00
allexzander
00eca1260e
Merge pull request #3290 from nextcloud/bugfix/block-vfs-on-windows-partition-root
...
Temporary! Windows. VFS. Block Virtual Files for partition root sync folders.
2021-05-11 19:04:37 +03:00
allexzander
bbf11d7e7a
Temporary! Windows. VFS. Block Virtual Files for partition root sync folders.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-11 18:53:35 +03:00
Nextcloud bot
4f7cbee64d
[tx-robot] updated from transifex
2021-05-11 03:54:30 +00:00
Matthieu Gallien
a107d7e5dd
Merge pull request #3297 from nextcloud/updateCopyrightNotice
...
also update ownCloud years interval in copyright notice
2021-05-10 13:38:35 +02:00
Matthieu Gallien
54d91cdd7b
also update ownCloud years interval in copyright notice
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-10 10:29:22 +00:00
Matthieu Gallien
131ab55673
Merge pull request #3272 from nextcloud/ci/staleBotMoreOften
...
Ci/stale bot more often
2021-05-10 09:53:19 +02:00
Matthieu Gallien
8d12dfe63d
add a message when bot close a staled issue
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-10 07:22:29 +00:00
Matthieu Gallien
60ccc3cb6f
run every 8 hours the stale bot to provide faster reaction to changes
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-10 07:22:29 +00:00
Nextcloud bot
21e607da57
[tx-robot] updated from transifex
2021-05-10 04:06:15 +00:00
Nextcloud bot
34a25a4e02
[tx-robot] updated from transifex
2021-05-09 03:54:21 +00:00
Nextcloud bot
e0dd06b978
[tx-robot] updated from transifex
2021-05-08 03:56:52 +00:00
Felix Weilbach
85df5d35cb
Merge pull request #3285 from nextcloud/feature/git-ignore-convert-exe
...
Git ignore convert.exe and .dir-locals.el
2021-05-07 12:28:04 +02:00
Felix Weilbach
690bc199c6
Git ignore convert.exe and .dir-locals.el
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-07 12:17:42 +02:00
Nextcloud bot
3ee831884f
[tx-robot] updated from transifex
2021-05-07 04:00:14 +00:00
Matthieu Gallien
05543d8b87
Merge pull request #3267 from nextcloud/feature/autoUpdatePlatforms
...
send OS name and version to auto updater to allow selective upgrades
2021-05-06 12:13:48 +02:00
Matthieu Gallien
86dda5675f
send OS name and version to auto updater to allow selective upgrades
...
in order to be able to suuport legacy OS, also sends the OS name and
version
will be used to detect Windows 8.1 and similar legacy versions
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 09:32:09 +00:00
Matthieu Gallien
8f7646d93f
Merge pull request #3260 from nextcloud/fix/cherryPickFixes
...
Fix/cherry pick fixes
2021-05-06 09:55:04 +02:00
Hannah von Reth
17a1a630a4
Use the http logger with the unittests
...
This allow better debugging of the tests
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
bff386e5c1
Fix int uint warning
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
98655ef28b
Fix warning by using qsizetype instead of size_t
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
ea3d78aecf
Fix warning by using QByteArrayLiteral
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
e04c6abcd5
Fix placeholder detection for cfapi
...
Fixes : #8326
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
Hannah von Reth
adb56178b9
GetLastError() needs to be called when the error happens
...
qDebug might clear it already
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-06 07:35:59 +00:00
allexzander
539b45a346
Merge pull request #3246 from nextcloud/bugfix/vfs-allow-dyhadration-of-readonly-files
...
VFS. Allow dehydartion of readonly files. Preserve 'readonly' flag when creating a placeholder.
2021-05-06 09:26:17 +03:00
allexzander
d754bb7102
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-06 06:17:36 +00:00
allexzander
ef89256d39
VFS. Allow dehydartion of readonly files. Preserve 'readonly' flag when creating a placeholder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-06 06:17:36 +00:00
Nextcloud bot
49e68d7234
[tx-robot] updated from transifex
2021-05-06 04:00:08 +00:00
allexzander
f66add825d
Merge pull request #3239 from nextcloud/bugfix/vfs-local-name-clash-error
...
VFS. Display local file name clash error when syncing in VFS mode.
2021-05-05 20:43:40 +03:00
allexzander
19522210ac
VFS. Display local file name clash error when syncing in VFS mode.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-05-05 17:34:59 +00:00
Matthieu Gallien
361bd6fdb4
Merge pull request #3265 from nextcloud/rakekniven-patch-1
...
Changed copyright year to 2021
2021-05-05 14:56:43 +02:00
rakekniven
6d23e93d31
Changed copyright year to 2021
...
Fix for #3258
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com >
2021-05-05 13:37:31 +02:00
Felix Weilbach
6d22da9a4b
Merge pull request #3263 from nextcloud/bugfix/dont-crash-if-screen-under-pointer-not-found
...
Fallback to primary screen if screen under pointer not found
2021-05-05 12:10:10 +02:00
Felix Weilbach
aadee15008
Fallback to primary screen if screen under pointer not found
...
Fixes #3252
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-05 11:56:46 +02:00
Matthieu Gallien
8716877e61
Merge pull request #3261 from nextcloud/ci/staleBot
...
increase number of operations per run to go through old issues
2021-05-05 11:45:21 +02:00
Matthieu Gallien
1e267f1781
increase number of operations per run to go through old issues
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-05 11:20:08 +02:00
Nextcloud bot
3062595022
[tx-robot] updated from transifex
2021-05-05 04:08:32 +00:00
Felix Weilbach
0bf725be3a
Merge pull request #3255 from nextcloud/bug/fixMissingTranslation
...
add missing call to tr to get a translated string
2021-05-04 12:44:15 +02:00
Matthieu Gallien
23ba193102
add missing call to tr to get a translated string
...
Fix #3250
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-05-04 12:16:10 +02:00
Felix Weilbach
c37a4a6452
Merge pull request #3193 from nextcloud/bugfix/pn-reconnect-forever-if-possible
...
Push notifications: reconnect forever if possible
2021-05-04 10:17:37 +02:00
Felix Weilbach
7112d2aa78
Push Notifications: Reconnect forever if capabilities allow it
...
Fixes #3115
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-04 10:05:19 +02:00
Felix Weilbach
aea867c445
Refactor push notification tests
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-04 07:27:06 +00:00
Felix Weilbach
d21df33a50
Add missing copyright headers for push notifications
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-05-04 07:27:06 +00:00
Nextcloud bot
9372b6827c
[tx-robot] updated from transifex
2021-05-04 03:57:20 +00:00
Nextcloud bot
b27c9ae9bc
[tx-robot] updated from transifex
2021-05-03 03:55:12 +00:00
Nextcloud bot
9b0c57cdea
[tx-robot] updated from transifex
2021-05-02 03:54:12 +00:00
Nextcloud bot
cee697e781
[tx-robot] updated from transifex
2021-05-01 03:58:05 +00:00
rakekniven
0d5e4a1ba2
Merge pull request #3241 from nextcloud/rakekniven-patch-2
...
No need to translate ellipsis
2021-04-30 14:50:28 +02:00
rakekniven
33ef3a1d1e
Merge branch 'master' into rakekniven-patch-2
2021-04-30 14:38:23 +02:00
rakekniven
ecd88832b8
Merge pull request #3242 from nextcloud/Valdnet-patch-3
...
l10n: Translation of ellipse
2021-04-30 14:37:56 +02:00
Valdnet
dc6518a4ee
l10n: Translation of ellipse
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-30 13:57:02 +02:00
rakekniven
0e12b0323e
No need to translate ellipsis
...
Here another PR for the same code line as #3238
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com >
2021-04-30 13:27:18 +02:00
Felix Weilbach
a97c083c98
Merge pull request #3238 from nextcloud/Valdnet-patch-3
...
l10n: Change to an ellipsis
2021-04-30 11:07:06 +02:00
Valdnet
f431649bad
l10n: Change to an ellipsis
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-30 08:19:25 +00:00
Matthieu Gallien
741c2f0bd3
Merge pull request #3233 from nextcloud/doc/updateDocumentationVersion
...
update version of documentation to the latest release (v3.2.1)
2021-04-30 10:07:14 +02:00
Matthieu Gallien
55f91e2cb7
update version of documentation to the latest release (v3.2.1)
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-30 07:28:58 +00:00
Nextcloud bot
e973dd8c39
[tx-robot] updated from transifex
2021-04-30 03:59:29 +00:00
allexzander
14843b7a62
Merge pull request #3186 from nextcloud/feature/share-obey-enforced-password-for-share-by-mail
...
Obey enforced password for share by email.
2021-04-29 11:21:24 +03:00
allexzander
e72013fed1
Fix Felix's comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:21 +00:00
allexzander
19e2d70c53
Final corrections and refactoring.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:21 +00:00
allexzander
deb9ba89f0
Only show password option for email shares.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:21 +00:00
allexzander
526fa399dc
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
allexzander
c908183044
Use separate progress indicator for password and replace a button with it while running.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
allexzander
0072d39ca0
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
allexzander
2d88fc6c99
Obey enforced password for share by email.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-29 07:43:20 +00:00
Nextcloud bot
a4bad72c57
[tx-robot] updated from transifex
2021-04-29 03:59:40 +00:00
Felix Weilbach
2234aa4387
Merge pull request #3218 from nextcloud/Valdnet-patch-3
...
l10n: Delete space and capital letter
2021-04-28 13:48:13 +02:00
Valdnet
8aedc74838
l10n: Delete space and change capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-28 11:41:06 +00:00
Felix Weilbach
d7b6ff2841
Merge pull request #3220 from nextcloud/feature/feature-req-template
...
Add separate GitHub templates for features and issues
2021-04-28 13:36:23 +02:00
Felix Weilbach
7cbea48a53
Add separate GitHub templates for features and issues
...
Additionally, this commit adds functionality to label automatically
feature and bug reports.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-28 10:34:29 +00:00
Nextcloud bot
314ab62804
[tx-robot] updated from transifex
2021-04-28 03:57:45 +00:00
Camila
864313d588
Merge pull request #3185 from HouraisanNEET/patch-1
...
Update installing.rst
2021-04-27 19:33:08 +02:00
HouraisanNEET
20a2c42963
Update installing.rst
...
Signed-off-by: HouraisanNEET <HouraisanNEET@users.noreply.github.com >
2021-04-27 17:20:54 +00:00
allexzander
98b1203856
Merge pull request #3178 from nextcloud/bugfix/improve-public-link-sharing-dialog
...
Improve public link sharing dialog
2021-04-27 14:15:27 +03:00
allexzander
e7e5542d3e
Improve public link sharing UI. Fix UX issues.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-27 13:51:52 +03:00
Nextcloud bot
2406b356c7
[tx-robot] updated from transifex
2021-04-27 03:59:28 +00:00
Matthieu Gallien
6cf1f7f9f2
Merge pull request #3214 from nextcloud/doc/updateNews
...
update the news part of documentation with improvements from 3.2 release
2021-04-26 21:07:12 +02:00
Matthieu Gallien
c2b36981fa
update the versions and date used in the doc generation
...
should no longer be necessary when this will come from cmake until that,
let's update it
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 16:37:13 +02:00
Matthieu Gallien
0aca5d616c
update the news part of documentation with improvements from 3.2 release
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 16:37:13 +02:00
Felix Weilbach
5ea16ffb3b
Merge pull request #3132 from yopito/fix/clang-variadic-macro-warning-only-for-clang
...
clang's variadic macro warnings: only for clang
2021-04-26 16:02:21 +02:00
yopito
14d61c5071
clang's variadic macro warnings: only for clang
...
following settings of cmake/modules/Warnings.cmake
Signed-off-by: yopito <pierre.bourgin@free.fr >
2021-04-26 13:22:41 +00:00
Felix Weilbach
384aeb513b
Merge pull request #3192 from nextcloud/bugfix/call-finish-if-remove-all-files
...
Call finish() if going to remove all files
2021-04-26 15:21:29 +02:00
Felix Weilbach
9a88e38121
Call finish() if going to remove all files
...
While investigating #3172 , I discoverd that the sync will hang forever
if the user has deleted all files on the server. Calling the callback
resolves the problem.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-26 12:50:14 +00:00
Matthieu Gallien
e9b3144e1a
Merge pull request #3170 from nextcloud/bug/fixVfsStatusDelay
...
status wrong for directories when using vfs and nextcloud desktop 3.2.0
2021-04-26 14:12:23 +02:00
Matthieu Gallien
419bd93dea
when files get hydrated indirectly through pinning, sets correct state
...
files that get downloaded not through an hydration request need to be
converted to placeholder
sets the expected state when converting them to placeholder files
#3082
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 13:54:32 +02:00
Matthieu Gallien
929ae965ce
prevent progress bar to appear after a download is finished with CfApi
...
when using Cloud Filter API with enabled VFS on Windows, a progress bar
stays visible for some time after hydration is completed. Not updating a
last time the progress bar prevents that.
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 13:54:32 +02:00
Matthieu Gallien
9453bcab59
Merge pull request #3209 from nextcloud/doc/serverCompatibility
...
add info in the installation page about the supported server versions
2021-04-26 13:19:25 +02:00
Matthieu Gallien
734d403a82
add info in the installation page about the supported server versions
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 13:18:34 +02:00
Matthieu Gallien
74b5ca3e8e
Merge pull request #3187 from nextcloud/bugfix/fixCfRegisterSyncRoot
...
fix errors when calling CfRegisterSyncRoot by setting more fields
2021-04-26 13:13:01 +02:00
Matthieu Gallien
97d785f1bb
fix errors when calling CfRegisterSyncRoot by setting more fields
...
sets a reasonable size of the StructSize members in the struct passed to
CfRegisterSyncRoot function
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-26 08:02:40 +00:00
Matthieu Gallien
5404c8cd2a
Merge pull request #3154 from q-wertz/update-client-integration-linux
...
Update Linux file manager integration
2021-04-26 09:27:53 +02:00
Clemens Sonnleitner
5e0385381f
Updated the description on file manager integration on Linux
...
Signed-off-by: Clemens Sonnleitner <clemens.sonnleitner@web.de >
2021-04-26 07:03:50 +00:00
Nextcloud bot
313d6d5bcf
[tx-robot] updated from transifex
2021-04-26 03:56:53 +00:00
Nextcloud bot
fb06b4743e
[tx-robot] updated from transifex
2021-04-25 03:58:29 +00:00
Nextcloud bot
82bf3ee0f6
[tx-robot] updated from transifex
2021-04-24 03:58:34 +00:00
Felix Weilbach
802be220ae
Merge pull request #3048 from nextcloud/linux-display-name
...
Use More Concise Display Name on Linux
2021-04-23 14:56:22 +02:00
Elsie Hupp
ce20aa36a2
Use concise display name
...
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com >
2021-04-23 12:20:35 +00:00
Nextcloud bot
fadc12996a
[tx-robot] updated from transifex
2021-04-23 03:58:40 +00:00
Felix Weilbach
bdebce7114
Merge pull request #3184 from nextcloud/featuer/add-pr-template
...
Add pull request template
2021-04-22 15:52:24 +02:00
Felix Weilbach
a9d05b3eca
Add pull request template
...
I'm tierd of telling people to signoff their work:)
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-22 15:02:44 +02:00
Felix Weilbach
52bb707d54
Merge pull request #3179 from nextcloud/Valdnet-patch-2
...
l10n: Change to an ellipsis
2021-04-22 09:46:34 +02:00
Valdnet
796b4e4e72
l10n: Change to an ellipsis
...
Reported on Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com >
2021-04-22 07:40:15 +00:00
Nextcloud bot
811d54fd24
[tx-robot] updated from transifex
2021-04-22 03:56:47 +00:00
Nextcloud bot
2240452804
[tx-robot] updated from transifex
2021-04-21 11:25:21 +00:00
Matthieu Gallien
b3daa9b8ab
Merge pull request #3174 from nextcloud/bug/avoidAssertEmptyDateHeader
...
avoid an assert by delaying access to response timestamp when in error
2021-04-21 09:22:31 +02:00
Matthieu Gallien
782a2fdf06
avoid an assert by delaying access to response timestamp when in error
...
when canceling the sync of a big directory, I can get some network
request that are aborted before a Date reply header has been read
in this case we would always access
AbstractNetworkJob::responseTimestamp() and fire the assert even if we
know that the network reply has an error
delay the access to after the possible errors have been dealt with
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-20 17:42:17 +02:00
Felix Weilbach
596992c2ea
Merge pull request #3127 from nextcloud/feature/add-note-to-group-share
...
Add note to user and group share
2021-04-20 13:47:50 +02:00
Felix Weilbach
275e46f0db
Show progess indicator
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
c3fac23903
Don't delete note and expiration date on toggle
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
8711d5bf49
Don't use unnecessary layout element
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
2851528595
Show user/group note on share if already set
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
22a3b19e08
Add expire date to user and group share
...
Fixes #3100
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Felix Weilbach
946a51e4c1
Add note to user and group share
...
Fixes #3104
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-20 07:13:23 +00:00
Nextcloud bot
87f3073b87
[tx-robot] updated from transifex
2021-04-20 03:56:46 +00:00
Matthieu Gallien
20357ca7fa
Revert "Add CMake option to enable address sanitizers"
...
This reverts commit 3000e26640 .
This was not intended for a direct push
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-19 17:54:09 +02:00
Felix Weilbach
3000e26640
Add CMake option to enable address sanitizers
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-19 15:38:59 +02:00
allexzander
da0b03b01c
Merge pull request #3167 from nextcloud/bugfix/fix-documentation-markup-warnings
...
Documentation. Fix incorrect syntax warnings and incorrect indentation before the 'image' element.
2021-04-19 11:24:10 +03:00
allexzander
21d39dea87
Documentation. Fix incorrect syntax warnings and incorrect indentation before image elements.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-19 10:32:53 +03:00
allexzander
801a3ff9d4
Merge pull request #3136 from nextcloud/E2EE-and-VFS
...
E2EE and VFS
2021-04-19 09:32:30 +03:00
Jos Poortvliet
cd598a00f7
Documentation: E2EE and VFS
...
Describe the relation between E2EE and VFS.
Signed-off-by: Jos Poortvliet <jospoortvliet@gmail.com >
2021-04-19 09:24:11 +03:00
Nextcloud bot
41bf68bc9c
[tx-robot] updated from transifex
2021-04-19 03:59:18 +00:00
Nextcloud bot
58992b0010
[tx-robot] updated from transifex
2021-04-18 03:53:09 +00:00
Nextcloud bot
f584971423
[tx-robot] updated from transifex
2021-04-17 03:55:03 +00:00
allexzander
66b625abdc
Merge pull request #3146 from nextcloud/bugfix/fix-incorrect-image-elements
...
Documentation. Fix incorrect format usage for images and subheaders.
2021-04-16 17:16:47 +03:00
allexzander
4fad07179d
Documentation. Fix incorrect subheader format.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-16 14:04:28 +00:00
allexzander
988e928d74
Documentation. Fix incorrect image elements.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-16 14:04:28 +00:00
allexzander
7d9d75e90a
Merge pull request #3150 from nextcloud/bugfix/vfs-documentation-show-experimental
...
Documentation: Correct option to enable virtual files on Linux/macOS
2021-04-16 17:02:54 +03:00
Felix Weilbach
315fdb0be8
Documentation: Correct option to enable virtual files on Linux/macOS
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-16 15:27:48 +02:00
allexzander
218e69e510
Merge pull request #3125 from nextcloud/bugfix/windows-navigation-panel-display-vfs-sync-folder
...
Display VFS sync folder within the navigation panel on Windows.
2021-04-16 10:43:24 +03:00
allexzander
d65c91ea36
Display VFS sync folder within the navigation panel on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-16 07:18:44 +00:00
Nextcloud bot
1374966567
[tx-robot] updated from transifex
2021-04-16 03:59:43 +00:00
Felix Weilbach
f77723e3a7
Merge pull request #3111 from nicolasfella/sharedmimeinfo
...
Copy FindSharedMimeInfo from ECM
2021-04-15 16:46:55 +02:00
Nicolas Fella
2548455f45
Copy FindSharedMimeInfo from ECM
...
Instead of relying on ECM being installed.
We copy other stuff from ECM so be consistent.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-15 14:32:46 +00:00
Felix Weilbach
8e3ddcc79c
Merge pull request #3133 from nicolasfella/cmaketest
...
Remove redundant CMake code
2021-04-15 16:31:34 +02:00
Nicolas Fella
2ad03d96ac
Remove redundant CMake code
...
The same is done somewhere below
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-15 14:13:36 +00:00
allexzander
63a02a988f
Merge pull request #3138 from nextcloud/feature/windows-msi-force-minimum-supported-os
...
Windows MSI. Do not allow installing Nextcloud client on < Windows 10 or < 1709
2021-04-15 14:35:00 +03:00
allexzander
c88e76a4a9
Minimum supported Windows 10, build 1709.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-15 13:47:37 +03:00
Felix Weilbach
a74d9ec516
Merge pull request #3124 from nextcloud/bugfix/cmake-require-sqlite-only-on-unix
...
CMake: Require sqlite3 only on Unix
2021-04-15 09:04:14 +02:00
Felix Weilbach
da1e5c448a
CMake: Use own SQLite3 on macOS and Windows
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-15 08:51:06 +02:00
Nextcloud bot
89677fe22f
[tx-robot] updated from transifex
2021-04-15 03:57:09 +00:00
rakekniven
0fa95bdfb1
Merge pull request #3121 from castillo92/patch-1
...
Update sharedialog.cpp
2021-04-14 20:39:03 +02:00
rakekniven
03e7d8da28
Merge branch 'master' into patch-1
2021-04-14 17:11:27 +02:00
Nicolas Fella
b1fc7d4b52
Merge pull request #3112 from nicolasfella/threads
...
Use imported target for Threads
2021-04-14 13:17:22 +02:00
Nicolas Fella
70033cda1f
Use imported target for Threads
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-14 11:07:04 +00:00
Felix Weilbach
71658b0974
Merge pull request #3119 from nextcloud/feature/cmake-add-feature-summary
...
Add feature summary to CMake
2021-04-14 10:23:59 +02:00
Felix Weilbach
f3eed2ad1e
Add feature summary to CMake
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-14 09:51:31 +02:00
castillo92
98a4bb8cce
Update sharedialog.cpp
...
The original sentence uses the word "share" three times and is too redundant when translated into other languages
2021-04-14 09:24:35 +02:00
allexzander
a5330aeb24
Merge pull request #3046 from nextcloud/bugfix/msi-do-not-reboot-silent-installation
...
Do not schedule reboot when installing MSI in silent mode unless 'SCHEDULE_REBOOT is set.
2021-04-14 10:17:19 +03:00
allexzander
7d2ab1f3fe
Do not schedule reboot when installing MSI in silent mode unless 'SCHEDULE_REBOOT' is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-14 06:59:21 +00:00
allexzander
32dd91e650
Merge pull request #3066 from nextcloud/bugfix/temporary-solution-for-file-restoration-via-datafingerprint
...
Temporary solution for file restoration issue due to failing the data…
2021-04-14 09:49:57 +03:00
allexzander
bc919bcc8c
Temporary solution for file restoration issue due to failing the dataFingerprint on client.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-14 06:42:48 +00:00
Nextcloud bot
0e6e240f09
[tx-robot] updated from transifex
2021-04-14 03:59:35 +00:00
Felix Weilbach
43cae72d4d
Merge pull request #3022 from nextcloud/feature/display-invalid-filenames-as-warning
...
Display invalid filenames as warning
2021-04-13 17:35:43 +02:00
Felix Weilbach
696979cb0e
Display invalid filenames as warning
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 14:58:51 +00:00
Felix Weilbach
b736355985
Add notification cache
...
The notification cache helps to not display duplicate desktop
notifications to the user.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 14:58:50 +00:00
Felix Weilbach
9c4a9958f7
Merge pull request #3031 from nextcloud/feature/push-notifications-ping-server
...
Push notifications: Ping server
2021-04-13 14:27:55 +02:00
Felix Weilbach
b256c6e694
Ping websocket server
...
This helps the client to recognize if the websocket server is still alive.
Fixes #2983
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 12:19:40 +00:00
Felix Weilbach
d7499b0746
Refactor push notification test utils
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 12:19:40 +00:00
Nicolas Fella
c49be218ec
Merge pull request #3092 from nextcloud/cloudproviders2
...
Only include libcloudproviders dir when cloudproviders is found
2021-04-13 13:38:03 +02:00
Nicolas Fella
b8879dbf07
Only include libcloudproviders dir when cloudproviders is found
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-13 11:29:29 +00:00
Nicolas Fella
478ca784b1
Merge pull request #3093 from nicolasfella/dolphin2
...
[shellintegration] Simplify cmake code
2021-04-13 13:28:04 +02:00
Nicolas Fella
df3ebb11f6
[shellintegration] Simplify cmake code
...
We don't need ECM to check for KIO
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-13 11:22:19 +00:00
Valdnet
e2ad407259
Merge pull request #3087 from nextcloud/Valdnet-patch-2
...
l10n: Unify spelling
2021-04-13 12:42:25 +02:00
Valdnet
e628a51735
l10n: Unify spelling
...
Spelling unification in Nextcloud applications.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-13 12:24:57 +02:00
allexzander
909248f058
Merge pull request #3089 from nextcloud/feature/add-vfs-and-status-feature-doc
...
Added documentation for VFS and Status Feature.
2021-04-13 12:38:17 +03:00
allexzander
b4d01afd86
Added documentation for VFS and Status Feature.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-13 10:18:27 +03:00
Felix Weilbach
f882dee8dc
Merge pull request #3059 from nextcloud/inotify
...
Improve Inotify cmake code
2021-04-13 08:46:54 +02:00
Nicolas Fella
3bc66bea66
Improve Inotify cmake code
...
Use the FindInotify from ECM. It handles the case of Linux vs BSD
correctly automatically.
Also only find Inotify on Linux and BSD
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-13 06:36:14 +00:00
Nextcloud bot
f119e4cf64
[tx-robot] updated from transifex
2021-04-13 03:56:05 +00:00
Matthieu Gallien
8102d51b99
Merge pull request #3065 from nicolasfella/dolphincmake
...
[dolphin] Clean up CMake code
2021-04-12 16:22:18 +02:00
Nicolas Fella
e207cfdbfc
[dolphin] Clean up CMake code
...
Remove some stuff that is not needed.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-12 13:27:46 +00:00
Matthieu Gallien
a1f78c4330
Merge pull request #3003 from nextcloud/fix-and-comment-default-build-type
...
Remove non-functional default CMAKE_BUILD_TYPE
2021-04-12 14:16:44 +02:00
Elsie Hupp
1183b3f7b9
Remove non-functional default CMAKE_BUILD_TYPE
...
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com >
2021-04-12 11:26:08 +00:00
Felix Weilbach
efdd46fb6d
Merge pull request #3058 from nicolasfella/cloudproviders
...
Use FindPkgConfig to find libcloudproviders and related libs
2021-04-12 13:15:38 +02:00
Nicolas Fella
b34a901838
Use FindPkgConfig to find libcloudproviders and related libs
...
Instead of using custom find modules.
This allows using imported targets which make the code much nicer.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-04-12 10:00:08 +00:00
Nextcloud bot
e74746c4e7
[tx-robot] updated from transifex
2021-04-12 03:55:08 +00:00
Nextcloud bot
96c51faa9c
[tx-robot] updated from transifex
2021-04-11 03:53:37 +00:00
Nextcloud bot
c956a462e2
[tx-robot] updated from transifex
2021-04-10 04:06:36 +00:00
Felix Weilbach
4efe00feca
Merge pull request #3075 from nextcloud/bugfix/embed-version-info-win
...
Embed version and icon into windows executable
2021-04-09 14:29:46 +02:00
Felix Weilbach
c49dc440bb
Embed version and icon into windows executable
...
These changes are necessary because of changing the compilation
process for the gui from a single executable to static lib +
executable in commit 0521dce174 .
Otherwise the version and icon information will be lost.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-04-09 13:53:12 +02:00
Nextcloud bot
5e15f4f2c6
[tx-robot] updated from transifex
2021-04-09 03:55:46 +00:00
allexzander
b6371bf39b
Merge pull request #3073 from nextcloud/bump_version_to_3.2.5
...
Bump version to 3.2.50
2021-04-08 11:26:20 +03:00
allexzander
740e1d2f0d
Bump version to 3.2.50.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-08 11:09:49 +03:00
allexzander
5e6c31b262
Merge pull request #3072 from nextcloud/bump-version-3.2.0
...
Bump version to 3.2.0.
2021-04-08 10:47:24 +03:00
allexzander
8550bfa8f1
Bump version to 3.2.0.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-08 10:38:10 +03:00
allexzander
f6afb62a53
Merge pull request #3069 from nextcloud/feature/user-status
...
User status bug fixing...
2021-04-08 10:18:13 +03:00
Camila
1ca0ea49dd
Remove unnecessary local variable.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
29f4a3857b
Reposition qml elements for the folder status icon.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
050bd49373
Rename enumToUserString => enumToString.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
8986975a17
Use enum class instead of enum.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
50de12b3c3
Undo unnecessary removal of lines.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
163015492a
Fix #3067 : missing apps icon.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
c8ac99c8cf
Align status text with server url.
...
Cleans the space in the beginning of the string when there is no emoji
set.
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
e51dad79a2
Refactor UserStatus.
...
- Make preDefinedStatus a local var.
- Add function to get the status user string.
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
d2b762aa66
Move curly brackets to the correct line.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:59 +00:00
Camila
98cfc362f7
Remove const and reference of base types.
...
Signed-off-by: Camila <hello@camila.codes >
2021-04-08 07:10:58 +00:00
Nextcloud bot
835a61c5ee
[tx-robot] updated from transifex
2021-04-08 03:55:06 +00:00
allexzander
5eb6834167
Merge pull request #3057 from nextcloud/bugfix/vfs-windows-lnk-files-freeze-issue
...
Fix VFX Windows .lnk files freeze/crash issue
2021-04-07 12:28:05 +03:00
allexzander
4b58c2b7b7
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
82953d0601
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
de85b79bb8
Address review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
cb8b6ccd9b
Ignore *.lnk files on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
13f4bb541d
Treat .lnk files as normal files without hydrating them or creating a placeholder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
3906ae0922
Another way to fix this.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
7235c708dc
Added .lnk file placeholder creation fix.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
allexzander
d5b6d93978
Fix VFS freeze when syncing '.lnk' files on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-07 09:08:02 +00:00
Matthieu Gallien
4a7145f1f3
Merge pull request #3068 from nextcloud/bug/fixAssertEditIgnoredFiles
...
use QFileInfo to check if path is absolute to avoid assert on windows
2021-04-07 10:06:29 +02:00
Matthieu Gallien
d6752c96b1
use QFileInfo to check if path is absolute to avoid assert on windows
...
on windos absolute path does not have to start with / . Remove failing assert
when editing ignored files list.
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr >
2021-04-07 07:40:07 +00:00
Nextcloud bot
77681ff5b5
[tx-robot] updated from transifex
2021-04-07 03:55:50 +00:00
allexzander
4c8378030d
Merge pull request #3061 from nextcloud/bugfix/vfs-syncroot-reg-params-non-temp
...
Create std::wstrings out of const wchar_t* so a copy is created every time
2021-04-06 15:46:06 +03:00
allexzander
0a33e99053
Create std::wstrings out of const wchar_t* so a copy is created every time.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-06 10:03:22 +03:00
allexzander
454226b3ea
Merge pull request #3060 from nextcloud/bugfix/reduce-socketapi-logging
...
Reduce Socket API logging.
2021-04-06 09:49:21 +03:00
allexzander
e15045977e
Reduce Socket API logging.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-04-06 09:34:20 +03:00
Nextcloud bot
a599cd2c3f
[tx-robot] updated from transifex
2021-04-06 03:54:22 +00:00
Nextcloud bot
487f29cf80
[tx-robot] updated from transifex
2021-04-04 03:53:11 +00:00
Nextcloud bot
2268facd9d
[tx-robot] updated from transifex
2021-04-03 04:11:49 +00:00
Nextcloud bot
57aeeca172
[tx-robot] updated from transifex
2021-04-02 03:55:01 +00:00
Nextcloud bot
962bbf3043
[tx-robot] updated from transifex
2021-04-01 03:55:02 +00:00
Felix Weilbach
6e147a7a8c
Merge pull request #3052 from nextcloud/bugfix/remove-html-tags-from-notifications
...
Remove html tags from strings that may appear in notifications
2021-03-31 17:36:15 +02:00
Felix Weilbach
b2377ff64f
Remove html tags from strings that may appear in notifications
...
The content of notifications on MacOS are not allowed to contain HTML
tags in it. Linux (Free Desktop) notifications may contain HTML tags
in their content. However, it is optional that the notification daemon
interprets the tags. The GNOME notification daemon does not interpret
HTML tags and even does not strip them off. KDE's daemon interprets
the tags. For now I think it's the best solution to remove the HTML
tags. In the future we should fire a action if the user clicks on the
notification and react on it and open the link then. This should work
on all platforms. But as this change involves working with the native
MacOS api and I don't have hardware for that at the moment for that I
will postpone it.
Fixes #2200
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-31 16:23:42 +02:00
Camila
be6e0f26df
Merge pull request #3049 from nextcloud/bump-version-rc3
...
Bump version to 3.1.83.
2021-03-31 12:27:22 +02:00
Camila
8741f4386c
Bump version to 3.1.83.
...
Signed-off-by: Camila <hello@camila.codes >
2021-03-31 12:14:18 +02:00
Nextcloud bot
ac6b62e19d
[tx-robot] updated from transifex
2021-03-31 03:55:58 +00:00
Nextcloud bot
044b5a33e9
[tx-robot] updated from transifex
2021-03-30 03:51:17 +00:00
Felix Weilbach
dde9eb645e
Merge pull request #3040 from nextcloud/bugfix/macos-dont-deploy-bearer
...
Don't deploy bearer plugin on MacOS
2021-03-29 16:01:41 +02:00
Felix Weilbach
354f4c02ee
Don't deploy bearer plugin on MacOS
...
Fixes #2944 , #2237
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-29 13:46:07 +00:00
Camila
58dd076b2b
Merge pull request #3015 from nextcloud/bugfix/update-wizard-doc
...
Update documentation for the account wizard.
2021-03-29 14:51:59 +02:00
Felix Weilbach
7faa80c1e1
Update documentation for the account wizard
...
This update is necessary because of the following commit:
b5cf820b42
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-29 12:10:37 +00:00
Nextcloud bot
f7dd4bbf69
[tx-robot] updated from transifex
2021-03-29 03:52:25 +00:00
Nextcloud bot
a7ac7991b8
[tx-robot] updated from transifex
2021-03-28 03:51:07 +00:00
Nextcloud bot
8eb5ed07bf
[tx-robot] updated from transifex
2021-03-27 03:52:53 +00:00
allexzander
4ce2e79e90
Merge pull request #3043 from nextcloud/bugfix/vfs-syncroot-register-error
...
Fix VFS CfAPI Syncroot Register Error.
2021-03-27 02:44:13 +02:00
allexzander
28771b25e3
Fix VFS CfAPI Syncroot Register Error.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-27 02:41:24 +02:00
allexzander
ab128cc4aa
Revert "Merge pull request #3042 from nextcloud/temp-fix-vfs-failure-wow6432"
...
This reverts commit cafa475398 , reversing
changes made to 003e56f4e6 .
2021-03-26 22:25:31 +02:00
allexzander
cafa475398
Merge pull request #3042 from nextcloud/temp-fix-vfs-failure-wow6432
...
Temp fix for vfs failure.
2021-03-26 21:46:10 +02:00
allexzander
9d15334813
Temp fix for vfs failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-26 21:41:44 +02:00
Nextcloud bot
003e56f4e6
[tx-robot] updated from transifex
2021-03-26 03:54:34 +00:00
Nextcloud bot
99309ab33b
[tx-robot] updated from transifex
2021-03-25 03:54:25 +00:00
Camila
d91e24d77d
Merge pull request #3034 from nextcloud/bump-version
...
Bump version to 3.1.82.
2021-03-24 19:48:28 +01:00
Camila
1edc2cfd31
Bump version to 3.1.82.
...
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 19:47:01 +01:00
Camila
e8669ad4b6
Merge pull request #2505 from nextcloud/status-feature
...
Status feature.
2021-03-24 17:28:27 +01:00
Camila
9219926a74
Add checks in case userStatus is not available/fails on the server side.
...
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:42:26 +01:00
Camila
d9a0778e52
Add UserStatus enum with the pre defined status.
...
- User QHash to map status strings and Status enum.
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:41:31 +01:00
Camila
974e2fb718
Do not display notifications when user status is do not disturb.
...
- This information is retrieved from the notifications endpoint.
- Add icons for the different pre defined status.
- Make functions available to QML to decide which status icon to display.
- Display the user status icon on the avatar and
move the online/offline connection status to the folder icon.
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:40:05 +01:00
Camila
f4d8699db8
Add UserStatus class to retrieve the user status.
...
- AccountState controls UserStatus.
- Display user status in the system tray menu next to user's avatar.
Signed-off-by: Camila <hello@camila.codes >
2021-03-24 15:39:13 +01:00
Felix Weilbach
c29c011095
Merge pull request #3029 from nextcloud/Valdnet-patch-2
...
l10n: Change sync message
2021-03-24 15:03:22 +01:00
Valdnet
519dee9104
l10n: Change sync message #3027
2021-03-24 13:13:40 +00:00
allexzander
e3a26477a2
Merge pull request #2981 from nextcloud/vfs_win_progress_bar_refresh
...
Refresh Windows download dialog progress when hydrating a placeholder
2021-03-24 15:01:27 +02:00
allexzander
193e50311b
Refresh Windows download dialog progress when hydrating a placeholder
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-24 14:09:06 +02:00
Felix Weilbach
6a53491645
Merge pull request #3028 from nextcloud/bugfix/check-db-read-successful-on-hydration-canceled
...
Check reading from journal was successful before remove placeholder
2021-03-24 12:25:13 +01:00
Felix Weilbach
d78774f29e
Check reading from journal was successful before remove placeholder
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-24 10:51:50 +00:00
Nextcloud bot
4e420fcb5c
[tx-robot] updated from transifex
2021-03-24 03:52:27 +00:00
Felix Weilbach
22a9d18d3b
Merge pull request #3025 from nextcloud/bugfix/hidpi-scaling
...
Enable high dpi scaling on all platforms
2021-03-23 09:49:25 +01:00
Felix Weilbach
c296a93cee
Enable high dpi scaling on all platforms
...
Fixes #2295 , #1079 , #914
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-23 08:36:11 +00:00
Nextcloud bot
66ee5087f6
[tx-robot] updated from transifex
2021-03-23 03:51:35 +00:00
Felix Weilbach
4d921c8025
Merge pull request #3020 from nextcloud/feature/increase-file-removal-logging
...
Increase logging around file removal events
2021-03-22 09:01:42 +01:00
Felix Weilbach
b1983d7d19
Increase logging around file removal events
...
To better see what is going on when and if files are removed by the
client.
See also: #260 , #1433 , #2913
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-22 07:48:39 +00:00
Nextcloud bot
54c1ab8828
[tx-robot] updated from transifex
2021-03-22 03:51:08 +00:00
Nextcloud bot
3652251587
[tx-robot] updated from transifex
2021-03-21 03:47:05 +00:00
Nextcloud bot
9c4c7217a0
[tx-robot] updated from transifex
2021-03-20 03:49:45 +00:00
Nextcloud bot
b3d5b4983e
[tx-robot] updated from transifex
2021-03-19 03:49:45 +00:00
Felix Weilbach
278a6fd005
Merge pull request #3010 from nextcloud/feature/cfapi-handle-cancelation
...
CFAPI: Handle cancelation of hydration requests
2021-03-18 13:27:27 +01:00
Felix Weilbach
9bf5b5c7ba
CFAPI: Handle cancelation of hydration requests
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-18 10:43:48 +00:00
allexzander
6abb0b2184
Merge pull request #3016 from nextcloud/fix_for_win_createfile_long_path
...
Fix for Windows CreateFile long path
2021-03-18 12:34:22 +02:00
allexzander
5f0344abb2
Fix warnings in CfApiWrapper.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-18 12:07:07 +02:00
allexzander
3fde838bee
Fix for Windows long path issue.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-18 12:07:07 +02:00
Nextcloud bot
af654fb4ed
[tx-robot] updated from transifex
2021-03-18 03:52:32 +00:00
Felix Weilbach
2ab23e3b3c
Merge pull request #2990 from nextcloud/bugfix/fix-create-folder-dialog-crash
...
Fix crash when trying to open the folder creation dialog
2021-03-17 09:41:06 +01:00
Felix Weilbach
f4853da2ab
Fix crash when trying to open the folder creation dialog
...
The bug does seem to just appear in special compiler
constellations. We're unsure why this fix works. To better see if this
fix works or if crashes still occur, we added some logging.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-17 08:43:32 +01:00
Nextcloud bot
262f20a8f4
[tx-robot] updated from transifex
2021-03-17 03:49:13 +00:00
Felix Weilbach
96ded93597
Merge pull request #3009 from nextcloud/bugfix/check-not-for-productname
...
Don't check against product name if checking server version
2021-03-16 16:00:32 +01:00
Felix Weilbach
c0f09ae12c
Don't check against product name if checking server version
...
We should not rely on the product name because it is something the
user can change in the theming options on the server.
Fixes #3001
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-16 14:30:56 +00:00
Felix Weilbach
162dff9525
Merge pull request #2989 from nextcloud/bugfix/fix-appearance-login-dialog
...
Display the content of the login dialog correct
2021-03-16 14:59:33 +01:00
Felix Weilbach
ff7932bb54
Display the content of the login dialog correct
...
This adjustment is necessary because of the changes of the new account
wizard that were introduced with:
e0b7ef15b2
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-16 13:34:34 +00:00
Nextcloud bot
6d6da18f9a
[tx-robot] updated from transifex
2021-03-16 03:50:03 +00:00
allexzander
a92d300b7f
Merge pull request #2995 from nextcloud/repair_basic_auth_support
...
Repair basic auth support
2021-03-15 11:52:21 +02:00
Kevin Ottens
a6bcd3af46
Force basic auth on get authentication required error
...
If the get job got an authentication required error on the account url
(not davUrl! at that stage we always get auth error there), then it is
safe to assume basic auth is used on the server. It is then kind of
pointless to use any other auth mode they will necessarily fail. Only
basic auth will do the job so force it.
Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com >
2021-03-15 09:38:15 +00:00
Kevin Ottens
0d3459e85e
Introduce an empty auth type
...
This is necessary to be able to distinguish between "I decided on basic
by default" and "I didn't write any auth type". To make sure all the
jobs end up writing something we then implement the "I decided on basic
by default" in the slots connected to the job and we assert it in
checkAllDone()
Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com >
2021-03-15 09:38:15 +00:00
Kevin Ottens
7ad0208800
Finish cleaning up shibboleth
...
There were a couple of shibboleth related enums left, since that auth
method isn't supported anymore remove the code tied to those enums. It
was dead code anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com >
2021-03-15 09:38:15 +00:00
Nextcloud bot
a61d2d2dd0
[tx-robot] updated from transifex
2021-03-15 03:55:26 +00:00
Nextcloud bot
88a7285e5f
[tx-robot] updated from transifex
2021-03-14 03:48:03 +00:00
Nextcloud bot
6c194be02d
[tx-robot] updated from transifex
2021-03-13 03:47:03 +00:00
Felix Weilbach
aa9821f05f
Merge pull request #2999 from nextcloud/bugfix/fix-settings-dialog-on-dark-theme
...
Don't customize settings dialog palette
2021-03-12 15:22:15 +01:00
Felix Weilbach
cdc2e4c56e
Don't customize settings dialog palette
...
Customizing of the palette will prevent the settings dialog from
display a dark theme correct.
Fixes #2993
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-12 11:47:16 +01:00
allexzander
d028466d1c
Merge pull request #2998 from nextcloud/fix_incorrect_logexpire_config_type
...
Fix incorrect type when reading the 'logExpire' property from config.
2021-03-12 10:40:12 +02:00
allexzander
c89d351d97
Fix incorrect type when reading the 'logExpire' property from config.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-03-12 10:23:31 +02:00
Nextcloud bot
90a06aa57b
[tx-robot] updated from transifex
2021-03-12 03:48:03 +00:00
Felix Weilbach
72858da27b
Merge pull request #2967 from nextcloud/bugfix/fix-missing-error-handling-download-encrypted
...
Add missing error handling for downloads of client side encryption
2021-03-11 14:40:40 +01:00
Felix Weilbach
88426de4dd
Add missing error handling for downloads of client side encryption
...
The missing error handlers can cause the sync to hang forever
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-11 10:59:08 +00:00
Felix Weilbach
6fac2d1e40
Merge pull request #2976 from nextcloud/refactor/split-out-valuable-activities
...
Split content of User::isValueableActivity()
2021-03-11 11:57:55 +01:00
Felix Weilbach
e3ac63e9ff
Rename isActivityIgnored() to isUnsolvableconflict()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-11 09:42:38 +00:00
Felix Weilbach
05d31e2e53
Split content of User::isValueableActivity()
...
Refactoring of User::isValueableactivity() because of changes
introduced with merge commit f17c52d .
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-11 09:42:38 +00:00
Nextcloud bot
0ce965e8da
[tx-robot] updated from transifex
2021-03-11 03:51:50 +00:00
Camila
ed8f081b4a
Merge pull request #2986 from nextcloud/bump-version-3.1.81
...
Bump version to 3.1.81
2021-03-10 15:31:22 +01:00
Felix Weilbach
18b282d213
Bump version to 3.1.81
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 15:06:47 +01:00
Felix Weilbach
b5cf820b42
Merge pull request #2895 from nextcloud/wizard_ui_improvements
...
Improve wizard ui
2021-03-10 12:54:43 +01:00
Felix Weilbach
e0b7ef15b2
Restyle wizard pages
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
f55e5b1885
Restyle wizard
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
9185956069
Split out wizard welcome page
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
05d2a87840
Add new wizard icons and remove obsolete ones
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-10 09:55:40 +01:00
Felix Weilbach
344b28d2f8
Merge pull request #2979 from ivaradi/no-externc-glib2
...
Do not include glib.h with extern C (2)
2021-03-10 09:54:48 +01:00
István Váradi
2e7cc96228
Do not include glib.h with extern C (2)
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-03-10 07:48:23 +01:00
Nextcloud bot
d258faa117
[tx-robot] updated from transifex
2021-03-10 04:00:48 +00:00
István Váradi
17e27ce4ed
Merge pull request #2972 from ivaradi/no-externc-glib
...
Do no include glib.h with extern C
2021-03-09 13:30:20 +01:00
István Váradi
db321d25ef
Do no include glib.h with extern C
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-03-09 10:29:14 +01:00
Nextcloud bot
4760e892ad
[tx-robot] updated from transifex
2021-03-09 03:52:13 +00:00
Nextcloud bot
ad34531f02
[tx-robot] updated from transifex
2021-03-08 03:51:36 +00:00
Nextcloud bot
2e80adcf26
[tx-robot] updated from transifex
2021-03-07 03:47:27 +00:00
Nextcloud bot
de06b10af9
[tx-robot] updated from transifex
2021-03-06 03:52:05 +00:00
Felix Weilbach
f17c52dccd
Merge pull request #2948 from nextcloud/bugfix/conflict-dialog-issue
...
Fix crash when opening conflict dialog
2021-03-05 14:31:59 +01:00
Felix Weilbach
63dbb90bbd
Iteration
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-05 11:32:44 +00:00
Felix Weilbach
ef5abac567
Fix crashes with conflict dialog
...
When the client runs and a conflict gets detected, the sync engine runs
two times.
On the first run, the sync engine detects the conflict, marks the
file as a conflict and propagates that to the GUI. This leads to an
error notification with the original filename in the main dialog.
The sync engine runs then a second time. On this second run, the file
that originally caused the conflict is not anymore a conflict
file. Instead, the sync engine detects the conflicted copy and
propagates that file as a conflict to the GUI.
When opening the conflict dialog with the original file name (not the
conflicted copy) a crash happens. Usually, the two sync runs are really
fast, so the user does not notice the first notification. However, a
problem can occur if a conflict gets created while the client is not
running. Since then, the client does not do two sync runs. It does only
run once.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-05 11:32:44 +00:00
Nextcloud bot
101d3e5d7d
[tx-robot] updated from transifex
2021-03-05 03:51:13 +00:00
Felix Weilbach
3796876c8e
Merge pull request #2958 from nextcloud/bugfix/vfs-win-download-large-files
...
VFS Windows: Fix download of large files
2021-03-04 22:51:42 +01:00
Felix Weilbach
523f1bcadd
VFS Windows: Fix download of large files
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-03-04 09:05:17 +01:00
Nextcloud bot
226ec38f5c
[tx-robot] updated from transifex
2021-03-04 03:53:22 +00:00
Nextcloud bot
23d76b0920
[tx-robot] updated from transifex
2021-03-03 03:51:17 +00:00
Felix Weilbach
97cd61140e
Merge pull request #2931 from elsiehupp/build-instructions
...
Improve OSX build Instructions
2021-03-01 19:15:34 +01:00
Elsie Hupp
b33ea05271
Update OSX build instructions
...
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com >
2021-03-01 15:26:32 +00:00
Nextcloud bot
2d6faebb10
[tx-robot] updated from transifex
2021-03-01 03:48:16 +00:00
Nextcloud bot
7179fd88e8
[tx-robot] updated from transifex
2021-02-28 03:46:22 +00:00
Kevin Ottens
f32a8b3236
Merge pull request #2951 from nextcloud/enhancement/better_logging_of_cfpapi_error
...
Log error message from CFAPI
2021-02-27 18:56:35 +01:00
Felix Weilbach
4d05979be5
Log error message from CFAPI
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-27 17:44:26 +00:00
Nextcloud bot
8e32bea212
[tx-robot] updated from transifex
2021-02-27 03:51:14 +00:00
Nextcloud bot
6e3b3fccfc
[tx-robot] updated from transifex
2021-02-26 03:48:56 +00:00
Nextcloud bot
b5ca1f2f4b
[tx-robot] updated from transifex
2021-02-25 03:50:19 +00:00
Tobias Kaminsky
f8c031ee93
Merge pull request #2949 from nextcloud/staleAction
...
Move from stale bot to stale action
2021-02-24 16:50:49 +01:00
tobiasKaminsky
3de6ce9ee9
Move from stale bot to stale action
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me >
2021-02-24 08:02:56 +01:00
Nextcloud bot
26b3ad1e1c
[tx-robot] updated from transifex
2021-02-24 03:56:01 +00:00
Nextcloud bot
26a08fa51b
[tx-robot] updated from transifex
2021-02-19 03:53:20 +00:00
allexzander
ebdec26e27
Merge pull request #2935 from nextcloud/do-not-auto-start-debug-build
...
Do not add debug build to startup programs.
2021-02-18 15:45:34 +02:00
allexzander
88a21c0665
Do not add debug build to startup programs.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-18 13:19:06 +00:00
Tobias Kaminsky
6c9cfa319b
Merge pull request #2937 from nextcloud/staleSecondTry
...
Stale: issue must have bug and must not have approved label
2021-02-18 12:54:17 +01:00
tobiasKaminsky
8dded9310c
Stale: issue must have bug and must not have approved label
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me >
2021-02-18 10:42:18 +01:00
Nextcloud bot
dafd37711a
[tx-robot] updated from transifex
2021-02-18 03:52:54 +00:00
Nextcloud bot
41c547e705
[tx-robot] updated from transifex
2021-02-17 03:46:45 +00:00
allexzander
e6ec648e3b
Merge pull request #2925 from nextcloud/fix-incorrect-logger-output-for-non-latin-strings
...
Fix incorrect logger output for non-Latin strings.
2021-02-16 16:13:16 +02:00
allexzander
4d66d209bc
Fix incorrect logger output for non-latin strings.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-16 09:30:08 +02:00
Nextcloud bot
642320c007
[tx-robot] updated from transifex
2021-02-16 03:48:18 +00:00
Nextcloud bot
10cd83fbb4
[tx-robot] updated from transifex
2021-02-15 03:43:56 +00:00
Nextcloud bot
be8521cdab
[tx-robot] updated from transifex
2021-02-14 03:41:47 +00:00
Kevin Ottens
0996b13386
Merge pull request #2928 from nextcloud/add_missing_override_specifier
...
Add missing override specifier
2021-02-13 11:32:46 +01:00
Felix Weilbach
29e1a82f56
Add missing override specifer to WebFlowCredentials
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-13 10:22:01 +00:00
Nextcloud bot
6a3260ec26
[tx-robot] updated from transifex
2021-02-13 03:44:20 +00:00
Camila
24ab49da18
Merge pull request #2914 from marcohald/master
...
Configuration Options for Windows Registry
2021-02-12 19:06:04 +01:00
marcohald
6032f2baef
Merge branch 'master' into master
2021-02-12 15:19:34 +01:00
Marco Hald
43ed8423e5
Configuration Options for Windows Registry
...
Added the configuration options
confirmExternalStorage
crashReporter
newBigFolderSizeLimit
useNewBigFolderSizeLimit
to the Windows registry
Signed-off-by: Marco Hald <marcohald@users.noreply.github.com >
2021-02-12 12:23:51 +01:00
Kevin Ottens
81831fd69a
Merge pull request #2919 from nextcloud/validate_ssl_providers_certificate
...
Validate the providers ssl certificate
2021-02-12 10:50:41 +01:00
Felix Weilbach
74d07e28cf
Validate the providers ssl certificate
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-12 08:25:59 +00:00
Nextcloud bot
6ff3d67f61
[tx-robot] updated from transifex
2021-02-12 03:44:56 +00:00
Nextcloud bot
c6cd25c5ce
[tx-robot] updated from transifex
2021-02-11 03:44:29 +00:00
Nextcloud bot
71547dc619
[tx-robot] updated from transifex
2021-02-10 03:51:25 +00:00
allexzander
7f92d8dccb
Merge pull request #2906 from nextcloud/fix-url-scheme-security-issue
...
Validate sensitive URLs to onle allow http(s) schemes.
2021-02-09 16:42:17 +02:00
allexzander
013f3cea70
Validate sensitive URLs to onle allow http(s) schemes.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-09 15:00:35 +02:00
allexzander
e97b7d8a25
Default parameter nullptr widget for openBrowser.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-09 08:40:51 +00:00
Nextcloud bot
18a82da494
[tx-robot] updated from transifex
2021-02-09 03:44:37 +00:00
Nextcloud bot
6be88c6d37
[tx-robot] updated from transifex
2021-02-08 03:44:42 +00:00
Nextcloud bot
ca0591c4e0
[tx-robot] updated from transifex
2021-02-07 03:45:41 +00:00
Nextcloud bot
2bce09801e
[tx-robot] updated from transifex
2021-02-06 03:48:23 +00:00
allexzander
496f174232
Merge pull request #2904 from ivaradi/ui-namespace
...
Move FolderCreationDialog into the OCC namespace
2021-02-05 19:19:56 +02:00
István Váradi
92f1074fcc
Put FolderCreationDialog into the OCC namespace.
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2021-02-05 16:27:25 +01:00
Nextcloud bot
f455f9969f
[tx-robot] updated from transifex
2021-02-05 03:48:33 +00:00
Kevin Ottens
1c1301e482
Merge pull request #2892 from nextcloud/repair_e2ee_on_non_remote_root_sync_folder
...
Repair E2EE on sync folders which don't point to the root of the server on the remote end
2021-02-04 13:24:18 +01:00
Kevin Ottens
856f0567a7
Make sure we pass a full remote path to LSCOL jobs
...
Indeed the path we have is supposedly not fully qualified in case of a
sync folder which doesn't point to / on the remote end. But LSCOL works
with absolute paths on the server so make sure this is what we give it
out.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-02-04 11:16:48 +00:00
Kevin Ottens
dd83efb543
The e2eMangledName was relative to the remote folder, repair it
...
This got broken during the huge discovery refactoring. I wrongly passed
the mangled name as is out of discovery, but coming from listing jobs it
was fully qualified while the jobs at propagation time and the db expect
those paths to be relative to the remote folder.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-02-04 11:16:48 +00:00
allexzander
2c8fa40fb6
Merge pull request #2897 from nextcloud/allow-creation-of-new-folders-from-the-settings-dialog
...
Allow creation of new folders from the Settings Dialog.
2021-02-04 10:28:05 +02:00
allexzander
81a090b362
Allow creation of new folders from the Settings Dialog.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-04 10:05:18 +02:00
Nextcloud bot
93b26bc666
[tx-robot] updated from transifex
2021-02-04 03:43:39 +00:00
allexzander
a94c109646
Merge pull request #2901 from nextcloud/win-tests-compilation-hot-fix
...
Win tests compilation fix.
2021-02-03 20:12:56 +02:00
allexzander
3d266b9246
Win tests compilation fix. For Windows, the build was failing because of not being able to locate #include <sqlite3.h> in tests.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-02-03 13:52:10 +02:00
Nextcloud bot
6d634c79ee
[tx-robot] updated from transifex
2021-02-03 03:58:51 +00:00
Felix Weilbach
6803256cb3
Merge pull request #2900 from nextcloud/make_sure_theme_resources_are_loaded
...
Load the theme resource explictly
2021-02-02 19:34:50 +01:00
Kevin Ottens
55fd0562de
Load the theme resource explictly
...
Otherwise they won't be loaded automatically at startup leading to lots
of missing icons. Since they're now in a static library they need that
explicit loading.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-02-02 18:33:45 +01:00
Camila
0521dce174
Merge pull request #2834 from nextcloud/compile_nextcloud_as_lib
...
Compile nextcoud gui as separate library
2021-02-02 14:44:40 +01:00
Felix Weilbach
d8493a9b3b
Add automoc property to updater
...
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-02-02 13:35:04 +00:00
Felix Weilbach
02dd363feb
Add test utils library
...
The test utils library collects all dependencies that are needed for
tests and gets automatically linked with every test.
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-02-02 13:35:04 +00:00
Felix Weilbach
73a41d8e34
Compile nextcoud gui as separate library
...
Compiling nextcoud gui as a separate library. This is needed to more
easily write tests. The whole nextcloud application can now be linked
against the tests.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-02-02 13:35:04 +00:00
Kevin Ottens
c19f048774
Merge pull request #2894 from nextcloud/fix-docs
...
Documentation: break line in config example.
2021-02-02 11:40:11 +01:00
Camila
3087a09c45
Documentation: break line in config example.
...
Also make sure the following note is not displayed as one block with the
config example.
Minor change: fix typo.
Signed-off-by: Camila <hello@camila.codes >
2021-02-02 10:51:34 +01:00
Nextcloud bot
b66d48a5d7
[tx-robot] updated from transifex
2021-02-02 03:40:51 +00:00
Nextcloud bot
cf2adc0446
[tx-robot] updated from transifex
2021-02-01 03:46:58 +00:00
Nextcloud bot
2fc7947c7b
[tx-robot] updated from transifex
2021-01-31 03:43:48 +00:00
Nextcloud bot
a1d264aaac
[tx-robot] updated from transifex
2021-01-30 03:51:02 +00:00
Nextcloud bot
79be34ce32
[tx-robot] updated from transifex
2021-01-29 03:49:40 +00:00
Nextcloud bot
5ee4c7a0ff
[tx-robot] updated from transifex
2021-01-28 03:59:43 +00:00
Kevin Ottens
d176b96b43
Merge pull request #2874 from nextcloud/more_active_stalebot
...
Reduce exempt labels list to give a chance to stale bot to do something
2021-01-27 19:33:18 +01:00
Kevin Ottens
cc681d094a
Reduce exempt labels list to give a chance to stale bot to do something
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-27 18:15:26 +00:00
Kevin Ottens
ab6ba2212a
Merge pull request #2877 from nextcloud/revert_2875
...
Revert "Specify PUBLIC for the link targets to make them visible to w…
2021-01-27 19:14:16 +01:00
Kevin Ottens
1456d6e433
Revert "Specify PUBLIC for the link targets to make them visible to windeployqt"
...
This reverts commit 002abdc38b .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-27 19:06:23 +01:00
allexzander
ac5a277e39
Merge pull request #2872 from nextcloud/use-push-notifications-for-activities-in-tray
...
Use push notifications for Tray activities/notifications fetch trigger.
2021-01-27 20:02:04 +02:00
allexzander
8c4d5333c1
Use push notifications for Tray activities/notifications fetch trigger.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-27 19:53:28 +02:00
Kevin Ottens
f2ffa74a7b
Merge pull request #2875 from nextcloud/make_qtwebsockets_visible_to_windeployqt
...
Specify PUBLIC for the link targets to make them visible to windeployqt
2021-01-27 18:07:51 +01:00
Kevin Ottens
002abdc38b
Specify PUBLIC for the link targets to make them visible to windeployqt
...
I went full steam on making it all public which is not really required,
it's only really QtWebSockets we're after. Could always be fine tuned
later on if this works as expected.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-27 18:00:26 +01:00
Kevin Ottens
c7d9e11d89
Merge pull request #2867 from nextcloud/fix_file_resolve_dialog
...
Start file conflict resolve dialog asynchronous
2021-01-27 09:10:32 +01:00
Felix Weilbach
51d8cf8102
Start file conflict resolve dialog asynchronous
...
Fixes #2804
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-01-27 08:01:25 +00:00
Kevin Ottens
71f0b45412
Merge pull request #2732 from nextcloud/Valdnet-patch-2
...
Replace dots with ellipses and add spaces.
2021-01-27 08:59:48 +01:00
Valdnet
d8a88fd047
Replace dots with ellipses and add spaces.
2021-01-27 07:36:52 +00:00
Nextcloud bot
4567c2b0a2
[tx-robot] updated from transifex
2021-01-27 03:47:28 +00:00
Kevin Ottens
90a7f583b2
Merge pull request #2868 from nextcloud/vfs_cfapi_dont_mistake_unpinned_directory_for_files_to_dehydrate
...
Don't treat new folders in unpinned folders as files to dehydrate
2021-01-26 18:27:24 +01:00
Kevin Ottens
ebfe51b7e7
Don't treat new folders in unpinned folders as files to dehydrate
...
This would only happen if the parent of the newly created folder would
be explicitly set to online only, hence why it went under the radar
previously.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 17:09:24 +00:00
Kevin Ottens
d119fc4749
Merge pull request #2733 from nextcloud/Valdnet-patch-3
...
Move space in "owncloudadvancedsetuppage.cpp"
2021-01-26 18:07:30 +01:00
Valdnet
817d460b84
Move space in "owncloudadvancedsetuppage.cpp"
2021-01-26 16:40:46 +00:00
Kevin Ottens
56b7ec70f4
Merge pull request #2840 from nextcloud/avoid_keeping_account_alive_from_subobject
...
Avoid keeping Account alive via a shared ptr in ClientSideEncryption
2021-01-26 14:00:27 +01:00
Kevin Ottens
d20fc1a6ce
Remove unused method
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 11:20:13 +00:00
Kevin Ottens
4168c0d082
Avoid keeping Account alive via a shared ptr in ClientSideEncryption
...
This account object was really only used during the initialization phase
or for forgetting the sensitive data. So let's receive it as parameter
there and pass it on from job to job as needed.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 11:20:13 +00:00
Kevin Ottens
737158e9b4
Merge pull request #2865 from nextcloud/vfs_cfapi_dont_get_stuck
...
VFS CfAPI implementation shouldn't get stuck
2021-01-26 12:19:07 +01:00
Kevin Ottens
21035d48a6
Don't crash when the same request is filled twice
...
The OS might request the same file again if we take too much time to
fulfill a request. So in case it's queueing the same one again instead
of bailing out just fail the second one and let the first one finish
properly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 10:58:14 +00:00
Kevin Ottens
d3c7218ee8
Be a bit more resilient with errors
...
In case we'd been to slow to fullfill or we're still processing a
cancelled request better not just crash. We still log the issue though.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-26 10:58:14 +00:00
Nextcloud bot
6a4da69a62
[tx-robot] updated from transifex
2021-01-26 03:45:50 +00:00
Kevin Ottens
76d0fb254b
Merge pull request #2734 from nextcloud/Valdnet-patch-4
...
Move space in "folderwizard.cpp"
2021-01-25 18:51:15 +01:00
Valdnet
f365ec1e4c
Move space in "folderwizard.cpp"
2021-01-25 17:42:38 +00:00
Kevin Ottens
24ee350ef3
Merge pull request #2735 from nextcloud/Valdnet-patch-5
...
Change the quotation marks
2021-01-25 18:41:31 +01:00
Valdnet
8539dc7dc6
Change the quotation marks
2021-01-25 17:33:46 +00:00
Kevin Ottens
8c66b9f89e
Merge pull request #2814 from nextcloud/files_push_notifications
...
Add push notifications for file changes
2021-01-25 18:17:39 +01:00
Felix Weilbach
78f00acaa2
Add push notifications for file changes
...
Resolves #2802
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-01-25 17:01:09 +00:00
Kevin Ottens
fd604ddc9e
Merge pull request #2864 from nextcloud/fixes_for_wizard_advanced_setup
...
Fixes for wizard advanced setup
2021-01-25 17:45:02 +01:00
Kevin Ottens
4992bfa8ef
Ensure the right radio is selected when selective sync is picked
...
This got broken previously when trying to reconcile during a
cherry-pick. This also repairs the case when the theme tells us the
default is to not select anything (not that we're using this right now
but in case we'd like to brand this).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-25 16:53:21 +01:00
Kevin Ottens
2b2dac10ef
It's not really recommended anymore at least not on Windows
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-25 16:24:44 +01:00
allexzander
bc753d5fba
Merge pull request #2853 from nextcloud/e2ee-fix-rename-root-folder-issue
...
E2ee fix rename root folder issue & Fix upload stuck issue due to incorrect Lock/Unlock sequence
2021-01-25 10:44:25 +02:00
allexzander
eb80f54dcf
E2EE Fix incorrect name of a nested encrypted item in the Settings dialog when the root folder is non-encrypted and it is renamed.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-25 10:35:54 +02:00
allexzander
483a874cb6
Fix folder upload issue due to wrong Lock/Unlock order
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-25 10:35:30 +02:00
allexzander
79fe231acc
Fix E2EE root folder rename issue.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-25 10:35:30 +02:00
Kevin Ottens
18f5b841e3
Merge pull request #2859 from nicolasfella/qt5153
...
Fix build against Qt 5.15.3
2021-01-25 09:35:08 +01:00
Nicolas Fella
ab064c92b6
Fix build against Qt 5.15.3
...
Use QLatin1Char to prevent build error due to stricter QT_NO_CAST_FROM_ASCII
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2021-01-25 08:19:49 +00:00
Kevin Ottens
398101ae3d
Merge pull request #2860 from nextcloud/rakekniven-patch-2
...
Removed blank before colon
2021-01-25 09:18:46 +01:00
rakekniven
c3403b83ef
Removed blank before colon
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2021-01-25 08:08:13 +00:00
Nextcloud bot
04df193539
[tx-robot] updated from transifex
2021-01-25 03:44:11 +00:00
Nextcloud bot
a916e5a64d
[tx-robot] updated from transifex
2021-01-24 03:42:11 +00:00
Nextcloud bot
b8a56e0b4b
[tx-robot] updated from transifex
2021-01-22 03:47:57 +00:00
Kevin Ottens
b43701822f
Merge pull request #2845 from nextcloud/default_to_colored_systray_on_linux
...
Default to colored systray on linux
2021-01-21 08:01:58 +01:00
Kevin Ottens
48f0c54a90
Fix the branding detection for monochrome icons on Mac
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-21 06:39:11 +00:00
Kevin Ottens
96b2b2a509
Revert "Make monochrome icons the default on Linux and Mac OS."
...
This reverts commit 016410dbaa .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-21 06:39:11 +00:00
Nextcloud bot
fdaf04e4e5
[tx-robot] updated from transifex
2021-01-21 03:46:57 +00:00
Kevin Ottens
7f51355dc8
Merge pull request #2844 from nextcloud/handle_svg_branded_clients
...
Handle SVG branded clients
2021-01-20 16:08:01 +01:00
Kevin Ottens
471bb25e62
Use APPLICATION_ICON_SET for themed icons
...
We now favor APPLICATION_ICON_SET to isBranded() regarding the decision
to use PNG or SVG for icons.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 15:11:57 +01:00
Kevin Ottens
88986749a4
Use the SVG wizard logo when APPLICATION_ICON_SET says so
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 15:09:58 +01:00
Kevin Ottens
4b4437787f
Add the APPLICATION_ICON_SET option
...
Also mention the svg possibly used in the wizard
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 10:41:16 +01:00
Kevin Ottens
0b135ae644
Reference the wizard_logo.svg file from the resources
...
Somehow this was missing
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-20 10:10:22 +01:00
Nextcloud bot
93e8aea19e
[tx-robot] updated from transifex
2021-01-20 03:47:11 +00:00
Nextcloud bot
b1780f9b03
[tx-robot] updated from transifex
2021-01-19 03:45:22 +00:00
Nextcloud bot
6bded34856
[tx-robot] updated from transifex
2021-01-18 03:44:21 +00:00
Nextcloud bot
d87538da8b
[tx-robot] updated from transifex
2021-01-17 03:43:43 +00:00
Nextcloud bot
d30ae39890
[tx-robot] updated from transifex
2021-01-16 03:42:11 +00:00
Nextcloud bot
e353d79881
[tx-robot] updated from transifex
2021-01-15 03:49:34 +00:00
Camila
0d33ed048f
Merge pull request #2827 from nextcloud/apply_version_suffix_to_msi_filename
...
Integrate the version suffix to the MSI filename
2021-01-14 21:14:46 +01:00
Kevin Ottens
576a25161b
Integrate the version suffix to the MSI filename
...
This should be enough to reinstate the "-daily" marker in the filename
for daily builds.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 19:24:42 +00:00
Kevin Ottens
bc78ee0ca8
Merge pull request #2826 from nextcloud/reference_coding_style_wiki_page
...
Reference coding style wiki page from CONTRIBIUTING.md
2021-01-14 19:01:36 +01:00
Felix Weilbach
60a3c27d84
Merge branch 'master' into reference_coding_style_wiki_page
2021-01-14 09:49:55 -08:00
Felix Weilbach
b8277355ec
Reference coding style wiki page from CONTRIBIUTING.md
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com >
2021-01-14 18:47:52 +01:00
Kevin Ottens
314f714082
Merge pull request #2824 from nextcloud/e2ee-can-not-move-folder
...
Fix e2ee folder move issue
2021-01-14 15:12:17 +01:00
allexzander
96472320e4
Fix e2ee folder move issue
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-14 15:54:30 +02:00
Kevin Ottens
c34c0f078b
Merge pull request #2793 from nextcloud/xattr_backend_for_vfs
...
XAttr backend for VFS
2021-01-14 14:30:39 +01:00
Kevin Ottens
1aeb77c967
Add the XAttr backend prototype with its test suite
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:03 +01:00
Kevin Ottens
7c8b7db725
Don't detect file changes during hydration for virtual files
...
Indeed, that file size will almost always change between the 1 byte
placeholder and the hydrated file. Only when using the CfAPI on Windows
this won't be the case since because it will expose the original size
even for placeholders.
Also worth noting: the suffix backend didn't hit that case since the
filename changes (with suffix for placeholders, without for hydrated
files).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:03 +01:00
Kevin Ottens
6e51dcf9c6
Provide the path to the current folder to statTypeVirtualFile on unix
...
Otherwise backends can't get to the actual file which will be needed for
the XAttr backend.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:03 +01:00
Kevin Ottens
a89b483773
Add the plumbing for a new extended attributes backend
...
Ideally this will end up being the backend we use for both Linux and
macOS but that will require work with desktop environments on the Linux
side and to reverse engineering at least on xattr value on macOS.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-14 12:57:02 +01:00
Kevin Ottens
4a1c650a56
Merge pull request #2821 from nextcloud/e2ee-fix-parallel-uploads-issue
...
E2EE fix upload parallelism issue.
2021-01-14 11:41:52 +01:00
allexzander
bf5b214e0e
E2EE fix upload parallelism issue.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-14 06:59:05 +00:00
Nextcloud bot
6656b23922
[tx-robot] updated from transifex
2021-01-14 03:47:20 +00:00
Camila
13930c084c
Merge pull request #2823 from nextcloud/repair_chunked_uploads
...
Repair chunked uploads
2021-01-13 18:28:28 +01:00
Kevin Ottens
5325e058d8
Repair chunked uploads
...
There's been a confusion between the chunk number and the chunk
offset leading to corruptions... Let's pass the proper offset to
the UploadDevice again.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-13 18:00:19 +01:00
Nextcloud bot
f7be923b73
[tx-robot] updated from transifex
2021-01-13 03:52:05 +00:00
Camila
731e8a2679
Merge pull request #2815 from nextcloud/update-docs
...
Update Github issue template and documentation with the new 3.1 option to "Create Debug Archive".
2021-01-12 19:34:25 +01:00
Camila
bba376e944
Update documentation with the new 3.1 option to "Create Debug Archive".
...
Signed-off-by: Camila <hello@camila.codes >
2021-01-12 18:38:43 +01:00
Camila
250fcf380b
Fix documentation path in instruction of doc/README.
...
Signed-off-by: Camila <hello@camila.codes >
2021-01-12 18:38:43 +01:00
Camila
c6fe097535
Update Github issue template with the new 3.1 option to "Create Debug Archive".
...
Also:
- cleaned up some of the text: nobody read that and it was mostly
from a time when this team was only one person.
- remove references to e2ee known issues. Not relevant anymore.
Signed-off-by: Camila <hello@camila.codes >
2021-01-12 18:38:30 +01:00
Nextcloud bot
4ae7224151
[tx-robot] updated from transifex
2021-01-12 03:48:28 +00:00
allexzander
7dc19b90bd
Merge pull request #2799 from nextcloud/e2ee-root-folder-remove-issue
...
E2ee root folder remove issue
2021-01-11 21:20:03 +02:00
allexzander
4ed7feab2b
Implement nested items removal when removing root encrypted folder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2021-01-11 21:12:58 +02:00
Nextcloud bot
ff661d47d4
[tx-robot] updated from transifex
2021-01-10 04:02:55 +00:00
Nextcloud bot
6cc9a721a6
[tx-robot] updated from transifex
2021-01-09 03:59:04 +00:00
Nextcloud bot
12053c98eb
[tx-robot] updated from transifex
2021-01-08 04:02:38 +00:00
Kevin Ottens
8d5d45ea5c
Merge pull request #2801 from nextcloud/fix_cfapi_win32_build
...
Fix CfAPI Win32 build
2021-01-07 15:33:45 +01:00
Kevin Ottens
2d8eb19ee5
Second attempt at fixing CfAPI wrapper build in Win32 mode
...
MSVC having so useless error messages it didn't quite point to the root
cause of the issue... it turns out that through the maze of macros
defined in the windows API, there's one which impacted the function
pointer definition of CfCloseHandle which would then not convert to
FileHandle::Deleter as expected. So I end up wrapping it in a lambda to
help... luckily this kind of lambdas decay into a simple function
pointer so there's likely no overhead it's just to coerce the compiler
into doing the right thing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-07 13:49:10 +01:00
Kevin Ottens
79a54d68ed
Revert "Fix CfAPI wrapper build in Win32 mode"
...
This reverts commit 3b3864296a .
2021-01-07 13:40:01 +01:00
Nextcloud bot
344a3c82fd
[tx-robot] updated from transifex
2021-01-07 03:58:16 +00:00
allexzander
33fb861ac8
Merge pull request #2800 from nextcloud/fix_cfapi_win32_build
...
Fix CfAPI wrapper build in Win32 mode
2021-01-06 19:08:29 +02:00
Kevin Ottens
3b3864296a
Fix CfAPI wrapper build in Win32 mode
...
For some reason MSVC manages to deduce the right constructor in Win64
mode but not in Win32 mode. So let's be more explicit about what we
return.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2021-01-06 17:07:50 +01:00
Nextcloud bot
a0facaf36d
[tx-robot] updated from transifex
2021-01-06 03:57:55 +00:00
Kevin Ottens
0bb6dcebd8
Merge pull request #2794 from FlexW/master
...
Remove NO_SHIBBOLETH flag and dead code
2021-01-05 14:17:25 +01:00
Felix Weilbach
db0f1e245d
Remove NO_SHIBBOLETH flag and dead code
...
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de >
2021-01-05 12:58:58 +01:00
Nextcloud bot
0b5f42f832
[tx-robot] updated from transifex
2021-01-05 03:53:25 +00:00
Nextcloud bot
e210dd894d
[tx-robot] updated from transifex
2021-01-04 03:54:59 +00:00
Nextcloud bot
d66983fe99
[tx-robot] updated from transifex
2021-01-03 03:55:25 +00:00
Nextcloud bot
629caeff7b
[tx-robot] updated from transifex
2021-01-02 03:52:58 +00:00
Nextcloud bot
10a5538a83
[tx-robot] updated from transifex
2021-01-01 03:53:03 +00:00
Nextcloud bot
845dab2559
[tx-robot] updated from transifex
2020-12-31 04:02:00 +00:00
Kevin Ottens
fbd9f5126c
Merge pull request #2781 from nextcloud/cherry_pick_2020_w53
...
Cherry pick 2020 w53
2020-12-30 19:00:19 +01:00
Hannah von Reth
09cc988026
Fix a possible crash with the remove all files dialog
2020-12-30 16:20:43 +01:00
Kevin Ottens
da3ff631ef
Use Q_REQUIRED_RESULT directly like in other places
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 16:20:42 +01:00
Hannah von Reth
72b6118c3e
Mark vfs functions as OC_REQUIRED_RESULT
2020-12-30 16:17:48 +01:00
Hannah von Reth
aadda32633
Handle errors in convertToPlaceholder
2020-12-30 16:17:47 +01:00
Hannah von Reth
552427ffc3
Update windows launch on start binary location
...
Fixes : #7672
2020-12-30 16:17:47 +01:00
Dominik Schmidt
69915ab594
Fix testVersionOfInstalledBinary for brandings
2020-12-30 16:17:47 +01:00
Dominik Schmidt
67f9890320
Use owncloudcmd in testVersionOfInstalledBinary
...
... as it works without X in CI.
2020-12-30 16:17:47 +01:00
Dominik Schmidt
635d2b2da2
Fix style
2020-12-30 16:17:47 +01:00
Hannah von Reth
713a429675
Add todo for Qt 5.15
2020-12-30 16:17:47 +01:00
Hannah von Reth
1144473f5d
Cleanup pathtoUNC and its test
2020-12-30 16:17:46 +01:00
Hannah von Reth
51d73e27ea
Clarify comment
2020-12-30 16:17:46 +01:00
Hannah von Reth
3f873ed2ee
Simplify file comparison
2020-12-30 16:17:46 +01:00
Hannah von Reth
157d526129
Include auth type in http log
2020-12-30 16:17:46 +01:00
Hannah von Reth
f6f7789afa
Log the final http request
2020-12-30 16:17:41 +01:00
Kevin Ottens
c501eed365
Merge pull request #2778 from nextcloud/windows_cfapi_backend_for_vfs
...
Windows cfapi backend for vfs
2020-12-30 16:16:57 +01:00
Kevin Ottens
46a5bd6b25
Ensure we properly cancel hydration on server errors
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:59 +01:00
Kevin Ottens
e37a5f36b0
Don't look at virtual files data for the mimetype matches
...
Otherwise this would attempt to download the file everytime we check the
direct editor for a given file which wouldn't be adequate. Would also
lead to a deadlock in our case since that would happen in the main
thread and implicit hydration is driven from there as well.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
90fbb7d322
Implement callback between wrapper and vfs object for hydration requests
...
This comes with a test simulating an open request coming from another
process (although in our case it's really just a thread). The actual
hydration works as expected by cfapi, handling of encrypted files is for
now missing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
5d013accea
Improve test readability with a bunch of macros
...
Since we often checked the same file states to see if they were virtual,
non virtual or gone, let's factor this out. This way intent in tests is
clearer.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
691ab9a40a
Port the tests to the CfApiWrapper
...
This reduces code duplication and opportunities of mistakes between the
test and the implementation.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
7668c521c1
Split the CfAPI lower level code in a wrapper
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
423780bf79
Add initial version of the CfApi backend
...
For now this implements only the logic necessary to get a test suite
equivalent to the TestSyncVirtualFiles one to pass. It doesn't (yet)
honor request to fetch files from the system.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:58 +01:00
Kevin Ottens
216b251b40
One byte placeholders assumption only holds for the suffix backend
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:57 +01:00
Kevin Ottens
4d4b87c9c3
Don't consider CfApi backend as experimental
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-30 09:44:53 +01:00
Nextcloud bot
a23791c039
[tx-robot] updated from transifex
2020-12-30 03:48:58 +00:00
Nextcloud bot
473abb4c7a
[tx-robot] updated from transifex
2020-12-29 03:48:59 +00:00
Kevin Ottens
23efdd2ead
Merge pull request #2748 from nextcloud/rakekniven-patch-1
...
Removed translation for "etag" and changed spelling
2020-12-28 10:01:18 +01:00
rakekniven
267d987895
Changed spelling of "etag".
...
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-12-28 08:51:56 +00:00
rakekniven
e1979fdb33
Removed translation for "etag" and changed spelling
...
Shouldn't be translated.
Just checked https://en.wikipedia.org/wiki/HTTP_ETag and all available localized pages.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-12-28 08:51:56 +00:00
Nextcloud bot
19765e2be7
[tx-robot] updated from transifex
2020-12-27 03:52:01 +00:00
Nextcloud bot
12a7fb32a9
[tx-robot] updated from transifex
2020-12-26 03:45:58 +00:00
Nextcloud bot
e726d71425
[tx-robot] updated from transifex
2020-12-25 03:45:25 +00:00
Nextcloud bot
2b4bc9d517
[tx-robot] updated from transifex
2020-12-24 03:46:47 +00:00
Nextcloud bot
274b27d2e0
[tx-robot] updated from transifex
2020-12-23 03:47:06 +00:00
István Váradi
b1458ff56b
Merge pull request #2759 from ivaradi/ubuntu-hirsute
...
Add support for Hirsute
2020-12-22 10:55:48 +01:00
István Váradi
dadc053809
Add support for Hirsute
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-12-22 10:19:08 +01:00
Nextcloud bot
269d42d7d9
[tx-robot] updated from transifex
2020-12-22 03:48:05 +00:00
Kevin Ottens
1c46101dff
Merge pull request #2739 from hrittich/master
...
Fixed the autostart for AppImages. See #2504 .
2020-12-21 12:07:44 +01:00
Hannah Rittich
5fc778bfaa
Fixed the autostart for AppImages. See #2504 .
...
Signed-off-by: Hannah Rittich <hrittich@users.noreply.github.com >
2020-12-21 11:56:09 +01:00
Kevin Ottens
f7ec914380
Merge pull request #2749 from nextcloud/rakekniven-patch-2
...
Changed triple dot to ellipsis
2020-12-21 09:12:42 +01:00
rakekniven
29d968ab15
Changed triple dot to ellipsis
...
Reported at Transifex.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-12-21 08:00:29 +00:00
Nextcloud bot
e5d5be9dfe
[tx-robot] updated from transifex
2020-12-21 03:46:22 +00:00
Nextcloud bot
4ef8a0e69f
[tx-robot] updated from transifex
2020-12-20 03:48:31 +00:00
Nextcloud bot
060fa3e125
[tx-robot] updated from transifex
2020-12-19 03:46:53 +00:00
Nextcloud bot
0ae71a34b5
[tx-robot] updated from transifex
2020-12-18 03:48:04 +00:00
Kevin Ottens
92a968860d
Merge pull request #2726 from nextcloud/settings-ui
...
UI improvements: Settings dialog
2020-12-17 11:00:48 +01:00
Camila
0e0ea9d81a
Update the settings dialog window title.
...
Signed-off-by: Camila <hello@camila.codes >
2020-12-17 07:04:07 +00:00
Camila
625752f85d
General settings: move buttons to the bottom left of their group boxes.
...
Signed-off-by: Camila <hello@camila.codes >
2020-12-17 07:04:07 +00:00
Nextcloud bot
8fd2443ead
[tx-robot] updated from transifex
2020-12-17 03:46:16 +00:00
Kevin Ottens
0d084ee343
Merge pull request #2725 from nextcloud/default-mono-icons
...
Make monochrome icons the default on Linux and Mac OS.
2020-12-16 19:03:56 +01:00
Camila
016410dbaa
Make monochrome icons the default on Linux and Mac OS.
...
Unless it is branded with other icons.
Signed-off-by: Camila <hello@camila.codes >
2020-12-16 14:42:24 +01:00
Nextcloud bot
e3081476cd
[tx-robot] updated from transifex
2020-12-16 03:48:12 +00:00
Kevin Ottens
1d5c203044
Merge pull request #2700 from nextcloud/major_engine_update
...
Major engine update
2020-12-15 12:32:17 +01:00
Kevin Ottens
a938e7d05f
Adjust the appimage script to the buildsystem changes
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Kevin Ottens
af57a702ef
Workaround bug in older GCC used for the AppImage toolchain
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Kevin Ottens
0756497c3e
Get the excluded files test to pass again on Windows
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Kevin Ottens
c57eff6fd8
Please the clang-tidy overlord
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 11:01:53 +01:00
Hannah von Reth
c03a5da670
Don't warn if everything is fine
2020-12-15 11:01:53 +01:00
Hannah von Reth
4e373ca7ff
Remove now unneeded cmake test and define
2020-12-15 11:01:52 +01:00
Hannah von Reth
ebd8047cb6
Replace custome date parser QDateTime::fromString(value, Qt::RFC2822Date)
2020-12-15 11:01:52 +01:00
Hannah von Reth
40e07ef3e3
Fix unit tests by setting Date header
2020-12-15 11:01:52 +01:00
Hannah von Reth
9d9eadba8e
Use time the request was send,..
...
not when it was processed by the client, to determine the quality of the connection.
2020-12-15 11:01:08 +01:00
Hannah von Reth
6818b8e303
Speedup test build by compile the fake server just once
2020-12-15 10:59:27 +01:00
Hannah von Reth
1b4ccea083
Owncloud - virtual files smaller <1KB - problems with syncing
...
The issue was caused by gziped responses not providing a
content lenght header.
Fixes : #8248
2020-12-15 10:59:27 +01:00
Hannah von Reth
96eaef6dba
Pause sync when remove all dialog is displayed
...
Fixes : #8263
2020-12-15 10:59:27 +01:00
Hannah von Reth
c253b51249
Use enum instead of int
2020-12-15 10:59:27 +01:00
Hannah von Reth
befc373ea6
Fix test on systems where C:\ is not writeable
2020-12-15 10:59:27 +01:00
Hannah von Reth
dc42ebb793
Don't recurse the whole tree looking for a git dir, use PROJECT_SOURCE_DIR
2020-12-15 10:59:26 +01:00
Hannah von Reth
0eb8b01f0a
Fix usePlaceholders migration
2020-12-15 10:59:26 +01:00
Hannah von Reth
58bc9e837c
Remove junk files
2020-12-15 10:59:26 +01:00
Hannah von Reth
a083a37126
Fix vfs experimental text
2020-12-15 10:59:26 +01:00
Hannah von Reth
b2934a68bc
Fix folder permission check on NTFS
...
Fixes : #8187
2020-12-15 10:59:26 +01:00
Hannah von Reth
8dbdaed5c3
Fix condition
2020-12-15 10:59:26 +01:00
Hannah von Reth
e4a0222954
Append .exe to crashreporter path so it is better located
2020-12-15 10:59:25 +01:00
Hannah von Reth
440b31986a
Ensure the callback is triggered
2020-12-15 10:59:25 +01:00
Hannah von Reth
f6faba48e2
Don`t block main thread when displaying all files removed dialog
...
Fixes : #8170
2020-12-15 10:59:25 +01:00
Hannah von Reth
b4cb3ecb5a
Don't use exec() on dialogs
2020-12-15 10:59:25 +01:00
Hannah von Reth
4878042e61
Update libcrashreporter-qt
2020-12-15 10:59:25 +01:00
Hannah von Reth
7c65d38ba4
Draw active progressbar
...
Pass a widget to the progressbar in the folder delegate to draw the correct active state
2020-12-15 10:59:25 +01:00
Kevin Ottens
201dbd54db
Remove the plugin loader mechanism for VFS backends
...
We will have all the code in public anyway so it can just be compiled
in. Thus no need to go through the plugin loading dance. Replaced the
loading with factory functions. Kept mostly the same structure
otherwise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
7e5f81ea81
Allow to control availability of folders in the settings dialog
...
It felt odd to be able to control the encryption status in the settings
dialog but not the availability. Also availability was controllable on
the root, so let's make it widely available.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
70c2dc70a1
Resurrect the display of subfolders for VFS sync folders
...
This got removed from the settings since in that case selective sync
isn't supported. Unfortunately that's also necessary to display them to
allow encrypting folders via the context menu.
So we display the subfolders again but in the case of VFS we disable the
ability to (un)check them. They just have an icon, a name and a context
menu.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
9f0e0b0f6a
Update the FolderStatusModel when a folder encryption ends
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
596bfab6e1
Set the account state after E2EE is setup in the GUI
...
Otherwise we would not display the E2EE message if the account was
connected before the creation of the settings dialog. This was likely
caused by the delayed creation of the settings dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
f45e84f2ee
Remove empty action in the settings toolbar
...
This was causing an unwanted line in the middle of the bar.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:24 +01:00
Kevin Ottens
d63097475c
Fix typo and style
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
1acb2679dd
Get rid of now unused GetFolderEncryptStatusJob
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
36b8e7c2a4
Remove the encryption flag check from encrypted propagation code
...
If we use those encrypted propagation code paths, we already know from
the discovery phase (and thus the journal db) that the folders are
encrypted so no need to check again.
This will remove another expensive round trip with the server.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
b2533e6451
Remove encrypt status job fetching from ClientSideEncryption
...
This is now unused.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
d22046d679
No need to fetch encryption data separately before discovery
...
This step isn't necessary anymore, no one looks at ClientSideEncryption
for that information anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
580b36fe20
Remove unused methods on ClientSideEncryption
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
ce5edfdf4d
Stop using e2e()->isFolderEncrypted() in the folder wizard
...
We used the same approach than for the FolderStatusModel by getting the
is-encrypted property straight from the LSCOL job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:23 +01:00
Kevin Ottens
4fde05b8b6
FolderStatusModel now uses the LSCOL job result for encryption status
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
8e5a8d9fb9
FolderStatusModel LSCOL job now gets the is-encrypted property
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
7a4a359704
Stop using e2e()->isFolderEncrypted() in the jobs
...
Thanks to the new discovery algorithm, we got all the freshest E2EE
information straight from the database so reuse it instead of going
through an in memory copy.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
37a51872e1
Set the encrypted flag in the database when EncryptFolderJob succeeds
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
b667bdda14
Change EncryptFolderJob path convention
...
It had a different path convention than all the other jobs, most likely
for legacy reasons because of the tight coupling it had to the settings
dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
ee8e0fa332
Have the folder token inside the EncryptFolderJob
...
No need to look for a token on the outside we can just work properly by
keeping all the state encapsulated in the job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:22 +01:00
Kevin Ottens
af00ef1cca
Don't use getFileRecordByE2eMangledName in jobs anymore
...
Thanks to the new discovery algorithm we got both mangled and original
file names in the item so no need to go through the database for
nothing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
66f24241d8
Repair E2EE deletions
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
567f678fd5
Make sure the encrypted flag gets all the way to the journal db
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
961794669e
Repair E2EE uploads
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
1d07af07a5
Start hooking up E2EE to the new discovery algorithm
...
Now we pull the encrypted metadata during the discovery which is a
better approach than before. This shall remove the need for some of the
deep propfinds we have been using so far. It already simplifies the code
a bit for the download scenario.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Kevin Ottens
2cf76bbcbf
Repair the Windows Build
...
We now enforce the use of QStringLiteral and friends in some places,
but that feel through the cracks for some of the Windows specific code.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:59:21 +01:00
Hannah von Reth
dd3e70b667
VirtualFiles: Ensure the target location supports vfs
...
Fixes : #8131
2020-12-15 10:59:20 +01:00
Hannah von Reth
8796f25994
Log error code as hex
2020-12-15 10:59:20 +01:00
Hannah von Reth
44175aca94
Fix: Log chunked messages
2020-12-15 10:59:20 +01:00
Hannah von Reth
60011e8003
Remove vfs warning in the delegate, indicate them in the description instead
...
Fixes : #8139
2020-12-15 10:59:20 +01:00
Hannah von Reth
93152761a1
Use verbose function names instead of direct member access
2020-12-15 10:59:20 +01:00
Hannah von Reth
356192fb1d
Don't show 404 errors when manually creating folder sync pair.
...
Fixes : #7724
2020-12-15 10:59:20 +01:00
Hannah von Reth
1619cd5dcc
Use winvfs by default when adding folder sync connection
...
Fixes : #8083
2020-12-15 10:59:19 +01:00
Hannah von Reth
8460526df9
Clear cookies on logout
2020-12-15 10:59:19 +01:00
Hannah von Reth
0c57bb8869
Remove the use of goto from test/csync/std_tests/check_std_c_jhash.c
2020-12-15 10:59:19 +01:00
Hannah von Reth
f220151527
Remove the use of goto from src/csync/csync_exclude.cpp
2020-12-15 10:59:19 +01:00
Hannah von Reth
4f596dae8c
Log http status
...
Fixes : #8073
2020-12-15 10:59:19 +01:00
Hannah von Reth
020c6d6424
Fix placeholders are reverted to OnlineOnly
...
Fixes : #7779
2020-12-15 10:59:19 +01:00
Hannah von Reth
d58cdaeb2a
Crashreporter: Apply the same hdpi settings as to the main gui
...
Fixes : #8042
2020-12-15 10:59:18 +01:00
Hannah von Reth
0eabc75039
Improve log message
2020-12-15 10:59:18 +01:00
Hannah von Reth
f1f6257b5d
Windows VFS: Enable Windows VFS by default
2020-12-15 10:59:18 +01:00
Hannah von Reth
1aa1ea7bea
Return empty string instead of 1 as adler32 checksum for empty files
2020-12-15 10:59:18 +01:00
Hannah von Reth
23f7c51f70
Print checksum on mismatch
2020-12-15 10:59:18 +01:00
Hannah von Reth
fd6146d09e
Clazy: Fix some warnings
2020-12-15 10:59:18 +01:00
Hannah von Reth
3caf8276a2
Remove pointless warning
...
We also don't have a version entry in the db if thne db is new.
As I don't expect regular updates from 1.5 this message can just be removed.
Fixes : #8004
2020-12-15 10:59:17 +01:00
Hannah von Reth
2d66025d72
csync: apply strict QString handling
2020-12-15 10:59:17 +01:00
Hannah von Reth
bd62615aab
Clazy: Fix some warnigns
2020-12-15 10:59:17 +01:00
Hannah von Reth
d109d49b49
Ui: Hide selective sync settings if vfs is active
...
Fixes : #7976
2020-12-15 10:59:17 +01:00
Hannah von Reth
54cc2be00f
Fix assertion introduced by e1ca612c5d3087e02f6b7f8e454224e0b88e82ad
...
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787
e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
2020-12-15 10:59:17 +01:00
Hannah von Reth
93281c8560
Use const access where possible
2020-12-15 10:59:17 +01:00
Hannah von Reth
563b347567
csync: apply strict QString handling
2020-12-15 10:59:16 +01:00
Hannah von Reth
82dbf8b5e1
VFS: remove now unused parameter
2020-12-15 10:59:16 +01:00
Hannah von Reth
c1a91e91e7
Use the servers checksum type by default
2020-12-15 10:59:16 +01:00
Hannah von Reth
8c3749cbe2
Log state before specific assertion
2020-12-15 10:59:16 +01:00
Hannah von Reth
2887a93c40
Win: Use full Windows paths in file watcher and improve logging
2020-12-15 10:59:16 +01:00
Hannah von Reth
7fa7bc54c4
Win: Move hresultToQString from vfs plugin to Utility::formatWinError
2020-12-15 10:59:16 +01:00
Hannah von Reth
4589772393
Remove more legacy C code
2020-12-15 10:59:15 +01:00
Hannah von Reth
3dcbc9fa66
Tests: Port check_vio_ext to Windows
2020-12-15 10:59:15 +01:00
Hannah von Reth
47dc7e6c49
Remove custome string functions
2020-12-15 10:59:15 +01:00
Hannah von Reth
29c6f44124
Logging: Print enum before cast in SqlQuer::bindValue
2020-12-15 10:59:15 +01:00
Hannah von Reth
b9638bc778
Fix warning
...
warning C4573: the usage of 'QObject::disconnect' requires the compiler to capture 'this' but the current default capture mode does not allow it
2020-12-15 10:59:15 +01:00
Hannah von Reth
e38b43123c
Log: Only print 'Saved account settings' in debug mode
...
Don't log that there was no error...
2020-12-15 10:59:15 +01:00
Hannah von Reth
c9ee0a0343
Log: Improve log message [ info gui.folder ]: Folder sync result: 4...
...
by including the name of the folder and print the name of the result
2020-12-15 10:59:15 +01:00
Hannah von Reth
fb34f8ea85
Gui: Don't try to display the wizard during shutdown
...
Fixes : #7936
2020-12-15 10:59:14 +01:00
Hannah von Reth
4f8928d35e
Remove dead code
2020-12-15 10:59:14 +01:00
Hannah von Reth
c5b59bf3b1
Make ownCloud accassible on the Application object
2020-12-15 10:59:14 +01:00
Hannah von Reth
4645e69147
Remove ifdef(Q_OS_X11) code, there never was such a define.
...
As noone complained since I don't think anyone will miss the code
2020-12-15 10:59:14 +01:00
Hannah von Reth
e4b7ed8fd6
A pedantic .desktop parser want's a list to end with ;
2020-12-15 10:59:14 +01:00
Hannah von Reth
f932dfc648
VFS: Tell the vfs plugin whether we have multiple accounts
...
This allows us to decide on the presentation of the account
2020-12-15 10:59:14 +01:00
Hannah von Reth
a0d81df21e
UnitTests: Set a CookiesJar in FakeQNAM
2020-12-15 10:59:13 +01:00
Hannah von Reth
7e91166d7a
CMake: Remove krazy2 support, we now use clazy
2020-12-15 10:59:13 +01:00
Hannah von Reth
7fdb842ed2
VFS: Prevent duplicated navigation panel icon
...
Issue: #7748
2020-12-15 10:59:13 +01:00
Hannah von Reth
6c2c544713
Log HTTP requests and responses
...
Issue: #7873
2020-12-15 10:59:13 +01:00
Hannah von Reth
c92f70d4ff
Beautify flags
2020-12-15 10:59:13 +01:00
Hannah von Reth
2b95f919ad
Fix 3aeca58b316363dc12ad4b392750fc57e7a2965a
2020-12-15 10:59:13 +01:00
Hannah von Reth
6d2526a67d
Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value
2020-12-15 10:59:12 +01:00
Hannah von Reth
b492b69dfd
Fix 150a5b4d06600d140ddf05383fb74cda6ae6e941
2020-12-15 10:59:12 +01:00
Hannah von Reth
6fde08d9f7
Fix crash on settings migration
...
Fixes : #7878
2020-12-15 10:59:12 +01:00
Hannah von Reth
fa87b899fb
Fix usage of QMessageBox
...
Fixes : #7874
2020-12-15 10:59:12 +01:00
Hannah von Reth
11b9e3fa61
Fix order of pluginkit commands and modernise
2020-12-15 10:59:12 +01:00
Hannah von Reth
aaca3e7ce5
Use separate loggin category for upload v1 and ng
2020-12-15 10:59:12 +01:00
Hannah von Reth
eed4ffb823
Wizard: Raise own window
...
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
2020-12-15 10:59:11 +01:00
Hannah von Reth
baff0a6986
VFS Dialog: Don't enable on close button clicked
...
Issue: #7710
2020-12-15 10:59:11 +01:00
Hannah von Reth
1a1035d516
Remove unused struct
2020-12-15 10:59:11 +01:00
Hannah von Reth
b15c308170
Remvoe now unneeded SyncRunFileLog::directionToStr
2020-12-15 10:59:11 +01:00
Hannah von Reth
4681421b62
Remvoe now unneeded SyncRunFileLog::instructionToStr
2020-12-15 10:59:11 +01:00
Hannah von Reth
a1d8010eae
Cleanup moc_csync.cpp include
2020-12-15 10:59:11 +01:00
Hannah von Reth
4d615c31da
Rename csync_instructions_e -> SyncInsturctions
2020-12-15 10:59:10 +01:00
Hannah von Reth
8cbdb4451b
Remove now unneede csync_instruction_str
2020-12-15 10:59:10 +01:00
Hannah von Reth
caa04f6adb
Make bit flags better readable
2020-12-15 10:59:10 +01:00
Hannah von Reth
c803292829
Use Q_ENUM_NS for PinState
2020-12-15 10:59:10 +01:00
Hannah von Reth
86789a1280
Test: Disable parallelism to ensure serial execution
2020-12-15 10:59:10 +01:00
Hannah von Reth
38c4d5a406
Cookies: Do set cookies in DetermineAuthTypeJob too
...
As we don't support cookie based authentication anymore we can provide cookies here.
This fixes issues with loadbalancers access policy managers.
2020-12-15 10:59:10 +01:00
Hannah von Reth
f073997aee
Cookies: Don't override cookies with outdated values
...
This code was actually not breaking most cookie handling by accident.
As the raw cookies where not split properly we added cookies with values like
"key: val; key2 = val2; key3 = val3"
When the code was corrected we overwrote the newer values in the jar with
the old ones from a request.
2020-12-15 10:59:09 +01:00
Olivier Goffart
317d3735d7
SocketAPI: fix status after a failure to move
...
Issue #7759
2020-12-15 10:59:09 +01:00
Hannah von Reth
734e49765d
Test: Fix testMovedWithError for vfs mode
2020-12-15 10:59:09 +01:00
Hannah von Reth
85aefa4232
Sync: Fix handling of virtual files in error state
...
Issue: #7799
2020-12-15 10:59:09 +01:00
Hannah von Reth
7644be576f
Test: Add test for vfs failed move crash
2020-12-15 10:59:09 +01:00
Hannah von Reth
bcceb5c33d
[Gui] Implement raiseDialog on Windows
...
Issue: #7774
2020-12-15 10:59:09 +01:00
Hannah von Reth
12ae1e97c6
[SocketApi] Ensure listener still exists
2020-12-15 10:59:08 +01:00
Hannah von Reth
868b05f25b
Improve logging of issues during plugin loading
...
If the plugin could not be loaded the client calls qFatal
Make the loading warnings critical so they get printed before we crash
2020-12-15 10:59:08 +01:00
Hannah von Reth
d63d4cdf62
Don't insert items into the folder model if selectiveSync is not supported
...
This fixes an assertion in FolderStatusModel::SubFolderInfo::resetSubs
rowCount reported 0 but we actually had items in the model
2020-12-15 10:59:08 +01:00
Hannah von Reth
9176afe263
Make sure all cases are handled
2020-12-15 10:59:08 +01:00
Hannah von Reth
9b0788bdf8
[Gui] Fix vfs dialog not showing on Windows
2020-12-15 10:59:08 +01:00
Hannah von Reth
a9728b527a
Remove unused defines
2020-12-15 10:59:08 +01:00
Hannah von Reth
1dd01477c5
Use Q_ENUM_NS to pretty print csync enums
2020-12-15 10:59:07 +01:00
Hannah von Reth
5927beb08d
Fix potential null pointer access
...
https://sentry.io/organizations/owncloud/issues/1529161263/events/02509984b5ca42ffb3960d9c9e161414/?project=79001&statsPeriod=14d
2020-12-15 10:59:07 +01:00
Olivier Goffart
b7193e6a0e
Folder Wizard: warn when adding a folder which is the parent of a sync'ed folder
...
issue #7741
2020-12-15 10:59:07 +01:00
Hannah von Reth
13c9d6431d
Fix expansion of tree view on newly added accounts
...
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a
I removed a few lines of code there which are already part of fetchMore()
Fixes : #7336
2020-12-15 10:59:07 +01:00
Hannah von Reth
fdc3b7c8da
[Wizard] Make vfs dialog blocking
...
Calling the callback after the receiver was deleted caused a crash
Fixes : #7709
Fixes : #7711
2020-12-15 10:59:07 +01:00
Olivier Goffart
a6a0e361c1
fixup test
2020-12-15 10:59:07 +01:00
Olivier Goffart
9f2c67dca9
Tests: add a couple of move tests
...
This was an attempt to reproduce #7722 , but this actually does not
reproduce it
2020-12-15 10:59:07 +01:00
Hannah von Reth
106a35d242
[SSL] Print warning only if something changed
2020-12-15 10:59:06 +01:00
Hannah von Reth
ba87fc9e78
[SSL] Properly restore user accepted certificats
2020-12-15 10:59:06 +01:00
Hannah von Reth
c8dd333e31
[Sanity] Remove old ifdef
2020-12-15 10:59:06 +01:00
Hannah von Reth
9564e5e92e
Fix saving of cookies
...
Fixes : #7700
2020-12-15 10:59:06 +01:00
Hannah von Reth
3a3ccb0834
Don't hardcode PLUGINDIR
2020-12-15 10:59:06 +01:00
Olivier Goffart
7fd4a280f0
Make PluginFactory virtual to silent -Wnon-virtual-dtor warning
...
This is not necessary, but it also shouldn't hurt.
2020-12-15 10:59:06 +01:00
Olivier Goffart
1c10fceacc
SyncEngine: no need to use QAtomicInt
...
This was done because the propagator jobs where running in a thread a long
time ago, but this is no longer the case.
(Also QAtomicInt::load is marked as deprecated now)
2020-12-15 10:59:05 +01:00
Olivier Goffart
f81f96915f
ProxyAuthHandler Use QPointer instead of QWeakPointer
...
QWeakPointer::data is deprecated.
In this case we should use QPointer
2020-12-15 10:59:05 +01:00
Hannah von Reth
e08645f259
Remove old test scripts
...
Fixes: 7679
2020-12-15 10:59:05 +01:00
Hannah von Reth
466e8abc91
[Core] Include more information about the OS in the user agent
2020-12-15 10:59:05 +01:00
Hannah von Reth
edb51abdfd
Don't ignore file sync notification after an unlock
...
For a usual file sync event we check for actual changes in the local file,
after an unlock the local file might be unchanged so we need to sync it anyhow.
Fixes : owncloud/enterprise#3609
2020-12-15 10:59:05 +01:00
Hannah von Reth
3317e354f2
Prepend PLUGINDIR else its pointless
2020-12-15 10:59:05 +01:00
Hannah von Reth
b6e8d47644
Use Q_ENUM on AuthType to get the name printed in the log
2020-12-15 10:59:04 +01:00
Hannah von Reth
a3a872eefe
Add Actions to the Desktop file
2020-12-15 10:59:04 +01:00
Hannah von Reth
dabf7aaebc
Application: Allow to quit running instances by commandline
2020-12-15 10:59:04 +01:00
Hannah von Reth
fa82a4aff3
Cleanup
2020-12-15 10:59:04 +01:00
Hannah von Reth
6c19b02888
Disable http2 support for now
...
Issue: #7610
2020-12-15 10:59:04 +01:00
Olivier Goffart
0e7c56e81c
Don't show the "All files deleted" popup when unselecting everything with selective sync
...
Issue #7337
2020-12-15 10:59:04 +01:00
Olivier Goffart
4424eb7f07
AccountSettings: limit the clickable region of the 'add folder' button
...
Issue #7326
2020-12-15 10:59:03 +01:00
Olivier Goffart
b97c0ed8a2
Network Settings: Show a warning that proxy settings do not apply to localhost
...
Only show this if at least one account is detected to have an url that looks
like localhost, because this could otherwise be confusing
Issue #7169
2020-12-15 10:59:03 +01:00
Olivier Goffart
392d3c257c
Discovery: Allow more HTTP error code to be treated as ignored dir
...
The original code from csync was stopping at any error.
But we have been whitelisting soeme http error code one by one
to ignore the directory instead of aborting the sync.
However, as there are more requests to continue the sync in case
of error, just ignore most HTTP errors
Issue #7586
2020-12-15 10:59:03 +01:00
Hannah von Reth
43c7e32ee1
[libsync] Export verifyFileUnchanged
...
This fixes Windows builds that are broken since #7562 was merged
2020-12-15 10:59:03 +01:00
Olivier Goffart
66f7b27121
VFS: Do not overwrite existing files by placeholder
...
For issue #7557 and #7556
Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
2020-12-15 10:59:03 +01:00
Hannah von Reth
9807285abd
[Gui] Set proper hdpi attributes
2020-12-15 10:59:03 +01:00
Olivier Goffart
fc0aeb53b1
Discovery: fix TestSyncVirtualFiles::testExtraFilesLocalDehydrated on windows
...
On windows we do a test to know if we should change the case of the files,
but that conflict with the test that checks if the file was still there
when the filename is actually the same. Which can happen with virtual files
as they have two representation (the one with and without suffix).
2020-12-15 10:59:02 +01:00
Olivier Goffart
ca18bbc2ca
Test: Fix testsyncvirtualfiles test
...
Like previous commit, the failure was caused by two conflicting commits
2020-12-15 10:59:02 +01:00
Olivier Goffart
ecd3de61f5
Fix build of tests.
...
Resulted from a conflict between two patches
2020-12-15 10:59:02 +01:00
Christian Kamm
4c4cbf0d97
Vfs: Lots of tests and corrections for suffix edge cases
...
Avoid or deal with problems that happen when suffixed files exist on the
server or suffix and non-suffixed files exist locally.
See #7350 , #7261 .
2020-12-15 10:59:02 +01:00
Olivier Goffart
88f86a56b1
Discovery: Attempt to fix issue with windows VFS and new files
...
(or moved files)
As seen in the log of #7558 , a conflict may be issued by mistake.
See investigation in https://github.com/owncloud/client/issues/7558#issuecomment-547385362
This hopefully fix #7558
2020-12-15 10:59:02 +01:00
Olivier Goffart
513b0c723c
Account Settings: change the color of info message from green to blue
...
To avoid confusion with the color of "success"
Issue #7403
2020-12-15 10:59:02 +01:00
Olivier Goffart
4d7ed8f62c
Wizard: fix compilation warnings about unused variables
2020-12-15 10:59:01 +01:00
Olivier Goffart
115a53134c
SyncEngine: Save a bit of memory by not keeping a set of all filename
...
This is only used for conflict files, so only save conflict files.
(The _seenFile was used for other things in 2.5, but not anymore)
2020-12-15 10:59:01 +01:00
Olivier Goffart
83d743b66b
When moving is allowed but deleting is not, do not restore moved items
...
Issue #7293
2020-12-15 10:59:01 +01:00
Olivier Goffart
ee611e6004
Restoration items should appear in the sync protocol
...
When an item is downloaded because it is restored, it shall be shown in the
sync protocol.
(It is also going to be shown in the not synchronized for a short while, but
that's fine)
2020-12-15 10:59:01 +01:00
Olivier Goffart
cb38bb2b5e
Fix Upload of large (> 2GiB) files
...
Issue #7506
This is a regression introduced by the delta sync feature (as the chunk offset
changed from being the chunk number to be the byte offset, it needs to be a
qint64 now)
2020-12-15 10:59:01 +01:00
Christian Kamm
ee3279c904
Tests: Fail if the initial sync fails
2020-12-15 10:59:01 +01:00
Christian Kamm
9d422284af
Discovery: Distinguish readdir and closedir errors
2020-12-15 10:59:01 +01:00
Olivier Goffart
390af4d41b
Tests: introduce ItemCompletedSpy to avoid a bit of code duplication
2020-12-15 10:59:00 +01:00
Olivier Goffart
adbd3d869b
Fix warning about serverJob not being used
...
And fix a FIXME in the same time
2020-12-15 10:59:00 +01:00
Christian Kamm
89216daee6
Propagate dir: Never write the etag on remote mkdir #7481
...
It must always only be written once all children are successfully
propagated.
2020-12-15 10:59:00 +01:00
Hannah von Reth
dc55617144
Ensure the url is complete before we validate it
...
Fixes : #6722
2020-12-15 10:59:00 +01:00
Christian Kamm
c9476a11f4
Checksums: Explicitly close file before reporting result
...
To ensure it's no longer open when the finished signal fires.
2020-12-15 10:59:00 +01:00
Christian Kamm
e91e1ca78f
Test: Disable local discovery parallelism in permission test
...
Adding parallelism broke the test because it depended on the order of
discovery.
2020-12-15 10:59:00 +01:00
Christian Kamm
e596b55977
Discovery: Change local job signal signatures
...
To make it more explicit that data a copy of the data is transfered
between threads. (though Qt will make a copy of the arguments anyway)
2020-12-15 10:58:59 +01:00
Christian Kamm
71f71b38f1
Discovery: local job shouldn't be parented
...
Since it'll be deleted by the thread pool.
2020-12-15 10:58:59 +01:00
Christian Kamm
53a217d4e4
Don't store pointer to local job
...
There were crashes in the QPointer assignment. Possibly the thread pool
is done with the job and deletes it before the assignment is done.
2020-12-15 10:58:59 +01:00
Markus Goetz
26b5e36351
Discovery: List local directories from thread #7456 #7439
2020-12-15 10:58:59 +01:00
Markus Goetz
09a0dbbf82
Reconcile: Sort already during discovery #7445
2020-12-15 10:58:59 +01:00
Christian Kamm
a5c6612883
ConnectionValidator: increase timeout to 57s #7456
...
When the gui thread blocks for several seconds it's possible for the
ConnectionValidator to timeout and decide that the account is
unreachable. It will then terminate all sync runs.
Increasing the timeout makes this less likely to happen. The tradeoff is
that real disconnects will not be detected as quickly.
This does not address the root cause but makes the symptom less likely
to appear.
2020-12-15 10:58:59 +01:00
Markus Goetz
41dc68f99c
Propagator: Delay job execution a bit #7439
2020-12-15 10:58:58 +01:00
Christian Kamm
e37e954720
Discovery: Remove level of indent around moves
...
No code changes.
2020-12-15 10:58:58 +01:00
Christian Kamm
28797baa39
Discovery: If a move is forbidden, restore the source
...
Previously the source was deleted (or attempted to be deleted), even if
the new location was not acceptable for upload. This could make data
unavilable on the server.
For #7410
2020-12-15 10:58:58 +01:00
Christian Kamm
c9d1037622
Propagation: Fix delete-before-rename bug #7441
...
By introducing a PropagateRootDirectory job that explicitly
separates the directory deletion jobs from all the other jobs.
Note that this means that if there are errors in subJobs the
dirDeletionJobs won't get executed.
2020-12-15 10:58:58 +01:00
Markus Goetz
475117dd60
Propagator: Make sure we schedule only one job #7439
...
To not starve the event loop.
(There is still ~= 3 jobs running at the same time)
2020-12-15 10:58:58 +01:00
Christian Kamm
3446412d92
PropagateDownload: Don't try to open readonly temporaries
...
This situation could arrise when receiving a read-only share and the
temporary rename failed for some reason.
See #7419
2020-12-15 10:58:58 +01:00
Hannah von Reth
f78c4f851b
Change Windows virtual files description to tech preview
2020-12-15 10:58:57 +01:00
Christian Kamm
0ac8a3e6be
Don't fatal on "Storage temporarily unavailable"
...
This is an unreliable workaround. The real fix will need to be deferred
to another release.
For #5088
2020-12-15 10:58:57 +01:00
Hannah von Reth
afc9cd2f46
OwncloudWizard: Mark vfs as tech preview instead of experimental
2020-12-15 10:58:57 +01:00
Hannah von Reth
e5a36c3bc6
CMake VFS: Enable us to provided vfs plugins from an external directory
2020-12-15 10:58:57 +01:00
Dominik Schmidt
7e4d24de2b
SocketApi: Avoid unneccessary conversions
2020-12-15 10:58:57 +01:00
Dominik Schmidt
06ac1c33e8
SocketApi: cleanup debug output
2020-12-15 10:58:57 +01:00
Dominik Schmidt
25cd52dd9f
Add ASYNC_ASSERT_ICON_IS_EQUAL command to SocketApi
2020-12-15 10:58:57 +01:00
Dominik Schmidt
d1f9b1a4f8
Make findWidget more powerful
2020-12-15 10:58:56 +01:00
Dominik Schmidt
67656fb136
Add Q_PROPERTYs for gui testing
2020-12-15 10:58:56 +01:00
Dominik Schmidt
596154a01a
Switch GUI Testing SocketApi to Utf8
2020-12-15 10:58:56 +01:00
Dominik Schmidt
ad033e40fd
Fix build with recent Clang (on Linux)
2020-12-15 10:58:56 +01:00
Dominik Schmidt
3288a36da6
Add GUI testing SocketApi extension
2020-12-15 10:58:56 +01:00
Hannah von Reth
e97784bb9d
Don't use mutable lambdas as they hide where we modify work on a copy
2020-12-15 10:58:55 +01:00
Hannah von Reth
0f92713ce5
AccountSettings: Use switch, case to ensure we handle all cases
2020-12-15 10:58:55 +01:00
Christian Kamm
bade7aedc6
Checksums: Add back QIODevice api
...
Because the winvfs plugin needs it. But be more careful about the
device's lifetime this time.
2020-12-15 10:58:55 +01:00
Christian Kamm
18e1098e38
Remove maxLogLines config option
...
It's no longer used.
For owncloud/docs#1365
2020-12-15 10:58:55 +01:00
Christian Kamm
ea829f96ca
Download: Don't trigger too many concurrent hash computations
...
Previously the job would only become "active" when the downloads
started. That meant that arbitrarily many hash computations could be
queued at the same time.
Since the the file was opened during future creation this could lead to
a "too many open files" problem if there were lots of new-new conflicts.
To change this:
- Make PropagateDownload become active when computing a hash
asynchronously.
- Make the computation future open the file only once it gets run. This
will make it less likely for this problem to occur even if thousands
of these futures are queued.
For #7372
2020-12-15 10:58:55 +01:00
Christian Kamm
8a5a185752
Fix 'unused parameter name' warnings
2020-12-15 10:58:55 +01:00
Christian Kamm
c9dbe46542
Checksums: Fix crash due to threading issue
...
The checksum computation thread was potentially using a QFile that was
deleted in the gui thread.
For #7368
2020-12-15 10:58:54 +01:00
Christian Kamm
a587cd3a13
AccountSettings: Fetch subitems after wiping them
...
That helps avoid empty lists after account creation #7336
2020-12-15 10:58:54 +01:00
Christian Kamm
5761f4cd8a
SyncEngine: Don't duplicate fatal errors
...
Previously fatal error texts were duplicated: Once they entered the
SyncResult via the SyncFileItem and once via syncError().
syncError is intended for folder-wide sync issues that are not pinned
to particular files. Thus that duplicated path is removed.
For #5088
2020-12-15 10:58:54 +01:00
Christian Kamm
61972c35a8
Discovery: Parse etag to be consistent with RequestEtagJob
...
This avoids unnecessary sync runs.
For #7345
2020-12-15 10:58:54 +01:00
Christian Kamm
38c466efbf
Vfs: Require local discovery after disabling vfs
...
Without it local files aren't guaranteed to be downloaded #6936 .
2020-12-15 10:58:54 +01:00
Christian Kamm
55ee3f440b
Vfs: Remove old db record when dehydrating via rename
...
For #7338
2020-12-15 10:58:54 +01:00
Christian Kamm
e6990bd04e
Vfs: Make move detection work with virtual files #7001
...
Previously a checksum computation could be done on a suffix-placeholder
file, making discovery believe that no move took place.
2020-12-15 10:58:54 +01:00
Christian Kamm
00dcf3ef59
Vfs: Ensure pins change with (de-)hydration
...
Previously an implicit hydration of a file in an online-only folder
would not change the pin state and cause a dehydration on the next
sync.
2020-12-15 10:58:53 +01:00
Christian Kamm
0df3b83bd2
Vfs: Add hook to allow update-metadata for unchanged files
...
Allows winvfs to convert files to placeholders when vfs is enabled. This
is required to mark files as in-sync #7329 .
2020-12-15 10:58:53 +01:00
Christian Kamm
b34df4413b
Vfs: Improve strings for availability states
2020-12-15 10:58:53 +01:00
Christian Kamm
5bc2180478
Vfs: Preserve pin state on hydration
...
For #7322 and #7323
2020-12-15 10:58:53 +01:00
Christian Kamm
fc52c5d0cd
Vfs: Retain existing data when enabling vfs #7302
...
Previously all local data was deleted because the root folder was marked
as OnlineOnly.
2020-12-15 10:58:53 +01:00
Dominik Schmidt
92f6d866e1
Add missing OWNCLOUDSYNC_EXPORT
2020-12-15 10:58:52 +01:00
Christian Kamm
eb58352286
Vfs: Make test pass with different suffix #7279
2020-12-15 10:58:52 +01:00
Christian Kamm
5acb157a7e
VfsSuffix: Wipe stale pin states #7273
...
Previously the pin states of deleted files stayed in the 'flags'
database and could be inadvertently reused when a new file with the same
name appeared. Now they are deleted.
To make this work right, the meaning of the 'path' column in the 'flags'
table was changed: Previously it never had the .owncloud file suffix.
Now it's the same as in metadata.path.
This takes the safe parts from #7274 for inclusion in 2.6. The more
elaborate database schema changes (why use 'path' the join the two
tables in the first place?) shall go into master.
2020-12-15 10:58:52 +01:00
Christian Kamm
0e9f030b0f
RequestEtagJob: Consistently parse etags #7271
...
Previously RequestEtagJob did return the etag verbatim (including extra
quotes) while the db had the parsed form. That caused the etag
comparison during discovery move detection to always fail. The test
didn't catch it because the etags there didn't have quotes.
Now:
- RequestEtagJob will parse the etag, leading to a consistent format
- Tests have etags with quotes, detecting the problem
2020-12-15 10:58:52 +01:00
Christian Kamm
69fa1e4775
UploadDevice: Fix windows issues #7264
...
- Close the UploadDevice to close the QFile after the PUT job is done.
This allows winvfs to get an oplock on the file later.
- Don't rely on QFile::fileName() to be valid after
openAndSeekFileSharedRead() was called. The way it is openend on
Windows makes it have an empty filename.
2020-12-15 10:58:52 +01:00
Christian Kamm
fb47419e84
Vfs: Move pin state if files move #7250
...
Previously renames of items didn't carry the pin state with them.
2020-12-15 10:58:52 +01:00
Christian Kamm
34dc5e4e88
Vfs: Don't let new local files start out unpinned #7250
...
If one adds a new file to an online-only folder the previous behavior
was to upload the file in one sync and dehydrate it in the next. Now
these new files get set to Unspecified pin state, making them retain
their data.
2020-12-15 10:58:52 +01:00
Markus Goetz
62d876b09a
OAuth2: Better error logging
...
This does not fix a bug, just was found while spotting a bug that was no bug.
For https://github.com/owncloud/enterprise/issues/2951
2020-12-15 10:58:51 +01:00
Christian Kamm
452ed56571
Upload: Read file chunks gradually #7226
...
Instead of all at once, to reduce peak memory use.
Changing UploadDevice in this way requires keeping the file open for the
duration of the upload. It also means changes to open(), seek(), close()
to ensure that uses of the device work right when a request needs to
be resent.
2020-12-15 10:58:51 +01:00
Christian Kamm
a7852e3aba
Http2: Resend requests on ContentReSend error #7174
...
Since Qt does not yet transparently resend HTTP2 requests in some cases
we do it manually.
The test showed a problem where the initial non-200 reply would close
the target temporary file and the follow-up request couldn't store any
data. Removing that close() call is safe because there also is a
_saveBodyToFile flag that guards writes to the target file.
2020-12-15 10:58:51 +01:00
Olivier Goffart
c335f69a65
Discovery: Do not abort the sync in case of error 404 (or 500)
...
Issue: #7199
2020-12-15 10:58:51 +01:00
Olivier Goffart
9f08636a4a
SyncEngine: Fix renaming a single file cause the "delete all file" popup
...
Possibly a regression, since the new discovery discovers rist the renamed
files as removed
Issue #7204
2020-12-15 10:58:51 +01:00
Olivier Goffart
2c975b1e70
SocketAPI: Fix string claiming a folder is a file
...
Issue #7206
2020-12-15 10:58:51 +01:00
Markus Goetz
46c336503a
Log Window: Create and open folder properly #7166
2020-12-15 10:58:50 +01:00
Christian Kamm
ee1078b768
owncloudcmd: log sync errors
...
Previously it was hard to debug some errors since the messages would not
show up in the output.
2020-12-15 10:58:50 +01:00
Christian Kamm
b974f579ae
Chunked upload: Fix percent encoding in If header #7176
2020-12-15 10:58:50 +01:00
Christian Kamm
9f3578b276
Tests: Fix DB locking issue in permissions test
2020-12-15 10:58:50 +01:00
Christian Kamm
a0457d5e1d
Tests: fix vfs availability test case
2020-12-15 10:58:50 +01:00
Christian Kamm
edad7ce7d7
Vfs: Mark sqlite temporaries excluded on db-open #7141
...
The previous patch ensured that the sqlite temporaries weren't deleted
and recreated for every sync run, but there was still time between
client startup and the first sync run where they would have the
"needs-sync" icon.
2020-12-15 10:58:50 +01:00
Christian Kamm
7774b8049e
Vfs: Distinguish availability error kinds #7143
...
Previously "no-availability" meant db-error and querying the
availability of a nonexistant path returned AllHydrated.
Now, the availability has a DbError and a NoSuchItem error case.
2020-12-15 10:58:49 +01:00
Christian Kamm
1e5ae77994
Fix logic for duration that an etag reply indicates connectivity
...
This got inverted accidentally when std::chrono was introduced.
For #7160
2020-12-15 10:58:49 +01:00
Christian Kamm
7f3f13fd97
Vfs: "free space" only shows when it has an effect #7143
...
To do this, introduce AllDehydrated availability and rename
SomeDehydrated to Mixed - it now guarantees there are also hydrated
items.
2020-12-15 10:58:49 +01:00
Christian Kamm
40d9fc4f4b
Vfs: Adjust and centralise action text #7143
...
Saying "Currently available locally" sounds more like an indicator than
"Availably locally" does. Centralizing translations avoids consistency
issues between shell context menus and sync folder context menu.
2020-12-15 10:58:49 +01:00
Christian Kamm
021f994584
FolderWizard: Don't crash when typing invalid drive #7041
...
When the user typed "x:" where the drive x didn't exist, the validation
function would loop forever. Now it shows a "path doesn't exist" error.
2020-12-15 10:58:49 +01:00
Christian Kamm
21cb93e3ce
SyncEngine: Don't close db when done #7141
...
The db-close operation is likely a leftover from when the SyncEngine
owned its own db connection and serves no purpose anymore.
Closing the db causes the removal of the temporary wal and shm files.
These files are recreated when the db is opened again, which happens
almost immediately.
This is a problem for winvfs because the delete-recreate step wipes the
exclusion state on these files just after the sync is done. That meant
that the db temporaries permanently had a "needs sync" icon marker shown
in the explorer.
Avoiding reopening the db also reduces the number of log messages per
sync.
2020-12-15 10:58:48 +01:00
Christian Kamm
a4f357ee4b
Sqlite: Use FULL synchronous mode with non-WAL journal
...
According to the documentation DELETE+NORMAL isn't safe from corruption
on older file systems.
2020-12-15 10:58:48 +01:00
Christian Kamm
076e24f465
Log: Start logging immediately when "permanent logs" enabled #7146
...
Previously one would need to wait for the next sync run to create the
first log file.
2020-12-15 10:58:48 +01:00
Christian Kamm
772a210cc9
Mention selective sync when switching on vfs
2020-12-15 10:58:48 +01:00
Christian Kamm
cfbcdc01db
Discovery: Improvements to doc comments
2020-12-15 10:58:48 +01:00
Christian Kamm
fbe2dbf4ab
Discovery: Query data-fingerprint on root item
...
Previously the property wasn't queried, meaning the fingerprint logic
couldn't get triggered.
2020-12-15 10:58:48 +01:00
Christian Kamm
c50f041c5b
Discovery: 403 and 503 on root cause error
...
Previously these result codes during remote discovery of the sync root
would not cause an error and the discovery would get stuck.
Also extends RemoteDiscovery tests to check for errors on the root item.
2020-12-15 10:58:48 +01:00
Christian Kamm
7b96321df2
PropagateIgnore: Default to NormalError for INSTRUCTION_ERROR
...
Previously if one set the instruction to ERROR while forgetting to set
an error status, it'd propagate as FileIgnored. Now the default is
NormalError for INSTRUCTION_ERROR and FileIgnored for
INSTRUCTION_IGNORE.
2020-12-15 10:58:47 +01:00
Christian Kamm
da40e84aec
About: Add remark about vfs plugin that's in use #7137
2020-12-15 10:58:47 +01:00
Christian Kamm
2bffde2600
Fix windows build
2020-12-15 10:58:47 +01:00
Christian Kamm
22234e0e73
LogWindow: Remove output, add "go to log folder" button #6475
2020-12-15 10:58:47 +01:00
Christian Kamm
dcf34316fd
Vfs: Add 'availability', a simplified, user-facing pin state #7111
...
The idea is that the user's question is "is this folder's data available
offline?" and not "does this folder have AlwaysLocal pin state?".
The the answers to the two questions can differ: an always-local
folder can have subitems that are not always-local and are dehydrated.
The new availability enum intends to describe the answer to the user's
actual question and can be derived from pin states. If pin states aren't
stored in the database the way of calculating availability will depend
on the vfs plugin.
2020-12-15 10:58:47 +01:00
Christian Kamm
590db28541
Vfs: Clear up relationship between _type and pin state
...
The pin state is a per-item attribute that has an effect on _type:
AlwaysLocal dehydrated files will be marked for hydration and OnlineOnly
hydrated files will be marked for dehydration.
Where exactly this effect materializes depends on how the pin states are
stored. If they're stored in the db (suffix) the dbEntry._type is
changed during the discovery.
If the pin state is stored in the filesystem, the localEntry._type must
be adjusted by the plugin's stat callback.
This patch makes pin states behave more consistently between plugins.
Previously with suffix-vfs pin states only had an effect on new remote
files. Now the effect of pinning or unpinning files or directories is as
documented and similar to other plugins.
2020-12-15 10:58:46 +01:00
Christian Kamm
2738f110f2
Sqlite: Update to 3.27.2
2020-12-15 10:58:46 +01:00
Christian Kamm
cd10e3d28c
PropagateDirectory: Set initial dir mtime to server mtime #7119
...
It's still not synced in any way later.
2020-12-15 10:58:46 +01:00
Christian Kamm
69887c531e
PropagateDirectory: Remove dead code
...
1. The _firstJob is usually deleted by the time the PropagateDirectory
finishes. (deleteLater() is called early)
2. The PropagateDirectory::_item and PropagateRemoteMkdir::_item point
to the same SyncFileItem anyway. This code is a leftover from when
each job had its own instance.
2020-12-15 10:58:46 +01:00
Christian Kamm
fd9b01981b
Detect missing server data during discovery #7112
...
This has two positive effects:
- We can put the error on the particular file that has missing data
- We can sync all other files
2020-12-15 10:58:46 +01:00
Christian Kamm
4bab93b246
Vfs: Better handling and more tests for suffix file renames
...
Previously removing the vfs suffix of a file always triggered a
conflict. Now it may just cause a file download.
This was done because users expected symmetry in the rename actions and
renaming foo -> foo.owncloud already triggers the "make the file
virtual" action. Now foo.owncloud -> foo triggers the "download the
contents" action.
2020-12-15 10:58:46 +01:00
Christian Kamm
5e5b0b3f76
Vfs suffix: Require suffix when creating placeholder files
2020-12-15 10:58:45 +01:00
Christian Kamm
3f55f9302e
Vfs: Hydrating a virtual is SYNC not NEW #7101
...
Previously it'd be NEW(ItemTypeFile), but now it has changed to be
SYNC(ItemTypeVirtualFileDownload) which allows better classification.
2020-12-15 10:58:45 +01:00
Christian Kamm
e0c8acc195
Notifications: Don't say "downloaded" for new files #7101
...
These files may very well just be new virtual files that were explicitly
*not* downloaded.
2020-12-15 10:58:45 +01:00
Christian Kamm
0c0049c908
Local discovery tracking: On success, also wipe _renameTarget
...
It's possible that the rename target was in the local discovery list.
2020-12-15 10:58:45 +01:00
Christian Kamm
04e0e22513
Protocol, Notifications: Show destination() instead of _file
...
destination() now consistently points to the file after the successful
sync operation. _file might be the place the item was moved from.
2020-12-15 10:58:45 +01:00
Christian Kamm
47f10fbf96
Fix and test _file and _renameTarget
...
There was a bunch of inconsistency around whether _file was set to
_renameTarget or not. This is now never done, passing on more
information.
2020-12-15 10:58:44 +01:00
Olivier Goffart
afbb580528
Test: fix compilation with GCC 4.9
...
It does not appear to support variadic lambda
2020-12-15 10:58:44 +01:00
Christian Kamm
0cf19123a7
VFS: Unbreak behavior for rename+hydrate #7001
...
Users can rename a file *and* add/remove the vfs suffix at the same time
leading to very complex sync actions. This patch doesn't add support for
them, but adds tests and makes sure these cases do not cause unintened
behavior.
The rename will be propagated, but the users's hydrate/dehydrate request
will be ignored.
2020-12-15 10:58:44 +01:00
Olivier Goffart
4346567a03
Async Poll: keep the size in the database
...
This was not required with 2.5 because a size of 0 was ignorted when comparing
size by the csync updater, to be compatible with very old version of the database.
But the we discovery will still think the file is changed if the database contains
a size of 0
2020-12-15 10:58:44 +01:00
Olivier Goffart
46bf3ed31a
Upload: asynchronious operations
...
Implements https://github.com/owncloud/core/pull/31851
2020-12-15 10:58:44 +01:00
Markus Goetz
32c60c2f5d
macOS: Fix vfs suffix plugin paths #7090
2020-12-15 10:58:44 +01:00
Christian Kamm
d496aa5933
Linux: Add autostart delay to avoid tray issues #6518
...
It seems that sometimes the tray implementation isn't ready on system
startup. Retrying later seems to not help. Delaying the start of the
client is the workaround that people have reported as effective.
2020-12-15 10:58:43 +01:00
Markus Goetz
5da48a5239
SocketApi: Fix owncloud/enterprise#2938
2020-12-15 10:58:43 +01:00
Christian Kamm
2f7cdb81cf
Tray: Try to establish tray after 10s if failed initially #6518
...
When owncloud is started during desktop startup the tray may not yet
be running when the client starts. This will make the client attempt
to create a tray icon again after 10 seconds if there's no tray
during initial startup.
2020-12-15 10:58:43 +01:00
Christian Kamm
4bd062f5be
OwnSql: Distinguish no-data from error #6677
...
This could fix a problem where the client incorrectly decides to delete
local data.
Previously any sqlite3_step() return value that wasn't SQLITE_ROW would
be interpreted as "there's no more data here". Thus an sqlite error at a
bad time could cause the remote discovery to fail to read an unchanged
subtree from the database. These files would then be deleted locally.
With this change sqlite errors from sqlite3_step are detected and
logged. For the particular case of SyncJournalDb::getFilesBelowPath()
the error will now be propagated and the sync run will fail instead of
performing spurious deletes.
Note that many other database functions still don't distinguish
not-found from error cases. Most of them won't have as severe effects on
affected sync runs though.
2020-12-15 10:58:43 +01:00
Christian Kamm
ee6a48b3dc
Client certs: Store pkcs12 in config, password in keychain
...
It still reads and writes the old format too, but all newly stored
client certs will be in the new form.
For #6776 because Windows limits credential data to 512 bytes in older
versions.
2020-12-15 10:58:43 +01:00
Christian Kamm
cc840534c0
Add PLUGINDIR cmake setting and define #7027
...
By default, plugins are only searched next to the binary or next to the
other Qt plugins. This optional build variable allows another path to be
configured.
The idea is that on linux the oC packaging probably wants the binary in
something like /opt/owncloud/bin and the plugins in
/opt/owncloud/lib/plugins.
Similarly, distribution packagers probably don't want the plugins next
to the binary or next to the other Qt plugins. This flag allows them to
configure another path that the executable will look in.
2020-12-15 10:58:43 +01:00
Olivier Goffart
87bd26bf6c
AccountManager: load the cookies
...
For issue #7054
2020-12-15 10:58:43 +01:00
Christian Kamm
575935ded0
Windows: Forbid chars 0-31 in filenames #6987
2020-12-15 10:58:42 +01:00
Christian Kamm
a72bf89779
Selective sync: Don't collapse tree when entering mode #7055
...
doExpand() is called when the selective sync editing mode is enabled in
the folder settings view. Previously it'd set the expansion to be
exactly the root items. Now, it just expands any root items that are
currently collapsed, leaving all other item expansion unchanged.
2020-12-15 10:58:42 +01:00
Christian Kamm
2e11f14a6b
SocketApi: Fix crash with readyRead() after disconnected() #7044
...
With the recent bugfix to avoid sending messages on dead connections
0bfe7ac250c54f5415c0a794c7b271428e83c3cf
the client now crashed if readyRead() was received after disconnected()
for the socket as the listener for that connection was already removed.
This code fixes it by still invoking the handler from readyRead() but
passing a SocketListener that won't attempt to send messages.
2020-12-15 10:58:42 +01:00
Christian Kamm
6199e140a5
Wizard: Avoid cert dialog multiple connection
...
This could lead to odd behavior when slotCertificateAccepted
was called multiple times.
2020-12-15 10:58:42 +01:00
Christian Kamm
83268c255a
Folder wizard: Fix infinite loop for bad paths #7041
2020-12-15 10:58:42 +01:00
Christian Kamm
93afc2a04b
Discovery win: Fix detection of case-only renames
...
Previously they were detected as DELETE+NEW because if "a" is renamed to
"A" then QFile::exists("a") will still return true on Windows.
2020-12-15 10:58:42 +01:00
Christian Kamm
238ac53666
Ensure local discovery on selective sync changes
...
As far as I'm aware local discovery can be skipped on folders that are
selective-sync blacklisted, so a local discovery is required when an
entry is removed from the blacklist.
Also rename
avoidReadFromDbOnNextSync() -> schedulePathForRemoteDiscovery()
since the old name might also imply it's not read from db in the local
discovery - which is not the case. Use Folder::
schedulePathForLocalDiscovery() for that.
2020-12-15 10:58:41 +01:00
Christian Kamm
4c04351360
Fix warnings about signedness
...
Sizes are always qint64, not unsigned.
TransferIds are always uint.
2020-12-15 10:58:41 +01:00
Christian Kamm
60cb5d3b34
Tests: Fix permission propagation check
...
It was using the wrong path to the conflict file.
2020-12-15 10:58:41 +01:00
Christian Kamm
5089f55629
Test: Add check for permission propagation
...
Also covering propagation to the downloaded file when a conflict-rename
is done at the same time, which used to not work.
2020-12-15 10:58:41 +01:00
Christian Kamm
aed1f28980
Tests: Add db checks to rename/move tests
...
For moves it's relevant that the old db entry is removed and the new one
is created at the right location.
2020-12-15 10:58:41 +01:00
Christian Kamm
910ccaf600
Vfs: Improve sync protocol entries for actions
...
Creating a new virtual file and replacing a file with a virtual one now
have their own text in the protocol, not just "Downloaded".
To do this, the SyncFileItem type is kept as
ItemTypeVirtualFileDehydration for these actions. Added new code to
ensure the type isn't written to the database.
While looking at this, I've also added documentation on SyncFileItem's
_file, _renameTarget, _originalFile and destination() because some of
the semantics weren't clear.
2020-12-15 10:58:41 +01:00
Christian Kamm
f24687ec93
Vfs: Make dehydration a SYNC and not a NEW action
...
That change will be useful for the notifications. Previously the
dehydrated files were reported as "newly downloaded", now they're
reported as "updated".
2020-12-15 10:58:40 +01:00
Christian Kamm
797734870f
PropagateDownload: Create conflict even if local file changed
...
Fixes a bug introduced while moving the attribute propagation before the
conflict-renaming.
2020-12-15 10:58:40 +01:00
Christian Kamm
8a8e93827f
Vfs suffix: Fix dehydration creating the wrong db entry
2020-12-15 10:58:40 +01:00
Christian Kamm
b06f67baf0
Vfs: Ensure VfsOff works without start() being called
...
In tests an un-started Vfs instance is sometimes passed to SyncEngine
via SyncOptions.
2020-12-15 10:58:40 +01:00
Christian Kamm
6a977edeee
Vfs: Remove VfsDefaults
...
That just complicated things. It's ok if Vfs is not a fully abstract
interface class.
The pinstate-in-db methods are instead provided directly on Vfs and
VfsSuffix and VfsOff use them to implement pin states.
The start() method is simply non-virtual and calls into startImpl() for
the plugin-specific startup code.
2020-12-15 10:58:40 +01:00
Christian Kamm
e9cbe13598
Vfs: Add option to hide socketapi pin actions
...
Because some plugins provide alternative ui.
2020-12-15 10:58:40 +01:00
Christian Kamm
e6ee5d0f8a
PropagateDownload: Conflict-rename later
...
The block of code that propagated attributes etc from the previously
existing file was placed *after* the block that renamed the previously
existing file to a conflict name. That meant the propagation didn't work
in the conflict case.
2020-12-15 10:58:39 +01:00
Christian Kamm
6c5fa1dadd
Vfs: dehydration is separate action
...
Allows for better attribute preservation.
Also add verifyFileUnchanged() call before dehydration to avoid data
loss when discovery takes a while.
2020-12-15 10:58:39 +01:00
Christian Kamm
d8873c18a1
File watcher: Pin state attribute changes are valid notifications
...
Previously they would be discarded since the file's mtime or size hadn't
changed.
2020-12-15 10:58:39 +01:00
Christian Kamm
83a818678f
PinStates cleanup
...
- SyncJournalDB functions now behind internalPinStates() to avoid
accidental usage, when nearly everyone should go through Vfs.
- Rename Vfs::getPinState() to Vfs::pinState()
2020-12-15 10:58:39 +01:00
Christian Kamm
0eb4065197
Folder: Add remoteFolderTrailingSlash()
...
There were cases where the "/" exception wasn't handled correctly
and there'd be extra slashes in generated paths.
2020-12-15 10:58:39 +01:00
Christian Kamm
41f1ddb5fc
Vfs: Call unregisterFolder() when folder is removed
2020-12-15 10:58:39 +01:00
Christian Kamm
597cc60f52
Vfs: Enable propagating attributes on download
2020-12-15 10:58:38 +01:00
Christian Kamm
01f7bc7b49
SyncFileStatusTracker: Distinguish Warning and Excluded
...
Any folder with a (potentially deeply) contained error will have
StatusWarning. StatusExcluded marks exclusions. The difference is useful
to know for VFS.
2020-12-15 10:58:38 +01:00
Christian Kamm
7f400e3226
Pin state updates
...
- unspecified and inherited are different
- move enum to header in common/
- access through Vfs instead of directly in Journal
2020-12-15 10:58:38 +01:00
Christian Kamm
2722c61515
Vfs: Shell integration is enabled optionally
...
Needs to be disabled for tests in some cases.
2020-12-15 10:58:38 +01:00
Christian Kamm
f89450648f
Vfs: Clarify SyncEngine::wipeVirtualFiles()
...
Possibly the behavior should actually change and the function should
de-placeholder all items, not just dehydrated ones.
2020-12-15 10:58:38 +01:00
Christian Kamm
5820ac8b41
Discovery: Files can have dehydrate/download actions
...
This will be used in conjunction with vfs plugins that detect whether a
file has a pending hydration/dehydration through independent means and
communicate that to the discovery through local file type.
2020-12-15 10:58:38 +01:00
Christian Kamm
af1666788e
Discovery: Add signal for silentlyExcluded files
...
This allows SyncFileStatusTracker to also know about these. After all
its information is used to provide icons for them too.
2020-12-15 10:58:37 +01:00
Christian Kamm
e2eea24a03
Vfs: Send SyncFileStatusTracker data to vfs plugins
2020-12-15 10:58:37 +01:00
Christian Kamm
31394f14b5
Vfs: Make files that end up in db placeholders
...
Since 'placeholder' just means that it's an item of the special type
that the vfs plugin can deal with - no matter whether hydrated or
dehydrated - all done items should become placeholders. Even
directories.
Now every file that passes through updateMetadata() will be converted to
a placeholder if necessary.
2020-12-15 10:58:37 +01:00
Christian Kamm
ca0323e1e7
Propagator: Helper for updating db
...
Similar steps were done in many propagation jobs.
This also updates the db entry to always have the item.destination() as
file path.
2020-12-15 10:58:37 +01:00
Christian Kamm
fe27804afb
Move SyncFileStatus to libcommon
...
It'll be needed in vfs plugins so they can connect to the data coming
out of SyncFileStatusTracker.
2020-12-15 10:58:37 +01:00
Christian Kamm
1cc41427fc
Build fix for mingw64 7.3 (Qt 5.12.0)
2020-12-15 10:58:37 +01:00
Christian Kamm
4d58208676
File watcher: Reduce touch ignore duration
...
On Linux and Windows the file watcher can't distinguish between changes
that were caused by the process itself, like during a sync operation,
and external changes. To work around that the client keeps a list of
files it has touched and blocks notifications on these files for a bit.
The duration of this block was originally and arbitrarily set at 15
seconds. During manual tests I regularly thought there was a bug when
syncs didn't trigger, when the only problem was that my changes happened
too close to a previous sync operation.
This change reduces the duration to three seconds. I imagine that this
is still enough.
Also use std::chrono while at it.
2020-12-15 10:58:36 +01:00
Dominik Schmidt
539cef345e
Switch to standard opt-out BUILD_TESTING instead of opt-in UNIT_TESTING
...
Compare https://cmake.org/cmake/help/v3.0/module/CTest.html
Craft automatically handles BUILD_TESTING, so we don't need to handle it
in our own blueprint.
2020-12-15 10:58:36 +01:00
Christian Kamm
13890c04a7
HttpCreds: Warn in log if keychain-write jobs fail #6776
...
Also, calling deleteLater() on jobs is unnecessary (they autodelete
after finished()) and deleting the attached QSettings is also
unnecessary because the settings object is parented to the job.
2020-12-15 10:58:36 +01:00
Christian Kamm
1a250bc3c7
Download: Ignore content-length for compressed HTTP2/SPDY replies #6885
...
It contains the compressed size.
See https://bugreports.qt.io/browse/QTBUG-73364
2020-12-15 10:58:36 +01:00
Christian Kamm
848b869cdf
SocketAPI: Remove listener immediately on lost connection
...
To avoid situations where messages are attempted to be sent to dead
connections.
2020-12-15 10:58:36 +01:00
Christian Kamm
0eebd77d2c
SocketAPI OSX: Forbid further sends on connectionDidDie
...
Also release the remote end immediately.
2020-12-15 10:58:36 +01:00
Olivier Goffart
6f4bf585f0
Move: Fix move detection in directory move on the other side
2020-12-15 10:58:35 +01:00
Olivier Goffart
88d02a887f
Move: add comments and tests
2020-12-15 10:58:35 +01:00
Olivier Goffart
1fb4c22adf
Move: add more test and fix move within moves
2020-12-15 10:58:35 +01:00
Olivier Goffart
ade4c11de3
Rename: fix renamed folder moved into renamed folder issue
...
Issue #6694
2020-12-15 10:58:35 +01:00
Christian Kamm
f3be99e5b2
vfs: Update pinning context menu to be less confusing
...
Seeing "Currently available online only" for a currently hydrated file
was odd. It makes sense since current hydration status and pin state are
independent.
The new text will say something like "Currently available, but marked
online only" to better indicate that the file might be dehydrated later
since it wasn't pinned.
2020-12-15 10:58:35 +01:00
Christian Kamm
b7079289c2
Vfs: Switch on/off only when sync isn't running #6936
...
Avoids some situations that might cause data loss.
2020-12-15 10:58:34 +01:00
Christian Kamm
5728256763
Folder: Add selective sync / ui related flags
...
supportsSelectiveSync(): clearer than !supportsVirtualFiles() and allows
extra logic
isVfsOnOffSwitchPending(): Somewhat awkward way of dealing with the
phase between a user requesting vfs state to be switched and it
actually happening
2020-12-15 10:58:34 +01:00
Christian Kamm
b91839b760
SyncEngine: Rename phase finishing slots
...
slotDiscoveryJobFinished -> slotDiscoveryFinished
slotFinished -> slotPropagationFinished
This should be clearer. Particular the
slotFinished -> finalize -> emit finished()
chain was confusing before.
2020-12-15 10:58:34 +01:00
Christian Kamm
9f8505c736
Discovery: Fix aborting during discovery #6972
2020-12-15 10:58:34 +01:00
Christian Kamm
836d298141
vfs suffix: Ignore server files or synced files with the suffix #6953
2020-12-15 10:58:34 +01:00
Christian Kamm
e774c6c739
Discovery: Ensure selective sync lists are sorted #6958
2020-12-15 10:58:34 +01:00
Christian Kamm
22255e4976
vfs: Add vfs migration options to folder context menu
...
This allows enabling and disabling vfs.
To distinguish this operation from setting the root pin state, the
availability setting is adjusted as well to be similar to the
menu that shows in the shell extensions.
2020-12-15 10:58:33 +01:00
Christian Kamm
20ef0a0290
vfs: Allow retrieving of pin state paths and flags
2020-12-15 10:58:33 +01:00
Christian Kamm
7ef6e60660
Result: Add copy/move ctor/op=
...
It has a destructor and these operations make sense. Particularly the
move is important for code like:
Result<x, y> foo() { Result<x, y> v; return v; }
because the move-ctor will not autogenerate if x or y are not trivially
destructible.
2020-12-15 10:58:33 +01:00
Christian Kamm
3b923e2afe
vfs: Change per-folder message on vfs support
...
I'm unsure this note is all that useful. Remove entirely?
2020-12-15 10:58:33 +01:00
Christian Kamm
4df101ed84
vfs: Allow (de-)hydrating the full sync folder
2020-12-15 10:58:33 +01:00
Christian Kamm
47e21bfc60
vfs: Don't assume suffix mode for old folders
...
That would break with old folders that use selective sync.
2020-12-15 10:58:33 +01:00
Christian Kamm
cbb32edee2
vfs: Disable selective sync if vfs support is available
2020-12-15 10:58:32 +01:00
Christian Kamm
aa23058d76
Wizard: Ensure client cert doesn't get lost #6911
2020-12-15 10:58:32 +01:00
Christian Kamm
c470825c8f
Wizard: Drop unused function
2020-12-15 10:58:32 +01:00
Markus Goetz
4fcad0d8b0
Sync: Display theme in debug log
2020-12-15 10:58:32 +01:00
Christian Kamm
b4e73690b7
sqlite: Set exclusive locking_mode to avoid WAL issues #6881
...
Can be overridden with OWNCLOUD_SQLITE_LOCKING_MODE
2020-12-15 10:58:32 +01:00
Dominik Schmidt
17465a6f94
Fix lookup of system wide settings
2020-12-15 10:58:32 +01:00
Olivier Goffart
f258af1198
sqlite: Update bundled version to 3.26.0
...
For OS X and Windows.
2020-12-15 10:58:31 +01:00
Olivier Goffart
c31d3f277f
HttpCredentials: Do not re-enter the event loop
...
https://sentry.io/owncloud/desktop-win-and-mac/issues/777907931/
mention a crash in OCC::HttpCredentialsGui::showDialog
One possible explaination is that this is caused by re-entring the event loop.
So don't do that.
2020-12-15 10:58:31 +01:00
Olivier Goffart
51d2e41d8b
Chunking Move: Fix too many starting slashes in the destination header
...
Commit 6ca724f fixed it for the move case. But the upload MOVE did the same
Issue #6904
2020-12-15 10:58:31 +01:00
Olivier Goffart
0e56dfe3a4
Gui: do not show the settings when opening a virtual file
...
Issue #6764
2020-12-15 10:58:31 +01:00
Christian Kamm
c4dfa82661
SocketAPI: Overhaul ui for 'available locally' vs 'online only'
...
For #6815
2020-12-15 10:58:30 +01:00
Christian Kamm
aa382eda29
Db: Add wiping of pin state for subtrees
2020-12-15 10:58:30 +01:00
Christian Kamm
d956f518a8
vfs: Remove newFilesAreVirtual - use root PinState instead
...
This unifies how to deal with pin states.
Also enable reading a folders direct pin state vs its effective pin
state.
2020-12-15 10:58:30 +01:00
Olivier Goffart
62ec4c9330
Discovery: Handle the blacklistFiles from the server capabilities
...
Issue #434
Ideally one could add the blacklist to the exlucde reggexp, but this
is simpler
2020-12-15 10:58:30 +01:00
Christian Kamm
8fecff5153
Progress: Virtual file creation needs no transfer progress #6933
...
Treat virtual file creation as a size-less action, similar to
propagating renames or deletions.
2020-12-15 10:58:30 +01:00
Christian Kamm
cdf61b9e82
vfs: Show "new files are virtual" option only with vfs
...
If there's no vfs possibility, showing it makes little sense.
2020-12-15 10:58:30 +01:00
Christian Kamm
8f895fc83c
vfs: SocketAPI actions adjust pin state of directories #6815
...
Downloading a folder also sets its pin state; releasing a folder sets
its pin state.
2020-12-15 10:58:29 +01:00
Christian Kamm
486c25cb47
vfs: Use PinState in sync algorithm #6815
...
New files are virtual if the file's pin state is OnlineOnly.
2020-12-15 10:58:29 +01:00
Christian Kamm
68126ac208
vfs: Introduce PinState db storage #6815
...
The idea is to allow folders (and later maybe files?) to be
- pinned to be available locally
- pinned to be online only
- inherit their pin from the parent
Where this pinning only controls the default for new files.
Subfolders may have a different pin state, and contained files
may be hydrated or dehydrated based on user actions.
This value is stored in a new 'flags' table. The idea is to store
data there that doesn't necessarily exist for each metadata entry.
The selective sync state could be migrated to this table.
2020-12-15 10:58:29 +01:00
Olivier Goffart
dfedb09fd8
Move test for issue #1329 from t1.pl to new test system
2020-12-15 10:58:29 +01:00
Olivier Goffart
a29320b18d
Discovery: Set right direction when restoring deleted discovery because it has modified files
...
(Catched by a faillure of t1.pl)
2020-12-15 10:58:29 +01:00
Olivier Goffart
6da96cd026
Port the exclude test to the QTest Framework
...
This is just a port to QtTest, I did not change the layout of the test.
I did search and replace to replace the assert with QCOMPARE/QVERIFY
I still call setup and setup_init like before (only explicitly, now)
Also ported the preformence tests to QBENCHMAK because windows don't have
gettimeofday.
Relates #6358
2020-12-15 10:58:29 +01:00
Olivier Goffart
fad1238b33
Test: Move the test for Utility::normalizeEtag to testutility.cpp
...
I just moved the text and did the minimum to port it to QtTest
Did not change hte layout of it.
Relates #6358
2020-12-15 10:58:28 +01:00
Olivier Goffart
6e048a2d3f
Remove check_csync_util
...
It's testing nothing.
Only that one can convert a csync instruction to a string.
But this is only used in debug anyway
Relates to #6358
2020-12-15 10:58:28 +01:00
Christian Kamm
69144566ce
Database: Change path for new dbs to .sync_* #5904
...
This is to avoid issues on OSX, where the ._ prefix has special meaning.
Originally (before 2.3.2) ._ was necessary to guarantee exclusion. But
since then the .sync_ prefix is excluded as well.
This does not affect existing database files.
2020-12-15 10:58:28 +01:00
Christian Kamm
30294e0c9a
Vfs: Have a static list of potential plugins for now
...
Fixes in-source builds and other cases where more non-plugin directories
are created in src/libsync/vfs.
2020-12-15 10:58:28 +01:00
Christian Kamm
75b9976526
Vfs: Ensure older versions gracefully ignore winvfs folders
...
Previously there'd likely be a mess if a 2.6 winvfs folder was attempted
to be used with a 2.5 client. Now the older clients will ignore these
folders.
2020-12-15 10:58:28 +01:00
Christian Kamm
bdfda460e6
Vfs plugins: Available plugins must load
...
A plugin that can't be loaded due to dependency issues should not be
considered as available.
2020-12-15 10:58:28 +01:00
Olivier Goffart
fd410a5a84
SyncEngine: Ensure that the paths passed to the discovery ends with slashes
...
This was making the tx.pl test fail
2020-12-15 10:58:28 +01:00
Olivier Goffart
edd806960d
Propagator: Don't abort sync on error 503
...
Only do it when it is actually a maintenance mode
Issues #5088 , #5859 , https://github.com/owncloud/enterprise/issues/2637
2020-12-15 10:58:27 +01:00
Olivier Goffart
feb770eca7
Allow to open log window via command line to already running client
...
Issue: #4098
2020-12-15 10:58:27 +01:00
Dominik Schmidt
687eb9665d
Fix installation of vfs suffix plugin
2020-12-15 10:58:27 +01:00
Olivier Goffart
a7a54b6d11
VFS: Plugin needs to be installed, otherwise it can't be loaded
2020-12-15 10:58:27 +01:00
Olivier Goffart
47b2913357
Fix compilation warning
...
src/libsync/propagatorjobs.cpp:63:10: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
[this, &deleted](const QString &path, bool isDir) {
^~~~~
2020-12-15 10:58:27 +01:00
Christian Kamm
d87c2b803d
vfs: Make Vfs ctor explicit
2020-12-15 10:58:27 +01:00
Christian Kamm
305d439c41
vfs: Separate vfs availability from new-files-virtual
...
This helps support 2.5 settings where there are virtual files in the
tree but new files aren't created virtual.
It's also a prelude for #6815
There's currently no way of
- upgrading vfs plugins (a silent suffix->winvfs upgrade is attempted
once only, when moving to master)
- disabling vfs capabilities outright
2020-12-15 10:58:27 +01:00
Christian Kamm
1e5e884805
vfs: Don't always load plugins, check metadata
2020-12-15 10:58:26 +01:00
Christian Kamm
cc912f4d02
vfs: ensure backwards-compatible settings value is always set
2020-12-15 10:58:26 +01:00
Christian Kamm
b30f79edf6
vfs: Ensure SyncOptions::_vfs is never null
...
- Create a VfsOff derived class
- Make it a shared pointer shared with Folder::_vfs
2020-12-15 10:58:26 +01:00
Christian Kamm
842577e014
vfs: Switch order of deletion and journal removal in dehydration
...
To be more crash-resilient.
2020-12-15 10:58:26 +01:00
Christian Kamm
4e40b635da
vfs: Update outdated comment
2020-12-15 10:58:26 +01:00
Christian Kamm
d7ad7854c1
vfs: Ensure local discovery is done on dehydration request
2020-12-15 10:58:26 +01:00
Christian Kamm
f2b78b5efb
Folder settings: Keep "usePlaceholders" to be backwards compatible
2020-12-15 10:58:25 +01:00
Christian Kamm
fa2450cf11
vfs: Be more careful about Vfs instance ownership
2020-12-15 10:58:25 +01:00
Christian Kamm
9196aa8e0a
vfs: Remove VfsSuffixPrivate
2020-12-15 10:58:25 +01:00
Christian Kamm
5b26b739f0
vfs: Document ignored return value.
2020-12-15 10:58:25 +01:00
Christian Kamm
77e5b956d1
Plugin: Drop PluginLoader
2020-12-15 10:58:25 +01:00
Christian Kamm
9bc28e3006
Plugin: style fixes
2020-12-15 10:58:25 +01:00
Christian Kamm
a5264f7740
Checksums: Make file ownership more explicit
2020-12-15 10:58:24 +01:00
Christian Kamm
9ced8dd836
vfs: Improve modeFromString() signature
2020-12-15 10:58:24 +01:00
Christian Kamm
f502a526fa
Generalize Result<> class, add Optional<>
...
To make it nicer to use outside of HTTP results.
2020-12-15 10:58:24 +01:00
Christian Kamm
e7e6b839c0
vfs: Add API docs
2020-12-15 10:58:24 +01:00
Dominik Schmidt
bd22caa5ec
Remove unused include directories
2020-12-15 10:58:24 +01:00
Christian Kamm
85dd10eb9b
vfs: Fix dealing with missing vfs instance
...
Maybe there should just be a VfsOff instance to make this less error
prone.
2020-12-15 10:58:24 +01:00
Dominik Schmidt
bfe136da7a
Fix export of vfs functions
2020-12-15 10:58:23 +01:00
Dominik Schmidt
1104883fba
Cleanup CMake (output)
2020-12-15 10:58:23 +01:00
Christian Kamm
f074c1a07b
vfs: Add check for presence of win plugin
2020-12-15 10:58:23 +01:00
Christian Kamm
4bef96afe7
vfs: Make switching vfs on/off work again
2020-12-15 10:58:23 +01:00
Christian Kamm
fa6f3cd847
vfs: Fix plugin decision in wizards, sanitize loading
2020-12-15 10:58:23 +01:00
Christian Kamm
d5a3604d39
vfs: Reenable local metadata updating of vfs files
2020-12-15 10:58:23 +01:00
Christian Kamm
96f4fd46e5
vfs: Make some behaviors suffix-vfs specific
2020-12-15 10:58:23 +01:00
Christian Kamm
90827c8162
vfs: Allow remote renames to propagate as such
2020-12-15 10:58:22 +01:00
Christian Kamm
e0ae6012b1
vfs: Allow folders without vfs
2020-12-15 10:58:22 +01:00
Christian Kamm
e39d751b59
Fix big-folder detection when vfs is disabled
2020-12-15 10:58:22 +01:00
Christian Kamm
bee1b0edd4
vfs: Implement dehydration tagging
2020-12-15 10:58:22 +01:00
Christian Kamm
ae9a7e088f
vfs: Fix suffix detection and handling
2020-12-15 10:58:22 +01:00
Christian Kamm
1ed005aafe
winvfs: Better error reporting
...
- fix download and validation error reporting
- add tests
2020-12-15 10:58:22 +01:00
Christian Kamm
0f2ef42ba2
Fixes after rebase to master
...
- use vfs suffix in ProcessDirectoryJob
- fix include vfs.h
- fix local vio passing vfs
- fix checksum computation
- vfs mode use
- mingw lambda compile issue
2020-12-15 10:58:21 +01:00
Christian Kamm
2b20985875
winvfs: initial work
...
Done by ckamm and dschmidt
2020-12-15 10:58:21 +01:00
Christian Kamm
c3b1a872aa
FolderMan: Remove assumption of unique running sync
2020-12-15 10:58:21 +01:00
Christian Kamm
22e08cf6ad
Checksums: Work on QIODevice*s
...
Needed for cfapi where we want to feed data through a custom device
which retrieves data from the windows api.
2020-12-15 10:58:21 +01:00
Olivier Goffart
a6614c18f1
IgnoreListEditor: increase a bit the size
...
Should Help for issue #6641
2020-12-15 10:58:21 +01:00
Olivier Goffart
7c1871ae65
Account: Fix crash when deleting an account
...
We should not have request parented to the account, otherwise we might get
a loop on the deletion order.
Issue #6893
2020-12-15 10:58:21 +01:00
Christian Kamm
6b0bb66b17
LockWatcher: Add chrono header
2020-12-15 10:58:20 +01:00
Christian Kamm
582803b6bd
cjhash: Fix build fix
...
See 17a4055e8d658f24b1fc47c44fd2daf66c7d5dbf
2020-12-15 10:58:20 +01:00
Olivier Goffart
175b064364
cjhash: use Q_FALLTHROUGH
...
This fixes the warning
warning: unknown option after ‘#pragma GCC diagnostic’ kind [-Wpragmas]
Issue #6872
2020-12-15 10:58:20 +01:00
Kevin Ottens
cce3d6f6fc
Excludes: switch all the path handling to QString
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:58:20 +01:00
Olivier Goffart
1c443ad021
CMakeLists.txt: increment sqlite version
...
3.9 is required for custom index to work
2020-12-15 10:58:20 +01:00
Olivier Goffart
5e05b61d2f
csync_vio_locale: use QString for the path in opendir
...
So we don't have to convert to utf8 and back again
2020-12-15 10:58:20 +01:00
Olivier Goffart
f0c24cb6f9
Remove csync_misc: The code no longer use fnmatch
2020-12-15 10:58:20 +01:00
Olivier Goffart
3c3619f99a
Exclude: do everything with QString wiuthout converting to char*
2020-12-15 10:58:19 +01:00
Olivier Goffart
164051b0c9
ProcessDirectoryJob::process: optimize so there is only one map
2020-12-15 10:58:19 +01:00
Olivier Goffart
1783db5811
PropagateUpload: Avoid many allocations by using QByteArrayLiteral
2020-12-15 10:58:19 +01:00
Olivier Goffart
d6a0290058
Optimisation: Add a cache SyncJournalDb::mapChecksumType
...
No need to do two sql query for something that's always the same and
there are very few checksum types
2020-12-15 10:58:19 +01:00
Olivier Goffart
69de2d5180
Sync: optimize by removing setFileRecordMetadata
...
Inh most case we already have a record from before, so avoid doing a useless
lookup in the database.
In owncloudpropagator.cpp, directories do not have a checksum so no need
to call a function that preserves it
2020-12-15 10:58:19 +01:00
Olivier Goffart
416a0b3482
Test System: Optimisations so the benchmark is significant
2020-12-15 10:58:19 +01:00
Olivier Goffart
7e1840bb2f
OwnSql: Speedup by avoiding allocating an error string on success
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
7e55ce6640
owncloudcmd: fix compiliation with TOKEN_AUTH_ONLY
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
b3792ac1f0
libsync: Fix build error with TOKEN_AUTH_ONLY
...
When enabling TOKEN_AUTH_ONLY, the code path using QPainter is disabled.
So we also don't need the includes.
This header is not available for Remarkable.
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
ff9bd84c45
Disable stack protector features when cross compiling
...
When cross-compiling this for remarkable using the poky toolchain
this results in linker errors with stack protector: libssp_nonshared.a
not found
2020-12-15 10:58:18 +01:00
Gerhard Gappmeier
6aead6425e
Add CMake option to disable GUI build
2020-12-15 10:58:18 +01:00
Kevin Ottens
9131a68ec4
Get DatabaseErrorTest to pass
...
The E2EE code path would get the engine to go wrong in case of db error.
It's just better to have a failing upload or failing mkdir later in those
cases.
Emitting signals from a ctor is a bad idea anyway
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:58:18 +01:00
Olivier Goffart
bb9ce8db21
Test that the sync behave well if there are errors while reading the database
2020-12-15 10:58:17 +01:00
Olivier Goffart
b79e57d1c1
Discovery: fix double emission of finished in case of error
2020-12-15 10:58:17 +01:00
Olivier Goffart
7061f31887
Discovery: Fix downloading files when database is used for local discovery
...
This also fix the currently failling LockedFilesTest
2020-12-15 10:58:17 +01:00
Olivier Goffart
0eaa950e9e
Remove csync.cpp: It's only dead code
2020-12-15 10:58:17 +01:00
Christian Kamm
0d49056a13
Add Ctrl-L as log window shortcut
...
F12 is taken on OSX and there's no other way of showing it.
2020-12-15 10:58:17 +01:00
Christian Kamm
9d55590d10
Test: Add test for locked file tracking and propagation
2020-12-15 10:58:17 +01:00
Christian Kamm
da178c1352
Folder: Treat file unlock similar to external change #6822
...
For consistent handling of incoming notifications.
2020-12-15 10:58:17 +01:00
Christian Kamm
815e0fee8f
Propagator: Add assert against duplicate done() calls
2020-12-15 10:58:16 +01:00
Olivier Goffart
2c9b66fe69
RemoteDiscoveryTest: Fix after the merge from 2.5
...
The new discovery's message is slightly different
2020-12-15 10:58:16 +01:00
Christian Kamm
18b9712105
Test: Check for folder in error message #6826
2020-12-15 10:58:16 +01:00
Markus Goetz
59d12c302e
gitignore: XCode userdata
2020-12-15 10:58:16 +01:00
Olivier Goffart
eb23776f16
Discovery: Fix renaming on windows
...
buf.type is ItemFileSkip because csync_vio_local_stat does not set this field
2020-12-15 10:58:16 +01:00
Olivier Goffart
beee123c80
New Discovery: Fix trailing slash causing failure on windows
2020-12-15 10:58:16 +01:00
Olivier Goffart
60b17cd128
Folder: update the folder version
...
Since the new index would crash old version of the client, we need to
upgrade folder version so they do not load in the client 2.5.0
2020-12-15 10:58:15 +01:00
Christian Kamm
7de453d439
Settings: Make FoldersWithPlaceholders group sticky
...
If virtual files are disabled on a folder it might still have db entries
or local virtual files that would confuse older client versions.
2020-12-15 10:58:15 +01:00
Olivier Goffart
ab85c60205
owncloudcmd: Read the server version from the capabilities
...
Issue: #6846
2020-12-15 10:58:15 +01:00
Olivier Goffart
3e4486c078
owncloudcmd: fetch the dav user
...
This is required to get the new endpoint working when the server
uses ldap or that the dav user is not the same as the login.
Issue #6830
2020-12-15 10:58:15 +01:00
Olivier Goffart
ec8c02dad0
Sharing: add the shareWithAdditionalInfo string in autocompletion results
...
Issue #6749
2020-12-15 10:58:15 +01:00
Olivier Goffart
380d7b8028
Migration from 2.4: fallback to move file by file if directory move failled ( #6807 )
...
Migration from 2.4: fallback to move file by file if directory move failed
This can happen if the directory already exist because, say, it was
created by the ownCloud outlook plugin which save its file in the same directory
2020-12-15 10:58:15 +01:00
Olivier Goffart
e20e1d110f
Move: Fix too many starting slashes in the destination header
...
QDir::cleanPath does not remove starting slashes on windows.
So use account::davUrl which is already cleaned
Issue: #6824
2020-12-15 10:58:15 +01:00
Olivier Goffart
dcfbde2a67
Wizard: Reset the QSslConfiguration before checking the server
...
Because a previous call with another demain might have set some
config for another server.
Issue #6832
2020-12-15 10:58:14 +01:00
Olivier Goffart
b820e46805
Fix compiler warning
2020-12-15 10:58:14 +01:00
Olivier Goffart
35967fc2d6
OAuth2: Refresh the token without aborting the sync
...
OAuth2 access token typically only has a token valid for 1 hour.
Before this patch, when the token was timing out during the sync, the
sync was aborted, and the ConnectionValidator was then requesting a new
token, so the sync can be started over.
If the discovery takes longer than the oauth2 validity, this means that
the sync can never proceed, as it would be always restarted from scratch.
With this patch, we try to transparently renew the OAuth2 token and restart
the jobs that failed because the access token was invalid.
Note that some changes were required in the GETFile job because it handled
the error itself and so it was erroring the jobs before its too late.
Issue #6814
2020-12-15 10:58:14 +01:00
Olivier Goffart
53a14c2041
HttpCredentials: initialize all member inline
2020-12-15 10:58:14 +01:00
Dominik Schmidt
5d9370594d
Disable autostartCheckBox if autostart is configured system wide
2020-12-15 10:58:14 +01:00
Christian Kamm
00edcf98a1
Discovery: Virtual file handling adjustments
...
- adjust virtual file path handing
- helpers for vfs suffix adding/removal
- helpers for isDirectory/isVirtual on SyncJournalRecords
- be clear about what PathTuple _local/_server mean
2020-12-15 10:58:14 +01:00
Olivier Goffart
58eaf9940a
Database: Add an index on the parent path
...
So we can quickly query the items in a parent directory
This uses a custom slite3 function, which means that when downgrading the client,
or using another tool to add entries in the database, any insertion in the metadata
table will produce an error: "unknown function: parent_hash()"
(This will crash the client 2.5)
2020-12-15 10:58:13 +01:00
Olivier Goffart
e45e57982d
Add missing export
2020-12-15 10:58:13 +01:00
Christian Kamm
b431f4ef0c
Discovery: Fix log output for instructions
2020-12-15 10:58:13 +01:00
Christian Kamm
ce420d77a8
Discovery: Don't rebuild invalidFilname regex each call
2020-12-15 10:58:13 +01:00
Christian Kamm
113124cde5
Discovery: Introduce smaller functions
2020-12-15 10:58:13 +01:00
Christian Kamm
4f6f706f40
Excludes: drop csyncTraversalMatchFun()
...
The new discovery can call the traversal match function directly.
2020-12-15 10:58:13 +01:00
Christian Kamm
1d4e4fafcc
Discovery: Add back virtual file instruction checks
2020-12-15 10:58:12 +01:00
Olivier Goffart
a4e139969c
Fix windows build
2020-12-15 10:58:12 +01:00
Olivier Goffart
8490664860
Account Settings: fix progress being written in white when there are errors
2020-12-15 10:58:12 +01:00
Christian Kamm
dd34cbc751
Virtual files: Wipe selective sync settings when enabled
2020-12-15 10:58:12 +01:00
Christian Kamm
60de1c9720
virtual files: show option only when branding allows it
2020-12-15 10:58:12 +01:00
Christian Kamm
251e01a440
Virtual files: Use theme to check for option availability
2020-12-15 10:58:12 +01:00
Olivier Goffart
94e63ef7b9
Account Settings: Add a context menu entry to enable or disable virtual files
...
Issue #6725
2020-12-15 10:58:12 +01:00
Olivier Goffart
18f6e346b8
Upload: Do not error out if the server do not send the X-OC-MTime: accepted header
...
If the server does not set the mtime, it is not a big problem for the
synchronisation.
The test was used before so we could do a PROPPATCH for server that did not
support this header. But now that all server supports that we don't need to
to the check. (We do not do the PROPPATCH since we got rid of the neon
dependency)
Apparently, it may happen that some backend don't support setting mtime
and this can lead to this error.
https://github.com/owncloud/client/issues/6797
2020-12-15 10:58:11 +01:00
Dominik Schmidt
a985ea8624
Do not select ownCloud in Finder after installation to fix #6781
2020-12-15 10:58:11 +01:00
Olivier Goffart
15eab07866
OAuth2: Store 'Account::davUser' in the config, and use that user for connecting
...
We need to use the user id to check if we are connected to the right account.
These might be different from the HTTP Basic Auth login. (LDAP setups)
When the account was configured as an oauth2 account form the wisard, the
http_user was already set correctly to the user id. But when the server is
upgrading from basic auth to oauth2, we need to pick the right login.
Note that Account::davUser() already defaults to the HTTP user when none
is set, so this means the upgrade will be fine if this is not set in the
config.
Issues:
https://github.com/owncloud/oauth2/issues/109
https://github.com/owncloud/enterprise/issues/2781
2020-12-15 10:58:11 +01:00
Olivier Goffart
75f66ddaa1
Local discovery: always recurse within touched directory
...
If the file system watcher tells us a directory was modified, we should
recurse into it because it means it is probably a new directory
Issue #6804
2020-12-15 10:58:11 +01:00
Christian Kamm
e10e953c66
PropagateUpload: Avoid crash due to cascading aborts
...
https://sentry.io/owncloud/desktop-win-and-mac/issues/698694072/activity/
2020-12-15 10:58:11 +01:00
Olivier Goffart
640cf0c71e
Fix leaks in tests
...
As discovered by AddressSanitizer
2020-12-15 10:58:11 +01:00
Christian Kamm
d1aedcfd3c
Discovery: restructure processFileAnalyzeLocalInfo
2020-12-15 10:58:10 +01:00
Christian Kamm
a2839bd40a
Discovery: easy conditions first in processFileAnalyzeRemoteInfo
...
Removing two levels of indent that way
2020-12-15 10:58:10 +01:00
Christian Kamm
76341904e9
Discovery: Add comments
2020-12-15 10:58:10 +01:00
Olivier Goffart
5a1c93d0ac
Discovery: make sure finished is not called twice, even in case of errors
2020-12-15 10:58:10 +01:00
Olivier Goffart
b86e1efc9a
Remove the backup deteciton code which was used for server < 9.1
2020-12-15 10:58:10 +01:00
Olivier Goffart
f666511a4b
Discovery: Remove stale DB entries
...
And test the Remove/Remove case.
This means we need to always query the database for all the entries.
This showed another small bug in the test in which sync item for virtual
files at the root could have a slash in front of them.
2020-12-15 10:58:10 +01:00
Christian Kamm
5683278fab
Discovery: Comments and visibility adjustments
2020-12-15 10:58:09 +01:00
Olivier Goffart
aa18e10ff5
Discovery: cleanups and comments
2020-12-15 10:58:09 +01:00
Olivier Goffart
b10b3e5eeb
Discovery: move checkMovePermissions to its own function
2020-12-15 10:58:09 +01:00
Olivier Goffart
edd866b32b
Discovery: Adjust the instruction in case of resolved conflict
...
When resolving a conflict because the file was just updated on the server,
we write all the metadata on the database immediatly, so INSTRUCITON_NONE
is enough and UPDATE_METADATA is not needed
2020-12-15 10:58:09 +01:00
Olivier Goffart
7cddaf82ab
ProcessDirectoryJob: always set _childModified to true, regardless the direction
...
This was like that to handle the case of CSYNC_INSTRUCTION_TYPE_CHANGE, but just add
a condition in this location.
2020-12-15 10:58:09 +01:00
Olivier Goffart
46510c2f39
Discovery phase: refactor some code in DiscoveryPhase::findAndCancelDeletedJob
...
Less code duplication
2020-12-15 10:58:09 +01:00
Olivier Goffart
1c2a3279bb
New Discovery Algorithm: more cleanups
...
- rename progress() to be more explicit
- Make some more member of the discovery phase private
2020-12-15 10:58:09 +01:00
Olivier Goffart
2f8c77c54f
Fixup commit 835c9163374f42003aa2f7795ade3f4ff62c8877
...
The previous code considered the also HTTP 207 code without the
application/xml header to have this message.
httpCode 0 does not make much sense anyway.
This change the behavior to consider any 2xx without the xml header
to show this error message
2020-12-15 10:58:08 +01:00
Olivier Goffart
c009dae1ce
New discovery algorithm: fixups
...
Adapt reviews from ckamm in https://github.com/owncloud/client/pull/6738#pullrequestreview-164623532
- SyncJournalFileRecord: initialize everything inline
- Add more comments
- And some ENFORCE
2020-12-15 10:58:08 +01:00
Olivier Goffart
059f722b3b
Move Result to its own header
2020-12-15 10:58:08 +01:00
Olivier Goffart
afed46afcc
New discovery algorithm: Parallel PROPFIND
2020-12-15 10:58:08 +01:00
Olivier Goffart
c8eff3da2d
New Discovery algorithm: Remove the sync cleanup phase
...
Since we do not recurse within some directories, many files are not seen.
The stale entry will cleanup by themself as the sync engine try to remove
the files that are already removed.
Should we need to actually do this cleanup, it should be dotected in the
discovery.
2020-12-15 10:58:08 +01:00
Olivier Goffart
35c0cf4e59
New discovery algorithm: Set the originalFile for ignored files
...
This is used to show the name in the UI
2020-12-15 10:58:08 +01:00
Olivier Goffart
52dcfcb166
New Propagation algorithm: Fetch, and emit, the root etag
...
Remove the feature to concatenate etags as servers that don't
have a root etag are no longer suported
2020-12-15 10:58:07 +01:00
Olivier Goffart
d25d87e92c
New Discovery Algorithm: Ge tthe size of new folders
...
Also add a test that this works properly
2020-12-15 10:58:07 +01:00
Olivier Goffart
ef542ac83d
New Discovery algorithm: Split the process function even further
...
Move the finialization in its own function.
This allow to save a bit of code duplication.
Also change the order of the parameter in the constructor for consistency
2020-12-15 10:58:07 +01:00
Olivier Goffart
fc69dda246
New Discovery Algo: Refactor by splitting the processFile in two
2020-12-15 10:58:07 +01:00
Olivier Goffart
b7d827d6d0
New Discovery Algorithm: Handle rename of virtual files
2020-12-15 10:58:07 +01:00
Christian Kamm
e58a25d7c5
Virtual files: Renames propagate #6718
2020-12-15 10:58:07 +01:00
Olivier Goffart
3289675b8d
Folder Wizard: Disable the 'choose what to sync' treeview if virtual files are selected
...
Don't allow to configure virtual files with a selective sync blacklist
2020-12-15 10:58:07 +01:00
Olivier Goffart
d8fa8e270f
AccountSetting: Fix Small Memoy leak
2020-12-15 10:58:06 +01:00
Olivier Goffart
f0ddf179a5
Fix tx.pl
...
The conflict filename changed
2020-12-15 10:58:06 +01:00
Olivier Goffart
0ba9dc7dd1
AccountSettings: Force sync should wipe the blacklist
...
Issue #6757
2020-12-15 10:58:06 +01:00
Olivier Goffart
68ace415d4
Virtual files: don't check for new big folders
...
https://github.com/owncloud/client/issues/6724#issuecomment-417368475
2020-12-15 10:58:06 +01:00
Olivier Goffart
75a57778d9
Virtual files: Don't show selective sync
...
Issue #6724
2020-12-15 10:58:06 +01:00
Olivier Goffart
46aa8fd1f8
Socket API: add an option to replace existing files with virtual files
...
Issue #6726
2020-12-15 10:58:06 +01:00
Olivier Goffart
afc953b649
Update the minimum supported version
...
We want to warn if the server version is not supported and did not get
appropriate QA for this client version.
https://github.com/owncloud/enterprise/issues/2687
2020-12-15 10:58:05 +01:00
Markus Goetz
811ac50c05
CMakeLists.txt: Log the Qt version in compile
2020-12-15 10:58:05 +01:00
Christian Kamm
6b571b609c
Conflicts: Rename BasePath to InitialBasePath #6709
2020-12-15 10:58:05 +01:00
Olivier Goffart
d81ccbb0c1
Checksum: Add support for SHA256 and SHA3
...
In case, some day, the server also supports it
2020-12-15 10:58:05 +01:00
Olivier Goffart
bf6e4174c8
Move the checksum related routine from FileSystem to checksum, where they belong
2020-12-15 10:58:05 +01:00
Olivier Goffart
198b65e9fc
Fix a compilation error on windows
2020-12-15 10:58:05 +01:00
Olivier Goffart
21fe54fb13
New Discovery Algo: readability improvements
...
As proposed by ckamm on #6738
2020-12-15 10:58:04 +01:00
Olivier Goffart
3a06a7978f
New discovery algo: data finger print
2020-12-15 10:58:04 +01:00
Olivier Goffart
5683f1c33d
New Disco Algo: Handle spurious virtual files
...
Port commit 0b9049e6ff
for issue #6718
2020-12-15 10:58:04 +01:00
Olivier Goffart
9c99544e0b
Fix test link with older Qt
2020-12-15 10:58:04 +01:00
Olivier Goffart
c3f745fa76
Conflict handling: add the OC-ConflictBasePath header
...
Issue #6702
2020-12-15 10:58:04 +01:00
Olivier Goffart
358aadfb98
Account Settings: Add a text for folder using vierual files
...
Issue #6723
2020-12-15 10:58:04 +01:00
Olivier Goffart
73d933115a
Virtual Files: Set the mtime of the virtual file to that of the server
...
Note: When the server mtime is modified, the mtime of the file is not updated
Issue #6727
2020-12-15 10:58:04 +01:00
Olivier Goffart
a17a2a9c06
Virtual Files Mime Type: use "vnd." prefix instead of "x-"
...
As reported in https://github.com/owncloud/client/issues/6717#issuecomment-413703567
2020-12-15 10:58:03 +01:00
Christian Kamm
c10f103fb8
Virtual files: Renaming to virtual doesn't delete data #6718
...
Unfortunately to do this, the local update phase must write to the
database, creating a new side-effect and order dependency (local update
must run before remote update).
2020-12-15 10:58:03 +01:00
Olivier Goffart
a670431a48
SyncEngine: Fix renames making hierarchy inversion
...
Issue #6694
2020-12-15 10:58:03 +01:00
Christian Kamm
be0fa72fcb
RemotePermissions: Fix empty vs null
...
Fixes two bugs that appeared since the introduction of the struct:
- when reading permissions from the journal, null ("") was read as
empty-not-null
- when reading permissinos from the server, empty ("") was read as null
Addresses #4608
2020-12-15 10:58:03 +01:00
Olivier Goffart
4837bc8d60
FolderStatusModel: Do not abort applying selective sync if one folder has an error
...
Issue #6675
2020-12-15 10:58:03 +01:00
Olivier Goffart
732069aaa7
SyncEngine: Fix the "direction" of the "all file delted" message when the server is reset
...
Using the direction of the "first" item is not enough as it might be a directory
which is a UPDATE_META_DATA, or there can have been a few changes locally as well.
As reported on https://github.com/owncloud/client/issues/6317#issuecomment-412163113
2020-12-15 10:58:02 +01:00
Christian Kamm
f6ca649308
Do not require server replies to contain an mtime
...
The check was added for #6317 in commit
13eb64584f .
We did see missing mtimes in replies in tests with live servers though.
Possibly those were old incomplete responses cached in the stat cache?
2020-12-15 10:58:02 +01:00
Olivier Goffart
9401273daf
New discovery algorithm: Call FolderDiscovered
2020-12-15 10:58:02 +01:00
Olivier Goffart
a36ed56f01
New Discovery algorithm: Refactor a bit the way the signal are emited
2020-12-15 10:58:02 +01:00
Olivier Goffart
8f3ce6e520
Fix TestDownload: _ignore_hidden_files was not properly initialized
2020-12-15 10:58:02 +01:00
Olivier Goffart
b6487181c6
New Discovery Phase: fix a few FIXME
...
Some FIXME were already fixed.
2020-12-15 10:58:02 +01:00
Olivier Goffart
9863500ec1
New discovery algorithm: handle symlinks
2020-12-15 10:58:01 +01:00
Olivier Goffart
a9ec521bf1
New discovery algo: Handle Database error
2020-12-15 10:58:01 +01:00
Olivier Goffart
d6fc3b6e0a
Skip failing test
...
These tests are failling because now we consider that any files that ends
with .owncloud is a virtual file, regardless what the DB say.
2020-12-15 10:58:01 +01:00
Olivier Goffart
1bcbcd407c
New discovery phase: read the direct download URL and Cookie
2020-12-15 10:58:01 +01:00
Olivier Goffart
ca32eb1cf7
More cleanup of csync remains
2020-12-15 10:58:01 +01:00
Olivier Goffart
ac24cdbde6
New Discovery Algo: Permsission check
2020-12-15 10:58:01 +01:00
Olivier Goffart
0a6d2d0f46
Remove csync_update and csync_reconcile
...
I guess some other csync utilities can also be remove dnow but
that will be for later
2020-12-15 10:58:00 +01:00
Olivier Goffart
5994c65ecb
Remove the check_csync_update test
...
since csync_update is going away
2020-12-15 10:58:00 +01:00
Olivier Goffart
57068b0fd9
New Discovery Algorithm: handle server errors
2020-12-15 10:58:00 +01:00
Olivier Goffart
4031fb6d5b
Backport 64014dd374
2020-12-15 10:58:00 +01:00
Olivier Goffart
6794306dde
Added test that checks what happens when there is an error in the remote discovery
...
(Many of the expected error string are left empty because the current
error message is not insterresting
2020-12-15 10:58:00 +01:00
Olivier Goffart
75a1f2d089
Convert p7.pl to a C++ test
...
This is just a translation of test/scripts/txpl/t7.pl to C++ using the test
framework.
2020-12-15 10:58:00 +01:00
Olivier Goffart
f4a5167812
New Discovery Algo: Support the DatabaseAndFilesystem mode for local discovery
2020-12-15 10:57:59 +01:00
Olivier Goffart
370923791d
New Disco algortihm: Fix TestChunkingNG::connectionDroppedBeforeEtagRecieved
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:57:59 +01:00
Olivier Goffart
710934bdbd
New disco algo: Fix TestSyncFileStatusTracker
2020-12-15 10:57:59 +01:00
Olivier Goffart
f926248937
New discovery algorithm: More work on virtual files
2020-12-15 10:57:59 +01:00
Olivier Goffart
35e40b58ca
New Disco algorithm: Type change (file to dir)
2020-12-15 10:57:59 +01:00
Olivier Goffart
1e8c37d3d6
New discovery algorithm: Virtual files
...
The commented tests lines were implementation details
2020-12-15 10:57:59 +01:00
Olivier Goffart
22d989e272
New discovery algorithm: Fix directory deletion
...
TestAllFilesDeleted passes
2020-12-15 10:57:59 +01:00
Olivier Goffart
d54e00488a
New Discovery algorithm
...
Some error handling. In particular for the case where there is a conflict
between files and directories.
SyncEngineTest and SyncMoveTest passes
2020-12-15 10:57:58 +01:00
Olivier Goffart
a384a2d1cb
New Discovery algorithm: Handle of move within a moved directory
2020-12-15 10:57:58 +01:00
Olivier Goffart
bdd1e72dda
New discovery algoritmh: more on Renames
2020-12-15 10:57:58 +01:00
Olivier Goffart
f43d07dc05
New Discovery algorithm: Check that the original file is still on the server while renaming
2020-12-15 10:57:58 +01:00
Olivier Goffart
7e36cc3fcb
New disco algorithm: Fix some moving
...
Fix TestSyncMove::testSelectiveSyncMovedFolder
2020-12-15 10:57:58 +01:00
Olivier Goffart
5a57a36729
New discovery algorithm: Local rename
2020-12-15 10:57:58 +01:00
Olivier Goffart
f9a9be59e6
New discovery algo: Remote move
...
TestSyncMove::testRemoteChangeInMovedFolder
2020-12-15 10:57:57 +01:00
Olivier Goffart
92ddc60900
Handle Encoding Problems
...
TestSyncEngine now passes
2020-12-15 10:57:57 +01:00
Olivier Goffart
501da58b10
Ignore Hidden Files
2020-12-15 10:57:57 +01:00
Olivier Goffart
8bf69cf0cd
Port the invalid napme regexp
...
TestSyncEngine::testInvalidFilenameRegex
2020-12-15 10:57:57 +01:00
Olivier Goffart
9efd21d70b
More progress
...
TestSyncEngine::testFakeConflict / TestSyncEngine::testSyncFileItemProperties
2020-12-15 10:57:57 +01:00
Olivier Goffart
e934f6b27b
New discovery algo
...
Make TestSyncEngine::testSelectiveSyncBug pass
2020-12-15 10:57:57 +01:00
Olivier Goffart
4066c1a004
New discovery: TestSyncEngine::testEmlLocalChecksum
2020-12-15 10:57:57 +01:00
Olivier Goffart
9bf417d930
New discovery algorithm
...
Some progress:
TestSyncEngine::testDirUpload
2020-12-15 10:57:56 +01:00
Olivier Goffart
ec681ab2a5
New discovery algorithm: Initial work.
...
SyncEngineTest testFileDownload is passing
2020-12-15 10:57:56 +01:00
Kevin Ottens
ba0d465e47
Revert "Merge pull request #1454 from nextcloud/syncjournal-del-prio"
...
This reverts commit d9fd9cfef2 , reversing
changes made to 2dcf594fc6 .
2020-12-15 10:57:56 +01:00
Dominik Schmidt
07f331717f
Rename ocsync library to ${APPLICATION_EXECUTABLE}_csync
2020-12-15 10:57:56 +01:00
Dominik Schmidt
aad928a6be
Install libocsync to lib/ without subfolder.
...
Installing to lib/${APPLICATION_EXECUTABLE} has caused a bunch of
irritations in the past and subtle annoying to fix bugs. To avoid name
clashes with branded clients ${APPLICATION_EXECUTABLE} becomes now
part of the filename instead of the subfolder.
The concrete motivation to change this now is that on Windows there
is no RPATH and it's not possible to run owncloud directly from the
Craft Root folder, which is nice when you're developing on Windows.
It would have been possible to change this just for Windows but as
written earlier this has caused lots of issues and thus I think it's
a good idea to just stay consistent accross platforms when touching it.
2020-12-15 10:57:56 +01:00
Olivier Goffart
919debccfc
nautilus shell integration: Fix when there are several branded client installed
...
It appears that several extension can be loaded at the same time, but their
classname for the extension need to be different, otherwise only the last
loaded one would be active.
Issue #6524
2020-12-15 10:57:55 +01:00
Olivier Goffart
0155a4fa73
Wizard + OAuth: Make opening a new browser after clicking back works again
...
Issue #6574
When there is an error in the advanced page, OwncloudAdvancedSetupPage::updateStatus
(and others) call completeChanged(), which is connected to
QWizardPrivate::_q_updateButtonStates which will re-enable the back button from the
last page.
When the user click "back" and re-open the browser, the account's credentials
already have a oauth token set. So the call to the API to get a new token fails
because we use the previous token instead of using the client's secret_id.
Fix this with the HttpCredentials::DontAddCredentialsAttribute.
Now, this is still not working because the session cookies are confusing the
server. So we'll clear the cookies when re-opening the browser
2020-12-15 10:57:55 +01:00
Olivier Goffart
d8e761ab61
FindSql3.cmake: Add the input variable in the search path
...
Issue #6278
2020-12-15 10:57:55 +01:00
Olivier Goffart
0d21936e95
FolderStatusModel: Fix crash when there is an error while expanding folders
...
In FolderStatusModel::slotLscolFinishedWithError, the call to parentInfo->resetSubs
deleted the 'job' and the reply 'r' which we accessed later to get the error code.
Fix this problem twice by
1) Get the error code before caling resetSubs
2) in FolderStatusModel::SubFolderInfo::resetSubs, call deleteLater instead of delete
Regression introduced in commit d69936e0
Issue #6562
2020-12-15 10:57:55 +01:00
Olivier Goffart
cf3846c565
csync: refactor csync_s::error_string to avoid valgrind error
...
The problem here is that we were sometimes allocating the error_string with
qstrdup, which need to be released with delete[] and not free().
Simplify the code by using QString instead.
```
==7230== Mismatched free() / delete / delete []
==7230== at 0x4C2E10B: free (vg_replace_malloc.c:530)
==7230== by 0x57C2321: csync_s::reinitialize() (csync.cpp:247)
==7230== by 0x548130F: OCC::SyncEngine::finalize(bool) (syncengine.cpp:1212)
==7230== by 0x5481223: OCC::SyncEngine::handleSyncError(csync_s*, char const*) (syncengine.cpp:746)
==7230== by 0x5483E78: OCC::SyncEngine::slotDiscoveryJobFinished(int) (syncengine.cpp:965)
==7230== by 0x5495E34: QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<int>, void, void (OCC::SyncEngine::*)(int)>::call(void (OCC::SyncEngine::*)(int), OCC::SyncEngine*, void**) (qobjectdefs_impl.h:134)
==7230== by 0x5495D92: void QtPrivate::FunctionPointer<void (OCC::SyncEngine::*)(int)>::call<QtPrivate::List<int>, void>(void (OCC::SyncEngine::*)(int), OCC::SyncEngine*, void**) (qobjectdefs_impl.h:167)
==7230== by 0x5495CB5: QtPrivate::QSlotObject<void (OCC::SyncEngine::*)(int), QtPrivate::List<int>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (qobjectdefs_impl.h:396)
==7230== by 0xA9BF2E1: QObject::event(QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== by 0x64BE983: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0x64C625A: QApplication::notify(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0xA994BC8: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== Address 0x225b2640 is 0 bytes inside a block of size 50 alloc'd
==7230== at 0x4C2DC6F: operator new[](unsigned long) (vg_replace_malloc.c:423)
==7230== by 0xA7E8FC8: qstrdup(char const*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== by 0x53F5750: OCC::DiscoveryJob::remote_vio_opendir_hook(char const*, void*) (discoveryphase.cpp:666)
==7230== by 0x57E1278: csync_vio_opendir(csync_s*, char const*) (csync_vio.cpp:39)
==7230== by 0x57D718F: csync_ftw(csync_s*, char const*, int (*)(csync_s*, std::unique_ptr<csync_file_stat_s, std::default_delete<csync_file_stat_s> >), unsigned int) (csync_update.cpp:674)
==7230== by 0x57C1B05: csync_update(csync_s*) (csync.cpp:109)
==7230== by 0x53F5BCC: OCC::DiscoveryJob::start() (discoveryphase.cpp:718)
==7230== by 0x54B8F74: OCC::DiscoveryJob::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_discoveryphase.cpp:494)
==7230== by 0xA9BF2E1: QObject::event(QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230== by 0x64BE983: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0x64C625A: QApplication::notify(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.11.0)
==7230== by 0xA994BC8: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/libQt5Core.so.5.11.0)
==7230==
```
2020-12-15 10:57:55 +01:00
Olivier Goffart
857afd32df
PropagateDownload: Don't discard the body of error message
...
We want to keep the body so we can get the message from it
(Issue #6459 )
TestDownload::testErrorMessage did not fail because the FakeErrorReply
did not emit readyRead and did not implement bytesAvailable.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:57:55 +01:00
Olivier Goffart
5bd902de9c
.desktop file: the MimeType entry must ends with a semi colon
...
Also remove some comments
2020-12-15 10:57:55 +01:00
Olivier Goffart
4ee244190b
Virtual Files: Allow to download a folder recursively from the socket API
...
Issue: #6466
2020-12-15 10:57:54 +01:00
Christian Kamm
6dba2e8b06
Virtual files: Wipe virtual after download completes, not before
...
Otherwise a interrupted or unsuccessful download would mean that the
download-intend was forgotten. The next sync would reestablish the
virtual file instead.
2020-12-15 10:57:54 +01:00
Olivier Goffart
530614bf78
Rename SocketApi::FileData::accountRelativePath to serverRelativePath
...
As discussed in issue #6552
2020-12-15 10:57:54 +01:00
Olivier Goffart
ced5dfb8ee
Share dialog: use the original name and not the virtual file name
...
When sharing a virtual file, we should actually use the original file name
not the virtual file name
Issue: #6461
2020-12-15 10:57:54 +01:00
Christian Kamm
a6c19572a2
Virtual files: Only remove virtual file once on download
...
With thanks to @ogoffart for spotting the problem.
2020-12-15 10:57:54 +01:00
Christian Kamm
97f7b5abeb
Settings migration: Preserve future settings where possible
...
See discussion in #6506
2020-12-15 10:57:54 +01:00
Christian Kamm
87ba4e6b9c
Config: Add version flags to accounts and folders
...
Also, if there is too-new configuration, backup the file, show a
warning message asking the user whether it's ok to discard the
configuration from the future.
See #6504
2020-12-15 10:57:53 +01:00
Christian Kamm
aa6f5f59c4
Rename Placeholders to Virtual Files in code #6531
2020-12-15 10:57:53 +01:00
Olivier Goffart
a877a9d472
SyncRunFileLog: Add the requestid
...
https://github.com/owncloud/client/pull/6427#issuecomment-383879509
2020-12-15 10:57:53 +01:00
Olivier Goffart
09cacc4cd4
Blacklist: remember the X-Request-ID
...
Issue #6420
Store the X-Request-ID in the SyncFileItem and also in the blacklist.
Note that for consistency reason, the X-Request-ID is also in the
SyncFileItem if the request succeeds.
Currently there is no UI to access it, but it can be queried with sql
commands
2020-12-15 10:57:53 +01:00
Christian Kamm
7da4bb4c20
Wizard: Add a "(recommended)" to the main option #6470
2020-12-15 10:57:53 +01:00
Christian Kamm
ddeeecd061
Rename "placeholder" feature
2020-12-15 10:57:53 +01:00
Christian Kamm
4e3f2f755a
Placeholder: Stop adding ignore pattern
...
Because we can't make older clients preserve the version directive that
was attached to it.
See #6504 and #6498
2020-12-15 10:57:52 +01:00
Christian Kamm
8b6ac63ddb
Placeholder: Don't contain "stub"
2020-12-15 10:57:52 +01:00
Christian Kamm
27b65cbc69
Placeholders: Save to key that's invisible to <2.5 clients #6504
2020-12-15 10:57:52 +01:00
Olivier Goffart
3272f3b72b
FolderWizard: fix crash when experimental feature are disabled
...
The _placeholderCheckBox only exists if the experimental features are enabled
Found via the crash reporter
https://sentry.io/owncloud/desktop-win-and-mac/issues/556407777/
2020-12-15 10:57:52 +01:00
Matthew Setter
eb0e7fa032
Correct incorrect reference to OSX Menu bar
...
This fixes https://github.com/owncloud/documentation/issues/4109 .
2020-12-15 10:57:52 +01:00
Markus Goetz
215afba89e
Share Dialog: Disable workaround for macOS too #6185
2020-12-15 10:57:52 +01:00
Christian Kamm
6347aeeed2
CMake: Add a default placeholder_suffix
...
To make themes work that don't define it explicitly.
2020-12-15 10:57:51 +01:00
Markus Goetz
8dcfd50a7d
Placeholders: Support for macOS #6290
2020-12-15 10:57:51 +01:00
Olivier Goffart
600b1a72c1
Fix test: QTemporaryDir::filePath was added in Qt 5.9
2020-12-15 10:57:51 +01:00
Christian Kamm
765c12dae1
LocalDiscoveryTracker: Separate from Folder and move to libsync
...
To allow relevant code to be closer together and for testing in
unittests without having to get a gui Folder.
See #6120
2020-12-15 10:57:51 +01:00
Olivier Goffart
7969067f80
Logger: Guard zlib usage by ZLIB_FOUND
...
Similar to the use for the checksum.
I know that zlib is required in principle, but i don't have it
in one of my test building environment, and it is easier to just
disable it.
2020-12-15 10:57:51 +01:00
Kevin Ottens
b1dc14977f
Get TestDownload to pass
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 10:57:51 +01:00
Olivier Goffart
4eb8997519
Download: Remove useless code and add a test
...
From issue #7015 , the code is wrong because the path is the file system path and
not the path on the DB.
But since this is a conflict, this means the reconcile will still want to download
the file from the server next sync, so we need not to worry about this case
2020-12-15 10:57:50 +01:00
Olivier Goffart
718843ffce
Download: Use the <s:message> from the reply in the error message if any
...
Issue: #6459
2020-12-15 10:57:50 +01:00
Olivier Goffart
50223d889b
Add a test for resuming downloads
2020-12-15 10:57:50 +01:00
Christian Kamm
9c6a76d280
Doc: Add showExperimentalOptions to conffile.rst
2020-12-15 10:57:50 +01:00
Christian Kamm
27c8bce0b9
Wizards: Show placeholder option only if showExperimentalOptions is set
...
This config file option will also control other features in the future.
2020-12-15 10:57:50 +01:00
Christian Kamm
aee8b9f3c5
Wizards: Add placeholder option and warning to account wizard
...
Also add the warning dialog to the option in the folder wizard.
2020-12-15 10:57:50 +01:00
Christian Kamm
7dc65b060d
NSIS: Register placeholder extension
...
Also change the placeholder suffix config option to not include the dot,
the dotless form is needed in the nsis script.
2020-12-15 10:57:50 +01:00
Christian Kamm
6a37a7a42c
Placeholders: Fix migration issues
...
Some edgecases weren't covered and didn't have tests yet.
2020-12-15 10:57:49 +01:00
Christian Kamm
40f2303166
SyncOptions: Add default placeholder suffix
...
Otherwise each test has to set this up anew.
2020-12-15 10:57:49 +01:00
Christian Kamm
12d6f680f2
Placeholders: Ignore placeholder files in older clients
...
To do this, we add the placeholder extension to the user exclude file
automatically. However, newer clients shouldn't use that exclude
pattern: so we also add version directives that allow making exclude
patterns dependent on the client version.
2020-12-15 10:57:49 +01:00
Christian Kamm
d6078f958b
Placeholders: Download from shell integration
2020-12-15 10:57:49 +01:00
Olivier Goffart
91f53521ae
Placeholder: The extension is now a branding option
2020-12-15 10:57:49 +01:00
Olivier Goffart
a2bdd5b9a5
Placeholders: Fixup clicking on placeholder after previous change
...
Now that the name in the db is the name of the placeholder file,
we need to adjust the call to downloadPlaceholder
2020-12-15 10:57:49 +01:00
Christian Kamm
b1de184bc8
Placeholders: Safe migration to older client versions
...
Now the db entries for placeholders will have the full placeholder
paths. That way older clients will, on remote discovery, delete the
placeholders and download the real files.
2020-12-15 10:57:48 +01:00
Christian Kamm
0cd83a2c09
Placeholders: Deal with conflicts when a placeholder exists
...
So "foo.owncloud" exists but the user adds a new "foo".
2020-12-15 10:57:48 +01:00
Olivier Goffart
d233e5f8d7
Placeholders: install mimetype on linux
2020-12-15 10:57:48 +01:00
Olivier Goffart
7eeb99ba24
Placeholders: Add an checkbox in the FolderWizard to enable the placeholder feature
2020-12-15 10:57:48 +01:00
Olivier Goffart
1049fb74d9
Placeholders: Move the placeholder option from the account to the folder
2020-12-15 10:57:48 +01:00
Olivier Goffart
6ce7c7a56b
PlaceHolders: Trigger a download of the placeholder and open it
2020-12-15 10:57:48 +01:00
Christian Kamm
f5cf03b6a6
On-demand downloading: Placeholder-file based prototype
...
- Controled by an option.
- New remote files start out as ItemTypePlaceholder, are created with a
.owncloud extension.
- When their db entry is set to ItemTypePlaceholderDownload the next
sync run will download them.
- Files that aren't in the placeholder state sync as usual.
- See test cases in testsyncplaceholders.
Missing:
- User ui for triggering placeholder file download
- Maybe: Going back from file to placeholder?
2020-12-15 10:57:43 +01:00
Camila
c50b1cc37c
Merge pull request #2714 from nextcloud/ensure_sync_after_conflict_resolution
...
Ensure a sync happens after a conflict resolution
2020-12-15 10:48:43 +01:00
Kevin Ottens
8c4bd2bb52
Ensure a sync happens after a conflict resolution
...
You'd expect that after a conflict resolution the file watcher would
pick up the change and trigger a sync. For some reason it doesn't seem
to happen on at least some Ubuntu systems. In such cases the user would
then still have a stale conflict entry in the activity list and wouldn't
be able to do anything with it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 09:40:57 +00:00
Camila
75a97bdaf3
Merge pull request #2713 from nextcloud/usermodel_properly_check_out_of_bound_index
...
UserModel: check indices are inside the user list
2020-12-15 10:37:58 +01:00
Kevin Ottens
d640076454
UserModel: check indices are inside the user list
...
The model was just checking for the user list being empty or not which
is overly optimistic. Indeed there might be cases where the id is
actually outside the boundaries so properly check for this.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-15 08:43:32 +00:00
Nextcloud bot
94c4e3044c
[tx-robot] updated from transifex
2020-12-15 03:48:34 +00:00
Kevin Ottens
2415d9525b
Merge pull request #2708 from nextcloud/fix_new_account_wizard_open
...
Have the new account wizard open again
2020-12-14 16:28:31 +01:00
Kevin Ottens
5ed397a430
Have the new account wizard open again
...
UserModel can't be connected to AccountSettings if the settings dialog
doesn't exist. This is the case now since we delay the creation of that
dialog and free it after use.
Instead it should be properly channeled through the Systray object all
the way up to OwncloudGui which knows how to handle this properly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-12-14 15:58:52 +01:00
Camila
be1fb77488
Merge pull request #2692 from nextcloud/fix-issue-1029
...
Handle the warning message when unchecking folders for syncing.
2020-12-14 12:54:05 +01:00
Camila
b4dc682690
Handle the warning message when unchecking folders for syncing.
...
Split widgets and slot to handle the refreshing of the view:
- refreshSelectiveSyncStatus is connected to signal dirtyChanged
and will handle big folder warning.
- slotSelectiveSyncChanged which is connected to dataChanged signal
and will handle the selective sync warning. It fixes #1029 because
it looks for the checkbox state before showing the warning.
Signed-off-by: Camila <hello@camila.codes >
2020-12-14 12:36:51 +01:00
Nextcloud bot
0b985f2743
[tx-robot] updated from transifex
2020-12-14 03:48:55 +00:00
Nextcloud bot
8c47d62fa2
[tx-robot] updated from transifex
2020-12-13 03:44:59 +00:00
Nextcloud bot
2de52c351a
[tx-robot] updated from transifex
2020-12-12 03:47:17 +00:00
Nextcloud bot
dc229480b3
[tx-robot] updated from transifex
2020-12-11 03:46:02 +00:00
Kevin Ottens
7f0e64ef67
Merge pull request #2698 from nextcloud/themed-icons-v2
...
Use the icon color property to color the icons in the tray window header.
2020-12-10 19:06:40 +01:00
Camila
cfbd22b5e7
Use the icon color property to color the icons in the tray window header.
...
The icon color is set with APPLICATION_WIZARD_HEADER_TITLE_COLOR in the
theme.
Signed-off-by: Camila <hello@camila.codes >
2020-12-10 17:43:45 +01:00
Kevin Ottens
5b534761bf
Merge pull request #2697 from nextcloud/v3.1.5
...
Bump master version to 3.1.50
2020-12-10 14:18:35 +01:00
allexzander
7b575fc643
Bump master version to 3.1.5
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-10 14:54:25 +02:00
allexzander
6c651f1cb6
Bump master version to 3.1.5
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-10 14:44:58 +02:00
Kevin Ottens
7f4ffd0f72
Merge pull request #2696 from nextcloud/v.3.1.0
...
Bump master version to 3.1.0
2020-12-10 12:16:47 +01:00
allexzander
e6b06d0a6b
Bump master version to 3.1.0
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-10 12:47:51 +02:00
Nextcloud bot
e160788204
[tx-robot] updated from transifex
2020-12-10 03:53:56 +00:00
Nextcloud bot
f5d4ac518f
[tx-robot] updated from transifex
2020-12-09 03:44:40 +00:00
allexzander
31d3ce7663
Merge pull request #2685 from nextcloud/fix-slow-sharee-search-in-dialog
...
Fixed slow sharee search in the share dialog
2020-12-08 15:56:29 +02:00
allexzander
9266ecc2e8
Fixed slow sharee search in the share dialog
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-08 13:48:43 +00:00
allexzander
14105d4ec6
Merge pull request #2686 from nextcloud/add-email-sharing
...
Added sharing via email.
2020-12-08 15:24:08 +02:00
allexzander
6e8658dc2c
Added sharing via email.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-08 11:08:45 +02:00
Nextcloud bot
1d7b7c26d3
[tx-robot] updated from transifex
2020-12-08 03:48:38 +00:00
Kevin Ottens
b2dfa29325
Merge pull request #2690 from nextcloud/update-documentation
...
Update documentation on how to generate debug logs.
2020-12-07 16:22:37 +01:00
Camila
09c2279bb5
Update documentation on how to generate debug logs.
...
Minor change: bypasses => bypass.
Signed-off-by: Camila <hello@camila.codes >
2020-12-07 14:52:51 +01:00
Nextcloud bot
4886525e08
[tx-robot] updated from transifex
2020-12-07 03:48:13 +00:00
Nextcloud bot
f2fd083898
[tx-robot] updated from transifex
2020-12-06 03:43:57 +00:00
Nextcloud bot
8a2eb71c4f
[tx-robot] updated from transifex
2020-12-04 03:45:51 +00:00
Kevin Ottens
8e29935195
Merge pull request #2682 from nextcloud/debug-skip
...
Add debug log to check which folders are being skipped during syncing.
2020-12-03 12:37:38 +01:00
Camila
5517ff2c02
Add debug log to check which folders are being skipped during syncing.
...
Signed-off-by: Camila <hello@camila.codes >
2020-12-03 12:24:25 +01:00
Nextcloud bot
bd959018a1
[tx-robot] updated from transifex
2020-12-03 03:45:56 +00:00
Camila
a527e85fe6
Merge pull request #2666 from nextcloud/notification_actions_bring_back_from_version_2
...
Notification action buttons and context menu
2020-12-02 15:42:32 +01:00
allexzander
f04281cb69
Implemented notification action buttons and context menu for confirm/dismiss and other actions.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-12-02 08:08:37 +00:00
Kevin Ottens
7721832ee0
Merge pull request #2677 from briankendall/fix-tray-window-spaces-bug
...
Fix macOS bug where tray window causes spaces to switch
2020-12-02 08:23:19 +01:00
Brian Kendall
f9991e180c
Fix macOS bug where tray window causes spaces to switch
...
Signed-off-by: Brian Kendall <brian@briankendall.net >
2020-12-02 06:54:16 +00:00
Nextcloud bot
bc38c0ba3f
[tx-robot] updated from transifex
2020-12-02 03:46:16 +00:00
Nextcloud bot
9ff8d97647
[tx-robot] updated from transifex
2020-12-01 03:45:58 +00:00
István Váradi
62bf777cda
Merge pull request #2652 from ivaradi/debian-version-discrepancy
...
Handle the case when the release version differs from that in VERSION.cmake
2020-11-30 16:46:20 +01:00
István Váradi
3d9d5f2fe7
Handle the case when the release version differs from that in VERSION.cmake
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-11-30 15:33:34 +01:00
allexzander
57e1f2ac07
Merge pull request #2675 from nextcloud/fix-appimage-build
...
fix AppImage build
2020-11-30 14:20:30 +02:00
allexzander
0fdb423fe0
fix AppImage build by using v0.10.0 for qtkeychain
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-30 13:41:12 +02:00
Nextcloud bot
7bfd8ea23c
[tx-robot] updated from transifex
2020-11-30 03:43:17 +00:00
Nextcloud bot
57a4cd926d
[tx-robot] updated from transifex
2020-11-29 03:42:10 +00:00
Nextcloud bot
de4edb6099
[tx-robot] updated from transifex
2020-11-28 03:39:34 +00:00
Nextcloud bot
70dbbbeaa4
[tx-robot] updated from transifex
2020-11-27 03:40:43 +00:00
Camila
9614d051a5
Merge pull request #2667 from nextcloud/version-bump
...
Master is now 3.0.82.
2020-11-26 13:08:20 +01:00
Camila
8d1fe8ed3c
Master is now 3.0.82.
...
Signed-off-by: Camila <hello@camila.codes >
2020-11-26 12:52:55 +01:00
Camila
4d133ba9a5
Merge pull request #2540 from nextcloud/fix-issue-1458
...
Add last / to exclude list file path.
2020-11-26 12:51:53 +01:00
Camila
bdd3465e7b
Check if there are patterns associated with a sync exclude file.
...
The previous check didn't take into the account that .sync-exclude.lst
might be empty which would crash at Q_ASSERT(_allExcludes.contains(basePath))
in the prepare function. It also takes into account that
_allExcludes[basePath] was creating new items in the list.
Signed-off-by: Camila <hello@camila.codes >
2020-11-26 12:12:04 +01:00
Camila
998e93ac13
Add last / to exclude list file path.
...
This Q_ASSERT(this->endsWith('/')) in BasePathByteArray was the reason
for bug report #1458 .
Signed-off-by: Camila <hello@camila.codes >
2020-11-26 12:11:57 +01:00
Nextcloud bot
820ab12561
[tx-robot] updated from transifex
2020-11-26 03:45:21 +00:00
Kevin Ottens
c38189e981
Merge pull request #2665 from nextcloud/sparkle_build_fixes
...
Sparkle build fixes
2020-11-25 18:00:34 +01:00
Dominik Schmidt
a50c665051
Simplify Sparkle handling in CMake
2020-11-25 09:43:59 +01:00
Chih-Hsuan Yen
6962cbf582
Fix build without Sparkle.framework
...
(PR #6567 )
2020-11-25 09:40:20 +01:00
Christian Kamm
60d3696ccd
Settings: Add warning when switching update channel
2020-11-25 09:39:16 +01:00
Nextcloud bot
c4987aa641
[tx-robot] updated from transifex
2020-11-25 03:42:43 +00:00
Camila
104d3c0661
Merge pull request #2647 from nextcloud/cherry_pick_updater_fixes_and_improvements
...
Cherry pick updater fixes and improvements
2020-11-24 20:58:26 +01:00
Kevin Ottens
4906353f2e
Please the clang-tidy overlord
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-24 18:22:33 +00:00
Hannah von Reth
038644f378
Don't scare users with critical parser log messages
2020-11-24 18:22:33 +00:00
Hannah von Reth
d30cd0f0fd
Include architecture in updater query
...
Fixes : #8074
2020-11-24 18:22:33 +00:00
Hannah von Reth
c76095859a
Cleanup stirngs
2020-11-24 18:22:33 +00:00
Olivier Goffart
a7f010c370
Updater: Fix crash when there is an XML error
...
The problem was accessing the lines with an off by one error, while printing
the log.
Other problem included the fact that QDebug added spaces, quotes, and other
things which made the error lot look right in the console.
Issue #7545
2020-11-24 18:22:33 +00:00
Olivier Goffart
1bf895cadc
Updater: Fix Version numer not shown in the user visible string
...
There was one argument too many in the string.
Bug was introduced in commit 21ac396b
Issue: #7288
2020-11-24 18:22:33 +00:00
Christian Kamm
c58f00abc7
Updater: Improved logging output #7388
2020-11-24 18:22:33 +00:00
Hannah von Reth
1df3f5b6df
NSISUpdater: Improve logging for version comparison
2020-11-24 18:22:33 +00:00
Hannah von Reth
1aca005267
Updater: Log parsing issues in autoupdatLog parsing issues in autoupdatee
2020-11-24 18:22:33 +00:00
Markus Goetz
9a375211d7
Autoupdater: Log the URL #3475
2020-11-24 18:22:33 +00:00
Christian Kamm
d2991210c5
Updater: Preserve target version string
...
For #7217
2020-11-24 18:22:33 +00:00
Christian Kamm
aa7409f401
Updater: Make "Update manually" not also "skip this version"
...
See #7217
2020-11-24 18:22:33 +00:00
Christian Kamm
0b3512f49c
WinUpdater: More useful options on update failure #7217
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-24 18:22:33 +00:00
Olivier Goffart
9596eb7f20
Updater: show the human readable version in the settings
...
The xml looks like this:
<version>2.5.0.328</version>
<versionstring>ownCloud Client 2.5.0 alpha1 (build 238)</versionstring>
And we should show the version string
Issue #6602
2020-11-24 18:22:33 +00:00
Olivier Goffart
f2c3ef741b
Updater: remove unused function
2020-11-24 18:22:33 +00:00
Dominik Schmidt
ae38b88d1c
Remove unused installers before copying new ones into the appdata dir
2020-11-24 18:22:33 +00:00
Olivier Goffart
e93972824d
MSI: Fix crash in the auto updater
...
'auto' here is a QStringBuilder referencing a temporary
Ammend commit 150d4f5935
(MSI: Always with logfile #6609 )
Found in the crash reporter:
https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/
2020-11-24 18:22:33 +00:00
Markus Goetz
5e518419de
MSI: Always with logfile #6609
2020-11-24 18:22:33 +00:00
Dominik Schmidt
d069fda9ab
Extract filename of updateFile without leading slash
2020-11-24 18:22:33 +00:00
Dominik Schmidt
dfac8c0e59
Escape msi and owncloud.exe path (who knows...)
2020-11-24 18:22:33 +00:00
Dominik Schmidt
ed0dc68db2
Run msi properly and restart client after update
2020-11-24 18:22:33 +00:00
Dominik Schmidt
08b5981fb6
Implement basic .msi support in updater
2020-11-24 18:22:33 +00:00
Markus Goetz
412e43b696
Updater: Comments
2020-11-24 18:22:33 +00:00
Christian Kamm
4b39731c27
Updater: Make sparkle updater respect release channel
2020-11-24 18:22:33 +00:00
Markus Goetz
311e3a3bd8
Auto Updater: Show UI element also on macOS
...
(cherry picked from commit dfdc2e1e87f99d387a042f4983c999fbb7fcf3d9)
2020-11-24 18:22:33 +00:00
Christian Kamm
a8ad946758
Settings: Add update channel combobox #6259
2020-11-24 18:22:33 +00:00
Markus Goetz
65035d1990
Sparkle: Delegate calls work now with 1.18.1 (maybe even before)
...
We can extend on this to give UI feedback.
2020-11-24 18:22:33 +00:00
Camila
c24b81c081
Merge pull request #2660 from nextcloud/folder-watcher
...
FolderWatcher: fixes and improvements
2020-11-24 19:19:08 +01:00
Christian Kamm
08014b6dc3
FolderWatcher: Disable test on OSX #7305
2020-11-24 16:56:49 +00:00
Olivier Goffart
5a432a193f
FolderWatcher: Usage of QTime for elapsed time is deprecated
2020-11-24 16:56:49 +00:00
Christian Kamm
28e4fc54a1
FolderWatcher: Wait for ready before testing #7305
2020-11-24 16:56:49 +00:00
Christian Kamm
e97fc430bf
FolderWatcher: Become unreliable if test notification fails #7241
...
Necessary for some filesystems on windows that don't have full file
watching capabilities.
2020-11-24 16:56:49 +00:00
Christian Kamm
74382ddcc0
FolderWatcher linux: Make automatically recursive #7068
...
Previously it depended on addFolder() / removeFolder() calls to adjust
watchers when new folders were added or removed. There also needed to be
complex move handling.
Now, any folder creation/move-in notifications automatically trigger
watcher additions and folder deletion/move-out triggers removal.
2020-11-24 16:56:49 +00:00
Christian Kamm
21b931dc6b
FolderWatcher: Always notify about conflict files #7073
...
This makes sure that the conflict list can be updated if a user resolves
a conflict by deleting the local conflict file. Previously one had to
wait for the next sync run.
2020-11-24 16:56:49 +00:00
Christian Kamm
351bada552
Folderwatcher: On linux, fix paths after dir renames #6808
...
If a folder was renamed A -> B, the folder watcher for the inode
would be unaware and still report changes for A/foo. Now directory
renames in the watched folders are tracked and paths are updated
accordingly.
2020-11-24 16:56:49 +00:00
allexzander
fe29290564
Merge pull request #2663 from nextcloud/fix-windows-compilation
...
Fix Windows compilation broken after QML debugging fix.
2020-11-24 18:34:04 +02:00
allexzander
29ca1404cc
Fix Windows compilation broken after QML debugging fix.
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-24 16:50:16 +02:00
allexzander
d4c14f8f4f
Merge pull request #2662 from nextcloud/fix-qml-debugging
...
Fix QML debugging by removing incorrect dependency
2020-11-24 16:24:17 +02:00
allexzander
92733e9069
Fix QML debugging by removing incorrect dependency
...
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-24 15:19:17 +02:00
Nextcloud bot
2aa3d17e5c
[tx-robot] updated from transifex
2020-11-24 03:41:57 +00:00
Kevin Ottens
7cf3f14f78
Merge pull request #2658 from nextcloud/enable_qml_debugger_on_debug_builds
...
Enable the QML debugger on debug builds
2020-11-23 18:59:52 +01:00
Kevin Ottens
922b322337
Enable the QML debugger on debug builds
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-23 17:39:50 +00:00
allexzander
f530758f78
Merge pull request #2655 from nextcloud/use-dinamyc-path-for-account-state-icons
...
Use dynamic path for account online/offline state icon. Refresh GUI on connection state change.
2020-11-23 18:01:13 +02:00
allexzander
665a8c4217
Use dynamic path for account online/offline state icon. Refresh GUI on connection state change.
...
Signed-off-by: Alex Zolotov <alex.zolotov.nextcloud.com>
Signed-off-by: allexzander <blackslayer4@gmail.com >
2020-11-23 17:49:25 +02:00
Nextcloud bot
10cb0a71eb
[tx-robot] updated from transifex
2020-11-23 03:38:35 +00:00
Nextcloud bot
e6ea3878a9
[tx-robot] updated from transifex
2020-11-21 03:44:21 +00:00
Nextcloud bot
8faa103ebf
[tx-robot] updated from transifex
2020-11-20 03:43:18 +00:00
Nextcloud bot
d0004230b9
[tx-robot] updated from transifex
2020-11-19 03:43:51 +00:00
Kevin Ottens
44f2bc24ff
Merge pull request #2648 from nextcloud/debian_packages_should_not_block_ci
...
Issue a warning for Debian pipeline failures but don't fail the CI
2020-11-18 16:32:29 +01:00
Kevin Ottens
6f25840ec9
Issue a warning for Debian pipeline failures but don't fail the CI
...
Since this fails every time we bump the version number and takes time to
catch up while failing every following PRs, let's prevent this pipeline
from failing the CI.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-18 16:05:19 +01:00
Nextcloud bot
1950efcfff
[tx-robot] updated from transifex
2020-11-18 03:41:49 +00:00
Nextcloud bot
d026aa9301
[tx-robot] updated from transifex
2020-11-16 03:43:48 +00:00
Nextcloud bot
0d7865e6f8
[tx-robot] updated from transifex
2020-11-15 03:41:36 +00:00
Nextcloud bot
fa1f20ca8e
[tx-robot] updated from transifex
2020-11-14 03:44:00 +00:00
Nextcloud bot
771bac2279
[tx-robot] updated from transifex
2020-11-13 03:43:12 +00:00
Kevin Ottens
ebcdb41fb9
Merge pull request #2630 from nextcloud/bump_to_version_3.0.81
...
Master is now 3.0.81
2020-11-12 16:31:01 +01:00
Kevin Ottens
d2e0959b47
Master is now 3.0.81
...
This feels a bit like moving back in that case, but that's due to the
change of convention in the release process. We used to bump early but
now we're moving to a point when we bump at the last minute.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-12 15:53:16 +01:00
Nextcloud bot
2316cb6ce4
[tx-robot] updated from transifex
2020-11-12 03:44:40 +00:00
Nextcloud bot
f66b091e12
[tx-robot] updated from transifex
2020-11-11 03:47:29 +00:00
Camila
00a47fefaf
Merge pull request #2616 from nextcloud/move_journaldb_files_back_to_sync_folders
...
Move journaldb files back to sync folders
2020-11-10 19:19:14 +01:00
Kevin Ottens
4f7876f520
Migrate journal dbs files back to the sync folder
...
In case of past collisions during the 3.0 times... well one will resync
from scratch unfortunately. But if that happened there are likely other
problems which occurred.
Also this might fix some of the bugs with people loosing settings from
the database. Indeed the -wal and -shm concatenations were wrong. Using
append was in fact changing the folderDefinition member which (I guess)
would potentially lead to funny ".db-wal-shm-wal-shm" names.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Kevin Ottens
0b731eb516
Revert "moved default db sync file to Qt standard path AppDataLocation"
...
This reverts commit fc6b895f52 .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Kevin Ottens
1b553b93b9
Partial Revert "Adapted for cmd version and added migration step for config file"
...
This partially reverts commit 67ed54671b .
The migration code was left untouched.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Kevin Ottens
cebd39aa85
Revert "Adjust to makeDbName returning an absolute path"
...
This reverts commit 2492e241ac .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:46:43 +00:00
Camila
2e97a7fb74
Merge pull request #2531 from nextcloud/bring_back_systray_menu_pause_sync_action
...
Bring back the "Pause sync" action in the systray context menu
2020-11-10 18:43:52 +01:00
Kevin Ottens
6c463442ef
Bring back the pause/resume action in the systray menu
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:29:51 +00:00
Kevin Ottens
1288ee0437
Move pause/unpause helpers to Systray
...
We had signals just to call those backs in ownCloudGui, they were
otherwise unused. So let's move them inside of Systray since it's
specific to it anyway.
Also fix the dangerous call to sender(). We can call this function
without going through a signal/slot connection and also it's never
connected to an AccountState.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 17:29:51 +00:00
Camila
3ffc699058
Merge pull request #2620 from nextcloud/fix_crash_when_displaying_share_dialog
...
Make sure the settings dialog exist before hiding it
2020-11-10 18:09:54 +01:00
Kevin Ottens
95487d8bfc
Make sure the settings dialog exist before hiding it
...
Because of PR #2580 the settings dialog doesn't always exist. We need to
check for it first before placing calls to it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-10 16:57:56 +00:00
Camila
863db075eb
Merge pull request #2621 from nextcloud/wiswedel/documentation/chunkedUpload
...
[documentation] upload chunks config
2020-11-10 17:56:28 +01:00
Sascha Wiswedel
e69b26e363
[documentation] upload chunks config
...
documenting e86499d990
2020-11-10 14:56:32 +01:00
Nextcloud bot
4382193519
[tx-robot] updated from transifex
2020-11-10 03:45:50 +00:00
Nextcloud bot
7a093592a0
[tx-robot] updated from transifex
2020-11-09 03:42:28 +00:00
Nextcloud bot
942d8ba86a
[tx-robot] updated from transifex
2020-11-08 03:42:17 +00:00
Nextcloud bot
9f9bcecd31
[tx-robot] updated from transifex
2020-11-07 03:42:02 +00:00
Kevin Ottens
46aba0832d
Merge pull request #2615 from nextcloud/fetch_apps_on_connectivity_changes_only
...
Fetch apps when we get connected only
2020-11-05 13:55:36 +01:00
Kevin Ottens
86d240f7b4
Fetch apps when we get connected only
...
This was right now on the check connectivity beat which is too much when
you got many users. Be more conservative there and only update the list
of apps when the account gets connected.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-05 13:37:25 +01:00
Nextcloud bot
6445a61d80
[tx-robot] updated from transifex
2020-11-05 03:40:34 +00:00
Nextcloud bot
3749fe15b6
[tx-robot] updated from transifex
2020-11-04 03:41:27 +00:00
Nextcloud bot
50e038cfaa
[tx-robot] updated from transifex
2020-11-03 03:41:44 +00:00
Camila
44a55674ac
Merge pull request #2603 from nextcloud/remove_findqt5keychain_cmake_module
...
Get rid of FindQt5Keychain.cmake
2020-11-02 14:36:46 +01:00
Kevin Ottens
0e617d020f
Adjust AppImage build of QtKeychain to be found by cmake
...
Now that things are done in a more standard way, let's adjust the
AppImage build so that QtKeychain is picked up properly now that our
FindQt5Keychain.cmake file is gone.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-02 13:28:02 +01:00
Kevin Ottens
3427dadaeb
Get rid of FindQt5Keychain.cmake
...
QtKeychain provides Qt5KeychainConfig.cmake and friends nowadays, so no
need to have a less reliable and outdated find module on our end.
Also this shows that we were including keychain.h in the wrong way and
were not using the link target, so both got fixed as well.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-11-02 13:19:48 +01:00
Nextcloud bot
dfd6cce978
[tx-robot] updated from transifex
2020-11-02 03:41:37 +00:00
Nextcloud bot
5a8c2bab89
[tx-robot] updated from transifex
2020-11-01 03:40:38 +00:00
Nextcloud bot
a14930c293
[tx-robot] updated from transifex
2020-10-31 03:41:57 +00:00
Nextcloud bot
a3914482d7
[tx-robot] updated from transifex
2020-10-30 03:42:51 +00:00
Kevin Ottens
56d067d7a9
Merge pull request #2589 from sryze/windows7-fixes
...
Misc fixes for Windows 7
2020-10-28 07:39:14 +01:00
Sergey Zolotarev
18c1bc0bd6
Misc fixes for Windows 7
...
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com >
2020-10-28 06:24:53 +00:00
Nextcloud bot
ef86d4b738
[tx-robot] updated from transifex
2020-10-28 03:42:53 +00:00
Nextcloud bot
a74861dbb5
[tx-robot] updated from transifex
2020-10-27 03:42:33 +00:00
Kevin Ottens
9593cea18c
Merge pull request #2591 from nextcloud/fix_conflict_dialog_wording
...
Remove last left over of the "remote" wording
2020-10-26 16:09:49 +01:00
Kevin Ottens
3e6b257ccd
Remove last left over of the "remote" wording
...
I switched from "remote" to "server" but apparently left one behind by
mistake...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-26 14:45:46 +00:00
Valdnet
d17c9af044
Merge pull request #2586 from nextcloud/Valdnet-patch-2
...
l10n: Change the triple dot to ellipsis
2020-10-26 15:09:15 +01:00
Valdnet
204cced445
l10n: Change the ellipsis
2020-10-26 13:22:55 +00:00
Valdnet
f116c39b0a
l10n: Add a space in generalsettings.ui
2020-10-26 13:22:55 +00:00
Kevin Ottens
6b794ddd5a
Merge pull request #2582 from nextcloud/macos_add_more_information_on_skipped_file_watcher_event
...
Also output the event flags in the debug logs
2020-10-26 14:15:15 +01:00
Kevin Ottens
8fad88055e
Also output the event flags in the debug logs
...
When we skip a watcher event on mac, we log the file path but not the
event flags which came with it. Let's add it, it should help figure out
what's going on with #2578 .
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-26 12:37:00 +00:00
Valdnet
1627522695
Merge pull request #2587 from nextcloud/rakekniven-patch-1
...
Triple dot to ellipsis
2020-10-26 13:32:42 +01:00
rakekniven
62fa8028a6
Triple dot to ellipsis
...
Reported at Transifex.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de >
2020-10-26 12:22:23 +00:00
Nextcloud bot
92801816e0
[tx-robot] updated from transifex
2020-10-26 03:37:49 +00:00
Nextcloud bot
599cf0143f
[tx-robot] updated from transifex
2020-10-25 03:39:15 +00:00
Nextcloud bot
38205cab68
[tx-robot] updated from transifex
2020-10-24 03:39:31 +00:00
Nextcloud bot
fa8f37e987
[tx-robot] updated from transifex
2020-10-23 03:38:53 +00:00
Camila
2bcc99792d
Merge pull request #2581 from nextcloud/ensure_systray_window_doesnt_prevent_windows_session_close
...
Ensure we quickly show/hide the systray window on startup
2020-10-22 19:48:43 +02:00
Kevin Ottens
24964e2b9b
Ensure we quickly show/hide the systray window on startup
...
This is quick enough that no flickering should appear in practice.
We end up doing this because for some reason on Windows (I dug up deep
into the Windows QPA without nailing it down) not showing that systray
window at least once prevents the app object to return from exec() when
the session ends.
It's as if that window would be in some limbo state (neither opened nor
closed) which would prevent quitting. Clearly what we're doing here is a
workaround...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 17:31:05 +00:00
Kevin Ottens
802d27ed0f
Merge pull request #2527 from nextcloud/improve_conflict_handling_gui
...
Improve conflict handling gui
2020-10-22 18:27:45 +02:00
Kevin Ottens
b835092ae9
Use the ConflictDialog directly from the activity list
...
No need to go to the file manager first to then have the user go through
the context menu, just popup the dialog directly.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:47 +02:00
Kevin Ottens
4116c90c9c
Move the activity action behavior on the C++ side
...
We better do this before this business logic grows in the QML side and
gets out of control. We'll need finer grained information due to the
conflict handling anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
910f0c9339
Repair SettingsDialog::showIssuesList
...
This was completely disabled code and the connect was gone... So let's
introduce the connect back and have it trigger the main window while
selecting the right user. This way the new activity list is displayed
and since the conflicts are shown at the top this is hopefully obvious
again.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
c42f4abd25
Add a function to know the user id matching a given account
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
e3b97b0a04
In the case of conflicts, have the socket api propose the config dialog
...
This should be safe in the case of conflicts in folders on which the
user can write. For other cases we still use the older actions.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
49c478cd2a
Add a conflict dialog to help the user solve them
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
67e81fcd0f
Add KeepBothVersions as a possible solution to ConflictSolver
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
4fdb203cdb
Move some of the SocketApi conflict handling in a ConflictSolver class
...
The socket api move and delete commands are not strictly about conflicts
since they also deal with files which couldn't be uploaded for some
other reason. Still the new ConflictSolver could be used in those cases.
This opens the door at reusing that logic in other places.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:46 +02:00
Kevin Ottens
26d62a9712
Repair the canAddToDir logic
...
This could only work at the root of the sync folder where the record for
the parent folder would be invalid. Otherwise the negation would be
wrong... assuming you can add a file only if the permission is not
there.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:44 +02:00
Christian Kamm
00e901f5a7
SocketAPI: Introduce conflict resolution actions #6252
...
For conflicts generally as well as new files in read-only directories
the context menu will now present delete and move options.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-22 16:40:10 +02:00
Christian Kamm
f62be57ef2
FileSystem: make removeRecursively() reusable
...
We want to use it for deleting directory conflicts.
2020-10-22 16:39:17 +02:00
Christian Kamm
e70371f408
FileSystem: Fix bad indentation
2020-10-22 16:39:17 +02:00
Kevin Ottens
b982a17998
Merge pull request #2580 from nextcloud/delay-settingsdialog-init
...
Delay initialization of SettingsDialog
2020-10-22 15:08:01 +02:00
Michael Schuster
7699004a11
Fix crash in SettingsDialog with delayed initialization
...
setWindowFlags triggered changeEvent, thus causing a crash in customizeStyle.
This fix should be kept even if we decide against delayed init in the future.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-22 11:29:38 +00:00
Michael Schuster
0fb10163a3
Delay initialization of SettingsDialog
...
ownCloudGui::slotShowSettings already got what it takes to create it only when we try to show it for the first time.
This however has some implications:
Pros:
- Only created when needed, while testing saved ca. 20 MB of RAM and got freed again after closing the dialog.
- Since we defaulted to the new Tray UI from 3.0, this is an added bonus for users don't opening the settings.
Cons:
- Resources like the avatar image have to be refetched everytime the dialog is recreated.
This may be desired as well, because it ensures displaying no outdated info (e.g. on connection issues).
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-22 11:29:38 +00:00
Nextcloud bot
40aa53bf76
[tx-robot] updated from transifex
2020-10-22 03:39:17 +00:00
Kevin Ottens
bb43127633
Merge pull request #2575 from nextcloud/expose_branding_values_to_qtquick
...
Expose branding values to qtquick
2020-10-21 14:13:40 +02:00
Kevin Ottens
c6c2d4cf4c
Use the Theme colors for the header part of the window
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:46:51 +02:00
Kevin Ottens
a2e3f9d63a
Expose Theme on the QML side
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:46:38 +02:00
Kevin Ottens
7536e4c00b
Expose the branding related members of Theme as properties
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:46:04 +02:00
Kevin Ottens
de63e5e221
Don't hardcode the color of text in the header
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 13:40:42 +02:00
Kevin Ottens
0e9efe728a
Get rid of ncBlueHover
...
Use a similar trick of a semi-transparent rectangle on top when the
mouse area is hovered. This way it will always work whatever is the
background color.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 11:24:06 +02:00
Kevin Ottens
60da0cee25
Merge pull request #2572 from nextcloud/avoid_depth_infinity_propfind_for_e2ee
...
Avoid depth infinity propfind for e2ee
2020-10-21 10:16:14 +02:00
Kevin Ottens
10cb4170c7
Don't use depth infinity anymore to get the folders e2ee status
...
This way we avoid the expensive SQL query on the server at the price of
more round-trips since we're doing the recursive traversal by hand now.
Also it turns out this depth was used for all the other propfind calls
during sync when we want fresher information regarding a folder. This
was very inefficient in all cases and won't happen anymore.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:59 +02:00
Kevin Ottens
b5fdbefb0e
Make sure jobs don't outlive ClientSideEncryption
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
399b97442e
Factor out the logic to start a new e2ee status job
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
cbc40b5a15
Mention the folder we listed in the debug logs
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
8e3ca71763
Change the way we store the job result
...
If there's more than one job we need to unite the maps not simply overwrite
them.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
9aeb7046d2
Start managing a list of GetFolderEncryptStatusJob
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Kevin Ottens
cfb66ddadd
Add a way to know which folder was listed for encrypted status
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-21 10:00:58 +02:00
Nextcloud bot
65b90f4bb1
[tx-robot] updated from transifex
2020-10-21 03:39:44 +00:00
Kevin Ottens
534f0567bf
Merge pull request #2568 from nextcloud/fix-macos-crash-403-folder-view
...
Fix crash when clicking on folder with status 403 in the main dialog.
2020-10-20 16:38:13 +02:00
Camila San
03b1c0b84a
Fix crash when clicking on folder with status 403 in the main dialog.
...
LsColJob was still being used after delete was called.
Signed-off-by: Camila San <hello@camila.codes >
2020-10-20 16:19:27 +02:00
Nextcloud bot
671ca522ea
[tx-robot] updated from transifex
2020-10-20 03:38:46 +00:00
Kevin Ottens
0927b9bc90
Merge pull request #2551 from nextcloud/fix_share_dialog_animation_for_enforced_password_policy
...
Fix share dialog animation for enforced password policy
2020-10-19 17:09:55 +02:00
Kevin Ottens
b7ea6530c5
Stop the animation if we got an error message
...
Otherwise it would spin forever while we know we're not doing any work
anymore since we got a message from the server.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-19 14:33:19 +00:00
Kevin Ottens
ecc170decc
Inform _emptyShareLinkWidget of linkShareRequiresPassword signals
...
All the other ShareLinkWidgets process that signal (which allows to
display error messages for instance) but not that one for some reason.
That being said it might need to deal with an enforced password
situation.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-19 14:33:19 +00:00
Kevin Ottens
e502e71926
Emit last to avoid use after delete crash
...
It turns out the shareDeleted() signal is connected to a function
cleaning up the ShareLinkWidget holding the last shared pointer to the
Share object. Since we use member variables for calling updateFolder()
this would lead to using deleted objects.
Just swap the call and the signal to have everything back in order.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-19 14:33:19 +00:00
Nextcloud bot
3329df4caf
[tx-robot] updated from transifex
2020-10-17 03:38:33 +00:00
Nextcloud bot
801c77401c
[tx-robot] updated from transifex
2020-10-16 03:39:07 +00:00
Nextcloud bot
f6824de126
[tx-robot] updated from transifex
2020-10-15 03:37:51 +00:00
Michael Schuster
61dc4b9137
Update comments
...
Everyone uses their private mail, so ensure people can get in touch.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-15 02:18:52 +02:00
Nextcloud bot
e656d67f39
[tx-robot] updated from transifex
2020-10-14 03:41:57 +00:00
Kevin Ottens
38f4843582
Merge pull request #2534 from nextcloud/connection_wizard_improvements
...
Connection wizard improvements
2020-10-13 15:23:56 +02:00
Kevin Ottens
ca57221b74
Ensure we use the app name in the GUI
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:43 +02:00
Kevin Ottens
7efaa2ed68
Fix the secure lock label aspect
...
Make sure we got a fixed size for that label. Also ensure that the
pixmap we display there is properly scaled to fit while maintaining the
aspect ratio.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:32 +02:00
Kevin Ottens
ec945b8ac7
Hide the slideshow when going to the login page
...
This is indeed very distracting otherwise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:32 +02:00
Kevin Ottens
9ec4b5ef8e
Add a label explaining the server address field
...
This is as discussed in #1160
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:31 +02:00
Kevin Ottens
5e472e629f
Improve wording on the wizard buttons
...
This is as discussed on #1158
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-13 07:28:31 +02:00
Nextcloud bot
d0a9d21de8
[tx-robot] updated from transifex
2020-10-13 03:40:16 +00:00
Kevin Ottens
e980682b4d
Merge pull request #2543 from renyhp/patch-2
...
Update bookmarks location
2020-10-12 17:31:11 +02:00
renyhp
e5b307c81f
Update bookmarks location
...
Signed-off-by: renyhp <renyhp@disroot.org >
2020-10-12 15:02:00 +00:00
Kevin Ottens
3c986ead91
Merge pull request #2542 from nicolasfella/puzzel
...
Avoid string translation puzzle
2020-10-12 17:00:49 +02:00
Nicolas Fella
206c98688e
Avoid string translation puzzle
...
Combining translated strings like this makes them hard to translate since the order of words is different between languages.
Use proper placeholder strings instead.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-10-12 13:34:50 +00:00
Kevin Ottens
e787054d1c
Merge pull request #2541 from nicolasfella/work/nullptrflags
...
Don't use nullptr for QFlags
2020-10-12 15:33:38 +02:00
Nicolas Fella
6f17bbe6d5
Don't use nullptr for QFlags
...
This fixes some deprecation warnings
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-10-12 11:52:53 +00:00
Kevin Ottens
142894b2f7
Merge pull request #2221 from nicolasfella/declarative
...
Make QML code more declarative by using properties
2020-10-12 13:51:47 +02:00
Nicolas Fella
f5860928d9
Make QML code more declarative by using properties
...
By using properties and property bindings the QML code gets more declarative rather than imperative, which is considered better.
This patch:
- Introduces a currentUserId property in UserModel that replaces the equivalent Q_INVOKABLE call
- Introduces an avatar property in User that contains the avatar's image provider url without any fallback
- Introduces new image provider urls for fallback images
- Moves the fallback image selection to QML since we want different fallbacks according to where it is used
- Wires up the necessary signals to propagate a changing avatar
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de >
2020-10-12 11:00:20 +00:00
Nextcloud bot
1d939121fc
[tx-robot] updated from transifex
2020-10-12 03:37:35 +00:00
Nextcloud bot
bfe9b0ba91
[tx-robot] updated from transifex
2020-10-10 03:42:03 +00:00
Nextcloud bot
3148705df6
[tx-robot] updated from transifex
2020-10-09 03:37:01 +00:00
Camila
643e43dcfb
Merge pull request #2530 from nextcloud/repair_windows_build
...
Repair the Windows build
2020-10-08 17:21:04 +02:00
Kevin Ottens
a53a87a3eb
Export the WordList functions
...
Now that they are used from gui/ they need to be properly exported so
that linking doesn't fail when visibility is activated (only on our
Windows build it seems).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 15:58:29 +02:00
Kevin Ottens
fc9ceb5af9
Merge pull request #2521 from nextcloud/use_friendly_user_agent_during_authentication
...
Use friendly user agent during authentication
2020-10-08 12:42:17 +02:00
Kevin Ottens
ab67741d87
Use setHeader instead of setRawHeader for the user agent
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Kevin Ottens
3d8af05037
Use friendly user agent during webflow2 auth
...
This way the server displays a less scary string while granting access
from the browser. Also this same string will be used in the "Devices and
sessions" section of the server settings.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Kevin Ottens
836de0358d
Add a function for a more friendly user agent string
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Kevin Ottens
50dd715f4d
Don't force user agent if one is already set on the request
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-08 05:55:47 +00:00
Nextcloud bot
d0ce8bc1ae
[tx-robot] updated from transifex
2020-10-08 03:37:16 +00:00
Michael Schuster
211dbadd1a
Merge pull request #2514 from nextcloud/make_it_easier_for_user_to_provide_debug_information
...
Make it easier for user to provide debug information
2020-10-07 17:12:02 +02:00
Kevin Ottens
3fca307fbb
Also add build infos in the archive
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
8ce137cc53
Also add the command line arguments in the archive
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
8fb673457b
Add a button to create a debug archive
...
This will harvest everything we might need for debugging purposes:
* config file
* sync journal dbs
* log files
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
15d294e7fb
Add dependency on QtGuiPrivate
...
I'm not a huge fan of using private APIs but QZip is really the API with
the least hassles for our debug archive need. No external dependency and
we know it is generally available and stable despite the lack of
stability promise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
607347289e
Expose more of the logger state
...
It is better to rely on the Logger state to know exactly where we're
logging. Indeed due to the the various ways to impact its state the
config alone might not now where we're logging.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
167800320f
Make sure --logfile has precedence on config
...
Since we changed the default in the config file and since log dir had
precedence on log file, the --logfile command line option wasn't doing
anything anymore.
We make sure it has an effect again overriding --logdir or the logDir
config entry.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Kevin Ottens
b0a38816fc
Change the defaults for logging
...
Turn on the logging by default for everyone. Let's use a log dir within
the config directory of the application and have debug logs expiring
after a day.
This obviously means we'll generate quite some logs but with the
automated compression it shouldn't be too horrible. Obviously that
scales with the amount of files and syncs occurring. In our tests with a
large setup we're around 100 MB for a day worth of logs, this shouldn't
be too much of an issue on today's average desktop/laptop.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 13:33:20 +00:00
Michael Schuster
f90ae66d94
Merge pull request #2520 from nextcloud/handle_askForOptionalPassword_capability
...
Handle ask for optional password capability
2020-10-07 15:30:17 +02:00
Kevin Ottens
e78312f094
If askForOptionalPassword is enabled preset a random password
...
This is the same approach used on the server side. Turns out I quite
like it, this avoids popping up a dialog to the user and since she won't
know the password she'll have to set a new one anyway or disable it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 09:43:47 +00:00
Kevin Ottens
099d25a56c
Since we must ask for a password this can't be a default public link
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 09:43:47 +00:00
Kevin Ottens
e356acbcee
Add sharePublicLinkAskOptionalPassword to Capabilities
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-07 09:43:47 +00:00
Nextcloud bot
d6f53d66f4
[tx-robot] updated from transifex
2020-10-07 03:36:23 +00:00
Nextcloud bot
a2a58eefde
[tx-robot] updated from transifex
2020-10-06 03:36:51 +00:00
Michael Schuster
36002701ed
Merge pull request #2512 from nextcloud/fix_updater_with_github_downloads
...
Handle redirects when downloading updates
2020-10-05 16:56:23 +02:00
Kevin Ottens
f39542688a
Handle redirects when downloading updates
...
This is necessary for downloads coming from Github for instance. They
are systematically redirected and we'd just fail the download.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-10-05 15:48:39 +02:00
Kevin Ottens
01152d3f37
Merge pull request #2500 from nextcloud/docs-msi
...
Windows MSI: Update Docs & add SKIPAUTOUPDATE property
2020-10-05 09:43:00 +02:00
Michael Schuster
b552c77128
Docs: Be slightly more modern and use 64-bit examples
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
ce279d0bbd
Windows MSI: Add SKIPAUTOUPDATE property for the skipUpdateCheck setting
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
c5ff288b37
Docs: Use our app name in the MSI docs
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
2476dcb425
Windows MSI: Stay compatible with the upstream "StartMenuShortcuts" feature
...
Even though we only create a program shortcut in the Start Menu, try to make administrators lives easier by not diverging feature and option naming.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
bf6980d31a
Docs: Adopt latest MSI doc enhancements from upstream master
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Dominik Schmidt
8e48d53b04
Docs: Adopt upstream commit fe04300 for MSI installation
...
See: fe043006c8
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Michael Schuster
0e5d9a5a6b
Docs: Update macOS version info
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-05 07:18:35 +00:00
Nextcloud bot
d1c0481338
[tx-robot] updated from transifex
2020-10-05 03:38:36 +00:00
Nextcloud bot
06177b1a7c
[tx-robot] updated from transifex
2020-10-04 03:38:54 +00:00
Nextcloud bot
ebe7cbf0ed
[tx-robot] updated from transifex
2020-10-03 03:40:51 +00:00
Michael Schuster
a0b351b145
Merge pull request #2497 from nextcloud/fix/mac-folderwatcher-memory-leak
...
macOS: Fix memory leak in FolderWatcherPrivate::startWatching
2020-10-02 19:30:26 +02:00
Michael Schuster
bb30633d31
Fix source file access modes
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-02 16:56:29 +00:00
Michael Schuster
5979ae30e1
macOS: Fix memory leak in FolderWatcherPrivate::startWatching
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-10-02 16:56:29 +00:00
Nextcloud bot
4b985ab3b3
[tx-robot] updated from transifex
2020-10-02 03:32:41 +00:00
Michael Schuster
5467909389
Merge pull request #2478 from Aldaris1985/patch-1
...
Update propagateupload.cpp
2020-10-02 00:07:45 +02:00
Aldaris1985
ef6773bd60
Update propagateupload.cpp
...
Typo corrected.
2020-10-01 21:26:17 +00:00
Kevin Ottens
c1feecc727
Merge pull request #2493 from nextcloud/kesselb-patch-1
...
Delete FUNDING.yml
2020-10-01 13:03:09 +02:00
kesselb
fbeba931d2
Delete FUNDING.yml
2020-10-01 11:21:12 +02:00
Nextcloud bot
ce2dec0194
[tx-robot] updated from transifex
2020-10-01 03:40:09 +00:00
Kevin Ottens
48524fc1f4
Merge pull request #2487 from nextcloud/add-talk-icon
...
Add a clickable icon for Talk notifications.
2020-09-30 14:02:27 +02:00
Camila
954544830d
Add a clickable icon for Talk notifications.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-30 08:46:01 +00:00
Nextcloud bot
2cb919a684
[tx-robot] updated from transifex
2020-09-30 03:39:38 +00:00
Kevin Ottens
6569ecbd27
Merge pull request #2272 from snake66/issues/2219/deprecate-foreach
...
Issues/2219/deprecate foreach
2020-09-29 19:58:52 +02:00
Harald Eilertsen
7721da25e5
Replace find_if with none_of where appropriate.
...
We're not interested in any found element in these cases, just to check
that none of the elements matches.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:32:39 +02:00
Harald Eilertsen
061ef027ff
Don't hold ref to value returned from function.
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:32:24 +02:00
Harald Eilertsen
074a94ceb9
gui/accountmanager: Make isAccountIdAvailable a bit clearer.
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:24 +02:00
Harald Eilertsen
62bf4c5fda
gui/folderman: Replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:24 +02:00
Harald Eilertsen
677997b2b3
gui/folder: Replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
5bd2529ca6
gui/application: replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
e343b4b947
gui/accountstate: Replace foreach ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
225fdabf6a
gui/accountstate: Replace foreach ( #2219 )
...
Most instances have been converted to range based for, but std::find_if
has been used where it made sense.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
1898782781
gui/accountmanager: Replace foreach/Q_FOREACH ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Harald Eilertsen
5f4cec870b
cmd: Replace foreach with range base for ( #2219 )
...
Signed-off-by: Harald Eilertsen <haraldei@anduin.net >
2020-09-29 19:31:23 +02:00
Camila
1b1975e01d
Merge pull request #2486 from nextcloud/fix-notification
...
Connect signal guiLog to slot to display systray message.
2020-09-29 19:26:06 +02:00
Camila
dc12cdf196
Correct the object name returned by the api.
...
The id was always 0 so no new systray messages were displayed.
Signed-off-by: Camila <hello@camila.codes >
2020-09-29 18:53:28 +02:00
Camila
d2eb24a9a8
Connect signal guiLog to slot to display systray message.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-29 18:53:28 +02:00
Kevin Ottens
b9873cac63
Merge pull request #2485 from nextcloud/Valdnet-patch-1
...
l10n: Remove space from string text
2020-09-29 14:43:39 +02:00
Valdnet
d50ad548d2
l10n: Remove space from string text
2020-09-29 14:39:34 +02:00
Nextcloud bot
68ba07a45a
[tx-robot] updated from transifex
2020-09-29 03:41:15 +00:00
Kevin Ottens
10b23200ab
Merge pull request #2317 from nextcloud/tray-accessibility
...
Tray accessibility
2020-09-28 16:48:26 +02:00
Dominique Fuchs
b96b7e20c7
emitting signals from Qts Accessibility interaction invocations instead of duplicating actions
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
1053c58b0f
KISS. Removed description for now, instead clarified some Accessible.name
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
8abe4219a5
Added missing qsTr() calls - again
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
a69898371f
Added missing qsTr() calls
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
a4151d71bc
Fix typo
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
3287ec2387
Typo fixes, minor additions
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
c6047e4d63
Re-add wrongly delete action
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Dominique Fuchs
43bf703806
Initial accessibility declarations for tray window qml src
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-28 12:38:21 +00:00
Camila
a7a079a335
Merge pull request #2477 from nextcloud/free_icon_job
...
Free IconJob after use
2020-09-28 13:02:41 +02:00
Dan Griffin
5763e1e9d8
Free IconJob after use
...
Signed-off-by: Dan Griffin <github.mk@xiragon.com >
2020-09-28 12:30:53 +02:00
Nextcloud bot
836638815f
[tx-robot] updated from transifex
2020-09-28 03:37:52 +00:00
Nextcloud bot
eefa46a8e7
[tx-robot] updated from transifex
2020-09-27 03:37:06 +00:00
Nextcloud bot
d58af951f3
[tx-robot] updated from transifex
2020-09-26 03:38:03 +00:00
Nextcloud bot
78a3e45456
[tx-robot] updated from transifex
2020-09-25 03:41:46 +00:00
Kevin Ottens
7b1ba31c13
Merge pull request #2470 from nextcloud/fix_qt_5_12_tooltip_wrap
...
Force tooltip wrap mode because it's not enabled in Qt 5.12...
2020-09-24 14:49:44 +02:00
Kevin Ottens
78b03739a7
Force tooltip wrap mode because it's not enabled in Qt 5.12...
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-24 14:47:56 +02:00
Nextcloud bot
16b709edbc
[tx-robot] updated from transifex
2020-09-24 03:38:39 +00:00
Kevin Ottens
a2899eba74
Merge pull request #2409 from jplsek/native-text-render
...
Use native text rendering for qml windows
2020-09-23 13:15:00 +02:00
Jeremy Plsek
5fa2a13f8d
Use native text rendering for qml windows
...
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com >
2020-09-23 08:00:46 +00:00
Kevin Ottens
dde4dd78fb
Merge pull request #2441 from nextcloud/enh/server-url
...
Allow server URL to be pre-defined without enforcing it
2020-09-23 09:59:31 +02:00
Michael Schuster
ce71ffe9f9
Allow server URL to be pre-defined without enforcing it to be used unmodified
...
APPLICATION_SERVER_URL can be either empty or be specified. This commit adds the new CMake option APPLICATION_SERVER_URL_ENFORCE to decide whether to enforce the
URL's unmodified use (like before, default: ON) or to allow modification by the user (new).
By default APPLICATION_SERVER_URL_ENFORCE is set to ON, to no break with the previous implementation's expectations.
If APPLICATION_SERVER_URL is empty, APPLICATION_SERVER_URL_ENFORCE will be ignored by the Account Wizard.
The previous behaviour confused me a bit with branded builds. When the URL was (usually) specified but not forced, it was simply discarded, forcing the user to
manually supply it.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-23 07:21:35 +00:00
Nextcloud bot
122493eeeb
[tx-robot] updated from transifex
2020-09-23 03:37:35 +00:00
Nextcloud bot
3ca6f4b0f2
[tx-robot] updated from transifex
2020-09-22 03:37:33 +00:00
Michael Schuster
b72bfb5c65
Merge pull request #2369 from nextcloud/enh/windows-msi
...
Windows: MSI support & Win32 migration tools
2020-09-21 17:35:37 +02:00
Michael Schuster
e024aa3f16
Windows: Win32 migration tools code review
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
a9014f9852
Windows MSI: Add MSI scripts and UI resources
...
Uses CMake to generate and install all required files in the "msi/" directory.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
f321cd8ae6
Windows: Add Win32 stand-alone migration tool NCNavRemove
...
Removes all Explorer Navigation Pane entries for a given ApplicationName, specified in NavRemove.ini in the working directory.
Also compiles a DLL with the same behaviour that exports:
- RemoveNavigationPaneEntries
Both tool variants are Mutex-protected.
Statically linked, optimized for binary size, no Qt dependencies.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
68776fe319
Windows MSI: Add helper DLL and shared migration tools code
...
The helper DLL will be utilized by Windows Installer with Custom Actions defined in the NCMsiHelper.wxs WiX fragment.
Exports:
- ExecNsisUninstaller
- RemoveNavigationPaneEntries
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
fc365df5de
Windows MSI: Let CMake install Shell Extensions WiX fragment to "msi/"
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Michael Schuster
fad9b2c969
Windows MSI: Add Upgrade Code and migration tool build options to NEXTCLOUD.cmake
...
The Upgrade Code is a GUID (specified without brackets) for the MSI package to allow Windows Installer identify existing installations.
New build options (default: OFF):
- BUILD_WIN_MSI: Build all MSI scripts and a required helper DLL (to uninstall NSIS legacy installations and remove Explorer Navigation Pane entries)
- BUILD_WIN_TOOLS: Build additional migration tools (currently NCNavRemove, a stand-alone tool for Explorer entries removal)
The helper DLL and migration tools are set to be statically linked and optimized for binary size.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-21 16:40:19 +02:00
Kevin Ottens
58b88de936
Merge pull request #2431 from jplsek/remove-this-includes
...
Remove "This includes" due to tooltip order
2020-09-21 15:40:37 +02:00
Jeremy Plsek
3a53afd704
Remove "This includes" due to tooltip order
...
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com >
2020-09-21 09:46:25 +00:00
Nextcloud bot
c127052f2d
[tx-robot] updated from transifex
2020-09-21 03:32:07 +00:00
Nextcloud bot
ed972a0e3f
[tx-robot] updated from transifex
2020-09-20 03:31:45 +00:00
Nextcloud bot
5d7e1b6a69
[tx-robot] updated from transifex
2020-09-19 03:34:11 +00:00
Michael Schuster
0f2784107c
Merge pull request #2437 from nextcloud/remove_no_description_available_messages_in_activity_list
...
If there's no description just say nothing
2020-09-18 20:41:34 +02:00
Kevin Ottens
3171cb2720
If there's no description just say nothing
...
Otherwise we get lots of "No description available" lines in the
activity list which is basically noise. Also trains the user to ignore
the secondary line.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-18 17:46:38 +00:00
Michael Schuster
f451e1d2d5
Merge pull request #2445 from nextcloud/fix-mac-catalina-login
...
Entitlement to sign the QtWebEngineProcess with an exception.
2020-09-18 06:44:11 +02:00
Camila San
9c5a51bb07
Entitlement to sign the QtWebEngineProcess with an exception.
...
Fix for #1793 : The problem seems to be related enabling hardened runtime.
This exception allows the webview to load.
Signed-off-by: Camila San <hello@camila.codes >
2020-09-18 04:35:06 +00:00
Nextcloud bot
091c805f9e
[tx-robot] updated from transifex
2020-09-18 03:30:59 +00:00
Dominique Fuchs
54364e7374
Merge pull request #2439 from nextcloud/fix-subfolder-missing-contentsync
...
Fix missing subdirectory discovery on move operations in macOS
2020-09-17 16:04:12 +02:00
Dominique Fuchs
f8f3190cb4
Fix missing subdirectory discovery on move operations in macOS.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Add qAsConst to avoid detaching
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Changed callchain to find and return possibly coalesced paths
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Removed another qAsConst remnant, more func const-correctness.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-17 15:44:32 +02:00
Nextcloud bot
ed3eb1ac9c
[tx-robot] updated from transifex
2020-09-17 04:13:19 +00:00
Kevin Ottens
61a74e67c9
Merge pull request #2435 from nextcloud/fix-journal-upgrade-multiple-syncconnections
...
Fix incomplete journal upgrade from 2.x to 3.x
2020-09-16 13:21:42 +02:00
Dominique Fuchs
d09b0284dd
Do not break out of outer loop when upgrading folders, continue instead
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
Remove awkward debug line a.k.a. whoops
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com >
2020-09-16 10:57:43 +02:00
Kevin Ottens
5eba2e9163
Merge pull request #2432 from nextcloud/fix/nsis-language-encoding
...
Windows: Fix NSIS language encoding (use UTF-8)
2020-09-16 09:13:26 +02:00
Michael Schuster
0e1e3a29ce
Windows: Remove unused and outdated NSIS Transifex settings
...
The last translation update from Transifex was done in 2017, so the scripts and settings were never used for Nextcloud.
This commit removes the unused scripts and "Auto-generated" comments in the translation files.
Some files have been modified over time either way and MSI will replace NSIS soon.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-16 05:41:27 +00:00
Michael Schuster
7f5b7f637c
Windows: Fix NSIS language encoding (use UTF-8 instead of Win code pages)
...
The old conversion to specific code pages caused display errors (see issue #2393 for Russian).
Based on bin/l10n.sh, the files in this commit were converted to UTF-8 using iconv with the following parameters:
iconv -f CP1252 -t UTF-8 -o German.nsh German.nsh
iconv -f CP1252 -t UTF-8 -o Galician.nsh Galician.nsh
iconv -f CP1253 -t UTF-8 -o Greek.nsh Greek.nsh
iconv -f CP1250 -t UTF-8 -o Slovenian.nsh Slovenian.nsh
iconv -f CP1257 -t UTF-8 -o Estonian.nsh Estonian.nsh
iconv -f CP1252 -t UTF-8 -o Italian.nsh Italian.nsh
iconv -f CP1252 -t UTF-8 -o PortugueseBR.nsh PortugueseBR.nsh
iconv -f CP1252 -t UTF-8 -o Spanish.nsh Spanish.nsh
iconv -f CP1252 -t UTF-8 -o Dutch.nsh Dutch.nsh
iconv -f CP1252 -t UTF-8 -o Finnish.nsh Finnish.nsh
iconv -f CP932 -t UTF-8 -o Japanese.nsh Japanese.nsh
iconv -f CP1250 -t UTF-8 -o Slovak.nsh Slovak.nsh
iconv -f CP1254 -t UTF-8 -o Turkish.nsh Turkish.nsh
iconv -f CP1252 -t UTF-8 -o Norwegian.nsh Norwegian.nsh
iconv -f CP852 -t UTF-8 -o Czech.nsh Czech.nsh
The installer script nextcloud.nsi in the client-building repo needs the following line (to be added on top):
Unicode true
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-09-16 05:41:27 +00:00
Nextcloud bot
dbe8422c5d
[tx-robot] updated from transifex
2020-09-16 03:27:56 +00:00
Kevin Ottens
9d05bc0a8b
Merge pull request #2424 from nextcloud/enable_ci_for_stable_branches
...
Try to enable the CI on stable branches as well
2020-09-15 15:24:58 +02:00
Kevin Ottens
f3c2632f8c
Try to enable the CI on stable branches as well
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 12:46:36 +00:00
Kevin Ottens
16dda17334
Merge pull request #2423 from nextcloud/disable_bugprone_forward_declaration_namespace_clang_tidy_check
...
Disable bugprone-forward-declaration-namespace check
2020-09-15 14:45:29 +02:00
Kevin Ottens
63c3580755
Disable bugprone-forward-declaration-namespace check
...
Turns out this clang-tidy check can give false positives coming from
headers outside the project while it shouldn't.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 12:04:32 +00:00
Kevin Ottens
8aaa533a3e
Merge pull request #2412 from jplsek/tooltip-update
...
Include list info in tooltip
2020-09-15 13:50:39 +02:00
Jeremy Plsek
797df2b5d5
Include list info in tooltip
...
Also extend the tooltip timeout
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com >
2020-09-15 10:04:06 +00:00
Kevin Ottens
14993d4de6
Merge pull request #2417 from nextcloud/fix_menu_popup_in_main_dialog
...
Fix menu popup in main dialog
2020-09-15 11:03:07 +02:00
Kevin Ottens
6ee37b5975
Make sure menu are closed when button is clicked again
...
This way we also made sure all the Menu are currently on the same close
policy.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 08:46:10 +00:00
Kevin Ottens
f7efe6a902
Delay binding on the menu width
...
Indee the MenuItem might not be linked to its Menu at creation time
which will make the binding fail and give a warning. Delay for the menu
availability.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 08:46:10 +00:00
Kevin Ottens
eb0cedebfa
Remove pre-QQC2.3 workaround
...
Now that we depend on Qt 5.12 anyway, the count property is available
just fine on the Menu item.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 08:46:09 +00:00
Kevin Ottens
4f5d707e44
Merge pull request #2418 from nextcloud/use_primary_screen_as_fallback_when_qcursor_pos_search_failed
...
Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
2020-09-15 10:44:54 +02:00
Kevin Ottens
7ccb016397
Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
...
Under Wayland QCursor::pos() is unlikely to give us anything meaningful,
so fallback to the primary screen information.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-15 07:17:03 +00:00
Nextcloud bot
54b09a1fbb
[tx-robot] updated from transifex
2020-09-15 03:22:14 +00:00
Nextcloud bot
9d3a905cc5
[tx-robot] updated from transifex
2020-09-12 03:19:44 +00:00
Nextcloud bot
88a573a643
[tx-robot] updated from transifex
2020-09-11 03:20:37 +00:00
Kevin Ottens
01986df8ca
Don't use a confusing "royal you" in the sync messages
...
Users get rightfully confused with the "You changed ..." messages in the
activity list for syncs. Indeed, some of those changes might be coming
from the server in which case we don't really know who did the change.
So now we use the old "Synced ..." messages for changes pulled from the
server and we have a more precise "You changed ..." (renamed, deleted,
created) when the changes were initiated locally (since there we know
the user reading the message did it).
Also changed how the messages are constructed so that they can be
properly translated.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-10 15:40:05 +02:00
Nextcloud bot
9ab256b4b4
[tx-robot] updated from transifex
2020-09-10 03:25:52 +00:00
Camila
95f634ce28
Click on activity list in systray open file in the file manager.
...
Clean up code, add more const and auto.
Signed-off-by: Camila <hello@camila.codes >
2020-09-09 20:06:46 +02:00
Camila
c1086c9886
Fix tooltip for activity info.
...
Also improves readability of the items in the list.
Signed-off-by: Camila <hello@camila.codes >
2020-09-09 20:06:46 +02:00
Valdnet
a432501d80
l10n: Add a period
2020-09-09 10:07:10 +02:00
Nextcloud bot
301a926f4d
[tx-robot] updated from transifex
2020-09-09 03:19:56 +00:00
Valdnet
9822079cae
l10n: Extract the button name
2020-09-08 16:44:51 +02:00
Valdnet
528fa92e86
l10n: Delete unnecessary sentence
2020-09-08 16:44:51 +02:00
Valdnet
1444500f77
l10n: A few more fixes
2020-09-08 16:44:51 +02:00
Valdnet
e2737b5067
l10n: Word correction
2020-09-08 16:44:51 +02:00
Valdnet
f931bc832c
l10n: Corrected translation
2020-09-08 16:44:51 +02:00
Kevin Ottens
fdb35e5f9f
Leave the implicit uint to int cast
...
I wrongly (and stupidly) assumed the int in QBitArray was treated as a
hash as well but it is an index so it must be positive. Also to make
things even worse I misread on which expression clang-tidy was
complaining regarding the implementation specific narrowing
conversion... This is happening after the modulo operator and not
before. We're in a safe range of values at that point, so it's fine to
let the narrowing happen.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-08 16:44:31 +02:00
Kevin Ottens
de3ba2721b
Merge pull request #2387 from nextcloud/update-troubleshooting
...
Update troubleshooting
2020-09-08 15:46:55 +02:00
Camila
0f03e3091d
Add README with instructions on how to build the documentation.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-08 13:44:26 +00:00
Camila
fecc62b7e1
Update troubleshooting instructions with the newly added config file options.
...
Signed-off-by: Camila <hello@camila.codes >
2020-09-08 13:44:26 +00:00
Nextcloud bot
5adb720630
[tx-robot] updated from transifex
2020-09-08 03:19:49 +00:00
Nextcloud bot
a61dd7cf46
[tx-robot] updated from transifex
2020-09-06 03:28:59 +00:00
Nextcloud bot
2db125dca0
[tx-robot] updated from transifex
2020-09-05 03:29:13 +00:00
Nextcloud bot
6c69ac6602
[tx-robot] updated from transifex
2020-09-04 03:29:47 +00:00
Kevin Ottens
a4cb7e3040
Merge pull request #2357 from thaytan/metadata-index-e2eMangledName
...
syncjournaldb: index e2eMangledName column in metadata
2020-09-03 16:20:48 +02:00
Jan Schmidt
3077a1378b
syncjournaldb: index e2eMangledName column in metadata
...
Add an index on the e2eMangledName column in the metadata table
to speed up file sync by orders of magnitude on directories with
a large number of files.
Signed-off-by: Jan Schmidt <jan@centricular.com >
2020-09-03 22:56:14 +10:00
Nextcloud bot
fd29a0ae57
[tx-robot] updated from transifex
2020-09-03 03:29:13 +00:00
Kevin Ottens
18b16a3ede
Merge pull request #2351 from nextcloud/fix_clang_tidy_errors_in_csync_tests
...
Fix clang tidy errors in csync tests
2020-09-02 08:25:24 +02:00
Kevin Ottens
ee92e5af9a
Switch to newer CI image to build csync tests
...
This new image brings the cmocka dependency and thus will make the CI
build the csync tests which depend on it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
2916144fe3
Fix bugprone-narrowing-conversion errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
c7c37f9bef
Fix modernize-use-nullptr errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
9a0713fab7
Fix modernize-use-auto errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:46 +00:00
Kevin Ottens
f323f8b4bc
Fix modernize-deprecated-headers errors in csync tests
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-02 06:12:45 +00:00
Nextcloud bot
9ec4e772eb
[tx-robot] updated from transifex
2020-09-02 03:31:47 +00:00
Kevin Ottens
b6591be973
Merge pull request #2283 from nextcloud/enable_bugprone_clang_tidy_checks
...
Enable bugprone clang tidy checks
2020-09-01 08:47:41 +02:00
Kevin Ottens
310693be2c
Enable all the other bugprone clang-tidy checks
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
aa63889e5b
Enable bugprone-terminating-continue clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
0909f00a8b
Enable bugprone-too-small-loop-variable clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
80cc196f6f
Enable bugprone-narrowing-conversions clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
5cec1373ad
Enable bugprone-macro-parentheses clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
608bf025e6
Enable bugprone-forward-declaration-namespace clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
c8ea848596
Enable the bugprone-branch-clone clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Kevin Ottens
4cb9bec23a
Enable the bugprone-argument-comment clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-09-01 06:37:03 +00:00
Nextcloud bot
4e61181b45
[tx-robot] updated from transifex
2020-09-01 03:26:29 +00:00
Kevin Ottens
4ee80bfe2e
Merge pull request #2345 from nextcloud/use_httpd_unix-directory_mimetype_for_e2ee_folders
...
Use httpd/unix-directory mimetype for E2EE folders
2020-08-31 13:11:51 +02:00
Kevin Ottens
eb76682b1e
Use httpd/unix-directory mimetype for E2EE folders
...
We don't do much with that mimetype on our end, but other clients
somehow don't expect inode/directory to let's lie. ;-)
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-31 10:08:48 +00:00
Kevin Ottens
1a0945a973
Enable all the misc clang-tidy check except one
...
This flagged mostly unused parameters. Didn't enable the
misc-non-private-member-variables-in-classes check as we got a lot of
those. Hopefully we'll get to fix them at some point but that feels too
early and too much work for now.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-31 09:14:09 +02:00
Nextcloud bot
7236af78af
[tx-robot] updated from transifex
2020-08-31 03:25:49 +00:00
Nextcloud bot
b01299349b
[tx-robot] updated from transifex
2020-08-30 03:24:23 +00:00
Nextcloud bot
78fa448c7e
[tx-robot] updated from transifex
2020-08-29 03:26:40 +00:00
Michael Schuster
75aa94be79
Merge pull request #2336 from nextcloud/jospoortvliet-patch-1
...
Some changes to the template...
2020-08-29 00:14:16 +02:00
Jos Poortvliet
01a722821a
Some changes to the template...
2020-08-28 21:54:10 +02:00
Nextcloud bot
e45be65996
[tx-robot] updated from transifex
2020-08-28 03:26:44 +00:00
Nextcloud bot
1f536a7e1b
[tx-robot] updated from transifex
2020-08-27 03:29:43 +00:00
Michael Schuster
5945f18d5a
Remove remaining QLinkedList includes in addition to #2300
...
Now the only remaining reference is in:
src/3rdparty/libcrashreporter-qt/3rdparty/drkonqi-parser/backtraceparser.cpp:269: || line.functionName().startsWith(QLatin1String("QLinkedList")
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-27 03:12:09 +02:00
Michael Schuster
bd519ffe7a
Adapt code style in addition to #2300
...
- Use "!empty()" instead of "size() > 0" in std::list
- Add comments for namespace brackets
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-27 01:31:06 +02:00
Michael Schuster
e973c43a7a
Merge pull request #2300 from chenecharry/master
...
Support client builds on VS2019 (QLinkedList is deprecated)
2020-08-27 01:27:09 +02:00
Michael Schuster
24a2b21c2c
Merge branch 'master' into master
2020-08-27 01:12:30 +02:00
Nextcloud bot
07bde18c3a
[tx-robot] updated from transifex
2020-08-26 03:29:53 +00:00
V.C
b20ea25201
Code review changes implemented
...
Code review changes implemented for bandwidthmanager.cpp
1. Use auto instead of size_t
2. Check for empty instead of size comparisions
Signed-off-by: V.C <c******@rediffmail.com >
2020-08-26 02:45:20 +00:00
V.C
af1bb7e98c
Support client builds on VS2019
...
Scenario: Build fails on Qt 5.15.0 + VS2019 16.7.2
Root cause: QLinkedList seems to be depreciated. Advise to use std::list instead.
Fix: Used std::list insead of QLinkedList.
Signed-off-by: V.C <c******@rediffmail.com >
2020-08-26 02:45:20 +00:00
Michael Schuster
c1cb3e6c49
Merge pull request #2309 from nextcloud/update-docs-page-title
...
Update copyright date and version displayed in the page title.
2020-08-25 21:07:18 +02:00
Camila
cbea02390e
Update copyright date and version displayed in the page title.
...
- This is the title displayed at https://docs.nextcloud.com/desktop/x.y
Signed-off-by: Camila <hello@camila.codes >
2020-08-25 18:50:14 +00:00
Michael Schuster
c4b87cd465
Merge pull request #2313 from nextcloud/update-issue-template
...
Add --logdebug parameter to instructions in issue_template for Github.
2020-08-25 20:48:59 +02:00
Camila
c746e65a8e
Update issue_template with information about logs, e2ee versions and code of conduct.
...
Signed-off-by: Camila <hello@camila.codes >
2020-08-25 15:11:34 +00:00
Camila
6c36041829
Add --logdebug parameter to instructions in issue_template for Github.
...
Signed-off-by: Camila <hello@camila.codes >
2020-08-25 15:11:34 +00:00
Nextcloud bot
c687fb0291
[tx-robot] updated from transifex
2020-08-25 03:32:20 +00:00
Nextcloud bot
d4183aebb3
[tx-robot] updated from transifex
2020-08-24 03:31:03 +00:00
Nextcloud bot
7af6e18491
[tx-robot] updated from transifex
2020-08-22 03:28:48 +00:00
Michael Schuster
5b8ec5cede
Merge pull request #2302 from ivaradi/no-eoan
...
Do not build for Eoan
2020-08-22 00:55:31 +02:00
István Váradi
cd303e313d
Do not build for Eoan
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-08-21 18:54:56 +02:00
Nextcloud bot
32880507b2
[tx-robot] updated from transifex
2020-08-21 03:30:20 +00:00
Michael Schuster
b60239c29e
Merge pull request #2288 from nextcloud/enh/windows-shellext
...
Windows shell extensions: Use custom GUIDs and prepare for MSI
2020-08-20 21:11:34 +02:00
Michael Schuster
4df8db4ff6
Fix spacing
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
db05f65e0d
Windows shell extensions: Add WiX (MSI) fragment
...
Use CMake to generate a WXI fragment to handle the DLL registration and file deployment for the shellext components.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
11632da7ea
Windows shell extensions: Change NCUtil Pipe name from ownCloud to APPLICATION_EXECUTABLE
...
Avoid interference with foreign pipes as this is always a bad idea ;p
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
0ba5df597f
Windows shell extensions: Rename all files and classes from OC* to NC*, update version info
...
This also ensures a clear separation in the system registry.
SelfReg is not recommended by Microsoft and will be handled by the MSI package to allow proper Repair and Uninstall.
However, we keep it for backward compatibility with the NSIS installer.
For details see:
https://stackoverflow.com/questions/364187/how-do-you-register-a-win32-com-dll-file-in-wix-3#364210
https://docs.microsoft.com/en-us/windows/win32/msi/selfreg-table#remarks
Another fix by this commit:
The "Version" registry value in the NCOverlays self reg should be a key and not a value.
Details: https://wixtoolset.org/documentation/manual/v3/xsd/wix/class.html
Example:
[HKCR\CLSID\{01234567-89AB-CDEF-0123-456789ABCDEF}\Version]
@="1.0.0.0"
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Michael Schuster
8ce13b7bdb
Windows shell extensions: Use custom GUIDs via CMake and prepare MSI reg
...
Previously side by side installation with ownCloud or other NC custom builds would break the shell integration because the same GUIDs and registry keys were used.
Now we specify our custom GUIDs in NEXTCLOUD.cmake and use CMake to generate a header file and WiX (MSI) include file with these constants.
Note: Using generators like "guidgen" or "uuidgen" ensures that GUIDs are unique, as manual changes are not guaranteed to be.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
4675869fb3
Remove dead code
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
bfd7707ff4
2.7 has less automatic includes on Windows
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
34e9e2f288
Cleanup Windows shell extensions
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Hannah von Reth
6c9a31f6ee
Remove outdated visual studio projects, we now use cmake
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Dominik Schmidt
13d4b91935
Avoid warning because /MT overrides /MD flag
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Dominik Schmidt
e4b53b12e1
Make OCUtil helper lib static and link it statically against crt
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Olivier Goffart
906556640d
Windows Shell Integration: Don't limit the size of the buffer
...
Otherwise we can't have operation that has many many filename
As reported in #6780
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Christian Kamm
77cc262337
Windows shellext: Update copyrights and company name
...
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Olivier Goffart
6274462036
windows shell extension: add OCUtil/resource.h
...
It's a copy from OCContextMenu/resources.h
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Christian Kamm
c6fc46aa09
Windows shellext: Add rc for OCUtil #6554
...
To set the dll's metadata.
Signed-off-by: Michael Schuster <michael@schuster.ms >
2020-08-20 18:50:05 +02:00
Kevin Ottens
d446431804
Merge pull request #2292 from nextcloud/prevent_sharing_for_e2ee_folders
...
Disable context menu actions for E2EE files and folders
2020-08-20 18:36:37 +02:00
Kevin Ottens
ed5e9de9f6
Present sharing of E2EE files from the main dialog too
...
The visibility of the share button for the activity list is tied to the
path role in the ActivityListModel, so make sure we don't return a path
for E2EE files and folders.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-20 14:53:14 +02:00
Kevin Ottens
07388e0f22
Disable context menu actions for E2EE files and folders
...
Those files and folders are not shareable and the "Edit" or "Open in
browser" actions will lead to showing an error in the web GUI. No need
to lead users there so just disable them.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-20 14:13:56 +02:00
Nextcloud bot
b67c61bf4a
[tx-robot] updated from transifex
2020-08-20 03:32:34 +00:00
Nextcloud bot
d6cc9fe829
[tx-robot] updated from transifex
2020-08-19 03:32:55 +00:00
Kevin Ottens
3540f1e460
Show the "Display mnemonic" button only when we know e2e is supported
...
Turns out that showing the button straight from the page ctor is a bit
too early. At that point the account might not be connected yet and thus
we wouldn't have proper information. Currently we were displaying that
button all the time, now we wait for the account to be connected to
decide to show it or not.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-18 17:41:38 +02:00
Camila
71fbc65eb0
Minor fix in text of warning and debug message.
...
Signed-off-by: Camila <hello@camila.codes >
2020-08-18 14:00:21 +02:00
Kevin Ottens
f6e36523d2
Make sure we don't assert when calling fileStatus
...
It happens that sometimes we leak a directory path ending with a slash,
but that violates fileStatus' precondition so let's catch it early and
skip such path.
Of course the right fix would be a larger swipe in the sync engine and
around it to not use naked strings anymore but rely on the typesystem.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-18 13:52:28 +02:00
Nextcloud bot
2456f943af
[tx-robot] updated from transifex
2020-08-18 03:34:45 +00:00
Nextcloud bot
c8b6bc6029
[tx-robot] updated from transifex
2020-08-17 03:28:12 +00:00
Nextcloud bot
60ce985828
[tx-robot] updated from transifex
2020-08-16 03:28:22 +00:00
István Váradi
770e3e7b85
Merge pull request #2271 from ivaradi/cstdint-fix
...
Include cstdint only when compiling C++ code
2020-08-15 14:35:01 +02:00
István Váradi
387df7ae71
Merge branch 'master' into cstdint-fix
2020-08-15 12:56:13 +02:00
Nextcloud bot
2e69680812
[tx-robot] updated from transifex
2020-08-15 03:29:02 +00:00
István Váradi
89d4b6e12a
Include cstdint only when compiling C++ code
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu >
2020-08-14 06:15:42 +02:00
Nextcloud bot
74c1710ed4
[tx-robot] updated from transifex
2020-08-14 03:44:39 +00:00
Kevin Ottens
4117ac2913
Merge pull request #2268 from nextcloud/cherry_pick_testchunkingng_related_improvements
...
Cherry pick TestChunkingNG related improvements
2020-08-13 17:26:33 +02:00
Kevin Ottens
ef6d2600ca
Size cleanups in TestChunkingNG
...
Some of the comments didn't match the size or were missing. This also
means reducing one of the 150 MB payloads left behind reducing the
execution time by a few more seconds. This is now around 30s execution
time which is more acceptable.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 16:46:14 +02:00
Olivier Goffart
a7847a4e82
Upload: Store the size in the UploadInfo, and compare it when resolving potential conflict
...
This is about the conflicts that happens when the file has been uploaded
correctly to the server, but the etag was not recieved because the connection
was closed before we got the reply.
We used to compare only the mtime when comparing the uploaded file and the
existing file. However, to be perfectly correct, we also should check the
size.
This was found because TestChunkingNG::connectionDroppedBeforeEtagRecieved is
flaky. Example of faillure found in https://drone.owncloud.com/owncloud/client/481/5
while testing PR #6626
(very trimmed log:)
06-29 07:58:02:015 [ info sync.csync.csync ]: ## Starting local discovery ##
06-29 07:58:02:016 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: <-> 1644a8c8750, inode: 1935629 <-> 1935629, size: 301 <-> 300, perms: 0 <-> ff, type: 0 <-> 0, checksum: <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:016 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:972 [ warning sync.networkjob ]: QNetworkReply::NetworkError(OperationCanceledError) "Connection timed out" QVariant(Invalid)
.. next sync...
06-29 07:58:02:980 [ info sync.engine ]: #### Discovery start ####################################################
06-29 07:58:02:981 [ info sync.csync.csync ]: ## Starting local discovery ##
06-29 07:58:02:983 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: <-> 1644a8c8750, inode: 1935629 <-> 1935629, size: 302 <-> 300, perms: 0 <-> ff, type: 0 <-> 0, checksum: <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:983 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:985 [ info sync.csync.csync ]: ## Starting remote discovery ##
06-29 07:58:02:985 [ info sync.networkjob ]: OCC::LsColJob created for "http://localhost/owncloud " + "" "OCC::DiscoverySingleDirectoryJob"
06-29 07:58:02:987 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: 1644a8c8b26 <-> 1644a8c8750, inode: 0 <-> 1935629, size: 301 <-> 300, perms: ff <-> ff, type: 0 <-> 0, checksum: SHA1:5adcdac9608ae0811247f07f4cf1ab0a2ef99154 <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:987 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:989 [ info sync.csync.csync ]: Update detection for remote replica took 0.004 seconds walking 13 files
06-29 07:58:02:990 [ info sync.engine ]: #### Discovery end #################################################### 9 ms
06-29 07:58:02:990 [ info sync.database ]: Updating file record for path: "A/a0" inode: 1935629 modtime: 1530259082 type: 0 etag: "1644a8c8b26" fileId: "16383ea4" remotePerm: "WDNVCKR" fileSize: 301 checksum: "SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1"
06-29 07:58:02:990 [ info sync.csync.reconciler ]: INSTRUCTION_UPDATE_METADATA client file: A/a0
06-29 07:58:02:990 [ info sync.csync.csync ]: Reconciliation for local replica took 0 seconds visiting 13 files.
06-29 07:58:02:990 [ info sync.csync.reconciler ]: INSTRUCTION_UPDATE_METADATA server dir: A
06-29 07:58:02:990 [ info sync.csync.csync ]: Reconciliation for remote replica took 0 seconds visiting 13 files.
06-29 07:58:02:990 [ info sync.engine ]: #### Reconcile end #################################################### 9 ms
06-29 07:58:02:990 [ info sync.database ]: Updating local metadata for: "A/a0" 1530259082 302 1935629
FAIL! : TestChunkingNG::connectionDroppedBeforeEtagRecieved(small file) '!fakeFolder.syncOnce()' returned FALSE. ()
2020-08-13 16:46:08 +02:00
Olivier Goffart
c2324327ef
TestChunkingNG: Make it faster
...
Use smaller files so the test run faster.
Particulary usefull for TestChunkingNG::connectionDroppedBeforeEtagRecieved
Which had become so much slower after 2638332dc6
increased the timeout for bigger files
2020-08-13 16:46:03 +02:00
Christian Kamm
c74c0d8e6e
Upload: Add more chunk resuming unit tests #6405
2020-08-13 16:45:55 +02:00
Kevin Ottens
2684ba149e
Merge pull request #2269 from nextcloud/enable_modernize_loop_convert
...
Enable the modernize-loop-convert check on clang-tidy
2020-08-13 16:37:41 +02:00
Kevin Ottens
866ffc2a6b
Enable the modernize-loop-convert check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 12:55:14 +00:00
Kevin Ottens
a5b4922a0e
Remove unused method
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 12:55:14 +00:00
Kevin Ottens
0e2af4b502
Enable the modernize-deprecated-headers check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 14:53:52 +02:00
Kevin Ottens
2f8c29082a
Enable the modernize-use-equals-default check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-13 14:19:42 +02:00
Nextcloud bot
2d4d66b998
[tx-robot] updated from transifex
2020-08-13 03:30:50 +00:00
Kevin Ottens
cdf6e7d72b
Enable the modernize-user-nullptr check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 19:45:25 +02:00
Kevin Ottens
3ff899cff9
Merge pull request #2264 from nextcloud/enable_modernize_use_using
...
Enable the modernize-use-using check on clang-tidy
2020-08-12 19:29:17 +02:00
Kevin Ottens
6ae1d0ddf6
Get rid of useless using constructs
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 18:18:57 +02:00
Kevin Ottens
97af14a4f0
Make QTokenizer use simpler by having optional second parameter
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 18:18:57 +02:00
Kevin Ottens
d58ec4bf70
Enable the modernize-use-using check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 18:18:57 +02:00
Kevin Ottens
7bb54e34d7
Merge pull request #2262 from nextcloud/enable_trivial_clang_tidy_modernize_checks
...
Enable "trivial" modernize clang-tidy checks
2020-08-12 17:16:38 +02:00
Kevin Ottens
07b7753216
Enable "trivial" modernize clang-tidy checks
...
This is a bunch of modernize checks which we don't hit at all. This is
an easy win and also make sure those old constructs won't creep up
behind our back.
Note that some of them won't trigger until we bump our C++ baseline
standard to C++17. But I'd say that's OK, that'll force our hand to do
those C++17 related cleanups when the time comes.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 13:13:08 +00:00
Kevin Ottens
1767c0295f
Merge pull request #2037 from nextcloud/enable_modernize_raw_string_literal
...
Enable modernize raw string literal
2020-08-12 15:02:55 +02:00
Kevin Ottens
3e79e1861b
We don't really need two \ here
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 09:48:33 +02:00
Kevin Ottens
c50a968a1e
Add more raw string literals missed previously
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 09:48:29 +02:00
Kevin Ottens
ed1c2eaab4
Merge pull request #2247 from nextcloud/improve_drone_config
...
Improve drone config
2020-08-12 09:45:26 +02:00
Kevin Ottens
14bfa5025f
Make sure wget looks for the certificates at the right place
...
Might happen because we got too many copies of OpenSSL around
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
571e15c6eb
Switch to Ninja for the clang build
...
Clang is generally slower to compile than GCC so use a faster Make for
that build variant. This also allows us to verify our CMake files don't
do anything Make specific.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
5116f4d255
Parallelize the clang-tidy runs
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
db5c186202
Split cmake and compile into separate pipeline steps
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:13 +00:00
Kevin Ottens
725f1e742d
Switch to actual commands inside of the steps
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
6da67ef653
Split the CI pipelines into proper steps
...
Will make it easier to navigate the logs
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
65407483e5
Now make sure we're not picking up generated headers
...
This could happen (and started to happen more with clang-tidy 10) that
clang-tidy picked up errors in headers from the build directory. Now
that we moved the build directory out of source, we can simply filter
headers based on the pwd.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
1e8340cd48
Move the build in a volume to be reused between steps
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
9016ffe4b7
Remove unneeded environment variables
...
Those are set by the base CI image anyway, no need to do the work again.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
be6a9dab01
Switch to the newer base CI image
...
We can now spare building QtKeychain over and over shortening a bit the
build. We also update to latest gcc and clang.
Note that I didn't switch the AppImage pipeline to the newer image to
keep the binary compatibility promise required by linuxdeployqt.
Probably would make sense to do a specific image for AppImage with some
other of the cleanups I did there (in particular to avoid building
qtkeychain every time).
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Kevin Ottens
d264f7078b
Parallelize the CI build
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-12 06:45:12 +00:00
Nextcloud bot
c3cd06ddad
[tx-robot] updated from transifex
2020-08-12 03:30:27 +00:00
Kevin Ottens
c5343e10f5
Merge pull request #2258 from nextcloud/have_a_way_to_display_e2ee_mnemonic
...
Keep the E2EE info message around to allow displaying mnemonic
2020-08-11 15:11:40 +02:00
Kevin Ottens
37e20698ca
Keep the E2EE info message around to allow displaying mnemonic
...
We lost the ability to display the E2EE mnemonic during the GUI
redesign and the info message wasn't displayed again on restart. So now
we display it every time, it still can be dismissed and the button text
is different in such a case to make the intent clearer.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-11 14:55:51 +02:00
Nextcloud bot
a1dbfd71cb
[tx-robot] updated from transifex
2020-08-11 03:30:03 +00:00
Kevin Ottens
d08c160b69
Merge pull request #2255 from nextcloud/restore_e2ee_old_key_storage_format_compatibility
...
Restore E2EE old key storage format compatibility
2020-08-10 16:07:06 +02:00
Kevin Ottens
ef3c516598
Add support for BASE64 encoded '|' when decrypting
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
595eb78c8a
Move the private key salt handling in its own function
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
d5339265fb
Ignore the salt part of the key during decryption
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
54a19945fd
Restore the symmetry between *StringSymmetric functions
...
If we receive data without base64 encoding for encryption, it makes
sense to get it without base64 encoding out of decryption.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Kevin Ottens
26b88131cc
Add unit tests for the encryption helpers
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-10 13:13:19 +02:00
Nextcloud bot
aac1f2ae56
[tx-robot] updated from transifex
2020-08-09 03:29:44 +00:00
Nextcloud bot
7e2c3b2516
[tx-robot] updated from transifex
2020-08-08 03:31:51 +00:00
Kevin Ottens
a813602124
Master is now what will become 3.1
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com >
2020-08-07 14:36:44 +02:00
Nextcloud bot
53f346fa9b
[tx-robot] updated from transifex
2020-08-07 03:32:17 +00:00