chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2026-08-15 09:30:05 +02:00
Code Activity
17,214 Commits 4 Branches 173 Tags
v3.4.0-do-not-use
Commit Graph
82 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthieu Gallien 1a9aade28e use the error message sent by the server for bulk upload 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 16:32:08 +01:00
Matthieu Gallien 34c4c28879 allow sending parallel batch of files: curretly disabled 
can allow to send a new batch before the reply to a previous one is
received

due to concerns with the reliability on the server side this is disabled

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 16:32:08 +01:00
Matthieu Gallien a272b34809 really check that this is a valid answer when receiving batch upload 
we could somehow miss that the reply is missing proper fields

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien 05b8d1e40d batch upload: only handle file that are in the reply 
do not handle all files sent but only received ones

should allow to submit more than one request in parallel

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien 18ef471332 let auto tests of batch upload return proper file paths 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien e14502606c make sure we do not start a new batch when the previous one is not sent 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien 59953d857b use a proper constant for the size of batch 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien f56985938d if BulkPropagatorJob abort after an error emit finished signal 
prevent sync engine being stuck because of an error when preparing bulk
upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 12:48:38 +01:00
Matthieu Gallien 426e0af8cd release 3.4.0 RC2 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 17:46:10 +01:00
Matthieu Gallien c194605c35 implement bulk upload 
add PutMultiFileJob to send many files at once

use it in BulkPropagatorJob to implement bulk upload feature

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 16:17:47 +01:00
Matthieu Gallien 112be18635 read capabilities for bulk upload from server 
use it in dedicated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 16:17:47 +01:00
Matthieu Gallien 802c7ac906 make AbstractNetworkJob::errorString virtual: it is already overriden 
in practice AbstractNetworkJob::errorString is already overriden but the
overrided code is probably never called while the intention looked like
the opposite

fix that by making the method virtual in base class

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 16:17:47 +01:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 83a8058b51 improve logging for CfApi 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 072e9d44bd gracefully handle one case of invalid handles 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) a3013de6ea fix OCC::CfApiWrapper::handleForPath when path does not exist 
sometime it can be called with a path that is already deleted

ensure we always go to the correct code path

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 9eed62a854 remove too noisy log print 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien 684d70985e fix button that should be disabled when force VFS 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-22 14:22:59 +01:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 12c6d6e3bd add a network access factory to qml engine 
ensure network access made via qml are using our user agent

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-22 12:21:58 +00:00
Matthieu Gallien f1d834df8e properly query sync journal DB to know when to run fix for VFS 
the new method added to query the db is not working and so the fix for
vfs is executed at each sync run

the new method for bool was not really needed so let's just remove it
(and that will make the usage of SqlQuery be correct

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-19 14:19:04 +01:00
Matthieu Gallien c59f88ca82 avoid adding icon data in a cache we never use 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-16 16:11:44 +01:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 2665c8fc16 we run on Windows 8.1+ 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-15 13:40:51 +00:00
Matthieu Gallien 5ab13b2adc add an option to enforce use of virtual files sync folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-05 16:56:24 +01:00
Matthieu GallienandFelix Weilbach 43ec429fe4 improve logs when place holder info cannot be read 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
Matthieu GallienandFelix Weilbach 9658aea963 on switch to VFS real plugin, convert existing files to placeholders 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) a62905f17a properly extract the file id when querying server 
use the proper local file id to get the e2ee meta data

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-02 08:15:54 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 8226c30d84 by default we produce debug logs because we need them 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-28 13:48:55 +00:00
Matthieu Gallien 87c583dcb6 schedule files upload after all other jobs have been completed 
should allow smarter policy dedicated to optimizing files upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 14:26:28 +02:00
Matthieu Gallien c6344c05be add test to check the order of actions when uploading new files 
should allow to check that uploads are delayed after directories are
created

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 12:45:15 +02:00
Matthieu Gallien 24428d9980 add missing Q_ENUM macro to improve logging 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 12:45:15 +02:00
Matthieu Gallien b0ef5e0635 no oneliner if: a bug waiting to happen 
it is much too easy to get a bug because one could miss the lask of {
and }

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 12:45:15 +02:00
Matthieu Gallien 69d6f4acec our source code files have lower case names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-25 15:38:21 +02:00
Matthieu Gallien b5462e1059 Merge branch 'Thatoo-AutoUpdateAppImage' 2021-10-22 12:42:27 +02:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 7a6bc830dd let sonarcloud takes automated tests into account and report coverage 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-20 08:09:23 +00:00
Matthieu Gallien f8a8e3f2f9 target names are not changed in branded builds only the output filenames 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-15 15:22:29 +02:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 46bc0452c7 provide logs of SSL errors including the certificate chain 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-13 15:20:52 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) d76778e3ee fix macOs build after targets name are not changed by branding 
target names used to be variable depending on branding
now the target names are always constant but generated output file names
are set according to active branding

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-11 07:41:29 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 833237b2e4 use alias target for internal libraries 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) c751fd5672 ensure DLL are generated with branded names 
cmake distinct runtime and library

on unix dynamic shared libraries are library kind of objects
on windows they are runtime kind of objects

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Matthieu Gallien fe344462a3 Merge branch 'Trafo-fix/WindowsPlaceholderShortCutMenu' 2021-09-28 11:21:41 +02:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) ac28cc1cf5 set default format for QSurface to handle NVidia context loss events 
should fix wrong OpenGL rendering after suspend on Linux with NVidia
binary OpenGL driver

close #3759

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-22 08:56:16 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 19b77416da TextInput by default do not allow selecting text by mouse 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-21 08:07:19 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 95e3ecfd3c prevent infinte recursion when closing a websocket in case of SSL errors 
the slots connected to the web socket can be called even during close
and lead to infinite calls to close -> error slot -> close -> ...

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-07 07:09:43 +00:00
Matthieu GallienandFelix Weilbach (Rebase PR Action) d17d831205 switch from Q_DECL_OVERRIDE to plain override 
our requirements guarantee availability of override keyword so we just
use it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:57 +00:00
Matthieu GallienandFelix Weilbach (Rebase PR Action) 25669938fd let clang-tidy add missing override after enabling again the check 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:56 +00:00
Matthieu GallienandFelix Weilbach (Rebase PR Action) 0c3f5cde12 fix name of one clang-tidy check 
allow modernize-use-override to work fine

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:56 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 601c4fb3c0 remove a tr call where translator cannot do anything meaningful 
close #3708

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-26 15:26:54 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 23bd4675fd fix build socket api Mac specific file is now in a subdirectory 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-25 14:02:05 +00:00
Matthieu Gallien ecb13d36f3 support server versions for one year after it is end of life 
according to https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-24 14:51:31 +02:00
Matthieu Gallien 22a5fadc13 remove broken assert that is not needed and break account setup 
it has been also removed from the original branch so no problem removing
it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-23 14:13:58 +02:00
Matthieu Gallien 0456cacd79 fix clang-tidy check for usage of =default 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-23 09:44:34 +02:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 65d22c08b7 put VFS plugins into the correct path 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-17 10:18:25 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 188b06b7bb no longer produce installers that would be stored by appveyor 
appveyor storage is limited and we ran into trouble with that

plan is to directly use github to do that and have links directly in PRs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-10 14:59:51 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) badb5c1fba fix review comment 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-29 08:27:53 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 391935c90f prevent crash in Accont::davPath without credentials 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-29 08:27:53 +00:00
Matthieu Gallien d2133da3ee fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-28 12:27:02 +02:00
Matthieu Gallien c40d276770 remove dead code around overriding dav path in URL 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-28 12:12:17 +02:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 77433f7e1d in wizard always use the correct way to get dav path 
fixes listing being incorrect when using dav endpoint

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-28 09:45:49 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) a8ef8bdcb8 do not block account menu: availability checking can be slow 
ignore availability that can be very slow to check with CfApi virtual
files plugin

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-21 12:58:23 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 2bf757a657 only run the pipeline for master branch and pull requests 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-21 11:33:07 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) bbcfe56cfd execute automated tests but do not fail if there are errors 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-21 11:33:07 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 1fca07546c print the real permissions string instead of its address 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-21 08:25:42 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 064f64f06d fix width of user status message to not overlap other elements 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-16 15:19:20 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 260e1d77f5 clean indentation in UserLine.qml 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-16 15:19:20 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) c2602135ab fix size of the Label with user status 
ensure the label width is not higher than the parent to ensure log
string get elided as expected

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-16 13:04:33 +00:00
Matthieu Gallien 2ee26bbd59 fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-12 14:31:19 +02:00
Matthieu Gallien 7c68408ee1 only compile xattr virtual files backend for linux platform (not unices) 
for a reason a mac os platform specific file is missing and before xattr
plugin was compiled only for linux

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-12 14:10:54 +02:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) d2f2e3305a avoid being stuck trying to create placeholder for existing file 
id sync db think a file is cirtual (empty placeholder) but file system
has a real file (non empty file) once the server has a modified version
we can no longer update it

state of file on disk takes precedence over sync DB to allow recovery

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-09 12:37:47 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 8ad6f89fed bring back dynamic load of VFS plugins 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-08 08:11:17 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) c123edb173 address review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-06 14:16:43 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 4016c2fab0 avoid error when doing hydration when data socket is closed too early 
when data is received, if we close the socket they cannot be read

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-06 14:16:43 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 8f5b88acd5 improve error message in case of trailing space in directory name 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-02 10:50:31 +00:00
Matthieu Gallien 746072e95d fix all usage of _com_error(cfExecuteresult).ErrorMessage() 
_com_error(cfExecuteresult).ErrorMessage() calls should be translated to
QString before use with qDebug and related logging facilities

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-02 11:19:04 +02:00
Matthieu Gallien 2bc72592a0 fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-01 14:40:25 +02:00
Matthieu Gallien 698d5f19ba download server public key and check user certificate against it 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-01 14:07:27 +02:00
Matthieu GallienandCamila (Rebase PR Action) c27fc1be4a use fallback icons for activities without icons 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-06-30 11:28:13 +00:00
Matthieu GallienandCamila (Rebase PR Action) 269d225511 directly send the icon url for activities to teh qml component 
should allow usage of default cache from Image qml standard component

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-06-30 11:28:12 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) c51815f8ad use upper case name for the github token access 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-06-08 08:50:51 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 149b1317e7 really fix the actions to remove needsinfo when someone comment 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-06-08 08:50:51 +00:00
Matthieu Gallien 8b98dfcabb fix needs info label remover action by providing github token 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-06-01 09:35:19 +02:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) dbeba16919 ensure we do not remove needs info label when stale bot comment 
we could have an issue with bug and needs info label

when it is detected as staled by the bot, a comment is added

we should ensure that the automated comment is not taken as answer to
the needs info

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-05-27 08:06:53 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) a9aef22acb remove use of checkout action as per review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-05-27 08:06:53 +00:00
Matthieu GallienandMatthieu Gallien (Rebase PR Action) 92146b0c8d use a specific stale label for needs info handling to solve conflict 
each stale bot needs to have its own stale label such that it does not
remove the label added by the other bot

that can happen due to needs info bot removing stale label on issues
that have both bug and needs info labels

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-05-27 07:46:59 +00:00