chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2026-08-21 07:27:15 +02:00
Code Activity
8,322 Commits 4 Branches 173 Tags
v2.0.0-beta2
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Olivier Goffart 81c19232a5 Account Settings: Remove the ability to select 2015-08-14 12:12:16 +02:00
Olivier Goffart dcfa6b97e3 Account Settings: add more margin on the overall text 
Attempt to fix https://github.com/owncloud/client/issues/3584#issuecomment-131009787
 2015-08-14 12:01:28 +02:00
Olivier Goffart 593016718d Account Settings: Align the progressbar with the icon #3567 2015-08-14 11:52:09 +02:00
Olivier Goffart 2dbe822972 Account Settings: remove the storage use label #3567 2015-08-14 11:52:09 +02:00
Olivier Goffart 5c9b865cec Setup wizard: remove some spacing in the result page #3588 2015-08-13 15:22:43 +02:00
Olivier Goffart 5f832b5b39 Account Settings: Reorder the options in the context menu #3584 2015-08-13 15:07:51 +02:00
Olivier Goffart b75b5a5a0c Account Settings: remove the down arrow in the 'more' button #3584 
It's ugly on mac
 2015-08-13 14:11:13 +02:00
Olivier Goffart f32c8d0570 Account settings: add a button to show the context menu #3584 2015-08-13 12:34:22 +02:00
Olivier Goffart b49e9e8f30 Account Settings: rename and re-order the options in the context menu 2015-08-13 12:32:59 +02:00
Olivier Goffart bf20a0d2f8 Account Settings: remove unused signals 2015-08-13 11:55:51 +02:00
Olivier Goffart 6fcb48a0c7 Account settings: Double click no longer open in the file browser #3585 
Add a separate option in the context menu for it
 2015-08-13 11:53:00 +02:00
Olivier Goffart 5685aa7ff0 Setup Wizard: add more space in the result page: #3588 2015-08-13 11:27:41 +02:00
Olivier Goffart 3238d61ef6 SocketApi: fix small leak (found with valgrind) #3369 2015-08-13 10:42:54 +02:00
Olivier Goffart 299faae830 Fix compiler warning 2015-08-13 10:26:35 +02:00
Olivier Goffart 6b003f96f5 Theme: add a method to hide the 'add account' button #3517 2015-08-13 09:39:44 +02:00
Olivier GoffartandMarkus Goetz 9dcce01e54 csync: ignore files/folder for which stat fails 
instead of pretending it suicceed and not recursing in it.

This fixes a bug in which a folder with a too long name would be properly
created, then removed on the server in the next sync.

(cherry picked from commit 4bbf7669091cde7ec726b1708d8c54427b68f016)

Conflicts:
	csync/src/csync.h
	csync/src/csync_exclude.h
	csync/src/csync_update.c
 2015-08-11 11:17:20 +02:00
Olivier Goffart b967359a74 Account setting: properly disable the 'add account' button #3571 
When upgrading from 1.8 and syncing the whole account, then the
remote folder is empty
 2015-08-07 14:32:51 +02:00
Olivier Goffart ae7b2509a5 Selective sync: When applying selective sync, put new folder that were just checked in the white list 
Issue #3560

Otherwise the just checked folder will be chacked again for their size.
We do not want that.
 2015-08-07 13:37:52 +02:00
Olivier Goffart 8b52a121bb AccountSettings: Show the wizard to add an account when the last account was deleted #3564 2015-08-07 13:15:02 +02:00
Olivier Goffart 2a4396fbdb Fixup ce5be89a18 2015-08-07 11:05:04 +02:00
Olivier GoffartandMarkus Goetz 29d7903c22 Propagator: do not use parallelism when we have bandwidth limit 
When user wants to limit the bandwidth, he does not care about speed
anymore. And parallelism on slow network might cause problems.

For issue #3382
Will also help for #3095

(cherry picked from commit b20f29f22797367c7aa92bd74389c99b10c852a4)
 2015-08-06 15:27:18 +02:00
Olivier Goffart 2cf29352b8 SyncJournalDB: clear all the prepared query when closing the database 
Not closing it may keep the file open (issue #3421)
 2015-08-06 14:28:02 +02:00
Olivier Goffart ce5be89a18 Fix warning 
csync_vio_local_unix.c:109:7: warning: ignoring return value of function declared with
      warn_unused_result attribute [-Wunused-result]
      asprintf(&file_stat->original_name, "%s/%s", handle->path, dirent->d_name);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2015-08-06 13:58:04 +02:00
Olivier Goffart 7202bbcf5d Fix Qt4 build 2015-08-06 13:58:03 +02:00
Olivier Goffart 499e13377d check_vio_ext.c: assert_string_equal is a macro and we cannot have #ifdef in it 2015-08-06 10:02:12 +02:00
Olivier Goffart 8ec4d0f19b Utility: use SI units for the sizes in bytes 2015-08-05 16:22:09 +02:00
Olivier Goffart dc299b0bf9 Account settings: Fix a label 
The feature is for all folder, not only shared folder
 2015-08-05 16:12:58 +02:00
Olivier Goffart 952c249039 Selective sync: on the first sync, do not ask confirmation for every folders 
Since we already confirmed a previous selective sync dialog
 2015-08-05 16:11:59 +02:00
Olivier Goffart 0e3262b181 Theme: add a settings for configuring the default of newBigFolderSizeLimit 2015-08-05 15:33:51 +02:00
Olivier Goffart ba896eabfb FolderStatusModel: do not expand the unconfimred folder themselfs 2015-08-05 15:33:51 +02:00
Olivier Goffart 646890abb3 SettingsDialog: use the same short display name on Win/Linux than on Mac 
Issue #3516
 2015-08-05 15:33:51 +02:00
Olivier Goffart 38da1b7de1 AccountSettings: automatically refresh and expands the undecided folders #3541 2015-08-05 12:51:49 +02:00
Olivier Goffart 157f59d44a Csync tests: fix on linux 
Linux do not iconv to decode filenames
 2015-08-05 11:09:27 +02:00
Olivier Goffart b470d0f7b8 Folderman: make the backup number starts with 2: #3512 2015-08-05 10:46:33 +02:00
Olivier Goffart 795922e2a0 Fix compilation with old GCC 
that does not understand nullptr

Note that we can't just replace nullptr by 0 in createIndex otherwise
it would be ambiguious.
So leave it commented to show that your intention is to create it with
a null pointer  (which is the default because of the default parameter)
 2015-07-30 10:44:07 +02:00
Olivier Goffart 3b261bc612 Wizard: Make the name of the backup folder more user friendly 
Issue #3512
 2015-07-29 12:23:33 +02:00
Olivier Goffart 07ddf18b3b Account Capabilities: style fixup 
- Remove the copy constructor. The default constructor is fine. Having
   a user defined copy constructor inhibit the move constructor.
 - Pass QVariantMap arguments via const references
 - Do not return a pointer to Capabilities from the account. It is a
   value type and should not be used by pointer.
 2015-07-29 12:07:57 +02:00
Olivier Goffart d9c52f6316 owncloudcmd: fix --httpproxy 
It was only used for csync, but not for QNAM

Issue #3465
 2015-07-28 13:33:58 +02:00
Olivier Goffart ec86d1a151 Wizards: allow adding a folder in a non-existing directory and create that folder 
The owncloud wizard already created the directory, but the recent addition
of FolderMan::checkPathValidityForNewFolder stopped allowing unexisting directories.

So change FolderMan::checkPathValidityForNewFolder to allow non existing directory
and whange the FolderWizard to create the directory if it does not exist.

Issue #3492
 2015-07-28 12:14:52 +02:00
Olivier Goffart 22013eb528 ConfigFile: remove some unused functions 2015-07-28 12:05:34 +02:00
Olivier Goffart 4016e0863f Fix warning 2015-07-28 11:20:22 +02:00
Olivier Goffart 28ab3666d3 Tests: Some tests need QtWidgets 2015-07-27 11:04:49 +02:00
Olivier Goffart ff6c11f126 Confirm feature: tray noticiation message when a new folder need to be confirmed 
Issue #3148
 2015-07-27 10:33:05 +02:00
Olivier Goffart 45b598cacb Confirm feature: default to 500MB 
Issue #3148
 2015-07-27 10:04:53 +02:00
Olivier Goffart 0ccaae9a22 Confirm feature: Confirm for any folder, not only shared ones 
issue #3148
 2015-07-27 09:54:20 +02:00
Olivier Goffart a9dfcdd463 FolderDefinition: fix uninitialized variable 2015-07-19 11:33:17 +02:00
Olivier Goffart 944564258c Fix the Utility Test 
1 should be printed as "1" and not as "1.00"
 2015-07-17 10:27:03 +02:00
Olivier Goffart 0a6aa88d72 Merge remote-tracking branch 'origin/hidden_file_handling' 2015-07-17 09:32:29 +02:00
Olivier Goffart b59fc39d13 Fix warnings about unused parametters 2015-07-16 18:15:07 +02:00
Olivier Goffart bdf5029d47 HTTP cred: properly forget the password when signing out #3462 
QNAM do not sign out by itself, it keeps the password in cache.

Qt5 has a function to clear the cache. On Qt4 we reset the QNAM
 2015-07-16 17:00:14 +02:00
Olivier Goffart 92dc3047d0 Qt4 SelectiveSyncDialog: Give a better size to the column by default 
Issue #3239
The feature to dynamically resize the column only came with Qt5,
But give a better default size of the name column so we can read the
contents.
 2015-07-14 15:18:55 +02:00
Olivier Goffart 371fc0ffa2 Qt4 test build: QTemporaryDir only exist since Qt5 
Disable that test for older versions of Qt
 2015-07-14 15:06:42 +02:00
Olivier Goffart cdb88d621c Qt4 build: Qt::ItemNeverHasChildren was added in Qt 5.1 2015-07-14 15:01:33 +02:00
Olivier Goffart b485e8f97f AccountSettings: disable the add folder button when syncing the entire owncloud #3438 2015-07-14 11:03:25 +02:00
Olivier Goffart ab23368764 FolderStatusModel: init all private members 2015-07-14 10:15:19 +02:00
Olivier Goffart 6030b4416d Account Settings: hide the [add folder] button when syncing the entire owncloud #3438 2015-07-13 16:29:01 +02:00
Olivier Goffart aabad22cef Wizard: show an error if the folder already exists 
Issue #3444
 2015-07-13 15:37:01 +02:00
Olivier Goffart 247771fbba Wizard: remove the configExists state 
The wizard is now only used to create new account, not update existing ones
 2015-07-13 15:21:18 +02:00
Olivier Goffart e5568b5d13 Wizard: remove the check for mutliple folders 
It does not make sens now that we have multi account
 2015-07-13 14:52:24 +02:00
Olivier Goffart 4dbe0693df FolderMan::checkPathValidityForNewFolder 
factorize the function to check the validity of a new folder out of
the folder wizard to the FolderMan.

There is even a test for it now.

That way we can also use it in the normal wizard
 2015-07-13 14:35:19 +02:00
Olivier Goffart 45180a024d Rename should_update_etag to should_update_metadata 
This should avoid some confusion
 2015-07-09 15:05:37 +02:00
Olivier Goffart 992d375e90 owncloudGui: Do not reset folders when login in or out. 
This made no sens. Folders are setup when the account is setup.

Also this had the bad side effect to shut the sync engine too early,
leaving the SyncEngine::_syncRunning to true, and leading to ASSERT later

Issue #3427
 2015-07-09 13:25:27 +02:00
Olivier Goffart 644486871b owncloudGui: Fix crash when sign in 
The sign in action from within that menu might change the account state
and call setupContextMenu. We must not delete the menu from there

Issue #3427
 2015-07-09 12:17:27 +02:00
Olivier Goffart 08fcf650eb Fix Qt4 build 2015-07-08 19:48:57 +02:00
Olivier Goffart 68668e25bd FolderStatusModel: uses int64 for the sizes to prevent overflow 
Issue #3420

(The change in Utility just make sure never to use the scientific notation,
even if it should never happen)
 2015-07-08 14:52:58 +02:00
Olivier Goffart e2cb6e8086 Utility: remove useless QList 
Not used anymore
 2015-07-08 11:16:32 +02:00
Olivier Goffart d1bfc7a636 Settings: fix broken signal/slot connection: 
No such slot OCC::GeneralSettings::slotForceRemoteDiscoveryOnFolders()
      (sender name:   'OCC__IgnoreListEditor')
      (receiver name: 'OCC__GeneralSettings')

The slot was in another settings page (because the button 'edit ignored files'
was moved.

Move the actual code to IgnoreListEditor where it logically belong.
Add a comment on the why this code is there.
 2015-07-07 20:46:39 +02:00
Olivier Goffart 41111541c5 Confirm feature: Add an option for it 2015-07-07 16:28:48 +02:00
Olivier Goffart f87d0139e1 AccountState: fix Sing-in of a connected account 
Issue #3413

There was two problem:
 - First, when singing in we were setting an account that was connected
   to disconnected  (AccountState::State)
 - Second, while getting the result from the ConnectionValidator, we would
   not set the state to connected if the previous call to ConnectionValidator
   was ConnectionValidator::Connected, regardless of the old state of the account
 2015-07-07 14:44:16 +02:00
Olivier Goffart ceddbe248e FolderStatusDelegate: style the Add Folder button 2015-07-06 16:04:06 +02:00
Olivier Goffart ef1f2d2b79 FolderStatusDelegate: Fix identation and remove empty functions 2015-07-06 14:44:53 +02:00
Olivier Goffart 9c9ff886c9 Fix qt4 build 
Qt5 automatically declares many types as QMetaType.
Qt4 needs them manually declared
 2015-07-06 11:04:17 +02:00
Olivier Goffart 76903fb55a Settings: Aling the non-accounts button on the right 2015-07-03 11:04:03 +02:00
Olivier Goffart 0b8163fae1 Folder: the limit for the confirm featur is 100MB, not 100kB 2015-07-03 10:42:20 +02:00
Olivier Goffart 2db7ab5c46 Do not use std::unique_ptr 
The class is not existing on all platform we support
(namely macos 10.7)
 2015-07-02 12:55:54 +02:00
Olivier Goffart 575ca50aac csync: Do not ignore hard links anymore 
There is no reason to ignore them. Downloading a file that is hardlinked
will break the link.

Will solve syncing NTFS directories #3241
 2015-07-01 13:05:08 +02:00
Olivier Goffart 4a541a9ab4 Merge remote-tracking branch 'origin/maser' 2015-06-30 13:52:38 +02:00
Olivier Goffart ec5894ef7a Fix Qt4 build 2015-06-30 11:29:59 +02:00
Olivier Goffart ec3fc50e0e FolderMan: store folders in a QMap instead of a QHash so they are kept in order 
Issue #1529
 2015-06-29 15:49:47 +02:00
Olivier Goffart 7a324ff25b Utility: improve the function to conver a duration to string 
- Make it translatable
 - Make use of the %n so that it supports plurals (but this will only
   take effect if we have an english translation)
 - Only put two units.  eg:  "5 years 7 months" instead of
   "5 years 7 months 12 days 34 minutes 23 seconds"
   Even when it is "2 hours 23 minutes" the amount of second does not
   matter, especially since the estimation is likely to be boggus anyway

Issues #2672 and #3097
 2015-06-29 14:59:28 +02:00
Olivier Goffart 23ccaa2821 QuotaInfo: add a comment about long running job 
To document the change made two commits ago
 2015-06-29 10:57:32 +02:00
Olivier Goffart 51c10de672 QuotaInfo: make sure that we always check the quota every 30 seconds 2015-06-26 18:04:27 +02:00
Olivier Goffart 84fdc8c6c0 Merge remote-tracking branch 'origin/1.8' 2015-06-26 17:54:35 +02:00
Olivier Goffart 516509b4ed csync_statedb: fix leak 
Spotted by coverity (CID 98061)
 2015-06-26 17:01:43 +02:00
Olivier Goffart 236951d9b3 QuotaInfo: allow only one job at the same time 2015-06-26 16:58:34 +02:00
Olivier Goffart e7d7646151 QuotaInfo: only request the quota when the UI is visible 2015-06-26 15:43:19 +02:00
Olivier Goffart 7757886ebc SystemTray menu: remove the quota information 
It makes no sens anymore with multi account and users will see it
from the dialog anyway.
 2015-06-26 13:32:02 +02:00
Olivier Goffart 61a1a0bb2d PropfindJob: fix a debug output message 
Prpfind job can be used for more than getting the quota
 2015-06-26 13:32:02 +02:00
Olivier Goffart 7332afa171 Fix Qt4 build 
QTRY_VERIFY was private API in Qt4
 2015-06-25 14:39:48 +02:00
Olivier Goffart db87d2a18e QuotaJob: remove and use a PropfindJob instead 
This remove code duplication because the QuotaJob was just a duplication
of the propfind jobs with the properties hardcoded.
 2015-06-25 14:39:48 +02:00
Olivier Goffart d7555cc14e Test for transchecksumvalidator: Do not use arbitrary waiting time 
Just stop the loop when we have the result.

This will hopefully fix the jenkins build
 2015-06-25 12:45:09 +02:00
Olivier Goffart 29fecb029e Merge remote-tracking branch 'origin/1.8' 
Conflicts:
	VERSION.cmake
        src/gui/accountsettings.cpp
	src/gui/accountsettings.h
 2015-06-25 12:30:52 +02:00
Olivier Goffart 494f08de8c Theme: add a non-inline destructor 
That way we do not need to include QIcon in theme.h
So the header can be included (indirrectly) from cmd.cpp
which is not compiled with the QtGui include paths
 2015-06-24 10:14:55 +02:00
Olivier Goffart c56cb2235c Missing EXPORT macro 2015-06-23 00:53:32 +02:00
Olivier Goffart bb85db6cc5 Fix windows build 2015-06-18 10:24:40 +02:00
Olivier Goffart dd5ddf2166 AbstractNetworkJob: move to its own file 2015-06-17 17:29:11 +02:00
Olivier Goffart c11358219a FolderStatusModel: fix a coverity warning 2015-06-17 12:46:49 +02:00
Olivier Goffart d902a37dfd Fix Qt4 compilation 
This header is not included in Qt4's QAbstractItemModel header
 2015-06-16 12:14:04 +02:00
Olivier Goffart 0cfc518c33 Fix coverity build which does not support nsdmi 2015-06-16 09:30:29 +02:00
Olivier Goffart f8cbed34c2 Should fix coverity build 
Issue #3346
 2015-06-15 17:59:08 +02:00