chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2026-08-20 05:07:57 +02:00
Code Activity
5,303 Commits 4 Branches 173 Tags
v1.6.0-beta1
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Olivier Goffart 20e850501d Make sure we do not remove files that are replaced by a symlink 
As we ignore symlink, we should not remove on the server the files that
are ignored.

Change tested in t4.pl

Relates to #1299
 2014-04-03 17:47:49 +02:00
Olivier Goffart 462ba7d942 Don't dead lock when all the files are removed 
SyncEngine is on the main thread, no need of the legacy BlockingConnection
 2014-04-03 17:47:49 +02:00
Olivier Goffart eaf5681f61 Put the sync log in the actual folder 2014-04-02 16:36:32 +02:00
Olivier Goffart 03ef2aadde Remove undeeded includes 
And don't use 'using namespace' in headers
 2014-04-02 16:23:57 +02:00
Olivier Goffart f09076180d don't add the list of field on the log for every sync 2014-04-02 16:21:07 +02:00
Olivier Goffart d5d3c1a23a Fix compilation with Qt5 
We don't need QtWidgets,  and we don't need Uility::escape
 2014-04-02 16:21:06 +02:00
Olivier Goffart 607e48a68b let configure the default count of the blacklist 2014-04-01 13:54:47 +02:00
Olivier Goffart bfe6a50b19 Fix some error cases in the SyncEngine 
Always cleanup properly when we bail out.

Also fix thread safety of the SyncJournalDB
 2014-04-01 13:41:47 +02:00
Olivier Goffart 3acdfc0004 Make configurable the maximum amount of job in parallel 
Bia the environement variable OWNCLOUD_MAX_PARALLEL
 2014-03-28 11:20:07 +01:00
Olivier Goffart a1fc7f0a25 Make the chunk size configurable via an environement variable 
OWNCLOUD_CHUNK_SIZE
 2014-03-28 11:11:02 +01:00
Olivier Goffart 5bceb6f787 fix test compilation 2014-03-28 11:02:18 +01:00
Olivier Goffart 8de9bec122 Remove progress info from csync 
csync doesn't do no propagation no more
 2014-03-28 10:50:15 +01:00
Olivier Goffart 5204a992b2 Remove HBF stuff from csync_owncloud 
csync doesn't do no propagation no more
 2014-03-28 10:41:48 +01:00
Olivier Goffart 765a18b74a Fix compilation with Qt4 2014-03-28 10:26:42 +01:00
Olivier Goffart 350283fe06 Remove obsolete code that removed the sync journal when the sync directory is deleted 
Since the journal is now in the same directory, we don't need this
security anymore

When the directory is removed, the sync will error out saying that the
journal cannot be loaded or created
 2014-03-28 10:23:09 +01:00
Olivier Goffart 2ba62b79b4 Make the size of the log maximum 1MiB 2014-03-28 10:13:35 +01:00
Olivier Goffart e0b6395d18 Use sane datastructure in Utility::StopWatch 
We don't want to logging to be O(N^2)

Also avoid usage of macro when possible
 2014-03-28 09:50:13 +01:00
Olivier Goffart ba896b0550 Avoid copies of the StopWatch 2014-03-28 09:39:50 +01:00
Olivier Goffart 36a2c861c2 Only build the static library when BUILD_LIBRARIES_ONLY is defined 2014-03-28 09:34:21 +01:00
Olivier Goffart 7f975e0b2f Avoid macro when it can easily be done with a local variable 2014-03-28 09:27:05 +01:00
Olivier Goffart 69fcbd3b0d Fix Qt4 compilation 
And a typo
 2014-03-27 18:19:56 +01:00
Olivier Goffart d6525a979d Do not let user change it's login while using shibbolet 
Fixes #915
 2014-03-27 17:59:50 +01:00
Olivier Goffart 353f21e856 Add a FAQ item for the .eml problem 
Fixes #1403
 2014-03-27 09:55:25 +01:00
Olivier Goffart de2335c1db Show the folders when in the accountsettings in the first start 2014-03-26 19:31:37 +01:00
Olivier Goffart 332c6cf726 Fix invalid signal connection 2014-03-26 19:31:37 +01:00
Olivier Goffart 2ad7b0aae0 Fix crash on first run when no account are configured 2014-03-26 17:42:05 +01:00
Olivier Goffart 588633a0f2 Fix leak: don't leak the settings 2014-03-26 17:42:05 +01:00
Olivier Goffart 38344589c4 Exxtract the exception message from reply to PUT 
Might be usefull to debug Internal Server Error

Fixes #1366
 2014-03-26 12:02:22 +01:00
Olivier Goffart 98d7ff5116 Don't create .ctmp of sync journal 
Fixes #1559
 2014-03-26 10:25:50 +01:00
Olivier Goffart b4f992b944 Merge pull request #1446 from owncloud/remove-tooltip 
remove superfluous tooltip from server address input field
 2014-03-25 20:16:26 +01:00
Olivier Goffart 8e6674e784 Merge branch '1.5' 
Conflicts:
	src/owncloudcmd/owncloudcmd.cpp
 2014-03-21 10:06:45 +01:00
Olivier Goffart 8aace3284f owncloudcmd: Fix an error during update phase would not terminate 
the QApplication::quit()  would be run before the exec() and would
be a noop,   and then exec would just wait forever.
 2014-03-21 10:03:11 +01:00
Olivier Goffart 922e004fc6 Make it an error instead of a crash when dav_connect fails. 
Fixes #1591
 2014-03-21 09:54:26 +01:00
Olivier Goffart bb9d6b34c7 Remove FIXME and TODO 
They are outdated
 2014-03-20 16:42:43 +01:00
Olivier Goffart 07025c7432 Remove a FIXME 
The commit message say that this line should be necessary to show
the information when the setting dialog is open,  but this is working
now via the signals
 2014-03-20 16:42:43 +01:00
Olivier Goffart b65601aaa4 Remove FIXME 
This has been refactored since the comment was added and is no longer a hack
 2014-03-20 16:42:43 +01:00
Olivier Goffart 756e1c4a12 Prefer the use of _isDirectory over item._type == SyncFileItem::Directory 2014-03-20 16:42:42 +01:00
Olivier Goffart c5f8a2555d Rename _dir to _direction 
(to avoid confusion with directory)
 2014-03-20 16:42:42 +01:00
Olivier Goffart a1ab9c84c7 Remove FIXME in syncengine 2014-03-20 16:42:42 +01:00
Olivier Goffart 23f3a6b319 restore the last change menu 
It was not yet implemented after the progress refactoring
 2014-03-20 14:43:10 +01:00
Olivier Goffart ebeb668a62 QNAM jobs: Make sure there is an etag is proper and not changed when one resume 
Those tests are existing on the legacy jobs.

We check there is an etag so we make sure a proxy is not in between.
(We have seen user complaining because their proxy is replacing the
pages with one that says they need to enter their login and password)

Also it is important to check that the etag has not changed if we resume
(this may happen if the file is changed on the server between the update
phase and the propagate phase,  and that we resume this file)
 2014-03-20 13:31:42 +01:00
Olivier Goffart 05d3273591 Detect the error that may happen when downloading a file 2014-03-20 11:35:30 +01:00
Olivier Goffart 6377dca4b0 Add the file and line number of the debug in the debug view 2014-03-17 12:15:45 +01:00
Olivier Goffart f05320c32c Clean the debug a bit 2014-03-17 12:15:16 +01:00
Olivier Goffart b0f8a24c20 CSyncThread was renamed, give proper names in Folder 
take in account that the object live in the same thread
 2014-03-17 11:47:23 +01:00
Olivier Goffart c841b9c0c4 Remove unused libsync_HEADERS 
This was unused and is redudent with owncloudsync_HEADERS
 2014-03-17 11:36:53 +01:00
Olivier Goffart 7b482c0e96 Rename CSyncThread to SyncEngine 
CSyncThread has not been a thread for a long time now
 2014-03-17 11:34:51 +01:00
Olivier Goffart bf5091d862 Merge branch '1.5' 2014-03-17 11:26:28 +01:00
Olivier Goffart 5c45ede4a5 Read the quota as double 
The server is sending floating point number when the amount of storage
is set to a custom number (say 1.2GB)

This should fix #1374
 2014-03-17 10:37:06 +01:00
Olivier Goffart cabcdd890e Only run the CheckQuota job if the account is connected 
We use another job to check the connection.
And this may cause wrong password failure as we are still in the wizzard

Fixes #1567
 2014-03-17 10:35:43 +01:00
Olivier Goffart 0a5e691ba3 Remove debug output that might cause a crash 
The account may not be finilized when this is called while the
wizzard is still running on first connection
 2014-03-17 10:22:14 +01:00
Olivier Goffart ba300c2fc1 Fix memory leak: Don't use raw pointers 2014-03-17 10:04:42 +01:00
Olivier Goffart 62e95e540b Remove Progress::Kind 
It's not really used,  one need to  look at the instruction of the items
being processed to see what happens
 2014-03-14 18:43:23 +01:00
Olivier Goffart d744b5e481 Fix the file count in the progress 
And clear the ignored files between syncs
 2014-03-14 18:29:23 +01:00
Olivier Goffart f9b82d852c Do not destroy the settings dialog when it is hidden. 
That way the protocol widget stay filled.
And the state is kept
 2014-03-14 17:39:20 +01:00
Olivier Goffart 33289bde29 Merge remote-tracking branch 'origin/1.5' 
Conflicts:
	CMakeLists.txt
	VERSION.cmake
	src/CMakeLists.txt
 2014-03-14 17:27:50 +01:00
Olivier Goffart 9053662fe8 remove Progress::SyncProblem and the problem slots 
They are merged into normal progress
 2014-03-14 17:18:26 +01:00
Olivier Goffart aacc278583 Refactor the progress 
Consider that there might be several files processed at the same time
 2014-03-14 13:32:32 +01:00
Olivier Goffart 7cab77e879 Call the start method assyncroniously 
That was my intention, which is why i did not do a direct call to start.

This should fix issue #1536
 2014-03-06 21:01:08 +01:00
Olivier Goffart feb49b2768 Saner defaults 2014-03-06 20:34:11 +01:00
Olivier Goffart 4e25595520 Better error classification 2014-03-06 20:33:17 +01:00
Olivier Goffart 4aaa256b11 Do not beleive that the credidential are wrong when the job is cancelled 
Otherwise, aborting the sync will make the client beleive the credidentials
are wrong.
 2014-03-06 20:31:48 +01:00
Olivier Goffart ac393c6374 Do not sent more chunk and cancel the upload when the file change while uploading chunks 2014-03-06 16:04:32 +01:00
Olivier Goffart 114c8de814 Remove the check_csync_treewalk 
because it runs csync_update which need to browse the owncloud directory
And there is no server
 2014-03-06 15:30:36 +01:00
Olivier Goffart 5e012366ab Keep string translatable 
(In french, one may want to add a space before the colon.
Other languages may want to change the order)

Also use the two argument version of arg() to avoid issues if the first
string contains a '%1' sign
 2014-03-06 15:01:34 +01:00
Olivier Goffart ed1294d668 Avoid double delete 2014-03-06 14:28:58 +01:00
Olivier Goffart 7f07385fd7 Remove check_csync_treewalk_remote 
Since we removed the vio abstraction, we cannot use the file system anymore
as a remote.  and because we unfortunately can't use a real server,
just disable that test.
 2014-03-06 14:24:53 +01:00
Olivier Goffart ed2316a53f Add missing line break 
(silent warning)
 2014-03-06 14:10:42 +01:00
Olivier Goffart e5a8cd4521 Merge branch '1.5' 
Conflicts:
	VERSION.cmake
 2014-03-06 14:10:08 +01:00
Olivier Goffart 3f3577d0b1 Merge pull request #1534 from owncloud/clarify-space-usage 
Clarify space usage
 2014-03-06 14:07:25 +01:00
Olivier Goffart 6df00ad08c Only removes the password from the credidentials if it has been fetched before 
Also only run the propfind job if the credidentials are readon, and fetch them
otherwise
 2014-03-03 17:55:15 +01:00
Olivier Goffart 76b24ff00d Revert "Do not wipe the credentials from config for reconnect." 
This reverts commit 9eb3452a71.

We need that or wrong password can never be changed
 2014-03-03 17:21:20 +01:00
Olivier Goffart 60a1d50ec9 Keep the rentrency flag when asking the user for the password 2014-03-03 17:16:57 +01:00
Olivier Goffart 0658802048 Fix layout of the network tab 
Fixes #1491
 2014-02-28 13:17:04 +01:00
Olivier Goffart eeb68919bf Do not erase the username and password from the config if we never connected 
If we never fetched the credidentials, the _user and _password will be empty,
we should therefore not try to save them because it would just erase them.

Version 1.5.2 always try to fetch the creds at startup.  But now we only
do it if we detect an internet connection
 2014-02-28 12:51:06 +01:00
Olivier Goffart 9a60732542 Do not erase the full account config if an old version of the client stored the password 2014-02-28 12:51:06 +01:00
Olivier Goffart e809a59049 Remove spurious error message. 
Sometimes 'success' is false without apparent reason.
Just remove the message
 2014-02-27 17:03:42 +01:00
Olivier Goffart 96c535d712 Make the parrallel uploaded also check for problem in Shared 2014-02-27 14:13:22 +01:00
Olivier Goffart d4fa955950 Don't fetch credidentials from application.cpp 
They will be fetched by the connection validator after doing
the status.php check
 2014-02-27 13:06:29 +01:00
Olivier Goffart 869793592d Merge branch '1.5' 
Conflicts:
	VERSION.cmake
	src/mirall/owncloudpropagator.cpp
	src/mirall/owncloudpropagator.h
 2014-02-27 11:40:34 +01:00
Olivier Goffart 8607300195 Make "Sign Out" forget the cookies 
If we keep the cookies, next time we sign in, the entered password
does not matter as the server still think our session is logged in.
 2014-02-26 13:23:52 +01:00
Olivier Goffart e468ea2d68 Avoid re-entrency in HTTPCredidential::fetch 
It is likely to re-enter if there is two jobs that asks for a password.

Example:
 1. log out
 2. restart the application
 3. enter a wrong password
 4. enter a wrong password again a few times
 5. enter the correct password
 6. it should must not prompt for the password again.

Because of the re-entrency, it was still prompting for the password several
times after the right password had been entered
 2014-02-26 13:10:11 +01:00
Olivier Goffart 75cff87316 add missing copyright header 2014-02-24 19:32:41 +01:00
Olivier Goffart 1e43d1fa49 Add missing license headers in tests 
LGPL for csync tests,  GPL for mirall tests
 2014-02-24 11:08:58 +01:00
Olivier Goffart f92cf3dee3 ammand last commit 
We should not close the directory twice in the normal case
 2014-02-21 19:09:38 +01:00
Olivier Goffart a71cb1d3ef Fix potential crash in case of abort while update: 
We need to reset ctx->remote.read_from_db  BEFORE caling vio_closedir
Otherwise, it may interpret the handle as a 'bdtree' handle instead of
a owncloud handle.

Should fix #1442
 2014-02-21 16:57:24 +01:00
Olivier Goffart cd13144415 Fix adding a file in a Shared readonly directory 
It should not create a conflict in that case.

Also when editing a file, create a conflict using the normal way,
after downloading the file and checking it is not the same
 2014-02-21 10:53:09 +01:00
Olivier Goffart f5e16540a1 Merge branch '1.5' 
Conflicts:
	src/mirall/owncloudpropagator.cpp
 2014-02-19 15:38:03 +01:00
Olivier Goffart e74f0f2854 Better support when user remove or rename the Shared directory 2014-02-19 15:23:36 +01:00
Olivier Goffart a51f050a08 More fix for moving shared directories 
Abort a directory job if the first job fails

Also make sure the jobs are in the directory job of their destination paths
 2014-02-19 13:08:35 +01:00
Olivier Goffart 5b561e4462 Use AUTOMOC 
This should also fix the compilation of owncloudcmd.cpp
Since we have a Q_OBJECT in a .cpp file and qt_wrap_cpp would not generate
the moc file.
 2014-02-19 11:55:08 +01:00
Olivier Goffart 1be322579c Merge remote-tracking branch 'origin/master' 
Conflicts:
	src/owncloudcmd/owncloudcmd.cpp
 2014-02-19 11:19:56 +01:00
Olivier Goffart d4bd327fef Merge branch 'parallel_upload' 
Conflicts:
	src/mirall/csyncthread.cpp
 2014-02-19 10:24:34 +01:00
Olivier Goffart 2de288c5f3 Merge remote-tracking branch 'origin/1.5' 
Conflicts:
	VERSION.cmake
 2014-02-19 10:21:23 +01:00
Olivier Goffart 496d900fee Refactor the renameReplace in its own function 
Share a bit more code between legacy and qnam download job
 2014-02-18 14:05:52 +01:00
Olivier Goffart 58bda69f8b PropagateRemoteRename is not a legacy job 
move it back to propagatorjobs.cpp
 2014-02-18 13:52:40 +01:00
Olivier Goffart 89b5ddec56 Fix the logs in the update phase 
Since csync use a thread local variable for the logs, we need
to reset it when we enter the update thread
 2014-02-18 13:48:13 +01:00
Olivier Goffart f7419094f3 move the file system helpers in their own file 2014-02-18 12:54:40 +01:00
Olivier Goffart 432f377750 Use the legacy jobs when using bandwidth limiting 
Or if a environement variable is set
 2014-02-18 12:24:35 +01:00
Olivier Goffart c32beb957d Move the jobs around between files 
Renamed owncloudpropagator_qnam  to propagator_qnam
Move the jobs in propagatorjobs.cpp
Move the neon jobs that have a qnam equivalent into propagator_legacy.cpp and
rename the jobs accordingly
 2014-02-18 12:21:05 +01:00