chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2026-08-15 09:30:05 +02:00
Code Activity
16,931 Commits 4 Branches 173 Tags
stable-3.3-lnk
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Hannah von RethandMatthieu Gallien 4df0ddcbd5 Add workaround for issue discovered in https://github.com/owncloud/core/pull/38304 2021-08-16 13:05:39 +02:00
Hannah von RethandMatthieu Gallien 26ca566428 Make findBestChecksum case insensitive 
Especially the casing of ADLER32 did not match the server.
 2021-08-16 13:05:34 +02:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) e7e218d8e6 Improve the error message returned by updateMetadata 
Also properly handle the case the the file can't be converted to a placeholder
as it is locked
 2021-07-06 14:03:53 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) 22c634935b Run expansive assert only in dev builds 2021-06-16 10:54:07 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) 03182ea714 Use longWinPath in more places 2021-06-16 10:54:07 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) d014293f6d Ensure pathtoUNC is called with an absolute path 2021-06-16 10:54:06 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) 17a1a630a4 Use the http logger with the unittests 
This allow better debugging of the tests

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) bff386e5c1 Fix int uint warning 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) 98655ef28b Fix warning by using qsizetype instead of size_t 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) ea3d78aecf Fix warning by using QByteArrayLiteral 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) e04c6abcd5 Fix placeholder detection for cfapi 
Fixes: #8326
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von RethandMatthieu Gallien (Rebase PR Action) adb56178b9 GetLastError() needs to be called when the error happens 
qDebug might clear it already

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von RethandKevin Ottens 09cc988026 Fix a possible crash with the remove all files dialog 2020-12-30 16:20:43 +01:00
Hannah von RethandKevin Ottens 72b6118c3e Mark vfs functions as OC_REQUIRED_RESULT 2020-12-30 16:17:48 +01:00
Hannah von RethandKevin Ottens aadda32633 Handle errors in convertToPlaceholder 2020-12-30 16:17:47 +01:00
Hannah von RethandKevin Ottens 552427ffc3 Update windows launch on start binary location 
Fixes: #7672
 2020-12-30 16:17:47 +01:00
Hannah von RethandKevin Ottens 713a429675 Add todo for Qt 5.15 2020-12-30 16:17:47 +01:00
Hannah von RethandKevin Ottens 1144473f5d Cleanup pathtoUNC and its test 2020-12-30 16:17:46 +01:00
Hannah von RethandKevin Ottens 51d73e27ea Clarify comment 2020-12-30 16:17:46 +01:00
Hannah von RethandKevin Ottens 3f873ed2ee Simplify file comparison 2020-12-30 16:17:46 +01:00
Hannah von RethandKevin Ottens 157d526129 Include auth type in http log 2020-12-30 16:17:46 +01:00
Hannah von RethandKevin Ottens f6f7789afa Log the final http request 2020-12-30 16:17:41 +01:00
Hannah von RethandKevin Ottens c03a5da670 Don't warn if everything is fine 2020-12-15 11:01:53 +01:00
Hannah von RethandKevin Ottens 4e373ca7ff Remove now unneeded cmake test and define 2020-12-15 11:01:52 +01:00
Hannah von RethandKevin Ottens ebd8047cb6 Replace custome date parser QDateTime::fromString(value, Qt::RFC2822Date) 2020-12-15 11:01:52 +01:00
Hannah von RethandKevin Ottens 40e07ef3e3 Fix unit tests by setting Date header 2020-12-15 11:01:52 +01:00
Hannah von RethandKevin Ottens 9d9eadba8e Use time the request was send,.. 
not when it was processed by the client, to determine the quality of the connection.
 2020-12-15 11:01:08 +01:00
Hannah von RethandKevin Ottens 6818b8e303 Speedup test build by compile the fake server just once 2020-12-15 10:59:27 +01:00
Hannah von RethandKevin Ottens 1b4ccea083 Owncloud - virtual files smaller <1KB - problems with syncing 
The issue was caused by gziped responses not providing a
content lenght header.

Fixes: #8248
 2020-12-15 10:59:27 +01:00
Hannah von RethandKevin Ottens 96eaef6dba Pause sync when remove all dialog is displayed 
Fixes: #8263
 2020-12-15 10:59:27 +01:00
Hannah von RethandKevin Ottens c253b51249 Use enum instead of int 2020-12-15 10:59:27 +01:00
Hannah von RethandKevin Ottens befc373ea6 Fix test on systems where C:\ is not writeable 2020-12-15 10:59:27 +01:00
Hannah von RethandKevin Ottens dc42ebb793 Don't recurse the whole tree looking for a git dir, use PROJECT_SOURCE_DIR 2020-12-15 10:59:26 +01:00
Hannah von RethandKevin Ottens 0eb8b01f0a Fix usePlaceholders migration 2020-12-15 10:59:26 +01:00
Hannah von RethandKevin Ottens 58bc9e837c Remove junk files 2020-12-15 10:59:26 +01:00
Hannah von RethandKevin Ottens a083a37126 Fix vfs experimental text 2020-12-15 10:59:26 +01:00
Hannah von RethandKevin Ottens b2934a68bc Fix folder permission check on NTFS 
Fixes: #8187
 2020-12-15 10:59:26 +01:00
Hannah von RethandKevin Ottens 8dbdaed5c3 Fix condition 2020-12-15 10:59:26 +01:00
Hannah von RethandKevin Ottens e4a0222954 Append .exe to crashreporter path so it is better located 2020-12-15 10:59:25 +01:00
Hannah von RethandKevin Ottens 440b31986a Ensure the callback is triggered 2020-12-15 10:59:25 +01:00
Hannah von RethandKevin Ottens f6faba48e2 Don`t block main thread when displaying all files removed dialog 
Fixes: #8170
 2020-12-15 10:59:25 +01:00
Hannah von RethandKevin Ottens b4cb3ecb5a Don't use exec() on dialogs 2020-12-15 10:59:25 +01:00
Hannah von RethandKevin Ottens 4878042e61 Update libcrashreporter-qt 2020-12-15 10:59:25 +01:00
Hannah von RethandKevin Ottens 7c65d38ba4 Draw active progressbar 
Pass a widget to the progressbar in the folder delegate to draw the correct active state
 2020-12-15 10:59:25 +01:00
Hannah von RethandKevin Ottens dd3e70b667 VirtualFiles: Ensure the target location supports vfs 
Fixes: #8131
 2020-12-15 10:59:20 +01:00
Hannah von RethandKevin Ottens 8796f25994 Log error code as hex 2020-12-15 10:59:20 +01:00
Hannah von RethandKevin Ottens 44175aca94 Fix: Log chunked messages 2020-12-15 10:59:20 +01:00
Hannah von RethandKevin Ottens 60011e8003 Remove vfs warning in the delegate, indicate them in the description instead 
Fixes: #8139
 2020-12-15 10:59:20 +01:00
Hannah von RethandKevin Ottens 93152761a1 Use verbose function names instead of direct member access 2020-12-15 10:59:20 +01:00
Hannah von RethandKevin Ottens 356192fb1d Don't show 404 errors when manually creating folder sync pair. 
Fixes: #7724
 2020-12-15 10:59:20 +01:00
Hannah von RethandKevin Ottens 1619cd5dcc Use winvfs by default when adding folder sync connection 
Fixes: #8083
 2020-12-15 10:59:19 +01:00
Hannah von RethandKevin Ottens 8460526df9 Clear cookies on logout 2020-12-15 10:59:19 +01:00
Hannah von RethandKevin Ottens 0c57bb8869 Remove the use of goto from test/csync/std_tests/check_std_c_jhash.c 2020-12-15 10:59:19 +01:00
Hannah von RethandKevin Ottens f220151527 Remove the use of goto from src/csync/csync_exclude.cpp 2020-12-15 10:59:19 +01:00
Hannah von RethandKevin Ottens 4f596dae8c Log http status 
Fixes: #8073
 2020-12-15 10:59:19 +01:00
Hannah von RethandKevin Ottens 020c6d6424 Fix placeholders are reverted to OnlineOnly 
Fixes: #7779
 2020-12-15 10:59:19 +01:00
Hannah von RethandKevin Ottens d58cdaeb2a Crashreporter: Apply the same hdpi settings as to the main gui 
Fixes: #8042
 2020-12-15 10:59:18 +01:00
Hannah von RethandKevin Ottens 0eabc75039 Improve log message 2020-12-15 10:59:18 +01:00
Hannah von RethandKevin Ottens f1f6257b5d Windows VFS: Enable Windows VFS by default 2020-12-15 10:59:18 +01:00
Hannah von RethandKevin Ottens 1aa1ea7bea Return empty string instead of 1 as adler32 checksum for empty files 2020-12-15 10:59:18 +01:00
Hannah von RethandKevin Ottens 23f7c51f70 Print checksum on mismatch 2020-12-15 10:59:18 +01:00
Hannah von RethandKevin Ottens fd6146d09e Clazy: Fix some warnings 2020-12-15 10:59:18 +01:00
Hannah von RethandKevin Ottens 3caf8276a2 Remove pointless warning 
We also don't have a version entry in the db if thne db is new.
As I don't expect regular updates from 1.5 this message can just be removed.

Fixes: #8004
 2020-12-15 10:59:17 +01:00
Hannah von RethandKevin Ottens 2d66025d72 csync: apply strict QString handling 2020-12-15 10:59:17 +01:00
Hannah von RethandKevin Ottens bd62615aab Clazy: Fix some warnigns 2020-12-15 10:59:17 +01:00
Hannah von RethandKevin Ottens d109d49b49 Ui: Hide selective sync settings if vfs is active 
Fixes: #7976
 2020-12-15 10:59:17 +01:00
Hannah von RethandKevin Ottens 54cc2be00f Fix assertion introduced by e1ca612c5d3087e02f6b7f8e454224e0b88e82ad 
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787

e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
 2020-12-15 10:59:17 +01:00
Hannah von RethandKevin Ottens 93281c8560 Use const access where possible 2020-12-15 10:59:17 +01:00
Hannah von RethandKevin Ottens 563b347567 csync: apply strict QString handling 2020-12-15 10:59:16 +01:00
Hannah von RethandKevin Ottens 82dbf8b5e1 VFS: remove now unused parameter 2020-12-15 10:59:16 +01:00
Hannah von RethandKevin Ottens c1a91e91e7 Use the servers checksum type by default 2020-12-15 10:59:16 +01:00
Hannah von RethandKevin Ottens 8c3749cbe2 Log state before specific assertion 2020-12-15 10:59:16 +01:00
Hannah von RethandKevin Ottens 2887a93c40 Win: Use full Windows paths in file watcher and improve logging 2020-12-15 10:59:16 +01:00
Hannah von RethandKevin Ottens 7fa7bc54c4 Win: Move hresultToQString from vfs plugin to Utility::formatWinError 2020-12-15 10:59:16 +01:00
Hannah von RethandKevin Ottens 4589772393 Remove more legacy C code 2020-12-15 10:59:15 +01:00
Hannah von RethandKevin Ottens 3dcbc9fa66 Tests: Port check_vio_ext to Windows 2020-12-15 10:59:15 +01:00
Hannah von RethandKevin Ottens 47dc7e6c49 Remove custome string functions 2020-12-15 10:59:15 +01:00
Hannah von RethandKevin Ottens 29c6f44124 Logging: Print enum before cast in SqlQuer::bindValue 2020-12-15 10:59:15 +01:00
Hannah von RethandKevin Ottens b9638bc778 Fix warning 
warning C4573: the usage of 'QObject::disconnect' requires the compiler to capture 'this' but the current default capture mode does not allow it
 2020-12-15 10:59:15 +01:00
Hannah von RethandKevin Ottens e38b43123c Log: Only print 'Saved account settings' in debug mode 
Don't log that there was no error...
 2020-12-15 10:59:15 +01:00
Hannah von RethandKevin Ottens c9ee0a0343 Log: Improve log message [ info gui.folder ]: Folder sync result: 4... 
by including the name of the folder and print the name of the result
 2020-12-15 10:59:15 +01:00
Hannah von RethandKevin Ottens fb34f8ea85 Gui: Don't try to display the wizard during shutdown 
Fixes: #7936
 2020-12-15 10:59:14 +01:00
Hannah von RethandKevin Ottens 4f8928d35e Remove dead code 2020-12-15 10:59:14 +01:00
Hannah von RethandKevin Ottens c5b59bf3b1 Make ownCloud accassible on the Application object 2020-12-15 10:59:14 +01:00
Hannah von RethandKevin Ottens 4645e69147 Remove ifdef(Q_OS_X11) code, there never was such a define. 
As noone complained since I don't think anyone will miss the code
 2020-12-15 10:59:14 +01:00
Hannah von RethandKevin Ottens e4b7ed8fd6 A pedantic .desktop parser want's a list to end with ; 2020-12-15 10:59:14 +01:00
Hannah von RethandKevin Ottens f932dfc648 VFS: Tell the vfs plugin whether we have multiple accounts 
This allows us to decide on the presentation of the account
 2020-12-15 10:59:14 +01:00
Hannah von RethandKevin Ottens a0d81df21e UnitTests: Set a CookiesJar in FakeQNAM 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 7e91166d7a CMake: Remove krazy2 support, we now use clazy 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 7fdb842ed2 VFS: Prevent duplicated navigation panel icon 
Issue: #7748
 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 6c2c544713 Log HTTP requests and responses 
Issue: #7873
 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens c92f70d4ff Beautify flags 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 2b95f919ad Fix 3aeca58b316363dc12ad4b392750fc57e7a2965a 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 6d2526a67d Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens 6fde08d9f7 Fix crash on settings migration 
Fixes: #7878
 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens fa87b899fb Fix usage of QMessageBox 
Fixes: #7874
 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens 11b9e3fa61 Fix order of pluginkit commands and modernise 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens aaca3e7ce5 Use separate loggin category for upload v1 and ng 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens eed4ffb823 Wizard: Raise own window 
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
 2020-12-15 10:59:11 +01:00
Hannah von RethandKevin Ottens baff0a6986 VFS Dialog: Don't enable on close button clicked 
Issue: #7710
 2020-12-15 10:59:11 +01:00