Add an option to use :orig image links in context menu

Configuration/UserConfig.cs

@@ -39,6 +39,7 @@ static UserConfig(){
 
         public bool ExpandLinksOnHover     { get; set; } = true;
         public bool SwitchAccountSelectors { get; set; } = true;
+        public bool BestImageQuality       { get; set; } = true;
         public bool EnableSpellCheck       { get; set; } = false;
         private int _zoomLevel                           = 100;
         private bool _muteNotifications;
@@ -81,6 +82,8 @@ static UserConfig(){
         public bool IsCustomNotificationPositionSet => CustomNotificationPosition != ControlExtensions.InvisibleLocation;
         public bool IsCustomNotificationSizeSet => CustomNotificationSize != Size.Empty;
 
+        public TwitterUtils.ImageQuality TwitterImageQuality => BestImageQuality ? TwitterUtils.ImageQuality.Orig : TwitterUtils.ImageQuality.Default;
+
         public string NotificationSoundPath{
             get => string.IsNullOrEmpty(_notificationSoundPath) ? string.Empty : _notificationSoundPath;
             set => _notificationSoundPath = value;

Core/Handling/ContextMenuBase.cs

@@ -5,7 +5,6 @@
 using System.Windows.Forms;
 using TweetDuck.Core.Bridge;
 using TweetDuck.Core.Controls;
-using TweetDuck.Core.Other;
 using TweetDuck.Core.Utils;
 
 namespace TweetDuck.Core.Handling{
@@ -13,6 +12,8 @@ abstract class ContextMenuBase : IContextMenuHandler{
         private static readonly Lazy<Regex> RegexTwitterAccount = new Lazy<Regex>(() => new Regex(@"^https?://twitter\.com/([^/]+)/?$", RegexOptions.Compiled), false);
         protected static readonly bool HasDevTools = File.Exists(Path.Combine(Program.ProgramPath, "devtools_resources.pak"));
 
+        private static TwitterUtils.ImageQuality ImageQuality => Program.UserConfig.TwitterImageQuality;
+
         private const int MenuOpenLinkUrl = 26500;
         private const int MenuCopyLinkUrl = 26501;
         private const int MenuCopyUsername = 26502;
@@ -61,34 +62,15 @@ public virtual bool OnContextMenuCommand(IWebBrowser browserControl, IBrowser br
                     break;
 
                 case MenuOpenImage:
-                    BrowserUtils.OpenExternalBrowser(parameters.SourceUrl);
+                    BrowserUtils.OpenExternalBrowser(TwitterUtils.GetImageLink(parameters.SourceUrl, ImageQuality));
                     break;
 
                 case MenuSaveImage:
-                    string fileName = GetImageFileName(parameters.SourceUrl);
+                    TwitterUtils.DownloadImage(parameters.SourceUrl, ImageQuality);
-                    string extension = Path.GetExtension(fileName);
-                    string saveTarget;
-
-                    using(SaveFileDialog dialog = new SaveFileDialog{
-                        AutoUpgradeEnabled = true,
-                        OverwritePrompt = true,
-                        Title = "Save image",
-                        FileName = fileName,
-                        Filter = "Image ("+(string.IsNullOrEmpty(extension) ? "unknown" : extension)+")|*.*"
-                    }){
-                        saveTarget = dialog.ShowDialog() == DialogResult.OK ? dialog.FileName : null;
-                    }
-
-                    if (saveTarget != null){
-                        BrowserUtils.DownloadFileAsync(parameters.SourceUrl, saveTarget, null, ex => {
-                            FormMessage.Error("Image Download", "An error occurred while downloading the image: "+ex.Message, FormMessage.OK);
-                        });
-                    }
-
                     break;
 
                 case MenuCopyImageUrl:
-                    SetClipboardText(parameters.SourceUrl);
+                    SetClipboardText(TwitterUtils.GetImageLink(parameters.SourceUrl, ImageQuality));
                     break;
 
                 case MenuCopyUsername:
@@ -129,17 +111,5 @@ protected static void AddSeparator(IMenuModel model){
                 model.AddSeparator();
             }
         }
-
-        private static string GetImageFileName(string url){
-            // twimg adds a colon after file extension
-            int dot = url.LastIndexOf('.');
-
-            if (dot != -1){
-                url = StringUtils.ExtractBefore(url, ':', dot);
-            }
-
-            // return file name
-            return BrowserUtils.GetFileNameFromUrl(url) ?? "unknown";
-        }
     }
 }

Core/Other/Settings/TabSettingsGeneral.Designer.cs

@@ -43,6 +43,7 @@ private void InitializeComponent() {
             this.panelUpdates = new System.Windows.Forms.Panel();
             this.panelTray = new System.Windows.Forms.Panel();
             this.labelUpdates = new System.Windows.Forms.Label();
+            this.checkBestImageQuality = new System.Windows.Forms.CheckBox();
             ((System.ComponentModel.ISupportInitialize)(this.trackBarZoom)).BeginInit();
             this.panelUI.SuspendLayout();
             this.panelUpdates.SuspendLayout();
@@ -87,11 +88,11 @@ private void InitializeComponent() {
             // checkSpellCheck
             // 
             this.checkSpellCheck.AutoSize = true;
-            this.checkSpellCheck.Location = new System.Drawing.Point(6, 51);
+            this.checkSpellCheck.Location = new System.Drawing.Point(6, 74);
             this.checkSpellCheck.Margin = new System.Windows.Forms.Padding(6, 3, 3, 3);
             this.checkSpellCheck.Name = "checkSpellCheck";
             this.checkSpellCheck.Size = new System.Drawing.Size(119, 17);
-            this.checkSpellCheck.TabIndex = 2;
+            this.checkSpellCheck.TabIndex = 3;
             this.checkSpellCheck.Text = "Enable Spell Check";
             this.toolTip.SetToolTip(this.checkSpellCheck, "Underlines words that are spelled incorrectly.");
             this.checkSpellCheck.UseVisualStyleBackColor = true;
@@ -122,11 +123,11 @@ private void InitializeComponent() {
             // labelZoomValue
             // 
             this.labelZoomValue.BackColor = System.Drawing.Color.Transparent;
-            this.labelZoomValue.Location = new System.Drawing.Point(141, 100);
+            this.labelZoomValue.Location = new System.Drawing.Point(141, 123);
             this.labelZoomValue.Margin = new System.Windows.Forms.Padding(0, 0, 3, 0);
             this.labelZoomValue.Name = "labelZoomValue";
             this.labelZoomValue.Size = new System.Drawing.Size(38, 13);
-            this.labelZoomValue.TabIndex = 5;
+            this.labelZoomValue.TabIndex = 6;
             this.labelZoomValue.Text = "100%";
             this.labelZoomValue.TextAlign = System.Drawing.ContentAlignment.TopRight;
             this.toolTip.SetToolTip(this.labelZoomValue, "Changes the zoom level.\r\nAlso affects notifications and screenshots.");
@@ -158,24 +159,24 @@ private void InitializeComponent() {
             this.trackBarZoom.AutoSize = false;
             this.trackBarZoom.BackColor = System.Drawing.SystemColors.Control;
             this.trackBarZoom.LargeChange = 25;
-            this.trackBarZoom.Location = new System.Drawing.Point(3, 99);
+            this.trackBarZoom.Location = new System.Drawing.Point(3, 122);
             this.trackBarZoom.Maximum = 200;
             this.trackBarZoom.Minimum = 50;
             this.trackBarZoom.Name = "trackBarZoom";
             this.trackBarZoom.Size = new System.Drawing.Size(148, 30);
             this.trackBarZoom.SmallChange = 5;
-            this.trackBarZoom.TabIndex = 4;
+            this.trackBarZoom.TabIndex = 5;
             this.trackBarZoom.TickFrequency = 25;
             this.trackBarZoom.Value = 100;
             // 
             // labelZoom
             // 
             this.labelZoom.AutoSize = true;
-            this.labelZoom.Location = new System.Drawing.Point(3, 83);
+            this.labelZoom.Location = new System.Drawing.Point(3, 106);
             this.labelZoom.Margin = new System.Windows.Forms.Padding(3, 12, 3, 0);
             this.labelZoom.Name = "labelZoom";
             this.labelZoom.Size = new System.Drawing.Size(34, 13);
-            this.labelZoom.TabIndex = 3;
+            this.labelZoom.TabIndex = 4;
             this.labelZoom.Text = "Zoom";
             // 
             // zoomUpdateTimer
@@ -198,6 +199,7 @@ private void InitializeComponent() {
             // 
             this.panelUI.Anchor = ((System.Windows.Forms.AnchorStyles)(((System.Windows.Forms.AnchorStyles.Top | System.Windows.Forms.AnchorStyles.Left) 
             | System.Windows.Forms.AnchorStyles.Right)));
+            this.panelUI.Controls.Add(this.checkBestImageQuality);
             this.panelUI.Controls.Add(this.checkExpandLinks);
             this.panelUI.Controls.Add(this.checkSwitchAccountSelectors);
             this.panelUI.Controls.Add(this.checkSpellCheck);
@@ -206,14 +208,14 @@ private void InitializeComponent() {
             this.panelUI.Controls.Add(this.trackBarZoom);
             this.panelUI.Location = new System.Drawing.Point(9, 31);
             this.panelUI.Name = "panelUI";
-            this.panelUI.Size = new System.Drawing.Size(322, 134);
+            this.panelUI.Size = new System.Drawing.Size(322, 157);
             this.panelUI.TabIndex = 1;
             // 
             // labelTray
             // 
             this.labelTray.AutoSize = true;
             this.labelTray.Font = new System.Drawing.Font("Microsoft Sans Serif", 12F, System.Drawing.FontStyle.Regular, System.Drawing.GraphicsUnit.Point, ((byte)(238)));
-            this.labelTray.Location = new System.Drawing.Point(5, 189);
+            this.labelTray.Location = new System.Drawing.Point(6, 212);
             this.labelTray.Margin = new System.Windows.Forms.Padding(0, 21, 0, 0);
             this.labelTray.Name = "labelTray";
             this.labelTray.Size = new System.Drawing.Size(96, 20);
@@ -226,7 +228,7 @@ private void InitializeComponent() {
             | System.Windows.Forms.AnchorStyles.Right)));
             this.panelUpdates.Controls.Add(this.checkUpdateNotifications);
             this.panelUpdates.Controls.Add(this.btnCheckUpdates);
-            this.panelUpdates.Location = new System.Drawing.Point(9, 335);
+            this.panelUpdates.Location = new System.Drawing.Point(9, 358);
             this.panelUpdates.Name = "panelUpdates";
             this.panelUpdates.Size = new System.Drawing.Size(322, 55);
             this.panelUpdates.TabIndex = 5;
@@ -238,7 +240,7 @@ private void InitializeComponent() {
             this.panelTray.Controls.Add(this.checkTrayHighlight);
             this.panelTray.Controls.Add(this.comboBoxTrayType);
             this.panelTray.Controls.Add(this.labelTrayIcon);
-            this.panelTray.Location = new System.Drawing.Point(9, 212);
+            this.panelTray.Location = new System.Drawing.Point(9, 235);
             this.panelTray.Name = "panelTray";
             this.panelTray.Size = new System.Drawing.Size(322, 76);
             this.panelTray.TabIndex = 3;
@@ -247,13 +249,25 @@ private void InitializeComponent() {
             // 
             this.labelUpdates.AutoSize = true;
             this.labelUpdates.Font = new System.Drawing.Font("Microsoft Sans Serif", 12F, System.Drawing.FontStyle.Regular, System.Drawing.GraphicsUnit.Point, ((byte)(238)));
-            this.labelUpdates.Location = new System.Drawing.Point(6, 312);
+            this.labelUpdates.Location = new System.Drawing.Point(6, 335);
             this.labelUpdates.Margin = new System.Windows.Forms.Padding(0, 21, 0, 0);
             this.labelUpdates.Name = "labelUpdates";
             this.labelUpdates.Size = new System.Drawing.Size(70, 20);
             this.labelUpdates.TabIndex = 4;
             this.labelUpdates.Text = "Updates";
             // 
+            // checkBestImageQuality
+            // 
+            this.checkBestImageQuality.AutoSize = true;
+            this.checkBestImageQuality.Location = new System.Drawing.Point(6, 51);
+            this.checkBestImageQuality.Margin = new System.Windows.Forms.Padding(6, 3, 3, 3);
+            this.checkBestImageQuality.Name = "checkBestImageQuality";
+            this.checkBestImageQuality.Size = new System.Drawing.Size(114, 17);
+            this.checkBestImageQuality.TabIndex = 2;
+            this.checkBestImageQuality.Text = "Best Image Quality";
+            this.toolTip.SetToolTip(this.checkBestImageQuality, "When right-clicking a tweet image, the context menu options\r\nwill use links to the original image size (:orig in the URL).");
+            this.checkBestImageQuality.UseVisualStyleBackColor = true;
+            // 
             // TabSettingsGeneral
             // 
             this.AutoScaleDimensions = new System.Drawing.SizeF(6F, 13F);
@@ -265,7 +279,7 @@ private void InitializeComponent() {
             this.Controls.Add(this.panelUI);
             this.Controls.Add(this.labelUI);
             this.Name = "TabSettingsGeneral";
-            this.Size = new System.Drawing.Size(340, 400);
+            this.Size = new System.Drawing.Size(340, 422);
             ((System.ComponentModel.ISupportInitialize)(this.trackBarZoom)).EndInit();
             this.panelUI.ResumeLayout(false);
             this.panelUI.PerformLayout();
@@ -299,5 +313,6 @@ private void InitializeComponent() {
         private System.Windows.Forms.Panel panelUpdates;
         private System.Windows.Forms.Panel panelTray;
         private System.Windows.Forms.Label labelUpdates;
+        private System.Windows.Forms.CheckBox checkBestImageQuality;
     }
 }

Core/Other/Settings/TabSettingsGeneral.cs

@@ -28,6 +28,7 @@ public TabSettingsGeneral(UpdateHandler updates){
 
             checkExpandLinks.Checked = Config.ExpandLinksOnHover;
             checkSwitchAccountSelectors.Checked = Config.SwitchAccountSelectors;
+            checkBestImageQuality.Checked = Config.BestImageQuality;
             checkSpellCheck.Checked = Config.EnableSpellCheck;
             checkTrayHighlight.Checked = Config.EnableTrayHighlight;
 
@@ -37,6 +38,7 @@ public TabSettingsGeneral(UpdateHandler updates){
         public override void OnReady(){
             checkExpandLinks.CheckedChanged += checkExpandLinks_CheckedChanged;
             checkSwitchAccountSelectors.CheckedChanged += checkSwitchAccountSelectors_CheckedChanged;
+            checkBestImageQuality.CheckedChanged += checkBestImageQuality_CheckedChanged;
             checkSpellCheck.CheckedChanged += checkSpellCheck_CheckedChanged;
             trackBarZoom.ValueChanged += trackBarZoom_ValueChanged;
 
@@ -59,6 +61,10 @@ private void checkSwitchAccountSelectors_CheckedChanged(object sender, EventArgs
             Config.SwitchAccountSelectors = checkSwitchAccountSelectors.Checked;
         }
 
+        private void checkBestImageQuality_CheckedChanged(object sender, EventArgs e){
+            Config.BestImageQuality = checkBestImageQuality.Checked;
+        }
+
         private void checkSpellCheck_CheckedChanged(object sender, EventArgs e){
             Config.EnableSpellCheck = checkSpellCheck.Checked;
             PromptRestart();

Core/Utils/TwitterUtils.cs

@@ -16,7 +16,7 @@ static class TwitterUtils{
         };
 
         public enum ImageQuality{
-            Large, Orig
+            Default, Orig
         }
 
         public static bool IsTweetDeckWebsite(IFrame frame){
@@ -33,16 +33,18 @@ private static string ExtractImageBaseLink(string url){
         }
 
         public static string GetImageLink(string url, ImageQuality quality){
-            string result = ExtractImageBaseLink(url);
+            if (quality == ImageQuality.Orig){
+                string result = ExtractImageBaseLink(url);
 
-            if (result != url){
+                if (result != url){
-                switch(quality){
+                    result += ":orig";
-                    case ImageQuality.Large: result += ":large"; break;
-                    case ImageQuality.Orig: result += ":orig"; break;
                 }
-            }
 
-            return result;
+                return result;
+            }
+            else{
+                return url;
+            }
         }
 
         public static void DownloadImage(string url, ImageQuality quality){