Address code analysis issues and fix unused parameter in CombinedFileStream.WriteToFile

Core/FormBrowser.Designer.cs

@@ -24,7 +24,6 @@ protected override void Dispose(bool disposing) {
         /// </summary>
         private void InitializeComponent() {
             this.components = new System.ComponentModel.Container();
-            System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(FormBrowser));
             this.trayIcon = new TweetDck.Core.TrayIcon();
             this.toolTip = new System.Windows.Forms.ToolTip(this.components);
             this.SuspendLayout();

Core/Other/FormSettings.Designer.cs

@@ -23,7 +23,6 @@ protected override void Dispose(bool disposing) {
         /// the contents of this method with the code editor.
         /// </summary>
         private void InitializeComponent() {
-            System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(FormSettings));
             this.btnClose = new System.Windows.Forms.Button();
             this.labelTip = new System.Windows.Forms.Label();
             this.tabPanel = new TweetDck.Core.Controls.TabPanel();

Core/Other/Settings/Export/CombinedFileStream.cs

@@ -89,8 +89,11 @@ public void WriteToFile(string path){
             }
 
             public void WriteToFile(string path, bool createDirectory){
-                // ReSharper disable once AssignNullToNotNullAttribute
-                Directory.CreateDirectory(Path.GetDirectoryName(path));
+                if (createDirectory){
+                    // ReSharper disable once AssignNullToNotNullAttribute
+                    Directory.CreateDirectory(Path.GetDirectoryName(path));
+                }
+
                 File.WriteAllBytes(path, contents);
             }
         }

Core/Other/Settings/Export/ExportManager.cs

@@ -33,9 +33,9 @@ public bool Export(bool includeSession){
                             continue;
                         }
                         else if (split.Length == 3){
-                            if (split[2].Equals(".meta", StringComparison.InvariantCultureIgnoreCase) ||
-                                split[2].Equals("browser.js", StringComparison.InvariantCultureIgnoreCase) ||
-                                split[2].Equals("notification.js", StringComparison.InvariantCultureIgnoreCase)){
+                            if (split[2].Equals(".meta", StringComparison.OrdinalIgnoreCase) ||
+                                split[2].Equals("browser.js", StringComparison.OrdinalIgnoreCase) ||
+                                split[2].Equals("notification.js", StringComparison.OrdinalIgnoreCase)){
                                 continue;
                             }
                         }

Core/Utils/CommandLineArgsParser.cs

@@ -33,7 +33,7 @@ public static int AddToDictionary(string args, IDictionary<string, string> dicti
                     value = matchValue.Substring(indexEquals+1).Trim('"');
                 }
 
-                if (key != string.Empty){
+                if (key.Length != 0){
                     dictionary[key] = value;
                     ++count;
                 }

Plugins/Controls/PluginControl.cs

@@ -27,7 +27,7 @@ public PluginControl(PluginManager pluginManager, Plugin plugin) : this(){
                 this.labelName.ForeColor = Color.DarkRed;
                 this.btnToggleState.Enabled = false;
             }
-            else if (labelDescription.Text == string.Empty){
+            else if (labelDescription.Text.Length == 0){
                 labelDescription.Visible = false;
             }
 
@@ -35,7 +35,7 @@ public PluginControl(PluginManager pluginManager, Plugin plugin) : this(){
         }
 
         private void panelDescription_Resize(object sender, EventArgs e){
-            if (labelDescription.Text == string.Empty){
+            if (labelDescription.Text.Length == 0){
                 Height = MinimumSize.Height;
             }
             else{

Plugins/Plugin.cs

@@ -93,7 +93,7 @@ private static bool LoadEnvironments(string path, Plugin plugin, out string erro
                 if (environment != PluginEnvironment.None){
                     plugin.Environments |= environment;
                 }
-                else if (!file.StartsWith("user.")){
+                else if (!file.StartsWith("user.", StringComparison.OrdinalIgnoreCase)){
                     error = "Unknown script file: "+file+". All custom script files have to be in the following naming style: user."+file;
                     return false;
                 }

Plugins/PluginBridge.cs

@@ -85,7 +85,7 @@ public string ReadFile(int token, string path, bool cache){
         public void DeleteFile(int token, string path){
             string fullPath = GetFullPathIfSafe(token, path);
 
-            if (fullPath == string.Empty){
+            if (fullPath.Length == 0){
                 throw new Exception("File path has to be relative to the plugin folder.");
             }
             
@@ -96,7 +96,7 @@ public void DeleteFile(int token, string path){
         public bool CheckFileExists(int token, string path){
             string fullPath = GetFullPathIfSafe(token, path);
 
-            if (fullPath == string.Empty){
+            if (fullPath.Length == 0){
                 throw new Exception("File path has to be relative to the plugin folder.");
             }