Merge pull request #129 from chylex/remove_legacy

Remove legacy code (plugins and installers)

Configuration/UserConfig.cs

@@ -45,8 +45,7 @@ public override Type BindToType(string assemblyName, string typeName){
 
         public bool EnableUpdateCheck { get; set; }
         public string DismissedUpdate { get; set; }
-
+        
-        [Obsolete] public PluginConfig Plugins { get; set; } // TODO remove eventually
         public WindowState PluginsWindow { get; set; }
 
         public string CustomCefArgs { get; set; }

Plugins/PluginConfig.cs

@@ -5,9 +5,7 @@
 using TweetDuck.Plugins.Events;
 
 namespace TweetDuck.Plugins{
-    [Serializable]
     sealed class PluginConfig{
-        [field:NonSerialized]
         public event EventHandler<PluginChangedStateEventArgs> InternalPluginChangedState; // should only be accessed from PluginManager
 
         public IEnumerable<string> DisabledPlugins => Disabled;
@@ -18,14 +16,6 @@ sealed class PluginConfig{
             "official/reply-account"
         };
 
-        public void ImportLegacy(PluginConfig config){
-            Disabled.Clear();
-            
-            foreach(string plugin in config.Disabled){
-                Disabled.Add(plugin);
-            }
-        }
-
         public void SetEnabled(Plugin plugin, bool enabled){
             if ((enabled && Disabled.Remove(plugin.Identifier)) || (!enabled && Disabled.Add(plugin.Identifier))){
                 InternalPluginChangedState?.Invoke(this, new PluginChangedStateEventArgs(plugin, enabled));

Plugins/PluginManager.cs

@@ -42,29 +42,14 @@ public PluginManager(string rootPath, string configPath){
             this.Config = new PluginConfig();
             this.Bridge = new PluginBridge(this);
 
-            LoadConfig();
+            Config.Load(configPath);
             
             Config.InternalPluginChangedState += Config_InternalPluginChangedState;
             Program.UserConfigReplaced += Program_UserConfigReplaced;
         }
 
-        private void LoadConfig(){
-            #pragma warning disable 612
-            if (Program.UserConfig.Plugins != null){
-                Config.ImportLegacy(Program.UserConfig.Plugins);
-                Config.Save(configPath);
-
-                Program.UserConfig.Plugins = null;
-                Program.UserConfig.Save();
-            }
-            #pragma warning restore 612
-            else{
-                Config.Load(configPath);
-            }
-        }
-
         private void Program_UserConfigReplaced(object sender, EventArgs e){
-            LoadConfig();
+            Config.Load(configPath);
             Reload();
         }
 

bld/gen_full.iss

@@ -48,13 +48,10 @@ Name: "{commondesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks:
 [Run]
 Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall shellexec skipifsilent
 
-[InstallDelete]
-Type: files; Name: "{app}\td-log.txt"
-Type: filesandordirs; Name: "{app}\plugins\official\design-revert"
-Type: filesandordirs; Name: "{localappdata}\TD_Plugins\official\design-revert"
-
 [UninstallDelete]
-Type: files; Name: "{app}\debug.log"
+Type: files; Name: "{app}\*.*"
+Type: filesandordirs; Name: "{app}\locales"
+Type: filesandordirs; Name: "{app}\scripts"
 Type: filesandordirs; Name: "{localappdata}\{#MyAppName}\Cache"
 Type: filesandordirs; Name: "{localappdata}\{#MyAppName}\GPUCache"
 

bld/gen_port.iss

@@ -41,10 +41,6 @@ Source: "..\bin\x86\Release\*"; DestDir: "{app}"; Flags: ignoreversion recursesu
 [Run]
 Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall shellexec skipifsilent
 
-[InstallDelete]
-Type: filesandordirs; Name: "{app}\plugins\official\design-revert"
-Type: filesandordirs; Name: "{app}\portable\storage\TD_Plugins\official\design-revert"
-
 [Code]
 var UpdatePath: String;
 

bld/gen_upd.iss

@@ -50,16 +50,6 @@ Name: "{group}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Check: TDIsUnin
 [Run]
 Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Parameters: "{code:TDGetRunArgs}"; Flags: nowait postinstall shellexec
 
-[InstallDelete]
-Type: files; Name: "{app}\*.xml"
-Type: files; Name: "{app}\*.js"
-Type: files; Name: "{app}\d3dcompiler_43.dll"
-Type: files; Name: "{app}\widevinecdmadapter.dll"
-Type: files; Name: "{app}\CefSharp.BrowserSubprocess.exe"
-Type: files; Name: "{app}\td-log.txt"
-Type: files; Name: "{app}\debug.log"
-Type: files; Name: "{localappdata}\{#MyAppName}\ChromeDWriteFontCache"
-
 [UninstallDelete]
 Type: files; Name: "{app}\*.*"
 Type: filesandordirs; Name: "{app}\locales"