chylex/Nextcloud-News
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-News.git synced 2026-08-21 11:27:04 +02:00
Code Activity
6,749 Commits 3 Branches 0 Tags
master
Commit Graph
6749 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
WENDLING NICOLASandSean Molenaar 604f64c30c 🚨 Fix linter in those classes: 
- ItemController
- ItemMapperV2
- ItemServicev2

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
WENDLING NICOLASandSean Molenaar 376f866a83 ✅ Fix those tests -> ItemControllerTest: 
-  testIndexForFeed
- testIndexForFolder
- testIndexForShared
- testIndexForOther
- testIndexSearchFeed
- testNewItemsFeed
- testNewItemsFolder
- testNewItemsShared
- testNewItemsOther

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar dd4617d368 Fix findFromUser, testFindAllFromUserWithParams, testFindAllFromUser 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 5a12e50cca Fix testFindForUserByGUIDHash 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
WENDLING NICOLASandSean Molenaar 890b8fa1df ✅ Fix FeedControllerTest tests 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 2c59331316 Fix testNewest 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 306f97d656 Fix tests testFindAllInFolderAfterHideRead, testFindAllInFolderAfter, testFindAllInFeedAfterHideRead, testFindAllInFeedAfter 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 6775fe541e Fix testFindAllItemsStarredSearch, testFindAllItemsStarred, testFindAllItemsUnread 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar e7ec222c1d Fix testFindAllItemsInvalid, testFindAllAfterInvalid, testFindAllAfterStarred, testFindAllAfterUnread 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar d6b32cf674 fix test findAllFeed 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar d314e8b495 Fix test findAllFeedSearch and findAllFeedHideRead 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar f59fe96105 Fix test findAllFolderIdNull and findAllFolderHideRead 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 319b15a655 Fix test findAllFolderHideReadInvertOrder 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 8b51ee583e Fix test FindAllFolderSearchId 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 818736c2be fix test readAll 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar fc8670f5be ✅ ItemMapperTest: add tests for findAllSharedAfter 
- testFindAllSharedAfter
- testFindAllSharedAfterHideRead

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar cbe1ca6b4d ✅ ItemMapperTest: test findAllSharedWithUser func 
- testFindAllSharedWithUser
- testFindAllSharedWithUserHideRead
- testFindAllSharedWithUserSearch

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 5c359a8d42 ✅ ItemServiceTest: test share functions 
- testFindAllShared
- testFindAllNewShared
- testSharedCount

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 14c6685344 ✅ ItemServiceTest: test share function 
- testShare
- testShareDoesNotExist

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 75e81d5e0b 🥅 ItemService: catch NotFoundException + cleanup 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 46cc069863 ✅ ItemControllerTest: added share tests (WIP) 
- testIndexForShared
- testNewItemShared

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar ceefee0d3e 🗃 Change share migration version 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 91c034c72f ✅ Fix ItemController share tests 
- testShare
- testShareDoesNotExist

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 88fc165f49 🔥 Remove old ItemMapper & ItemService 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar df8680b14a 🩹 Remove traces of feed_id being nullable 
- feed_id is not nullable so we remove default values

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 08982fc540 ✨ Add findAllSharedAfter 
- adapted Controller, Service and Mapper (newItems)

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 0f6ec7c99c ✨ Implementer shared getter + add count in request 
- ItemServiceV2: added sharedWithUser - returns unread shared items
- ItemController & FeedController - returning shared count

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 7e1a0b47cf ✨ ItemController (index): add case for shared items 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar d63e999d93 ✨ ItemServiceV2: add findAllSharedWithUserWithFilters 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 1f0924fb57 ✨ ItemMapperV2: exclude shared items in functions 
updated the following functions to exclude shared_items:
- findAllInFeedAfter
- findAllInFolderAfter
- findAllFeed
- findAllFolder

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 26ae92bc7b ✨ ItemMapperV2: include shared in functions 
updated the following functions to include shared items:
- findFromUser
- findForUserByGuidHash
- readAll
- findAllAfter
- findAllItems

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 83bdbc08a0 ✨ ItemMapperV2: include shared in functions 
updated the following functions to include shared items:
- findAllFromUser
- newest

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar c3cc70b15e ✨ ItemMapperV2: added findAllSharedWithUser funct 
- return all items shared with a given user

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 907e764749 🚧 ItemService, Controller: added basic sharing 
- TODO: check if relation already exists

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 237363e087 💡 Added comments to ItemMapper share fncts 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 89d7293e84 ✅ Add tests: testFindAllShared, testShare + ... 
+ testShareDoesNotExist

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar f9f25ddbd2 Add tests setSharedBy and setSharedWith 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
WENDLING NICOLASandSean Molenaar 615668d688 ✅ Unary test for itemShare from itemService class 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 4133e68c8e ✅ Update tests to contain share data 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 54aa8b5270 🩹 Return starredCount in newItems response params 
- returning sharedCount everywhere where starredCount is returned

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar ec5ae1a90a 🩹 ItemMapper->deleteUser: include shared items 
- deletes items shared with a user

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 15dedf0ceb 🩹 Patch getNewestItemId: include shared articles 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar 11bd056bdf 🩹 Patch readAll: concerns items shared with user 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar c640740444 🐛 Fix readAll: cannot read items we shared 
- A shared item is still in our feed, but it's not ours to read

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar bf92ace3e8 🐛 Added sharedCount to feedController index resp. 
- After reloading news app, the shared menu count wouldn't update
- The number would only update on click (call ItemController index)
- Adding it here fixes the issue

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar b27226d4ae 🚑 Fix bug - other user feeds show for shared item 
- findAllFeeds doesn't return feeds of shared articles
- Disable feed cache handling for shared items

Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar e78153c051 ✨ Sharing: update ownership in sql (sharedwith) 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
AurélienandSean Molenaar 5f69c256e3 Add function for avoid duplicate item (share) 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Marco NassabainandSean Molenaar f3c4d744c0 🐛 Share Item: feed_id not nullable, copy feed_id 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00
Jimmy HuynhandSean Molenaar 98d72bac54 (*) fix: item Model 
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
 2021-04-08 22:31:21 +02:00