Marco Nassabain
486e651ed6
🎨 Rename $l to $l10n
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
307534cc29
✅ Added test for sharedByDisplayName field
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
9e9bd24c5f
✅ Add + update sharer display name tests
...
- added testMapSharedByDisplayNames
- updated ItemController tests to expect call to function
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
bbdd95c30d
🔥 Remove UserManager code from ItemMapper & tests
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
c2c92a3f5a
🩹 Fix issues after rebase
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
af84bbf204
✅ Item: update tests - include sharer display name
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
0fdd88df55
🧹 ShareService: rename $url to $urlGenerator
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
a754b437e0
✅ Update test to include localization
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
7f3c63a2a4
🎨 ShareService: update dummy feed URL
...
- add IURLGenerator DI
- update url to "http://serverurl/news/sharedwithme "
- updated tests: added DI + adapted expected url
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
920ae54a2c
🌐 ShareService: Localize dummy feed title
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
b0c42e4cd7
♻️ Item: Remove isShared
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
2cba1e4146
🧹 Cleanup code, remove spaces, rename variables
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
5c5578b16e
✅ Update ItemServiceTest: remove share tests
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
e6eb878c4f
✅ WIP add ShareServiceTest
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
25e2efd54a
✅ Update ItemTest - remove sharedWith field
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
88fa9886ae
✅ Update ItemController share tests
...
- use ShareService and shareItemWithUser function
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
d275a5b9e7
🩹 Patch ItemControllerTest to mock shareService
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
409c835433
🩹 Patch ItemController + test to use ShareService
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
dd818c6203
🚑 Fix circular inclusion: create ShareService
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
54a228eca5
✨ Add FeedService DI into ItemService in tests
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
2ee5112760
🔥 Remove old share logic from tests & old tests
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
f708e40b75
✏️ Fix share test name typo
...
- testFindAllShared => testFindAllSharedWithUser
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
80dec257c2
✅ Update find shared items tests
...
- testFindAllSharedWithUser
- testFindAllSharedWithUserHideRead
- testFindAllSharedWithUserSearch
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
8de50d44b6
✅ ItemMapperPaginatedTest: update tests
...
Adapted folder/feed/item tests to take account for shared data
- testFindAllItemsStarredSearch
- testFindAllFeed
- testFindAllFeedInverted
- testFindAllFeedHideRead
- testFindAllFeedSearch
- testFindAllFolderIdNull
- testFindAllFolderHideRead
- testFindAllFolderHideReadInvertOrder
- testFindAllFolderSearchId
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
WENDLING NICOLAS
ee49a1d1cc
✅ Fix tests in ItemMapperPaginatedTest:
...
- testFindAllItemsInvalid
- testFindAllItemsFullInverted
- testFindAllItemsUnread
- testFindAllItemsStarred
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
WENDLING NICOLAS
abba7386ee
✅ Fix tests in ItemMapperAfterTest:
...
- testFindAllAfterStarred
- testFindAllAfterAll
- testFindAllAfterInvalid
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
WENDLING NICOLAS
6dbf64fa9d
✅ Fix tests in ItemMapperAfterTest:
...
- testFindAllInFeedAfter
- testFindAllInFeedAfterHideRead
- testFindAllInFolderAfter
- testFindAllInFolderAfterHideRead
- testFindAllAfterUnread
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
702d611f35
🔀 Resolving merge: moving shared tests
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
85dbed9ffa
🧹 Cleanup test files: added new lines
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
WENDLING NICOLAS
376f866a83
✅ Fix those tests -> ItemControllerTest:
...
- testIndexForFeed
- testIndexForFolder
- testIndexForShared
- testIndexForOther
- testIndexSearchFeed
- testNewItemsFeed
- testNewItemsFolder
- testNewItemsShared
- testNewItemsOther
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
dd4617d368
Fix findFromUser, testFindAllFromUserWithParams, testFindAllFromUser
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
5a12e50cca
Fix testFindForUserByGUIDHash
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
WENDLING NICOLAS
890b8fa1df
✅ Fix FeedControllerTest tests
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
2c59331316
Fix testNewest
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
306f97d656
Fix tests testFindAllInFolderAfterHideRead, testFindAllInFolderAfter, testFindAllInFeedAfterHideRead, testFindAllInFeedAfter
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
6775fe541e
Fix testFindAllItemsStarredSearch, testFindAllItemsStarred, testFindAllItemsUnread
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
e7ec222c1d
Fix testFindAllItemsInvalid, testFindAllAfterInvalid, testFindAllAfterStarred, testFindAllAfterUnread
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
d6b32cf674
fix test findAllFeed
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
d314e8b495
Fix test findAllFeedSearch and findAllFeedHideRead
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
f59fe96105
Fix test findAllFolderIdNull and findAllFolderHideRead
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
319b15a655
Fix test findAllFolderHideReadInvertOrder
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
8b51ee583e
Fix test FindAllFolderSearchId
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Aurélien
818736c2be
fix test readAll
...
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
fc8670f5be
✅ ItemMapperTest: add tests for findAllSharedAfter
...
- testFindAllSharedAfter
- testFindAllSharedAfterHideRead
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
cbe1ca6b4d
✅ ItemMapperTest: test findAllSharedWithUser func
...
- testFindAllSharedWithUser
- testFindAllSharedWithUserHideRead
- testFindAllSharedWithUserSearch
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
5c359a8d42
✅ ItemServiceTest: test share functions
...
- testFindAllShared
- testFindAllNewShared
- testSharedCount
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
14c6685344
✅ ItemServiceTest: test share function
...
- testShare
- testShareDoesNotExist
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
46cc069863
✅ ItemControllerTest: added share tests (WIP)
...
- testIndexForShared
- testNewItemShared
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
91c034c72f
✅ Fix ItemController share tests
...
- testShare
- testShareDoesNotExist
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00
Marco Nassabain
89d7293e84
✅ Add tests: testFindAllShared, testShare + ...
...
+ testShareDoesNotExist
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com >
2021-04-08 22:31:21 +02:00