mirror of
https://github.com/chylex/Nextcloud-Desktop.git
synced 2024-11-26 22:42:44 +01:00
611f633ba8
On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
160 lines
6.4 KiB
C++
160 lines
6.4 KiB
C++
/*
|
|
* This software is in the public domain, furnished "as is", without technical
|
|
* support, and with no warranty, express or implied, as to its usefulness for
|
|
* any purpose.
|
|
*
|
|
*/
|
|
|
|
#include <qglobal.h>
|
|
#if QT_VERSION >= QT_VERSION_CHECK(5, 1, 0)
|
|
#include <QTemporaryDir>
|
|
#endif
|
|
#include <QtTest>
|
|
|
|
#include "utility.h"
|
|
#include "folderman.h"
|
|
#include "account.h"
|
|
#include "accountstate.h"
|
|
#include "configfile.h"
|
|
#include "creds/httpcredentials.h"
|
|
|
|
using namespace OCC;
|
|
|
|
class HttpCredentialsTest : public HttpCredentials {
|
|
public:
|
|
HttpCredentialsTest(const QString& user, const QString& password)
|
|
: HttpCredentials(user, password)
|
|
{}
|
|
|
|
void askFromUser() Q_DECL_OVERRIDE {
|
|
|
|
}
|
|
};
|
|
|
|
static FolderDefinition folderDefinition(const QString &path) {
|
|
FolderDefinition d;
|
|
d.localPath = path;
|
|
d.targetPath = path;
|
|
d.alias = path;
|
|
return d;
|
|
}
|
|
|
|
|
|
class TestFolderMan: public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
FolderMan _fm;
|
|
|
|
private slots:
|
|
void testCheckPathValidityForNewFolder()
|
|
{
|
|
#if QT_VERSION >= QT_VERSION_CHECK(5, 1, 0)
|
|
QTemporaryDir dir;
|
|
ConfigFile::setConfDir(dir.path()); // we don't want to pollute the user's config file
|
|
QVERIFY(dir.isValid());
|
|
QDir dir2(dir.path());
|
|
QVERIFY(dir2.mkpath("sub/ownCloud1/folder/f"));
|
|
QVERIFY(dir2.mkpath("ownCloud2"));
|
|
QVERIFY(dir2.mkpath("sub/free"));
|
|
QVERIFY(dir2.mkpath("free2/sub"));
|
|
{
|
|
QFile f(dir.path() + "/sub/file.txt");
|
|
f.open(QFile::WriteOnly);
|
|
f.write("hello");
|
|
}
|
|
QString dirPath = dir2.canonicalPath();
|
|
|
|
AccountPtr account = Account::create();
|
|
QUrl url("http://example.de");
|
|
HttpCredentialsTest *cred = new HttpCredentialsTest("testuser", "secret");
|
|
account->setCredentials(cred);
|
|
account->setUrl( url );
|
|
|
|
AccountStatePtr newAccountState(new AccountState(account));
|
|
FolderMan *folderman = FolderMan::instance();
|
|
QCOMPARE(folderman, &_fm);
|
|
QVERIFY(folderman->addFolder(newAccountState.data(), folderDefinition(dirPath + "/sub/ownCloud1")));
|
|
QVERIFY(folderman->addFolder(newAccountState.data(), folderDefinition(dirPath + "/ownCloud2")));
|
|
|
|
|
|
// those should be allowed
|
|
// QString FolderMan::checkPathValidityForNewFolder(const QString& path, const QUrl &serverUrl, bool forNewDirectory)
|
|
|
|
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/free"), QString());
|
|
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/free2/"), QString());
|
|
// Not an existing directory -> Ok
|
|
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/bliblablu"), QString());
|
|
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/free/bliblablu"), QString());
|
|
// QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/bliblablu/some/more"), QString());
|
|
|
|
// A file -> Error
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/file.txt").isNull());
|
|
|
|
// There are folders configured in those folders, url needs to be taken into account: -> ERROR
|
|
QUrl url2(url);
|
|
const QString user = account->credentials()->user();
|
|
url2.setUserName(user);
|
|
|
|
// The following both fail because they refer to the same account (user and url)
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1", url2).isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/ownCloud2/", url2).isNull());
|
|
|
|
// Now it will work because the account is different
|
|
QUrl url3("http://anotherexample.org");
|
|
url3.setUserName("dummy");
|
|
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1", url3), QString());
|
|
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/ownCloud2/", url3), QString());
|
|
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath).isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/folder").isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/folder/f").isNull());
|
|
|
|
|
|
// make a bunch of links
|
|
QVERIFY(QFile::link(dirPath + "/sub/free", dirPath + "/link1"));
|
|
QVERIFY(QFile::link(dirPath + "/sub", dirPath + "/link2"));
|
|
QVERIFY(QFile::link(dirPath + "/sub/ownCloud1", dirPath + "/link3"));
|
|
QVERIFY(QFile::link(dirPath + "/sub/ownCloud1/folder", dirPath + "/link4"));
|
|
|
|
// Ok
|
|
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link1").isNull());
|
|
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link2/free").isNull());
|
|
|
|
// Not Ok
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link2").isNull());
|
|
|
|
// link 3 points to an existing sync folder. To make it fail, the account must be the same
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link3", url2).isNull());
|
|
// while with a different account, this is fine
|
|
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/link3", url3), QString());
|
|
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link4").isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link3/folder").isNull());
|
|
|
|
|
|
// test some non existing sub path (error)
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/some/sub/path").isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/ownCloud2/blublu").isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/folder/g/h").isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link3/folder/neu_folder").isNull());
|
|
|
|
// Subfolder of links
|
|
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link1/subfolder").isNull());
|
|
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link2/free/subfolder").isNull());
|
|
|
|
// Invalid paths
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder("").isNull());
|
|
|
|
// Should not have the rights
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder("/").isNull());
|
|
QVERIFY(!folderman->checkPathValidityForNewFolder("/usr/bin/somefolder").isNull());
|
|
#else
|
|
QSKIP("Test not supported with Qt4", SkipSingle);
|
|
#endif
|
|
}
|
|
};
|
|
|
|
QTEST_APPLESS_MAIN(TestFolderMan)
|
|
#include "testfolderman.moc"
|