7715583b14
Correctly use indexOf
2021-08-23 09:40:26 +02:00
9ffa7bcd4d
Add workaround for issue discovered in https://github.com/owncloud/core/pull/38304
2021-08-11 17:13:44 +00:00
3bc026a557
Make findBestChecksum case insensitive
...
Especially the casing of ADLER32 did not match the server.
2021-08-11 17:13:44 +00:00
dbd061c44b
l10n: Replace apostrophe with double quotation. Remove double space and sort sentence.
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-08-03 15:00:53 +03:00
8122c63ebc
Revert Added config parameter that allows to bypass checksum validation failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-28 07:57:10 +00:00
dc72686ab3
Allow download with mismatched checksum if a config option is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-10 13:39:11 +03:00
c57eff6fd8
Please the clang-tidy overlord
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 11:01:53 +01:00
1aa1ea7bea
Return empty string instead of 1 as adler32 checksum for empty files
2020-12-15 10:59:18 +01:00
23f7c51f70
Print checksum on mismatch
2020-12-15 10:59:18 +01:00
c1a91e91e7
Use the servers checksum type by default
2020-12-15 10:59:16 +01:00
c9476a11f4
Checksums: Explicitly close file before reporting result
...
To ensure it's no longer open when the finished signal fires.
2020-12-15 10:59:00 +01:00
bade7aedc6
Checksums: Add back QIODevice api
...
Because the winvfs plugin needs it. But be more careful about the
device's lifetime this time.
2020-12-15 10:58:55 +01:00
ea829f96ca
Download: Don't trigger too many concurrent hash computations
...
Previously the job would only become "active" when the downloads
started. That meant that arbitrarily many hash computations could be
queued at the same time.
Since the the file was opened during future creation this could lead to
a "too many open files" problem if there were lots of new-new conflicts.
To change this:
- Make PropagateDownload become active when computing a hash
asynchronously.
- Make the computation future open the file only once it gets run. This
will make it less likely for this problem to occur even if thousands
of these futures are queued.
For #7372
2020-12-15 10:58:55 +01:00
c9dbe46542
Checksums: Fix crash due to threading issue
...
The checksum computation thread was potentially using a QFile that was
deleted in the gui thread.
For #7368
2020-12-15 10:58:54 +01:00
a5264f7740
Checksums: Make file ownership more explicit
2020-12-15 10:58:24 +01:00
22e08cf6ad
Checksums: Work on QIODevice*s
...
Needed for cfapi where we want to feed data through a custom device
which retrieves data from the windows api.
2020-12-15 10:58:21 +01:00
d81ccbb0c1
Checksum: Add support for SHA256 and SHA3
...
In case, some day, the server also supports it
2020-12-15 10:58:05 +01:00
bf6e4174c8
Move the checksum related routine from FileSystem to checksum, where they belong
2020-12-15 10:58:05 +01:00
a73a1f3927
Use = default for trivial ctors and dtors
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-25 21:33:24 +02:00
dea6ebaa35
Use nullptr when appropriate
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-20 02:21:26 +02:00
c1189421c0
Use qEnvironmentVariableIsEmpty
...
clazy suggests that it is more efficient since it doesn't allocate.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2020-03-21 01:06:15 +01:00
a63d34f870
Prepend "nextcloud" for all logging categories
...
Thus making easier to exclude logging from kio, qt
and only enable "nextcloud.*"
2017-12-28 17:33:10 -02:00
480932a58a
Checksum: Ignore unkown OC-Checksum header when downloading...
...
And if there are several checksums, pick the "best" one.
The case of several checksum was reported in
https://github.com/nextcloud/client_theming/issues/213
2017-11-20 10:51:15 +01:00
a9761a8976
Use qEnvironmentVariable* instead of qgetenv when appropriate
...
Now that we use Qt5, we should do that. It is slightly more efficient
and declares the intent.
(Modified using clazy)
2017-10-19 13:57:49 +02:00
3f7b3ca962
Checksums: Improve logging and add global disable #5017
2017-10-13 13:08:20 +02:00
ff4213b59f
Use the Qt5 connection syntax (automated with clazy)
...
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.
This commit only contains calls that were automatically converted with clazy.
2017-09-21 14:05:39 +02:00
a1f1775d15
Move SyncJournalDB to src/common
2017-09-18 14:00:52 +02:00
Hannah von Reth