Commit Graph
17214 Commits
Author SHA1 Message Date
Hannah von RethandKevin Ottens a0d81df21e UnitTests: Set a CookiesJar in FakeQNAM 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 7e91166d7a CMake: Remove krazy2 support, we now use clazy 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 7fdb842ed2 VFS: Prevent duplicated navigation panel icon
Issue: #7748
2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 6c2c544713 Log HTTP requests and responses
Issue: #7873
2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens c92f70d4ff Beautify flags 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 2b95f919ad Fix 3aeca58b316363dc12ad4b392750fc57e7a2965a 2020-12-15 10:59:13 +01:00
Hannah von RethandKevin Ottens 6d2526a67d Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens b492b69dfd Fix 150a5b4d06600d140ddf05383fb74cda6ae6e941 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens 6fde08d9f7 Fix crash on settings migration
Fixes: #7878
2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens fa87b899fb Fix usage of QMessageBox
Fixes: #7874
2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens 11b9e3fa61 Fix order of pluginkit commands and modernise 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens aaca3e7ce5 Use separate loggin category for upload v1 and ng 2020-12-15 10:59:12 +01:00
Hannah von RethandKevin Ottens eed4ffb823 Wizard: Raise own window
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
2020-12-15 10:59:11 +01:00
Hannah von RethandKevin Ottens baff0a6986 VFS Dialog: Don't enable on close button clicked
Issue: #7710
2020-12-15 10:59:11 +01:00
Hannah von RethandKevin Ottens 1a1035d516 Remove unused struct 2020-12-15 10:59:11 +01:00
Hannah von RethandKevin Ottens b15c308170 Remvoe now unneeded SyncRunFileLog::directionToStr 2020-12-15 10:59:11 +01:00
Hannah von RethandKevin Ottens 4681421b62 Remvoe now unneeded SyncRunFileLog::instructionToStr 2020-12-15 10:59:11 +01:00
Hannah von RethandKevin Ottens a1d8010eae Cleanup moc_csync.cpp include 2020-12-15 10:59:11 +01:00
Hannah von RethandKevin Ottens 4d615c31da Rename csync_instructions_e -> SyncInsturctions 2020-12-15 10:59:10 +01:00
Hannah von RethandKevin Ottens 8cbdb4451b Remove now unneede csync_instruction_str 2020-12-15 10:59:10 +01:00
Hannah von RethandKevin Ottens caa04f6adb Make bit flags better readable 2020-12-15 10:59:10 +01:00
Hannah von RethandKevin Ottens c803292829 Use Q_ENUM_NS for PinState 2020-12-15 10:59:10 +01:00
Hannah von RethandKevin Ottens 86789a1280 Test: Disable parallelism to ensure serial execution 2020-12-15 10:59:10 +01:00
Hannah von RethandKevin Ottens 38c4d5a406 Cookies: Do set cookies in DetermineAuthTypeJob too
As we don't support cookie based authentication anymore we can provide cookies here.
This fixes issues with loadbalancers access policy managers.
2020-12-15 10:59:10 +01:00
Hannah von RethandKevin Ottens f073997aee Cookies: Don't override cookies with outdated values
This code was actually not breaking most cookie handling by accident.
As the raw cookies where not split properly we added cookies with values like
"key: val; key2 = val2; key3 = val3"
When the code was corrected we overwrote the newer values in the jar with
the old ones from a request.
2020-12-15 10:59:09 +01:00
Olivier GoffartandKevin Ottens 317d3735d7 SocketAPI: fix status after a failure to move
Issue #7759
2020-12-15 10:59:09 +01:00
Hannah von RethandKevin Ottens 734e49765d Test: Fix testMovedWithError for vfs mode 2020-12-15 10:59:09 +01:00
Hannah von RethandKevin Ottens 85aefa4232 Sync: Fix handling of virtual files in error state
Issue: #7799
2020-12-15 10:59:09 +01:00
Hannah von RethandKevin Ottens 7644be576f Test: Add test for vfs failed move crash 2020-12-15 10:59:09 +01:00
Hannah von RethandKevin Ottens bcceb5c33d [Gui] Implement raiseDialog on Windows
Issue: #7774
2020-12-15 10:59:09 +01:00
Hannah von RethandKevin Ottens 12ae1e97c6 [SocketApi] Ensure listener still exists 2020-12-15 10:59:08 +01:00
Hannah von RethandKevin Ottens 868b05f25b Improve logging of issues during plugin loading
If the plugin could not be loaded the client calls qFatal
Make the loading warnings critical so they get printed before we crash
2020-12-15 10:59:08 +01:00
Hannah von RethandKevin Ottens d63d4cdf62 Don't insert items into the folder model if selectiveSync is not supported
This fixes an assertion in FolderStatusModel::SubFolderInfo::resetSubs
rowCount reported 0 but we actually had items in the model
2020-12-15 10:59:08 +01:00
Hannah von RethandKevin Ottens 9176afe263 Make sure all cases are handled 2020-12-15 10:59:08 +01:00
Hannah von RethandKevin Ottens 9b0788bdf8 [Gui] Fix vfs dialog not showing on Windows 2020-12-15 10:59:08 +01:00
Hannah von RethandKevin Ottens a9728b527a Remove unused defines 2020-12-15 10:59:08 +01:00
Hannah von RethandKevin Ottens 1dd01477c5 Use Q_ENUM_NS to pretty print csync enums 2020-12-15 10:59:07 +01:00
Hannah von RethandKevin Ottens 5927beb08d Fix potential null pointer access
https://sentry.io/organizations/owncloud/issues/1529161263/events/02509984b5ca42ffb3960d9c9e161414/?project=79001&statsPeriod=14d
2020-12-15 10:59:07 +01:00
Olivier GoffartandKevin Ottens b7193e6a0e Folder Wizard: warn when adding a folder which is the parent of a sync'ed folder
issue #7741
2020-12-15 10:59:07 +01:00
Hannah von RethandKevin Ottens 13c9d6431d Fix expansion of tree view on newly added accounts
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a

I removed a few lines of code there which are already part of fetchMore()

Fixes: #7336
2020-12-15 10:59:07 +01:00
Hannah von RethandKevin Ottens fdc3b7c8da [Wizard] Make vfs dialog blocking
Calling the callback after the receiver was deleted caused a crash
Fixes: #7709
Fixes: #7711
2020-12-15 10:59:07 +01:00
Olivier GoffartandKevin Ottens a6a0e361c1 fixup test 2020-12-15 10:59:07 +01:00
Olivier GoffartandKevin Ottens 9f2c67dca9 Tests: add a couple of move tests
This was an attempt to reproduce #7722, but this actually does not
reproduce it
2020-12-15 10:59:07 +01:00
Hannah von RethandKevin Ottens 106a35d242 [SSL] Print warning only if something changed 2020-12-15 10:59:06 +01:00
Hannah von RethandKevin Ottens ba87fc9e78 [SSL] Properly restore user accepted certificats 2020-12-15 10:59:06 +01:00
Hannah von RethandKevin Ottens c8dd333e31 [Sanity] Remove old ifdef 2020-12-15 10:59:06 +01:00
Hannah von RethandKevin Ottens 9564e5e92e Fix saving of cookies
Fixes: #7700
2020-12-15 10:59:06 +01:00
Hannah von RethandKevin Ottens 3a3ccb0834 Don't hardcode PLUGINDIR 2020-12-15 10:59:06 +01:00
Olivier GoffartandKevin Ottens 7fd4a280f0 Make PluginFactory virtual to silent -Wnon-virtual-dtor warning
This is not necessary, but it also shouldn't hurt.
2020-12-15 10:59:06 +01:00
Olivier GoffartandKevin Ottens 1c10fceacc SyncEngine: no need to use QAtomicInt
This was done because the propagator jobs where running in a thread a long
time ago, but this is no longer the case.

(Also QAtomicInt::load is marked as deprecated now)
2020-12-15 10:59:05 +01:00