chylex
d2e5094d13
Revert "Merge pull request #3057 from nextcloud/bugfix/vfs-windows-lnk-files-freeze-issue"
2022-02-07 01:17:05 +01:00
alex-z
4584e8fa01
Remove Temporary solution for file restoration issue due to failing to set the data-fingerprint.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-28 08:33:47 +00:00
Felix Weilbach
68cb6a4d4e
Only use basic authentication if needed
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-19 07:27:27 +00:00
Felix Weilbach
b27eb606ed
Don't log encryption data in release mode
...
We deliver our builds to users with debug logging enabled to have an
easier time finding problems. However, logging all the encryption data
in this loop is too much and should not be done in release mode.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-30 10:23:19 +00:00
Matthieu Gallien
5dccbbf343
prevent infinte recursion when closing a websocket in case of SSL errors
...
the slots connected to the web socket can be called even during close
and lead to infinite calls to close -> error slot -> close -> ...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-07 12:24:10 +02:00
allexzander
9492defbe2
Use separate arguments for a remote root and do not use dav or webdav in the server's URL
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-23 15:11:44 +00:00
Felix Weilbach
1e28185ee9
Enforce fetching of user id
...
With the change of commit 3e61bdc431
and
the relase of v3.3.0 users that had their email address used as login
are not able to login anymore. The dav_user should be empty if users
tried to create a account in the meantime. Therefore we fetch the user
id in the case dav_user (and then Account::_davUser) is empty. We then
store the user id in dav_user.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 16:43:11 +00:00
Matthieu Gallien
391935c90f
prevent crash in Accont::davPath without credentials
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-29 08:27:53 +00:00
Matthieu Gallien
c40d276770
remove dead code around overriding dav path in URL
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-28 12:12:17 +02:00
Matthieu Gallien
77433f7e1d
in wizard always use the correct way to get dav path
...
fixes listing being incorrect when using dav endpoint
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-28 09:45:49 +00:00
allexzander
8122c63ebc
Revert Added config parameter that allows to bypass checksum validation failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-28 07:57:10 +00:00
Felix Weilbach
3e61bdc431
Use dav instead of webdav
...
Fixes #3342
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-16 12:42:02 +00:00
Felix Weilbach
efaccbd6fd
Show main dialog as normal window if tray icons not available
...
Fixes #3307
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-12 14:10:26 +00:00
Matthieu Gallien
2ee26bbd59
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-12 14:31:19 +02:00
Matthieu Gallien
7c68408ee1
only compile xattr virtual files backend for linux platform (not unices)
...
for a reason a mac os platform specific file is missing and before xattr
plugin was compiled only for linux
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-12 14:10:54 +02:00
Matthieu Gallien
d2f2e3305a
avoid being stuck trying to create placeholder for existing file
...
id sync db think a file is cirtual (empty placeholder) but file system
has a real file (non empty file) once the server has a modified version
we can no longer update it
state of file on disk takes precedence over sync DB to allow recovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-09 12:37:47 +00:00
Matthieu Gallien
8ad6f89fed
bring back dynamic load of VFS plugins
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-08 08:11:17 +00:00
Matthieu Gallien
c123edb173
address review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-06 14:16:43 +00:00
Matthieu Gallien
4016c2fab0
avoid error when doing hydration when data socket is closed too early
...
when data is received, if we close the socket they cannot be read
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-06 14:16:43 +00:00
Hannah von Reth
e7e218d8e6
Improve the error message returned by updateMetadata
...
Also properly handle the case the the file can't be converted to a placeholder
as it is locked
2021-07-06 14:03:53 +00:00
Matthieu Gallien
8f5b88acd5
improve error message in case of trailing space in directory name
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-02 10:50:31 +00:00
Matthieu Gallien
746072e95d
fix all usage of _com_error(cfExecuteresult).ErrorMessage()
...
_com_error(cfExecuteresult).ErrorMessage() calls should be translated to
QString before use with qDebug and related logging facilities
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-02 11:19:04 +02:00
Matthieu Gallien
2bc72592a0
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-01 14:40:25 +02:00
Matthieu Gallien
698d5f19ba
download server public key and check user certificate against it
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-01 14:07:27 +02:00
allexzander
99f6e82290
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
6ce5279b6c
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
22eba41cb8
Do not process non-directories and non-virtual files. Wipe empty online-only folder based on its pinState.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
c5982143aa
Refactoring.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
48aefc1983
Fix VFS crash and false conflict on local new.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:20 +03:00
Felix Weilbach
c9715db720
Check if first is not empty
...
If it's not checked that first is empty, crashes may happen.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-30 06:57:41 +00:00
Felix Weilbach
2ee3ca02a4
Add unit test for move custom remote root
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-25 10:14:29 +00:00
Felix Weilbach
8376b99ec5
Allow to compile without QWebEngine
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Valdnet
3937595eef
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-17 12:18:00 +00:00
Felix Weilbach
c799dbdd61
Cfapi: Make sure no data is transfered after cancellation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-17 09:10:06 +00:00
Hannah von Reth
03182ea714
Use longWinPath in more places
2021-06-16 10:54:07 +00:00
Camila
f3c17c747a
Fix compiling warning: multiple definitions of stateOnlineImageSource in theme.h.
...
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
allexzander
a3d12a616b
Add error message to GUI.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-15 14:33:45 +03:00
allexzander
6312f6ddde
Wipe empty folder when moving a VFS placeholder. Keep a folder if there are hydrated items inside.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-15 13:19:35 +03:00
Felix Weilbach
a89a84ff14
Mark placeholder in sync after updating the placeholder
...
Fixes #3403 #3082 #3391
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-14 13:40:26 +00:00
allexzander
dc72686ab3
Allow download with mismatched checksum if a config option is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-10 13:39:11 +03:00
allexzander
bb55232e8e
VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-08 09:25:43 +00:00
AJ Jordan
a51d0a14db
Improve error message
...
This one is more user-friendly and grammatically correct.
Signed-off-by: AJ Jordan <alex@strugee.net>
2021-06-03 11:25:47 +00:00
allexzander
bf39f053c4
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-01 13:51:02 +00:00
allexzander
a80c58f367
Bugfix. Crash when printing OpenSSL decryption errors with no e2ee mnemonic.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-01 13:51:02 +00:00
Matthieu Gallien
7fb09a8163
check e2ee public key against private one
...
should ensure we have matching private/public keys
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-27 07:26:48 +00:00
Camila
671b099c98
Check if the user is connected and if the server supports user status.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Felix Weilbach
78f1943d76
Add a key value store to the sync journal
...
This key value store should help to keep track of important events,
that can not be store in the logs, because the logs are deleted too fast.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-19 09:04:43 +02:00
Felix Weilbach
32b7e62359
Warn user if using e2ee and vfs together
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-18 11:50:18 +00:00
allexzander
76be5dce73
Add remote folder prefix for renaming in a non-root local folder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-05-17 12:19:58 +00:00
Felix Weilbach
c3a2587a91
Remove unnecessary cfapi logging statements
...
For big files that can add a lot lines to the log files.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-12 08:49:13 +00:00