chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2024-11-07 22:42:47 +01:00
Code
16,676 Commits 4 Branches 173 Tags 91 MiB
v3.3.0-rc2
Commit Graph

16676 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nextcloud bot
fe1d287c62
[tx-robot] updated from transifex 2020-05-31 03:24:59 +00:00
Nextcloud bot
b5ffad192c
[tx-robot] updated from transifex 2020-05-30 03:24:55 +00:00
Michael Schuster
a80d0b0f0f
Merge pull request #1940 from nextcloud/traywindow-listview-actions 
Implemented share functionality in tray window and changed buttons
 2020-05-29 21:14:21 +02:00
Michael Schuster
6ec69a700d
ShareDialog: Pointer cosmetics 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-05-29 20:57:52 +02:00
Michael Schuster
ae0ea12501
Merge branch 'master' into traywindow-listview-actions 2020-05-29 19:08:21 +02:00
Michael Schuster
ba4d109315
ShareDialog: Add further checks for the _manager member ptr 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-05-29 18:29:47 +02:00
Michael Schuster
efdef8535f
ShareDialog: Fix crash, properly init member pointers 
_manager ptr only got initialized in the constructor when sharingPossible was set to true

Changes:
- Move member ptr inits from constructor to the header file's class definition
- Init _manager: set to nullptr too
- Add check for _manager to avoid crash in showSharingUi()

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-05-29 18:12:36 +02:00
Nextcloud bot
4620734194
[tx-robot] updated from transifex 2020-05-29 03:26:32 +00:00
Kevin Ottens
53c3eb8fe5 Try to fix the rebase action 
I think I got the if clause wrong regarding limiting the command only to
member users. Let's move this out of the way for now.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-28 19:27:12 +02:00
Kevin Ottens
08cc4e1967 Remove the last redundant void arg I left behind 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-28 18:57:20 +02:00
Kevin Ottens
8d823baede Add a GitHub Action to easily rebase PRs 
This will make it easier to have a semi-linear commit history

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-28 18:12:27 +02:00
Nextcloud bot
300fb90c0b
[tx-robot] updated from transifex 2020-05-28 03:30:34 +00:00
Michael Schuster
a2fd79bcf7
Merge pull request #2035 from nextcloud/add_clang_tidy_pipeline_to_drone 
Add clang tidy pipeline to drone
 2020-05-27 19:14:08 +02:00
Kevin Ottens
2b4ea340e2 Run clang-tidy from the 5.12-clang pipeline 
This should pass, with the minimal .clang-tidy which was provided. Other
PRs should be done to enable further checks.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-27 18:44:25 +02:00
Kevin Ottens
7f7dd6bc76 Upgrade to the latest client image 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-27 16:43:24 +02:00
Michael Schuster
c0a9f60d0d
Merge pull request #2032 from nextcloud/insulate_testutility_from_user_settings 
testLaunchOnStartup shouldn't fail on dev setup
 2020-05-27 16:10:57 +02:00
Michael Schuster
ad8075a30b
Merge pull request #2023 from nextcloud/use_return_braced_init_list 
Use the return braced init list pattern
 2020-05-27 16:08:19 +02:00
Kevin Ottens
b39a14bf2b testLaunchOnStartup shouldn't fail on dev setup 
This test was failing locally for me. Indeed, through QStandardPaths it
was finding the user settings of my production client and not having the
initial state it expected. Using QStandardPaths test mode then it starts
from a clean slate every time.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-27 15:11:25 +02:00
Kevin Ottens
6e62c8b430 Use the return braced init list pattern 
This way we avoid repeating the return type while it is already known.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-27 14:36:07 +02:00
Michael Schuster
ccc409dbd0
Merge pull request #2024 from nextcloud/use_raw_string_literals 
Use raw string literals when appropriate
 2020-05-27 05:54:54 +02:00
Nextcloud bot
606aa131e7
[tx-robot] updated from transifex 2020-05-27 03:26:35 +00:00
Michael Schuster
044a4bf6b5
Merge pull request #2021 from nextcloud/use_default_for_trivial_ctor_and_dtor 
Use = default for trivial ctors and dtors
 2020-05-27 05:17:24 +02:00
Michael Schuster
b2b0e8f4e4
Merge pull request #2020 from nextcloud/use_make_unique 
Use make_unique when appropriate
 2020-05-27 05:10:41 +02:00
Michael Schuster
4b2684cf4a
Merge pull request #2019 from nextcloud/remove_redundant_void_argument 
Remove redundant void argument list
 2020-05-27 05:07:52 +02:00
Michael Schuster
21c6dd50a2
Merge pull request #2018 from nextcloud/use_using 
Use using instead of typedef
 2020-05-27 05:04:55 +02:00
Michael Schuster
7a102feca8
Merge pull request #2017 from nextcloud/remove_redundant_initializer 
Remove redundant initializer
 2020-05-27 05:01:34 +02:00
Kevin Ottens
f5350db078 Use raw string literals when appropriate 
This is especially nice for Windows paths.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-26 20:13:51 +02:00
Kevin Ottens
a73a1f3927 Use = default for trivial ctors and dtors 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 21:33:24 +02:00
Kevin Ottens
9e20a0fecf Use make_unique when appropriate 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 21:08:43 +02:00
Kevin Ottens
65e6c445e5 Remove redundant void argument list 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 20:32:55 +02:00
Kevin Ottens
0bc4dcd8a5 Use using instead of typedef 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 20:29:44 +02:00
Kevin Ottens
86b1821251 Remove redundant initializer 
This is the same value than the initializer value in the header, no need
to repeat it.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 20:12:09 +02:00
Kevin Ottens
b579b49a5c Get rid of redundant parentheses 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 20:03:01 +02:00
Nextcloud bot
4825c472f6
[tx-robot] updated from transifex 2020-05-25 03:23:39 +00:00
Nextcloud bot
6a207d19e7
[tx-robot] updated from transifex 2020-05-24 03:24:41 +00:00
Michael Schuster
d4563e9196
Merge pull request #2006 from nextcloud/sbeyer-improve-wizard-url-field 
Improve URL input field in Wizard
 2020-05-23 20:06:21 +02:00
Stephan Beyer
375fcb8e14 Replace "https://..." hint by "https://host:port" 
The new hint is a little more verbose and provides more information
than the old one.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-23 18:32:18 +02:00
Stephan Beyer
f46ce2ce98 Show URL placeholder hint in wizard 
In owncloudsetupnocredspage.ui, the URL input field leUrl has a
placeholder text saying "https://..." which is a very useful hint
for the user.  However, in the OwncloudSetupPage constructor, the
placeholer text is overwritten by the return string of the theme's
wizardUrlHint() method.  The NextcloudTheme class does not override
this virtual method, so an empty string is used.

To make available the "https://..." hint, it is moved from the
UI file to NextcloudTheme::wizardUrlHint().  Note that, if a
theme is used which does not allow a custom server URL, the
placeholder text is now empty.  This makes sense because the
input field is disabled in that case.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-23 18:32:15 +02:00
Stephan Beyer
deff3230f5 Change vertical size policy of URL input field in wizard 
The input field for the nextcloud server URL is vertically too
big (because of the icon next to it in the same horizontal layout).
This commit solves this issue by changing its vertical size policy
from Ignored to Fixed.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-23 18:32:10 +02:00
Nextcloud bot
7b2ef2f41e
[tx-robot] updated from transifex 2020-05-23 03:27:12 +00:00
István Váradi
77c2048ff6
Merge pull request #2003 from ivaradi/debian-qt512 
Do not build master for distributions without Qt 5.12 or later
 2020-05-22 18:46:30 +02:00
Nextcloud bot
d53121c6ad
[tx-robot] updated from transifex 2020-05-22 03:28:53 +00:00
István Váradi
81682b4cbe Do not build master for distributions without Qt 5.12 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2020-05-21 21:01:57 +02:00
Kevin Ottens
89316ced9e
Merge pull request #1987 from sbeyer/fix-leaks 
Fix a few leaks
 2020-05-21 17:12:04 +02:00
Kevin Ottens
c3ad79ba91
Merge pull request #2001 from nextcloud/sbeyer-member-tidy 
Use default member initialization
 2020-05-21 17:10:48 +02:00
Nextcloud bot
9d10671cea
[tx-robot] updated from transifex 2020-05-21 03:28:21 +00:00
Stephan Beyer
faeb233a74 Use default member initializers in OCC::FolderStatusModel sub-structs 
This allows to remove their explicit default constructor definitions.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:45:13 +02:00
Stephan Beyer
04a24c14a8 Use default member initializers in OCC::SyncJournalErrorBlacklistRecord 
This allows to remove its explicit default constructor definition.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:41:33 +02:00
Stephan Beyer
3015ea5715 Use default member initializers in OCC::SyncJournalDb sub-structs 
This allows to remove their explicit default constructor definitions.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:32:16 +02:00
Stephan Beyer
f275640343 Fix leak in OCC::AccountManager stub for FolderManTest 
We simply use a static QObject using Q_GLOBAL_STATIC()
instead of allocating a leaking QObject on the heap.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:22:15 +02:00