chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2024-09-27 21:42:47 +02:00
Code
16,676 Commits 4 Branches 173 Tags 91 MiB
v3.3.0-rc2
Commit Graph

7999 Commits

Author SHA1 Message Date
Felix Weilbach
c799dbdd61 Cfapi: Make sure no data is transfered after cancellation 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-17 09:10:06 +00:00
Hannah von Reth
22c634935b Run expansive assert only in dev builds 2021-06-16 10:54:07 +00:00
Hannah von Reth
03182ea714 Use longWinPath in more places 2021-06-16 10:54:07 +00:00
Hannah von Reth
d014293f6d Ensure pathtoUNC is called with an absolute path 2021-06-16 10:54:06 +00:00
Camila
7ddc4ca170 Remove extra RowLayout. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
449fda16e1 Fix QML Warning: ReferenceError: PopupMenu is not defined. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
f3c17c747a Fix compiling warning: multiple definitions of stateOnlineImageSource in theme.h. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
19e581657d Fix QML warning: Cannot specify left, right... anchors for items inside Row. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
5585f61cc0 Fix QML warning: Detected anchors on an item that is managed by a layout. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
c8edb11228 Fix QML warning: Accessible must be attached to an Item. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Felix Weilbach
7850551cad Start macOS app bundle name with uppercase letter 
It's a convention on macOS that app bundle names start with an uppercase
letter. Also this aligns the app name with Windows and Linux.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-15 12:19:55 +00:00
allexzander
a3d12a616b Add error message to GUI. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-15 14:33:45 +03:00
allexzander
6312f6ddde Wipe empty folder when moving a VFS placeholder. Keep a folder if there are hydrated items inside. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-15 13:19:35 +03:00
Felix Weilbach
a89a84ff14 Mark placeholder in sync after updating the placeholder 
Fixes #3403 #3082 #3391

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-14 13:40:26 +00:00
Felix Weilbach
d4b0273792 Generate application png icons from svg icons 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-14 10:14:28 +00:00
Felix Weilbach
e7c65a71b8 Remove conditional logic for OEM.cmake 
This file is not used in Brander and in the desktop client and just
confused people.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-14 10:14:28 +00:00
allexzander
dc72686ab3 Allow download with mismatched checksum if a config option is set. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-10 13:39:11 +03:00
allexzander
d6ddf595f8 Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-08 09:25:43 +00:00
allexzander
5dd310c21c Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-08 09:25:43 +00:00
allexzander
b150de9106 Fix review comments. Also consider exclude.lst. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-08 09:25:43 +00:00
allexzander
bb55232e8e VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-08 09:25:43 +00:00
AJ Jordan
a51d0a14db Improve error message 
This one is more user-friendly and grammatically correct.

Signed-off-by: AJ Jordan <alex@strugee.net>
 2021-06-03 11:25:47 +00:00
allexzander
bf39f053c4 Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-01 13:51:02 +00:00
allexzander
a80c58f367 Bugfix. Crash when printing OpenSSL decryption errors with no e2ee mnemonic. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-01 13:51:02 +00:00
Felix Weilbach
03610cb706 Set button on QMessageBox before changing the text 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-27 07:39:50 +00:00
Matthieu Gallien
7fb09a8163 check e2ee public key against private one 
should ensure we have matching private/public keys

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-27 07:26:48 +00:00
Camila
f758157973 Fix aligment emoji + message on Windows. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
8d2264e027 Display the user status emoji separated from the message. 
It allows to align the emoji with the message.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
1cb7f63575 Remove signal refreshCurrentUserGui. 
Use only QML property bindings to refresh the UI.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
46f7cd3884 User property isConnected instead of a invokable. 
Remove unnecessary connection to refreshCurrentUserGui signal.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
1adde8d547 serverUserStatus => serverHasUserStatus. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
2caa9ccfc6 Add Q_UNREACHABLE() after switch statements in UserStatus. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
73da14040b Rename ServerUserStatusRole to ServerHasUserStatusRole. 
- serverHasUserStatus Q_PROPERTY is CONSTANT.
- Fix code style.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
828881d82a Do not display the folder status if there are no folders being synced. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
4326eb53ba Fix margins and sizes to align both avatar + user status displays. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
dc01b76066 Fix code style. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
93227ab08b Check if new value is different from the current one. 
In AccountState::setDesktopNotificationsAllowed.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
f7e9e31bc9 Rename isDesktopNotificationsAllowed property to desktopNotificationsAllowed. 
- User !== instead of !=.
- Fix code style.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
820e97cd9b Do not display the user status if there is no pre defined message. 
Display the server url instead.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
c793cbe593 Always display the server url in the drop down account menu. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
419595ce5e Use DesktopNotificationsAllowedRole to check if user is online. 
Rename ServerUserStatus to ServerUserStatusRole.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
bd65eee278 Remove unused methods in UserModel. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
671b099c98 Check if the user is connected and if the server supports user status. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
e3b96ddc85 Move stringToEnum and enumToString to an anonymous namespace. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
1f61d258bb Fix user status message alignment. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
rakekniven
793c211232
Merge branch 'master' into Valdnet-patch-3 2021-05-20 07:47:17 +02:00
Felix Weilbach
78f1943d76 Add a key value store to the sync journal 
This key value store should help to keep track of important events,
that can not be store in the logs, because the logs are deleted too fast.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-19 09:04:43 +02:00
Felix Weilbach
32b7e62359 Warn user if using e2ee and vfs together 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-18 11:50:18 +00:00
allexzander
76be5dce73 Add remote folder prefix for renaming in a non-root local folder. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-17 12:19:58 +00:00
Felix Weilbach
e2d0481c64 Add CMake option to enable address sanitizers 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-17 11:43:55 +00:00
Matthieu Gallien
89be02f8e7 upgrade SQLite3 to 3.35.5 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-17 09:48:15 +00:00
Valdnet
a3b2dc669c
One more apostrophe change 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-05-12 12:45:33 +02:00
Valdnet
dadddd7ea2 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-05-12 12:34:22 +02:00
Felix Weilbach
c3a2587a91 Remove unnecessary cfapi logging statements 
For big files that can add a lot lines to the log files.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-12 08:49:13 +00:00
allexzander
bbf11d7e7a Temporary! Windows. VFS. Block Virtual Files for partition root sync folders. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-11 18:53:35 +03:00
Matthieu Gallien
54d91cdd7b also update ownCloud years interval in copyright notice 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-10 10:29:22 +00:00
Matthieu Gallien
86dda5675f send OS name and version to auto updater to allow selective upgrades 
in order to be able to suuport legacy OS, also sends the OS name and
version

will be used to detect Windows 8.1 and similar legacy versions

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 09:32:09 +00:00
Hannah von Reth
17a1a630a4 Use the http logger with the unittests 
This allow better debugging of the tests

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von Reth
98655ef28b Fix warning by using qsizetype instead of size_t 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von Reth
ea3d78aecf Fix warning by using QByteArrayLiteral 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von Reth
e04c6abcd5 Fix placeholder detection for cfapi 
Fixes: #8326
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Hannah von Reth
adb56178b9 GetLastError() needs to be called when the error happens 
qDebug might clear it already

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
allexzander
d754bb7102 Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-06 06:17:36 +00:00
allexzander
ef89256d39 VFS. Allow dehydartion of readonly files. Preserve 'readonly' flag when creating a placeholder. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-06 06:17:36 +00:00
allexzander
19522210ac VFS. Display local file name clash error when syncing in VFS mode. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-05 17:34:59 +00:00
rakekniven
6d23e93d31
Changed copyright year to 2021 
Fix for #3258 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-05-05 13:37:31 +02:00
Felix Weilbach
aadee15008 Fallback to primary screen if screen under pointer not found 
Fixes #3252

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-05 11:56:46 +02:00
Matthieu Gallien
23ba193102 add missing call to tr to get a translated string 
Fix #3250

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-04 12:16:10 +02:00
Felix Weilbach
7112d2aa78 Push Notifications: Reconnect forever if capabilities allow it 
Fixes #3115

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-04 10:05:19 +02:00
Felix Weilbach
d21df33a50 Add missing copyright headers for push notifications 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-04 07:27:06 +00:00
rakekniven
33ef3a1d1e
Merge branch 'master' into rakekniven-patch-2 2021-04-30 14:38:23 +02:00
Valdnet
dc6518a4ee
l10n: Translation of ellipse 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-30 13:57:02 +02:00
rakekniven
0e12b0323e
No need to translate ellipsis 
Here another PR for the same code line as #3238 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-04-30 13:27:18 +02:00
Valdnet
f431649bad l10n: Change to an ellipsis 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-30 08:19:25 +00:00
allexzander
e72013fed1 Fix Felix's comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:21 +00:00
allexzander
19e2d70c53 Final corrections and refactoring. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:21 +00:00
allexzander
deb9ba89f0 Only show password option for email shares. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:21 +00:00
allexzander
526fa399dc Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
allexzander
c908183044 Use separate progress indicator for password and replace a button with it while running. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
allexzander
0072d39ca0 Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
allexzander
2d88fc6c99 Obey enforced password for share by email. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
Valdnet
8aedc74838 l10n: Delete space and change capital letter 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-28 11:41:06 +00:00
allexzander
e7e5542d3e Improve public link sharing UI. Fix UX issues. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-27 13:51:52 +03:00
yopito
14d61c5071 clang's variadic macro warnings: only for clang 
following settings of cmake/modules/Warnings.cmake

Signed-off-by: yopito <pierre.bourgin@free.fr>
 2021-04-26 13:22:41 +00:00
Felix Weilbach
9a88e38121 Call finish() if going to remove all files 
While investigating #3172, I discoverd that the sync will hang forever
if the user has deleted all files on the server. Calling the callback
resolves the problem.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-26 12:50:14 +00:00
Matthieu Gallien
419bd93dea when files get hydrated indirectly through pinning, sets correct state 
files that get downloaded not through an hydration request need to be
converted to placeholder

sets the expected state when converting them to placeholder files

 #3082

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-26 13:54:32 +02:00
Matthieu Gallien
929ae965ce prevent progress bar to appear after a download is finished with CfApi 
when using Cloud Filter API with enabled VFS on Windows, a progress bar
stays visible for some time after hydration is completed. Not updating a
last time the progress bar prevents that.

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-26 13:54:32 +02:00
Matthieu Gallien
97d785f1bb fix errors when calling CfRegisterSyncRoot by setting more fields 
sets a reasonable size of the StructSize members in the struct passed to
CfRegisterSyncRoot function

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-26 08:02:40 +00:00
Valdnet
796b4e4e72 l10n: Change to an ellipsis 
Reported on Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-22 07:40:15 +00:00
Matthieu Gallien
782a2fdf06 avoid an assert by delaying access to response timestamp when in error 
when canceling the sync of a big directory, I can get some network
request that are aborted before a Date reply header has been read

in this case we would always access
AbstractNetworkJob::responseTimestamp() and fire the assert even if we
know that the network reply has an error

delay the access to after the possible errors have been dealt with

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-20 17:42:17 +02:00
Felix Weilbach
275e46f0db Show progess indicator 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
c3fac23903 Don't delete note and expiration date on toggle 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
8711d5bf49 Don't use unnecessary layout element 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
2851528595 Show user/group note on share if already set 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
22a3b19e08 Add expire date to user and group share 
Fixes #3100

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
946a51e4c1 Add note to user and group share 
Fixes #3104

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Matthieu Gallien
20357ca7fa Revert "Add CMake option to enable address sanitizers" 
This reverts commit 3000e26640.

This was not intended for a direct push

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-19 17:54:09 +02:00
Felix Weilbach
3000e26640 Add CMake option to enable address sanitizers 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-19 15:38:59 +02:00
allexzander
d65c91ea36 Display VFS sync folder within the navigation panel on Windows. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-16 07:18:44 +00:00
Nicolas Fella
2548455f45 Copy FindSharedMimeInfo from ECM 
Instead of relying on ECM being installed.

We copy other stuff from ECM so be consistent.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-04-15 14:32:46 +00:00