392d3c257c
Discovery: Allow more HTTP error code to be treated as ignored dir
...
The original code from csync was stopping at any error.
But we have been whitelisting soeme http error code one by one
to ignore the directory instead of aborting the sync.
However, as there are more requests to continue the sync in case
of error, just ignore most HTTP errors
Issue #7586
2020-12-15 10:59:03 +01:00
43c7e32ee1
[libsync] Export verifyFileUnchanged
...
This fixes Windows builds that are broken since #7562 was merged
2020-12-15 10:59:03 +01:00
66f7b27121
VFS: Do not overwrite existing files by placeholder
...
For issue #7557 and #7556
Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
2020-12-15 10:59:03 +01:00
9807285abd
[Gui] Set proper hdpi attributes
2020-12-15 10:59:03 +01:00
fc0aeb53b1
Discovery: fix TestSyncVirtualFiles::testExtraFilesLocalDehydrated on windows
...
On windows we do a test to know if we should change the case of the files,
but that conflict with the test that checks if the file was still there
when the filename is actually the same. Which can happen with virtual files
as they have two representation (the one with and without suffix).
2020-12-15 10:59:02 +01:00
ca18bbc2ca
Test: Fix testsyncvirtualfiles test
...
Like previous commit, the failure was caused by two conflicting commits
2020-12-15 10:59:02 +01:00
ecd3de61f5
Fix build of tests.
...
Resulted from a conflict between two patches
2020-12-15 10:59:02 +01:00
4c4cbf0d97
Vfs: Lots of tests and corrections for suffix edge cases
...
Avoid or deal with problems that happen when suffixed files exist on the
server or suffix and non-suffixed files exist locally.
See #7350 , #7261 .
2020-12-15 10:59:02 +01:00
88f86a56b1
Discovery: Attempt to fix issue with windows VFS and new files
...
(or moved files)
As seen in the log of #7558 , a conflict may be issued by mistake.
See investigation in https://github.com/owncloud/client/issues/7558#issuecomment-547385362
This hopefully fix #7558
2020-12-15 10:59:02 +01:00
513b0c723c
Account Settings: change the color of info message from green to blue
...
To avoid confusion with the color of "success"
Issue #7403
2020-12-15 10:59:02 +01:00
4d7ed8f62c
Wizard: fix compilation warnings about unused variables
2020-12-15 10:59:01 +01:00
115a53134c
SyncEngine: Save a bit of memory by not keeping a set of all filename
...
This is only used for conflict files, so only save conflict files.
(The _seenFile was used for other things in 2.5, but not anymore)
2020-12-15 10:59:01 +01:00
83d743b66b
When moving is allowed but deleting is not, do not restore moved items
...
Issue #7293
2020-12-15 10:59:01 +01:00
ee611e6004
Restoration items should appear in the sync protocol
...
When an item is downloaded because it is restored, it shall be shown in the
sync protocol.
(It is also going to be shown in the not synchronized for a short while, but
that's fine)
2020-12-15 10:59:01 +01:00
cb38bb2b5e
Fix Upload of large (> 2GiB) files
...
Issue #7506
This is a regression introduced by the delta sync feature (as the chunk offset
changed from being the chunk number to be the byte offset, it needs to be a
qint64 now)
2020-12-15 10:59:01 +01:00
ee3279c904
Tests: Fail if the initial sync fails
2020-12-15 10:59:01 +01:00
9d422284af
Discovery: Distinguish readdir and closedir errors
2020-12-15 10:59:01 +01:00
390af4d41b
Tests: introduce ItemCompletedSpy to avoid a bit of code duplication
2020-12-15 10:59:00 +01:00
adbd3d869b
Fix warning about serverJob not being used
...
And fix a FIXME in the same time
2020-12-15 10:59:00 +01:00
89216daee6
Propagate dir: Never write the etag on remote mkdir #7481
...
It must always only be written once all children are successfully
propagated.
2020-12-15 10:59:00 +01:00
dc55617144
Ensure the url is complete before we validate it
...
Fixes : #6722
2020-12-15 10:59:00 +01:00
c9476a11f4
Checksums: Explicitly close file before reporting result
...
To ensure it's no longer open when the finished signal fires.
2020-12-15 10:59:00 +01:00
e91e1ca78f
Test: Disable local discovery parallelism in permission test
...
Adding parallelism broke the test because it depended on the order of
discovery.
2020-12-15 10:59:00 +01:00
e596b55977
Discovery: Change local job signal signatures
...
To make it more explicit that data a copy of the data is transfered
between threads. (though Qt will make a copy of the arguments anyway)
2020-12-15 10:58:59 +01:00
71f71b38f1
Discovery: local job shouldn't be parented
...
Since it'll be deleted by the thread pool.
2020-12-15 10:58:59 +01:00
53a217d4e4
Don't store pointer to local job
...
There were crashes in the QPointer assignment. Possibly the thread pool
is done with the job and deletes it before the assignment is done.
2020-12-15 10:58:59 +01:00
26b5e36351
Discovery: List local directories from thread #7456 #7439
2020-12-15 10:58:59 +01:00
09a0dbbf82
Reconcile: Sort already during discovery #7445
2020-12-15 10:58:59 +01:00
a5c6612883
ConnectionValidator: increase timeout to 57s #7456
...
When the gui thread blocks for several seconds it's possible for the
ConnectionValidator to timeout and decide that the account is
unreachable. It will then terminate all sync runs.
Increasing the timeout makes this less likely to happen. The tradeoff is
that real disconnects will not be detected as quickly.
This does not address the root cause but makes the symptom less likely
to appear.
2020-12-15 10:58:59 +01:00
41dc68f99c
Propagator: Delay job execution a bit #7439
2020-12-15 10:58:58 +01:00
e37e954720
Discovery: Remove level of indent around moves
...
No code changes.
2020-12-15 10:58:58 +01:00
28797baa39
Discovery: If a move is forbidden, restore the source
...
Previously the source was deleted (or attempted to be deleted), even if
the new location was not acceptable for upload. This could make data
unavilable on the server.
For #7410
2020-12-15 10:58:58 +01:00
c9d1037622
Propagation: Fix delete-before-rename bug #7441
...
By introducing a PropagateRootDirectory job that explicitly
separates the directory deletion jobs from all the other jobs.
Note that this means that if there are errors in subJobs the
dirDeletionJobs won't get executed.
2020-12-15 10:58:58 +01:00
475117dd60
Propagator: Make sure we schedule only one job #7439
...
To not starve the event loop.
(There is still ~= 3 jobs running at the same time)
2020-12-15 10:58:58 +01:00
3446412d92
PropagateDownload: Don't try to open readonly temporaries
...
This situation could arrise when receiving a read-only share and the
temporary rename failed for some reason.
See #7419
2020-12-15 10:58:58 +01:00
f78c4f851b
Change Windows virtual files description to tech preview
2020-12-15 10:58:57 +01:00
0ac8a3e6be
Don't fatal on "Storage temporarily unavailable"
...
This is an unreliable workaround. The real fix will need to be deferred
to another release.
For #5088
2020-12-15 10:58:57 +01:00
afc9cd2f46
OwncloudWizard: Mark vfs as tech preview instead of experimental
2020-12-15 10:58:57 +01:00
e5a36c3bc6
CMake VFS: Enable us to provided vfs plugins from an external directory
2020-12-15 10:58:57 +01:00
7e4d24de2b
SocketApi: Avoid unneccessary conversions
2020-12-15 10:58:57 +01:00
06ac1c33e8
SocketApi: cleanup debug output
2020-12-15 10:58:57 +01:00
25cd52dd9f
Add ASYNC_ASSERT_ICON_IS_EQUAL command to SocketApi
2020-12-15 10:58:57 +01:00
d1f9b1a4f8
Make findWidget more powerful
2020-12-15 10:58:56 +01:00
67656fb136
Add Q_PROPERTYs for gui testing
2020-12-15 10:58:56 +01:00
596154a01a
Switch GUI Testing SocketApi to Utf8
2020-12-15 10:58:56 +01:00
ad033e40fd
Fix build with recent Clang (on Linux)
2020-12-15 10:58:56 +01:00
3288a36da6
Add GUI testing SocketApi extension
2020-12-15 10:58:56 +01:00
e97784bb9d
Don't use mutable lambdas as they hide where we modify work on a copy
2020-12-15 10:58:55 +01:00
0f92713ce5
AccountSettings: Use switch, case to ensure we handle all cases
2020-12-15 10:58:55 +01:00
bade7aedc6
Checksums: Add back QIODevice api
...
Because the winvfs plugin needs it. But be more careful about the
device's lifetime this time.
2020-12-15 10:58:55 +01:00
Olivier Goffart