chylex
/
Nextcloud-Desktop
mirror of https://github.com/chylex/Nextcloud-Desktop.git
1
0
Fork 0
Code
15,187 Commits 4 Branches 173 Tags 91 MiB
Commit Graph

2782 Commits

Author SHA1 Message Date
Roeland Jago Douma 3776a04206
Allow sharing to circles 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-05 10:44:06 +01:00
Michael Schuster ff642085b4
Fix Explorer pinning: Add fallbacks for Shell commands (fixes #1599) 
See: #1599

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 18:45:58 +01:00
Michael Schuster ab1099f13e
WebFlowCredentials: Make username comparison case-insensitive (fix #1741) 
Fixes issue #1741

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 06:01:27 +01:00
Michael Schuster aab735a595
Fix MSVC warnings: Missing return value, cast type 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 02:08:37 +01:00
Michael Schuster eb7ed33d98
Merge pull request #1744 from nextcloud/qt-traygeometry-workaround 
Fix wrong window position on some linux DEs - worked around invalid g…
 2020-03-01 07:07:47 +01:00
Michael Schuster 712fef0cac
Merge branch 'master' into qml-singleton-style and fix merge conflict 
Migrate changes in client.qrc to resources.qrc

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 06:47:46 +01:00
Michael Schuster 318c749558
Merge pull request #1736 from nextcloud/resource-cleanup 
Resource cleanup and application-wide svg usage
 2020-03-01 06:11:17 +01:00
Michael Schuster 5b2877a63e
Merge branch 'master' into resource-cleanup 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 05:34:12 +01:00
Michael Schuster 29e02d0579
owncloudsetuppage.cpp: adapt to string change from master: url -> URL 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 05:32:59 +01:00
Michael Schuster a92a764c2a
owncloudsetuppage.cpp: also rename client/theme/lock-http(s) PNGs to SVG 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 05:12:59 +01:00
Michael Schuster 40767f7ae0
Fix Explorer integration: Hide option on non-Windows 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 04:03:29 +01:00
Michael Schuster f1dd312b2e
Fix Explorer integration re-save (fixes issue #1807) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 03:39:24 +01:00
Michael Schuster bf838bd336
Merge pull request #1809 from sroracle/cmake-qml-quick 
Fix cmake inclusion of Qml and Quick
 2020-02-29 21:18:11 +01:00
rakekniven b936cc1f6e
l10n: Change spelling of "webdav" 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:14:34 +01:00
rakekniven 62bc9d025e
l10n: Removed colon from translation 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:13:34 +01:00
rakekniven 961c05363a
l10n: Removed blank before colon 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:10:05 +01:00
rakekniven 3f7cd5c0f3
l10n: Change case of one word 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:08:56 +01:00
Max Rees 3d3021e3b0
Fix cmake inclusion of Qml and Quick 
Signed-off-by: Max Rees <maxcrees@me.com>
 2020-02-23 23:44:54 -06:00
Michael Schuster 9c8a0204e5
Updater: Add query-parameter 'updatesegment' to the update check 
Used to throttle down desktop release rollout in order to keep the update servers alive at peak times.

See: https://github.com/nextcloud/client_updater_server/pull/36

Targeted issues: #1795, #1800

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-02-21 21:28:42 +01:00
Michael Schuster 640655ea10
Code cleanup 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-02-14 03:00:20 +01:00
Michael Schuster abfebcf291
Add UserInfo class and fetch quota via API instead of PropfindJob 
The PropfindJob quota includes the size of shares and thus leads to confusion
in regard of the real space available, as shown in the UI.
This commit aims to streamline the behaviour with the Android and iOS apps,
which also utilize the API.

Details:
- Refactor the QuotaInfo class into UserInfo
- Use JsonApiJob (ocs/v1.php/cloud/user) instead of PropfindJob
- Let ConnectionValidator use the new UserInfo class to fetch
  the user and the avatar image (to avoid code duplication)
- Allow updating the avatar image upon AccountSettings visibility,
  using UserInfo's quota fetching

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-02-14 02:10:01 +01:00
Dominique Fuchs 6d23ce82d7
Merge pull request #1770 from nextcloud/rakekniven-patch-1 
l10n: Changed grammar and triple dots to ellipsis
 2020-02-06 08:17:38 +01:00
Dominique Fuchs 4b8b84f2dd
Merge pull request #1759 from nextcloud/fix/do_not_save_all_the_time 
Do not save notes on text change
 2020-02-06 07:49:28 +01:00
Dominique Fuchs e7b5cc8974
Merge pull request #1763 from nextcloud/tintou/cloudprovider-valid-dbus-path 
Make sure that the libcloudprovider integration is using a valid D-Bus path
 2020-02-06 07:17:35 +01:00
rakekniven da66b3956e
l10n: Changed grammar 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:55:51 +01:00
rakekniven 1988511c55
l10n: Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:54:32 +01:00
rakekniven abcadec94a
l10n: Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:53:17 +01:00
rakekniven 8f82fc2e51
Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:52:17 +01:00
rakekniven f9d27e4e3b
l10n: Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:50:27 +01:00
rakekniven 32c2c062c0 l10n: Changed spelling of "user name" to "username" 
Using "username" like on > 200 strings over the whole Nextcloud project.

Signed-off-by: rakekniven mark.ziegler@rakekniven.de
 2020-02-03 10:42:37 +01:00
Corentin Noël a7d6555de2 Make sure that the libcloudprovider integration is using a valid D-Bus path 
Set a simple unique identifier per folder to ensure that it is always unique.

Fixes https://github.com/nextcloud/desktop/issues/1704

Signed-off-by: Corentin Noël <corentin@elementary.io>
 2020-01-30 21:05:13 +01:00
rakekniven dfdb872e7b Changed product name to Nextcloud 
Reported at Transifex.

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-01-30 19:16:01 +01:00
Roeland Jago Douma bd9b0cf23f Am empty note is not a valid note 
Do not show the note edit field for empty new shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-28 12:46:15 +01:00
Roeland Jago Douma d449912a0a
Do not save notes on text change 
Only save notes on submit. Else you will get spammed with a ton of
requests (and possibly mails)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-28 12:09:17 +01:00
Dominique Fuchs 0697c81ae6 Rewrite of screen selection logic, plus synamic screen selection Window.qml 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-21 13:54:04 +01:00
Dominique Fuchs 77be6729a2 Fix also screen selection for different Qt versions and for buggy linux DEs 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-21 12:16:24 +01:00
Julius Härtl baf082df7c
Use system proxy by default if no config file is present 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-01-21 11:59:07 +01:00
Dominique Fuchs f3062f6c96 Fix wrong window position on some linux DEs - worked around invalid geometry() returned by QT 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-21 09:55:26 +01:00
Dominique Fuchs bb757c6a27 Merge branch 'master' into resource-cleanup 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:44:59 +01:00
Dominique Fuchs 6593317afa Merge branch 'master' into qml-singleton-style 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:43:36 +01:00
Dominique Fuchs 9deb51c846 Module styling also for UserLine.qml 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:40:49 +01:00
Dominique Fuchs 3a39e636ae Introduced Style module 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:13:12 +01:00
Michael Schuster 03cddabfd0
Tray menu: Only show time ago (view too noisy) 
Don't show date and time for now, rather as a tool tip later.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-19 19:12:34 +01:00
Dominique Fuchs d3cd422b46
Fix crash on start without any accounts 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 9935606c87ec4818f04c7d7c63d2f4b61187eead)
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-19 14:14:23 +01:00
István Váradi 835cd2ac80 Qt 5.5 compatibility ifdef 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2020-01-19 13:16:17 +01:00
Dominique Fuchs 01e9343d8b Cleanup/Removal/Adaption/Update to resource files and crresponding code, esp. regarding svg usage 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-18 17:47:17 +01:00
Michael Schuster c0863ede02
Share context menu: Use directEditing capability in SocketApi 
- Allow direct editing "Edit" when an editor is available for the mime type
- Show "Open in browser" if editing is unavailable (as previously)
  (now on top of the menu list)
- Rename the menu title to the app name, "Nextcloud" instead of "Share via ..."

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-18 15:12:16 +01:00
Michael Schuster 45b39cdbc1
Add support for the directEditing capability 
- Fetch in ConnectionValidator::slotCapabilitiesRecieved
- Add editors to a list made of the new DirectEditor class

TODO:
- Add support for re-fetch and continously check for changes (ETag)

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-18 15:07:51 +01:00
Michael Schuster 2039872ee5
Merge pull request #1565 from nextcloud/qml-tray-menu 
New tray window
 2020-01-18 13:18:45 +01:00
Michael Schuster 016a90d7b0
More code maintenance 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-18 12:56:26 +01:00
Dominique Fuchs 9b5bb1365c Code maintenance - correct some syntax, fix some warnings. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-18 10:30:34 +01:00
Michael Schuster de74057cc8
Add grey hint Activity entry if limit is reached 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:26:48 +01:00
Michael Schuster e2188b109a
Limit fetching Activities to 100 or max. 30 days old 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:25:41 +01:00
Michael Schuster 3ae55c2555
AccountState: Add helper to find navigation App 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:21:42 +01:00
Michael Schuster b47adb7aeb
Notifications bug fix: Don't init ETag response header with * 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:20:37 +01:00
Michael Schuster 889cb636d3
Add Activity date and time 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:16:20 +01:00
Dominique Fuchs c9719f44dc Fix hover property wrongly placed in button, not MouseArea 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 16:30:27 +01:00
Dominique Fuchs 599dae0486 Inclusion of possible 'notification' type descriptions in activity 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 14:50:05 +01:00
Dominique Fuchs 1c5cdc4d36 Adapted currentId logic for activity fetching to new API (should fix endless fetch bug) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 14:29:54 +01:00
Dominique Fuchs 0156edf320 Removed visibility workaround 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 11:21:43 +01:00
Dominique Fuchs f425dfdfea Set sourceSize to prevent blurry rerendering of svg source in activityIcon 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 10:38:21 +01:00
Dominique Fuchs 7ea2f3fa59 Refresh visibility of ListView based on presence of items on showWindow 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 09:09:42 +01:00
Dominique Fuchs 1c22070a74 Refresh immediately on showWindow, regardless of the timer 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 09:04:24 +01:00
Michael Schuster 9abc1eb921
Add initial support for Apps menu icon display (show remote SVGs) 
Caching and showing them from local data-URLs leaded to blurry rendering in Qt.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-16 18:43:48 +01:00
Dominique Fuchs 94325359d7 Fixed bug regarding additional but empty delegate at end of activitylist 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 18:01:18 +01:00
Dominique Fuchs 585094a719 Minor property hierarchy fix 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 17:40:47 +01:00
Dominique Fuchs 4b79c597dc Disabled animations until population glitches are fixed 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 17:11:08 +01:00
Dominique Fuchs 1bc8ec59aa Streamlining local sync notification/activity icons with server ones. Added fileAction logic for local sync activities 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 17:09:34 +01:00
Dominique Fuchs b9a350e201 Minor layout adjustments 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 15:19:17 +01:00
Dominique Fuchs cd80c749d6 Retreive and svg data from icon property url for activity entries 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 14:01:54 +01:00
Dominique Fuchs 06fdde8f1e Upgrade of NC server API usage + corresponding activity queries and properties including icon ref 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 12:43:04 +01:00
Dominique Fuchs 9f259bda27 Add check if applist rowCount() already empty to prevent assert exception 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 11:30:51 +01:00
Dominique Fuchs 246f7e9395 1px border #0082c9 around tray window 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 08:01:09 +01:00
Michael Schuster 7fe138330e
Double the width of the Apps menu (x starts at the Talk button) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-16 00:57:49 +01:00
Michael Schuster 3488fd7c7f
Fix font sizes for "Log out" and "Remove account" and the Apps menu 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-16 00:45:31 +01:00
Dominique Fuchs 00d73a9389 Add visual separation between accountStateIndicator and avatar 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 20:11:50 +01:00
Dominique Fuchs ddf67ff948 Preserve a 2px distance from tray border (streamlining with acount menu) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 19:28:40 +01:00
Dominique Fuchs 9b32ebdae4 Allow text to expand further if one or both buttons aren't visible 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 19:15:25 +01:00
Dominique Fuchs 0ec2291bd7 Layout adjustments & also show remote path in activitylist 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 18:44:33 +01:00
Michael Schuster 026bf02c85
App menu: Filter out Talk because we have a dedicated button for it 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 18:14:20 +01:00
Michael Schuster 42ebc7e995
Remove debug output 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 18:09:33 +01:00
Michael Schuster b4b6366ba8
Add App list menu to Tray UI 
- Modify Window.qml and Systray to show the App menu upon clicking the App button
  on the top-right. Fall back to opening the general URL in case no apps are found.

- Introduce a new UserAppsModel in UserModel.cpp to access the fetched server Apps
  from AccountState (propagated down from the User class).

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 16:42:06 +01:00
Michael Schuster 7b740f5e9a
Remove setTalkCapability() from AccountState and filter for Talk upon App list building 
Since the per Account App list is now being built in AccountState's slotNavigationAppsFetched
it's easy to filter for the availability of the Talk app on the server by its ID property
upon App list building, thus eliminating the need for an extra fetch job.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 16:30:05 +01:00
Michael Schuster cb328d6cea
Fetch server Apps in AccountState (moved from ownCloudGui) 
- Add a new class AccountApp to keep them in an AccountAppList
  and also save properties like ID and Icon URL.

- Clear the app list upon re-fetch to avoid endlessly growing lists
  like in the previous implementation in ownCloudGui.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 16:23:46 +01:00
Dominique Fuchs b57b8cfb66 Resized add account icon, adapted layout for new size 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 08:01:54 +01:00
Dominique Fuchs 29138cc533 Font and icon size improvements, svg transfer to new folder 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-14 19:48:21 +01:00
Dominique Fuchs c09dd9287c Fix missing trayScreen init in non-OSX clause 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-14 08:55:39 +01:00
Dominique Fuchs 65b47d4613 Make qml UI strings translatable 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-14 07:59:28 +01:00
Dominique Fuchs f748a4bb50 Made tray window positioning HighDPI aware 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 22:11:57 +01:00
Dominique Fuchs e4b19d0cb5 Activity refresh in background 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 14:35:58 +01:00
Dominique Fuchs eeefbe57af Added progressInfo / cleanup to acitivtymodel 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 13:10:32 +01:00
Dominique Fuchs 84066634e7 Integrated local error messages in activitymodel 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 12:54:38 +01:00
Dominique Fuchs 9e82ba60b4 Integrated local sync activities in activitymodel 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 12:20:41 +01:00
Dominique Fuchs 96a74d9ef0 Minor improvements 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 11:46:49 +01:00
Dominique Fuchs 1ebcd3a0fb Icon selection, svg path transfers, scrollbar 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 09:59:34 +01:00
Michael Schuster 8f9101773c Fix Explorer integration on Windows and the crash on other systems 
- Ensure that the folder integration stays persistent in Explorer,
  the uninstaller removes the folder upon updating the client.
  Recreate all entries upon start. This has the benefit of removing
  old remains of non-working, outdated entries.

- Don't crash on the other systems when the user clicks the option
  button "Show sync folders in Explorer's Navigation Pane".
  Even though the option currently doesn't work on the other platforms,
  crashing is never good...

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-13 09:25:01 +01:00
Dominique Fuchs 17fcfd4e41 Show ListView delegate only when model is populated (prevent dummy delegate) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 09:12:44 +01:00
Dominique Fuchs 9e6df7a4dc Add populate transition 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 08:43:51 +01:00
Dominique Fuchs 9319210c4c Fix local folder not opening on windows, add extra slash 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 08:33:10 +01:00
Dominique Fuchs 58f1c3234d Temperarily disabling animations due to lags - FIXME 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 21:37:08 +01:00
Dominique Fuchs 715924cac6 Show activitylist on initial tray opening when logged in 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 21:19:18 +01:00
Dominique Fuchs 163ca3b58a Removed old account toolbox 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 19:53:02 +01:00
Dominique Fuchs 1c2916052d Bunch of fixes and optimizations for activityList 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 17:52:51 +01:00
Dominique Fuchs b76da25ef1 Model/View improvements, also fixes crash on account removal 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 16:16:24 +01:00
Dominique Fuchs 7f35178c70 More fixes to login/logout logic 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 11:06:48 +01:00
Dominique Fuchs 212e1f80f5 emit signal for current user GUI refresh on login/logout 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 10:46:14 +01:00
Dominique Fuchs a2c9e369c3 call resetRejectedCertificates on fresh login 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 10:42:40 +01:00
Dominique Fuchs 78f12de997 Merge branch 'master' into qml-tray-menu 2020-01-12 09:12:16 +01:00
Dominique Fuchs 8ec7cfa700 Connection status indicators as avatar overlay 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 09:10:06 +01:00
Dominique Fuchs bc8f64bb98 Generalized connection check, now working for every user in account menu 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 08:50:13 +01:00
Dominique Fuchs 578a3b4ef4 Streamlined 'Add account' button with account entries 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 20:28:00 +01:00
Dominique Fuchs cc671dfad3 Fix local folder URL 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 19:56:56 +01:00
Dominique Fuchs 86b915d42e Systray now a singleton with instance(), show tray on finished wizard 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 17:34:56 +01:00
Dominique Fuchs 738127525f Fix comment 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 17:14:44 +01:00
Dominique Fuchs 6485ef480b Added confirmation dialog for account removal 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 17:06:42 +01:00
Dominique Fuchs 9af7d4ad06 Fix crash on startup when no users configured 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 16:41:20 +01:00
Dominique Fuchs 32741162d9 Detect newly added user and rebuild account menu automatically 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 15:47:36 +01:00
Dominique Fuchs 3da982f073 Implemented account removal 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 15:32:59 +01:00
Dominique Fuchs a021f62e96 Tray creation timing, account menu reinstantiating on visible change 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 15:05:37 +01:00
Dominique Fuchs 80e21560eb More UserLine, avatar fixes 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-11 14:57:22 +01:00
Dominique Fuchs 9c0221a0fa UserLine drafting, bugfixes, restuctures 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-10 16:28:53 +01:00
Roeland Jago Douma 05083e32c9 Ask for password on password protected link shares 
Fixes #1485

This was missed when creating the new share dialog.
Now it pops up with a nice share password dialog to enter for your link
share.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-09 18:20:32 +01:00
JanDragon 4a64e8da83 Updated year in legalnotice.cpp 2020-01-06 09:08:22 +01:00
Dominique Fuchs 6ac1a4a353 Preps for UserLine submenu 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-05 21:31:09 +01:00
Dominique Fuchs 330ff96ee2 Code cleanup regarding context menu. Pause/resume logic implemented. Halfway through remodeling account menu. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-05 21:06:42 +01:00
Dominique Fuchs a90995cf15 Focus and popup improvements for macOS 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-05 16:25:32 +01:00
Dominique Fuchs aa9921c6f5 Quit/settings button in tray menu, disable context menu, font size fixes 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-04 17:22:56 +01:00
Dominique Fuchs d653618b0a Fix blurry caret svg due to https://bugreports.qt.io/browse/QTBUG-44863 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-04 12:18:06 +01:00
Dominique Fuchs dc9744448c Fix wrong macro clause 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-04 12:15:01 +01:00
Dominique Fuchs ed9c06583a Fix macOS popup y position, neglecting unneccesary calculations 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-04 12:08:30 +01:00
Dominique Fuchs ff92adf3e0 Tray account menu wording/positioning 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-04 10:09:01 +01:00
Dominique Fuchs e0641df727 First real activity connection 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-03 16:15:15 +01:00
Dominique Fuchs f01c47e0ec Fix server adress retreival in tray window buttons 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-03 14:00:07 +01:00
Dominique Fuchs faf46fcf60 More typo fix 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-03 13:42:07 +01:00
Dominique Fuchs 687a99279d Has function for ActivityModel, typos 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-03 13:39:10 +01:00
Dominique Fuchs 02cb43180c Fix git not recognizing case sensitive changes 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-03 13:12:04 +01:00
Dominique Fuchs b32310b8a6 Gigantic ton of changes and deletions: ActivityListModel, tray GUI, Account logic. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-03 13:09:29 +01:00
Dominique Fuchs 556a1a5ef2 Added ActivityModel in new tray backend, implemented as delegate in UI 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-02 10:39:53 +01:00
Dominique Fuchs 36467c1e3a Added folder search for User instance, added open folder button connection 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-02 09:55:37 +01:00
Dominique Fuchs d4b334636e Fall back to primary screen on QT version < 5.10 instead of icon position detection 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-02 08:56:07 +01:00
Dominique Fuchs 7653c5fa60 Fix merge conflict 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-02 08:43:34 +01:00
Dominique Fuchs 44bfc79caa Implemented platform agnostic tray window positioning logic 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-30 14:14:28 +01:00
Dominique Fuchs 6f8ffc0357 Backend code separation & structure cleanup 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-30 11:52:07 +01:00
Dominique Fuchs bb45a5f67e Added popup show/hide logic 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-30 11:39:21 +01:00
Michael Schuster 2b2810511d
KeychainChunk: Fix error handling in ReadJob::slotReadJobDone 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 12:17:43 +01:00
Michael Schuster e07859fb3c Fix date in ActivityWidget and remove unnecessary string conversion 
The local date and time value was converted into a string, just to be converted
into another string, to be converted to a value once again, returning zero as
the result. This caused the widget to always display "now".

Looks like this was a simply copy and paste mistake from this line in
ActivityListModel::slotActivitiesReceived:

a._dateTime = QDateTime::fromString(json.value("date").toString(), Qt::ISODate);

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 08:53:14 +01:00
Michael Schuster 9b034a2eb0 Heavy refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys and large certs 
With QtKeychain on Windows, storing larger keys or certs in one keychain entry causes the
following error due to limits in the Windows APIs:
    Error: "Credential size exceeds maximum size of 2560"

This fix implements the new wrapper class KeychainChunk with wrapper jobs ReadJob and WriteJob
to encapsulate the QKeychain handling of ReadPasswordJob and WritePasswordJob with binaryData
but split every supplied keychain entry's data into 2048 byte chunks, on Windows only.

The wrapper is used for all keychain operations in WebFlowCredentials, except for the server password.

All finished keychain jobs now get deleted properly, to avoid memory leaks.

For reference also see previous fixes:
- https://github.com/nextcloud/desktop/pull/1389
- https://github.com/nextcloud/desktop/pull/1394

This should finally fix the re-opened issue:
- https://github.com/nextcloud/desktop/issues/863

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:47:35 +01:00
Michael Schuster bd9652b24c Flow2AuthWidget: Minor fixes and improvements 
- Improve status messages

- Add a counter to make sure that "Link copied to clipboard." is visible for
  three seconds and to not enable the buttons too early

- Add more space between buttons and status

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster 8b5f09305c Flow2: Refactor UI into Flow2AuthWidget only and improve Flow2Auth 
- Flow2AuthCredsPage:
  - Remove .ui file and embed Flow2AuthWidget into layout

- Flow2AuthWidget:
  - Make use generic for Flow2AuthCredsPage and WebFlowCredentialsDialog
  - Fix _errorLabel to render HTML tags instead of dumping them as plain text

- Flow2Auth:
  - Explicitly start auth with startAuth(account) instead of using constructor
  - Take control of copying the auth link to clipboard
  - Request a new auth link on copying, to avoid expiry invalidation
  - Use signals statusChanged() and result() to be more verbose (status, errors)
  - Change timer invocation and add safety bool's to avoid weird behaviour when
    the user triggers multiple link-copy calls (fetchNewToken)

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster 6d033f2964 Add new HeaderBanner class for WebFlowCredentialsDialog 
New widget on top of the layout, based on Qt's own modern wizard header banner.

This should improve the user's perception of the dialog.

Encapsulate the existing layout into a container layout to allow the banner taking
the full width of the dialog.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster 0bcac1882a Make WebFlowCredentialsDialog cancellation- and deletion-safe 
- Add new signal to let WebFlowCredentials know and emit asked() to also
  tell AccountState that the user won't authenticate, and triggering
  log-out state in the settings window.

- Use deleteLater() to safely delete WebFlowCredentialsDialog, so
  that Qt can free it at the right time and without crashes.
  Do the same with it's _webView and _flow2AuthWidget on closeEvent().

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster b6b04aeff8 WebFlowCredentialsDialog: Bring re-auth dialog to top (raise) on error 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster a69aed80e6 Flow2: Make ProgressIndicator's background-aware (Dark-/Light-Mode switching) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster e81f972270 Flow2: Add poll status text, ProgressIndicator and countdown timer 
Also enable / disable buttons during polling.

This aims to make the authentication status more transparent and should avoid the
impression that the client is perhaps doing nothing.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster 542590db7c Small fixes and code cleanup 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster e04aae94bc Flow2: Poll for re-auth result upon WebFlowCredentialsDialog window activation 
Since the default remote poll interval has been re-raised recently to 30 seconds,
the delay between clicking "Grant access" in the browser and fetch and showing success
in the dialog may seem erroneous to the users and tempt them to click "Re-open browser"
again, causing the whole login process to restart.

This commit implements an event handler to pass the dialog's window activation
event down to the Login Flow v2 widget, in order to allow it to poll earlier.

See previous commits for dependent implementation details.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster aa18667905 WebFlowCredentialsDialog: Bring re-auth dialog to top (raise) upon showing SettingsDialog 
Purpose: The floating re-auth windows of the WebFlowCredentialsDialog often get hidden behind
the SettingsDialog, and the users have to minimize a lot of other windows to find them again.

See previous commit for dependent implementation details.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster addb27a085 Add helper slots and signals to catch SettingsDialog's window activation events 
Signal the SettingsDialog's window activation event down to ownCloudGui and Application,
so that other classes can hook in to get notified when the SettingsDialog is being shown
again.

This approach has been chosen because we otherwise would have to deal with new instance
pointers of the current SettingsWindow - but Application is already there ;-)

Purpose: The floating re-auth windows of the WebFlowCredentialsDialog often get hidden
behind the SettingsDialog, and the users have to minimize a lot of other windows to find
them again. This commit implements the preparation for the upcoming fix commit.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster be10d5200f Flow2: Use ownCloudGui::raiseDialog to bring account setup wizard to top (raise) on auth result 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster e8348612b4 Flow2: Poll for auth result upon account setup wizard window activation 
Since the default remote poll interval has been re-raised recently to 30 seconds,
the delay between clicking "Grant access" in the browser and fetch and showing success
in the wizard may seem erroneous to the users and tempt them to click "Re-open browser"
again, causing the whole login process to restart.

This commit implements an event handler to pass the wizard's window activation
event down to the Login Flow v2 page, in order to allow it to poll earlier.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster 3a160a4dce Flow2: Bring account setup wizard to top (raise) on auth result 
Show and raise the wizard on success / error in the Login Flow v2 auth.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:46:57 +01:00
Michael Schuster ccd20f0172 Fix issue #1237: White text on almost-white background 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:44:18 +01:00
Michael Schuster c03bc8540c Fix folder opening in ActivityListModel 
After fixing the crash in the previous commit, double-clicking on Activity list rows still didn't work.

This fix partly reverts commit 8546d53b05 in ActivityItemDelegate::PathRole
of ActivityListModel::data, but adds a new check for relPath's existence in line 74.

I'm assuming the previous change there has been done to shorten the code and avoid opening the user's home
folder upon clicking entries which file value is "App Password". The new path-check takes care of that too now.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:42:01 +01:00
Michael Schuster 003acb7254 Fix crash in ActivityListModel (fixes #1693) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:42:01 +01:00
Michael Schuster b961b683d6 Show date and time in activity log (fixes issue #1683) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-24 07:40:42 +01:00
Michael Schuster a7dade979c Fix build (missing refactoring) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster 3a2caf61e5 Mac and high-dpi displays: Add workaround in ActivityItemDelegate to show full uncropped activity's actionText and timeText 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster b5ed16088a Make all ProgressIndicator's background-aware (Dark-/Light-Mode switching) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster e4a20b9e72 Make OwncloudWizard and its pages background-aware (Dark-/Light-Mode switching) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster 37e5fe786f Remove unnecessary string translation and copy in ActivityItemDelegate 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster 643995528b Remove unnecessary breaks in ActivityListModel 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster ecd17f2ea2 Make ActivityItemDelegate background- and selection-aware (Dark-/Light-Mode switching) 
Also implement cached member icons in ActivityListModel and return their enums to
ActivityItemDelegate instead of always recreating them for each call to paint().

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster bf0bf2c1b6 Refactor ActivitySettings: Rename member variable ui to _ui 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster acedf362b6 Make AccountSettings and ActivitySettings background-aware (Dark-/Light-Mode switching) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster 3b580eeca7 Change error link colour in AccountSettings::showConnectionLabel 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-19 22:07:30 +01:00
Michael Schuster cc21d175f1 Fix Activity List: Add check to avoid first empty entry 
Add checks to ActivityListModel::combineActivityLists in order to avoid adding
empty Activity entries to the _finalList.

The previous implementation always added an empty entry to the top of the list because
_notificationIgnoredFiles was appended without checking (_listOfIgnoredFiles.size() > 0).

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-18 03:29:54 +01:00
Michael Schuster b754eacd74 macOS: Rename 'Explorer' appropriately on non-Windows 
- Rename it to 'Finder' on macOS.
- This way we also avoid having the whole string re-translated on Transifex.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-09 21:37:21 +01:00
Michael Schuster 7ce8a6a201 Make the ShareDialog background-aware (Dark-/Light-Mode switching) 
Use customizeStyle() to change link colours, icons and pixmaps in the ShareDialog and notify
it's widgets via slots.

TODO - known issue (macOS):
- The background and font colours in the ShareUserLine widget still stay the same.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-09 21:37:21 +01:00
Michael Schuster 789a2a7ae3 Make SettingsDialog background-aware (Dark-/Light-Mode switching) 
Use customizeStyle() to change link colours in the SettingsDialog and notify it's widgets via slots.

Also modify the background colour of the errors messages in AccountSettings::showConnectionLabel
to always use an appropiate colour for it's custom-defined background.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-09 21:37:21 +01:00
Michael Schuster be4fc6b887 Implement and move some colour-aware helper methods into the Theme class 
This introduces a new method to change the colours in the links in QLabel's.
Utilizes a custom crafted RegEx function to replace already-coloured links.

Moved code is based on stuff from the SettingsDialog class.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-09 21:37:21 +01:00
Michael Schuster 2dae31486a Pick from upstream: Fix too low contrast when tab is selected 
The low contrast is also a problem with the Dark Mode on macOS.

For reference please see:
- Commit: 413ef5e96d
- Issue: https://github.com/owncloud/client/issues/7512

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-09 21:37:21 +01:00
Michael Schuster 71f66c6229 Fix SSL-button's info background color for Dark Mode 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-09 21:37:21 +01:00
Michael Schuster b4f926ded7 Remove submodule qtmacgoodies and the MacSettingsDialog class 
Reverts back to the SettingsDialog class because of bugs and glitches with
more recent Qt versions (Qt 5.12) and with the macOS Dark Mode.

See upstream: https://github.com/owncloud/client/pull/7492

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-09 21:37:21 +01:00
Dominique Fuchs 438a445353 Merge remote-tracking branch 'origin/master' into qml-tray-menu 2019-12-09 06:52:52 +01:00
Dominique Fuchs 6a04fe8ab6 Remove init.qml from CMakeLists and resource file 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-09 06:43:20 +01:00
Dominique Fuchs c45d2212a5 Removal of init.qml plus minor fixes 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-08 20:18:03 +01:00
Dominique Fuchs 66bfccc738 Replaced .engine() by pointer access b/c of backward compatibility 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-08 13:18:46 +01:00
Dominique Fuchs ae7eddf7c9 Fixed inconsistent module import versions (based on Qt 5.9) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-08 11:32:22 +01:00
Michael Schuster 5869b93acb Fix deleteKeychainEntries: Stay consistent with job->setInsecureFallback(false) 
We never fall back to the insecure variant in the whole codebase, so don't do it here.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-08 02:47:22 +01:00
Michael Schuster b15eb27aa9 Fix Windows key-chunk deletion (too paranoid) 
Clear the key chunk buffer, but don't set _clientSslKeyChunkCount to zero because we need it later for deleteKeychainEntries

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-08 02:47:22 +01:00
Michael Schuster 336b64a569 Fix member variable name from last refactoring (Windows code) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-08 02:47:22 +01:00
Michael Schuster 0c5f4a1525 Remote Wipe: Implement hack to allow deleting all keychain entries (SSL certs & keys) 
Client SSL certificates and keys cannot be deleted at this time because there is
no UI for selecting them on re-login.

We introduce this dirty hack here, to allow deleting them upon Remote Wipe.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-08 02:47:22 +01:00
Michael Schuster 6ef9f3cc26 Refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys 
WebFlowCredentials:
- Remove _clientSslCaKeyWriteQueue and simply use _clientSslKeyChunkBufferPEM
- Store key's sub-chunks in slots with "." (dot) suffix
- Implement deletion of the key chunks in WebFlowCredentials::deleteKeychainEntries
- Remove spaces in log messages
- Improve code readability

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-08 02:47:22 +01:00
Michael Schuster 72be80cbd9 Windows: Workaround for storing >= 4k (4096 bit) client-cert SSL keys 
With QtKeychain on Windows, storing larger keys in one keychain entry causes the
following error due to limits in the Windows APIs:
  Error: "Credential size exceeds maximum size of 2560"

To avoid overhead on the other platforms and balance code duplication, this
approach puts some read- and write-parts into Windows-only defines.

For reference also see previous fixes:
- https://github.com/nextcloud/desktop/pull/1389
- https://github.com/nextcloud/desktop/pull/1394

This (again) fixes the re-opened issue:
- https://github.com/nextcloud/desktop/issues/863

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-08 02:47:22 +01:00
Michael Schuster 877fd7abb9 Fall back to old login flow on GS as this is not yet ready (#2: re-auth) 
This commit ensures that the check also occurs on re-authorization in case
the user gets logged out.

See: https://github.com/nextcloud/desktop/pull/1644

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-12-06 21:03:01 +01:00
David Kahles 9a3aa55b29 Compare QDateTime objects more efficient 
There is no need to call toMSecsSinceEpoch() as QDateTime implements an
comparison operator itself. This is more efficient, because the
QDateTime comparison operator doesn't call localtime() in all cases. Thus, we
don't read /etc/localtime for every comparison. This improves
performance in some cases.

Signed-off-by: David Kahles <david.kahles96@gmail.com>
 2019-12-06 16:17:53 +01:00
Dominique Fuchs ab9897b397 Added frontend invokation to open local folder 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-06 14:50:34 +01:00
Dominique Fuchs c18611d4af Finished account switch back- and frontend in tray menuwindow 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-05 11:38:29 +01:00
Dominique Fuchs 5eff8608fe Account swtich logic and UI updates 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-05 08:21:19 +01:00
Dominique Fuchs 3a4ca5e190 Working on account switching 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-04 16:19:42 +01:00
Dominique Fuchs d1d1f9bb58 Connected AccountWizard with new account action in tray menu, minor fixes 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-04 14:19:23 +01:00
Dominique Fuchs 90ace3fedc Minor preps for c++ ActivityListModel impl. in QML 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-04 13:10:28 +01:00
Dominique Fuchs 4e0997dbdf Minor fixes and enhancements 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-04 08:06:56 +01:00
Dominique Fuchs 57084fbd3e WIP: working UserModel.cpp and account menu 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-03 22:15:25 +01:00
Dominique Fuchs 4478399282 More stuff regarding tray/UserModel.cpp 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-03 18:50:34 +01:00
Dominique Fuchs 53abf5a316 WIP: Building User/MenuModel backend for tray menu 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-03 17:25:11 +01:00
Joas Schilling 9ce2491d67 Use … instead of 3 dots 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-12-03 09:06:06 +01:00
Joas Schilling ec637217f2 Fix some translations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-12-03 09:06:06 +01:00
Joas Schilling 91a5395e1a Improve the translation of "Share via …" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-12-03 09:06:06 +01:00
Dominique Fuchs dac1c9b413 Avatar, full user name and server address now reflected in QML gui, provided by C++ backend 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-12-03 07:26:59 +01:00
Dominique Fuchs c21e4f5982 Clean up test variable 2019-12-02 22:48:39 +01:00
Dominique Fuchs 478281d853 Restructures and refactorings: New systray class, handling of current user selection, integration of user information in tray window header 2019-12-02 22:45:14 +01:00
Dominique Fuchs 08d4c56886 WIP: Extending systray class, transitioning towas independent ActivityModel inclusion 2019-12-02 14:10:18 +01:00
Dominique Fuchs 03c0d8ba5a Minor preps for c++ ActivityListModel impl. in QML 2019-11-29 17:06:35 +01:00
Michael Schuster dcc84d3508 Fix remote wipe keychain storage (issue #1592) 
The app password for the remote wipe was constantly being written in
WebFlowCredentials::slotFinished to the keychain, leading to unnecessary
write and log overhead on the system.

This fix introduces a check to only store the app password once in
a lifetime of the Account class. Also the method used to store the
password will be renamed from setAppPassword to writeAppPasswordOnce
to be more expressive.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-11-29 13:53:52 +01:00
Christoph Wurst 923abd8d0b Fix legal notice year 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-11-26 12:46:02 +01:00
rakekniven e896c41ef9
l10n: Remove string from Transifex resource 
Fix for #1578 

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2019-11-13 18:03:22 +01:00
Camila Ayres 4efa282f80
Merge branch 'master' into issue_1351 2019-11-04 22:48:07 +01:00
Michael Schuster b9ad82ceeb
Merge branch 'master' into fix-remote-wipe-proxy 2019-11-04 19:58:56 +01:00
Michael Schuster 6421397083
Fix updater message: Download link instead of "use the system's update tool" 
Provide a download link to the new version instead of the confusing message that
users should use their "system's update tool to install it".

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-11-04 19:19:59 +01:00
Camila San 52ae354ca2 Fix remote wipe when a proxy is configured. 
Signed-off-by: Camila San <hello@camila.codes>
 2019-11-04 17:52:02 +00:00
Dominique Fuchs c6ff66be79 Smoother deletions: Added animation for removeDisplaced including sequential opacity change and displacement animation 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-11-04 12:48:07 +01:00
Dominique Fuchs 06b251063e Initial ListView design/modeling for activity list 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-10-30 20:47:21 +01:00
Dominique Fuchs cb7b2a3dc6
Merge branch 'master' into qml-tray-menu 2019-10-30 17:19:18 +01:00
Dominique Fuchs 6135eb26ad Finished (static) header design and hover effects 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-10-29 23:25:00 +01:00
Dominique Fuchs 7ed03f1f29 resolving conflict with current master 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-10-29 14:07:26 +01:00
Dominique Fuchs 5301477747
Merge branch 'master' into recipientnote 2019-10-29 12:58:14 +01:00
Dominique Fuchs 73667a5367 Updated vecto icons and names, disabled init position (breaks on multiple monitors on windows), integrated new icons in qml 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-10-29 08:13:05 +01:00
Camila San 1e43c29484
Add new qml tray icon. 
This is a work in progress.

Signed-off-by: Camila San <hello@camila.codes>
 2019-10-27 20:02:30 +01:00
Michael Schuster 8e8858178b
Merge branch 'master' into move-rtfiles 2019-10-27 17:49:22 +01:00
Michael Schuster e54f127a06
Merge branch 'master' into lnx-domainname-desktopfiles 2019-10-27 17:30:48 +01:00
Michael Schuster 9618500975
fix tab spacing 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-10-27 17:25:50 +01:00
Dominique Fuchs eff75a2059
Merge branch 'master' into move-rtfiles 2019-10-27 15:43:41 +01:00
Dominique Fuchs 7f764f8108 Added basic UI [WIP] for new tray window 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-10-27 15:19:20 +01:00
Sergey Zolotarev 9a11bef263 Fix duplicate items in Apps menu (a bug introduced in #1477) 
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
 2019-10-24 02:55:56 +06:00
adrb 921b144d06
Merge branch 'master' into issue_1351 2019-10-18 08:19:32 +02:00
Adrian Brzezinski 3b750895b4 * fix for issue no. 1351 
Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl>
 2019-10-18 08:16:59 +02:00
Michael Schuster 32bb31a417
Merge branch 'master' into feature/remote-wipe 2019-10-17 22:05:20 +02:00
Camila San 19491ff85f
Once client gets 401/403 from the server, check if remote wipe was requested. 
- When the the users logs because of 401 or 403 errors, it checks if the
server requested the remote wipe. If yes, locally deletes account and folders
connected to the account and notify the server. If no, proceeds to ask the
user to login again.
- The app password is restored in the keychain.
- WIP: The change also includes a test class for RemoteWipe.

Signed-off-by: Camila San <hello@camila.codes>
 2019-10-17 20:11:31 +02:00
Camila San 8546d53b05
Merge the list of ignored files/symlinks into one Activity notification. 
Signed-off-by: Camila San <hello@camila.codes>
 2019-10-17 18:45:33 +02:00
Michael Schuster ade50d0b92 Pick from upstream: Update qtmacgoodies for an OSX crash fix #6930 
With Qt 5.12.5 this OC crash also applies to the Nextcloud Desktop Client on macOS.

For reference please see:
- https://github.com/owncloud/client/issues/6930
- 0dc7bc3328

For the required changes in the qtmacgoodies submodule see:
https://github.com/camilasan/qtmacgoodies/pull/1

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-10-17 04:29:33 +02:00
Michael Schuster e8fc3ecf28
Merge branch 'master' into quit-wizard-fix 2019-10-16 04:43:41 +02:00
Michael Schuster c8b4145214
Add a 'Content-Length: 0' header to initial POST requests 
The webserver lighttpd rejected POST requests without a Content-length
header with "411 Length Required".

See: https://github.com/nextcloud/desktop/issues/1473

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-10-10 05:17:22 +02:00
Michael Schuster 04a9f0313a
Merge pull request #1481 from asapelkin/for_loop_optimization 
Avoiding copying in range-based loops
 2019-10-10 01:30:40 +02:00
Michael Schuster 4ddc606361
Merge branch 'master' into for_loop_optimization 2019-10-10 01:12:57 +02:00
Michael Schuster 836c748cd9
Merge branch 'master' into trexcl 2019-10-10 01:12:48 +02:00
Michael Schuster 0d349d54b4
Fix outdated link to server admin docs 
Sets the target version from "15" to "latest" and removes
"index.html" because this could get obsolete in the future too.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-10-10 01:03:46 +02:00
Michael Schuster 29123f4d9d
Merge branch 'master' into master 2019-10-10 00:45:04 +02:00
Dominique Fuchs c1cd308940
Merge branch 'master' into quit-wizard-fix 2019-10-09 09:18:26 +02:00
Sergey Zolotarev 4bba498229 Replace isQuitting flag with disconnect() 
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
 2019-10-09 11:07:00 +06:00
asapelkin 6b71e4ec6f
Merge branch 'master' into for_loop_optimization 2019-10-07 15:31:01 +03:00
Dominique Fuchs 75444e44b9
Merge branch 'master' into master 2019-10-07 09:45:22 +02:00
asapelkin 17f39bd09d little loops optimization 
Signed-off-by: asapelkin <asapelkin0x01@ya.ru>
 2019-10-07 01:29:55 +03:00
Sergey Zolotarev eaddc55267 Don't run connection wizard when quitting the application 
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
 2019-10-05 22:38:47 +06:00
Sergey Zolotarev f6b6765424 Prevent jumping of tray menu 
Instead of adding the "Apps" menu after the apps are fetched, add it
from the start (together with other actions) but in a disabled state,
and enable it after the apps data is ready.

Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
 2019-10-05 22:10:35 +06:00
Michael Schuster 7deb74cc22
Merge branch 'master' into show-server-vers 2019-10-05 00:44:08 +02:00
rakekniven b25aa99de7
Fixed grammar 
Reported at Transifex.
See https://www.transifex.com/nextcloud/nextcloud/translate/#nl/client/182396083

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2019-10-04 08:10:55 +02:00
Daniel Kesselberg 4114fe68c9 Add server info to menu 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2019-10-01 16:16:20 +02:00
Felix Eckhofer 28da954aad
Fix typo 
Signed-off-by: Felix Eckhofer <felix@eckhofer.com>
 2019-10-01 08:25:24 +02:00
Dominique Fuchs 0a407a39b0
Merge branch 'master' into lnx-domainname-desktopfiles 2019-09-30 09:46:15 +02:00
Dominique Fuchs 3ad1c0e7a8 Created wrapper variable LINUX_APPLICATION_ID to clean up code 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-30 09:45:41 +02:00
Michael Schuster 00db94a73c
Revert "Fix White Window issue on Windows after Qt 5.12.4 upgrade" 
This reverts commit 8f616969ab.

Turns out that with the upgrade to the new released Qt 5.12.5 the issue
has been solved by the Qt developers, so this fix becomes obsolete.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-09-27 04:58:12 +02:00
Dominique Fuchs f52c330c22 cleanup and migration for location change 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-26 19:09:40 +02:00
Dominique Fuchs 67ed54671b Adapted for cmd version and added migration step for config file 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-26 17:47:01 +02:00
Dominique Fuchs fc6b895f52 moved default db sync file to Qt standard path AppDataLocation 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-26 17:09:24 +02:00
Camila Ayres 6f9256f290
Merge branch 'master' into lnx-domainname-desktopfiles 2019-09-26 13:26:22 +02:00
Dominique Fuchs 555c513acb
Merge branch 'master' into lnx-domainname-desktopfiles 2019-09-26 12:51:20 +02:00
Dominique Fuchs 96da4674f9 Updated .desktop file naming scheme 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-26 12:36:05 +02:00
Camila Ayres 570041e3b4
Merge branch 'master' into enhancement/change-share-menu-wording 2019-09-26 11:12:43 +02:00
Michael Schuster 8f616969ab
Fix White Window issue on Windows after Qt 5.12.4 upgrade 
Qt 5.12.4 seems to introduce a new bug on Windows, causing the settings window
to not be redrawn when re-opening it, for example by clicking at the tray icon.

As a workaround this fix starts a 100 ms timer to be fired once upon
QDialog::showEvent is called.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-09-26 04:59:17 +02:00
Camila San b9f0e444e8
Improve wording of the context menu in the file manager extension. 
'Share...' -> 'Share options'
'private link' -> 'internal link'
Removes 'to clipboard' from 'copy link' options.

Signed-off-by: Camila San <hello@camila.codes>
 2019-09-25 19:54:22 +02:00
Dominique Fuchs cd89efc24b Fixed some missing 'translatable' exclusions, added missing window titles in flow dialogs 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-25 14:02:59 +02:00
Camila San dd90ed9643
Changes wording in the share context menu. 
Instead of only Nextcloud it says "Share via Nextcloud".

Signed-off-by: Camila San <hello@camila.codes>
 2019-09-24 16:25:03 +02:00
Dominique Fuchs 0ff91574d2 show only 'shared with you by...' if it's not the current user itself 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-20 18:50:32 +02:00
Michael Schuster 30cff4e4f8
UI improvement: Message box: Delete / Keep all files 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-09-20 16:47:11 +02:00
Dominique Fuchs 31f3b322c8 Color corrections and sharer=self case implementation 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-19 10:04:52 +02:00
Dominique Fuchs 5a9fc02f07 Correcting autoraise for widget w/ background fill 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-18 13:40:14 +02:00
Dominique Fuchs 9d6780d6c1 Finishing PR #1154 adding note when sharing 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-18 13:37:49 +02:00
Michael Schuster 916d414543
Merge branch 'master' into ivan/remote-size-retrieved-race-condition 2019-09-16 19:17:00 +02:00
Michael Schuster b40e3e7b4e
Merge branch 'master' into msvc-warn-audit 2019-09-16 16:55:42 +02:00
Kilian Pfeiffer c46ca5c256
Merge branch 'master' into master 2019-09-16 13:41:15 +02:00
Dominique Fuchs a2a753a34b
Merge branch 'master' into fix_urlscheme_warning 2019-09-15 19:12:22 +02:00
Dominique Fuchs 7d4406254a
Merge branch 'master' into fix_urlscheme_warning 2019-09-15 09:56:16 +02:00
Dominique Fuchs 1eb61b7949 Fixed unused var 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-13 20:49:59 +02:00
Dominique Fuchs f6bac6cfdd Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow 2019-09-13 20:38:16 +02:00
Dominique Fuchs e8c8fe4223 Added slight svg transparency as requested in ref issue, fixed bg detection logic 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-13 20:38:03 +02:00
Dominique Fuchs 3659bca0ec
Merge branch 'master' into bugfixing-slideshow 2019-09-13 17:30:25 +02:00
Dominique Fuchs ace3da841c (Maybe) finished implementation of themed wizard buttons and accessibility refinements and thus implementation of helper fct. to retrieve themed QIcons. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-13 17:26:39 +02:00
Kilian Pfeiffer 457b0c3ab1
Merge branch 'master' into master 2019-09-13 08:57:06 +02:00
Dominique Fuchs 544229d1e8 [WIP] themed button implementation 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-13 08:24:02 +02:00
Dominique Fuchs af05db895c [WIP] Resource file and include changes as well as new control icons for wizard slide buttons 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-13 08:08:39 +02:00
Dominique Fuchs 1d96b102c0 Layout optimizations and tab access for self-hosting link 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-12 22:00:43 +02:00
Dominique Fuchs ff5bf8634f fix naming for slide navigation, adapted everywhere to be consistent 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-12 20:59:03 +02:00
Dominique Fuchs f49cd1850c Restructured layout, as the initial change were too broken (after additions through the last months) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-12 20:53:40 +02:00
Dominique Fuchs c873da75e4 Fixed wrong resource paths 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-12 17:52:31 +02:00
Dominique Fuchs 907f36bfcb Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow 2019-09-12 16:43:54 +02:00
Dominique Fuchs 04fedf83b4 Added newly created next/prev svg's and fixed reduntant layout parts in wizard 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-12 16:43:24 +02:00
Michael Schuster f3d774e2e5
Merge branch 'master' into fix-double-slashes 2019-09-12 05:09:21 +02:00
Dominique Fuchs febc035063
Merge branch 'master' into ivan/remote-size-retrieved-race-condition 2019-09-11 22:56:34 +02:00
Dominique Fuchs 4902751d02
Merge branch 'master' into bugfixing-slideshow 2019-09-11 22:17:57 +02:00
Dominique Fuchs 45bd869a15
Merge branch 'master' into master 2019-09-11 22:06:22 +02:00
Michael Schuster 905c1532fe
fix comment typo 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-09-11 17:31:16 +02:00
Dominique Fuchs dd130ede8f
Merge branch 'master' into master 2019-09-10 10:17:37 +02:00
Dominique Fuchs c662ff1902 fixed wrongly assigned pointer, didn't recognize class 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 20:06:32 +02:00
Dominique Fuchs a237493def Q_UNUSED for atm unused parameters 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 19:23:38 +02:00
Dominique Fuchs 3a0cd45782 Declared Q_UNUSED for as-of-now unused parameters. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 19:23:37 +02:00
Dominique Fuchs f08cc08eb2 Prevented warning regarding operator precedence - enhanced clarity by adding parentheses 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 19:23:36 +02:00
Dominique Fuchs e3685b951c removed reduntant /* within a comment 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 19:23:35 +02:00
Dominique Fuchs 6b04e2f77b Remove unnecessary argument 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 19:23:34 +02:00
Dominique Fuchs 2e8b7771b0 Prevent use of uninitialized folder pointer. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 19:23:32 +02:00
Dominique Fuchs 26e98d35e6 Added forgotten case when parsing log through gui. LockedFiles were not communicated. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-09 19:23:31 +02:00
Dominique Fuchs c585e81530 Moved macro definition due to timing issues while compiling when relying on header inheritance 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 19:46:08 +02:00
Dominique Fuchs c779098772 Conditional (based on Qt version) use of 'horizontalAdvance' to provide better UI experience. See https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 19:37:56 +02:00
Dominique Fuchs cc07ed1ee8 commit 222b2d did the trick. now streamlined use of https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION_CHECK 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 19:22:40 +02:00
Dominique Fuchs 222b2d8645 Further testing of cond. include of Qt library > 5.9. Utilized different macro. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 19:17:00 +02:00
Dominique Fuchs 48097801e8 Fixed logic error in QTLEGACY macro and added forgottin #if clause for header file 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 18:42:40 +02:00
Dominique Fuchs dca83aad45 Added macro definition and compile-time condition to support Qt < 5.9 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 17:33:34 +02:00
Dominique Fuchs 503b9de2a0 Fixed missing braces 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 15:49:53 +02:00
Dominique Fuchs a2d47cdec4 Qt: Fixed numerous deprecated calls by adapting newer ones 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 15:40:49 +02:00
Dominique Fuchs d6af025a46 Numoerous safe conversions implemented. Added additional Utility::convertSizeToDWORD for windows builds. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-08 11:33:20 +02:00
Michael Schuster 67107a4f5d
Fix double slashes in WebDAV URLs (account setup wizard) 
Sanitize URL paths to elaminate double-slashes in the URL path string,
used for the first connection by the account setup wizard.

Example: https://cloud.example.com/remote.php/webdav//

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-09-07 04:18:07 +02:00
Camila Ayres 081f9741e4
Merge branch 'master' into flow2-ui-qt5-compat 2019-09-06 17:32:40 +02:00
Camila Ayres a3beb9ba41
Merge branch 'master' into w10-start-logo 2019-09-06 17:02:06 +02:00
Camila Ayres 9ab5241459
Merge branch 'master' into w10-start-logo 2019-09-06 16:03:54 +02:00
Camila Ayres ec603b061d
Merge branch 'master' into logo-update 2019-09-06 15:42:02 +02:00
Michael Schuster b792a627e2
Qt5.5 compatiblity patch for login flow V2 + UI improvment 
Removes the right-click function for the "Re-open browser" buttons because
they are not intuitive for the user.

Adds a dedicated "Copy link" button.

Implements Qt 5.5 fixes based on: https://github.com/nextcloud/desktop/pull/1392

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-09-06 14:40:54 +02:00
Camila Ayres d36ddb752a
Merge branch 'master' into per-directory-ignore 2019-09-06 13:35:28 +02:00
Dominique Fuchs 680f70aa1a
Merge branch 'master' into w10-start-logo 2019-09-06 09:30:12 +02:00
Dominique Fuchs 4ea64bf9ee Final commit to resolve #22 (at least in desktop repo, final bits have to be set in client-building). 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-06 09:24:06 +02:00
Dominique Fuchs c1dd0079d9 Modified CMakeLists (src/gui/) to install VisualElements logo files in appropiate install output folder 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-06 08:35:46 +02:00
Dominique Fuchs f33d0a322d Renamed files for consistent sheme & use in CMakeLists (/src/gui) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-06 08:23:48 +02:00
Dominique Fuchs abb2711d26
Merge branch 'master' into logo-update 2019-09-05 21:38:17 +02:00
Dominique Fuchs 4b9e8274b5 Merge branch 'logo-update' of https://github.com/DominiqueFuchs/desktop into logo-update 2019-09-05 20:59:34 +02:00
Dominique Fuchs 7aefa5afaf Updated CmakeLists for gui part to correct old variable (OUTFILE_BASE[NAME]) that changed by recent update of AddAppIcon modules. Fixes wrong naming of resource pack in build output. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2019-09-05 20:58:05 +02:00
Michael Schuster 1b2e64788d
Merge branch 'master' into ssl-error-digests 2019-09-05 01:07:20 +02:00
Roeland Jago Douma b8ef78205a
Merge pull request #1256 from meskobalazs/master 
Marking unused strings as unstranslatable
 2019-09-04 23:06:08 +02:00
Martin Sucha 3e6422a889
Use newer digest algorithms in TLS error dialog 
MD5 has been broken for a long time now and SHA1 has been
deprecated as well. SHA1 is not used when issuing new
publicly trusted certificates since 1 January 2016[1] and
there are more and more effective attacks[2][3] against it,
so display SHA1 fingerprint only for old certificates
to encourage use of safer digests by users.

So, we display SHA-256 and SHA-512 fingerprints instead in
the common case.

[1] https://cabforum.org/wp-content/uploads/CA-Browser-Forum-BR-1.6.5.pdf
[2] https://shattered.io/static/shattered.pdf
[3] https://eprint.iacr.org/2019/459.pdf

Signed-off-by: Martin Sucha <git@mm.ms47.eu>
 2019-09-04 22:06:12 +02:00
Michael Schuster 61884d1ada
fix indents, add comment 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-30 05:35:36 +02:00
Michael Schuster b52292db92
Windows: Workaround for CredWriteW used by QtKeychain 
Saving all client CA's within one credential may result in:
  Error: "Credential size exceeds maximum size of 2560"

Client CA certificates are now being stored in separate slots
within the keychain and are being processed by a queue mechanism.

IMPORTANT TODO:
forgetSensitiveData(): Invoked by "Log out" & "Remove account"

- Remove client CA certs and KEY!
  (uncomment "//deleteKeychainEntries();" )

  Disabled as long as selecting another cert is not supported by the UI.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-30 04:56:01 +02:00
Roeland Jago Douma d584bedcb6
Also store the CACertificates of the client side certificate 
Else authentication will still fail in setups that have a chain of
certificates supplied.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-08-27 09:55:41 +02:00
Michael Schuster dbde585049
Adds SSL client cert storage to webflow + Login Flow v2 
The previous commit 50cd6af394 - Build a webflowcredentials
changed:

src/gui/wizard/flow2authcredspage.cpp in line 135 to use WebFlowCredentials
instead of HttpCredentials.
But the WebFlowCredentials class didn't include code to store and load SSL client
certificates and keys from the keychain.

This commit migrates the useful stuff from the old HttpCredentials class
into WebFlowCredentials.

Successfully tested on Windows. Please test on other systems and verify it's safe! :)

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-27 03:32:21 +02:00
Roeland Jago Douma 302ca0e04e
Fix some compiler warnings 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-08-26 20:41:14 +02:00
Roeland Jago Douma 50cd6af394
Build a webflowcredentials 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-08-26 20:04:23 +02:00
Michael Schuster fd8345ccbe
Login Flow V2: adds re-auth upon logout, improvements 
- Implements re-auth upon logout -> login
- Improves UI and security

TODO:
- SSL: Client certificate login is possible at the first time only but missing after relaunch

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-26 20:03:15 +02:00
Michael Schuster 7add98e9a3
UI: don't let Flow2 and OAuth hide the wizard 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-26 20:03:15 +02:00
Michael Schuster 628bab92c4
fix comment typo in webflowcredentials.cpp 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-26 20:03:15 +02:00
Michael Schuster 12f2ea6728
Login Flow V2: remove static test url 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-26 20:03:15 +02:00
Michael Schuster 8fa55b97b4
Login Flow V2: 1st implementation, cleanup 
This is the first draft of the Login Flow V2 authorization method.

See: https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#login-flow-v2

- Adds the Login Fĺow V2 auth method
- Adds ability to reinitiate a new request via UI

TODO:
- Implement re-auth upon logout -> login
- Improve UI
- SSL: Client certificate login is possible at the first time only but missing after relaunch

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-26 20:03:15 +02:00
Michael Schuster 2742411abd
Login Flow V2: 1st test-implementation 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2019-08-26 20:03:15 +02:00
Roeland Jago Douma e0a1d78441
Merge pull request #1225 from edent/patch-1 
Typo
 2019-08-19 15:39:10 +02:00