29ca1404cc
Fix Windows compilation broken after QML debugging fix.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2020-11-24 16:50:16 +02:00
92733e9069
Fix QML debugging by removing incorrect dependency
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2020-11-24 15:19:17 +02:00
0b731eb516
Revert "moved default db sync file to Qt standard path AppDataLocation"
...
This reverts commit fc6b895f52
2020-11-10 17:46:43 +00:00
18c1bc0bd6
Misc fixes for Windows 7
...
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
2020-10-28 06:24:53 +00:00
00e901f5a7
SocketAPI: Introduce conflict resolution actions #6252
...
For conflicts generally as well as new files in read-only directories
the context menu will now present delete and move options.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-22 16:40:10 +02:00
e5b307c81f
Update bookmarks location
...
Signed-off-by: renyhp <renyhp@disroot.org>
2020-10-12 15:02:00 +00:00
836de0358d
Add a function for a more friendly user agent string
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-08 05:55:47 +00:00
3077a1378b
syncjournaldb: index e2eMangledName column in metadata
...
Add an index on the e2eMangledName column in the metadata table
to speed up file sync by orders of magnitude on directories with
a large number of files.
Signed-off-by: Jan Schmidt <jan@centricular.com>
2020-09-03 22:56:14 +10:00
80cc196f6f
Enable bugprone-narrowing-conversions clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
5cec1373ad
Enable bugprone-macro-parentheses clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
1a0945a973
Enable all the misc clang-tidy check except one
...
This flagged mostly unused parameters. Didn't enable the
misc-non-private-member-variables-in-classes check as we got a lot of
those. Hopefully we'll get to fix them at some point but that feels too
early and too much work for now.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-31 09:14:09 +02:00
71fbc65eb0
Minor fix in text of warning and debug message.
...
Signed-off-by: Camila <hello@camila.codes>
2020-08-18 14:00:21 +02:00
89d4b6e12a
Include cstdint only when compiling C++ code
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
2020-08-14 06:15:42 +02:00
0e2af4b502
Enable the modernize-deprecated-headers check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-13 14:53:52 +02:00
2f8c29082a
Enable the modernize-use-equals-default check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-13 14:19:42 +02:00
cdf6e7d72b
Enable the modernize-user-nullptr check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-12 19:45:25 +02:00
c50a968a1e
Add more raw string literals missed previously
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-12 09:48:29 +02:00
7bb48a76c4
Add isE2eEncrypted column in the metadata table
...
This will allow to exploit the information of a directory being
encrypted or not during the discovery phase.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-07-06 05:27:14 +00:00
9a2d04720a
Also use mangled paths when looking for entries below a path
...
Otherwise on second sync we wouldn't find anything under a mangled path
and just end up thinking said files were removed.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-07-01 16:58:29 +00:00
0f21b625ab
Also check on mangled names when cleaning up the journal
...
Otherwise, after a first sync all the mangled entries would be removed
from the journal. On second sync it would be fine because we'd then have
seen the unmangled names because of the local files. Unfortunately
that'd mean reuploading them for nothing or trying to mkdir again on the
server for nothing... with a chance of using differently mangled names
(although I didn't spot it, I can't exclude it never happened).
This also led to weirdly getting stuck during sync when there was more
than one sync point.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-07-01 16:58:29 +00:00
f44df7f61a
Major multi monitor improvements and rewrite of tray window positioning
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2020-06-15 12:32:25 +00:00
456c1eadbe
Simplify nullptr comparisons where appropriate
...
Make the codebase consistent, we already have a lot of implicit pointer comparisons.
Exception: Stay explicit on return's, example:
return _db != nullptr;
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-06-11 00:27:30 +02:00
24177ec7e4
Change default autostart to hide gui
...
Signed-off-by: Rick van der Zwet <info@rickvanderzwet.nl>
2020-06-09 18:34:30 +02:00
ea16804751
Replace NULL by nullptr in all C++ files
...
We keep NULL in the pure C files in src/csync/std and test/csync.
We also replace Doxygen documentation referring to "NULL" to
"\c nullptr" (formatted as code).
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
2020-06-08 20:07:50 +02:00
bce93b052b
Use APPLICATION_ICON_NAME for autostart icon
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2020-06-08 20:06:00 +02:00
e3e262e42e
Use default member init when applicable
...
This also fixes a couple of warnings at places (out of order init for
instance) and a potential bug in the webflow credentials / qtkeychain
integration.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-06-03 16:10:39 +02:00
3bae570f29
Do not declare local variables without an initial value.
...
Signed-off-by: Camila San <hello@camila.codes>
2020-06-03 07:50:40 +00:00
a73a1f3927
Use = default for trivial ctors and dtors
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-25 21:33:24 +02:00
04a24c14a8
Use default member initializers in OCC::SyncJournalErrorBlacklistRecord
...
This allows to remove its explicit default constructor definition.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
2020-05-21 01:41:33 +02:00
3015ea5715
Use default member initializers in OCC::SyncJournalDb sub-structs
...
This allows to remove their explicit default constructor definitions.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
2020-05-21 01:32:16 +02:00
5543e4d834
Don't use int literals for bools
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-20 13:52:58 +02:00
712869db9a
Use auto to avoiding repeating type names
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-20 03:54:41 +02:00
dea6ebaa35
Use nullptr when appropriate
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-20 02:21:26 +02:00
c1189421c0
Use qEnvironmentVariableIsEmpty
...
clazy suggests that it is more efficient since it doesn't allocate.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2020-03-21 01:06:15 +01:00
dac1c9b413
Avatar, full user name and server address now reflected in QML gui, provided by C++ backend
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-12-03 07:26:59 +01:00
478281d853
Restructures and refactorings: New systray class, handling of current user selection, integration of user information in tray window header
2019-12-02 22:45:14 +01:00
8e8858178b
Merge branch 'master' into move-rtfiles
2019-10-27 17:49:22 +01:00
9618500975
fix tab spacing
...
Signed-off-by: Michael Schuster <michael@schuster.ms>
2019-10-27 17:25:50 +01:00
3ad1c0e7a8
Created wrapper variable LINUX_APPLICATION_ID to clean up code
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-30 09:45:41 +02:00
83918619cf
Corrected new .desktop file location in forgotten function
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-26 20:56:14 +02:00
fc6b895f52
moved default db sync file to Qt standard path AppDataLocation
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-26 17:09:24 +02:00
96da4674f9
Updated .desktop file naming scheme
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-26 12:36:05 +02:00
ab3d0141ec
initialize _modtime to prevent undefined usage
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-09 19:23:30 +02:00
7473cdf184
Removed disabling of msvc warning to prevent generating a unknown option for other compilers in turn. Now detect specifically GCC in ifdef
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-09 13:46:46 +02:00
c585e81530
Moved macro definition due to timing issues while compiling when relying on header inheritance
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-08 19:46:08 +02:00
222b2d8645
Further testing of cond. include of Qt library > 5.9. Utilized different macro.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-08 19:17:00 +02:00
f41eeaf6ec
Fixed another logic error -> logical to bitwise OR for QTLEGACY
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-08 18:51:54 +02:00
48097801e8
Fixed logic error in QTLEGACY macro and added forgottin #if clause for header file
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-08 18:42:40 +02:00
dca83aad45
Added macro definition and compile-time condition to support Qt < 5.9
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-08 17:33:34 +02:00
be7a524557
Indeed, DWORD is a special snowflake - only when on _WIN32
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2019-09-08 16:22:08 +02:00
allexzander