chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2025-12-24 10:38:23 +01:00
Code Activity
14,876 Commits 4 Branches 173 Tags
v3.0.2
Commit Graph

6961 Commits

Author SHA1 Message Date
Michael Schuster
0c040c9686 Merge pull request #1986 from nextcloud/properly_handle_denormalized_href_path 
Properly handle denormalized href
 2020-05-20 01:31:34 +02:00
Dominique Fuchs
9bfcdbae3a More code cleanupand style-preference adjustments. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-05-20 00:09:41 +02:00
Dominique Fuchs
aa13aa533a Removed publiclink param and corresponding if branch. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-05-19 23:29:59 +02:00
Dominique Fuchs
fa9dddf567 Code cleanup and this-> removals. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-05-19 23:25:21 +02:00
Kevin Ottens
4d1ff01654 Properly handle denormalized href 
In case of denormalized paths in the dav href (presence of . or .. in
the path) simple string startsWith comparison wasn't enough to know if
said href ended up in the right namespace. That's why we're now using
QUrl (pretending local file since we don't have a full URL in the href)
to normalize the path before comparison.

This could happen with broken proxies for instance where we would
wrongly validate the dav information resulting in potentially surprising
syncing and name collisions.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-18 19:33:34 +02:00
Kevin Ottens
3867e73fd5 Stop supporting Qt older than 5.12 
This both removes older Qt from the CI and also adjust all the
find_package calls in CMakeLists.txt

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-14 21:15:45 +02:00
Kevin Ottens
9000a880cb Don't silently kill debug messages 
The message handler globally installed by the logger silently drop
messages if the logger is not logging. On top of it, it doesn't log
debug messages by default.

Anything not logged is currently silently discarded. This can come as a
surprise to a developer trying to contribute for the first time and
adding some debug message for some reason.

We're thus trying to strike a middle ground which is that debug messages
get a regular output if the logger isn't interested in them.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-12 17:33:13 +02:00
Kevin Ottens
3b6ab2fa5a Indicate this is a dialog and not a regular window 
This is necessary with some window managers which would otherwise
consider they can reposition and resize the tray window as they wish
(yes, even though the user can't do it directly).

This is for instance the case if you use the tiling mode scripts of
KWin. It automatically ignores dialogs but might force windows to be
fullscreen (which would badly break the layout in our case).

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-07 09:39:08 +02:00
Kevin Ottens
de7021e85e Force the default QQC2 style 
This works around a bug in KDE's qqc2-desktop-style which breaks buttons
with icons not based on a name. By forcing a style name the KDE Plasma
platformtheme plugin won't try to force qqc2-desktops-style anymore.

Can be removed once the bug in qqc2-desktop-style is gone.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-07 02:07:02 +02:00
Sandro Knauß
6cdae6c19e Fix typos. 
Debian has a list of known typos in their checking tools.

Signed-off-by: Sandro Knauß <hefee@debian.org>
 2020-05-04 18:11:36 +00:00
Dominique Fuchs
671961e641 Added share icon from nc server repo, changed corresp. btn icon 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-04-27 08:06:58 +02:00
Dominique Fuchs
1c21bfdd7c Merge pull request #1922 from taaem/fix-recent-files 
Fix cloudprovider crashing - don't clear the _recentMenu pointer
 2020-04-25 13:37:29 +02:00
Dominique Fuchs
ddee26084d Merge pull request #1937 from ivaradi/xenial-compat 
Qt 5.5 compatibility #ifdef
 2020-04-25 12:23:25 +02:00
Dominique Fuchs
6df75328fd Merge pull request #1893 from nicolasfella/override 
override specifier missing
 2020-04-25 12:18:56 +02:00
Dominique Fuchs
210253ce35 Merge pull request #1889 from nicolasfella/applicationengine 
Use QQmlApplicationEngine instead of QQmlEngine
 2020-04-25 12:15:33 +02:00
Dominique Fuchs
4bd5e9d79b Implemented share functionality in tray window and changed actions / button logic. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-04-25 10:17:53 +02:00
István Váradi
3d44a71755 Qt 5.5 compatibility #ifdef 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2020-04-23 20:22:30 +02:00
Michael Schuster
6e220b10e4 Merge pull request #1883 from nicolasfella/contexticon 
[dolphin] Add icon to context menu
 2020-04-16 02:52:34 +02:00
Michael Schuster
45342d7952 Merge pull request #1882 from nicolasfella/detach 
Fix container detaching
 2020-04-15 21:28:51 +02:00
Michael Schuster
d0b698ed37 Merge pull request #1881 from nicolasfella/envempty 
Use qEnvironmentVariableIsEmpty
 2020-04-15 17:52:09 +02:00
Michael Schuster
ef42635c23 Merge pull request #1880 from nicolasfella/timeout 
Remove timeout parameter from showMessage
 2020-04-15 17:28:02 +02:00
Nicolas Fella
29fa924853 Use LINUX_APPLICATION_ID 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-04-14 21:38:33 +02:00
Tim Klocke
18615d0297 CloudProviders: Don't clear the _recentMenu pointer 
The _recentMenu pointer ref should not be freed, when building the
menu.
This fixes #1920 and #1818
 2020-04-10 23:08:07 +02:00
Nicolas Fella
b4d1a63c14 Use override 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-22 21:58:15 +01:00
Nicolas Fella
d54add6233 Use QQmlApplicationEngine 
This simplifies the code a bit.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-22 16:14:56 +01:00
Nicolas Fella
e1f4d17446 [dolphin] Add icon to context menu 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 02:04:42 +01:00
Nicolas Fella
1afda2b875 Fix container detaching 
Found by clazy

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 01:24:37 +01:00
Nicolas Fella
c1189421c0 Use qEnvironmentVariableIsEmpty 
clazy suggests that it is more efficient since it doesn't allocate.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 01:06:15 +01:00
Nicolas Fella
b84a1eeb8d Remove timeout parameter from showMessage 
It it never set by calling code so the default value of 10000 is used. It is only used in the call to QSystemTrayIcon, which uses 10000 as default value too.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 00:40:40 +01:00
Nicolas Fella
2f54e911b7 Add desktop-entry hint to notifications 
This allows the notification server to map a notification to the program's desktop file, which allows the server to do extra things. For example KDE Plasma adds the Nextcloud icon to the notification and allows to configure notifications from Nextcloud.

This is a standard hint from https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html#hints

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 00:25:33 +01:00
Michael Schuster
102369bfbe WebView: Add missing Q_OBJECT macros 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-11 01:18:11 +01:00
Michael Schuster
78776f81e4 Merge pull request #1847 from nextcloud/enh/updater 
Updater: Enhance UI, make build optional
 2020-03-10 15:53:47 +01:00
Michael Schuster
e833e86da6 Updater: Add CMake option BUILD_UPDATER to make the updater optional 
- Default: BUILD_UPDATER = NO

  To ease builds for distro packages and contributors (regardless of the specified update URL)

- Enable updater build for Drone CI and AppImage builds

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 02:34:55 +01:00
Michael Schuster
c812d896aa Fix OCUpdater: Also change status on network error or invalid XML 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 02:34:55 +01:00
Michael Schuster
c043a4e55c Updater UI: Implement auto-update option and update button 
- Add checkbox and button to UI
- Add new parameter autoUpdateCheck to ConfigFile

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 02:34:55 +01:00
Michael Schuster
555b41f300 Fix Legal notice dialog: Correct title and header font 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 00:41:59 +01:00
Michael Schuster
d8c407ac97 Settings dialog: Move detailed version info from About section to Legal notice dialog 
- Enlarge dialog widget to show full content
- Implement Dark-/Light-Mode switching (hyperlinks)

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-07 06:45:41 +01:00
Michael Schuster
2adde0fcca Settings dialog About section: Show minimal version info 
- Application name, version number, OS

  Example: Nextcloud Desktop Client
           Version 2.6.4 (macOS)

- Keep previous version info in new method Theme::aboutDetails()

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-07 06:38:09 +01:00
Michael Schuster
a471868d88 Version parameter: Show Qt platform plugin, OS and CPU arch 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-07 06:31:14 +01:00
Michael Schuster
6685722cb3 Add missing --version parameter to help screen 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-07 06:20:00 +01:00
Michael Schuster
0e60bf7c82 Merge pull request #1838 from nextcloud/enh/share_circles 
Allow sharing to circles: https://github.com/nextcloud/circles
 2020-03-06 02:17:36 +01:00
Roeland Jago Douma
3776a04206 Allow sharing to circles 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-05 10:44:06 +01:00
Michael Schuster
ff642085b4 Fix Explorer pinning: Add fallbacks for Shell commands (fixes #1599) 
See: #1599

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 18:45:58 +01:00
Michael Schuster
ab1099f13e WebFlowCredentials: Make username comparison case-insensitive (fix #1741) 
Fixes issue #1741

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 06:01:27 +01:00
Michael Schuster
aab735a595 Fix MSVC warnings: Missing return value, cast type 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 02:08:37 +01:00
Michael Schuster
f90f31756a Fix build with older Qt: Disable http2 for now due to Qt bug, add env var (upstream) 
Disable http2 for now due to Qt bug but allow enabling it via env var, see: https://github.com/owncloud/client/pull/7620
  and: https://github.com/nextcloud/desktop/pull/1806
Issue: https://github.com/nextcloud/desktop/issues/1503

Co-authored-by: XNG <Milokita@users.noreply.github.com>
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-02 01:47:00 +01:00
XNG
e2066b317b Disable http2 for now due to Qt bug 
So that user may continue to use http2 on their webpage

Signed-off-by: XNG <Milokita@users.noreply.github.com>
(cherry picked from commit dad95d4e4617211360bf2b4391e29c341e939844)
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-02 01:27:04 +01:00
Michael Schuster
eb7ed33d98 Merge pull request #1744 from nextcloud/qt-traygeometry-workaround 
Fix wrong window position on some linux DEs - worked around invalid g…
 2020-03-01 07:07:47 +01:00
Michael Schuster
712fef0cac Merge branch 'master' into qml-singleton-style and fix merge conflict 
Migrate changes in client.qrc to resources.qrc

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 06:47:46 +01:00
Michael Schuster
318c749558 Merge pull request #1736 from nextcloud/resource-cleanup 
Resource cleanup and application-wide svg usage
 2020-03-01 06:11:17 +01:00