chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2026-10-04 17:31:01 +02:00
Code Activity
11,836 Commits 4 Branches 173 Tags
v2.5.0-alpha
Commit Graph
5475 Commits
Author SHA1 Message Date
Dominik Schmidt d69e9ebf46 Apply branding to crashreporter resources file 2018-03-16 16:59:01 +01:00
Dominik Schmidt 24bf1b3629 Define APPLICATION_ICON_NAME fallback only in one place 2018-03-16 16:59:01 +01:00
Dominik Schmidt 94b0c9f78e Fix crash reporter icon 2018-03-16 16:59:01 +01:00
Christian Kamm a89508ba26 Minor header fixup 
To make the IDE happy.
 2018-03-16 13:41:57 +01:00
Olivier Goffart 0bf0f92949 OwnSql: Fixup after feedback for #6388 2018-03-15 19:30:21 +01:00
Olivier Goffart 04f8d0f2bc OwnSql: Put the SQL queries next to their use. 
This avoid haivng to modify 4 places when we want to add a query
 2018-03-15 19:30:21 +01:00
Olivier Goffart 4584e5d3c5 OwnSql: Some refactoring 
Use QByteArray for the query so we don't have to convert twice.
Automatically finish the query when the DB close, so we don't
have to call reset
 2018-03-15 19:30:21 +01:00
Olivier Goffart bbf1843865 SyncEngine: remove the "CSync" wording from the error messages 
They are confusing for the user.
Example in issue #6274
 2018-03-14 10:25:45 +01:00
Olivier Goffart b6aaa6fd2b CSync: Remove unused error codes 
None of the removed ERRNO code were ever set.
So none of the removed error hapenned anymore
 2018-03-14 10:25:45 +01:00
Olivier Goffart 0031e09410 CSync: reconcile never returns an error 2018-03-14 10:25:45 +01:00
Olivier Goffart 0071011ebf csync: remove CSYNC_PARAM_ERROR 
It does not make sense to report such error to the user.
Its goal was to show invalid use of the csync API, but this is now done
with asserts.
 2018-03-14 10:25:45 +01:00
Olivier Goffart 978a129eed csync: Simplify csync_walk_local_tree/csync_walk_remote_tree 
Small refactoring
 2018-03-14 10:25:45 +01:00
Christian Kamm 86b30e36c2 Merge remote-tracking branch 'origin/2.4' 2018-03-12 10:24:25 +01:00
Christian Kamm 427bb83f0d IssuesWidget: addItem performance improvement 
Ensure adding a new item isn't usually O(n) by keeping track of which
items have associated issues.
 2018-03-06 13:02:54 +01:00
Christian Kamm faec059a9b IssuesWidget: Don't allow two issues for the same file/folder 
This is intended to safeguard against invalidation bugs that cause the
same error to be added again for every sync run.
 2018-03-06 13:02:54 +01:00
Christian Kamm 641eddfbdf INSTRUCTION_IGNORE now carries a direction 
This allows IssuesWidget to selectively wipe only the 'Up' ignores
during selective local discovery.
 2018-03-06 13:02:54 +01:00
Christian Kamm 61869bb65e ProtocolItem: Adjust the way data is stored again 
The struct makes it easy to pack data and should consume less memory
overall.
 2018-03-06 13:02:54 +01:00
Christian Kamm 797473ba1f SyncResult: Make sure the number of conflicts is correct #6226 
If the SyncResult incorrectly believes that there are no conflicts, the
tray icon won't be correct and there will be no warning about unresolved
conflicts on the account.

Nevertheless, it's pretty awkward that the IssuesWidget is better
informed about pending conflicts than the Folder itself. This kind of
backwards data flow is very confusing.

Unfortunately the only alternative I see is to either keep track of
this information in two places (also in Folder), or create a common
data-holding class that can serve as a model instance for the issues
view as well as provide data directly to the Folder - which would
have been a much larger change.
 2018-03-06 13:02:54 +01:00
Christian Kamm f82d61ea19 SyncEngine: Make "local discovery?" question available 
Also fix the minor bug that was mentioned and add tests.
 2018-03-06 13:02:54 +01:00
Christian Kamm ec281654ae Issues tab: Invalidate issues selectively #6226 
Everything is invalidated later: after discovery, not before. In
addition entries that should only be invalidated when new local
discovery is done have that behavior now.
 2018-03-06 13:02:54 +01:00
Christian Kamm 52dfe589ba ProgressInfo: Add information for local vs remote discovery 2018-03-06 13:02:54 +01:00
Christian Kamm a5aebac6a7 slotFolderDiscovered: Fix 'local' always being false 
It was unused, so no harm done.
 2018-03-06 13:02:54 +01:00
Christian Kamm 13eb64584f Discovery: Error if properties are missing #6317 2018-03-06 13:01:53 +01:00
Olivier Goffart 7397565274 Propagator: remove a bunch of code related to the 'Shared' directory 
This no longer exists since the owncloud server 7.0 which we no longer
allow to connect to
 2018-03-01 14:48:00 +01:00
Olivier Goffart 4a19a8d644 ConnectionValidator: change the minimum server version 
Forbit connection with server older than 7.0. These server did not have
permission.

Also warn for anything older than 9.1. 9.0 is end of life according to
https://github.com/owncloud/core/wiki/Maintenance-and-Release-Schedule
 2018-03-01 14:48:00 +01:00
Olivier Goffart 302c60fe15 ConnectionValidator::Status use Q_ENUM 
So no need to have a manual conversion to QString
This is only used in debug message anyway.
 2018-02-26 16:11:46 +01:00
Olivier Goffart 22c7002d59 Move ClientProxy and ConnecitonValidator to gui 
They are using the ConfigFile and are used to control
when to sync rather than for the sync itself
 2018-02-26 16:11:46 +01:00
Olivier Goffart 9968142976 owncloudcmd: Do not overwrite the http timeout for json jobs 
The AbstractNetworkJob already has a sensible timeout that depends
on an environment variable.
No need to overwrite that with some arbitrary value. (The connection
validator does that because it could cause problems if two connection
validator were to run at the same time. Not a problem here)
 2018-02-26 16:11:46 +01:00
Olivier Goffart 75a6783a79 owncloudcmd: Do not read the proxy settings from the gui's config file 
The proxy settings for the owncloudcmd client can be set via the
--httpproxy command line argument. owncloudcmd should not depends
on the gui's config
 2018-02-26 16:11:46 +01:00
Olivier Goffart 18afe6a395 Folder: remove unused member 2018-02-26 16:11:46 +01:00
Olivier Goffart f6331951eb cmake: Remove references of now unused WITH_TESTING 
Issue #6318
 2018-02-21 11:28:31 +01:00
Olivier Goffart 7897b386b6 Utility::fsCasePreserving: remove UNIT_TESTING ifdef 
Since the release package will be build with unit test, we don't
want to query the env variable at every call to fsCasePreserving.
So only test the env variable at startup.
And the testutility can still change the value.

(The env variable is still used from t8.pl and maybe smashbox)

Issue #6318
 2018-02-21 11:28:31 +01:00
Christian Kamm 48dd8ed6c2 Partial local discovery: Fix scheduling logic 
A recent patch that touched the condition for deciding whether a
periodic full local discovery is necessary accidentally inverted the
condition.
 2018-02-20 18:07:28 +01:00
Christian Kamm 33306dcc38 Set launch-on-startup when the first account is set up 
The previous code would disable it when the second account was
configured.

See #6347
 2018-02-20 11:20:52 +01:00
Christian Kamm 6fc3bfc265 Conflicts: Add user name to conflict file name #6325 
For the case of uploading conflict files only.
 2018-02-20 10:10:34 +01:00
Christian Kamm 129b814931 SyncEngine: Use separate state for two unicode conversions 
It's unlikely that there were interaction effects but still seems safer
to use different conversion state for the path and rename_path.
 2018-02-20 10:01:47 +01:00
Christian Kamm 6c1a73b67a SyncJournal: Clear etag filter before sync 
Before, we only cleared the _avoidReadFromDbOnNextSyncFilter *after* a
sync which meant that we had to sync twice after selective sync setup.

Now, we clear the filter *before* a sync as well which allows the actual
next sync to write the correct etags to the db again - instead of only
the sync after that one.

Also expand on comments and rename _avoidReadFromDbOnNextSyncFilter to
_etagStorageFilter.
 2018-02-16 11:39:19 +01:00
Christian Kamm 4a47f7e438 Merge remote-tracking branch 'origin/2.4' 2018-02-16 10:17:19 +01:00
Christian Kamm 73062e21a3 SyncJournal: Don't use LIKE with paths 
Paths can contain the wildcards % and _ and that would lead to odd
behavior.

This patch also clarifies the behavior of avoidReadFromDbOnNextSync()
which previously dependend on whether "foo/bar" or "foo/bar/" was
passed as input.

Possibly affects #6322
 2018-02-15 09:56:43 +01:00
Christian Kamm e7e6584cab Sharing: Use maximum allowed permissions for new share #6346 
The client already computed the valid permissions, there was just a typo
that meant we didn't end up using them.
 2018-02-15 09:10:47 +01:00
Markus Goetz 13f1122c50 HTTP2: Only from Qt 5.9.4 #6285 2018-02-14 12:11:27 +01:00
Markus Goetz b5e129aa6b Theme: Icon cache explanation 2018-02-12 17:11:58 +01:00
Markus Goetz 9fc175231d Notifications: Immediately request when getting account online 2018-02-12 09:01:00 +01:00
Markus Goetz 4dd0a75cce SettingsDialogMac: Also start timer for notifications 2018-02-12 09:01:00 +01:00
Christian Kamm 22b19636e9 Don't delete contents behind directory junctions #6322 
QFileInfo::isSymLink() does detect reparse points that are symlinks but
returns false for junctions. The new function FileSystem::isJunction()
can detect those and is used to not recursively delete files inside
directories that are junctions.

See also https://bugreports.qt.io/browse/QTBUG-45344 and the
discussion in the PR https://codereview.qt-project.org/#/c/113019/.
 2018-02-09 09:15:29 +01:00
Markus Goetz 7860876b54 libcrashreporter-qt: Update submodule 2018-02-07 15:31:42 +01:00
Markus Goetz 7eb2dc21af ServerNotificationHandler: Properly create "Dismiss" URL 
Qt's JSON API is confusing, it doesn't convert to a string as one expects.
 2018-02-06 20:28:00 +01:00
Markus Goetz e338739d83 Fix compile for libcrashreporter-qt on macOS 2018-02-06 15:22:19 +01:00
Markus Goetz cedf72825b NO_SHIBBOLETH: Fix warning 2018-02-02 19:47:26 +01:00
Olivier Goffart e720f84005 owncloudcmd: Do not do the capability call when --nonshib is passed 
https://github.com/owncloud/enterprise/issues/2391
 2018-01-29 09:57:18 +01:00