Christian Kamm
d01065b9a1
Fix crash on account deletion
...
Calling forgetSensitiveData() on account deletion leads to a timer for
clearQNAMCache() being queued. Then the Account object is deleted. The
Credentials object stays alive for now because it has a deleteLater
deleter.
If the timer calls into a slot on the Credentials object, the _account
pointer will be invalid at this time.
As a workaround, move the target slot to Account - that way it will not
be called as the account object is already destroyed.
However since Account and Credentials are mutually dependent, it would
be much preferable if their lifetimes were linked, avoiding this
category of bugs.
The current behavior was introduced in
d40c56eda5
and I currently don't
understand why - maybe there's another way of dealing with the problem
that existed then.
2017-07-06 14:34:02 +02:00
Hefee
607287a9d6
Use OWNCLOUD_BIN_DIR directly in C++ code.
...
No need to do a STR replacement and the macro changing the path.
It actually broke test execution for Debian.
See https://bugs.debian.org/844937
2017-07-06 08:41:02 +02:00
Jenkins for ownCloud
01b3cde79b
[tx-robot] updated from transifex
2017-07-06 02:18:28 +02:00
Jenkins for ownCloud
5b0fea195d
[tx-robot] updated from transifex
2017-07-05 02:18:35 +02:00
ckamm
ce8341ca1f
Add a more functional error view #5516 ( #5861 )
...
* Add a more functional error view #5516
* Allow filtering of ignores and warnings to see only important bits.
* Navigate from the folder view to the error view by clicking on the
error list with the red background.
* Move the error list into its own ui file to allow easier extension.
* Fix issue around tab id handling in ActivitySettings.
* Rename "Action" column to "Issue".
* Change mouse cursor to hand over button and new error list area
Several OSX fixes provided by guruz.
2017-07-04 14:08:41 +02:00
Christian Kamm
9493e8f42e
AccountState: Add a 1-5min reconnection delay #5872
...
This only applies when the server was explicitly in maintenance mode or
when it was 503-unavailable.
2017-07-04 13:12:41 +02:00
Christian Kamm
b1aaf055b1
Blacklist: Don't let errors become warnings #5516
...
Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.
2017-07-04 13:07:51 +02:00
Olivier Goffart
34e75f80bc
main.cpp: Fix a compiler warning
...
src/gui/main.cpp:112:9: warning: bool literal returned from 'main' [-Wmain]
Used 1 to keep previous behaviour. I supposed the code was meant
to return success (0), but it does not really matter anyway.
2017-07-04 11:43:07 +02:00
Markus Goetz
f4d1a07b72
SyncEngine: Keep local size in SyncItem #5855
2017-07-04 11:42:44 +02:00
Christian Kamm
0db095e02a
SyncEngineTest: Fix test reliability
...
There was a rounding issue in the mtimes which sometimes resulted in an
off-by-one error. Caused by storing a full QDateTime in the FileInfo but
the mtime saved to the disk being truncated to seconds.
2017-07-04 09:57:22 +02:00
Jenkins for ownCloud
99f5580c37
[tx-robot] updated from transifex
2017-07-04 02:18:29 +02:00
Olivier Goffart
30095a0c3f
Fix check_csync_update
...
Commit 8160963110
changed the
SQL requests from csync to read from the checksumtype table.
So we need to add this table in the fake DB as well
2017-07-03 17:26:29 +02:00
Olivier Goffart
946c6967e9
Fix check_csync_exclude test
...
Commit 4697f0274f
remove .htaccess from
the sync-exclude.lst, so use another known excluded pattern
2017-07-03 17:26:29 +02:00
Piotr Mrowczynski
d1e00099dc
Classify chunked items correctly. Issue #5850
2017-07-03 14:41:53 +02:00
Markus Goetz
f49985697b
TestSyncJournalDB: Fix concurrent usage on CI
2017-07-03 14:08:39 +02:00
Christian Kamm
d018d460e3
csync tests: remove stray 'print'
2017-07-03 13:16:55 +02:00
Christian Kamm
851a3128e4
SyncEngine: Add unittest for SyncFileItem properties #5855
...
Checks instruction, direction, size, modtime for three common cases.
2017-07-03 12:54:24 +02:00
Christian Kamm
bdb8a4a0cb
csync tests: Fix for new owncloudcmd return codes
...
These were introduced in 4af45394f9
2017-07-03 11:48:38 +02:00
Jenkins for ownCloud
2a410217e2
[tx-robot] updated from transifex
2017-07-03 02:18:29 +02:00
Jenkins for ownCloud
2c0e820d9a
[tx-robot] updated from transifex
2017-07-02 02:18:29 +02:00
Jenkins for ownCloud
2326ea77e6
[tx-robot] updated from transifex
2017-07-01 02:18:28 +02:00
Jenkins for ownCloud
e6984f4058
[tx-robot] updated from transifex
2017-06-30 02:18:46 +02:00
Samuel Alfageme
aeea27b57b
Update central.owncloud.org link
...
Desktop client category was renamed, old link was 404 - see: https://central.owncloud.org/t/new-central-categories-you-decide
2017-06-29 17:54:42 +02:00
Samuel Alfageme
0f70bd7913
Update central.owncloud.org link
...
Desktop client category was renamed, old link was 404 - see: https://central.owncloud.org/t/new-central-categories-you-decide
2017-06-29 17:52:00 +02:00
Roeland Jago Douma
d810c13304
Merge pull request #27 from nextcloud-gmbh/wording-fix
...
Change wording from synchronizing to synchronized
2017-06-29 16:06:07 +02:00
Jan-Christoph Borchardt
3d2f5b6af1
Change wording from synchronizing to synchronized
2017-06-29 15:36:57 +02:00
Jenkins for ownCloud
e8f95743cc
[tx-robot] updated from transifex
2017-06-29 02:22:16 +02:00
Roeland Jago Douma
e240904a32
Merge pull request #33 from nextcloud-gmbh/update_doc
...
Point to NC doc repo
2017-06-28 16:44:31 +02:00
Roeland Jago Douma
58e0c6c630
Point to NC doc repo
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-06-28 16:40:42 +02:00
Roeland Jago Douma
501394ec6f
Merge pull request #32 from nextcloud-gmbh/oc_master
...
Oc master
2017-06-28 13:24:24 +02:00
Jenkins for ownCloud
fd0b8f3583
[tx-robot] updated from transifex
2017-06-28 02:22:09 +02:00
Jenkins for ownCloud
2a52b087fd
[tx-robot] updated from transifex
2017-06-27 02:22:10 +02:00
Jenkins for ownCloud
c70cdd61ca
[tx-robot] updated from transifex
2017-06-26 02:22:09 +02:00
Jenkins for ownCloud
5979db1270
[tx-robot] updated from transifex
2017-06-25 02:22:09 +02:00
Jenkins for ownCloud
0edc29dc72
[tx-robot] updated from transifex
2017-06-24 02:22:16 +02:00
Jenkins for ownCloud
5e4aaab91b
[tx-robot] updated from transifex
2017-06-23 02:22:09 +02:00
Markus Goetz
59bbbd5e66
Jenkinsfile: Some comments
2017-06-22 15:42:56 +02:00
Markus Goetz
1e98ba27c6
CSyncSqliteTest: Fix test
2017-06-22 15:11:49 +02:00
Markus Goetz
2244b35a6d
test_journal.db: Add checksumtype table
2017-06-22 15:11:49 +02:00
Christian Kamm
15ee7b39ac
Merge remote-tracking branch 'origin/2.3'
2017-06-22 14:06:31 +02:00
Jenkins for ownCloud
6a298d180d
[tx-robot] updated from transifex
2017-06-22 02:22:09 +02:00
Markus Goetz
cb7d74a063
Jenkinsfile: Compile in debug because of all the asserts
2017-06-21 15:11:55 +02:00
Markus Goetz
bc946053a3
Jenkinsfile: Compile in debug because of all the asserts
2017-06-21 15:02:26 +02:00
Markus Goetz
bfe095b065
Jenkinsfile: Run verbose tests
2017-06-21 12:18:21 +02:00
Markus Goetz
30bcd45a14
Jenkinsfile: Run full testing
2017-06-21 12:13:01 +02:00
Markus Goetz
cd5ad7db64
Jenkinsfile: Run full testing
2017-06-21 12:12:08 +02:00
Markus Goetz
1332e7d66a
Jenkinsfile: 2.3.3 will ship with Qt 5.
...
This should fix the current CI run too
2017-06-21 11:59:24 +02:00
Markus Goetz
f44d3914ef
owncloudcmd: Explain --debug parameter
2017-06-21 10:01:32 +02:00
Jenkins for ownCloud
949e8e5f51
[tx-robot] updated from transifex
2017-06-21 02:22:08 +02:00
Christian Kamm
1e78a14f1a
Ignore ui: Add the sync journal patterns #5844
...
The ignore patterns for the journal files are hardcoded. Add them to
the UI to make them discoverable.
2017-06-20 13:35:34 +02:00