1729e1a94c
Declared Q_UNUSED for as-of-now unused parameters.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 3a0cd45782
2019-10-17 19:38:55 +02:00
60859714ae
Prevented warning regarding operator precedence - enhanced clarity by adding parentheses
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit f08cc08eb2
2019-10-17 19:38:55 +02:00
b5fcfd918b
removed reduntant /* within a comment
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit e3685b951c
2019-10-17 19:38:54 +02:00
44176be964
Remove unnecessary argument
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 6b04e2f77b
2019-10-17 19:38:54 +02:00
3935866052
Prevent use of uninitialized folder pointer.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 2e8b7771b0
2019-10-17 19:38:54 +02:00
1e9c45222c
Added forgotten case when parsing log through gui. LockedFiles were not communicated.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 26e98d35e6
2019-10-17 19:38:54 +02:00
adc3b1a25c
initialize _modtime to prevent undefined usage
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit ab3d0141ec
2019-10-17 19:38:54 +02:00
9ae0417cad
Use return type to prevent warning and determine chown success. Added TODO
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 39df36c247
2019-10-17 19:38:54 +02:00
03453d6800
Removed disabling of msvc warning to prevent generating a unknown option for other compilers in turn. Now detect specifically GCC in ifdef
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 7473cdf184
2019-10-17 19:38:53 +02:00
1ac9c4ea8d
Moved macro definition due to timing issues while compiling when relying on header inheritance
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit c585e81530
2019-10-17 19:34:19 +02:00
986bb49a88
Conditional (based on Qt version) use of 'horizontalAdvance' to provide better UI experience. See https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit c779098772
2019-10-17 19:34:19 +02:00
8f39c4140e
commit 222b2d did the trick. now streamlined use of https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION_CHECK
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit cc07ed1ee8
2019-10-17 19:34:18 +02:00
9c7903868f
Further testing of cond. include of Qt library > 5.9. Utilized different macro.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 222b2d8645
2019-10-17 19:34:18 +02:00
8ee1adf058
Fixed another logic error -> logical to bitwise OR for QTLEGACY
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit f41eeaf6ec
2019-10-17 19:34:18 +02:00
27fb1fcd53
Fixed logic error in QTLEGACY macro and added forgottin #if clause for header file
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 48097801e8
2019-10-17 19:34:18 +02:00
29cc5c1e7f
Added macro definition and compile-time condition to support Qt < 5.9
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit dca83aad45
2019-10-17 19:34:18 +02:00
29bb76019f
Indeed, DWORD is a special snowflake - only when on _WIN32
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit be7a524557
2019-10-17 19:34:18 +02:00
bf6d57f327
Fixed wrongly formatted args for win32 linker flags resulting in 'unrecognized option' for all of them. Remark: /WL is for VS only, useless (and not necessary for msvc cmd)
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 0827ff0995
2019-10-17 19:34:17 +02:00
eb5ec05ef8
Fixed missing braces
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 503b9de2a0
2019-10-17 19:34:17 +02:00
c723028eae
Qt: Fixed numerous deprecated calls by adapting newer ones
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit a2d47cdec4
2019-10-17 19:34:17 +02:00
5d024fdf33
Added cmake preprocessor definitions when using msvc regarding the 'safe' versions of CRT functions
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit ba74c24d8f
2019-10-17 19:34:17 +02:00
ed99cb297b
Use existing fct for RegKeyQuery instead of redundant subroutine
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit d60a216982
2019-10-17 19:34:17 +02:00
a0e794a7f1
Numoerous safe conversions implemented. Added additional Utility::convertSizeToDWORD for windows builds.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit d6af025a46
2019-10-17 19:34:16 +02:00
0761342840
Corrected namespace when calling convertSizetoUint
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 82fa10c227
2019-10-17 19:34:16 +02:00
4da9123b67
Renamed conversion function to make intention more clear. Also defaulted to 'controlled truncation' to not stupidly crash. TBD/TODO: Better handling for such things.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 46e0a05078
2019-10-17 19:34:16 +02:00
c7158e2c7c
Selectively and temporary disabled warning about unknown preprocessor declarative for msvc when using specific GCC instruction.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 8329de4cee
2019-10-17 19:34:16 +02:00
4adc45483a
Implemented Utility::convert function to convert size_t -> uint safely and on the fly. Often necessary for Qt and WIN32 functions. Using this will not generate compiler warnings of possible truncation. First call implemented in ownsql.cpp
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit b4dee67bf5
2019-10-17 19:34:16 +02:00
ae0ff6b3e3
Fixed broken overloading mechanism of variadic templates. See code comment for further information.
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 5ae3435fe6
2019-10-17 19:34:16 +02:00
dc6d2e6a6d
usage of UINT as iterator here because comparing with UINT retval from DragQueryFile
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 9a256fcbfe
2019-10-17 19:34:15 +02:00
5127f50d1e
Removed redundant (and wrong in terms of it's value) definitions for WINVER/_WIN32_WINNT
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 112d2bfe11
2019-10-17 19:34:15 +02:00
a26f2a7359
Removed redundant (and wrong in terms of it's value) definitions for WINVER/_WIN32_WINNT
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 69a11a7ec1
2019-10-17 19:34:15 +02:00
42f1f445a9
Removed redundant (and wrong in terms of it's value) definitions for WINVER/_WIN32_WINNT
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 3960ffea3f
2019-10-17 19:34:15 +02:00
51304485c3
Updated WINVER/_WIN32_WINNT from 0x0600 to 0x0601 (e.g. Server 2008/Vista to 7) as 7 is reasonable and noted everywhere as requirement
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 78543deee4
2019-10-17 19:34:12 +02:00
63cc6edddd
fix qt warning about registering a URL sheme first.
...
Qt recommends to register a URL scheme before installing it.
I don't know the impact of the not registering before instaling but I
think the change is pretty harmles.
See:
https://doc.qt.io/qt-5/qwebengineurlscheme.html#registerScheme
Signed-off-by: Björn Bidar <theodorstormgrade@gmail.com>
(cherry picked from commit cea0d519a4
2019-10-17 18:08:39 +02:00
58abebe9ac
Fixed e2e key transmission issue after generation (forgotten content type on sendrequest())
...
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit a35b346e62
2019-10-17 17:33:41 +02:00
1182ae9e26
Merge pull request #1515 from nextcloud/qt5-mac-5.12-prepare
...
Add new "styles" plugin to macOS deployment script for Qt 5.12.5
2019-10-15 23:58:26 +02:00
3407174c2f
Add new "styles" plugin to macOS deployment script for Qt 5.12.5
...
Qt 5.12 needs this library to use the correct style for Light / Dark Mode:
styles/libqmacstyle.dylib
The interface looks like from the 1990's without this library ;-)
Signed-off-by: Michael Schuster <michael@schuster.ms>
2019-10-14 02:01:56 +02:00
913894eaa5
Merge pull request #1496 from nextcloud/backport/1495/stable-2.6
...
[stable-2.6] Add a 'Content-Length: 0' header to initial POST requests
2019-10-10 08:11:43 +02:00
db91552578
Add a 'Content-Length: 0' header to initial POST requests
...
The webserver lighttpd rejected POST requests without a Content-length
header with "411 Length Required".
See: https://github.com/nextcloud/desktop/issues/1473
Signed-off-by: Michael Schuster <michael@schuster.ms>
2019-10-10 06:09:59 +00:00
286e45bafe
Bump version to 2.6.0
...
Signed-off-by: Camila San <hello@camila.codes>
(cherry picked from commit e0b32c19e4
2019-10-05 15:13:59 +02:00
aa1bb470e6
fix comment typo
...
Signed-off-by: Michael Schuster <michael@schuster.ms>
(cherry picked from commit 905c1532fe
2019-10-05 14:56:48 +02:00
3be9adde4b
Fix double slashes in WebDAV URLs (account setup wizard)
...
Sanitize URL paths to elaminate double-slashes in the URL path string,
used for the first connection by the account setup wizard.
Example: https://cloud.example.com/remote.php/webdav//
Signed-off-by: Michael Schuster <michael@schuster.ms>
(cherry picked from commit 67107a4f5d
2019-10-05 14:56:15 +02:00
41d97abd08
Merge pull request #1475 from ivaradi/stable-2.6
...
Remove kdelibs5-dev from the build dependencies for Eoan
2019-10-05 09:33:00 +02:00
6bc232c9b4
Remove kdelibs5-dev from the build dependencies for Eoan
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
2019-10-05 09:31:55 +02:00
d4a0be92ae
Merge pull request #1466 from ivaradi/stable-2.6.0
...
Trigger builds for tagging on the 2.6.0 branch
2019-10-04 20:19:38 +02:00
75bf41fba1
Trigger builds for tagging on the 2.6.0 branch
...
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
2019-10-02 19:18:13 +02:00
a2bfd5039c
Revert "Fix White Window issue on Windows after Qt 5.12.4 upgrade"
...
This reverts commit aeba2e4de6
2019-09-27 15:04:14 +02:00
a9ee7472b9
Improve wording of the context menu in the file manager extension.
...
'Share...' -> 'Share options'
'private link' -> 'internal link'
Removes 'to clipboard' from 'copy link' options.
Signed-off-by: Camila San <hello@camila.codes>
2019-09-26 13:24:10 +02:00
211d6cb162
UI improvement: Message box: Delete / Keep all files
...
Signed-off-by: Michael Schuster <michael@schuster.ms>
2019-09-26 12:05:34 +02:00
501c353291
Fix for #1382 "linux client crashes for no discernable reason"
...
There in no "return" in
PropagateUploadFileCommon::slotStartUpload in if (prevModtime != _item-
>_modtime) {... }
There is possibility that
PropagateItemJob::done(status, errorString)
maybe called two times from PropagateUploadFileCommon::slotStartUpload
1. in if (prevModtime != _item->_modtime) {... }
2. in if (fileIsStillChanging(*_item)) {..}
if changes in files are frequent the second call is possible.
This two calls has effect in PropagatorCompositeJob::slotSubJobFinished
and job is removed two times in _runningJobs.remove(i);
(the second time with argumetnt -1 (because first call removed job).
This return was removed in commit
efc039863b
2019-09-26 12:03:20 +02:00
Dominique Fuchs