chylex/Nextcloud-Desktop
1
0
Fork 0
mirror of https://github.com/chylex/Nextcloud-Desktop.git synced 2026-10-05 02:53:40 +02:00
Code Activity
17,398 Commits 4 Branches 173 Tags
master
Commit Graph
17398 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kevin Ottens 310693be2c Enable all the other bugprone clang-tidy checks 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens aa63889e5b Enable bugprone-terminating-continue clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens 0909f00a8b Enable bugprone-too-small-loop-variable clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens 80cc196f6f Enable bugprone-narrowing-conversions clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens 5cec1373ad Enable bugprone-macro-parentheses clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens 608bf025e6 Enable bugprone-forward-declaration-namespace clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens c8ea848596 Enable the bugprone-branch-clone clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens 4cb9bec23a Enable the bugprone-argument-comment clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Nextcloud bot 4e61181b45 [tx-robot] updated from transifex 2020-09-01 03:26:29 +00:00
Kevin Ottens 4ee80bfe2e Merge pull request #2345 from nextcloud/use_httpd_unix-directory_mimetype_for_e2ee_folders 
Use httpd/unix-directory mimetype for E2EE folders
 2020-08-31 13:11:51 +02:00
Kevin Ottens eb76682b1e Use httpd/unix-directory mimetype for E2EE folders 
We don't do much with that mimetype on our end, but other clients
somehow don't expect inode/directory to let's lie. ;-)

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-31 10:08:48 +00:00
Kevin Ottens 1a0945a973 Enable all the misc clang-tidy check except one 
This flagged mostly unused parameters. Didn't enable the
misc-non-private-member-variables-in-classes check as we got a lot of
those. Hopefully we'll get to fix them at some point but that feels too
early and too much work for now.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-31 09:14:09 +02:00
Nextcloud bot 7236af78af [tx-robot] updated from transifex 2020-08-31 03:25:49 +00:00
Nextcloud bot b01299349b [tx-robot] updated from transifex 2020-08-30 03:24:23 +00:00
Nextcloud bot 78fa448c7e [tx-robot] updated from transifex 2020-08-29 03:26:40 +00:00
Michael Schuster 75aa94be79 Merge pull request #2336 from nextcloud/jospoortvliet-patch-1 
Some changes to the template...
 2020-08-29 00:14:16 +02:00
Jos Poortvliet 01a722821a Some changes to the template... 2020-08-28 21:54:10 +02:00
Nextcloud bot e45be65996 [tx-robot] updated from transifex 2020-08-28 03:26:44 +00:00
Nextcloud bot 1f536a7e1b [tx-robot] updated from transifex 2020-08-27 03:29:43 +00:00
Michael Schuster 5945f18d5a Remove remaining QLinkedList includes in addition to #2300 
Now the only remaining reference is in:

src/3rdparty/libcrashreporter-qt/3rdparty/drkonqi-parser/backtraceparser.cpp:269:        || line.functionName().startsWith(QLatin1String("QLinkedList")

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-27 03:12:09 +02:00
Michael Schuster bd519ffe7a Adapt code style in addition to #2300 
- Use "!empty()" instead of "size() > 0" in std::list
- Add comments for namespace brackets

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-27 01:31:06 +02:00
Michael Schuster e973c43a7a Merge pull request #2300 from chenecharry/master 
Support client builds on VS2019 (QLinkedList is deprecated)
 2020-08-27 01:27:09 +02:00
Michael Schuster 24a2b21c2c Merge branch 'master' into master 2020-08-27 01:12:30 +02:00
Nextcloud bot 07bde18c3a [tx-robot] updated from transifex 2020-08-26 03:29:53 +00:00
V.C b20ea25201 Code review changes implemented 
Code review changes implemented for bandwidthmanager.cpp
1. Use auto instead of size_t
2. Check for empty instead of size comparisions

Signed-off-by: V.C <c******@rediffmail.com>
 2020-08-26 02:45:20 +00:00
V.C af1bb7e98c Support client builds on VS2019 
Scenario: Build fails on Qt 5.15.0 + VS2019 16.7.2
Root cause: QLinkedList seems to be depreciated. Advise to use std::list instead.
Fix: Used std::list insead of QLinkedList.

Signed-off-by: V.C <c******@rediffmail.com>
 2020-08-26 02:45:20 +00:00
Michael Schuster c1cb3e6c49 Merge pull request #2309 from nextcloud/update-docs-page-title 
Update copyright date and version displayed in the page title.
 2020-08-25 21:07:18 +02:00
Camila cbea02390e Update copyright date and version displayed in the page title. 
- This is the title displayed at https://docs.nextcloud.com/desktop/x.y

Signed-off-by: Camila <hello@camila.codes>
 2020-08-25 18:50:14 +00:00
Michael Schuster c4b87cd465 Merge pull request #2313 from nextcloud/update-issue-template 
Add --logdebug parameter to instructions in issue_template for Github.
 2020-08-25 20:48:59 +02:00
Camila c746e65a8e Update issue_template with information about logs, e2ee versions and code of conduct. 
Signed-off-by: Camila <hello@camila.codes>
 2020-08-25 15:11:34 +00:00
Camila 6c36041829 Add --logdebug parameter to instructions in issue_template for Github. 
Signed-off-by: Camila <hello@camila.codes>
 2020-08-25 15:11:34 +00:00
Nextcloud bot c687fb0291 [tx-robot] updated from transifex 2020-08-25 03:32:20 +00:00
Nextcloud bot d4183aebb3 [tx-robot] updated from transifex 2020-08-24 03:31:03 +00:00
Nextcloud bot 7af6e18491 [tx-robot] updated from transifex 2020-08-22 03:28:48 +00:00
Michael Schuster 5b8ec5cede Merge pull request #2302 from ivaradi/no-eoan 
Do not build for Eoan
 2020-08-22 00:55:31 +02:00
István Váradi cd303e313d Do not build for Eoan 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2020-08-21 18:54:56 +02:00
Nextcloud bot 32880507b2 [tx-robot] updated from transifex 2020-08-21 03:30:20 +00:00
Michael Schuster b60239c29e Merge pull request #2288 from nextcloud/enh/windows-shellext 
Windows shell extensions: Use custom GUIDs and prepare for MSI
 2020-08-20 21:11:34 +02:00
Michael Schuster 4df8db4ff6 Fix spacing 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster db05f65e0d Windows shell extensions: Add WiX (MSI) fragment 
Use CMake to generate a WXI fragment to handle the DLL registration and file deployment for the shellext components.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster 11632da7ea Windows shell extensions: Change NCUtil Pipe name from ownCloud to APPLICATION_EXECUTABLE 
Avoid interference with foreign pipes as this is always a bad idea ;p

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster 0ba5df597f Windows shell extensions: Rename all files and classes from OC* to NC*, update version info 
This also ensures a clear separation in the system registry.

SelfReg is not recommended by Microsoft and will be handled by the MSI package to allow proper Repair and Uninstall.
However, we keep it for backward compatibility with the NSIS installer.

For details see:
https://stackoverflow.com/questions/364187/how-do-you-register-a-win32-com-dll-file-in-wix-3#364210
https://docs.microsoft.com/en-us/windows/win32/msi/selfreg-table#remarks

Another fix by this commit:
The "Version" registry value in the NCOverlays self reg should be a key and not a value.

Details: https://wixtoolset.org/documentation/manual/v3/xsd/wix/class.html

Example:

  [HKCR\CLSID\{01234567-89AB-CDEF-0123-456789ABCDEF}\Version]
  @="1.0.0.0"

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster 8ce13b7bdb Windows shell extensions: Use custom GUIDs via CMake and prepare MSI reg 
Previously side by side installation with ownCloud or other NC custom builds would break the shell integration because the same GUIDs and registry keys were used.

Now we specify our custom GUIDs in NEXTCLOUD.cmake and use CMake to generate a header file and WiX (MSI) include file with these constants.

Note: Using generators like "guidgen" or "uuidgen" ensures that GUIDs are unique, as manual changes are not guaranteed to be.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth 4675869fb3 Remove dead code 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth bfd7707ff4 2.7 has less automatic includes on Windows 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth 34e9e2f288 Cleanup Windows shell extensions 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth 6c9a31f6ee Remove outdated visual studio projects, we now use cmake 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Dominik Schmidt 13d4b91935 Avoid warning because /MT overrides /MD flag 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Dominik Schmidt e4b53b12e1 Make OCUtil helper lib static and link it statically against crt 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Olivier Goffart 906556640d Windows Shell Integration: Don't limit the size of the buffer 
Otherwise we can't have operation that has many many filename

As reported in #6780

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00