Commit Graph
8567 Commits
Author SHA1 Message Date
Alex Plate e36131b38b [VIM-2929]: Adding logging for tracing the keyStack 2023-12-28 11:24:13 +02:00
Alex Plate b67868afde Extract the companion object into the top level
As the inspection says, due to eager companion object initialization, it's better to keep such things on the top level
2023-12-28 10:03:50 +02:00
Alex Plate 328fdee281 Add comment about autocompletion in macros 2023-12-22 10:55:16 +02:00
Matt EllisandAlex Pláte 8ab43e98fe Remove unnecessary keeping visual mode flag
The value was only ever set to false.
2023-12-22 10:55:00 +02:00
Matt EllisandAlex Pláte 4f407ccc03 Remove unused multikey-undo flag
It's uncertain what this was introduced for, and it's no longer used for any behaviour
2023-12-22 10:55:00 +02:00
Matt EllisandAlex Pláte 5f3fddd3e4 Remove unnecessary post process method
We no longer need to post process the selection because it is up to the operator implementation to end in the correct mode
2023-12-22 10:55:00 +02:00
Matt EllisandAlex Pláte 392f3b536d Remove unnecessary mode reset
Visual mode should already have been exited before executing the operator. The operator's implementation is responsible for handling the final mode
2023-12-22 10:55:00 +02:00
Matt EllisandAlex Pláte 155de2b396 Remove always true check and always exit visual 2023-12-22 10:55:00 +02:00
Matt EllisandAlex Pláte 6c9930ac2a Removes unnecessary 'exit visual' command flag
This flag is only used to modify the behaviour of visual operators, but all visual operators have the flag, which means it's unnecessary. The only behaviour for visual operators now is to exit visual mode.

Note that visual motions are implemented separately, and handle their own visual mode requirements (e.g. MotionArrowLeftAction).
2023-12-22 10:55:00 +02:00
Matt EllisandAlex Pláte 9dddf4f4bc Minor cleanup 2023-12-22 10:55:00 +02:00
IdeaVim Bot 314506c15c Update changelog after merging PR 2023-12-22 07:34:37 +00:00
chylexandAlex Pláte 673222da6c Prevent code completion popup from appearing after running a macro 2023-12-22 09:32:33 +02:00
Alex Plate 58b97e6361 Get back to regular agents 2023-12-19 10:45:40 +02:00
Alex Plate 8bc2032b07 Do not override all artifact rules 2023-12-19 10:44:49 +02:00
Alex Plate 40d4354dfc Avoid issue with blocked execution due to starting a coroutine in ProjectActivity 2023-12-19 10:30:14 +02:00
Alex Plate 27f2f5bb2b Migrate KeymapChecker to ProjectActivity 2023-12-19 10:08:01 +02:00
Alex Plate 490b934269 Turn on leaks check on local development 2023-12-19 10:00:10 +02:00
Alex Plate e2e2b4d176 Proper tear down with tests with mock 2023-12-19 09:59:54 +02:00
Alex Plate 7a1763bbee Dispose carets of custom editor in test 2023-12-19 02:21:34 +02:00
Alex Plate ca8904b6bb Refactor common extension tests in order to avoid double remove of extension.
Firstly extension is removed in tearDown, then as disposable of VimPlugin.getInstance()
2023-12-19 02:21:18 +02:00
Alex Plate 6384b28689 Refactor listeners to avoid manual unregister
However, manual removal of listeners may cause "double" remove in cause the user turns off the plugin and then closes IDE: firstly listener is removed manually, and then by dispose call
2023-12-19 01:44:57 +02:00
Alex Plate e661466558 Small refactorings on IdeaSelectionControl
They are done because if we don't set timer to null after tests, we have a leaked project
2023-12-19 00:12:54 +02:00
Alex Plate 8faf2beba4 Refactor IdeaRefactorModeHelper for splitting logic into change calculation and change apply 2023-12-19 00:12:54 +02:00
Alex Plate fb29319ec6 Add VimPlugin.isNotEnabled function to simplify a lot of checks for !isEnabled() 2023-12-19 00:12:54 +02:00
Alex Plate 7779d7d193 This Easter egg caused a bug that a disposable balloon was leaked.
As smart people suggest, it's better not to have easter eggs at all.
2023-12-19 00:12:54 +02:00
Alex Plate 2c5246b62f Avoid project leak via KeyEvent 2023-12-19 00:12:53 +02:00
Alex Plate e43a3f4518 Avoid disposable leak because of widget
With the call that was removed, we initialized the widget too early, and the widget wasn't properly registered as disposable. This caused disposable leak.
Also, there is no understanding why this code was used to update the widget. The call for ShowCmd.update seems enough
2023-12-19 00:12:53 +02:00
Alex Plate b5716f7a6d Fix incorrect error handling
Since TestLoggerAssertionError is not available in production, we can't catch this exception in production code
2023-12-19 00:12:53 +02:00
Alex Plate fac5a3cc6f Remove XYZ testing configuration 2023-12-19 00:12:53 +02:00
Alex Plate 671793078a Revert "Downgrade version of IJ plugin"
This reverts commit 258203f400.
2023-12-19 00:12:53 +02:00
Alex Plate 4f5ea1696f Revert "Add back-to-232 branch"
This reverts commit 20832f11b6.
2023-12-19 00:12:53 +02:00
Alex Plate b3e47e3bac Revert "Disable some tests"
This reverts commit 95838d045d.
2023-12-19 00:12:52 +02:00
IdeaVim Bot d67e990065 Update changelog. Action id - 7231244078 2023-12-16 10:06:23 +00:00
Alex Plate 7fb6f4b47f Revert "Refactor key cache"
This reverts commit e159866d3b.
2023-12-15 18:49:18 +02:00
Alex Plate df3b435a1f Revert "Clean swing timer"
This reverts commit 5b65f1b544.
2023-12-15 18:49:18 +02:00
Alex Plate 5b65f1b544 Clean swing timer 2023-12-15 18:43:49 +02:00
Alex Plate e159866d3b Refactor key cache 2023-12-15 18:40:04 +02:00
Alex Plate aa0ce71612 Temporally switch to larger agents 2023-12-15 18:24:31 +02:00
Alex Plate 522e547f99 Clean up patch 2023-12-15 17:45:01 +02:00
Alex Plate 9430341d4e Add artifact rules for all builds 2023-12-15 17:42:08 +02:00
Alex Plate 95838d045d Disable some tests 2023-12-15 17:17:01 +02:00
Alex Plate 20832f11b6 Add back-to-232 branch 2023-12-15 17:01:08 +02:00
Alex Plate 258203f400 Downgrade version of IJ plugin 2023-12-15 16:52:59 +02:00
Alex Plate 3b1768fa4e Update new build configuration name 2023-12-15 16:41:48 +02:00
Alex Plate 23a3085bad Add xyz branch for testing 2023-12-15 16:34:38 +02:00
Alex Plate 78c12e0ea6 Switch to stable version of IDEA 2023-12-15 16:34:38 +02:00
Alex Plate 997cb85663 Do not log LOG.error during test execution 2023-12-15 16:34:37 +02:00
aleksei.plate@jetbrains.comandteamcity 968d5eabfa TeamCity change in 'Ideavim' project: general settings of 'Tests for IntelliJ Latest EAP' build configuration were updated 2023-12-15 14:26:47 +00:00
aleksei.plate@jetbrains.comandteamcity 590ce1f7ed TeamCity change in 'Ideavim' project: runners of 'Tests for IntelliJ Latest EAP' build configuration were updated 2023-12-15 14:19:03 +00:00
aleksei.plate@jetbrains.comandteamcity 416a8838e4 TeamCity change in 'Ideavim' project: runners of 'Tests for IntelliJ Latest EAP' build configuration were updated 2023-12-15 14:16:39 +00:00