Commit Graph

1968 Commits

Author SHA1 Message Date
Sergio Pedri 4d9816e171
Merge pull request #111 from CommunityToolkit/dev/async-command-concurrency-notify
Fix AsyncRelayCommand with allowConcurrentExecutions == false not raising CanExecuteChanged
2022-02-28 23:33:13 +01:00
Sergio Pedri 105e31ac87 Fix some typos 2022-02-28 23:12:26 +01:00
Sergio Pedri d776a1ecda Add unit tests for Execute raising CanExecuteChanged if needed 2022-02-28 22:58:55 +01:00
Sergio Pedri 3c71d4b401 Notify CanExecute when invoking an async command 2022-02-28 22:57:49 +01:00
Sergio Pedri 5dcc52bc4b
Merge pull request #113 from CommunityToolkit/dev/task-await-propagate-unobserved
Propagate task exceptions to TaskScheduler.UnobservedTaskException
2022-02-28 22:56:29 +01:00
Sergio Pedri 2ca1ac7055 Add notes on TaskSchedulerTestHelper logic 2022-02-28 22:39:23 +01:00
Sergio Pedri 55b600b5f4 Add unit tests for UnobservedTaskExceptions propagation 2022-02-28 22:37:26 +01:00
Sergio Pedri 33c58e3eda Remove try/catch when awaiting tasks, ignore exceptions
This allows exceptions to remain unobserved and propagate to TaskScheduler.UnobservedTaskException. It will also be more efficient, as there is no longer an exception being thrown and handled if there's one.
2022-02-28 22:37:26 +01:00
Sergio Pedri 98fc90732a Add __TaskExtensions.GetAwaitableWithoutEndValidation 2022-02-28 22:37:26 +01:00
Sergio Pedri 90cf3443e3
Merge pull request #127 from CommunityToolkit/dev/default-async-command-concurrency-false
Switch async commands to default to no concurrent execution
2022-02-28 21:25:43 +01:00
Sergio Pedri c71eb3592e
Merge pull request #124 from CommunityToolkit/dev/observable-property-inheritdoc
Add <inheritdoc/> to generated observable properties
2022-02-28 21:24:21 +01:00
Sergio Pedri d9c315c3fe
Merge pull request #110 from CommunityToolkit/dev/fix-observable-recipient-attribute-inheritance
Fix [ObservableRecipient] with inherited base attributes
2022-02-28 21:23:38 +01:00
Sergio Pedri 0e26a29a57 Update async commands XML docs 2022-02-27 18:55:12 +01:00
Sergio Pedri f6ca1f0bc4 Switch default async command concurrency to false 2022-02-27 18:53:07 +01:00
Sergio Pedri 4a004a4fab Add <inheritdoc/> to generated observable properties 2022-02-24 23:59:29 +01:00
Sergio Pedri c1cb029bc2 Fix [ObservableRecipient] with inherited base attributes 2022-02-22 20:00:26 +01:00
Sergio Pedri 3d7b45c97a
Merge pull request #121 from CommunityToolkit/dev/fix-build-warnings
Fix analyzer build warnings/errors
2022-02-22 19:58:07 +01:00
Sergio Pedri bc6f26f118 Improve ILLinker analyzer suppression 2022-02-22 19:37:36 +01:00
Sergio Pedri ee30d3129c Add temporary workaround for AD0001 warning 2022-02-22 19:17:02 +01:00
Sergio Pedri 71ad82d274 Workaround for RS2002 warnings
See https://github.com/dotnet/roslyn-analyzers/issues/5828
2022-02-22 13:13:37 +01:00
Sergio Pedri 0813779556
Merge pull request #112 from CommunityToolkit/dev/fix-nbgv-install
Switch NBGV from install to update
2022-02-14 21:43:18 +01:00
Sergio Pedri 8fc359d50d Switch NBGV from install to update
This avoids issues if the tool is already installed
2022-02-14 21:15:03 +01:00
Sergio Pedri 0936b58854
Merge pull request #106 from CommunityToolkit/dev/icommand-attribute-generated-can-execute
Allow using [ICommand(CanExecute)] on generated observable properties
2022-01-31 22:24:55 +01:00
Sergio Pedri b861efc8e8 Add unit tests for CanExecute on generated properties 2022-01-31 19:45:19 +01:00
Sergio Pedri 7e0bf75f8a Add support for [ICommand(CanExecute)] on generated properties 2022-01-31 19:40:35 +01:00
Nirmal Guru ea1010575d
Remove Cake Build (#94)
We no longer require Cake build nor we use it extensively!
Update Azure Pipelines (CI YAML) Script to be more modern and runnable across platforms.
Replaced the headers check with a PowerShell script mimicking the Cake script's `UpdateHeaders` task functionality.
2022-01-25 13:23:53 +01:00
Nirmal Guru c5ab771da4
Fix linter issues with ReadMe (#84)
* Use an emoji for Contributors title

Emoji Used: Champion Cup
Aligns with the rest of the titles

Why Champion Cup you ask? Well, Contributors are champions too! 😎

* Don't use inline HTML in markdown

Always use markdown format if possible.
This format to represent image with a link is supported by most markdown parsers.

* Fix grammatical errors in markdown

These were reported by Spell Checker extension (by EWSoftware) in VS IDE.

* Use canonical language-agnostic URLs

Microsoft Docs provide language-specific content for docs published
to the website but in-order for devs in specific region to get locally
translated content, we need to put language-agnostic canonical URLs.

This is usually done by removing any language and region specific info from URLs.

Reported by Docs markdown linter in VSCode.
2022-01-17 17:26:29 +01:00
Sergio Pedri f2cfa3ad71
Merge pull request #92 from CommunityToolkit/dev/remove-leftover-head-files
Disable generation of header files if no targets are present
2022-01-14 14:34:29 +01:00
Sergio Pedri c38a4a2118 Disable generation of header files if no targets are present 2022-01-14 14:19:48 +01:00
Sergio Pedri eff71685c7
Merge pull request #91 from CommunityToolkit/dev/targets-update
Update .targets for MVVM Toolkit to fix .wapproj issues
2022-01-14 14:02:29 +01:00
Sergio Pedri 9b1596d453 Refactor conditional logic into separate target
This works around <Choose> not supporting <Target> parents
2022-01-14 13:34:22 +01:00
Sergio Pedri 0d894ea7c9 Minor tweaks to MSBuild checks 2022-01-14 13:01:33 +01:00
Sergio Pedri 408c44b4a5 Simplify Roslyn assembly resolution logic 2022-01-14 00:34:53 +01:00
Sergio Pedri 861beea017 Update .targets for MVVM Toolkit to fix .wapproj issues 2022-01-14 00:24:41 +01:00
Sergio Pedri d3d9752364
Merge pull request #90 from CommunityToolkit/version-update
Update base version number to reflect upcoming version
2022-01-13 22:43:12 +01:00
Sergio Pedri 54808964f0
Merge pull request #88 from CommunityToolkit/dev/nuget-reference-updates
Bump NuGet package reference versions
2022-01-13 22:08:28 +01:00
Sergio Pedri bd4f365f01 Bump NuGet package reference versions 2022-01-13 21:53:49 +01:00
Sergio Pedri 2fa3961601
Merge pull request #89 from CommunityToolkit/dev/nullability-attributes-check
Fix conflicting generation of nullability attributes
2022-01-13 21:21:49 +01:00
Sergio Pedri 7d52b58e76 Fix conflicting generation of nullability attributes 2022-01-13 20:30:28 +01:00
Michael Hawker MSFT (XAML Llama) 4702495856
Update to reflect upcoming version 2022-01-13 10:41:27 -08:00
Sergio Pedri af106bf7af
Merge pull request #87 from jmarolf/patch-1
Calculate the current C# compiler version
2022-01-13 18:41:32 +01:00
Sergio Pedri 99cf8cb072 Minor code style tweaks, add more XML comments 2022-01-13 18:17:42 +01:00
Jonathon Marolf 914fc275e7
Calculate the current C# compiler version
This change allows us to calculate the current C# compiler version in a way that will work on all platforms and only relies on the `Microsoft.CSharp.CurrentVersion.targets` target (specifically [this line](https://github.com/dotnet/msbuild/blob/main/src/Tasks/Microsoft.CSharp.CurrentVersion.targets#L315)) being imported. `Microsoft.CSharp.CurrentVersion.targets` is the core msbuild logic for finding the C# compiler and is used universally so this fix should work everywhere there is a C# compiler to be found.
2022-01-12 20:51:59 -08:00
Sergio Pedri 0e150d58f3
Merge pull request #78 from CommunityToolkit/dev/guard-unconstrained-generic
Remove class constraint from Guard.Is[Not]Null APIs
2022-01-04 13:55:47 +01:00
Sergio Pedri c096438a4a Add unit tests for new generic combinations 2022-01-04 13:25:00 +01:00
Sergio Pedri 5d7f2a7674 Remove class constraint from Guaard.Is[Not]Null APIs 2022-01-04 13:24:59 +01:00
Sergio Pedri 87268d40b6
Merge pull request #79 from CommunityToolkit/dev/require-preview-features
Add [RequiresPreviewFeatures] to unsafe APIs
2022-01-04 13:24:25 +01:00
Sergio Pedri f8ca8da76a Add [RequiresPreviewFeatures] to unsafe APIs 2022-01-01 20:11:13 +01:00
Sergio Pedri 6f20b2611c Switch attribute property setters to init-only 2022-01-01 19:53:50 +01:00
Sergio Pedri f81cf4b4f9 Switch to target-type new() for direct return values 2022-01-01 17:02:31 +01:00